Skip to content

chore: add import cycle baseline check for src - #19085

Closed
DrJKL wants to merge 27 commits into
mainfrom
drjkl/depcruise-no-circular
Closed

DrJKL wants to merge 27 commits into
mainfrom
drjkl/depcruise-no-circular

Conversation

@DrJKL

@DrJKL DrJKL commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds a CI gate that fails when a change introduces a new import cycle inside src/. Today 1027 of 2616 src/ modules sit in 9 cycles; the largest has 983 members and spans litegraph, app.ts, api.ts, stores, and components. Members of a cycle cannot be split across TypeScript project references, and this component holds the core most of src/ depends on, so in practice src/ stays one program and tsc -b has nothing to skip. This PR only stops the number from growing; the follow-up slices shrink it.

Tracks FE-2769 / FE-3037.

Changes

  • dependency-cruiser (dev) extracts the import graph of src/ (.dependency-cruiser.ts: tsconfig.json paths, .vue modules, test/story/spec files excluded, node_modules not followed). Its own no-circular rule and --ignore-known baseline are not used: it reports one representative edge per cycle and picks that edge by DFS order, so the baseline drifted by ~500 entries between two runs on the same tree.
  • scripts/check-import-cycles.ts reads the JSON dump, computes strongly connected components (iterative Tarjan), and treats every edge whose endpoints share a component as cyclic. That set is exact and order independent. It diffs against .import-cycles-baseline.json ({ from: [to, ...] }, one module per line, 1027 entries), fails on new cyclic edges with the shortest cycle through the edge, and fails on stale entries so the baseline only shrinks deliberately (same model as eslint-suppressions.json and knip). --update rewrites the file.
  • pnpm lint:cycles / pnpm lint:cycles:update; a step in .github/actions/repo-checks runs the check next to knip and the ADR check.
  • @vue/compiler-sfc added as a root dev dependency. dependency-cruiser loads it with a bare require to parse .vue files; under pnpm strict layout it is otherwise unresolvable, .vue files get parsed as plain TS, and @import-another= template attrs crash the extractor.
  • pnpm lint:cycles listed in AGENTS.md and CONTRIBUTING.md.
  • knip and fallow: .dependency-cruiser.ts registered as an entry; @vue/compiler-sfc and typescript-native-bridge (resolved by path string in scripts/vue-tsc-native.ts, already on main) ignored as runtime-loaded dependencies.

Review Focus

  • Runtime: ~18-23 s on a 16-vCPU orb, almost all in dependency-cruiser's extraction; the SCC pass is under 100 ms. Two consecutive runs produce byte-identical baselines.
  • Negative check: adding import { useDomWidgetStore } from '@/stores/domWidgetStore' to src/composables/functional/useChainCallback.ts fails with exit 1 and prints the shortest cycle through each of the 18 edges it makes cyclic (the first is 3 modules).
  • Unit tests in scripts/check-import-cycles.test.ts cover SCC detection, edge classification (including cross-edges into completed components), order independence, the baseline diff and failure messages, baseline JSON round-trip, and a 50k-node chain (no recursion).
  • Baseline file is formatted to keep diffs one line per module; it is excluded from oxfmt.

Stack

Import-cycle progress for FE-3037, measured with pnpm lint:cycles (dependency-cruiser on src).

Standalone PRs targeting main

Each is one commit on current main and can merge on its own. Numbers are that PR alone against origin/main (1027 cyclic modules, largest cycle 983, 4562 cyclic edges).

PR Base Change Cyclic modules Largest cycle Cyclic edges
#19089 main ServerFeatureFlag enum to a leaf module 1027 -> 884 983 -> 677 4562 -> 3382
#19094 main Empty-workflow dialog out of appModeStore 1027 -> 1026 983 -> 982 4562 -> 4558
#19109 main Mask editor menu item into Comfy.MaskEditor extension 1027 -> 1027 983 -> 983 4562 -> 4562
#19112 main PositionConfig and layer editor dialog key to leaf modules 1027 -> 1027 983 -> 983 4562 -> 4558
#19122 main settingStore off scripts/app; $el to a leaf 1027 -> 1025 983 -> 981 4562 -> 4552
#19124 main MissingNodeType to the nodeReplacement leaf 1027 -> 1027 983 -> 983 4562 -> 4555
#19125 main Blueprint node defs owned by nodeDefStore 1027 -> 1027 983 -> 983 4562 -> 4561
#19127 main Thumbnail and minimap data from explicit inputs 1027 -> 1027 983 -> 983 4562 -> 4561

All eight together on main, plus #19091, #19107, #19108, #19111, #19116 and #19113 (checked locally; those six are not retargeted yet): 630 cyclic modules, largest cycle 412, 2476 cyclic edges.

Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR stack, each PR against its parent at the time, on the older main the stack forked from (967 cyclic modules then). They have not been remeasured since the eight PRs above left the stack. Where the base changed, the parent the numbers were measured on is in parentheses.

#19091, #19107, #19111, #19113 and #19131 still carry the old commits of the PRs they were moved off (#19131 carries #19122, #19124, #19125 and #19127), so their GitHub diffs are wider than one PR until the stack is rebased.

PR Base Change Cyclic modules Largest cycle
#19085 (this PR) main Import-cycle baseline check (pnpm lint:cycles) 967 (baseline) 923 (baseline)
#19088 #19085 Split litegraph interfaces.ts into leaf types 967 -> 949 923 -> 905
#19091 #19088 (measured on #19089) Register core sidebar tabs outside sidebarTabStore 816 -> 669 618 -> 465
#19092 #19091 Load extensions from bootstrap, not extensionService 669 -> 580 465 -> 371
#19093 #19092 Split scripts/widgets.ts registry, types, helpers 580 -> 566 371 -> 357
#19107 #19093 (measured on #19094) Register settings dialog from the app shell 558 -> 509 349 -> 297
#19108 #19107 Register asset browser modal from the app shell 509 -> 496 297 -> 284
#19111 #19108 (measured on #19109) Register core bottom panel tabs from GraphView 484 -> 476 272 -> 264
#19113 #19111 (measured on #19112) Model library asset-browser routing onto the sidebar tab 471 -> 467 257 -> 253
#19116 #19113 Progress text previews out of executionStore 467 -> 464 253 -> 250
#19118 #19116 Inject the api auth provider from main.ts 464 -> 447 250 -> 233
#19121 #19118 Install workspace api credentials from main.ts 447 -> 428 233 -> 214
#19131 #19121 (measured on #19127) Feature dialogs out of dialogService 400 -> 391 181 -> 172
#19143 #19131 Invert scripts/app behind useApp() 391 -> 352 172 -> 149
#19148 #19143 Billing rails announce refreshes; dialogs above the facade 352 -> 324 149 (baseline)
#19153 #19148 types/comfy, comfyWorkflow, dialog/workflow contracts as leaves 324 -> 293 149 (baseline)
#19186 #19153 Workbench cycles: openManager onto useManagerDialog, agent leaves 293 -> 259 149 (baseline)
#19189 #19186 Thirteen small app cycles: ui, nodeDef, auth dialogs, menu, and more 259 -> 211 149 (baseline)

@DrJKL
DrJKL requested a review from a team September 27, 2026 07:51
@github-actions

github-actions Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 2235 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2215 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 17 / ❌ 0 / ⚠️ 1 / ⏭️ 0)

🌐 Website E2E

Tip

All tests passed.

Status ✅ Passed
Report View Report

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/06/2026, 09:35:30 PM UTC

Links

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

No new findings in the changed files.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since bc69ba46e59621dcfa4c5c5aa3c9761419496de6

Full docs: ADR-DEVEX-LINT-0015

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

📦 Bundle: 10.3 MB gzip ⚪ 0 B

Details

Summary

  • Raw size: 43.3 MB baseline 43.3 MB — ⚪ 0 B
  • Gzip: 10.3 MB baseline 10.3 MB — ⚪ 0 B
  • Brotli: 7.29 MB baseline 7.29 MB — ⚪ 0 B
  • Bundles: 485 current • 485 baseline

Category Glance
Other ⚪ 0 B (18.6 MB) · Vendor & Third-Party ⚪ 0 B (17.3 MB) · Data & Services ⚪ 0 B (4.19 MB) · Graph Workspace ⚪ 0 B (1.46 MB) · Panels & Settings ⚪ 0 B (672 kB) · Utilities & Hooks ⚪ 0 B (582 kB) · + 5 more

App Entry Points — 4.17 kB (baseline 4.17 kB) • ⚪ 0 B

Main entry bundles and manifests

Status: 1 unchanged

Graph Workspace — 1.46 MB (baseline 1.46 MB) • ⚪ 0 B

Graph editor runtime, canvas, workflow orchestration

Status: 3 unchanged

Views & Navigation — 143 kB (baseline 143 kB) • ⚪ 0 B

Top-level views, pages, and routed surfaces

Status: 18 unchanged

Panels & Settings — 672 kB (baseline 672 kB) • ⚪ 0 B

Configuration panels, inspectors, and settings screens

Status: 29 unchanged

User & Accounts — 54.4 kB (baseline 54.4 kB) • ⚪ 0 B

Authentication, profile, and account management bundles

Status: 15 unchanged

Editors & Dialogs — 133 kB (baseline 133 kB) • ⚪ 0 B

Modals, dialogs, drawers, and in-app editors

Status: 9 unchanged

UI Components — 205 kB (baseline 205 kB) • ⚪ 0 B

Reusable component library chunks

Status: 20 unchanged

Data & Services — 4.19 MB (baseline 4.19 MB) • ⚪ 0 B

Stores, services, APIs, and repositories

Status: 17 unchanged

Utilities & Hooks — 582 kB (baseline 582 kB) • ⚪ 0 B

Helpers, composables, and utility bundles

Status: 39 unchanged

Vendor & Third-Party — 17.3 MB (baseline 17.3 MB) • ⚪ 0 B

External libraries and shared vendor chunks

Status: 18 unchanged

Other — 18.6 MB (baseline 18.6 MB) • ⚪ 0 B

Bundles that do not match a named category

Status: 316 unchanged

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.5 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.3 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.1 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.1 MB heap
dom-widget-order-dense-n200-w200-i120: · 27.8 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 589ms TBT · 84.7 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 39.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 227ms TBT · 76.7 MB heap
extension-clean-combined-draw: · 29.9 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 1492ms TBT · 69.8 MB heap
extension-rgthree-prototype-draw: · 30.8 avg FPS · 17.1 P5 FPS ❌ (target: ≥52) · 1298ms TBT · 78.4 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.5 MB heap
large-graph-pan: · 59.8 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.8 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.7 MB heap
legacy-node-drag: · 59.5 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.2 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.9 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.8 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.4 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.6 MB heap
subgraph-transition-enter: · 51.5 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 140ms TBT · 101.9 MB heap
viewport-pan-sweep: · 59.9 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.3 MB heap
vue-large-graph-idle: · 30.3 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 174.4 MB heap
vue-large-graph-pan: · 22.1 avg FPS · 10.9 P5 FPS ❌ (target: ≥52) · 27ms TBT · 179.0 MB heap
vue-node-resize-workload: · 25.7 avg FPS · 12.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 212.6 MB heap
vue-zoom-out-idle: · 30.1 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 173.5 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.9 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.7 MB heap
agent-composer-long-conversation-typing: · 53.9 avg FPS · 29.9 P5 FPS ❌ (target: ≥52) · 0ms TBT · 111.9 MB heap

⚠️ 18 regressions detected

Show regressions
Metric Baseline PR (median) Δ Sig
canvas-idle: script duration 8ms 13ms +54% ⚠️ z=2.2
canvas-idle: heap used 61.0 MB 72.5 MB +19% ⚠️ z=2.2
canvas-mouse-sweep: layout duration 5ms 5ms +11% ⚠️ z=2.7
canvas-mouse-sweep: style recalc duration 14ms 18ms +32% ⚠️ z=2.9
canvas-zoom-sweep: script duration 11ms 16ms +40% ⚠️ z=2.6
minimap-idle: style recalc duration 3ms 4ms +48% ⚠️ z=2.6
subgraph-dom-widget-clipping: style recalc duration 5ms 7ms +38% ⚠️ z=2.2
subgraph-idle: script duration 8ms 12ms +53% ⚠️ z=2.1
subgraph-idle: heap used 74.8 MB 74.4 MB -1% ⚠️ z=2.3
subgraph-mouse-sweep: layout duration 6ms 7ms +15% ⚠️ z=3.1
subgraph-mouse-sweep: style recalc duration 15ms 19ms +26% ⚠️ z=2.9
viewport-pan-sweep: avg frame time 17ms 17ms +0% ⚠️ z=2.4
workflow-execution: layout duration 1ms 3ms +82% ⚠️ z=3.5
workflow-execution: style recalc duration 11ms 20ms +89% ⚠️ z=4.0
workflow-execution: style recalc count 8 20 +150% ⚠️ z=3.3
workflow-execution: task duration 88ms 143ms +62% ⚠️ z=2.7
workflow-execution: script duration 8ms 14ms +76% ⚠️ z=2.4
workflow-execution: event listeners 33 81 +145% ⚠️ z=2.8
All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms -0% z=-0.8
canvas-idle: p95 frame time 17ms 17ms +0% z=-1.5
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 3ms 4ms +37% z=1.2
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 10 9 -10% z=-1.1
canvas-idle: task duration 417ms 525ms +26% z=1.7
canvas-idle: script duration 8ms 13ms +54% ⚠️ z=2.2
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 61.0 MB 72.5 MB +19% ⚠️ z=2.2
canvas-idle: DOM nodes 0 0 +0% z=0.4
canvas-idle: event listeners 0 0 +0% z=0.4
canvas-mouse-sweep: avg frame time 17ms 17ms +0% z=0.3
canvas-mouse-sweep: p95 frame time 17ms 17ms +0% z=-0.9
canvas-mouse-sweep: layout duration 5ms 5ms +11% ⚠️ z=2.7
canvas-mouse-sweep: style recalc duration 14ms 18ms +32% ⚠️ z=2.9
canvas-mouse-sweep: layout count 12 12 +0% —
canvas-mouse-sweep: style recalc count 55 76 +38% z=1.4
canvas-mouse-sweep: task duration 741ms 875ms +18% z=1.3
canvas-mouse-sweep: script duration 135ms 175ms +30% z=1.5
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: heap used 75.8 MB 63.3 MB -16% z=-0.5
canvas-mouse-sweep: DOM nodes 0 0 +0% z=0.5
canvas-mouse-sweep: event listeners 0 0 +0% z=0.5
canvas-zoom-sweep: avg frame time 17ms 17ms -0% z=0.0
canvas-zoom-sweep: p95 frame time 17ms 17ms +0% z=0.9
canvas-zoom-sweep: layout duration 1ms 1ms -1% z=0.6
canvas-zoom-sweep: style recalc duration 6ms 7ms +27% z=1.9
canvas-zoom-sweep: layout count 3 3 +0% —
canvas-zoom-sweep: style recalc count 19 19 -3% z=-0.4
canvas-zoom-sweep: task duration 345ms 435ms +26% z=1.9
canvas-zoom-sweep: script duration 11ms 16ms +40% ⚠️ z=2.6
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 75.2 MB 70.1 MB -7% z=0.1
canvas-zoom-sweep: DOM nodes 45 45 +0% variance too high
canvas-zoom-sweep: event listeners 39 39 +0% variance too high
dom-widget-clipping: avg frame time 17ms 17ms +0% z=-0.4
dom-widget-clipping: p95 frame time 17ms 17ms -0% z=-1.3
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 3ms 4ms +27% z=0.5
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 13 14 +4% z=-0.4
dom-widget-clipping: task duration 440ms 469ms +7% z=0.8
dom-widget-clipping: script duration 160ms 168ms +5% z=0.8
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 61.7 MB 60.1 MB -3% z=-1.9
dom-widget-clipping: DOM nodes 0 0 +0% z=0.5
dom-widget-clipping: event listeners 0 0 +0% z=0.4
dom-widget-order-dense-n200-w200-i120: avg frame time 34ms 36ms +7% z=1.2
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms 17ms -0% z=-0.4
dom-widget-order-dense-n200-w200-i120: layout duration 0ms 0ms +0% —
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms 0ms +0% —
dom-widget-order-dense-n200-w200-i120: layout count 0 0 +0% —
dom-widget-order-dense-n200-w200-i120: style recalc count 0 0 +0% —
dom-widget-order-dense-n200-w200-i120: task duration 799ms 919ms +15% z=1.3
dom-widget-order-dense-n200-w200-i120: script duration 59ms 76ms +29% z=1.4
dom-widget-order-dense-n200-w200-i120: TBT 509ms 589ms +16% z=1.2
dom-widget-order-dense-n200-w200-i120: heap used 85.2 MB 84.7 MB -1% z=-1.1
dom-widget-order-dense-n200-w200-i120: DOM nodes 0 0 +0% —
dom-widget-order-dense-n200-w200-i120: event listeners 0 0 +0% —
dom-widget-order-sparse-n1000-w20-i120: avg frame time 25ms 25ms +1% z=0.9
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms 17ms +0% z=0.9
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms 0ms +0% —
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms 0ms +0% —
dom-widget-order-sparse-n1000-w20-i120: layout count 0 0 +0% —
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0 0 +0% —
dom-widget-order-sparse-n1000-w20-i120: task duration 480ms 510ms +6% z=1.1
dom-widget-order-sparse-n1000-w20-i120: script duration 148ms 172ms +16% z=1.0
dom-widget-order-sparse-n1000-w20-i120: TBT 219ms 227ms +4% z=0.8
dom-widget-order-sparse-n1000-w20-i120: heap used 76.7 MB 76.7 MB +0% z=-1.6
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0 0 +0% —
dom-widget-order-sparse-n1000-w20-i120: event listeners 0 0 +0% —
extension-clean-combined-draw: avg frame time 28ms 33ms +20% z=1.0
extension-clean-combined-draw: p95 frame time 50ms 67ms +33% z=1.7
extension-clean-combined-draw: layout duration 0ms 0ms +0% —
extension-clean-combined-draw: style recalc duration 0ms 0ms +1054% variance too high
extension-clean-combined-draw: layout count 0 0 +0% —
extension-clean-combined-draw: style recalc count 1 2 +50% variance too high
extension-clean-combined-draw: task duration 7819ms 9517ms +22% z=1.1
extension-clean-combined-draw: script duration 6355ms 8118ms +28% z=1.2
extension-clean-combined-draw: TBT 109ms 1492ms +1269% variance too high
extension-clean-combined-draw: heap used 67.3 MB 69.8 MB +4% z=-2.3
extension-clean-combined-draw: DOM nodes -141 -141 +0% z=-0.3
extension-clean-combined-draw: event listeners -69 -71 +3% z=-0.7
extension-rgthree-prototype-draw: avg frame time 29ms 33ms +14% z=1.0
extension-rgthree-prototype-draw: p95 frame time 50ms 58ms +17% z=1.4
extension-rgthree-prototype-draw: layout duration 0ms 0ms +0% —
extension-rgthree-prototype-draw: style recalc duration 1ms 0ms -94% variance too high
extension-rgthree-prototype-draw: layout count 0 0 +0% —
extension-rgthree-prototype-draw: style recalc count 2 1 -75% variance too high
extension-rgthree-prototype-draw: task duration 8239ms 9716ms +18% z=1.2
extension-rgthree-prototype-draw: script duration 6696ms 8032ms +20% z=1.2
extension-rgthree-prototype-draw: TBT 149ms 1298ms +771% variance too high
extension-rgthree-prototype-draw: heap used 88.5 MB 78.4 MB -11% z=0.2
extension-rgthree-prototype-draw: DOM nodes -141 -157 +11% z=-1.2
extension-rgthree-prototype-draw: event listeners -73 -77 +5% z=-1.1
large-graph-idle: avg frame time 17ms 17ms -0% z=1.1
large-graph-idle: p95 frame time 17ms 17ms +1% z=1.9
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 3ms 4ms +34% z=1.8
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 9 9 +0% z=-0.6
large-graph-idle: task duration 509ms 614ms +21% z=1.4
large-graph-idle: script duration 33ms 40ms +22% z=1.8
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 82.1 MB 75.5 MB -8% z=-0.6
large-graph-idle: DOM nodes 0 0 +0% z=0.8
large-graph-idle: event listeners 0 0 +0% z=0.8
large-graph-pan: avg frame time 17ms 17ms +0% z=0.7
large-graph-pan: p95 frame time 17ms 17ms -0% z=-0.1
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 7ms 8ms +23% z=0.6
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 69 70 +1% z=0.3
large-graph-pan: task duration 1534ms 1685ms +10% z=1.1
large-graph-pan: script duration 819ms 867ms +6% z=1.0
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: heap used 71.6 MB 82.8 MB +16% z=1.6
large-graph-pan: DOM nodes 0 0 +0% z=0.5
large-graph-pan: event listeners 0 0 +0% z=0.4
large-graph-zoom: avg frame time 17ms 17ms -0% z=-0.9
large-graph-zoom: p95 frame time 17ms 17ms +0% z=0.6
large-graph-zoom: layout duration 18ms 17ms -2% z=0.7
large-graph-zoom: style recalc duration 9ms 9ms -0% z=0.3
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 72 71 -2% z=-0.9
large-graph-zoom: task duration 1658ms 1834ms +11% z=1.2
large-graph-zoom: script duration 786ms 863ms +10% z=1.2
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 79.1 MB 71.7 MB -9% z=-0.9
large-graph-zoom: DOM nodes 24 -140 -683% variance too high
large-graph-zoom: event listeners 0 -72 — —
legacy-node-drag: avg frame time 17ms 17ms +0% z=1.1
legacy-node-drag: p95 frame time 17ms 17ms +0% z=-0.2
legacy-node-drag: layout duration 0ms 0ms +0% —
legacy-node-drag: style recalc duration 6ms 6ms +3% z=-0.1
legacy-node-drag: layout count 0 0 +0% —
legacy-node-drag: style recalc count 46 45 -3% z=-1.9
legacy-node-drag: task duration 1826ms 1997ms +9% z=1.1
legacy-node-drag: script duration 980ms 1028ms +5% z=1.0
legacy-node-drag: TBT 0ms 0ms +0% —
legacy-node-drag: heap used 83.7 MB 76.2 MB -9% z=-0.6
legacy-node-drag: DOM nodes 0 0 +0% —
legacy-node-drag: event listeners 180 180 +0% —
minimap-idle: avg frame time 17ms 17ms -0% z=0.3
minimap-idle: p95 frame time 17ms 17ms -1% z=-1.5
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 3ms 4ms +48% ⚠️ z=2.6
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 8 9 +6% z=-0.3
minimap-idle: task duration 520ms 603ms +16% z=1.4
minimap-idle: script duration 36ms 37ms +4% z=1.3
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 83.7 MB 78.9 MB -6% z=-0.2
minimap-idle: DOM nodes 0 0 +0% z=0.8
minimap-idle: event listeners 0 0 +0% z=0.7
subgraph-dom-widget-clipping: avg frame time 17ms 17ms -0% z=-1.3
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms +0% z=-1.2
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 5ms 7ms +38% ⚠️ z=2.2
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 46 49 +5% z=1.2
subgraph-dom-widget-clipping: task duration 388ms 431ms +11% z=1.1
subgraph-dom-widget-clipping: script duration 141ms 151ms +7% z=1.1
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 58.9 MB 63.8 MB +8% z=0.1
subgraph-dom-widget-clipping: DOM nodes 0 0 +0% z=0.6
subgraph-dom-widget-clipping: event listeners 6 6 +0% z=0.5
subgraph-idle: avg frame time 17ms 17ms +0% z=0.8
subgraph-idle: p95 frame time 17ms 17ms +0% z=0.3
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 3ms 4ms +53% z=1.9
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 10 10 +0% z=-0.5
subgraph-idle: task duration 416ms 527ms +26% z=1.7
subgraph-idle: script duration 8ms 12ms +53% ⚠️ z=2.1
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 74.8 MB 74.4 MB -1% ⚠️ z=2.3
subgraph-idle: DOM nodes 0 0 +0% z=0.6
subgraph-idle: event listeners 0 0 +0% z=0.3
subgraph-mouse-sweep: avg frame time 17ms 17ms +0% z=1.6
subgraph-mouse-sweep: p95 frame time 17ms 17ms +0% z=0.6
subgraph-mouse-sweep: layout duration 6ms 7ms +15% ⚠️ z=3.1
subgraph-mouse-sweep: style recalc duration 15ms 19ms +26% ⚠️ z=2.9
subgraph-mouse-sweep: layout count 16 16 +0% —
subgraph-mouse-sweep: style recalc count 77 78 +1% z=0.8
subgraph-mouse-sweep: task duration 701ms 821ms +17% z=1.2
subgraph-mouse-sweep: script duration 95ms 119ms +25% z=1.8
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 67.2 MB 66.6 MB -1% z=-0.0
subgraph-mouse-sweep: DOM nodes 0 0 +0% z=0.5
subgraph-mouse-sweep: event listeners 0 0 +0% z=0.5
subgraph-transition-enter: avg frame time 19ms 19ms +2% z=0.9
subgraph-transition-enter: p95 frame time 17ms 17ms +0% z=0.4
subgraph-transition-enter: layout duration 13ms 16ms +19% z=1.3
subgraph-transition-enter: style recalc duration 27ms 31ms +15% z=1.4
subgraph-transition-enter: layout count 5 5 +0% —
subgraph-transition-enter: style recalc count 17 17 +0% z=-0.8
subgraph-transition-enter: task duration 918ms 1018ms +11% z=1.1
subgraph-transition-enter: script duration 28ms 34ms +21% z=1.1
subgraph-transition-enter: TBT 114ms 140ms +23% z=1.1
subgraph-transition-enter: heap used 103.5 MB 101.9 MB -2% z=-1.1
subgraph-transition-enter: DOM nodes 14570 14570 +0% —
subgraph-transition-enter: event listeners 2458 2458 +0% —
viewport-pan-sweep: avg frame time 17ms 17ms +0% ⚠️ z=2.4
viewport-pan-sweep: p95 frame time 17ms 17ms -1% z=-1.8
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 21ms 23ms +9% z=0.7
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 251 251 -0% z=0.2
viewport-pan-sweep: task duration 5407ms 6194ms +15% z=1.3
viewport-pan-sweep: script duration 2623ms 3049ms +16% z=1.4
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 67.3 MB 71.3 MB +6% z=-0.1
viewport-pan-sweep: DOM nodes 0 0 +0% z=0.7
viewport-pan-sweep: event listeners 0 0 +0% z=0.7
vue-large-graph-idle: avg frame time 32ms 33ms +2% z=1.0
vue-large-graph-idle: p95 frame time 67ms 67ms +0% z=0.9
vue-large-graph-idle: layout duration 0ms 0ms +0% —
vue-large-graph-idle: style recalc duration 0ms 0ms +0% —
vue-large-graph-idle: layout count 0 0 +0% —
vue-large-graph-idle: style recalc count 0 0 +0% —
vue-large-graph-idle: task duration 17916ms 18481ms +3% z=1.1
vue-large-graph-idle: script duration 287ms 315ms +10% z=1.6
vue-large-graph-idle: TBT 0ms 0ms +0% variance too high
vue-large-graph-idle: heap used 174.1 MB 174.4 MB +0% z=0.1
vue-large-graph-idle: DOM nodes -3046 -3046 +0% z=0.3
vue-large-graph-idle: event listeners -14915 -14915 +0% z=-0.3
vue-large-graph-pan: avg frame time 44ms 45ms +3% z=1.2
vue-large-graph-pan: p95 frame time 83ms 92ms +10% z=1.3
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 18ms 20ms +9% z=1.8
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 180 182 +1% z=0.8
vue-large-graph-pan: task duration 22809ms 24013ms +5% z=1.2
vue-large-graph-pan: script duration 884ms 1003ms +13% z=1.7
vue-large-graph-pan: TBT 29ms 27ms -7% variance too high
vue-large-graph-pan: heap used 179.3 MB 179.0 MB -0% z=-0.8
vue-large-graph-pan: DOM nodes -3046 -3046 +0% z=0.3
vue-large-graph-pan: event listeners -14915 -14915 +0% z=0.3
vue-node-resize-workload: avg frame time 39ms 39ms +1% z=1.1
vue-node-resize-workload: p95 frame time 83ms 83ms -0% z=1.5
vue-node-resize-workload: layout duration 26ms 26ms +1% z=0.9
vue-node-resize-workload: style recalc duration 69ms 76ms +10% z=0.9
vue-node-resize-workload: layout count 20 20 +0% —
vue-node-resize-workload: style recalc count 20 20 +0% —
vue-node-resize-workload: task duration 6756ms 6755ms -0% z=1.1
vue-node-resize-workload: script duration 116ms 120ms +3% z=1.3
vue-node-resize-workload: TBT 0ms 0ms +0% variance too high
vue-node-resize-workload: heap used 214.8 MB 212.6 MB -1% z=1.1
vue-node-resize-workload: DOM nodes 0 0 +0% —
vue-node-resize-workload: event listeners 0 0 +0% —
vue-zoom-out-idle: avg frame time 33ms 33ms +1% z=1.0
vue-zoom-out-idle: p95 frame time 67ms 67ms -0% z=0.8
vue-zoom-out-idle: layout duration 0ms 0ms +0% —
vue-zoom-out-idle: style recalc duration 0ms 0ms +0% —
vue-zoom-out-idle: layout count 0 0 +0% —
vue-zoom-out-idle: style recalc count 0 0 +0% —
vue-zoom-out-idle: task duration 9099ms 9302ms +2% z=1.0
vue-zoom-out-idle: script duration 150ms 151ms +1% z=0.8
vue-zoom-out-idle: TBT 0ms 0ms +0% —
vue-zoom-out-idle: heap used 175.1 MB 173.5 MB -1% z=-1.1
vue-zoom-out-idle: DOM nodes -3046 -3046 +0% z=0.3
vue-zoom-out-idle: event listeners -14915 -14915 +0% z=-0.3
workflow-execution: avg frame time 17ms 17ms -0% z=-0.4
workflow-execution: p95 frame time 17ms 17ms +0% z=-0.4
workflow-execution: layout duration 1ms 3ms +82% ⚠️ z=3.5
workflow-execution: style recalc duration 11ms 20ms +89% ⚠️ z=4.0
workflow-execution: layout count 3 4 +33% z=1.6
workflow-execution: style recalc count 8 20 +150% ⚠️ z=3.3
workflow-execution: task duration 88ms 143ms +62% ⚠️ z=2.7
workflow-execution: script duration 8ms 14ms +76% ⚠️ z=2.4
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 67.0 MB 63.9 MB -5% z=-0.5
workflow-execution: DOM nodes 98 132 +34% z=0.9
workflow-execution: event listeners 33 81 +145% ⚠️ z=2.8
agent-composer-empty-conversation-typing: avg frame time 17ms 17ms -0% z=-0.3
agent-composer-empty-conversation-typing: p95 frame time 17ms 17ms -0% z=0.1
agent-composer-empty-conversation-typing: layout duration 27ms 28ms +6% z=1.4
agent-composer-empty-conversation-typing: style recalc duration 96ms 96ms -0% z=1.4
agent-composer-empty-conversation-typing: layout count 76 76 +0% —
agent-composer-empty-conversation-typing: style recalc count 78 78 +0% —
agent-composer-empty-conversation-typing: task duration 870ms 941ms +8% z=1.2
agent-composer-empty-conversation-typing: script duration 348ms 389ms +12% z=1.2
agent-composer-empty-conversation-typing: TBT 0ms 0ms +0% —
agent-composer-empty-conversation-typing: heap used 82.1 MB 81.7 MB -0% z=0.9
agent-composer-empty-conversation-typing: DOM nodes 76 76 +0% —
agent-composer-empty-conversation-typing: event listeners 876 876 +0% —
agent-composer-long-conversation-typing: avg frame time 19ms 19ms +0% z=1.5
agent-composer-long-conversation-typing: p95 frame time 33ms 33ms +0% z=1.5
agent-composer-long-conversation-typing: layout duration 31ms 32ms +3% z=1.5
agent-composer-long-conversation-typing: style recalc duration 303ms 269ms -11% z=0.8
agent-composer-long-conversation-typing: layout count 76 76 +0% —
agent-composer-long-conversation-typing: style recalc count 78 78 +0% —
agent-composer-long-conversation-typing: task duration 1409ms 1462ms +4% z=0.9
agent-composer-long-conversation-typing: script duration 467ms 490ms +5% z=0.8
agent-composer-long-conversation-typing: TBT 0ms 0ms +0% —
agent-composer-long-conversation-typing: heap used 112.1 MB 111.9 MB -0% z=-0.3
agent-composer-long-conversation-typing: DOM nodes 76 76 +0% —
agent-composer-long-conversation-typing: event listeners 876 876 +0% —
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: p95 frame time 17ms 0ms 0.1%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 3ms 0ms 13.3%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 10 1 11.4%
canvas-idle: task duration 387ms 83ms 21.4%
canvas-idle: script duration 9ms 2ms 19.0%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: heap used 65.6 MB 3.2 MB 4.8%
canvas-idle: DOM nodes -9 25 0.0%
canvas-idle: event listeners -6 16 0.0%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.0%
canvas-mouse-sweep: p95 frame time 17ms 0ms 0.2%
canvas-mouse-sweep: layout duration 4ms 0ms 6.4%
canvas-mouse-sweep: style recalc duration 15ms 1ms 8.1%
canvas-mouse-sweep: layout count 12 0 0.0%
canvas-mouse-sweep: style recalc count 71 4 5.3%
canvas-mouse-sweep: task duration 713ms 130ms 18.2%
canvas-mouse-sweep: script duration 137ms 25ms 18.3%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: heap used 66.3 MB 5.9 MB 9.0%
canvas-mouse-sweep: DOM nodes -24 44 0.0%
canvas-mouse-sweep: event listeners -16 30 0.0%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: p95 frame time 17ms 0ms 0.1%
canvas-zoom-sweep: layout duration 1ms 0ms 7.9%
canvas-zoom-sweep: style recalc duration 6ms 1ms 11.0%
canvas-zoom-sweep: layout count 3 0 0.0%
canvas-zoom-sweep: style recalc count 19 0 2.0%
canvas-zoom-sweep: task duration 315ms 64ms 20.4%
canvas-zoom-sweep: script duration 11ms 2ms 16.2%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: heap used 69.8 MB 4.4 MB 6.3%
canvas-zoom-sweep: DOM nodes 36 25 68.9%
canvas-zoom-sweep: event listeners 33 17 52.7%
dom-widget-clipping: avg frame time 17ms 0ms 0.0%
dom-widget-clipping: p95 frame time 17ms 0ms 0.2%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 4ms 0ms 12.2%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 14 1 9.0%
dom-widget-clipping: task duration 404ms 76ms 18.9%
dom-widget-clipping: script duration 147ms 28ms 19.0%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: heap used 65.7 MB 3.0 MB 4.6%
dom-widget-clipping: DOM nodes -14 29 0.0%
dom-widget-clipping: event listeners -6 17 0.0%
dom-widget-order-dense-n200-w200-i120: avg frame time 32ms 4ms 11.6%
dom-widget-order-dense-n200-w200-i120: p95 frame time 18ms 2ms 11.0%
dom-widget-order-dense-n200-w200-i120: layout duration 0ms 0ms 0.0%
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms 0ms 0.0%
dom-widget-order-dense-n200-w200-i120: layout count 0 0 0.0%
dom-widget-order-dense-n200-w200-i120: style recalc count 0 0 0.0%
dom-widget-order-dense-n200-w200-i120: task duration 714ms 159ms 22.3%
dom-widget-order-dense-n200-w200-i120: script duration 57ms 13ms 22.9%
dom-widget-order-dense-n200-w200-i120: TBT 445ms 120ms 27.0%
dom-widget-order-dense-n200-w200-i120: heap used 87.7 MB 2.8 MB 3.1%
dom-widget-order-dense-n200-w200-i120: DOM nodes 0 0 0.0%
dom-widget-order-dense-n200-w200-i120: event listeners 0 0 0.0%
dom-widget-order-sparse-n1000-w20-i120: avg frame time 24ms 2ms 8.4%
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms 0ms 0.2%
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms 0ms 0.0%
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms 0ms 0.0%
dom-widget-order-sparse-n1000-w20-i120: layout count 0 0 0.0%
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0 0 0.0%
dom-widget-order-sparse-n1000-w20-i120: task duration 410ms 93ms 22.6%
dom-widget-order-sparse-n1000-w20-i120: script duration 139ms 31ms 22.6%
dom-widget-order-sparse-n1000-w20-i120: TBT 177ms 60ms 33.7%
dom-widget-order-sparse-n1000-w20-i120: heap used 82.5 MB 3.7 MB 4.4%
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0 0 0.0%
dom-widget-order-sparse-n1000-w20-i120: event listeners 0 0 0.0%
extension-clean-combined-draw: avg frame time 28ms 5ms 19.8%
extension-clean-combined-draw: p95 frame time 47ms 12ms 25.7%
extension-clean-combined-draw: layout duration 0ms 0ms 0.0%
extension-clean-combined-draw: style recalc duration 1ms 0ms 73.0%
extension-clean-combined-draw: layout count 0 0 0.0%
extension-clean-combined-draw: style recalc count 2 2 67.7%
extension-clean-combined-draw: task duration 7550ms 1822ms 24.1%
extension-clean-combined-draw: script duration 6202ms 1626ms 26.2%
extension-clean-combined-draw: TBT 517ms 520ms 100.5%
extension-clean-combined-draw: heap used 79.4 MB 4.2 MB 5.2%
extension-clean-combined-draw: DOM nodes -136 17 0.0%
extension-clean-combined-draw: event listeners -65 8 0.0%
extension-rgthree-prototype-draw: avg frame time 27ms 5ms 19.7%
extension-rgthree-prototype-draw: p95 frame time 44ms 10ms 23.1%
extension-rgthree-prototype-draw: layout duration 0ms 0ms 0.0%
extension-rgthree-prototype-draw: style recalc duration 1ms 0ms 59.6%
extension-rgthree-prototype-draw: layout count 0 0 0.0%
extension-rgthree-prototype-draw: style recalc count 2 2 61.9%
extension-rgthree-prototype-draw: task duration 7493ms 1820ms 24.3%
extension-rgthree-prototype-draw: script duration 6099ms 1577ms 25.9%
extension-rgthree-prototype-draw: TBT 456ms 442ms 97.0%
extension-rgthree-prototype-draw: heap used 77.7 MB 4.4 MB 5.7%
extension-rgthree-prototype-draw: DOM nodes -132 20 0.0%
extension-rgthree-prototype-draw: event listeners -66 10 0.0%
large-graph-idle: avg frame time 17ms 0ms 0.0%
large-graph-idle: p95 frame time 17ms 0ms 0.2%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 3ms 0ms 12.2%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 9 1 8.3%
large-graph-idle: task duration 476ms 101ms 21.1%
large-graph-idle: script duration 32ms 4ms 13.7%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: heap used 78.0 MB 3.9 MB 5.1%
large-graph-idle: DOM nodes -55 66 0.0%
large-graph-idle: event listeners -26 32 0.0%
large-graph-pan: avg frame time 17ms 0ms 0.3%
large-graph-pan: p95 frame time 17ms 0ms 0.2%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 7ms 1ms 11.0%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 69 1 1.1%
large-graph-pan: task duration 1425ms 238ms 16.7%
large-graph-pan: script duration 748ms 123ms 16.5%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: heap used 76.2 MB 4.0 MB 5.3%
large-graph-pan: DOM nodes -21 43 0.0%
large-graph-pan: event listeners -7 17 0.0%
large-graph-zoom: avg frame time 17ms 0ms 0.0%
large-graph-zoom: p95 frame time 17ms 0ms 0.1%
large-graph-zoom: layout duration 17ms 1ms 6.6%
large-graph-zoom: style recalc duration 9ms 1ms 11.1%
large-graph-zoom: layout count 60 0 0.0%
large-graph-zoom: style recalc count 72 1 1.7%
large-graph-zoom: task duration 1513ms 260ms 17.2%
large-graph-zoom: script duration 710ms 125ms 17.5%
large-graph-zoom: TBT 0ms 0ms 0.0%
large-graph-zoom: heap used 76.6 MB 5.4 MB 7.1%
large-graph-zoom: DOM nodes 10 36 350.3%
large-graph-zoom: event listeners 0 0 0.0%
legacy-node-drag: avg frame time 17ms 0ms 0.3%
legacy-node-drag: p95 frame time 17ms 0ms 0.1%
legacy-node-drag: layout duration 0ms 0ms 0.0%
legacy-node-drag: style recalc duration 6ms 1ms 9.3%
legacy-node-drag: layout count 0 0 0.0%
legacy-node-drag: style recalc count 46 1 2.1%
legacy-node-drag: task duration 1691ms 279ms 16.5%
legacy-node-drag: script duration 882ms 144ms 16.3%
legacy-node-drag: TBT 0ms 0ms 0.0%
legacy-node-drag: heap used 79.2 MB 4.8 MB 6.1%
legacy-node-drag: DOM nodes 0 0 0.0%
legacy-node-drag: event listeners 180 0 0.0%
minimap-idle: avg frame time 17ms 0ms 0.0%
minimap-idle: p95 frame time 17ms 0ms 0.1%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 3ms 0ms 12.5%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 9 1 9.9%
minimap-idle: task duration 467ms 96ms 20.5%
minimap-idle: script duration 32ms 4ms 12.2%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: heap used 79.4 MB 3.1 MB 3.9%
minimap-idle: DOM nodes -42 53 0.0%
minimap-idle: event listeners -17 24 0.0%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: p95 frame time 17ms 0ms 0.2%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 6ms 1ms 9.7%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 47 1 1.9%
subgraph-dom-widget-clipping: task duration 361ms 61ms 17.0%
subgraph-dom-widget-clipping: script duration 127ms 22ms 17.3%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: heap used 63.5 MB 2.0 MB 3.2%
subgraph-dom-widget-clipping: DOM nodes -20 35 0.0%
subgraph-dom-widget-clipping: event listeners -6 25 0.0%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: p95 frame time 17ms 0ms 0.1%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 3ms 1ms 15.7%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 10 1 7.9%
subgraph-idle: task duration 392ms 81ms 20.8%
subgraph-idle: script duration 8ms 2ms 21.6%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: heap used 68.9 MB 2.4 MB 3.5%
subgraph-idle: DOM nodes -21 36 0.0%
subgraph-idle: event listeners -4 17 0.0%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: p95 frame time 17ms 0ms 0.1%
subgraph-mouse-sweep: layout duration 6ms 0ms 7.3%
subgraph-mouse-sweep: style recalc duration 16ms 1ms 8.1%
subgraph-mouse-sweep: layout count 16 0 0.0%
subgraph-mouse-sweep: style recalc count 75 3 4.6%
subgraph-mouse-sweep: task duration 676ms 117ms 17.4%
subgraph-mouse-sweep: script duration 98ms 12ms 12.2%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: heap used 66.7 MB 3.1 MB 4.6%
subgraph-mouse-sweep: DOM nodes -35 69 0.0%
subgraph-mouse-sweep: event listeners -13 27 0.0%
subgraph-transition-enter: avg frame time 19ms 0ms 2.1%
subgraph-transition-enter: p95 frame time 17ms 0ms 0.2%
subgraph-transition-enter: layout duration 12ms 3ms 21.5%
subgraph-transition-enter: style recalc duration 24ms 4ms 18.5%
subgraph-transition-enter: layout count 5 0 0.0%
subgraph-transition-enter: style recalc count 18 1 5.7%
subgraph-transition-enter: task duration 830ms 175ms 21.1%
subgraph-transition-enter: script duration 27ms 6ms 22.0%
subgraph-transition-enter: TBT 102ms 35ms 34.5%
subgraph-transition-enter: heap used 103.5 MB 1.4 MB 1.4%
subgraph-transition-enter: DOM nodes 14570 0 0.0%
subgraph-transition-enter: event listeners 2458 0 0.0%
viewport-pan-sweep: avg frame time 17ms 0ms 0.1%
viewport-pan-sweep: p95 frame time 17ms 0ms 0.2%
viewport-pan-sweep: layout duration 0ms 0ms 0.0%
viewport-pan-sweep: style recalc duration 21ms 2ms 9.4%
viewport-pan-sweep: layout count 0 0 0.0%
viewport-pan-sweep: style recalc count 250 0 0.2%
viewport-pan-sweep: task duration 5078ms 864ms 17.0%
viewport-pan-sweep: script duration 2483ms 400ms 16.1%
viewport-pan-sweep: TBT 0ms 0ms 0.0%
viewport-pan-sweep: heap used 72.0 MB 4.9 MB 6.7%
viewport-pan-sweep: DOM nodes -62 93 0.0%
viewport-pan-sweep: event listeners -30 45 0.0%
vue-large-graph-idle: avg frame time 28ms 5ms 15.9%
vue-large-graph-idle: p95 frame time 54ms 14ms 25.5%
vue-large-graph-idle: layout duration 0ms 0ms 0.0%
vue-large-graph-idle: style recalc duration 0ms 0ms 0.0%
vue-large-graph-idle: layout count 0 0 0.0%
vue-large-graph-idle: style recalc count 0 0 0.0%
vue-large-graph-idle: task duration 15717ms 2536ms 16.1%
vue-large-graph-idle: script duration 249ms 42ms 16.9%
vue-large-graph-idle: TBT 0ms 1ms 269.9%
vue-large-graph-idle: heap used 174.1 MB 1.7 MB 1.0%
vue-large-graph-idle: DOM nodes -3048 5 0.0%
vue-large-graph-idle: event listeners -14915 1 0.0%
vue-large-graph-pan: avg frame time 37ms 7ms 18.8%
vue-large-graph-pan: p95 frame time 73ms 15ms 19.9%
vue-large-graph-pan: layout duration 0ms 0ms 0.0%
vue-large-graph-pan: style recalc duration 13ms 3ms 25.5%
vue-large-graph-pan: layout count 0 0 0.0%
vue-large-graph-pan: style recalc count 144 46 32.1%
vue-large-graph-pan: task duration 19614ms 3639ms 18.6%
vue-large-graph-pan: script duration 790ms 128ms 16.2%
vue-large-graph-pan: TBT 12ms 10ms 81.9%
vue-large-graph-pan: heap used 180.4 MB 1.6 MB 0.9%
vue-large-graph-pan: DOM nodes -3161 429 0.0%
vue-large-graph-pan: event listeners -14915 0 0.0%
vue-node-resize-workload: avg frame time 34ms 5ms 14.2%
vue-node-resize-workload: p95 frame time 66ms 11ms 16.9%
vue-node-resize-workload: layout duration 24ms 2ms 8.8%
vue-node-resize-workload: style recalc duration 65ms 12ms 18.8%
vue-node-resize-workload: layout count 20 0 0.0%
vue-node-resize-workload: style recalc count 20 0 0.0%
vue-node-resize-workload: task duration 5765ms 893ms 15.5%
vue-node-resize-workload: script duration 98ms 17ms 17.8%
vue-node-resize-workload: TBT 0ms 1ms 387.3%
vue-node-resize-workload: heap used 208.8 MB 3.4 MB 1.6%
vue-node-resize-workload: DOM nodes 0 0 0.0%
vue-node-resize-workload: event listeners 0 0 0.0%
vue-zoom-out-idle: avg frame time 28ms 5ms 16.6%
vue-zoom-out-idle: p95 frame time 56ms 13ms 24.1%
vue-zoom-out-idle: layout duration 0ms 0ms 0.0%
vue-zoom-out-idle: style recalc duration 0ms 0ms 0.0%
vue-zoom-out-idle: layout count 0 0 0.0%
vue-zoom-out-idle: style recalc count 0 0 0.0%
vue-zoom-out-idle: task duration 7890ms 1406ms 17.8%
vue-zoom-out-idle: script duration 128ms 27ms 21.4%
vue-zoom-out-idle: TBT 0ms 0ms 0.0%
vue-zoom-out-idle: heap used 175.4 MB 1.7 MB 1.0%
vue-zoom-out-idle: DOM nodes -3161 429 0.0%
vue-zoom-out-idle: event listeners -14915 1 0.0%
workflow-execution: avg frame time 17ms 0ms 1.6%
workflow-execution: p95 frame time 17ms 2ms 11.1%
workflow-execution: layout duration 1ms 0ms 23.1%
workflow-execution: style recalc duration 12ms 2ms 17.1%
workflow-execution: layout count 3 1 16.4%
workflow-execution: style recalc count 11 3 22.9%
workflow-execution: task duration 90ms 20ms 22.4%
workflow-execution: script duration 9ms 2ms 24.8%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: heap used 65.3 MB 2.6 MB 4.0%
workflow-execution: DOM nodes 106 28 26.5%
workflow-execution: event listeners 44 13 29.7%
agent-composer-empty-conversation-typing: avg frame time 17ms 0ms 0.5%
agent-composer-empty-conversation-typing: p95 frame time 17ms 0ms 0.2%
agent-composer-empty-conversation-typing: layout duration 23ms 4ms 15.4%
agent-composer-empty-conversation-typing: style recalc duration 80ms 11ms 14.4%
agent-composer-empty-conversation-typing: layout count 76 0 0.0%
agent-composer-empty-conversation-typing: style recalc count 78 0 0.0%
agent-composer-empty-conversation-typing: task duration 653ms 233ms 35.6%
agent-composer-empty-conversation-typing: script duration 258ms 109ms 42.3%
agent-composer-empty-conversation-typing: TBT 0ms 0ms 0.0%
agent-composer-empty-conversation-typing: heap used 76.8 MB 5.4 MB 7.1%
agent-composer-empty-conversation-typing: DOM nodes 76 0 0.0%
agent-composer-empty-conversation-typing: event listeners 876 0 0.0%
agent-composer-long-conversation-typing: avg frame time 17ms 1ms 4.3%
agent-composer-long-conversation-typing: p95 frame time 23ms 7ms 29.9%
agent-composer-long-conversation-typing: layout duration 28ms 3ms 9.5%
agent-composer-long-conversation-typing: style recalc duration 245ms 31ms 12.7%
agent-composer-long-conversation-typing: layout count 76 0 0.0%
agent-composer-long-conversation-typing: style recalc count 78 0 0.0%
agent-composer-long-conversation-typing: task duration 1192ms 295ms 24.8%
agent-composer-long-conversation-typing: script duration 382ms 131ms 34.3%
agent-composer-long-conversation-typing: TBT 0ms 0ms 0.0%
agent-composer-long-conversation-typing: heap used 112.9 MB 3.7 MB 3.3%
agent-composer-long-conversation-typing: DOM nodes 76 0 0.0%
agent-composer-long-conversation-typing: event listeners 876 0 0.0%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▆▁▃▃▃▆▁██▁▃▆▆▁▆ ➡️ 17ms
canvas-idle: p95 frame time ▅█▄▄█▄▄█▅▁▅▁█▅▁ ➡️ 17ms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration ▇▆▇▄▅▁▅▁██▄▂▆▃▂ ➡️ 3ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count ▅▃▂▃▁█▃▁▄▇▄██▆▃ ➡️ 10
canvas-idle: task duration █▅▇▅▆▁▅▅▆▆▄▁▃▂▄ 📉 378ms
canvas-idle: script duration █▅▇▄▄▁▃▂▆▇▅▁▄▃▄ ➡️ 9ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used ▃▆█▁▄▁▆▁▆▂▄▂▃▂▂ ➡️ 62.9 MB
canvas-idle: DOM nodes ███████▁█▁█████ ➡️ 0
canvas-idle: event listeners ███████▁█▁█████ ➡️ 0
canvas-mouse-sweep: avg frame time █▂▇▄▄▄▇▂▄▁▅▁▄▅▄ ➡️ 17ms
canvas-mouse-sweep: p95 frame time █▁█▁██▁▁▄▅▁▁█▄▁ ➡️ 17ms
canvas-mouse-sweep: layout duration █▅▆▄▄▁▄▂▃▁▃▃▄▄▅ ➡️ 5ms
canvas-mouse-sweep: style recalc duration █▅▇▄▅▁▃▁▅▃▄▃▄▅▄ ➡️ 15ms
canvas-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 12
canvas-mouse-sweep: style recalc count █▇▅▇▇▆▄▄▇▆▆▇▇▆▁ ➡️ 61
canvas-mouse-sweep: task duration █▆▇▆▆▁▆▅▆▄▄▂▂▃▆ 📉 760ms
canvas-mouse-sweep: script duration ▇▇█▆▇▁▇▆▇▃▄▂▂▃▅ 📉 135ms
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: heap used ▁▁▆▆▄▂▄▆▃▆▅█▃▄▆ ➡️ 70.7 MB
canvas-mouse-sweep: DOM nodes ██▄████████▁▄█▄ 📈 -71
canvas-mouse-sweep: event listeners ██▅████████▁▅█▅ 📈 -49
canvas-zoom-sweep: avg frame time ▃▅▄▃▄▃▃▃▃▄█▂▁▄▅ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ▁▁▄▅▁███▄▄▁▅▁▄▅ ➡️ 17ms
canvas-zoom-sweep: layout duration █▄█▁▄▃▃▂▃▂▄▃▄▄▅ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▆▃█▃▅▂▃▁▅▄▃▃▂▄▃ ➡️ 6ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 3
canvas-zoom-sweep: style recalc count ▆▁████▃█▆▃▃▆▆▁█ ➡️ 19
canvas-zoom-sweep: task duration █▅▇▅▆▁▅▅▆▄▃▂▁▂▅ 📉 341ms
canvas-zoom-sweep: script duration ▇▃█▂▅▁▃▁▆▅▄▃▂▃▄ ➡️ 11ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used ▅▆█▆█▅▆▅█▇▁▅▄▄█ ➡️ 75.0 MB
canvas-zoom-sweep: DOM nodes █████▁██████▁██ ➡️ 45
canvas-zoom-sweep: event listeners █████▁██████▁██ ➡️ 39
dom-widget-clipping: avg frame time ▃▅▂▁▁▁▄█▁▄▃▆█▁▄ ➡️ 17ms
dom-widget-clipping: p95 frame time ▁▆▁▃▃▁▆▆██▆▁▆▃▃ ➡️ 17ms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▇▃▄▄▆▅▁▃▄▆▆▂▇█▁ ➡️ 3ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▅▂▃▄▃▆▁▄▄▅▆▃▆█▃ ➡️ 13
dom-widget-clipping: task duration █▆▆▆▆▁▆▆▆▄▄▁▂▂▆ 📉 440ms
dom-widget-clipping: script duration █▇█▆▇▁▇▇▇▅▄▁▂▂▆ 📉 160ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ▄▄▁▄▄▅▆▄▆▃▄▄█▃▃ ➡️ 63.7 MB
dom-widget-clipping: DOM nodes █▁█▁▁██████████ 📉 0
dom-widget-clipping: event listeners ███▁▁██████████ 📉 0
dom-widget-order-dense-n200-w200-i120: avg frame time █▇█▇▇▁▇▆█▄▄▂▂▁▇ ➡️ 34ms
dom-widget-order-dense-n200-w200-i120: p95 frame time ▁▁▁▁▁▁█▁▁▁▁█▁▁▁ ➡️ 17ms
dom-widget-order-dense-n200-w200-i120: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-order-dense-n200-w200-i120: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-order-dense-n200-w200-i120: style recalc count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-order-dense-n200-w200-i120: task duration █▆█▆▇▁▆▆▇▄▄▂▂▂▆ 📉 804ms
dom-widget-order-dense-n200-w200-i120: script duration ▇▇█▇▇▁▇▇█▅▃▂▂▂▆ 📉 59ms
dom-widget-order-dense-n200-w200-i120: TBT █▇█▇▇▁▆▆█▄▄▂▂▁▆ 📉 509ms
dom-widget-order-dense-n200-w200-i120: heap used ▆▁▄▁▃█▄▆▆█▆▅▇▇▃ ➡️ 84.9 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-order-dense-n200-w200-i120: event listeners ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-order-sparse-n1000-w20-i120: avg frame time ▇▇█▇█▁▇▇█▄▅▁▁▁▇ ➡️ 25ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time ▃▆██▆█▆▆▆▆██▆▁█ ➡️ 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-order-sparse-n1000-w20-i120: task duration ▇▇█▇▇▁▆▇▇▄▅▂▂▁▇ 📉 479ms
dom-widget-order-sparse-n1000-w20-i120: script duration ▅▇█▆▇▁▇▇▇▃▄▂▁▁▅ 📉 148ms
dom-widget-order-sparse-n1000-w20-i120: TBT ▆▇███▁▇▇█▄▅▁▁▁▇ 📉 219ms
dom-widget-order-sparse-n1000-w20-i120: heap used ▆█▄▅▁▅▂▆▆▂██▁▄▄ ➡️ 80.9 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-order-sparse-n1000-w20-i120: event listeners ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
extension-clean-combined-draw: avg frame time ▇█▇█▇▁███▄▄▂▂▁▅ 📉 28ms
extension-clean-combined-draw: p95 frame time ▅▇▆▅▆▁▆▆█▁▁▁▁▁▅ 📉 50ms
extension-clean-combined-draw: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
extension-clean-combined-draw: style recalc duration ▂▃▁▃▄▇▄▃▃▆▄▇█▇▂ 📈 0ms
extension-clean-combined-draw: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
extension-clean-combined-draw: style recalc count ▂▃▁▃▄█▃▃▃▆▄▇█▇▂ 📈 1
extension-clean-combined-draw: task duration ▇██▆▇▁▇▇█▃▃▂▂▁▅ 📉 7790ms
extension-clean-combined-draw: script duration ▆█▇▆▇▁▆▇█▃▃▁▂▁▅ 📉 6416ms
extension-clean-combined-draw: TBT ▃▆▆▄▅▁▅▅█▁▁▁▁▁▂ 📉 133ms
extension-clean-combined-draw: heap used █▄▅▆▃▅▅▇▇▆▅▆▆▂▁ ➡️ 70.3 MB
extension-clean-combined-draw: DOM nodes ▂▂▂▂▂▂▂▁▂▂█▁▂▂█ ➡️ -94
extension-clean-combined-draw: event listeners ▄▂▂▂▂▂▂▂▃▂█▁▂▄█ ➡️ -47
extension-rgthree-prototype-draw: avg frame time ▇████▁███▄▄▂▂▂▆ 📉 28ms
extension-rgthree-prototype-draw: p95 frame time ▇▇█▇▇▁█▇█▂▂▂▂▂▇ 📉 50ms
extension-rgthree-prototype-draw: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
extension-rgthree-prototype-draw: style recalc duration ▂▄▂▃▁█▂▃▂▄▇▇██▃ 📈 0ms
extension-rgthree-prototype-draw: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
extension-rgthree-prototype-draw: style recalc count ▂▃▂▃▁█▂▃▂▃▆▆▇█▃ 📈 2
extension-rgthree-prototype-draw: task duration ▇▇█▆▇▁█▇█▄▃▂▂▂▆ 📉 8060ms
extension-rgthree-prototype-draw: script duration ▆▇█▆▇▁█▇█▄▃▂▂▂▆ 📉 6551ms
extension-rgthree-prototype-draw: TBT ▄▇█▄▆▁▇▅█▁▁▁▁▁▂ 📉 130ms
extension-rgthree-prototype-draw: heap used ▇▄▂▂▃▂▂▇▁▄▃▅▄█▇ ➡️ 83.7 MB
extension-rgthree-prototype-draw: DOM nodes ▂▂▂▂▃██▂▂█▂▂▁▁▂ ➡️ -141
extension-rgthree-prototype-draw: event listeners ▂▂▂▁▄█▇▂▁▆▂▂▁▁▁ 📈 -73
large-graph-idle: avg frame time █▇▅▅█▆▅█▄▁▅▄▅▅█ ➡️ 17ms
large-graph-idle: p95 frame time ▃▆▁▆▃▆▃▁▁▆▃▆▃█▁ ➡️ 17ms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▆▆▆▅▅▁▇▄█▅▄▃▅▅▄ ➡️ 3ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count ▂▁▁▄▂▇▅▅▆▂▇▄▇█▄ ➡️ 9
large-graph-idle: task duration █▆▇▅▆▁▅▅▇▄▃▂▂▃▅ 📉 510ms
large-graph-idle: script duration █▇█▅▅▁▅▄▇▆▄▃▄▄▅ ➡️ 33ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used ▄▁▅▆▆▂▂▅▃▅█▅▄▅▅ ➡️ 78.9 MB
large-graph-idle: DOM nodes █▅▅█▅▅███▅█▁▅██ ➡️ 0
large-graph-idle: event listeners █▅▅█▅▅███▅█▁▅██ ➡️ 0
large-graph-pan: avg frame time ▇▃█▁▁▁▁▁█▁▁▁▁▁▄ ➡️ 17ms
large-graph-pan: p95 frame time ▆▃▃▁▃▆▆▆██▃▁▃█▆ ➡️ 17ms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration ▂▄▅▃▂▄▃▁▄▅▃█▆▆▂ ➡️ 7ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count ▂▇▅▇▁▆▆█▇█▄█▇█▄ ➡️ 69
large-graph-pan: task duration █▇▇▆▇▁▆▆▇▄▄▃▂▃▆ 📉 1515ms
large-graph-pan: script duration █▇█▇▇▁▇▇█▅▄▃▂▂▆ 📉 797ms
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: heap used ▁▇█▂▁▃▅▂▂█▄▂▆▇▃ ➡️ 74.3 MB
large-graph-pan: DOM nodes ▁███████████▁█▁ 📈 -103
large-graph-pan: event listeners ████████████▁█▁ ➡️ -49
large-graph-zoom: avg frame time █▆▅▇█▄▄▂▃▂▅▂▁▃▆ ➡️ 17ms
large-graph-zoom: p95 frame time ▅█▅█▅▅█▅▅▁█▅▁▅▁ ➡️ 17ms
large-graph-zoom: layout duration █▂▇▂▄▄▂▁▄▅▃█▅█▇ ➡️ 18ms
large-graph-zoom: style recalc duration ▇▁▇▄▅▄▁▁▄▇▅█▆█▆ 📈 9ms
large-graph-zoom: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 60
large-graph-zoom: style recalc count ▄▁▅▆▅▆▂▄▄██▇▆▆▅ ➡️ 72
large-graph-zoom: task duration █▆▇▆▆▁▆▅▆▄▄▂▁▃▆ 📉 1661ms
large-graph-zoom: script duration █▆█▇▇▁▆▆▇▄▄▃▁▂▇ 📉 785ms
large-graph-zoom: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-zoom: heap used ▄▁▅█▅▂▄▃▄▆▆▇▃▃▆ ➡️ 79.7 MB
large-graph-zoom: DOM nodes █▁████▁████████ 📉 24
large-graph-zoom: event listeners ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
legacy-node-drag: avg frame time ▆█▇█▆▁▆▆▆▇▇▁▁▁▆ ➡️ 17ms
legacy-node-drag: p95 frame time ▆▆▆▆▆▆▃▆█▆▃▁▃▆▃ ➡️ 17ms
legacy-node-drag: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
legacy-node-drag: style recalc duration ▃▃▅▁▁▃▃▁▄▅▁█▇▆▃ 📈 6ms
legacy-node-drag: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
legacy-node-drag: style recalc count ▂▅▃▄▁▅▄▅▄▇▃█▆▅▄ ➡️ 46
legacy-node-drag: task duration █▆▇▆▇▁▆▆▇▅▄▃▂▃▆ 📉 1836ms
legacy-node-drag: script duration █▇█▆▇▁▇▇▇▅▄▃▂▂▇ 📉 982ms
legacy-node-drag: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
legacy-node-drag: heap used █▁▂▁▂▃▃▅▄▁▃▃▄▅▆ ➡️ 84.9 MB
legacy-node-drag: DOM nodes ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
legacy-node-drag: event listeners ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 180
minimap-idle: avg frame time ▃▇▅▄▁▅▅▅▅▂▅▃▇▃█ ➡️ 17ms
minimap-idle: p95 frame time ▅▁█▅▁▅▅▅▅▅█▅▅▁█ ➡️ 17ms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▆▇█▆█▃▇▁▇▅▄▄▅▇▃ ➡️ 3ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count ▃▃▃▃▃▄▃▂▁▄▃▇█▆▃ ➡️ 8
minimap-idle: task duration █▆▇▅▅▁▆▅▇▅▄▂▂▂▆ 📉 522ms
minimap-idle: script duration █▅▇▄▆▁▄▂▇▅▅▃▄▃▆ ➡️ 35ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used ▅▁▅▄▃▄▄▅█▂▆▇▄▇▆ ➡️ 82.1 MB
minimap-idle: DOM nodes ███▂█▁▂▁█▂████▂ 📉 -103
minimap-idle: event listeners ███▁█▁▁██▁████▁ 📉 -49
subgraph-dom-widget-clipping: avg frame time ▅▂▅▅▄▅▁▃▂▂█▄▂▃▄ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time ▆▃█▃▃▁▁▆▃▁▆▃▃▃▁ ➡️ 17ms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration █▅▆▃▃▃▁▂▅▅▃▅▆▄▂ ➡️ 5ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count ▆▇▅▅▃▅▁▆▆▇▇██▅▃ ➡️ 46
subgraph-dom-widget-clipping: task duration █▆▇▅▆▁▅▆▆▃▃▂▁▂▆ 📉 392ms
subgraph-dom-widget-clipping: script duration █▇█▆▇▁▇▇▇▄▄▂▂▂▇ 📉 142ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used ▁▄▄▅▅▄▆▅▄█▆▄▅▅▅ ➡️ 63.4 MB
subgraph-dom-widget-clipping: DOM nodes ███▁█▁████▁██▁█ ➡️ 0
subgraph-dom-widget-clipping: event listeners ███▂█▁███████▁█ 📉 6
subgraph-idle: avg frame time ▃▃▆▃▃▁▆▁▃██▁▁▆▃ ➡️ 17ms
subgraph-idle: p95 frame time █▄▄▄▄█▁▄█▄██▄█▄ ➡️ 17ms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration ▆█▆▆█▁▄▁█▄▄▅▅▅▃ ➡️ 3ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count ▅▆▃▆▅█▃▃▁▅▅▇▇▆▄ ➡️ 10
subgraph-idle: task duration █▆▇▅▆▁▅▅▇▄▄▂▃▃▅ 📉 420ms
subgraph-idle: script duration █▅▆▃▄▁▃▃▇▅▄▄▅▄▄ ➡️ 8ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used ▅▇▇▄▅▇██▅▂▅▁▄█▇ ➡️ 71.0 MB
subgraph-idle: DOM nodes ████████▁▂▂▂███ ➡️ 0
subgraph-idle: event listeners ███████████▁███ ➡️ 0
subgraph-mouse-sweep: avg frame time ▆█▆▆▅▄▅▄▄▁▆▃▇▅▄ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time ██▅▅▅█▅▅▅▅▅▁▁█▁ ➡️ 17ms
subgraph-mouse-sweep: layout duration ▇▃█▃▁▁▅▂▅▂▃▆▃▂▄ ➡️ 6ms
subgraph-mouse-sweep: style recalc duration █▄█▃▃▁▃▃▄▅▄▅▅▄▃ ➡️ 15ms
subgraph-mouse-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 16
subgraph-mouse-sweep: style recalc count █▄▇▇▇▆▁█▇▇▇▇▆▇▇ ➡️ 77
subgraph-mouse-sweep: task duration █▆▇▅▅▁▅▅▆▄▄▂▂▃▅ 📉 702ms
subgraph-mouse-sweep: script duration ▇▆█▅▆▁▆▅▇▄▄▃▃▃▅ 📉 95ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ▅▄▅▅▅▂▇▃▅▅▆█▁▄▆ ➡️ 69.0 MB
subgraph-mouse-sweep: DOM nodes █▆█▃██████▆▁███ 📈 0
subgraph-mouse-sweep: event listeners █▁████████▁▁███ 📈 0
subgraph-transition-enter: avg frame time ▅█▆▅▇▂▃▇▆▄▁▁▁▁▃ ➡️ 19ms
subgraph-transition-enter: p95 frame time ▁████████████▁█ ➡️ 17ms
subgraph-transition-enter: layout duration ▅▇█▇█▁▆▇▇▄▄▂▂▂▆ 📉 13ms
subgraph-transition-enter: style recalc duration ▅▇█▇█▁▇▆▇▄▄▂▂▂▆ 📉 27ms
subgraph-transition-enter: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 5
subgraph-transition-enter: style recalc count ▆▁▆▆▃▆▆▁▃█▆███▃ ➡️ 17
subgraph-transition-enter: task duration ▇▆█▆█▁▆▆▇▄▅▂▂▂▆ 📉 918ms
subgraph-transition-enter: script duration ▇▆█▆█▁▅▅▇▄▅▃▂▃▅ 📉 28ms
subgraph-transition-enter: TBT ▆▇▇▇█▁▆▆▇▃▄▂▂▂▆ 📉 114ms
subgraph-transition-enter: heap used ▃█▁▃▃▇▃██▂▄▄▆▆▅ ➡️ 103.5 MB
subgraph-transition-enter: DOM nodes ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 14570
subgraph-transition-enter: event listeners ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 2458
viewport-pan-sweep: avg frame time ▇██▁▄▁▄▁▄▁█▁▁▁▁ ➡️ 17ms
viewport-pan-sweep: p95 frame time █▆▃▃▆▃▁▆▆▆▆▁█▃▆ ➡️ 17ms
viewport-pan-sweep: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
viewport-pan-sweep: style recalc duration ▅▃▅▃▄▅▃▁▄▅▅█▇▇▅ ➡️ 21ms
viewport-pan-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
viewport-pan-sweep: style recalc count ▅█▁▆▆▁▆▆▅▆▆▆▁▅▆ ➡️ 251
viewport-pan-sweep: task duration █▆▇▆▇▁▆▆▇▄▄▂▂▂▆ 📉 5418ms
viewport-pan-sweep: script duration █▇█▇█▁▇▆▇▄▄▂▁▁▆ 📉 2636ms
viewport-pan-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
viewport-pan-sweep: heap used ▂▅▆▄█▅▃▄▇▅█▇▃▁▅ ➡️ 72.5 MB
viewport-pan-sweep: DOM nodes ▆████▆███▃█▆▆▁█ 📈 0
viewport-pan-sweep: event listeners ▆████▆███▃█▆▆▁█ 📈 0
vue-large-graph-idle: avg frame time ▇██▇█▁▇▆█▆▅▂▂▂█ 📉 32ms
vue-large-graph-idle: p95 frame time ▆████▁█▅█▅▅▂▁▁█ 📉 67ms
vue-large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-large-graph-idle: style recalc duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-large-graph-idle: style recalc count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-large-graph-idle: task duration ▆██▇█▁▇▆█▅▅▂▂▃█ 📉 18046ms
vue-large-graph-idle: script duration ▇▇█▇▇▁▇▅▇▆▄▃▂▃▇ 📉 286ms
vue-large-graph-idle: TBT ▆▁▁▁▁▁▁▁▁▁▁▁▁█▁ 📈 0ms
vue-large-graph-idle: heap used ▄▅▄▅▅█▄▆▅▅▁▅▆▅▂ ➡️ 171.3 MB
vue-large-graph-idle: DOM nodes █▇██████████▁▇█ ➡️ -3046
vue-large-graph-idle: event listeners ▂▁▁▁▁▁▁▁▁▁▁█▁▁▁ ➡️ -14915
vue-large-graph-pan: avg frame time ▆▇█▆█▁▇▇█▄▃▁▁▂█ 📉 44ms
vue-large-graph-pan: p95 frame time ▇▇▇▇▇▁▇▇▇▄▃▂▁▂█ 📉 89ms
vue-large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-large-graph-pan: style recalc duration ▆▆█▅▆▁▆▅▇▄▃▂▁▂█ 📉 18ms
vue-large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-large-graph-pan: style recalc count ▆████▁███▅▄▂▁▂█ 📉 180
vue-large-graph-pan: task duration ▅▇█▇█▁▇▇█▄▃▂▁▂█ 📉 22929ms
vue-large-graph-pan: script duration ▇▇█▆▇▁▇▇▇▄▄▂▂▂▇ 📉 904ms
vue-large-graph-pan: TBT ▇▃█▅▃▃▄▇▂▄▄▁▁▁▇ 📉 24ms
vue-large-graph-pan: heap used ▁▁▂▁▄▄▁▁▂▆▁▅▅█▂ ➡️ 179.5 MB
vue-large-graph-pan: DOM nodes ████████▁██████ ➡️ -3046
vue-large-graph-pan: event listeners ▁█▇▇▇▇▇▇▂▇▇▇▇▇▇ ➡️ -14915
vue-node-resize-workload: avg frame time ▆▅█▆▇▁▆▆▆▅▅▂▂▃▇ ➡️ 39ms
vue-node-resize-workload: p95 frame time ▆▃█▆█▁▅▅▆▅▅▂▁▁▇ 📉 78ms
vue-node-resize-workload: layout duration █▂▆▂▃▁▃▂▄▄▂▂▁▂▅ ➡️ 26ms
vue-node-resize-workload: style recalc duration ▇▇█▇▇▁▇▇█▄▄▂▁▂▆ 📉 69ms
vue-node-resize-workload: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 20
vue-node-resize-workload: style recalc count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 20
vue-node-resize-workload: task duration ▆▆█▅█▁▇▆▇▅▅▂▁▂█ ➡️ 6701ms
vue-node-resize-workload: script duration ▆▆█▅▇▁▆▅▇▅▅▂▁▂▇ 📉 115ms
vue-node-resize-workload: TBT ▁▁▁▁▁▁▁▁▁▁▁█▁▁▁ 📈 0ms
vue-node-resize-workload: heap used ▆▃█▅▆▃▅▄▁▅▅▄▅▂▆ ➡️ 211.9 MB
vue-node-resize-workload: DOM nodes ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-node-resize-workload: event listeners ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-zoom-out-idle: avg frame time ▇████▁▇▅█▆▅▂▂▃█ 📉 32ms
vue-zoom-out-idle: p95 frame time █████▁█▄█▅▅▃▃▅█ 📉 67ms
vue-zoom-out-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-zoom-out-idle: style recalc duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-zoom-out-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-zoom-out-idle: style recalc count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-zoom-out-idle: task duration ▇██▇█▁▇▅█▆▅▃▃▃█ 📉 9098ms
vue-zoom-out-idle: script duration █▆▇▇▇▁▆▄▆▅▅▃▂▃▇ 📉 148ms
vue-zoom-out-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-zoom-out-idle: heap used ▁▂▃▁▂█▃▂▂▆▃▂▅▃▂ ➡️ 174.8 MB
vue-zoom-out-idle: DOM nodes ███████████▁███ ➡️ -3046
vue-zoom-out-idle: event listeners ▁▁▂▁▁▁▁▁▁▁▁▁█▁▁ ➡️ -14915
workflow-execution: avg frame time ▁▁▁▇█▁▁▁▁▁▁▁▁▁▁ ➡️ 17ms
workflow-execution: p95 frame time ▁▁▁██▁▁▁▁▁▁▁▁▁▁ ➡️ 17ms
workflow-execution: layout duration █▇▄█▄▄▆▃▇▅▅▁▅▂▄ 📉 1ms
workflow-execution: style recalc duration ▆▆▅▇▅▁▄▄█▃▅▃▃▃▃ ➡️ 11ms
workflow-execution: layout count ▅█▄▇▅▄▄▂▇▂▇▁▇▁▄ ➡️ 3
workflow-execution: style recalc count ▄▄▆█▅▁▃▄▇▄▇▃▄▃▃ ➡️ 10
workflow-execution: task duration ▇▆▆█▆▁▄▅█▃▅▂▃▂▅ 📉 90ms
workflow-execution: script duration ▅▅▅█▅▁▄▃▇▃▄▂▄▂▃ 📉 8ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used ▇█▆▆█▂▅▄▅▁▆▁█▆▄ ➡️ 64.2 MB
workflow-execution: DOM nodes ▇▇▇█▇▇▇▆▁▇▇▆█▇▁ 📉 35
workflow-execution: event listeners ▅▄██▆▁▁▄▇▃▅▄▄▄▄ ➡️ 38
agent-composer-empty-conversation-typing: avg frame time █▁▁▁▁▁▁▁▁▁▁▁▁▁▁ ➡️ 17ms
agent-composer-empty-conversation-typing: p95 frame time ▃▃▃▆▃▃▆▁▃▃█▆▃▃█ ➡️ 17ms
agent-composer-empty-conversation-typing: layout duration █▅▅▄▅▂▄▃▅▄▃▄▁▂▅ 📉 26ms
agent-composer-empty-conversation-typing: style recalc duration █▅▆▄▆▂▅▅▅▄▃▃▁▂▇ 📉 97ms
agent-composer-empty-conversation-typing: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 76
agent-composer-empty-conversation-typing: style recalc count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 78
agent-composer-empty-conversation-typing: task duration █▅▅▄▅▁▄▄▅▃▂▂▁▁▅ 📉 850ms
agent-composer-empty-conversation-typing: script duration █▅▅▅▅▁▅▄▅▃▂▁▁▁▅ 📉 341ms
agent-composer-empty-conversation-typing: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
agent-composer-empty-conversation-typing: heap used ▇▁▅▂▆▃▃▂▃▂▂▃█▂▃ ➡️ 76.0 MB
agent-composer-empty-conversation-typing: DOM nodes ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 76
agent-composer-empty-conversation-typing: event listeners ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 876
agent-composer-long-conversation-typing: avg frame time █▃▅▃▅▁▄▃▄▂▂▁▁▁▆ ➡️ 19ms
agent-composer-long-conversation-typing: p95 frame time █▃█▁▆▁▆▃▆▁▁▁▁▁█ 📉 33ms
agent-composer-long-conversation-typing: layout duration █▆▇▆▆▄▆▅▆▅▄▇▁▃█ ➡️ 31ms
agent-composer-long-conversation-typing: style recalc duration ▇▅▆▅▆▄▅▆▆▅▄▆▁▂█ ➡️ 295ms
agent-composer-long-conversation-typing: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 76
agent-composer-long-conversation-typing: style recalc count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 78
agent-composer-long-conversation-typing: task duration █▇▇▇▇▂▇▇▇▅▅▃▁▂▇ 📉 1421ms
agent-composer-long-conversation-typing: script duration ███▇█▂█▇▇▅▅▃▁▁▇ 📉 464ms
agent-composer-long-conversation-typing: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
agent-composer-long-conversation-typing: heap used ▅▄▂▄█▆▄▅▅▄▃▄▆▁▃ ➡️ 110.1 MB
agent-composer-long-conversation-typing: DOM nodes ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 76
agent-composer-long-conversation-typing: event listeners ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 876
Raw data
{
  "timestamp": "2026-10-06T21:48:27.045Z",
  "gitSha": "91f6ca39cdc13e77c1f7e92661f18fd3b3992166",
  "branch": "drjkl/depcruise-no-circular",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2018.6989999999696,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 3.6969999999999987,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 548.1780000000001,
      "heapDeltaBytes": 7485108,
      "heapUsedBytes": 75748472,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 13.849,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2022.0469999999295,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 4.215,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 501.86300000000006,
      "heapDeltaBytes": 7322764,
      "heapUsedBytes": 76263596,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 11.640000000000004,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198346,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1857.3750000000473,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 18.823,
      "layouts": 12,
      "layoutDurationMs": 5.126,
      "taskDurationMs": 884.984,
      "heapDeltaBytes": 3049388,
      "heapUsedBytes": 70935080,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 176.33100000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665765765765762,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1826.724000000013,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 17.915,
      "layouts": 12,
      "layoutDurationMs": 5.335,
      "taskDurationMs": 865.786,
      "heapDeltaBytes": -246812,
      "heapUsedBytes": 61894776,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 173.398,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666363636363638,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1739.8719999999912,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 7.7540000000000004,
      "layouts": 3,
      "layoutDurationMs": 1.0219999999999998,
      "taskDurationMs": 451.689,
      "heapDeltaBytes": 5952588,
      "heapUsedBytes": 68733516,
      "domNodes": 45,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 17.073,
      "eventListeners": 39,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666346153846156,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1698.3170000000882,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 6.776999999999998,
      "layouts": 3,
      "layoutDurationMs": 0.8370000000000001,
      "taskDurationMs": 419.2309999999999,
      "heapDeltaBytes": 9702600,
      "heapUsedBytes": 78331508,
      "domNodes": 45,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 14.735000000000005,
      "eventListeners": 39,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6656862745098,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 667.00000000003,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 3.906999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 477.24899999999997,
      "heapDeltaBytes": -5583396,
      "heapUsedBytes": 62790952,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 169.317,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.664102564102556,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 615.319999999997,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 3.5329999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 460.132,
      "heapDeltaBytes": -5614316,
      "heapUsedBytes": 63156868,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 167.262,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.667567567567563,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1256.510999999989,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 932.2189999999999,
      "heapDeltaBytes": 17596288,
      "heapUsedBytes": 89036772,
      "domNodes": 0,
      "jsHeapTotalBytes": 5931008,
      "scriptDurationMs": 84.49500000000002,
      "eventListeners": 0,
      "totalBlockingTimeMs": 613,
      "frameDurationMs": 36.76176470588234,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1201.3490000000502,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 905.2410000000001,
      "heapDeltaBytes": 17587180,
      "heapUsedBytes": 88504332,
      "domNodes": 0,
      "jsHeapTotalBytes": 3571712,
      "scriptDurationMs": 67.571,
      "eventListeners": 0,
      "totalBlockingTimeMs": 564,
      "frameDurationMs": 35.291176470588226,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 861.3489999999615,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 500.66500000000013,
      "heapDeltaBytes": -7679804,
      "heapUsedBytes": 80472708,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 172.29,
      "eventListeners": 0,
      "totalBlockingTimeMs": 228,
      "frameDurationMs": 25.485294117647058,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 875.0730000000431,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 519.8000000000005,
      "heapDeltaBytes": -7720444,
      "heapUsedBytes": 80456772,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 171.443,
      "eventListeners": 0,
      "totalBlockingTimeMs": 226,
      "frameDurationMs": 25.237142857142835,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 10445.394999999962,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 0.730999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9456.8,
      "heapDeltaBytes": -5338212,
      "heapUsedBytes": 74160312,
      "domNodes": -141,
      "jsHeapTotalBytes": -5640192,
      "scriptDurationMs": 8033.3,
      "eventListeners": -73,
      "totalBlockingTimeMs": 1502,
      "frameDurationMs": 33.983387622149834,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 10579.945999999949,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.07700000000000068,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9577.760000000002,
      "heapDeltaBytes": -13940252,
      "heapUsedBytes": 72206620,
      "domNodes": -141,
      "jsHeapTotalBytes": -7475200,
      "scriptDurationMs": 8203.686999999998,
      "eventListeners": -69,
      "totalBlockingTimeMs": 1482,
      "frameDurationMs": 32.81459627329192,
      "p95FrameDurationMs": 66.69999999999891
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 11122.308000000032,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10249.424,
      "heapDeltaBytes": -3603276,
      "heapUsedBytes": 82919252,
      "domNodes": -172,
      "jsHeapTotalBytes": -1183744,
      "scriptDurationMs": 8542.797,
      "eventListeners": -81,
      "totalBlockingTimeMs": 1743,
      "frameDurationMs": 33.38198198198199,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 10041.026999999985,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.060000000000001025,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9183.079,
      "heapDeltaBytes": 2443916,
      "heapUsedBytes": 81565576,
      "domNodes": -141,
      "jsHeapTotalBytes": -9572352,
      "scriptDurationMs": 7521.409000000001,
      "eventListeners": -73,
      "totalBlockingTimeMs": 853,
      "frameDurationMs": 31.649526813880126,
      "p95FrameDurationMs": 50.100000000000364
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2021.9809999999825,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 3.651,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 614.815,
      "heapDeltaBytes": -5013964,
      "heapUsedBytes": 72507132,
      "domNodes": 0,
      "jsHeapTotalBytes": -225280,
      "scriptDurationMs": 39.757999999999996,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2023.6580000000686,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 4.428,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 613.0709999999999,
      "heapDeltaBytes": -3322008,
      "heapUsedBytes": 85905608,
      "domNodes": 0,
      "jsHeapTotalBytes": 36864,
      "scriptDurationMs": 40.407,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2461.5530000000376,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 8.208,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1701.6750000000002,
      "heapDeltaBytes": 16876892,
      "heapUsedBytes": 93379476,
      "domNodes": 0,
      "jsHeapTotalBytes": 487424,
      "scriptDurationMs": 876.969,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665986394557827,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2366.0750000000235,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 7.832999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1668.7599999999998,
      "heapDeltaBytes": -9204084,
      "heapUsedBytes": 80224884,
      "domNodes": 0,
      "jsHeapTotalBytes": 786432,
      "scriptDurationMs": 857.9480000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.78439716312057,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3840.154000000041,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 10.063,
      "layouts": 60,
      "layoutDurationMs": 18.352,
      "taskDurationMs": 1883.562,
      "heapDeltaBytes": 10231056,
      "heapUsedBytes": 79627872,
      "domNodes": 24,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 892.247,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666086956521735,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3662.8630000000157,
      "styleRecalcs": 70,
      "styleRecalcDurationMs": 7.852000000000001,
      "layouts": 60,
      "layoutDurationMs": 16.616,
      "taskDurationMs": 1783.7200000000003,
      "heapDeltaBytes": 6127556,
      "heapUsedBytes": 70805772,
      "domNodes": -304,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 833.342,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665753424657535,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3186.3099999999918,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 6.493999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2045.607,
      "heapDeltaBytes": 736764,
      "heapUsedBytes": 70524772,
      "domNodes": 0,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 1061.315,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.84232804232804,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3078.723000000082,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 4.992999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1947.5059999999996,
      "heapDeltaBytes": 23725988,
      "heapUsedBytes": 89225752,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 995.241,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.756830601092897,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2013.1020000000035,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 3.940000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 599.386,
      "heapDeltaBytes": -4922308,
      "heapUsedBytes": 76692144,
      "domNodes": 0,
      "jsHeapTotalBytes": 36864,
      "scriptDurationMs": 36.732,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2023.9460000000236,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 4.2269999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 607.0310000000001,
      "heapDeltaBytes": 19583208,
      "heapUsedBytes": 88727632,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 37.936,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 641.1600000000135,
      "styleRecalcs": 49,
      "styleRecalcDurationMs": 7.302000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 441.934,
      "heapDeltaBytes": -10045560,
      "heapUsedBytes": 59858312,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 152.032,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665789473684214,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 597.6350000000821,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 6.758,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 419.92799999999994,
      "heapDeltaBytes": 12664080,
      "heapUsedBytes": 73873256,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 149.544,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663888888888877,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2017.803000000015,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 4.109,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 551.946,
      "heapDeltaBytes": 7963896,
      "heapUsedBytes": 78827028,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 12.705000000000007,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.2770000000446,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 4.874,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 501.07500000000005,
      "heapDeltaBytes": 7682312,
      "heapUsedBytes": 77191720,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 11.582000000000003,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1722.6310000000353,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 19.712,
      "layouts": 16,
      "layoutDurationMs": 7.175000000000001,
      "taskDurationMs": 835.4739999999999,
      "heapDeltaBytes": -284156,
      "heapUsedBytes": 70091812,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 122.01400000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66699029126214,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1710.5589999999893,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 18.958999999999996,
      "layouts": 16,
      "layoutDurationMs": 7.137000000000001,
      "taskDurationMs": 806.726,
      "heapDeltaBytes": -429064,
      "heapUsedBytes": 69528380,
      "domNodes": 0,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 116.874,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66601941747573,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1402.5229999999738,
      "styleRecalcs": 17,
      "styleRecalcDurationMs": 30.515,
      "layouts": 5,
      "layoutDurationMs": 15.834000000000001,
      "taskDurationMs": 1018.234,
      "heapDeltaBytes": 32312288,
      "heapUsedBytes": 106838512,
      "domNodes": 14570,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 33.756,
      "eventListeners": 2458,
      "totalBlockingTimeMs": 140,
      "frameDurationMs": 19.4054794520548,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8994.31999999996,
      "styleRecalcs": 251,
      "styleRecalcDurationMs": 23.199,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5996.244000000001,
      "heapDeltaBytes": -18975400,
      "heapUsedBytes": 70184732,
      "domNodes": 0,
      "jsHeapTotalBytes": 823296,
      "scriptDurationMs": 2913.846,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.696840148698882,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9708.744000000024,
      "styleRecalcs": 250,
      "styleRecalcDurationMs": 22.497,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6392.504000000001,
      "heapDeltaBytes": -10281032,
      "heapUsedBytes": 79397992,
      "domNodes": 0,
      "jsHeapTotalBytes": 823296,
      "scriptDurationMs": 3184.461,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.694836488812392,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 19251.74800000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18761.441000000003,
      "heapDeltaBytes": -31635916,
      "heapUsedBytes": 183001776,
      "domNodes": -3046,
      "jsHeapTotalBytes": 6836224,
      "scriptDurationMs": 338.71399999999994,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 33.332062391681106,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18809.69300000004,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18200.912000000004,
      "heapDeltaBytes": -35778556,
      "heapUsedBytes": 182636952,
      "domNodes": -3046,
      "jsHeapTotalBytes": 7622656,
      "scriptDurationMs": 291.507,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 32.66649305555555,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 24530.41300000001,
      "styleRecalcs": 182,
      "styleRecalcDurationMs": 19.703,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 24162.685,
      "heapDeltaBytes": -37185168,
      "heapUsedBytes": 187592692,
      "domNodes": -3046,
      "jsHeapTotalBytes": 1417216,
      "scriptDurationMs": 963.204,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 4,
      "frameDurationMs": 46.11353383458646,
      "p95FrameDurationMs": 99.90000000000146
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 24200.874,
      "styleRecalcs": 181,
      "styleRecalcDurationMs": 19.713000000000008,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 23863.855,
      "heapDeltaBytes": -32585624,
      "heapUsedBytes": 187832956,
      "domNodes": -3046,
      "jsHeapTotalBytes": 1941504,
      "scriptDurationMs": 1043.142,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 50,
      "frameDurationMs": 44.40183486238533,
      "p95FrameDurationMs": 83.40000000000146
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 7030.115999999964,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 77.871,
      "layouts": 20,
      "layoutDurationMs": 27.550000000000004,
      "taskDurationMs": 6901.001000000001,
      "heapDeltaBytes": 761568,
      "heapUsedBytes": 220489492,
      "domNodes": 0,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 125.98100000000001,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 40.18857142857142,
      "p95FrameDurationMs": 83.39999999999964
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6728.636999999935,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 74.14700000000002,
      "layouts": 20,
      "layoutDurationMs": 24.61400000000001,
      "taskDurationMs": 6609.226000000001,
      "heapDeltaBytes": 999784,
      "heapUsedBytes": 225288400,
      "domNodes": 0,
      "jsHeapTotalBytes": 1048576,
      "scriptDurationMs": 113.704,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 37.615083798882694,
      "p95FrameDurationMs": 83.29999999999927
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9797.948000000019,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9550.217999999999,
      "heapDeltaBytes": -28367984,
      "heapUsedBytes": 182430892,
      "domNodes": -3046,
      "jsHeapTotalBytes": 6430720,
      "scriptDurationMs": 157.18199999999993,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 33.61821305841925,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9429.933000000005,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9054.266,
      "heapDeltaBytes": -31708120,
      "heapUsedBytes": 181354440,
      "domNodes": -3046,
      "jsHeapTotalBytes": 4100096,
      "scriptDurationMs": 144.54600000000002,
      "eventListeners": -14915,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 32.75347222222222,
      "p95FrameDurationMs": 66.59999999999854
    },
    {
      "name": "workflow-execution",
      "durationMs": 487.76299999997264,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 22.799000000000003,
      "layouts": 4,
      "layoutDurationMs": 3.2670000000000003,
      "taskDurationMs": 146.724,
      "heapDeltaBytes": 6254164,
      "heapUsedBytes": 72983280,
      "domNodes": 133,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 12.703,
      "eventListeners": 81,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665517241379316,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 487.13999999995394,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 17.517000000000003,
      "layouts": 4,
      "layoutDurationMs": 2.129,
      "taskDurationMs": 140.274,
      "heapDeltaBytes": 6296656,
      "heapUsedBytes": 60972412,
      "domNodes": 130,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 16.256,
      "eventListeners": 81,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 867.1150000000125,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 92.568,
      "layouts": 76,
      "layoutDurationMs": 26.303,
      "taskDurationMs": 839.54,
      "heapDeltaBytes": -8133600,
      "heapUsedBytes": 78786120,
      "domNodes": 76,
      "jsHeapTotalBytes": 2097152,
      "scriptDurationMs": 338.529,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665384615384603,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 1076.3480000000527,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 98.673,
      "layouts": 76,
      "layoutDurationMs": 30.023999999999997,
      "taskDurationMs": 1041.8960000000002,
      "heapDeltaBytes": 19858364,
      "heapUsedBytes": 92512120,
      "domNodes": 76,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 439.99399999999997,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66562499999999,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1476.495,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 272.19100000000003,
      "layouts": 76,
      "layoutDurationMs": 32.044000000000004,
      "taskDurationMs": 1460.807,
      "heapDeltaBytes": 10338288,
      "heapUsedBytes": 115968756,
      "domNodes": 76,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 486.375,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.54124999999999,
      "p95FrameDurationMs": 33.399999999999636
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1480.5169999999634,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 265.498,
      "layouts": 76,
      "layoutDurationMs": 31.126,
      "taskDurationMs": 1462.8670000000002,
      "heapDeltaBytes": 10577384,
      "heapUsedBytes": 118669460,
      "domNodes": 76,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 493.095,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.542499999999997,
      "p95FrameDurationMs": 33.399999999999636
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 54437 84137 64.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 66.8% 1167
src/LGraphNode.ts 70.6% 387
src/platform/workspace/stores/billingOperationStore.ts 7.8% 366
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/core/billing/operationLifecycle.ts 1.3% 303
src/LGraph.ts 79.0% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 39.3% 258
src/scripts/app.ts 73.0% 255
src/core/webSessionIdentity.ts 3.3% 231
src/scripts/pnginfo.ts 20.7% 222

@socket-security

socket-security Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​dependency-cruiser@​18.4.09910010097100

View full report

@coderabbitai

coderabbitai Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 6f8364e3-f9ef-4b19-9f94-e5fc61f7fc40

📥 Commits

Reviewing files that changed from the base of the PR and between 218206b and 7bd1e8b.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • .import-cycles-baseline.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review. Your free on-demand review promotion remains active until October 9, 2026 at 6:00 PM UTC.


📝 Walkthrough

Walkthrough

The change adds dependency-cruiser configuration and a source import-cycle check. The check builds a graph, compares cyclic edges with a stored baseline, and runs through repository checks.

Changes

Import Cycle Check

Layer / File(s) Summary
Configure dependency analysis
.dependency-cruiser.ts, .fallowrc.jsonc, knip.config.ts, package.json, pnpm-workspace.yaml
Adds dependency-cruiser settings, registers the configuration with repository analysis tools, and declares required packages and workspace versions.
Build and validate the cycle graph
scripts/check-import-cycles.ts, scripts/check-import-cycles.test.ts
Filters dependency-cruiser output to src, finds strongly connected components and cyclic edges, compares baseline edges, and locates cycle paths. Tests cover graph behavior, baseline differences, and graph conversion.
Run the baseline check
scripts/check-import-cycles.ts, .import-cycles-baseline.json, package.json, .github/actions/repo-checks/action.yml, .oxfmtrc.json
Adds command behavior to update or check the baseline, package scripts and a repository-check step to run it, and a formatter exclusion for the baseline file.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Other

Sequence Diagram(s)

sequenceDiagram
  participant RepoChecks as Repository checks
  participant Pnpm
  participant CycleCheck as check-import-cycles
  participant Depcruise as dependency-cruiser
  participant Baseline as Import-cycle baseline
  RepoChecks->>Pnpm: Run lint:cycles
  Pnpm->>CycleCheck: Start the cycle check
  CycleCheck->>Depcruise: Collect dependency graph
  Depcruise-->>CycleCheck: Return dependency graph JSON
  CycleCheck->>Baseline: Read stored cyclic edges
  CycleCheck->>CycleCheck: Compare current and stored edges
Loading

Suggested reviewers: austinmroz

Merge Risk: ⚪ Minimal · up to 7bd1e

The import-cycle baseline matches the current source graph, and no issue remains that would prevent merging after normal checks.

🚥 Pre-merge checks | ✅ 7
✅ Passed checks (7 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
End-To-End Regression Coverage For Fixes ✅ Passed PASS. Although several commit subjects use fix language, the PR changes no files under src/ or packages/; its changes are tooling, configuration, CI, scripts, and a baseline file. The explicit f…
Website End-To-End Regression Coverage ✅ Passed No changed files are under apps/website/src/ or apps/website/public/. The pull request changes tooling, configuration, scripts, and a baseline file only, so this website-specific check does not ap…
Adr Compliance For Entity/Litegraph Changes ✅ Passed The changed-file list contains no files under src/lib/litegraph/ or src/ecs/, and it does not modify graph-entity files for nodes, links, widgets, slots, reroutes, groups, or subgraphs. This check…
Title check ✅ Passed The title clearly summarizes the main change: adding an import-cycle baseline check for src.
Description check ✅ Passed The description explains the problem, design, changes, and verification details. It does not include a dedicated Verification section, but the Review Focus section documents runtime, negative-check, a…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@            Coverage Diff             @@
##             main   #19085      +/-   ##
==========================================
- Coverage   85.48%   85.47%   -0.01%     
==========================================
  Files        3528     3528              
  Lines      169353   169353              
  Branches    46383    45640     -743     
==========================================
- Hits       144769   144760       -9     
- Misses      22590    22599       +9     
  Partials     1994     1994              
Flag Coverage Δ
billing-web-unit 92.23% <ø> (ø)
e2e 64.70% <ø> (-0.04%) ⬇️
unit 83.60% <ø> (ø)
website-unit 80.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Sep 27, 2026
@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 27, 2026
This was referenced Sep 27, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a manual request Oct 7, 2026
@christian-byrne
christian-byrne deleted the drjkl/depcruise-no-circular branch October 7, 2026 09:23

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 7 finding(s).

Severity Count
🟡 Medium 4
🟢 Low 2
⚪ Nit 1

Panel: 8/8 reviewers contributed findings.


function cruiseSource(): Graph {
const output = execFileSync(
'pnpm',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — execFileSync('pnpm', ...) spawns without a shell, but on Windows pnpm is installed as a pnpm.cmd shim (Corepack/npm), and since the CVE-2024-27980 fix Node refuses to spawn .cmd/.bat without shell: true. Both pnpm lint:cycles and pnpm lint:cycles:update therefore fail at startup (EINVAL/ENOENT) before dependency-cruiser runs, so Windows contributors cannot run or update the baseline locally even though Linux CI is unaffected. Invoke dependency-cruiser's JS API, or resolve a cross-platform binary path, instead of shelling out to pnpm.

Raised by 3 of 8 reviewers (gpt-5.6-sol-max adversarial, kimi-k3-max adversarial, gpt-5.6-sol-max edge-case).

Comment thread .dependency-cruiser.ts
const config: IConfiguration = {
options: {
tsConfig: { fileName: 'tsconfig.json' },
tsPreCompilationDeps: 'specify',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — tsPreCompilationDeps: 'specify' makes dependency-cruiser emit type-only imports and tag each one preCompilationOnly, but cruiseOutputSchema in scripts/check-import-cycles.ts only picks resolved, so zod strips the tag and import type edges become indistinguishable from runtime edges. Adding a single new import type between two modules will fail the gate with "new import cycle edge(s) ... Break the cycle" even though the compiled output has no cycle. Either filter on preCompilationOnly (presumably why 'specify' was chosen over true) and regenerate the baseline, or decide explicitly that type-only cycles count and document it.

Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).


if (
process.argv[1] &&
fileURLToPath(import.meta.url) === resolve(process.argv[1])

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — Node resolves ESM specifiers through symlinks, so fileURLToPath(import.meta.url) yields a realpath while resolve(process.argv[1]) is only made absolute. When the checkout is reached through a symlinked path (macOS /tmp -> /private/tmp, a bind mount, a symlinked CI workspace) the two differ, main() never runs, and pnpm lint:cycles exits 0 — the new required CI step then passes vacuously while new cycles land unnoticed. Compare against realpathSync(process.argv[1]), or compare import.meta.url to pathToFileURL(process.argv[1]).href.

Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).

const violations: string[] = []
if (added.length > 0) {
violations.push(
`${added.length} new import cycle edge(s) in src:\n\n${added

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — The failure message is unbounded: one new edge that merges two strongly connected components reclassifies every cross edge between them as added, and each added edge gets its own full-graph BFS in formatEdge plus a multi-line cycle path. Against a baseline this size, a one-line change can render thousands of cycle paths — quadratic traversal and a CI log nobody can read. Cap the number of rendered edges and print a count for the remainder.

Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial).

const output = execFileSync(
'pnpm',
['exec', 'depcruise', 'src', '--output-type', 'json'],
{ encoding: 'utf8', maxBuffer: 512 * 1024 * 1024, stdio: 'pipe' }

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — The depcruise child is spawned with no timeout and with stdio: 'pipe', which hands it an stdin pipe that is never closed and swallows its stderr, and there is no try/catch around the call. A hang (resolver stall, symlink cycle, a blocking prompt) blocks until the job-level timeout instead of failing fast, and any real failure — config rejection, resolution error, non-zero exit, maxBuffer overflow — surfaces as an unhandled exception with the actual diagnostic buried in the thrown error's properties. Add a timeout, use stdio: ['ignore', 'pipe', 'inherit'], and wrap the call with an actionable message.

Raised by 3 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case).

}

function readBaseline(path: string): Baseline {
if (!existsSync(path)) return {}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — readBaseline treats an absent file as an empty baseline, so a deleted, renamed, or not-yet-committed .import-cycles-baseline.json — or any invocation whose cwd isn't the repo root, since baselinePath resolves against process.cwd() — reports all ~700 pre-existing edges as newly added with "Break the cycle" advice instead of saying the baseline is missing. Only the --update path needs the empty default; the check path should fail with an explicit "baseline not found" error.

Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).

Comment thread .dependency-cruiser.ts
@@ -0,0 +1,18 @@
import type { IConfiguration } from 'dependency-cruiser'

const config: IConfiguration = {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ Nit — This file was registered with knip and .fallowrc.jsonc but not added to tsconfig.json's include, which enumerates root-level TS config files individually (eslint.config.ts, knip.config.ts, lint-staged.config.ts, playwright.config.ts, vitest.config.ts). The IConfiguration annotation — the whole reason to author the config in TypeScript — is therefore never checked by pnpm typecheck, and an invalid option would only fail at depcruise runtime.

Raised by 1 of 8 reviewers (claude-opus-5-thinking-max edge-case).

kaili-yang pushed a commit to kaili-yang/ComfyUI_frontend that referenced this pull request Oct 7, 2026
…rg#19091)

## Summary

Targets `main`. In the original FE-3037 stack it sat on Comfy-Org#19089. Moves
`registerCoreSidebarTabs` out of `sidebarTabStore` into
`src/composables/sidebarTabs/registerCoreSidebarTabs.ts`.

The store imported the six core tab composables
(`useNodeLibrarySidebarTab`, `useModelLibrarySidebarTab`,
`useAssetsSidebarTab`, `useJobHistorySidebarTab`,
`useWorkflowsSidebarTab`, `useAppsSidebarTab`) only so it could register
them. Every one of those trees reads the store back, so the node
library, model library, queue, assets and workflow UI all sat in the
same import cycle as the store. `menuItemStore` was pulled in the same
way for the View-menu commands.

Measured with dependency-cruiser on `src` (the `pnpm lint:cycles` script
arrives with Comfy-Org#19085) against current `origin/main`:

| | before | after |
| --- | --- | --- |
| modules in any cycle | 1027 | 833 |
| largest cycle | 983 | 783 |
| cyclic edges | 4562 | 3766 |

Tracks FE-2769 / FE-3037.

## Changes

- New `registerCoreSidebarTabs()` in `src/composables/sidebarTabs/`.
Same body as the old store action, calling `useSidebarTabStore()` for
register/unregister.
- `sidebarTabStore` no longer imports the tab composables or
`menuItemStore`, and `registerCoreSidebarTabs` is gone from its return
value. It keeps `registerSidebarTab`, `unregisterSidebarTab`,
`toggleSidebarTab` and the model-library toggle command logic.
- `GraphView.vue` (the only caller) imports the function directly.
`GraphView.test.ts` mocks the module instead of the store action.
- Store tests that only exercised registration ordering move to
`registerCoreSidebarTabs.test.ts`; the model-library view-selection
tests stay on the store and register a tab directly.
- `registerCoreSidebarTabs.test.ts` also covers turning QPO V2 off (the
job history tab is removed), asserts the registered toggle command IDs
instead of a call count, and checks the two View-menu `registerCommands`
calls.

## Review Focus

- No behavior change in the app. `registerCoreSidebarTabs` is called
once, at the same point in `GraphView.vue`, and the QPO V2 watcher is
still created during `GraphView` setup.
- `app.extensionManager.sidebarTab` is the store instance, so
`registerCoreSidebarTabs` was reachable from extensions at runtime. It
is not on the typed `ExtensionManager` interface, and `GraphView.vue`
was its only caller in this repo.
- The new file sits in `src/composables/`, which the pre-commit hook
flags as frozen. It lives next to the tab composables it wires together;
happy to move it if there is a better home.
- The `tab.id === 'model-library'` special case in the store is
untouched; a per-tab activation hook on `SidebarTabExtension` would be
the way to remove it, but that changes the extension-facing type.

<!-- stack-table:start -->
## Stack

Import-cycle progress for FE-3037, measured with `pnpm lint:cycles`
(dependency-cruiser on `src`).

### Standalone PRs targeting `main`

Each is one commit on current `main` and can merge on its own. Numbers
are that PR alone against `origin/main` (1027 cyclic modules, largest
cycle 983, 4562 cyclic edges).

| PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges |
| --- | --- | --- | --- | --- | --- |
| Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 ->
884 | 983 -> 677 | 4562 -> 3382 |
| Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027
-> 1026 | 983 -> 982 | 4562 -> 4558 |
| Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor`
extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 |
| Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf
modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 |
| Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf |
1027 -> 1025 | 983 -> 981 | 4562 -> 4552 |
| Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027
-> 1027 | 983 -> 983 | 4562 -> 4555 |
| Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027
-> 1027 | 983 -> 983 | 4562 -> 4561 |
| Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs |
1027 -> 1027 | 983 -> 983 | 4562 -> 4561 |

All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet):
630 cyclic modules, largest cycle 412, 2476 cyclic edges.

### Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR
stack, each PR against its parent at the time, on the older `main` the
stack forked from (967 cyclic modules then). They have not been
remeasured since the eight PRs above left the stack. Where the base
changed, the parent the numbers were measured on is in parentheses.

Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of
the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and
Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is
rebased.

| PR | Base | Change | Cyclic modules | Largest cycle |
| --- | --- | --- | --- | --- |
| Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) |
967 (baseline) | 923 (baseline) |
| Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types |
967 -> 949 | 923 -> 905 |
| **Comfy-Org#19091** (this PR) | **Comfy-Org#19088 (measured on Comfy-Org#19089)** | **Register
core sidebar tabs outside `sidebarTabStore`** | **816 -> 669** | **618
-> 465** |
| Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not
`extensionService` | 669 -> 580 | 465 -> 371 |
| Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers
| 580 -> 566 | 371 -> 357 |
| Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from
the app shell | 558 -> 509 | 349 -> 297 |
| Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell |
509 -> 496 | 297 -> 284 |
| Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs
from GraphView | 484 -> 476 | 272 -> 264 |
| Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser
routing onto the sidebar tab | 471 -> 467 | 257 -> 253 |
| Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467
-> 464 | 253 -> 250 |
| Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 ->
447 | 250 -> 233 |
| Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` |
447 -> 428 | 233 -> 214 |
| Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of
`dialogService` | 400 -> 391 | 181 -> 172 |
| Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352
| 172 -> 149 |
| Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the
facade | 352 -> 324 | 149 (baseline) |
| Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow
contracts as leaves | 324 -> 293 | 149 (baseline) |
| Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto
`useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) |
| Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth
dialogs, menu, and more | 259 -> 211 | 149 (baseline) |
<!-- stack-table:end -->

---------

Co-authored-by: Amp <amp@ampcode.com>
kaili-yang pushed a commit to kaili-yang/ComfyUI_frontend that referenced this pull request Oct 7, 2026
## Summary

Targets `main`; in the original stack it sat on Comfy-Org#19088. Moves the
`ServerFeatureFlag` enum out of `useFeatureFlags.ts` into a leaf module
so `remoteConfig.ts` no longer imports the composable.

That single type-only import was the bridge that kept litegraph in the
app-wide import cycle: `remoteConfig → useFeatureFlags → api →
workflowSchema → LGraph`. Everything that reports errors (`reportError`,
`hostTelemetryEnabled`, `linkPresentationStore`,
`transferLinkPresentation`, and the litegraph canvas code that calls
them) rode that chain back into litegraph.

Measured with `pnpm lint:cycles` from Comfy-Org#19085 (dependency-cruiser, type
edges included; not on `main` yet, applied locally) on top of Comfy-Org#19088 in
the original stack:

| | before | after |
| --- | --- | --- |
| modules in any cycle | 949 | 816 |
| largest cycle | 905 | 618 |
| litegraph modules in the largest cycle | 117 | 0 |

Alone on current `main`: 1027 -> 884 cyclic modules, largest cycle 983
-> 677, 4562 -> 3382 cyclic edges, and no litegraph modules in the
largest cycle.

In the original stack, litegraph and its entity stores
(`widgetValueStore`, `layoutStore`, `nodeDataStore`,
`graphMetadataStore`, `previewExposureStore`, `core/graph/subgraph`,
`core/schemas`) formed their own 149-module cycle with no path to
`platform/`, `components/`, or `composables/`. That is the shape a
future graph-core package would need. On current `main` that cycle has
158 modules and includes `platform/nodeReplacement/cnrIdUtil.ts`, so it
is not yet separate from `platform/`.

Tracks FE-2769 / FE-3037.

## Changes

- New `src/platform/remoteConfig/serverFeatureFlag.ts` holding the enum
verbatim. No imports.
- `useFeatureFlags.ts`, `remoteConfig.ts`, `checkoutJourney.ts`,
`nodeReplacementStore.ts`, `useNodeImageUpload.ts`,
`useWidgetSelectActions.ts` and two tests import the enum from the leaf.
No re-export from `useFeatureFlags.ts`.
- `src/storybook/mocks/useFeatureFlags.ts` drops its hand-copied
duplicate of the enum; it existed only because of this coupling.
- `tools/test-recorder` flag discovery reads the enum from the leaf,
with a test against the real file; `docs/FEATURE_FLAGS.md` points at the
leaf.

## Review Focus

- No behavior change; the enum values are unchanged and nothing else
moved.
- The Storybook alias for `@/composables/useFeatureFlags` still points
at the mock; nothing imports `ServerFeatureFlag` through that alias any
more, so the mock only needs `useFeatureFlags`.

<!-- stack-table:start -->
## Stack

Import-cycle progress for FE-3037, measured with `pnpm lint:cycles`
(dependency-cruiser on `src`).

### Standalone PRs targeting `main`

Each is one commit on current `main` and can merge on its own. Numbers
are that PR alone against `origin/main` (1027 cyclic modules, largest
cycle 983, 4562 cyclic edges).

| PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges |
| --- | --- | --- | --- | --- | --- |
| **Comfy-Org#19089** (this PR) | **`main`** | **`ServerFeatureFlag` enum to a
leaf module** | **1027 -> 884** | **983 -> 677** | **4562 -> 3382** |
| Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027
-> 1026 | 983 -> 982 | 4562 -> 4558 |
| Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor`
extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 |
| Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf
modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 |
| Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf |
1027 -> 1025 | 983 -> 981 | 4562 -> 4552 |
| Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027
-> 1027 | 983 -> 983 | 4562 -> 4555 |
| Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027
-> 1027 | 983 -> 983 | 4562 -> 4561 |
| Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs |
1027 -> 1027 | 983 -> 983 | 4562 -> 4561 |

All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet):
630 cyclic modules, largest cycle 412, 2476 cyclic edges.

### Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR
stack, each PR against its parent at the time, on the older `main` the
stack forked from (967 cyclic modules then). They have not been
remeasured since the eight PRs above left the stack. Where the base
changed, the parent the numbers were measured on is in parentheses.

Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of
the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and
Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is
rebased.

| PR | Base | Change | Cyclic modules | Largest cycle |
| --- | --- | --- | --- | --- |
| Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) |
967 (baseline) | 923 (baseline) |
| Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types |
967 -> 949 | 923 -> 905 |
| Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs
outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 |
| Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not
`extensionService` | 669 -> 580 | 465 -> 371 |
| Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers
| 580 -> 566 | 371 -> 357 |
| Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from
the app shell | 558 -> 509 | 349 -> 297 |
| Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell |
509 -> 496 | 297 -> 284 |
| Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs
from GraphView | 484 -> 476 | 272 -> 264 |
| Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser
routing onto the sidebar tab | 471 -> 467 | 257 -> 253 |
| Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467
-> 464 | 253 -> 250 |
| Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 ->
447 | 250 -> 233 |
| Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` |
447 -> 428 | 233 -> 214 |
| Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of
`dialogService` | 400 -> 391 | 181 -> 172 |
| Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352
| 172 -> 149 |
| Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the
facade | 352 -> 324 | 149 (baseline) |
| Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow
contracts as leaves | 324 -> 293 | 149 (baseline) |
| Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto
`useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) |
| Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth
dialogs, menu, and more | 259 -> 211 | 149 (baseline) |
<!-- stack-table:end -->

---------

Co-authored-by: Amp <amp@ampcode.com>
DrJKL added a commit to another-chi/ComfyUI_frontend that referenced this pull request Oct 8, 2026
)

## Summary

Adds dependency-cruiser and `pnpm deps:audit` to report import cycles in
`src/` for auditing and tracking. Unlike Comfy-Org#19085, there is no baseline
file, no ratchet, and no CI step: `no-circular` is a `warn` rule, so the
command always exits 0.

- `.dependency-cruiser.json`: resolves through `tsconfig.json` paths,
parses `.vue`, skips test/spec/story files, does not follow
`node_modules`. It is JSON rather than `.ts` because knip's and fallow's
built-in dependency-cruiser plugins only detect
`.dependency-cruiser.{js,cjs,mjs,json}`; this way neither tool needs a
manual entry or ignore.
- No root `@vue/compiler-sfc`: dependency-cruiser resolves it through
pnpm's hoisted `.pnpm/node_modules` (a direct dependency of `vue`).
`depcruise --info` shows `✔ @vue/compiler-sfc` and `✔ .vue`, and the
audit output is identical with or without the root dependency.
- dependency-cruiser's `no-circular` reports one representative edge per
cycle, chosen in DFS order. The count is useful for spotting trends but
is not stable enough to gate on.

Tracks FE-2769 / FE-3037.

## Verification

- `pnpm deps:audit` on current `main`: exit 0, `3116 dependency
violations (0 errors, 3116 warnings). 2618 modules, 15788 dependencies
cruised.` Takes about 23 s.
- `pnpm knip` and `pnpm fallow audit --changed-since origin/main` are
clean with no dependency-cruiser entries in either config.

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
DrJKL added a commit to another-chi/ComfyUI_frontend that referenced this pull request Oct 8, 2026
…#19124)

## Summary

Targets `main`; in the original stack it sat on Comfy-Org#19122. Tracks FE-2769 /
FE-3037.

`src/types/comfy.ts` is inside the app cycle (litegraph barrel,
`ComfyExtension`). `MissingNodeType` lived there, so the missing-node
scan, error catalog, right-side-panel error groups and telemetry
grouping all joined the cycle to read one type alias. The alias already
depended on `NodeReplacement` from the `nodeReplacement` leaf; it now
lives next to it.

Import cycles in the original stack, on top of Comfy-Org#19122: 417 -> 411 cyclic
modules, largest SCC 203 -> 197. Alone on current `main`: cyclic modules
and largest SCC unchanged (1027, 983), 4562 -> 4555 cyclic edges.

## Changes

- `MissingNodeType` moves from `src/types/comfy.ts` to
`src/platform/nodeReplacement/types.ts`, unchanged.
- Importers read it from `@/platform/nodeReplacement/types`; `comfy.ts`
imports it for the `ComfyExtension.beforeConfigureGraph` /
`afterConfigureGraph` hooks. No re-export is left behind.

## Review Focus

- Type-only move, no runtime change. `MissingNodeType` was not part of
the `src/types/index.ts` public barrel, so the extension-facing surface
is unchanged.

<!-- stack-table:start -->
## Stack

Import-cycle progress for FE-3037, measured with `pnpm lint:cycles`
(dependency-cruiser on `src`).

### Standalone PRs targeting `main`

Each is one commit on current `main` and can merge on its own. Numbers
are that PR alone against `origin/main` (1027 cyclic modules, largest
cycle 983, 4562 cyclic edges).

| PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges |
| --- | --- | --- | --- | --- | --- |
| Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 ->
884 | 983 -> 677 | 4562 -> 3382 |
| Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027
-> 1026 | 983 -> 982 | 4562 -> 4558 |
| Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor`
extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 |
| Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf
modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 |
| Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf |
1027 -> 1025 | 983 -> 981 | 4562 -> 4552 |
| **Comfy-Org#19124** (this PR) | **`main`** | **`MissingNodeType` to the
nodeReplacement leaf** | **1027 -> 1027** | **983 -> 983** | **4562 ->
4555** |
| Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027
-> 1027 | 983 -> 983 | 4562 -> 4561 |
| Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs |
1027 -> 1027 | 983 -> 983 | 4562 -> 4561 |

All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet):
630 cyclic modules, largest cycle 412, 2476 cyclic edges.

### Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR
stack, each PR against its parent at the time, on the older `main` the
stack forked from (967 cyclic modules then). They have not been
remeasured since the eight PRs above left the stack. Where the base
changed, the parent the numbers were measured on is in parentheses.

Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of
the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and
Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is
rebased.

| PR | Base | Change | Cyclic modules | Largest cycle |
| --- | --- | --- | --- | --- |
| Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) |
967 (baseline) | 923 (baseline) |
| Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types |
967 -> 949 | 923 -> 905 |
| Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs
outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 |
| Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not
`extensionService` | 669 -> 580 | 465 -> 371 |
| Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers
| 580 -> 566 | 371 -> 357 |
| Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from
the app shell | 558 -> 509 | 349 -> 297 |
| Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell |
509 -> 496 | 297 -> 284 |
| Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs
from GraphView | 484 -> 476 | 272 -> 264 |
| Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser
routing onto the sidebar tab | 471 -> 467 | 257 -> 253 |
| Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467
-> 464 | 253 -> 250 |
| Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 ->
447 | 250 -> 233 |
| Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` |
447 -> 428 | 233 -> 214 |
| Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of
`dialogService` | 400 -> 391 | 181 -> 172 |
| Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352
| 172 -> 149 |
| Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the
facade | 352 -> 324 | 149 (baseline) |
| Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow
contracts as leaves | 324 -> 293 | 149 (baseline) |
| Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto
`useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) |
| Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth
dialogs, menu, and more | 259 -> 211 | 149 (baseline) |
<!-- stack-table:end -->

---------

Co-authored-by: Amp <amp@ampcode.com>
DrJKL added a commit to another-chi/ComfyUI_frontend that referenced this pull request Oct 8, 2026
…omfy-Org#19107)

## Summary

Stacked on Comfy-Org#19091, which targets `main`. In the original stack it sat on
Comfy-Org#19094. Tracks FE-2769 / FE-3037.

`useSettingsDialog` imported `SettingDialog.vue` so it could open it.
The settings subtree (billing stores, top-up dialogs,
`ConfirmationDialogContent`, `UploadModelUrlInput`, `scripts/ui.ts`)
imports `useSettingsDialog` to jump to a panel. That one edge kept the
settings UI inside the main import cycle.

Measured with dependency-cruiser on `src` (the `pnpm lint:cycles` script
arrives with Comfy-Org#19085) against Comfy-Org#19091's branch: cyclic modules 833 -> 772,
largest cycle 783 -> 719, cyclic edges 3766 -> 3541.

## Changes

- `useSettingsDialog.show()` opens whichever component was registered
through the new `registerSettingDialogComponent()`; `GraphView.vue`
registers `SettingDialog.vue` next to the other core registrations. An
unregistered `show()` reports `failure_opening_settings_dialog` through
`reportError` and returns without opening anything.
- `SettingDialogProps` moves to `platform/settings/types.ts`;
`SettingDialog.vue` uses it for `defineProps`, so the registration stays
typed without importing the component.
- `useSettingsDialog.test.ts` drops the billing/i18n/telemetry mocks it
only needed because it transitively loaded `SettingDialog.vue`,
registers a stub, and asserts `show()` passes that stub.
`useSettingsDialog.unregistered.test.ts` covers `show()` before
registration: it reports `failure_opening_settings_dialog` and opens no
dialog. `GraphView.test.ts` stubs `SettingDialog.vue` now that
`GraphView` imports it.

## Review Focus

- `GraphView` runs `registerSettingDialogComponent` during setup, before
`GraphCanvas` (child) runs the `?settings=` URL loader, and before any
user action can trigger `Comfy.ShowSettingsDialog`.
- Registration is module-level state in `useSettingsDialog.ts`, the same
shape as the sidebar tab registration in Comfy-Org#19091 but for one component.

<!-- stack-table:start -->
## Stack

Import-cycle progress for FE-3037, measured with `pnpm lint:cycles`
(dependency-cruiser on `src`).

### Standalone PRs targeting `main`

Each is one commit on current `main` and can merge on its own. Numbers
are that PR alone against `origin/main` (1027 cyclic modules, largest
cycle 983, 4562 cyclic edges).

| PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges |
| --- | --- | --- | --- | --- | --- |
| Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 ->
884 | 983 -> 677 | 4562 -> 3382 |
| Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027
-> 1026 | 983 -> 982 | 4562 -> 4558 |
| Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor`
extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 |
| Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf
modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 |
| Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf |
1027 -> 1025 | 983 -> 981 | 4562 -> 4552 |
| Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027
-> 1027 | 983 -> 983 | 4562 -> 4555 |
| Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027
-> 1027 | 983 -> 983 | 4562 -> 4561 |
| Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs |
1027 -> 1027 | 983 -> 983 | 4562 -> 4561 |

All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet):
630 cyclic modules, largest cycle 412, 2476 cyclic edges.

### Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR
stack, each PR against its parent at the time, on the older `main` the
stack forked from (967 cyclic modules then). They have not been
remeasured since the eight PRs above left the stack. Where the base
changed, the parent the numbers were measured on is in parentheses.

Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of
the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and
Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is
rebased.

| PR | Base | Change | Cyclic modules | Largest cycle |
| --- | --- | --- | --- | --- |
| Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) |
967 (baseline) | 923 (baseline) |
| Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types |
967 -> 949 | 923 -> 905 |
| Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs
outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 |
| Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not
`extensionService` | 669 -> 580 | 465 -> 371 |
| Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers
| 580 -> 566 | 371 -> 357 |
| **Comfy-Org#19107** (this PR) | **Comfy-Org#19093 (measured on Comfy-Org#19094)** | **Register
settings dialog from the app shell** | **558 -> 509** | **349 -> 297** |
| Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell |
509 -> 496 | 297 -> 284 |
| Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs
from GraphView | 484 -> 476 | 272 -> 264 |
| Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser
routing onto the sidebar tab | 471 -> 467 | 257 -> 253 |
| Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467
-> 464 | 253 -> 250 |
| Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 ->
447 | 250 -> 233 |
| Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` |
447 -> 428 | 233 -> 214 |
| Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of
`dialogService` | 400 -> 391 | 181 -> 172 |
| Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352
| 172 -> 149 |
| Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the
facade | 352 -> 324 | 149 (baseline) |
| Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow
contracts as leaves | 324 -> 293 | 149 (baseline) |
| Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto
`useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) |
| Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth
dialogs, menu, and more | 259 -> 211 | 149 (baseline) |
<!-- stack-table:end -->

---------

Co-authored-by: Amp <amp@ampcode.com>
Penguinjanator pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Oct 8, 2026
…9127)

## Summary

Targets `main` on its own; in the original stack it sat on Comfy-Org#19125.
Tracks FE-2769 / FE-3037.

`createGraphThumbnail()` read the graph to render from `workflowStore`
and `canvasStore`, and `MinimapDataSource` read node progress from
`executionStore`. That put the thumbnail renderer and the minimap data
path into the app cycle (`workflowStore -> useWorkflowThumbnail ->
graphThumbnailRenderer -> ... -> executionStore -> workflowStore`). Both
now take their inputs as arguments.

Import cycles in the original stack, on top of Comfy-Org#19125: 403 -> 400 cyclic
modules, largest SCC 184 -> 181. Alone on current `main`: cyclic modules
and largest SCC unchanged (1027, 983), 4562 -> 4561 cyclic edges.

## Changes

- `graphThumbnailRenderer.ts`: `createGraphThumbnail(graph)` renders the
graph it is given. No store imports.
- `useWorkflowThumbnail.ts`: `createMinimapPreview(graph)` and
`storeThumbnail(workflow, graph)` forward the graph.
- `workflowService.beforeLoadNewGraph` passes
`workflowStore.activeSubgraph || app.canvasOrUndefined?.graph`, the same
selection the renderer made before.
- `MinimapDataSource(graph, nodeProgressStates = {})`: progress states
are injected. `MinimapRenderContext.nodeProgressStates` carries them;
`useMinimapRenderer` resolves `useExecutionStore()` once in setup and
passes `nodeLocationProgressStates` on each render, so the live minimap
still colors running/finished/error nodes.
- `minimap/types.ts`: `MinimapNodeExecutionState` and
`MinimapNodeProgressStates` replace the inline union.
- `workflowService.test.ts`: `beforeLoadNewGraph` stores a thumbnail of
the active subgraph, or of `app.canvasOrUndefined.graph` when none is
active. The shared `scripts/__mocks__/app.ts` gains a
`canvasOrUndefined` getter backed by the same state as `canvas`.

## Review Focus

- Stored workflow thumbnails no longer show execution-state colors:
`createGraphThumbnail` passes no progress states. Thumbnails are
captured when switching away from a workflow, so that state was stale by
the time it was shown. If the colors matter, `workflowService` can pass
`useExecutionStore().nodeLocationProgressStates` through
`storeThumbnail`.
- `useMinimapViewport` builds a `MinimapDataSource` for bounds only and
did not need progress states; it uses the default.
- `MinimapDataSource.test.ts` injects states through the constructor
instead of `Object.assign(useExecutionStore(), ...)`.
`useMinimap.progressBaseline.test.ts` still exercises the executionStore
path through `useMinimapRenderer` and is unchanged; removing the
`nodeProgressStates` line in `useMinimapRenderer` fails it.
- The `canvasOrUndefined` mock getter also reaches
`workflowStore.updateActiveGraph`, which previously returned early under
the mock. The 80 suites that use the shared app mock pass.

<!-- stack-table:start -->
## Stack

Import-cycle progress for FE-3037, measured with `pnpm lint:cycles`
(dependency-cruiser on `src`).

### Standalone PRs targeting `main`

Each is one commit on current `main` and can merge on its own. Numbers
are that PR alone against `origin/main` (1027 cyclic modules, largest
cycle 983, 4562 cyclic edges).

| PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges |
| --- | --- | --- | --- | --- | --- |
| Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 ->
884 | 983 -> 677 | 4562 -> 3382 |
| Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027
-> 1026 | 983 -> 982 | 4562 -> 4558 |
| Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor`
extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 |
| Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf
modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 |
| Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf |
1027 -> 1025 | 983 -> 981 | 4562 -> 4552 |
| Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027
-> 1027 | 983 -> 983 | 4562 -> 4555 |
| Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027
-> 1027 | 983 -> 983 | 4562 -> 4561 |
| **Comfy-Org#19127** (this PR) | **`main`** | **Thumbnail and minimap data from
explicit inputs** | **1027 -> 1027** | **983 -> 983** | **4562 -> 4561**
|

All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet):
630 cyclic modules, largest cycle 412, 2476 cyclic edges.

### Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR
stack, each PR against its parent at the time, on the older `main` the
stack forked from (967 cyclic modules then). They have not been
remeasured since the eight PRs above left the stack. Where the base
changed, the parent the numbers were measured on is in parentheses.

Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of
the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and
Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is
rebased.

| PR | Base | Change | Cyclic modules | Largest cycle |
| --- | --- | --- | --- | --- |
| Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) |
967 (baseline) | 923 (baseline) |
| Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types |
967 -> 949 | 923 -> 905 |
| Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs
outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 |
| Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not
`extensionService` | 669 -> 580 | 465 -> 371 |
| Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers
| 580 -> 566 | 371 -> 357 |
| Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from
the app shell | 558 -> 509 | 349 -> 297 |
| Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell |
509 -> 496 | 297 -> 284 |
| Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs
from GraphView | 484 -> 476 | 272 -> 264 |
| Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser
routing onto the sidebar tab | 471 -> 467 | 257 -> 253 |
| Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467
-> 464 | 253 -> 250 |
| Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 ->
447 | 250 -> 233 |
| Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` |
447 -> 428 | 233 -> 214 |
| Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of
`dialogService` | 400 -> 391 | 181 -> 172 |
| Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352
| 172 -> 149 |
| Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the
facade | 352 -> 324 | 149 (baseline) |
| Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow
contracts as leaves | 324 -> 293 | 149 (baseline) |
| Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto
`useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) |
| Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth
dialogs, menu, and more | 259 -> 211 | 149 (baseline) |
<!-- stack-table:end -->

---------

Co-authored-by: Amp <amp@ampcode.com>
Penguinjanator pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Oct 8, 2026
## Summary

Targets `main` as a single commit; in the original stack it sat on
Comfy-Org#19124. Tracks FE-2769 / FE-3037.

`nodeDefStore.nodeDefs` prepended `subgraphStore.subgraphBlueprints`, so
the node-def registry depended on `subgraphStore`, and through it on the
workflow store, dialog service, canvas store and the rest of the app
cycle. Blueprint node defs are node defs; the registry now owns them and
`subgraphStore` writes into it, so the dependency points one way.

Import cycles in the original stack, on top of Comfy-Org#19124: 411 -> 403 cyclic
modules, largest SCC 197 -> 184. Alone on current `main`: cyclic modules
and largest SCC unchanged (1027, 983), 4562 -> 4561 cyclic edges.

## Changes

- `nodeDefStore.ts`: owns blueprint defs in a private map keyed by def
name (`SubgraphBlueprint.<name>`, like `nodeDefsByName`), replacing
`subgraphStore`'s private `subgraphDefCache`. It exposes a read-only
`blueprintNodeDefsByName` plus `registerBlueprintNodeDef` and
`removeBlueprintNodeDef`. `nodeDefs` reads the map directly, and the
`subgraphStore` import is gone.
- `subgraphStore.ts`: registers, checks and removes blueprint defs
through those actions and getter, reading through the store on every
access. The now-unused `subgraphBlueprints` export is removed; no
production code read it once `nodeDefStore` stopped.
- `subgraphStore.test.ts`: new tests for deleting a blueprint, and for
confirming or declining an overwrite on publish. Blueprint counts are
asserted through `useNodeDefStore()`.

## Review Focus

- Global blueprints are registered under their server key `k`, so their
def name is `SubgraphBlueprint.<k>`. The overwrite check and
`isGlobalBlueprint` add the prefix to the bare name; `deleteBlueprint`
removes by the `nodeType` it already receives.

<!-- stack-table:start -->
## Stack

Import-cycle progress for FE-3037, measured with `pnpm lint:cycles`
(dependency-cruiser on `src`).

### Standalone PRs targeting `main`

Each is one commit on current `main` and can merge on its own. Numbers
are that PR alone against `origin/main` (1027 cyclic modules, largest
cycle 983, 4562 cyclic edges).

| PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges |
| --- | --- | --- | --- | --- | --- |
| Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 ->
884 | 983 -> 677 | 4562 -> 3382 |
| Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027
-> 1026 | 983 -> 982 | 4562 -> 4558 |
| Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor`
extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 |
| Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf
modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 |
| Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf |
1027 -> 1025 | 983 -> 981 | 4562 -> 4552 |
| Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027
-> 1027 | 983 -> 983 | 4562 -> 4555 |
| **Comfy-Org#19125** (this PR) | **`main`** | **Blueprint node defs owned by
`nodeDefStore`** | **1027 -> 1027** | **983 -> 983** | **4562 -> 4561**
|
| Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs |
1027 -> 1027 | 983 -> 983 | 4562 -> 4561 |

All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet):
630 cyclic modules, largest cycle 412, 2476 cyclic edges.

### Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR
stack, each PR against its parent at the time, on the older `main` the
stack forked from (967 cyclic modules then). They have not been
remeasured since the eight PRs above left the stack. Where the base
changed, the parent the numbers were measured on is in parentheses.

Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of
the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and
Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is
rebased.

| PR | Base | Change | Cyclic modules | Largest cycle |
| --- | --- | --- | --- | --- |
| Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) |
967 (baseline) | 923 (baseline) |
| Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types |
967 -> 949 | 923 -> 905 |
| Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs
outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 |
| Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not
`extensionService` | 669 -> 580 | 465 -> 371 |
| Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers
| 580 -> 566 | 371 -> 357 |
| Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from
the app shell | 558 -> 509 | 349 -> 297 |
| Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell |
509 -> 496 | 297 -> 284 |
| Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs
from GraphView | 484 -> 476 | 272 -> 264 |
| Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser
routing onto the sidebar tab | 471 -> 467 | 257 -> 253 |
| Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467
-> 464 | 253 -> 250 |
| Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 ->
447 | 250 -> 233 |
| Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` |
447 -> 428 | 233 -> 214 |
| Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of
`dialogService` | 400 -> 391 | 181 -> 172 |
| Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352
| 172 -> 149 |
| Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the
facade | 352 -> 324 | 149 (baseline) |
| Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow
contracts as leaves | 324 -> 293 | 149 (baseline) |
| Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto
`useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) |
| Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth
dialogs, menu, and more | 259 -> 211 | 149 (baseline) |
<!-- stack-table:end -->

---------

Co-authored-by: Amp <amp@ampcode.com>
Penguinjanator pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Oct 8, 2026
## Summary

Targets `main` as a standalone branch; in the original stack it sat on
Comfy-Org#19121. Tracks FE-2769 / FE-3037.

`settingStore` imported `scripts/app` to replay every setting change on
the legacy `ComfySettingsDialog` event target, and owned
`SettingTreeNode`, a settings-dialog UI type that dragged
`treeExplorerTypes` (and through it `nodeDefStore`) into the store. Both
edges kept the store inside the app cycle even though nothing the store
does depends on the app.

Import cycles in the original stack, on top of Comfy-Org#19121: 428 -> 417 cyclic
modules, largest SCC 214 -> 203. Alone on current `main`: 1027 -> 1024
cyclic modules, largest SCC 983 -> 980, 4562 -> 4545 cyclic edges.

## Changes

- `settingStore.ts`: exposes `onSettingChanged` (vueuse
`createEventHook`, same shape as `executionStore.onJobReset`).
`onChange` fires it where it used to call
`app.ui.settings.dispatchChange`, still before awaiting the setting's
own handler so the ordering extensions observe is unchanged. No more
`scripts/app` import.
- `GraphCanvas.vue`: subscribes `comfyApp.ui.settings.dispatchChange` to
the hook in setup, before `CORE_SETTINGS` register, so extensions
listening for `<id>.change` on the legacy dialog still receive every
event, including the ones fired by core-setting registration.
`createEventHook` unsubscribes on scope dispose, so a remount does not
double-dispatch. `GraphCanvas.test.ts` covers both.
- `SettingTreeNode` moves to `useSettingSearch.ts`, next to the
composables that build and search the settings tree; `useSettingUI.ts`
and `SettingDialog.vue` import it from there.
- `settingStore.test.ts` asserts on the hook payload (`id`, `value`,
`oldValue`) instead of the `app` mock; the `scripts/app` mock is gone
from the file.
- `$el` (with `Props`, `Children`, `ElementType`) moves from
`scripts/ui.ts` to the new leaf `scripts/ui/utils.ts`; `ui.ts`
re-exports it as `export const $el` so the comfyAPI shim keeps
`window.comfyAPI.ui.$el`. Every internal importer, including the
`scripts/ui/components` and `scripts/ui/menu` modules, imports `$el`
from the leaf; only the shim re-export in `ui.ts` remains. Without
settingStore -> app, `scripts/utils -> ui.ts -> ... -> app.ts` was
reached before `app` in some test graphs and `new ComfyApp()` ran with
`ComfyUI` uninitialised.
- `app.test.ts` imports `./app` right after the shoehorn import so
`app.ts` evaluates before the `litegraphUtil` manual mock's circular
import returns the original module.
- fallow: `ignoreExports` entry for the `$el` re-export (same situation
as the baselined `ComfyDialog`); dead-code baseline swaps the removed
`settingStore -> app` cycle for the five app.ts cycle representatives
fallow now reports instead; health baseline follows `$el` to
`ui/utils.ts`.

## Review Focus

- The bridge lives in `GraphCanvas.vue` because `app` (and
`app.ui.settings`) is constructed at module import, before pinia is
active, so `ComfySettingsDialog` cannot subscribe in its constructor.
Extensions are loaded in `app.setup()`, which GraphCanvas calls after
the bridge subscribes, so no `<id>.change` listener exists before the
bridge does.
- `SettingChange` stays a module-private interface; only the hook's
inferred type exposes it.
- The `app.test.ts` import reorder is an evaluation-order workaround.
The underlying `litegraphUtil -> app` edge (`resolveNode(graph =
app.rootGraph)`) frees no cyclic modules on its own, so it is left for a
later PR.

<!-- stack-table:start -->
## Stack

Import-cycle progress for FE-3037, measured with `pnpm lint:cycles`
(dependency-cruiser on `src`).

### Standalone PRs targeting `main`

Each is one commit on current `main` and can merge on its own. Numbers
are that PR alone against `origin/main` (1027 cyclic modules, largest
cycle 983, 4562 cyclic edges).

| PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges |
| --- | --- | --- | --- | --- | --- |
| Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 ->
884 | 983 -> 677 | 4562 -> 3382 |
| Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027
-> 1026 | 983 -> 982 | 4562 -> 4558 |
| Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor`
extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 |
| Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf
modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 |
| **Comfy-Org#19122** (this PR) | **`main`** | **`settingStore` off
`scripts/app`; `$el` to a leaf** | **1027 -> 1025** | **983 -> 981** |
**4562 -> 4552** |
| Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027
-> 1027 | 983 -> 983 | 4562 -> 4555 |
| Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027
-> 1027 | 983 -> 983 | 4562 -> 4561 |
| Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs |
1027 -> 1027 | 983 -> 983 | 4562 -> 4561 |

All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet):
630 cyclic modules, largest cycle 412, 2476 cyclic edges.

### Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR
stack, each PR against its parent at the time, on the older `main` the
stack forked from (967 cyclic modules then). They have not been
remeasured since the eight PRs above left the stack. Where the base
changed, the parent the numbers were measured on is in parentheses.

Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of
the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and
Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is
rebased.

| PR | Base | Change | Cyclic modules | Largest cycle |
| --- | --- | --- | --- | --- |
| Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) |
967 (baseline) | 923 (baseline) |
| Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types |
967 -> 949 | 923 -> 905 |
| Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs
outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 |
| Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not
`extensionService` | 669 -> 580 | 465 -> 371 |
| Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers
| 580 -> 566 | 371 -> 357 |
| Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from
the app shell | 558 -> 509 | 349 -> 297 |
| Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell |
509 -> 496 | 297 -> 284 |
| Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs
from GraphView | 484 -> 476 | 272 -> 264 |
| Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser
routing onto the sidebar tab | 471 -> 467 | 257 -> 253 |
| Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467
-> 464 | 253 -> 250 |
| Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 ->
447 | 250 -> 233 |
| Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` |
447 -> 428 | 233 -> 214 |
| Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of
`dialogService` | 400 -> 391 | 181 -> 172 |
| Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352
| 172 -> 149 |
| Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the
facade | 352 -> 324 | 149 (baseline) |
| Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow
contracts as leaves | 324 -> 293 | 149 (baseline) |
| Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto
`useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) |
| Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth
dialogs, menu, and more | 259 -> 211 | 149 (baseline) |
<!-- stack-table:end -->

---------

Co-authored-by: Amp <amp@ampcode.com>
Penguinjanator pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Oct 8, 2026
…lder (Comfy-Org#19094)

## Summary

Targets `main` as a standalone branch; in the original stack it sat on
Comfy-Org#19093. `appModeStore.enterBuilder()` no longer decides whether to show
the empty-workflow dialog. That check moves to a new `useEnterBuilder`
composable next to the dialog, and the store's `enterBuilder` enters the
builder unconditionally.

The store imported `useEmptyWorkflowDialog`, which imports
`dialogService`, `useWorkflowTemplateSelectorDialog` and their content
components. That was the only reason those modules sat in the same
import cycle as the app-mode store.

Measured with dependency-cruiser (type edges included; the `pnpm
lint:cycles` script from Comfy-Org#19085, not yet on `main`) on top of Comfy-Org#19093 in
the original stack:

| | before | after |
| --- | --- | --- |
| modules in any cycle | 566 | 558 |
| largest cycle | 357 | 349 |

Alone on current `main`: 1027 -> 1026 cyclic modules, largest cycle 983
-> 982, 4562 -> 4558 cyclic edges.

Tracks FE-2769 / FE-3037.

## Changes

- New `src/components/builder/useEnterBuilder.ts`: if
`appModeStore.hasNodes` is false it shows the empty-workflow dialog,
otherwise it calls `appModeStore.enterBuilder()`. Dismissing the dialog
("Back to workflow") returns to graph mode. After "Load template", the
dialog checks the live graph and calls `appModeStore.enterBuilder()`
directly, instead of re-reading the cached `hasNodes`, which can lag a
template load.
- `appModeStore.enterBuilder()` drops the `!hasNodes` branch and the
dialog import.
- `useWorkflowActionsMenu`, `AppModeToolbar.vue` and `LinearWelcome.vue`
call `useEnterBuilder().enterBuilder` instead of the store action. The
toolbar and welcome buttons were already hidden or disabled without
nodes; the actions menu was the only reachable path to the dialog.
- The dialog tests move from `appModeStore.test.ts` to
`useEnterBuilder.test.ts`. New `useEmptyWorkflowDialog.test.ts` covers
the dismiss path and the live-graph check after a template load.
`useWorkflowActionsMenu.test.ts` mocks the composable and asserts on it.

## Review Focus

- `appModeStore.enterBuilder()` is now a plain transition. Any future
caller that can run with an empty graph must go through
`useEnterBuilder`.
- `useEnterBuilder.test.ts` uses the global testing Pinia and
`Object.assign(store, { hasNodes })`, matching `AppModeToolbar.test.ts`;
the `comfy/use-global-pinia` lint rule rejects mocking the store module.


<!-- stack-table:start -->
## Stack

Import-cycle progress for FE-3037, measured with `pnpm lint:cycles`
(dependency-cruiser on `src`).

### Standalone PRs targeting `main`

Each is one commit on current `main` and can merge on its own. Numbers
are that PR alone against `origin/main` (1027 cyclic modules, largest
cycle 983, 4562 cyclic edges).

| PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges |
| --- | --- | --- | --- | --- | --- |
| Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 ->
884 | 983 -> 677 | 4562 -> 3382 |
| **Comfy-Org#19094** (this PR) | **`main`** | **Empty-workflow dialog out of
`appModeStore`** | **1027 -> 1026** | **983 -> 982** | **4562 -> 4558**
|
| Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor`
extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 |
| Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf
modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 |
| Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf |
1027 -> 1025 | 983 -> 981 | 4562 -> 4552 |
| Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027
-> 1027 | 983 -> 983 | 4562 -> 4555 |
| Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027
-> 1027 | 983 -> 983 | 4562 -> 4561 |
| Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs |
1027 -> 1027 | 983 -> 983 | 4562 -> 4561 |

All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet):
630 cyclic modules, largest cycle 412, 2476 cyclic edges.

### Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR
stack, each PR against its parent at the time, on the older `main` the
stack forked from (967 cyclic modules then). They have not been
remeasured since the eight PRs above left the stack. Where the base
changed, the parent the numbers were measured on is in parentheses.

Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of
the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and
Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is
rebased.

| PR | Base | Change | Cyclic modules | Largest cycle |
| --- | --- | --- | --- | --- |
| Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) |
967 (baseline) | 923 (baseline) |
| Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types |
967 -> 949 | 923 -> 905 |
| Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs
outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 |
| Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not
`extensionService` | 669 -> 580 | 465 -> 371 |
| Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers
| 580 -> 566 | 371 -> 357 |
| Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from
the app shell | 558 -> 509 | 349 -> 297 |
| Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell |
509 -> 496 | 297 -> 284 |
| Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs
from GraphView | 484 -> 476 | 272 -> 264 |
| Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser
routing onto the sidebar tab | 471 -> 467 | 257 -> 253 |
| Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467
-> 464 | 253 -> 250 |
| Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 ->
447 | 250 -> 233 |
| Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` |
447 -> 428 | 233 -> 214 |
| Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of
`dialogService` | 400 -> 391 | 181 -> 172 |
| Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352
| 172 -> 149 |
| Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the
facade | 352 -> 324 | 149 (baseline) |
| Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow
contracts as leaves | 324 -> 293 | 149 (baseline) |
| Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto
`useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) |
| Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth
dialogs, menu, and more | 259 -> 211 | 149 (baseline) |
<!-- stack-table:end -->

---------

Co-authored-by: Amp <amp@ampcode.com>
Penguinjanator pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Oct 8, 2026
…f modules (Comfy-Org#19112)

## Summary

Two type/constant-only imports pulled UI modules into the stores and
scripts import cycle. `domWidgetStore` imported `useAbsolutePosition`
for the `PositionConfig` type, and `changeTracker` imported
`layerEditorDialog` for `LAYER_EDITOR_DIALOG_KEY`. Both now come from
leaf modules. Import cycles in the original stack, on top of Comfy-Org#19111: 476
-> 471 cyclic modules, largest SCC 264 -> 257; frees 7 modules
(`useAbsolutePosition`, `DomWidget.vue`, `layerEditorDialog`,
`LayerEditorContent.vue`, `useCompositorEditor`, `changeTracker`,
`domWidgetStore`). Alone on current `main`: cyclic modules and largest
SCC unchanged (1027, 983), 4562 -> 4558 cyclic edges.

Targets `main` as a single commit; in the original stack it sat on
Comfy-Org#19111. Tracks FE-2769 / FE-3037.

## Changes

- `src/types/positionConfig.ts` holds `PositionConfig`, typed with
`Point` and `Size` from litegraph `interfaces` rather than the litegraph
barrel; `useAbsolutePosition` and `domWidgetStore` import it from there.
- `src/renderer/extensions/layerEditor/layerEditorDialogKey.ts` holds
`LAYER_EDITOR_DIALOG_KEY`; `useLayerEditor`, `useCompositorEditor`, and
`changeTracker` import it from there, and `layerEditorDialog` no longer
exports it.

## Review Focus

- No behavior change; moves only. Neither `useAbsolutePosition` nor
`layerEditorDialog` re-exports the moved symbol, so any external import
of `PositionConfig` or `LAYER_EDITOR_DIALOG_KEY` from the old paths
breaks at typecheck. Neither is part of the extension API surface.

<!-- stack-table:start -->
## Stack

Import-cycle progress for FE-3037, measured with `pnpm lint:cycles`
(dependency-cruiser on `src`).

### Standalone PRs targeting `main`

Each is one commit on current `main` and can merge on its own. Numbers
are that PR alone against `origin/main` (1027 cyclic modules, largest
cycle 983, 4562 cyclic edges).

| PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges |
| --- | --- | --- | --- | --- | --- |
| Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 ->
884 | 983 -> 677 | 4562 -> 3382 |
| Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027
-> 1026 | 983 -> 982 | 4562 -> 4558 |
| Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor`
extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 |
| **Comfy-Org#19112** (this PR) | **`main`** | **`PositionConfig` and layer
editor dialog key to leaf modules** | **1027 -> 1027** | **983 -> 983**
| **4562 -> 4558** |
| Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf |
1027 -> 1025 | 983 -> 981 | 4562 -> 4552 |
| Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027
-> 1027 | 983 -> 983 | 4562 -> 4555 |
| Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027
-> 1027 | 983 -> 983 | 4562 -> 4561 |
| Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs |
1027 -> 1027 | 983 -> 983 | 4562 -> 4561 |

All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet):
630 cyclic modules, largest cycle 412, 2476 cyclic edges.

### Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR
stack, each PR against its parent at the time, on the older `main` the
stack forked from (967 cyclic modules then). They have not been
remeasured since the eight PRs above left the stack. Where the base
changed, the parent the numbers were measured on is in parentheses.

Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of
the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and
Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is
rebased.

| PR | Base | Change | Cyclic modules | Largest cycle |
| --- | --- | --- | --- | --- |
| Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) |
967 (baseline) | 923 (baseline) |
| Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types |
967 -> 949 | 923 -> 905 |
| Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs
outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 |
| Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not
`extensionService` | 669 -> 580 | 465 -> 371 |
| Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers
| 580 -> 566 | 371 -> 357 |
| Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from
the app shell | 558 -> 509 | 349 -> 297 |
| Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell |
509 -> 496 | 297 -> 284 |
| Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs
from GraphView | 484 -> 476 | 272 -> 264 |
| Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser
routing onto the sidebar tab | 471 -> 467 | 257 -> 253 |
| Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467
-> 464 | 253 -> 250 |
| Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 ->
447 | 250 -> 233 |
| Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` |
447 -> 428 | 233 -> 214 |
| Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of
`dialogService` | 400 -> 391 | 181 -> 172 |
| Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352
| 172 -> 149 |
| Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the
facade | 352 -> 324 | 149 (baseline) |
| Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow
contracts as leaves | 324 -> 293 | 149 (baseline) |
| Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto
`useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) |
| Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth
dialogs, menu, and more | 259 -> 211 | 149 (baseline) |
<!-- stack-table:end -->

---------

Co-authored-by: Amp <amp@ampcode.com>
@DrJKL
DrJKL restored the drjkl/depcruise-no-circular branch October 8, 2026 04:39
@DrJKL
DrJKL deleted the drjkl/depcruise-no-circular branch October 8, 2026 04:39
laurigates pushed a commit to laurigates/ComfyUI_frontend that referenced this pull request Oct 8, 2026
…Org#19108)

## Summary

Stacked on Comfy-Org#19107, in a chain rooted on `main` (Comfy-Org#19091 -> Comfy-Org#19107 ->
Comfy-Org#19108). Tracks FE-2769 / FE-3037.

`useAssetBrowserDialog` imported `AssetBrowserModal.vue` so it could
open it. The modal pulls in the asset grid, model info panel, upload
flow, and their stores, and those in turn reach the dialog composable
through `createAssetWidget` and `openModelLibraryBrowser`. That one edge
kept 13 asset-browser modules inside the main import cycle.

Same registration pattern as Comfy-Org#19091 and Comfy-Org#19107: the composable opens
whatever component the app shell registers.

Import cycles, measured with dependency-cruiser on `src` (the `pnpm
lint:cycles` script arrives with Comfy-Org#19085) against Comfy-Org#19107's branch: cyclic
modules 772 -> 759, largest cycle 719 -> 706, cyclic edges 3541 -> 3499.

## Changes

- `useAssetBrowserDialog.ts`: drop the `AssetBrowserModal.vue` import;
add `registerAssetBrowserModalComponent(component:
Component<AssetBrowserModalProps>)`; `show()`/`browse()` route through
one `openModal()` that calls `reportError`
(`failure_opening_asset_browser_modal`) and opens nothing if no
component is registered.
- `src/platform/assets/types/assetBrowserModalProps.ts`: new leaf
holding the modal's props interface; `AssetBrowserModal.vue` uses
`defineProps<AssetBrowserModalProps>()`.
- `GraphView.vue`: registers `AssetBrowserModal` next to the other core
registrations.
- `show()` no longer forwards `inputName`/`currentValue` to the modal.
The modal never declared them, so they only landed as fallthrough DOM
attributes. `ShowOptions` keeps the fields: `createAssetWidget` passes
them, filled from its `inputNameForBrowser` option that
`widgetInputs.ts` and `useComboWidget.ts` set. Dropping them means
changing those widget paths, which is left for a follow-up.
- Tests: `useAssetBrowserDialog.test.ts` registers a stub before each
test, types the dialog props with `AssetBrowserModalProps`, and asserts
in the `browse()` test that the stub is the component passed to the
dialog; `useAssetBrowserDialog.unregistered.test.ts` checks that
`browse()` with nothing registered reports
`failure_opening_asset_browser_modal` and opens no dialog;
`GraphView.test.ts` stubs the modal module.

## Review Focus

- The `AssetBrowserModal.stories.ts` and
`useAssetBrowserDialog.stories.ts` stories render the component
directly, so they need no registration.
- Callers are unchanged: `createAssetWidget.ts` and
`openModelLibraryBrowser.ts` call the composable, and `useCoreCommands`
reaches it through `openModelLibraryBrowser`. All of them open the
dialog from user actions, after `GraphView` setup has registered the
modal.

<!-- stack-table:start -->
## Stack

Import-cycle progress for FE-3037, measured with `pnpm lint:cycles`
(dependency-cruiser on `src`).

### Standalone PRs targeting `main`

Each is one commit on current `main` and can merge on its own. Numbers
are that PR alone against `origin/main` (1027 cyclic modules, largest
cycle 983, 4562 cyclic edges).

| PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges |
| --- | --- | --- | --- | --- | --- |
| Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 ->
884 | 983 -> 677 | 4562 -> 3382 |
| Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027
-> 1026 | 983 -> 982 | 4562 -> 4558 |
| Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor`
extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 |
| Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf
modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 |
| Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf |
1027 -> 1025 | 983 -> 981 | 4562 -> 4552 |
| Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027
-> 1027 | 983 -> 983 | 4562 -> 4555 |
| Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027
-> 1027 | 983 -> 983 | 4562 -> 4561 |
| Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs |
1027 -> 1027 | 983 -> 983 | 4562 -> 4561 |

All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet):
630 cyclic modules, largest cycle 412, 2476 cyclic edges.

### Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR
stack, each PR against its parent at the time, on the older `main` the
stack forked from (967 cyclic modules then). They have not been
remeasured since the eight PRs above left the stack. Where the base
changed, the parent the numbers were measured on is in parentheses.

Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of
the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and
Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is
rebased.

| PR | Base | Change | Cyclic modules | Largest cycle |
| --- | --- | --- | --- | --- |
| Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) |
967 (baseline) | 923 (baseline) |
| Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types |
967 -> 949 | 923 -> 905 |
| Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs
outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 |
| Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not
`extensionService` | 669 -> 580 | 465 -> 371 |
| Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers
| 580 -> 566 | 371 -> 357 |
| Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from
the app shell | 558 -> 509 | 349 -> 297 |
| **Comfy-Org#19108** (this PR) | **Comfy-Org#19107** | **Register asset browser modal
from the app shell** | **509 -> 496** | **297 -> 284** |
| Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs
from GraphView | 484 -> 476 | 272 -> 264 |
| Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser
routing onto the sidebar tab | 471 -> 467 | 257 -> 253 |
| Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467
-> 464 | 253 -> 250 |
| Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 ->
447 | 250 -> 233 |
| Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` |
447 -> 428 | 233 -> 214 |
| Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of
`dialogService` | 400 -> 391 | 181 -> 172 |
| Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352
| 172 -> 149 |
| Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the
facade | 352 -> 324 | 149 (baseline) |
| Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow
contracts as leaves | 324 -> 293 | 149 (baseline) |
| Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto
`useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) |
| Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth
dialogs, menu, and more | 259 -> 211 | 149 (baseline) |
<!-- stack-table:end -->

---------

Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: AustinMroz <austin@comfy.org>
laurigates pushed a commit to laurigates/ComfyUI_frontend that referenced this pull request Oct 8, 2026
…9111)

## Summary

Stacked on Comfy-Org#19108, in a chain rooted on `main` (Comfy-Org#19091 -> Comfy-Org#19107 ->
Comfy-Org#19108 -> Comfy-Org#19111). In the original stack it sat on Comfy-Org#19109. Tracks
FE-2769 / FE-3037.

Cuts `stores/workspace/bottomPanelStore.ts ->
composables/bottomPanelTabs/{useShortcutsTab,useTerminalTabs}.ts`. The
store imported the tab composables only to register the core tabs, which
pulled the shortcuts and terminal panel components into the stores
import cycle. Measured with dependency-cruiser on `src` (the `pnpm
lint:cycles` script arrives with Comfy-Org#19085) against Comfy-Org#19108's branch: cyclic
modules 759 -> 751, largest cycle 706 -> 698, cyclic edges 3499 -> 3480.
Frees 8 modules (`composables/bottomPanelTabs/*`,
`components/bottomPanel/tabs/*`).

## Changes

- New `composables/bottomPanelTabs/registerCoreBottomPanelTabs.ts` holds
the former store action (shortcuts tabs, then lazily loaded terminal
tabs outside cloud, command terminal on desktop). Same shape as
`registerCoreSidebarTabs` from Comfy-Org#19091. One behaviour change: a terminal
tab load failure now goes through `reportError` (`errorType:
'error_loading_terminal_tabs'`, `surface: 'platform'`) instead of
`console.error`, so it reaches telemetry; `reportError` still logs to
the console.
- `bottomPanelStore` drops `registerCoreBottomPanelTabs` and its
`isDesktop`/`useShortcutsTab` imports; `GraphView.vue` calls the new
function at startup, and `GraphView.test.ts` mocks the new module
instead of the store action.
- The tab-composable and `isDesktop` mocks in `bottomPanelStore.test.ts`
were left over from the action (no test there called it), so they move
to `registerCoreBottomPanelTabs.test.ts`. That file adds coverage the
action did not have: the registered tab ids per panel for a local build
with and without desktop and for a cloud build (no terminal tabs), and
the failure path (shortcuts tabs kept, no terminal tabs, one
`reportError` call with the error type above).

## Review Focus

- `registerCoreBottomPanelTabs` was a store action, so it was reachable
as `app.extensionManager.bottomPanel.registerCoreBottomPanelTabs()`. No
caller in `src/`, `browser_tests/`, or the public extension types uses
it; `registerBottomPanelTab` and `registerExtensionBottomPanelTabs` stay
on the store.
- The file sits in the frozen `src/composables/` tree next to the tab
composables it registers, matching `registerCoreSidebarTabs`; the
pre-commit hook warns but allows it.

<!-- stack-table:start -->
## Stack

Import-cycle progress for FE-3037, measured with `pnpm lint:cycles`
(dependency-cruiser on `src`).

### Standalone PRs targeting `main`

Each is one commit on current `main` and can merge on its own. Numbers
are that PR alone against `origin/main` (1027 cyclic modules, largest
cycle 983, 4562 cyclic edges).

| PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges |
| --- | --- | --- | --- | --- | --- |
| Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 ->
884 | 983 -> 677 | 4562 -> 3382 |
| Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027
-> 1026 | 983 -> 982 | 4562 -> 4558 |
| Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor`
extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 |
| Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf
modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 |
| Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf |
1027 -> 1025 | 983 -> 981 | 4562 -> 4552 |
| Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027
-> 1027 | 983 -> 983 | 4562 -> 4555 |
| Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027
-> 1027 | 983 -> 983 | 4562 -> 4561 |
| Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs |
1027 -> 1027 | 983 -> 983 | 4562 -> 4561 |

All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet):
630 cyclic modules, largest cycle 412, 2476 cyclic edges.

### Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR
stack, each PR against its parent at the time, on the older `main` the
stack forked from (967 cyclic modules then). They have not been
remeasured since the eight PRs above left the stack. Where the base
changed, the parent the numbers were measured on is in parentheses.

Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of
the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and
Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is
rebased.

| PR | Base | Change | Cyclic modules | Largest cycle |
| --- | --- | --- | --- | --- |
| Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) |
967 (baseline) | 923 (baseline) |
| Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types |
967 -> 949 | 923 -> 905 |
| Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs
outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 |
| Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not
`extensionService` | 669 -> 580 | 465 -> 371 |
| Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers
| 580 -> 566 | 371 -> 357 |
| Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from
the app shell | 558 -> 509 | 349 -> 297 |
| Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell |
509 -> 496 | 297 -> 284 |
| **Comfy-Org#19111** (this PR) | **Comfy-Org#19108 (measured on Comfy-Org#19109)** | **Register
core bottom panel tabs from GraphView** | **484 -> 476** | **272 ->
264** |
| Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser
routing onto the sidebar tab | 471 -> 467 | 257 -> 253 |
| Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467
-> 464 | 253 -> 250 |
| Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 ->
447 | 250 -> 233 |
| Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` |
447 -> 428 | 233 -> 214 |
| Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of
`dialogService` | 400 -> 391 | 181 -> 172 |
| Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352
| 172 -> 149 |
| Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the
facade | 352 -> 324 | 149 (baseline) |
| Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow
contracts as leaves | 324 -> 293 | 149 (baseline) |
| Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto
`useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) |
| Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth
dialogs, menu, and more | 259 -> 211 | 149 (baseline) |
<!-- stack-table:end -->

---------

Co-authored-by: Amp <amp@ampcode.com>
laurigates pushed a commit to laurigates/ComfyUI_frontend that referenced this pull request Oct 8, 2026
…sion (Comfy-Org#19109)

## Summary

Cuts `services/litegraphService.ts ->
composables/maskeditor/useMaskEditor.ts`, the edge that pulled the mask
editor composables and components into the services import cycle. Import
cycles in the original stack, on top of Comfy-Org#19108: 496 -> 484 cyclic
modules, largest SCC 284 -> 272; frees 12 modules
(`composables/maskeditor/*`, `components/maskeditor/*`). Alone on
current `main` the counts do not change (1027 cyclic modules, largest
SCC 983, 4562 cyclic edges).

Targets `main` directly; in the original stack it sat on Comfy-Org#19108. Tracks
FE-2769 / FE-3037.

## Changes

- `Comfy.MaskEditor` extension contributes the "Open in MaskEditor |
Image Canvas" node menu item from `beforeRegisterNodeDef`, wrapping
`nodeType.prototype.getExtraMenuOptions` (calls the existing handler,
keeps its return value, then pushes the item), with the same
`clipspace_return_node` and `isImageNode` guards and the same
`'preview'` media-action marking.
- `litegraphService.ts` drops the item and the `useMaskEditor` import.
- `maskeditor.test.ts` covers the guards, the callback target, the
preview marking, and chaining with an existing `getExtraMenuOptions`
handler.

## Review Focus

- Extension contract: the item stays in the `options` array that
`getExtraMenuOptions` fills, so custom nodes that wrap
`getExtraMenuOptions` and look the item up by label
(ComfyUI-prompt-formula, ComfyUI-PreviewBridgeExtended) keep working.
Core extensions register before custom ones, so `litegraphService`
installs the prototype handler, this wrapper runs next, and later
wrappers see the item. Menu position is unchanged in both the litegraph
and the Vue menu.
- Blueprint subgraph node classes (`litegraphService` creates them
without calling `beforeRegisterNodeDef`) do not get the item. Before,
they got it only with an image preview, which blueprints do not have.
- `filterUnavailableCoreMediaMenuActions` in `useMoreOptionsMenu` still
hides the item when the node has no preview, because the callback keeps
the `'preview'` mark.

<!-- stack-table:start -->
## Stack

Import-cycle progress for FE-3037, measured with `pnpm lint:cycles`
(dependency-cruiser on `src`).

### Standalone PRs targeting `main`

Each is one commit on current `main` and can merge on its own. Numbers
are that PR alone against `origin/main` (1027 cyclic modules, largest
cycle 983, 4562 cyclic edges).

| PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges |
| --- | --- | --- | --- | --- | --- |
| Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 ->
884 | 983 -> 677 | 4562 -> 3382 |
| Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027
-> 1026 | 983 -> 982 | 4562 -> 4558 |
| **Comfy-Org#19109** (this PR) | **`main`** | **Mask editor menu item into
`Comfy.MaskEditor` extension** | **1027 -> 1027** | **983 -> 983** |
**4562 -> 4562** |
| Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf
modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 |
| Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf |
1027 -> 1025 | 983 -> 981 | 4562 -> 4552 |
| Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027
-> 1027 | 983 -> 983 | 4562 -> 4555 |
| Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027
-> 1027 | 983 -> 983 | 4562 -> 4561 |
| Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs |
1027 -> 1027 | 983 -> 983 | 4562 -> 4561 |

All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet):
630 cyclic modules, largest cycle 412, 2476 cyclic edges.

### Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR
stack, each PR against its parent at the time, on the older `main` the
stack forked from (967 cyclic modules then). They have not been
remeasured since the eight PRs above left the stack. Where the base
changed, the parent the numbers were measured on is in parentheses.

Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of
the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and
Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is
rebased.

| PR | Base | Change | Cyclic modules | Largest cycle |
| --- | --- | --- | --- | --- |
| Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) |
967 (baseline) | 923 (baseline) |
| Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types |
967 -> 949 | 923 -> 905 |
| Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs
outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 |
| Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not
`extensionService` | 669 -> 580 | 465 -> 371 |
| Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers
| 580 -> 566 | 371 -> 357 |
| Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from
the app shell | 558 -> 509 | 349 -> 297 |
| Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell |
509 -> 496 | 297 -> 284 |
| Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs
from GraphView | 484 -> 476 | 272 -> 264 |
| Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser
routing onto the sidebar tab | 471 -> 467 | 257 -> 253 |
| Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467
-> 464 | 253 -> 250 |
| Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 ->
447 | 250 -> 233 |
| Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` |
447 -> 428 | 233 -> 214 |
| Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of
`dialogService` | 400 -> 391 | 181 -> 172 |
| Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352
| 172 -> 149 |
| Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the
facade | 352 -> 324 | 149 (baseline) |
| Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow
contracts as leaves | 324 -> 293 | 149 (baseline) |
| Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto
`useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) |
| Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth
dialogs, menu, and more | 259 -> 211 | 149 (baseline) |
<!-- stack-table:end -->

---------

Co-authored-by: Amp <amp@ampcode.com>
laurigates pushed a commit to laurigates/ComfyUI_frontend that referenced this pull request Oct 8, 2026
…omfy-Org#19088)

## Summary

Second slice of FE-3037. `src/lib/litegraph/src/interfaces.ts` (589
lines) mixed geometry primitives, utility types, slot data, link-network
contracts, context-menu options, panel widgets, and node-creation
options. Its type imports of `LGraphNode`, `LLink`, `Reroute`,
`ContextMenu`, `Rectangle`, `types/widgets` and `types/events` put every
importer of `Point` or `ReadOnlyRect` into the largest import cycle.

This PR keeps `interfaces.ts` as a leaf (it now imports only branded IDs
from `src/types/*` and `types/globalEnums`) and moves the graph-bound
contracts into files named by responsibility.

Measured with dependency-cruiser on `src` (the Comfy-Org#19085 config, run
locally), rebased on `main` at 03bca8a: cyclic modules 660 -> 653,
largest SCC 444 (unchanged), cyclic edges 2577 -> 2520. Originally
cycle-free after this slice, before the merged slices above it moved the
numbers: `Rectangle`, `measure`, `ConstrainedSize`, `LGraphBadge`,
`LGraphButton`, `node/SlotBase`, `interfaces` inside litegraph;
`linkStore`, `rerouteStore`, `linkTopology`, `mathUtil`,
`positionBounds`, `nodeDefUtil`, `boundsCalculator`,
`marqueeSelectionUtil`, `useAssetGridSelection`, `useTimelineScrub`,
`gradients`, `GradientSlider.vue`, `NodeBadge.vue`, `GizmoManager`,
`load3dViewport` in the app.

Rebased onto `main` after Comfy-Org#19085 was closed in favour of Comfy-Org#20461
(warn-only `pnpm deps:audit`). Targets `main` directly; the rest of the
stack (Comfy-Org#19092 and up) is rebased on this branch.

Tracks FE-2769 / FE-3037.

## Changes

- `interfaces.ts`: leaf. Keeps `Point`, `Size`, `Rect`, `ReadOnlyRect`,
`Positionable`, `HasBoundingRect`, `INodeSlot`, `INodeFlags`,
`ISlotType`, `IWidgetLocator`, `LinkSegment`, `DefaultConnectionColors`,
colour and utility types. `LinkId`/`RerouteId` now come from
`@/types/linkId` and `@/types/rerouteId` instead of via
`LLink`/`Reroute`.
- `types/slots.ts`: `INodeInputSlot`, `INodeOutputSlot`,
`IWidgetInputSlot`, `ISubgraphInput`, `IFoundSlot`,
`INodeSlotContextItem`, `ConnectingLink`. `INodeInputSlot` cannot be a
leaf because `_widget?: IBaseWidget` references `types/widgets`, which
references `LGraphNode`/`LGraphCanvas`.
- `types/linkNetwork.ts`: `LinkNetwork`, `ReadonlyLinkNetwork`,
`ItemLocator`.
- `types/contextMenu.ts`: `IContextMenuOptions`, `IContextMenuValue`,
`ContextMenuDivElement`.
- `types/panel.ts`: `Panel*`.
- `CreateNodeOptions` -> `LiteGraphGlobal.ts`; `NewNodePosition`,
`IBoundaryNodes` -> `utils/arrange.ts`; `Hoverable` ->
`types/events.ts`.
- 94 files repointed (98 changed, 4 new), including
`node/widgetsView.ts`, `contextMenuFilter.ts`, and the agent CRDT files
added on `main` since the branch forked. Declarations moved verbatim.
The `litegraph.ts` barrel exports the same names, so the extension API
is unchanged.

## Review Focus

- `pnpm typecheck`, `oxlint --type-aware`, `eslint` (warnings only, same
as main), `pnpm knip`, `fallow audit`, litegraph and touched-area unit
tests (217 files) pass on the rebased head.
- `git diff -M --stat` is mostly import-line churn; the only new code is
import headers in the four new files.
- Rebase conflicts resolved by hand: `interfaces.ts` re-applies main's
`ISlotType = number | string | string[]` and `slot_index?: SlotIndex` on
`INodeSlot`; `types/slots.ts` carries main's `_pendingDemotionToken` on
`INodeInputSlot`; `types/panel.ts` carries main's widened
`PanelWidgetOptions.values`; `nodeDataStore.ts` is taken from main.
- Next slice: `types/widgets.ts` (657 lines) and the `simplifiedWidget`
two-cycle, which is what keeps `INodeInputSlot` and the ~26 widget
classes in the SCC.

<!-- stack-table:start -->
## Stack

Import-cycle progress for FE-3037, measured with `pnpm lint:cycles`
(dependency-cruiser on `src`).

### Standalone PRs targeting `main`

Each is one commit on current `main` and can merge on its own. Numbers
are that PR alone against `origin/main` (1027 cyclic modules, largest
cycle 983, 4562 cyclic edges).

| PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges |
| --- | --- | --- | --- | --- | --- |
| Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 ->
884 | 983 -> 677 | 4562 -> 3382 |
| Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027
-> 1026 | 983 -> 982 | 4562 -> 4558 |
| Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor`
extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 |
| Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf
modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 |
| Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf |
1027 -> 1025 | 983 -> 981 | 4562 -> 4552 |
| Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027
-> 1027 | 983 -> 983 | 4562 -> 4555 |
| Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027
-> 1027 | 983 -> 983 | 4562 -> 4561 |
| Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs |
1027 -> 1027 | 983 -> 983 | 4562 -> 4561 |

All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet):
630 cyclic modules, largest cycle 412, 2476 cyclic edges.

### Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR
stack, each PR against its parent at the time, on the older `main` the
stack forked from (967 cyclic modules then). They have not been
remeasured since the eight PRs above left the stack. Where the base
changed, the parent the numbers were measured on is in parentheses.

Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of
the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and
Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is
rebased.

| PR | Base | Change | Cyclic modules | Largest cycle |
| --- | --- | --- | --- | --- |
| Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) |
967 (baseline) | 923 (baseline) |
| **Comfy-Org#19088** (this PR) | **Comfy-Org#19085** | **Split litegraph `interfaces.ts`
into leaf types** | **967 -> 949** | **923 -> 905** |
| Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs
outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 |
| Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not
`extensionService` | 669 -> 580 | 465 -> 371 |
| Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers
| 580 -> 566 | 371 -> 357 |
| Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from
the app shell | 558 -> 509 | 349 -> 297 |
| Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell |
509 -> 496 | 297 -> 284 |
| Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs
from GraphView | 484 -> 476 | 272 -> 264 |
| Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser
routing onto the sidebar tab | 471 -> 467 | 257 -> 253 |
| Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467
-> 464 | 253 -> 250 |
| Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 ->
447 | 250 -> 233 |
| Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` |
447 -> 428 | 233 -> 214 |
| Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of
`dialogService` | 400 -> 391 | 181 -> 172 |
| Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352
| 172 -> 149 |
| Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the
facade | 352 -> 324 | 149 (baseline) |
| Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow
contracts as leaves | 324 -> 293 | 149 (baseline) |
| Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto
`useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) |
| Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth
dialogs, menu, and more | 259 -> 211 | 149 (baseline) |
<!-- stack-table:end -->

---------

Co-authored-by: Amp <amp@ampcode.com>
AkiEvansDev pushed a commit to AkiEvansDev/ComfyUI-Frontend that referenced this pull request Oct 8, 2026
…ab (Comfy-Org#19113)

## Summary

Stacked on Comfy-Org#19111, in a chain rooted on `main` (Comfy-Org#19091 -> Comfy-Org#19107 ->
Comfy-Org#19108 -> Comfy-Org#19111 -> Comfy-Org#19113). In the original stack it sat on Comfy-Org#19112.
Tracks FE-2769 / FE-3037.

`sidebarTabStore` hard-coded the model-library tab: when
`Comfy.ModelLibrary.UseAssetBrowser` and the `assetsEnabled` flag were
set, its toggle command opened the asset browser instead of the sidebar.
That single tab pulled `openModelLibraryBrowser`, `useFeatureFlags`, and
`settingStore` into the store and into the stores/scripts import cycle.

Import cycles, measured with dependency-cruiser on `src` (the `pnpm
lint:cycles` script arrives with Comfy-Org#19085) against Comfy-Org#19111's branch: cyclic
modules 751 -> 747, largest cycle 698 -> 694, cyclic edges 3480 -> 3460.

## Changes

- `SidebarTabExtension` gains an optional `onToggle?: () => boolean |
Promise<boolean>` hook. The toggle command calls it first and only
toggles the sidebar when the hook returns false or is absent.
- `useModelLibrarySidebarTab` sets `onToggle` with the asset browser
routing that used to live in the store.
- `sidebarTabStore` loses the tab-id special case and its three imports.
- Tests: the model-library cases move to
`useModelLibrarySidebarTab.test.ts`; `sidebarTabStore.test.ts` covers
the hook contract (absent, declines, handles) as a table.

## Review Focus

- `onToggle` is new public API: `SidebarTabExtension` is exported from
`src/types`, so the field ships in the published types package.
Extensions that register a sidebar tab can now intercept the toggle by
returning true; nothing else changes for them.
- The routing now belongs to the core tab object, not to the
`model-library` id. A tab registered under that id by anything other
than `useModelLibrarySidebarTab` no longer opens the asset browser.
- The tab and its `Workspace.ToggleSidebarTab.model-library` command
keep their ids, so the keybinding default is unaffected.
`missingModelDownload` sets `activeSidebarTabId` directly and never ran
the toggle command, so it opens the sidebar tree as before.

<!-- stack-table:start -->
## Stack

Import-cycle progress for FE-3037, measured with `pnpm lint:cycles`
(dependency-cruiser on `src`).

### Standalone PRs targeting `main`

Each is one commit on current `main` and can merge on its own. Numbers
are that PR alone against `origin/main` (1027 cyclic modules, largest
cycle 983, 4562 cyclic edges).

| PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges |
| --- | --- | --- | --- | --- | --- |
| Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 ->
884 | 983 -> 677 | 4562 -> 3382 |
| Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027
-> 1026 | 983 -> 982 | 4562 -> 4558 |
| Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor`
extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 |
| Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf
modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 |
| Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf |
1027 -> 1025 | 983 -> 981 | 4562 -> 4552 |
| Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027
-> 1027 | 983 -> 983 | 4562 -> 4555 |
| Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027
-> 1027 | 983 -> 983 | 4562 -> 4561 |
| Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs |
1027 -> 1027 | 983 -> 983 | 4562 -> 4561 |

All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet):
630 cyclic modules, largest cycle 412, 2476 cyclic edges.

### Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR
stack, each PR against its parent at the time, on the older `main` the
stack forked from (967 cyclic modules then). They have not been
remeasured since the eight PRs above left the stack. Where the base
changed, the parent the numbers were measured on is in parentheses.

Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of
the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and
Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is
rebased.

| PR | Base | Change | Cyclic modules | Largest cycle |
| --- | --- | --- | --- | --- |
| Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) |
967 (baseline) | 923 (baseline) |
| Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types |
967 -> 949 | 923 -> 905 |
| Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs
outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 |
| Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not
`extensionService` | 669 -> 580 | 465 -> 371 |
| Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers
| 580 -> 566 | 371 -> 357 |
| Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from
the app shell | 558 -> 509 | 349 -> 297 |
| Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell |
509 -> 496 | 297 -> 284 |
| Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs
from GraphView | 484 -> 476 | 272 -> 264 |
| **Comfy-Org#19113** (this PR) | **Comfy-Org#19111 (measured on Comfy-Org#19112)** | **Model
library asset-browser routing onto the sidebar tab** | **471 -> 467** |
**257 -> 253** |
| Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467
-> 464 | 253 -> 250 |
| Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 ->
447 | 250 -> 233 |
| Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` |
447 -> 428 | 233 -> 214 |
| Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of
`dialogService` | 400 -> 391 | 181 -> 172 |
| Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352
| 172 -> 149 |
| Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the
facade | 352 -> 324 | 149 (baseline) |
| Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow
contracts as leaves | 324 -> 293 | 149 (baseline) |
| Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto
`useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) |
| Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth
dialogs, menu, and more | 259 -> 211 | 149 (baseline) |
<!-- stack-table:end -->

---------

Co-authored-by: Amp <amp@ampcode.com>
Penguinjanator pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Oct 9, 2026
…ce (Comfy-Org#19092)

## Summary

Targets `main` (Comfy-Org#19088, Comfy-Org#19089 and Comfy-Org#19091 merged; rebased onto `main` at
0ef0276). Moves `loadExtensions` out of `extensionService` into
`src/services/extensionLoader.ts`, called from `GraphCanvas.vue` before
`app.setup()`.

`extensionService` imported `extensions/core/index` so `loadExtensions`
could pull the core extensions in. Every core extension imports `app`,
which imports `extensionService`, so the whole `extensions/core` tree
and the UI it reaches (load3d, mask editor, painter, image compare,
agent panel, ...) sat in the same import cycle as the app object.
`GraphCanvas.vue` already owns the bootstrap sequence and is outside the
cycle, so it is the right owner of the "load extensions" step.

Measured with dependency-cruiser on `src` (the Comfy-Org#19085 config, run
locally), against `main` at 0ef0276:

| | before | after |
| --- | --- | --- |
| modules in any cycle | 631 | 500 |
| largest cycle | 421 | 285 |
| cyclic edges | 2451 | 2034 |

Tracks FE-2769 / FE-3037.

## Changes

- New `src/services/extensionLoader.ts` with `loadExtensions()`,
`shouldLoadExtension()`, `importCustomExtension()` and
`reportExtensionLoadFailures()` (moved verbatim from `main`, including
the `extensions-load-core` / `extensions-load-custom` subphases from
Comfy-Org#19888 and the aggregate failure report). `extensionService.test.ts`
becomes `extensionLoader.test.ts`.
- `extensionService` drops `loadExtensions` and its `api`,
`bootstrapTracer`, `reportError` and `getErrorMessage` imports; it keeps
`registerExtension`, `invokeExtensions`, `invokeExtensionsAsync`.
- Comfy-Org#19730 (subphase timings, previously merged into this branch) is
dropped from the branch because `main` carries the same instrumentation
via Comfy-Org#19888.
- `GraphCanvas.vue` runs
`bootstrapTracer.settle('bootstrap/extensions-load', loadExtensions)`
right before `comfyApp.setup()`. `app.setup()` no longer loads
extensions.
- `GraphCanvas.test.ts` mocks the loader; `SelectionToolbox.test.ts`
drops `loadExtensions` from its service mock.
- `browser_tests/types/globals.d.ts` imports `@/types` explicitly. The
browser typecheck (`lint-pr / typecheck-aux`) only reached the app's
`Window` augmentation through `app -> extensionService ->
extensions/core`, and that path is gone.

## Review Focus

- Ordering change: extension modules now import before `app.setup()`
runs `syncWorkflows()` and `fetchSubgraphs()` and before
`bodyTop`/`canvasContainer`/`canvasElRef` are assigned, instead of
after. Extension hooks (`init`, `setup`, `registerCustomNodes`,
`addCustomNodeDefs`) still run inside `app.setup()` exactly as before,
so an extension only notices if it reads those at module top level.
Nothing in `extensions/core` does.
- The `bootstrap/extensions-load` tracer phase keeps its name and
position between `workflows` and `extensions-init`.
- `src/services/` is a frozen directory per the pre-commit hook; the
loader sits next to `extensionService`, which it was split from.

<!-- stack-table:start -->
## Stack

Import-cycle progress for FE-3037, measured with `pnpm lint:cycles`
(dependency-cruiser on `src`).

### Standalone PRs targeting `main`

Each is one commit on current `main` and can merge on its own. Numbers
are that PR alone against `origin/main` (1027 cyclic modules, largest
cycle 983, 4562 cyclic edges).

| PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges |
| --- | --- | --- | --- | --- | --- |
| Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 ->
884 | 983 -> 677 | 4562 -> 3382 |
| Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027
-> 1026 | 983 -> 982 | 4562 -> 4558 |
| Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor`
extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 |
| Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf
modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 |
| Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf |
1027 -> 1025 | 983 -> 981 | 4562 -> 4552 |
| Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027
-> 1027 | 983 -> 983 | 4562 -> 4555 |
| Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027
-> 1027 | 983 -> 983 | 4562 -> 4561 |
| Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs |
1027 -> 1027 | 983 -> 983 | 4562 -> 4561 |

All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet):
630 cyclic modules, largest cycle 412, 2476 cyclic edges.

### Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR
stack, each PR against its parent at the time, on the older `main` the
stack forked from (967 cyclic modules then). They have not been
remeasured since the eight PRs above left the stack. Where the base
changed, the parent the numbers were measured on is in parentheses.

Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of
the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and
Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is
rebased.

| PR | Base | Change | Cyclic modules | Largest cycle |
| --- | --- | --- | --- | --- |
| Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) |
967 (baseline) | 923 (baseline) |
| Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types |
967 -> 949 | 923 -> 905 |
| Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs
outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 |
| **Comfy-Org#19092** (this PR) | **Comfy-Org#19091** | **Load extensions from bootstrap,
not `extensionService`** | **669 -> 580** | **465 -> 371** |
| Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers
| 580 -> 566 | 371 -> 357 |
| Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from
the app shell | 558 -> 509 | 349 -> 297 |
| Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell |
509 -> 496 | 297 -> 284 |
| Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs
from GraphView | 484 -> 476 | 272 -> 264 |
| Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser
routing onto the sidebar tab | 471 -> 467 | 257 -> 253 |
| Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467
-> 464 | 253 -> 250 |
| Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 ->
447 | 250 -> 233 |
| Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` |
447 -> 428 | 233 -> 214 |
| Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of
`dialogService` | 400 -> 391 | 181 -> 172 |
| Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352
| 172 -> 149 |
| Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the
facade | 352 -> 324 | 149 (baseline) |
| Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow
contracts as leaves | 324 -> 293 | 149 (baseline) |
| Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto
`useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) |
| Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth
dialogs, menu, and more | 259 -> 211 | 149 (baseline) |
<!-- stack-table:end -->

Co-authored-by: Amp <amp@ampcode.com>
christian-byrne pushed a commit to christian-byrne/ComfyUI_frontend that referenced this pull request Oct 10, 2026
…fy-Org#19118)

## Summary

Re-implemented on current `main` (the original commit no longer applied
after `api.ts` gained `authCredential`, the web-session fetch and
unified remint). Now targets `main` directly. Tracks FE-2769 / FE-3037.

`ComfyApi` reached into the auth layer itself: it lazily imported
`authStore` for the Firebase header and WebSocket token, and imported
`remintRetry` for the 401 re-mint fetch. Both pull the cloud auth graph
(workspace store, session cookie, feature flags, SSO dialogs) into
`api.ts`, the most imported module in `src/`. The client now takes an
`ApiAuthProvider`; the cloud provider is installed from `main.ts`.

Import cycles (dependency-cruiser on `src`, against `main` at
18a9c42): 511 -> 457 cyclic modules, largest SCC 296 -> 232, cyclic
edges 2121 -> 1811 (15 -> 17 cycles: the big SCC splits).

## Changes

- `src/platform/auth/apiAuthProvider.ts` (leaf): `ApiAuthProvider`
interface (`waitForInitialization`, `getAuthHeader`, `getAuthToken`,
`shouldRetryOn401`, `fetch`), `RetrySignalLifecycle`, and
`anonymousApiAuthProvider` (no header, no token, no retry, plain
`fetch`).
- `src/platform/auth/cloudApiAuthProvider.ts`: the moved token logic
(auth-store wait bounded by `AUTH_INIT_TIMEOUT_MS` from
`@/scripts/apiTimeouts`, header/token lookup with the same
`console.warn` fallbacks, WebSocket token telemetry,
`shouldRemintCloudRequest`, `fetchWithUnifiedRemint`).
`installCloudApiAuth()` sets it on `api`.
- `api.ts`: `setAuthProvider`; `addCloudAuthHeader`, `addSocketAuth` and
the token-path `fetch` delegate to the provider. No more `authStore` or
`remintRetry` imports. The web-session path (`webSessionRequests`,
`scopeMediaRoute`), `authCredentialOf` / `notifyAuthCredential`
reporting and the `isCloud` gates stay where they are: those modules are
leaves.
- `main.ts`: `installCloudApiAuth()` in the existing `isCloud` block,
before any request.
- `remintRetry.ts` imports `RetrySignalLifecycle` from the leaf instead
of declaring it.
- Second commit: `ToastAction` / `ToastOptions` move from
`types/extensionTypes.ts` to a new leaf `types/toastOptions.ts`
(`extensionTypes` re-exports them, so `@/types` is unchanged). Comfy-Org#16313
made `api.ts` import `components/ui/toast/toastStore`, which took these
types from `extensionTypes`, and `extensionTypes` reaches
`workflowStore`, `dialogService` and `commandStore` through type
imports. Without this move the provider split leaves `api.ts` inside the
application SCC and the numbers above do not change at all.
- Tests: cloud integration suites (`api.fetchApi`, `api.socketReset`,
`webSessionFlagOff`, `webSessionFlagOn`, `nonWebClientsStayOnTokens`)
call `installCloudApiAuth()` where they previously relied on the lazy
import; the localhost row installs the anonymous provider, as a local
build does. New `it.for` table in `api.fetchApi.test.ts` checks the
header is applied, the retry decision is consulted only for
authenticated requests, and the request goes through the provider's
`fetch`.

## Review Focus

- Install ordering. Requests made before `installCloudApiAuth()` are
anonymous. `main.ts` installs it first thing in the cloud block;
`refreshRemoteConfig({ useAuth: false })` uses bare `fetch`, so nothing
earlier needs credentials.
- Difference from the first version of this PR: `fetchApi` and
`createSocket` keep their `isCloud` gates. On `main` the web session is
switched on by a server feature flag, not by distribution, so dropping
the gate could route a local build's requests through the session.
Keeping it also leaves the local `createSocket` path synchronous, so
`api.featureFlags.test.ts` needs no change.
- Behavior moved, not changed: same timeout, warnings, and telemetry
event for a missing WebSocket token. The telemetry import in the
provider is static; `api.ts` already imported `useTelemetry` statically,
so the old dynamic import saved nothing.

<!-- stack-table:start -->
## Stack

Import-cycle progress for FE-3037, measured with `pnpm lint:cycles`
(dependency-cruiser on `src`).

### Standalone PRs targeting `main`

Each is one commit on current `main` and can merge on its own. Numbers
are that PR alone against `origin/main` (1027 cyclic modules, largest
cycle 983, 4562 cyclic edges).

| PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges |
| --- | --- | --- | --- | --- | --- |
| Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 ->
884 | 983 -> 677 | 4562 -> 3382 |
| Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027
-> 1026 | 983 -> 982 | 4562 -> 4558 |
| Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor`
extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 |
| Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf
modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 |
| Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf |
1027 -> 1025 | 983 -> 981 | 4562 -> 4552 |
| Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027
-> 1027 | 983 -> 983 | 4562 -> 4555 |
| Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027
-> 1027 | 983 -> 983 | 4562 -> 4561 |
| Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs |
1027 -> 1027 | 983 -> 983 | 4562 -> 4561 |

All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet):
630 cyclic modules, largest cycle 412, 2476 cyclic edges.

### Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR
stack, each PR against its parent at the time, on the older `main` the
stack forked from (967 cyclic modules then). They have not been
remeasured since the eight PRs above left the stack. Where the base
changed, the parent the numbers were measured on is in parentheses.

Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of
the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and
Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is
rebased.

| PR | Base | Change | Cyclic modules | Largest cycle |
| --- | --- | --- | --- | --- |
| Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) |
967 (baseline) | 923 (baseline) |
| Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types |
967 -> 949 | 923 -> 905 |
| Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs
outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 |
| Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not
`extensionService` | 669 -> 580 | 465 -> 371 |
| Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers
| 580 -> 566 | 371 -> 357 |
| Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from
the app shell | 558 -> 509 | 349 -> 297 |
| Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell |
509 -> 496 | 297 -> 284 |
| Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs
from GraphView | 484 -> 476 | 272 -> 264 |
| Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser
routing onto the sidebar tab | 471 -> 467 | 257 -> 253 |
| Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467
-> 464 | 253 -> 250 |
| **Comfy-Org#19118** (this PR) | **Comfy-Org#19116** | **Inject the api auth provider
from `main.ts`** | **464 -> 447** | **250 -> 233** |
| Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` |
447 -> 428 | 233 -> 214 |
| Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of
`dialogService` | 400 -> 391 | 181 -> 172 |
| Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352
| 172 -> 149 |
| Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the
facade | 352 -> 324 | 149 (baseline) |
| Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow
contracts as leaves | 324 -> 293 | 149 (baseline) |
| Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto
`useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) |
| Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth
dialogs, menu, and more | 259 -> 211 | 149 (baseline) |
<!-- stack-table:end -->
christian-byrne pushed a commit to christian-byrne/ComfyUI_frontend that referenced this pull request Oct 10, 2026
… of scripts/widgets (Comfy-Org#19093)

## Summary

Targets `main` (Comfy-Org#19092 merged). Splits `src/scripts/widgets.ts` into the
`ComfyWidgets` registry, a leaf type module, and the
control_after_generate helpers.

`widgets.ts` imported all 22 widget composables to build the registry,
and every composable imported `ComfyWidgetConstructorV2` from
`widgets.ts`. That type edge put the whole
`vueNodes/widgets/composables` tree into the app import cycle even
though the type only needs `LGraphNode`, `InputSpec` and `IBaseWidget`.

Measured with dependency-cruiser on `src` (the Comfy-Org#19085 config, run
locally), against `main` at 18a9c42:

| | before | after |
| --- | --- | --- |
| modules in any cycle | 511 | 496 |
| largest cycle | 296 | 281 |
| cyclic edges | 2121 | 2085 |

Tracks FE-2769 / FE-3037.

## Changes

- New `src/types/widgetConstructor.ts` with `ComfyWidgetConstructorV2`.
The 22 composables and `widgets.ts` import it from there.
`ComfyWidgetConstructor` (V1) and `CustomComfyWidgetConstructor` stay in
`widgets.ts` because they take `ComfyApp`.
- New `src/core/graph/widgets/valueControlWidgets.ts` with
`addValueControlWidget`, `addValueControlWidgets`,
`updateControlWidgetLabel` and their private helpers, moved verbatim
from current `main` (including `controlAfterGenerateNameOverride` and
the `isValueControlMode` handling added since the branch forked).
`useIntWidget`, `useFloatWidget`, `useComboWidget`, `widgetInputs.ts`
and `GraphCanvas.vue` import from it.
`widgets.controlAfterGenerateName.test.ts` moves with them as
`valueControlWidgets.controlAfterGenerateName.test.ts`.
- `useLightInfoWidget.ts` (added on `main` since the original PR)
imports `ComfyWidgetConstructorV2` from `@/types/widgetConstructor` like
the other composables.
- `widgets.ts` no longer re-exports `IS_CONTROL_WIDGET`;
`GraphCanvas.vue` imports it from
`core/graph/widgets/controlWidgetMarker`.
- `valueControl.ts`, `controlWidgetMarker.ts` and
`promotedWidgetControl.ts` move out of `scripts/` into
`core/graph/widgets` and `core/graph/subgraph`; `health.json` follows
`valueControl.ts`.
- `widgets.ts` keeps `export const` declarations of the three
value-control helpers because `comfyAPIPlugin` only exposes declarations
through the `scripts/widgets.js` shim that custom nodes import
(`.fallowrc.jsonc` lists them as public,
`build/plugins/comfyAPIPlugin.test.ts` asserts them).
`useComboWidget.test.ts` mocks all three, since the shim reads them at
module load.
- `useIntWidget.test.ts` and `useFloatWidget.test.ts` add
`vi.mock(import('@/scripts/app'))` (the repo's manual mock). Their old
`vi.mock('@/scripts/widgets')` had also been preventing the registry
from evaluating; with the registry no longer mocked, the pre-existing
`settingStore -> app -> extensionService -> widgetStore -> widgets`
runtime cycle reached `useIntWidget()` before its definition. Production
import order is unaffected: `app.ts` is entered first there, as before.

## Review Focus

- `valueControlWidgets.ts` stays in the cycle (it needs
`useSettingStore`); it did not go into `valueControl.ts` because that
would have pulled `valueControl.ts` and `promotedWidgetControl.ts` into
the cycle too.
- The 7 composables still in the cycle (`useComboWidget`,
`useIntWidget`, `useFloatWidget`, `useImageUploadWidget`, ...) reach it
through `settingStore`, `assetService` or node output stores, not
through `widgets.ts`.
- `src/types/` was chosen for the type because `simplifiedWidget.ts` and
`widgetState.ts` already live there as widget leaf types.

<!-- stack-table:start -->
## Stack

Import-cycle progress for FE-3037, measured with `pnpm lint:cycles`
(dependency-cruiser on `src`).

### Standalone PRs targeting `main`

Each is one commit on current `main` and can merge on its own. Numbers
are that PR alone against `origin/main` (1027 cyclic modules, largest
cycle 983, 4562 cyclic edges).

| PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges |
| --- | --- | --- | --- | --- | --- |
| Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 ->
884 | 983 -> 677 | 4562 -> 3382 |
| Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027
-> 1026 | 983 -> 982 | 4562 -> 4558 |
| Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor`
extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 |
| Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf
modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 |
| Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf |
1027 -> 1025 | 983 -> 981 | 4562 -> 4552 |
| Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027
-> 1027 | 983 -> 983 | 4562 -> 4555 |
| Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027
-> 1027 | 983 -> 983 | 4562 -> 4561 |
| Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs |
1027 -> 1027 | 983 -> 983 | 4562 -> 4561 |

All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet):
630 cyclic modules, largest cycle 412, 2476 cyclic edges.

### Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR
stack, each PR against its parent at the time, on the older `main` the
stack forked from (967 cyclic modules then). They have not been
remeasured since the eight PRs above left the stack. Where the base
changed, the parent the numbers were measured on is in parentheses.

Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of
the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and
Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is
rebased.

| PR | Base | Change | Cyclic modules | Largest cycle |
| --- | --- | --- | --- | --- |
| Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) |
967 (baseline) | 923 (baseline) |
| Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types |
967 -> 949 | 923 -> 905 |
| Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs
outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 |
| Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not
`extensionService` | 669 -> 580 | 465 -> 371 |
| **Comfy-Org#19093** (this PR) | **Comfy-Org#19092** | **Split `scripts/widgets.ts`
registry, types, helpers** | **580 -> 566** | **371 -> 357** |
| Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from
the app shell | 558 -> 509 | 349 -> 297 |
| Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell |
509 -> 496 | 297 -> 284 |
| Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs
from GraphView | 484 -> 476 | 272 -> 264 |
| Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser
routing onto the sidebar tab | 471 -> 467 | 257 -> 253 |
| Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467
-> 464 | 253 -> 250 |
| Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 ->
447 | 250 -> 233 |
| Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` |
447 -> 428 | 233 -> 214 |
| Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of
`dialogService` | 400 -> 391 | 181 -> 172 |
| Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352
| 172 -> 149 |
| Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the
facade | 352 -> 324 | 149 (baseline) |
| Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow
contracts as leaves | 324 -> 293 | 149 (baseline) |
| Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto
`useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) |
| Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth
dialogs, menu, and more | 259 -> 211 | 149 (baseline) |
<!-- stack-table:end -->

---------

Co-authored-by: Amp <amp@ampcode.com>
christian-byrne pushed a commit to christian-byrne/ComfyUI_frontend that referenced this pull request Oct 10, 2026
…Comfy-Org#19121)

## Summary

Re-implemented on current `main` (the original commit no longer applied
after `workspaceApi` gained the web-session adapter path). Comfy-Org#19118 has
merged, so this is now one commit on `main`. Tracks FE-2769 / FE-3037.

`workspaceApi` imported `authStore` for its request headers and
`remintRetry` to attach the 401 re-mint interceptor at module load. Both
edges put the workspace billing SDK, capability composables, and
churnkey modules inside the auth cycle. The client now receives its
credentials through `setWorkspaceApiAuth`, wired from `main.ts`, the
same shape as Comfy-Org#19118.

Import cycles (dependency-cruiser on `src`, against `origin/main` at
b835c9d): 459 -> 439 cyclic modules, largest SCC 234 -> 214, cyclic
edges 1815 -> 1730.

## Changes

- `workspaceApi.ts`: module-private `WorkspaceApiAuth`
(`getWorkspaceAuthHeader`, `getFirebaseAuthHeader`,
`attachRetryInterceptor`) and exported `setWorkspaceApiAuth`, which
stores the auth and attaches the interceptor to the axios client.
`requestAuth` keeps its web-session adapter branch and falls back to the
installed workspace header; `acceptInvite` uses the installed Firebase
header. Calls that reach the token path before installation throw
`WorkspaceApiError('Workspace API auth is not installed', 401)`. No more
`authStore` or `remintRetry` imports; `capabilityRevision` still
attaches at module load because it has no auth dependency.
- New `workspaceApiAuth.ts`: `installWorkspaceApiAuth()` binds the
auth-store `*OrThrow` getters and `attachUnifiedRemintInterceptor`.
- `main.ts` calls `installWorkspaceApiAuth()` on every distribution,
right after the cloud block. It cannot share the `isCloud` gate with
`installCloudApiAuth()`: `authStore.getWorkspaceAuthToken` initializes
`teamWorkspaceStore` (and so calls `workspaceApi.list()`) for a
signed-in user on desktop/local too.
- `workspaceApi.test.ts` installs the auth once at module scope; the
store actions it stubs are the same ones the installer binds.
`webSessionFlagOn.test.ts` installs it next to `installCloudApiAuth()`
so the suite runs the production wiring.

## Review Focus

- The interceptor is attached in `setWorkspaceApiAuth`, so calling it
twice attaches two re-mint interceptors. `main.ts` calls it once; the
test files install once at module scope for the same reason.
- Unconfigured state only exists before `main.ts` runs. Previously a
header lookup in that window would have thrown `AuthStoreError`; it now
throws `WorkspaceApiError`. The web-session path never needed the auth
store and is unaffected.
- `WorkspaceApiAuth` is module-private; nothing outside
`workspaceApi.ts` names the type.

<!-- stack-table:start -->
## Stack

Import-cycle progress for FE-3037, measured with `pnpm lint:cycles`
(dependency-cruiser on `src`).

### Standalone PRs targeting `main`

Each is one commit on current `main` and can merge on its own. Numbers
are that PR alone against `origin/main` (1027 cyclic modules, largest
cycle 983, 4562 cyclic edges).

| PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges |
| --- | --- | --- | --- | --- | --- |
| Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 ->
884 | 983 -> 677 | 4562 -> 3382 |
| Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027
-> 1026 | 983 -> 982 | 4562 -> 4558 |
| Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor`
extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 |
| Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf
modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 |
| Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf |
1027 -> 1025 | 983 -> 981 | 4562 -> 4552 |
| Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027
-> 1027 | 983 -> 983 | 4562 -> 4555 |
| Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027
-> 1027 | 983 -> 983 | 4562 -> 4561 |
| Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs |
1027 -> 1027 | 983 -> 983 | 4562 -> 4561 |

All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet):
630 cyclic modules, largest cycle 412, 2476 cyclic edges.

### Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR
stack, each PR against its parent at the time, on the older `main` the
stack forked from (967 cyclic modules then). They have not been
remeasured since the eight PRs above left the stack. Where the base
changed, the parent the numbers were measured on is in parentheses.

Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of
the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and
Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is
rebased.

| PR | Base | Change | Cyclic modules | Largest cycle |
| --- | --- | --- | --- | --- |
| Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) |
967 (baseline) | 923 (baseline) |
| Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types |
967 -> 949 | 923 -> 905 |
| Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs
outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 |
| Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not
`extensionService` | 669 -> 580 | 465 -> 371 |
| Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers
| 580 -> 566 | 371 -> 357 |
| Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from
the app shell | 558 -> 509 | 349 -> 297 |
| Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell |
509 -> 496 | 297 -> 284 |
| Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs
from GraphView | 484 -> 476 | 272 -> 264 |
| Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser
routing onto the sidebar tab | 471 -> 467 | 257 -> 253 |
| Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467
-> 464 | 253 -> 250 |
| Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 ->
447 | 250 -> 233 |
| **Comfy-Org#19121** (this PR) | **Comfy-Org#19118** | **Install workspace api
credentials from `main.ts`** | **447 -> 428** | **233 -> 214** |
| Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of
`dialogService` | 400 -> 391 | 181 -> 172 |
| Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352
| 172 -> 149 |
| Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the
facade | 352 -> 324 | 149 (baseline) |
| Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow
contracts as leaves | 324 -> 293 | 149 (baseline) |
| Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto
`useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) |
| Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth
dialogs, menu, and more | 259 -> 211 | 149 (baseline) |
<!-- stack-table:end -->
christian-byrne pushed a commit to christian-byrne/ComfyUI_frontend that referenced this pull request Oct 10, 2026
…g#19116)

## Summary

Targets `main`; the rest of this chain (Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19113) has merged. Tracks FE-2769 / FE-3037.

`executionStore` drove the node text preview widget itself: it bound the
`progress_text` socket event, resolved the node on the canvas, called
`showTextPreview`, and on job reset walked the job's nodes to
`removeTextPreview`. That pulled `useNodeProgressText` (and through it
the widget layer and `app`) plus `canvasStore` into the store.
Separately, `workflowStore` imported `executionStore` to rewrite session
job paths on rename, while `executionStore` imports `workflowStore`;
fallow flags that two-module cycle once this PR touches
`executionStore`.

Import cycles, measured with dependency-cruiser on `src` (the `pnpm
lint:cycles` script arrives with Comfy-Org#19085) against `main`: cyclic modules
421 -> 418, largest cycle 196 -> 193, cyclic edges 1687 -> 1679. The
rename change removes one of those edges; both stores stay in the large
cycle through other paths.

## Changes

- `executionStore` exposes `onJobReset` (vueuse `createEventHook`) and
triggers it with the finished `QueuedJob` inside `resetExecutionState`,
before the job is dropped. `QueuedJob` is exported for the listener
type. The store no longer imports `useNodeProgressText`, `canvasStore`,
or `parseNodeId`, and `progress_text` is no longer bound in
`bindExecutionEvents`.
- New `useProgressTextPreviews` composable listens to `api`
`progress_text` and `executionStore.onJobReset` and owns the widget
calls. GraphView mounts it next to `useProgressFavicon`.
`GraphView.test.ts` is unchanged.
- `workflowStore` no longer imports `executionStore`. `renameWorkflow`
triggers a new `onWorkflowRenamed` hook where it used to call
`rewriteSessionWorkflowPaths`, and `executionStore` subscribes in its
setup. `rewriteSessionWorkflowPaths` is now private.
- Tests: the progress_text and widget-removal cases move to
`useProgressTextPreviews.test.ts` (real execution store, the shared
`api` automock, fixtures built in each test, scope stopped with
`onTestFinished`), which adds cases for the active-prompt filter, for
mapping a nested execution id, and for disposal removing both listeners.
Removal there is driven through `clearActiveJobIfStale`.
`executionStore.test.ts` keeps one table asserting `onJobReset` fires
with the job after success, interrupt, and error, and drops
`progress_text` from the unbind list. Its session-path tests now drive a
real `renameWorkflow`; the matching rename test in
`workflowStore.test.ts` is removed and its duplicate-graph-id case lives
in `executionStore.test.ts`.
- E2E: the Flux2 rerun spec's progress-text test now checks the status
line is visible on the node while it runs, then hidden and gone from the
widget store after `execution_success`. Before, it only checked removal,
so it passed even if the preview never appeared.

## Review Focus

- `createEventHook` follows the existing pattern in
`cloudWebSessionStore` (`onSignedOutElsewhere`). Its `on`
auto-unsubscribes when the calling scope (GraphView) is disposed, and
`trigger` calls listeners synchronously, so the listener sees the job
before `resetExecutionState` deletes it.
- Listener lifetime: `useEventListener(api, 'progress_text')` binds at
GraphView setup and unbinds when GraphView's scope is disposed. Before,
the store bound it in `bindExecutionEvents` (GraphView `onMounted`) and
unbound it in `unbindExecutionEvents` (`onBeforeUnmount`).
`progress_text` only matters once the canvas exists, and the handler
already ignores events with no canvas.
- Rename timing: the hook fires synchronously at the point the direct
call ran, right after `workflow.rename` and before the lookup swap and
bookmark awaits, so linear-mode outputs keep matching the renamed
workflow. When `executionStore` does not exist yet there is no session
state to rewrite.
- Behavior is otherwise unchanged. The filters (active prompt only,
nested execution ids mapped through `workflowStore`, active workflow
only on reset) keep the same logic; node lookup is now one shared
`findNode` helper.

<!-- stack-table:start -->
## Stack

Import-cycle progress for FE-3037, measured with `pnpm lint:cycles`
(dependency-cruiser on `src`).

### Standalone PRs targeting `main`

Each is one commit on current `main` and can merge on its own. Numbers
are that PR alone against `origin/main` (1027 cyclic modules, largest
cycle 983, 4562 cyclic edges).

| PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges |
| --- | --- | --- | --- | --- | --- |
| Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 ->
884 | 983 -> 677 | 4562 -> 3382 |
| Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027
-> 1026 | 983 -> 982 | 4562 -> 4558 |
| Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor`
extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 |
| Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf
modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 |
| Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf |
1027 -> 1025 | 983 -> 981 | 4562 -> 4552 |
| Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027
-> 1027 | 983 -> 983 | 4562 -> 4555 |
| Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027
-> 1027 | 983 -> 983 | 4562 -> 4561 |
| Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs |
1027 -> 1027 | 983 -> 983 | 4562 -> 4561 |

All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet):
630 cyclic modules, largest cycle 412, 2476 cyclic edges.

### Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR
stack, each PR against its parent at the time, on the older `main` the
stack forked from (967 cyclic modules then). They have not been
remeasured since the eight PRs above left the stack. Where the base
changed, the parent the numbers were measured on is in parentheses.

Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of
the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and
Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is
rebased.

| PR | Base | Change | Cyclic modules | Largest cycle |
| --- | --- | --- | --- | --- |
| Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) |
967 (baseline) | 923 (baseline) |
| Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types |
967 -> 949 | 923 -> 905 |
| Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs
outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 |
| Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not
`extensionService` | 669 -> 580 | 465 -> 371 |
| Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers
| 580 -> 566 | 371 -> 357 |
| Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from
the app shell | 558 -> 509 | 349 -> 297 |
| Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell |
509 -> 496 | 297 -> 284 |
| Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs
from GraphView | 484 -> 476 | 272 -> 264 |
| Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser
routing onto the sidebar tab | 471 -> 467 | 257 -> 253 |
| **Comfy-Org#19116** (this PR) | **Comfy-Org#19113** | **Progress text previews out of
`executionStore`** | **467 -> 464** | **253 -> 250** |
| Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 ->
447 | 250 -> 233 |
| Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` |
447 -> 428 | 233 -> 214 |
| Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of
`dialogService` | 400 -> 391 | 181 -> 172 |
| Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352
| 172 -> 149 |
| Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the
facade | 352 -> 324 | 149 (baseline) |
| Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow
contracts as leaves | 324 -> 293 | 149 (baseline) |
| Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto
`useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) |
| Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth
dialogs, menu, and more | 259 -> 211 | 149 (baseline) |
<!-- stack-table:end -->

---------

Co-authored-by: Amp <amp@ampcode.com>
Penguinjanator pushed a commit to Penguinjanator/ComfyUI_frontend that referenced this pull request Oct 10, 2026
## Summary

Targets `main` directly, rebased onto cb72d45 after Comfy-Org#19093 merged
(6067dee). The original sat on Comfy-Org#19121; Comfy-Org#19118 and Comfy-Org#19121 are no
longer in this chain. Tracks FE-2769 / FE-3037.

`dialogService` bundled the core prompt/confirm/error dialogs with every
auth, billing, workspace, cloud-notification and ComfyHub dialog. Any
module that called `confirm()` transitively imported the billing and
workspace layers, and `workspaceStore -> dialogService ->
useBillingContext -> ... -> workspaceStore` held the whole platform
layer in the app SCC.

The core service keeps `showExecutionErrorDialog`, `showErrorDialog`,
`prompt`, `confirm`, `showExtensionDialog`, `showLayoutDialog` and
`showSmallLayoutDialog`. Feature dialogs move verbatim into per-feature
composables. Extensions still see every dialog on
`app.extensionManager.dialog`.

Import cycles on `main` cb72d45: 421 -> 412 cyclic modules, largest
SCC 196 -> 187, 1687 -> 1648 cyclic edges.

## Changes

- `dialogService.ts`: core dialogs only. Declares
`ExtensionDialogService` (core + feature signatures, leaf types only),
`registerExtensionDialogService()` and `useExtensionDialogService()`.
- `extensionDialogService.ts`: `createExtensionDialogService()` spreads
the core service and the feature composables. `App.vue` registers it
before `useWorkspaceStore()` is created; `workspaceStore.dialog` reads
the registry. `ExtensionManager.dialog` is typed
`ExtensionDialogService`.
- New composables, functions moved unchanged:
`composables/auth/useAuthDialogs.ts`,
`composables/billing/useBillingDialogs.ts`,
`platform/workspace/composables/useWorkspaceDialogs.ts`,
`platform/cloud/notification/composables/useCloudNotificationDialog.ts`;
`showPublishDialog` joins `useComfyHubPublishDialog`. The shared
`workspaceDialogProps` object becomes `SELF_STYLED_PANEL_DIALOG_PROPS`
in `components/ui/dialog/dialog.variants.ts`, next to
`HUG_CONTENT_CLASS` and `SELF_STYLED_PANEL_CONTENT_CLASS`, which `main`
already has there.
- `composables/billing/types.ts` gains `TopUpCreditsDialogOptions`,
`SubscriptionDialogOptions`, `DowngradeToPersonalResult`.
`ConfirmationDialogType` moves to
`components/dialog/content/confirmationDialogTypes.ts`.
- `useSettingsDialog` calls `dialogStore.showDialog` directly with the
same renderer/headless/closable props `showLayoutDialog` applied.
- Callers switch from `useDialogService().showX` to the owning
composable. Tests get a `__mocks__` per feature composable; billing
dialog tests move next to `useBillingDialogs` (`git mv`), and the two
`showCancelSubscriptionDialog` guard tests move from
`dialogService.concurrency.test.ts` into
`useBillingDialogs.cancelSubscription.test.ts`. `useInviteUrlLoader` and
`UserPanel` (added on `main` since the original) switch to
`useWorkspaceDialogs` / `useAuthDialogs` too. The downgrade-failure
toast in `useBillingDialogs` uses the `useToast()` API from Comfy-Org#16313, as
the moved code on `main` does.

## Review Focus

- Registry over direct import: `workspaceStore` importing the aggregator
directly keeps every feature composable in the SCC (in the original
stack, simulated 185 vs 172). The registry is a module-level `let`
guarded by `assert` from `@/base/assert`; `App.vue` is the only
registration site.
- `useExtensionDialogService()` before registration is a programming
error: `assert` throws in DEV and reports in production.
- Browser test fixtures (`PublishDialog.ts`, `CloudNotification.ts`)
call
`window.app.extensionManager.dialog.showPublishDialog/showCloudNotification`;
both remain on the extension surface.
- Feature dialog composables are still in the SCC through their dialog
components, which import `app`. That is the next PR (`app` -> root graph
leaf).
- `.fallow-baselines/health.json`: one `crap_high` entry added for
`useBillingDialogs.ts`; `showTopUpCreditsDialog` moved verbatim, fallow
re-estimates coverage per file from export references, and the
composable has fewer importers than `dialogService`.

<!-- stack-table:start -->
## Stack

Import-cycle progress for FE-3037, measured with `pnpm lint:cycles`
(dependency-cruiser on `src`).

### Standalone PRs targeting `main`

Each is one commit on current `main` and can merge on its own. Numbers
are that PR alone against `origin/main` (1027 cyclic modules, largest
cycle 983, 4562 cyclic edges).

| PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges |
| --- | --- | --- | --- | --- | --- |
| Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 ->
884 | 983 -> 677 | 4562 -> 3382 |
| Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027
-> 1026 | 983 -> 982 | 4562 -> 4558 |
| Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor`
extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 |
| Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf
modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 |
| Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf |
1027 -> 1025 | 983 -> 981 | 4562 -> 4552 |
| Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027
-> 1027 | 983 -> 983 | 4562 -> 4555 |
| Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027
-> 1027 | 983 -> 983 | 4562 -> 4561 |
| Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs |
1027 -> 1027 | 983 -> 983 | 4562 -> 4561 |

All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet):
630 cyclic modules, largest cycle 412, 2476 cyclic edges.

### Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR
stack, each PR against its parent at the time, on the older `main` the
stack forked from (967 cyclic modules then). They have not been
remeasured since the eight PRs above left the stack. Where the base
changed, the parent the numbers were measured on is in parentheses.

Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of
the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and
Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is
rebased.

| PR | Base | Change | Cyclic modules | Largest cycle |
| --- | --- | --- | --- | --- |
| Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) |
967 (baseline) | 923 (baseline) |
| Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types |
967 -> 949 | 923 -> 905 |
| Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs
outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 |
| Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not
`extensionService` | 669 -> 580 | 465 -> 371 |
| Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers
| 580 -> 566 | 371 -> 357 |
| Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from
the app shell | 558 -> 509 | 349 -> 297 |
| Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell |
509 -> 496 | 297 -> 284 |
| Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs
from GraphView | 484 -> 476 | 272 -> 264 |
| Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser
routing onto the sidebar tab | 471 -> 467 | 257 -> 253 |
| Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467
-> 464 | 253 -> 250 |
| Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 ->
447 | 250 -> 233 |
| Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` |
447 -> 428 | 233 -> 214 |
| **Comfy-Org#19131** (this PR) | **Comfy-Org#19121 (measured on Comfy-Org#19127)** | **Feature
dialogs out of `dialogService`** | **400 -> 391** | **181 -> 172** |
| Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352
| 172 -> 149 |
| Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the
facade | 352 -> 324 | 149 (baseline) |
| Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow
contracts as leaves | 324 -> 293 | 149 (baseline) |
| Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto
`useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) |
| Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth
dialogs, menu, and more | 259 -> 211 | 149 (baseline) |
<!-- stack-table:end -->

Co-authored-by: Amp <amp@ampcode.com>
christian-byrne pushed a commit to christian-byrne/ComfyUI_frontend that referenced this pull request Oct 11, 2026
…omfy-Org#19143)

## Summary

Modules below `scripts/app.ts` in the import graph stop importing the
`app` value from it. They call `useApp()` from `scripts/appInstance`,
which reads a registry that `app.ts` fills right after constructing
`ComfyApp`. Type-only consumers import the new `ComfyApp` interface from
`types/comfy`. Clipspace state moves out of the class into
`scripts/clipspace`.

Import cycles: 409 -> 371 cyclic modules, largest SCC 184 -> 154
(litegraph is now the largest), 1640 -> 1451 cyclic edges, measured with
dependency-cruiser on `main` a2dba8f.

Targets `main` directly, rebased onto a2dba8f. Tracks FE-2769 /
FE-3037.

## Changes

- `types/comfy.ts`: `ComfyApp` interface (public instance surface),
`QueuePromptOptions`, `LoadGraphDataOptions`. `types/index.ts`
re-exports the type from here instead of from `scripts/app`.
- `scripts/appRegistry.ts`: `registerApp` / `useApp` (asserts
registration). `scripts/appInstance.ts` re-exports `useApp` as the
consumer-facing seam so tests can mock it without re-entering `app.ts`.
- `scripts/clipspace.ts`: clipspace state plus `copyToClipspace` /
`pasteFromClipspace`. `ComfyApp` statics stay as accessors for
custom-node compatibility; `litegraphService` and `changeTracker` use
the leaf directly.
- `class ComfyApp implements ComfyApp` (aliased `IComfyApp` inside
`app.ts`). `ANIM_PREVIEW_WIDGET` now lives in `useNodeAnimatedImage.ts`
and is re-exported from `app.ts`.
- ~40 SCC importers switched to `useApp()` (all call sites are inside
functions). On the current base that includes the mask editor
composables, `useNodeProgressText` and `useProgressTextWidget`, which
joined the SCC after the original PR. Type positions use
`ComfyApp['rootGraph']` / `Parameters<ComfyApp['loadGraphData']>[0]`.
- `commandStore.loadExtensionCommands` takes `{ name; commands? }` so it
no longer imports `ComfyExtension`.
- `vitest.setup.ts`: global mock of `@/scripts/appInstance` that
resolves `useApp()` to whatever `@/scripts/app` is in the test file
(real or per-file mock), awaited in `beforeAll` / `beforeEach`.
`firstRunEntry.test.ts`'s `createSharedComposable` stand-in now resets
every composable it created rather than only the last one registered.
- `scripts/README.md`: documents the interface / `useApp()` / clipspace
pattern.
- Baselines: `.fallow-baselines/dead-code.json` gains 32 pre-existing
cycles (auth, billing, `workflowStore` <-> `executionStore`, the billing
paths through `useBillingDialogs`, and `comfyWorkflow -> changeTracker
-> workflowStore`) that fallow only enumerates once the hub edges are
gone; every entry's modules sit in one SCC on `main`; the entries use
fallow's sorted-path key. `health.json` entry for `clipspace.ts`.

## Review Focus

- Only modules below `app.ts` use `useApp()`. Top-level code
(extensions, components, `App.vue`) keeps `import { app }`.
- `useApp()` asserts that `registerApp` has run; every migrated call
site runs after `app.ts` evaluates. `appRegistry.test.ts` covers both
branches.
- The vitest bridge loads `@/scripts/app` asynchronously, so modules in
its tree now evaluate after the test subject's imports.
`firstRunEntry.test.ts` was the one test sensitive to that ordering.

<!-- stack-table:start -->
## Stack

Import-cycle progress for FE-3037, measured with `pnpm lint:cycles`
(dependency-cruiser on `src`).

### Standalone PRs targeting `main`

Each is one commit on current `main` and can merge on its own. Numbers
are that PR alone against `origin/main` (1027 cyclic modules, largest
cycle 983, 4562 cyclic edges).

| PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges |
| --- | --- | --- | --- | --- | --- |
| Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 ->
884 | 983 -> 677 | 4562 -> 3382 |
| Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027
-> 1026 | 983 -> 982 | 4562 -> 4558 |
| Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor`
extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 |
| Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf
modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 |
| Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf |
1027 -> 1025 | 983 -> 981 | 4562 -> 4552 |
| Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027
-> 1027 | 983 -> 983 | 4562 -> 4555 |
| Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027
-> 1027 | 983 -> 983 | 4562 -> 4561 |
| Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs |
1027 -> 1027 | 983 -> 983 | 4562 -> 4561 |

All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet):
630 cyclic modules, largest cycle 412, 2476 cyclic edges.

### Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR
stack, each PR against its parent at the time, on the older `main` the
stack forked from (967 cyclic modules then). They have not been
remeasured since the eight PRs above left the stack. Where the base
changed, the parent the numbers were measured on is in parentheses.

Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of
the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and
Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is
rebased.

| PR | Base | Change | Cyclic modules | Largest cycle |
| --- | --- | --- | --- | --- |
| Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) |
967 (baseline) | 923 (baseline) |
| Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types |
967 -> 949 | 923 -> 905 |
| Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs
outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 |
| Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not
`extensionService` | 669 -> 580 | 465 -> 371 |
| Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers
| 580 -> 566 | 371 -> 357 |
| Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from
the app shell | 558 -> 509 | 349 -> 297 |
| Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell |
509 -> 496 | 297 -> 284 |
| Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs
from GraphView | 484 -> 476 | 272 -> 264 |
| Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser
routing onto the sidebar tab | 471 -> 467 | 257 -> 253 |
| Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467
-> 464 | 253 -> 250 |
| Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 ->
447 | 250 -> 233 |
| Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` |
447 -> 428 | 233 -> 214 |
| Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of
`dialogService` | 400 -> 391 | 181 -> 172 |
| **Comfy-Org#19143** (this PR) | **Comfy-Org#19131** | **Invert `scripts/app` behind
`useApp()`** | **391 -> 352** | **172 -> 149** |
| Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the
facade | 352 -> 324 | 149 (baseline) |
| Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow
contracts as leaves | 324 -> 293 | 149 (baseline) |
| Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto
`useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) |
| Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth
dialogs, menu, and more | 259 -> 211 | 149 (baseline) |
<!-- stack-table:end -->

---------

Co-authored-by: Amp <amp@ampcode.com>
laurigates pushed a commit to laurigates/ComfyUI_frontend that referenced this pull request Oct 13, 2026
## Summary

`types/comfy.ts` is the public extension contract, yet it imported
`scripts/widgets`, `scripts/ui`, and the workflow store, so every module
that typed against `ComfyApp` was pulled into the app's largest import
cycle. This PR makes `types/comfy.ts`, `types/extensionTypes.ts`, and
`comfyWorkflow.ts` leaves: they no longer reach `scripts/appInstance`.
Before the review fixes, depcruise measured the 273-module app SCC
splitting into 119 + 58 modules.

Import-cycle measurements before the review fixes: 371 -> 341 cyclic
modules, largest SCC 154 -> 154 (litegraph), 1451 -> 1335 cyclic edges,
on `main` df4ea6d (Comfy-Org#19143 merged as cdc9fe0). These counts have
not been remeasured after restoring the extension hooks.
`workflowStoreTypes.ts` carries main's `nodeLocatorIdToNodeId: ... =>
NodeId | null` signature, which landed on `main` after the interface
moved.

Targets `main` directly, rebased onto df4ea6d after Comfy-Org#19143 merged
(cdc9fe0). Tracks FE-2769 / FE-3037.

## Changes

- `ComfyWidgetConstructor` / `CustomComfyWidgetConstructor` are declared
in `types/comfy.ts`; `scripts/widgets.ts` imports them.
`ComfyApp.widgets` is typed as `Record<string, ComfyWidgetConstructor |
CustomComfyWidgetConstructor>` instead of `typeof ComfyWidgets`, and
`dynamicComboWidget` narrows the result of `app.widgets.COMBO`.
- `MissingModelPipelineResult` moves to
`platform/missingModel/types.ts`; `groupCandidatesByName` moves into
`missingModelGrouping.ts` so grouping stops importing scan.
- `scripts/ui.ts`: `ComfyUI(app, host)` takes the app and a
`LegacyMenuHost` (`resetView`, `restoreOutputs`, `trackRunButton`,
`enterFocusMode`) instead of calling `useApp()`, `litegraphService`,
`nodeOutputStore`, `workspaceStore`, and `useRunButtonTelemetry`.
`app.ts` wires the host.
- `comfyWorkflow.ts` becomes a leaf. `WorkflowChangeTracker` is an
interface `ChangeTracker` implements. A `WorkflowRuntime`
(`createChangeTracker`, draft get/remove/markUsed,
`isDraftPersistenceEnabled`) is registered by `workflowStore.ts` at
module scope, replacing the dynamic `import('@/scripts/changeTracker')`
and the direct settings/draft-store imports.
- `ComfyWorkflow.promptSave()` remains an extension override point. Its
default delegates to the registered `WorkflowRuntime`, which opens the
dialog using `saveNamePrompt` i18n keys, overridden by
`SubgraphBlueprint`. `workflowService.saveWorkflowAs` continues calling
the hook.
- Clipspace editor save honors `ComfyApp.pasteFromClipspace` overrides.
Image paste updates store-backed outputs without requiring legacy
previews and skips absent selections while still pasting widget values.
- New leaf `workflowStoreTypes.ts` exports the `WorkflowStore`
interface; `ExtensionManager.workflow` is typed as `WorkflowStore`.
- New leaf `services/dialogServiceTypes.ts` with `CoreDialogService`,
`ExtensionDialogService`, `ConfirmOptions`, `ExecutionErrorDialogInput`;
`useDialogService()` returns `CoreDialogService` and `extensionTypes.ts`
imports the leaf. `ExtensionDialogService` carries main's current
signatures (`showCancelSubscriptionDialog` scope/confirmed args,
`paymentIntentSource`, `showInviteLinkInvalidDialog`,
`showInviteWrongAccountDialog`).
- `comfyWorkflow.test.ts` deleted (it tested the dynamic-import failure
path that no longer exists); `workflowService.test.ts` mocks
`useDialogService().prompt` and asserts the save-name copy; `ui.test.ts`
/ `ui.setStatus.test.ts` pass the app and a stub host.

## Review Focus

- `ComfyApp.widgets` loses the `typeof ComfyWidgets` key typing. Core
widget constructors are still reachable as
`useWidgetStore().coreWidgets`; extension code indexing
`app.widgets.<Name>` now gets the union type.
- `ExtensionManager.workflow` no longer exposes Pinia `$`-methods on the
public type. Extensions calling `app.extensionManager.workflow.$patch`
would be a type break (runtime unchanged).
- `ComfyWorkflow.promptSave` is preserved because
[RigShare](https://github.com/xiaodoudou/ComfyUI-RigShare/blob/3de3cc32e2a5bd266879dd6b346f8960ad4dd619/web/rigshare/save-dialog.js#L22)
and
[Bada-Utils](https://github.com/bada-ya/ComfyUI-Bada-Utils/blob/0898b33e803df8e169501d8fe0cf1fd04044f7bf/web/workflow_organizer.js#L2996)
wrap its prototype implementation to customize Save As. A regression
test checks that an override's filename reaches the save path.
- `workflowStore.ts` now imports `ChangeTracker` statically. fallow sees
the previously dynamic `comfyWorkflow -> workflowStore -> changeTracker`
3-cycle reshaped into two short `workflowStore <-> changeTracker`
cycles; this plus 28 pre-existing cycles fallow newly enumerates
(auth/session, api <-> authStore <-> dialogService, promotionUtils
through canvasStore and litegraphService, useAppMode -> workflowStore ->
changeTracker -> executionStore, workflowStore <-> executionStore,
canvasStore <-> litegraphUtil) are baselined in
`.fallow-baselines/dead-code.json`. Breaking `changeTracker ->
workflowStore` needs a host injection into `ChangeTracker` and a rewrite
of its 1400-line test, so it is left for a follow-up.
- `dynamicComboWidget` keeps the runtime lookup through
`app.widgets.COMBO`. A static import of `useComboWidget` or
`widgetStore` from `dynamicWidgets.ts` creates a module-evaluation cycle
with `scripts/widgets.ts` (`...dynamicWidgets` spread sees an
uninitialised binding), which is why the assert-based narrowing is used
instead.

<!-- stack-table:start -->
## Stack

Import-cycle progress for FE-3037, measured with `pnpm lint:cycles`
(dependency-cruiser on `src`).

### Standalone PRs targeting `main`

Each is one commit on current `main` and can merge on its own. Numbers
are that PR alone against `origin/main` (1027 cyclic modules, largest
cycle 983, 4562 cyclic edges).

| PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges |
| --- | --- | --- | --- | --- | --- |
| Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 ->
884 | 983 -> 677 | 4562 -> 3382 |
| Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027
-> 1026 | 983 -> 982 | 4562 -> 4558 |
| Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor`
extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 |
| Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf
modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 |
| Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf |
1027 -> 1025 | 983 -> 981 | 4562 -> 4552 |
| Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027
-> 1027 | 983 -> 983 | 4562 -> 4555 |
| Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027
-> 1027 | 983 -> 983 | 4562 -> 4561 |
| Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs |
1027 -> 1027 | 983 -> 983 | 4562 -> 4561 |

All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet):
630 cyclic modules, largest cycle 412, 2476 cyclic edges.

### Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR
stack, each PR against its parent at the time, on the older `main` the
stack forked from (967 cyclic modules then). They have not been
remeasured since the eight PRs above left the stack. Where the base
changed, the parent the numbers were measured on is in parentheses.

Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of
the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and
Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is
rebased.

| PR | Base | Change | Cyclic modules | Largest cycle |
| --- | --- | --- | --- | --- |
| Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) |
967 (baseline) | 923 (baseline) |
| Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types |
967 -> 949 | 923 -> 905 |
| Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs
outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 |
| Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not
`extensionService` | 669 -> 580 | 465 -> 371 |
| Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers
| 580 -> 566 | 371 -> 357 |
| Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from
the app shell | 558 -> 509 | 349 -> 297 |
| Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell |
509 -> 496 | 297 -> 284 |
| Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs
from GraphView | 484 -> 476 | 272 -> 264 |
| Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser
routing onto the sidebar tab | 471 -> 467 | 257 -> 253 |
| Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467
-> 464 | 253 -> 250 |
| Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 ->
447 | 250 -> 233 |
| Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` |
447 -> 428 | 233 -> 214 |
| Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of
`dialogService` | 400 -> 391 | 181 -> 172 |
| Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352
| 172 -> 149 |
| Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the
facade | 352 -> 324 | 149 (baseline) |
| **Comfy-Org#19153** (this PR) | **Comfy-Org#19148** | **`types/comfy`, `comfyWorkflow`,
dialog/workflow contracts as leaves** | **324 -> 293** | **149
(baseline)** |
| Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto
`useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) |
| Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth
dialogs, menu, and more | 259 -> 211 | 149 (baseline) |
<!-- stack-table:end -->

---------

Co-authored-by: Amp <amp@ampcode.com>
xmarre pushed a commit to xmarre/ComfyUI_frontend that referenced this pull request Oct 14, 2026
## Summary

Removes the import cycles left inside `src/workbench`: the 28-module
manager cycle and the agent CRDT status cycle. `workbench/` is now
cycle-free, which is a prerequisite for giving it its own TypeScript
project reference.

Import cycles: 341 -> 311 cyclic modules, 20 -> 18 cycles, largest SCC
154 -> 154 (litegraph), 1335 -> 1262 cyclic edges, on top of Comfy-Org#19153
(rebased onto `main` df4ea6d).

Stacked on Comfy-Org#19153 (rebased onto the `drjkl/comfy-types-leaf` chain).
Tracks FE-2769 / FE-3037.

## Changes

- Manager: `useManagerState` had two responsibilities, deriving the
manager UI state and opening the manager. Opening needs
`useManagerDialog`, which imports `ManagerDialog.vue`, whose subtree
imports `useManagerState` again. `openManager` moves to
`useManagerDialog`, which already owns `show()`/`hide()`.
`useManagerState` keeps the state derivations and the once-per-session
upgrade toast, and exports `showIncompatibleManagerToast({ force })` so
the explicit-click re-emit lives with `openManager`.
- Callers (`useCoreCommands`, `TopMenuSection`, `ComfyMenuButton`,
`HelpCenterMenuContent`, `ErrorGroupList`, `MissingPackGroupRow`) call
`useManagerDialog().openManager(...)`. `ComfyMenuButton` no longer needs
`useManagerState`. The legacy-menu error toast in `openManager` uses the
`useToast()` API from Comfy-Org#16313, as `useManagerState` does on `main`.
- Tests: `openManager` coverage moves from `useManagerState.test.ts` to
`useManagerDialog.test.ts` and now covers all four states (DISABLED,
INCOMPATIBLE, LEGACY_UI with and without `showToastOnLegacyError`,
NEW_UI with and without `isLegacyOnly`) by driving the real
`useManagerState` through `systemStatsStore` and spied `api` feature
flags. The shared `__mocks__/useManagerState.ts` drops `openManager`; a
new `__mocks__/useManagerDialog.ts` covers component tests.
- Agent composer: the `ComposerAttachment` leaf this PR originally
introduced already landed on main (`types/composerAttachment.ts`), so
that part is dropped.
- Agent CRDT: `AgentCrdtStatus` and `AgentCrdtOutcomeCounters` move to a
new leaf `crdt/agentCrdtStatus.ts` so `crdtSnapshot.ts` stops importing
`useAgentCrdtFollower.ts`.
- fallow baselines: `dead-code.json` is unchanged (the stale manager
entries stay as unused baseline rows); the `crap_high` entry for
`openManager` moves from `useManagerState.ts` to `useManagerDialog.ts`
in `health.json` (same function, new file).

## Review Focus

- `openManager` now calls `useManagerState()` per invocation. Its
`watch(..., { immediate: true })` runs once per call and can fire the
once-per-session INCOMPATIBLE toast if no component had instantiated the
composable yet. That matches the previous behaviour, where every caller
instantiated `useManagerState()` before calling `openManager`.
- `useManagerDialog` now imports `useManagerState`; the dependency
direction is dialog -> state, matching `useManagerDialog ->
ManagerDialog.vue -> ... -> useManagerState`.

<!-- stack-table:start -->
## Stack

Import-cycle progress for FE-3037, measured with `pnpm lint:cycles`
(dependency-cruiser on `src`).

### Standalone PRs targeting `main`

Each is one commit on current `main` and can merge on its own. Numbers
are that PR alone against `origin/main` (1027 cyclic modules, largest
cycle 983, 4562 cyclic edges).

| PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges |
| --- | --- | --- | --- | --- | --- |
| Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 ->
884 | 983 -> 677 | 4562 -> 3382 |
| Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027
-> 1026 | 983 -> 982 | 4562 -> 4558 |
| Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor`
extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 |
| Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf
modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 |
| Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf |
1027 -> 1025 | 983 -> 981 | 4562 -> 4552 |
| Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027
-> 1027 | 983 -> 983 | 4562 -> 4555 |
| Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027
-> 1027 | 983 -> 983 | 4562 -> 4561 |
| Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs |
1027 -> 1027 | 983 -> 983 | 4562 -> 4561 |

All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111,
Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet):
630 cyclic modules, largest cycle 412, 2476 cyclic edges.

### Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR
stack, each PR against its parent at the time, on the older `main` the
stack forked from (967 cyclic modules then). They have not been
remeasured since the eight PRs above left the stack. Where the base
changed, the parent the numbers were measured on is in parentheses.

Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of
the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and
Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is
rebased.

| PR | Base | Change | Cyclic modules | Largest cycle |
| --- | --- | --- | --- | --- |
| Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) |
967 (baseline) | 923 (baseline) |
| Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types |
967 -> 949 | 923 -> 905 |
| Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs
outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 |
| Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not
`extensionService` | 669 -> 580 | 465 -> 371 |
| Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers
| 580 -> 566 | 371 -> 357 |
| Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from
the app shell | 558 -> 509 | 349 -> 297 |
| Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell |
509 -> 496 | 297 -> 284 |
| Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs
from GraphView | 484 -> 476 | 272 -> 264 |
| Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser
routing onto the sidebar tab | 471 -> 467 | 257 -> 253 |
| Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467
-> 464 | 253 -> 250 |
| Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 ->
447 | 250 -> 233 |
| Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` |
447 -> 428 | 233 -> 214 |
| Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of
`dialogService` | 400 -> 391 | 181 -> 172 |
| Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352
| 172 -> 149 |
| Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the
facade | 352 -> 324 | 149 (baseline) |
| Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow
contracts as leaves | 324 -> 293 | 149 (baseline) |
| **Comfy-Org#19186** (this PR) | **Comfy-Org#19153** | **Workbench cycles: `openManager`
onto `useManagerDialog`, agent leaves** | **293 -> 259** | **149
(baseline)** |
| Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth
dialogs, menu, and more | 259 -> 211 | 149 (baseline) |
<!-- stack-table:end -->

---------

Co-authored-by: Amp <amp@ampcode.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cursor-review Trigger multi-model Cursor agent review on this PR greenlight refactor-gordian-knot Import-cycle untangling stack (FE-3037) risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants