Repository navigation
refactor: make types/comfy a leaf of the app runtime - #19153
Conversation
📦 Bundle: 9.41 MB gzip 🔴 +1.47 kBDetailsSummary
Category Glance App Entry Points — 5.54 kB (baseline 5.44 kB) • 🔴 +105 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.16 MB (baseline 2.16 MB) • 🟢 -304 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 147 kB (baseline 147 kB) • 🟢 -67 BTop-level views, pages, and routed surfaces
Status: 11 added / 11 removed / 7 unchanged Panels & Settings — 669 kB (baseline 669 kB) • 🔴 +67 BConfiguration panels, inspectors, and settings screens
Status: 5 added / 5 removed / 24 unchanged User & Accounts — 276 kB (baseline 63.8 kB) • 🔴 +212 kBAuthentication, profile, and account management bundles
Status: 8 added / 7 removed / 9 unchanged Editors & Dialogs — 341 kB (baseline 341 kB) • 🔴 +177 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed / 4 unchanged UI Components — 211 kB (baseline 211 kB) • 🟢 -300 BReusable component library chunks
Status: 7 added / 7 removed / 17 unchanged Data & Services — 2.16 MB (baseline 1.36 MB) • 🔴 +791 kBStores, services, APIs, and repositories
Status: 14 added / 15 removed / 10 unchanged Utilities & Hooks — 1.3 MB (baseline 2.29 MB) • 🟢 -997 kBHelpers, composables, and utility bundles
Status: 27 added / 26 removed / 36 unchanged Vendor & Third-Party — 14.3 MB (baseline 14.3 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 19 MB (baseline 19.1 MB) • 🟢 -5.61 kBBundles that do not match a named category
Status: 81 added / 83 removed / 270 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-12T21:39:31.829Z",
"gitSha": "ef2762361a6bdc102ff4fe3b91936d56327798f7",
"branch": "drjkl/comfy-types-leaf",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2031.1629999999923,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9640000000000004,
"layouts": 10,
"layoutDurationMs": 3.0649999999999995,
"taskDurationMs": 614.1610000000001,
"heapDeltaBytes": -8169700,
"heapUsedBytes": 57627704,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 12.274000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2022.5249999999733,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.1879999999999997,
"layouts": 9,
"layoutDurationMs": 3.137,
"taskDurationMs": 582.871,
"heapDeltaBytes": 22097180,
"heapUsedBytes": 87966556,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 13.493000000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1748.6059999999952,
"styleRecalcs": 74,
"styleRecalcDurationMs": 16.025000000000002,
"layouts": 9,
"layoutDurationMs": 2.6639999999999997,
"taskDurationMs": 909.0120000000001,
"heapDeltaBytes": -8076504,
"heapUsedBytes": 67377064,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 153.79600000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1992.734999999925,
"styleRecalcs": 84,
"styleRecalcDurationMs": 16.93,
"layouts": 8,
"layoutDurationMs": 2.7039999999999997,
"taskDurationMs": 1105.97,
"heapDeltaBytes": 15599668,
"heapUsedBytes": 81177452,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 157.219,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.2359999999899,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.341,
"layouts": 11,
"layoutDurationMs": 3.303,
"taskDurationMs": 413.95300000000003,
"heapDeltaBytes": 18733732,
"heapUsedBytes": 84948420,
"domNodes": 47,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 14.337,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1814.0859999999748,
"styleRecalcs": 18,
"styleRecalcDurationMs": 6.175000000000001,
"layouts": 11,
"layoutDurationMs": 3.0029999999999997,
"taskDurationMs": 483.74899999999997,
"heapDeltaBytes": 18317568,
"heapUsedBytes": 83800944,
"domNodes": 47,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 14.744,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871563,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 697.8710000000206,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.3420000000000005,
"layouts": 9,
"layoutDurationMs": 2.7449999999999997,
"taskDurationMs": 499.042,
"heapDeltaBytes": 25524860,
"heapUsedBytes": 91531260,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 166.59099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668292682926833,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 711.4319999999452,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.172,
"layouts": 9,
"layoutDurationMs": 2.7889999999999997,
"taskDurationMs": 498.90999999999997,
"heapDeltaBytes": -597180,
"heapUsedBytes": 65797860,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 167.91099999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66744186046511,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1254.934999999989,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1001.7309999999999,
"heapDeltaBytes": -12052272,
"heapUsedBytes": 81160524,
"domNodes": -192,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 70.607,
"eventListeners": -106,
"totalBlockingTimeMs": 564,
"frameDurationMs": 33.7810810810811,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1226.560999999947,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 887.991,
"heapDeltaBytes": -12874552,
"heapUsedBytes": 81450800,
"domNodes": -192,
"jsHeapTotalBytes": 20717568,
"scriptDurationMs": 62.90899999999999,
"eventListeners": -106,
"totalBlockingTimeMs": 536,
"frameDurationMs": 33.32972972972973,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 850.3259999999955,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.36800000000017,
"heapDeltaBytes": -4355560,
"heapUsedBytes": 76692296,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 143.351,
"eventListeners": 0,
"totalBlockingTimeMs": 217,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 856.4299999999321,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 501.0330000000001,
"heapDeltaBytes": -5504264,
"heapUsedBytes": 75489768,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 145.44300000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 219,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9762.625000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8801.461,
"heapDeltaBytes": -24821828,
"heapUsedBytes": 74759368,
"domNodes": -258,
"jsHeapTotalBytes": 5632000,
"scriptDurationMs": 6948.412,
"eventListeners": -68,
"totalBlockingTimeMs": 333,
"frameDurationMs": 28.507894736842108,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8709.963000000016,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.060000000000001025,
"layouts": 1,
"layoutDurationMs": 0.2459999999999997,
"taskDurationMs": 7723.6050000000005,
"heapDeltaBytes": -12932320,
"heapUsedBytes": 86843012,
"domNodes": -258,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 6320.071,
"eventListeners": -68,
"totalBlockingTimeMs": 165,
"frameDurationMs": 27.847923322683705,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8672.568000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7860.622000000001,
"heapDeltaBytes": -2945836,
"heapUsedBytes": 96874664,
"domNodes": -258,
"jsHeapTotalBytes": 10612736,
"scriptDurationMs": 6486.4349999999995,
"eventListeners": -67,
"totalBlockingTimeMs": 438,
"frameDurationMs": 32.45805243445693,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9032.943000000047,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.05800000000000076,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8078.932,
"heapDeltaBytes": -6784972,
"heapUsedBytes": 70475784,
"domNodes": -258,
"jsHeapTotalBytes": 1961984,
"scriptDurationMs": 6640.489,
"eventListeners": -68,
"totalBlockingTimeMs": 142,
"frameDurationMs": 28.62349206349207,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 227.1910000000048,
"styleRecalcs": 24,
"styleRecalcDurationMs": 16.912,
"layouts": 11,
"layoutDurationMs": 3.6479999999999997,
"taskDurationMs": 172.10899999999998,
"heapDeltaBytes": -8211068,
"heapUsedBytes": 79225940,
"domNodes": 917,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 8.960999999999999,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.209090909090843,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 233.06300000001556,
"styleRecalcs": 23,
"styleRecalcDurationMs": 19.054,
"layouts": 12,
"layoutDurationMs": 4.090999999999999,
"taskDurationMs": 180.02,
"heapDeltaBytes": -7552508,
"heapUsedBytes": 79997940,
"domNodes": 917,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 10.293999999999999,
"eventListeners": 195,
"totalBlockingTimeMs": 7,
"frameDurationMs": 25.922222222222242,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2071.392000000003,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.374,
"layouts": 8,
"layoutDurationMs": 2.21,
"taskDurationMs": 739.751,
"heapDeltaBytes": -25832012,
"heapUsedBytes": 72574892,
"domNodes": -258,
"jsHeapTotalBytes": 4096000,
"scriptDurationMs": 40.133,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666935483870972,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2056.656000000089,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.531,
"layouts": 8,
"layoutDurationMs": 2.5220000000000002,
"taskDurationMs": 699.1250000000001,
"heapDeltaBytes": -2236656,
"heapUsedBytes": 77026296,
"domNodes": -258,
"jsHeapTotalBytes": 2748416,
"scriptDurationMs": 41.292,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2212.670000000003,
"styleRecalcs": 68,
"styleRecalcDurationMs": 7.026,
"layouts": 7,
"layoutDurationMs": 2.0649999999999995,
"taskDurationMs": 1492.012,
"heapDeltaBytes": -1338500,
"heapUsedBytes": 79065784,
"domNodes": -258,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 822.255,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.793129770992362,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2674.604000000045,
"styleRecalcs": 68,
"styleRecalcDurationMs": 7.078000000000001,
"layouts": 6,
"layoutDurationMs": 1.7110000000000003,
"taskDurationMs": 1712.1270000000002,
"heapDeltaBytes": 2946708,
"heapUsedBytes": 83162048,
"domNodes": -258,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 798.3299999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665838509316767,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3847.899000000041,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.314000000000002,
"layouts": 64,
"layoutDurationMs": 11.823,
"taskDurationMs": 1843.958,
"heapDeltaBytes": -18125520,
"heapUsedBytes": 81575320,
"domNodes": -234,
"jsHeapTotalBytes": 6455296,
"scriptDurationMs": 800.558,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.738695652173917,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3872.239000000036,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.934999999999999,
"layouts": 64,
"layoutDurationMs": 12.319,
"taskDurationMs": 1846.5479999999998,
"heapDeltaBytes": 3993380,
"heapUsedBytes": 86211152,
"domNodes": -234,
"jsHeapTotalBytes": 4583424,
"scriptDurationMs": 815.044,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379312,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3046.0769999999684,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.2090000000000005,
"layouts": 4,
"layoutDurationMs": 1.4169999999999998,
"taskDurationMs": 1976.1449999999998,
"heapDeltaBytes": 2155556,
"heapUsedBytes": 85228232,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 956.135,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.85111111111111,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2856.8729999999505,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.521,
"layouts": 5,
"layoutDurationMs": 1.5669999999999997,
"taskDurationMs": 1793.1940000000002,
"heapDeltaBytes": 14379508,
"heapUsedBytes": 98073648,
"domNodes": 0,
"jsHeapTotalBytes": 5660672,
"scriptDurationMs": 964.294,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.862721893491127,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2031.7279999999869,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.7340000000000004,
"layouts": 9,
"layoutDurationMs": 2.7019999999999995,
"taskDurationMs": 684.2259999999999,
"heapDeltaBytes": -20982560,
"heapUsedBytes": 77520172,
"domNodes": -258,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 34.53099999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66557377049181,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2041.5259999999762,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.2779999999999996,
"layouts": 7,
"layoutDurationMs": 2.053,
"taskDurationMs": 645.2249999999999,
"heapDeltaBytes": -1197316,
"heapUsedBytes": 80531672,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 34.688,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 630.1799999999957,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.364000000000001,
"layouts": 9,
"layoutDurationMs": 2.4160000000000004,
"taskDurationMs": 414.025,
"heapDeltaBytes": 21557092,
"heapUsedBytes": 88996076,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 146.48999999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667567567567573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 658.92400000007,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.901999999999999,
"layouts": 9,
"layoutDurationMs": 2.7399999999999998,
"taskDurationMs": 490.03200000000004,
"heapDeltaBytes": -1091348,
"heapUsedBytes": 76463432,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 157.56,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664999999999985,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2020.729000000017,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.1079999999999997,
"layouts": 9,
"layoutDurationMs": 2.8609999999999998,
"taskDurationMs": 576.9960000000001,
"heapDeltaBytes": 21566576,
"heapUsedBytes": 88943688,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 12.123000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2024.0440000000035,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.8910000000000005,
"layouts": 9,
"layoutDurationMs": 2.7779999999999996,
"taskDurationMs": 573.35,
"heapDeltaBytes": -223152,
"heapUsedBytes": 77714732,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 11.843,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1972.6220000000012,
"styleRecalcs": 87,
"styleRecalcDurationMs": 18.345999999999997,
"layouts": 8,
"layoutDurationMs": 2.948,
"taskDurationMs": 1063.4229999999998,
"heapDeltaBytes": 11138144,
"heapUsedBytes": 78611896,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 113.76700000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1959.699999999998,
"styleRecalcs": 87,
"styleRecalcDurationMs": 18.627000000000002,
"layouts": 9,
"layoutDurationMs": 3.121,
"taskDurationMs": 913.3299999999999,
"heapDeltaBytes": 11245812,
"heapUsedBytes": 78746964,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 113.19399999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1453.9249999999129,
"styleRecalcs": 20,
"styleRecalcDurationMs": 29.781000000000002,
"layouts": 5,
"layoutDurationMs": 15.41,
"taskDurationMs": 1117.3310000000004,
"heapDeltaBytes": 4990568,
"heapUsedBytes": 100001976,
"domNodes": 15956,
"jsHeapTotalBytes": 17965056,
"scriptDurationMs": 30.337999999999997,
"eventListeners": 3244,
"totalBlockingTimeMs": 147,
"frameDurationMs": 19.297368421052635,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10349.128000000008,
"styleRecalcs": 248,
"styleRecalcDurationMs": 21.456,
"layouts": 5,
"layoutDurationMs": 1.4159999999999997,
"taskDurationMs": 5953.414,
"heapDeltaBytes": 12829696,
"heapUsedBytes": 92059684,
"domNodes": -258,
"jsHeapTotalBytes": 4251648,
"scriptDurationMs": 2650.4399999999996,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.719870759289172,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9442.061000000082,
"styleRecalcs": 250,
"styleRecalcDurationMs": 22.221999999999998,
"layouts": 8,
"layoutDurationMs": 2.286,
"taskDurationMs": 5933.166,
"heapDeltaBytes": 8691808,
"heapUsedBytes": 88345600,
"domNodes": -258,
"jsHeapTotalBytes": 3989504,
"scriptDurationMs": 2638.545,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75488454706927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16865.094999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16204.755,
"heapDeltaBytes": -12095400,
"heapUsedBytes": 287946860,
"domNodes": -3334,
"jsHeapTotalBytes": 23584768,
"scriptDurationMs": 262.27,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.537828371278458,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 24594.56399999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 23888.204999999998,
"heapDeltaBytes": -32837912,
"heapUsedBytes": 258418820,
"domNodes": -3330,
"jsHeapTotalBytes": 12574720,
"scriptDurationMs": 372.63,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.872076788830725,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 29394.92100000001,
"styleRecalcs": 181,
"styleRecalcDurationMs": 22.124000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 29077.66,
"heapDeltaBytes": -18916080,
"heapUsedBytes": 277932776,
"domNodes": -3330,
"jsHeapTotalBytes": 11001856,
"scriptDurationMs": 918.6679999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 47,
"frameDurationMs": 55.99752380952381,
"p95FrameDurationMs": 116.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 20774.60400000007,
"styleRecalcs": 161,
"styleRecalcDurationMs": 16.217999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20404.012000000002,
"heapDeltaBytes": -17120076,
"heapUsedBytes": 264664888,
"domNodes": -3330,
"jsHeapTotalBytes": 19128320,
"scriptDurationMs": 849.603,
"eventListeners": -651,
"totalBlockingTimeMs": 18,
"frameDurationMs": 38.773507462686574,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6398.069000000021,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.06799999999997,
"layouts": 20,
"layoutDurationMs": 33.096000000000004,
"taskDurationMs": 6304.226000000001,
"heapDeltaBytes": 5017924,
"heapUsedBytes": 286848512,
"domNodes": -3330,
"jsHeapTotalBytes": 21749760,
"scriptDurationMs": 112.04299999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.66514285714287,
"p95FrameDurationMs": 83.19999999999891
},
{
"name": "vue-node-resize-workload",
"durationMs": 6497.828000000027,
"styleRecalcs": 20,
"styleRecalcDurationMs": 67.924,
"layouts": 20,
"layoutDurationMs": 26.648000000000003,
"taskDurationMs": 6355.464000000001,
"heapDeltaBytes": 7837456,
"heapUsedBytes": 288792972,
"domNodes": -3330,
"jsHeapTotalBytes": 24633344,
"scriptDurationMs": 112.01399999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.83522727272727,
"p95FrameDurationMs": 66.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 12045.798999999988,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11603.664,
"heapDeltaBytes": 10627584,
"heapUsedBytes": 262326080,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 171.85899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.57773851590106,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8528.186000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8356.373999999998,
"heapDeltaBytes": 19048604,
"heapUsedBytes": 269385668,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 136.40000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.869152542372873,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 149.38100000006216,
"styleRecalcs": 11,
"styleRecalcDurationMs": 12.097999999999997,
"layouts": 10,
"layoutDurationMs": 3.408,
"taskDurationMs": 112.29899999999999,
"heapDeltaBytes": -10641436,
"heapUsedBytes": 68689336,
"domNodes": 97,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 10.695000000000002,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 144.7130000000243,
"styleRecalcs": 11,
"styleRecalcDurationMs": 12.391000000000002,
"layouts": 11,
"layoutDurationMs": 4.674,
"taskDurationMs": 98.56200000000001,
"heapDeltaBytes": -15345376,
"heapUsedBytes": 68119748,
"domNodes": 117,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 7.7,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.677777777777766,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 509.96600000007675,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.382,
"layouts": 76,
"layoutDurationMs": 16.241,
"taskDurationMs": 460.199,
"heapDeltaBytes": -14532544,
"heapUsedBytes": 80218504,
"domNodes": 4,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 218.757,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903224,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 570.5329999999549,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.564,
"layouts": 76,
"layoutDurationMs": 17.851,
"taskDurationMs": 516.276,
"heapDeltaBytes": 12461380,
"heapUsedBytes": 95158412,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 246.42700000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66764705882355,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 576.35700000003,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.761,
"layouts": 76,
"layoutDurationMs": 16.371,
"taskDurationMs": 535.213,
"heapDeltaBytes": 351604,
"heapUsedBytes": 123106888,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 209.45600000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.15588235294118,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 544.4830000000138,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.9,
"layouts": 76,
"layoutDurationMs": 16.299999999999997,
"taskDurationMs": 503.79299999999995,
"heapDeltaBytes": -225520,
"heapUsedBytes": 122615676,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 191.86,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2262 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 1c26bd1c6d96172040c94ab888be429f86484e24
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #19153 +/- ##
==========================================
+ Coverage 86.13% 86.96% +0.83%
==========================================
Files 3653 2609 -1044
Lines 174705 146548 -28157
Branches 48215 38113 -10102
==========================================
- Hits 150476 127443 -23033
+ Misses 22220 18717 -3503
+ Partials 2009 388 -1621
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1076 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…omfy-Org#19143) ## Summary Modules below `scripts/app.ts` in the import graph stop importing the `app` value from it. They call `useApp()` from `scripts/appInstance`, which reads a registry that `app.ts` fills right after constructing `ComfyApp`. Type-only consumers import the new `ComfyApp` interface from `types/comfy`. Clipspace state moves out of the class into `scripts/clipspace`. Import cycles: 409 -> 371 cyclic modules, largest SCC 184 -> 154 (litegraph is now the largest), 1640 -> 1451 cyclic edges, measured with dependency-cruiser on `main` a2dba8f. Targets `main` directly, rebased onto a2dba8f. Tracks FE-2769 / FE-3037. ## Changes - `types/comfy.ts`: `ComfyApp` interface (public instance surface), `QueuePromptOptions`, `LoadGraphDataOptions`. `types/index.ts` re-exports the type from here instead of from `scripts/app`. - `scripts/appRegistry.ts`: `registerApp` / `useApp` (asserts registration). `scripts/appInstance.ts` re-exports `useApp` as the consumer-facing seam so tests can mock it without re-entering `app.ts`. - `scripts/clipspace.ts`: clipspace state plus `copyToClipspace` / `pasteFromClipspace`. `ComfyApp` statics stay as accessors for custom-node compatibility; `litegraphService` and `changeTracker` use the leaf directly. - `class ComfyApp implements ComfyApp` (aliased `IComfyApp` inside `app.ts`). `ANIM_PREVIEW_WIDGET` now lives in `useNodeAnimatedImage.ts` and is re-exported from `app.ts`. - ~40 SCC importers switched to `useApp()` (all call sites are inside functions). On the current base that includes the mask editor composables, `useNodeProgressText` and `useProgressTextWidget`, which joined the SCC after the original PR. Type positions use `ComfyApp['rootGraph']` / `Parameters<ComfyApp['loadGraphData']>[0]`. - `commandStore.loadExtensionCommands` takes `{ name; commands? }` so it no longer imports `ComfyExtension`. - `vitest.setup.ts`: global mock of `@/scripts/appInstance` that resolves `useApp()` to whatever `@/scripts/app` is in the test file (real or per-file mock), awaited in `beforeAll` / `beforeEach`. `firstRunEntry.test.ts`'s `createSharedComposable` stand-in now resets every composable it created rather than only the last one registered. - `scripts/README.md`: documents the interface / `useApp()` / clipspace pattern. - Baselines: `.fallow-baselines/dead-code.json` gains 32 pre-existing cycles (auth, billing, `workflowStore` <-> `executionStore`, the billing paths through `useBillingDialogs`, and `comfyWorkflow -> changeTracker -> workflowStore`) that fallow only enumerates once the hub edges are gone; every entry's modules sit in one SCC on `main`; the entries use fallow's sorted-path key. `health.json` entry for `clipspace.ts`. ## Review Focus - Only modules below `app.ts` use `useApp()`. Top-level code (extensions, components, `App.vue`) keeps `import { app }`. - `useApp()` asserts that `registerApp` has run; every migrated call site runs after `app.ts` evaluates. `appRegistry.test.ts` covers both branches. - The vitest bridge loads `@/scripts/app` asynchronously, so modules in its tree now evaluate after the test subject's imports. `firstRunEntry.test.ts` was the one test sensitive to that ordering. <!-- stack-table:start --> ## Stack Import-cycle progress for FE-3037, measured with `pnpm lint:cycles` (dependency-cruiser on `src`). ### Standalone PRs targeting `main` Each is one commit on current `main` and can merge on its own. Numbers are that PR alone against `origin/main` (1027 cyclic modules, largest cycle 983, 4562 cyclic edges). | PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges | | --- | --- | --- | --- | --- | --- | | Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 -> 884 | 983 -> 677 | 4562 -> 3382 | | Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027 -> 1026 | 983 -> 982 | 4562 -> 4558 | | Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor` extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 | | Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 | | Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf | 1027 -> 1025 | 983 -> 981 | 4562 -> 4552 | | Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027 -> 1027 | 983 -> 983 | 4562 -> 4555 | | Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027 -> 1027 | 983 -> 983 | 4562 -> 4561 | | Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs | 1027 -> 1027 | 983 -> 983 | 4562 -> 4561 | All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111, Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet): 630 cyclic modules, largest cycle 412, 2476 cyclic edges. ### Remaining stack Bottom to top, with current bases. Numbers are from the original 26-PR stack, each PR against its parent at the time, on the older `main` the stack forked from (967 cyclic modules then). They have not been remeasured since the eight PRs above left the stack. Where the base changed, the parent the numbers were measured on is in parentheses. Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is rebased. | PR | Base | Change | Cyclic modules | Largest cycle | | --- | --- | --- | --- | --- | | Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) | 967 (baseline) | 923 (baseline) | | Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types | 967 -> 949 | 923 -> 905 | | Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 | | Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not `extensionService` | 669 -> 580 | 465 -> 371 | | Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers | 580 -> 566 | 371 -> 357 | | Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from the app shell | 558 -> 509 | 349 -> 297 | | Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell | 509 -> 496 | 297 -> 284 | | Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs from GraphView | 484 -> 476 | 272 -> 264 | | Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser routing onto the sidebar tab | 471 -> 467 | 257 -> 253 | | Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467 -> 464 | 253 -> 250 | | Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 -> 447 | 250 -> 233 | | Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` | 447 -> 428 | 233 -> 214 | | Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of `dialogService` | 400 -> 391 | 181 -> 172 | | **Comfy-Org#19143** (this PR) | **Comfy-Org#19131** | **Invert `scripts/app` behind `useApp()`** | **391 -> 352** | **172 -> 149** | | Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the facade | 352 -> 324 | 149 (baseline) | | Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow contracts as leaves | 324 -> 293 | 149 (baseline) | | Comfy-Org#19186 | Comfy-Org#19153 | Workbench cycles: `openManager` onto `useManagerDialog`, agent leaves | 293 -> 259 | 149 (baseline) | | Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth dialogs, menu, and more | 259 -> 211 | 149 (baseline) | <!-- stack-table:end --> --------- Co-authored-by: Amp <amp@ampcode.com>
f363565 to
887c40c
Compare
20695c0 to
7ad22d6
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed rebased head 7ad22d6 against main base bf2ff8b. I found no actionable correctness issues in the changed workflow/runtime boundary, missing-model extraction, dialog service typing, or legacy UI host wiring. All observed required checks are complete and successful. The aggregate main-branch deps audit remains an environment handoff: package.json defines pnpm deps:audit as depcruise src and requires Node >=26.8.2 <27.
| /** | ||
| * Exposed store interface for the workflow store. | ||
| * Explicitly typed to avoid trigger following error: | ||
| * error TS7056: The inferred type of this node exceeds the maximum length the | ||
| * compiler will serialize. An explicit type annotation is needed. | ||
| */ |
There was a problem hiding this comment.
Since the interface is no longer owned by the store, this comment is not longer accurate.
0441289
|
Fixed in 0441289: Addressed AustinMroz’s stale-interface-comment finding by deleting the copied TS7056 explanation. No types or behavior changed. Commits pushed: 0441289502. Validation: formatting, lint, app typecheck, Knip, and Fallow passed through the enabled Git hooks. Runtime tests were not needed for a comment-only deletion. The earlier seven findings already have answers; no new review-body or top-level finding remained in this round. No threads resolved. |
The public extension contract in types/comfy.ts no longer reaches scripts/appInstance. Widget constructor types move into types/comfy, MissingModelPipelineResult into platform/missingModel/types, and the legacy menu (scripts/ui.ts) takes its app and host collaborators as constructor arguments. comfyWorkflow.ts becomes a leaf: the change tracker, draft persistence, and settings are registered by the workflow store through a WorkflowRuntime, and the save-as name prompt moves to workflowService with the copy supplied as i18n keys. WorkflowStore and the dialog service contracts are declared in new leaf modules so extensionTypes.ts stops importing the stores. Import cycles: 487 -> 391 cyclic modules, largest SCC 273 -> 153 (the 273-module app SCC splits into 119 + 58 modules). Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
0441289 to
8c3327b
Compare
## Summary Removes the import cycles left inside `src/workbench`: the 28-module manager cycle and the agent CRDT status cycle. `workbench/` is now cycle-free, which is a prerequisite for giving it its own TypeScript project reference. Import cycles: 341 -> 311 cyclic modules, 20 -> 18 cycles, largest SCC 154 -> 154 (litegraph), 1335 -> 1262 cyclic edges, on top of Comfy-Org#19153 (rebased onto `main` df4ea6d). Stacked on Comfy-Org#19153 (rebased onto the `drjkl/comfy-types-leaf` chain). Tracks FE-2769 / FE-3037. ## Changes - Manager: `useManagerState` had two responsibilities, deriving the manager UI state and opening the manager. Opening needs `useManagerDialog`, which imports `ManagerDialog.vue`, whose subtree imports `useManagerState` again. `openManager` moves to `useManagerDialog`, which already owns `show()`/`hide()`. `useManagerState` keeps the state derivations and the once-per-session upgrade toast, and exports `showIncompatibleManagerToast({ force })` so the explicit-click re-emit lives with `openManager`. - Callers (`useCoreCommands`, `TopMenuSection`, `ComfyMenuButton`, `HelpCenterMenuContent`, `ErrorGroupList`, `MissingPackGroupRow`) call `useManagerDialog().openManager(...)`. `ComfyMenuButton` no longer needs `useManagerState`. The legacy-menu error toast in `openManager` uses the `useToast()` API from Comfy-Org#16313, as `useManagerState` does on `main`. - Tests: `openManager` coverage moves from `useManagerState.test.ts` to `useManagerDialog.test.ts` and now covers all four states (DISABLED, INCOMPATIBLE, LEGACY_UI with and without `showToastOnLegacyError`, NEW_UI with and without `isLegacyOnly`) by driving the real `useManagerState` through `systemStatsStore` and spied `api` feature flags. The shared `__mocks__/useManagerState.ts` drops `openManager`; a new `__mocks__/useManagerDialog.ts` covers component tests. - Agent composer: the `ComposerAttachment` leaf this PR originally introduced already landed on main (`types/composerAttachment.ts`), so that part is dropped. - Agent CRDT: `AgentCrdtStatus` and `AgentCrdtOutcomeCounters` move to a new leaf `crdt/agentCrdtStatus.ts` so `crdtSnapshot.ts` stops importing `useAgentCrdtFollower.ts`. - fallow baselines: `dead-code.json` is unchanged (the stale manager entries stay as unused baseline rows); the `crap_high` entry for `openManager` moves from `useManagerState.ts` to `useManagerDialog.ts` in `health.json` (same function, new file). ## Review Focus - `openManager` now calls `useManagerState()` per invocation. Its `watch(..., { immediate: true })` runs once per call and can fire the once-per-session INCOMPATIBLE toast if no component had instantiated the composable yet. That matches the previous behaviour, where every caller instantiated `useManagerState()` before calling `openManager`. - `useManagerDialog` now imports `useManagerState`; the dependency direction is dialog -> state, matching `useManagerDialog -> ManagerDialog.vue -> ... -> useManagerState`. <!-- stack-table:start --> ## Stack Import-cycle progress for FE-3037, measured with `pnpm lint:cycles` (dependency-cruiser on `src`). ### Standalone PRs targeting `main` Each is one commit on current `main` and can merge on its own. Numbers are that PR alone against `origin/main` (1027 cyclic modules, largest cycle 983, 4562 cyclic edges). | PR | Base | Change | Cyclic modules | Largest cycle | Cyclic edges | | --- | --- | --- | --- | --- | --- | | Comfy-Org#19089 | `main` | `ServerFeatureFlag` enum to a leaf module | 1027 -> 884 | 983 -> 677 | 4562 -> 3382 | | Comfy-Org#19094 | `main` | Empty-workflow dialog out of `appModeStore` | 1027 -> 1026 | 983 -> 982 | 4562 -> 4558 | | Comfy-Org#19109 | `main` | Mask editor menu item into `Comfy.MaskEditor` extension | 1027 -> 1027 | 983 -> 983 | 4562 -> 4562 | | Comfy-Org#19112 | `main` | `PositionConfig` and layer editor dialog key to leaf modules | 1027 -> 1027 | 983 -> 983 | 4562 -> 4558 | | Comfy-Org#19122 | `main` | `settingStore` off `scripts/app`; `$el` to a leaf | 1027 -> 1025 | 983 -> 981 | 4562 -> 4552 | | Comfy-Org#19124 | `main` | `MissingNodeType` to the nodeReplacement leaf | 1027 -> 1027 | 983 -> 983 | 4562 -> 4555 | | Comfy-Org#19125 | `main` | Blueprint node defs owned by `nodeDefStore` | 1027 -> 1027 | 983 -> 983 | 4562 -> 4561 | | Comfy-Org#19127 | `main` | Thumbnail and minimap data from explicit inputs | 1027 -> 1027 | 983 -> 983 | 4562 -> 4561 | All eight together on `main`, plus Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19108, Comfy-Org#19111, Comfy-Org#19116 and Comfy-Org#19113 (checked locally; those six are not retargeted yet): 630 cyclic modules, largest cycle 412, 2476 cyclic edges. ### Remaining stack Bottom to top, with current bases. Numbers are from the original 26-PR stack, each PR against its parent at the time, on the older `main` the stack forked from (967 cyclic modules then). They have not been remeasured since the eight PRs above left the stack. Where the base changed, the parent the numbers were measured on is in parentheses. Comfy-Org#19091, Comfy-Org#19107, Comfy-Org#19111, Comfy-Org#19113 and Comfy-Org#19131 still carry the old commits of the PRs they were moved off (Comfy-Org#19131 carries Comfy-Org#19122, Comfy-Org#19124, Comfy-Org#19125 and Comfy-Org#19127), so their GitHub diffs are wider than one PR until the stack is rebased. | PR | Base | Change | Cyclic modules | Largest cycle | | --- | --- | --- | --- | --- | | Comfy-Org#19085 | `main` | Import-cycle baseline check (`pnpm lint:cycles`) | 967 (baseline) | 923 (baseline) | | Comfy-Org#19088 | Comfy-Org#19085 | Split litegraph `interfaces.ts` into leaf types | 967 -> 949 | 923 -> 905 | | Comfy-Org#19091 | Comfy-Org#19088 (measured on Comfy-Org#19089) | Register core sidebar tabs outside `sidebarTabStore` | 816 -> 669 | 618 -> 465 | | Comfy-Org#19092 | Comfy-Org#19091 | Load extensions from bootstrap, not `extensionService` | 669 -> 580 | 465 -> 371 | | Comfy-Org#19093 | Comfy-Org#19092 | Split `scripts/widgets.ts` registry, types, helpers | 580 -> 566 | 371 -> 357 | | Comfy-Org#19107 | Comfy-Org#19093 (measured on Comfy-Org#19094) | Register settings dialog from the app shell | 558 -> 509 | 349 -> 297 | | Comfy-Org#19108 | Comfy-Org#19107 | Register asset browser modal from the app shell | 509 -> 496 | 297 -> 284 | | Comfy-Org#19111 | Comfy-Org#19108 (measured on Comfy-Org#19109) | Register core bottom panel tabs from GraphView | 484 -> 476 | 272 -> 264 | | Comfy-Org#19113 | Comfy-Org#19111 (measured on Comfy-Org#19112) | Model library asset-browser routing onto the sidebar tab | 471 -> 467 | 257 -> 253 | | Comfy-Org#19116 | Comfy-Org#19113 | Progress text previews out of `executionStore` | 467 -> 464 | 253 -> 250 | | Comfy-Org#19118 | Comfy-Org#19116 | Inject the api auth provider from `main.ts` | 464 -> 447 | 250 -> 233 | | Comfy-Org#19121 | Comfy-Org#19118 | Install workspace api credentials from `main.ts` | 447 -> 428 | 233 -> 214 | | Comfy-Org#19131 | Comfy-Org#19121 (measured on Comfy-Org#19127) | Feature dialogs out of `dialogService` | 400 -> 391 | 181 -> 172 | | Comfy-Org#19143 | Comfy-Org#19131 | Invert `scripts/app` behind `useApp()` | 391 -> 352 | 172 -> 149 | | Comfy-Org#19148 | Comfy-Org#19143 | Billing rails announce refreshes; dialogs above the facade | 352 -> 324 | 149 (baseline) | | Comfy-Org#19153 | Comfy-Org#19148 | `types/comfy`, `comfyWorkflow`, dialog/workflow contracts as leaves | 324 -> 293 | 149 (baseline) | | **Comfy-Org#19186** (this PR) | **Comfy-Org#19153** | **Workbench cycles: `openManager` onto `useManagerDialog`, agent leaves** | **293 -> 259** | **149 (baseline)** | | Comfy-Org#19189 | Comfy-Org#19186 | Thirteen small app cycles: ui, nodeDef, auth dialogs, menu, and more | 259 -> 211 | 149 (baseline) | <!-- stack-table:end --> --------- Co-authored-by: Amp <amp@ampcode.com>
Summary
types/comfy.tsis the public extension contract, yet it importedscripts/widgets,scripts/ui, and the workflow store, so every module that typed againstComfyAppwas pulled into the app's largest import cycle. This PR makestypes/comfy.ts,types/extensionTypes.ts, andcomfyWorkflow.tsleaves: they no longer reachscripts/appInstance. Before the review fixes, depcruise measured the 273-module app SCC splitting into 119 + 58 modules.Import-cycle measurements before the review fixes: 371 -> 341 cyclic modules, largest SCC 154 -> 154 (litegraph), 1451 -> 1335 cyclic edges, on
maindf4ea6d (#19143 merged as cdc9fe0). These counts have not been remeasured after restoring the extension hooks.workflowStoreTypes.tscarries main'snodeLocatorIdToNodeId: ... => NodeId | nullsignature, which landed onmainafter the interface moved.Targets
maindirectly, rebased onto df4ea6d after #19143 merged (cdc9fe0). Tracks FE-2769 / FE-3037.Changes
ComfyWidgetConstructor/CustomComfyWidgetConstructorare declared intypes/comfy.ts;scripts/widgets.tsimports them.ComfyApp.widgetsis typed asRecord<string, ComfyWidgetConstructor | CustomComfyWidgetConstructor>instead oftypeof ComfyWidgets, anddynamicComboWidgetnarrows the result ofapp.widgets.COMBO.MissingModelPipelineResultmoves toplatform/missingModel/types.ts;groupCandidatesByNamemoves intomissingModelGrouping.tsso grouping stops importing scan.scripts/ui.ts:ComfyUI(app, host)takes the app and aLegacyMenuHost(resetView,restoreOutputs,trackRunButton,enterFocusMode) instead of callinguseApp(),litegraphService,nodeOutputStore,workspaceStore, anduseRunButtonTelemetry.app.tswires the host.comfyWorkflow.tsbecomes a leaf.WorkflowChangeTrackeris an interfaceChangeTrackerimplements. AWorkflowRuntime(createChangeTracker, draft get/remove/markUsed,isDraftPersistenceEnabled) is registered byworkflowStore.tsat module scope, replacing the dynamicimport('@/scripts/changeTracker')and the direct settings/draft-store imports.ComfyWorkflow.promptSave()remains an extension override point. Its default delegates to the registeredWorkflowRuntime, which opens the dialog usingsaveNamePrompti18n keys, overridden bySubgraphBlueprint.workflowService.saveWorkflowAscontinues calling the hook.ComfyApp.pasteFromClipspaceoverrides. Image paste updates store-backed outputs without requiring legacy previews and skips absent selections while still pasting widget values.workflowStoreTypes.tsexports theWorkflowStoreinterface;ExtensionManager.workflowis typed asWorkflowStore.services/dialogServiceTypes.tswithCoreDialogService,ExtensionDialogService,ConfirmOptions,ExecutionErrorDialogInput;useDialogService()returnsCoreDialogServiceandextensionTypes.tsimports the leaf.ExtensionDialogServicecarries main's current signatures (showCancelSubscriptionDialogscope/confirmed args,paymentIntentSource,showInviteLinkInvalidDialog,showInviteWrongAccountDialog).comfyWorkflow.test.tsdeleted (it tested the dynamic-import failure path that no longer exists);workflowService.test.tsmocksuseDialogService().promptand asserts the save-name copy;ui.test.ts/ui.setStatus.test.tspass the app and a stub host.Review Focus
ComfyApp.widgetsloses thetypeof ComfyWidgetskey typing. Core widget constructors are still reachable asuseWidgetStore().coreWidgets; extension code indexingapp.widgets.<Name>now gets the union type.ExtensionManager.workflowno longer exposes Pinia$-methods on the public type. Extensions callingapp.extensionManager.workflow.$patchwould be a type break (runtime unchanged).ComfyWorkflow.promptSaveis preserved because RigShare and Bada-Utils wrap its prototype implementation to customize Save As. A regression test checks that an override's filename reaches the save path.workflowStore.tsnow importsChangeTrackerstatically. fallow sees the previously dynamiccomfyWorkflow -> workflowStore -> changeTracker3-cycle reshaped into two shortworkflowStore <-> changeTrackercycles; this plus 28 pre-existing cycles fallow newly enumerates (auth/session, api <-> authStore <-> dialogService, promotionUtils through canvasStore and litegraphService, useAppMode -> workflowStore -> changeTracker -> executionStore, workflowStore <-> executionStore, canvasStore <-> litegraphUtil) are baselined in.fallow-baselines/dead-code.json. BreakingchangeTracker -> workflowStoreneeds a host injection intoChangeTrackerand a rewrite of its 1400-line test, so it is left for a follow-up.dynamicComboWidgetkeeps the runtime lookup throughapp.widgets.COMBO. A static import ofuseComboWidgetorwidgetStorefromdynamicWidgets.tscreates a module-evaluation cycle withscripts/widgets.ts(...dynamicWidgetsspread sees an uninitialised binding), which is why the assert-based narrowing is used instead.Stack
Import-cycle progress for FE-3037, measured with
pnpm lint:cycles(dependency-cruiser onsrc).Standalone PRs targeting
mainEach is one commit on current
mainand can merge on its own. Numbers are that PR alone againstorigin/main(1027 cyclic modules, largest cycle 983, 4562 cyclic edges).mainServerFeatureFlagenum to a leaf modulemainappModeStoremainComfy.MaskEditorextensionmainPositionConfigand layer editor dialog key to leaf modulesmainsettingStoreoffscripts/app;$elto a leafmainMissingNodeTypeto the nodeReplacement leafmainnodeDefStoremainAll eight together on
main, plus #19091, #19107, #19108, #19111, #19116 and #19113 (checked locally; those six are not retargeted yet): 630 cyclic modules, largest cycle 412, 2476 cyclic edges.Remaining stack
Bottom to top, with current bases. Numbers are from the original 26-PR stack, each PR against its parent at the time, on the older
mainthe stack forked from (967 cyclic modules then). They have not been remeasured since the eight PRs above left the stack. Where the base changed, the parent the numbers were measured on is in parentheses.#19091, #19107, #19111, #19113 and #19131 still carry the old commits of the PRs they were moved off (#19131 carries #19122, #19124, #19125 and #19127), so their GitHub diffs are wider than one PR until the stack is rebased.
mainpnpm lint:cycles)interfaces.tsinto leaf typessidebarTabStoreextensionServicescripts/widgets.tsregistry, types, helpersexecutionStoremain.tsmain.tsdialogServicescripts/appbehinduseApp()types/comfy,comfyWorkflow, dialog/workflow contracts as leavesopenManagerontouseManagerDialog, agent leaves