Repository navigation
fix: play agent-generated video assets in the Media Assets panel - #18096
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2039 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 9.92 MB gzip 🔴 +77 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 638 kB (baseline 638 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 17 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 3.86 MB (baseline 3.86 MB) • 🔴 +558 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 566 kB (baseline 566 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 19 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.7 MB (baseline 17.7 MB) • 🔴 +79 BBundles that do not match a named category
Status: 74 added / 74 removed / 224 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-20T02:12:54.936Z",
"gitSha": "ae0ab325b3c337bfc8a1126f2526384558ff6833",
"branch": "test/agent-video-asset-thumbnail-repro-v2",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2011.8059999999787,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.256000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.757,
"heapDeltaBytes": 9566304,
"heapUsedBytes": 70858632,
"domNodes": -263,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 9.751,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2005.9969999999794,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.840999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.966,
"heapDeltaBytes": 15027760,
"heapUsedBytes": 77134088,
"domNodes": -265,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 10.439,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2006.6700000000424,
"styleRecalcs": 79,
"styleRecalcDurationMs": 39.190000000000005,
"layouts": 14,
"layoutDurationMs": 5.424,
"taskDurationMs": 920.965,
"heapDeltaBytes": 10232312,
"heapUsedBytes": 71713580,
"domNodes": -264,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 195.95200000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1822.251999999935,
"styleRecalcs": 76,
"styleRecalcDurationMs": 29.432000000000002,
"layouts": 14,
"layoutDurationMs": 4.021,
"taskDurationMs": 872.99,
"heapDeltaBytes": 18299240,
"heapUsedBytes": 80274260,
"domNodes": -260,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 166.784,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.3090000000093,
"styleRecalcs": 31,
"styleRecalcDurationMs": 17.889000000000003,
"layouts": 6,
"layoutDurationMs": 1.2950000000000002,
"taskDurationMs": 371.63900000000007,
"heapDeltaBytes": 2175668,
"heapUsedBytes": 64304636,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 13.028000000000002,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.4159999999156,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.716000000000005,
"layouts": 6,
"layoutDurationMs": 1.3060000000000003,
"taskDurationMs": 374.87000000000006,
"heapDeltaBytes": 2157420,
"heapUsedBytes": 64214872,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 13.508,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 697.527999999977,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.124,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.40400000000005,
"heapDeltaBytes": 18275688,
"heapUsedBytes": 79968664,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 169.406,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 666.3690000000315,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.782000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.5349999999999,
"heapDeltaBytes": 17930720,
"heapUsedBytes": 79922848,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 169.12099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2033.687000000043,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.289999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 630.4170000000001,
"heapDeltaBytes": 2697328,
"heapUsedBytes": 83052484,
"domNodes": -253,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 36.818000000000005,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2026.153000000022,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.771000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.382,
"heapDeltaBytes": 1507888,
"heapUsedBytes": 82544536,
"domNodes": -251,
"jsHeapTotalBytes": -1806336,
"scriptDurationMs": 41.56999999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2355.8289999999715,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.964000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1712.5980000000002,
"heapDeltaBytes": 3029824,
"heapUsedBytes": 83241044,
"domNodes": -255,
"jsHeapTotalBytes": -569344,
"scriptDurationMs": 861.758,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2401.7000000000053,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.817999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1723.001,
"heapDeltaBytes": 14798508,
"heapUsedBytes": 78959152,
"domNodes": -256,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 889.0559999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3584.208999999987,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.867,
"layouts": 60,
"layoutDurationMs": 13.171999999999999,
"taskDurationMs": 1728.8190000000002,
"heapDeltaBytes": 8417568,
"heapUsedBytes": 73965764,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 795.882,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3626.9360000000006,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.028999999999996,
"layouts": 60,
"layoutDurationMs": 13.239999999999998,
"taskDurationMs": 1735.845,
"heapDeltaBytes": 8059628,
"heapUsedBytes": 73814208,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 802.0350000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3101.122000000032,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.845999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1918.0220000000002,
"heapDeltaBytes": 14460296,
"heapUsedBytes": 80344752,
"domNodes": 0,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 965.187,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3176.4340000000857,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.939000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2020.385,
"heapDeltaBytes": 1232812,
"heapUsedBytes": 84995372,
"domNodes": -259,
"jsHeapTotalBytes": 933888,
"scriptDurationMs": 1000.418,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 1996.5359999999919,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.384000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 558.7980000000001,
"heapDeltaBytes": 20083328,
"heapUsedBytes": 84660580,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.231999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2031.7320000000336,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.278999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 613.437,
"heapDeltaBytes": -5755516,
"heapUsedBytes": 81685796,
"domNodes": -256,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 37.50200000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 578.897999999981,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.841,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.736,
"heapDeltaBytes": 13527328,
"heapUsedBytes": 76893336,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 145.36,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 579.9440000000686,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.184,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.9389999999999,
"heapDeltaBytes": 13439304,
"heapUsedBytes": 76873436,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 141.279,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2015.9280000000308,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.004000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.61100000000005,
"heapDeltaBytes": 9113128,
"heapUsedBytes": 72546876,
"domNodes": -275,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.353,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2001.0469999999714,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.127000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 500.16399999999993,
"heapDeltaBytes": -138212,
"heapUsedBytes": 63316684,
"domNodes": -278,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.568,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1719.001999999989,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.455000000000005,
"layouts": 18,
"layoutDurationMs": 5.087,
"taskDurationMs": 813.372,
"heapDeltaBytes": 11553664,
"heapUsedBytes": 74897736,
"domNodes": -279,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 111.038,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1717.7709999999706,
"styleRecalcs": 78,
"styleRecalcDurationMs": 28.05,
"layouts": 18,
"layoutDurationMs": 4.967,
"taskDurationMs": 832.383,
"heapDeltaBytes": 1052520,
"heapUsedBytes": 64438772,
"domNodes": -277,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 115.259,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.9519999999375,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.213000000000005,
"layouts": 5,
"layoutDurationMs": 13.044,
"taskDurationMs": 979.665,
"heapDeltaBytes": -8240188,
"heapUsedBytes": 81369576,
"domNodes": 13587,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 33.88700000000001,
"eventListeners": 2383,
"totalBlockingTimeMs": 144,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8681.11399999998,
"styleRecalcs": 248,
"styleRecalcDurationMs": 37.263,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6114.936,
"heapDeltaBytes": -10693124,
"heapUsedBytes": 75585736,
"domNodes": -249,
"jsHeapTotalBytes": -40960,
"scriptDurationMs": 2925.301,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8523.774000000003,
"styleRecalcs": 248,
"styleRecalcDurationMs": 37.513999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6080.072999999999,
"heapDeltaBytes": -4717588,
"heapUsedBytes": 75286116,
"domNodes": -248,
"jsHeapTotalBytes": 741376,
"scriptDurationMs": 2862.0150000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17429.38700000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16872.36,
"heapDeltaBytes": -35030524,
"heapUsedBytes": 189250308,
"domNodes": -8061,
"jsHeapTotalBytes": -17207296,
"scriptDurationMs": 272.618,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17324.883,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16939.587,
"heapDeltaBytes": -60972700,
"heapUsedBytes": 169471212,
"domNodes": -8061,
"jsHeapTotalBytes": -8450048,
"scriptDurationMs": 274.111,
"eventListeners": -14927,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20791.538000000004,
"styleRecalcs": 150,
"styleRecalcDurationMs": 19.46299999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20571.941,
"heapDeltaBytes": -64070556,
"heapUsedBytes": 166932964,
"domNodes": -8061,
"jsHeapTotalBytes": -10555392,
"scriptDurationMs": 949.346,
"eventListeners": -14928,
"totalBlockingTimeMs": 126,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21066.34699999995,
"styleRecalcs": 154,
"styleRecalcDurationMs": 19.402999999999977,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20860.664,
"heapDeltaBytes": -47797124,
"heapUsedBytes": 168730148,
"domNodes": -8061,
"jsHeapTotalBytes": -13766656,
"scriptDurationMs": 912.711,
"eventListeners": -14928,
"totalBlockingTimeMs": 169,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6308.677999999986,
"styleRecalcs": 20,
"styleRecalcDurationMs": 102.75400000000002,
"layouts": 20,
"layoutDurationMs": 35.917,
"taskDurationMs": 6255.8060000000005,
"heapDeltaBytes": -41087892,
"heapUsedBytes": 168555312,
"domNodes": -8060,
"jsHeapTotalBytes": 9891840,
"scriptDurationMs": 111.048,
"eventListeners": -14928,
"totalBlockingTimeMs": 517,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6221.86499999998,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.33699999999999,
"layouts": 20,
"layoutDurationMs": 23.949000000000012,
"taskDurationMs": 6153.728000000001,
"heapDeltaBytes": -53666160,
"heapUsedBytes": 181579824,
"domNodes": -8061,
"jsHeapTotalBytes": 13828096,
"scriptDurationMs": 107.54200000000002,
"eventListeners": -14928,
"totalBlockingTimeMs": 354,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8772.611999999981,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8552.356000000002,
"heapDeltaBytes": 536120,
"heapUsedBytes": 190606216,
"domNodes": 0,
"jsHeapTotalBytes": -7077888,
"scriptDurationMs": 156.8489999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8770.727999999963,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8430.469,
"heapDeltaBytes": 8903568,
"heapUsedBytes": 186732276,
"domNodes": 0,
"jsHeapTotalBytes": -7340032,
"scriptDurationMs": 136.737,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 476.42099999995935,
"styleRecalcs": 22,
"styleRecalcDurationMs": 32.042,
"layouts": 5,
"layoutDurationMs": 2.2390000000000003,
"taskDurationMs": 155.04299999999998,
"heapDeltaBytes": 5242964,
"heapUsedBytes": 66984596,
"domNodes": 151,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 18.688,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 108.89399999996385,
"styleRecalcs": 9,
"styleRecalcDurationMs": 16.556,
"layouts": 3,
"layoutDurationMs": 1.659,
"taskDurationMs": 79.70799999999997,
"heapDeltaBytes": 2959172,
"heapUsedBytes": 64350688,
"domNodes": 127,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.054000000000002,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 6a15cc1b4b242c2a704c8f83b220dd41ac28da1f
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #18096 +/- ##
==========================================
+ Coverage 82.79% 83.80% +1.01%
==========================================
Files 2947 2251 -696
Lines 145101 128081 -17020
Branches 37370 34499 -2871
==========================================
- Hits 120136 107342 -12794
+ Misses 23699 20449 -3250
+ Partials 1266 290 -976
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 707 files with indirect coverage changes 🚀 New features to boost your workflow:
|
jaeone94
left a comment
There was a problem hiding this comment.
Reviewed 54700bb9b5. The production fix looks appropriately scoped, and the correctness and regression passes found no new production blocker. The remaining concerns are primarily the regression tests and the explanation of the drag failure.
The history investigation points to the assets-backed panel migration in #15381: history previously supplied original video URLs, whereas an assets-API record without preview fields leaves the card without a source. This fallback restores that shared video/audio behavior. I would describe this as an asset-panel regression; the evidence does not establish that agent generation recently stopped producing metadata. Existing preview precedence, grouped assets' underlying file IDs, history URLs, and download/3D callers are preserved.
For the two review-focus questions:
- Keep the
disposition: 'inline'option. It matches the existing backend contract and makes the caller's intent clear. A separate “playable” helper would add little here; inline disposition alone does not guarantee codec support or successful playback. - Track audio performance separately. The waveform player fetches and decodes the whole file as soon as it receives a source, independently of the media element's
preload="metadata". Restoring missing URLs activates that work for these assets too. Virtualization limits mounted cards, but the waveform composable has no unmount cancellation for its in-flight download. A follow-up should measure large/multiple audio assets and scrolling or closing the panel. I have not established a blocking performance regression.
The test changes I recommend are:
-
Make the video E2E prove playback. The current assertion only checks that
currentSrcis nonempty. I forced the content response to return 404 and the test still passed, withreadyState = 0,currentTime = 0, and media error code 4. Serve an existing MP4 fixture only at the expected asset-ID URL, reject incorrect IDs, and assert that video dimensions load andcurrentTimeadvances after clicking Play. A temporary version of that stronger test passed locally on this head. The consent-video test already uses the advancing-time pattern. -
Correct the drag test's fixture and expected failure. This test serves
plain_video.mp4and expects an embedded workflow to open. I verified with the production metadata parser that this fixture has no recognized workflow, whileworkflowInMedia/workflow.mp4does. The expectation therefore fails even with correct metadata handling. Also, serving the same file for every content ID hides the job-ID versus asset-ID error. Please consolidate this coverage with #18111's actual workflow-bearing fixture and exact asset-ID routing, and update this PR's upstream-metadata explanation accordingly. This does not require bringing the drag production fix into this PR. -
Cover the audio fallback at component level. The new component case only exercises video. Removing just the audio fallback still left all 32 tests in the two affected unit files passing. A small video/audio table that checks source delivery to each media element should cover this without duplicating the E2E suite.
-
Remove the new Testing Library suppression. The added DOM query disables both
no-containerandno-node-access. A stable test ID andscreen.findByTestIdwould avoid those exceptions, the manual polling, and the non-null assertion, consistent with the repository's testing principles.
For test structure, the existing helpers and shared feature-flag mock are sufficient; no additional harness is needed. The new “defaults to no disposition param” case duplicates existing exact-URL assertions. The fixture data and route setup can also follow the existing fixtures/data and scoped beforeEach conventions when revising the E2E.
Local regression proof: the two affected unit files passed 32/32 on this head; keeping the tests and restoring the two production files to the PR base produced 2 failures / 30 passes; restoring the head returned 32/32. Thus the new unit tests do catch the original missing-source/inline-option changes. The original browser spec had one passing playback test and one expected drag failure; the forced-404 and stronger real-playback checks above were separate temporary runs. These ran serially with one worker. Browser checks used local Chromium and a Cloud-configured frontend, with a temporary local users-proxy adjustment for the test backend. All temporary changes were restored. I did not rerun the full lint/typecheck/build suites.
|
Thanks for the thorough pass. Addressed in 5078410:
Generated by Claude Code |
jaeone94
left a comment
There was a problem hiding this comment.
Re-reviewed 50784100 against my previous comments. The concerns are addressed, and I found no new blocking issues.
The playback E2E now uses a workflow-bearing MP4 served only at the correct asset-ID URL and verifies loaded video dimensions and advancing playback time. The component tests cover both video and audio source delivery. The new lint suppression and redundant default-option test are removed, and the fixture/setup reuse existing conventions.
Focused verification, run locally with one worker:
- Both affected unit files passed: 32/32. Restoring the pre-fix production code caused the three relevant tests to fail; restoring the fix returned all 32 to green.
- Removing only the audio fallback failed the audio row, confirming that the previous coverage gap is closed.
- The playback E2E passed, failed when the MP4 response was forced to 404, and passed again after restoring the response.
- Scoped ESLint passed for all nine changed files.
The drag test remains an expected failure in this parent PR. I confirmed that the same test passes without retries in #18111's CI, where the production drag fix belongs. Keeping the inline-disposition option is appropriate; audio waveform download/decode performance remains a separate, non-blocking follow-up.
88fe75c to
35108ab
Compare
|
The The same test fails identically on main's own run for 7806755 (https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35478298723), since #17730 merged over a red cloud check. It is not this PR's change: the PR touches no agent canvas code, and both The fix belongs on main. Either regenerate await expect(page.locator('#graph-canvas')).toHaveScreenshot(
'two-turn-dependent-edit-wired.png',
{
mask: [
agentConversation.panel,
page.getByTestId('minimap-container'),
page.getByTestId('agent-graph-added-toast')
]
}
)Generated by Claude Code |
35108ab to
1992034
Compare
…/playback/metadata bugs Adds two test.fail() Playwright specs that reproduce the reported bug in the Comfy Agent / cloud media panel: a generated video asset with no thumbnail_url/preview_url renders a black tile with an unplayable <video> (MediaAssetCard.vue's src fallback has no case for video, unlike the '3D' kind), and dragging such an asset onto the canvas attaches no workflow metadata to the resulting node. Both tests mock the /api/assets network boundary the same way the existing "Assets sidebar - cloud exports" tests in assets.spec.ts do, and are expected to start passing once the bug is fixed.
MediaAssetCard's src fallback (thumbnail_url || preview_url || '') left video/audio assets with an empty <video>/<audio> src whenever the backend had not populated a preview - which it never does for agent/cloud-generated video or audio outputs. The result was a black, unplayable tile. Mirror the existing '3D' fallback: when no server preview exists for a video or audio asset, point the element at the asset's own real content URL via getAssetFileUrl(), now with an explicit disposition=inline query param so the assets-API content endpoint serves it for in-page playback instead of forcing a download (its default is Content-Disposition: attachment). Existing callers of getAssetFileUrl() (downloads, the 3D viewer) are unaffected since the new disposition option defaults to unset. Video is unmounted while off-screen (VirtualGrid) and already loads with preload="metadata", so this does not turn the grid into an eager full-file video downloader. Flips the corresponding e2e assertion in agentVideoAsset.spec.ts from test.fail() to a passing assertion; the drag-to-canvas workflow-metadata test is left as test.fail() (separate, likely upstream/backend gap).
- The video E2E serves the MP4 fixture only at the card's own asset-id content URL (every other id gets the backend's 404 body) and asserts the dimensions load and currentTime advances after clicking play, instead of only checking currentSrc is non-empty. - The drag E2E uses the workflow-bearing fixture with the same exact-id routing; it stays an expected failure until #18111 lands. - The component test covers the video and audio fallback as one table and queries the media elements by test id instead of DOM traversal. - Drop the redundant disposition-default case in assetUrlUtil.test.ts.
1992034 to
8f23ccc
Compare
…mid-turn doc reset (PM-1355-shaped) Intentionally-failing repro for the nightly bug report (Jo Zhang, 2026-09-20): asking the in-app agent to run the canvas workflow blanks the canvas the moment the agent starts working, for the whole run, with every node reappearing at once when the run finishes. No fix is attempted here. Two independently-confirmed frontend mechanisms combine to produce exactly that timeline: - A `doc_reset`/`follower_replaced` frame synchronously sweeps every live materialized node off the canvas (`AgentCrdtProjection.clearForReset`) -- the only path that actively removes already-rendered nodes. - The resubscribe that follows can be acknowledged (`doc_subscribed:ok`) without its catch-up `doc_update`. This exact anomaly is visible in the bug report's own attached debug log, on a different (later, smaller) workflow in the same session, self-healing only via the passive 30-second `STALE_AFTER_MS` stale-probe heartbeat (`agentCrdtDocLifecycle.ts`) -- there is no faster active recovery. Together, whatever triggers the reset, the canvas can sit blank for up to 30 real seconds with zero active recovery -- comfortably spanning one generation run (this report's own run + wait_for_job took 15386ms). Step 0 (existing PR check): searched open PRs across ComfyUI_frontend/cloud for "canvas blank"/"run"/"agent run"/"crdt-authority" during this run. #18099 ("repro schema-gate latch leaving canvas at zero nodes") is the closest sibling but covers a PERMANENT latch (until an explicit doc_reset) triggered by an unreadable schema_version -- not this transient, self-healing, run-duration-scoped blank. #18064 (new-chat stale canvas) is a different trigger (thread binding, not a mid-turn reset). No existing PR covers this. Open half of the RCA, stated plainly: the backend condition that would emit a doc_reset for a plain, edit-free "run the workflow" turn was NOT found. `run` / `wait_for_job` / `get_output` (cloud/services/agent/internal/loop/ tools.go) make no calls into the CRDT doc store at all, and the turn-start reconciliation that can emit a reset (`ensureDoc`/`prepareWorkflow` in cloud/services/agent/internal/loop/crdt.go) is heavily unit-tested against firing on an unmodified canvas. Which backend path actually emitted the reset in production is unconfirmed; this repro pins what the user sees once one is emitted, for whatever reason, and gives backend engineers a concrete signature (a `doc_reset` frame, or a `doc_subscribed:ok` with no following `doc_update`) to search production logs for around the incident. Verification: - pnpm exec eslint / oxlint / oxfmt --check on the new file -- clean - pnpm exec vue-tsc --project browser_tests/tsconfig.json --noEmit -- clean - pnpm exec playwright test --list -- collects the spec correctly under the cloud project with the right tags - pnpm exec vitest run src/workbench/extensions/agent/crdt/ useAgentCrdtFollower.test.ts -- 61/61 passed, no regressions - Known limitation: this sandbox's egress policy blocks cdn.playwright.dev (403), so the pinned Chromium build could not be downloaded and the spec could not be executed against a real browser here (same limitation noted on sibling repro PRs #18099/#18096 in this program). CI's Playwright run on this PR is the first real execution; treat its result, not this description, as the authoritative pass/fail signal. Related Slack thread: #comfy-agent-user-feedback, Jo Zhang's nightly report, 2026-09-20 03:24 UTC.
…401) (#18174) ## Summary Dragging an asset out of the Media Assets panel does nothing while the panel is in **list view**, and works in grid view ([PM-1401](https://linear.app/comfyorg/issue/PM-1401/fix-dragging-an-asset-from-the-asset-panel-does-not-work-in-list-view), reported on nightly through the feedback survey). The composer's "drag in asset from asset panel" path is therefore unusable from one of the two view modes, with no error shown. Opened RED (`98f7ee82`, 5 failing unit cases) and made GREEN by `b468ce99`. Now based directly on `main`: #18096 and #18111 have merged, and this branch was rebuilt on top of them (`2fd052d1a5`). The `MediaAssetCard` payload writer this PR extracts is #18111's post-fix version, so the file-URL `text/uri-list` rule moves into `startAssetDrag` intact. **Before:** `MediaAssetCard` was the only asset surface that set `:draggable="true"` and wrote a drag payload. `AssetsSidebarListView` renders `AssetsListItem`, which sets neither, so a list row never started a native drag at all. The drop side is view-agnostic - `AgentPanelRoot` `isAssetDrag` accepts a drop purely on `dataTransfer.types` containing `application/x-comfy-asset-info` - so a row that advertises nothing is a silent attachment failure rather than a rejected drop. **After:** both flavours are written by one function, `startAssetDrag`, which derives everything it needs from the `AssetItem` alone (`getAssetType(asset.tags)`, `getMediaTypeFromFilename(asset.name)`), and both the grid card and the list rows call it. A list row now carries exactly the payload a grid card carries, including the file-URL `text/uri-list` rule this PR's parent established. Not the marquee: `useAssetGridSelection` only `preventDefault`s a dragstart while it is tracking, and it starts tracking only in a container holding `[data-asset-id]`, which list rows do not set. That attribute is deliberately still not set, so list-view marquee behaviour is unchanged by this PR. ## Changes - **What**: - `src/platform/assets/utils/assetDragUtil.ts` (new): `startAssetDrag(event, asset)` holds the Ctrl/Meta cancel guard and both `dataTransfer` flavours, moved verbatim from `MediaAssetCard.dragStart` (including the `allOutputs[0]` branch and the file-URL rule from #18111). Pure function of the asset, no component state. - `src/platform/assets/components/MediaAssetCard.vue`: `dragStart` delegates to it; now-unused imports dropped. - `src/components/sidebar/tabs/AssetsSidebarListView.vue`: rows get `:draggable="true"` and `@dragstart="startAssetDrag($event, item.asset)"`. `AssetsListItem` is a single-root component with attribute fallthrough, so no prop plumbing. - `docs/adr/ASSETS-DRAG-DROP-0035-asset-card-drag-uses-file-url.md`: new rule 4, the payload belongs to the asset and not to a view mode, with the PM-1401 failure recorded as the worked example; two consequences added (nothing mechanically forces a new surface through `startAssetDrag`; the Ctrl/Meta branch is grid parity in list view, not a behaviour list view needs today). Rule 1 de-specialised from `MediaAssetCard` to the drag side. - **Tests**: - `AssetsSidebarListView.test.ts`: rows are `draggable`; a row publishes the asset-info payload the composer resolves an attachment from; it publishes the file URL as `text/uri-list`; `it.for` over Ctrl and Meta asserts the drag is cancelled with nothing added. All 5 fail on the parent. - `browser_tests/tests/sidebar/assetListViewDrag.spec.ts` (new, `@cloud`): switches the panel to list view through the settings menu and drags a row onto the canvas, asserting the workflow embedded in the dropped file opens and the tab is named after the asset - the same observable as the grid counterpart in `agentVideoAsset.spec.ts`, so a regression in either view mode reads as the same failure. ## Review Focus - `startAssetDrag` is a plain function rather than a composable so a non-setup call site (the `VirtualGrid` slot) can use it; it calls `useFeatureFlags()` transitively through `getAssetFileUrl`, which that helper already did at call time before this PR. - The list row keeps `role="button"` and `tabindex="0"`; `draggable` on the same element does not change its accessibility name or keyboard activation, and the existing keyboard-activation case still passes. - Nothing lints the invariant that a new asset surface must call `startAssetDrag`. The ADR records that gap; the practical guard is one case per surface. - There is still no browser coverage anywhere for asset-drag-to-**composer-attachment** (the literal PM-1401 journey), for either view mode - `browser_tests` has no agent-composer drop harness at all. This PR asserts the canvas consumer of the same payload instead. Building that harness is a separate PR. ## Verification - `vitest run src/platform/assets src/components/sidebar src/components/queue src/composables/node`: 97 files, 1195 passed, 0 failed. - Browser case verified both ways against a cloud dist served by `ghcr.io/comfy-org/comfyui-ci-container:0.0.22` (the CI backend), `--project=cloud`: **red** with the list-view wiring reverted (`expect(tabName).toContain('agent_generated_video')` fails, no workflow loads), **green** with it restored. - Re-verified after rebuilding on post-merge `main`: this PR's list-view case **and both of #18111's grid-card cases** pass together in one run, which is the check that matters here - the extraction must not regress the file-URL fix it moved. - `pnpm typecheck` and `typecheck:browser` clean; `eslint`, `oxlint`, `oxfmt`, `stylelint` clean on changed files via lint-staged on both commits; Knip clean on push.
…workflow (Comfy-Org#18111) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789793100348859?thread_ts=1789715585.888609&cid=C0BGH348Z0C)_ ## Summary Dropping a cloud video (or audio, or 3D) asset card onto the canvas showed an invalid-workflow error instead of opening the workflow embedded in the file, because the card dragged its preview URL rather than its file URL. This PR ships the fix, the ADR, and the tests. It was opened RED (ADR + failing tests, commits `a2c69cb6`, `844d56b9`), went through two adversarial reviews, and the GREEN commits (`14d047c8` fix, `d7ea37af` ADR rewrite) incorporate the reviewers' required changes. **Before:** with the cloud assets API on, `unflattenOutputAssets` groups cards per job, so a card's `id` is the job id and the file's own id lives in `user_metadata.assetId`. `MediaAssetCard` `dragStart` published `resolvePreviewUrl(asset)` as `text/uri-list`. Cloud images self-preview (their `preview_url` is the file), so they worked. A video without a preview fell back to `/api/assets/<jobId>/content`, ingest answered 404 `{"code":"ASSET_NOT_FOUND"}`, `fetchDroppedAsset` wrapped that JSON body in a `File` without checking `response.ok`, and `handleFile` tried to load `{code,message}` as a workflow. A 3D asset with a persisted thumbnail (`preview_id`) dragged the thumbnail PNG instead of the model. A node target without `onResultItemDrop` (LoadAudio) named the fetched file after the last URL segment, the literal `content`. **After:** the drag always carries `getAssetFileUrl(asset)` (resolves `user_metadata.assetId || asset.id`, never a preview), for every media kind. `fetchDroppedAsset` returns no file on a non-OK response (status-based). The canvas drop handler toasts and `reportError`s when a drop that carried `application/x-comfy-asset-info` yields no file; plain link drops stay silent. `useNodeDragAndDrop` names the fetched `File` after the asset-info `filename` before falling back to the URL. `resolvePreviewUrl`'s fallback goes through the shared `getAssetContentId`, so no path derives a content URL from a job id. The asset-info payload still carries `preview_url` for image previews (agent composer). No server change. ## Changes - **What**: - `src/platform/assets/components/MediaAssetCard.vue`: `text/uri-list` from `getAssetFileUrl(asset)`; `resolvePreviewUrl` only feeds the image `preview_url` field of the asset-info payload. - `src/utils/eventUtils.ts`: `fetchDroppedAsset` returns `undefined` on `!response.ok` (return shape unchanged; `AgentPanelRoot.attachDroppedAsset` relies on it). - `src/composables/node/useNodeDragAndDrop.ts`: file name prefers `parseAssetInfo(dataTransfer)?.filename`, then `?filename=`, then last URL segment. - `src/scripts/app.ts` `addDropHandler`: when `extractFilesFromDragEvent` returns `[]` and `dataTransfer.types` includes `MIME_ASSET_INFO`, `reportError(..., { errorType: 'asset_drop_load_failure' })` + `useToastStore().addAlert(t('toastMessages.assetDropFailed'))`. New i18n key `toastMessages.assetDropFailed`. - `src/platform/assets/utils/assetUrlUtil.ts`: export `getAssetContentId` (accepts `Pick<AssetItem, 'id' | 'user_metadata'>`). `assetPreviewUtil.ts` `resolvePreviewUrl`: fallback `preview_id ?? getAssetContentId(asset)`; `AssetRecord` gains optional `user_metadata`. - `docs/adr/ASSETS-DRAG-DROP-0035-asset-card-drag-uses-file-url.md` (+ index row): Decision stated as four durable rules; Context records why node targets with `onResultItemDrop` never see the URI and the self-preview backend fact. Status left Proposed. - **Tests**: - `MediaAssetCard.test.ts`: `it.for` table built with the real `unflattenOutputAssets`: grouped image with self-preview → `/api/assets/<fileId>/content`; grouped video with no preview → `/api/assets/<fileId>/content`; 3D model with `preview_id` → `/api/assets/model/content`; flag-OFF history image → its `/api/view?...` URL absolutized. The `getOutputAssetMetadata` module mock is gone (it masked `assetId`). - `src/utils/__tests__/eventUtils.test.ts`: table over `{status, contentType, body}`: 404 JSON → `[]`; 500 HTML → `[]`; 200 workflow JSON → one `application/json` File (defeats a content-type-sniffing fake fix). - `useNodeDragAndDrop.test.ts`: asset-card drop with `{filename:'clip.wav'}` asset-info yields a File named `clip.wav`. - `assetPreviewUtil.test.ts`: `resolvePreviewUrl` table incl. job-grouped card → file id. - `app.test.ts`: drop yielding no file toasts + reports for an asset-card drag, stays silent for a plain `text/uri-list` drag. - `browser_tests/tests/sidebar/agentVideoAsset.spec.ts`: `test.fail()` removed; asserts tab name and `getGraphNodesCount() === 2` (workflow.mp4 embeds LoadImage + SaveImage); route-order comment states Playwright matches the most recently registered route first. ### Review outcomes Both adversarial reviews confirmed the root cause and the kind-agnostic rule. Changes made because of them: the flag-OFF guard row and realistic grouped image row; the 500-HTML and 200-success rows; the `useNodeDragAndDrop` filename fix; surfacing failed asset drops (toast + telemetry) instead of a silent no-op; tightening `resolvePreviewUrl`; the node-count assertion in e2e; and the ADR rewritten as rules rather than a change log. ### Verification `pnpm vitest run src/platform/assets src/utils src/composables/node src/scripts`: 159 files, 2357 passed, 1 skipped, 0 failed (the 4 previously red cases are green). `pnpm eslint` on changed files: 0 errors (3 pre-existing `import-x/no-named-as-default-member` warnings in app.ts, untouched). `pnpm oxlint` clean on changed files. `vue-tsc --noEmit` exit 0. `pnpm knip` exit 0. `oxfmt --check` clean. `pnpm adr:check` pass. Pre-commit lint-staged (typecheck + typecheck:browser) passed on both commits. The Playwright cloud project for `agentVideoAsset.spec.ts` runs in CI. ## Review Focus - The drag never uses a preview, even when one exists (3D thumbnail row). Push back if any consumer relies on receiving the thumbnail. - Toast copy: `Unable to load the dropped asset`. Random non-asset links dropped from elsewhere do not toast. - New telemetry slug `asset_drop_load_failure`. - Follow-up (not in this PR): `uploadAudio.ts` has no `onResultItemDrop`, so a cloud audio card dropped on LoadAudio still re-uploads the fetched file (now correctly named) instead of referencing the existing asset. - Base branch is `test/agent-video-asset-thumbnail-repro-v2` (stacked on Comfy-Org#18096). 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01UP49A8QXF7zN5cYmUqsAx4 --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: bymyself <cbyrne@comfy.org>
## Summary Seventeen non-billing Agent sources are carried for `core/1.54`. Exact-head hosted checks and target-native replay acceptance pass; review remains. <details><summary>Full context for agent readers</summary> ## Changes - **Sources**: [18113](#18113), [18096](#18096), [18122](#18122), [18164](#18164), [18121](#18121), [18148](#18148), [18111](#18111), [18174](#18174), [17912](#17912), [18081](#18081), [16936](#16936), [18183](#18183), [18197](#18197), [18070](#18070), [18084](#18084), [18071](#18071), and [18107](#18107). - **New in this head**: PR 18107 rejects incompatible Agent-created links, retires incompatible retained links from the local projection, and keeps one bad link from blocking unrelated later edits. Main-only Load3D coverage is adapted onto the release-local unit, `HostDoc`, and tab-return harnesses. - **Dependencies**: no new package dependency; release lockfile pins are preserved. - **Exclusions**: billing/account work, protected source [17730](#17730), target-specific screenshot source [18168](#18168), separately owned focused carriers, and [18123](#18123), whose generic Vue-node test depends on [17576](#17576), absent from this release line. ## Review focus - PR 16936 adapts widget-state rebinding to the 1.54 store API without importing `main`'s newer visibility architecture. - PR 18070 runs target-local live widget projection callbacks with the canvas and owner node while retaining the release projection boundary. - PR 18084 adds placement as a renderer-owned port; resync materializations retain document coordinates, while new offscreen batches move together beside existing content. - The release browser harness seeds the same client-only API-node colors that normal node registration owns before testing whether a later CRDT reconcile preserves them. - This is not behavioral acceptance, deployment authorization, or a merge-check waiver. ## Exact-head verification Current head: `2bd4dace2e6207fede11d2ac219d691a811769dc`, verified under Node 25.9.0 and pnpm 11.13.1. - main typecheck passed with an 8 GiB heap at the production-identical parent; this head changes only the browser harness lifecycle; - the prior 146-test selection passed with 1 expected failure; - after repairing idempotent replay, 119 focused tests passed with 1 expected failure; - the exact head passes browser typecheck and adds a target-native check that the missing checkpoint value and `aria-invalid=true` survive tab return; - ancestor head `bd7da3cffd6dc349e1c48c5a277bc112cabd0e41` passed one zero-retry target-native warning-retention case with an inspected final frame; its [durable QA receipt](https://github.com/christian-byrne/in-app-agent-program/blob/7fa0ba4d731f00684388a45f1aeb1d24dc6f2280/reports/pr-ownership/2026-09-20-missing-model-tab-warning.md#1145-utc-exact-core-native-case-passes-final-warning-frame-inspected) is ancestry evidence, not acceptance of this newer head; - frozen installation and main typecheck pass at the production-identical parent; browser typecheck, target-native browser collection, formatting, ESLint, fixture mint/projection, and diff checks pass at this exact head; - the extended browser case commits pasted-node operations through the real `HostDoc` and asserts the pasted position survives another tab retarget; - parent head `389a3718bd2f637f704bde349068cbfd87cd9542` passed warning, node-presentation, and viewport assertions but stopped before paste because the zoom popup backdrop intercepted node selection; this head closes the popup through its real toggle and asserts it hidden before selection; - the first PR 18107 browser head stopped before app boot because the force-input string sink serialized one widget value while declaring no widgets; this head removes that non-widget value, and the exact fixture contract now mints and projects successfully; - parent head `366e0287095876351377f873688fece88eb90397` reached local paste but had already closed the Agent panel, which unmounted `AgentPanelRoot`, detached mint-port wiring, and disposed the CRDT follower; this head preserves the closed-panel screenshot, then reopens the panel and requires a fresh workflow subscription before mutation while retaining the unchanged `HostDoc` assertion; - one zero-retry target-native invocation passed the complete case at 13:44:02 UTC: warning retention, node presentation, popup closure, fresh subscription, local and host paste position after a second retarget, incompatible-link retirement, and the subsequent Agent edit; the [durable QA receipt](https://github.com/christian-byrne/in-app-agent-program/blob/28f5a4bb05318cc4e1a95d819951f7924bf9d2c2/reports/pr-ownership/2026-09-20-missing-model-tab-warning.md#1345-utc-both-lifecycle-corrected-candidates-pass-the-complete-native-case) includes inspected frames and cleanup; - PR 18107's exact-head focused coverage passes 63 tests with 1 expected failure; main and browser typechecks, targeted formatting and ESLint, and three affected Cloud-project browser cases also collect successfully; - targeted format and ESLint passed; - three affected Cloud-project browser cases collected successfully. Exact-head hosted checks and target-native replay acceptance pass. Review and the release-target merge-readiness gate remain required before merge. No deployment or check waiver is authorized. </details> Justification: Authorized Agent 1.54 release backport aggregate merged without standing human approval under the published release-backport authority; exact-head hosted checks, target-native replay acceptance, target-aware merge guard, adaptation review, and absence of unresolved human objections limit risk. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com>
## Summary Seventeen non-billing Agent sources are carried for `cloud/1.54`. The candidate now contains release `1.54.12`; fresh hosted checks and target-native replay acceptance passed. <details><summary>Full context for agent readers</summary> ## Changes - **Sources**: [18113](#18113), [18096](#18096), [18122](#18122), [18164](#18164), [18121](#18121), [18148](#18148), [18111](#18111), [18174](#18174), [17912](#17912), [18081](#18081), [16936](#16936), [18183](#18183), [18197](#18197), [18070](#18070), [18084](#18084), [18071](#18071), and [18107](#18107). - **New in this head**: PR 18107 rejects incompatible Agent-created links, retires incompatible retained links from the local projection, and keeps one bad link from blocking unrelated later edits. Main-only Load3D coverage is adapted onto the release-local unit, `HostDoc`, and tab-return harnesses. - **Dependencies**: no new package dependency; release lockfile pins are preserved. - **Exclusions**: billing/account work, protected source [17730](#17730), target-specific screenshot source [18168](#18168), separately owned focused carriers, and [18123](#18123), whose generic Vue-node test depends on [17576](#17576), absent from this release line. ## Review focus - PR 16936 adapts widget-state rebinding to the 1.54 store API without importing `main`'s newer visibility architecture. - PR 18070 runs target-local live widget projection callbacks with the canvas and owner node while retaining the release projection boundary. - PR 18084 adds placement as a renderer-owned port; resync materializations retain document coordinates, while new offscreen batches move together beside existing content. - The release browser harness seeds the same client-only API-node colors that normal node registration owns before testing whether a later CRDT reconcile preserves them. - This is not behavioral acceptance, deployment authorization, or a merge-check waiver. ## Exact-head verification Current head: `aabd82168d2d7b2f1b9f685a5477dcdc491d3b02`, verified locally under Node 25.9.0 and pnpm 11.13.1. - merged current `cloud/1.54` tip `d2667baf6bdb8664821b4bed7a7f5a1df65f9f49` cleanly; the imported release delta is limited to the package version and locale data; - frozen installation, 174 focused Agent/missing-model tests with 1 expected failure, main and browser typechecks, formatting, full ESLint with zero errors, the Cloud production build, target ancestry, and diff checks pass locally; - fresh exact-head hosted checks and one zero-retry target-native replay passed after the release target changed; - main typecheck passed with an 8 GiB heap at the production-identical parent; this head changes only the browser harness lifecycle; - the prior 146-test selection passed with 1 expected failure; - after repairing idempotent replay, 119 focused tests passed with 1 expected failure; - the exact head passes browser typecheck and adds a target-native check that the missing checkpoint value and `aria-invalid=true` survive tab return; - frozen installation and main typecheck pass at the production-identical parent; browser typecheck, target-native browser collection, formatting, ESLint, fixture mint/projection, and diff checks pass at this exact head; - the extended browser case commits pasted-node operations through the real `HostDoc` and asserts the pasted position survives another tab retarget; - parent head `dfe99947cffb5f31c5f4750113eb9770720e5eac` passed warning, node-presentation, and viewport assertions but stopped before paste because the zoom popup backdrop intercepted node selection; this head closes the popup through its real toggle and asserts it hidden before selection; - the first PR 18107 browser head stopped before app boot because the force-input string sink serialized one widget value while declaring no widgets; this head removes that non-widget value, and the exact fixture contract now mints and projects successfully; - parent head `5ec6c64e9b78b56b12350ae732dc1e1ea20052e0` reached local paste but had already closed the Agent panel, which unmounted `AgentPanelRoot`, detached mint-port wiring, and disposed the CRDT follower; this head preserves the closed-panel screenshot, then reopens the panel and requires a fresh workflow subscription before mutation while retaining the unchanged `HostDoc` assertion; - one zero-retry target-native invocation passed the complete case at 13:45:15 UTC: warning retention, node presentation, popup closure, fresh subscription, local and host paste position after a second retarget, incompatible-link retirement, and the subsequent Agent edit; the [durable QA receipt](https://github.com/christian-byrne/in-app-agent-program/blob/28f5a4bb05318cc4e1a95d819951f7924bf9d2c2/reports/pr-ownership/2026-09-20-missing-model-tab-warning.md#1345-utc-both-lifecycle-corrected-candidates-pass-the-complete-native-case) includes inspected frames and cleanup; - PR 18107's exact-head focused coverage passes 63 tests with 1 expected failure; main and browser typechecks, targeted formatting and ESLint, and three affected Cloud-project browser cases also collect successfully; - targeted format and ESLint passed; - three affected Cloud-project browser cases collected successfully. The prior replay receipt remains historical evidence for parent head `516f6b5f71e251b25985fb61715432f05249c4bd`. Fresh hosted checks and the fresh target-native replay passed at current head `aabd82168d2d7b2f1b9f685a5477dcdc491d3b02`; adaptation review and the release-target merge-readiness gate also passed. </details> Justification: Author-owned release aggregate merged under the published Agent 1.54 backport grant after exact-head hosted checks, target-native replay, adaptation review, target ancestry, and the target-aware merge guard passed; no independent approval was available. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com>
|
|
|
|
Requested by Christian Byrne · Slack thread
Summary
Video assets generated through the Comfy Agent / cloud path show up as an unplayable black tile in the Media Assets panel. This is an asset-panel regression from the assets-backed panel migration (#15381): history records used to carry the original video URL, but an
/api/assetsvideo record has neitherthumbnail_urlnorpreview_url(the backend only builds previews for images), andMediaAssetCard.vuehad no fallback for that case, unlike the3Dkind, which already falls back to a real content URL.Changes
MediaAssetCard.vue'ssrcfallback now points video and audio assets at their real content URL (getAssetFileUrl()) when both preview fields are empty, mirroring the3Dpattern.getAssetFileUrl()gained an optional{ disposition: 'inline' }option because/api/assets/{id}/contentdefaults toContent-Disposition: attachment, which makes the browser download instead of play. Existing callers (downloads, the 3D viewer) are unaffected.VirtualGridunmounts off-screen cards and<video>usespreload="metadata", so this does not turn the panel into an eager video downloader.preload="metadata", and has no unmount cancellation for the in-flight download. Restoring missing URLs activates that work for these assets too. Not measured as a blocking regression here; tracked separately.browser_tests/tests/sidebar/agentVideoAsset.spec.ts: the MP4 fixture (workflowInMedia/workflow.mp4) is served only at the card's own asset-id content URL; every other/api/assets/*/contentid returns the backend's 404 JSON. The playback test asserts the video'scurrentSrcis that URL, its dimensions load (videoWidth > 0), andcurrentTimeadvances after clicking play, so a 404'd source can no longer pass.MediaAssetCard.test.ts): a video/audio table asserts the inline content URL reaches each media element (<video>,<audio>), queried viadata-testid(media-asset-video,wave-audio-media). Removing the audio fallback fails the audio row.assetUrlUtil.test.tscovers thedisposition: 'inline'option.test.fail()kept): this is a frontend bug, not an upstream metadata gap. The card is grouped per job, so itsidis the job id; the drag publishes/api/assets/<job-id>/content, which 404s, and the error JSON gets loaded as the "workflow". Fixed in the stacked PR fix: drag cloud asset cards by file URL so dropped videos keep their workflow #18111, which flips this test to passing.Verification
pnpm vitest runon the two affected unit files,pnpm eslint,pnpm oxfmt --check,pnpm vue-tsc --noEmit, andpnpm knippass locally. The Playwright spec could not be run in this sandbox (no Chromium, no backend); it lists cleanly and runs in CI.Notes
test/pm-1342-video-asset-repro, which had an internal ticket ID baked into the branch name, commit message, and test file. That branch is left in place, unused, for whoever wants to delete it.🤖 Generated with Claude Code
https://claude.ai/code/session_01UP49A8QXF7zN5cYmUqsAx4
Generated by Claude Code