Skip to content

[backport core/1.53] refactor(assets): gate asset surfaces on server assets flag, retire Comfy.Assets.UseAssetAPI - #18729

Merged
comfy-pr-bot merged 1 commit into
core/1.53from
backport-17117-to-core-1.53
Sep 25, 2026
Merged

comfy-pr-bot merged 1 commit into
core/1.53from
backport-17117-to-core-1.53

Conversation

@synap5e

@synap5e synap5e commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Manual backport of #17117 to core/1.53. The automated backport failed with merge conflicts (#17117 (comment)).

Cherry-picked from dffad2d (git cherry-pick -x).

Why

On core/1.53, the hidden Comfy.Assets.UseAssetAPI setting and the Comfy.ToggleAssetAPI / Comfy.BrowseModelAssets palette commands can put the model library in asset mode against a server that doesn't advertise the assets feature, so it calls /api/assets on a backend that doesn't serve it. This ties the model library, sidebar tab, model store and those commands to the server assets flag (useFeatureFlags().flags.assetsEnabled) and removes the setting and toggle command.

Dependency check

No open PRs target core/1.53. As with #18727 (core/1.54) and #18728 (cloud/1.54), the conflicts are real and come from main-only test-mock migrations and files that don't exist on this branch.

Conflict resolution

14 files:

No other changes from main are included.

Validation

  • pnpm typecheck and pnpm typecheck:browser: clean
  • eslint on changed files: clean
  • vitest run on the touched tests: 292 passed (modelStore.test.ts 46/46)
  • Local e2e against a real ComfyUI backend without --enable-assets, with a temporary request guard that is not included in this PR:
    • Targeted spec: 10/10 passed with no /api/assets* requests, including a user with a stale persisted Comfy.Assets.UseAssetAPI=true.
    • Full non-cloud e2e run: no unexpected /api/assets* requests.
    • Negative control: the same guard on unpatched core/1.53 recorded /api/assets and /api/assets/seed requests with the server flag off.

…omfy.Assets.UseAssetAPI (#17117)

Retires the hidden `Comfy.Assets.UseAssetAPI` setting. Asset surfaces
now follow the backend's `assets` capability flag. Widget-embedded model
pickers stay cloud-only, under a name that says so.

The backend already advertises `assets` support, so a hidden client
override was redundant — and on core it could force asset mode against a
server with no `/assets` endpoints.

The gate functions were misleadingly named. `isAssetAPIEnabled` /
`shouldUseAssetBrowser` read as "is the asset API on", but actually
gated *widget* pickers — which are cloud-only because
`MODEL_NODE_MAPPINGS` is only maintained for cloud. They're now
`isWidgetAssetPickerEnabled` / `shouldUseWidgetAssetPicker`, hardcoded
to `isCloud`.

67 files, small surface: **18 production**, 30 one-line locale
deletions, 19 test migration. Commit 1 is production, commits 2–3 are
tests.

Unchanged for default settings on cloud, and on core without
`--enable-assets`.

**Core+ (`--enable-assets`)** — the model library enters asset mode. Six
deliberate consequences, each already asserted by
`modelLibraryAssetMode.spec.ts`:

1. Tree data from `/assets` instead of `api.getModels`
2. `visibleModelFolders` hides loaded-but-empty folders
3. The `supportsModelTypeTags` watcher goes live
4. Refresh issues `POST /assets/seed` via `requestModelScan()`
5. The per-folder extension allowlist applies client-side
6. The tab hides "Load all folders" and eager-loads on mount, bypassing
`Comfy.ModelLibrary.AutoLoadAll` — the most visible off-cloud change

**Anyone who had flipped the hidden setting:**

- Cloud, set `false` → asset surfaces return; that opt-out is
deliberately retired
- Core, set `true` → no longer forces asset mode at servers that can't
serve it (broken by construction)
- Core−, palette command → silent no-op instead of a dialog offering to
enable an API the server lacks

**Deliberately untouched:** `Comfy.ModelLibrary.UseAssetBrowser`
(sidebar-vs-modal), `Comfy.Assets.Sidebar.ViewMode`,
`MODEL_NODE_MAPPINGS`.

This PR edits `scripts/checkAssetsFlagArtifact.ts`, which statically
proves non-cloud bundles strip the widget gate. Its non-cloud invariant
is byte-identical — only the cloud regex and the function locator
changed, tracking the rename. Verified against real builds for all three
distributions, and mutation-tested: reverting the gate to a runtime
setting read, or flipping its polarity, both still fail the check.

Full unit suite and all touched e2e specs pass.

`Comfy_ToggleAssetAPI` and its `menuLabels` mirror are removed from all
15 locales. The command is gone, so the keys are unreachable — a pure
deletion, no translation pass. `pnpm locale:check`: 0 prunable keys, was
28.

(cherry picked from commit dffad2d)
@synap5e
synap5e requested review from a team, comfyui-wiki and ltdrdata as code owners September 24, 2026 21:07
@synap5e synap5e added backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned) labels Sep 24, 2026
@vercel

vercel Bot commented Sep 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
billing-web-test Error Error Sep 24, 2026 9:07pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 24, 2026 9:07pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 17ff765e-2137-4fdc-a181-dab875aec8b3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-24T21:11:10.962892Z e7cdae0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1912 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1891 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/24/2026, 09:09:35 PM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.3 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.5 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.6 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.5 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.0 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.9 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.4 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.2 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.6 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.9 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.3 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 102ms TBT · 82.4 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.9 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 168.1 MB heap
vue-large-graph-pan: · 58.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 21ms TBT · 180.5 MB heap
vue-node-resize-workload: · 59.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 62ms TBT · 170.9 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.2 MB heap

⚠️ 11 regressions detected

Show regressions
Metric Baseline PR (median) Δ Sig
canvas-mouse-sweep: style recalc duration 43ms 25ms -41% ⚠️ z=7.6
canvas-zoom-sweep: heap used 71.5 MB 71.6 MB +0% ⚠️ z=2.7
large-graph-idle: p95 frame time 17ms 17ms +0% ⚠️ z=2.5
large-graph-idle: heap used 83.0 MB 82.0 MB -1% ⚠️ z=2.1
large-graph-pan: heap used 80.7 MB 83.9 MB +4% ⚠️ z=2.1
subgraph-dom-widget-clipping: avg frame time 17ms 17ms +0% ⚠️ z=2.2
subgraph-dom-widget-clipping: heap used 83.4 MB 83.6 MB +0% ⚠️ z=2.3
subgraph-mouse-sweep: style recalc duration 34ms 25ms -26% ⚠️ z=7.5
workflow-execution: heap used 69.4 MB 70.2 MB +1% ⚠️ z=3.8
workflow-execution: DOM nodes 130 140 +8% ⚠️ z=2.0
workflow-execution: event listeners 74 97 +31% ⚠️ z=3.0
All metrics
Metric Baseline PR (median) Δ Sig
canvas-idle: avg frame time 17ms 17ms +0% z=0.7
canvas-idle: p95 frame time 17ms 17ms +0% z=0.5
canvas-idle: layout duration 0ms 0ms +0% —
canvas-idle: style recalc duration 7ms 6ms -15% z=-0.4
canvas-idle: layout count 0 0 +0% —
canvas-idle: style recalc count 10 11 +16% z=0.3
canvas-idle: task duration 531ms 423ms -20% z=0.3
canvas-idle: script duration 9ms 7ms -27% z=-0.7
canvas-idle: TBT 0ms 0ms +0% —
canvas-idle: heap used 66.6 MB 64.3 MB -3% z=0.7
canvas-idle: DOM nodes -280 -278 -1% z=-0.8
canvas-idle: event listeners -155 -170 +10% z=-0.6
canvas-mouse-sweep: avg frame time 17ms 17ms +0% z=1.4
canvas-mouse-sweep: p95 frame time 17ms 17ms -0% z=-1.5
canvas-mouse-sweep: layout duration 5ms 3ms -34% variance too high
canvas-mouse-sweep: style recalc duration 43ms 25ms -41% ⚠️ z=7.6
canvas-mouse-sweep: layout count 14 14 +0% variance too high
canvas-mouse-sweep: style recalc count 80 74 -8% z=1.9
canvas-mouse-sweep: task duration 899ms 689ms -23% z=-0.3
canvas-mouse-sweep: script duration 146ms 106ms -27% z=-1.4
canvas-mouse-sweep: TBT 0ms 0ms +0% —
canvas-mouse-sweep: heap used 59.9 MB 58.5 MB -2% z=-1.2
canvas-mouse-sweep: DOM nodes -280 -279 -0% z=-1.0
canvas-mouse-sweep: event listeners -156 -155 -1% z=0.1
canvas-zoom-sweep: avg frame time 17ms 17ms +0% z=1.6
canvas-zoom-sweep: p95 frame time 17ms 17ms +0% z=0.3
canvas-zoom-sweep: layout duration 1ms 1ms -22% z=-2.1
canvas-zoom-sweep: style recalc duration 17ms 12ms -30% z=-0.4
canvas-zoom-sweep: layout count 6 6 +0% —
canvas-zoom-sweep: style recalc count 33 30 -8% z=-0.6
canvas-zoom-sweep: task duration 355ms 286ms -20% z=-0.3
canvas-zoom-sweep: script duration 10ms 8ms -20% z=-1.4
canvas-zoom-sweep: TBT 0ms 0ms +0% —
canvas-zoom-sweep: heap used 71.5 MB 71.6 MB +0% ⚠️ z=2.7
canvas-zoom-sweep: DOM nodes 79 79 +0% z=0.6
canvas-zoom-sweep: event listeners 19 19 +0% —
dom-widget-clipping: avg frame time 17ms 17ms -0% z=-0.6
dom-widget-clipping: p95 frame time 17ms 17ms +0% z=0.4
dom-widget-clipping: layout duration 0ms 0ms +0% —
dom-widget-clipping: style recalc duration 8ms 6ms -25% z=-0.7
dom-widget-clipping: layout count 0 0 +0% —
dom-widget-clipping: style recalc count 12 12 +4% z=-1.0
dom-widget-clipping: task duration 450ms 346ms -23% z=-0.9
dom-widget-clipping: script duration 157ms 116ms -26% z=-1.4
dom-widget-clipping: TBT 0ms 0ms +0% —
dom-widget-clipping: heap used 72.2 MB 69.5 MB -4% z=-4.9
dom-widget-clipping: DOM nodes 19 20 +5% variance too high
dom-widget-clipping: event listeners 2 1 -50% —
large-graph-idle: avg frame time 17ms 17ms +0% z=0.2
large-graph-idle: p95 frame time 17ms 17ms +0% ⚠️ z=2.5
large-graph-idle: layout duration 0ms 0ms +0% —
large-graph-idle: style recalc duration 3ms 4ms +51% z=-1.1
large-graph-idle: layout count 0 0 +0% —
large-graph-idle: style recalc count 4 7 +100% z=-1.9
large-graph-idle: task duration 582ms 499ms -14% z=-0.2
large-graph-idle: script duration 34ms 27ms -21% z=-0.6
large-graph-idle: TBT 0ms 0ms +0% —
large-graph-idle: heap used 83.0 MB 82.0 MB -1% ⚠️ z=2.1
large-graph-idle: DOM nodes -271 -268 -1% z=-4.3
large-graph-idle: event listeners -154 -181 +18% z=-3.3
large-graph-pan: avg frame time 17ms 17ms +0% z=-0.9
large-graph-pan: p95 frame time 17ms 17ms -0% z=-0.2
large-graph-pan: layout duration 0ms 0ms +0% —
large-graph-pan: style recalc duration 13ms 7ms -42% z=-3.0
large-graph-pan: layout count 0 0 +0% —
large-graph-pan: style recalc count 67 66 -1% z=-3.0
large-graph-pan: task duration 1545ms 1206ms -22% z=-1.1
large-graph-pan: script duration 756ms 581ms -23% z=-1.4
large-graph-pan: TBT 0ms 0ms +0% —
large-graph-pan: heap used 80.7 MB 83.9 MB +4% ⚠️ z=2.1
large-graph-pan: DOM nodes -272 -133 -51% z=1.3
large-graph-pan: event listeners -91 -88 -3% z=1.3
large-graph-zoom: avg frame time 17ms 17ms -0% z=-1.6
large-graph-zoom: p95 frame time 17ms 17ms -0% z=-1.5
large-graph-zoom: layout duration 13ms 9ms -28% z=-4.7
large-graph-zoom: style recalc duration 11ms 9ms -11% z=-2.6
large-graph-zoom: layout count 60 60 +0% —
large-graph-zoom: style recalc count 60 63 +5% z=-0.4
large-graph-zoom: task duration 1660ms 1235ms -26% z=-1.3
large-graph-zoom: script duration 757ms 526ms -31% z=-1.6
large-graph-zoom: TBT 0ms 0ms +0% —
large-graph-zoom: heap used 74.5 MB 73.9 MB -1% z=1.2
large-graph-zoom: DOM nodes 0 8 — z=1.1
large-graph-zoom: event listeners 8 8 +0% z=1.1
legacy-node-drag: avg frame time 17ms 17ms +0% z=0.7
legacy-node-drag: p95 frame time 17ms 17ms -0% z=0.4
legacy-node-drag: layout duration 0ms 0ms +0% —
legacy-node-drag: style recalc duration 5ms 5ms -10% z=-2.6
legacy-node-drag: layout count 0 0 +0% —
legacy-node-drag: style recalc count 40 44 +9% z=-0.5
legacy-node-drag: task duration 1892ms 1366ms -28% z=-1.3
legacy-node-drag: script duration 956ms 641ms -33% z=-1.7
legacy-node-drag: TBT 0ms 0ms +0% variance too high
legacy-node-drag: heap used 89.5 MB 79.4 MB -11% z=0.1
legacy-node-drag: DOM nodes 0 2 — z=1.0
legacy-node-drag: event listeners 188 186 -1% z=1.1
minimap-idle: avg frame time 17ms 17ms -0% z=-0.8
minimap-idle: p95 frame time 17ms 17ms +0% z=-1.2
minimap-idle: layout duration 0ms 0ms +0% —
minimap-idle: style recalc duration 3ms 4ms +43% z=-0.9
minimap-idle: layout count 0 0 +0% —
minimap-idle: style recalc count 3 6 +100% z=-1.3
minimap-idle: task duration 573ms 461ms -20% z=-0.5
minimap-idle: script duration 35ms 24ms -32% z=-1.4
minimap-idle: TBT 0ms 0ms +0% —
minimap-idle: heap used 82.7 MB 83.2 MB +1% z=1.9
minimap-idle: DOM nodes -275 -271 -1% z=-1.3
minimap-idle: event listeners -170 -181 +6% z=-1.0
subgraph-dom-widget-clipping: avg frame time 17ms 17ms +0% ⚠️ z=2.2
subgraph-dom-widget-clipping: p95 frame time 17ms 17ms -0% z=0.4
subgraph-dom-widget-clipping: layout duration 0ms 0ms +0% —
subgraph-dom-widget-clipping: style recalc duration 10ms 7ms -23% z=-1.0
subgraph-dom-widget-clipping: layout count 0 0 +0% —
subgraph-dom-widget-clipping: style recalc count 47 48 +2% z=-0.7
subgraph-dom-widget-clipping: task duration 397ms 305ms -23% z=-1.1
subgraph-dom-widget-clipping: script duration 139ms 98ms -30% z=-1.7
subgraph-dom-widget-clipping: TBT 0ms 0ms +0% —
subgraph-dom-widget-clipping: heap used 83.4 MB 83.6 MB +0% ⚠️ z=2.3
subgraph-dom-widget-clipping: DOM nodes 19 21 +11% variance too high
subgraph-dom-widget-clipping: event listeners 7 6 -14% —
subgraph-idle: avg frame time 17ms 17ms -0% z=-2.8
subgraph-idle: p95 frame time 17ms 17ms +0% z=0.1
subgraph-idle: layout duration 0ms 0ms +0% —
subgraph-idle: style recalc duration 8ms 6ms -23% z=-0.4
subgraph-idle: layout count 0 0 +0% —
subgraph-idle: style recalc count 10 11 +10% z=0.2
subgraph-idle: task duration 482ms 408ms -15% z=0.1
subgraph-idle: script duration 7ms 7ms -6% z=-0.3
subgraph-idle: TBT 0ms 0ms +0% —
subgraph-idle: heap used 59.8 MB 64.9 MB +9% z=0.2
subgraph-idle: DOM nodes -296 -293 -1% z=-1.9
subgraph-idle: event listeners -200 -231 +16% z=-2.8
subgraph-mouse-sweep: avg frame time 17ms 17ms +0% z=0.5
subgraph-mouse-sweep: p95 frame time 17ms 17ms +0% z=0.2
subgraph-mouse-sweep: layout duration 5ms 3ms -35% variance too high
subgraph-mouse-sweep: style recalc duration 34ms 25ms -26% ⚠️ z=7.5
subgraph-mouse-sweep: layout count 18 18 +0% variance too high
subgraph-mouse-sweep: style recalc count 77 78 +2% z=2.2
subgraph-mouse-sweep: task duration 781ms 621ms -20% z=-0.6
subgraph-mouse-sweep: script duration 97ms 70ms -29% z=-2.1
subgraph-mouse-sweep: TBT 0ms 0ms +0% —
subgraph-mouse-sweep: heap used 57.5 MB 57.3 MB -0% z=-1.9
subgraph-mouse-sweep: DOM nodes -296 -296 -0% z=-1.2
subgraph-mouse-sweep: event listeners -216 -201 -7% z=-0.1
subgraph-transition-enter: avg frame time 17ms 17ms +0% z=0.3
subgraph-transition-enter: p95 frame time 17ms 17ms -1% z=-0.7
subgraph-transition-enter: layout duration 15ms 10ms -30% z=-0.3
subgraph-transition-enter: style recalc duration 30ms 23ms -23% z=-0.5
subgraph-transition-enter: layout count 16 16 +0% —
subgraph-transition-enter: style recalc count 20 20 +0% z=2.7
subgraph-transition-enter: task duration 906ms 692ms -24% z=-0.5
subgraph-transition-enter: script duration 30ms 21ms -31% z=-0.9
subgraph-transition-enter: TBT 124ms 102ms -18% z=-0.3
subgraph-transition-enter: heap used 83.0 MB 82.4 MB -1% z=-0.7
subgraph-transition-enter: DOM nodes 13751 13751 +0% —
subgraph-transition-enter: event listeners 2381 2381 +0% —
viewport-pan-sweep: avg frame time 17ms 17ms -0% z=-0.8
viewport-pan-sweep: p95 frame time 17ms 17ms -0% z=-1.8
viewport-pan-sweep: layout duration 0ms 0ms +0% —
viewport-pan-sweep: style recalc duration 38ms 27ms -28% z=-2.9
viewport-pan-sweep: layout count 0 0 +0% —
viewport-pan-sweep: style recalc count 247 248 +0% z=-3.1
viewport-pan-sweep: task duration 5518ms 4329ms -22% z=-1.0
viewport-pan-sweep: script duration 2549ms 1901ms -25% z=-1.6
viewport-pan-sweep: TBT 0ms 0ms +0% —
viewport-pan-sweep: heap used 80.8 MB 82.9 MB +3% z=1.6
viewport-pan-sweep: DOM nodes -272 -270 -1% z=-2.0
viewport-pan-sweep: event listeners -154 -152 -1% z=0.1
vue-large-graph-idle: avg frame time 18ms 17ms -2% z=0.2
vue-large-graph-idle: p95 frame time 17ms 17ms -0% z=-1.0
vue-large-graph-idle: layout duration 0ms 0ms +0% —
vue-large-graph-idle: style recalc duration 0ms 0ms +0% —
vue-large-graph-idle: layout count 0 0 +0% —
vue-large-graph-idle: style recalc count 0 0 +0% —
vue-large-graph-idle: task duration 16877ms 10971ms -35% z=-1.4
vue-large-graph-idle: script duration 279ms 162ms -42% z=-1.3
vue-large-graph-idle: TBT 0ms 0ms +0% —
vue-large-graph-idle: heap used 168.1 MB 168.1 MB +0% z=-0.7
vue-large-graph-idle: DOM nodes -6548 -6548 +0% z=262.0
vue-large-graph-idle: event listeners -7473 -7475 +0% z=3102.3
vue-large-graph-pan: avg frame time 18ms 17ms -3% z=-0.9
vue-large-graph-pan: p95 frame time 17ms 17ms +0% z=-1.1
vue-large-graph-pan: layout duration 0ms 0ms +0% —
vue-large-graph-pan: style recalc duration 20ms 12ms -38% z=-1.5
vue-large-graph-pan: layout count 0 0 +0% —
vue-large-graph-pan: style recalc count 172 70 -59% z=-1.6
vue-large-graph-pan: task duration 21107ms 13761ms -35% z=-1.5
vue-large-graph-pan: script duration 911ms 716ms -21% z=-0.7
vue-large-graph-pan: TBT 98ms 21ms -79% variance too high
vue-large-graph-pan: heap used 163.6 MB 180.5 MB +10% z=1.7
vue-large-graph-pan: DOM nodes -6549 -6548 -0% z=267.2
vue-large-graph-pan: event listeners -7469 -7473 +0% z=3256.7
vue-node-resize-workload: avg frame time 18ms 17ms -6% z=-2.0
vue-node-resize-workload: p95 frame time 17ms 17ms +0% z=0.9
vue-node-resize-workload: layout duration 24ms 19ms -21% z=-1.4
vue-node-resize-workload: style recalc duration 74ms 60ms -18% z=-0.7
vue-node-resize-workload: layout count 20 20 +0% —
vue-node-resize-workload: style recalc count 20 20 +0% —
vue-node-resize-workload: task duration 6188ms 4051ms -35% z=-1.6
vue-node-resize-workload: script duration 115ms 70ms -39% z=-1.3
vue-node-resize-workload: TBT 480ms 62ms -87% variance too high
vue-node-resize-workload: heap used 165.4 MB 170.9 MB +3% z=-0.9
vue-node-resize-workload: DOM nodes -6548 -6548 +0% z=224.6
vue-node-resize-workload: event listeners -7471 -7473 +0% z=3106.1
workflow-execution: avg frame time 17ms 17ms -0% z=-0.9
workflow-execution: p95 frame time 17ms 17ms +0% z=0.1
workflow-execution: layout duration 1ms 1ms -27% z=-1.6
workflow-execution: style recalc duration 20ms 17ms -16% z=-0.0
workflow-execution: layout count 3 3 -17% z=-1.6
workflow-execution: style recalc count 13 18 +40% z=1.9
workflow-execution: task duration 102ms 95ms -6% z=0.2
workflow-execution: script duration 10ms 7ms -30% z=-0.8
workflow-execution: TBT 0ms 0ms +0% —
workflow-execution: heap used 69.4 MB 70.2 MB +1% ⚠️ z=3.8
workflow-execution: DOM nodes 130 140 +8% ⚠️ z=2.0
workflow-execution: event listeners 74 97 +31% ⚠️ z=3.0
Historical variance (last 15 runs)
Metric μ σ CV
canvas-idle: avg frame time 17ms 0ms 0.0%
canvas-idle: p95 frame time 17ms 0ms 0.2%
canvas-idle: layout duration 0ms 0ms 0.0%
canvas-idle: style recalc duration 7ms 3ms 36.2%
canvas-idle: layout count 0 0 0.0%
canvas-idle: style recalc count 11 1 7.3%
canvas-idle: task duration 400ms 83ms 20.6%
canvas-idle: script duration 8ms 2ms 20.9%
canvas-idle: TBT 0ms 0ms 0.0%
canvas-idle: heap used 61.1 MB 4.5 MB 7.4%
canvas-idle: DOM nodes -215 82 0.0%
canvas-idle: event listeners -142 51 0.0%
canvas-mouse-sweep: avg frame time 17ms 0ms 0.0%
canvas-mouse-sweep: p95 frame time 17ms 0ms 0.2%
canvas-mouse-sweep: layout duration 1ms 2ms 172.0%
canvas-mouse-sweep: style recalc duration 15ms 1ms 8.5%
canvas-mouse-sweep: layout count 3 5 171.7%
canvas-mouse-sweep: style recalc count 52 11 21.9%
canvas-mouse-sweep: task duration 728ms 126ms 17.3%
canvas-mouse-sweep: script duration 141ms 26ms 18.1%
canvas-mouse-sweep: TBT 0ms 0ms 0.0%
canvas-mouse-sweep: heap used 63.5 MB 4.4 MB 6.9%
canvas-mouse-sweep: DOM nodes -241 38 0.0%
canvas-mouse-sweep: event listeners -156 21 0.0%
canvas-zoom-sweep: avg frame time 17ms 0ms 0.0%
canvas-zoom-sweep: p95 frame time 17ms 0ms 0.1%
canvas-zoom-sweep: layout duration 1ms 0ms 8.3%
canvas-zoom-sweep: style recalc duration 13ms 3ms 23.0%
canvas-zoom-sweep: layout count 6 0 0.0%
canvas-zoom-sweep: style recalc count 31 1 3.4%
canvas-zoom-sweep: task duration 300ms 56ms 18.7%
canvas-zoom-sweep: script duration 11ms 2ms 16.0%
canvas-zoom-sweep: TBT 0ms 0ms 0.0%
canvas-zoom-sweep: heap used 65.0 MB 2.4 MB 3.7%
canvas-zoom-sweep: DOM nodes 71 11 16.0%
canvas-zoom-sweep: event listeners 15 0 0.0%
dom-widget-clipping: avg frame time 17ms 0ms 0.0%
dom-widget-clipping: p95 frame time 17ms 0ms 0.1%
dom-widget-clipping: layout duration 0ms 0ms 0.0%
dom-widget-clipping: style recalc duration 7ms 2ms 32.4%
dom-widget-clipping: layout count 0 0 0.0%
dom-widget-clipping: style recalc count 13 1 5.7%
dom-widget-clipping: task duration 406ms 67ms 16.5%
dom-widget-clipping: script duration 150ms 25ms 16.6%
dom-widget-clipping: TBT 0ms 0ms 0.0%
dom-widget-clipping: heap used 80.7 MB 2.3 MB 2.9%
dom-widget-clipping: DOM nodes 16 10 62.6%
dom-widget-clipping: event listeners 0 0 0.0%
large-graph-idle: avg frame time 17ms 0ms 0.0%
large-graph-idle: p95 frame time 17ms 0ms 0.1%
large-graph-idle: layout duration 0ms 0ms 0.0%
large-graph-idle: style recalc duration 6ms 2ms 31.6%
large-graph-idle: layout count 0 0 0.0%
large-graph-idle: style recalc count 9 1 10.7%
large-graph-idle: task duration 516ms 98ms 19.1%
large-graph-idle: script duration 30ms 5ms 18.1%
large-graph-idle: TBT 0ms 0ms 0.0%
large-graph-idle: heap used 76.9 MB 2.4 MB 3.1%
large-graph-idle: DOM nodes -239 7 0.0%
large-graph-idle: event listeners -161 6 0.0%
large-graph-pan: avg frame time 17ms 0ms 0.0%
large-graph-pan: p95 frame time 17ms 0ms 0.1%
large-graph-pan: layout duration 0ms 0ms 0.0%
large-graph-pan: style recalc duration 13ms 2ms 13.5%
large-graph-pan: layout count 0 0 0.0%
large-graph-pan: style recalc count 69 1 1.3%
large-graph-pan: task duration 1483ms 262ms 17.7%
large-graph-pan: script duration 763ms 132ms 17.3%
large-graph-pan: TBT 0ms 0ms 0.0%
large-graph-pan: heap used 75.2 MB 4.1 MB 5.5%
large-graph-pan: DOM nodes -202 51 0.0%
large-graph-pan: event listeners -133 36 0.0%
large-graph-zoom: avg frame time 17ms 0ms 0.0%
large-graph-zoom: p95 frame time 17ms 0ms 0.1%
large-graph-zoom: layout duration 14ms 1ms 6.8%
large-graph-zoom: style recalc duration 12ms 1ms 9.3%
large-graph-zoom: layout count 60 0 0.0%
large-graph-zoom: style recalc count 64 2 2.9%
large-graph-zoom: task duration 1545ms 247ms 16.0%
large-graph-zoom: script duration 712ms 117ms 16.5%
large-graph-zoom: TBT 0ms 0ms 0.0%
large-graph-zoom: heap used 70.2 MB 3.2 MB 4.5%
large-graph-zoom: DOM nodes -107 101 0.0%
large-graph-zoom: event listeners -64 63 0.0%
legacy-node-drag: avg frame time 17ms 0ms 0.0%
legacy-node-drag: p95 frame time 17ms 0ms 0.1%
legacy-node-drag: layout duration 0ms 0ms 0.0%
legacy-node-drag: style recalc duration 7ms 1ms 14.1%
legacy-node-drag: layout count 0 0 0.0%
legacy-node-drag: style recalc count 44 2 4.2%
legacy-node-drag: task duration 1760ms 300ms 17.1%
legacy-node-drag: script duration 896ms 150ms 16.7%
legacy-node-drag: TBT 1ms 3ms 281.6%
legacy-node-drag: heap used 79.2 MB 4.4 MB 5.6%
legacy-node-drag: DOM nodes -56 59 0.0%
legacy-node-drag: event listeners 141 42 29.7%
minimap-idle: avg frame time 17ms 0ms 0.0%
minimap-idle: p95 frame time 17ms 0ms 0.2%
minimap-idle: layout duration 0ms 0ms 0.0%
minimap-idle: style recalc duration 5ms 2ms 32.1%
minimap-idle: layout count 0 0 0.0%
minimap-idle: style recalc count 8 1 16.4%
minimap-idle: task duration 510ms 92ms 18.1%
minimap-idle: script duration 31ms 5ms 16.7%
minimap-idle: TBT 0ms 0ms 0.0%
minimap-idle: heap used 77.5 MB 2.9 MB 3.8%
minimap-idle: DOM nodes -231 31 0.0%
minimap-idle: event listeners -149 33 0.0%
subgraph-dom-widget-clipping: avg frame time 17ms 0ms 0.0%
subgraph-dom-widget-clipping: p95 frame time 17ms 0ms 0.2%
subgraph-dom-widget-clipping: layout duration 0ms 0ms 0.0%
subgraph-dom-widget-clipping: style recalc duration 10ms 2ms 24.9%
subgraph-dom-widget-clipping: layout count 0 0 0.0%
subgraph-dom-widget-clipping: style recalc count 48 1 1.4%
subgraph-dom-widget-clipping: task duration 365ms 57ms 15.5%
subgraph-dom-widget-clipping: script duration 132ms 20ms 15.5%
subgraph-dom-widget-clipping: TBT 0ms 0ms 0.0%
subgraph-dom-widget-clipping: heap used 77.2 MB 2.8 MB 3.6%
subgraph-dom-widget-clipping: DOM nodes 16 10 62.7%
subgraph-dom-widget-clipping: event listeners 6 0 0.0%
subgraph-idle: avg frame time 17ms 0ms 0.0%
subgraph-idle: p95 frame time 17ms 0ms 0.2%
subgraph-idle: layout duration 0ms 0ms 0.0%
subgraph-idle: style recalc duration 7ms 3ms 34.6%
subgraph-idle: layout count 0 0 0.0%
subgraph-idle: style recalc count 11 1 5.3%
subgraph-idle: task duration 404ms 77ms 19.1%
subgraph-idle: script duration 7ms 1ms 18.9%
subgraph-idle: TBT 0ms 0ms 0.0%
subgraph-idle: heap used 64.0 MB 4.4 MB 6.9%
subgraph-idle: DOM nodes -266 14 0.0%
subgraph-idle: event listeners -206 9 0.0%
subgraph-mouse-sweep: avg frame time 17ms 0ms 0.0%
subgraph-mouse-sweep: p95 frame time 17ms 0ms 0.2%
subgraph-mouse-sweep: layout duration 1ms 3ms 172.3%
subgraph-mouse-sweep: style recalc duration 15ms 1ms 8.6%
subgraph-mouse-sweep: layout count 4 7 171.7%
subgraph-mouse-sweep: style recalc count 53 12 22.1%
subgraph-mouse-sweep: task duration 688ms 122ms 17.7%
subgraph-mouse-sweep: script duration 97ms 13ms 13.7%
subgraph-mouse-sweep: TBT 0ms 0ms 0.0%
subgraph-mouse-sweep: heap used 67.0 MB 5.1 MB 7.7%
subgraph-mouse-sweep: DOM nodes -261 30 0.0%
subgraph-mouse-sweep: event listeners -200 20 0.0%
subgraph-transition-enter: avg frame time 17ms 0ms 0.0%
subgraph-transition-enter: p95 frame time 17ms 0ms 0.3%
subgraph-transition-enter: layout duration 11ms 2ms 19.9%
subgraph-transition-enter: style recalc duration 25ms 4ms 17.5%
subgraph-transition-enter: layout count 5 0 0.0%
subgraph-transition-enter: style recalc count 18 1 5.2%
subgraph-transition-enter: task duration 762ms 138ms 18.1%
subgraph-transition-enter: script duration 25ms 5ms 19.6%
subgraph-transition-enter: TBT 113ms 33ms 29.0%
subgraph-transition-enter: heap used 89.9 MB 10.5 MB 11.7%
subgraph-transition-enter: DOM nodes 13667 0 0.0%
subgraph-transition-enter: event listeners 2383 0 0.0%
viewport-pan-sweep: avg frame time 17ms 0ms 0.0%
viewport-pan-sweep: p95 frame time 17ms 0ms 0.1%
viewport-pan-sweep: layout duration 0ms 0ms 0.0%
viewport-pan-sweep: style recalc duration 37ms 4ms 9.5%
viewport-pan-sweep: layout count 0 0 0.0%
viewport-pan-sweep: style recalc count 250 1 0.3%
viewport-pan-sweep: task duration 5194ms 885ms 17.0%
viewport-pan-sweep: script duration 2520ms 397ms 15.8%
viewport-pan-sweep: TBT 0ms 0ms 0.0%
viewport-pan-sweep: heap used 74.5 MB 5.2 MB 7.0%
viewport-pan-sweep: DOM nodes -229 20 0.0%
viewport-pan-sweep: event listeners -153 18 0.0%
vue-large-graph-idle: avg frame time 17ms 0ms 2.1%
vue-large-graph-idle: p95 frame time 17ms 0ms 0.1%
vue-large-graph-idle: layout duration 0ms 0ms 0.0%
vue-large-graph-idle: style recalc duration 0ms 0ms 0.0%
vue-large-graph-idle: layout count 0 0 0.0%
vue-large-graph-idle: style recalc count 0 0 0.0%
vue-large-graph-idle: task duration 14129ms 2314ms 16.4%
vue-large-graph-idle: script duration 222ms 47ms 21.1%
vue-large-graph-idle: TBT 0ms 0ms 0.0%
vue-large-graph-idle: heap used 172.3 MB 5.7 MB 3.3%
vue-large-graph-idle: DOM nodes -8058 6 0.0%
vue-large-graph-idle: event listeners -14927 2 0.0%
vue-large-graph-pan: avg frame time 18ms 0ms 2.1%
vue-large-graph-pan: p95 frame time 17ms 0ms 0.1%
vue-large-graph-pan: layout duration 0ms 0ms 0.0%
vue-large-graph-pan: style recalc duration 16ms 2ms 14.9%
vue-large-graph-pan: layout count 0 0 0.0%
vue-large-graph-pan: style recalc count 127 35 27.3%
vue-large-graph-pan: task duration 17648ms 2538ms 14.4%
vue-large-graph-pan: script duration 799ms 120ms 15.0%
vue-large-graph-pan: TBT 43ms 28ms 64.7%
vue-large-graph-pan: heap used 173.7 MB 3.9 MB 2.3%
vue-large-graph-pan: DOM nodes -8058 6 0.0%
vue-large-graph-pan: event listeners -14927 2 0.0%
vue-node-resize-workload: avg frame time 18ms 0ms 1.8%
vue-node-resize-workload: p95 frame time 17ms 0ms 0.2%
vue-node-resize-workload: layout duration 23ms 3ms 11.5%
vue-node-resize-workload: style recalc duration 70ms 13ms 18.0%
vue-node-resize-workload: layout count 20 0 0.0%
vue-node-resize-workload: style recalc count 20 0 0.0%
vue-node-resize-workload: task duration 5306ms 775ms 14.6%
vue-node-resize-workload: script duration 95ms 19ms 19.9%
vue-node-resize-workload: TBT 268ms 150ms 56.1%
vue-node-resize-workload: heap used 176.9 MB 6.5 MB 3.7%
vue-node-resize-workload: DOM nodes -8059 7 0.0%
vue-node-resize-workload: event listeners -14927 2 0.0%
workflow-execution: avg frame time 17ms 0ms 0.0%
workflow-execution: p95 frame time 17ms 0ms 0.2%
workflow-execution: layout duration 2ms 0ms 25.2%
workflow-execution: style recalc duration 17ms 5ms 27.0%
workflow-execution: layout count 3 0 14.8%
workflow-execution: style recalc count 11 4 33.0%
workflow-execution: task duration 90ms 22ms 24.4%
workflow-execution: script duration 9ms 2ms 27.2%
workflow-execution: TBT 0ms 0ms 0.0%
workflow-execution: heap used 65.1 MB 1.3 MB 2.1%
workflow-execution: DOM nodes 124 8 6.4%
workflow-execution: event listeners 42 18 44.2%
Trend (last 15 commits on main)
Metric Trend Dir Latest
canvas-idle: avg frame time ▁▆▃▃▁▆▁▆▃▆▃▆▆█▃ ➡️ 17ms
canvas-idle: p95 frame time ▃▆▁█▁▁▃▃▃▃▃▃▆▆▁ ➡️ 17ms
canvas-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: style recalc duration ▅▆▇▅▇▇▇▆█▆▆▁▂▁▂ 📉 4ms
canvas-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
canvas-idle: style recalc count █▄▅▇▅▄▄▅▄▂▂▆▁▅▁ ➡️ 10
canvas-idle: task duration ▂▆▅▄▇▆▆▅█▆▅▁▅▁▆ ➡️ 444ms
canvas-idle: script duration ▄▄▅▄▅▇▅▅█▅▄▁▃▁▄ 📉 8ms
canvas-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-idle: heap used ▁▂▃▁▄▃▅▁▅█▅▂▄▁▅ ➡️ 64.4 MB
canvas-idle: DOM nodes ▁▁▁▁▁▁▁▁▁▁▁█▄▆▄ 📉 -152
canvas-idle: event listeners ▁▁▁▁▂▁▁▁▂▂▁█▄▆▂ 📉 -149
canvas-mouse-sweep: avg frame time ▅▁▅▃▃▅▅▁▁▁█▆█▅▃ ➡️ 17ms
canvas-mouse-sweep: p95 frame time ▃▁▃▃▁▃▃▆▆▃▆▃▃█▃ ➡️ 17ms
canvas-mouse-sweep: layout duration ▁▁▁▁▁▁▁▁▁▁▁▇█▇█ 📈 5ms
canvas-mouse-sweep: style recalc duration ▂▃▅▁▆▄▄▃█▃▄▄▇▃▇ ➡️ 17ms
canvas-mouse-sweep: layout count ▁▁▁▁▁▁▁▁▁▁▁████ 📈 12
canvas-mouse-sweep: style recalc count ▂▁▁▂▁▁▁▂▂▁▁████ 📈 71
canvas-mouse-sweep: task duration ▂▇▇▄█▇█▅██▆▁▇▁█ ➡️ 832ms
canvas-mouse-sweep: script duration ▂▇█▃▇▆▆▄▇██▁█▁█ ➡️ 163ms
canvas-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-mouse-sweep: heap used ▄▄▃█▅▆▂▃▃▄▆▃▃▄▁ ➡️ 56.4 MB
canvas-mouse-sweep: DOM nodes ▁▁▁▁▁▁▁▁▁▁▁█▃█▃ 📉 -228
canvas-mouse-sweep: event listeners ▂▂▂▃▂▂▁▂▁▂▂█▃▇▂ ➡️ -164
canvas-zoom-sweep: avg frame time ▅▃▅▆▃▅▃▅▆▃▁▅▅▁█ ➡️ 17ms
canvas-zoom-sweep: p95 frame time ▅▁██▄▄▅███▅▁▅█▄ ➡️ 17ms
canvas-zoom-sweep: layout duration ▆▅▆▁▆▅▂▂█▄▃▅▆▃▆ ➡️ 1ms
canvas-zoom-sweep: style recalc duration ▅▆█▅▇▇█▅██▇▁▂▁▂ 📉 9ms
canvas-zoom-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
canvas-zoom-sweep: style recalc count ▁▆▆▅█▇▆▃▆▇▇▅▆▃▆ ➡️ 31
canvas-zoom-sweep: task duration ▂▆▆▄█▇▇▅██▆▁▆▁▇ ➡️ 332ms
canvas-zoom-sweep: script duration ▃▄▄▃▇▇▅▅██▄▁▃▁▅ ➡️ 11ms
canvas-zoom-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
canvas-zoom-sweep: heap used ▃██▅▆█▃████▃▁▁▁ ➡️ 61.6 MB
canvas-zoom-sweep: DOM nodes ███████████▁▁▁▁ 📉 53
canvas-zoom-sweep: event listeners ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 15
dom-widget-clipping: avg frame time ▆▆█▆██▁▆▆▃█▆▃▆▆ ➡️ 17ms
dom-widget-clipping: p95 frame time ▄▄▄▄██▄█▁█▄▄█▄▄ ➡️ 17ms
dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: style recalc duration ▆▇▇▆▇▇▇▆█▇▇▁▁▁▁ 📉 3ms
dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
dom-widget-clipping: style recalc count ▇▄▅█▄▇▇▆▇▄▃▆▂█▁ ➡️ 11
dom-widget-clipping: task duration ▂▆▆▄▇▆▆▄█▆▆▁▅▁▆ ➡️ 445ms
dom-widget-clipping: script duration ▁██▄▇▆▇▄███▁▇▁█ ➡️ 169ms
dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
dom-widget-clipping: heap used ▆▆█████▅███▃▁▁▁ ➡️ 76.7 MB
dom-widget-clipping: DOM nodes █▇██▇████▇▇▁▁▁▁ 📉 0
dom-widget-clipping: event listeners ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: avg frame time █▆▁▆▆▃▃█▁▆▆█▆▆▆ ➡️ 17ms
large-graph-idle: p95 frame time ▄███▅█▄▄▁██▁▅▄▄ ➡️ 17ms
large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: style recalc duration ▇█▇▆▇▇█▆▇█▆▁▃▃▁ 📉 3ms
large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-idle: style recalc count █▂▃▅▃▄▅▅▂▁▂▆▅▇▂ ➡️ 8
large-graph-idle: task duration ▂▆▅▄▇▆▆▅█▆▅▁▆▁▆ ➡️ 562ms
large-graph-idle: script duration ▄▅▆▆█▇▇▅▇▇▆▁▆▁▇ ➡️ 33ms
large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-idle: heap used ▅▇▇▆▇▆▆▇██▅▁▁▂▅ ➡️ 76.2 MB
large-graph-idle: DOM nodes ▄▃▃▃▃▃▃▄▃▃▁████ ➡️ -228
large-graph-idle: event listeners ▁▅▅▃▅▃▅▅▇▅▃▅▄▆█ ➡️ -149
large-graph-pan: avg frame time ▆▁▃▁██▃▃▃▆▆▆▁▃▆ ➡️ 17ms
large-graph-pan: p95 frame time ▁▅▅▅▁▅▁█▄▁▅▁█▁▁ ➡️ 17ms
large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: style recalc duration █▃▂▆█▇▆▅▇▃▅▃▁▃▁ 📉 10ms
large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
large-graph-pan: style recalc count █▁▁▇▅▄▄▅▄▁▃▇▅▆▆ ➡️ 69
large-graph-pan: task duration ▂▆▆▃▇▆▆▄█▆▆▁▆▁▇ ➡️ 1679ms
large-graph-pan: script duration ▂▇▇▄▇▆▇▄█▇▇▁▇▁█ ➡️ 870ms
large-graph-pan: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-pan: heap used ▄▆▇▆▆▇▇▄▇█▆▁▂▆▅ ➡️ 73.9 MB
large-graph-pan: DOM nodes ▆▅█▁▂▄▁▂▂▁▂▅▂▂▂ 📈 -228
large-graph-pan: event listeners ▄▅█▂▁▄▅▂▁▅▁▅▂▂▂ 📈 -149
large-graph-zoom: avg frame time ▅▃▄▅▅▅▅▅▆▅▅▁▃█▄ ➡️ 17ms
large-graph-zoom: p95 frame time ▄▁▅▄▅██▁██▄▄█▄▁ ➡️ 17ms
large-graph-zoom: layout duration ▆▁▁▁▇█▄▂▅▃▁▆▄▄▃ ➡️ 13ms
large-graph-zoom: style recalc duration █▂▅▅▅█▆▇▅▅▄▅▃▃▁ ➡️ 10ms
large-graph-zoom: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 60
large-graph-zoom: style recalc count ▆▁▃▅▁▂▂▅▁▂▃█▅▆▂ ➡️ 62
large-graph-zoom: task duration ▂▆▇▄▇▆▇▅█▇▆▂▆▁▆ ➡️ 1652ms
large-graph-zoom: script duration ▂▇▇▄█▆▇▅██▇▂▇▁▇ ➡️ 788ms
large-graph-zoom: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
large-graph-zoom: heap used ▄▅▅▅▅▅▅▄▅▅▅▁▁█▅ ➡️ 71.3 MB
large-graph-zoom: DOM nodes ▃▆▁▆██▆▁█▆▃▂▂██ ➡️ 0
large-graph-zoom: event listeners ▆▆▃▆██▆▁█▆▆▁▁██ 📈 0
legacy-node-drag: avg frame time ▃▃▃█▃▃▃▆▆▆▃▃▁▃█ ➡️ 17ms
legacy-node-drag: p95 frame time ▄▄▄██▄▄▄██▄▄▄▁█ ➡️ 17ms
legacy-node-drag: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
legacy-node-drag: style recalc duration █▅▂▆▄▆▄▅▄▃▂▄▁▄▁ 📉 6ms
legacy-node-drag: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
legacy-node-drag: style recalc count ▆▄▂▄▁▃▃▄▁▁▁█▃▇▃ ➡️ 44
legacy-node-drag: task duration ▂▆▆▄▇▆▇▄█▇▆▁▆▁▇ ➡️ 1973ms
legacy-node-drag: script duration ▁▇▇▄▇▆▇▄█▇▆▁▇▁█ ➡️ 1043ms
legacy-node-drag: TBT ▁▄▁▁▁▁▁▁▁▁▁▁▁▁█ 📈 12ms
legacy-node-drag: heap used ▁▄▅▃▅▁▂▃▃█▃▃▅▁▁ ➡️ 74.2 MB
legacy-node-drag: DOM nodes ▅██▁▄▅▅▅▅█▁█▅██ 📉 0
legacy-node-drag: event listeners ▄██▁▅▅▅▅▅███▁██ 📈 180
minimap-idle: avg frame time ▃▃▃▃▆▃▁▃█▃▃▃▃▁▃ ➡️ 17ms
minimap-idle: p95 frame time ▄▁█▄▁▁█▄▄██▄▁▁▄ ➡️ 17ms
minimap-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: style recalc duration ▇▆▇▆▇▄▅▆█▅▅▁▃▃▂ 📉 3ms
minimap-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
minimap-idle: style recalc count █▅▅▄▅▁▃▅▄▃▃▆▆█▅ ➡️ 8
minimap-idle: task duration ▃▆▇▄█▅▅▅█▆▆▁▆▂▇ ➡️ 574ms
minimap-idle: script duration ▄▆▇▅█▇▆▆▇▇▆▁▅▃▆ 📉 32ms
minimap-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
minimap-idle: heap used ▆▇▅▆▆██▅▆██▄▃▁▆ ➡️ 77.5 MB
minimap-idle: DOM nodes ▂▁▁▁▁▁▁▁▁▇▁█▃▃▃ 📉 -228
minimap-idle: event listeners ▁▂▁▁▁▅▂▁▂█▂▅▂▁▂ 📉 -157
subgraph-dom-widget-clipping: avg frame time ▃▅▁▃▅▆▅▅▅▃▅█▃▁█ ➡️ 17ms
subgraph-dom-widget-clipping: p95 frame time ▃█▁▃▆▆▃▁▁▁▁▆▆▃▆ ➡️ 17ms
subgraph-dom-widget-clipping: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: style recalc duration ▇▇▆▆▇▇█▆█▇▇▁▁▁▁ 📉 6ms
subgraph-dom-widget-clipping: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-dom-widget-clipping: style recalc count █▅▂▅▃▃▄▅▁▃▃▅▂▅▂ ➡️ 47
subgraph-dom-widget-clipping: task duration ▃▆▅▄▆▆▇▄█▇▆▁▆▁▆ ➡️ 393ms
subgraph-dom-widget-clipping: script duration ▂▇▇▄█▇▇▄█▇▇▁▇▁▇ ➡️ 144ms
subgraph-dom-widget-clipping: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-dom-widget-clipping: heap used █▇█▆██▆██▃▃▁▁▃▁ ➡️ 73.0 MB
subgraph-dom-widget-clipping: DOM nodes ██▇█▇▇▇█▇▇▇▁▁▁▁ 📉 0
subgraph-dom-widget-clipping: event listeners ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 6
subgraph-idle: avg frame time ▃▁▁▃▆▃▃█▆▆▆█▆▆▃ ➡️ 17ms
subgraph-idle: p95 frame time ▁▁▆▃█▆▆▆▃▁▃██▁▃ ➡️ 17ms
subgraph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: style recalc duration ▆▇▇▅▇▇▇▆███▁▂▁▂ 📉 4ms
subgraph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
subgraph-idle: style recalc count █▃▂▆▁▅▅▅▃▅▆█▂▃▂ ➡️ 10
subgraph-idle: task duration ▂▆▇▃█▇▇▅█▆▇▁▆▁▇ ➡️ 441ms
subgraph-idle: script duration ▄▄▅▄▇▇▆▆█▆▄▁▄▁▄ 📉 7ms
subgraph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-idle: heap used ▁▄▆▆█▂▃▃▆▇▆▇▇▇▆ ➡️ 65.7 MB
subgraph-idle: DOM nodes ▂▁▁▁▁▁▁▁▁▁▁████ ➡️ -244
subgraph-idle: event listeners ▅▁▃▅▅▃▇▁▃▃▅████ ➡️ -195
subgraph-mouse-sweep: avg frame time ▃█▆▆█▆▆▁▆▁▃▃▃▃▆ ➡️ 17ms
subgraph-mouse-sweep: p95 frame time ▁▆▃▃▃▆▃▃▃▃▃█▃▃█ ➡️ 17ms
subgraph-mouse-sweep: layout duration ▁▁▁▁▁▁▁▁▁▁▁▇█▇█ 📈 6ms
subgraph-mouse-sweep: style recalc duration ▃▃▄▁▅▃▅▂▇▅▅▅▇▄█ 📈 18ms
subgraph-mouse-sweep: layout count ▁▁▁▁▁▁▁▁▁▁▁████ 📈 16
subgraph-mouse-sweep: style recalc count ▁▁▁▁▁▁▁▁▁▁▁█▆█▆ 📈 68
subgraph-mouse-sweep: task duration ▂▆▆▃▆▆▇▄█▆▆▁▆▁▇ ➡️ 781ms
subgraph-mouse-sweep: script duration ▂▇█▂▇▆▆▃▇██▂█▁█ ➡️ 109ms
subgraph-mouse-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
subgraph-mouse-sweep: heap used ▆▆▆▅▇██▁▆▃▃▃▄▅▃ ➡️ 61.6 MB
subgraph-mouse-sweep: DOM nodes ▁▁▁▁▁▁▁▁▁▁▁▃▃█▃ 📉 -244
subgraph-mouse-sweep: event listeners ▂▂▂▂▃▃▃▁▃▂▂▂▃█▂ ➡️ -203
subgraph-transition-enter: avg frame time ▁▅█▁▁█▁▁▅▅▅▅▅▁█ ➡️ 17ms
subgraph-transition-enter: p95 frame time ███▁▁▁▁▁▁▁█▁▁▁█ ➡️ 17ms
subgraph-transition-enter: layout duration ▂▇█▃▆▄▆▄▆█▇▁█▁█ ➡️ 13ms
subgraph-transition-enter: style recalc duration ▂▇▇▄▆▅▆▄▆█▇▁▇▁█ ➡️ 29ms
subgraph-transition-enter: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 5
subgraph-transition-enter: style recalc count ▆▆▃█▃▃▆▃▁▃▃█▃█▃ ➡️ 17
subgraph-transition-enter: task duration ▄▇▇▄█▇▄▄▄█▇▁▇▁█ ➡️ 892ms
subgraph-transition-enter: script duration ▄▇▇▃██▄▄▅█▇▁▆▁█ ➡️ 30ms
subgraph-transition-enter: TBT ▂▇█▄▆▇▇▄▇██▁█▁█ ➡️ 138ms
subgraph-transition-enter: heap used ▁▇▇▁▂█▁▇▁▃▁▇▇▇▇ ➡️ 99.2 MB
subgraph-transition-enter: DOM nodes ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 13667
subgraph-transition-enter: event listeners ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 2383
viewport-pan-sweep: avg frame time ▃▁█▃▃▃▃▃▃▃▃▆▁▃█ ➡️ 17ms
viewport-pan-sweep: p95 frame time ▄▅▄▄▄███▄█▁▁███ ➡️ 17ms
viewport-pan-sweep: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
viewport-pan-sweep: style recalc duration █▃▃▄▇█▄▅▄▅▃▅▁▄▂ ➡️ 33ms
viewport-pan-sweep: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
viewport-pan-sweep: style recalc count ▇▅▆▆▅▅▃█▁▇▄▆▅▆▇ ➡️ 251
viewport-pan-sweep: task duration ▂▅▆▄▇▆▆▄█▇▆▁▆▁▆ ➡️ 5609ms
viewport-pan-sweep: script duration ▂▇▇▄▇▆▇▄█▇▇▁▇▁▇ ➡️ 2816ms
viewport-pan-sweep: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
viewport-pan-sweep: heap used ▃▆▃▃▁▅▆▅█▅▇▃▇▄▆ ➡️ 78.4 MB
viewport-pan-sweep: DOM nodes ▂▁▂▂▂▂█▂▁▁▁▂▂▂▂ ➡️ -228
viewport-pan-sweep: event listeners ▃▃▂▃▁▇█▁▃▃▃▄▃▃▄ ➡️ -149
vue-large-graph-idle: avg frame time ▁▃▆▇▆▃▄▂▅█▇▁▆▃█ ➡️ 18ms
vue-large-graph-idle: p95 frame time ▁▅▄▄▅██▅▅▄▁██▄▅ ➡️ 17ms
vue-large-graph-idle: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-large-graph-idle: style recalc duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-large-graph-idle: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-large-graph-idle: style recalc count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-large-graph-idle: task duration ▂▇▇▅▇▅▆▄▇█▇▁▆▂█ ➡️ 16446ms
vue-large-graph-idle: script duration ▂▆▇▄█▆▅▄▆▇▇▁▅▁█ ➡️ 278ms
vue-large-graph-idle: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-large-graph-idle: heap used ▂▁▃▁▆▃▃▃▄▃▄▅▄█▆ ➡️ 179.6 MB
vue-large-graph-idle: DOM nodes ▂▂▂▁▂▂▂▂▁▂▂████ ➡️ -8049
vue-large-graph-idle: event listeners ▁▁▁▁▁▁▁▁▁▁▁▇▇█▇ ➡️ -14923
vue-large-graph-pan: avg frame time ▁▇▇▄█▇▆█▇▆▅▂▆▁▇ ➡️ 18ms
vue-large-graph-pan: p95 frame time ▄█▄▄▄█▁▄███▁▄▄█ ➡️ 17ms
vue-large-graph-pan: layout duration ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
vue-large-graph-pan: style recalc duration ▂▄▄▃█▆▄▃▅▃▄▁▃▁▅ ➡️ 18ms
vue-large-graph-pan: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0
vue-large-graph-pan: style recalc count ▁██▅▇▅▅▅▆▅▆▁▆▁█ 📉 168
vue-large-graph-pan: task duration ▂▆▇▄█▄▅▄▆▆▆▁▅▁█ ➡️ 20841ms
vue-large-graph-pan: script duration ▂▇▇▄▇▇▆▄█▆▇▂▆▁█ ➡️ 921ms
vue-large-graph-pan: TBT ▃▆▅▁▄▃▂▂▄█▄▃▂▁▇ 📈 84ms
vue-large-graph-pan: heap used ▅▁▇▄▁█▃▃▆▄▅▄▂▁▃ ➡️ 172.6 MB
vue-large-graph-pan: DOM nodes ▁▂▂▁▂▁▂▁▂▂▂████ ➡️ -8049
vue-large-graph-pan: event listeners ▁▁▁▁▁▁▁▁▁▁▁████ ➡️ -14923
vue-node-resize-workload: avg frame time ▃▂▅▄▅▃▄▄▃▅█▁▄▂▅ ➡️ 18ms
vue-node-resize-workload: p95 frame time █▆████▆▁▆▃▃▆▆▆█ ➡️ 17ms
vue-node-resize-workload: layout duration ▄▅█▃▇▆▆▃▇▅▄▁▅▁▅ ➡️ 23ms
vue-node-resize-workload: style recalc duration ▂▇█▃▇▅▆▃▆▆▆▁▆▁▇ ➡️ 79ms
vue-node-resize-workload: layout count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 20
vue-node-resize-workload: style recalc count ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 20
vue-node-resize-workload: task duration ▃▆▇▅█▅▆▅▅▇▇▁▆▁█ ➡️ 6141ms
vue-node-resize-workload: script duration ▂▅▇▅█▆▅▄▅▇▆▁▅▁▇ ➡️ 112ms
vue-node-resize-workload: TBT ▃▆▇▄█▄▆▄▄▇▇▁▇▁▇ 📉 387ms
vue-node-resize-workload: heap used ▅▅▂▄▂▄▃▆▃▄▄▆▃█▁ ➡️ 165.7 MB
vue-node-resize-workload: DOM nodes ▄▄▄▄▄▄▄▁▄▄▄████ ➡️ -8049
vue-node-resize-workload: event listeners ▂▂▂▂▂▂▂▂▁▂▂████ ➡️ -14923
workflow-execution: avg frame time ▃▃▁▁▆▆▆▃▆██▃▁▆▃ ➡️ 17ms
workflow-execution: p95 frame time ▆█▆▃▆▁▁▁▃▆▃█▃▆▃ ➡️ 17ms
workflow-execution: layout duration ▃▅▁▁▅▄▇▂▄█▅▃▅▂▆ 📈 2ms
workflow-execution: style recalc duration ▃▅▅▃▇▄▅▂▅█▄▁▃▁▅ ➡️ 20ms
workflow-execution: layout count ▁▆▁▃▃▁▅▃▆█▅▅▆▁█ 📈 4
workflow-execution: style recalc count ▃▃▄▃▆▁▂▁▄▇▂▃▂▃█ 📈 19
workflow-execution: task duration ▂▅▅▃▇▃▄▁▅█▄▁▄▁█ ➡️ 126ms
workflow-execution: script duration ▁▄▄▃▆▃▄▁▇█▄▁▅▂█ 📈 13ms
workflow-execution: TBT ▄▄▄▄▄▄▄▄▄▄▄▄▄▄▄ ➡️ 0ms
workflow-execution: heap used ▇▇▆██▄▆▆▅█▄▁▄▁▃ ➡️ 64.0 MB
workflow-execution: DOM nodes ▆▄▄▃▅▄▃▃▅█▃▁▂▁▃ ➡️ 119
workflow-execution: event listeners ▃▂▄▄▆▁▁▁▄▆▁▄▁▄█ 📈 81
Raw data
{
  "timestamp": "2026-09-24T21:18:46.842Z",
  "gitSha": "c1d934c7914c0ce68ebcc5b36b2a4b642bbb22e8",
  "branch": "backport-17117-to-core-1.53",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2025.935000000004,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 5.340000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 418.728,
      "heapDeltaBytes": -14021728,
      "heapUsedBytes": 56819628,
      "domNodes": -279,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 6.667000000000001,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2019.8609999999917,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.093999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 427.16499999999996,
      "heapDeltaBytes": 7519252,
      "heapUsedBytes": 77963868,
      "domNodes": -277,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 7.100000000000002,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1720.4329999999572,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 24.979000000000003,
      "layouts": 14,
      "layoutDurationMs": 3.302,
      "taskDurationMs": 712.171,
      "heapDeltaBytes": -7737876,
      "heapUsedBytes": 62924736,
      "domNodes": -280,
      "jsHeapTotalBytes": 4186112,
      "scriptDurationMs": 108.836,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1704.431999999997,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 25.266000000000005,
      "layouts": 14,
      "layoutDurationMs": 3.2329999999999997,
      "taskDurationMs": 666.122,
      "heapDeltaBytes": -11048580,
      "heapUsedBytes": 59702932,
      "domNodes": -278,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 103.26299999999999,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1671.842999999967,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 12.122000000000002,
      "layouts": 6,
      "layoutDurationMs": 0.9629999999999999,
      "taskDurationMs": 289.80899999999997,
      "heapDeltaBytes": 4442384,
      "heapUsedBytes": 75104592,
      "domNodes": 79,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 9.154000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1658.5900000000038,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 11.693999999999999,
      "layouts": 6,
      "layoutDurationMs": 0.8920000000000001,
      "taskDurationMs": 281.215,
      "heapDeltaBytes": 4441672,
      "heapUsedBytes": 75114988,
      "domNodes": 78,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 7.627999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 574.6859999999856,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 6.0840000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 361.981,
      "heapDeltaBytes": 18455776,
      "heapUsedBytes": 82745856,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 122.73200000000001,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 536.7820000000165,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 5.176,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 330.755,
      "heapDeltaBytes": -7845464,
      "heapUsedBytes": 62901488,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 109.733,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000273
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2011.1390000000142,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 3.8010000000000024,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 498.11300000000006,
      "heapDeltaBytes": 10279472,
      "heapUsedBytes": 85893260,
      "domNodes": -270,
      "jsHeapTotalBytes": -1130496,
      "scriptDurationMs": 32.01,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2025.351999999998,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 4.749000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 498.896,
      "heapDeltaBytes": 10781352,
      "heapUsedBytes": 86063372,
      "domNodes": -266,
      "jsHeapTotalBytes": -1392640,
      "scriptDurationMs": 21.82,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2113.756999999964,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 6.772,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1169.625,
      "heapDeltaBytes": 21798136,
      "heapUsedBytes": 88017388,
      "domNodes": 4,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 564.4559999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2146.099999999933,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 8.056000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1242.205,
      "heapDeltaBytes": 10704296,
      "heapUsedBytes": 87926688,
      "domNodes": -270,
      "jsHeapTotalBytes": 667648,
      "scriptDurationMs": 598.286,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3131.528000000003,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 10.459,
      "layouts": 60,
      "layoutDurationMs": 10.697,
      "taskDurationMs": 1276.7180000000003,
      "heapDeltaBytes": 7724696,
      "heapUsedBytes": 75169552,
      "domNodes": 8,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 548.943,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3072.593999999981,
      "styleRecalcs": 63,
      "styleRecalcDurationMs": 8.231000000000002,
      "layouts": 60,
      "layoutDurationMs": 7.838999999999999,
      "taskDurationMs": 1193.3799999999999,
      "heapDeltaBytes": 10795488,
      "heapUsedBytes": 79895736,
      "domNodes": 8,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 502.29699999999997,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2101.3869999999883,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 4.663999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1356.5819999999999,
      "heapDeltaBytes": 14397816,
      "heapUsedBytes": 81441892,
      "domNodes": -5,
      "jsHeapTotalBytes": 1204224,
      "scriptDurationMs": 635.849,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2259.064999999964,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 4.858000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1374.4299999999998,
      "heapDeltaBytes": 17871728,
      "heapUsedBytes": 85119120,
      "domNodes": 8,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 645.8870000000001,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2010.5379999999968,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 3.518999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 468.53900000000004,
      "heapDeltaBytes": 10517520,
      "heapUsedBytes": 87067340,
      "domNodes": -271,
      "jsHeapTotalBytes": -2703360,
      "scriptDurationMs": 22.779000000000007,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2002.4160000000393,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 3.9489999999999976,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 452.547,
      "heapDeltaBytes": 21850752,
      "heapUsedBytes": 87314656,
      "domNodes": -271,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 24.831,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 541.1720000000173,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 7.656999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 316.691,
      "heapDeltaBytes": 14845916,
      "heapUsedBytes": 87617872,
      "domNodes": 22,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 100.81599999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 498.1989999999996,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 7.283000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 294.04600000000005,
      "heapDeltaBytes": 14926328,
      "heapUsedBytes": 87775756,
      "domNodes": 20,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 94.399,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2003.9050000000316,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.612999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 409.004,
      "heapDeltaBytes": -11943792,
      "heapUsedBytes": 60903328,
      "domNodes": -292,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 7.437999999999999,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.073999999975,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 5.8679999999999986,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 406.667,
      "heapDeltaBytes": 2429572,
      "heapUsedBytes": 75221644,
      "domNodes": -293,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 6.284999999999999,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1727.4829999999497,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 26.062999999999995,
      "layouts": 18,
      "layoutDurationMs": 3.3230000000000004,
      "taskDurationMs": 644.263,
      "heapDeltaBytes": -12375536,
      "heapUsedBytes": 60333012,
      "domNodes": -294,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 72.735,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1672.5400000000263,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 24.126,
      "layouts": 18,
      "layoutDurationMs": 3.1279999999999997,
      "taskDurationMs": 597.0360000000001,
      "heapDeltaBytes": -13080848,
      "heapUsedBytes": 59745968,
      "domNodes": -297,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 66.31099999999999,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 916.0369999999602,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 23.012999999999998,
      "layouts": 16,
      "layoutDurationMs": 10.227999999999998,
      "taskDurationMs": 691.821,
      "heapDeltaBytes": -7347800,
      "heapUsedBytes": 86427696,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 20.734999999999996,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 102,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8143.274000000019,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 26.776999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4297.549,
      "heapDeltaBytes": 13489668,
      "heapUsedBytes": 89135088,
      "domNodes": -270,
      "jsHeapTotalBytes": -118784,
      "scriptDurationMs": 1876.7559999999999,
      "eventListeners": -167,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8188.535999999999,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 27.199,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4361.135,
      "heapDeltaBytes": -16181744,
      "heapUsedBytes": 84655384,
      "domNodes": -269,
      "jsHeapTotalBytes": -1392640,
      "scriptDurationMs": 1924.507,
      "eventListeners": -137,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 11201.870999999983,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10589.612,
      "heapDeltaBytes": -34184340,
      "heapUsedBytes": 175963824,
      "domNodes": -6548,
      "jsHeapTotalBytes": -2985984,
      "scriptDurationMs": 145.066,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12023.694999999974,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11353.017,
      "heapDeltaBytes": -33100456,
      "heapUsedBytes": 176485820,
      "domNodes": -6548,
      "jsHeapTotalBytes": -3088384,
      "scriptDurationMs": 178.26000000000002,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14119.600999999988,
      "styleRecalcs": 69,
      "styleRecalcDurationMs": 12.05399999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 13436.567000000001,
      "heapDeltaBytes": -10842296,
      "heapUsedBytes": 189898012,
      "domNodes": -6548,
      "jsHeapTotalBytes": 2293760,
      "scriptDurationMs": 676.3560000000001,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 14681.695999999989,
      "styleRecalcs": 71,
      "styleRecalcDurationMs": 12.419000000000013,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14084.566000000003,
      "heapDeltaBytes": -27072316,
      "heapUsedBytes": 188670704,
      "domNodes": -6548,
      "jsHeapTotalBytes": -913408,
      "scriptDurationMs": 756.437,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 42,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4344.789999999989,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 60.59600000000004,
      "layouts": 20,
      "layoutDurationMs": 20.348000000000006,
      "taskDurationMs": 4209.275,
      "heapDeltaBytes": -25773484,
      "heapUsedBytes": 176363604,
      "domNodes": -6548,
      "jsHeapTotalBytes": 12599296,
      "scriptDurationMs": 75.92799999999998,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 24,
      "frameDurationMs": 17.220000000000013,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4044.655999999918,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 60.284999999999975,
      "layouts": 20,
      "layoutDurationMs": 18.394999999999996,
      "taskDurationMs": 3893.6600000000008,
      "heapDeltaBytes": -19831060,
      "heapUsedBytes": 182043872,
      "domNodes": -6548,
      "jsHeapTotalBytes": 14962688,
      "scriptDurationMs": 64.993,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 100,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "workflow-execution",
      "durationMs": 448.72299999997267,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 16.740000000000002,
      "layouts": 2,
      "layoutDurationMs": 0.569,
      "taskDurationMs": 97.20899999999999,
      "heapDeltaBytes": 5076384,
      "heapUsedBytes": 73555432,
      "domNodes": 130,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.444999999999999,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 451.7549999999346,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 16.882,
      "layouts": 3,
      "layoutDurationMs": 1.3380000000000003,
      "taskDurationMs": 93.08500000000001,
      "heapDeltaBytes": 5209456,
      "heapUsedBytes": 73668192,
      "domNodes": 150,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 8.013,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 48391 71079 68.1% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.2% 1185
src/LGraphNode.ts 69.6% 396
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.2% 302
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 78.4% 261
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.7% 247
src/scripts/pnginfo.ts 21.4% 221
src/renderer/core/canvas/pathRenderer.ts 24.7% 192

@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 24, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e7cdae05ce

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/stores/modelStore.ts
() => flags.assetsEnabled,
() => {
reloadModels().catch((error) => {
reportError(error, { errorType: 'model_library_capability_reload' })

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Rename the telemetry error type to the required form

Both new failure handlers emit model_library_capability_reload, which starts with the subject and uses reload rather than a present-participle operation. This prevents these failures from sorting and grouping with the repository's error telemetry taxonomy; use a generic-to-specific slug such as error_reloading_model_library_after_capability_change.

AGENTS.md reference: src/AGENTS.md:L23-L28

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rejected: out of scope for a backport. Renaming it here would split the error type across branches; it belongs on main.

Comment thread src/stores/modelStore.ts
Comment on lines +537 to +543
watch(
() => flags.assetsEnabled,
() => {
reloadModels().catch((error) => {
reportError(error, { errorType: 'model_library_capability_reload' })
})
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Serialize the capability reload with the eager load

When the feature_flags handshake enables assets after GraphView has populated the folder names but before any folder has loaded, this watcher races the mounted sidebar's new loadModels() watcher. reloadModels() snapshots every old folder as uninitialized, while loadModels() starts loading those legacy folder objects; the reload then replaces them with fresh, uninitialized asset-backed folders, so the completed legacy loads are detached and asset-mode search and badges remain incomplete until the user expands folders or refreshes. The source-switch reload and asset-mode eager load need to be one serialized operation.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rejected for this backport: the same code is on main from #17117. Being fixed on main, and that fix will be offered as its own backport.

@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.13043% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...components/sidebar/tabs/ModelLibrarySidebarTab.vue 71.42% 2 Missing ⚠️
src/stores/modelStore.ts 83.33% 2 Missing ⚠️
src/platform/assets/services/assetService.ts 87.50% 1 Missing ⚠️
@@              Coverage Diff              @@
##           core/1.53   #18729      +/-   ##
=============================================
+ Coverage      83.33%   83.43%   +0.09%     
=============================================
  Files           2036     2035       -1     
  Lines         117778   117929     +151     
  Branches       32696    33302     +606     
=============================================
+ Hits           98156    98395     +239     
+ Misses         19268    19171      -97     
- Partials         354      363       +9     
Flag Coverage Δ
e2e 66.56% <64.70%> (-0.05%) ⬇️
unit 76.81% <88.88%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/composables/graph/useErrorClearingHooks.ts 96.72% <ø> (-0.04%) ⬇️
src/composables/useCoreCommands.ts 64.42% <100.00%> (+0.57%) ⬆️
src/extensions/core/widgetInputs.ts 95.07% <100.00%> (-0.31%) ⬇️
...form/assets/composables/openModelLibraryBrowser.ts 100.00% <100.00%> (ø)
src/platform/assets/utils/assetPreviewUtil.ts 90.47% <100.00%> (-0.23%) ⬇️
src/platform/missingModel/missingModelPipeline.ts 83.52% <100.00%> (+1.92%) ⬆️
src/platform/settings/constants/coreSettings.ts 85.24% <ø> (-0.24%) ⬇️
...sions/vueNodes/widgets/components/WidgetSelect.vue 98.00% <100.00%> (ø)
...ons/vueNodes/widgets/composables/useComboWidget.ts 77.60% <100.00%> (ø)
src/schemas/apiSchema.ts 100.00% <ø> (ø)
... and 5 more

... and 64 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed as the 1.53 backport of #17117, since this is the change that puts the server-flag gating in front of the external testing cohort.

The two E2E failures are pre-existing on core/1.53, not caused by this PR

I want to state the evidence rather than the conclusion, because the conclusion is the opposite of what it first looked like.

The run fails allNodes.spec.ts:61 (S3 save/reload contracts) and connectivity.spec.ts:208 (representative edges through model, serialize and prompt conversion), with graphToPrompt rejected a restored dangling link: InvalidLinkError: No input node found for id [734] slot [0] model. On an assets-gating backport, two failures both naming model slots is about as incriminating as CI gets.

First control, against main: main's latest CI: Tests Custom Nodes run has 51 failures, and neither of these two is among them. Taken alone that supports the regression reading, since the failure set is disjoint and ours are the assets-shaped ones.

Second control, against unrelated core/1.53 backports:

Run Failures Ours?
backport-17486-to-core-1.53 2 both
backport-18301-to-core-1.53 2 both
backport-17916-to-core-1.53 0 —

Two backports with nothing to do with assets fail exactly these two tests and nothing else. So they are a property of core/1.53, not of this change. The third run being clean says they are intermittent or environment-dependent on that branch rather than hard-broken, which is worth knowing separately.

Not a blocker for this PR. It is worth someone owning on the branch, because "custom nodes E2E is red" is currently indistinguishable from "custom nodes E2E is red for a new reason", and this PR is exactly the kind of change where that distinction matters.

The Vercel – billing-web-test failure is a preview deploy and looks unrelated to the diff.

The actual finding: three files from #17117 are not in this backport

.github/actions/build-cloud-frontend/action.yaml
scripts/checkAssetsFlagArtifact.ts
scripts/checkAssetsFlagArtifact.test.ts

67 files in the original, 64 here, and nothing added in exchange.

Those are not incidental CI plumbing. checkAssetsFlagArtifact is the build gate for the exact refactor being backported. It asserts, per distribution, that the widget asset-picker gate compiles to a static constant, false/!1 off-cloud, which is what proves the picker is statically stripped and lets the bundler drop everything behind it. It also scans every chunk, including sourcesContent, for COMFY_PRODUCTION_FORBIDDEN_MOCK_ASSET_SENTINEL, so a test-fixture mock asset cannot reach a production bundle. The action wiring is what makes it run on every caller of build-cloud-frontend.

So core/1.53 gets the refactor without the check that the refactor stayed correct. On the branch that is about to carry the external testing cohort, that inverts the usual backport risk trade: the release line with the less watched build is the one losing the build gate.

Three ways this could be fine, and I cannot tell which from here:

  1. The gate depends on build tooling that does not exist on core/1.53, so it could not be carried.
  2. isWidgetAssetPickerEnabled differs enough on 1.53 that the assertions would not hold as written.
  3. It was dropped as CI-only noise during the backport.

If (1) or (2), say so in the description and I am satisfied. If (3), I would carry them: they are self-contained, and the sentinel scan in particular is cheap insurance against precisely the failure mode a hurried backport introduces.

Otherwise

The remaining 64 files line up with the original one for one, and the diff is the same shape: +374/-364 here against +455/-448 there, consistent with 1.53 lacking some of the surfaces main had rather than with hunks being dropped.

No objection to the backport itself. Answer the three-file question and this is good to go.

@synap5e synap5e added the cursor-review Trigger multi-model Cursor agent review on this PR label Sep 24, 2026
@synap5e

synap5e commented Sep 24, 2026

Copy link
Copy Markdown
Contributor Author

Answering the three-file question.

The files were never on core/1.53. checkAssetsFlagArtifact and its wiring (the build manifest, the mock-asset sentinel, the package script, the ci-tests-e2e and build-cloud-frontend steps) came from #16480 and #16570, which weren't backported to 1.53. #17117 only renamed things inside those files, so on 1.53 there was nothing to modify. The action.yaml hunk rewords a verify step that 1.53 doesn't have.

That's closest to your (1), but narrower. keepNames is already on 1.53, and the gate compiles correctly there. I copied main's script onto this branch locally and added only the emit-build-manifest plugin. Localhost, desktop and cloud builds, minified and unminified, all pass the check: the gate comes out as return!1 off-cloud and return!0 on cloud. What 1.53 lacks is #16480 and #16570 themselves, and carrying the gate properly means backporting those.

So I'd keep this PR as the #17117 backport and treat the gate as a separate backport of #16480 and #16570. The description now says this.

On the custom-nodes E2E: agreed, it's pre-existing. One correction: #18525's first attempt failed the same two tests (its second attempt errored after the PR merged). Every core/1.53 run since 2026-09-22 ~23:00 UTC fails them the same way.

Separately, Codex's P2 about the late assets-flag reload is a real race, and it's in #17117 on main as well. When the flag arrives after the folder names load, the sidebar's eager load lands on the legacy folders that the reload then replaces, so asset-mode folders stay unloaded until you expand one or search. I'm fixing it on main. Do you want that fix backported to this line as well?


Answering from my context. 👎 if unhelpful.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @synap5e.

Found 8 finding(s).

Severity Count
🟡 Medium 2
🟢 Low 5
⚪ Nit 1

Panel: 8/8 reviewers contributed findings.

watch(
() => flags.assetsEnabled,
async (enabled) => {
if (enabled) await withLoadFailureToast(() => modelStore.loadModels())

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — This watcher duplicates the new watch(() => flags.assetsEnabled) added to modelStore in the same PR, and both fire on the same flip. The store's reloadModels() rebuilds the folder map and only re-loads folders that were non-Uninitialized before the flip, so this loadModels() populates the pre-flip folder objects (still holding the legacy api.getModels closure) which the store's commit then discards — leaving the freshly committed map entirely Uninitialized in the common case, plus a possible spurious modelLibraryLoadFailed toast from the discarded legacy fetch. Consider dropping this watcher and letting the store's reload own the eager load.

Raised by 5 of 8 reviewers (claude-opus-5-thinking-max adversarial, gpt-5.6-sol-max adversarial, claude-opus-5-thinking-max edge-case, gemini-3.1-pro edge-case, gpt-5.6-sol-max edge-case).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rejected for this backport: the same code is on main from #17117. Being fixed on main, and that fix will be offered as its own backport.

Comment thread src/stores/modelStore.ts
watch(
() => flags.assetsEnabled,
() => {
reloadModels().catch((error) => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Medium — If this one-shot reload rejects (e.g. a transient getModelFolders failure right at handshake time), the error is only reported: the already-built ModelFolders keep the getModelsFunc captured for the previous capability while flags.assetsEnabled has already flipped, so the data source and every flag-derived gate (visibleModelFolders, widget routing) disagree with no retry until a manual refresh. Consider retrying or marking the library stale on failure.

Raised by 2 of 8 reviewers (gpt-5.6-sol-max adversarial, gpt-5.6-sol-max edge-case).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rejected: out of scope for a backport (identical to #17117 on main); noted for main.

import { useToastStore } from '@/platform/updates/common/toastStore'

export async function openModelLibraryBrowser(): Promise<void> {
if (!useFeatureFlags().flags.assetsEnabled) return

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — This early return makes Comfy.BrowseModelAssets a completely silent no-op: the command stays registered and visible in the command palette on every distribution, so on a backend without the assets capability the user invokes it and gets no dialog, no toast, not even a console line — the removed flow at least prompted to enable the API. Gate the command's registration/visibility on flags.assetsEnabled, or surface a toast here.

Raised by 5 of 8 reviewers (claude-opus-5-thinking-max adversarial, kimi-k3-max adversarial, claude-opus-5-thinking-max edge-case, gemini-3.1-pro edge-case, kimi-k3-max edge-case).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rejected: deliberate in #17117. The command does nothing when the server doesn't advertise assets.

Comment thread src/stores/modelStore.ts
* stale response a no-op, so no debouncing is needed here.
*/
watch(
() => flags.assetsEnabled,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — Unlike the scan subscription a few lines above, which deliberately skips work with if (!modelDataConsumed) return, this watcher reloads unconditionally — a handshake landing after store init fires api.getModelFolders() plus a per-folder walk even when no UI has ever read the store. Applying the same modelDataConsumed guard would keep the two capability paths consistent.

Raised by 2 of 8 reviewers (claude-opus-5-thinking-max adversarial, claude-opus-5-thinking-max edge-case).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rejected: out of scope for a backport (identical to #17117 on main). A modelDataConsumed guard would also leave the boot-built folders on the wrong data source.

// Cloud always has assets enabled, so the unmocked asset endpoints would 403
// and workflow restore would throw uncaught. One glob covers every shape boot
// asks for: `/api/assets`, `?query`, `/seed`, `/<id>`.
await page.route('**/api/assets**', (route) => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — The comment claims one glob covers /<id>, but the fulfilled body is the list envelope: **/api/assets** also matches GET /api/assets/<id>, which assetService.getAssetDetails validates against the single-asset schema and rejects with Invalid asset response against zod schema — reproducing the exact uncaught boot-chain throw this mock exists to prevent (/<id>/content is likewise served JSON). Match only the list shapes or branch on the URL; the same block is duplicated verbatim in checkoutRecovery.spec.ts and pricingTableDeepLink.spec.ts.

Raised by 2 of 8 reviewers (claude-opus-5-thinking-max edge-case, kimi-k3-max edge-case).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rejected: out of scope for a backport. The fixture is identical on main, and no current test fetches those paths.

if (!isCloud) return false
return !!useSettingStore().get('Comfy.Assets.UseAssetAPI')
function isWidgetAssetPickerEnabled(): boolean {
return isCloud

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — Every other asset surface in this PR now gates on flags.assetsEnabled, but widget pickers gate on distribution alone, so a cloud backend that does not advertise assets (incident, staged rollout, older deployment) still renders pickers that call asset endpoints — and with Comfy.Assets.UseAssetAPI gone there is no user- or server-side kill switch left. Consider isCloud && useFeatureFlags().flags.assetsEnabled.

Raised by 2 of 8 reviewers (kimi-k3-max adversarial, gemini-3.1-pro edge-case).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rejected: widget pickers are deliberately cloud-only in #17117.

Comment thread src/stores/modelStore.ts

function createGetModelsFunc(): (folder: string) => Promise<ModelFile[]> {
return usesAssetApi()
return flags.assetsEnabled

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Low — Deriving the data source purely from the capability flag means a non-cloud backend that merely advertises assets now silently switches the model library from the live filesystem listing to the asset database, with the user setting that previously defaulted off locally no longer available as an escape hatch. If that database is not yet seeded, visibleModelFolders filters out the empty folders, so the sidebar renders blank with no hint that anything is missing.

Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rejected: retiring Comfy.Assets.UseAssetAPI is the intent of #17117.

await commandStore.commands
.find((cmd) => cmd.id === 'Comfy.BrowseModelAssets')
?.function?.()
await openModelLibraryBrowser()

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ Nit — Calling the implementation directly instead of resolving Comfy.BrowseModelAssets from the command store bypasses the command registry, so an extension that re-registers that command id (allowed — registerCommand replaces by id) now affects only the palette entry and not the model-library sidebar button. Resolving through useCommandStore() keeps the two entry points in agreement.

Raised by 1 of 8 reviewers (claude-opus-5-thinking-max adversarial).

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rejected: out of scope for a backport (identical to #17117 on main).

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified your three-file answer and it holds, with a control: scripts/checkAssetsFlagArtifact.ts 404s on core/1.53 and resolves on main, and #16480/#16570 both merged to main only. So the file-set difference is 1.53 lacking those two PRs, not this backport dropping anything. That closes it for me.

Your version is also narrower and better evidenced than my (1) — I asked whether the tooling was absent; you went and proved the gate itself compiles correctly on 1.53 by copying main's script across and checking return!1 off-cloud and return!0 on cloud. Treating the gate as a separate backport of #16480 and #16570 is the right split, and having the description say so is what I actually wanted.

Taking your E2E correction too. I established pre-existing by comparing against #17486 and #18301; you've given the sharper fact, that #18525's first attempt failed the same two and every core/1.53 run since 2026-09-22 ~23:00 UTC fails them identically. That's an onset, which is more useful than my "not caused by this PR".

On backporting the late-flag reload race: yes

Specifically because this is the cohort line.

The whole reason #17117 is being backported is to put server-flag gating in front of the external testers. If 1.53 gets the refactor without the race fix, then the first thing that cohort sees of asset-mode folders is the broken ordering: folders stay unloaded until they expand one or search. They will report it, and it will read as "assets sidebar is empty" rather than "load-order race", so you would be paying for the reports twice — once triaging them, once re-testing after the fix lands.

Shipping a known defect to the population you assembled to find unknown defects is the part that makes this worth the extra backport, rather than general risk appetite about touching a release line.

One sequencing ask: land them together, or land the race fix on main first and backport both in order. If this merges alone there is a window where 1.53 carries the refactor and not the fix, and if the cohort starts in that window the first-impression problem happens anyway.

Not blocking this PR on it — it's approved and correct as the #17117 backport. Just don't want the cohort to meet 1.53 in between.

@AustinMroz

Copy link
Copy Markdown
Collaborator

I second being careful on an actual merge here. I'll take a closer look at the actual tests once I've looked over the sibbling backports. From my very quick hand testing everythin appears to work as expected.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AustinMroz — since you're about to look at the tests across the sibling backports, here's what's already been established so you don't redo it.

The two custom-nodes E2E failures on this PR are pre-existing on core/1.53, not caused by it. What I verified directly:

  • main's latest CI: Tests Custom Nodes run has 51 failures, and neither of these two is among them. That alone looks like evidence for a regression, which is why the second control matters.
  • backport-17486-to-core-1.53 and backport-18301-to-core-1.53 — neither touching assets — each fail exactly these two tests and nothing else. backport-17916-to-core-1.53 had zero.

Failing tests are allNodes.spec.ts:61 (S3 enrolled save/reload contracts) and connectivity.spec.ts:208 (representative edges through model/serialize/prompt), with graphToPrompt rejected a restored dangling link: InvalidLinkError: No input node found for id [734] slot [0] model.

Both name model slots on an assets-gating backport, which is about as incriminating as CI gets and is exactly why one control isn't enough. Stopping after the main comparison would have produced a confident, wrong regression report.

Simon added an onset I have not independently checked: that #18525's first attempt failed the same two, and every core/1.53 run since 2026-09-22 ~23:00 UTC fails them identically. Worth confirming if you need the exact boundary, but the "not this PR" conclusion stands on the two backport controls alone.

The separate thing worth your eye when you get to it is the late-flag reload race Codex found (P2), which is in #17117 on main too and is the one defect here that a tester would actually notice: asset-mode folders stay unloaded until expanded or searched. Simon is fixing it on main and asked about backporting; I argued yes, because this is the cohort line and the sequencing matters — merging this alone opens a window where 1.53 has the refactor without the fix.

@comfy-pr-bot
comfy-pr-bot merged commit 93dd6b4 into core/1.53 Sep 25, 2026
155 of 160 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-17117-to-core-1.53 branch September 25, 2026 03:56

This branch had an error being deployed

1 failed deployment
Preview – billing-web-test — e7cdae05 Deployed Sep 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate cursor-review Trigger multi-model Cursor agent review on this PR risk:R3 PR risk grade (advisory shadow check; grader-owned) risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants