Repository navigation
[backport core/1.54] fix(agent): wait for the general onboarding before offering Agent consent (#18431) - #18571
MaanilVerma wants to merge 1 commit into
Conversation
…sent (#18431) A new cloud user's first login showed the Agent consent card on top of the Getting Started screen, and accepting it started the Agent coach over a hidden canvas. The automatic offer now waits until the general onboarding is out of the way: it holds for the whole first session when Getting Started or the first-run tour takes the screen, and it appears on the next login instead. The Agent button still opens the card at any time. - Fixes PM-1497 - **What**: `offerConsentUnprompted` in `agentPanel.ts` waits for the boot's first-run decision before evaluating, and returns before writing the one-shot key while `firstRunTookScreen` is set or a coachmark tour is on screen. When a tour ends, the offer runs again through the same wait, so a held offer comes back the moment the screen is free. `useFirstRunEntry` now reports two per-boot facts: `firstRunTookScreen` (Getting Started showed, or a template/share link started the tour) and `whenStartupDecided()` (the first-run stages have run, fail-closed after a 60s grace). - **Breaking**: None. Existing users, local and desktop, and users whose general onboarding never comes are offered exactly as before. - The hold is a per-boot latch, on purpose: a new user who finishes Getting Started and keeps the tab open gets the offer on their next login, not later in the same session. That is Jo's "second session" rule, and it is what `keeps withholding after a tour ends when Getting Started took the screen` pins. - The offer waits for the boot to decide (`whenStartupDecided`) rather than asking whether the user qualifies for Getting Started. The earlier draft asked "would it show", which held the offer forever for team-workspace users whose restored work skips Getting Started while their tutorial flag was never written. "Did it show" has no such cohort. - Fail-closed on the grace: a boot that never reports skips this session's automatic offer rather than landing it on a late first-run screen. The one-shot key is untouched, so the next boot or any later trigger offers. A healthy boot never pays the 60s. - One residual, named in the guard comment: a tour that auto-opens after the guard has passed but before the card paints still shows under it. The wait closes this for every tour the boot starts; only a trigger firing later in the session can hit it, and the consequence is cosmetic. - `firstRunEntry.ts` gains only additive state; every existing branch and every `TutorialCompleted` writer is unchanged. Three independent audits of the ~30 PRs that built and stabilized this onboarding found no regressed invariant (reports under `temp/summaries/pm-1497-regression-audit-*.md`). - Layer note: `src/extensions/core` reaches into `renderer/extensions/firstRunTour` for the entry composable, which has precedent in that directory. `firstRunEntry` has no renderer dependency and belongs in `platform/onboarding`; that move is part of the onboarding unification follow-up, together with registering the consent card into the What's New overlay store from #18287 and emitting a telemetry stage when the offer is withheld. - [x] Unit: 98 passing across the two touched suites; 177 files / 2,730 tests across every onboarding-adjacent and agent suite - [x] Revert-red: guard removed fails 5 cases, decision wait removed fails 3, fail-closed check removed fails 1, tour watch removed fails 1; all 98 green intact - [x] Flip-check: 17/17 changed tests fail on the merge-base, 0 false-green - [x] Mutation: 9/9 killed on changed lines, 0 survivors, coverage complete - [x] E2E (`@cloud`, CI): new user boot shows Getting Started with no consent card, anchored on the consent read; existing "Automatic agent consent" describe is the positive control on a returning-user boot - [x] Manual (staging): sign in as a new user, confirm Getting Started shows with no consent card; dismiss it, pick a template, finish or skip the tour, confirm no card this session; reload, confirm the card appears; as a returning user in App Mode with outputs and no consent, confirm the App Mode tour runs first and the card follows it https://github.com/user-attachments/assets/c3bb229c-090e-4edb-b9cb-5bdc03c8af79
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1946 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-23T08:17:47.065Z",
"gitSha": "a7cbc27ea8ec8cdd0656e634e5abced49b747912",
"branch": "backport-18431-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2209.269999999947,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.524000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 859.1399999999999,
"heapDeltaBytes": 3843888,
"heapUsedBytes": 74157296,
"domNodes": -283,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 15.895,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2069.2639999999756,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.180000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 627.197,
"heapDeltaBytes": 3139148,
"heapUsedBytes": 73919384,
"domNodes": -281,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 14.962000000000003,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1927.9249999999593,
"styleRecalcs": 77,
"styleRecalcDurationMs": 37.05,
"layouts": 14,
"layoutDurationMs": 4.872,
"taskDurationMs": 1020.7929999999999,
"heapDeltaBytes": 8430852,
"heapUsedBytes": 79161116,
"domNodes": -278,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 178.45,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1913.007000000107,
"styleRecalcs": 77,
"styleRecalcDurationMs": 35.07599999999999,
"layouts": 14,
"layoutDurationMs": 4.966,
"taskDurationMs": 979.077,
"heapDeltaBytes": -4045256,
"heapUsedBytes": 67106096,
"domNodes": -280,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 177.78199999999998,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1686.743999999976,
"styleRecalcs": 30,
"styleRecalcDurationMs": 20.087,
"layouts": 6,
"layoutDurationMs": 1.319,
"taskDurationMs": 433.97,
"heapDeltaBytes": 4227496,
"heapUsedBytes": 74655252,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 14.97,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1758.750999999961,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.984999999999996,
"layouts": 6,
"layoutDurationMs": 1.365,
"taskDurationMs": 446.33500000000004,
"heapDeltaBytes": 4630072,
"heapUsedBytes": 75580512,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 16.688,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 752.6849999999854,
"styleRecalcs": 10,
"styleRecalcDurationMs": 10.304,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 519.237,
"heapDeltaBytes": -7857348,
"heapUsedBytes": 63304736,
"domNodes": 16,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 174.79899999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 759.5289999999295,
"styleRecalcs": 12,
"styleRecalcDurationMs": 10.251,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 523.1669999999999,
"heapDeltaBytes": 18082712,
"heapUsedBytes": 88182936,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 188.56900000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2024.7190000000046,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.5959999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 698.253,
"heapDeltaBytes": 10959456,
"heapUsedBytes": 87095012,
"domNodes": -274,
"jsHeapTotalBytes": -1941504,
"scriptDurationMs": 36.819,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2071.9669999999724,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.445999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 734.6,
"heapDeltaBytes": 7229152,
"heapUsedBytes": 83867732,
"domNodes": -274,
"jsHeapTotalBytes": -1679360,
"scriptDurationMs": 36.179,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2837.7699999999777,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.434000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1839.19,
"heapDeltaBytes": 27623228,
"heapUsedBytes": 93656968,
"domNodes": -277,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 890.7879999999999,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2900.170000000003,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.239999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1858.3439999999998,
"heapDeltaBytes": 15429048,
"heapUsedBytes": 92591876,
"domNodes": -273,
"jsHeapTotalBytes": -1191936,
"scriptDurationMs": 905.938,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3860.0319999999897,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.759999999999998,
"layouts": 60,
"layoutDurationMs": 13.45,
"taskDurationMs": 1880.7179999999998,
"heapDeltaBytes": 9914044,
"heapUsedBytes": 76582340,
"domNodes": -281,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 837.3459999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3785.2329999999483,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.390999999999998,
"layouts": 60,
"layoutDurationMs": 12.751000000000001,
"taskDurationMs": 1857.8990000000001,
"heapDeltaBytes": 10656908,
"heapUsedBytes": 77466924,
"domNodes": -279,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 822.371,
"eventListeners": -158,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3185.037999999963,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.408000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2088.0270000000005,
"heapDeltaBytes": 22103480,
"heapUsedBytes": 89904764,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1010.664,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3248.1940000000122,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.551999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2087.087,
"heapDeltaBytes": 22121804,
"heapUsedBytes": 89604500,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 1023.4929999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2072.127000000023,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.593000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 734.7489999999999,
"heapDeltaBytes": 5593488,
"heapUsedBytes": 82987232,
"domNodes": -282,
"jsHeapTotalBytes": -1679360,
"scriptDurationMs": 37.316,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2090.960999999993,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.926000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 780.0630000000001,
"heapDeltaBytes": 6669464,
"heapUsedBytes": 83626076,
"domNodes": -277,
"jsHeapTotalBytes": -1941504,
"scriptDurationMs": 39.419,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 652.3540000000025,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.687000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.811,
"heapDeltaBytes": 13931164,
"heapUsedBytes": 86377992,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 150.08100000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 658.1879999999956,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.901,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.29,
"heapDeltaBytes": 15073300,
"heapUsedBytes": 88041956,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 142.422,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2032.4909999999932,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.742999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 619.173,
"heapDeltaBytes": -6733628,
"heapUsedBytes": 65706968,
"domNodes": -295,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 13.134,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2018.9369999999371,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.321,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 602.05,
"heapDeltaBytes": 382896,
"heapUsedBytes": 72794960,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 11.182,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1802.2220000000289,
"styleRecalcs": 78,
"styleRecalcDurationMs": 31.762999999999998,
"layouts": 18,
"layoutDurationMs": 5.444999999999999,
"taskDurationMs": 925.34,
"heapDeltaBytes": 9920220,
"heapUsedBytes": 82683232,
"domNodes": -293,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 123.35199999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1757.3059999999714,
"styleRecalcs": 77,
"styleRecalcDurationMs": 30.002000000000002,
"layouts": 18,
"layoutDurationMs": 5.574000000000001,
"taskDurationMs": 930.1389999999999,
"heapDeltaBytes": -7395928,
"heapUsedBytes": 65682860,
"domNodes": -296,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 123.88200000000002,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.1469999999763,
"styleRecalcs": 19,
"styleRecalcDurationMs": 33.65800000000001,
"layouts": 15,
"layoutDurationMs": 16.621,
"taskDurationMs": 1009.9590000000001,
"heapDeltaBytes": 21101408,
"heapUsedBytes": 110181864,
"domNodes": 13751,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 33.22599999999999,
"eventListeners": 2387,
"totalBlockingTimeMs": 152,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9955.765999999983,
"styleRecalcs": 247,
"styleRecalcDurationMs": 38.802,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6487.641999999999,
"heapDeltaBytes": 13403668,
"heapUsedBytes": 89576808,
"domNodes": -275,
"jsHeapTotalBytes": 348160,
"scriptDurationMs": 2897.415,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 10492.396000000099,
"styleRecalcs": 246,
"styleRecalcDurationMs": 37.887,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6766.067,
"heapDeltaBytes": -11571776,
"heapUsedBytes": 92347284,
"domNodes": -269,
"jsHeapTotalBytes": -663552,
"scriptDurationMs": 3093.472,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17788.478,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17215.832,
"heapDeltaBytes": -30731880,
"heapUsedBytes": 176704296,
"domNodes": -8068,
"jsHeapTotalBytes": -8970240,
"scriptDurationMs": 342.8,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17735.589000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17182.185,
"heapDeltaBytes": -47533276,
"heapUsedBytes": 178418260,
"domNodes": -8068,
"jsHeapTotalBytes": -16367616,
"scriptDurationMs": 322.187,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 22046.226999999988,
"styleRecalcs": 171,
"styleRecalcDurationMs": 23.320000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21781.354,
"heapDeltaBytes": -41196528,
"heapUsedBytes": 182655464,
"domNodes": -8068,
"jsHeapTotalBytes": -14413824,
"scriptDurationMs": 955.039,
"eventListeners": -14925,
"totalBlockingTimeMs": 245,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "vue-large-graph-pan",
"durationMs": 22268.562999999973,
"styleRecalcs": 167,
"styleRecalcDurationMs": 23.929000000000034,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22021.828999999998,
"heapDeltaBytes": -66802632,
"heapUsedBytes": 164975976,
"domNodes": -8068,
"jsHeapTotalBytes": -18526208,
"scriptDurationMs": 1038.2169999999999,
"eventListeners": -14929,
"totalBlockingTimeMs": 106,
"frameDurationMs": 18.889999999999905,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "vue-node-resize-workload",
"durationMs": 6750.653999999997,
"styleRecalcs": 20,
"styleRecalcDurationMs": 91.20299999999997,
"layouts": 20,
"layoutDurationMs": 29.276999999999997,
"taskDurationMs": 6661.862999999999,
"heapDeltaBytes": -31957292,
"heapUsedBytes": 181173068,
"domNodes": -8068,
"jsHeapTotalBytes": 15343616,
"scriptDurationMs": 132.443,
"eventListeners": -14929,
"totalBlockingTimeMs": 575,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6469.737000000009,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.183,
"layouts": 20,
"layoutDurationMs": 25.32200000000001,
"taskDurationMs": 6368.599999999999,
"heapDeltaBytes": -47458532,
"heapUsedBytes": 176882320,
"domNodes": -8068,
"jsHeapTotalBytes": 6193152,
"scriptDurationMs": 118.68299999999999,
"eventListeners": -14931,
"totalBlockingTimeMs": 476,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9100.461999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8699.786,
"heapDeltaBytes": 4656688,
"heapUsedBytes": 190308204,
"domNodes": 0,
"jsHeapTotalBytes": -24641536,
"scriptDurationMs": 176.27799999999993,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9088.206000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8786.248,
"heapDeltaBytes": 23569380,
"heapUsedBytes": 182248716,
"domNodes": 0,
"jsHeapTotalBytes": -2883584,
"scriptDurationMs": 155.84299999999996,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 116.83800000002975,
"styleRecalcs": 8,
"styleRecalcDurationMs": 18.355999999999998,
"layouts": 2,
"layoutDurationMs": 1.497,
"taskDurationMs": 83.201,
"heapDeltaBytes": 3015208,
"heapUsedBytes": 72255044,
"domNodes": 131,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.645999999999998,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 113.39599999996608,
"styleRecalcs": 8,
"styleRecalcDurationMs": 17.279,
"layouts": 2,
"layoutDurationMs": 1.4300000000000002,
"taskDurationMs": 84.30099999999999,
"heapDeltaBytes": 2964428,
"heapUsedBytes": 72009072,
"domNodes": 127,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.514,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.54 #18571 +/- ##
=============================================
+ Coverage 83.63% 83.64% +0.01%
=============================================
Files 2098 2098
Lines 123959 123997 +38
Branches 33430 31589 -1841
=============================================
+ Hits 103675 103720 +45
+ Misses 20105 20098 -7
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 2 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: f9ea315 | Docs | View more details | Give us feedback! |
## Summary Ports to `core/1.54` every merged `main` Agent fix that `cloud/1.54` carries and core does not (the Agent UI catch-up from #18622, the cloud-only CRDT and workflow fixes, and the round-2 fixes), so both release lines are symmetric ahead of the local-agent rollout. ## Changes - **What**: `cherry-pick -x`, in three groups: - Agent UI, as in #18622: #17339, #17908, #17420, #18348, #18043, #17621 (without its two `src/lib/litegraph/` files; a 5 px HUD offset in `SideToolbar.vue` compensates), #17471, #17690. - Cloud-only fixes: #18063, #18073, #18064, #18033, #18289, #18604, #18616, #18376. - Round 2: #17568, #17628, #16491, #18453, #17767, #18431 (from #18571), #18603. - **Already on `core/1.54`**: #17439 (#18161), #17912 (#18186), #18391 (#18595). - **Excluded**: #17730 (core lacks its three files), #18421 (dead code on core builds), #16917 (conflicts with later core changes), #18066 (Christian's request), #18375 and #18251 (need their litegraph hunks). ## Review Focus - On this line the Agent panel registers only in cloud builds (`src/extensions/core/index.ts:41-44`); the shared chrome from #17621 and #17471 and the host telemetry from #18376 and #18603 ship in every build. - `HostTelemetrySink.ts` and its test equal `main`'s files (#18376, then #18603 on top). - #18064: `agentConversationHostDoc.test.ts` keeps this line's file; #18063's new test uses `main`'s version (multi-player 0.3.x stamps). - Supersedes #18571 and the closed #18637. Linear: [PM-1657](https://linear.app/comfyorg/issue/PM-1657), [PM-1656](https://linear.app/comfyorg/issue/PM-1656) ## Screenshots (if applicable) Visual changes are the ones reviewed on `main` and carried to cloud in #18622. --------- Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: ryan-di <ryan.weihao.di@gmail.com> Co-authored-by: jaeone lee <89377375+jaeone94@users.noreply.github.com> Co-authored-by: Christian Byrne <cbyrne@comfy.org> Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Comfy Org PR Bot <snomiao+comfy-pr@gmail.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Hunter <huntcsg@users.noreply.github.com> Co-authored-by: Maanil Verma <vermaMaanil97@gmail.com>
|
Closing as superseded by #18631, which cherry-picked #18431 onto |
Summary
Manual backport of #18431 to
core/1.54after the label-driven cherry-pick conflicted in three test files. Source files applied cleanly; every conflict was test scaffolding that diverged between the release branch and main.Resolution
agentPanelMocks.ts: keeps the release branch'smockCloudBoot(main renamed itmockCloudBootRoutes) and adds theinitialFeatureFlagsmerge the new first-session spec relies on.agentUxScenarios.spec.ts: unchanged. The source commit only removed a settings re-route this branch never had; the neighbor-layout describe in the conflict is main-only and stays out.agentPanel.test.ts: takes the first-run entry mock and thefromPartialextension-service mock; drops theuseCurrentUsertype import the branch's own mock does not need.firstRunEntry.test.ts: the branch mocks@vueuse/corewith a factory, so it now spreads the real module and wrapsuntil(whichfirstRunEntry.tsnewly uses) invi.fn; the screen-stage-throws case drivesmocks.executelike the branch's other tests.Verification
pnpm typecheckpnpm typecheck:browserpnpm test:unit src/extensions/core/agentPanel.test.ts src/renderer/extensions/firstRunTour/gettingStarted/firstRunEntry.test.ts src/workbench/extensions/agent/composables/agent/useAgentConsent.test.ts— 118 passedknip