Repository navigation
fix: stop dropping a later completed download after a premature failed status (PM-1302) - #18082
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2066 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.95 MB gzip 🟢 -16 BDetailsSummary
Category Glance App Entry Points — 3.81 kB (baseline 3.81 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.46 MB (baseline 1.46 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 638 kB (baseline 638 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 3.87 MB (baseline 3.87 MB) • 🔴 +297 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 566 kB (baseline 566 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 19 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.8 MB (baseline 17.8 MB) • ⚪ 0 BBundles that do not match a named category
Status: 73 added / 73 removed / 228 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-20T12:55:59.444Z",
"gitSha": "de1c6d149cdb65b5c2f904696649902424b69d21",
"branch": "test/pm-1302-download-toast-stuck-repro",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2029.4790000000376,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.734,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.47100000000006,
"heapDeltaBytes": 13054392,
"heapUsedBytes": 74658256,
"domNodes": -265,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.625000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2004.7010000000682,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.498000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.517,
"heapDeltaBytes": 13904076,
"heapUsedBytes": 76022040,
"domNodes": -263,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.761,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1821.360000000027,
"styleRecalcs": 75,
"styleRecalcDurationMs": 26.788,
"layouts": 14,
"layoutDurationMs": 4.077,
"taskDurationMs": 815.542,
"heapDeltaBytes": 15898276,
"heapUsedBytes": 77197384,
"domNodes": -265,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 161.175,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1814.279000000056,
"styleRecalcs": 76,
"styleRecalcDurationMs": 27.734,
"layouts": 14,
"layoutDurationMs": 4.496,
"taskDurationMs": 820.966,
"heapDeltaBytes": 17866856,
"heapUsedBytes": 80010000,
"domNodes": -264,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 163.868,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.1130000000317,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.441999999999998,
"layouts": 6,
"layoutDurationMs": 1.2030000000000003,
"taskDurationMs": 324.427,
"heapDeltaBytes": 2180284,
"heapUsedBytes": 64432788,
"domNodes": 76,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 10.315999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1724.6939999999995,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.161999999999999,
"layouts": 6,
"layoutDurationMs": 1.0819999999999999,
"taskDurationMs": 323.77,
"heapDeltaBytes": 2184236,
"heapUsedBytes": 64267364,
"domNodes": 75,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.425999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 618.6500000000024,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.56000000000006,
"heapDeltaBytes": 18527040,
"heapUsedBytes": 80312696,
"domNodes": 18,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 169.004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 599.0719999999783,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.975999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 429.40600000000006,
"heapDeltaBytes": 18085292,
"heapUsedBytes": 80210088,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 161.90900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2039.5879999999806,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.297999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 571.2539999999999,
"heapDeltaBytes": 818912,
"heapUsedBytes": 81867212,
"domNodes": -249,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 33.305,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2046.82600000001,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.245000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 592.5020000000001,
"heapDeltaBytes": -2940404,
"heapUsedBytes": 83269996,
"domNodes": -245,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 38.462999999999994,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2212.439999999958,
"styleRecalcs": 65,
"styleRecalcDurationMs": 9.944,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1572.459,
"heapDeltaBytes": 20096556,
"heapUsedBytes": 84589804,
"domNodes": -253,
"jsHeapTotalBytes": 1011712,
"scriptDurationMs": 826.36,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2229.9330000000737,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.465,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1618.455,
"heapDeltaBytes": 15720572,
"heapUsedBytes": 79860472,
"domNodes": -259,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 849.222,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3456.3360000000216,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.225999999999999,
"layouts": 60,
"layoutDurationMs": 12.499,
"taskDurationMs": 1494.8260000000002,
"heapDeltaBytes": 10550184,
"heapUsedBytes": 74079984,
"domNodes": -261,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 777.544,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3594.03199999997,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.139000000000003,
"layouts": 60,
"layoutDurationMs": 13.013,
"taskDurationMs": 1710.1660000000002,
"heapDeltaBytes": 9395120,
"heapUsedBytes": 74735248,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 803.984,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "legacy-node-drag",
"durationMs": 3193.7239999999747,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.755,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1962.904,
"heapDeltaBytes": 27209788,
"heapUsedBytes": 92416300,
"domNodes": -9,
"jsHeapTotalBytes": 2514944,
"scriptDurationMs": 1025.031,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3168.631000000005,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.54,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1964.366,
"heapDeltaBytes": 26781808,
"heapUsedBytes": 92603116,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 1015.4209999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2030.7500000000118,
"styleRecalcs": 5,
"styleRecalcDurationMs": 7.869999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 536.558,
"heapDeltaBytes": -4562984,
"heapUsedBytes": 84041848,
"domNodes": -252,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 30.81600000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2004.6070000000782,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.9759999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 586.7209999999999,
"heapDeltaBytes": 20105052,
"heapUsedBytes": 84629980,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 35.619,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 560.3730000000269,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.480000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.016,
"heapDeltaBytes": 14580840,
"heapUsedBytes": 78114248,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 142.10899999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 595.7610000000386,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.898000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.825,
"heapDeltaBytes": 14573504,
"heapUsedBytes": 78071240,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 149.846,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1997.7390000000241,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.879999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.89,
"heapDeltaBytes": -2972068,
"heapUsedBytes": 60711964,
"domNodes": -277,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.8999999999999995,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2021.003999999948,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.681000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.7,
"heapDeltaBytes": 2305276,
"heapUsedBytes": 65742512,
"domNodes": -276,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.854,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.2589999999786,
"styleRecalcs": 77,
"styleRecalcDurationMs": 26.426,
"layouts": 18,
"layoutDurationMs": 4.769000000000001,
"taskDurationMs": 779.5419999999999,
"heapDeltaBytes": -1442272,
"heapUsedBytes": 61972048,
"domNodes": -276,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 110.692,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1688.8030000000072,
"styleRecalcs": 77,
"styleRecalcDurationMs": 29.623,
"layouts": 18,
"layoutDurationMs": 5.662999999999999,
"taskDurationMs": 805.6090000000002,
"heapDeltaBytes": 5532688,
"heapUsedBytes": 69118348,
"domNodes": -278,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 113.24100000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.0129999999817,
"styleRecalcs": 16,
"styleRecalcDurationMs": 29.059,
"layouts": 5,
"layoutDurationMs": 13.347000000000001,
"taskDurationMs": 899.0770000000001,
"heapDeltaBytes": -6505304,
"heapUsedBytes": 81362620,
"domNodes": 13587,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 29.951000000000004,
"eventListeners": 2383,
"totalBlockingTimeMs": 142,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8425.224999999955,
"styleRecalcs": 248,
"styleRecalcDurationMs": 35.249,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5743.126,
"heapDeltaBytes": -4045592,
"heapUsedBytes": 76364916,
"domNodes": -246,
"jsHeapTotalBytes": 479232,
"scriptDurationMs": 2768.454,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8502.32900000003,
"styleRecalcs": 247,
"styleRecalcDurationMs": 34.702999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6036.061,
"heapDeltaBytes": 3237220,
"heapUsedBytes": 83441284,
"domNodes": -248,
"jsHeapTotalBytes": 1527808,
"scriptDurationMs": 3031.2070000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16634.750999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16110.704000000002,
"heapDeltaBytes": -34702504,
"heapUsedBytes": 180318784,
"domNodes": -8065,
"jsHeapTotalBytes": -16592896,
"scriptDurationMs": 281.877,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 13372.417999999925,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12797.242,
"heapDeltaBytes": -28507404,
"heapUsedBytes": 194095512,
"domNodes": -8061,
"jsHeapTotalBytes": -13225984,
"scriptDurationMs": 238.766,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20427.724000000013,
"styleRecalcs": 161,
"styleRecalcDurationMs": 16.049000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20139.451999999997,
"heapDeltaBytes": -42285224,
"heapUsedBytes": 180388924,
"domNodes": -8074,
"jsHeapTotalBytes": -20123648,
"scriptDurationMs": 860.096,
"eventListeners": -14928,
"totalBlockingTimeMs": 24,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20533.687999999984,
"styleRecalcs": 158,
"styleRecalcDurationMs": 16.44899999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20284.949,
"heapDeltaBytes": -51747828,
"heapUsedBytes": 180062272,
"domNodes": -8061,
"jsHeapTotalBytes": -14528512,
"scriptDurationMs": 867.715,
"eventListeners": -14928,
"totalBlockingTimeMs": 156,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6089.2299999999295,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.38499999999998,
"layouts": 20,
"layoutDurationMs": 23.873000000000005,
"taskDurationMs": 5987.378000000001,
"heapDeltaBytes": -28447928,
"heapUsedBytes": 195354132,
"domNodes": -8061,
"jsHeapTotalBytes": 11137024,
"scriptDurationMs": 105.78500000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 406,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6243.026999999984,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.39599999999997,
"layouts": 20,
"layoutDurationMs": 23.69299999999999,
"taskDurationMs": 6179.441000000001,
"heapDeltaBytes": -41456628,
"heapUsedBytes": 196107048,
"domNodes": -8061,
"jsHeapTotalBytes": 13692928,
"scriptDurationMs": 113.38100000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 434,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8548.526000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8278.952,
"heapDeltaBytes": -2330676,
"heapUsedBytes": 190022332,
"domNodes": 0,
"jsHeapTotalBytes": -27000832,
"scriptDurationMs": 129.43200000000004,
"eventListeners": -1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8553.352000000017,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8317.625,
"heapDeltaBytes": 42444052,
"heapUsedBytes": 199866308,
"domNodes": 0,
"jsHeapTotalBytes": -7340032,
"scriptDurationMs": 157.64800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 126.75000000001546,
"styleRecalcs": 9,
"styleRecalcDurationMs": 20.561999999999998,
"layouts": 4,
"layoutDurationMs": 1.885,
"taskDurationMs": 98.87200000000001,
"heapDeltaBytes": 3214756,
"heapUsedBytes": 64862828,
"domNodes": 113,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 10.092,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 448.59100000007857,
"styleRecalcs": 11,
"styleRecalcDurationMs": 18.314,
"layouts": 3,
"layoutDurationMs": 0.8880000000000001,
"taskDurationMs": 100.29899999999999,
"heapDeltaBytes": 4772812,
"heapUsedBytes": 66287792,
"domNodes": 117,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.495,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (8 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 87885fcad70a5f328e05c1d71bae2df1942c9461
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
…ds (PM-1302) Adds failing regression coverage for the known bug where a premature terminal `failed` WS message for a retryable download permanently locks assetDownloadStore's status, silently dropping the later `completed` message the backend sends once its retry succeeds: - Vitest: two `it.fails()` cases on assetDownloadStore proving the status gets stuck at `failed` and the task is excluded from activeDownloads forever, even after a real `completed` message arrives. - Playwright: drives the real `asset_download` WS event sequence (running -> failed -> completed) and screenshots the ModelImportProgressDialog toast stuck showing "1 download failed". No fix code included; see the paired Comfy-Org/cloud PR for the backend half of the root cause (download_file.go / middleware.go).
c0cb9fe to
600b88d
Compare
|
Updating Playwright Expectations |
| snapshot | status | changed pixels | | --- | --- | --- | | `tests/modelImportProgressDialogStuckDownload.spec.ts-snapshots/model-import-progress-toast-stuck-failed-chromium-linux.png` | new | n/a | Screenshot capture is not bit-deterministic; small pixel deltas are usually text rasterization noise. Confirm each rewrite corresponds to a test expected to change.
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: chromium Recorded test titles:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18082 +/- ##
==========================================
+ Coverage 82.77% 83.93% +1.16%
==========================================
Files 2936 2260 -676
Lines 144439 128563 -15876
Branches 39004 33281 -5723
==========================================
- Hits 119562 107912 -11650
+ Misses 23620 20361 -3259
+ Partials 1257 290 -967
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 846 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Adds a second Playwright case to the existing repro spec proving the close (X) button still works once a download is (incorrectly) stuck in a terminal failed state, since isInProgress is false for that status. This isolates the reported "never dismisses" symptom to the status itself staying wrong, not to the dismiss control being blocked.
There was a problem hiding this comment.
Reviewed per the "already in-flight, review + add tests" instruction rather than re-investigating.
Verdict: repro-only, no fix yet, and it's a correct repro. Verified assetDownloadStore.handleAssetDownload (src/stores/assetDownloadStore.ts) has the exact terminal-state short circuit described (if (existing?.status === 'completed' || existing?.status === 'failed') return), and pollStaleDownloads() only reconciles items still in activeDownloads, which excludes anything already flipped to failed. Both it.fails() Vitest cases and the Playwright screenshot spec pass against current CI (test, website-unit-gate, all playwright-tests-* shards green on the latest commit), confirming the repro is real and stable, not flaky.
Added: a second Playwright case in the same spec verifying the toast's close (X) button still works while wrongly stuck in failed (isInProgress is false for that status, so the button renders). This isolates the reported "never dismisses" complaint to the status itself staying wrong forever, not to the dismiss control being blocked — worth knowing when scoping the eventual fix. Pushed directly to this branch.
Not fixed here (by design, matches this PR's stated scope) — the actual fix needs handleAssetDownload to stop treating failed as unconditionally terminal, paired with the backend fix in comfy/cloud#9823 so a retryable error doesn't broadcast a premature terminal status in the first place.
🤖 Generated with Claude Code
getByRole('status') alone also matches the top-menu action bar's own
status region, so the assertion hit a Playwright strict-mode
violation (2 elements) in CI. Filter by the toast's own footer text
to disambiguate.
15baaff to
109983e
Compare
page.getByRole('button', { name: 'Close' }) matches two elements once
the canvas minimap is visible: the minimap's own close button
(data-testid="close-minimap-button") and the toast's close button,
causing a strict-mode violation. Scope the click to the already-scoped
`toast` locator, same as the status-region locator above it.
8614c79 to
5e3556c
Compare
…d status (PM-1302) assetDownloadStore.handleAssetDownload only trusted `completed` as a terminal status; `failed` is now treated as recoverable, since cloud's HandleDownloadFile can broadcast a premature terminal `failed` message for a retryable error before asynq decides whether to retry (see the paired backend fix in Comfy-Org/cloud#9823). pollStaleDownloads() now also re-checks `failed` downloads so a stuck premature failure gets reconciled with the backend instead of being excluded from polling forever. Flips the first PM-1302 regression test from it.fails to it now that it passes. The second (activeDownloads exclusion) stays pinned as a deliberate, documented product-decision gap: activeDownloads doubles as the UI's isInProgress signal, and folding failed downloads back into it would make the dialog show them as in-progress again. Updates the paired Playwright spec to assert the toast recovers to "All downloads completed" instead of staying stuck on a stale failed status.
| snapshot | status | changed pixels | | --- | --- | --- | | `tests/modelImportProgressDialogStuckDownload.spec.ts-snapshots/model-import-progress-toast-recovered-completed-chromium-linux.png` | new | n/a | Screenshot capture is not bit-deterministic; small pixel deltas are usually text rasterization noise. Confirm each rewrite corresponds to a test expected to change.
A full-body screenshot also captures the canvas graph background, which isn't pixel-stable across separate CI runs (the freshly-committed baseline diffed by 6590px / 1% against the very next CI run). Scope to the toast locator instead, matching the pattern already used by the sibling dismiss test in this file. The stale body-scoped baseline is removed; a fresh toast-scoped one needs generating via the New Browser Test Expectations label.
| snapshot | status | changed pixels | | --- | --- | --- | | `tests/modelImportProgressDialogStuckDownload.spec.ts-snapshots/model-import-progress-toast-recovered-completed-chromium-linux.png` | new | n/a | Screenshot capture is not bit-deterministic; small pixel deltas are usually text rasterization noise. Confirm each rewrite corresponds to a test expected to change.
christian-byrne
left a comment
There was a problem hiding this comment.
Download recovery reviewed; dismissal race repaired. Broader import/cancellation work stays open. Native checks remain merge gates.
Full context for agent readers
Reviewed the full source diff at fd58d47: failed downloads remain recoverable through socket updates and stale-task polling; completed downloads remain terminal; failed downloads retain the close control. The added identity guard discards a response after dismissal or a newer status replacement rather than restoring stale state.
Executed acceptance: 19 unit tests pass with one existing expected failure; manual dismissal and dismissal during an in-flight poll both pass in Chromium. The new race tests were observed failing without the guard and passing with it. Source/browser types, lint, formatting and hooks pass.
The complete browser file is not green locally: its recovery text assertions pass, but the screenshot comparison fails on four pixels. Inspected actual and diff: differences are at the rounded left corners, with no visible text/layout change. The baseline and thresholds are unchanged. Approval is source/behavior review, not a claim that this screenshot check passed; fresh native checks and the normal queue remain mandatory.
Read the linked Slack thread and both original Linear reports. This PR does not demonstrate cancellation of a running download or end-to-end Auto Mode missing-model import. Those, the still-open backend retry PR, and independent core/1.54 and cloud/1.54 qualification remain owned in the program download-completion task and both Linear issues. The expected-failing active-download test documents a presentation choice; it is not proof of an implemented feature.
Glossary: native checks are GitHub's automated PR checks; socket updates are server-pushed download status events.
…d status (PM-1302) (#18082) ## Before A premature failed download status stayed failed after a successful retry. Polling ignored failed downloads. Dismissing a failed toast while a status request was in flight could also reopen it when the response arrived. ## After Only completed downloads are terminal. Failed downloads accept later status messages and are rechecked by polling. Poll responses are discarded if the tracked item was removed or replaced while the request was in flight. Failed downloads still leave the active-download list so the failure state and close button remain available. Running-download cancellation and the original Auto Mode missing-model import remain separate acceptance work, not completed by this PR. ## Test plan - 19 unit tests pass; one existing expected-failing test records the unresolved active-download presentation choice. - The new dismissal-race unit and browser cases fail without the guard and pass with it. Manual failed-toast dismissal also passes. - Source and browser typechecks, lint, formatting and commit hooks pass. - Recovery text assertions pass locally. The recovery screenshot differed by four pixels on the first local run; its baseline was not changed. Fresh native CI remains a merge gate. ## Tracking [Original Slack report](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789700733927729) · [original Claude session](https://claude.ai/code/session_01Stfza8cuRcz7X1SkxmpDt1). Related issues: PM-1302 (download/import failure) and PM-1309 (download progress and cancellation). Christian's completion lane owns remaining acceptance and core/1.54 plus cloud/1.54 qualification in the [program completion record](https://github.com/christian-byrne/in-app-agent-program/blob/main/program/slack-claude-pilot.md), task `claude-handoff-13`. Correction: [the paired backend retry fix](Comfy-Org/cloud#9823) is **open**, not merged as the earlier description claimed. This frontend recovery is independently useful; it does not establish backend retry correctness. Glossary: CI means automated pull-request checks; expected-failing means an assertion deliberately records unimplemented behavior, not a passing feature. --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: bymyself <cbyrne@comfy.org>
…d status (PM-1302) (#18082) ## Before A premature failed download status stayed failed after a successful retry. Polling ignored failed downloads. Dismissing a failed toast while a status request was in flight could also reopen it when the response arrived. ## After Only completed downloads are terminal. Failed downloads accept later status messages and are rechecked by polling. Poll responses are discarded if the tracked item was removed or replaced while the request was in flight. Failed downloads still leave the active-download list so the failure state and close button remain available. Running-download cancellation and the original Auto Mode missing-model import remain separate acceptance work, not completed by this PR. ## Test plan - 19 unit tests pass; one existing expected-failing test records the unresolved active-download presentation choice. - The new dismissal-race unit and browser cases fail without the guard and pass with it. Manual failed-toast dismissal also passes. - Source and browser typechecks, lint, formatting and commit hooks pass. - Recovery text assertions pass locally. The recovery screenshot differed by four pixels on the first local run; its baseline was not changed. Fresh native CI remains a merge gate. ## Tracking [Original Slack report](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789700733927729) · [original Claude session](https://claude.ai/code/session_01Stfza8cuRcz7X1SkxmpDt1). Related issues: PM-1302 (download/import failure) and PM-1309 (download progress and cancellation). Christian's completion lane owns remaining acceptance and core/1.54 plus cloud/1.54 qualification in the [program completion record](https://github.com/christian-byrne/in-app-agent-program/blob/main/program/slack-claude-pilot.md), task `claude-handoff-13`. Correction: [the paired backend retry fix](Comfy-Org/cloud#9823) is **open**, not merged as the earlier description claimed. This frontend recovery is independently useful; it does not establish backend retry correctness. Glossary: CI means automated pull-request checks; expected-failing means an assertion deliberately records unimplemented behavior, not a passing feature. --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: bymyself <cbyrne@comfy.org>
…fter a premature failed status (PM-1302) (#18208) Backport of #18082 to `cloud/1.54` Automatically created by backport workflow. Justification: Agent 1.54 release backport authorized by Christian's September 16/20 grant; exact head 0dace4a was independently adaptation-reviewed against cloud/1.54@78ab9ed884cd588026bb52c23755a04045585d72, required target-native acceptance and terminal hosted checks passed, the current target-aware merge guard passed, and no unresolved human objection remains. REVIEW_REQUIRED is the only branch-protection condition bypassed. Christian additionally authorized automatic testcloud/staging deployment from qualified Cloud merges on September 21; its downstream run will be monitored to terminal status. Residuals retained: PM-1302/PM-1309 activeDownloads expected-failure/product decision, backend retry and broader import/cancellation acceptance; prior local four-pixel screenshot mismatch; historical target AI trailer pending separate disposition. --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: bymyself <cbyrne@comfy.org>
…ter a premature failed status (PM-1302) (#18207) Backport of #18082 to core/1.54. Keep premature failed downloads eligible for later completion and polling reconciliation, while preventing a dismissed toast from reopening after an in-flight poll. Retain the source tests and target-native browser coverage. Independently reviewed head: 5823386 Target: ebd07f3 Source patch ID: e31ee6613bb4a4001293643491eb4783478aeb13 The activeDownloads expected failure and broader backend/import/cancellation acceptance remain open. Historical generated co-author trailers remain explicitly accepted residuals; this merge does not repair release history. Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: bymyself <cbyrne@comfy.org>
|
|
Before
A premature failed download status stayed failed after a successful retry. Polling ignored failed downloads. Dismissing a failed toast while a status request was in flight could also reopen it when the response arrived.
After
Only completed downloads are terminal. Failed downloads accept later status messages and are rechecked by polling. Poll responses are discarded if the tracked item was removed or replaced while the request was in flight.
Failed downloads still leave the active-download list so the failure state and close button remain available. Running-download cancellation and the original Auto Mode missing-model import remain separate acceptance work, not completed by this PR.
Test plan
Tracking
Original Slack report · original Claude session.
Related issues: PM-1302 (download/import failure) and PM-1309 (download progress and cancellation). Christian's completion lane owns remaining acceptance and core/1.54 plus cloud/1.54 qualification in the program completion record, task
claude-handoff-13.Correction: the paired backend retry fix is open, not merged as the earlier description claimed. This frontend recovery is independently useful; it does not establish backend retry correctness.
Glossary: CI means automated pull-request checks; expected-failing means an assertion deliberately records unimplemented behavior, not a passing feature.