Repository navigation
[backport core/1.54] Agent UI catch-up (PM-1657) - #18631
Conversation
## Summary > [!IMPORTANT] > **This is a design PR, not production code.** It is a working prototype that shows how the design looks and how it can behave. Review it to decide which parts to keep and which parts to rewrite. When the reply finishes, the thinking and tool-call trace folds into one summary row. Fixes [DES-778](https://linear.app/comfyorg/issue/DES-778/des-fold-the-thinking-tool-call-trace-into-a-summary-once-the-reply) ## Changes - **What**: - While the agent works, the panel shows one flat list. Each thinking step and each tool call is one row. - A vertical line connects the icons of adjacent rows. - While a thinking step runs, the row reads `Thinking - <action>`. - After the turn ends, the row reads `Thought for 1.4s` with the reasoning text below it. - When the reply finishes, all steps fold into one collapsed row. - When a turn is longer than one minute, the label reads `Worked for 3m 25s`. - A `Working...` row marks the gap between the last tool call and the first reply token. - **Internal**: This PR removes `ToolCallGroup.vue` and `ToolCallCard.vue`. `ActivityTrace.vue` and `WorkSummary.vue` replace them. `agentActivityRows.ts` holds the fold of wire parts into display rows. `formatDuration.ts` holds the duration format. ## Review Focus - One summary holds every thinking step and tool call of the turn. Text that came between two tool calls now shows below the summary, not between the calls. - `v-memo` on the trace rows stops the re-render of a settled row on each token. The old component collapsed its rows during the reply stream, so this cost is new. - The reasoning text is always open. A long turn gives a long summary when the reader opens it. - `ActivityTrace.vue` uses `<i18n-t>` with a slot. The global `escapeParameter` option turns an apostrophe into `'` inside a `t()` parameter. - Storybook and the unit tests cover this change. No one ran it in the live app. ## Screenshots Thinking and tool call w/ agent working state https://github.com/user-attachments/assets/d2114d9f-601b-4287-9fbd-42a9527ae5ea When agent is done, the thinking and tool call is collapsed https://github.com/user-attachments/assets/156c611d-751f-4b3e-b595-69dd1b72f267 --------- Co-authored-by: ryan-di <ryan.weihao.di@gmail.com> (cherry picked from commit d17e2ec)
## Summary Linear issues: [PM-629](https://linear.app/comfyorg/issue/PM-629/request-for-video-asset-for-consent-card) · [PM-514](https://linear.app/comfyorg/issue/PM-514) The Comfy Agent consent card now plays a new video, and the card has a new layout. https://github.com/user-attachments/assets/ee20ab80-32c6-4eb2-826a-a3ed82b11941 ## Changes - **What**: - The card shows the new Comfy Agent video. It replaces the older MCP launch film. - The video now comes from the Comfy media server. It is no longer stored in this repository. - The card also loads an MP4 copy and a still image. Older iPhones can now play the video. - The card is one column. The video is on top, and the text is below it. - The video keeps its widescreen shape. The picture is no longer cut off at the sides. - Both buttons are larger. "Skip for now" now uses the standard button style. - On a wide card, the "Read the docs" link sits beside the buttons. On a narrow card, it moves up beside the text. ## Review Focus - This change answers PM-629 from the other side. The card no longer crops the video to a square, so a square asset and a crop safe zone are not necessary. - The three media files are new paths on the media server, so they serve immediately. No cached file is replaced. - The 2.2 MB video file is deleted from the repository. The build no longer carries it. - The browser tests load a small test video instead of the real one. This keeps the tests off the media server. ## Screenshots (if applicable) <img width="1728" height="963" alt="image" src="https://github.com/user-attachments/assets/28d17739-bb85-4fb8-8d94-c4990df5a543" /> --------- Co-authored-by: jaeone lee <89377375+jaeone94@users.noreply.github.com> (cherry picked from commit f9a37f9)
…ger (#17420) ## Summary Steps in the agent trace fade in as they arrive, and the scroll-follow trigger no longer serializes the transcript. Fixes [DES-1032](https://linear.app/comfyorg/issue/DES-1032/agent-panel-animate-steps-as-they-arrive) ## Changes - **What**: - A step fades in over 160ms as it arrives. The animation uses opacity only. - The panel is bottom-anchored and scrolls to the newest row. A rise would move the row upward a second time. - The `live` prop gates the animation. `AgentMessage` passes it for a running turn. `WorkSummary` does not pass it. - Reduced motion and `.disable-animations` turn the animation off, the same as the shimmer. - The scroll-follow trigger reads the entry count, the part count, and the size of the tail part. Before this change it ran `JSON.stringify` over every part of the newest message and measured the string it built. - A new story, `DES-1032 Each step fades in as it arrives`, appends a step every 900ms. The other stories mount every row at once, so they show the fade but not the arrival. ## Review Focus - Open the new story to see the animation. Each row fades in as it lands, and the rows already on screen hold still. - Only the newest row animates, and an older row does not restart when the list re-renders around it. Measured with `getAnimations()` across five arrivals in that story: exactly one row animated each time, and it was always the newest. A local turn added nothing to this. That turn used no tools, so no trace rendered. - The `live` gate is where an error hides. When you open a finished turn and expand the summary, no row fades. The same is true for a conversation you reopen. Both paths mount every row at once. - The scroll change is invisible. The review surface is the scroll behavior: the panel follows the bottom during a turn, a scroll up releases it, and the jump button returns. - Measured cost of the trigger on a 5.9KB transcript: 1.6µs per call before, 0.08µs after. The old cost grew with the transcript, so a long turn paid it again on each update. - A test covers the trigger. I flattened the signal on purpose to make sure that the test fails, then restored it. - DES-1032 also asked for paced reply text and a guard for an unfinished code fence. Both are dropped. The backend sends the whole reply in one `agent_message_delta` event, so there is no stream to smooth and no fence is ever half-typed. DES-1034 records the backend ask. ## Screenshots (if applicable) Storybook: Agent/AgentMessage -> "DES-1032 Each step fades in as it arrives" 🤖 Generated with [Claude Code](https://claude.com/claude-code) (cherry picked from commit aabda32)
## Summary - remove elapsed-time text from the agent work summary and activity rows - stop deriving duration data in the presentation model while retaining raw timing for diagnostics - remove the unused workflow duration formatter and update focused coverage ## Test plan - `pnpm test:unit src/workbench/extensions/agent/components/agent/message/WorkSummary.test.ts src/workbench/extensions/agent/services/agent/agentActivityRows.test.ts` - `pnpm format:check` - `pnpm typecheck` - targeted ESLint - `pnpm knip` - `pnpm locale:check` Linear: [PM-1238](https://linear.app/comfy/issue/PM-1238/remove-timing-information-from-agent-workflow) ## E2E coverage A Playwright regression is not practical for this presentation-only change because reaching the timed activity state requires an authenticated hosted agent turn and backend streaming events that the browser harness does not provide deterministically. The focused component tests render timed thinking/tool parts directly and assert that neither row-level durations nor an elapsed-time summary label are visible. (cherry picked from commit 2e6865b)
## Summary The "Ask Comfy Agent" button had dark text on a dark background in the light theme, so the label was not readable. This change gives the button the standard button colors, which adapt to each theme. This is a stopgap. #17621 rebuilds this button and replaces the fix. Land this first so the light theme is readable now, because #17621 is a much larger change. ## Changes - **What**: The agent button in the top bar now uses the shared `secondary` button style. This is the same style as the "0 active" button in the action bar. The background, the label, the border, and the Comfy mark all come from theme colors, so each color adapts to the theme. - The label contrast increased from 1.11:1 to 14.76:1 in the light theme. The minimum for text is 4.5:1. - The Comfy mark is now the same color as the label. It was brand yellow in both themes, which is not readable on a light background. One color keeps the button consistent across the two themes. - The dark theme looks almost the same as before. The change is three lines in one file. It adds no color token and no dependency. ## Review Focus - **This conflicts with #17621.** That PR moves the button out of `WorkflowTabs.vue` into a new `AgentEntryButton.vue`. Expect a conflict in `WorkflowTabs.vue` and resolve it in favor of #17621. - The hover style for the border is removed. The border was a strong purple on hover, which does not suit the new quiet border. The background still changes on hover, the same as every other `secondary` button. ## Screenshots  Light <img width="1727" height="963" alt="image" src="https://github.com/user-attachments/assets/0c187c8e-a453-465f-8d42-2b08430f862f" /> Dark <img width="1727" height="963" alt="image" src="https://github.com/user-attachments/assets/4467a6ff-3b33-407e-8c00-87c23409289f" /> (cherry picked from commit 2e178a9)
#17621) ## Summary The agent button moves to the far right of the tab bar, and the agent panel moves below the tab bar. The button now sits above the close button of the panel. <img width="652" height="180" alt="Sep-18-2026 10-08-35" src="https://github.com/user-attachments/assets/789f20a4-c0df-4eb0-a1ef-c17df63cfc5a" /> Linear: [DES-1038 \[DES\] Agent button and panel position](https://linear.app/comfyorg/issue/DES-1038/des-agent-button-and-panel-position) ## Changes - **What**: - The agent button moves after the user avatar, at the far right. - The label changes from "Ask Comfy Agent" to "Agent". The icon changes from the Comfy logo to the lucide `astroid` star. - The button stays visible when the panel is open. A click on it closes the panel. Before, the button disappeared. - The agent panel moves below the tab bar. The tab bar now spans the full window width. - The panel has no background of its own against the canvas. The graph shows around it, so the panel reads as a card on the graph. - App mode gets the same panel position. - If an opaque panel sits next to the agent panel, the agent panel takes back its background and its left border. The parent that lays out both panels decides this and passes it as a prop. - Two separators divide the environment badge, the icon buttons, and the agent button. Each separator disappears with the item that it divides. - The feedback megaphone is 24px, with a 16px icon in muted gray. It was a 32px box with a white icon. - `WorkflowTabs` now renders `TopbarBadges` and `TopbarSubscribeButton` itself. Both views passed the same two components, so the slot is gone. - The i18n key `agent.askComfyAgent` becomes `agent.entryButton`. The other locale files fall back to English until the translation pipeline runs. - **Shared components**: two changes below reach every topbar badge, not only the agent work. - The badge icon is 16px at every screen width. It was 12px on wide screens and 19px on narrow screens. - `server_health_alert.message` arrives in capitals from some backends. `toTitleCase` recases it to "Staging Environment" in `cloudBadges.ts`, at the point that reads the field. - **Canvas spacing**: merged from #17879. The floating canvas UI reads one token. - The toolbars at the top and the bottom of the graph sat 4px from the edge. The agent panel card sat 8px. The two never lined up. Both now read `--comfy-canvas-gutter`, set to 8px. - The graph and the top toolbar drop their right gutter when the agent panel is what sits beside them. A right-hand sidebar or an offside panel keeps it. - The canvas info text (`T:`, `FPS:`) reads the same token and starts level with the graph. It sat 5px from the sidebar. - `renderInfo` offset every line by a hardcoded 5px, so a caller's `x` was never where the text landed. The offset is gone and `x` is now the true left edge. The no-argument default keeps its old position. - **Agent button style**: merged from #17879. - The button takes the outline variant. It was a solid fill. - Its border carries a shine that sweeps right to left, returns faster, then rests. The shine runs only until the panel opens once, then stops for good. - The icon turns one full circle on hover and unwinds on release. - The button moves out of `WorkflowTabs` into `AgentEntryButton.vue`, with a Storybook entry for each state: [Components/Button/AgentEntryButton](https://uy-des-1038-agent-button-int.comfy-storybook.pages.dev/?path=/story/components-button-agententrybutton--default&globals=theme:dark). - `Comfy.AgentPanel.discovered` remembers the first open. The store writes it when the panel becomes visible, not when the open action runs, so a restored panel counts too. ## Review Focus - `DockedAgentPanel` takes a `hasOpaqueNeighbor` prop. An earlier version read `rightSidePanelStore.isOpen` instead. That setting is global and persisted, so it leaked into app mode, which has no such panel. It also disagreed with the true neighbor when the sidebar sits on the right, during node selection, and in builder mode. - `toTitleCase` lives next to the one backend field that shouts, not in `TopbarBadge`. `topbarBadges` is a public extension API. A recase in the shared renderer would turn an acronym badge such as "GPU OOM" into "Gpu Oom". - The layout change touches `LiteGraphCanvasSplitterOverlay.vue` and `LinearView.vue`. In both files the tab bar moves out of the workspace column, and the panel becomes a sibling of that column. The two shells stay separate on purpose. What they share is three flex wrappers, and the rest differs. - The graph canvas already spans the full window and runs under the panel. The panel only stopped showing it, so one class removal is enough. - Two tests changed their contract. One pinned the seam border that this PR removes. One pinned the tab bar inside the workspace column. - `renderInfo` is shared drawing code for every canvas. Removing its hidden 5px inset changes what an explicit `x` means. This repo has one such caller. - One test asserts a margin class, against the usual rule. The gutter is a margin, the test environment does no layout, and the class is the whole behavior. A comment in the test records this. - `graph-canvas-gutter` is a test id that exists only so that test has something to query. Testing Library rejects a direct CSS lookup. - The screenshot baselines are stale. The gutter moves the canvas by 4px, so the stored images no longer match. They need a regeneration run before this merges. ## Screenshots Inviting state w/ shimmer animation Animates until user clicks <img width="368" height="226" alt="image" src="https://github.com/user-attachments/assets/a178f906-1046-4ab5-a86f-26ad4fcfbb23" /> Active state w/ icon filled <img width="368" height="226" alt="image" src="https://github.com/user-attachments/assets/e062f943-2bf7-4037-be01-aa193da192cb" /> Default state after clicked <img width="368" height="226" alt="image" src="https://github.com/user-attachments/assets/a73e16ae-9985-4d36-aa22-00f6ce4d42a8" /> --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com> (cherry picked from commit bee86d4)
…Summary #17339 replaces the "Ran N tool call" activity row with WorkSummary and a "Working..." row, and #18348 drops the step durations, so the turn-lock fixture, the socket-drop spec and the tool-call history spec could no longer find their summary button. Take main's current locators for those three files. Main-only changes there that depend on PRs not on this line are left out: the PM-916 draft test, the entryButton label key, and the promptHistory thread-id list. On core/1.54 the tool-call history spec is left to the next commit, which takes main's block: #18579 had already rewritten it here.
Backport adaptation: test-only. Three tests exist only on core/1.54 and still expected the ToolCallGroup summary that #17339 removes. Each now uses main's form: - AgentPanelRoot.test.ts (from #18602): the settled-tool-call case finds agent.working, as main's does. Its comment tail is main's too; the old one said the settle showed only through "Ran N tool calls". - agentCanvasLagsToolCallCompletion.spec.ts (from #18595): the three /^Ran/ locators become main's /^Worked/. - agentToolCallHistoryPersistence.spec.ts (from #18579): the summary block is main's, the agent.worked button plus the listitem check.
Backport adaptation: test-only. The #17621 pick renamed this spec's entry-button lookups (:388, :499) to agent.entryButton ("Agent") without exact: true. The name then matched 2 buttons at :499, and Playwright's strict mode failed the test. Main's copy of this spec passes exact: true; this matches it.
Backport adaptation: runtime. #17621 puts the canvas info text at the sidebar's right edge plus the canvas gutter, which assumes main's renderInfo draws the text at x. The release line's renderInfo still draws it 5px in from x, and the litegraph change stays out of this branch. So the HUD landed 5px to the right of main, and canvasSettings.spec.ts:32 failed its screenshot. Subtract the inset here until that change reaches the line.
## Summary Replace Agent's shadow theme with shared design-system tokens and controls. Fixes [FE-2219](https://linear.app/comfyorg/issue/FE-2219/refactor-delete-agents-shadow-design-system). ## Changes - Remove Agent color/radius aliases and the global stylesheet import; keep animations and normalization in the Agent stylesheet. - Reuse shared tooltips, popovers, inputs, and action buttons while preserving required Reka interactions. - Add Storybook states and keep tests focused on behavior, not specific styles. ## Review Focus Shared tooltip compatibility, input focus/selection, portaled controls, and reduced-motion behavior. Local checks passed: 279 component tests; cloud, standalone-mode, and Storybook builds; typecheck; lint; formatting; Knip. Light and dark Storybook states were visually inspected. Figma MCP was unavailable. Authenticated cloud and standalone app flows were not exercised. ## Screenshots  --------- Co-authored-by: Amp <amp@ampcode.com> (cherry picked from commit d3ab7cb)
Backport adaptation: runtime. The line's run-mode menu is #18265, the cloud/1.54 carrier of #18115. It keeps the DropdownMenu and the store calls, but still styles them with the old agent tooltip helper, raw buttons and surface classes. Main's final file (146ef34, still the blob on origin/main) is the same DropdownMenu with the same behaviour, styled with the shared Button and design tokens. This takes main's file unchanged.
## Summary Stacked on #17471. Use shared Button variants for user-facing Agent controls instead of bespoke control styles. Continues [FE-2219](https://linear.app/comfyorg/issue/FE-2219/refactor-delete-agents-shadow-design-system). ## Changes - Replace native action buttons and compose Reka triggers with the shared Button. - Remove duplicated hover, focus, and disabled styling. Keep feature-specific layout and existing interactions. - No new shared APIs, dependencies, or style assertions. ## Review Focus - Rename focus restoration, run-mode radio selection, clipboard actions, and audio controls. - CRDT debug-panel buttons, selects, and textarea remain follow-up work. Specialized media thumbnails, reference chips, and editor-generated DOM are unchanged. - Passed 310 tests across 28 files, typecheck, lint, formatting, Knip, and the Storybook build. Browser checks cover light/dark states, rename focus, selection, copy feedback, and audio playback/mute. - Live Figma access was unavailable; this uses existing shared component APIs and rendered Storybook checks. ## Screenshots [Storybook preview](https://t-03gunii1zj3p8h7t18j5kuq9s-p27802.onamp.dev/) --------- Co-authored-by: Amp <amp@ampcode.com> (cherry picked from commit 48715f5)
…agent-ui-core-1.54
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1948 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🌐 Website E2ETip All tests passed.
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-23T22:11:47.934Z",
"gitSha": "9900c35b7eb5dba6ec10b8d15b63ac8ff0bb02b2",
"branch": "backport-pm1657-agent-ui-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2108.7309999999775,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.936,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 651.491,
"heapDeltaBytes": 1137372,
"heapUsedBytes": 71440140,
"domNodes": -283,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 11.7,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2037.2729999999706,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.997999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 516.991,
"heapDeltaBytes": -12005328,
"heapUsedBytes": 57454136,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.107000000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1939.2100000000028,
"styleRecalcs": 78,
"styleRecalcDurationMs": 33.103,
"layouts": 14,
"layoutDurationMs": 4.285,
"taskDurationMs": 931.44,
"heapDeltaBytes": 715436,
"heapUsedBytes": 71814256,
"domNodes": -282,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 155.715,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1891.4190000000417,
"styleRecalcs": 75,
"styleRecalcDurationMs": 32.126000000000005,
"layouts": 14,
"layoutDurationMs": 4.5200000000000005,
"taskDurationMs": 927.3860000000001,
"heapDeltaBytes": -4023760,
"heapUsedBytes": 67173428,
"domNodes": -281,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 157.852,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1738.1999999999493,
"styleRecalcs": 32,
"styleRecalcDurationMs": 18.046,
"layouts": 6,
"layoutDurationMs": 1.179,
"taskDurationMs": 395.751,
"heapDeltaBytes": 4606812,
"heapUsedBytes": 74706744,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 14.524,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.1589999999724,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.837,
"layouts": 6,
"layoutDurationMs": 1.2630000000000001,
"taskDurationMs": 372.175,
"heapDeltaBytes": 4697588,
"heapUsedBytes": 75660532,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.27,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 741.1539999999945,
"styleRecalcs": 12,
"styleRecalcDurationMs": 10.458,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459,
"heapDeltaBytes": 18094720,
"heapUsedBytes": 88733060,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 153.864,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 688.4009999999989,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.234,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.63,
"heapDeltaBytes": -7803812,
"heapUsedBytes": 63336832,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 157.181,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2069.0550000000485,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.964,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 701.5709999999999,
"heapDeltaBytes": 5125860,
"heapUsedBytes": 81776760,
"domNodes": -281,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 38.224999999999994,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2071.972999999957,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.346999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 729.552,
"heapDeltaBytes": 9257968,
"heapUsedBytes": 85644968,
"domNodes": -271,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 36.376999999999995,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2326.0380000000396,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.506000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1680.9790000000003,
"heapDeltaBytes": 7136252,
"heapUsedBytes": 84734984,
"domNodes": -277,
"jsHeapTotalBytes": -1187840,
"scriptDurationMs": 784.768,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2234.3290000000025,
"styleRecalcs": 64,
"styleRecalcDurationMs": 10.615999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1624.799,
"heapDeltaBytes": 18897408,
"heapUsedBytes": 85385724,
"domNodes": -276,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 778.898,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3718.28899999997,
"styleRecalcs": 61,
"styleRecalcDurationMs": 13.241999999999997,
"layouts": 60,
"layoutDurationMs": 13.402,
"taskDurationMs": 1860.2379999999998,
"heapDeltaBytes": -3302800,
"heapUsedBytes": 75697832,
"domNodes": -284,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 800.826,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3823.6040000000457,
"styleRecalcs": 63,
"styleRecalcDurationMs": 14.461000000000002,
"layouts": 60,
"layoutDurationMs": 13.926999999999998,
"taskDurationMs": 1847.1179999999997,
"heapDeltaBytes": 10410568,
"heapUsedBytes": 76945960,
"domNodes": -274,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 822.4659999999999,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3168.439000000035,
"styleRecalcs": 40,
"styleRecalcDurationMs": 6.008000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2040.5369999999996,
"heapDeltaBytes": 22428568,
"heapUsedBytes": 90061292,
"domNodes": 0,
"jsHeapTotalBytes": 1204224,
"scriptDurationMs": 989.309,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3189.5060000000512,
"styleRecalcs": 43,
"styleRecalcDurationMs": 8.507000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2042.304,
"heapDeltaBytes": 11932188,
"heapUsedBytes": 93661172,
"domNodes": -279,
"jsHeapTotalBytes": -995328,
"scriptDurationMs": 983.8439999999999,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2061.61800000001,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.957000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 701.675,
"heapDeltaBytes": 6289308,
"heapUsedBytes": 83899480,
"domNodes": -278,
"jsHeapTotalBytes": -626688,
"scriptDurationMs": 43.626,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2023.1769999999187,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.873999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 591.4639999999998,
"heapDeltaBytes": 9936544,
"heapUsedBytes": 88217716,
"domNodes": -272,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 32.50500000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 658.2160000000385,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.11,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.5210000000001,
"heapDeltaBytes": 14704164,
"heapUsedBytes": 87922448,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 153.068,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 588.3289999999306,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.850999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.66700000000003,
"heapDeltaBytes": 14691424,
"heapUsedBytes": 87848480,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 143.35999999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2020.6919999999968,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.886,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 506.0899999999999,
"heapDeltaBytes": -6429192,
"heapUsedBytes": 66520748,
"domNodes": -295,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 9.308,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.5020000000077,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.955,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.3960000000001,
"heapDeltaBytes": 2706692,
"heapUsedBytes": 75199076,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.442000000000002,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1732.3260000000005,
"styleRecalcs": 77,
"styleRecalcDurationMs": 28.215999999999998,
"layouts": 18,
"layoutDurationMs": 5.062,
"taskDurationMs": 873.53,
"heapDeltaBytes": -5405796,
"heapUsedBytes": 67642892,
"domNodes": -296,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 111.789,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1756.2739999999621,
"styleRecalcs": 77,
"styleRecalcDurationMs": 31.226,
"layouts": 18,
"layoutDurationMs": 6.402999999999999,
"taskDurationMs": 881.1049999999999,
"heapDeltaBytes": -7176744,
"heapUsedBytes": 65309960,
"domNodes": -297,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 115.31400000000001,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1434.9000000000274,
"styleRecalcs": 20,
"styleRecalcDurationMs": 31.237000000000002,
"layouts": 16,
"layoutDurationMs": 15.138000000000002,
"taskDurationMs": 987.3020000000001,
"heapDeltaBytes": 19616844,
"heapUsedBytes": 105450844,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 30.916,
"eventListeners": 2385,
"totalBlockingTimeMs": 133,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8656.18999999998,
"styleRecalcs": 246,
"styleRecalcDurationMs": 41.656,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6152.408,
"heapDeltaBytes": 9672092,
"heapUsedBytes": 85835692,
"domNodes": -274,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 2673.078,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8436.09600000002,
"styleRecalcs": 248,
"styleRecalcDurationMs": 41.025,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5949.224,
"heapDeltaBytes": -12514212,
"heapUsedBytes": 90998980,
"domNodes": -270,
"jsHeapTotalBytes": -102400,
"scriptDurationMs": 2693.1440000000002,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18094.21999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17796.345,
"heapDeltaBytes": -33600740,
"heapUsedBytes": 178526860,
"domNodes": -8068,
"jsHeapTotalBytes": -8663040,
"scriptDurationMs": 304.11299999999994,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 18147.12099999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17500.305,
"heapDeltaBytes": -22861216,
"heapUsedBytes": 181195804,
"domNodes": -8068,
"jsHeapTotalBytes": -6828032,
"scriptDurationMs": 305.175,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 22683.464000000014,
"styleRecalcs": 167,
"styleRecalcDurationMs": 23.97899999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22480.23,
"heapDeltaBytes": -31050204,
"heapUsedBytes": 192664316,
"domNodes": -8068,
"jsHeapTotalBytes": -14237696,
"scriptDurationMs": 975.944,
"eventListeners": -14927,
"totalBlockingTimeMs": 117,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "vue-large-graph-pan",
"durationMs": 23093.36600000006,
"styleRecalcs": 172,
"styleRecalcDurationMs": 25.760999999999978,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22926.695,
"heapDeltaBytes": -50290228,
"heapUsedBytes": 192918492,
"domNodes": -8068,
"jsHeapTotalBytes": -19927040,
"scriptDurationMs": 1002.4009999999998,
"eventListeners": -14927,
"totalBlockingTimeMs": 152,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999995634
},
{
"name": "vue-node-resize-workload",
"durationMs": 6584.662000000037,
"styleRecalcs": 20,
"styleRecalcDurationMs": 94.03100000000003,
"layouts": 20,
"layoutDurationMs": 32.07600000000001,
"taskDurationMs": 6543.899,
"heapDeltaBytes": -37276644,
"heapUsedBytes": 193923204,
"domNodes": -8068,
"jsHeapTotalBytes": 2183168,
"scriptDurationMs": 149.67400000000004,
"eventListeners": -14929,
"totalBlockingTimeMs": 399,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6668.29800000005,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.64899999999997,
"layouts": 20,
"layoutDurationMs": 25.91700000000001,
"taskDurationMs": 6639.200999999999,
"heapDeltaBytes": -24162632,
"heapUsedBytes": 202006820,
"domNodes": -8068,
"jsHeapTotalBytes": 12103680,
"scriptDurationMs": 126.79799999999999,
"eventListeners": -14927,
"totalBlockingTimeMs": 381,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9093.976999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8862.173999999999,
"heapDeltaBytes": -3065792,
"heapUsedBytes": 178792528,
"domNodes": -1,
"jsHeapTotalBytes": -28049408,
"scriptDurationMs": 158.87799999999996,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9232.51199999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9086.811,
"heapDeltaBytes": 20419408,
"heapUsedBytes": 192645884,
"domNodes": 0,
"jsHeapTotalBytes": -10747904,
"scriptDurationMs": 153.92800000000005,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 109.42399999998997,
"styleRecalcs": 8,
"styleRecalcDurationMs": 16.341,
"layouts": 2,
"layoutDurationMs": 1.2209999999999999,
"taskDurationMs": 75.24499999999999,
"heapDeltaBytes": 3020636,
"heapUsedBytes": 72314012,
"domNodes": 131,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.585,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 100.5640000000767,
"styleRecalcs": 6,
"styleRecalcDurationMs": 12.056999999999999,
"layouts": 2,
"layoutDurationMs": 0.7589999999999999,
"taskDurationMs": 70.83600000000001,
"heapDeltaBytes": 3082904,
"heapUsedBytes": 72340688,
"domNodes": 107,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.721999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.54 #18631 +/- ##
=============================================
- Coverage 83.41% 82.22% -1.19%
=============================================
Files 2098 2533 +435
Lines 124150 132265 +8115
Branches 31418 33424 +2006
=============================================
+ Hits 103556 108756 +5200
- Misses 20415 22995 +2580
- Partials 179 514 +335
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 502 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…agent-ui-core-1.54
Backport source PR 18073 to the pre-split cloud/1.54 follower with bounded unanswered-subscribe retries and release-native unit coverage. (cherry picked from commit f39439a)
Backport adaptation: test-only. The #18063 carrier's race test mints its ops by hand with the three-part stamp of comfy-multi-player 0.2.1. core/1.54 runs 0.3.6, whose applyOps rejects that stamp as malformed_op, so two cases failed during setup. Cloud made the same fix when it adopted 0.3.2 (#18304): the test now mints through the runtime's mintWireOps. This takes main's file, which is byte-identical to cloud's after #18304. No runtime file changes, and #18304 changed none of the carrier's runtime code either.
#18064) (#18317) ## Summary Backports source PR #18064 to Cloud 1.54 so same-tick human graph operations are coalesced and pending batches are aborted on a document reset, preventing a cleared canvas from returning in a new chat. Source: #18064, merged as `42d44cd31e56071cea90e4a5027ee1d2d7a46830`. Target: `cloud/1.54` at `19a4f18b799f228a0faf39d951c22a4fdb53daf8`. Tracking: https://github.com/christian-byrne/blocked-on-christian/issues/827 ## Changes - **What**: Preserves same-tick operation coalescing, aborts admitted/in-flight human batches on `doc_reset`, and retains the saved workflow identity plus empty current draft for a new chat. - **Dependencies**: None. The release lockfile is unchanged. - **Target adaptation**: Keeps the release's `EcsFollowerAdapter`; adapts the removed conversation/socket regression to `agentConversationHostDoc` and `agentRequestResponseFixture` coverage. ## Review Focus - Coalescer admission/flush ordering around retarget and reset. - Release-specific adapter integration and target-harness regression coverage. - Backend authority behavior is not proven here; authentic served Cloud acceptance remains unavailable. Validation: focused Vitest 8 files / 355 tests; main and browser typechecks; full lint; format; ADR validation. All passed. Backport note (core/1.54): two mechanical conflicts, both resolved to main's end state. - browser_tests/fixtures/agentConversationHostDoc.test.ts keeps core's file. The carrier's extra "coalesced canvas clear" test exists only on cloud (main's #18064 never added it). It also calls HostDoc.applyClient, which core and main replaced with applyWire. - useAgentCrdtFollower.test.ts keeps both imports: core's GraphOperation and the carrier's BatchOutcome. (cherry picked from commit 06068f3)
…rkflows (#18330) Backport of [source workflow repair](#18033) to `cloud/1.54` Automatically created by backport workflow. <details><summary>Full context for agent readers</summary> Justification: Necessary Cloud release backport under Christian’s explicit admin-merge authorization. Exact-head target-aware guard, required lint/unit/browser checks, substantive review and normal hooks passed; no recorded human objection. No standing human approval is claimed. Authenticated edit/save/reload acceptance remains separate and open. </details> Co-authored-by: Christian Byrne <cbyrne@comfy.org> (cherry picked from commit 86d76db)
Backport adaptation (test-only) for #18603 on core/1.54. agentPanel.test.ts and OnboardingCoach.test.ts mock @/platform/telemetry without a factory and read methods off useTelemetry(). On main that resolves to src/platform/telemetry/__mocks__/index.ts, added by #17686, which this line does not have, so useTelemetry() returned undefined and 15 tests failed. Add the file as main has it. WorkflowTabs.test.ts, the only other suite here that mocks the module without a factory, passes with and without it.
Backport adaptation (test-only) for #18603 on core/1.54. #18603's new tour test in AgentPanelRoot.test.ts starts an onboarding tour, and the tour store reports each stage through useTelemetry()?.trackOnboardingTour. This suite's hand-written telemetry mock has no such method, so the run ended with two unhandled rejections ("telemetry?.trackOnboardingTour is not a function") and exit 1 although all 237 tests passed. Stub it like the mock's other methods.
Backport resolution (runtime) for #18603 on core/1.54. #18603 adds trackAgentConsentNotOffered and trackAgentOnboardingNotShown to HostTelemetrySink. This branch already carries #18376's agent methods, so the sink and its test are at the exact state #18603 started from on main (blobs 3401ead and c78a7ed). This commit applies #18603's own sink change to them, and both files now equal main's.
…so 'server' reaches the backend catalog (#18860) ## Summary Backports the **test-fixture subset** of #17730 to `core/1.54`: `bootAgentApp` now passes `objectInfo` through to `mockCloudBoot`, so `objectInfo: 'server'` stops being swallowed and the empty `{}` `/api/object_info` mock is no longer registered last (Playwright runs the most-recently-registered matching route first, so that empty mock was shadowing every node-def route a harness registers before boot). ## Changes - **What**: `browser_tests/fixtures/agentPanelFixture.ts` + `browser_tests/fixtures/utils/cloudBootMocks.ts` — the exact fixture hunks `cloud/1.54` received inside #18550 (manual backport of #17730, source squash `7806755421`). Byte-identical to both `cloud/1.54` and `main` after this change. **Test infrastructure only** — no `src/` changes; the #17730 product feature stays excluded from `core/1.54` exactly as #18631 recorded ("core lacks its three files"). ## Review Focus This is the root cause of the two deterministic failures blocking #18512 (run [36138115446](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36138115446)): `agentCrdtMultiAutogrowRealign.spec.ts` boots with `objectInfo: 'server'` and registers its node defs before boot, which only works with the post-#17730 fixture semantics. On this branch the app booted with an **empty node catalog**, `LiteGraph.createNode` returned null for the fixture types, the CRDT materializer fell back to `missingNode()`, and the target node rendered slots but zero widgets — hence no `textbox "prompt"`. This is a test-env artifact, **not** a product accessibility divergence: with the catalog actually served, `core/1.54` renders the prompt textarea with the correct accessible name. Local verification at `core/1.54` + #18512 carrier head: - Both `agentCrdtMultiAutogrowRealign` tests: red before this change, **green after** (1.8s / 4.5s). - Full `--project=cloud` suite: 225 passed; the 6 local failures are identical with and without this change (pre-existing local-env artifacts, all green in CI baseline). - `typecheck:browser`, `eslint`, `oxfmt --check`: clean.
Summary
Ports to
core/1.54every mergedmainAgent fix thatcloud/1.54carries and core does not (the Agent UI catch-up from #18622, the cloud-only CRDT and workflow fixes, and the round-2 fixes), so both release lines are symmetric ahead of the local-agent rollout.Changes
cherry-pick -x, in three groups:src/lib/litegraph/files; a 5 px HUD offset inSideToolbar.vuecompensates), refactor: replace Agent shadow theme with shared design system #17471, refactor: use shared buttons across Agent controls #17690.core/1.54: feat(FE-2042): add four-step Agent onboarding tour #17439 (Catalogue-wide Agent backports for core/1.54 #18161), feat(agent): offer the consent card without a button click #17912 ([backport core/1.54] Agent catalogue sweep 2 #18186), fix: agent tool-call chat completion lags canvas materialization (PM-1575/PM-1576) #18391 ([backport core/1.54] fix: agent tool-call chat completion lags canvas materialization (PM-1575/PM-1576) #18595).Review Focus
src/extensions/core/index.ts:41-44); the shared chrome from feat(agent): move the agent button to the far right and nest the panel #17621 and refactor: replace Agent shadow theme with shared design system #17471 and the host telemetry from fix: forward agent telemetry to desktop host #18376 and fix(onboarding): report three onboarding failures that were silent #18603 ship in every build.HostTelemetrySink.tsand its test equalmain's files (fix: forward agent telemetry to desktop host #18376, then fix(onboarding): report three onboarding failures that were silent #18603 on top).agentConversationHostDoc.test.tskeeps this line's file; fix(agent-crdt): keep a human delete across a workflow tab switch #18063's new test usesmain's version (multi-player 0.3.x stamps).Linear: PM-1657, PM-1656
Screenshots (if applicable)
Visual changes are the ones reviewed on
mainand carried to cloud in #18622.