Skip to content

[backport cloud/1.54] feat(agent): report graph activity without moving the camera - #18550

Merged
christian-byrne merged 4 commits into
cloud/1.54from
backport-17730-cloud-1.54
Sep 23, 2026
Merged

christian-byrne merged 4 commits into
cloud/1.54from
backport-17730-cloud-1.54

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Backports the graph-activity change to cloud/1.54.

  • Reports agent-added nodes without moving the camera.
  • Highlights those nodes in the minimap and frames them only on request.
  • Preserves the release line's newer conflict-free replicated data type lifecycle and browser harness.
Full context for agent readers

Source squash: 7806755.

This is a manual semantic backport because the source conflicted with newer conflict-free replicated data type follower, retry, persistence, suspension, and browser-fixture work already present on cloud/1.54. The resolution keeps that newer architecture, adds classified live-versus-catch-up materialization events, and adapts the black-box browser case to the release line's existing host-document harness rather than restoring deleted replay fixtures.

Static verification: git diff --check passed; no conflict markers or stale imports remain. Local executable checks were intentionally not run under the active Resource Guardian constraint. Hosted continuous integration is the executable verification authority.

Manual backport of #17730 (7806755), adapted to the release line's newer CRDT follower and HostDoc browser harness.
@christian-byrne
christian-byrne requested a review from a team as a code owner September 23, 2026 05:29
@christian-byrne christian-byrne added the backport Backporting a PR onto a release candidate label Sep 23, 2026
@christian-byrne christian-byrne self-assigned this Sep 23, 2026
@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: d28051aa-cecf-4f87-968a-dd0c9cf13e1c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@vercel

vercel Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 23, 2026 8:02am UTC

Request Review

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1945 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1924 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/23/2026, 08:09:09 AM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.1 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.9 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.8 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.4 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.8 MB heap
large-graph-pan: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.6 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.1 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.0 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.7 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.8 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.7 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 146ms TBT · 79.0 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.3 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.0 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 64ms TBT · 168.2 MB heap
vue-node-resize-workload: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 442ms TBT · 175.9 MB heap
vue-zoom-out-idle: · 55.4 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.2 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.3 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 11ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 566ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 69.1 MB
canvas-idle: DOM nodes -130
canvas-idle: event listeners -80
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 31ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 907ms
canvas-mouse-sweep: script duration 169ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 67.9 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -179
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 390ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.8 MB
canvas-zoom-sweep: DOM nodes 75
canvas-zoom-sweep: event listeners 20
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 459ms
dom-widget-clipping: script duration 165ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.4 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 647ms
large-graph-idle: script duration 37ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 78.8 MB
large-graph-idle: DOM nodes -282
large-graph-idle: event listeners -193
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 12ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 1738ms
large-graph-pan: script duration 844ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 78.6 MB
large-graph-pan: DOM nodes -279
large-graph-pan: event listeners -192
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 13ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 62
large-graph-zoom: task duration 1832ms
large-graph-zoom: script duration 805ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.1 MB
large-graph-zoom: DOM nodes -285
large-graph-zoom: event listeners -192
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 1972ms
legacy-node-drag: script duration 976ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 84.0 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 614ms
minimap-idle: script duration 34ms
minimap-idle: TBT 0ms
minimap-idle: heap used 82.7 MB
minimap-idle: DOM nodes -272
minimap-idle: event listeners -193
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 12ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 423ms
subgraph-dom-widget-clipping: script duration 144ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.2 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 507ms
subgraph-idle: script duration 9ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 66.8 MB
subgraph-idle: DOM nodes -295
subgraph-idle: event listeners -226
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 30ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 853ms
subgraph-mouse-sweep: script duration 116ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 71.7 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -226
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 17ms
subgraph-transition-enter: style recalc duration 34ms
subgraph-transition-enter: layout count 17
subgraph-transition-enter: style recalc count 21
subgraph-transition-enter: task duration 1005ms
subgraph-transition-enter: script duration 32ms
subgraph-transition-enter: TBT 146ms
subgraph-transition-enter: heap used 79.0 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2387
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 36ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 247
viewport-pan-sweep: task duration 6088ms
viewport-pan-sweep: script duration 2801ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 83.3 MB
viewport-pan-sweep: DOM nodes -271
viewport-pan-sweep: event listeners -146
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17140ms
vue-large-graph-idle: script duration 301ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 171.0 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14934
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 168
vue-large-graph-pan: task duration 21082ms
vue-large-graph-pan: script duration 935ms
vue-large-graph-pan: TBT 64ms
vue-large-graph-pan: heap used 168.2 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14927
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 25ms
vue-node-resize-workload: style recalc duration 82ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6317ms
vue-node-resize-workload: script duration 119ms
vue-node-resize-workload: TBT 442ms
vue-node-resize-workload: heap used 175.9 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14928
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8682ms
vue-zoom-out-idle: script duration 152ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 170.2 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -11
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 18ms
workflow-execution: layout count 3
workflow-execution: style recalc count 11
workflow-execution: task duration 93ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.3 MB
workflow-execution: DOM nodes 124
workflow-execution: event listeners 42
Raw data
{
  "timestamp": "2026-09-23T08:17:30.415Z",
  "gitSha": "bcc5799d0e5a9554e3cce28da54d31f587c2287f",
  "branch": "backport-17730-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2161.0900000000015,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 13.244999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 658.183,
      "heapDeltaBytes": 3792272,
      "heapUsedBytes": 74034156,
      "domNodes": -277,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 10.812999999999999,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2018.609999999967,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.91,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 473.54900000000004,
      "heapDeltaBytes": 1456396,
      "heapUsedBytes": 70923796,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 8.726999999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1890.07799999996,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 30.975,
      "layouts": 14,
      "layoutDurationMs": 4.072,
      "taskDurationMs": 905.5,
      "heapDeltaBytes": 3106064,
      "heapUsedBytes": 74327060,
      "domNodes": -282,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 165.58700000000002,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1874.4100000000117,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 30.776999999999997,
      "layouts": 14,
      "layoutDurationMs": 4.204999999999999,
      "taskDurationMs": 907.732,
      "heapDeltaBytes": -2848964,
      "heapUsedBytes": 67990004,
      "domNodes": -280,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 172.686,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1736.947999999984,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.415999999999997,
      "layouts": 6,
      "layoutDurationMs": 1.336,
      "taskDurationMs": 378.946,
      "heapDeltaBytes": 4381352,
      "heapUsedBytes": 74689484,
      "domNodes": 74,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 12.460999999999997,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1682.0579999999836,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.107,
      "layouts": 6,
      "layoutDurationMs": 1.101,
      "taskDurationMs": 400.058,
      "heapDeltaBytes": 4613256,
      "heapUsedBytes": 75830316,
      "domNodes": 75,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 12.050000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 704.845999999975,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.603999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 455.1430000000001,
      "heapDeltaBytes": 18300904,
      "heapUsedBytes": 88729260,
      "domNodes": 16,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 166.751,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 725.750000000005,
      "styleRecalcs": 13,
      "styleRecalcDurationMs": 10.998000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 463.22100000000006,
      "heapDeltaBytes": -7884700,
      "heapUsedBytes": 63114360,
      "domNodes": 22,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 164.161,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2071.762999999976,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.857999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 634.9090000000001,
      "heapDeltaBytes": 6564280,
      "heapUsedBytes": 82870292,
      "domNodes": -279,
      "jsHeapTotalBytes": -1155072,
      "scriptDurationMs": 38.00099999999999,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2068.5110000000577,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 5.385999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 658.361,
      "heapDeltaBytes": 5665888,
      "heapUsedBytes": 82392772,
      "domNodes": -284,
      "jsHeapTotalBytes": -1679360,
      "scriptDurationMs": 35.689,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2421.547999999973,
      "styleRecalcs": 67,
      "styleRecalcDurationMs": 12.781999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1768.517,
      "heapDeltaBytes": -2236888,
      "heapUsedBytes": 75290864,
      "domNodes": -283,
      "jsHeapTotalBytes": 118784,
      "scriptDurationMs": 857.793,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2355.519999999956,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 11.196999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1708.4509999999998,
      "heapDeltaBytes": 12161392,
      "heapUsedBytes": 89577712,
      "domNodes": -275,
      "jsHeapTotalBytes": -405504,
      "scriptDurationMs": 829.449,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3687.463999999977,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 12.438000000000004,
      "layouts": 60,
      "layoutDurationMs": 12.352000000000002,
      "taskDurationMs": 1833.37,
      "heapDeltaBytes": -3455960,
      "heapUsedBytes": 75572564,
      "domNodes": -289,
      "jsHeapTotalBytes": 1990656,
      "scriptDurationMs": 806.9040000000001,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3713.58900000007,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 12.809000000000001,
      "layouts": 60,
      "layoutDurationMs": 12.135,
      "taskDurationMs": 1831.447,
      "heapDeltaBytes": -2645616,
      "heapUsedBytes": 75679484,
      "domNodes": -280,
      "jsHeapTotalBytes": -1941504,
      "scriptDurationMs": 802.519,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3118.7250000000404,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.079999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1957.731,
      "heapDeltaBytes": 17692612,
      "heapUsedBytes": 85632684,
      "domNodes": 0,
      "jsHeapTotalBytes": 1466368,
      "scriptDurationMs": 967.881,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3128.812000000039,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.925999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1986.6789999999999,
      "heapDeltaBytes": 22213844,
      "heapUsedBytes": 90569328,
      "domNodes": 0,
      "jsHeapTotalBytes": 1990656,
      "scriptDurationMs": 984.357,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "minimap-idle",
      "durationMs": 2051.200999999992,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 4.661000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 620.667,
      "heapDeltaBytes": 7501552,
      "heapUsedBytes": 85721124,
      "domNodes": -275,
      "jsHeapTotalBytes": -1941504,
      "scriptDurationMs": 33.529,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2036.3229999999248,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.615999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 606.7179999999998,
      "heapDeltaBytes": 9300700,
      "heapUsedBytes": 87666496,
      "domNodes": -269,
      "jsHeapTotalBytes": -1417216,
      "scriptDurationMs": 34.58800000000001,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 578.3109999999851,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 12.821,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 420.419,
      "heapDeltaBytes": 15059228,
      "heapUsedBytes": 88251552,
      "domNodes": 22,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 141.77499999999998,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 639.372000000094,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 11.358999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 425.35200000000003,
      "heapDeltaBytes": 13596360,
      "heapUsedBytes": 86318952,
      "domNodes": 18,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 145.478,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.8879999999663,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.033999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 496.03700000000003,
      "heapDeltaBytes": 5472908,
      "heapUsedBytes": 77977220,
      "domNodes": -296,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 8.6,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2015.3119999999944,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.903999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 517.4810000000001,
      "heapDeltaBytes": -10413836,
      "heapUsedBytes": 62090720,
      "domNodes": -294,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 8.732,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1773.4690000000342,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 32.872,
      "layouts": 18,
      "layoutDurationMs": 5.944,
      "taskDurationMs": 863.087,
      "heapDeltaBytes": -5258824,
      "heapUsedBytes": 67969588,
      "domNodes": -295,
      "jsHeapTotalBytes": 7069696,
      "scriptDurationMs": 117.35600000000001,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1741.186999999968,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 27.51,
      "layouts": 18,
      "layoutDurationMs": 5.248000000000001,
      "taskDurationMs": 843.775,
      "heapDeltaBytes": 9383560,
      "heapUsedBytes": 82478956,
      "domNodes": -296,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 115.16499999999999,
      "eventListeners": -212,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1401.8489999999701,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 34.03,
      "layouts": 17,
      "layoutDurationMs": 16.627,
      "taskDurationMs": 1005.3949999999999,
      "heapDeltaBytes": -7151384,
      "heapUsedBytes": 82838148,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10223616,
      "scriptDurationMs": 31.981,
      "eventListeners": 2387,
      "totalBlockingTimeMs": 146,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8915.030000000002,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 36.301,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6101.505999999999,
      "heapDeltaBytes": 9170964,
      "heapUsedBytes": 85336512,
      "domNodes": -272,
      "jsHeapTotalBytes": -176128,
      "scriptDurationMs": 2799.526,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8975.59799999999,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 36.034,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6074.601000000001,
      "heapDeltaBytes": 12776732,
      "heapUsedBytes": 89427712,
      "domNodes": -269,
      "jsHeapTotalBytes": -962560,
      "scriptDurationMs": 2803.245,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17825.99399999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17167.182,
      "heapDeltaBytes": -39969564,
      "heapUsedBytes": 178255556,
      "domNodes": -8068,
      "jsHeapTotalBytes": -10235904,
      "scriptDurationMs": 303.36800000000005,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17922.268000000033,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17113.07,
      "heapDeltaBytes": -56363488,
      "heapUsedBytes": 180254336,
      "domNodes": -8068,
      "jsHeapTotalBytes": -15118336,
      "scriptDurationMs": 299.622,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21599.231000000033,
      "styleRecalcs": 168,
      "styleRecalcDurationMs": 18.59299999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21233.128,
      "heapDeltaBytes": -28211940,
      "heapUsedBytes": 183450836,
      "domNodes": -8068,
      "jsHeapTotalBytes": -21479424,
      "scriptDurationMs": 941.598,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 68,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21276.126999999975,
      "styleRecalcs": 168,
      "styleRecalcDurationMs": 18.923999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20930.464,
      "heapDeltaBytes": -63012028,
      "heapUsedBytes": 169206308,
      "domNodes": -8068,
      "jsHeapTotalBytes": -19050496,
      "scriptDurationMs": 928.081,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 59,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6446.286999999984,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 85.08499999999997,
      "layouts": 20,
      "layoutDurationMs": 25.811999999999987,
      "taskDurationMs": 6371.372,
      "heapDeltaBytes": -37515300,
      "heapUsedBytes": 181830508,
      "domNodes": -8068,
      "jsHeapTotalBytes": 11538432,
      "scriptDurationMs": 116.08099999999999,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 468,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6392.078000000083,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 79.58300000000001,
      "layouts": 20,
      "layoutDurationMs": 23.429000000000006,
      "taskDurationMs": 6263.4349999999995,
      "heapDeltaBytes": -31091028,
      "heapUsedBytes": 187020872,
      "domNodes": -8068,
      "jsHeapTotalBytes": 19386368,
      "scriptDurationMs": 122.608,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 415,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9020.497999999974,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8718.019,
      "heapDeltaBytes": -2152032,
      "heapUsedBytes": 178470988,
      "domNodes": 0,
      "jsHeapTotalBytes": -15728640,
      "scriptDurationMs": 152.736,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9081.569000000058,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8645.789999999999,
      "heapDeltaBytes": 22676504,
      "heapUsedBytes": 178556760,
      "domNodes": 0,
      "jsHeapTotalBytes": -8126464,
      "scriptDurationMs": 150.644,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 113.09899999997697,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 16.299,
      "layouts": 2,
      "layoutDurationMs": 1.4280000000000002,
      "taskDurationMs": 85.80099999999999,
      "heapDeltaBytes": 3010304,
      "heapUsedBytes": 71471288,
      "domNodes": 129,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 6.6869999999999985,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 456.21300000004794,
      "styleRecalcs": 14,
      "styleRecalcDurationMs": 19.395999999999997,
      "layouts": 3,
      "layoutDurationMs": 1.2439999999999998,
      "taskDurationMs": 100.05,
      "heapDeltaBytes": 4748600,
      "heapUsedBytes": 73917604,
      "domNodes": 119,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 8.767,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50367 75571 66.6% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.6% 275
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.4% 260
src/scripts/pnginfo.ts 21.4% 221

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 23, 2026
@datadog-official

datadog-official Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Pipelines

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 2 Pipeline jobs failed

CI: Tests E2E | e2e-status

View in Datadog · View in GitHub Actions

CI: Tests E2E | playwright-tests (cloud)

View in Datadog · View in GitHub Actions

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 166b82e | Docs | View more details | Give us feedback!

Copy link
Copy Markdown
Contributor Author

Shepherd receipt: merged the current cloud/1.54 tip into this author-controlled branch with a normal guarded push. The PR head is now 951b657073a91c7fcb27451e5ac663850f859f89, containing target a0e11238804e2b4ab862785c78e66743936288ef; the prior target-induced conflict is resolved. No force-push, workflow rerun, approval, or merge action was used.

Conflict resolution and verification
  • Resolved the sole conflict in layoutFollowerBridge.ts by preserving this PR's classified doc_update dispatch and incorporating the target's schema-gate recovery behavior from [backport cloud/1.54] test(agent-crdt): repro schema-gate latch leaving canvas at zero nodes #18542.
  • Focused unit tests: 4 files, 219 tests passed.
  • pnpm typecheck: passed.
  • Changed-file oxfmt and ESLint: passed.
  • Commit hooks: oxfmt, type-aware Oxlint, ESLint, and typecheck passed.
  • Push hook: Knip passed.
  • Next guard: hosted checks and independent review must qualify this exact head before any merge action.

@codecov

codecov Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 81.77458% with 76 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ensions/agent/components/AgentGraphActivityBar.vue 29.31% 41 Missing ⚠️
...derer/extensions/minimap/composables/useMinimap.ts 72.50% 11 Missing ⚠️
src/workbench/extensions/agent/AgentPanelRoot.vue 76.59% 11 Missing ⚠️
src/platform/canvas/minimapDecorationRegistry.ts 90.90% 4 Missing ⚠️
...ench/extensions/agent/crdt/useAgentCrdtFollower.ts 93.75% 4 Missing ⚠️
src/components/graph/CanvasBanner.vue 71.42% 1 Missing and 1 partial ⚠️
...nderer/extensions/minimap/minimapCanvasRenderer.ts 96.55% 1 Missing ⚠️
src/utils/positionBounds.ts 96.00% 1 Missing ⚠️
...sions/agent/stores/agent/agentConversationStore.ts 93.33% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #18550   +/-   ##
=============================================
  Coverage              ?   83.66%           
=============================================
  Files                 ?     2105           
  Lines                 ?   124587           
  Branches              ?    31584           
=============================================
  Hits                  ?   104233           
  Misses                ?    20175           
  Partials              ?      179           
Flag Coverage Δ
e2e 66.65% <61.72%> (?)
unit 78.70% <82.03%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/components/graph/NodeSelectionModeBanner.vue 100.00% <100.00%> (ø)
src/renderer/core/spatial/boundsCalculator.ts 96.66% <100.00%> (ø)
src/renderer/extensions/minimap/MiniMap.vue 46.66% <ø> (ø)
...tensions/minimap/composables/useMinimapRenderer.ts 100.00% <100.00%> (ø)
src/stores/agentNodeSelectionStore.ts 98.80% <100.00%> (ø)
src/stores/workflowTabActivityStore.ts 100.00% <ø> (ø)
...ench/extensions/agent/crdt/layoutFollowerBridge.ts 97.76% <100.00%> (ø)
...ions/agent/stores/agent/agentGraphActivityStore.ts 100.00% <100.00%> (ø)
...nderer/extensions/minimap/minimapCanvasRenderer.ts 96.66% <96.55%> (ø)
src/utils/positionBounds.ts 96.00% <96.00%> (ø)
... and 7 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne
christian-byrne merged commit f1fb881 into cloud/1.54 Sep 23, 2026
89 of 91 checks passed
@christian-byrne
christian-byrne deleted the backport-17730-cloud-1.54 branch September 23, 2026 09:38
comfy-pr-bot pushed a commit that referenced this pull request Sep 23, 2026
#18622)

## Summary

Backports the Agent UI changes that staging and prod are missing to
`cloud/1.54`, as one cherry-pick catalogue: the folded trace, the shared
design system and buttons for the Agent controls, the consent card
redesign, and the moved Agent button with the nested panel. Staging
picks it up with the next `cloud/1.54` deploy; prod gets it at the next
production promotion of `cloud/1.54`.

Linear:
[PM-1657](https://linear.app/comfyorg/issue/PM-1657/test-stagingprod-missing-the-tool-call-always-expose-thinking-then),
[PM-1656](https://linear.app/comfyorg/issue/PM-1656)

## Changes

- **What**: `cherry-pick -x` of 8 merged `main` PRs, in `main` merge
order:
  - #17339 fold the finished trace into one summary
  - #17908 consent card video and stacked card layout
  - #17420 animate a step as it arrives (follow-up to #17339)
  - #18348 remove the workflow timing display (follow-up to #17339)
  - #18043 make the agent button legible in the light theme
- #17621 agent button at the far right, nested panel, without its two
`src/lib/litegraph/` files (see Review Focus)
  - #17471 replace the Agent shadow theme with the shared design system
  - #17690 use shared buttons across Agent controls
- **Already on `cloud/1.54`** from the same request, so not repeated
here: #17439 (via #18162), #17912 (via #18185), #17730 (via #18550).
- **Breaking**: none.
- **Dependencies**: none. `package.json` and the lockfile are unchanged
apart from the merged 1.54.15 bump (#18569).

## Review Focus

- #17621 changes shared chrome outside the Agent panel (top bar,
workflow tabs, side toolbar, breadcrumb, canvas splitter, LinearView),
so every user sees the new layout. #17471 changes the shared tooltip.
- #17621's two `src/lib/litegraph/` files are held out (agent fixes keep
litegraph unchanged); a 5 px HUD offset in `SideToolbar.vue`
compensates. Carrying them instead is a one-file follow-up if preferred.
- #18351 and #18367 are superseded by main's trace renderer, which this
brings in.
- Hosted checks are green on the head: 86 passed, 0 failed. Per-source
resolutions and the full verification log are in the details below.

<details><summary>Resolution and verification, per source</summary>

### Resolution

- `b5401705d8` drops a duplicate `useI18n` declaration left by the
#17339 pick.
- The merge of the `cloud/1.54` tip keeps main's `AgentMessage.vue` and
its test, which supersede #18351 and #18367: the working spinner after
tools is #17339's composing row, covered by `AgentMessage.test.ts`
"marks the turn as still working between the last tool and the first
reply token", and the thinking text uses the trace's `text-sm/5`.
- #17621: 8 release-line browser files switch from `askComfyAgent` to
`entryButton`, since #17621 removes that label; its GraphCanvas dock
tests set linear mode after mount on this line's test setup.
- `101c8f19cd` (test-only): three agent browser tests move off the
removed "Ran N tool calls" button to main's WorkSummary locators.
- `09236f342d` (test-only): `exact: true` on the autogrow spec's two
entry-button lookups, as on main, since "Agent" now also prefixes the
targeted workflow tab's button name.
- `d49b4ddf12` (runtime): `SideToolbar.vue` places the canvas info HUD
at `sidebarRight + canvasGutter() - 5`. The release line's `renderInfo`
keeps a 5 px text inset that main removed in #17621's litegraph half, so
this offset lands the HUD where main puts it. It goes away when that
litegraph change reaches the line.
- #17471: 12 conflicts resolved toward main. `ab65e60731` (runtime)
takes main's final `RunModePopover.vue` as is: main's end state is the
DropdownMenu form from #18115, which this line carries via #18265, and
the remaining diff was styling only. `55e005ed10` (runtime) maps the
last 2 shadow-theme tokens in `CrdtDevPanel`. 38 of 42 files carry the
source's exact change stream.
- #17690: 1 conflict resolved toward main; 17 of 18 files carry the
source's exact change stream.
- The `cloud/1.54` tip was merged in twice; the second merge brings the
1.54.15 bump (#18569) with no other change.

### Verification

- Hosted checks on the head: 86 passed, 0 failed (e2e run 35907168615:
16 chromium shards, cloud, 0.5x, 2x, mobile-chrome, mobile-safari,
video).
- `git diff --name-only origin/cloud/1.54...HEAD --
':/src/lib/litegraph/'` prints nothing.
- Local at the head: `pnpm typecheck` and `pnpm typecheck:browser` exit
0; 41 unit suites, 563 tests pass; 0 shadow-theme tokens and 0
`AgentTooltip` references remain.
- #17908: `agentConsent.spec.ts` passes 14 of 14 with the change and
fails 5 of 14 without it (local run, devtools setup endpoints stubbed).
- Per-source parity: every difference from the source change streams is
listed under Resolution.
- Staging acceptance after landing: the trace fold, the design system
and buttons in light and dark, the nested panel and moved button, the
consent card, plus the onboarding tour, consent without a click and the
graph activity bar as regressions. Prod needs a production promotion of
`cloud/1.54` after that.

</details>

## Screenshots (if applicable)

Visual changes are the ones already reviewed on `main` in #17471,
#17690, #17621 and #17908; the e2e screenshot baselines in this PR come
from those merges.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Co-authored-by: uytieu <uytieu@users.noreply.github.com>
Co-authored-by: ryan-di <ryan.weihao.di@gmail.com>
Co-authored-by: jaeone lee <89377375+jaeone94@users.noreply.github.com>
Co-authored-by: Christian Byrne <cbyrne@comfy.org>
Co-authored-by: Amp <amp@ampcode.com>
Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Alexander Brown <drjkl@comfy.org>
@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-session Agent sessions, history, turn lifecycle or workflow binding agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components labels Sep 24, 2026
christian-byrne added a commit that referenced this pull request Sep 25, 2026
…so 'server' reaches the backend catalog (#18860)

## Summary

Backports the **test-fixture subset** of #17730 to `core/1.54`:
`bootAgentApp` now passes `objectInfo` through to `mockCloudBoot`, so
`objectInfo: 'server'` stops being swallowed and the empty `{}`
`/api/object_info` mock is no longer registered last (Playwright runs
the most-recently-registered matching route first, so that empty mock
was shadowing every node-def route a harness registers before boot).

## Changes

- **What**: `browser_tests/fixtures/agentPanelFixture.ts` +
`browser_tests/fixtures/utils/cloudBootMocks.ts` — the exact fixture
hunks `cloud/1.54` received inside #18550 (manual backport of #17730,
source squash `7806755421`). Byte-identical to both `cloud/1.54` and
`main` after this change. **Test infrastructure only** — no `src/`
changes; the #17730 product feature stays excluded from `core/1.54`
exactly as #18631 recorded ("core lacks its three files").

## Review Focus

This is the root cause of the two deterministic failures blocking #18512
(run
[36138115446](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36138115446)):
`agentCrdtMultiAutogrowRealign.spec.ts` boots with `objectInfo:
'server'` and registers its node defs before boot, which only works with
the post-#17730 fixture semantics. On this branch the app booted with an
**empty node catalog**, `LiteGraph.createNode` returned null for the
fixture types, the CRDT materializer fell back to `missingNode()`, and
the target node rendered slots but zero widgets — hence no `textbox
"prompt"`. This is a test-env artifact, **not** a product accessibility
divergence: with the catalog actually served, `core/1.54` renders the
prompt textarea with the correct accessible name.

Local verification at `core/1.54` + #18512 carrier head:
- Both `agentCrdtMultiAutogrowRealign` tests: red before this change,
**green after** (1.8s / 4.5s).
- Full `--project=cloud` suite: 225 passed; the 6 local failures are
identical with and without this change (pre-existing local-env
artifacts, all green in CI baseline).
- `typecheck:browser`, `eslint`, `oxfmt --check`: clean.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-crdt Agent document synchronization, graph projection or CRDT operations agent-session Agent sessions, history, turn lifecycle or workflow binding agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-test-unit Touches Agent-related unit/component tests or their support agent-ui Agent panel, composer, transcript or other user-interface components backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants