Repository navigation
[backport cloud/1.54] Agent UI catch-up for staging and prod (PM-1657) - #18622
Conversation
> [!IMPORTANT] > **This is a design PR, not production code.** It is a working prototype that shows how the design looks and how it can behave. Review it to decide which parts to keep and which parts to rewrite. When the reply finishes, the thinking and tool-call trace folds into one summary row. Fixes [DES-778](https://linear.app/comfyorg/issue/DES-778/des-fold-the-thinking-tool-call-trace-into-a-summary-once-the-reply) - **What**: - While the agent works, the panel shows one flat list. Each thinking step and each tool call is one row. - A vertical line connects the icons of adjacent rows. - While a thinking step runs, the row reads `Thinking - <action>`. - After the turn ends, the row reads `Thought for 1.4s` with the reasoning text below it. - When the reply finishes, all steps fold into one collapsed row. - When a turn is longer than one minute, the label reads `Worked for 3m 25s`. - A `Working...` row marks the gap between the last tool call and the first reply token. - **Internal**: This PR removes `ToolCallGroup.vue` and `ToolCallCard.vue`. `ActivityTrace.vue` and `WorkSummary.vue` replace them. `agentActivityRows.ts` holds the fold of wire parts into display rows. `formatDuration.ts` holds the duration format. - One summary holds every thinking step and tool call of the turn. Text that came between two tool calls now shows below the summary, not between the calls. - `v-memo` on the trace rows stops the re-render of a settled row on each token. The old component collapsed its rows during the reply stream, so this cost is new. - The reasoning text is always open. A long turn gives a long summary when the reader opens it. - `ActivityTrace.vue` uses `<i18n-t>` with a slot. The global `escapeParameter` option turns an apostrophe into `'` inside a `t()` parameter. - Storybook and the unit tests cover this change. No one ran it in the live app. Thinking and tool call w/ agent working state https://github.com/user-attachments/assets/d2114d9f-601b-4287-9fbd-42a9527ae5ea When agent is done, the thinking and tool call is collapsed https://github.com/user-attachments/assets/156c611d-751f-4b3e-b595-69dd1b72f267 --------- Co-authored-by: ryan-di <ryan.weihao.di@gmail.com> (cherry picked from commit d17e2ec)
## Summary Linear issues: [PM-629](https://linear.app/comfyorg/issue/PM-629/request-for-video-asset-for-consent-card) · [PM-514](https://linear.app/comfyorg/issue/PM-514) The Comfy Agent consent card now plays a new video, and the card has a new layout. https://github.com/user-attachments/assets/ee20ab80-32c6-4eb2-826a-a3ed82b11941 ## Changes - **What**: - The card shows the new Comfy Agent video. It replaces the older MCP launch film. - The video now comes from the Comfy media server. It is no longer stored in this repository. - The card also loads an MP4 copy and a still image. Older iPhones can now play the video. - The card is one column. The video is on top, and the text is below it. - The video keeps its widescreen shape. The picture is no longer cut off at the sides. - Both buttons are larger. "Skip for now" now uses the standard button style. - On a wide card, the "Read the docs" link sits beside the buttons. On a narrow card, it moves up beside the text. ## Review Focus - This change answers PM-629 from the other side. The card no longer crops the video to a square, so a square asset and a crop safe zone are not necessary. - The three media files are new paths on the media server, so they serve immediately. No cached file is replaced. - The 2.2 MB video file is deleted from the repository. The build no longer carries it. - The browser tests load a small test video instead of the real one. This keeps the tests off the media server. ## Screenshots (if applicable) <img width="1728" height="963" alt="image" src="https://github.com/user-attachments/assets/28d17739-bb85-4fb8-8d94-c4990df5a543" /> --------- Co-authored-by: jaeone lee <89377375+jaeone94@users.noreply.github.com> (cherry picked from commit f9a37f9)
…ger (#17420) Steps in the agent trace fade in as they arrive, and the scroll-follow trigger no longer serializes the transcript. Fixes [DES-1032](https://linear.app/comfyorg/issue/DES-1032/agent-panel-animate-steps-as-they-arrive) - **What**: - A step fades in over 160ms as it arrives. The animation uses opacity only. - The panel is bottom-anchored and scrolls to the newest row. A rise would move the row upward a second time. - The `live` prop gates the animation. `AgentMessage` passes it for a running turn. `WorkSummary` does not pass it. - Reduced motion and `.disable-animations` turn the animation off, the same as the shimmer. - The scroll-follow trigger reads the entry count, the part count, and the size of the tail part. Before this change it ran `JSON.stringify` over every part of the newest message and measured the string it built. - A new story, `DES-1032 Each step fades in as it arrives`, appends a step every 900ms. The other stories mount every row at once, so they show the fade but not the arrival. - Open the new story to see the animation. Each row fades in as it lands, and the rows already on screen hold still. - Only the newest row animates, and an older row does not restart when the list re-renders around it. Measured with `getAnimations()` across five arrivals in that story: exactly one row animated each time, and it was always the newest. A local turn added nothing to this. That turn used no tools, so no trace rendered. - The `live` gate is where an error hides. When you open a finished turn and expand the summary, no row fades. The same is true for a conversation you reopen. Both paths mount every row at once. - The scroll change is invisible. The review surface is the scroll behavior: the panel follows the bottom during a turn, a scroll up releases it, and the jump button returns. - Measured cost of the trigger on a 5.9KB transcript: 1.6µs per call before, 0.08µs after. The old cost grew with the transcript, so a long turn paid it again on each update. - A test covers the trigger. I flattened the signal on purpose to make sure that the test fails, then restored it. - DES-1032 also asked for paced reply text and a guard for an unfinished code fence. Both are dropped. The backend sends the whole reply in one `agent_message_delta` event, so there is no stream to smooth and no fence is ever half-typed. DES-1034 records the backend ask. Storybook: Agent/AgentMessage -> "DES-1032 Each step fades in as it arrives" 🤖 Generated with [Claude Code](https://claude.com/claude-code) (cherry picked from commit aabda32)
- remove elapsed-time text from the agent work summary and activity rows - stop deriving duration data in the presentation model while retaining raw timing for diagnostics - remove the unused workflow duration formatter and update focused coverage - `pnpm test:unit src/workbench/extensions/agent/components/agent/message/WorkSummary.test.ts src/workbench/extensions/agent/services/agent/agentActivityRows.test.ts` - `pnpm format:check` - `pnpm typecheck` - targeted ESLint - `pnpm knip` - `pnpm locale:check` Linear: [PM-1238](https://linear.app/comfy/issue/PM-1238/remove-timing-information-from-agent-workflow) A Playwright regression is not practical for this presentation-only change because reaching the timed activity state requires an authenticated hosted agent turn and backend streaming events that the browser harness does not provide deterministically. The focused component tests render timed thinking/tool parts directly and assert that neither row-level durations nor an elapsed-time summary label are visible. (cherry picked from commit 2e6865b)
## Summary The "Ask Comfy Agent" button had dark text on a dark background in the light theme, so the label was not readable. This change gives the button the standard button colors, which adapt to each theme. This is a stopgap. #17621 rebuilds this button and replaces the fix. Land this first so the light theme is readable now, because #17621 is a much larger change. ## Changes - **What**: The agent button in the top bar now uses the shared `secondary` button style. This is the same style as the "0 active" button in the action bar. The background, the label, the border, and the Comfy mark all come from theme colors, so each color adapts to the theme. - The label contrast increased from 1.11:1 to 14.76:1 in the light theme. The minimum for text is 4.5:1. - The Comfy mark is now the same color as the label. It was brand yellow in both themes, which is not readable on a light background. One color keeps the button consistent across the two themes. - The dark theme looks almost the same as before. The change is three lines in one file. It adds no color token and no dependency. ## Review Focus - **This conflicts with #17621.** That PR moves the button out of `WorkflowTabs.vue` into a new `AgentEntryButton.vue`. Expect a conflict in `WorkflowTabs.vue` and resolve it in favor of #17621. - The hover style for the border is removed. The border was a strong purple on hover, which does not suit the new quiet border. The background still changes on hover, the same as every other `secondary` button. ## Screenshots  Light <img width="1727" height="963" alt="image" src="https://github.com/user-attachments/assets/0c187c8e-a453-465f-8d42-2b08430f862f" /> Dark <img width="1727" height="963" alt="image" src="https://github.com/user-attachments/assets/4467a6ff-3b33-407e-8c00-87c23409289f" /> (cherry picked from commit 2e178a9)
# Conflicts: # src/workbench/extensions/agent/components/agent/message/AgentMessage.test.ts # src/workbench/extensions/agent/components/agent/message/AgentMessage.vue
#17621) The agent button moves to the far right of the tab bar, and the agent panel moves below the tab bar. The button now sits above the close button of the panel. <img width="652" height="180" alt="Sep-18-2026 10-08-35" src="https://github.com/user-attachments/assets/789f20a4-c0df-4eb0-a1ef-c17df63cfc5a" /> Linear: [DES-1038 \[DES\] Agent button and panel position](https://linear.app/comfyorg/issue/DES-1038/des-agent-button-and-panel-position) - **What**: - The agent button moves after the user avatar, at the far right. - The label changes from "Ask Comfy Agent" to "Agent". The icon changes from the Comfy logo to the lucide `astroid` star. - The button stays visible when the panel is open. A click on it closes the panel. Before, the button disappeared. - The agent panel moves below the tab bar. The tab bar now spans the full window width. - The panel has no background of its own against the canvas. The graph shows around it, so the panel reads as a card on the graph. - App mode gets the same panel position. - If an opaque panel sits next to the agent panel, the agent panel takes back its background and its left border. The parent that lays out both panels decides this and passes it as a prop. - Two separators divide the environment badge, the icon buttons, and the agent button. Each separator disappears with the item that it divides. - The feedback megaphone is 24px, with a 16px icon in muted gray. It was a 32px box with a white icon. - `WorkflowTabs` now renders `TopbarBadges` and `TopbarSubscribeButton` itself. Both views passed the same two components, so the slot is gone. - The i18n key `agent.askComfyAgent` becomes `agent.entryButton`. The other locale files fall back to English until the translation pipeline runs. - **Shared components**: two changes below reach every topbar badge, not only the agent work. - The badge icon is 16px at every screen width. It was 12px on wide screens and 19px on narrow screens. - `server_health_alert.message` arrives in capitals from some backends. `toTitleCase` recases it to "Staging Environment" in `cloudBadges.ts`, at the point that reads the field. - **Canvas spacing**: merged from #17879. The floating canvas UI reads one token. - The toolbars at the top and the bottom of the graph sat 4px from the edge. The agent panel card sat 8px. The two never lined up. Both now read `--comfy-canvas-gutter`, set to 8px. - The graph and the top toolbar drop their right gutter when the agent panel is what sits beside them. A right-hand sidebar or an offside panel keeps it. - The canvas info text (`T:`, `FPS:`) reads the same token and starts level with the graph. It sat 5px from the sidebar. - `renderInfo` offset every line by a hardcoded 5px, so a caller's `x` was never where the text landed. The offset is gone and `x` is now the true left edge. The no-argument default keeps its old position. - **Agent button style**: merged from #17879. - The button takes the outline variant. It was a solid fill. - Its border carries a shine that sweeps right to left, returns faster, then rests. The shine runs only until the panel opens once, then stops for good. - The icon turns one full circle on hover and unwinds on release. - The button moves out of `WorkflowTabs` into `AgentEntryButton.vue`, with a Storybook entry for each state: [Components/Button/AgentEntryButton](https://uy-des-1038-agent-button-int.comfy-storybook.pages.dev/?path=/story/components-button-agententrybutton--default&globals=theme:dark). - `Comfy.AgentPanel.discovered` remembers the first open. The store writes it when the panel becomes visible, not when the open action runs, so a restored panel counts too. - `DockedAgentPanel` takes a `hasOpaqueNeighbor` prop. An earlier version read `rightSidePanelStore.isOpen` instead. That setting is global and persisted, so it leaked into app mode, which has no such panel. It also disagreed with the true neighbor when the sidebar sits on the right, during node selection, and in builder mode. - `toTitleCase` lives next to the one backend field that shouts, not in `TopbarBadge`. `topbarBadges` is a public extension API. A recase in the shared renderer would turn an acronym badge such as "GPU OOM" into "Gpu Oom". - The layout change touches `LiteGraphCanvasSplitterOverlay.vue` and `LinearView.vue`. In both files the tab bar moves out of the workspace column, and the panel becomes a sibling of that column. The two shells stay separate on purpose. What they share is three flex wrappers, and the rest differs. - The graph canvas already spans the full window and runs under the panel. The panel only stopped showing it, so one class removal is enough. - Two tests changed their contract. One pinned the seam border that this PR removes. One pinned the tab bar inside the workspace column. - `renderInfo` is shared drawing code for every canvas. Removing its hidden 5px inset changes what an explicit `x` means. This repo has one such caller. - One test asserts a margin class, against the usual rule. The gutter is a margin, the test environment does no layout, and the class is the whole behavior. A comment in the test records this. - `graph-canvas-gutter` is a test id that exists only so that test has something to query. Testing Library rejects a direct CSS lookup. - The screenshot baselines are stale. The gutter moves the canvas by 4px, so the stored images no longer match. They need a regeneration run before this merges. Inviting state w/ shimmer animation Animates until user clicks <img width="368" height="226" alt="image" src="https://github.com/user-attachments/assets/a178f906-1046-4ab5-a86f-26ad4fcfbb23" /> Active state w/ icon filled <img width="368" height="226" alt="image" src="https://github.com/user-attachments/assets/e062f943-2bf7-4037-be01-aa193da192cb" /> Default state after clicked <img width="368" height="226" alt="image" src="https://github.com/user-attachments/assets/a73e16ae-9985-4d36-aa22-00f6ce4d42a8" /> --------- Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com> (cherry picked from commit bee86d4)
#17339 replaces the "Ran N tool call" activity row with WorkSummary and a "Working..." row, and #18348 drops the step durations, so the turn-lock fixture, the socket-drop spec and the tool-call history spec could no longer find their summary button. Take main's current locators for those three files. Main-only changes there that depend on PRs not on this line are left out: the PM-916 draft test, the entryButton label key, and the promptHistory thread-id list.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1945 passed, 0 failed📊 Browser Reports
🌐 Website E2ETip All tests passed.
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-23T19:25:47.970Z",
"gitSha": "9d7e5ebb7ddccc3246de675722693c89234c3ec8",
"branch": "backport-pm1657-agent-ui-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2006.292999999971,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.996000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 362.05499999999995,
"heapDeltaBytes": 5682772,
"heapUsedBytes": 76485408,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.794000000000001,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2002.916999999968,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.0040000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 335.57899999999995,
"heapDeltaBytes": -12926532,
"heapUsedBytes": 56556244,
"domNodes": -1,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 7.724,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1705.1720000000046,
"styleRecalcs": 74,
"styleRecalcDurationMs": 23.276,
"layouts": 14,
"layoutDurationMs": 3.8729999999999998,
"taskDurationMs": 592.99,
"heapDeltaBytes": -8552672,
"heapUsedBytes": 61006072,
"domNodes": -279,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 102.97,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1709.4809999999825,
"styleRecalcs": 73,
"styleRecalcDurationMs": 24.977,
"layouts": 14,
"layoutDurationMs": 4.298,
"taskDurationMs": 600.987,
"heapDeltaBytes": 4617128,
"heapUsedBytes": 74420536,
"domNodes": -282,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 108.164,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.6749999999806,
"styleRecalcs": 31,
"styleRecalcDurationMs": 11.021999999999998,
"layouts": 6,
"layoutDurationMs": 0.9580000000000001,
"taskDurationMs": 206.92099999999996,
"heapDeltaBytes": 4630512,
"heapUsedBytes": 75400188,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 7.755,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1676.637000000028,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.861,
"layouts": 6,
"layoutDurationMs": 1.102,
"taskDurationMs": 241.07299999999998,
"heapDeltaBytes": 4719136,
"heapUsedBytes": 75800060,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.612999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 431.61699999996017,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.372999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 296.17199999999997,
"heapDeltaBytes": 18405252,
"heapUsedBytes": 88435120,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 103.936,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 538.1020000000376,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.117,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 318.25600000000003,
"heapDeltaBytes": 17829344,
"heapUsedBytes": 87922504,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 110.682,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2008.4690000000478,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.651999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 367.27799999999996,
"heapDeltaBytes": 8762340,
"heapUsedBytes": 85251136,
"domNodes": -268,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 22.565,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2019.7919999999954,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.329999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 370.18600000000004,
"heapDeltaBytes": 9581436,
"heapUsedBytes": 85979416,
"domNodes": -264,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 23.63200000000001,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2106.0580000000186,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.313999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1065.445,
"heapDeltaBytes": 23639672,
"heapUsedBytes": 89589452,
"domNodes": -270,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 545.3130000000001,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2285.363000000018,
"styleRecalcs": 68,
"styleRecalcDurationMs": 14.258,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1135.5300000000002,
"heapDeltaBytes": 12807592,
"heapUsedBytes": 90022568,
"domNodes": -270,
"jsHeapTotalBytes": -139264,
"scriptDurationMs": 567.9879999999999,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3134.6770000000106,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.43,
"layouts": 60,
"layoutDurationMs": 12.495000000000001,
"taskDurationMs": 1121.539,
"heapDeltaBytes": 13623480,
"heapUsedBytes": 81690392,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 525.474,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3127.7299999999855,
"styleRecalcs": 66,
"styleRecalcDurationMs": 14.696,
"layouts": 60,
"layoutDurationMs": 12.943,
"taskDurationMs": 1157.477,
"heapDeltaBytes": -2615880,
"heapUsedBytes": 75750944,
"domNodes": -271,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 496.547,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2202.3510000000215,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.72,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1221.7530000000002,
"heapDeltaBytes": 13846732,
"heapUsedBytes": 81411584,
"domNodes": 8,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 597.8380000000001,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2250.0909999999976,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.297999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1218.584,
"heapDeltaBytes": 16686780,
"heapUsedBytes": 97337720,
"domNodes": 12,
"jsHeapTotalBytes": 5398528,
"scriptDurationMs": 607.6550000000001,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 1998.9799999999605,
"styleRecalcs": 4,
"styleRecalcDurationMs": 2.271000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 323.84499999999997,
"heapDeltaBytes": 21683256,
"heapUsedBytes": 88693680,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 24.061,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.7239999999492,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.200000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.576,
"heapDeltaBytes": 10082332,
"heapUsedBytes": 88060172,
"domNodes": -266,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 26.99599999999999,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 419.1509999999994,
"styleRecalcs": 49,
"styleRecalcDurationMs": 10.345,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 267.93600000000004,
"heapDeltaBytes": 13883080,
"heapUsedBytes": 86419644,
"domNodes": 24,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 88.91799999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 463.1520000000364,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.735000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 292.414,
"heapDeltaBytes": 15074356,
"heapUsedBytes": 87734176,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 99.423,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2003.5550000000057,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.873000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 289.19700000000006,
"heapDeltaBytes": -4915336,
"heapUsedBytes": 68339792,
"domNodes": -298,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 5.051,
"eventListeners": -238,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.5230000000115,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.961,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 339.763,
"heapDeltaBytes": -9721608,
"heapUsedBytes": 61994692,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.852000000000001,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1676.8500000000017,
"styleRecalcs": 77,
"styleRecalcDurationMs": 24.214,
"layouts": 18,
"layoutDurationMs": 5.119000000000001,
"taskDurationMs": 551.526,
"heapDeltaBytes": -7998780,
"heapUsedBytes": 64501268,
"domNodes": -296,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 80.32800000000002,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.5170000000094,
"styleRecalcs": 77,
"styleRecalcDurationMs": 23.792999999999996,
"layouts": 18,
"layoutDurationMs": 4.62,
"taskDurationMs": 575.27,
"heapDeltaBytes": -9158964,
"heapUsedBytes": 63367020,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 82.25299999999999,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 799.982,
"styleRecalcs": 20,
"styleRecalcDurationMs": 21.827999999999992,
"layouts": 16,
"layoutDurationMs": 10.555,
"taskDurationMs": 560.143,
"heapDeltaBytes": 19114060,
"heapUsedBytes": 109646368,
"domNodes": 13751,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 18.332999999999995,
"eventListeners": 2385,
"totalBlockingTimeMs": 60,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8185.8270000000175,
"styleRecalcs": 250,
"styleRecalcDurationMs": 42.466,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3723.3450000000003,
"heapDeltaBytes": 1024768,
"heapUsedBytes": 77017660,
"domNodes": -274,
"jsHeapTotalBytes": 122880,
"scriptDurationMs": 1791.353,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9438.968999999986,
"styleRecalcs": 249,
"styleRecalcDurationMs": 42.448,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4397.396000000001,
"heapDeltaBytes": 19400888,
"heapUsedBytes": 95865436,
"domNodes": -270,
"jsHeapTotalBytes": -663552,
"scriptDurationMs": 2070.4510000000005,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 12318.798000000015,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11497.512,
"heapDeltaBytes": -34187032,
"heapUsedBytes": 178507892,
"domNodes": -8068,
"jsHeapTotalBytes": -20058112,
"scriptDurationMs": 164.112,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12444.186999999944,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11642.468,
"heapDeltaBytes": -38284328,
"heapUsedBytes": 176399448,
"domNodes": -8068,
"jsHeapTotalBytes": -14151680,
"scriptDurationMs": 188.831,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14408.112000000017,
"styleRecalcs": 70,
"styleRecalcDurationMs": 13.990000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13924.158,
"heapDeltaBytes": -40021964,
"heapUsedBytes": 178872612,
"domNodes": -8068,
"jsHeapTotalBytes": -14639104,
"scriptDurationMs": 661.83,
"eventListeners": -14929,
"totalBlockingTimeMs": 31,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 14311.690999999995,
"styleRecalcs": 69,
"styleRecalcDurationMs": 12.762999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13681.730000000001,
"heapDeltaBytes": -27964588,
"heapUsedBytes": 190128824,
"domNodes": -8068,
"jsHeapTotalBytes": -14483456,
"scriptDurationMs": 609.38,
"eventListeners": -14931,
"totalBlockingTimeMs": 31,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4508.721000000037,
"styleRecalcs": 20,
"styleRecalcDurationMs": 55.306,
"layouts": 20,
"layoutDurationMs": 25.227,
"taskDurationMs": 4412.231999999999,
"heapDeltaBytes": -53365136,
"heapUsedBytes": 171058308,
"domNodes": -8068,
"jsHeapTotalBytes": 6348800,
"scriptDurationMs": 74.47899999999998,
"eventListeners": -14929,
"totalBlockingTimeMs": 110,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4478.574000000094,
"styleRecalcs": 20,
"styleRecalcDurationMs": 65.52999999999997,
"layouts": 20,
"layoutDurationMs": 22.182999999999993,
"taskDurationMs": 4312.835,
"heapDeltaBytes": -49483716,
"heapUsedBytes": 177460324,
"domNodes": -8072,
"jsHeapTotalBytes": 6942720,
"scriptDurationMs": 112.766,
"eventListeners": -14931,
"totalBlockingTimeMs": 12,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6305.372999999974,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5984.195999999999,
"heapDeltaBytes": 8459480,
"heapUsedBytes": 189436576,
"domNodes": 0,
"jsHeapTotalBytes": -39845888,
"scriptDurationMs": 86.57699999999996,
"eventListeners": 16,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6248.8610000000335,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5899.343999999999,
"heapDeltaBytes": 8133836,
"heapUsedBytes": 179499152,
"domNodes": 0,
"jsHeapTotalBytes": -15466496,
"scriptDurationMs": 89.38600000000002,
"eventListeners": -6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 70.66100000002962,
"styleRecalcs": 5,
"styleRecalcDurationMs": 10.482000000000001,
"layouts": 2,
"layoutDurationMs": 0.934,
"taskDurationMs": 47.11,
"heapDeltaBytes": 3013556,
"heapUsedBytes": 71738636,
"domNodes": 125,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 4.026,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 421.86900000001515,
"styleRecalcs": 13,
"styleRecalcDurationMs": 13.673,
"layouts": 2,
"layoutDurationMs": 0.481,
"taskDurationMs": 73.204,
"heapDeltaBytes": 4744676,
"heapUsedBytes": 73269168,
"domNodes": 121,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.568,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## cloud/1.54 #18622 +/- ##
=============================================
Coverage ? 82.18%
=============================================
Files ? 2537
Lines ? 132397
Branches ? 35631
=============================================
Hits ? 108806
Misses ? 23078
Partials ? 513
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
Backport adaptation: test-only. The #17621 pick renamed this spec's entry-button lookups (:388, :499) to agent.entryButton ("Agent") without exact: true. The name then matched 2 buttons at :499, and Playwright's strict mode failed the test. Main's copy of this spec passes exact: true; this matches it.
Backport adaptation: runtime. #17621 puts the canvas info text at the sidebar's right edge plus the canvas gutter, which assumes main's renderInfo draws the text at x. The release line's renderInfo still draws it 5px in from x, and the litegraph change stays out of this branch. So the HUD landed 5px to the right of main, and canvasSettings.spec.ts:32 failed its screenshot. Subtract the inset here until that change reaches the line.
Replace Agent's shadow theme with shared design-system tokens and controls. Fixes [FE-2219](https://linear.app/comfyorg/issue/FE-2219/refactor-delete-agents-shadow-design-system). - Remove Agent color/radius aliases and the global stylesheet import; keep animations and normalization in the Agent stylesheet. - Reuse shared tooltips, popovers, inputs, and action buttons while preserving required Reka interactions. - Add Storybook states and keep tests focused on behavior, not specific styles. Shared tooltip compatibility, input focus/selection, portaled controls, and reduced-motion behavior. Local checks passed: 279 component tests; cloud, standalone-mode, and Storybook builds; typecheck; lint; formatting; Knip. Light and dark Storybook states were visually inspected. Figma MCP was unavailable. Authenticated cloud and standalone app flows were not exercised.  --------- Co-authored-by: Amp <amp@ampcode.com> (cherry picked from commit d3ab7cb)
Backport adaptation: runtime. The line's run-mode menu is #18265, the cloud/1.54 carrier of #18115. It keeps the DropdownMenu and the store calls, but still styles them with the old agent tooltip helper, raw buttons and surface classes. Main's final file (146ef34, still the blob on origin/main) is the same DropdownMenu with the same behaviour, styled with the shared Button and design tokens. This takes main's file unchanged.
Backport adaptation: runtime. #17471 deletes agentTheme.css. Two CrdtDevPanel elements the line carries were outside its diff and still used the removed agent tokens, so they would have rendered unstyled: - The copy-failure alert now uses main's own class for it, text-danger. - The manual-copy textarea exists only on the line. It now uses the shared tokens that agentTheme.css aliased, so it looks the same.
Stacked on #17471. Use shared Button variants for user-facing Agent controls instead of bespoke control styles. Continues [FE-2219](https://linear.app/comfyorg/issue/FE-2219/refactor-delete-agents-shadow-design-system). - Replace native action buttons and compose Reka triggers with the shared Button. - Remove duplicated hover, focus, and disabled styling. Keep feature-specific layout and existing interactions. - No new shared APIs, dependencies, or style assertions. - Rename focus restoration, run-mode radio selection, clipboard actions, and audio controls. - CRDT debug-panel buttons, selects, and textarea remain follow-up work. Specialized media thumbnails, reference chips, and editor-generated DOM are unchanged. - Passed 310 tests across 28 files, typecheck, lint, formatting, Knip, and the Storybook build. Browser checks cover light/dark states, rename focus, selection, copy feedback, and audio playback/mute. - Live Figma access was unavailable; this uses existing shared component APIs and rendered Storybook checks. [Storybook preview](https://t-03gunii1zj3p8h7t18j5kuq9s-p27802.onamp.dev/) --------- Co-authored-by: Amp <amp@ampcode.com> (cherry picked from commit 48715f5)
## Summary Backports six merged `main` Agent fixes to `cloud/1.54` and repairs the `agentCanvasLagsToolCallCompletion` e2e spec that #18586 landed with, which fails `typecheck:browser` on the current branch tip. ## Changes - **What**: `cherry-pick -x` of #17568, #17628, #16491, #18453, #17767 and #18603, in `main` merge order. The spec fix uses `entryButton` and the "Worked for" summary instead of the labels #18622 removed, and adds `HostDoc.graph()` to the conversation host-doc fixture. #18391 itself is already on the line via #18586 and is unchanged here. - **Excluded**: #18066 (Christian's request), #16908 (refactor), #18375 (needs its `src/lib/litegraph/` half). ## Review Focus - #18603 forwards two new onboarding telemetry events for every user, not only Agent users. - `AgentPanelRoot.vue` changes come from #16491 and #17767 on top of #18391's merged code; `useAgentCrdtFollower.ts` is identical to the tip. - Merging the tip resolved two conflicts: the spec (this copy) and `AgentPanelRoot.test.ts` (the tip's #18391 test plus these picks). - Second batch (#16856, #18204, #18229, #17327, #18251, #16985, #18224) follows on this tip. Linear: [PM-1656](https://linear.app/comfyorg/issue/PM-1656) ## Screenshots (if applicable) No new visuals; #17568 and #17767 were reviewed on `main`. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Maanil Verma <vermaMaanil97@gmail.com> Co-authored-by: Christian Byrne <cbyrne@comfy.org> Co-authored-by: Alexander Brown <drjkl@comfy.org>
## Summary Ports to `core/1.54` every merged `main` Agent fix that `cloud/1.54` carries and core does not (the Agent UI catch-up from #18622, the cloud-only CRDT and workflow fixes, and the round-2 fixes), so both release lines are symmetric ahead of the local-agent rollout. ## Changes - **What**: `cherry-pick -x`, in three groups: - Agent UI, as in #18622: #17339, #17908, #17420, #18348, #18043, #17621 (without its two `src/lib/litegraph/` files; a 5 px HUD offset in `SideToolbar.vue` compensates), #17471, #17690. - Cloud-only fixes: #18063, #18073, #18064, #18033, #18289, #18604, #18616, #18376. - Round 2: #17568, #17628, #16491, #18453, #17767, #18431 (from #18571), #18603. - **Already on `core/1.54`**: #17439 (#18161), #17912 (#18186), #18391 (#18595). - **Excluded**: #17730 (core lacks its three files), #18421 (dead code on core builds), #16917 (conflicts with later core changes), #18066 (Christian's request), #18375 and #18251 (need their litegraph hunks). ## Review Focus - On this line the Agent panel registers only in cloud builds (`src/extensions/core/index.ts:41-44`); the shared chrome from #17621 and #17471 and the host telemetry from #18376 and #18603 ship in every build. - `HostTelemetrySink.ts` and its test equal `main`'s files (#18376, then #18603 on top). - #18064: `agentConversationHostDoc.test.ts` keeps this line's file; #18063's new test uses `main`'s version (multi-player 0.3.x stamps). - Supersedes #18571 and the closed #18637. Linear: [PM-1657](https://linear.app/comfyorg/issue/PM-1657), [PM-1656](https://linear.app/comfyorg/issue/PM-1656) ## Screenshots (if applicable) Visual changes are the ones reviewed on `main` and carried to cloud in #18622. --------- Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: ryan-di <ryan.weihao.di@gmail.com> Co-authored-by: jaeone lee <89377375+jaeone94@users.noreply.github.com> Co-authored-by: Christian Byrne <cbyrne@comfy.org> Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Comfy Org PR Bot <snomiao+comfy-pr@gmail.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Hunter <huntcsg@users.noreply.github.com> Co-authored-by: Maanil Verma <vermaMaanil97@gmail.com>
Summary
Backports the Agent UI changes that staging and prod are missing to
cloud/1.54, as one cherry-pick catalogue: the folded trace, the shared design system and buttons for the Agent controls, the consent card redesign, and the moved Agent button with the nested panel. Staging picks it up with the nextcloud/1.54deploy; prod gets it at the next production promotion ofcloud/1.54.Linear: PM-1657, PM-1656
Changes
cherry-pick -xof 8 mergedmainPRs, inmainmerge order:src/lib/litegraph/files (see Review Focus)cloud/1.54from the same request, so not repeated here: feat(FE-2042): add four-step Agent onboarding tour #17439 (via Catalogue-wide Agent backports for cloud/1.54 #18162), feat(agent): offer the consent card without a button click #17912 (via [backport cloud/1.54] Agent catalogue sweep 2 #18185), feat(agent): show graph activity while the agent writes nodes #17730 (via [backport cloud/1.54] feat(agent): report graph activity without moving the camera #18550).package.jsonand the lockfile are unchanged apart from the merged 1.54.15 bump (1.54.15 #18569).Review Focus
src/lib/litegraph/files are held out (agent fixes keep litegraph unchanged); a 5 px HUD offset inSideToolbar.vuecompensates. Carrying them instead is a one-file follow-up if preferred.Resolution and verification, per source
Resolution
b5401705d8drops a duplicateuseI18ndeclaration left by the feat(agent): fold the finished trace into one summary #17339 pick.cloud/1.54tip keeps main'sAgentMessage.vueand its test, which supersede [backport cloud/1.54] fix(agent): prevent thinking text clipping #18351 and fix(agent): restore working spinner after tools #18367: the working spinner after tools is feat(agent): fold the finished trace into one summary #17339's composing row, covered byAgentMessage.test.ts"marks the turn as still working between the last tool and the first reply token", and the thinking text uses the trace'stext-sm/5.askComfyAgenttoentryButton, since feat(agent): move the agent button to the far right and nest the panel #17621 removes that label; its GraphCanvas dock tests set linear mode after mount on this line's test setup.101c8f19cd(test-only): three agent browser tests move off the removed "Ran N tool calls" button to main's WorkSummary locators.09236f342d(test-only):exact: trueon the autogrow spec's two entry-button lookups, as on main, since "Agent" now also prefixes the targeted workflow tab's button name.d49b4ddf12(runtime):SideToolbar.vueplaces the canvas info HUD atsidebarRight + canvasGutter() - 5. The release line'srenderInfokeeps a 5 px text inset that main removed in feat(agent): move the agent button to the far right and nest the panel #17621's litegraph half, so this offset lands the HUD where main puts it. It goes away when that litegraph change reaches the line.ab65e60731(runtime) takes main's finalRunModePopover.vueas is: main's end state is the DropdownMenu form from fix(agent): apply the run permission choice without a save step #18115, which this line carries via [Cloud 1.54] Apply run permission choice without save step #18265, and the remaining diff was styling only.55e005ed10(runtime) maps the last 2 shadow-theme tokens inCrdtDevPanel. 38 of 42 files carry the source's exact change stream.cloud/1.54tip was merged in twice; the second merge brings the 1.54.15 bump (1.54.15 #18569) with no other change.Verification
git diff --name-only origin/cloud/1.54...HEAD -- ':/src/lib/litegraph/'prints nothing.pnpm typecheckandpnpm typecheck:browserexit 0; 41 unit suites, 563 tests pass; 0 shadow-theme tokens and 0AgentTooltipreferences remain.agentConsent.spec.tspasses 14 of 14 with the change and fails 5 of 14 without it (local run, devtools setup endpoints stubbed).cloud/1.54after that.Screenshots (if applicable)
Visual changes are the ones already reviewed on
mainin #17471, #17690, #17621 and #17908; the e2e screenshot baselines in this PR come from those merges.🤖 Generated with Claude Code