Repository navigation
fix: send the workspace token when downloading a cloud asset - #18421
Conversation
createAssetDownload built a 'fetch' download without a fetch function, so
downloadFileAsBlob fell back to bare fetch. That sends no Authorization
header, so /api/assets/{id}/content authenticated by session cookie, which
resolves to the caller's personal workspace — an asset owned by any other
workspace answered 404 and the download failed.
Route it through api.fetchApi, which carries the selected workspace's
token, matching resolveReplyAssetDownload in the agent download path.
apiURL is idempotent for /api-prefixed routes and api_base is '' on cloud,
so passing the built content URL back through it is a no-op.
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2092 passed, 0 failed · 1 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since f34a7bf24a988127b06efd08a0a92861d9f18b6c
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 9.96 MB gzip 🔴 +268 kBDetailsSummary
Category Glance App Entry Points — 3.87 kB (baseline 3.73 kB) • 🔴 +138 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.44 MB (baseline 1.43 MB) • 🔴 +13.6 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 124 kB) • 🔴 +8.02 kBTop-level views, pages, and routed surfaces
Status: 17 added / 16 removed / 1 unchanged Panels & Settings — 639 kB (baseline 621 kB) • 🔴 +17.6 kBConfiguration panels, inspectors, and settings screens
Status: 28 added / 27 removed User & Accounts — 37.9 kB (baseline 27.8 kB) • 🔴 +10.1 kBAuthentication, profile, and account management bundles
Status: 9 added / 9 removed / 2 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • 🔴 +740 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed UI Components — 123 kB (baseline 117 kB) • 🔴 +6.31 kBReusable component library chunks
Status: 16 added / 15 removed Data & Services — 3.91 MB (baseline 3.6 MB) • 🔴 +309 kBStores, services, APIs, and repositories
Status: 16 added / 16 removed Utilities & Hooks — 577 kB (baseline 559 kB) • 🔴 +18.7 kBHelpers, composables, and utility bundles
Status: 31 added / 29 removed / 7 unchanged Vendor & Third-Party — 17.4 MB (baseline 18.1 MB) • 🟢 -692 kBExternal libraries and shared vendor chunks
Status: 11 added / 11 removed / 7 unchanged Other — 17.8 MB (baseline 16.4 MB) • 🔴 +1.42 MBBundles that do not match a named category
Status: 179 added / 173 removed / 123 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-22T10:58:40.455Z",
"gitSha": "659efa45a3a21d67a4d12baab3e7e2831d8dad99",
"branch": "glary/authenticate-cloud-asset-downloads",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2016.7230000000131,
"styleRecalcs": 11,
"styleRecalcDurationMs": 9.166,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.93899999999996,
"heapDeltaBytes": 7829952,
"heapUsedBytes": 75349628,
"domNodes": -258,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 8.077999999999998,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2017.0990000000302,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.703000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.4789999999999,
"heapDeltaBytes": -6459796,
"heapUsedBytes": 60950452,
"domNodes": -261,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 8.736,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1776.6399999999862,
"styleRecalcs": 45,
"styleRecalcDurationMs": 15.469000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 808.14,
"heapDeltaBytes": 9065868,
"heapUsedBytes": 76525844,
"domNodes": -260,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 162.987,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1787.1059999999943,
"styleRecalcs": 43,
"styleRecalcDurationMs": 14.731,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 786.554,
"heapDeltaBytes": -2246208,
"heapUsedBytes": 60075468,
"domNodes": -263,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 165.562,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1666.057999999964,
"styleRecalcs": 33,
"styleRecalcDurationMs": 15.686000000000002,
"layouts": 6,
"layoutDurationMs": 0.9959999999999999,
"taskDurationMs": 325.90200000000004,
"heapDeltaBytes": 3177828,
"heapUsedBytes": 70751304,
"domNodes": 81,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.322000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1698.3890000000201,
"styleRecalcs": 28,
"styleRecalcDurationMs": 14.108999999999998,
"layouts": 6,
"layoutDurationMs": 1.1750000000000003,
"taskDurationMs": 315.485,
"heapDeltaBytes": 2385480,
"heapUsedBytes": 63291140,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.372,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 625.251999999989,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.57,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.33,
"heapDeltaBytes": 18861336,
"heapUsedBytes": 86387256,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 165.139,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 642.4819999999727,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.85,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 454.90799999999996,
"heapDeltaBytes": 18945960,
"heapUsedBytes": 86468200,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 172.843,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1176.3749999999504,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 829.6370000000001,
"heapDeltaBytes": 12213976,
"heapUsedBytes": 85358180,
"domNodes": 0,
"jsHeapTotalBytes": 19558400,
"scriptDurationMs": 71.882,
"eventListeners": 0,
"totalBlockingTimeMs": 562,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1145.1240000000098,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 813.3340000000001,
"heapDeltaBytes": 10934924,
"heapUsedBytes": 88702436,
"domNodes": 0,
"jsHeapTotalBytes": 20082688,
"scriptDurationMs": 66.636,
"eventListeners": 0,
"totalBlockingTimeMs": 539,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 861.3500000000158,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.0740000000002,
"heapDeltaBytes": 14254996,
"heapUsedBytes": 90438424,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 165.487,
"eventListeners": 0,
"totalBlockingTimeMs": 226,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.535999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.5199999999997,
"heapDeltaBytes": 15795620,
"heapUsedBytes": 92564712,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 165.37800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 226,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11356.50000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10382.652,
"heapDeltaBytes": -7883448,
"heapUsedBytes": 67651548,
"domNodes": -6,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 8621.955,
"eventListeners": 0,
"totalBlockingTimeMs": 1463,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10099.918000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9195.983,
"heapDeltaBytes": 10515544,
"heapUsedBytes": 92242340,
"domNodes": -16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 7848.054,
"eventListeners": 0,
"totalBlockingTimeMs": 1077,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10707.310000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9867.685,
"heapDeltaBytes": 17678348,
"heapUsedBytes": 93835764,
"domNodes": -10,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 8186.294,
"eventListeners": 0,
"totalBlockingTimeMs": 1182,
"frameDurationMs": 19.996666666666655,
"p95FrameDurationMs": 49.89999999999782
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10424.51200000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9547.057999999999,
"heapDeltaBytes": 6055920,
"heapUsedBytes": 81353232,
"domNodes": -4,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 7901.495,
"eventListeners": 0,
"totalBlockingTimeMs": 957,
"frameDurationMs": 20,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2044.3460000000186,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.630000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.3330000000001,
"heapDeltaBytes": -4616396,
"heapUsedBytes": 82593784,
"domNodes": -243,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 36.86599999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000007,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2037.4090000000251,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.729000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 565.6370000000001,
"heapDeltaBytes": -3552404,
"heapUsedBytes": 83667288,
"domNodes": -242,
"jsHeapTotalBytes": -1282048,
"scriptDurationMs": 32.111000000000004,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2346.5530000000285,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.489000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1663.351,
"heapDeltaBytes": -1885680,
"heapUsedBytes": 80640280,
"domNodes": -245,
"jsHeapTotalBytes": 253952,
"scriptDurationMs": 879.47,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2300.1410000000533,
"styleRecalcs": 69,
"styleRecalcDurationMs": 16.368000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1670.573,
"heapDeltaBytes": -22728516,
"heapUsedBytes": 65412204,
"domNodes": -257,
"jsHeapTotalBytes": 1863680,
"scriptDurationMs": 844.354,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3477.4509999999736,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.129999999999997,
"layouts": 60,
"layoutDurationMs": 13.065999999999999,
"taskDurationMs": 1656.5780000000002,
"heapDeltaBytes": 8108064,
"heapUsedBytes": 74151404,
"domNodes": 6,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 778.946,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3527.0340000000715,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.273000000000001,
"layouts": 60,
"layoutDurationMs": 12.990000000000002,
"taskDurationMs": 1689.3100000000002,
"heapDeltaBytes": 7906604,
"heapUsedBytes": 73779716,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 797.71,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3037.229000000025,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.779999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1858.907,
"heapDeltaBytes": 20951072,
"heapUsedBytes": 87258452,
"domNodes": 6,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 972.4829999999998,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2824.261999999976,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.038999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1713.689,
"heapDeltaBytes": 9118820,
"heapUsedBytes": 74862120,
"domNodes": 8,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 965.158,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2003.6499999999933,
"styleRecalcs": 7,
"styleRecalcDurationMs": 4.992999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 540.0440000000001,
"heapDeltaBytes": 20263168,
"heapUsedBytes": 84637268,
"domNodes": -245,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.12799999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2018.748999999957,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.260999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 542.0600000000001,
"heapDeltaBytes": -4896072,
"heapUsedBytes": 84199400,
"domNodes": -244,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 32.452000000000005,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 573.6590000000206,
"styleRecalcs": 48,
"styleRecalcDurationMs": 10.694000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.514,
"heapDeltaBytes": 13716364,
"heapUsedBytes": 83638916,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 143.471,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 577.9919999999947,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.097,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.262,
"heapDeltaBytes": 13731616,
"heapUsedBytes": 83498292,
"domNodes": 22,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 144.71800000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 1989.6150000000148,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.139,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.34399999999994,
"heapDeltaBytes": -13186416,
"heapUsedBytes": 56435324,
"domNodes": -276,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.832000000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2004.2230000000245,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.014000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.77599999999995,
"heapDeltaBytes": -619276,
"heapUsedBytes": 62378560,
"domNodes": -274,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.259000000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1718.4009999999716,
"styleRecalcs": 47,
"styleRecalcDurationMs": 13.342,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 717.705,
"heapDeltaBytes": -2879800,
"heapUsedBytes": 66948380,
"domNodes": -277,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 102.533,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1716.109000000074,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.583,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 717.5120000000001,
"heapDeltaBytes": 3403220,
"heapUsedBytes": 73164220,
"domNodes": -275,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 103.44,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 933.1370000001016,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.356999999999996,
"layouts": 5,
"layoutDurationMs": 13.046999999999999,
"taskDurationMs": 696.3519999999999,
"heapDeltaBytes": -6379616,
"heapUsedBytes": 85216328,
"domNodes": 13667,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 28.294,
"eventListeners": 2383,
"totalBlockingTimeMs": 140,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "viewport-pan-sweep",
"durationMs": 8282.516000000043,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.194,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5692.142000000001,
"heapDeltaBytes": -6940336,
"heapUsedBytes": 80117700,
"domNodes": -242,
"jsHeapTotalBytes": -532480,
"scriptDurationMs": 2721.376,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8360.799000000043,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.288000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5788.967,
"heapDeltaBytes": -10495376,
"heapUsedBytes": 76827468,
"domNodes": -240,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 2838.286,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12661.002999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12103.837,
"heapDeltaBytes": -38231236,
"heapUsedBytes": 182254336,
"domNodes": -8061,
"jsHeapTotalBytes": -10027008,
"scriptDurationMs": 215.036,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333326,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16792.48800000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16358.389,
"heapDeltaBytes": -31410644,
"heapUsedBytes": 194103556,
"domNodes": -8061,
"jsHeapTotalBytes": -9707520,
"scriptDurationMs": 263.526,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20801.874999999996,
"styleRecalcs": 169,
"styleRecalcDurationMs": 17.05999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20386.871,
"heapDeltaBytes": -55878732,
"heapUsedBytes": 169595044,
"domNodes": -8061,
"jsHeapTotalBytes": -17047552,
"scriptDurationMs": 909.8159999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 48,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20821.956,
"styleRecalcs": 175,
"styleRecalcDurationMs": 17.348000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20458.692,
"heapDeltaBytes": -57615776,
"heapUsedBytes": 180292960,
"domNodes": -8062,
"jsHeapTotalBytes": -17235968,
"scriptDurationMs": 919.28,
"eventListeners": -14928,
"totalBlockingTimeMs": 77,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4716.284999999971,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.49000000000001,
"layouts": 20,
"layoutDurationMs": 23.226999999999997,
"taskDurationMs": 4594.448,
"heapDeltaBytes": -40723632,
"heapUsedBytes": 193469056,
"domNodes": -8062,
"jsHeapTotalBytes": 23318528,
"scriptDurationMs": 90.52699999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 82,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 6001.045999999974,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.57,
"layouts": 20,
"layoutDurationMs": 21.224999999999994,
"taskDurationMs": 5910.878,
"heapDeltaBytes": -22361212,
"heapUsedBytes": 197797232,
"domNodes": -8062,
"jsHeapTotalBytes": 14524416,
"scriptDurationMs": 104.13399999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 324,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8394.160000000056,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8173.101999999998,
"heapDeltaBytes": 5593088,
"heapUsedBytes": 198167416,
"domNodes": 0,
"jsHeapTotalBytes": -27000832,
"scriptDurationMs": 124.05399999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8447.946000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8202.394,
"heapDeltaBytes": -982264,
"heapUsedBytes": 168889804,
"domNodes": 0,
"jsHeapTotalBytes": -10747904,
"scriptDurationMs": 153.88600000000008,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 473.16799999998693,
"styleRecalcs": 20,
"styleRecalcDurationMs": 24.791,
"layouts": 4,
"layoutDurationMs": 1.82,
"taskDurationMs": 133.27600000000004,
"heapDeltaBytes": 5311668,
"heapUsedBytes": 67244852,
"domNodes": 155,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 16.331,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 114.60499999998319,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.402,
"layouts": 3,
"layoutDurationMs": 0.9179999999999999,
"taskDurationMs": 79.77600000000001,
"heapDeltaBytes": 3096336,
"heapUsedBytes": 68683328,
"domNodes": 109,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.056,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 3 remain after this review. 📝 WalkthroughWalkthroughCloud asset downloads now use ChangesAsset download handling
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to Cloud asset downloads now use workspace authentication while OSS downloads remain unchanged. The focused coverage addresses the new callback behavior, so the change is ready to merge. Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The title and commit subject use the bug-fix signal
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
Thanks — this is the "review in progress" placeholder, so there are no findings to address yet. I'll respond to each one once the review lands. Two pointers for whoever reviews (human or bot), since both look like dead code at a glance and both are load-bearing: 1. The fetch: (route) => api.fetchApi(route)It reads like an identity wrapper, but deleting it is the bug this PR fixes. 2. Feeding a built URL back through
|
|
Addressing the failing "End-to-end regression coverage for fixes" check. The signal is correct — Why a
|
authorization on /api/assets/{id}/content |
result | |
|---|---|---|
| without fix | absent | falls back to cookie auth |
| with fix | Bearer …, JWT workspace_id matching the asset's row in the DB |
302 |
Plus the unit test (red before, green after), 1995 frontend unit tests, vue-tsc clean, lint clean.
@coderabbitai — note that my tooling cannot edit a PR description, only post comments, so this explanation lives here. A maintainer can paste it into the body if the check needs it there.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18421 +/- ##
==========================================
+ Coverage 83.35% 84.33% +0.98%
==========================================
Files 2985 2283 -702
Lines 147072 129886 -17186
Branches 39914 33209 -6705
==========================================
- Hits 122586 109538 -13048
+ Misses 23204 20053 -3151
+ Partials 1282 295 -987
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 712 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Obsolete bot review: the current head has successful CI and CodeRabbit status, with no unresolved bot findings.
AustinMroz
left a comment
There was a problem hiding this comment.
Change and test are good and minimal. I suggest merging as is.
That this is an established footgun with surrounding boilerplate is slightly concerning. I'll make a note to do some more digging in the future. Perhaps we can set the default fetch implementation for downloadFileAsBlob to be api.fetch
|
Thanks @AustinMroz. Agreed on the footgun — leaving the PR as-is per your suggestion, but I dug into the default- Short version: defaulting Why the default is unsafe as statedFirst, a naming detail: there's no apiURL(route: string): string {
if (route.startsWith('/api')) return this.api_base + route
return this.api_base + '/api' + route
}That matters because
There's also a layering cost: A cheaper fix that closes the same holeMake I checked rather than assumed: flipping That also pairs naturally with the duplication you spotted: the two constructors could share one builder, which is the "surrounding boilerplate" that let this drift in the first place. Happy to put both in a follow-up PR if you want it — just say the word and I'll open one. |
|
@christian-byrne Successfully backported to #18478 |
|
## Summary Ports to `core/1.54` every merged `main` Agent fix that `cloud/1.54` carries and core does not (the Agent UI catch-up from #18622, the cloud-only CRDT and workflow fixes, and the round-2 fixes), so both release lines are symmetric ahead of the local-agent rollout. ## Changes - **What**: `cherry-pick -x`, in three groups: - Agent UI, as in #18622: #17339, #17908, #17420, #18348, #18043, #17621 (without its two `src/lib/litegraph/` files; a 5 px HUD offset in `SideToolbar.vue` compensates), #17471, #17690. - Cloud-only fixes: #18063, #18073, #18064, #18033, #18289, #18604, #18616, #18376. - Round 2: #17568, #17628, #16491, #18453, #17767, #18431 (from #18571), #18603. - **Already on `core/1.54`**: #17439 (#18161), #17912 (#18186), #18391 (#18595). - **Excluded**: #17730 (core lacks its three files), #18421 (dead code on core builds), #16917 (conflicts with later core changes), #18066 (Christian's request), #18375 and #18251 (need their litegraph hunks). ## Review Focus - On this line the Agent panel registers only in cloud builds (`src/extensions/core/index.ts:41-44`); the shared chrome from #17621 and #17471 and the host telemetry from #18376 and #18603 ship in every build. - `HostTelemetrySink.ts` and its test equal `main`'s files (#18376, then #18603 on top). - #18064: `agentConversationHostDoc.test.ts` keeps this line's file; #18063's new test uses `main`'s version (multi-player 0.3.x stamps). - Supersedes #18571 and the closed #18637. Linear: [PM-1657](https://linear.app/comfyorg/issue/PM-1657), [PM-1656](https://linear.app/comfyorg/issue/PM-1656) ## Screenshots (if applicable) Visual changes are the ones reviewed on `main` and carried to cloud in #18622. --------- Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: ryan-di <ryan.weihao.di@gmail.com> Co-authored-by: jaeone lee <89377375+jaeone94@users.noreply.github.com> Co-authored-by: Christian Byrne <cbyrne@comfy.org> Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Comfy Org PR Bot <snomiao+comfy-pr@gmail.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Hunter <huntcsg@users.noreply.github.com> Co-authored-by: Maanil Verma <vermaMaanil97@gmail.com>
PR Created by the Glary-Bot Agent
Fixes the "download failed" half of the staging report: clicking download on a Media Assets card raised
1 download failed, withGET /api/assets/<id>/contentreturning 404 in the console.Root cause
createAssetDownloadbuilt amode: 'fetch'download but never set the optionalfetchfield, sodownloadFileAsBlobfell through to its default — the bare globalfetch(src/base/common/downloadUtil.ts, thefetch: fetchFile = fetchparameter default).A bare same-origin
fetchsends noAuthorizationheader, so/api/assets/{id}/contentauthenticated by session cookie. Cookie auth resolves the caller's personal workspace (resolveCookieUser→UpsertWithPersonalWorkspace), andGetAssetContentscopes its lookup to that workspace, returningASSET_NOT_FOUND→ 404 for an asset owned by any other workspace.This is not 3D-specific — it affects every Media Assets download of an asset outside the user's personal workspace. The reporter hit it on a 3D job because that job is what surfaced the duplicate-output bug fixed in Comfy-Org/cloud#10214.
Change
Route the cloud download through
api.fetchApi, which attaches the selected workspace's Cloud JWT. This mirrorsresolveReplyAssetDownload(src/workbench/extensions/agent/utils/resolveReplyAssetDownload.ts) — the only otherFetchedAssetDownloadproducer, which already ships this exact pattern against the same endpoint. No type or interface change:FetchedAssetDownload.fetchalready existed for precisely this.Passing the built content URL back through
fetchApiis a no-op:apiURLearly-returns for/api-prefixed input, andapi_baseis''on cloud — which is the only branch that takesmode: 'fetch'.Test
fetches a cloud download through the workspace-authenticated clientasserts the download is handed an authenticated fetch and that invoking it reachesapi.fetchApi. Verified red before the change (expected "vi.fn()" to be called with arguments) and green after.Verification
pnpm vitest run src/platform/assets/— 52 files, 799 passed.pnpm vitest run src/base/common/downloadUtil.test.ts src/workbench/extensions/agent— 127 files, 1995 passed.vue-tsc --noEmit— 0 errors. ESLint clean.pnpm formatclean. Pre-commit hook (oxfmt + oxlint --type-aware + eslint + typecheck) passed.Manual browser QA (A/B on a local cloud stack)
Ran the real UI against a locally running cloud backend, logged in as a fresh account, generated an output, and clicked the card's Download button — then reverted the fix and repeated the identical click:
authorizationheader on/api/assets/{id}/contentBearer eyJ…, JWT payloadworkspace_idmatching the asset'sworkspace_idin the DBThe header is exactly what was missing. The local sandbox cannot complete the second leg (the 302 to the signed GCS URL returns 403), but that is environmental and not caused by this change: it reproduces identically with the fix reverted, and a plain server-side
curlof the same signed URL — no browser, no CORS, no headers — also returns 403 with a GCS signature error, i.e. the sandbox cannot mint valid signatures for the shared test bucket.That A/B also closes the one risk worth flagging: the added
Authorizationheader produces no behavioural difference on the cross-origin redirect leg. Worth one manual download on staging after deploy to confirm the GCS preflight admits it there too — the shippedresolveReplyAssetDownloadprecedent suggests it will.