Repository navigation
[backport core/1.54] test: route objectInfo through cloud boot mocks so 'server' reaches the backend catalog - #18860
Conversation
…so 'server' reaches the backend catalog Fixture subset of #17730 (main 7806755), already on cloud/1.54 via #18550. bootAgentApp previously dropped objectInfo before calling mockCloudBoot, so mockCloudBoot registered an empty {} /api/object_info route last and every harness-registered node-def route was shadowed. Test infrastructure only; the product feature in #17730 stays excluded (as recorded in #18631).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1954 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-25T14:18:39.751Z",
"gitSha": "7321eff5924fa68b6aa4db03c9452d3e54ef2cd4",
"branch": "backport-17730-fixture-objectinfo-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2081.678000000011,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.319999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 619.5240000000001,
"heapDeltaBytes": -12784300,
"heapUsedBytes": 57053072,
"domNodes": 0,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 11.015999999999998,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2055.04499999995,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.479000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 547.9150000000001,
"heapDeltaBytes": -12112344,
"heapUsedBytes": 57958492,
"domNodes": -278,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 10.925,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1829.3559999999616,
"styleRecalcs": 75,
"styleRecalcDurationMs": 28.78,
"layouts": 14,
"layoutDurationMs": 4.393,
"taskDurationMs": 925.841,
"heapDeltaBytes": 13164020,
"heapUsedBytes": 84153960,
"domNodes": -280,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 151.85299999999998,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1890.4400000000123,
"styleRecalcs": 78,
"styleRecalcDurationMs": 30.945999999999998,
"layouts": 14,
"layoutDurationMs": 4.043,
"taskDurationMs": 948.0379999999999,
"heapDeltaBytes": -2835812,
"heapUsedBytes": 68021084,
"domNodes": -281,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 154.25,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1730.0369999999248,
"styleRecalcs": 31,
"styleRecalcDurationMs": 18.529999999999998,
"layouts": 6,
"layoutDurationMs": 1.5159999999999998,
"taskDurationMs": 389.295,
"heapDeltaBytes": 4550916,
"heapUsedBytes": 75773456,
"domNodes": 76,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 12.491999999999996,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1680.9000000000651,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.282999999999998,
"layouts": 6,
"layoutDurationMs": 1.1179999999999999,
"taskDurationMs": 398.03900000000004,
"heapDeltaBytes": 4623116,
"heapUsedBytes": 76009092,
"domNodes": 75,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 12.611000000000004,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 694.1120000000183,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.026,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 475.36400000000003,
"heapDeltaBytes": 18742620,
"heapUsedBytes": 89162072,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 159.113,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 698.8639999999577,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.914999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.15700000000004,
"heapDeltaBytes": 17659448,
"heapUsedBytes": 87979816,
"domNodes": 16,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 160.623,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2035.682999999949,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.998000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 663.925,
"heapDeltaBytes": 5349316,
"heapUsedBytes": 81517764,
"domNodes": -280,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 33.319,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2064.4979999999578,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.579000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 680.0799999999999,
"heapDeltaBytes": 10512172,
"heapUsedBytes": 87135348,
"domNodes": -268,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 38.754,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2629.3319999999767,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.232,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1771.144,
"heapDeltaBytes": 2338092,
"heapUsedBytes": 79516564,
"domNodes": -285,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 805.397,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2685.903000000053,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.391000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1807.28,
"heapDeltaBytes": 11828444,
"heapUsedBytes": 89264104,
"domNodes": -250,
"jsHeapTotalBytes": -663552,
"scriptDurationMs": 903.44,
"eventListeners": -192,
"totalBlockingTimeMs": 23,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3692.410999999993,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.434000000000003,
"layouts": 60,
"layoutDurationMs": 12.650000000000002,
"taskDurationMs": 1772.6779999999999,
"heapDeltaBytes": 8180628,
"heapUsedBytes": 76081340,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 774.197,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3712.2459999999364,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.199,
"layouts": 60,
"layoutDurationMs": 12.538999999999998,
"taskDurationMs": 1760.634,
"heapDeltaBytes": 9943336,
"heapUsedBytes": 76210880,
"domNodes": -285,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 768.825,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3205.2360000000135,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.984000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2063.6580000000004,
"heapDeltaBytes": 9123408,
"heapUsedBytes": 89639684,
"domNodes": -256,
"jsHeapTotalBytes": 315392,
"scriptDurationMs": 977.583,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3158.4679999999707,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.147000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2004.6429999999998,
"heapDeltaBytes": 20876796,
"heapUsedBytes": 88894132,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 985.943,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2006.748000000016,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.0869999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 602.927,
"heapDeltaBytes": 22159508,
"heapUsedBytes": 88005156,
"domNodes": -274,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 36.829,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2051.4970000000403,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.281,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 659.6560000000002,
"heapDeltaBytes": 5680172,
"heapUsedBytes": 83126028,
"domNodes": -282,
"jsHeapTotalBytes": -1150976,
"scriptDurationMs": 31.501,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 658.8660000001028,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.239999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.92699999999996,
"heapDeltaBytes": 14634556,
"heapUsedBytes": 87902260,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 151.564,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 645.2600000000075,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.831999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 430.296,
"heapDeltaBytes": 14965184,
"heapUsedBytes": 88496396,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 143.69,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2023.0530000000044,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.627999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 534.248,
"heapDeltaBytes": -8341096,
"heapUsedBytes": 57668164,
"domNodes": 16,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 10.280999999999999,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.7559999999585,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.651000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 540.868,
"heapDeltaBytes": -2416192,
"heapUsedBytes": 71022628,
"domNodes": -295,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 10.228000000000002,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1752.444999999966,
"styleRecalcs": 79,
"styleRecalcDurationMs": 29.027,
"layouts": 18,
"layoutDurationMs": 4.561,
"taskDurationMs": 887.081,
"heapDeltaBytes": -15251976,
"heapUsedBytes": 57902560,
"domNodes": -293,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 102.91300000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1720.2510000000757,
"styleRecalcs": 78,
"styleRecalcDurationMs": 26.828000000000003,
"layouts": 18,
"layoutDurationMs": 4.909,
"taskDurationMs": 886.1399999999999,
"heapDeltaBytes": -390140,
"heapUsedBytes": 72664956,
"domNodes": -296,
"jsHeapTotalBytes": 6807552,
"scriptDurationMs": 104.503,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1417.6109999999653,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.132000000000005,
"layouts": 14,
"layoutDurationMs": 14.166000000000002,
"taskDurationMs": 954.6909999999999,
"heapDeltaBytes": 21989600,
"heapUsedBytes": 105500400,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 31.055000000000007,
"eventListeners": 2387,
"totalBlockingTimeMs": 140,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8881.151000000045,
"styleRecalcs": 247,
"styleRecalcDurationMs": 36.846000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6134.758,
"heapDeltaBytes": 5371488,
"heapUsedBytes": 81646760,
"domNodes": -248,
"jsHeapTotalBytes": 614400,
"scriptDurationMs": 2719.009,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9058.722999999987,
"styleRecalcs": 248,
"styleRecalcDurationMs": 39.533,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6231.8730000000005,
"heapDeltaBytes": 13226396,
"heapUsedBytes": 89290896,
"domNodes": -273,
"jsHeapTotalBytes": 122880,
"scriptDurationMs": 2681.4809999999998,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15654.755000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15125.31,
"heapDeltaBytes": -58700528,
"heapUsedBytes": 178200036,
"domNodes": -8068,
"jsHeapTotalBytes": -16953344,
"scriptDurationMs": 242.647,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 15597.99899999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15095.539999999999,
"heapDeltaBytes": -57660232,
"heapUsedBytes": 178621892,
"domNodes": -8068,
"jsHeapTotalBytes": -17477632,
"scriptDurationMs": 267.089,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 18670.875000000022,
"styleRecalcs": 137,
"styleRecalcDurationMs": 17.38899999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18400.165999999997,
"heapDeltaBytes": -35602588,
"heapUsedBytes": 168762172,
"domNodes": -8069,
"jsHeapTotalBytes": -7614464,
"scriptDurationMs": 892.5540000000001,
"eventListeners": -14931,
"totalBlockingTimeMs": 20,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 19024.45399999999,
"styleRecalcs": 134,
"styleRecalcDurationMs": 17.61500000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18689.512,
"heapDeltaBytes": -48418428,
"heapUsedBytes": 182101684,
"domNodes": -8068,
"jsHeapTotalBytes": -19836928,
"scriptDurationMs": 914.618,
"eventListeners": -14935,
"totalBlockingTimeMs": 37,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5795.495999999957,
"styleRecalcs": 20,
"styleRecalcDurationMs": 97.94999999999999,
"layouts": 20,
"layoutDurationMs": 36.594,
"taskDurationMs": 5725.927,
"heapDeltaBytes": -53512640,
"heapUsedBytes": 165629904,
"domNodes": -8068,
"jsHeapTotalBytes": 12001280,
"scriptDurationMs": 121.119,
"eventListeners": -14931,
"totalBlockingTimeMs": 474,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5706.731999999988,
"styleRecalcs": 20,
"styleRecalcDurationMs": 90.11500000000002,
"layouts": 20,
"layoutDurationMs": 36.451,
"taskDurationMs": 5598.916,
"heapDeltaBytes": -63431836,
"heapUsedBytes": 175877216,
"domNodes": -8068,
"jsHeapTotalBytes": 3231744,
"scriptDurationMs": 101.33500000000001,
"eventListeners": -14931,
"totalBlockingTimeMs": 306,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7908.319000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7613.743999999999,
"heapDeltaBytes": 6541044,
"heapUsedBytes": 178376772,
"domNodes": 0,
"jsHeapTotalBytes": -9961472,
"scriptDurationMs": 117.55799999999994,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7924.5619999999235,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7777.28,
"heapDeltaBytes": -23048684,
"heapUsedBytes": 167264296,
"domNodes": 0,
"jsHeapTotalBytes": -19398656,
"scriptDurationMs": 150.80300000000003,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 467.83300000004147,
"styleRecalcs": 18,
"styleRecalcDurationMs": 20.658999999999995,
"layouts": 3,
"layoutDurationMs": 1.393,
"taskDurationMs": 115.39400000000002,
"heapDeltaBytes": 4899188,
"heapUsedBytes": 73012432,
"domNodes": 145,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.4,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 157.80099999994945,
"styleRecalcs": 8,
"styleRecalcDurationMs": 20.634999999999998,
"layouts": 2,
"layoutDurationMs": 1.7870000000000001,
"taskDurationMs": 112.52699999999999,
"heapDeltaBytes": 2944532,
"heapUsedBytes": 71445112,
"domNodes": 127,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.619999999999998,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #18860 +/- ##
=============================================
- Coverage 83.79% 83.78% -0.01%
=============================================
Files 2105 2105
Lines 124732 124732
Branches 33452 31585 -1867
=============================================
- Hits 104519 104512 -7
- Misses 20035 20042 +7
Partials 178 178
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Recorded merge judgment (program-authorized 1.54 backport flow)
|
…xture helper (#17403) (#18876) ## Summary Restores fixture-contract parity with `main` and `cloud/1.54`: adds the `NodeSlotReference.expectLinkCount` helper from #17403 to `browser_tests/fixtures/utils/litegraphUtils.ts`. The file is **byte-identical to both `origin/main` and `origin/cloud/1.54`** (blob `d3a1e76d0e`). ## Why Program audit row `bpaudit-1` (silently-dropped backport collateral, follow-up to the #17730/#18860 fixture-semantics incident) found this as the one remaining undecided test-infrastructure divergence on the 1.54 pair: - `cloud/1.54` received this exact hunk as a hand-carried adaptation inside #18257 because a picked spec needed it. - `core/1.54` never received #17403 by any route, so the next spec backport written against main's fixture contract that calls `expectLinkCount` fails on core only — the same failure shape that cost three days on #18512 (see #18860). ## Scope - Test infrastructure only: one fixture method, 3 lines, no product code. - No consumer on this branch yet; `getLinkCount` (which it wraps) already exists here. - No behavior change to any existing test. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Summary
Backports the test-fixture subset of #17730 to
core/1.54:bootAgentAppnow passesobjectInfothrough tomockCloudBoot, soobjectInfo: 'server'stops being swallowed and the empty{}/api/object_infomock is no longer registered last (Playwright runs the most-recently-registered matching route first, so that empty mock was shadowing every node-def route a harness registers before boot).Changes
browser_tests/fixtures/agentPanelFixture.ts+browser_tests/fixtures/utils/cloudBootMocks.ts— the exact fixture hunkscloud/1.54received inside [backport cloud/1.54] feat(agent): report graph activity without moving the camera #18550 (manual backport of feat(agent): show graph activity while the agent writes nodes #17730, source squash7806755421). Byte-identical to bothcloud/1.54andmainafter this change. Test infrastructure only — nosrc/changes; the feat(agent): show graph activity while the agent writes nodes #17730 product feature stays excluded fromcore/1.54exactly as [backport core/1.54] Agent UI catch-up (PM-1657) #18631 recorded ("core lacks its three files").Review Focus
This is the root cause of the two deterministic failures blocking #18512 (run 36138115446):
agentCrdtMultiAutogrowRealign.spec.tsboots withobjectInfo: 'server'and registers its node defs before boot, which only works with the post-#17730 fixture semantics. On this branch the app booted with an empty node catalog,LiteGraph.createNodereturned null for the fixture types, the CRDT materializer fell back tomissingNode(), and the target node rendered slots but zero widgets — hence notextbox "prompt". This is a test-env artifact, not a product accessibility divergence: with the catalog actually served,core/1.54renders the prompt textarea with the correct accessible name.Local verification at
core/1.54+ #18512 carrier head:agentCrdtMultiAutogrowRealigntests: red before this change, green after (1.8s / 4.5s).--project=cloudsuite: 225 passed; the 6 local failures are identical with and without this change (pre-existing local-env artifacts, all green in CI baseline).typecheck:browser,eslint,oxfmt --check: clean.