Repository navigation
[backport core/1.54] fix(agent): preserve fresher live widget values during CRDT reconcile - #18536
Conversation
…during CRDT reconcile Backport of source PR #18361 via the qualified cloud/1.54 adaptation from PR #18423. Preserves fresher live widget values during stale CRDT reconciliation and closes local-dirty suppression after graph-load success or failure. The adaptation retains core/1.54's target-native imports and lifecycle behavior.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1944 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-23T16:24:00.486Z",
"gitSha": "aadaf06de2ace52c7d00e4011af439461dfce834",
"branch": "backport-18361-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2071.909000000005,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 612.7139999999999,
"heapDeltaBytes": -12048188,
"heapUsedBytes": 58270240,
"domNodes": -279,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 12.447999999999997,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2043.391999999983,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.291,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 618.427,
"heapDeltaBytes": 5979000,
"heapUsedBytes": 77121116,
"domNodes": -280,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 16.651,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2184.215999999992,
"styleRecalcs": 80,
"styleRecalcDurationMs": 42.162000000000006,
"layouts": 14,
"layoutDurationMs": 4.536999999999999,
"taskDurationMs": 1131.916,
"heapDeltaBytes": 6821720,
"heapUsedBytes": 77074432,
"domNodes": -280,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 191.204,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1840.8090000000357,
"styleRecalcs": 77,
"styleRecalcDurationMs": 32.459,
"layouts": 14,
"layoutDurationMs": 4.257,
"taskDurationMs": 935.441,
"heapDeltaBytes": 13615344,
"heapUsedBytes": 84325428,
"domNodes": -277,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 167.798,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1754.8130000000128,
"styleRecalcs": 32,
"styleRecalcDurationMs": 19.624000000000002,
"layouts": 6,
"layoutDurationMs": 1.2950000000000002,
"taskDurationMs": 433.60299999999995,
"heapDeltaBytes": 4313168,
"heapUsedBytes": 74638860,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 15.744000000000002,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1735.2879999999686,
"styleRecalcs": 30,
"styleRecalcDurationMs": 17.745,
"layouts": 6,
"layoutDurationMs": 1.467,
"taskDurationMs": 429.952,
"heapDeltaBytes": 4375580,
"heapUsedBytes": 74666128,
"domNodes": 74,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 16.133000000000003,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 698.2429999999908,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.9940000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.73199999999997,
"heapDeltaBytes": -7851124,
"heapUsedBytes": 63171400,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 167.535,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 707.273999999984,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.77,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 483.50499999999994,
"heapDeltaBytes": 18079696,
"heapUsedBytes": 88373312,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 165.412,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2073.1400000000235,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.186999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 738.326,
"heapDeltaBytes": 6760784,
"heapUsedBytes": 82644148,
"domNodes": -272,
"jsHeapTotalBytes": -1155072,
"scriptDurationMs": 37.644,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2088.5110000000395,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.617000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 809.4950000000001,
"heapDeltaBytes": 8523144,
"heapUsedBytes": 84588812,
"domNodes": -272,
"jsHeapTotalBytes": -630784,
"scriptDurationMs": 42.836,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2707.5209999999856,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.918000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1778.816,
"heapDeltaBytes": 12139136,
"heapUsedBytes": 89395892,
"domNodes": -271,
"jsHeapTotalBytes": -143360,
"scriptDurationMs": 850.8439999999999,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2809.9190000000362,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.113,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1865.7989999999998,
"heapDeltaBytes": 3661528,
"heapUsedBytes": 81354352,
"domNodes": -286,
"jsHeapTotalBytes": 118784,
"scriptDurationMs": 926.577,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3808.150000000012,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.908,
"layouts": 60,
"layoutDurationMs": 13.04,
"taskDurationMs": 1899.0669999999998,
"heapDeltaBytes": 1352388,
"heapUsedBytes": 79553248,
"domNodes": -288,
"jsHeapTotalBytes": 2252800,
"scriptDurationMs": 830.3960000000001,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3649.0309999999226,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.513000000000002,
"layouts": 60,
"layoutDurationMs": 12.506,
"taskDurationMs": 1759.9239999999998,
"heapDeltaBytes": 7761372,
"heapUsedBytes": 75851532,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 790.742,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3143.827999999985,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.148000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2026.1560000000004,
"heapDeltaBytes": 22789840,
"heapUsedBytes": 93031736,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 988.79,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3192.6320000000032,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.511000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2035.6190000000001,
"heapDeltaBytes": 22863328,
"heapUsedBytes": 90736964,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 992.071,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2069.2999999999984,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.765000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 757.1329999999999,
"heapDeltaBytes": 5141796,
"heapUsedBytes": 82499772,
"domNodes": -280,
"jsHeapTotalBytes": -1941504,
"scriptDurationMs": 45.152,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2017.421000000013,
"styleRecalcs": 2,
"styleRecalcDurationMs": 2.0440000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 695.0820000000001,
"heapDeltaBytes": 22151728,
"heapUsedBytes": 88470140,
"domNodes": -274,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 39.17000000000001,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 661.907000000042,
"styleRecalcs": 46,
"styleRecalcDurationMs": 11.888,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.89400000000006,
"heapDeltaBytes": 15041748,
"heapUsedBytes": 88234740,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 145.19899999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 690.0530000000344,
"styleRecalcs": 44,
"styleRecalcDurationMs": 9.611999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 439.81800000000004,
"heapDeltaBytes": 14940304,
"heapUsedBytes": 88304856,
"domNodes": 14,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 147.16899999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2030.6830000000105,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.904999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 595.0790000000001,
"heapDeltaBytes": -8985772,
"heapUsedBytes": 63485588,
"domNodes": -294,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 12.666999999999998,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2041.2900000000036,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.162,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 593.588,
"heapDeltaBytes": -5546504,
"heapUsedBytes": 67682364,
"domNodes": -295,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 12.152999999999997,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1739.307999999994,
"styleRecalcs": 77,
"styleRecalcDurationMs": 29.754999999999995,
"layouts": 18,
"layoutDurationMs": 5.630999999999999,
"taskDurationMs": 897.0399999999998,
"heapDeltaBytes": 9430132,
"heapUsedBytes": 82184956,
"domNodes": -296,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 123.87899999999999,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1856.6959999999426,
"styleRecalcs": 78,
"styleRecalcDurationMs": 34.487,
"layouts": 18,
"layoutDurationMs": 5.835,
"taskDurationMs": 960.062,
"heapDeltaBytes": -7589544,
"heapUsedBytes": 64873100,
"domNodes": -294,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 127.22800000000001,
"eventListeners": -244,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.2420000000207,
"styleRecalcs": 18,
"styleRecalcDurationMs": 34.480999999999995,
"layouts": 14,
"layoutDurationMs": 16.2,
"taskDurationMs": 1030.772,
"heapDeltaBytes": 21960380,
"heapUsedBytes": 106304260,
"domNodes": 13751,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 34.84300000000001,
"eventListeners": 2387,
"totalBlockingTimeMs": 161,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9417.223999999977,
"styleRecalcs": 248,
"styleRecalcDurationMs": 39.27799999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6416.387000000001,
"heapDeltaBytes": -17944608,
"heapUsedBytes": 85245188,
"domNodes": -264,
"jsHeapTotalBytes": 647168,
"scriptDurationMs": 2865.526,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9760.377000000062,
"styleRecalcs": 246,
"styleRecalcDurationMs": 37.561,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6413.008,
"heapDeltaBytes": -9773196,
"heapUsedBytes": 93066056,
"domNodes": -270,
"jsHeapTotalBytes": -1449984,
"scriptDurationMs": 2884.5490000000004,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17991.38099999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17316.06,
"heapDeltaBytes": -53289772,
"heapUsedBytes": 164128064,
"domNodes": -8068,
"jsHeapTotalBytes": -13164544,
"scriptDurationMs": 335.015,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 18025.580999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17283.670000000002,
"heapDeltaBytes": -39595912,
"heapUsedBytes": 178311660,
"domNodes": -8068,
"jsHeapTotalBytes": -7352320,
"scriptDurationMs": 347.087,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22027.41199999997,
"styleRecalcs": 166,
"styleRecalcDurationMs": 22.104000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21767.194,
"heapDeltaBytes": -32096456,
"heapUsedBytes": 178623500,
"domNodes": -8068,
"jsHeapTotalBytes": -18206720,
"scriptDurationMs": 982.1070000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 41,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.700000000004366
},
{
"name": "vue-large-graph-pan",
"durationMs": 21816.744000000086,
"styleRecalcs": 160,
"styleRecalcDurationMs": 26.92599999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21638.438000000002,
"heapDeltaBytes": -55139940,
"heapUsedBytes": 168322520,
"domNodes": -8068,
"jsHeapTotalBytes": -17051648,
"scriptDurationMs": 993.0649999999999,
"eventListeners": -14923,
"totalBlockingTimeMs": 191,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6554.268999999977,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.79700000000001,
"layouts": 20,
"layoutDurationMs": 28.184,
"taskDurationMs": 6468.024,
"heapDeltaBytes": -34881816,
"heapUsedBytes": 182142368,
"domNodes": -8068,
"jsHeapTotalBytes": 11264000,
"scriptDurationMs": 125.15799999999999,
"eventListeners": -14927,
"totalBlockingTimeMs": 425,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6453.574000000003,
"styleRecalcs": 20,
"styleRecalcDurationMs": 95.97100000000003,
"layouts": 20,
"layoutDurationMs": 29.397000000000006,
"taskDurationMs": 6313.526000000001,
"heapDeltaBytes": -46905728,
"heapUsedBytes": 171208264,
"domNodes": -8068,
"jsHeapTotalBytes": 11522048,
"scriptDurationMs": 117.08200000000001,
"eventListeners": -14931,
"totalBlockingTimeMs": 576,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9050.546999999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8719.714999999998,
"heapDeltaBytes": 21626200,
"heapUsedBytes": 179286488,
"domNodes": 0,
"jsHeapTotalBytes": -8388608,
"scriptDurationMs": 150.53799999999995,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9043.875999999955,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8618.088,
"heapDeltaBytes": 7829816,
"heapUsedBytes": 178691912,
"domNodes": 0,
"jsHeapTotalBytes": -8126464,
"scriptDurationMs": 157.44400000000002,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 111.51200000000472,
"styleRecalcs": 8,
"styleRecalcDurationMs": 14.677,
"layouts": 2,
"layoutDurationMs": 0.6200000000000001,
"taskDurationMs": 75.378,
"heapDeltaBytes": 3006784,
"heapUsedBytes": 71478940,
"domNodes": 108,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.326000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 116.03999999999814,
"styleRecalcs": 9,
"styleRecalcDurationMs": 21.71,
"layouts": 3,
"layoutDurationMs": 1.895,
"taskDurationMs": 83.203,
"heapDeltaBytes": 3024700,
"heapUsedBytes": 72137144,
"domNodes": 108,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.706999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.54 #18536 +/- ##
=============================================
+ Coverage 83.63% 83.64% +0.01%
=============================================
Files 2098 2098
Lines 123900 123957 +57
Branches 31367 31378 +11
=============================================
+ Hits 103618 103685 +67
+ Misses 20103 20093 -10
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Core adaptation is faithful. Local regression coverage is green. Hosted exact-head checks are still running.
Full context for agent readers
Reviewed exact head b52719b6c1fe2462522ef5ef7177998f5cbdd878 against core/1.54. The carrier preserves the source fix: stale CRDT reconciliation cannot overwrite a fresher live widget value, while older live values still accept the document value. The release branch advanced during qualification, so I merged the current target without rewriting history and reran the affected suites; 285 tests passed, with one expected failure and one skip. The earlier exact head also passed the full 21,375-test unit suite, typecheck, changed-file formatting and lint, Knip, all Chromium shards, Cloud Playwright, mobile/scaled lanes, and ecosystem checks. No correctness issue found in the resulting target diff. Final merge remains conditional on terminal hosted checks and a fresh target-aware guard.
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 1 Pipeline job failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 53e5ea5 | Docs | View more details | Give us feedback! |
|
Target refresh complete at exact head
|
|
Exact-head qualification found the remaining adverse CI is independently reproduced by the current target tip.
No branch change or workflow rerun is warranted for this target-baseline failure. The PR remains mergeable but blocked on the existing |
|
Target refresh complete at exact head
Merge remains blocked on terminal exact-head checks and the existing |
Backports the reported stale prompt reconciliation bug fix to
core/1.54.cloud/1.54adaptation.Full context for agent readers
Backport of source PR 18361 via the target-adapted Cloud carrier PR 18423.
core/1.54contains the Agent panel and CRDT reconciliation path, and lacked this fix.The carrier preserves named and positional widget reconciliation, repeated stale replay handling, object-valued acknowledgements, explicit writes, deletions, structural replay, and graph-load success/failure cleanup. The only content difference from the merged Cloud carrier is the target branch's current import ordering in
graphMutations.test.ts.Verification at head:
pnpm typecheck: passedgit diff --check: passedThis PR does not claim deployment or served-environment acceptance.