Skip to content

[backport cloud/1.54] fix: send the workspace token when downloading a cloud asset - #18478

Merged
comfy-pr-bot merged 1 commit into
cloud/1.54from
backport-18421-to-cloud-1.54
Sep 23, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.54from
backport-18421-to-cloud-1.54

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #18421 to cloud/1.54

Automatically created by backport workflow.

*PR Created by the Glary-Bot Agent*

---

Fixes the "download failed" half of the staging report: clicking
download on a Media Assets card raised `1 download failed`, with `GET
/api/assets/<id>/content` returning **404** in the console.

## Root cause

`createAssetDownload` built a `mode: 'fetch'` download but never set the
optional `fetch` field, so `downloadFileAsBlob` fell through to its
default — the bare global `fetch` (`src/base/common/downloadUtil.ts`,
the `fetch: fetchFile = fetch` parameter default).

A bare same-origin `fetch` sends no `Authorization` header, so
`/api/assets/{id}/content` authenticated by **session cookie**. Cookie
auth resolves the caller's *personal* workspace (`resolveCookieUser` →
`UpsertWithPersonalWorkspace`), and `GetAssetContent` scopes its lookup
to that workspace, returning `ASSET_NOT_FOUND` → 404 for an asset owned
by any other workspace.

This is not 3D-specific — it affects every Media Assets download of an
asset outside the user's personal workspace. The reporter hit it on a 3D
job because that job is what surfaced the duplicate-output bug fixed in
Comfy-Org/cloud#10214.

## Change

Route the cloud download through `api.fetchApi`, which attaches the
selected workspace's Cloud JWT. This mirrors `resolveReplyAssetDownload`
(`src/workbench/extensions/agent/utils/resolveReplyAssetDownload.ts`) —
the only other `FetchedAssetDownload` producer, which already ships this
exact pattern against the same endpoint. No type or interface change:
`FetchedAssetDownload.fetch` already existed for precisely this.

Passing the built content URL back through `fetchApi` is a no-op:
`apiURL` early-returns for `/api`-prefixed input, and `api_base` is `''`
on cloud — which is the only branch that takes `mode: 'fetch'`.

## Test

`fetches a cloud download through the workspace-authenticated client`
asserts the download is handed an authenticated fetch and that invoking
it reaches `api.fetchApi`. Verified red before the change (`expected
"vi.fn()" to be called with arguments`) and green after.

## Verification

- `pnpm vitest run src/platform/assets/` — 52 files, 799 passed.
- `pnpm vitest run src/base/common/downloadUtil.test.ts
src/workbench/extensions/agent` — 127 files, 1995 passed.
- `vue-tsc --noEmit` — 0 errors. ESLint clean. `pnpm format` clean.
Pre-commit hook (oxfmt + oxlint --type-aware + eslint + typecheck)
passed.

### Manual browser QA (A/B on a local cloud stack)

Ran the real UI against a locally running cloud backend, logged in as a
fresh account, generated an output, and clicked the card's Download
button — then reverted the fix and repeated the identical click:

| | `authorization` header on `/api/assets/{id}/content` | status |
|---|---|---|
| **without fix** | *absent* | 302 |
| **with fix** | `Bearer eyJ…`, JWT payload `workspace_id` matching the
asset's `workspace_id` in the DB | 302 |

The header is exactly what was missing. The local sandbox cannot
complete the *second* leg (the 302 to the signed GCS URL returns 403),
but that is environmental and **not** caused by this change: it
reproduces identically with the fix reverted, and a plain server-side
`curl` of the same signed URL — no browser, no CORS, no headers — also
returns 403 with a GCS signature error, i.e. the sandbox cannot mint
valid signatures for the shared test bucket.

That A/B also closes the one risk worth flagging: the added
`Authorization` header produces **no behavioural difference** on the
cross-origin redirect leg. Worth one manual download on staging after
deploy to confirm the GCS preflight admits it there too — the shipped
`resolveReplyAssetDownload` precedent suggests it will.

Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Sep 22, 2026
@vercel

vercel Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 22, 2026 11:16pm UTC

Request Review

@github-actions

github-actions Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/22/2026, 11:21:49 PM UTC

Links

🎭 Playwright: ✅ 1935 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1914 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.3 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.0 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.4 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.1 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.3 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.0 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.9 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.8 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 66.2 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.2 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 135ms TBT · 101.6 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.5 MB heap
vue-large-graph-idle: · 56.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.3 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 16ms TBT · 161.7 MB heap
vue-node-resize-workload: · 54.5 avg FPS · 30.0 P5 FPS ❌ (target: ≥52) · 273ms TBT · 171.5 MB heap
vue-zoom-out-idle: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 172.0 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 11
canvas-idle: task duration 544ms
canvas-idle: script duration 11ms
canvas-idle: TBT 0ms
canvas-idle: heap used 59.3 MB
canvas-idle: DOM nodes -277
canvas-idle: event listeners -194
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 26ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 74
canvas-mouse-sweep: task duration 828ms
canvas-mouse-sweep: script duration 136ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 65.0 MB
canvas-mouse-sweep: DOM nodes -277
canvas-mouse-sweep: event listeners -196
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 353ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.3 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 422ms
dom-widget-clipping: script duration 146ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 84.4 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 5ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 581ms
large-graph-idle: script duration 34ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.1 MB
large-graph-idle: DOM nodes -268
large-graph-idle: event listeners -178
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 14ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 67
large-graph-pan: task duration 1524ms
large-graph-pan: script duration 718ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 72.3 MB
large-graph-pan: DOM nodes -274
large-graph-pan: event listeners -178
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 14ms
large-graph-zoom: style recalc duration 12ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 61
large-graph-zoom: task duration 1647ms
large-graph-zoom: script duration 708ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 73.0 MB
large-graph-zoom: DOM nodes 1
large-graph-zoom: event listeners 9
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 7ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 42
legacy-node-drag: task duration 1828ms
legacy-node-drag: script duration 880ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 79.9 MB
legacy-node-drag: DOM nodes -126
legacy-node-drag: event listeners 88
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 584ms
minimap-idle: script duration 32ms
minimap-idle: TBT 0ms
minimap-idle: heap used 80.8 MB
minimap-idle: DOM nodes -276
minimap-idle: event listeners -179
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 394ms
subgraph-dom-widget-clipping: script duration 132ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.2 MB
subgraph-dom-widget-clipping: DOM nodes 19
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 7ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 490ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 66.2 MB
subgraph-idle: DOM nodes -296
subgraph-idle: event listeners -241
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 26ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 789ms
subgraph-mouse-sweep: script duration 96ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 67.2 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -210
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 12ms
subgraph-transition-enter: style recalc duration 28ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 845ms
subgraph-transition-enter: script duration 29ms
subgraph-transition-enter: TBT 135ms
subgraph-transition-enter: heap used 101.6 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2387
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 42ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 5498ms
viewport-pan-sweep: script duration 2470ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 84.5 MB
viewport-pan-sweep: DOM nodes -267
viewport-pan-sweep: event listeners -146
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 14526ms
vue-large-graph-idle: script duration 249ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 169.3 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14935
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 20ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 148
vue-large-graph-pan: task duration 17682ms
vue-large-graph-pan: script duration 858ms
vue-large-graph-pan: TBT 16ms
vue-large-graph-pan: heap used 161.7 MB
vue-large-graph-pan: DOM nodes -8083
vue-large-graph-pan: event listeners -14931
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 33ms
vue-node-resize-workload: layout duration 28ms
vue-node-resize-workload: style recalc duration 72ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5205ms
vue-node-resize-workload: script duration 94ms
vue-node-resize-workload: TBT 273ms
vue-node-resize-workload: heap used 171.5 MB
vue-node-resize-workload: DOM nodes -8070
vue-node-resize-workload: event listeners -14933
vue-zoom-out-idle: avg frame time 17ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 7148ms
vue-zoom-out-idle: script duration 113ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 172.0 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -10
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 14ms
workflow-execution: layout count 2
workflow-execution: style recalc count 8
workflow-execution: task duration 72ms
workflow-execution: script duration 5ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.4 MB
workflow-execution: DOM nodes 118
workflow-execution: event listeners 25
Raw data
{
  "timestamp": "2026-09-22T23:30:22.331Z",
  "gitSha": "e6894fb1cc4ad4c915bd573d32d54dab8101062d",
  "branch": "backport-18421-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2070.9130000000187,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.094000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 588.3419999999999,
      "heapDeltaBytes": -7824036,
      "heapUsedBytes": 63328464,
      "domNodes": -278,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 11.993999999999998,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2027.9379999999492,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.756000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 500.1200000000001,
      "heapDeltaBytes": -9696192,
      "heapUsedBytes": 60997900,
      "domNodes": -275,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 9.050000000000002,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1802.186000000006,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 25.846999999999998,
      "layouts": 14,
      "layoutDurationMs": 4.0760000000000005,
      "taskDurationMs": 831.877,
      "heapDeltaBytes": -237880,
      "heapUsedBytes": 69278796,
      "domNodes": -276,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 137.214,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1836.8530000000192,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 25.655000000000005,
      "layouts": 14,
      "layoutDurationMs": 4.347,
      "taskDurationMs": 824.079,
      "heapDeltaBytes": -3952940,
      "heapUsedBytes": 67065672,
      "domNodes": -278,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 134.81699999999998,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1739.0030000000252,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 16.054,
      "layouts": 6,
      "layoutDurationMs": 1.223,
      "taskDurationMs": 351.383,
      "heapDeltaBytes": 4683696,
      "heapUsedBytes": 75480052,
      "domNodes": 77,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 12.434999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1722.8719999999385,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 15.082000000000003,
      "layouts": 6,
      "layoutDurationMs": 1.1309999999999998,
      "taskDurationMs": 354.01300000000003,
      "heapDeltaBytes": 4335552,
      "heapUsedBytes": 73958976,
      "domNodes": 76,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 11.845,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 693.725000000029,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.693999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 436.65600000000006,
      "heapDeltaBytes": 18052668,
      "heapUsedBytes": 88382528,
      "domNodes": 20,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 150.488,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 609.0080000000171,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 6.305999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 406.751,
      "heapDeltaBytes": 18366000,
      "heapUsedBytes": 88621668,
      "domNodes": 18,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 141.37000000000003,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2051.288999999997,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 6.224999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 580.929,
      "heapDeltaBytes": 10536508,
      "heapUsedBytes": 86842616,
      "domNodes": -269,
      "jsHeapTotalBytes": -1679360,
      "scriptDurationMs": 36.792,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2036.9099999999207,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 3.7090000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 580.3629999999999,
      "heapDeltaBytes": -15963556,
      "heapUsedBytes": 87414368,
      "domNodes": -267,
      "jsHeapTotalBytes": -1118208,
      "scriptDurationMs": 32.096,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2185.1110000000062,
      "styleRecalcs": 68,
      "styleRecalcDurationMs": 15.008000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1546.3100000000002,
      "heapDeltaBytes": -9310220,
      "heapUsedBytes": 67414724,
      "domNodes": -278,
      "jsHeapTotalBytes": 155648,
      "scriptDurationMs": 724.603,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2228.7509999999884,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 12.101,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1502.6779999999997,
      "heapDeltaBytes": -19895404,
      "heapUsedBytes": 84163356,
      "domNodes": -269,
      "jsHeapTotalBytes": -892928,
      "scriptDurationMs": 712.1310000000001,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3688.1670000000213,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 11.903000000000004,
      "layouts": 60,
      "layoutDurationMs": 13.954999999999998,
      "taskDurationMs": 1671.3870000000002,
      "heapDeltaBytes": 8519448,
      "heapUsedBytes": 76088080,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 729.8549999999999,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3594.380000000001,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 12.065000000000003,
      "layouts": 60,
      "layoutDurationMs": 13.819999999999999,
      "taskDurationMs": 1623.503,
      "heapDeltaBytes": 9454632,
      "heapUsedBytes": 77068936,
      "domNodes": 2,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 686.652,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3092.5940000000196,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.485,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1781.016,
      "heapDeltaBytes": 18335068,
      "heapUsedBytes": 86319936,
      "domNodes": 0,
      "jsHeapTotalBytes": 1466368,
      "scriptDurationMs": 848.982,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3110.484999999926,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 9.319,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1874.4759999999999,
      "heapDeltaBytes": 1181632,
      "heapUsedBytes": 81239428,
      "domNodes": -252,
      "jsHeapTotalBytes": 311296,
      "scriptDurationMs": 910.271,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2030.7109999999966,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.527,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 606.5310000000001,
      "heapDeltaBytes": 4801216,
      "heapUsedBytes": 82022784,
      "domNodes": -279,
      "jsHeapTotalBytes": -1155072,
      "scriptDurationMs": 34.129000000000005,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2029.4790000000376,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.467999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 560.9689999999999,
      "heapDeltaBytes": 10030856,
      "heapUsedBytes": 87496980,
      "domNodes": -273,
      "jsHeapTotalBytes": -2203648,
      "scriptDurationMs": 30.258,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 616.581999999994,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.258000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 396.388,
      "heapDeltaBytes": 14705380,
      "heapUsedBytes": 87761980,
      "domNodes": 18,
      "jsHeapTotalBytes": 4980736,
      "scriptDurationMs": 131.911,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 596.7239999999947,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.446999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 391.0400000000001,
      "heapDeltaBytes": 14208648,
      "heapUsedBytes": 86628364,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 132.58199999999997,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2018.8949999999863,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.148999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 498.355,
      "heapDeltaBytes": -6862392,
      "heapUsedBytes": 66211644,
      "domNodes": -295,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 10.196,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2018.3250000000044,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 6.913000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 481.227,
      "heapDeltaBytes": -493164,
      "heapUsedBytes": 72721296,
      "domNodes": -296,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 9.160000000000002,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1735.6210000000374,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 25.156000000000006,
      "layouts": 18,
      "layoutDurationMs": 4.917999999999999,
      "taskDurationMs": 779.859,
      "heapDeltaBytes": -15997220,
      "heapUsedBytes": 57074008,
      "domNodes": -295,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 94.766,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1723.9120000000412,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 27.296999999999997,
      "layouts": 18,
      "layoutDurationMs": 5.6339999999999995,
      "taskDurationMs": 798.3240000000001,
      "heapDeltaBytes": 11111112,
      "heapUsedBytes": 83844208,
      "domNodes": -297,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 97.00399999999999,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1334.777000000031,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 28.097000000000005,
      "layouts": 16,
      "layoutDurationMs": 12.406,
      "taskDurationMs": 845.0210000000001,
      "heapDeltaBytes": 21966164,
      "heapUsedBytes": 106503912,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 29.023,
      "eventListeners": 2387,
      "totalBlockingTimeMs": 135,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8260.08300000001,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 43.278,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5565.161,
      "heapDeltaBytes": 16466396,
      "heapUsedBytes": 92196264,
      "domNodes": -268,
      "jsHeapTotalBytes": -667648,
      "scriptDurationMs": 2518.614,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8218.53699999997,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 40.011,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5430.07,
      "heapDeltaBytes": -18021392,
      "heapUsedBytes": 85013904,
      "domNodes": -265,
      "jsHeapTotalBytes": -1417216,
      "scriptDurationMs": 2422.123,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14797.492999999975,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14385.686,
      "heapDeltaBytes": -33818300,
      "heapUsedBytes": 177476360,
      "domNodes": -8068,
      "jsHeapTotalBytes": -12333056,
      "scriptDurationMs": 249.39100000000002,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 15194.882000000007,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14666.158999999998,
      "heapDeltaBytes": -33581216,
      "heapUsedBytes": 177652144,
      "domNodes": -8068,
      "jsHeapTotalBytes": -8663040,
      "scriptDurationMs": 248.24200000000002,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17747.960999999974,
      "styleRecalcs": 139,
      "styleRecalcDurationMs": 18.39599999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17352.181,
      "heapDeltaBytes": -48245424,
      "heapUsedBytes": 168431688,
      "domNodes": -8068,
      "jsHeapTotalBytes": -11808768,
      "scriptDurationMs": 842.899,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 19,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 18335.01100000001,
      "styleRecalcs": 156,
      "styleRecalcDurationMs": 20.84099999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 18011.215,
      "heapDeltaBytes": -44507836,
      "heapUsedBytes": 170688752,
      "domNodes": -8097,
      "jsHeapTotalBytes": -18808832,
      "scriptDurationMs": 873.732,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 13,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5330.76299999999,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 68.75399999999998,
      "layouts": 20,
      "layoutDurationMs": 24.651000000000007,
      "taskDurationMs": 5238.921,
      "heapDeltaBytes": -60439196,
      "heapUsedBytes": 175654504,
      "domNodes": -8072,
      "jsHeapTotalBytes": 12484608,
      "scriptDurationMs": 92.817,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 171,
      "frameDurationMs": 18.886666666666677,
      "p95FrameDurationMs": 49.899999999999636
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5271.318000000065,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 75.52900000000001,
      "layouts": 20,
      "layoutDurationMs": 30.815999999999995,
      "taskDurationMs": 5171.656000000001,
      "heapDeltaBytes": -33083140,
      "heapUsedBytes": 183970180,
      "domNodes": -8068,
      "jsHeapTotalBytes": 9904128,
      "scriptDurationMs": 96.106,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 374,
      "frameDurationMs": 17.779999999999987,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7410.4730000000245,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7182.330000000002,
      "heapDeltaBytes": 4969688,
      "heapUsedBytes": 176588672,
      "domNodes": 0,
      "jsHeapTotalBytes": -13893632,
      "scriptDurationMs": 114.87399999999992,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7375.617999999918,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7113.408999999999,
      "heapDeltaBytes": 22263756,
      "heapUsedBytes": 184226040,
      "domNodes": 0,
      "jsHeapTotalBytes": 1835008,
      "scriptDurationMs": 110.67300000000002,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 114.57800000005136,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 12.824,
      "layouts": 2,
      "layoutDurationMs": 0.601,
      "taskDurationMs": 73.312,
      "heapDeltaBytes": 3096076,
      "heapUsedBytes": 72071720,
      "domNodes": 111,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 6.8100000000000005,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 94.61500000008982,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 14.984,
      "layouts": 2,
      "layoutDurationMs": 1.501,
      "taskDurationMs": 69.75200000000001,
      "heapDeltaBytes": 2936856,
      "heapUsedBytes": 71272480,
      "domNodes": 125,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 3.547999999999999,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 50315 75455 66.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 78.3% 264
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.4% 260
src/scripts/pnginfo.ts 21.4% 221

@codecov

codecov Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #18478   +/-   ##
=============================================
  Coverage              ?   83.62%           
=============================================
  Files                 ?     2098           
  Lines                 ?   124088           
  Branches              ?    31420           
=============================================
  Hits                  ?   103766           
  Misses                ?    20144           
  Partials              ?      178           
Flag Coverage Δ
e2e 66.69% <0.00%> (?)
unit 78.60% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...latform/assets/composables/useMediaAssetActions.ts 80.11% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@comfy-pr-bot
comfy-pr-bot merged commit a0e1123 into cloud/1.54 Sep 23, 2026
103 of 106 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-18421-to-cloud-1.54 branch September 23, 2026 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants