Repository navigation
fix: lock the canvas to selection-only while agent node picking is active - #18066
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2116 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle: 9.98 MB gzip 🔴 +456 BDetailsSummary
Category Glance App Entry Points — 3.87 kB (baseline 3.87 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.44 MB (baseline 1.44 MB) • 🔴 +943 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 639 kB (baseline 639 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 6 added / 6 removed / 5 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 3.94 MB (baseline 3.93 MB) • 🔴 +9.75 kBStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 577 kB (baseline 577 kB) • 🔴 +1 BHelpers, composables, and utility bundles
Status: 19 added / 19 removed / 19 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.8 MB (baseline 17.8 MB) • 🟢 -8.19 kBBundles that do not match a named category
Status: 74 added / 74 removed / 228 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-23T07:09:48.332Z",
"gitSha": "cec654edea659f213d5d62e0c08efb4634ea2091",
"branch": "test/pm-1329-selection-mode-lockdown",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2000.4600000000323,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.859999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.18499999999995,
"heapDeltaBytes": -658908,
"heapUsedBytes": 66880212,
"domNodes": -259,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.76,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2009.9179999999706,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.329,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 382.958,
"heapDeltaBytes": -7772640,
"heapUsedBytes": 59916168,
"domNodes": -262,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.35,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1711.0660000000166,
"styleRecalcs": 45,
"styleRecalcDurationMs": 11.092,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 636.9350000000001,
"heapDeltaBytes": 10807572,
"heapUsedBytes": 78221524,
"domNodes": -260,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 112.907,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1689.8570000000745,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.978000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 636.2339999999999,
"heapDeltaBytes": -6711292,
"heapUsedBytes": 61115932,
"domNodes": -258,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 111.22,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.050999999988,
"styleRecalcs": 31,
"styleRecalcDurationMs": 11.753,
"layouts": 6,
"layoutDurationMs": 0.91,
"taskDurationMs": 273.688,
"heapDeltaBytes": 3098588,
"heapUsedBytes": 70955636,
"domNodes": 79,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.266,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1692.1909999999798,
"styleRecalcs": 30,
"styleRecalcDurationMs": 11.706999999999999,
"layouts": 6,
"layoutDurationMs": 1.0670000000000002,
"taskDurationMs": 268.128,
"heapDeltaBytes": 3132420,
"heapUsedBytes": 70959260,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 9.539000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 517.218000000014,
"styleRecalcs": 14,
"styleRecalcDurationMs": 6.567,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 338.238,
"heapDeltaBytes": 18692592,
"heapUsedBytes": 86289232,
"domNodes": 23,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 120.94999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 517.325000000028,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.506,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 328.735,
"heapDeltaBytes": 18900996,
"heapUsedBytes": 85685128,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 130.265,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1083.6729999999761,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 733.327,
"heapDeltaBytes": -17278240,
"heapUsedBytes": 73118256,
"domNodes": -294,
"jsHeapTotalBytes": 20840448,
"scriptDurationMs": 51.371,
"eventListeners": -217,
"totalBlockingTimeMs": 423,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1068.2239999999865,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 721.2160000000001,
"heapDeltaBytes": -17616552,
"heapUsedBytes": 72938668,
"domNodes": -293,
"jsHeapTotalBytes": 20578304,
"scriptDurationMs": 49.62899999999999,
"eventListeners": -217,
"totalBlockingTimeMs": 422,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 728.3249999999839,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 325.01999999999987,
"heapDeltaBytes": 14530324,
"heapUsedBytes": 90988380,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 101.66600000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 116,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 728.9690000000064,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 326.8649999999997,
"heapDeltaBytes": 13917688,
"heapUsedBytes": 90237896,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 105.60499999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 117,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6130.808999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5326.629000000001,
"heapDeltaBytes": 1584972,
"heapUsedBytes": 75291620,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 4324.357999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 3,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6451.802000000043,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5707.185,
"heapDeltaBytes": 23366540,
"heapUsedBytes": 97248420,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 4426.8240000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.779999999999987,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6727.1529999999875,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6018.151000000001,
"heapDeltaBytes": -9541764,
"heapUsedBytes": 72708132,
"domNodes": -18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 4662.745999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 54,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7115.416999999979,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.5929999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6326.527999999999,
"heapDeltaBytes": 11241048,
"heapUsedBytes": 85371912,
"domNodes": -8,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 4937.602,
"eventListeners": 0,
"totalBlockingTimeMs": 42,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "large-graph-idle",
"durationMs": 2016.0759999999982,
"styleRecalcs": 8,
"styleRecalcDurationMs": 4.734,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.491,
"heapDeltaBytes": 20637428,
"heapUsedBytes": 84007472,
"domNodes": -241,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.094,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2032.7889999999798,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.312999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.58900000000006,
"heapDeltaBytes": -4595616,
"heapUsedBytes": 82807428,
"domNodes": -237,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 30.275999999999996,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2135.9540000000266,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.469,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1162.081,
"heapDeltaBytes": -1242652,
"heapUsedBytes": 80423712,
"domNodes": -236,
"jsHeapTotalBytes": 741376,
"scriptDurationMs": 624.179,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2152.8429999999616,
"styleRecalcs": 70,
"styleRecalcDurationMs": 13.817999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1290.7419999999997,
"heapDeltaBytes": -7949764,
"heapUsedBytes": 80320236,
"domNodes": -213,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 629.0899999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3238.8950000000136,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.943999999999997,
"layouts": 60,
"layoutDurationMs": 12.578000000000001,
"taskDurationMs": 1389.825,
"heapDeltaBytes": -24115924,
"heapUsedBytes": 65311644,
"domNodes": -219,
"jsHeapTotalBytes": 28672,
"scriptDurationMs": 584.2860000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3156.0779999999795,
"styleRecalcs": 66,
"styleRecalcDurationMs": 13.11,
"layouts": 60,
"layoutDurationMs": 12.487000000000002,
"taskDurationMs": 1362.9759999999999,
"heapDeltaBytes": -24239556,
"heapUsedBytes": 65374212,
"domNodes": -219,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 575.447,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2149.847999999963,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.323999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1352.426,
"heapDeltaBytes": 17195320,
"heapUsedBytes": 83236716,
"domNodes": 8,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 661.771,
"eventListeners": 180,
"totalBlockingTimeMs": 3,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2286.1529999998993,
"styleRecalcs": 45,
"styleRecalcDurationMs": 6.237999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1417.3550000000002,
"heapDeltaBytes": 17915036,
"heapUsedBytes": 83647084,
"domNodes": 10,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 702.041,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2001.4409999999998,
"styleRecalcs": 6,
"styleRecalcDurationMs": 3.2789999999999973,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 419.4430000000001,
"heapDeltaBytes": 20233224,
"heapUsedBytes": 84921016,
"domNodes": -244,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 26.308999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2014.3850000000612,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.295000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.2059999999999,
"heapDeltaBytes": -7393280,
"heapUsedBytes": 81875144,
"domNodes": -244,
"jsHeapTotalBytes": 815104,
"scriptDurationMs": 31.002999999999997,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 503.66900000000214,
"styleRecalcs": 50,
"styleRecalcDurationMs": 8.713999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 294.18899999999996,
"heapDeltaBytes": 13770880,
"heapUsedBytes": 83776196,
"domNodes": 25,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 99.142,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 494.0200000000914,
"styleRecalcs": 48,
"styleRecalcDurationMs": 8.600000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 308.33,
"heapDeltaBytes": 14124504,
"heapUsedBytes": 83882636,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 107.791,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1993.7869999999975,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.827000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 312.918,
"heapDeltaBytes": 11670340,
"heapUsedBytes": 81471204,
"domNodes": -275,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.415999999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2005.1639999999225,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.767999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 389.295,
"heapDeltaBytes": -6554400,
"heapUsedBytes": 63314844,
"domNodes": -272,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.8469999999999995,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.8910000000078,
"styleRecalcs": 46,
"styleRecalcDurationMs": 12.259,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 580.0340000000001,
"heapDeltaBytes": -7614988,
"heapUsedBytes": 62302944,
"domNodes": -274,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 73.449,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1704.751999999985,
"styleRecalcs": 48,
"styleRecalcDurationMs": 13.236,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 616.36,
"heapDeltaBytes": -7164976,
"heapUsedBytes": 62953476,
"domNodes": -270,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 79.28299999999999,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 883.640000000014,
"styleRecalcs": 18,
"styleRecalcDurationMs": 21.539999999999996,
"layouts": 5,
"layoutDurationMs": 8.551,
"taskDurationMs": 683.943,
"heapDeltaBytes": -6259884,
"heapUsedBytes": 81958596,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 23.292,
"eventListeners": 2383,
"totalBlockingTimeMs": 109,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8142.238999999961,
"styleRecalcs": 250,
"styleRecalcDurationMs": 31.933999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4448.432000000001,
"heapDeltaBytes": -10563428,
"heapUsedBytes": 76694672,
"domNodes": -238,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 2041.061,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8171.4170000000195,
"styleRecalcs": 251,
"styleRecalcDurationMs": 31.141000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4380.009999999999,
"heapDeltaBytes": -1498324,
"heapUsedBytes": 80594708,
"domNodes": -232,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 1989.627,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 12686.088999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11961.195,
"heapDeltaBytes": -51912348,
"heapUsedBytes": 168531884,
"domNodes": -8062,
"jsHeapTotalBytes": -21299200,
"scriptDurationMs": 215.74,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 9108.157000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8356.94,
"heapDeltaBytes": -50936904,
"heapUsedBytes": 196164292,
"domNodes": -8062,
"jsHeapTotalBytes": -12713984,
"scriptDurationMs": 139.048,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999952,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15082.071999999982,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.323000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14595.733000000002,
"heapDeltaBytes": -60613924,
"heapUsedBytes": 179884596,
"domNodes": -8062,
"jsHeapTotalBytes": -23269376,
"scriptDurationMs": 696.262,
"eventListeners": -14928,
"totalBlockingTimeMs": 5,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15001.805999999988,
"styleRecalcs": 73,
"styleRecalcDurationMs": 18.256999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14462.508,
"heapDeltaBytes": -37307892,
"heapUsedBytes": 177638256,
"domNodes": -8062,
"jsHeapTotalBytes": -11022336,
"scriptDurationMs": 764.0129999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 103,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 3457.7980000000252,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.21100000000001,
"layouts": 20,
"layoutDurationMs": 21.943000000000005,
"taskDurationMs": 3309.387000000001,
"heapDeltaBytes": -55056224,
"heapUsedBytes": 181718464,
"domNodes": -8062,
"jsHeapTotalBytes": 13258752,
"scriptDurationMs": 65.603,
"eventListeners": -14927,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 4501.758999999993,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.072999999999986,
"layouts": 20,
"layoutDurationMs": 22.308999999999994,
"taskDurationMs": 4366.964,
"heapDeltaBytes": -52052796,
"heapUsedBytes": 189288592,
"domNodes": -8062,
"jsHeapTotalBytes": 5566464,
"scriptDurationMs": 111.67,
"eventListeners": -14928,
"totalBlockingTimeMs": 124,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6234.0789999999515,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5799.254000000001,
"heapDeltaBytes": -11810968,
"heapUsedBytes": 168740568,
"domNodes": 0,
"jsHeapTotalBytes": -18350080,
"scriptDurationMs": 113.91399999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6322.830000000067,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6017.327,
"heapDeltaBytes": 29250100,
"heapUsedBytes": 195389180,
"domNodes": 0,
"jsHeapTotalBytes": -21495808,
"scriptDurationMs": 93.59400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 98.62999999995736,
"styleRecalcs": 7,
"styleRecalcDurationMs": 13.482000000000001,
"layouts": 3,
"layoutDurationMs": 1.7530000000000001,
"taskDurationMs": 70.28099999999999,
"heapDeltaBytes": 3085816,
"heapUsedBytes": 68592576,
"domNodes": 125,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.648,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 438.95100000008824,
"styleRecalcs": 14,
"styleRecalcDurationMs": 14.26,
"layouts": 3,
"layoutDurationMs": 0.959,
"taskDurationMs": 87.25000000000001,
"heapDeltaBytes": 4758048,
"heapUsedBytes": 70370412,
"domNodes": 122,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.107999999999999,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (46 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 091325836a8172dbfecbb4cd51285ba69db98e18
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
f972ea6 to
6f27abf
Compare
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #18066 +/- ##
==========================================
+ Coverage 83.51% 84.52% +1.00%
==========================================
Files 2989 2287 -702
Lines 148019 130780 -17239
Branches 40125 33411 -6714
==========================================
- Hits 123619 110538 -13081
+ Misses 23115 19942 -3173
+ Partials 1285 300 -985
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 710 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Did a fresh, evidence-based re-check of Verified as correct (no change needed):
The actual mismatch — Pushed a fix ( I still couldn't reach this branch's raw CI logs (the Generated by Claude Code |
|
Status update after the correction ( However, I could not retrieve the exact assertion/error text: the job log and HTML report both redirect to hosts ( Separately, the Generated by Claude Code |
5ff9afc to
1c6ff17
Compare
|
Answering the two earlier status comments (5738931231, 5739449318): the The branch is rebased on Generated by Claude Code |
|
@coderabbitai review Generated by Claude Code |
|
CI wrap-up for head
Final roll-up on Generated by Claude Code |
f7f8dc2 to
3ec4778
Compare
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: request changes
I found four blocking gaps in the selection-only contract:
- Vue nodes still clone on Alt-click, toggle advanced inputs from the footer, and accept native drops while picking.
- Classic canvas picking still permits reroute and link-canvas mutations and opening node search from empty canvas.
Comfy.Graph.ToggleWidgetPromotionremains executable through the command store or a user/extension keybinding. If this stays deferred, the PR body and ADR must not claim that every mutating command is blocked.- Undo/redo decides whether to mutate in the next animation frame rather than when the shortcut was pressed, so exiting picking before that frame allows an undo pressed during picking.
The PR title also still says this is a test-only reproduction, but the exact head contains the production fix and a proposed ADR across 41 files. Please rename it so review and release history classify the change correctly.
Findings without an inline anchor
- [P1]
Comfy.Graph.ToggleWidgetPromotionbypasses the policy.useCoreCommands.ts:1108-1112directly exposestryToggleWidgetPromotion, while the generic command/keybinding path can execute it during picking. Guard it like the neighboring graph mutations, or narrow the universal lockdown claims in the PR body and ADR. - [P2] The title is stale.
test: add failing repro...no longer describes a branch that ships the policy, renderer guards, command guards, and ADR.
Checked and cleared
- I did not request centralized
mutatesGraphmetadata in this PR. ADR-CANVAS-INTERACTION-0035 explicitly defers it, so I reviewed the chosen per-site guards instead. - I kept
selectingNodesandnodeSelectionCanvasout of the findings. They still cancel queued focus and clear the entry canvas after canvas replacement. - The immediate Playwright checks of
selectOnlyare sound because the projection watcher usesflush: 'sync'and entry/exit update the store synchronously. - The earlier bot comment about Fallow complexity was for an older head. The exact-head Fallow check is green.
Coverage and verification
Deep review covered all 41 changed files in correctness, maintainability, idiomaticity, tests, and documentation shards. I traced both renderers, settings projection, command and keyboard entry points, undo/change tracking, Agent lifecycle, Playwright mocks, the proposed ADR, and the PR claims. FE-2504 does not apply to the changed AgentPanelRoot lines because they do not touch Agent graph projection or minting.
Focused red tests reproduced all three Vue bypasses. A 17-case classic-canvas harness confirmed the unguarded reroute/link/search paths. Focused lifecycle harnesses reproduced the delayed undo and lost pre-existing selectOnly value. Changed-area unit suites passed, including 99 policy/renderer tests, 197 mutation tests, and 224 AgentPanelRoot tests. Local pnpm typecheck, pnpm typecheck:browser, pnpm lint, pnpm format:check, pnpm knip, and pnpm adr:check passed. The full unit suite reached 22,457 passing tests but had six unrelated environment failures: five temporary-git tests could not create signed commits, and one Astro lint-plugin test timed out. GitHub reports 85 successful and 15 skipped checks on this exact head, with no failures, including cloud Playwright.
I could not run the real cloud browser flow locally because this orb has no ComfyUI backend/dev server. The exact-head cloud Playwright and new-test video jobs passed, and I inspected the interaction code and DOM/accessibility contracts directly.
3ec4778 to
9101265
Compare
|
Addressed the changes-requested review. New head: 9101265 (rebased onto current Findings to commits
Every P1 was reproduced by a red test on the reviewed head before the fix. Unanchored items
What the ADR now claims Three capabilities ( Verification
Generated by Claude Code |
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: ready to approve
I re-reviewed the complete diff at 9101265. The follow-up fixes address every issue from my previous review: Vue clone/footer/drop mutations, classic reroute/link/double-click mutations, widget promotion, deferred undo/redo, pre-pick selectOnly restoration, slot-interaction falsifiers, the AgentPanel E2E recipe, the redraw-budget regression, policy capability duplication, and the stale title/ADR wording. I found no remaining correctness or maintainability issue. FE-2504 does not apply because this change does not alter Agent graph projection or minting.
Red/green evidence: the old head's focused reproductions failed on the missing guards; the updated focused suite passes 8 files / 233 tests. pnpm typecheck, pnpm typecheck:browser, changed-file ESLint (0 errors; 23 pre-existing warnings), pnpm oxlint:main (0 errors; 5 warnings), pnpm format:check, and pnpm knip pass. Playwright discovers all 3 cloud cases. A direct local run could not reach the backend at localhost:8188, failing in fixture setup before test actions; CI currently has 73 successful and 25 skipped checks, no failures, and 3 pending jobs.
9101265 to
75fe420
Compare
The picking policy sync wrote commandPolicyStore.graphMutationsLocked directly, so disposing the scope while picking left mutating commands refused for good. The flag now follows the selectOnly pin's ownership: an owner set keyed per sync instance, the flag projected from its size, and the owner dropped on disposal, so stopping one of two live scopes cannot unlock the other.
Collapse is unavailable downstream during agent node picking, but the button stayed enabled and focusable, so keyboard and assistive-technology users could activate a control that did nothing. It now binds to canEditNodes, matching the title editor in the same header, and the downstream mutation guard stays in place.
The ADR now states that the graph mutation lock is owned like the selectOnly pin, and its sequence-collision note no longer claims an exact number of filenames sharing 0028, which was already wrong. Also removes the clear() docblock, which claimed the method clears all data while it releases canvas selection, clears the attached selection scope and resets transient canvas state.
LGraphCanvas takes an optional interactionMode reader and its selectOnly getter reads the canvas flag or that reader, so the application decides when the canvas is a picking surface without litegraph importing a store and without patching the accessor on the instance. The primary button classifies a press once: while select-only a node press only selects and any other press is an empty-canvas press, so the editable branch carries no select-only checks of its own.
The command store receives the same reader the canvas receives when ComfyApp creates the canvas and refuses mutatesGraph commands while it reads select-only, synchronously at dispatch, instead of reading a flag copied into commandPolicyStore.
… selectOnly The Vue node layer and the classic DOM widget layer are inert while picking, so every press, wheel and key lands on the canvas, which classifies it. The CanvasInfo watch returns to useLitegraphSettings with picking as a source. The selectOnly pin, the picking policy sync and the command policy store are removed.
…nents The node header, node body and widget grid no longer bind picking capabilities; the inert node layer blocks their input while picking.
…node composables The node event handlers and the slot link interaction no longer read picking capabilities, and resolvePickingPolicy goes with them.
The Vue node pointer interactions no longer read the picking store, since the inert layer never hands them a press; the lockdown spec clicks through the inert layer by coordinates.
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: ready to approve after the rewrite, but the route here was unacceptable.
This rewrite is the design this PR should have started with. The previous revision took one fact, copied it into several policy representations, patched a class accessor at runtime, introduced two owner registries with different lifetimes, and scattered roughly twenty guards across unrelated surfaces. Each review round repaired the latest symptom while preserving the mistake that produced it. Reviewers then had to discover ownership leaks, disposal bugs, graph-switch races, stale documentation, and missing guards created by that architecture.
That is patch accretion, not engineering. Green tests repeatedly showed that the newest patch worked; they did not make the design coherent. By the ninth round, the review process had become a substitute for stepping back and choosing the correct boundary. A strong engineering pass should have treated the growing guard inventory as evidence that the design was wrong, not as a checklist to complete. The most damning fact is that the maintainable solution appeared only after the accumulated implementation was challenged directly, and it deletes most of the machinery built during those rounds.
The current head is dramatically better. One injected reader preserves the layer boundary, the canvas classifies the gesture, the command store owns command policy, and inert renderer roots replace component-by-component defenses. I found no behavioral blocker in the rewrite. Three documentation inaccuracies remain, including one body-only item below.
Finding without an inline anchor
- P2: The PR body says
LGraphCanvas.setGraph.test.ts,AgentPanelRoot.test.ts,changeTracker.test.ts,usePaste.test.ts,useCanvasDrop.test.ts,app.test.ts, andTopMenuSection.test.tsare unchanged. Against the stated merge base, every listed file changed, andLGraphCanvas.setGraph.test.tsis new. If this means unchanged by only the final seven rewrite commits, say that. In a description of the current head, the present wording is false.
Checked and cleared
I traced the injected mode through canvas construction, graph replacement, command dispatch, pointer selection, paste, drop, history, inert Vue and DOM layers, selection persistence, and the #17048 integration. I also checked mode changes between gestures, legacy canvas.selectOnly, the canvas-info owner, drop payload variants, wheel readiness, and the local Playwright coordinate helper. Those do not produce additional findings.
Coverage and checks
Deep correctness, maintainability, idiomaticity, tests, and documentation lanes reviewed all 42 changed files at 7bcad5ce11. Frozen install, main and browser typechecks, changed-file ESLint with zero errors, type-aware Oxlint, format, Knip, ADR validation, and 669 focused unit tests passed. Playwright discovery found all four lockdown cases. Exact-head CI has 101 completed checks with no failures or pending checks.
| existing reader of `selectOnly`, including `isSelectOnly()` in | ||
| `litegraphUtil.ts`, sees the mode without a pin or a projection. | ||
|
|
||
| 3. **Three chokepoints read the mode; nothing else does.** |
There was a problem hiding this comment.
P2: This heading is false as written. Lines 131–137 immediately list four more mode-reading guards in usePaste, ChangeTracker, app.ts, and useCanvasDrop, and useSelectionOperations / litegraphUtil.createNode add further guarded mutation entry points. These may be legitimate bypass boundaries, but then this is not ‘three chokepoints; nothing else.’ Please call these three primary integration boundaries and explicitly separate the document-level guards.
There was a problem hiding this comment.
Changed in f8662d1: decision 3 is now headed "Three primary integration boundaries read the mode", and the document-level guards sit in their own labelled group, "Document-level guards outside the three boundaries", which lists every isSelectOnly() call site outside them (the usePaste paste listener, the ChangeTracker keydown listener, the app.ts drop listener, useCanvasDrop.onDrop, useSelectionOperations.deleteSelection, litegraphUtil.createNode). The two Consequences sentences that repeated "three reads" and "paste, drop and history listeners" now say the same.
Generated by Claude Code
There was a problem hiding this comment.
Tracked as FE-2840. The PR merged with this thread unresolved, so the finding is carried in Linear rather than lost here. Filed automatically; close the ticket if the finding is no longer true at main.
| node layer (`TransformPane`) and `DomWidgets.vue` renders the classic | ||
| DOM widget layer with `:inert="agentNodeSelectionStore.isActive"`. An | ||
| inert subtree receives no pointer events and cannot hold focus, so | ||
| while picking every press, wheel and key lands on the canvas, which |
There was a problem hiding this comment.
P3: inert prevents descendant focus and pointer targeting, but it does not guarantee that keyboard events retarget to the canvas. The separate document/key guards are what make keyboard behavior safe. Please limit this claim to pointer/wheel input reaching the underlying canvas and descendants being unable to retain focus.
There was a problem hiding this comment.
Changed in f8662d1: the inert bullet now claims only that the subtree is not a pointer target and that its descendants cannot take or keep focus, so press and wheel reach the canvas underneath. It states that inert promises nothing about where keyboard events go and attributes keyboard safety to processKey, commandStore.execute and the document-level guards.
Generated by Claude Code
There was a problem hiding this comment.
Tracked as FE-2840. The PR merged with this thread unresolved, so the finding is carried in Linear rather than lost here. Filed automatically; close the ticket if the finding is no longer true at main.
|
The body-only P2 is corrected. The "are unchanged" sentence under Tests now reads:
The Verification section now names the head f8662d1 ( Generated by Claude Code |
DrJKL
left a comment
There was a problem hiding this comment.
Approved at 9e59343bd4.
The rewrite is now the right design, and all three documentation findings from my prior review are fixed. I also checked the merge from main: its only conflict resolution in PR-owned code is AgentPanelRoot.test.ts, where the result preserves this branch's litegraph fixtures and main's workflow-service automock. That exact test file passes all 247 tests on the merge commit.
No remaining nits. Exact-head CI currently has no failures; 13 checks are still queued.
Requested by Christian Byrne · Slack thread
Summary
Before: entering the agent panel's "Select nodes" mode set
canvas.selectOnlyfromAgentPanelRoot.vue, which only the classic canvas honours. With Vue nodes (the cloud and desktop default) a user could still type into text widgets, rename, collapse, resize and alt-clone nodes, toggle advanced inputs, drop files onto nodes, drag or Ctrl+Alt-disconnect links and open the node menu; classic DOM widgets stayed editable; the classic canvas still allowed reroute and link drags, the link menu, double-click node search and selected-node key callbacks; Ctrl+B/M/P, arrow nudges, paste, undo/redo, group, subgraph and widget promotion commands still mutated the picked nodes; the canvas info overlay and the queue notification banners stayed visible; and exit restored saved flag values, so a setting toggled mid-mode was undone. The previous revision of this PR closed those gaps by projectingagentNodeSelectionStore.isActiveoutward: aresolvePickingPolicytruth table, a per-canvasselectOnlypin (Object.definePropertyon the canvas instance plus an owner registry), auseCanvasPickingPolicySynccomposable, acommandPolicyStore.graphMutationsLockedflag,canEditNodes/canFocusWidgetscapabilities onuseCanvasInteractions, and about twenty per-surface guards (:disabled,:inert,pointer-events-none, early returns) across the node header, node body, widgets, slot links, node event handlers, DOM widgets and media previews.After: the projection layer and the per-surface guards are gone.
agentNodeSelectionStore.isActivestays the single fact and is read at three primary integration boundaries through one small litegraph interface,CanvasInteractionModeReader { isSelectOnly(): boolean }, which the app implements over the store (createCanvasInteractionMode()) and hands to the canvas (new LGraphCanvas(el, graph, { interactionMode })) and tocommandStore.setInteractionMode()whenComfyAppcreates the canvas. litegraph never imports an app store;canvas.selectOnlyreadsstate.selectOnly || interactionMode.isSelectOnly(), so every existing reader (isSelectOnly(), paste, drops, history) sees the mode without a pin. (1)LGraphCanvas._processPrimaryButtonclassifies a press once: while select-only, a node press only registersprocessSelect(node)and any other press is an empty-canvas press (pan or selection rectangle); the editable branch with its clone, widget, collapse, slot, resize, reroute, link, badge, group and double-click handling is never entered and carries no select-only checks. (2)commandStore.executerefusesmutatesGraphcommands while the injected mode is select-only, synchronously at dispatch. (3) The Vue node layer (TransformPane) and the classic DOM widget layer (DomWidgets) areinertwhile picking, so every press and wheel lands on the canvas, no descendant can keep focus, and no widget, header button, resize handle, slot or preview needs a pointer binding of its own; keyboard safety stays withprocessKey, the command gate and the document-level guards (usePaste,ChangeTracker, theapp.tsanduseCanvasDropdrop handlers,deleteSelection,createNode), which the ADR lists as their own group. Chrome (action bars, sidebar, banner, queue overlays, canvas info) keeps reading the store;useLitegraphSettingsderivescanvas.show_info = canvasInfoEnabled && !picking. Click-to-select, panning and zooming keep working in both renderers, exit recomputes from the current settings, and staged references survive entering the mode and replacing the viewed graph.How: implements ADR-CANVAS-INTERACTION-0035 (
docs/adr/CANVAS-INTERACTION-0035-agent-node-picking-policy.md), rewritten for the chokepoint design; it records the projection layer plus per-surface guards as the rejected alternative A, with the review reasoning (policy spread across every surface, an open-ended guard set, a runtime patch of a class accessor, two owner sets releasing on different events).What the head contains
src/lib/litegraph/src/canvas/CanvasInteractionMode.ts(the reader interface and the editable default),options.interactionModeonLGraphCanvas, theselectOnlygetter reading the injected mode,#processSelectOnlyPrimaryButtonand#setupCanvasDraginLGraphCanvas.ts; the select-only checks the previous revision sprinkled through_processPrimaryButton,_processNodeClickand_startDraggingItemsare removed, andprocessKeykeeps skipping the selected-node key callbacks.LGraphCanvas.setGraph()/openSubgraph()keep the round-8 fix: the outgoing selection is released before the new graph is attached,litegraph:set-graphfires once, and the outgoing scope is dropped after the listeners run.src/renderer/core/canvas/interaction/canvasInteractionMode.tsimplements the reader over the store;app.tswires it into the canvas and the command store;commandStore.setInteractionMode()replacescommandPolicyStore;GraphCanvas.vuebinds:inertonTransformPaneandDomWidgets.vueon its root;useLitegraphSettingsowns theCanvasInfowatch again with picking as a source;useNodePointerInteractionsno longer reads the store (the layer is inert). The document-level listeners (usePaste,ChangeTrackerkeydown, thedroplistener inapp.ts,useCanvasDrop) keep theirisSelectOnly(canvas)guard, which now reads the injected mode.ComfyCommand.mutatesGraphand its declarations on the graph-mutating core commands are unchanged.pickingPolicy.ts,selectOnlyPin.ts,useCanvasPickingPolicySync.ts(and.reactiveEdge),commandPolicyStore.ts,useSlotLinkInteraction.picking.test.ts, and their tests;NodeHeader.vue,LGraphNode.vue,NodeWidgets.vue,useNodeEventHandlers.ts,useSlotLinkInteraction.ts,useCanvasInteractions.tsand its automock return to their merge-base content, as do their tests.LGraphCanvas.interactionMode.test.ts(reader absent, editable and select-only; read at interaction time rather than construction; kept acrosssetGraph(); a classic and a Vue-mode node press selects without a drag; a group press is an empty-canvas press; an empty-canvas press still pans) andcanvasInteractionMode.test.ts.LGraphCanvas.selectOnly.test.tskeeps every suppressed-path row and drives them through_processPrimaryButton.commandStore.test.tsanduseCoreCommands.selectOnly.test.tsdrive the gate throughsetInteractionMode, including decide-at-dispatch and the mask-editor predicate.DomWidgets.test.tsasserts the inert root;useLitegraphSettings.test.tsreturns with theCanvasInfo× picking table and the mid-mode toggle case. Against the merge base091325836a,LGraphCanvas.setGraph.test.tsanduseCanvasDrop.test.tsare new files andAgentPanelRoot.test.ts,changeTracker.test.ts,usePaste.test.ts,app.test.tsandTopMenuSection.test.tsare modified (git diff --stat 091325836a..HEADon the seven: 551 insertions, 60 deletions); none of the seven is touched by the seven rewrite commits7e10ad6ac9..7bcad5ce11, which carried them forward from the earlier heads.agentNodeSelectionStore.test.tsis unchanged against the merge base. The e2e lockdown spec keeps its four scenarios; the two Vue-node cases click by coordinates because the node layer is inert and the pointer target is the canvas.Review Focus
LGraphCanvas.ts: theselectOnlygetter and the early#processSelectOnlyPrimaryButtonbranch are the only litegraph reads of the mode on the primary-button path;processSelect()andselect()keep the select-only selection semantics (node-only, accumulating, empty-canvas preservation) from ADR-0028.commandStore.ts:setInteractionMode()exists because the command store cannot import the agent or canvas stores (module graph and a past dynamic-import race, recorded as alternative E in the ADR).GraphCanvas.vue/DomWidgets.vue:inertremoves hover feedback on Vue nodes while picking; recorded as a consequence and a deferred item in the ADR.useNodePointerInteractions.ts: itsisActivereads are removed because the layer is inert; if a future surface above the canvas needs to stay live while picking it must live outsideTransformPane.Verification
Head 9e59343:
f8662d1d29plus DrJKL's merge of main091325836ainto the branch, which brings the composite actions (.github/actions/tool-cache-restore,tool-cache-save) that the #18495 lint workflow references onto the branch;091325836ais the exact merge base,git merge-treeagainst it is clean, and the merge produces the same tree as replaying the branch commits onto it.f8662d1d29is7bcad5ce11plus one docs-only commit that editsdocs/adr/CANVAS-INTERACTION-0035-agent-node-picking-policy.md(decision 3 names three primary integration boundaries and lists the document-level guards as a separate labelled group; theinertclaim is limited to pointer and wheel input and to descendants not keeping focus), rebased onto maind9186aa574(the merge base before the merge;git merge-treeagainst it was clean). The seven rewrite commits are the same ones5c15396983carried on top of3d50865a1e, replayed twice as main moved: first ontof2eee4896e(one conflict insrc/workbench/extensions/agent/AgentPanelRoot.test.ts, where main widened the litegraph type import to includeLGraphwhile this branch already importsLGraph,LGraphCanvasandLGraphNodeas values; the branch import is kept and main'sstubAttachMintPortWiringandgetGraph()cases are carried unchanged), then ontod9186aa574(conflicts inbrowser_tests/tests/agent/agentPanelMocks.ts, where main addedagentConsentReads,initialFeatureFlagsandinitialSettingsto the fixture plumbing and this branch adds the@vue-nodestag setting; both are kept, with the tag'sComfy.VueNodes.Enabledspread beforeinitialSettingsso an explicit setting still wins). Main's lockfile change (@comfyorg/comfy-multi-playerbumped to acodeload.github.comtarball) is adopted as is; this branch does not touchpackage.jsonor the lockfile. Red then green (on the pre-rebase head, same diff):LGraphCanvas.interactionMode.test.ts(6 failures before the reader existed:selectOnlyreadfalsewith a select-only reader, a select-only node press still set up a drag, a Vue-mode node press selected nothing, a group press resized the group), thesetInteractionModecases incommandStore.test.tsanduseCoreCommands.selectOnly.test.ts, thedom-widgetsinert row and theCanvasInfo× picking table failed to compile or resolve before the implementation and pass after it.Gates on the docs commit:
oxfmt --checkon the ADR 0 (also as the lint-staged pre-commit hook),pnpm adr:check0,scripts/cicd/check-adr-links.sh0,pnpm knip0 as the pre-push hook,.github/scripts/check-ai-co-authors.sh 7bcad5ce11 HEADclean. Gates on7bcad5ce11, whose code this head carries unchanged, run serially on that tree:pnpm typecheck0 andpnpm typecheck:browser0,pnpm lint0 errors (188 warnings on the current main base; the only warning in a file this PR adds is oneimport-x/no-restricted-pathson thelayoutStoreautomock inLGraphCanvas.interactionMode.test.ts, the same pattern and rule as its siblingsLGraphCanvas.setGraph.test.tsandLGraphCanvas.selectOnly.test.ts),pnpm format:check0,pnpm knip0 (also as the pre-push hook),pnpm adr:check0, focused Vitest on the touched suites (60 files, 1237 tests pass, 7 expected failures, 1 skipped), the litegraph and canvas-core directories (139 files, 2064 tests pass, 7 expected failures, 5 skipped),VITE_USE_LEGACY_DEFAULT_GRAPH=true VITE_BILLING_WEB_URL=https://billing-web.example pnpm build:cloud0 andVITE_USE_LEGACY_DEFAULT_GRAPH=true pnpm build0, the lockdown Playwright spec 4/4 (--project=cloud,DISTRIBUTION=cloud, against the fresh cloud build served by a local multi-user ComfyUI), and the twoerrorsTabModeAware.spec.ts"Undo after bypass restores error without showing overlay" cases 2/2 (missing nodes, missing models) against the fresh default build.changeTracker.spec.ts"Can undo multiple operations" is flaky on this runner at its collapse-click step ("Node is not collapsed"): on the branch dist it went 1/3 in the chain and 1/3 in isolation, and a fresh default build of maind9186aa574itself went 1/3 on the same step, so it is a main-owned flake rather than rebase fallout; the same case passed 3/3 on the two earlier heads (5c15396983,89bb1162ab) where the runner was less loaded. Fullpnpm test:unitran on the pre-rebase head5c15396983(1661 files, 22976 tests pass, 21 expected failures, 7 skipped, 0 failed) and was not repeated after the rebases; CI is the arbiter for the full suite on this head. Local environment note:pnpm installcannot fetch the privatecomfy-multi-playertarball from this runner, so the package was built from a git clone of the same commit (b475423a) and placed innode_modules, and the runs used pnpm withverify-deps-before-rundisabled; the gates above are the runs with that package present..github/scripts/check-ai-co-authors.sh 091325836a HEADis clean on9e59343bd4; commit messages and the diff carry no internal references.Fixes
No GitHub issue; tracked internally.
Screenshots
None; the e2e cases assert behaviour with retrying assertions and rely on Playwright's configured failure evidence.
🤖 Generated with Claude Code
https://claude.ai/code/session_01324gEbBCJCMaz6ezqVza6c
Generated by Claude Code