Repository navigation
[backport cloud/1.54] Agent fixes catch-up 2a (PM-1656) - #18636
Conversation
…1575/PM-1576) (#18391) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1790054750260419?thread_ts=1790054750.260419&cid=C0BGH348Z0C)_ ## Summary Fixes PM-1575/PM-1576: the agent's chat-side tool-call-completion affordance ("done" spinner, "Worked for Xs" summary) settled well before the resulting graph change actually rendered on canvas, with nothing in the UI indicating the canvas hadn't caught up. This PR now contains both the failing repro test (red) and the minimal client-side fix (green). ## Changes **Before (bug):** an agent tool call that touches the canvas (e.g. adding a node) reports done — the tool's own row flips straight to its settled icon — while the canvas itself still shows nothing for the new content, for a stretch that (per the stagingcloud report) is close to 10 real seconds. `agentEventTransport.ts`'s `ingest()` flipped a tool part's `state` to `'done'` purely from the chat-channel `agent_tool_call` frame's own `status` field, with zero coupling to whether the corresponding CRDT `doc_update` had actually reached and been projected onto the canvas (`useAgentCrdtFollower.ts` / `LayoutFollowerBridge`) — two structurally disjoint listeners, never consulting each other. **After (fixed):** `createAgentEventTransport` now takes an optional `shouldAwaitCanvasSync` gate. While it returns `true`, a tool call that reports done holds its part's displayed `state` at `'streaming'` (the same spinner glyph it showed while running) instead of flipping straight to `'done'`, until either `notifyCanvasCaughtUp()` is called or `STALE_AFTER_MS` (30s) elapses — reusing the CRDT follower's own passive-heartbeat bound (`agentCrdtDocLifecycle.ts`) rather than inventing a new magic number. The gate defaults to always-`false`, so any caller that never wires it up (including every pre-existing unit test) keeps the old immediate-done behavior unchanged. `agentConversationStore.ts` threads this gate through to every transport it creates and exposes `setCanvasSyncGate` / `notifyCanvasCaughtUp` so a host can register the gate and forward catch-up signals to the active turn and any stashed background ones. `AgentPanelRoot.vue` wires the gate to `agentPanelStore.enabled` (the same flag that gates the CRDT follower itself) and calls `notifyCanvasCaughtUp()` whenever `useAgentCrdtFollower`'s `outcomes.applied` counter increases for the bound workflow — i.e. the moment a fresh doc update actually lands. **Relationship to PM-1355 (`#18179`, `agentCanvasBlanksDuringRunTurn.spec.ts`):** this mirrors that fix's *shape* (a bounded catch-up-confirmation signal) rather than reusing its primitive directly. PM-1355's `AgentCrdtDocLifecycle`/`SUBSCRIBE_CATCHUP_GRACE_MS` answers "is THIS subscribe's own catch-up frame overdue" — a question scoped to one resubscribe. This bug needed a different question answered: "has some later doc update landed since this tool call reported done", which lives one level up, at the chat-transport/composable boundary rather than inside the subscribe lifecycle. Both do reuse the same `STALE_AFTER_MS` bound as their fallback timeout, per the design guidance, rather than adding a second magic number. **Out of scope:** the actual backend ~10s doc-broadcast propagation delay itself is not addressed here — this fix only makes the client accurately reflect canvas state instead of eliminating the underlying lag. Root-causing that lag is still open (see the file-header RCA in the spec). ## Test Plan - `browser_tests/tests/agent/agentCanvasLagsToolCallCompletion.spec.ts`'s first test (previously `test.fail()`) now asserts the fix directly: after the `add_node` tool call reports `success`, its row (expanded from the "Worked for Xs" summary) stays on the spinner glyph — not the settled one — while the canvas still has zero nodes; once the delayed `doc_update` lands, the row flips to done in the same moment the node appears. - The second test (node eventually lands once the delayed `doc_update` arrives) is unchanged and still passes. - `eslint`, `vue-tsc --noEmit`, and `playwright test --list` (both tests listed and named correctly) all pass. Every existing agent-suite unit test (125 files, ~1956 tests) still passes unchanged, since the new gate defaults to off unless a caller opts in. - Could not run a real browser in this sandbox (Playwright's Chromium/headless-shell download is CDN-blocked here, same known limitation as before). ## Screenshots (if applicable) N/A — this is a Playwright spec + client-side logic change; no visual/UI screenshot to attach. Backport note (cloud/1.54). Adapted in this commit, because every commit here must pass the pre-commit lint and typecheck: - runtime: agentEventTransport.ts and its test import STALE_AFTER_MS from ../../crdt/useAgentCrdtFollower, where this line defines it (30s, the same value). main defines it in crdt/agentCrdtDocLifecycle.ts, added by the follower-layer split (#16908) that this line never got. The core/1.54 backport (#18595) made the same change. - test-only: agentConversationStore.test.ts keeps this line's pinia setup and adds ref for the new tests (conflicted import block). - test-only: the new e2e spec imports UserDataFullInfo from @/schemas/apiSchema, where this line exports it, and the shared HostDoc harness gains graph() as main has it. Left at the cloud/1.54 side here: the conflicted hunks in useAgentCrdtFollower.ts. The next commit resolves them (runtime). (cherry picked from commit fce6d77)
Backport resolution (runtime) for #18391 on cloud/1.54. main counts appliedLive through incrementOutcome, which this line's follower does not have. Its onUpdate already reads the bridge's catchUp flag, so count appliedLive there: an applied frame that is not the subscribe's own catch-up. The core/1.54 backport (#18595) made the same change.
Backport adaptation (test-only) for #18391 on cloud/1.54. agentEventTransport.test.ts pins CANVAS_MUTATING_TOOLS against every tool name recorded in browser_tests/fixtures/data/agent/conversations, a directory this line does not have. Add the 15 recorded conversations as they stand in #18391's source tree (fce6d77). They are test data only; nothing at runtime reads them.
…18603) ## Summary Three onboarding failures that used to disappear into `console.error` or an empty `catch` now reach Sentry and Datadog through `reportError`, per Christian's ask on #18431. ## Changes - **What**: - `failure_writing_tutorial_completed_setting` (warning) in `firstRunEntry.markTutorialCompleted`. The flag never persists, so Getting Started comes back on the next launch. - `error_parsing_workflow_draft_index` (warning) in `useNewUserService`. A corrupt draft index reads as "no drafts", which onboards an existing user over their work. It reports a fixed message and the index length, never the parse error, because V8's `SyntaxError` quotes the stored workflow paths. - `failure_locating_agent_coach_target` (warning) from a watchdog in `OnboardingCoach.vue`: a coach step whose element is still missing after 8s, once per selector per session. The coach otherwise polls every 50ms forever and shows nothing. - Slugs follow the `<category>_<operation>_<subject>` rule in `src/AGENTS.md`; the once-per-session guard is an inline `Set`, like `reportedNotStarted` in `onboardingTourStore`. ## Review Focus - The tutorial write only sees network failures: `settingStore.set` resolves on HTTP 5xx because `fetchApi` never checks `ok`, so a server rejection stays silent until that changes for every caller. - The watchdog is keyed on the missing selector through `useTimeoutFn`, so moving to another step re-arms it, closing the panel cancels it, and a user who already finished the coach never triggers it. - A report for the 60s first-run decision timeout was considered and dropped: a url-intent boot waits on the share dialog, so it would count a user reading that dialog as a failure. Follow-up to #18431. Backport note (cloud/1.54). Adapted in this commit, because every commit here must pass the pre-commit lint and typecheck: - test-only: the new tests in firstRunEntry.test.ts and useNewUserService.test.ts use this line's setting-store mocks (mocks.setSetting, mockSettingStore) instead of main's useSettingStore() calls. - test-only: AgentPanelRoot.test.ts takes the two onboarding-tour imports the new tests use (not main's canvasSelectionTestUtils import, which comes from #18066), and its hand-written telemetry mock gains trackAgentOnboardingNotShown and trackOnboardingTour, which the new tests reach. Left at the cloud/1.54 side here: HostTelemetrySink.ts and its test. The next commits add the shared telemetry mock the new tests rely on (test-only) and the two host-sink methods this change introduces (runtime). (cherry picked from commit d256803)
Backport adaptation (test-only) for #18603 on cloud/1.54. agentPanel.test.ts and OnboardingCoach.test.ts mock @/platform/telemetry without a factory and read methods off useTelemetry(). On main that resolves to src/platform/telemetry/__mocks__/index.ts, added by #17686, which this line does not have, so useTelemetry() returned undefined. Add the file as main has it. WorkflowTabs.test.ts, the only other suite here that mocks the module without a factory, still passes with it.
Backport resolution (runtime) for #18603 on cloud/1.54. #18603 adds trackAgentConsentNotOffered and trackAgentOnboardingNotShown to HostTelemetrySink, next to agent methods main has and this line does not. Add only the two methods this change introduces, and cover them with main's forwarding table, limited to these two events.
Make the Agent composer workflow icon and run-permissions chevron 16px. The workflow icon now matches the existing 16px working spinner. <details><summary>Changes and verification</summary> Updated against main without restoring the removed Agent-specific theme tokens. The mention-nodes icon cleanup from the original version already landed on main, so it is no longer part of this change. - 101 focused component tests passed. - Browser checks passed for rendered icon dimensions, the open run-permissions popover, and the existing save/draft flow. - The new sizing check fails against the unchanged workflow icon at 14px and passes here at 16px. - Inspected the settled popover screenshot; text and controls are legible and aligned. - Application and browser typechecks, targeted lint/format checks, and the pre-push Knip check passed. GitHub checks are running. Review focus: both changed icons use the existing sizing scale and keep the surrounding controls unchanged. No agent behavior or workflow selection logic changes. Glossary: Knip checks for unused code and dependencies. </details> Backport note (cloud/1.54): - Already on this line: RunModePopover.vue's chevron change, from #18162 (378b690), and WorkflowSelectorChip.vue, which already equals this change's version. This pick adds only the e2e test. - test-only, adapted in this commit because the pre-commit typecheck needs it: the new test opens the panel with agent.entryButton, the label the rest of this spec uses here. main's test used agent.askComfyAgent, which this line does not have. (cherry picked from commit 11a912b)
## Summary Pressing Enter while an Agent run is active now preserves the typed draft without stopping the run. The explicit Stop button remains available. ## Changes - Guard Enter submission while the composer is streaming or submitting. - Add a component regression test covering draft preservation and the absence of Stop/Send events. ## Review Focus Confirm that keyboard Enter is blocked during a run while pointer activation of Stop remains unchanged. Fixes [ComfyUI_frontend #16514](#16514) ## Linear [FE-1973](https://linear.app/comfyorg/issue/FE-1973/route-agent-composer-enter-through-the-pending-submit-guard) (cherry picked from commit 5b1d3ba)
## Summary Extracts provider-neutral gaps from frozen [#16448](#16448) onto `main`: agent API failures resolve through the existing error catalog, feedback telemetry carries nullable workflow attribution, and feedback now derives that attribution from the rated assistant message rather than mutable session state. ## Changes - Registers `agent_api_failed` and adds focused catalog-routing coverage. - Types nullable feedback `workflow_id`. - Attributes feedback to the rated message's final tab link, with last-tab and null-path regression coverage. - Omits PostHog engagement expansions, unused `VITE_AGENT_CRDT_FOLLOWER` typing, stale CRDT POC documentation, and the untranslated `agent_draft_apply_failed` key. ## Review Focus Please verify that the extraction stays provider-neutral and that per-message workflow attribution is the intended behavior when a message contains multiple or no tab links. Source: frozen [#16448](#16448) at [`278338e6a0`](278338e); original hunk authorship is preserved in the first commit trailer. ## Evidence - `gh pr checks 16491 --repo Comfy-Org/ComfyUI_frontend` — exact head [`62e11958e3`](62e1195): no pending or failed checks; unit, E2E, lint/format, custom-node matrix, performance, security, and CodeRabbit checks pass. - `git diff origin/main 278338e -- <cjx-12 files>` — confirmed the live provider-neutral residuals are `agent_api_failed` routing and nullable feedback `workflow_id`; excluded the PostHog/provider-specific telemetry surface. - `rg 'VITE_AGENT_CRDT_FOLLOWER|agentCrdtFollower|Comfy.Agent.CrdtFollower' src --glob '!vite-env.d.ts'` — no consumers; the stale environment typing and POC README instructions remain omitted. <!-- authored-by:agent lane-cjx-12-1658 --> --------- Co-authored-by: Nathaniel Parson Koroso <tetratrade@zoho.com> (cherry picked from commit c14309b)
## Summary Make the lightweight subgraph-definition ID scan agree with the full projector's ID normalization and own-key handling while remaining safe on deeply nested documents. ## Changes - **What**: Normalize shared-type IDs, ignore inherited record fields, replace recursive traversal with an explicit stack, and add discriminating regressions for all three boundaries. ## Review Focus The iterative traversal preserves depth-first definition order by pushing children in reverse. The 12,000-level regression distinguishes it from the previous recursive implementation. At exact head `b85749616595edac8d33a5840ad213264c16f000`, human review recorded 30 focused tests passing plus file-scoped ESLint and formatting checks passing; hosted CI is also green. <details><summary>Full context for agent readers</summary> This ports the still-valid high, medium, and low findings left unresolved after merged PR 16971. A `Y.Text` ID now passes through the same `plain()` projection used by the full reader. Plain records use own-key lookup, matching the projector's unsafe-key boundary. No production API or schema changes. Original findings: - #16971 (comment) - #16971 (comment) - #16971 (comment) </details> (cherry picked from commit 0ab0c96)
## Summary Use the existing shared `Tag` component for Agent chips and references. ## Changes - Share removable controls and variants with core `TagsInput`. - Use the same variants for imperative ProseMirror node views. ## Review Focus Preserve upload previews, keyboard access, reference IDs, rich clipboard serialization, and editor undo/redo. Verified 307 focused tests across Tag, TagsInput, attachment/message, composer reference/clipboard, and AgentPanel root suites. Typecheck, targeted lint, and formatting pass. Inspected interactive, removable, focus, and long-label states. Fixes [FE-2410](https://linear.app/comfyorg/issue/FE-2410). (cherry picked from commit d9186aa)
cloud/1.54 moved to b8a52c2 (#18586), which carries #18391's code and tests. This branch's #18391 commits now net out against the tip, except for two test fixes the tip needs. Resolutions: - agentCanvasLagsToolCallCompletion.spec.ts (add/add): this branch's copy. The tip's copy names enMessages.agent.askComfyAgent, which no longer exists here, and fails typecheck:browser (TS2339). This copy opens the panel with agent.entryButton and asserts on host.graph(). - AgentPanelRoot.test.ts: the tip's side in #18391's canvas-sync test (the store's tool part reaches 'done'), with this branch's #18603, #16491 and #17767 changes. - useAgentCrdtFollower.ts: the tip's version. Both sides count appliedLive, and the automatic merge counted a live frame twice. Only the tip's single count remains.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1943 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-23T21:24:23.469Z",
"gitSha": "01889531214ba36f93998f639b1ff3b89e2a294d",
"branch": "backport-agent-fixes-2-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2027.7700000000323,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.572,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.813,
"heapDeltaBytes": -7905600,
"heapUsedBytes": 62958920,
"domNodes": -278,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.432999999999999,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-idle",
"durationMs": 2051.4420000000086,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.552000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 484.36500000000007,
"heapDeltaBytes": 9161228,
"heapUsedBytes": 79306748,
"domNodes": -281,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.2239999999999975,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1999.5309999999904,
"styleRecalcs": 78,
"styleRecalcDurationMs": 33.531,
"layouts": 14,
"layoutDurationMs": 5.208,
"taskDurationMs": 950.4609999999999,
"heapDeltaBytes": 7110448,
"heapUsedBytes": 78071376,
"domNodes": -280,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 168.953,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1860.8500000000276,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.236000000000004,
"layouts": 14,
"layoutDurationMs": 3.8939999999999997,
"taskDurationMs": 834.052,
"heapDeltaBytes": -3735820,
"heapUsedBytes": 67112856,
"domNodes": -279,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 157.507,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1734.3529999999987,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.174999999999999,
"layouts": 6,
"layoutDurationMs": 1.1489999999999998,
"taskDurationMs": 344.93699999999995,
"heapDeltaBytes": 4652080,
"heapUsedBytes": 75845536,
"domNodes": 75,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 15.684,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.3380000000125,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.683,
"layouts": 6,
"layoutDurationMs": 0.9490000000000002,
"taskDurationMs": 348.171,
"heapDeltaBytes": 4618124,
"heapUsedBytes": 75276412,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 9.498,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 621.0419999999885,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.303000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.98799999999994,
"heapDeltaBytes": -7865692,
"heapUsedBytes": 63298256,
"domNodes": 18,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 159.86599999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 617.1879999999987,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.663999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 427.11299999999994,
"heapDeltaBytes": 17719752,
"heapUsedBytes": 88398372,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 155.631,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2040.0859999999739,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.961000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 609.305,
"heapDeltaBytes": 8909952,
"heapUsedBytes": 85048168,
"domNodes": -271,
"jsHeapTotalBytes": -888832,
"scriptDurationMs": 32.14500000000001,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2050.2720000000068,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.361999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 589.895,
"heapDeltaBytes": 10703748,
"heapUsedBytes": 86988324,
"domNodes": -269,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 35.352999999999994,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2295.6800000000044,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.404,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1654.61,
"heapDeltaBytes": 15463936,
"heapUsedBytes": 92770388,
"domNodes": -274,
"jsHeapTotalBytes": -1449984,
"scriptDurationMs": 829.5020000000001,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2204.287000000022,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.848999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1606.285,
"heapDeltaBytes": -8353192,
"heapUsedBytes": 68396328,
"domNodes": -281,
"jsHeapTotalBytes": 421888,
"scriptDurationMs": 799.0780000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3476.159999999993,
"styleRecalcs": 60,
"styleRecalcDurationMs": 8.726,
"layouts": 60,
"layoutDurationMs": 10.794,
"taskDurationMs": 1634.805,
"heapDeltaBytes": 8821656,
"heapUsedBytes": 76452508,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 747.809,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3476.4189999999644,
"styleRecalcs": 60,
"styleRecalcDurationMs": 8.766000000000004,
"layouts": 60,
"layoutDurationMs": 11.023000000000001,
"taskDurationMs": 1627.8389999999997,
"heapDeltaBytes": 8066140,
"heapUsedBytes": 75801012,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 746.3949999999999,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2987.4640000000454,
"styleRecalcs": 44,
"styleRecalcDurationMs": 8.385,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1887.8849999999998,
"heapDeltaBytes": 21649148,
"heapUsedBytes": 87946040,
"domNodes": -275,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 950.268,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3141.0880000000816,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.814000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1994.3039999999999,
"heapDeltaBytes": 5047932,
"heapUsedBytes": 85846048,
"domNodes": -288,
"jsHeapTotalBytes": 839680,
"scriptDurationMs": 990.882,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2062.737000000027,
"styleRecalcs": 3,
"styleRecalcDurationMs": 3.064999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 581.6200000000001,
"heapDeltaBytes": 8078612,
"heapUsedBytes": 86704820,
"domNodes": -277,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 34.68500000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2030.934000000002,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.329000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 565.7489999999999,
"heapDeltaBytes": 9300504,
"heapUsedBytes": 87468484,
"domNodes": -275,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 30.593999999999998,
"eventListeners": -194,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 560.118999999986,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.011,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 389.80199999999996,
"heapDeltaBytes": 14603600,
"heapUsedBytes": 88044304,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 138.86100000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 560.2129999999761,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.161,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 393.94199999999995,
"heapDeltaBytes": 14604236,
"heapUsedBytes": 87893456,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 138.599,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2020.1059999999984,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.043999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.603,
"heapDeltaBytes": -6336316,
"heapUsedBytes": 66929692,
"domNodes": -295,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 6.845000000000001,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2017.6100000000474,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.728000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.24000000000007,
"heapDeltaBytes": 9138200,
"heapUsedBytes": 82430300,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.9910000000000005,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1749.3610000000217,
"styleRecalcs": 78,
"styleRecalcDurationMs": 25.617,
"layouts": 18,
"layoutDurationMs": 4.1370000000000005,
"taskDurationMs": 779.8009999999999,
"heapDeltaBytes": -6992764,
"heapUsedBytes": 65255496,
"domNodes": -297,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 104.107,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1757.09599999999,
"styleRecalcs": 80,
"styleRecalcDurationMs": 28.544,
"layouts": 18,
"layoutDurationMs": 4.890999999999999,
"taskDurationMs": 789.7539999999999,
"heapDeltaBytes": 8484376,
"heapUsedBytes": 81777564,
"domNodes": -295,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 105.207,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1383.4239999999909,
"styleRecalcs": 19,
"styleRecalcDurationMs": 31.221,
"layouts": 15,
"layoutDurationMs": 15.438,
"taskDurationMs": 898.0499999999998,
"heapDeltaBytes": 21085200,
"heapUsedBytes": 110245472,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 28.237,
"eventListeners": 2387,
"totalBlockingTimeMs": 138,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8415.877999999964,
"styleRecalcs": 248,
"styleRecalcDurationMs": 33.842999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5751.827,
"heapDeltaBytes": 14902824,
"heapUsedBytes": 91536484,
"domNodes": -269,
"jsHeapTotalBytes": -401408,
"scriptDurationMs": 2716.493,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8291.782000000012,
"styleRecalcs": 247,
"styleRecalcDurationMs": 32.205,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5608.366,
"heapDeltaBytes": 1151432,
"heapUsedBytes": 77329140,
"domNodes": -273,
"jsHeapTotalBytes": 909312,
"scriptDurationMs": 2613.8350000000005,
"eventListeners": -148,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 16500.502999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15625.742,
"heapDeltaBytes": -40164384,
"heapUsedBytes": 178242928,
"domNodes": -8068,
"jsHeapTotalBytes": -12541952,
"scriptDurationMs": 269.977,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 16534.89300000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15912.455999999998,
"heapDeltaBytes": -56815496,
"heapUsedBytes": 181800900,
"domNodes": -8068,
"jsHeapTotalBytes": -14856192,
"scriptDurationMs": 256.07,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20143.353000000046,
"styleRecalcs": 168,
"styleRecalcDurationMs": 15.892000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19745.139000000003,
"heapDeltaBytes": -62971772,
"heapUsedBytes": 167560824,
"domNodes": -8068,
"jsHeapTotalBytes": -19574784,
"scriptDurationMs": 863.337,
"eventListeners": -14929,
"totalBlockingTimeMs": 172,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20931.208999999966,
"styleRecalcs": 173,
"styleRecalcDurationMs": 17.52199999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20496.603,
"heapDeltaBytes": -46567776,
"heapUsedBytes": 192459424,
"domNodes": -8068,
"jsHeapTotalBytes": -19517440,
"scriptDurationMs": 916.655,
"eventListeners": -14927,
"totalBlockingTimeMs": 66,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5891.210999999998,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.54500000000003,
"layouts": 20,
"layoutDurationMs": 21.058999999999994,
"taskDurationMs": 5763.069999999999,
"heapDeltaBytes": -41349872,
"heapUsedBytes": 176248200,
"domNodes": -8068,
"jsHeapTotalBytes": 8404992,
"scriptDurationMs": 104.42699999999999,
"eventListeners": -14927,
"totalBlockingTimeMs": 349,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5823.7570000000005,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.46999999999998,
"layouts": 20,
"layoutDurationMs": 21.958999999999993,
"taskDurationMs": 5689.006000000001,
"heapDeltaBytes": -34503060,
"heapUsedBytes": 183002476,
"domNodes": -8068,
"jsHeapTotalBytes": 18046976,
"scriptDurationMs": 99.07,
"eventListeners": -14931,
"totalBlockingTimeMs": 395,
"frameDurationMs": 18.329999999999988,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8232.348999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7807.646999999999,
"heapDeltaBytes": 985688,
"heapUsedBytes": 180231320,
"domNodes": 0,
"jsHeapTotalBytes": -23068672,
"scriptDurationMs": 123.896,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8303.95699999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7848.723999999999,
"heapDeltaBytes": 11799028,
"heapUsedBytes": 178535848,
"domNodes": 0,
"jsHeapTotalBytes": -22806528,
"scriptDurationMs": 122.78100000000003,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 98.6520000000155,
"styleRecalcs": 6,
"styleRecalcDurationMs": 14.445,
"layouts": 2,
"layoutDurationMs": 0.818,
"taskDurationMs": 72.97300000000001,
"heapDeltaBytes": 3105720,
"heapUsedBytes": 71600788,
"domNodes": 108,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.347000000000002,
"eventListeners": 35,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 89.92899999998372,
"styleRecalcs": 8,
"styleRecalcDurationMs": 12.906,
"layouts": 2,
"layoutDurationMs": 1.023,
"taskDurationMs": 66.417,
"heapDeltaBytes": 3013472,
"heapUsedBytes": 71600676,
"domNodes": 106,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.724999999999998,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## cloud/1.54 #18636 +/- ##
=============================================
Coverage ? 83.71%
=============================================
Files ? 2109
Lines ? 124937
Branches ? 31673
=============================================
Hits ? 104590
Misses ? 20168
Partials ? 179
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Summary
Backports six merged
mainAgent fixes tocloud/1.54and repairs theagentCanvasLagsToolCallCompletione2e spec that #18586 landed with, which failstypecheck:browseron the current branch tip.Changes
cherry-pick -xof agent: normalize icon sizing to the established scale tokens #17568, fix(agent): preserve drafts when Enter is pressed during runs #17628, fix(agent): carry provider-neutral error metadata #16491, Fix subgraph definition ID scan edge cases #18453, refactor: consolidate Agent chip presentation (FE-2410) #17767 and fix(onboarding): report three onboarding failures that were silent #18603, inmainmerge order. The spec fix usesentryButtonand the "Worked for" summary instead of the labels [backport cloud/1.54] Agent UI catch-up for staging and prod (PM-1657) #18622 removed, and addsHostDoc.graph()to the conversation host-doc fixture. fix: agent tool-call chat completion lags canvas materialization (PM-1575/PM-1576) #18391 itself is already on the line via [backport cloud/1.54] chore: backport BE-11470 conversation-replay fixtures #18586 and is unchanged here.src/lib/litegraph/half).Review Focus
AgentPanelRoot.vuechanges come from fix(agent): carry provider-neutral error metadata #16491 and refactor: consolidate Agent chip presentation (FE-2410) #17767 on top of fix: agent tool-call chat completion lags canvas materialization (PM-1575/PM-1576) #18391's merged code;useAgentCrdtFollower.tsis identical to the tip.AgentPanelRoot.test.ts(the tip's fix: agent tool-call chat completion lags canvas materialization (PM-1575/PM-1576) #18391 test plus these picks).Linear: PM-1656
Screenshots (if applicable)
No new visuals; #17568 and #17767 were reviewed on
main.