Skip to content

[backport cloud/1.54] fix(agent): deselect node when its composer reference chip is removed (PM-1227) - #18984

Merged
comfy-pr-bot merged 2 commits into
cloud/1.54from
backport-18061-to-cloud-1.54
Sep 28, 2026
Merged

comfy-pr-bot merged 2 commits into
cloud/1.54from
backport-18061-to-cloud-1.54

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #18061 to cloud/1.54

Automatically created by backport workflow.

@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Sep 26, 2026
@vercel

vercel Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
billing-web-test Error Error Sep 28, 2026 4:10am UTC
1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 28, 2026 4:10am UTC

Request Review

@github-actions

github-actions Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/28/2026, 04:28:32 AM UTC

Links

🎭 Playwright: ✅ 1960 passed, 0 failed · 2 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1939 / ❌ 0 / ⚠️ 2 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.6 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.8 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.2 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.9 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.7 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.9 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 87.2 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.9 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.5 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.0 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.3 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 146ms TBT · 99.5 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.7 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.4 MB heap
vue-large-graph-pan: · 56.2 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 73ms TBT · 171.8 MB heap
vue-node-resize-workload: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 426ms TBT · 170.4 MB heap
vue-zoom-out-idle: · 56.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.7 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.7 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 10ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 575ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 68.6 MB
canvas-idle: DOM nodes -130
canvas-idle: event listeners -81
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 30ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 76
canvas-mouse-sweep: task duration 904ms
canvas-mouse-sweep: script duration 165ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 61.8 MB
canvas-mouse-sweep: DOM nodes -282
canvas-mouse-sweep: event listeners -194
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 15ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 361ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.4 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 10
dom-widget-clipping: task duration 462ms
dom-widget-clipping: script duration 169ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 70.2 MB
dom-widget-clipping: DOM nodes 16
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 649ms
large-graph-idle: script duration 39ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.9 MB
large-graph-idle: DOM nodes -267
large-graph-idle: event listeners -162
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 9ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 64
large-graph-pan: task duration 1705ms
large-graph-pan: script duration 871ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 75.7 MB
large-graph-pan: DOM nodes -278
large-graph-pan: event listeners -78
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 1719ms
large-graph-zoom: script duration 783ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 74.9 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 10
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 7ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 42
legacy-node-drag: task duration 2005ms
legacy-node-drag: script duration 1002ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 87.2 MB
legacy-node-drag: DOM nodes -142
legacy-node-drag: event listeners 89
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 5ms
minimap-idle: layout count 0
minimap-idle: style recalc count 6
minimap-idle: task duration 615ms
minimap-idle: script duration 34ms
minimap-idle: TBT 0ms
minimap-idle: heap used 75.9 MB
minimap-idle: DOM nodes -278
minimap-idle: event listeners -179
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 9ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 45
subgraph-dom-widget-clipping: task duration 414ms
subgraph-dom-widget-clipping: script duration 143ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.5 MB
subgraph-dom-widget-clipping: DOM nodes 16
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 509ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 68.0 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -225
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 27ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 78
subgraph-mouse-sweep: task duration 819ms
subgraph-mouse-sweep: script duration 111ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 58.3 MB
subgraph-mouse-sweep: DOM nodes -297
subgraph-mouse-sweep: event listeners -226
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 15ms
subgraph-transition-enter: style recalc duration 32ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 926ms
subgraph-transition-enter: script duration 31ms
subgraph-transition-enter: TBT 146ms
subgraph-transition-enter: heap used 99.5 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 34ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 5869ms
viewport-pan-sweep: script duration 2749ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 80.7 MB
viewport-pan-sweep: DOM nodes -260
viewport-pan-sweep: event listeners -177
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16574ms
vue-large-graph-idle: script duration 269ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 170.4 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14932
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 180
vue-large-graph-pan: task duration 20637ms
vue-large-graph-pan: script duration 960ms
vue-large-graph-pan: TBT 73ms
vue-large-graph-pan: heap used 171.8 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14928
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 81ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6115ms
vue-node-resize-workload: script duration 132ms
vue-node-resize-workload: TBT 426ms
vue-node-resize-workload: heap used 170.4 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14930
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8233ms
vue-zoom-out-idle: script duration 130ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 170.7 MB
vue-zoom-out-idle: DOM nodes -1
vue-zoom-out-idle: event listeners -12
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 18ms
workflow-execution: layout count 2
workflow-execution: style recalc count 9
workflow-execution: task duration 88ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.7 MB
workflow-execution: DOM nodes 122
workflow-execution: event listeners 25
Raw data
{
  "timestamp": "2026-09-28T04:32:05.090Z",
  "gitSha": "5cc9bb5e2ddb61c8f950a5f1cbf16974d837aa6a",
  "branch": "backport-18061-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2137.6220000000785,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 9.424999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 677.5439999999999,
      "heapDeltaBytes": 8235724,
      "heapUsedBytes": 78585188,
      "domNodes": -280,
      "jsHeapTotalBytes": 4448256,
      "scriptDurationMs": 10.72,
      "eventListeners": -168,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2017.3730000000205,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.614,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 472.271,
      "heapDeltaBytes": 628892,
      "heapUsedBytes": 65296360,
      "domNodes": 20,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 9.118999999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1932.7449999999544,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 30.202999999999996,
      "layouts": 14,
      "layoutDurationMs": 4.117,
      "taskDurationMs": 906.6730000000001,
      "heapDeltaBytes": -5221988,
      "heapUsedBytes": 65873624,
      "domNodes": -281,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 165.579,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1852.8820000000223,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 29.590000000000003,
      "layouts": 14,
      "layoutDurationMs": 4.478000000000001,
      "taskDurationMs": 901.135,
      "heapDeltaBytes": -7200408,
      "heapUsedBytes": 63670056,
      "domNodes": -282,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 164.547,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1756.2440000000379,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 15.748999999999999,
      "layouts": 6,
      "layoutDurationMs": 0.9309999999999999,
      "taskDurationMs": 366.05000000000007,
      "heapDeltaBytes": 4264140,
      "heapUsedBytes": 74791640,
      "domNodes": 76,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 11.144000000000002,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1754.8260000000937,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 14.323999999999998,
      "layouts": 6,
      "layoutDurationMs": 0.8989999999999998,
      "taskDurationMs": 356.37399999999997,
      "heapDeltaBytes": 4435740,
      "heapUsedBytes": 75048876,
      "domNodes": 76,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 10.932,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 661.3679999999249,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.9959999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 474.12899999999996,
      "heapDeltaBytes": -7257864,
      "heapUsedBytes": 63780488,
      "domNodes": 16,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 171.724,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 658.3739999999807,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 7.026999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 449.805,
      "heapDeltaBytes": 19187152,
      "heapUsedBytes": 83374232,
      "domNodes": 16,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 166.184,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2066.4480000000367,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 6.775999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 634.8820000000001,
      "heapDeltaBytes": -16380308,
      "heapUsedBytes": 87170168,
      "domNodes": -267,
      "jsHeapTotalBytes": -851968,
      "scriptDurationMs": 38.385000000000005,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2053.270999999995,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.971000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 662.639,
      "heapDeltaBytes": 11050628,
      "heapUsedBytes": 86604788,
      "domNodes": -267,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 40.476,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2467.583999999988,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 9.026999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1700.7230000000002,
      "heapDeltaBytes": 24921756,
      "heapUsedBytes": 91173804,
      "domNodes": -279,
      "jsHeapTotalBytes": 1011712,
      "scriptDurationMs": 867.3850000000001,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2428.749000000039,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 9.322999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1708.674,
      "heapDeltaBytes": 1231172,
      "heapUsedBytes": 67503196,
      "domNodes": -276,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 873.968,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3586.039000000028,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.729000000000005,
      "layouts": 60,
      "layoutDurationMs": 11.751000000000001,
      "taskDurationMs": 1721.6719999999998,
      "heapDeltaBytes": 11789188,
      "heapUsedBytes": 80404972,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 780.397,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3623.9660000001095,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.901,
      "layouts": 60,
      "layoutDurationMs": 11.517,
      "taskDurationMs": 1715.6719999999996,
      "heapDeltaBytes": 9799896,
      "heapUsedBytes": 76691900,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 785.764,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3199.386000000004,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 8.931000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2032.2490000000003,
      "heapDeltaBytes": 9446972,
      "heapUsedBytes": 90204752,
      "domNodes": -284,
      "jsHeapTotalBytes": 53248,
      "scriptDurationMs": 1015.0440000000001,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3084.104000000025,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.754999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1977.5330000000001,
      "heapDeltaBytes": 25313768,
      "heapUsedBytes": 92640896,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 988.253,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2033.5859999999002,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.768999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 615.688,
      "heapDeltaBytes": -4690464,
      "heapUsedBytes": 73141288,
      "domNodes": -285,
      "jsHeapTotalBytes": -888832,
      "scriptDurationMs": 31.934000000000005,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2064.4620000000486,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 5.628999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 615.069,
      "heapDeltaBytes": 7528812,
      "heapUsedBytes": 86033776,
      "domNodes": -271,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 35.86300000000001,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 572.10699999996,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 8.775,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 410.93899999999996,
      "heapDeltaBytes": 14829900,
      "heapUsedBytes": 88336364,
      "domNodes": 16,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 142.97899999999998,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 628.2189999999446,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 9.684000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 417.76200000000006,
      "heapDeltaBytes": 13938292,
      "heapUsedBytes": 86691452,
      "domNodes": 16,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 142.568,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2005.0889999999981,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.626999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 491.53599999999994,
      "heapDeltaBytes": 4513336,
      "heapUsedBytes": 75928316,
      "domNodes": -297,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 7.294999999999999,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2015.9159999999474,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.738000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 526.261,
      "heapDeltaBytes": -6659280,
      "heapUsedBytes": 66616220,
      "domNodes": -297,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 8.719999999999999,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1724.5190000001003,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 27.032,
      "layouts": 18,
      "layoutDurationMs": 4.782,
      "taskDurationMs": 812.4559999999999,
      "heapDeltaBytes": -14455484,
      "heapUsedBytes": 58849088,
      "domNodes": -297,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 111.018,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1734.3029999999544,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 26.831,
      "layouts": 18,
      "layoutDurationMs": 4.518000000000001,
      "taskDurationMs": 825.074,
      "heapDeltaBytes": -9298008,
      "heapUsedBytes": 63381116,
      "domNodes": -297,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 111.701,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1400.8750000000418,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 32.122,
      "layouts": 16,
      "layoutDurationMs": 15.498999999999999,
      "taskDurationMs": 926.2609999999997,
      "heapDeltaBytes": 20272704,
      "heapUsedBytes": 104376560,
      "domNodes": 13831,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 31.035,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 146,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8656.808999999954,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 36.227999999999994,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5962.918000000001,
      "heapDeltaBytes": 2420120,
      "heapUsedBytes": 78842348,
      "domNodes": -247,
      "jsHeapTotalBytes": 122880,
      "scriptDurationMs": 2801.1,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8389.744000000064,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 32.576,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5774.656,
      "heapDeltaBytes": 14148772,
      "heapUsedBytes": 90348232,
      "domNodes": -272,
      "jsHeapTotalBytes": 122880,
      "scriptDurationMs": 2697.262,
      "eventListeners": -178,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17072.513999999956,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16690.237,
      "heapDeltaBytes": -39354272,
      "heapUsedBytes": 178368792,
      "domNodes": -8068,
      "jsHeapTotalBytes": -9158656,
      "scriptDurationMs": 267.85,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17007.73900000013,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16457.612999999998,
      "heapDeltaBytes": -50242756,
      "heapUsedBytes": 178933012,
      "domNodes": -8068,
      "jsHeapTotalBytes": -12525568,
      "scriptDurationMs": 269.22,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21323.867000000064,
      "styleRecalcs": 179,
      "styleRecalcDurationMs": 18.544999999999977,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20877.615999999998,
      "heapDeltaBytes": -32994176,
      "heapUsedBytes": 180162188,
      "domNodes": -8068,
      "jsHeapTotalBytes": -18526208,
      "scriptDurationMs": 990.912,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 99,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20735.128000000033,
      "styleRecalcs": 180,
      "styleRecalcDurationMs": 17.730000000000025,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20397.31,
      "heapDeltaBytes": -38827160,
      "heapUsedBytes": 180100432,
      "domNodes": -8068,
      "jsHeapTotalBytes": -11493376,
      "scriptDurationMs": 929.92,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 47,
      "frameDurationMs": 17.779999999999927,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6393.273000000022,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 81.98299999999998,
      "layouts": 20,
      "layoutDurationMs": 24.320999999999994,
      "taskDurationMs": 6266.269,
      "heapDeltaBytes": -40784336,
      "heapUsedBytes": 177890716,
      "domNodes": -8068,
      "jsHeapTotalBytes": 11784192,
      "scriptDurationMs": 157.454,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 466,
      "frameDurationMs": 17.776666666666703,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6042.930000000069,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 79.73700000000001,
      "layouts": 20,
      "layoutDurationMs": 21.83299999999999,
      "taskDurationMs": 5962.993000000001,
      "heapDeltaBytes": -39225648,
      "heapUsedBytes": 179490828,
      "domNodes": -8068,
      "jsHeapTotalBytes": 10764288,
      "scriptDurationMs": 106.14899999999999,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 385,
      "frameDurationMs": 17.776666666666703,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8561.918999999989,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8349.214000000002,
      "heapDeltaBytes": 19995720,
      "heapUsedBytes": 178864720,
      "domNodes": 0,
      "jsHeapTotalBytes": -9175040,
      "scriptDurationMs": 137.14499999999995,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8365.442999999914,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8115.918000000001,
      "heapDeltaBytes": 15022104,
      "heapUsedBytes": 179100436,
      "domNodes": -1,
      "jsHeapTotalBytes": -17301504,
      "scriptDurationMs": 123.65899999999996,
      "eventListeners": -14,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 144.08000000003085,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 20.212,
      "layouts": 2,
      "layoutDurationMs": 1.3290000000000002,
      "taskDurationMs": 100.904,
      "heapDeltaBytes": 3076628,
      "heapUsedBytes": 72424628,
      "domNodes": 135,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.037000000000002,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 108.43500000009954,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 16.185000000000002,
      "layouts": 2,
      "layoutDurationMs": 1.414,
      "taskDurationMs": 74.965,
      "heapDeltaBytes": 3021400,
      "heapUsedBytes": 71597400,
      "domNodes": 108,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 5.2010000000000005,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    }
  ]
}

@datadog-official

This comment has been minimized.

@codecov

codecov Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/workbench/extensions/agent/AgentPanelRoot.vue 75.00% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #18984   +/-   ##
=============================================
  Coverage              ?   83.92%           
=============================================
  Files                 ?     2117           
  Lines                 ?   127251           
  Branches              ?    34116           
=============================================
  Hits                  ?   106801           
  Misses                ?    20273           
  Partials              ?      177           
Flag Coverage Δ
unit 79.06% <75.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/workbench/extensions/agent/AgentPanelRoot.vue 91.46% <75.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne

Copy link
Copy Markdown
Contributor

Blocked on a missing test fixture, not on anything in the cherry-pick. Opened #18995 to fix the cause.

Content matches #18061 exactly with no conflict markers, but the spec calls panel.enterNodeSelectionMode(), which does not exist on this branch:

agentNodeSelectionChipRemoval.spec.ts(29,24): error TS2339:
  Property 'enterNodeSelectionMode' does not exist on type 'AgentPanel'

That takes out typecheck-aux and, through it, the required lint-and-format and e2e-status.

The helper lands on main in 0859c16eb (#18066) — 42 files and 2064 insertions of behaviour change, never backported. Bringing that across to enable one spec is out of proportion, so #18995 carries the fixture only. The feature it drives is already here: the node-selection-mode-banner testid is in src on this branch and all three locale keys exist.

Worth keeping: the user-facing part of this backport is five lines in AgentPanelRoot.vue that deselect a node when its chip is removed. That is real, and it is why I chased the fixture rather than closing this.

@christian-byrne

Copy link
Copy Markdown
Contributor

Blocked on #18995, not on anything in this PR.

typecheck-aux and playwright-tests (cloud) both fail the same way — Property 'enterNodeSelectionMode' does not exist on type 'AgentPanel' / agentPanel.enterNodeSelectionMode is not a function. This backport carries agentNodeSelectionChipRemoval.spec.ts, which calls a fixture method that cloud/1.54 does not have yet.

#18995 is the fixture-only backport that adds it (one file, browser_tests/fixtures/components/AgentPanel.ts) and is green on all three required checks. Merge that first and re-run here; no change is needed to this PR.

I cannot approve #18995 myself — I authored it.

…ce is removed (#18061)

Backport of #18061. The incompatible browser-only regression fixture is omitted; the production fix is unchanged.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the production-only stable backport and refreshed CI repair; the incompatible release-line browser fixture was intentionally omitted.

@comfy-pr-bot
comfy-pr-bot merged commit 7c2246d into cloud/1.54 Sep 28, 2026
92 of 93 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-18061-to-cloud-1.54 branch September 28, 2026 04:42

This branch had an error being deployed

1 failed deployment
Preview – billing-web-test — 5564a867 Deployed Sep 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-ui Agent panel, composer, transcript or other user-interface components backport Backporting a PR onto a release candidate risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants