Skip to content

test(agent): carry the node-selection fixture helpers to cloud/1.54 - #18995

Closed
christian-byrne wants to merge 1 commit into
cloud/1.54from
fix/node-selection-fixture-cloud-1.54
Closed

christian-byrne wants to merge 1 commit into
cloud/1.54from
fix/node-selection-fixture-cloud-1.54

Conversation

@christian-byrne

Copy link
Copy Markdown
Contributor

Unblocks #18984.

That backport's spec calls panel.enterNodeSelectionMode(), which does not exist on cloud/1.54, so it fails typecheck-aux and through it the required lint-and-format and e2e-status:

agentNodeSelectionChipRemoval.spec.ts(29,24): error TS2339:
  Property 'enterNodeSelectionMode' does not exist on type 'AgentPanel'

The helper arrives on main in 0859c16eb (#18066) — 42 files, 2064 insertions of behaviour change, never backported anywhere. Pulling that across to enable one spec is out of proportion, so this brings only the fixture, which is test-side.

Everything it drives already exists on this branch, checked rather than assumed: the node-selection-mode-banner testid is in src here, and agent.addToPrompt, agent.nodes and agent.nodeSelection.exit are all in the locale file. open(), selectWorkflow(), root and page are already on the fixture. The gap was the helper alone, not the feature.

exitNodeSelectionMode comes along as its pair; the spec only uses enter.

#18983 and #18984 backport the PM-1227 fix, whose spec calls
`panel.enterNodeSelectionMode()`. That helper does not exist here, so both fail
`typecheck-aux` and, through it, the required `lint-and-format` and
`e2e-status`:

  agentNodeSelectionChipRemoval.spec.ts(29,24): error TS2339:
    Property "enterNodeSelectionMode" does not exist on type "AgentPanel"

The helper arrives on main in `0859c16eb` (#18066), which is 42 files and 2064
insertions of behaviour change and has never been backported. Importing that to
enable one spec would be wildly out of proportion, and the rule is to bring the
missing module rather than rewrite the caller -- so this brings only the
fixture, which is test-side.

Everything it drives already exists here, checked rather than assumed: the
`node-selection-mode-banner` testid is in `src` on this branch, and
`agent.addToPrompt`, `agent.nodes` and `agent.nodeSelection.exit` are all in the
locale file. `open()`, `selectWorkflow()`, `root` and `page` are already on the
fixture. So the gap was the helper alone, not the feature.

`exitNodeSelectionMode` comes along as its pair; the spec only uses enter.
@vercel

vercel Bot commented Sep 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
billing-web-test Error Error Sep 26, 2026 11:53am UTC
1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 26, 2026 11:53am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 26, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: d1bc6de0-b060-458b-a488-069d57805251

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1958 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1937 / ❌ 0 / ⚠️ 1 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.3 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.6 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.2 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.2 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.5 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 74.3 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.9 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.5 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.2 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.9 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 147ms TBT · 105.3 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.5 MB heap
vue-large-graph-idle: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 172.0 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 99ms TBT · 166.9 MB heap
vue-node-resize-workload: · 53.7 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 416ms TBT · 169.3 MB heap
vue-zoom-out-idle: · 54.5 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.8 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.7 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 8ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 494ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 67.3 MB
canvas-idle: DOM nodes -280
canvas-idle: event listeners -165
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 32ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 77
canvas-mouse-sweep: task duration 966ms
canvas-mouse-sweep: script duration 178ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 65.6 MB
canvas-mouse-sweep: DOM nodes -283
canvas-mouse-sweep: event listeners -181
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 18ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 406ms
canvas-zoom-sweep: script duration 14ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.4 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 20
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 459ms
dom-widget-clipping: script duration 165ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.2 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 4ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 626ms
large-graph-idle: script duration 34ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.2 MB
large-graph-idle: DOM nodes -270
large-graph-idle: event listeners -162
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 9ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 63
large-graph-pan: task duration 1683ms
large-graph-pan: script duration 841ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 85.5 MB
large-graph-pan: DOM nodes -139
large-graph-pan: event listeners 7
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 61
large-graph-zoom: task duration 1744ms
large-graph-zoom: script duration 776ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 74.3 MB
large-graph-zoom: DOM nodes -144
large-graph-zoom: event listeners -90
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 8ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 43
legacy-node-drag: task duration 2105ms
legacy-node-drag: script duration 1034ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 84.6 MB
legacy-node-drag: DOM nodes -270
legacy-node-drag: event listeners -11
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 4ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 582ms
minimap-idle: script duration 35ms
minimap-idle: TBT 0ms
minimap-idle: heap used 82.9 MB
minimap-idle: DOM nodes -273
minimap-idle: event listeners -93
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 12ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 47
subgraph-dom-widget-clipping: task duration 426ms
subgraph-dom-widget-clipping: script duration 147ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.5 MB
subgraph-dom-widget-clipping: DOM nodes 20
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 10ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 529ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 65.2 MB
subgraph-idle: DOM nodes -295
subgraph-idle: event listeners -240
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 29ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 76
subgraph-mouse-sweep: task duration 862ms
subgraph-mouse-sweep: script duration 117ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 57.9 MB
subgraph-mouse-sweep: DOM nodes -298
subgraph-mouse-sweep: event listeners -226
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 17ms
subgraph-transition-enter: style recalc duration 34ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 1016ms
subgraph-transition-enter: script duration 33ms
subgraph-transition-enter: TBT 147ms
subgraph-transition-enter: heap used 105.3 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 36ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 246
viewport-pan-sweep: task duration 6162ms
viewport-pan-sweep: script duration 2800ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 86.5 MB
viewport-pan-sweep: DOM nodes -274
viewport-pan-sweep: event listeners -160
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 17189ms
vue-large-graph-idle: script duration 296ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 172.0 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14933
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 19ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 166
vue-large-graph-pan: task duration 20846ms
vue-large-graph-pan: script duration 921ms
vue-large-graph-pan: TBT 99ms
vue-large-graph-pan: heap used 166.9 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14928
vue-node-resize-workload: avg frame time 19ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 24ms
vue-node-resize-workload: style recalc duration 82ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6330ms
vue-node-resize-workload: script duration 135ms
vue-node-resize-workload: TBT 416ms
vue-node-resize-workload: heap used 169.3 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14930
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8664ms
vue-zoom-out-idle: script duration 163ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 169.8 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -12
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 17ms
workflow-execution: layout count 2
workflow-execution: style recalc count 7
workflow-execution: task duration 77ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.7 MB
workflow-execution: DOM nodes 109
workflow-execution: event listeners 33
Raw data
{
  "timestamp": "2026-09-26T12:04:38.465Z",
  "gitSha": "692404f7e52742bcdeeeafd8d737a817f5990701",
  "branch": "fix/node-selection-fixture-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2056.18400000003,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 7.396000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 492.772,
      "heapDeltaBytes": 10618748,
      "heapUsedBytes": 81402860,
      "domNodes": -279,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 8.649000000000004,
      "eventListeners": -164,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2017.8990000000567,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.256999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 495.91999999999996,
      "heapDeltaBytes": -10591852,
      "heapUsedBytes": 59674256,
      "domNodes": -281,
      "jsHeapTotalBytes": 4710400,
      "scriptDurationMs": 8.677999999999999,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1998.8370000000373,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 34.381,
      "layouts": 14,
      "layoutDurationMs": 4.162,
      "taskDurationMs": 1034.3360000000002,
      "heapDeltaBytes": 2831648,
      "heapUsedBytes": 73387448,
      "domNodes": -284,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 191.002,
      "eventListeners": -168,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1883.2390000000032,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 29.972,
      "layouts": 14,
      "layoutDurationMs": 4.056000000000001,
      "taskDurationMs": 898.064,
      "heapDeltaBytes": -5966440,
      "heapUsedBytes": 64246196,
      "domNodes": -281,
      "jsHeapTotalBytes": 6807552,
      "scriptDurationMs": 164.353,
      "eventListeners": -194,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1744.6150000000102,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 19.061999999999998,
      "layouts": 6,
      "layoutDurationMs": 1.369,
      "taskDurationMs": 457.98900000000003,
      "heapDeltaBytes": 4618412,
      "heapUsedBytes": 75988764,
      "domNodes": 75,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 16.968,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1722.976000000017,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.189000000000004,
      "layouts": 6,
      "layoutDurationMs": 1.0439999999999998,
      "taskDurationMs": 354.966,
      "heapDeltaBytes": 4487888,
      "heapUsedBytes": 75926392,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 11.068999999999999,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 687.6280000000179,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.662999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 460.68399999999997,
      "heapDeltaBytes": 18385848,
      "heapUsedBytes": 88584820,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 164.95,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 676.3320000000022,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.927999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 457.18499999999995,
      "heapDeltaBytes": -7539552,
      "heapUsedBytes": 62927200,
      "domNodes": 18,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 164.148,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2038.1970000000251,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.268999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 662.618,
      "heapDeltaBytes": 10513284,
      "heapUsedBytes": 87141972,
      "domNodes": -271,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 35.01499999999999,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2051.965999999993,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 4.33,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 588.582,
      "heapDeltaBytes": -16587760,
      "heapUsedBytes": 87287192,
      "domNodes": -268,
      "jsHeapTotalBytes": -1114112,
      "scriptDurationMs": 32.85099999999999,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2741.8990000000463,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 10.068999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1776.5010000000002,
      "heapDeltaBytes": 23689096,
      "heapUsedBytes": 89817284,
      "domNodes": -278,
      "jsHeapTotalBytes": 1536000,
      "scriptDurationMs": 869.6870000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2216.996999999992,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 7.746999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1589.859,
      "heapDeltaBytes": 22798680,
      "heapUsedBytes": 89554900,
      "domNodes": 0,
      "jsHeapTotalBytes": 749568,
      "scriptDurationMs": 811.9499999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3664.9679999999876,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 11.344999999999997,
      "layouts": 60,
      "layoutDurationMs": 12.211,
      "taskDurationMs": 1815.6310000000003,
      "heapDeltaBytes": -3410008,
      "heapUsedBytes": 75797592,
      "domNodes": -288,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 783.663,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3503.9500000000317,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.864,
      "layouts": 60,
      "layoutDurationMs": 11.882,
      "taskDurationMs": 1671.4470000000001,
      "heapDeltaBytes": 11769084,
      "heapUsedBytes": 80024900,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 769.2470000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3236.6349999999784,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 6.669000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2192.6899999999996,
      "heapDeltaBytes": 8668144,
      "heapUsedBytes": 89483456,
      "domNodes": -290,
      "jsHeapTotalBytes": 53248,
      "scriptDurationMs": 1062.987,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3171.2099999999737,
      "styleRecalcs": 44,
      "styleRecalcDurationMs": 8.906999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2017.5170000000003,
      "heapDeltaBytes": 6867092,
      "heapUsedBytes": 87967800,
      "domNodes": -249,
      "jsHeapTotalBytes": -208896,
      "scriptDurationMs": 1004.1200000000001,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2072.6700000000164,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 6.918,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 636.515,
      "heapDeltaBytes": 6889500,
      "heapUsedBytes": 85486452,
      "domNodes": -270,
      "jsHeapTotalBytes": -1675264,
      "scriptDurationMs": 34.929999999999986,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2005.3990000000113,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 1.5040000000000018,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 527.993,
      "heapDeltaBytes": 21758616,
      "heapUsedBytes": 88434912,
      "domNodes": -275,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 34.281000000000006,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 607.783999999981,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.813,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 441.67,
      "heapDeltaBytes": 15169696,
      "heapUsedBytes": 88462736,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 150.899,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 593.3340000000271,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 11.664000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 410.03299999999996,
      "heapDeltaBytes": 14007680,
      "heapUsedBytes": 86641444,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 142.91199999999998,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.6120000000378,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.733,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 568.7199999999999,
      "heapDeltaBytes": -867324,
      "heapUsedBytes": 71707252,
      "domNodes": -296,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 11.74,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2020.4439999999977,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 10.392000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 490.176,
      "heapDeltaBytes": -7509712,
      "heapUsedBytes": 65104756,
      "domNodes": -294,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 7.712,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1734.3629999999735,
      "styleRecalcs": 75,
      "styleRecalcDurationMs": 29.471000000000004,
      "layouts": 18,
      "layoutDurationMs": 5,
      "taskDurationMs": 888.9869999999999,
      "heapDeltaBytes": -15670740,
      "heapUsedBytes": 57656828,
      "domNodes": -300,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 120.00800000000001,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1741.549999999961,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 29.216000000000005,
      "layouts": 18,
      "layoutDurationMs": 5.076,
      "taskDurationMs": 835.6810000000002,
      "heapDeltaBytes": -8914872,
      "heapUsedBytes": 63776552,
      "domNodes": -295,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 114.76599999999999,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1418.3610000000044,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 33.596000000000004,
      "layouts": 15,
      "layoutDurationMs": 17.378,
      "taskDurationMs": 1016.314,
      "heapDeltaBytes": 21189440,
      "heapUsedBytes": 110418044,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11534336,
      "scriptDurationMs": 33.217000000000006,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 147,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 9671.72899999997,
      "styleRecalcs": 247,
      "styleRecalcDurationMs": 37.86299999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6360.46,
      "heapDeltaBytes": 13945340,
      "heapUsedBytes": 90696284,
      "domNodes": -274,
      "jsHeapTotalBytes": 876544,
      "scriptDurationMs": 2854.5249999999996,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8799.615000000016,
      "styleRecalcs": 245,
      "styleRecalcDurationMs": 33.37800000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5964.2,
      "heapDeltaBytes": 14129672,
      "heapUsedBytes": 90620840,
      "domNodes": -273,
      "jsHeapTotalBytes": -663552,
      "scriptDurationMs": 2745.26,
      "eventListeners": -146,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 18055.53600000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17342.793999999998,
      "heapDeltaBytes": -53113036,
      "heapUsedBytes": 178872332,
      "domNodes": -8068,
      "jsHeapTotalBytes": -16158720,
      "scriptDurationMs": 304.4,
      "eventListeners": -14935,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17994.686999999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17036.187,
      "heapDeltaBytes": -36174928,
      "heapUsedBytes": 181763640,
      "domNodes": -8068,
      "jsHeapTotalBytes": -5255168,
      "scriptDurationMs": 287.711,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21329.098000000045,
      "styleRecalcs": 159,
      "styleRecalcDurationMs": 19.645000000000024,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21061.725000000002,
      "heapDeltaBytes": -47897868,
      "heapUsedBytes": 180264956,
      "domNodes": -8068,
      "jsHeapTotalBytes": -17764352,
      "scriptDurationMs": 922.4229999999999,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 53,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21032.830999999987,
      "styleRecalcs": 173,
      "styleRecalcDurationMs": 18.303999999999988,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20629.57,
      "heapDeltaBytes": -53736380,
      "heapUsedBytes": 169717064,
      "domNodes": -8068,
      "jsHeapTotalBytes": -14692352,
      "scriptDurationMs": 918.825,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 144,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6612.197999999921,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 85.36700000000003,
      "layouts": 20,
      "layoutDurationMs": 26.622999999999994,
      "taskDurationMs": 6496.436,
      "heapDeltaBytes": -41062912,
      "heapUsedBytes": 177384376,
      "domNodes": -8068,
      "jsHeapTotalBytes": 11522048,
      "scriptDurationMs": 150.627,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 411,
      "frameDurationMs": 18.329999999999927,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6299.510000000055,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 78.53899999999997,
      "layouts": 20,
      "layoutDurationMs": 21.944999999999993,
      "taskDurationMs": 6163.054,
      "heapDeltaBytes": -40681652,
      "heapUsedBytes": 177647884,
      "domNodes": -8068,
      "jsHeapTotalBytes": 11259904,
      "scriptDurationMs": 119.29900000000002,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 421,
      "frameDurationMs": 18.890000000000025,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 9052.684999999998,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8749.81,
      "heapDeltaBytes": 762224,
      "heapUsedBytes": 177086244,
      "domNodes": 0,
      "jsHeapTotalBytes": -13893632,
      "scriptDurationMs": 180.50599999999994,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8998.767999999927,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8578.517000000002,
      "heapDeltaBytes": 16255368,
      "heapUsedBytes": 179112292,
      "domNodes": 0,
      "jsHeapTotalBytes": -13369344,
      "scriptDurationMs": 146.107,
      "eventListeners": -14,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.890000000000025,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 114.12000000007083,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 16.991,
      "layouts": 2,
      "layoutDurationMs": 0.51,
      "taskDurationMs": 79.835,
      "heapDeltaBytes": 3114620,
      "heapUsedBytes": 71755732,
      "domNodes": 111,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 7.126,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "workflow-execution",
      "durationMs": 97.85499999998137,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 16.142,
      "layouts": 2,
      "layoutDurationMs": 1.391,
      "taskDurationMs": 73.80399999999999,
      "heapDeltaBytes": 3031680,
      "heapUsedBytes": 72374760,
      "domNodes": 106,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 5.243000000000001,
      "eventListeners": 33,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50619 75805 66.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.6% 275
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.4% 260
src/scripts/pnginfo.ts 21.4% 221

@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Sep 26, 2026
@codecov

codecov Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #18995   +/-   ##
=============================================
  Coverage              ?   83.92%           
=============================================
  Files                 ?     2116           
  Lines                 ?   126040           
  Branches              ?    34101           
=============================================
  Hits                  ?   105778           
  Misses                ?    20085           
  Partials              ?      177           
Flag Coverage Δ
e2e 66.78% <ø> (?)
unit 79.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DrJKL DrJKL added agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-test-only Agent tests, fixtures and test support only; no production changes agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-ui Agent panel, composer, transcript or other user-interface components labels Sep 27, 2026
@christian-byrne

Copy link
Copy Markdown
Contributor Author

Closing as obsolete: the dependent production backport was made target-native without this test-only helper, so no release-branch change remains necessary.

@christian-byrne
christian-byrne deleted the fix/node-selection-fixture-cloud-1.54 branch September 28, 2026 04:12

This branch had an error being deployed

1 failed deployment
Preview – billing-web-test — 71d2d915 Deployed Sep 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation agent-backport Agent changes targeting a stable cloud/core release branch agent-test-only Agent tests, fixtures and test support only; no production changes agent-test-playwright Touches Agent-related Playwright tests, fixtures or configuration agent-ui Agent panel, composer, transcript or other user-interface components risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants