Repository navigation
test: add failing repro for composer placeholder reset (PM-1331) - #18069
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2041 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 9.92 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 637 kB (baseline 637 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.86 MB (baseline 3.86 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 565 kB (baseline 565 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 38 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.7 MB (baseline 17.7 MB) • ⚪ 0 BBundles that do not match a named category Status: 298 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-19T17:48:00.484Z",
"gitSha": "671e2897f46db5e3f4c128ffb38408e79fe19d1b",
"branch": "test/pm-1331-composer-placeholder-reset",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1993.9149999999586,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.164999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 289.06299999999993,
"heapDeltaBytes": 14678336,
"heapUsedBytes": 76562152,
"domNodes": -262,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.689,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 1993.7889999999925,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.427,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 295.122,
"heapDeltaBytes": 14764856,
"heapUsedBytes": 76626356,
"domNodes": -261,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.502000000000002,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1724.9690000000442,
"styleRecalcs": 73,
"styleRecalcDurationMs": 18.131999999999998,
"layouts": 14,
"layoutDurationMs": 2.861,
"taskDurationMs": 704.7560000000001,
"heapDeltaBytes": 8062824,
"heapUsedBytes": 70103400,
"domNodes": -262,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 126.64999999999999,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1711.5479999999934,
"styleRecalcs": 73,
"styleRecalcDurationMs": 16.273000000000003,
"layouts": 14,
"layoutDurationMs": 2.4939999999999998,
"taskDurationMs": 589.9129999999999,
"heapDeltaBytes": -978936,
"heapUsedBytes": 61127592,
"domNodes": -261,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 100.514,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.23700000003,
"styleRecalcs": 32,
"styleRecalcDurationMs": 12.025,
"layouts": 6,
"layoutDurationMs": 1.0379999999999998,
"taskDurationMs": 258.00800000000004,
"heapDeltaBytes": 2167440,
"heapUsedBytes": 64208148,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8.713,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.5439999999371,
"styleRecalcs": 31,
"styleRecalcDurationMs": 11.383000000000001,
"layouts": 6,
"layoutDurationMs": 1.042,
"taskDurationMs": 261.098,
"heapDeltaBytes": 2208052,
"heapUsedBytes": 64256344,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 9.206000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 511.1079999999788,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.2250000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 321.23699999999997,
"heapDeltaBytes": 17984176,
"heapUsedBytes": 79259032,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 115.778,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 525.08499999999,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.3629999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 320.24300000000005,
"heapDeltaBytes": 17556108,
"heapUsedBytes": 80029968,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 114.81599999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-idle",
"durationMs": 2025.0629999999887,
"styleRecalcs": 10,
"styleRecalcDurationMs": 5.99,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.12600000000003,
"heapDeltaBytes": 262888,
"heapUsedBytes": 79355952,
"domNodes": -243,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 24.268000000000004,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2013.4219999999914,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.621000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.454,
"heapDeltaBytes": 1931780,
"heapUsedBytes": 82748244,
"domNodes": -240,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 28.901000000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2109.414000000015,
"styleRecalcs": 68,
"styleRecalcDurationMs": 7.781,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1166.24,
"heapDeltaBytes": 15700260,
"heapUsedBytes": 79602748,
"domNodes": -245,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 582.673,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2106.3620000001038,
"styleRecalcs": 68,
"styleRecalcDurationMs": 7.932999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1167.1390000000001,
"heapDeltaBytes": -2198664,
"heapUsedBytes": 79410644,
"domNodes": -246,
"jsHeapTotalBytes": -8192,
"scriptDurationMs": 574.476,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3093.3519999999817,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.79,
"layouts": 60,
"layoutDurationMs": 9.274000000000001,
"taskDurationMs": 1210.9610000000002,
"heapDeltaBytes": 8582636,
"heapUsedBytes": 74516520,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 543.5110000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3081.937000000039,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.848999999999998,
"layouts": 60,
"layoutDurationMs": 9.162,
"taskDurationMs": 1182.629,
"heapDeltaBytes": 8408000,
"heapUsedBytes": 73939524,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 523.532,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2161.03099999998,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.752000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1351.2740000000001,
"heapDeltaBytes": -16173252,
"heapUsedBytes": 67987940,
"domNodes": -223,
"jsHeapTotalBytes": 2351104,
"scriptDurationMs": 641.936,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2178.274999999985,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.301999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1342.252,
"heapDeltaBytes": 14963160,
"heapUsedBytes": 80699084,
"domNodes": -250,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 660.503,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2037.6919999999927,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.421,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 385.266,
"heapDeltaBytes": -1086752,
"heapUsedBytes": 79798348,
"domNodes": -249,
"jsHeapTotalBytes": -532480,
"scriptDurationMs": 27.071999999999992,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 1991.5200000000368,
"styleRecalcs": 5,
"styleRecalcDurationMs": 3.0349999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 320.50200000000007,
"heapDeltaBytes": 19611512,
"heapUsedBytes": 84157544,
"domNodes": 10,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 23.128999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 493.83100000000013,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.611,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 297.482,
"heapDeltaBytes": 13056296,
"heapUsedBytes": 76408388,
"domNodes": 20,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 101.09800000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666665,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 463.169999999991,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.284999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 294.159,
"heapDeltaBytes": 13196624,
"heapUsedBytes": 76504560,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 100.411,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2003.20099999999,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.425,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 370.36600000000004,
"heapDeltaBytes": 369320,
"heapUsedBytes": 63683976,
"domNodes": -274,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.308000000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1989.1660000000684,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.439,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 367.85,
"heapDeltaBytes": 1195232,
"heapUsedBytes": 64441196,
"domNodes": -273,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 6.476000000000001,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1675.9930000000054,
"styleRecalcs": 78,
"styleRecalcDurationMs": 19.289,
"layouts": 18,
"layoutDurationMs": 3.6370000000000005,
"taskDurationMs": 575.7950000000001,
"heapDeltaBytes": 15696,
"heapUsedBytes": 63335820,
"domNodes": -275,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 69.857,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1674.1710000000012,
"styleRecalcs": 78,
"styleRecalcDurationMs": 17.813,
"layouts": 18,
"layoutDurationMs": 3.1539999999999995,
"taskDurationMs": 574.54,
"heapDeltaBytes": -1213640,
"heapUsedBytes": 62353868,
"domNodes": -273,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 67.129,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 866.7779999999539,
"styleRecalcs": 17,
"styleRecalcDurationMs": 20.551,
"layouts": 5,
"layoutDurationMs": 8.427,
"taskDurationMs": 665.9950000000001,
"heapDeltaBytes": -6454936,
"heapUsedBytes": 80922776,
"domNodes": 13587,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 20.005999999999997,
"eventListeners": 2383,
"totalBlockingTimeMs": 105,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8113.5699999999815,
"styleRecalcs": 249,
"styleRecalcDurationMs": 21.782999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4047.553,
"heapDeltaBytes": -14538056,
"heapUsedBytes": 66232524,
"domNodes": -242,
"jsHeapTotalBytes": 3436544,
"scriptDurationMs": 1856.121,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8172.366000000011,
"styleRecalcs": 251,
"styleRecalcDurationMs": 25.619999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4219.805,
"heapDeltaBytes": -2536680,
"heapUsedBytes": 76433380,
"domNodes": -240,
"jsHeapTotalBytes": 1789952,
"scriptDurationMs": 1951.038,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 10664.620000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10112.37,
"heapDeltaBytes": -39597624,
"heapUsedBytes": 182291948,
"domNodes": -8061,
"jsHeapTotalBytes": -10948608,
"scriptDurationMs": 139.626,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 10675.866999999926,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10124.765,
"heapDeltaBytes": -47540872,
"heapUsedBytes": 182750760,
"domNodes": -8061,
"jsHeapTotalBytes": -4513792,
"scriptDurationMs": 142.411,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 10758.380999999987,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.03499999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10090.812,
"heapDeltaBytes": -38722336,
"heapUsedBytes": 176490876,
"domNodes": -8062,
"jsHeapTotalBytes": -13615104,
"scriptDurationMs": 653.591,
"eventListeners": -14928,
"totalBlockingTimeMs": 47,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 13662.808999999925,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.038999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13032.195000000002,
"heapDeltaBytes": -19496216,
"heapUsedBytes": 190010972,
"domNodes": -8061,
"jsHeapTotalBytes": -15605760,
"scriptDurationMs": 629.959,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 3954.4899999999643,
"styleRecalcs": 20,
"styleRecalcDurationMs": 57.73600000000001,
"layouts": 20,
"layoutDurationMs": 18.86199999999999,
"taskDurationMs": 3799.5809999999997,
"heapDeltaBytes": -25274792,
"heapUsedBytes": 201860660,
"domNodes": -8062,
"jsHeapTotalBytes": 18628608,
"scriptDurationMs": 65.135,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 3956.1639999999443,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.17300000000001,
"layouts": 20,
"layoutDurationMs": 19.639000000000003,
"taskDurationMs": 3789.186999999999,
"heapDeltaBytes": -58210148,
"heapUsedBytes": 171770196,
"domNodes": -8061,
"jsHeapTotalBytes": 14884864,
"scriptDurationMs": 63.48,
"eventListeners": -14927,
"totalBlockingTimeMs": 77,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5804.147999999941,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5360.664999999999,
"heapDeltaBytes": 10375392,
"heapUsedBytes": 194235820,
"domNodes": 0,
"jsHeapTotalBytes": -25165824,
"scriptDurationMs": 101.59099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 4199.602000000027,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.09499999999998399,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3655.4879999999994,
"heapDeltaBytes": 18996840,
"heapUsedBytes": 194074676,
"domNodes": 0,
"jsHeapTotalBytes": -13631488,
"scriptDurationMs": 46.25600000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 417.77399999989484,
"styleRecalcs": 13,
"styleRecalcDurationMs": 16.316,
"layouts": 4,
"layoutDurationMs": 1.7269999999999999,
"taskDurationMs": 88.09999999999998,
"heapDeltaBytes": 4956328,
"heapUsedBytes": 66672872,
"domNodes": 124,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.171,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 432.1019999999862,
"styleRecalcs": 13,
"styleRecalcDurationMs": 11.729,
"layouts": 3,
"layoutDurationMs": 0.699,
"taskDurationMs": 71.07499999999999,
"heapDeltaBytes": 4873832,
"heapUsedBytes": 66626088,
"domNodes": 121,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.942000000000002,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18069 +/- ##
==========================================
+ Coverage 82.78% 83.81% +1.02%
==========================================
Files 2939 2244 -695
Lines 144660 127683 -16977
Branches 37220 34355 -2865
==========================================
- Hits 119763 107012 -12751
+ Misses 23630 20382 -3248
+ Partials 1267 289 -978
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 708 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
I could not pull the exact assertion/error text from this sandbox: raw job logs redirect to From reading the code, my best-supported (but unconfirmed) lead: What's needed: someone with normal |
|
Re-checked the earlier standing-down comment's leading suspicion against current source, and it doesn't hold up: the
Tracing the bug mechanism through this exact button confirms PM-1331 is still live and correctly reproduced as written: Given that, I did not rewrite the removal step to use Backspace-on-inline-atom — that targets an unrelated code path (the I still couldn't reach the run's raw logs/report ( Generated by Claude Code |
|
Status update on the Traced the code path the spec exercises ( Since the store-fix logic traces correctly and this failure predates the fix (same job failed on the test-only commits too), this looks like an issue in the new spec's test setup/environment (e.g. a locator/timeout earlier in the flow — All other suites that have finished on this commit pass (13/16 chromium shards plus mobile-chrome, mobile-safari, chromium-0.5x, chromium-2x all green, 0 failed); Generated by Claude Code |
Adds a test.fail()-pinned e2e repro plus a Vitest it.fails() unit repro for PM-1331: the composer placeholder never comes back after removing the only node reference from an otherwise-empty composer. insertComposerReference pads an empty draft with a literal space on first insert, and setNodes()/removeReference() filter references on removal but leave that space in place, so the placeholder guard (!draft && !references.length) never re-shows the placeholder. Test-only, no fix included.
playwright-video-new-tests and playwright-tests (cloud) both failed on this branch. Bring the new spec back in line with the rest of the suite: - Drop exact:true on the "Nodes" add-to-prompt menuitem lookup so it matches the accessible-name matching used by every other spec (e.g. agentPanel.spec.ts), instead of requiring an exact string match against a name computed from the menu item's child content. - Write the debug screenshot through test.info().outputPath() instead of a hardcoded 'test-results/...' path, matching the convention used by every other screenshot call in the suite and respecting the run's configured --output directory.
…M-1331)
insertComposerReference pads an empty composer draft with a literal
space on first insert. removeReference()/setNodes()/setNodeScope()
filtered out the removed reference but left that space behind, so the
composer never reported empty again and the placeholder stayed hidden.
- agentComposerStore: reset text to '' in removeReference(), setNodes(),
and setNodeScope()'s node-clearing branch whenever the resulting
references array is empty and the leftover text is whitespace-only.
- AgentPanelRoot.test.ts: the 'removed-attachment' case of the
parameterized "settles a submission" test asserted the exact leftover
space this fixes; updated its expectation to '' now that the store
clears it. ('removed-reference' still expects a single space: that
path removes the chip node directly from the ProseMirror doc without
its trailing space, a separate, unrelated leftover-whitespace issue in
InlinePromptEditor.vue's remove-button handler.)
The spec failed inside `NodeOperationsHelper.addNode` with
`TypeError: Cannot set properties of null (setting 'pos')`: `agentTest`
booted through `mockCloudBootRoutes` with an empty `object_info` mock, so
`LiteGraph.createNode('KSampler')` returned null. Thread an `objectInfo`
fixture option through `agentTest`, add the node on a cleared graph, wait
for the picking viewport to settle and click the node body by position.
Inserting a workflow chip into an empty draft pads it with a trailing space. Removing the chip through its remove button or Backspace deletes only the atom, so the editor and the store keep a stray ' ' and the placeholder stays hidden. A typed leading space with no reference must survive untouched.
Inserting a workflow chip pads the doc with a space after the atom. Removing the chip through its remove button or Backspace/Delete deleted only the atom, so the editor and the store kept a stray ' ' that hid the composer placeholder and doubled the space before following text. Delete the padding space with the atom when it directly follows it. The AgentPanelRoot expectations that encoded the leftover space now assert the clean text.
74bdf31 to
0b42d4f
Compare
|
Answering the earlier status comments asking for the real failing assertion behind Failing assertion (local repro, cloud project): the spec failed before reaching any placeholder assertion, at Fixes on this branch (rebased on
Local results: Generated by Claude Code |
|
@coderabbitai review Generated by Claude Code |
christian-byrne
left a comment
There was a problem hiding this comment.
The node-selection removal path now restores the empty composer placeholder. Reviewed the store removal paths and shared inline atom deletion at this head; typed text is preserved.
Full context for agent readers
Independent verification: 230 unit/component tests, source and browser typechecks, scoped lint/format, and Cloud build passed. The unchanged browser case failed with the pre-fix store and passed with this head. Inline chip-button and Backspace tests failed before the atom-padding fix and passed afterward. The rendered placeholder screenshot was inspected. No unresolved review threads or human objections were present at submission. Release acceptance remains tracked separately from source merge.
## Summary Restore the composer placeholder after removing its last reference. Backport the [merged source fix](#18069) with a release-native browser fixture. **Human owner:** christian-byrne <details><summary>Full context for agent readers</summary> ## Changes Production behavior matches the [reviewed source](0b42d4f): removing the final node/workflow reference clears insertion padding, without normalizing ordinary typed text. The release's `mockCloudBoot` gains the opt-in `objectInfo: 'server'` fixture option; its default mocked behavior is unchanged. No production prerequisite or wholesale main merge. ## Review Focus Preserve typed leading spaces and text after removed references. Verify chip-button, Backspace and node-selection removal. This is an adapted backport, not an unchanged automatic cherry-pick. ## Test Plan - 229 unit/component tests pass on this release target. - Target-native Cloud browser case passes against the existing backend, including a real KSampler node reference and the restored placeholder. - Three core-target tests fail on the original production source and pass with this patch. Both targets receive identical production changes. - Source/browser typechecks, lint, changed-file formatting and commit hooks pass. Hosted checks and release integration remain outstanding. ## Tracking [Placeholder incident and release follow-through](https://linear.app/comfyorg/issue/PM-1331#comment-bf73a3df) remains open under Christian's completion lane. The [program receipt](https://github.com/christian-byrne/in-app-agent-program/blob/main/program/slack-claude-pilot.md#0910-two-source-merges-and-conflict-repair) records both release targets and retained evidence. A merge is not deployment. Glossary: backport applies a merged source fix to a release branch; fixture adaptation changes test setup rather than shipped behavior. </details>
## Summary Restore the composer placeholder after removing its last reference. Backport the [merged source fix](#18069) with a release-native browser fixture. **Human owner:** christian-byrne <details><summary>Full context for agent readers</summary> ## Changes Production behavior matches the [reviewed source](0b42d4f): removing the final node/workflow reference clears insertion padding, without normalizing ordinary typed text. The release's `mockCloudBoot` gains the opt-in `objectInfo: 'server'` fixture option; its default mocked behavior is unchanged. No production prerequisite or wholesale main merge. ## Review Focus Preserve typed leading spaces and text after removed references. Verify chip-button, Backspace and node-selection removal. This is an adapted backport, not an unchanged automatic cherry-pick. ## Test Plan - 229 unit/component tests pass on this release target. - Target-native Cloud browser case passes against the existing backend, including a real KSampler node reference and the restored placeholder. - Three core-target tests fail on the original production source and pass with this patch. Both targets receive identical production changes. - Source/browser typechecks, lint, changed-file formatting and commit hooks pass. Hosted checks and release integration remain outstanding. ## Tracking [Placeholder incident and release follow-through](https://linear.app/comfyorg/issue/PM-1331#comment-bf73a3df) remains open under Christian's completion lane. The [program receipt](https://github.com/christian-byrne/in-app-agent-program/blob/main/program/slack-claude-pilot.md#0910-two-source-merges-and-conflict-repair) records both release targets and retained evidence. A merge is not deployment. Glossary: backport applies a merged source fix to a release branch; fixture adaptation changes test setup rather than shipped behavior. </details>
Requested by Christian Byrne · Slack thread
Summary
Before: inserting a node or workflow reference into an empty agent composer padded the draft with a space. Removing that reference (chip button, Backspace or Delete) left the invisible space behind, so the "Describe ideas..." placeholder never came back and the sent text carried a stray double space.
After: removing the only reference leaves the draft truly empty, the placeholder reappears, and text after a removed chip keeps a single space.
Fixes the composer placeholder reset after the last reference is removed.
How: the store resets whitespace-only text to
''when the last reference is cleared (resetTextWhenReferencesClearedinagentComposerStore.ts, coveringremoveReference,setNodesandsetNodeScope), and the inline editor deletes the padding space together with the atom when a chip is removed through its button or Backspace/Delete (deleteReferenceinInlinePromptEditor.vue). Nothing is normalised inupdateDraftand the placeholder guard is unchanged, so a typed leading space survives.Changes
src/workbench/extensions/agent/stores/agent/agentComposerStore.ts:resetTextWhenReferencesClearedon the store-side removal paths.src/workbench/extensions/agent/components/agent/composer/InlinePromptEditor.vue:deleteReferenceremoves the atom plus its trailing padding space; used by the chip remove button and the Backspace/Delete handler.src/workbench/extensions/agent/stores/agent/agentComposerStore.test.ts: store regression case.src/workbench/extensions/agent/components/agent/Composer.inlineReferences.test.ts: removing the only inline reference via the chip button or Backspace leaves''in the editor and the store; a typed' hello'with no reference is kept verbatim.src/workbench/extensions/agent/AgentPanelRoot.test.ts: theremoved-referenceandremoved-attachmentcases expect''; the staged-reference send expects a single space after the node reference.browser_tests/tests/agent/agentComposerPlaceholderReset.spec.tsandagentPanelMocks.ts: e2e repro; theagentTestfixture gains anobjectInfo: 'server'option so the spec boots with real node definitions (the mockedobject_infowas{}, soaddNode('KSampler')threw before reaching the assertion).Review Focus
deleteReferencemirrors the insertion check (nodeAt(afterChip)?.text?.startsWith(' ')), so it only removes a space that directly follows the atom.AgentPanelRoot.test.ts"navigates to a staged reference": the sent content drops from two spaces to one after the workflow chip is removed; that is the padding this PR stops leaking.Fixes
n/a
Screenshots
n/a (placeholder returns after the last chip is removed; covered by the e2e screenshot step).
🤖 Generated with Claude Code
https://claude.ai/code/session_01324gEbBCJCMaz6ezqVza6c
Generated by Claude Code