Skip to content

[backport cloud/1.54] fix(agent): show loaded skill names - #19705

Merged
christian-byrne merged 13 commits into
cloud/1.54from
backport-18429-to-cloud-1.54
Oct 1, 2026
Merged

christian-byrne merged 13 commits into
cloud/1.54from
backport-18429-to-cloud-1.54

Conversation

@christian-byrne

@christian-byrne christian-byrne commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Manual backport of #18429 after the automated cherry-pick conflicted in two Agent Playwright helpers.

This shows loaded skill names in the Agent activity trace and includes the correctness fixes from #19726, preserving names through null payloads, persisted transcripts, activity folding, and status rendering. The branch-specific conflicts retain the cloud/1.54 fixture API and its more permissive persisted transcript schema.

Original: #18429
Correctness follow-up: #19726

Justification: exact-head human approval and all required checks are green; the head is one commit behind main with zero changed-file overlap against the untested delta, so the unrelated main-only change cannot interact with this Agent activity UI carrier.
@vercel

vercel Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated
billing-web Ignored Ignored Oct 1, 2026 12:33pm UTC
billing-web-test Ignored Ignored Oct 1, 2026 12:33pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 882e2950-8b52-4010-8b93-db987eebee3f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@christian-byrne christian-byrne added cursor-review Trigger multi-model Cursor agent review on this PR greenlight labels Oct 1, 2026
@christian-byrne christian-byrne self-assigned this Oct 1, 2026
@christian-byrne christian-byrne added the agent Comfy Agent product, integration, tests or product documentation label Oct 1, 2026
@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 10/01/2026, 12:35:05 PM UTC

Links

🎭 Playwright: ✅ 1980 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1959 / ❌ 0 / ⚠️ 1 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 59.4 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.3 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.3 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.1 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.3 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.2 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 73.7 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 86.3 MB heap
minimap-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.2 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 57.7 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.9 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 149ms TBT · 102.0 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.1 MB heap
vue-large-graph-idle: · 57.2 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.3 MB heap
vue-large-graph-pan: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 39ms TBT · 160.7 MB heap
vue-node-resize-workload: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 499ms TBT · 172.0 MB heap
vue-zoom-out-idle: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 171.7 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.7 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 9ms
canvas-idle: layout count 0
canvas-idle: style recalc count 10
canvas-idle: task duration 515ms
canvas-idle: script duration 9ms
canvas-idle: TBT 0ms
canvas-idle: heap used 59.4 MB
canvas-idle: DOM nodes -280
canvas-idle: event listeners -196
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 4ms
canvas-mouse-sweep: style recalc duration 29ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 77
canvas-mouse-sweep: task duration 951ms
canvas-mouse-sweep: script duration 167ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 72.3 MB
canvas-mouse-sweep: DOM nodes -282
canvas-mouse-sweep: event listeners -182
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 350ms
canvas-zoom-sweep: script duration 11ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 72.3 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 8ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 448ms
dom-widget-clipping: script duration 162ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 61.1 MB
dom-widget-clipping: DOM nodes 19
dom-widget-clipping: event listeners 1
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 7
large-graph-idle: task duration 609ms
large-graph-idle: script duration 36ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 80.3 MB
large-graph-idle: DOM nodes -274
large-graph-idle: event listeners -177
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 1619ms
large-graph-pan: script duration 812ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 82.2 MB
large-graph-pan: DOM nodes -263
large-graph-pan: event listeners -177
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 12ms
large-graph-zoom: style recalc duration 11ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 62
large-graph-zoom: task duration 1686ms
large-graph-zoom: script duration 773ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 73.7 MB
large-graph-zoom: DOM nodes -137
large-graph-zoom: event listeners -91
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 5ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 1886ms
legacy-node-drag: script duration 944ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 86.3 MB
legacy-node-drag: DOM nodes -142
legacy-node-drag: event listeners 188
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 2ms
minimap-idle: layout count 0
minimap-idle: style recalc count 3
minimap-idle: task duration 541ms
minimap-idle: script duration 32ms
minimap-idle: TBT 0ms
minimap-idle: heap used 84.2 MB
minimap-idle: DOM nodes -278
minimap-idle: event listeners -93
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 12ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 413ms
subgraph-dom-widget-clipping: script duration 143ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 84.2 MB
subgraph-dom-widget-clipping: DOM nodes 21
subgraph-dom-widget-clipping: event listeners 7
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 9ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 480ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 57.7 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -225
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 5ms
subgraph-mouse-sweep: style recalc duration 26ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 805ms
subgraph-mouse-sweep: script duration 108ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 64.9 MB
subgraph-mouse-sweep: DOM nodes -298
subgraph-mouse-sweep: event listeners -227
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 16ms
subgraph-transition-enter: style recalc duration 33ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 903ms
subgraph-transition-enter: script duration 29ms
subgraph-transition-enter: TBT 149ms
subgraph-transition-enter: heap used 102.0 MB
subgraph-transition-enter: DOM nodes 13831
subgraph-transition-enter: event listeners 2385
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 36ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 249
viewport-pan-sweep: task duration 5817ms
viewport-pan-sweep: script duration 2723ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 75.1 MB
viewport-pan-sweep: DOM nodes -277
viewport-pan-sweep: event listeners -178
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16616ms
vue-large-graph-idle: script duration 302ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 169.3 MB
vue-large-graph-idle: DOM nodes -8068
vue-large-graph-idle: event listeners -14932
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 18ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 173
vue-large-graph-pan: task duration 20452ms
vue-large-graph-pan: script duration 907ms
vue-large-graph-pan: TBT 39ms
vue-large-graph-pan: heap used 160.7 MB
vue-large-graph-pan: DOM nodes -8068
vue-large-graph-pan: event listeners -14928
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 24ms
vue-node-resize-workload: style recalc duration 85ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6049ms
vue-node-resize-workload: script duration 110ms
vue-node-resize-workload: TBT 499ms
vue-node-resize-workload: heap used 172.0 MB
vue-node-resize-workload: DOM nodes -8068
vue-node-resize-workload: event listeners -14930
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 8314ms
vue-zoom-out-idle: script duration 148ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 171.7 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -14
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 1ms
workflow-execution: style recalc duration 15ms
workflow-execution: layout count 2
workflow-execution: style recalc count 8
workflow-execution: task duration 74ms
workflow-execution: script duration 6ms
workflow-execution: TBT 0ms
workflow-execution: heap used 68.7 MB
workflow-execution: DOM nodes 128
workflow-execution: event listeners 17
Raw data
{
  "timestamp": "2026-10-01T12:44:16.800Z",
  "gitSha": "61fd807e61a180d5d671258fcc2259aba07778ac",
  "branch": "backport-18429-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2071.317000000022,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 8.100000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 532.9540000000001,
      "heapDeltaBytes": -7272008,
      "heapUsedBytes": 64152192,
      "domNodes": -282,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 9.620999999999997,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 2036.5530000000263,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 10.500999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 497.536,
      "heapDeltaBytes": -10108084,
      "heapUsedBytes": 60345204,
      "domNodes": -278,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 8.059999999999997,
      "eventListeners": -196,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2152.0249999999805,
      "styleRecalcs": 80,
      "styleRecalcDurationMs": 30.793999999999997,
      "layouts": 14,
      "layoutDurationMs": 3.9830000000000005,
      "taskDurationMs": 1058.673,
      "heapDeltaBytes": -2621428,
      "heapUsedBytes": 67908720,
      "domNodes": -283,
      "jsHeapTotalBytes": 7069696,
      "scriptDurationMs": 177.27100000000002,
      "eventListeners": -198,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1783.3769999999731,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 27.238000000000007,
      "layouts": 14,
      "layoutDurationMs": 3.8939999999999997,
      "taskDurationMs": 844.185,
      "heapDeltaBytes": 12352488,
      "heapUsedBytes": 83651872,
      "domNodes": -281,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 156.402,
      "eventListeners": -166,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1660.868999999991,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 15.712999999999997,
      "layouts": 6,
      "layoutDurationMs": 1.045,
      "taskDurationMs": 338.482,
      "heapDeltaBytes": 4658140,
      "heapUsedBytes": 75637640,
      "domNodes": 76,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 9.679,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1737.3329999999214,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.82,
      "layouts": 6,
      "layoutDurationMs": 1.262,
      "taskDurationMs": 361.03,
      "heapDeltaBytes": 4607160,
      "heapUsedBytes": 75959136,
      "domNodes": 76,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 11.379,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 661.3100000000145,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 7.323000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 446.80699999999996,
      "heapDeltaBytes": -6623620,
      "heapUsedBytes": 64614852,
      "domNodes": 18,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 162.744,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 653.3869999999524,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 8.539000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 450.045,
      "heapDeltaBytes": -7512172,
      "heapUsedBytes": 63516488,
      "domNodes": 20,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 162.01100000000002,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2057.4359999999956,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.290999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 597.129,
      "heapDeltaBytes": 10804704,
      "heapUsedBytes": 86817756,
      "domNodes": -267,
      "jsHeapTotalBytes": -888832,
      "scriptDurationMs": 34.122,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2054.885000000013,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 6.430999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 621.816,
      "heapDeltaBytes": 5625952,
      "heapUsedBytes": 81599292,
      "domNodes": -281,
      "jsHeapTotalBytes": -1937408,
      "scriptDurationMs": 38.356,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2226.1210000000347,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 10.947999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1588.642,
      "heapDeltaBytes": 8891936,
      "heapUsedBytes": 86431724,
      "domNodes": -273,
      "jsHeapTotalBytes": -1187840,
      "scriptDurationMs": 794.124,
      "eventListeners": -162,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2216.7160000000194,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 11.609000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1649.7009999999998,
      "heapDeltaBytes": 8201888,
      "heapUsedBytes": 85901948,
      "domNodes": -252,
      "jsHeapTotalBytes": 122880,
      "scriptDurationMs": 829.4730000000001,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3488.2880000000114,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 9.437000000000001,
      "layouts": 60,
      "layoutDurationMs": 11.580000000000002,
      "taskDurationMs": 1675.624,
      "heapDeltaBytes": 9544248,
      "heapUsedBytes": 77740204,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 788.3950000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3546.4459999999463,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 12.384000000000002,
      "layouts": 60,
      "layoutDurationMs": 11.559,
      "taskDurationMs": 1696.446,
      "heapDeltaBytes": -2067592,
      "heapUsedBytes": 76731148,
      "domNodes": -274,
      "jsHeapTotalBytes": -1675264,
      "scriptDurationMs": 758.536,
      "eventListeners": -190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2994.781000000046,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 4.548,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1868.81,
      "heapDeltaBytes": 22875928,
      "heapUsedBytes": 90592648,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 932.877,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3036.3230000000385,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 5.7120000000000015,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1903.909,
      "heapDeltaBytes": 24177672,
      "heapUsedBytes": 90410200,
      "domNodes": -283,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 955.3409999999999,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2049.0270000000237,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.3930000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 564.554,
      "heapDeltaBytes": 9819124,
      "heapUsedBytes": 88197032,
      "domNodes": -274,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 33.429,
      "eventListeners": -192,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2006.8800000000238,
      "styleRecalcs": 1,
      "styleRecalcDurationMs": 0.7379999999999991,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 517.2949999999998,
      "heapDeltaBytes": 22202784,
      "heapUsedBytes": 88431328,
      "domNodes": -282,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 31.324000000000005,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 585.9549999999558,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 10.326,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 406.8419999999999,
      "heapDeltaBytes": 15265184,
      "heapUsedBytes": 88363664,
      "domNodes": 20,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 141.68200000000002,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 608.8230000000294,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 12.915,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 418.285,
      "heapDeltaBytes": 15168664,
      "heapUsedBytes": 88131488,
      "domNodes": 22,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 144.619,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2020.826999999997,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.297,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 479.981,
      "heapDeltaBytes": -15871868,
      "heapUsedBytes": 57516164,
      "domNodes": -295,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 7.0870000000000015,
      "eventListeners": -210,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2022.136000000046,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.886000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 479.139,
      "heapDeltaBytes": -9138176,
      "heapUsedBytes": 63509620,
      "domNodes": -298,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 7.2109999999999985,
      "eventListeners": -240,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1724.4660000000067,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 25.480999999999998,
      "layouts": 18,
      "layoutDurationMs": 4.3790000000000004,
      "taskDurationMs": 802.066,
      "heapDeltaBytes": -6855820,
      "heapUsedBytes": 66665820,
      "domNodes": -296,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 108.002,
      "eventListeners": -242,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1752.1669999999858,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 27.190999999999995,
      "layouts": 18,
      "layoutDurationMs": 4.816,
      "taskDurationMs": 808.511,
      "heapDeltaBytes": -2609540,
      "heapUsedBytes": 69478844,
      "domNodes": -299,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 107.524,
      "eventListeners": -212,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1400.5049999999528,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 32.578,
      "layouts": 16,
      "layoutDurationMs": 15.836000000000002,
      "taskDurationMs": 902.5609999999999,
      "heapDeltaBytes": 22125400,
      "heapUsedBytes": 106955364,
      "domNodes": 13831,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 28.72500000000001,
      "eventListeners": 2385,
      "totalBlockingTimeMs": 149,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8440.56500000005,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 36.349000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5799.714,
      "heapDeltaBytes": -6518852,
      "heapUsedBytes": 69564008,
      "domNodes": -282,
      "jsHeapTotalBytes": 4091904,
      "scriptDurationMs": 2682.367,
      "eventListeners": -178,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8456.394000000046,
      "styleRecalcs": 249,
      "styleRecalcDurationMs": 35.873,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5834.983,
      "heapDeltaBytes": 11252576,
      "heapUsedBytes": 87895324,
      "domNodes": -271,
      "jsHeapTotalBytes": 1957888,
      "scriptDurationMs": 2763.942,
      "eventListeners": -178,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17119.136000000028,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16587.446,
      "heapDeltaBytes": -59278096,
      "heapUsedBytes": 177857540,
      "domNodes": -8068,
      "jsHeapTotalBytes": -19836928,
      "scriptDurationMs": 274.74199999999996,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17244.382999999973,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16644.946,
      "heapDeltaBytes": -61430052,
      "heapUsedBytes": 177286060,
      "domNodes": -8068,
      "jsHeapTotalBytes": -20910080,
      "scriptDurationMs": 328.392,
      "eventListeners": -14933,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20905.474000000027,
      "styleRecalcs": 175,
      "styleRecalcDurationMs": 18.141999999999992,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20465.467,
      "heapDeltaBytes": -42154372,
      "heapUsedBytes": 170426128,
      "domNodes": -8068,
      "jsHeapTotalBytes": -20873216,
      "scriptDurationMs": 932.366,
      "eventListeners": -14927,
      "totalBlockingTimeMs": 59,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20832.94000000001,
      "styleRecalcs": 170,
      "styleRecalcDurationMs": 17.46599999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20437.650999999998,
      "heapDeltaBytes": -52643840,
      "heapUsedBytes": 166509596,
      "domNodes": -8068,
      "jsHeapTotalBytes": -12902400,
      "scriptDurationMs": 881.553,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 18,
      "frameDurationMs": 18.333333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6126.011000000006,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 81.845,
      "layouts": 20,
      "layoutDurationMs": 22.894000000000013,
      "taskDurationMs": 6018.160999999999,
      "heapDeltaBytes": -41614504,
      "heapUsedBytes": 177672124,
      "domNodes": -8068,
      "jsHeapTotalBytes": 10788864,
      "scriptDurationMs": 105.01199999999999,
      "eventListeners": -14931,
      "totalBlockingTimeMs": 461,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6188.5690000000295,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 88.04099999999998,
      "layouts": 20,
      "layoutDurationMs": 24.197999999999997,
      "taskDurationMs": 6079.389000000001,
      "heapDeltaBytes": -49878092,
      "heapUsedBytes": 182999004,
      "domNodes": -8068,
      "jsHeapTotalBytes": 8392704,
      "scriptDurationMs": 114.80000000000001,
      "eventListeners": -14929,
      "totalBlockingTimeMs": 537,
      "frameDurationMs": 17.220000000000013,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8455.896999999994,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8180.0289999999995,
      "heapDeltaBytes": 23418656,
      "heapUsedBytes": 182638416,
      "domNodes": 0,
      "jsHeapTotalBytes": -7077888,
      "scriptDurationMs": 131.49600000000007,
      "eventListeners": -12,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8717.336000000047,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8448.130000000001,
      "heapDeltaBytes": -3065064,
      "heapUsedBytes": 177481388,
      "domNodes": 0,
      "jsHeapTotalBytes": -24903680,
      "scriptDurationMs": 165.01499999999996,
      "eventListeners": -15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "workflow-execution",
      "durationMs": 134.9400000000287,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 15.139,
      "layouts": 2,
      "layoutDurationMs": 1.271,
      "taskDurationMs": 78.585,
      "heapDeltaBytes": 3081280,
      "heapUsedBytes": 72383400,
      "domNodes": 131,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 6.989999999999999,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 102.05299999995532,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 14.868999999999998,
      "layouts": 2,
      "layoutDurationMs": 1.305,
      "taskDurationMs": 70.26700000000001,
      "heapDeltaBytes": 2966820,
      "heapUsedBytes": 71587212,
      "domNodes": 125,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 4.886,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 50778 76083 66.7% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.5% 1156
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 7.9% 313
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 77.8% 272
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 72.3% 253
src/scripts/pnginfo.ts 21.4% 221

@github-actions
github-actions Bot requested a review from ryan-di October 1, 2026 05:06
@christian-byrne
christian-byrne requested a review from DrJKL October 1, 2026 05:12

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Cursor Review — Consolidated panel

Triggered by @christian-byrne.

Found 9 finding(s).

Severity Count
🟡 Medium 4
🟢 Low 3
⚪ Nit 2

Panel: 8/8 reviewers contributed findings.

@codecov

codecov Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.54   #19705   +/-   ##
=============================================
  Coverage              ?   84.03%           
=============================================
  Files                 ?     2123           
  Lines                 ?   127262           
  Branches              ?    34227           
=============================================
  Hits                  ?   106944           
  Misses                ?    20139           
  Partials              ?      179           
Flag Coverage Δ
e2e 66.79% <ø> (?)
unit 79.22% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...s/agent/components/agent/message/ActivityTrace.vue 100.00% <100.00%> (ø)
...rkbench/extensions/agent/schemas/agentApiSchema.ts 100.00% <ø> (ø)
...tensions/agent/services/agent/agentActivityRows.ts 100.00% <100.00%> (ø)
...nsions/agent/services/agent/agentEventTransport.ts 100.00% <100.00%> (ø)
...tensions/agent/services/agent/agentMessageParts.ts 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: Request changes. The port of #18429 is faithful except for an unused nodeSelectionBanner fixture member that the conflict resolution added and the source does not contain.

I compared this branch, against its merge base 327e65b (the current cloud/1.54 tip), with #18429's merged diff (4b36741).

  • Eleven of the source's 12 files carry exactly the source's added and removed lines: the schema field, the message part, the transport, the activity-row fold, ActivityTrace.vue, the locale entry, the three unit test files, agentPanelMocks.ts, and agentLoadedSkillActivity.spec.ts.
  • In AgentPanel.ts, the source's activityRows and activityRow() additions are present as written. The one extra change is inline.
  • At 39e302f: vitest run over agentActivityRows.test.ts, agentEventTransport.test.ts, and components/agent/message/ passed 180/180 across 14 files. Hosted checks passed, apart from the two cancelled pr-risk jobs.

Once the extra member is gone, this is a straight cherry-pick.

@christian-byrne
christian-byrne requested a review from DrJKL October 1, 2026 08:38
@christian-byrne christian-byrne removed their assignment Oct 1, 2026
@github-actions github-actions Bot added the risk:high PR risk grade (advisory shadow check; grader-owned) label Oct 1, 2026
@christian-byrne christian-byrne self-assigned this Oct 1, 2026
@datadog-official

This comment has been minimized.

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: Request changes. 3d6f377 fixed the fixture issue, but the four commits after it add behavior that is in neither #18429 nor main, and typecheck and a unit test now fail at this head.

I compared this branch, at 244e53d against its merge base 327e65b (the current cloud/1.54 tip), with #18429's merged diff (4b36741). At 3d6f377 all 12 files carried exactly the source's added and removed lines, and 3d6f377 resolved my earlier nodeSelectionBanner comment.

032ae31, b1a0ff9, aba10ec, and 244e53d change those files further and touch three files the source does not: agentTranscript.ts, agentTranscript.test.ts, and agentApiSchema.test.ts. On main, the only later change to these modules is unrelated #18801, so none of this is a backport of a main fix. These look like answers to the automated review on this PR. If those findings are real defects, I think they should be fixed on main first and backported on their own, not folded into this cherry-pick. Each divergence is inline.

Checks at 244e53d:

  • Locally, vue-tsc --noEmit fails with agentTranscript.ts(171,5): error TS2339: Property 'skill' does not exist on type '{ status: string; id: string; tool_name: string; duration_ms?: number | undefined; tool_call_id?: string | undefined; }'. Hosted typecheck failed the same way at b1a0ff9.
  • vitest run over agentTranscript.test.ts, agentApiSchema.test.ts, agentEventTransport.test.ts, agentActivityRows.test.ts, and components/agent/message/ gives 1 failed and 253 passed. The failure is the added "restores a persisted skill name", because the transcript parse never yields skill.

The fix is to reset this branch to the 3d6f377 content.

@christian-byrne
christian-byrne force-pushed the backport-18429-to-cloud-1.54 branch from 244e53d to 3d6f377 Compare October 1, 2026 09:01
@DrJKL
DrJKL self-requested a review October 1, 2026 09:01
@christian-byrne christian-byrne removed their assignment Oct 1, 2026

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: Request changes. 1294769 restores #18429's outcome label, fold latch, and grouping, but it deliberately keeps five changes that are in neither #18429 nor main.

I compared this branch, at 1294769 against its merge base 327e65b, with #18429's merged diff (4b36741). Against the source-faithful 3d6f377 it is still +129/-8 across eight files. agentActivityRows.ts and its test, WorkSummary.test.ts, agentLoadedSkillActivity.spec.ts, agentPanelMocks.ts, the locale entry, and agentMessageParts.ts match the source again.

The reply threads describe the remaining changes as hardening of the visible skill name. That may well be right, but none of it is on main: the only later change there to these modules is unrelated #18801. A backport should carry #18429 as it shipped, adapting only for what cloud/1.54 lacks. Fixes beyond that belong on main first, then in their own backport, so the release line and main do not drift apart. Each remaining divergence is inline.

Checks at 1294769: vitest run over agentTranscript.test.ts, agentApiSchema.test.ts, agentEventTransport.test.ts, agentActivityRows.test.ts, and components/agent/message/ passed 251/251 across 16 files. When I posted, hosted checks had no failures so far and 11 were still running. Passing checks do not change the outcome here.

The fix is to reset this branch to the 3d6f377 content.

@DrJKL DrJKL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: Approve. This is a faithful backport of #18429 to cloud/1.54. The net change is a straight cherry-pick with no adaptations.

I compared this branch, at 72613f5 against its merge base 327e65b, with #18429's merged diff (4b36741). All 12 files carry exactly the source's added and removed lines, and no other files change. The net diff is identical to 3d6f377: the follow-up commits that added non-source behavior have been reverted. That resolves my earlier comments.

Checks:

  • I merged the current cloud/1.54 tip, 22e29bc (#19734), into this head locally. The merge is clean.
  • On the merged tree, vitest run over agentActivityRows.test.ts, agentEventTransport.test.ts, and components/agent/message/ passed 180/180 across 14 files. vue-tsc --noEmit and pnpm typecheck:browser both passed.
  • All hosted checks at this head passed.

@DrJKL DrJKL removed their assignment Oct 1, 2026
@christian-byrne
christian-byrne merged commit 8a160ce into cloud/1.54 Oct 1, 2026
102 checks passed
@christian-byrne
christian-byrne deleted the backport-18429-to-cloud-1.54 branch October 1, 2026 13:00
christian-byrne added a commit that referenced this pull request Oct 3, 2026
christian-byrne added a commit that referenced this pull request Oct 3, 2026
…19726) (#19989)

## Summary

Incremental backport of #19726 for `cloud/1.54` after its original
carrier #19705 landed.

- accepts `null` completion skill values without dropping the tool-call
frame
- preserves an existing skill name when completion sends `null` or an
empty string
- clamps long names by Unicode code point
- lets a later successful retry replace an earlier failed folded outcome

## Validation

- adds focused schema, event-transport, and activity-folding regression
tests
- `git diff --check origin/cloud/1.54..HEAD`
- full agent unit and browser gates run in PR CI

## Excluded

Persisted-skill hydration is deliberately excluded because the earlier
cloud/1.54 carrier retained this branch's older transcript contract.
Review-only refactors and selector cleanup are also omitted.

Backport of #19726.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Comfy Agent product, integration, tests or product documentation cursor-review Trigger multi-model Cursor agent review on this PR greenlight risk:high PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants