Repository navigation
[backport cloud/1.54] fix(agent): show loaded skill names - #19705
Conversation
Justification: exact-head human approval and all required checks are green; the head is one commit behind main with zero changed-file overlap against the untested delta, so the unrelated main-only change cannot interact with this Agent activity UI carrier.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1980 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-10-01T12:44:16.800Z",
"gitSha": "61fd807e61a180d5d671258fcc2259aba07778ac",
"branch": "backport-18429-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2071.317000000022,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.100000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 532.9540000000001,
"heapDeltaBytes": -7272008,
"heapUsedBytes": 64152192,
"domNodes": -282,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 9.620999999999997,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2036.5530000000263,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.500999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 497.536,
"heapDeltaBytes": -10108084,
"heapUsedBytes": 60345204,
"domNodes": -278,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 8.059999999999997,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2152.0249999999805,
"styleRecalcs": 80,
"styleRecalcDurationMs": 30.793999999999997,
"layouts": 14,
"layoutDurationMs": 3.9830000000000005,
"taskDurationMs": 1058.673,
"heapDeltaBytes": -2621428,
"heapUsedBytes": 67908720,
"domNodes": -283,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 177.27100000000002,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1783.3769999999731,
"styleRecalcs": 74,
"styleRecalcDurationMs": 27.238000000000007,
"layouts": 14,
"layoutDurationMs": 3.8939999999999997,
"taskDurationMs": 844.185,
"heapDeltaBytes": 12352488,
"heapUsedBytes": 83651872,
"domNodes": -281,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 156.402,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1660.868999999991,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.712999999999997,
"layouts": 6,
"layoutDurationMs": 1.045,
"taskDurationMs": 338.482,
"heapDeltaBytes": 4658140,
"heapUsedBytes": 75637640,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.679,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1737.3329999999214,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.82,
"layouts": 6,
"layoutDurationMs": 1.262,
"taskDurationMs": 361.03,
"heapDeltaBytes": 4607160,
"heapUsedBytes": 75959136,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.379,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 661.3100000000145,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.323000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.80699999999996,
"heapDeltaBytes": -6623620,
"heapUsedBytes": 64614852,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 162.744,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 653.3869999999524,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.539000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.045,
"heapDeltaBytes": -7512172,
"heapUsedBytes": 63516488,
"domNodes": 20,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 162.01100000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2057.4359999999956,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.290999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 597.129,
"heapDeltaBytes": 10804704,
"heapUsedBytes": 86817756,
"domNodes": -267,
"jsHeapTotalBytes": -888832,
"scriptDurationMs": 34.122,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2054.885000000013,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.430999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 621.816,
"heapDeltaBytes": 5625952,
"heapUsedBytes": 81599292,
"domNodes": -281,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 38.356,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2226.1210000000347,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.947999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1588.642,
"heapDeltaBytes": 8891936,
"heapUsedBytes": 86431724,
"domNodes": -273,
"jsHeapTotalBytes": -1187840,
"scriptDurationMs": 794.124,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2216.7160000000194,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.609000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1649.7009999999998,
"heapDeltaBytes": 8201888,
"heapUsedBytes": 85901948,
"domNodes": -252,
"jsHeapTotalBytes": 122880,
"scriptDurationMs": 829.4730000000001,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3488.2880000000114,
"styleRecalcs": 60,
"styleRecalcDurationMs": 9.437000000000001,
"layouts": 60,
"layoutDurationMs": 11.580000000000002,
"taskDurationMs": 1675.624,
"heapDeltaBytes": 9544248,
"heapUsedBytes": 77740204,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 788.3950000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "large-graph-zoom",
"durationMs": 3546.4459999999463,
"styleRecalcs": 64,
"styleRecalcDurationMs": 12.384000000000002,
"layouts": 60,
"layoutDurationMs": 11.559,
"taskDurationMs": 1696.446,
"heapDeltaBytes": -2067592,
"heapUsedBytes": 76731148,
"domNodes": -274,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 758.536,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2994.781000000046,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.548,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1868.81,
"heapDeltaBytes": 22875928,
"heapUsedBytes": 90592648,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 932.877,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3036.3230000000385,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.7120000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1903.909,
"heapDeltaBytes": 24177672,
"heapUsedBytes": 90410200,
"domNodes": -283,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 955.3409999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2049.0270000000237,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.3930000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 564.554,
"heapDeltaBytes": 9819124,
"heapUsedBytes": 88197032,
"domNodes": -274,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 33.429,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2006.8800000000238,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.7379999999999991,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 517.2949999999998,
"heapDeltaBytes": 22202784,
"heapUsedBytes": 88431328,
"domNodes": -282,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.324000000000005,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 585.9549999999558,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.326,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 406.8419999999999,
"heapDeltaBytes": 15265184,
"heapUsedBytes": 88363664,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 141.68200000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 608.8230000000294,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.915,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 418.285,
"heapDeltaBytes": 15168664,
"heapUsedBytes": 88131488,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 144.619,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2020.826999999997,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.297,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.981,
"heapDeltaBytes": -15871868,
"heapUsedBytes": 57516164,
"domNodes": -295,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.0870000000000015,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.136000000046,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.886000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 479.139,
"heapDeltaBytes": -9138176,
"heapUsedBytes": 63509620,
"domNodes": -298,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.2109999999999985,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.4660000000067,
"styleRecalcs": 77,
"styleRecalcDurationMs": 25.480999999999998,
"layouts": 18,
"layoutDurationMs": 4.3790000000000004,
"taskDurationMs": 802.066,
"heapDeltaBytes": -6855820,
"heapUsedBytes": 66665820,
"domNodes": -296,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 108.002,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1752.1669999999858,
"styleRecalcs": 77,
"styleRecalcDurationMs": 27.190999999999995,
"layouts": 18,
"layoutDurationMs": 4.816,
"taskDurationMs": 808.511,
"heapDeltaBytes": -2609540,
"heapUsedBytes": 69478844,
"domNodes": -299,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 107.524,
"eventListeners": -212,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.5049999999528,
"styleRecalcs": 20,
"styleRecalcDurationMs": 32.578,
"layouts": 16,
"layoutDurationMs": 15.836000000000002,
"taskDurationMs": 902.5609999999999,
"heapDeltaBytes": 22125400,
"heapUsedBytes": 106955364,
"domNodes": 13831,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 28.72500000000001,
"eventListeners": 2385,
"totalBlockingTimeMs": 149,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8440.56500000005,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.349000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5799.714,
"heapDeltaBytes": -6518852,
"heapUsedBytes": 69564008,
"domNodes": -282,
"jsHeapTotalBytes": 4091904,
"scriptDurationMs": 2682.367,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8456.394000000046,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.873,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5834.983,
"heapDeltaBytes": 11252576,
"heapUsedBytes": 87895324,
"domNodes": -271,
"jsHeapTotalBytes": 1957888,
"scriptDurationMs": 2763.942,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17119.136000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16587.446,
"heapDeltaBytes": -59278096,
"heapUsedBytes": 177857540,
"domNodes": -8068,
"jsHeapTotalBytes": -19836928,
"scriptDurationMs": 274.74199999999996,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17244.382999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16644.946,
"heapDeltaBytes": -61430052,
"heapUsedBytes": 177286060,
"domNodes": -8068,
"jsHeapTotalBytes": -20910080,
"scriptDurationMs": 328.392,
"eventListeners": -14933,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20905.474000000027,
"styleRecalcs": 175,
"styleRecalcDurationMs": 18.141999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20465.467,
"heapDeltaBytes": -42154372,
"heapUsedBytes": 170426128,
"domNodes": -8068,
"jsHeapTotalBytes": -20873216,
"scriptDurationMs": 932.366,
"eventListeners": -14927,
"totalBlockingTimeMs": 59,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20832.94000000001,
"styleRecalcs": 170,
"styleRecalcDurationMs": 17.46599999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20437.650999999998,
"heapDeltaBytes": -52643840,
"heapUsedBytes": 166509596,
"domNodes": -8068,
"jsHeapTotalBytes": -12902400,
"scriptDurationMs": 881.553,
"eventListeners": -14929,
"totalBlockingTimeMs": 18,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6126.011000000006,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.845,
"layouts": 20,
"layoutDurationMs": 22.894000000000013,
"taskDurationMs": 6018.160999999999,
"heapDeltaBytes": -41614504,
"heapUsedBytes": 177672124,
"domNodes": -8068,
"jsHeapTotalBytes": 10788864,
"scriptDurationMs": 105.01199999999999,
"eventListeners": -14931,
"totalBlockingTimeMs": 461,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6188.5690000000295,
"styleRecalcs": 20,
"styleRecalcDurationMs": 88.04099999999998,
"layouts": 20,
"layoutDurationMs": 24.197999999999997,
"taskDurationMs": 6079.389000000001,
"heapDeltaBytes": -49878092,
"heapUsedBytes": 182999004,
"domNodes": -8068,
"jsHeapTotalBytes": 8392704,
"scriptDurationMs": 114.80000000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 537,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8455.896999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8180.0289999999995,
"heapDeltaBytes": 23418656,
"heapUsedBytes": 182638416,
"domNodes": 0,
"jsHeapTotalBytes": -7077888,
"scriptDurationMs": 131.49600000000007,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8717.336000000047,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8448.130000000001,
"heapDeltaBytes": -3065064,
"heapUsedBytes": 177481388,
"domNodes": 0,
"jsHeapTotalBytes": -24903680,
"scriptDurationMs": 165.01499999999996,
"eventListeners": -15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 134.9400000000287,
"styleRecalcs": 9,
"styleRecalcDurationMs": 15.139,
"layouts": 2,
"layoutDurationMs": 1.271,
"taskDurationMs": 78.585,
"heapDeltaBytes": 3081280,
"heapUsedBytes": 72383400,
"domNodes": 131,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.989999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 102.05299999995532,
"styleRecalcs": 7,
"styleRecalcDurationMs": 14.868999999999998,
"layouts": 2,
"layoutDurationMs": 1.305,
"taskDurationMs": 70.26700000000001,
"heapDeltaBytes": 2966820,
"heapUsedBytes": 71587212,
"domNodes": 125,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.886,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 9 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 4 |
| 🟢 Low | 3 |
| ⚪ Nit | 2 |
Panel: 8/8 reviewers contributed findings.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.54 #19705 +/- ##
=============================================
Coverage ? 84.03%
=============================================
Files ? 2123
Lines ? 127262
Branches ? 34227
=============================================
Hits ? 106944
Misses ? 20139
Partials ? 179
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: Request changes. The port of #18429 is faithful except for an unused nodeSelectionBanner fixture member that the conflict resolution added and the source does not contain.
I compared this branch, against its merge base 327e65b (the current cloud/1.54 tip), with #18429's merged diff (4b36741).
- Eleven of the source's 12 files carry exactly the source's added and removed lines: the schema field, the message part, the transport, the activity-row fold,
ActivityTrace.vue, the locale entry, the three unit test files,agentPanelMocks.ts, andagentLoadedSkillActivity.spec.ts. - In
AgentPanel.ts, the source'sactivityRowsandactivityRow()additions are present as written. The one extra change is inline. - At 39e302f:
vitest runoveragentActivityRows.test.ts,agentEventTransport.test.ts, andcomponents/agent/message/passed 180/180 across 14 files. Hosted checks passed, apart from the two cancelledpr-riskjobs.
Once the extra member is gone, this is a straight cherry-pick.
This comment has been minimized.
This comment has been minimized.
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: Request changes. 3d6f377 fixed the fixture issue, but the four commits after it add behavior that is in neither #18429 nor main, and typecheck and a unit test now fail at this head.
I compared this branch, at 244e53d against its merge base 327e65b (the current cloud/1.54 tip), with #18429's merged diff (4b36741). At 3d6f377 all 12 files carried exactly the source's added and removed lines, and 3d6f377 resolved my earlier nodeSelectionBanner comment.
032ae31, b1a0ff9, aba10ec, and 244e53d change those files further and touch three files the source does not: agentTranscript.ts, agentTranscript.test.ts, and agentApiSchema.test.ts. On main, the only later change to these modules is unrelated #18801, so none of this is a backport of a main fix. These look like answers to the automated review on this PR. If those findings are real defects, I think they should be fixed on main first and backported on their own, not folded into this cherry-pick. Each divergence is inline.
Checks at 244e53d:
- Locally,
vue-tsc --noEmitfails withagentTranscript.ts(171,5): error TS2339: Property 'skill' does not exist on type '{ status: string; id: string; tool_name: string; duration_ms?: number | undefined; tool_call_id?: string | undefined; }'. Hostedtypecheckfailed the same way at b1a0ff9. vitest runoveragentTranscript.test.ts,agentApiSchema.test.ts,agentEventTransport.test.ts,agentActivityRows.test.ts, andcomponents/agent/message/gives 1 failed and 253 passed. The failure is the added "restores a persisted skill name", because the transcript parse never yieldsskill.
The fix is to reset this branch to the 3d6f377 content.
244e53d to
3d6f377
Compare
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: Request changes. 1294769 restores #18429's outcome label, fold latch, and grouping, but it deliberately keeps five changes that are in neither #18429 nor main.
I compared this branch, at 1294769 against its merge base 327e65b, with #18429's merged diff (4b36741). Against the source-faithful 3d6f377 it is still +129/-8 across eight files. agentActivityRows.ts and its test, WorkSummary.test.ts, agentLoadedSkillActivity.spec.ts, agentPanelMocks.ts, the locale entry, and agentMessageParts.ts match the source again.
The reply threads describe the remaining changes as hardening of the visible skill name. That may well be right, but none of it is on main: the only later change there to these modules is unrelated #18801. A backport should carry #18429 as it shipped, adapting only for what cloud/1.54 lacks. Fixes beyond that belong on main first, then in their own backport, so the release line and main do not drift apart. Each remaining divergence is inline.
Checks at 1294769: vitest run over agentTranscript.test.ts, agentApiSchema.test.ts, agentEventTransport.test.ts, agentActivityRows.test.ts, and components/agent/message/ passed 251/251 across 16 files. When I posted, hosted checks had no failures so far and 11 were still running. Passing checks do not change the outcome here.
The fix is to reset this branch to the 3d6f377 content.
Addresses review feedback: #19705 (comment)
Addresses review feedback: #19705 (comment)
Addresses review feedback: #19705 (comment)
Addresses review feedback: #19705 (comment)
Addresses review feedback: #19705 (comment)
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: Approve. This is a faithful backport of #18429 to cloud/1.54. The net change is a straight cherry-pick with no adaptations.
I compared this branch, at 72613f5 against its merge base 327e65b, with #18429's merged diff (4b36741). All 12 files carry exactly the source's added and removed lines, and no other files change. The net diff is identical to 3d6f377: the follow-up commits that added non-source behavior have been reverted. That resolves my earlier comments.
Checks:
- I merged the current
cloud/1.54tip, 22e29bc (#19734), into this head locally. The merge is clean. - On the merged tree,
vitest runoveragentActivityRows.test.ts,agentEventTransport.test.ts, andcomponents/agent/message/passed 180/180 across 14 files.vue-tsc --noEmitandpnpm typecheck:browserboth passed. - All hosted checks at this head passed.
…19726) (#19989) ## Summary Incremental backport of #19726 for `cloud/1.54` after its original carrier #19705 landed. - accepts `null` completion skill values without dropping the tool-call frame - preserves an existing skill name when completion sends `null` or an empty string - clamps long names by Unicode code point - lets a later successful retry replace an earlier failed folded outcome ## Validation - adds focused schema, event-transport, and activity-folding regression tests - `git diff --check origin/cloud/1.54..HEAD` - full agent unit and browser gates run in PR CI ## Excluded Persisted-skill hydration is deliberately excluded because the earlier cloud/1.54 carrier retained this branch's older transcript contract. Review-only refactors and selector cleanup are also omitted. Backport of #19726.
Manual backport of #18429 after the automated cherry-pick conflicted in two Agent Playwright helpers.
This shows loaded skill names in the Agent activity trace and includes the correctness fixes from #19726, preserving names through null payloads, persisted transcripts, activity folding, and status rendering. The branch-specific conflicts retain the cloud/1.54 fixture API and its more permissive persisted transcript schema.
Original: #18429
Correctness follow-up: #19726