Repository navigation
test(agent): carry the node-selection fixture helpers to core/1.54 - #18994
christian-byrne wants to merge 1 commit into
Conversation
#18983 and #18984 backport the PM-1227 fix, whose spec calls `panel.enterNodeSelectionMode()`. That helper does not exist here, so both fail `typecheck-aux` and, through it, the required `lint-and-format` and `e2e-status`: agentNodeSelectionChipRemoval.spec.ts(29,24): error TS2339: Property "enterNodeSelectionMode" does not exist on type "AgentPanel" The helper arrives on main in `0859c16eb` (#18066), which is 42 files and 2064 insertions of behaviour change and has never been backported anywhere. Importing that to enable one spec would be wildly out of proportion, and the rule is to bring the missing module rather than rewrite the caller -- so this brings only the fixture, which is test-side. Everything it drives already exists here, checked rather than assumed: the `node-selection-mode-banner` testid is in `src` on this branch, and `agent.addToPrompt`, `agent.nodes` and `agent.nodeSelection.exit` are all in the locale file. `open()`, `selectWorkflow()`, `root` and `page` are already on the fixture. `exitNodeSelectionMode` comes along as its pair; the spec only uses enter.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1954 passed, 0 failed📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-26T12:04:52.919Z",
"gitSha": "75f407dc56e4ea0d4705221bb95238bdc75e4c41",
"branch": "fix/node-selection-fixture-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2081.9379999999796,
"styleRecalcs": 8,
"styleRecalcDurationMs": 10.123,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.5100000000001,
"heapDeltaBytes": -8979348,
"heapUsedBytes": 61414124,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.353,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2055.6969999998955,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.248999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.698,
"heapDeltaBytes": -7862756,
"heapUsedBytes": 63006464,
"domNodes": -283,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 8.948,
"eventListeners": -196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1816.9520000000148,
"styleRecalcs": 74,
"styleRecalcDurationMs": 27.939,
"layouts": 14,
"layoutDurationMs": 3.623,
"taskDurationMs": 874.5219999999999,
"heapDeltaBytes": 3001832,
"heapUsedBytes": 73838492,
"domNodes": -282,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 162.801,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1865.6260000000202,
"styleRecalcs": 74,
"styleRecalcDurationMs": 29.566,
"layouts": 14,
"layoutDurationMs": 3.7939999999999996,
"taskDurationMs": 872.026,
"heapDeltaBytes": 8501432,
"heapUsedBytes": 79616668,
"domNodes": -281,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 164.26,
"eventListeners": -166,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.0429999999615,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.37,
"layouts": 6,
"layoutDurationMs": 0.992,
"taskDurationMs": 346.61600000000004,
"heapDeltaBytes": 4671788,
"heapUsedBytes": 75635940,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.380999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1663.1519999999682,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.866999999999999,
"layouts": 6,
"layoutDurationMs": 0.9600000000000002,
"taskDurationMs": 358.05699999999996,
"heapDeltaBytes": 4648364,
"heapUsedBytes": 75842456,
"domNodes": 76,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.955,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 635.2779999999711,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.741,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.89500000000004,
"heapDeltaBytes": -8267972,
"heapUsedBytes": 62851392,
"domNodes": 18,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 159.92100000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 627.236000000039,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.098,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 441.578,
"heapDeltaBytes": 18438804,
"heapUsedBytes": 88625752,
"domNodes": 16,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 156.65,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2083.83299999997,
"styleRecalcs": 6,
"styleRecalcDurationMs": 8.150999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 626.2939999999999,
"heapDeltaBytes": 9322856,
"heapUsedBytes": 85464732,
"domNodes": -276,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 41.510000000000005,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2055.1479999999174,
"styleRecalcs": 7,
"styleRecalcDurationMs": 8.587000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 634.799,
"heapDeltaBytes": 9006400,
"heapUsedBytes": 84986180,
"domNodes": -273,
"jsHeapTotalBytes": -364544,
"scriptDurationMs": 34.305,
"eventListeners": -192,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2225.951000000009,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.849999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1609.676,
"heapDeltaBytes": 6729304,
"heapUsedBytes": 83829336,
"domNodes": -273,
"jsHeapTotalBytes": 122880,
"scriptDurationMs": 805.9660000000001,
"eventListeners": -162,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2319.376000000034,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.689000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1687.896,
"heapDeltaBytes": 4349936,
"heapUsedBytes": 81242640,
"domNodes": -279,
"jsHeapTotalBytes": 647168,
"scriptDurationMs": 855.562,
"eventListeners": -192,
"totalBlockingTimeMs": 3,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3567.2289999999975,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.721,
"layouts": 60,
"layoutDurationMs": 11.453000000000001,
"taskDurationMs": 1729.463,
"heapDeltaBytes": -2907160,
"heapUsedBytes": 75669048,
"domNodes": -279,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 767.644,
"eventListeners": -190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3567.254999999932,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.922000000000002,
"layouts": 60,
"layoutDurationMs": 12.025999999999998,
"taskDurationMs": 1755.6350000000002,
"heapDeltaBytes": -10869708,
"heapUsedBytes": 67725352,
"domNodes": -289,
"jsHeapTotalBytes": 4354048,
"scriptDurationMs": 779.5880000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3090.0080000000116,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.624999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1945.6759999999997,
"heapDeltaBytes": 23944088,
"heapUsedBytes": 92468616,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 972.604,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3132.9829999999674,
"styleRecalcs": 40,
"styleRecalcDurationMs": 4.7269999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1931.4419999999998,
"heapDeltaBytes": 24611252,
"heapUsedBytes": 92275044,
"domNodes": 0,
"jsHeapTotalBytes": 1728512,
"scriptDurationMs": 947.938,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 1993.3039999999664,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.6420000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 519.002,
"heapDeltaBytes": 21945420,
"heapUsedBytes": 88890364,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.077999999999996,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2000.5630000000565,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.735000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 548.52,
"heapDeltaBytes": 21847368,
"heapUsedBytes": 88354164,
"domNodes": -273,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 37.00200000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 561.1079999999902,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.587999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.312,
"heapDeltaBytes": 15020560,
"heapUsedBytes": 88135572,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 140.57500000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 577.1510000000717,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.745,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 407.79299999999995,
"heapDeltaBytes": 15052096,
"heapUsedBytes": 88361636,
"domNodes": 20,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 138.11200000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2003.9620000000014,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.726,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.535,
"heapDeltaBytes": 4484796,
"heapUsedBytes": 76710308,
"domNodes": -298,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 7.612999999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2038.2280000000037,
"styleRecalcs": 10,
"styleRecalcDurationMs": 12.757,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 513.517,
"heapDeltaBytes": -7282620,
"heapUsedBytes": 65219996,
"domNodes": -297,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 9.198000000000002,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1724.8690000000124,
"styleRecalcs": 78,
"styleRecalcDurationMs": 28.217,
"layouts": 18,
"layoutDurationMs": 4.760000000000001,
"taskDurationMs": 811.8530000000001,
"heapDeltaBytes": -6124448,
"heapUsedBytes": 67263856,
"domNodes": -297,
"jsHeapTotalBytes": 7069696,
"scriptDurationMs": 109.49600000000001,
"eventListeners": -242,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1757.0779999999786,
"styleRecalcs": 78,
"styleRecalcDurationMs": 29.419,
"layouts": 18,
"layoutDurationMs": 4.917999999999999,
"taskDurationMs": 840.556,
"heapDeltaBytes": -9158952,
"heapUsedBytes": 63323004,
"domNodes": -294,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 112.023,
"eventListeners": -240,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-transition-enter",
"durationMs": 1400.7229999999709,
"styleRecalcs": 20,
"styleRecalcDurationMs": 34.221,
"layouts": 16,
"layoutDurationMs": 16.365,
"taskDurationMs": 999.0609999999999,
"heapDeltaBytes": -9152256,
"heapUsedBytes": 84321916,
"domNodes": 13751,
"jsHeapTotalBytes": 13107200,
"scriptDurationMs": 35.22,
"eventListeners": 2385,
"totalBlockingTimeMs": 151,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8730.913999999984,
"styleRecalcs": 246,
"styleRecalcDurationMs": 33.706,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5991.262000000001,
"heapDeltaBytes": 8764200,
"heapUsedBytes": 84863940,
"domNodes": -273,
"jsHeapTotalBytes": 385024,
"scriptDurationMs": 2730.401,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8561.061999999993,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.691,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5871.298000000001,
"heapDeltaBytes": -7660200,
"heapUsedBytes": 68256664,
"domNodes": -279,
"jsHeapTotalBytes": 1732608,
"scriptDurationMs": 2688.9510000000005,
"eventListeners": -178,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16943.716999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16488.34,
"heapDeltaBytes": -61820636,
"heapUsedBytes": 178236644,
"domNodes": -8068,
"jsHeapTotalBytes": -18526208,
"scriptDurationMs": 307.673,
"eventListeners": -14931,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17105.522000000063,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16634.646,
"heapDeltaBytes": -55370684,
"heapUsedBytes": 178279608,
"domNodes": -8068,
"jsHeapTotalBytes": -17252352,
"scriptDurationMs": 279.73499999999996,
"eventListeners": -14935,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20748.65699999998,
"styleRecalcs": 169,
"styleRecalcDurationMs": 17.23600000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20361.401,
"heapDeltaBytes": -39187576,
"heapUsedBytes": 178857400,
"domNodes": -8068,
"jsHeapTotalBytes": -11546624,
"scriptDurationMs": 884.259,
"eventListeners": -14927,
"totalBlockingTimeMs": 16,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21105.9140000001,
"styleRecalcs": 172,
"styleRecalcDurationMs": 17.11399999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20771.070000000003,
"heapDeltaBytes": -32347728,
"heapUsedBytes": 179919168,
"domNodes": -8068,
"jsHeapTotalBytes": -18526208,
"scriptDurationMs": 896.8620000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 111,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6133.01100000001,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.23599999999998,
"layouts": 20,
"layoutDurationMs": 22.083999999999993,
"taskDurationMs": 6026.377000000001,
"heapDeltaBytes": -34963816,
"heapUsedBytes": 183850524,
"domNodes": -8068,
"jsHeapTotalBytes": 19701760,
"scriptDurationMs": 104.76500000000001,
"eventListeners": -14929,
"totalBlockingTimeMs": 389,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6192.538000000013,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.349,
"layouts": 20,
"layoutDurationMs": 21.23,
"taskDurationMs": 6080.362999999999,
"heapDeltaBytes": -40197540,
"heapUsedBytes": 177129916,
"domNodes": -8068,
"jsHeapTotalBytes": 9711616,
"scriptDurationMs": 117.91099999999999,
"eventListeners": -14927,
"totalBlockingTimeMs": 441,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8712.156999999934,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8421.198999999999,
"heapDeltaBytes": 1040188,
"heapUsedBytes": 178482744,
"domNodes": 0,
"jsHeapTotalBytes": -22020096,
"scriptDurationMs": 147.053,
"eventListeners": -14,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8866.882000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8466.580999999998,
"heapDeltaBytes": 8557016,
"heapUsedBytes": 178573560,
"domNodes": 0,
"jsHeapTotalBytes": -11272192,
"scriptDurationMs": 173.13499999999993,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 107.93100000000777,
"styleRecalcs": 7,
"styleRecalcDurationMs": 16.337,
"layouts": 2,
"layoutDurationMs": 1.2890000000000001,
"taskDurationMs": 78.325,
"heapDeltaBytes": 3014152,
"heapUsedBytes": 71597776,
"domNodes": 129,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 5.300000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 88.17599999997583,
"styleRecalcs": 6,
"styleRecalcDurationMs": 11.903,
"layouts": 2,
"layoutDurationMs": 0.7080000000000001,
"taskDurationMs": 60.169,
"heapDeltaBytes": 3001932,
"heapUsedBytes": 71906036,
"domNodes": 104,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 4.275999999999999,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.54 #18994 +/- ##
=============================================
- Coverage 83.81% 83.81% -0.01%
=============================================
Files 2107 2107
Lines 125139 125139
Branches 31710 33577 +1867
=============================================
- Hits 104885 104880 -5
- Misses 20076 20081 +5
Partials 178 178
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Closing as obsolete: the dependent production backport was made target-native without this test-only helper, so no release-branch change remains necessary. |
Unblocks #18983.
That backport's spec calls
panel.enterNodeSelectionMode(), which does not exist oncore/1.54, so it failstypecheck-auxand through it the requiredlint-and-formatande2e-status:The helper arrives on main in
0859c16eb(#18066) — 42 files, 2064 insertions of behaviour change, never backported anywhere. Pulling that across to enable one spec is out of proportion, so this brings only the fixture, which is test-side.Everything it drives already exists on this branch, checked rather than assumed: the
node-selection-mode-bannertestid is insrchere, andagent.addToPrompt,agent.nodesandagent.nodeSelection.exitare all in the locale file.open(),selectWorkflow(),rootandpageare already on the fixture. The gap was the helper alone, not the feature.exitNodeSelectionModecomes along as its pair; the spec only uses enter.