Skip to content

[backport cloud/1.53] test: add ECS widget QA coverage - #17600

Closed
comfy-pr-bot wants to merge 5 commits into
cloud/1.53from
backport-17460-to-cloud-1.53
Closed

comfy-pr-bot wants to merge 5 commits into
cloud/1.53from
backport-17460-to-cloud-1.53

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #17460 to cloud/1.53

Automatically created by backport workflow.

- Covers source-deletion restoration and special-character multiline
persistence.
- Two focused Chromium cases pass at `239398abea`.
- Duplicate clear, combo, and pin cases were removed in favor of their
feature owners.

<details><summary>Full context for agent readers</summary>

The restoration case explicitly uses the legacy renderer and proves the
retained seed value plus a visible, enabled, connection-unsuppressed
widget row after direct source-node removal. The multiline case
explicitly uses Vue Nodes and preserves newlines, Unicode, HTML-like
text, ampersands, hashes, and percentages across save/reload. Existing
owners remain `vueNodes/widgets/widgetValuePersistence.spec.ts`,
`vueNodes/widgets/combo/comboWidget.spec.ts`, and
`vueNodes/nodeStates/pin.spec.ts`.

Verification: Oxfmt, Oxlint, ESLint, browser typecheck, and Knip passed.
Focused Chromium: 2/2. Mutating the expected restored visibility to
false failed the restoration oracle. Logs:
`/tmp/ecs-wake1/logs/pr-17460-static.log`, `pr-17460-targeted.log`, and
`pr-17460-mutation.log`.

</details>
@github-actions

github-actions Bot commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ❌ 1899 passed, 1 failed · 3 flaky

❌ Failed Tests

📊 Browser Reports
  • chromium: View Report (✅ 1878 / ❌ 1 / ⚠️ 3 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • New-test walkthrough (chromium, recorded video): View Report

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.9 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 68.2 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.6 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.8 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.1 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.9 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.9 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 81.2 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.5 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.7 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 67.1 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.1 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 132ms TBT · 98.6 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.8 MB heap
vue-large-graph-idle: · 59.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 170.0 MB heap
vue-large-graph-pan: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 51ms TBT · 162.5 MB heap
vue-node-resize-workload: · 58.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 41ms TBT · 171.6 MB heap
workflow-execution: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.5 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 6ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 448ms
canvas-idle: script duration 7ms
canvas-idle: TBT 0ms
canvas-idle: heap used 61.9 MB
canvas-idle: DOM nodes -281
canvas-idle: event listeners -171
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 3ms
canvas-mouse-sweep: style recalc duration 30ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 75
canvas-mouse-sweep: task duration 785ms
canvas-mouse-sweep: script duration 124ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 68.2 MB
canvas-mouse-sweep: DOM nodes -280
canvas-mouse-sweep: event listeners -170
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 13ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 315ms
canvas-zoom-sweep: script duration 8ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 70.6 MB
canvas-zoom-sweep: DOM nodes 77
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 6ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 370ms
dom-widget-clipping: script duration 127ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 71.8 MB
dom-widget-clipping: DOM nodes 20
dom-widget-clipping: event listeners 0
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 3ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 509ms
large-graph-idle: script duration 24ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.1 MB
large-graph-idle: DOM nodes -271
large-graph-idle: event listeners -75
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 7ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 66
large-graph-pan: task duration 1313ms
large-graph-pan: script duration 625ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 83.9 MB
large-graph-pan: DOM nodes -139
large-graph-pan: event listeners -88
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 10ms
large-graph-zoom: style recalc duration 9ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 62
large-graph-zoom: task duration 1361ms
large-graph-zoom: script duration 586ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 71.9 MB
large-graph-zoom: DOM nodes 4
large-graph-zoom: event listeners 7
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 4ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 41
legacy-node-drag: task duration 1491ms
legacy-node-drag: script duration 713ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 81.2 MB
legacy-node-drag: DOM nodes 1
legacy-node-drag: event listeners 186
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 5
minimap-idle: task duration 506ms
minimap-idle: script duration 22ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.5 MB
minimap-idle: DOM nodes -131
minimap-idle: event listeners -89
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 8ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 48
subgraph-dom-widget-clipping: task duration 347ms
subgraph-dom-widget-clipping: script duration 114ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.7 MB
subgraph-dom-widget-clipping: DOM nodes 21
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 6ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 445ms
subgraph-idle: script duration 7ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 67.1 MB
subgraph-idle: DOM nodes -297
subgraph-idle: event listeners -217
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 4ms
subgraph-mouse-sweep: style recalc duration 28ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 693ms
subgraph-mouse-sweep: script duration 78ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 64.1 MB
subgraph-mouse-sweep: DOM nodes -298
subgraph-mouse-sweep: event listeners -216
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 12ms
subgraph-transition-enter: style recalc duration 26ms
subgraph-transition-enter: layout count 16
subgraph-transition-enter: style recalc count 20
subgraph-transition-enter: task duration 774ms
subgraph-transition-enter: script duration 23ms
subgraph-transition-enter: TBT 132ms
subgraph-transition-enter: heap used 98.6 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2381
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 24ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 4633ms
viewport-pan-sweep: script duration 2026ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 82.8 MB
viewport-pan-sweep: DOM nodes -270
viewport-pan-sweep: event listeners -151
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 11776ms
vue-large-graph-idle: script duration 171ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 170.0 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7476
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 12ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 78
vue-large-graph-pan: task duration 14976ms
vue-large-graph-pan: script duration 759ms
vue-large-graph-pan: TBT 51ms
vue-large-graph-pan: heap used 162.5 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7471
vue-node-resize-workload: avg frame time 17ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 19ms
vue-node-resize-workload: style recalc duration 67ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 4346ms
vue-node-resize-workload: script duration 71ms
vue-node-resize-workload: TBT 41ms
vue-node-resize-workload: heap used 171.6 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7473
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 17ms
workflow-execution: layout count 4
workflow-execution: style recalc count 15
workflow-execution: task duration 90ms
workflow-execution: script duration 8ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.5 MB
workflow-execution: DOM nodes 133
workflow-execution: event listeners 73
Raw data
{
  "timestamp": "2026-09-24T08:41:10.631Z",
  "gitSha": "269c6d3ab4f29628c4e0e7b75875c01a0295cab9",
  "branch": "backport-17460-to-cloud-1.53",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2038.3790000000204,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.973000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 449.30500000000006,
      "heapDeltaBytes": -10838504,
      "heapUsedBytes": 58916932,
      "domNodes": -280,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 6.804000000000001,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-idle",
      "durationMs": 1998.0389999999488,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 5.4209999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 447.52299999999997,
      "heapDeltaBytes": 395728,
      "heapUsedBytes": 70848180,
      "domNodes": -282,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 6.829999999999999,
      "eventListeners": -187,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1796.541999999988,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 33.667,
      "layouts": 14,
      "layoutDurationMs": 3.5449999999999995,
      "taskDurationMs": 856.923,
      "heapDeltaBytes": 12314684,
      "heapUsedBytes": 81497048,
      "domNodes": -279,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 134.55100000000002,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1740.8960000000206,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 26.694,
      "layouts": 14,
      "layoutDurationMs": 3.432,
      "taskDurationMs": 712.986,
      "heapDeltaBytes": -9054264,
      "heapUsedBytes": 61494724,
      "domNodes": -280,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 114.16500000000002,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1707.2340000000281,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 13.38,
      "layouts": 6,
      "layoutDurationMs": 0.889,
      "taskDurationMs": 309.88699999999994,
      "heapDeltaBytes": 4399820,
      "heapUsedBytes": 74075608,
      "domNodes": 76,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 8.319,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1672.2520000000713,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 13.569,
      "layouts": 6,
      "layoutDurationMs": 1.0880000000000003,
      "taskDurationMs": 320.503,
      "heapDeltaBytes": 4435464,
      "heapUsedBytes": 73943588,
      "domNodes": 78,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 8.443,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 557.8229999999849,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 5.507999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 374.354,
      "heapDeltaBytes": 17853884,
      "heapUsedBytes": 88148168,
      "domNodes": 20,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 128.659,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 544.6069999999281,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 6.415000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 365.785,
      "heapDeltaBytes": -8121316,
      "heapUsedBytes": 62415096,
      "domNodes": 20,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 124.63699999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 1998.6660000000143,
      "styleRecalcs": 2,
      "styleRecalcDurationMs": 1.2600000000000007,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 481.27599999999995,
      "heapDeltaBytes": 22206276,
      "heapUsedBytes": 87381200,
      "domNodes": -274,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 22.201000000000004,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2037.8920000000562,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.277,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 536.3350000000002,
      "heapDeltaBytes": -13538904,
      "heapUsedBytes": 86867044,
      "domNodes": -267,
      "jsHeapTotalBytes": -1093632,
      "scriptDurationMs": 24.985,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2187.6980000000117,
      "styleRecalcs": 66,
      "styleRecalcDurationMs": 8.146999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1366.855,
      "heapDeltaBytes": 12996632,
      "heapUsedBytes": 88833436,
      "domNodes": -273,
      "jsHeapTotalBytes": 143360,
      "scriptDurationMs": 645.274,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2066.6630000000623,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 6.621999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1259.541,
      "heapDeltaBytes": 21117980,
      "heapUsedBytes": 87074528,
      "domNodes": -5,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 604.915,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3116.047999999978,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 8.84,
      "layouts": 60,
      "layoutDurationMs": 9.74,
      "taskDurationMs": 1361.1740000000002,
      "heapDeltaBytes": 7746500,
      "heapUsedBytes": 75414624,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 584.1310000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3131.0869999999795,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 8.306999999999999,
      "layouts": 60,
      "layoutDurationMs": 9.340000000000002,
      "taskDurationMs": 1361.0320000000002,
      "heapDeltaBytes": 8174252,
      "heapUsedBytes": 75371452,
      "domNodes": 4,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 588.0529999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2243.223999999998,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 3.141999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1490.356,
      "heapDeltaBytes": 16702108,
      "heapUsedBytes": 84716228,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 712.2900000000001,
      "eventListeners": 184,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2477.2480000000314,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 4.725999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1492.2730000000001,
      "heapDeltaBytes": 18191596,
      "heapUsedBytes": 85602664,
      "domNodes": 2,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 714.38,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2004.052999999999,
      "styleRecalcs": 3,
      "styleRecalcDurationMs": 1.753000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 480.55500000000006,
      "heapDeltaBytes": 21771172,
      "heapUsedBytes": 87897052,
      "domNodes": 6,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 22.29099999999999,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "minimap-idle",
      "durationMs": 2030.5319999999938,
      "styleRecalcs": 6,
      "styleRecalcDurationMs": 4.292999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 530.531,
      "heapDeltaBytes": 10456976,
      "heapUsedBytes": 87114532,
      "domNodes": -268,
      "jsHeapTotalBytes": -2965504,
      "scriptDurationMs": 22.118,
      "eventListeners": -181,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 579.3630000000007,
      "styleRecalcs": 48,
      "styleRecalcDurationMs": 9.179,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 355.186,
      "heapDeltaBytes": 14798684,
      "heapUsedBytes": 87576992,
      "domNodes": 22,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 116.90400000000001,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 539.2519999999195,
      "styleRecalcs": 47,
      "styleRecalcDurationMs": 7.677,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 338.931,
      "heapDeltaBytes": 15046400,
      "heapUsedBytes": 87959936,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 110.316,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2007.0089999999823,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.623,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 444.3090000000001,
      "heapDeltaBytes": 3523472,
      "heapUsedBytes": 76302352,
      "domNodes": -296,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 6.994999999999997,
      "eventListeners": -233,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2009.9060000000009,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 5.935,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 446.141,
      "heapDeltaBytes": -8247772,
      "heapUsedBytes": 64359148,
      "domNodes": -298,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 6.5120000000000005,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1710.5489999999577,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 30.267,
      "layouts": 18,
      "layoutDurationMs": 4.233,
      "taskDurationMs": 696.5469999999999,
      "heapDeltaBytes": 2059360,
      "heapUsedBytes": 74825404,
      "domNodes": -298,
      "jsHeapTotalBytes": 6021120,
      "scriptDurationMs": 80.64600000000002,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1685.6109999999944,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 25.820999999999998,
      "layouts": 18,
      "layoutDurationMs": 3.589,
      "taskDurationMs": 689.367,
      "heapDeltaBytes": -13039300,
      "heapUsedBytes": 59599200,
      "domNodes": -297,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 75.44000000000001,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 999.7680000000173,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 25.868999999999996,
      "layouts": 16,
      "layoutDurationMs": 12.013,
      "taskDurationMs": 773.8150000000002,
      "heapDeltaBytes": 19913904,
      "heapUsedBytes": 103368856,
      "domNodes": 13751,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 22.626999999999995,
      "eventListeners": 2381,
      "totalBlockingTimeMs": 132,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8195.644000000015,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 24.339999999999996,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4679.366,
      "heapDeltaBytes": 9198768,
      "heapUsedBytes": 84995124,
      "domNodes": -273,
      "jsHeapTotalBytes": -905216,
      "scriptDurationMs": 2051.3500000000004,
      "eventListeners": -167,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8186.309000000051,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 23.693,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 4586.576,
      "heapDeltaBytes": 23647360,
      "heapUsedBytes": 88687240,
      "domNodes": -267,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 2000.2929999999997,
      "eventListeners": -135,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12627.711000000034,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11808.999,
      "heapDeltaBytes": -28659780,
      "heapUsedBytes": 181247896,
      "domNodes": -6548,
      "jsHeapTotalBytes": 1929216,
      "scriptDurationMs": 190.696,
      "eventListeners": -7477,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333237,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 12685.381000000007,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 11743.078000000001,
      "heapDeltaBytes": -33636784,
      "heapUsedBytes": 175235440,
      "domNodes": -6548,
      "jsHeapTotalBytes": -4894720,
      "scriptDurationMs": 151.45999999999998,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 15501.842000000068,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 12.397999999999993,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14915.847000000002,
      "heapDeltaBytes": -21954032,
      "heapUsedBytes": 174969108,
      "domNodes": -6548,
      "jsHeapTotalBytes": 6328320,
      "scriptDurationMs": 735.269,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 26,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 15630.041000000005,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 12.123999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15035.598,
      "heapDeltaBytes": -38408836,
      "heapUsedBytes": 165901908,
      "domNodes": -6548,
      "jsHeapTotalBytes": -569344,
      "scriptDurationMs": 782.119,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 76,
      "frameDurationMs": 17.220000000000073,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4490.218999999911,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 66.943,
      "layouts": 20,
      "layoutDurationMs": 19.083000000000002,
      "taskDurationMs": 4312.141,
      "heapDeltaBytes": -30071144,
      "heapUsedBytes": 179301344,
      "domNodes": -6548,
      "jsHeapTotalBytes": 10018816,
      "scriptDurationMs": 69.808,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 34,
      "frameDurationMs": 17.220000000000013,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 4534.948999999983,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 66.745,
      "layouts": 20,
      "layoutDurationMs": 19.421000000000006,
      "taskDurationMs": 4379.242,
      "heapDeltaBytes": -21739280,
      "heapUsedBytes": 180653548,
      "domNodes": -6548,
      "jsHeapTotalBytes": 12840960,
      "scriptDurationMs": 72.73100000000001,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 48,
      "frameDurationMs": 17.223333333333297,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 457.75800000001254,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 19.865000000000002,
      "layouts": 5,
      "layoutDurationMs": 1.7759999999999998,
      "taskDurationMs": 109.72500000000001,
      "heapDeltaBytes": 5366500,
      "heapUsedBytes": 74086844,
      "domNodes": 157,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 10.346999999999998,
      "eventListeners": 97,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 109.53400000005331,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 13.418999999999999,
      "layouts": 2,
      "layoutDurationMs": 1.389,
      "taskDurationMs": 70.42899999999999,
      "heapDeltaBytes": 3228772,
      "heapUsedBytes": 71666948,
      "domNodes": 108,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 5.66,
      "eventListeners": 49,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.663333333333338,
      "p95FrameDurationMs": 16.700000000000273
    }
  ]
}

🔬 E2E Coverage

Note

Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.

Metric Covered Total Pct
Lines 48231 70922 68.0% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.2% 1185
src/LGraphNode.ts 69.5% 396
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.1% 305
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 78.4% 261
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.7% 247
src/scripts/pnginfo.ts 21.4% 221
src/stores/assetsStore.ts 45.0% 203

@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 14, 2026
@codecov

codecov Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@              Coverage Diff              @@
##             cloud/1.53   #17600   +/-   ##
=============================================
  Coverage              ?   83.42%           
=============================================
  Files                 ?     2028           
  Lines                 ?   117787           
  Branches              ?    33307           
=============================================
  Hits                  ?    98266           
  Misses                ?    19163           
  Partials              ?      358           
Flag Coverage Δ
e2e 66.50% <ø> (?)
unit 76.82% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

comfy-pr-bot pushed a commit that referenced this pull request Sep 17, 2026
…entation (#17348) (#17750)

Manual backport of #17348 (`6a6a4a2`). The automated cherry-pick failed
with conflicts, so this was resolved by hand per the bot's instructions.

## Why
#17348 is labelled for this release. The auto-backport workflow could
not apply it because this branch predates several `main` refactors the
commit sits on top of.

## Root cause of the conflict
Not a stacking conflict — the open backports the bot pointed at (#17720
/ #17721 / #17600) are workflow and ECS test-coverage changes that touch
none of the conflicting files. The conflicts are genuine divergence
between `main` and this branch.

## How — conflicts and how each was resolved

- **`billingOperationStore.ts`** — `main` wraps `handleSuccess`'s body
in `try { cleanup(opId) … }`; this branch does not. The checkout-journey
clear is placed before the success telemetry here, keeping the same
guarantee (it runs before any cleanup path can throw) against this
branch's structure.
- **`TopUpCreditsDialogContentWorkspace.test.ts`** — this branch mocks
the operation store with hoisted `mockStartOperation` and has no
`billingOperationTestUtils` helper, which `main`'s version of this file
depends on. Taking `main`'s blocks wholesale compiled but broke all 31
tests, so only #17348's journey additions were applied onto this
branch's own structure, plus a `firebase/auth` spy mock so
`useAuthStore()` does not reach real Firebase.
- **`types.ts`** — the conflict region carried `FetchTimeoutMetadata`,
which belongs to a `main`-only feature and has no consumer here.
Dropped; `knip` confirms nothing else was over-pulled.
- **Provider imports and the ADR index** — merged with this branch's
existing entries.

The diff against this branch now adds exactly the symbols #17348 added,
and nothing else.

## AS IS / TO BE
Not applicable — this is a telemetry-only backport with no user-visible
surface. #17348 changes no checkout UX or payment behavior; it adds
`billing.checkout.*` events alongside the existing terminal `billing.*`
taxonomy.

## Verification
- 7 affected suites, 362 tests passing
- `pnpm typecheck`, `pnpm knip`, `pnpm lint` (0 errors) clean
comfy-pr-bot pushed a commit that referenced this pull request Sep 17, 2026
…mentation (#17348) (#17751)

Manual backport of #17348 (`6a6a4a2`). The automated cherry-pick failed
with conflicts, so this was resolved by hand per the bot's instructions.

## Why
#17348 is labelled for this release. The auto-backport workflow could
not apply it because this branch predates several `main` refactors the
commit sits on top of.

## Root cause of the conflict
Not a stacking conflict — the open backports the bot pointed at (#17720
/ #17721 / #17600) are workflow and ECS test-coverage changes that touch
none of the conflicting files. The conflicts are genuine divergence
between `main` and this branch.

## How — conflicts and how each was resolved

- **`billingOperationStore.ts`** — `main` wraps `handleSuccess`'s body
in `try { cleanup(opId) … }`; this branch does not. The checkout-journey
clear is placed before the success telemetry here, keeping the same
guarantee (it runs before any cleanup path can throw) against this
branch's structure.
- **`TopUpCreditsDialogContentWorkspace.test.ts`** — this branch mocks
the operation store with hoisted `mockStartOperation` and has no
`billingOperationTestUtils` helper, which `main`'s version of this file
depends on. Taking `main`'s blocks wholesale compiled but broke all 31
tests, so only #17348's journey additions were applied onto this
branch's own structure, plus a `firebase/auth` spy mock so
`useAuthStore()` does not reach real Firebase.
- **`types.ts`** — the conflict region carried `FetchTimeoutMetadata`,
which belongs to a `main`-only feature and has no consumer here.
Dropped; `knip` confirms nothing else was over-pulled.
- **Provider imports and the ADR index** — merged with this branch's
existing entries.

The diff against this branch now adds exactly the symbols #17348 added,
and nothing else.

## AS IS / TO BE
Not applicable — this is a telemetry-only backport with no user-visible
surface. #17348 changes no checkout UX or payment behavior; it adds
`billing.checkout.*` events alongside the existing terminal `billing.*`
taxonomy.

## Verification
- 7 affected suites, 362 tests passing
- `pnpm typecheck`, `pnpm knip`, `pnpm lint` (0 errors) clean
comfy-pr-bot pushed a commit that referenced this pull request Sep 17, 2026
…entation (#17348) (#17752)

Manual backport of #17348 (`6a6a4a2`). The automated cherry-pick failed
with conflicts, so this was resolved by hand per the bot's instructions.

## Why
#17348 is labelled for this release. The auto-backport workflow could
not apply it because this branch predates several `main` refactors the
commit sits on top of.

## Root cause of the conflict
Not a stacking conflict — the open backports the bot pointed at (#17720
/ #17721 / #17600) are workflow and ECS test-coverage changes that touch
none of the conflicting files. The conflicts are genuine divergence
between `main` and this branch.

## How — conflicts and how each was resolved

- **`billingOperationStore.ts`** — `main` wraps `handleSuccess`'s body
in `try { cleanup(opId) … }`; this branch does not. The checkout-journey
clear is placed before the success telemetry here, keeping the same
guarantee (it runs before any cleanup path can throw) against this
branch's structure.
- **`TopUpCreditsDialogContentWorkspace.vue`** — this branch names the
polling computed `isPolling`, `main` renamed it `isAddingCredits`. Kept
this branch's name.
- **Provider event sets** — this branch types `TELEMETRY_EVENT_SET` as
`Set<TelemetryEventName>` rather than `Set<string>`, so the
checkout-journey names are spread into that typed set.
- **`TopUpCreditsDialogContentWorkspace.test.ts` /
`TelemetryRegistry.test.ts`** — this branch mocks the operation store
with hoisted mocks and has no `billingOperationTestUtils` helper, which
`main`'s version depends on. Taking `main`'s blocks wholesale compiled
but broke every test, so only #17348's journey additions were applied
onto this branch's own structure, plus a `firebase/auth` spy so
`useAuthStore()` does not reach real Firebase.
- **`types.ts` / `TelemetryRegistry.ts`** — the conflict regions carried
`FetchTimeoutMetadata` and `BootstrapCompleteMetadata`, both from
`main`-only features with no consumer here. Dropped; `knip` confirms
nothing else was over-pulled.
- **ADR index** — this branch still uses the numeric ADR naming scheme,
so the row was appended rather than slotted into a domain-led ordering.

The diff against this branch now adds exactly the symbols #17348 added,
and nothing else.

## AS IS / TO BE
Not applicable — this is a telemetry-only backport with no user-visible
surface. #17348 changes no checkout UX or payment behavior; it adds
`billing.checkout.*` events alongside the existing terminal `billing.*`
taxonomy.

## Verification
- 7 affected suites, 342 tests passing
- `pnpm typecheck`, `pnpm knip`, `pnpm lint` (0 errors) clean

Co-authored-by: Luke Mino-Altherr <luke@comfy.org>
comfy-pr-bot pushed a commit that referenced this pull request Sep 17, 2026
…mentation (#17348) (#17753)

Manual backport of #17348 (`6a6a4a2`). The automated cherry-pick failed
with conflicts, so this was resolved by hand per the bot's instructions.

## Why
#17348 is labelled for this release. The auto-backport workflow could
not apply it because this branch predates several `main` refactors the
commit sits on top of.

## Root cause of the conflict
Not a stacking conflict — the open backports the bot pointed at (#17720
/ #17721 / #17600) are workflow and ECS test-coverage changes that touch
none of the conflicting files. The conflicts are genuine divergence
between `main` and this branch.

## How — conflicts and how each was resolved

- **`billingOperationStore.ts`** — `main` wraps `handleSuccess`'s body
in `try { cleanup(opId) … }`; this branch does not. The checkout-journey
clear is placed before the success telemetry here, keeping the same
guarantee (it runs before any cleanup path can throw) against this
branch's structure.
- **`TopUpCreditsDialogContentWorkspace.vue`** — this branch keeps
`isAddingCredits`, unlike core/1.53 which uses `isPolling`.
- **Provider event sets** — this branch types `TELEMETRY_EVENT_SET` as
`Set<TelemetryEventName>` rather than `Set<string>`, so the
checkout-journey names are spread into that typed set.
- **`TopUpCreditsDialogContentWorkspace.test.ts` /
`TelemetryRegistry.test.ts`** — this branch mocks the operation store
with hoisted mocks and has no `billingOperationTestUtils` helper, which
`main`'s version depends on. Taking `main`'s blocks wholesale compiled
but broke every test, so only #17348's journey additions were applied
onto this branch's own structure, plus a `firebase/auth` spy so
`useAuthStore()` does not reach real Firebase.
- **`types.ts` / `TelemetryRegistry.ts`** — the conflict regions carried
`FetchTimeoutMetadata` and `BootstrapCompleteMetadata`, both from
`main`-only features with no consumer here. Dropped; `knip` confirms
nothing else was over-pulled.
- **ADR index** — this branch still uses the numeric ADR naming scheme,
so the row was appended rather than slotted into a domain-led ordering.

The diff against this branch now adds exactly the symbols #17348 added,
and nothing else.

## AS IS / TO BE
Not applicable — this is a telemetry-only backport with no user-visible
surface. #17348 changes no checkout UX or payment behavior; it adds
`billing.checkout.*` events alongside the existing terminal `billing.*`
taxonomy.

## Verification
- 7 affected suites, 352 tests passing
- `pnpm typecheck`, `pnpm knip`, `pnpm lint` (0 errors) clean

Co-authored-by: Luke Mino-Altherr <luke@comfy.org>
@vercel

vercel Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
billing-web-test Error Error Sep 24, 2026 8:28am UTC
1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 24, 2026 8:28am UTC

Request Review

@datadog-official

datadog-official Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Pipelines

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 4 Pipeline jobs failed

CI: Lint Format | lint-and-format — 🔧 Needs a code fix, caused by this PR

View in Datadog · View in GitHub Actions

CI: Tests E2E | playwright-tests-chromium-sharded (16, 16) — 🔧 Needs a code fix, caused by this PR

View in Datadog · View in GitHub Actions

CI: Tests E2E | playwright-video-new-tests — 🔧 Needs a code fix, caused by this PR

View in Datadog · View in GitHub Actions

View all 4 failed jobs.

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c172228 | Docs | View more details | Give us feedback!

@christian-byrne

Copy link
Copy Markdown
Contributor

Closing: this cannot compile on cloud/1.53 and there is no production fix behind it.

The PR is a single file, browser_tests/tests/widgets/ecsWidgets.spec.ts, and zero src/ changes. It is QA coverage for the ECS widget API, backported to a branch that does not have that API:

                       main  cloud/1.55  cloud/1.54  cloud/1.53
connectionSuppressed      5           5           0           0
isWidgetRowVisible        2           2           0           0

Hence the two required failures:

ecsWidgets.spec.ts(103,45): error TS2339: Property 'connectionSuppressed' does not exist on type 'IBaseWidget<...>'
ecsWidgets.spec.ts(105,39): error TS2551: Property 'isWidgetRowVisible' does not exist on type 'LGraphNode | SubgraphNode'

lint-and-format fails on those, and e2e-status fails downstream of the same spec not compiling. Neither is flake and neither clears on a re-run.

Making this pass would mean backporting the ECS widget API itself to 1.53, which is a feature, not a fix. Backporting test coverage to a release line that lacks the feature under test buys nothing, so the right outcome is to drop it rather than carry a permanently-red PR against cloud/1.53.

It has been approved and red since 2026-09-13. The same coverage is already on main and cloud/1.55, where the API exists.

This branch had an error being deployed

1 failed deployment
Preview – billing-web-test — c172228a Deployed Sep 24, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:R2 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants