Repository navigation
[backport cloud/1.53] test: add ECS widget QA coverage - #17600
comfy-pr-bot wants to merge 5 commits into
Conversation
- Covers source-deletion restoration and special-character multiline persistence. - Two focused Chromium cases pass at `239398abea`. - Duplicate clear, combo, and pin cases were removed in favor of their feature owners. <details><summary>Full context for agent readers</summary> The restoration case explicitly uses the legacy renderer and proves the retained seed value plus a visible, enabled, connection-unsuppressed widget row after direct source-node removal. The multiline case explicitly uses Vue Nodes and preserves newlines, Unicode, HTML-like text, ampersands, hashes, and percentages across save/reload. Existing owners remain `vueNodes/widgets/widgetValuePersistence.spec.ts`, `vueNodes/widgets/combo/comboWidget.spec.ts`, and `vueNodes/nodeStates/pin.spec.ts`. Verification: Oxfmt, Oxlint, ESLint, browser typecheck, and Knip passed. Focused Chromium: 2/2. Mutating the expected restored visibility to false failed the restoration oracle. Logs: `/tmp/ecs-wake1/logs/pr-17460-static.log`, `pr-17460-targeted.log`, and `pr-17460-mutation.log`. </details>
Pull request was closed
🎭 Playwright: ❌ 1899 passed, 1 failed · 3 flaky❌ Failed Tests📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-24T08:41:10.631Z",
"gitSha": "269c6d3ab4f29628c4e0e7b75875c01a0295cab9",
"branch": "backport-17460-to-cloud-1.53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2038.3790000000204,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.973000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.30500000000006,
"heapDeltaBytes": -10838504,
"heapUsedBytes": 58916932,
"domNodes": -280,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 6.804000000000001,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1998.0389999999488,
"styleRecalcs": 8,
"styleRecalcDurationMs": 5.4209999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.52299999999997,
"heapDeltaBytes": 395728,
"heapUsedBytes": 70848180,
"domNodes": -282,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.829999999999999,
"eventListeners": -187,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1796.541999999988,
"styleRecalcs": 76,
"styleRecalcDurationMs": 33.667,
"layouts": 14,
"layoutDurationMs": 3.5449999999999995,
"taskDurationMs": 856.923,
"heapDeltaBytes": 12314684,
"heapUsedBytes": 81497048,
"domNodes": -279,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 134.55100000000002,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1740.8960000000206,
"styleRecalcs": 74,
"styleRecalcDurationMs": 26.694,
"layouts": 14,
"layoutDurationMs": 3.432,
"taskDurationMs": 712.986,
"heapDeltaBytes": -9054264,
"heapUsedBytes": 61494724,
"domNodes": -280,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 114.16500000000002,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.2340000000281,
"styleRecalcs": 31,
"styleRecalcDurationMs": 13.38,
"layouts": 6,
"layoutDurationMs": 0.889,
"taskDurationMs": 309.88699999999994,
"heapDeltaBytes": 4399820,
"heapUsedBytes": 74075608,
"domNodes": 76,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8.319,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1672.2520000000713,
"styleRecalcs": 30,
"styleRecalcDurationMs": 13.569,
"layouts": 6,
"layoutDurationMs": 1.0880000000000003,
"taskDurationMs": 320.503,
"heapDeltaBytes": 4435464,
"heapUsedBytes": 73943588,
"domNodes": 78,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8.443,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 557.8229999999849,
"styleRecalcs": 12,
"styleRecalcDurationMs": 5.507999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 374.354,
"heapDeltaBytes": 17853884,
"heapUsedBytes": 88148168,
"domNodes": 20,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 128.659,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 544.6069999999281,
"styleRecalcs": 12,
"styleRecalcDurationMs": 6.415000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 365.785,
"heapDeltaBytes": -8121316,
"heapUsedBytes": 62415096,
"domNodes": 20,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 124.63699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 1998.6660000000143,
"styleRecalcs": 2,
"styleRecalcDurationMs": 1.2600000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 481.27599999999995,
"heapDeltaBytes": 22206276,
"heapUsedBytes": 87381200,
"domNodes": -274,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 22.201000000000004,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2037.8920000000562,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.277,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 536.3350000000002,
"heapDeltaBytes": -13538904,
"heapUsedBytes": 86867044,
"domNodes": -267,
"jsHeapTotalBytes": -1093632,
"scriptDurationMs": 24.985,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2187.6980000000117,
"styleRecalcs": 66,
"styleRecalcDurationMs": 8.146999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1366.855,
"heapDeltaBytes": 12996632,
"heapUsedBytes": 88833436,
"domNodes": -273,
"jsHeapTotalBytes": 143360,
"scriptDurationMs": 645.274,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2066.6630000000623,
"styleRecalcs": 65,
"styleRecalcDurationMs": 6.621999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1259.541,
"heapDeltaBytes": 21117980,
"heapUsedBytes": 87074528,
"domNodes": -5,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 604.915,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3116.047999999978,
"styleRecalcs": 62,
"styleRecalcDurationMs": 8.84,
"layouts": 60,
"layoutDurationMs": 9.74,
"taskDurationMs": 1361.1740000000002,
"heapDeltaBytes": 7746500,
"heapUsedBytes": 75414624,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 584.1310000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3131.0869999999795,
"styleRecalcs": 62,
"styleRecalcDurationMs": 8.306999999999999,
"layouts": 60,
"layoutDurationMs": 9.340000000000002,
"taskDurationMs": 1361.0320000000002,
"heapDeltaBytes": 8174252,
"heapUsedBytes": 75371452,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 588.0529999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2243.223999999998,
"styleRecalcs": 40,
"styleRecalcDurationMs": 3.141999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1490.356,
"heapDeltaBytes": 16702108,
"heapUsedBytes": 84716228,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 712.2900000000001,
"eventListeners": 184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2477.2480000000314,
"styleRecalcs": 41,
"styleRecalcDurationMs": 4.725999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1492.2730000000001,
"heapDeltaBytes": 18191596,
"heapUsedBytes": 85602664,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 714.38,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2004.052999999999,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.753000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.55500000000006,
"heapDeltaBytes": 21771172,
"heapUsedBytes": 87897052,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 22.29099999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 2030.5319999999938,
"styleRecalcs": 6,
"styleRecalcDurationMs": 4.292999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.531,
"heapDeltaBytes": 10456976,
"heapUsedBytes": 87114532,
"domNodes": -268,
"jsHeapTotalBytes": -2965504,
"scriptDurationMs": 22.118,
"eventListeners": -181,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 579.3630000000007,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.179,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 355.186,
"heapDeltaBytes": 14798684,
"heapUsedBytes": 87576992,
"domNodes": 22,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 116.90400000000001,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 539.2519999999195,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.677,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 338.931,
"heapDeltaBytes": 15046400,
"heapUsedBytes": 87959936,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 110.316,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2007.0089999999823,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.623,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 444.3090000000001,
"heapDeltaBytes": 3523472,
"heapUsedBytes": 76302352,
"domNodes": -296,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.994999999999997,
"eventListeners": -233,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2009.9060000000009,
"styleRecalcs": 9,
"styleRecalcDurationMs": 5.935,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.141,
"heapDeltaBytes": -8247772,
"heapUsedBytes": 64359148,
"domNodes": -298,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 6.5120000000000005,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1710.5489999999577,
"styleRecalcs": 78,
"styleRecalcDurationMs": 30.267,
"layouts": 18,
"layoutDurationMs": 4.233,
"taskDurationMs": 696.5469999999999,
"heapDeltaBytes": 2059360,
"heapUsedBytes": 74825404,
"domNodes": -298,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 80.64600000000002,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1685.6109999999944,
"styleRecalcs": 76,
"styleRecalcDurationMs": 25.820999999999998,
"layouts": 18,
"layoutDurationMs": 3.589,
"taskDurationMs": 689.367,
"heapDeltaBytes": -13039300,
"heapUsedBytes": 59599200,
"domNodes": -297,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 75.44000000000001,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 999.7680000000173,
"styleRecalcs": 20,
"styleRecalcDurationMs": 25.868999999999996,
"layouts": 16,
"layoutDurationMs": 12.013,
"taskDurationMs": 773.8150000000002,
"heapDeltaBytes": 19913904,
"heapUsedBytes": 103368856,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 22.626999999999995,
"eventListeners": 2381,
"totalBlockingTimeMs": 132,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8195.644000000015,
"styleRecalcs": 248,
"styleRecalcDurationMs": 24.339999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4679.366,
"heapDeltaBytes": 9198768,
"heapUsedBytes": 84995124,
"domNodes": -273,
"jsHeapTotalBytes": -905216,
"scriptDurationMs": 2051.3500000000004,
"eventListeners": -167,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8186.309000000051,
"styleRecalcs": 248,
"styleRecalcDurationMs": 23.693,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4586.576,
"heapDeltaBytes": 23647360,
"heapUsedBytes": 88687240,
"domNodes": -267,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 2000.2929999999997,
"eventListeners": -135,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 12627.711000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11808.999,
"heapDeltaBytes": -28659780,
"heapUsedBytes": 181247896,
"domNodes": -6548,
"jsHeapTotalBytes": 1929216,
"scriptDurationMs": 190.696,
"eventListeners": -7477,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12685.381000000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11743.078000000001,
"heapDeltaBytes": -33636784,
"heapUsedBytes": 175235440,
"domNodes": -6548,
"jsHeapTotalBytes": -4894720,
"scriptDurationMs": 151.45999999999998,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 15501.842000000068,
"styleRecalcs": 77,
"styleRecalcDurationMs": 12.397999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14915.847000000002,
"heapDeltaBytes": -21954032,
"heapUsedBytes": 174969108,
"domNodes": -6548,
"jsHeapTotalBytes": 6328320,
"scriptDurationMs": 735.269,
"eventListeners": -7471,
"totalBlockingTimeMs": 26,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 15630.041000000005,
"styleRecalcs": 79,
"styleRecalcDurationMs": 12.123999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15035.598,
"heapDeltaBytes": -38408836,
"heapUsedBytes": 165901908,
"domNodes": -6548,
"jsHeapTotalBytes": -569344,
"scriptDurationMs": 782.119,
"eventListeners": -7471,
"totalBlockingTimeMs": 76,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4490.218999999911,
"styleRecalcs": 20,
"styleRecalcDurationMs": 66.943,
"layouts": 20,
"layoutDurationMs": 19.083000000000002,
"taskDurationMs": 4312.141,
"heapDeltaBytes": -30071144,
"heapUsedBytes": 179301344,
"domNodes": -6548,
"jsHeapTotalBytes": 10018816,
"scriptDurationMs": 69.808,
"eventListeners": -7471,
"totalBlockingTimeMs": 34,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 4534.948999999983,
"styleRecalcs": 20,
"styleRecalcDurationMs": 66.745,
"layouts": 20,
"layoutDurationMs": 19.421000000000006,
"taskDurationMs": 4379.242,
"heapDeltaBytes": -21739280,
"heapUsedBytes": 180653548,
"domNodes": -6548,
"jsHeapTotalBytes": 12840960,
"scriptDurationMs": 72.73100000000001,
"eventListeners": -7475,
"totalBlockingTimeMs": 48,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 457.75800000001254,
"styleRecalcs": 21,
"styleRecalcDurationMs": 19.865000000000002,
"layouts": 5,
"layoutDurationMs": 1.7759999999999998,
"taskDurationMs": 109.72500000000001,
"heapDeltaBytes": 5366500,
"heapUsedBytes": 74086844,
"domNodes": 157,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.346999999999998,
"eventListeners": 97,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 109.53400000005331,
"styleRecalcs": 8,
"styleRecalcDurationMs": 13.418999999999999,
"layouts": 2,
"layoutDurationMs": 1.389,
"taskDurationMs": 70.42899999999999,
"heapDeltaBytes": 3228772,
"heapUsedBytes": 71666948,
"domNodes": 108,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.66,
"eventListeners": 49,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E CoverageNote Shard completeness could not be verified for this run, so these totals may not be comparable with a whole merge.
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.53 #17600 +/- ##
=============================================
Coverage ? 83.42%
=============================================
Files ? 2028
Lines ? 117787
Branches ? 33307
=============================================
Hits ? 98266
Misses ? 19163
Partials ? 358
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
…entation (#17348) (#17750) Manual backport of #17348 (`6a6a4a2`). The automated cherry-pick failed with conflicts, so this was resolved by hand per the bot's instructions. ## Why #17348 is labelled for this release. The auto-backport workflow could not apply it because this branch predates several `main` refactors the commit sits on top of. ## Root cause of the conflict Not a stacking conflict — the open backports the bot pointed at (#17720 / #17721 / #17600) are workflow and ECS test-coverage changes that touch none of the conflicting files. The conflicts are genuine divergence between `main` and this branch. ## How — conflicts and how each was resolved - **`billingOperationStore.ts`** — `main` wraps `handleSuccess`'s body in `try { cleanup(opId) … }`; this branch does not. The checkout-journey clear is placed before the success telemetry here, keeping the same guarantee (it runs before any cleanup path can throw) against this branch's structure. - **`TopUpCreditsDialogContentWorkspace.test.ts`** — this branch mocks the operation store with hoisted `mockStartOperation` and has no `billingOperationTestUtils` helper, which `main`'s version of this file depends on. Taking `main`'s blocks wholesale compiled but broke all 31 tests, so only #17348's journey additions were applied onto this branch's own structure, plus a `firebase/auth` spy mock so `useAuthStore()` does not reach real Firebase. - **`types.ts`** — the conflict region carried `FetchTimeoutMetadata`, which belongs to a `main`-only feature and has no consumer here. Dropped; `knip` confirms nothing else was over-pulled. - **Provider imports and the ADR index** — merged with this branch's existing entries. The diff against this branch now adds exactly the symbols #17348 added, and nothing else. ## AS IS / TO BE Not applicable — this is a telemetry-only backport with no user-visible surface. #17348 changes no checkout UX or payment behavior; it adds `billing.checkout.*` events alongside the existing terminal `billing.*` taxonomy. ## Verification - 7 affected suites, 362 tests passing - `pnpm typecheck`, `pnpm knip`, `pnpm lint` (0 errors) clean
…mentation (#17348) (#17751) Manual backport of #17348 (`6a6a4a2`). The automated cherry-pick failed with conflicts, so this was resolved by hand per the bot's instructions. ## Why #17348 is labelled for this release. The auto-backport workflow could not apply it because this branch predates several `main` refactors the commit sits on top of. ## Root cause of the conflict Not a stacking conflict — the open backports the bot pointed at (#17720 / #17721 / #17600) are workflow and ECS test-coverage changes that touch none of the conflicting files. The conflicts are genuine divergence between `main` and this branch. ## How — conflicts and how each was resolved - **`billingOperationStore.ts`** — `main` wraps `handleSuccess`'s body in `try { cleanup(opId) … }`; this branch does not. The checkout-journey clear is placed before the success telemetry here, keeping the same guarantee (it runs before any cleanup path can throw) against this branch's structure. - **`TopUpCreditsDialogContentWorkspace.test.ts`** — this branch mocks the operation store with hoisted `mockStartOperation` and has no `billingOperationTestUtils` helper, which `main`'s version of this file depends on. Taking `main`'s blocks wholesale compiled but broke all 31 tests, so only #17348's journey additions were applied onto this branch's own structure, plus a `firebase/auth` spy mock so `useAuthStore()` does not reach real Firebase. - **`types.ts`** — the conflict region carried `FetchTimeoutMetadata`, which belongs to a `main`-only feature and has no consumer here. Dropped; `knip` confirms nothing else was over-pulled. - **Provider imports and the ADR index** — merged with this branch's existing entries. The diff against this branch now adds exactly the symbols #17348 added, and nothing else. ## AS IS / TO BE Not applicable — this is a telemetry-only backport with no user-visible surface. #17348 changes no checkout UX or payment behavior; it adds `billing.checkout.*` events alongside the existing terminal `billing.*` taxonomy. ## Verification - 7 affected suites, 362 tests passing - `pnpm typecheck`, `pnpm knip`, `pnpm lint` (0 errors) clean
…entation (#17348) (#17752) Manual backport of #17348 (`6a6a4a2`). The automated cherry-pick failed with conflicts, so this was resolved by hand per the bot's instructions. ## Why #17348 is labelled for this release. The auto-backport workflow could not apply it because this branch predates several `main` refactors the commit sits on top of. ## Root cause of the conflict Not a stacking conflict — the open backports the bot pointed at (#17720 / #17721 / #17600) are workflow and ECS test-coverage changes that touch none of the conflicting files. The conflicts are genuine divergence between `main` and this branch. ## How — conflicts and how each was resolved - **`billingOperationStore.ts`** — `main` wraps `handleSuccess`'s body in `try { cleanup(opId) … }`; this branch does not. The checkout-journey clear is placed before the success telemetry here, keeping the same guarantee (it runs before any cleanup path can throw) against this branch's structure. - **`TopUpCreditsDialogContentWorkspace.vue`** — this branch names the polling computed `isPolling`, `main` renamed it `isAddingCredits`. Kept this branch's name. - **Provider event sets** — this branch types `TELEMETRY_EVENT_SET` as `Set<TelemetryEventName>` rather than `Set<string>`, so the checkout-journey names are spread into that typed set. - **`TopUpCreditsDialogContentWorkspace.test.ts` / `TelemetryRegistry.test.ts`** — this branch mocks the operation store with hoisted mocks and has no `billingOperationTestUtils` helper, which `main`'s version depends on. Taking `main`'s blocks wholesale compiled but broke every test, so only #17348's journey additions were applied onto this branch's own structure, plus a `firebase/auth` spy so `useAuthStore()` does not reach real Firebase. - **`types.ts` / `TelemetryRegistry.ts`** — the conflict regions carried `FetchTimeoutMetadata` and `BootstrapCompleteMetadata`, both from `main`-only features with no consumer here. Dropped; `knip` confirms nothing else was over-pulled. - **ADR index** — this branch still uses the numeric ADR naming scheme, so the row was appended rather than slotted into a domain-led ordering. The diff against this branch now adds exactly the symbols #17348 added, and nothing else. ## AS IS / TO BE Not applicable — this is a telemetry-only backport with no user-visible surface. #17348 changes no checkout UX or payment behavior; it adds `billing.checkout.*` events alongside the existing terminal `billing.*` taxonomy. ## Verification - 7 affected suites, 342 tests passing - `pnpm typecheck`, `pnpm knip`, `pnpm lint` (0 errors) clean Co-authored-by: Luke Mino-Altherr <luke@comfy.org>
…mentation (#17348) (#17753) Manual backport of #17348 (`6a6a4a2`). The automated cherry-pick failed with conflicts, so this was resolved by hand per the bot's instructions. ## Why #17348 is labelled for this release. The auto-backport workflow could not apply it because this branch predates several `main` refactors the commit sits on top of. ## Root cause of the conflict Not a stacking conflict — the open backports the bot pointed at (#17720 / #17721 / #17600) are workflow and ECS test-coverage changes that touch none of the conflicting files. The conflicts are genuine divergence between `main` and this branch. ## How — conflicts and how each was resolved - **`billingOperationStore.ts`** — `main` wraps `handleSuccess`'s body in `try { cleanup(opId) … }`; this branch does not. The checkout-journey clear is placed before the success telemetry here, keeping the same guarantee (it runs before any cleanup path can throw) against this branch's structure. - **`TopUpCreditsDialogContentWorkspace.vue`** — this branch keeps `isAddingCredits`, unlike core/1.53 which uses `isPolling`. - **Provider event sets** — this branch types `TELEMETRY_EVENT_SET` as `Set<TelemetryEventName>` rather than `Set<string>`, so the checkout-journey names are spread into that typed set. - **`TopUpCreditsDialogContentWorkspace.test.ts` / `TelemetryRegistry.test.ts`** — this branch mocks the operation store with hoisted mocks and has no `billingOperationTestUtils` helper, which `main`'s version depends on. Taking `main`'s blocks wholesale compiled but broke every test, so only #17348's journey additions were applied onto this branch's own structure, plus a `firebase/auth` spy so `useAuthStore()` does not reach real Firebase. - **`types.ts` / `TelemetryRegistry.ts`** — the conflict regions carried `FetchTimeoutMetadata` and `BootstrapCompleteMetadata`, both from `main`-only features with no consumer here. Dropped; `knip` confirms nothing else was over-pulled. - **ADR index** — this branch still uses the numeric ADR naming scheme, so the row was appended rather than slotted into a domain-led ordering. The diff against this branch now adds exactly the symbols #17348 added, and nothing else. ## AS IS / TO BE Not applicable — this is a telemetry-only backport with no user-visible surface. #17348 changes no checkout UX or payment behavior; it adds `billing.checkout.*` events alongside the existing terminal `billing.*` taxonomy. ## Verification - 7 affected suites, 352 tests passing - `pnpm typecheck`, `pnpm knip`, `pnpm lint` (0 errors) clean Co-authored-by: Luke Mino-Altherr <luke@comfy.org>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 4 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: c172228 | Docs | View more details | Give us feedback! |
|
Closing: this cannot compile on The PR is a single file, Hence the two required failures:
Making this pass would mean backporting the ECS widget API itself to 1.53, which is a feature, not a fix. Backporting test coverage to a release line that lacks the feature under test buys nothing, so the right outcome is to drop it rather than carry a permanently-red PR against It has been approved and red since 2026-09-13. The same coverage is already on |
Backport of #17460 to
cloud/1.53Automatically created by backport workflow.