Skip to content

[backport core/1.53] test: add ECS feature sanity coverage - #18971

Closed
comfy-pr-bot wants to merge 1 commit into
core/1.53from
backport-17459-to-core-1.53
Closed

comfy-pr-bot wants to merge 1 commit into
core/1.53from
backport-17459-to-core-1.53

Conversation

@comfy-pr-bot

Copy link
Copy Markdown
Member

Backport of #17459 to core/1.53

Automatically created by backport workflow.

Adds e2e coverage for four ECS migration behaviours, in both the Vue and
legacy renderers:

- **Node source badge Settings transitions**
(`nodeSourceBadgeMode.spec.ts`). Drives the real Settings control
through Show all, Hide built-in, None, Show all again, with no reload.
Core `PreviewImage` and custom `DevToolsErrorRaiseNode` are expected to
differ under Hide built-in. Vue asserts on visible badges; legacy
observes actual `drawBadges`/`fillText` calls and waits for a completed
frame.
- **API pricing badge toggle** (`apiPricingBadge.spec.ts`).
- **Link disconnect/reconnect at emulated DPR 1.5**
(`links/deviceScaleFactor.spec.ts`). Exact endpoints and output-link
count.
- **Marquee selection at emulated DPR 1.5**
(`selection/deviceScaleFactor.spec.ts`). Exact two-node selection.

Both scaling tests use Playwright's emulated `deviceScaleFactor`, not
physical display scaling or browser zoom. Physical display validation
stays manual.

Supporting fixtures: `LegacyNodeBadgeHelper` (legacy badge probe),
`SettingDialog.selectSetting`.

[QA
plan](https://app.notion.com/p/comfy-org/3c56d73d365081629481ea0f1d09fc65)
· [Migration](#14246)

<details><summary>Rebase note, 2026-09-25</summary>

The branch had drifted 634 commits behind `main` and was red on
`typecheck-aux`, `repo-checks`, `fallow` and `lint`. Rebased clean (no
conflicts, diff unchanged at 551 lines across 7 files) and fixed the
fallout in `e8ae9041a0`:

- `Settings` moved out of `@/schemas/apiSchema`. The unresolved import
was the single cause of the typecheck, knip and fallow failures.
- `SettingDialog` already imports `comfyExpect as expect`; the added
`@playwright/test` `expect` was a duplicate identifier.
- `vueNodes.waitForNodes()` no longer takes a count.
- `comfy(prefer-initial-settings)` landed after this branch was cut.
Startup settings moved to `test.use({ initialSettings })`, and the
settings-only `afterEach` teardown was removed: `comfyPageFixture`
reseeds settings before each test, so the restores were dead code. That
supersedes three earlier commits on this branch that added those
restores in response to review. Dropping them also removes
describe-scope mutable state shared across the renderer loop.

Earlier body text referenced pre-rebase commit SHAs and out-of-scope
claims (body zoom, API serialization, locale layout, download/re-import,
Browse Templates undo, missing-model dialogs). None of that is in this
PR; removed so it does not read as a spec.

</details>

---------

Co-authored-by: Amp <amp@ampcode.com>
@comfy-pr-bot comfy-pr-bot added the backport Backporting a PR onto a release candidate label Sep 26, 2026
@vercel

vercel Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
billing-web-test Error Error Sep 26, 2026 7:38am UTC
1 Skipped Deployment
Project Deployment Actions Updated
billing-web Ignored Ignored Sep 26, 2026 7:38am UTC

Request Review

@github-actions

github-actions Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: 🕵🏻 0 passed, 0 failed

📊 Browser Reports

📦 Bundle Size

⏳ Size data collection in progress…

🔬 E2E Coverage

⚠️ Coverage collection failed. Check the CI workflow logs.

@github-actions github-actions Bot added the risk:R2 PR risk grade (advisory shadow check; grader-owned) label Sep 26, 2026
@github-actions
github-actions Bot requested a review from huang47 September 26, 2026 07:38
@datadog-official

datadog-official Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Pipelines

❌ Errors

Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 26 Pipeline jobs failed

CI: Lint Format | lint-and-format — 🔧 Needs a code fix, caused by this PR

View in Datadog · View in GitHub Actions

CI: Tests Custom Nodes | custom_nodes_e2e (2/5, 0) — 🔧 Needs a code fix, caused by this PR

View in Datadog · View in GitHub Actions

CI: Tests E2E | playwright-tests-chromium-sharded (1, 16) — 🔧 Needs a code fix, caused by this PR

View in Datadog · View in GitHub Actions

View all 26 failed jobs.

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: c3ea363 | Docs | View more details | Give us feedback!

@codecov

codecov Bot commented Sep 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@             Coverage Diff             @@
##           core/1.53   #18971    +/-   ##
===========================================
  Coverage      83.32%   83.32%            
===========================================
  Files           2037     2037            
  Lines         117762   117762            
  Branches       32686    33277   +591     
===========================================
  Hits           98130    98130            
  Misses         19278    19278            
  Partials         354      354            
Flag Coverage Δ
unit 76.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@christian-byrne

Copy link
Copy Markdown
Contributor

Closing: this cannot pass on core/1.53 without importing a much larger change, and there is no user-facing fix behind it.

Zero src/ files — it is test coverage only. Both required checks fail, and the cause is one unresolvable import:

knip: Unlisted dependencies (1)
  @e2e/fixtures/networkIsolationFixture  browser_tests/fixtures/legacyNodeBadgeFixture.ts:2:49

browser_tests/fixtures/networkIsolationFixture.ts exists on main, 1.55 and 1.54, and on neither 1.53 branch. That takes out lint-and-format via knip and e2e-status via every Playwright shard, since the fixture cannot resolve.

The rule for this shape is to backport the missing module rather than rewrite the import. I checked, and here that is disproportionate: the fixture arrives in cc69f9a78 ("test: isolate browser tests from external networks", #17160), which is 43 files and 712 insertions — an oxlint plugin, a shell script, and edits across the whole browser suite. Importing that into a two-releases-back branch to enable sanity coverage risks the 1.53 suite for no user-facing gain.

1.53 is still taking backports, but the recent ones carry src/ fixes that protect users. This one does not.

Same disposition as #17600 for the same reason. The coverage is already on main, 1.55 and 1.54, where the fixture exists.

auto-merge was automatically disabled September 26, 2026 07:52

Pull request was closed

This branch had an error being deployed

1 failed deployment
Preview – billing-web-test — c3ea363e Deployed Sep 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:R2 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants