Repository navigation
[backport core/1.53] feat(billing): embedded checkout journey instrumentation (#17348) - #17752
Conversation
…entation (#17348) Manual backport of 6a6a4a2 — the automated cherry-pick hit conflicts. Resolutions against this branch: - billingOperationStore: no try/cleanup restructure here, so the journey clear sits before the success telemetry instead. - TopUpCreditsDialogContentWorkspace.vue: this branch names the polling computed isPolling, not isAddingCredits. - Provider event sets: this branch types the Set as TelemetryEventName, so the checkout names are spread into that typed set rather than a Set<string>. - TopUpCreditsDialogContentWorkspace.test / TelemetryRegistry.test: only the journey additions were applied onto this branch's own mocks, plus a firebase/auth spy so useAuthStore() does not reach real Firebase. - Dropped FetchTimeoutMetadata and BootstrapCompleteMetadata, which the conflict regions carried in from main-only features.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1889 passed, 0 failed · 3 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-15T16:10:32.520Z",
"gitSha": "f5077791d5b8b515890b0bf87b6ec84d5ab8b7d2",
"branch": "backport-17348-to-core-1.53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2089.5719999999756,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.784999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 584.3380000000001,
"heapDeltaBytes": -11712456,
"heapUsedBytes": 57801352,
"domNodes": -282,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 12.786999999999999,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2042.1549999999797,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.547999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 486.4149999999999,
"heapDeltaBytes": 12520216,
"heapUsedBytes": 82101544,
"domNodes": -284,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 10.647,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1810.23399999998,
"styleRecalcs": 75,
"styleRecalcDurationMs": 38.451,
"layouts": 14,
"layoutDurationMs": 4.531999999999999,
"taskDurationMs": 876.536,
"heapDeltaBytes": -8747016,
"heapUsedBytes": 61457448,
"domNodes": -279,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 145.55,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1858.9729999999918,
"styleRecalcs": 75,
"styleRecalcDurationMs": 36.251,
"layouts": 14,
"layoutDurationMs": 4.653,
"taskDurationMs": 869.561,
"heapDeltaBytes": -8792044,
"heapUsedBytes": 61797344,
"domNodes": -281,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 144.06900000000002,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1688.3869999999774,
"styleRecalcs": 33,
"styleRecalcDurationMs": 16.554,
"layouts": 6,
"layoutDurationMs": 1.191,
"taskDurationMs": 354.14900000000006,
"heapDeltaBytes": 4753460,
"heapUsedBytes": 75175660,
"domNodes": 79,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 10.717,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1720.980999999938,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.487000000000002,
"layouts": 6,
"layoutDurationMs": 1.0520000000000003,
"taskDurationMs": 362.576,
"heapDeltaBytes": 4458336,
"heapUsedBytes": 74317536,
"domNodes": 78,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.875,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 677.2569999999973,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.040999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.26899999999995,
"heapDeltaBytes": 17837708,
"heapUsedBytes": 88346168,
"domNodes": 18,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 160.03099999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 667.3589999999194,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.376999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.27000000000004,
"heapDeltaBytes": 17786956,
"heapUsedBytes": 88170388,
"domNodes": 16,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 155.058,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2038.725999999997,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.4749999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 589.2590000000001,
"heapDeltaBytes": -13707416,
"heapUsedBytes": 86639384,
"domNodes": -271,
"jsHeapTotalBytes": -569344,
"scriptDurationMs": 33.504000000000005,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2049.9469999999747,
"styleRecalcs": 6,
"styleRecalcDurationMs": 5.665,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 616.191,
"heapDeltaBytes": -13542312,
"heapUsedBytes": 87185392,
"domNodes": -269,
"jsHeapTotalBytes": -1093632,
"scriptDurationMs": 33.286,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2163.936999999976,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.170999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1538.9089999999999,
"heapDeltaBytes": 23483808,
"heapUsedBytes": 88941320,
"domNodes": -275,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 754.1020000000001,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2173.7549999999146,
"styleRecalcs": 65,
"styleRecalcDurationMs": 10.628000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1584.4,
"heapDeltaBytes": -16802392,
"heapUsedBytes": 85130608,
"domNodes": -273,
"jsHeapTotalBytes": -868352,
"scriptDurationMs": 763.5090000000001,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3536.147000000028,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.867999999999997,
"layouts": 60,
"layoutDurationMs": 12.597000000000001,
"taskDurationMs": 1659.017,
"heapDeltaBytes": 9447268,
"heapUsedBytes": 76004452,
"domNodes": -276,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 752.459,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3437.0290000000523,
"styleRecalcs": 61,
"styleRecalcDurationMs": 11.098,
"layouts": 60,
"layoutDurationMs": 13.207,
"taskDurationMs": 1641.445,
"heapDeltaBytes": 7712940,
"heapUsedBytes": 75484220,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 747.032,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3066.5690000000154,
"styleRecalcs": 41,
"styleRecalcDurationMs": 6.324,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1911.003,
"heapDeltaBytes": 17441452,
"heapUsedBytes": 85209688,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 965.1509999999998,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3096.5760000000273,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.2700000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1880.557,
"heapDeltaBytes": 21737788,
"heapUsedBytes": 89431956,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 940.8169999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2014.8599999999988,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.1410000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 550.596,
"heapDeltaBytes": 22151360,
"heapUsedBytes": 87495204,
"domNodes": -275,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.71,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2050.7989999999836,
"styleRecalcs": 3,
"styleRecalcDurationMs": 2.577000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 591.4789999999999,
"heapDeltaBytes": -15002284,
"heapUsedBytes": 87958128,
"domNodes": -272,
"jsHeapTotalBytes": -1093632,
"scriptDurationMs": 32.762,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 607.1390000000179,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.59599999999995,
"heapDeltaBytes": 14798112,
"heapUsedBytes": 87601312,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 142.44799999999998,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 612.487000000101,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.081,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.90799999999996,
"heapDeltaBytes": 15094256,
"heapUsedBytes": 87431048,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 145.29600000000002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2024.0380000000187,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.591999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.80999999999995,
"heapDeltaBytes": -6888120,
"heapUsedBytes": 65801256,
"domNodes": -296,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.4330000000000025,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2020.0250000000324,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.455,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.5919999999999,
"heapDeltaBytes": 2844940,
"heapUsedBytes": 75675728,
"domNodes": -297,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.056999999999999,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1767.8289999999492,
"styleRecalcs": 79,
"styleRecalcDurationMs": 42.342,
"layouts": 18,
"layoutDurationMs": 4.887,
"taskDurationMs": 797.71,
"heapDeltaBytes": -14282636,
"heapUsedBytes": 58066220,
"domNodes": -293,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 100.46000000000001,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1719.9620000000095,
"styleRecalcs": 77,
"styleRecalcDurationMs": 36.543,
"layouts": 18,
"layoutDurationMs": 5.0920000000000005,
"taskDurationMs": 807.5369999999999,
"heapDeltaBytes": -1729308,
"heapUsedBytes": 69929048,
"domNodes": -297,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 104.213,
"eventListeners": -233,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1398.8899999999376,
"styleRecalcs": 20,
"styleRecalcDurationMs": 30.288999999999998,
"layouts": 16,
"layoutDurationMs": 14.304,
"taskDurationMs": 914.0730000000001,
"heapDeltaBytes": 21105248,
"heapUsedBytes": 109639060,
"domNodes": 13751,
"jsHeapTotalBytes": 10223616,
"scriptDurationMs": 29.49299999999999,
"eventListeners": 2383,
"totalBlockingTimeMs": 129,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8398.768999999958,
"styleRecalcs": 248,
"styleRecalcDurationMs": 38.595000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5570.697,
"heapDeltaBytes": -19763212,
"heapUsedBytes": 80944504,
"domNodes": -269,
"jsHeapTotalBytes": -1130496,
"scriptDurationMs": 2564.481,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8345.481000000063,
"styleRecalcs": 248,
"styleRecalcDurationMs": 39.717,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5899.2519999999995,
"heapDeltaBytes": -10731984,
"heapUsedBytes": 90428936,
"domNodes": -266,
"jsHeapTotalBytes": 1490944,
"scriptDurationMs": 2768.904,
"eventListeners": -139,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 17892.180999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16962.064000000002,
"heapDeltaBytes": -34232708,
"heapUsedBytes": 175878088,
"domNodes": -6548,
"jsHeapTotalBytes": 4661248,
"scriptDurationMs": 299.752,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 18001.792000000023,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17297.162999999997,
"heapDeltaBytes": -27735384,
"heapUsedBytes": 176609432,
"domNodes": -6548,
"jsHeapTotalBytes": -3796992,
"scriptDurationMs": 303.396,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21262.824999999964,
"styleRecalcs": 160,
"styleRecalcDurationMs": 19.186999999999955,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20934.726000000002,
"heapDeltaBytes": -23097344,
"heapUsedBytes": 180251344,
"domNodes": -6548,
"jsHeapTotalBytes": -790528,
"scriptDurationMs": 921.1610000000002,
"eventListeners": -7467,
"totalBlockingTimeMs": 53,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21958.654000000024,
"styleRecalcs": 166,
"styleRecalcDurationMs": 20.318,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21656.048000000003,
"heapDeltaBytes": -28464844,
"heapUsedBytes": 181513108,
"domNodes": -6548,
"jsHeapTotalBytes": -3534848,
"scriptDurationMs": 923.2149999999999,
"eventListeners": -7467,
"totalBlockingTimeMs": 301,
"frameDurationMs": 19.44333333333331,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6332.267000000002,
"styleRecalcs": 20,
"styleRecalcDurationMs": 74.56599999999996,
"layouts": 20,
"layoutDurationMs": 24.970999999999993,
"taskDurationMs": 6236.547,
"heapDeltaBytes": -31257220,
"heapUsedBytes": 182321336,
"domNodes": -6548,
"jsHeapTotalBytes": 7843840,
"scriptDurationMs": 111.41699999999999,
"eventListeners": -7471,
"totalBlockingTimeMs": 510,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6497.190000000046,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.66499999999998,
"layouts": 20,
"layoutDurationMs": 26.52900000000001,
"taskDurationMs": 6418.8099999999995,
"heapDeltaBytes": -31926716,
"heapUsedBytes": 181635860,
"domNodes": -6548,
"jsHeapTotalBytes": 8892416,
"scriptDurationMs": 119.99900000000001,
"eventListeners": -7469,
"totalBlockingTimeMs": 468,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 482.70899999999983,
"styleRecalcs": 17,
"styleRecalcDurationMs": 20.695000000000004,
"layouts": 2,
"layoutDurationMs": 1.3680000000000003,
"taskDurationMs": 117.38499999999999,
"heapDeltaBytes": 5316280,
"heapUsedBytes": 73656368,
"domNodes": 151,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.458,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 460.5070000000069,
"styleRecalcs": 17,
"styleRecalcDurationMs": 23.118,
"layouts": 3,
"layoutDurationMs": 1.638,
"taskDurationMs": 111.954,
"heapDeltaBytes": 5174804,
"heapUsedBytes": 73292032,
"domNodes": 146,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.566,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.53 #17752 +/- ##
=============================================
+ Coverage 83.26% 83.36% +0.10%
=============================================
Files 2034 2033 -1
Lines 117458 117861 +403
Branches 32570 32706 +136
=============================================
+ Hits 97796 98254 +458
+ Misses 19306 19253 -53
+ Partials 356 354 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 67 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Holding this backport for 1.55 from main: there is no log of testing beyond unit tests, and the release lines need that evidence. |
christian-byrne
left a comment
There was a problem hiding this comment.
Approving as part of a batch pass over the eight unreviewed backports. For this family (#17750–#17753) I compared the 1.53 and 1.54 payloads against each other rather than reading each separately, because the question that matters for a backport set is whether every release line gets the same change.
They are equivalent except in one place, and it is deliberate. The size difference (+2351/−48 on 1.54 versus +2383/−81 on 1.53) resolves to four files, and three of them are noise — an ADR index that is ordered differently on the older branch, and a test file needing slightly more adaptation. The real one is this, in both MixpanelTelemetryProvider.ts and PostHogTelemetryProvider.ts:
// 1.54
const TELEMETRY_EVENT_SET = new Set<TelemetryEventName>([
...Object.values(TelemetryEvents),
// 1.53
const TELEMETRY_EVENT_SET = new Set<string>([
...(Object.values(TelemetryEvents) as TelemetryEventName[]),Both branches add exactly 9 and 15 lines respectively, so the behaviour is the same — the set holds the same events and filters the same way at runtime. What differs is the type: 1.53 widens the set to string and casts the spread.
I assume that is forced by TelemetryEvents having a looser shape on the older branch, which makes it a reasonable adaptation rather than a defect. Two things worth noting anyway:
- On 1.53 the set no longer constrains what can be looked up in it. Anything typed
stringis accepted. That is a weaker guarantee than 1.54 gets from the same PR, and theascast is what makes the mismatch invisible rather than resolving it. - This is only findable by comparing the siblings. Read on its own, each PR looks like a faithful backport. Worth a line in the 1.53 bodies saying the type was widened and why, so nobody later reads the two release lines as byte-identical or copies the
stringversion forward.
Nothing here blocks: the runtime payload matches, the file sets are identical, and CI is green and mergeable on all four.
Manual backport of #17348 (
6a6a4a2). The automated cherry-pick failed with conflicts, so this was resolved by hand per the bot's instructions.Why
#17348 is labelled for this release. The auto-backport workflow could not apply it because this branch predates several
mainrefactors the commit sits on top of.Root cause of the conflict
Not a stacking conflict — the open backports the bot pointed at (#17720 / #17721 / #17600) are workflow and ECS test-coverage changes that touch none of the conflicting files. The conflicts are genuine divergence between
mainand this branch.How — conflicts and how each was resolved
billingOperationStore.ts—mainwrapshandleSuccess's body intry { cleanup(opId) … }; this branch does not. The checkout-journey clear is placed before the success telemetry here, keeping the same guarantee (it runs before any cleanup path can throw) against this branch's structure.TopUpCreditsDialogContentWorkspace.vue— this branch names the polling computedisPolling,mainrenamed itisAddingCredits. Kept this branch's name.TELEMETRY_EVENT_SETasSet<TelemetryEventName>rather thanSet<string>, so the checkout-journey names are spread into that typed set.TopUpCreditsDialogContentWorkspace.test.ts/TelemetryRegistry.test.ts— this branch mocks the operation store with hoisted mocks and has nobillingOperationTestUtilshelper, whichmain's version depends on. Takingmain's blocks wholesale compiled but broke every test, so only feat(billing): embedded checkout journey instrumentation #17348's journey additions were applied onto this branch's own structure, plus afirebase/authspy souseAuthStore()does not reach real Firebase.types.ts/TelemetryRegistry.ts— the conflict regions carriedFetchTimeoutMetadataandBootstrapCompleteMetadata, both frommain-only features with no consumer here. Dropped;knipconfirms nothing else was over-pulled.The diff against this branch now adds exactly the symbols #17348 added, and nothing else.
AS IS / TO BE
Not applicable — this is a telemetry-only backport with no user-visible surface. #17348 changes no checkout UX or payment behavior; it adds
billing.checkout.*events alongside the existing terminalbilling.*taxonomy.Verification
pnpm typecheck,pnpm knip,pnpm lint(0 errors) clean