Repository navigation
[backport core/1.54] feat(billing): embedded checkout journey instrumentation (#17348) - #17750
Conversation
…entation (#17348) Manual backport of 6a6a4a2 — the automated cherry-pick hit conflicts. Resolutions against this branch: - billingOperationStore: this branch has no try/cleanup restructure, so the journey clear sits before the success telemetry instead. - TopUpCreditsDialogContentWorkspace.test: this branch mocks the operation store with hoisted mocks and has no billingOperationTestUtils helper, so only the journey setup was added onto its own structure, plus a firebase/auth spy so useAuthStore() does not reach real Firebase. - ADR index and provider imports merged with this branch's entries.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1920 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-15T15:59:40.759Z",
"gitSha": "273241b5e2e4388cf94e0adf630ff0929e1026f3",
"branch": "backport-17348-to-core-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2052.902999999958,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.022000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 356.575,
"heapDeltaBytes": -1162376,
"heapUsedBytes": 69500724,
"domNodes": -274,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 8.391,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2007.9620000000205,
"styleRecalcs": 11,
"styleRecalcDurationMs": 6.168999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 309.442,
"heapDeltaBytes": -2544700,
"heapUsedBytes": 67280048,
"domNodes": -278,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 6.185,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1774.6630000000323,
"styleRecalcs": 75,
"styleRecalcDurationMs": 35.166999999999994,
"layouts": 14,
"layoutDurationMs": 4.521,
"taskDurationMs": 660.4259999999999,
"heapDeltaBytes": 4254356,
"heapUsedBytes": 74804072,
"domNodes": -276,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 115.73000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1722.9900000000384,
"styleRecalcs": 74,
"styleRecalcDurationMs": 26.748,
"layouts": 14,
"layoutDurationMs": 4.148,
"taskDurationMs": 557.189,
"heapDeltaBytes": 1412688,
"heapUsedBytes": 70617008,
"domNodes": -276,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 99.68299999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1659.2729999999847,
"styleRecalcs": 29,
"styleRecalcDurationMs": 12.961,
"layouts": 6,
"layoutDurationMs": 0.9400000000000001,
"taskDurationMs": 236.84999999999997,
"heapDeltaBytes": 4711564,
"heapUsedBytes": 74843352,
"domNodes": 78,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 8.934000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1669.593999999961,
"styleRecalcs": 30,
"styleRecalcDurationMs": 15.223,
"layouts": 6,
"layoutDurationMs": 1.06,
"taskDurationMs": 234.83699999999996,
"heapDeltaBytes": 5072852,
"heapUsedBytes": 75694720,
"domNodes": 79,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 9.111,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 526.0069999999928,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.240999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 330.13,
"heapDeltaBytes": 17861044,
"heapUsedBytes": 87672928,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 108.993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 492.8600000000074,
"styleRecalcs": 13,
"styleRecalcDurationMs": 7.674,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 299.252,
"heapDeltaBytes": 17749220,
"heapUsedBytes": 87894564,
"domNodes": 22,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 101.36,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2037.4290000000315,
"styleRecalcs": 5,
"styleRecalcDurationMs": 6.550000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 560.4630000000001,
"heapDeltaBytes": 10628320,
"heapUsedBytes": 87033012,
"domNodes": -261,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 33.05400000000001,
"eventListeners": -170,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2025.1800000000344,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.86,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 408.37600000000003,
"heapDeltaBytes": 11600036,
"heapUsedBytes": 87167188,
"domNodes": -263,
"jsHeapTotalBytes": -2461696,
"scriptDurationMs": 27.991999999999997,
"eventListeners": -170,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2221.4519999999993,
"styleRecalcs": 66,
"styleRecalcDurationMs": 12.312,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1131.904,
"heapDeltaBytes": 24124128,
"heapUsedBytes": 90016984,
"domNodes": -268,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 574.6089999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2230.3320000000326,
"styleRecalcs": 66,
"styleRecalcDurationMs": 11.727000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1071.359,
"heapDeltaBytes": 22030920,
"heapUsedBytes": 88603116,
"domNodes": 8,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 537.1239999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3258.2439999999906,
"styleRecalcs": 65,
"styleRecalcDurationMs": 14.109,
"layouts": 60,
"layoutDurationMs": 13.141,
"taskDurationMs": 1198.6080000000002,
"heapDeltaBytes": -3262048,
"heapUsedBytes": 75509560,
"domNodes": -272,
"jsHeapTotalBytes": -1937408,
"scriptDurationMs": 502.94900000000007,
"eventListeners": -168,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3258.7760000000117,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.324,
"layouts": 60,
"layoutDurationMs": 13.439,
"taskDurationMs": 1194.663,
"heapDeltaBytes": 8596356,
"heapUsedBytes": 76310648,
"domNodes": 8,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 520.519,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2508.217000000002,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.377999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1333.376,
"heapDeltaBytes": 18773596,
"heapUsedBytes": 86056272,
"domNodes": 6,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 637.2489999999999,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2530.0489999999627,
"styleRecalcs": 42,
"styleRecalcDurationMs": 7.383000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1417.3749999999998,
"heapDeltaBytes": 17221864,
"heapUsedBytes": 85501140,
"domNodes": 4,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 675.7810000000001,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "minimap-idle",
"durationMs": 1997.177000000022,
"styleRecalcs": 6,
"styleRecalcDurationMs": 3.563999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 334.331,
"heapDeltaBytes": 21826504,
"heapUsedBytes": 88031112,
"domNodes": -263,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 25.33400000000001,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2004.0989999999965,
"styleRecalcs": 6,
"styleRecalcDurationMs": 3.5600000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 332.09099999999995,
"heapDeltaBytes": 21907580,
"heapUsedBytes": 87627632,
"domNodes": -268,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 21.122000000000003,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 408.8750000000232,
"styleRecalcs": 48,
"styleRecalcDurationMs": 9.894,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 262.80099999999993,
"heapDeltaBytes": 14304196,
"heapUsedBytes": 86181684,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 89.09,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 481.3459999999168,
"styleRecalcs": 47,
"styleRecalcDurationMs": 10.583,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 305.42900000000003,
"heapDeltaBytes": 15158064,
"heapUsedBytes": 88252640,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 97.308,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663333333333338,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2008.258000000012,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.640999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 366.44,
"heapDeltaBytes": -5405992,
"heapUsedBytes": 65978928,
"domNodes": -294,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 8.597,
"eventListeners": -218,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2009.471000000019,
"styleRecalcs": 9,
"styleRecalcDurationMs": 6.310000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 332.17299999999994,
"heapDeltaBytes": -1849568,
"heapUsedBytes": 70100960,
"domNodes": -296,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.9019999999999975,
"eventListeners": -222,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.0890000000059,
"styleRecalcs": 78,
"styleRecalcDurationMs": 40.51,
"layouts": 18,
"layoutDurationMs": 6.575,
"taskDurationMs": 725.0909999999999,
"heapDeltaBytes": 8039096,
"heapUsedBytes": 74047508,
"domNodes": -296,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 105.57799999999999,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.2649999999735,
"styleRecalcs": 78,
"styleRecalcDurationMs": 28.644000000000002,
"layouts": 18,
"layoutDurationMs": 4.827000000000001,
"taskDurationMs": 572.97,
"heapDeltaBytes": -5424588,
"heapUsedBytes": 66643504,
"domNodes": -292,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 82.258,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 817.7279999999882,
"styleRecalcs": 21,
"styleRecalcDurationMs": 20.762999999999998,
"layouts": 17,
"layoutDurationMs": 10.45,
"taskDurationMs": 584.4,
"heapDeltaBytes": -7338808,
"heapUsedBytes": 86892212,
"domNodes": 13751,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 18.544999999999998,
"eventListeners": 2385,
"totalBlockingTimeMs": 57,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8488.073000000042,
"styleRecalcs": 248,
"styleRecalcDurationMs": 39.727,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3902.967,
"heapDeltaBytes": -11995928,
"heapUsedBytes": 89338304,
"domNodes": -266,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 1825.0720000000001,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8721.592000000044,
"styleRecalcs": 249,
"styleRecalcDurationMs": 41.721000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4134.598000000001,
"heapDeltaBytes": 16852256,
"heapUsedBytes": 93131064,
"domNodes": -266,
"jsHeapTotalBytes": -1449984,
"scriptDurationMs": 1884.8799999999999,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12673.527999999977,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11737.156,
"heapDeltaBytes": -34455016,
"heapUsedBytes": 182630796,
"domNodes": -6548,
"jsHeapTotalBytes": 9162752,
"scriptDurationMs": 196.47199999999998,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12233.841999999982,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11411.364000000001,
"heapDeltaBytes": -33782356,
"heapUsedBytes": 177558188,
"domNodes": -6548,
"jsHeapTotalBytes": -7278592,
"scriptDurationMs": 172.474,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14528.502000000004,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.664000000000009,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14018.028,
"heapDeltaBytes": -43234176,
"heapUsedBytes": 179957992,
"domNodes": -6548,
"jsHeapTotalBytes": -7319552,
"scriptDurationMs": 651.2130000000001,
"eventListeners": -7473,
"totalBlockingTimeMs": 33,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 14287.918999999987,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.335999999999986,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13814.405,
"heapDeltaBytes": -14702336,
"heapUsedBytes": 188539168,
"domNodes": -6548,
"jsHeapTotalBytes": -1683456,
"scriptDurationMs": 644.0600000000001,
"eventListeners": -7473,
"totalBlockingTimeMs": 36,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4296.7519999999695,
"styleRecalcs": 20,
"styleRecalcDurationMs": 50.483,
"layouts": 20,
"layoutDurationMs": 21.302000000000003,
"taskDurationMs": 4206.9039999999995,
"heapDeltaBytes": -20333296,
"heapUsedBytes": 190651496,
"domNodes": -6548,
"jsHeapTotalBytes": 15527936,
"scriptDurationMs": 69.341,
"eventListeners": -7471,
"totalBlockingTimeMs": 58,
"frameDurationMs": 17.220000000000013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 4184.657000000016,
"styleRecalcs": 20,
"styleRecalcDurationMs": 49.57500000000001,
"layouts": 20,
"layoutDurationMs": 19.373,
"taskDurationMs": 4094.4899999999993,
"heapDeltaBytes": -35998612,
"heapUsedBytes": 176157844,
"domNodes": -6548,
"jsHeapTotalBytes": 4018176,
"scriptDurationMs": 68.42799999999998,
"eventListeners": -7473,
"totalBlockingTimeMs": 4,
"frameDurationMs": 17.223333333333297,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5980.090000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5614.813999999999,
"heapDeltaBytes": 6582740,
"heapUsedBytes": 183248784,
"domNodes": 0,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 77.679,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5963.799999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5580.012,
"heapDeltaBytes": 3564124,
"heapUsedBytes": 174907412,
"domNodes": 0,
"jsHeapTotalBytes": -3932160,
"scriptDurationMs": 98.74499999999998,
"eventListeners": -9,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 429.2199999999866,
"styleRecalcs": 18,
"styleRecalcDurationMs": 16.656999999999996,
"layouts": 3,
"layoutDurationMs": 1.3829999999999998,
"taskDurationMs": 75.53699999999999,
"heapDeltaBytes": 4947776,
"heapUsedBytes": 73213528,
"domNodes": 149,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 5.840999999999999,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669999999999998,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 432.3060000000396,
"styleRecalcs": 16,
"styleRecalcDurationMs": 20.029,
"layouts": 3,
"layoutDurationMs": 1.369,
"taskDurationMs": 100.131,
"heapDeltaBytes": -12489992,
"heapUsedBytes": 66661784,
"domNodes": 121,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 7.862999999999999,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999727
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## core/1.54 #17750 +/- ##
=============================================
+ Coverage 82.97% 82.99% +0.02%
=============================================
Files 2053 2053
Lines 119720 120048 +328
Branches 30970 31095 +125
=============================================
+ Hits 99337 99634 +297
- Misses 20203 20234 +31
Partials 180 180
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Holding this backport for 1.55 from main: there is no log of testing beyond unit tests, and the release lines need that evidence. |
christian-byrne
left a comment
There was a problem hiding this comment.
Approving as part of a batch pass over the eight unreviewed backports. For this family (#17750–#17753) I compared the 1.53 and 1.54 payloads against each other rather than reading each separately, because the question that matters for a backport set is whether every release line gets the same change.
They are equivalent except in one place, and it is deliberate. The size difference (+2351/−48 on 1.54 versus +2383/−81 on 1.53) resolves to four files, and three of them are noise — an ADR index that is ordered differently on the older branch, and a test file needing slightly more adaptation. The real one is this, in both MixpanelTelemetryProvider.ts and PostHogTelemetryProvider.ts:
// 1.54
const TELEMETRY_EVENT_SET = new Set<TelemetryEventName>([
...Object.values(TelemetryEvents),
// 1.53
const TELEMETRY_EVENT_SET = new Set<string>([
...(Object.values(TelemetryEvents) as TelemetryEventName[]),Both branches add exactly 9 and 15 lines respectively, so the behaviour is the same — the set holds the same events and filters the same way at runtime. What differs is the type: 1.53 widens the set to string and casts the spread.
I assume that is forced by TelemetryEvents having a looser shape on the older branch, which makes it a reasonable adaptation rather than a defect. Two things worth noting anyway:
- On 1.53 the set no longer constrains what can be looked up in it. Anything typed
stringis accepted. That is a weaker guarantee than 1.54 gets from the same PR, and theascast is what makes the mismatch invisible rather than resolving it. - This is only findable by comparing the siblings. Read on its own, each PR looks like a faithful backport. Worth a line in the 1.53 bodies saying the type was widened and why, so nobody later reads the two release lines as byte-identical or copies the
stringversion forward.
Nothing here blocks: the runtime payload matches, the file sets are identical, and CI is green and mergeable on all four.
Manual backport of #17348 (
6a6a4a2). The automated cherry-pick failed with conflicts, so this was resolved by hand per the bot's instructions.Why
#17348 is labelled for this release. The auto-backport workflow could not apply it because this branch predates several
mainrefactors the commit sits on top of.Root cause of the conflict
Not a stacking conflict — the open backports the bot pointed at (#17720 / #17721 / #17600) are workflow and ECS test-coverage changes that touch none of the conflicting files. The conflicts are genuine divergence between
mainand this branch.How — conflicts and how each was resolved
billingOperationStore.ts—mainwrapshandleSuccess's body intry { cleanup(opId) … }; this branch does not. The checkout-journey clear is placed before the success telemetry here, keeping the same guarantee (it runs before any cleanup path can throw) against this branch's structure.TopUpCreditsDialogContentWorkspace.test.ts— this branch mocks the operation store with hoistedmockStartOperationand has nobillingOperationTestUtilshelper, whichmain's version of this file depends on. Takingmain's blocks wholesale compiled but broke all 31 tests, so only feat(billing): embedded checkout journey instrumentation #17348's journey additions were applied onto this branch's own structure, plus afirebase/authspy mock souseAuthStore()does not reach real Firebase.types.ts— the conflict region carriedFetchTimeoutMetadata, which belongs to amain-only feature and has no consumer here. Dropped;knipconfirms nothing else was over-pulled.The diff against this branch now adds exactly the symbols #17348 added, and nothing else.
AS IS / TO BE
Not applicable — this is a telemetry-only backport with no user-visible surface. #17348 changes no checkout UX or payment behavior; it adds
billing.checkout.*events alongside the existing terminalbilling.*taxonomy.Verification
pnpm typecheck,pnpm knip,pnpm lint(0 errors) clean