Skip to content

[backport cloud/1.54] feat(billing): embedded checkout journey instrumentation (#17348) - #17751

Merged
comfy-pr-bot merged 1 commit into
cloud/1.54from
backport-17348-to-cloud-1.54
Sep 17, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.54from
backport-17348-to-cloud-1.54

Conversation

@dante01yoon

Copy link
Copy Markdown
Collaborator

Manual backport of #17348 (6a6a4a2). The automated cherry-pick failed with conflicts, so this was resolved by hand per the bot's instructions.

Why

#17348 is labelled for this release. The auto-backport workflow could not apply it because this branch predates several main refactors the commit sits on top of.

Root cause of the conflict

Not a stacking conflict — the open backports the bot pointed at (#17720 / #17721 / #17600) are workflow and ECS test-coverage changes that touch none of the conflicting files. The conflicts are genuine divergence between main and this branch.

How — conflicts and how each was resolved

  • billingOperationStore.ts — main wraps handleSuccess's body in try { cleanup(opId) … }; this branch does not. The checkout-journey clear is placed before the success telemetry here, keeping the same guarantee (it runs before any cleanup path can throw) against this branch's structure.
  • TopUpCreditsDialogContentWorkspace.test.ts — this branch mocks the operation store with hoisted mockStartOperation and has no billingOperationTestUtils helper, which main's version of this file depends on. Taking main's blocks wholesale compiled but broke all 31 tests, so only feat(billing): embedded checkout journey instrumentation #17348's journey additions were applied onto this branch's own structure, plus a firebase/auth spy mock so useAuthStore() does not reach real Firebase.
  • types.ts — the conflict region carried FetchTimeoutMetadata, which belongs to a main-only feature and has no consumer here. Dropped; knip confirms nothing else was over-pulled.
  • Provider imports and the ADR index — merged with this branch's existing entries.

The diff against this branch now adds exactly the symbols #17348 added, and nothing else.

AS IS / TO BE

Not applicable — this is a telemetry-only backport with no user-visible surface. #17348 changes no checkout UX or payment behavior; it adds billing.checkout.* events alongside the existing terminal billing.* taxonomy.

Verification

  • 7 affected suites, 362 tests passing
  • pnpm typecheck, pnpm knip, pnpm lint (0 errors) clean

…mentation (#17348)

Manual backport of 6a6a4a2 — the automated cherry-pick hit conflicts.

Resolutions against this branch:
- billingOperationStore: this branch has no try/cleanup restructure, so the
  journey clear sits before the success telemetry instead.
- TopUpCreditsDialogContentWorkspace.test: this branch mocks the operation
  store with hoisted mocks and has no billingOperationTestUtils helper, so
  only the journey setup was added onto its own structure, plus a
  firebase/auth spy so useAuthStore() does not reach real Firebase.
- ADR index and provider imports merged with this branch's entries.
@dante01yoon dante01yoon added the backport Backporting a PR onto a release candidate label Sep 15, 2026
@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 7851e918-ee65-43c0-bde9-2f1a84bcc8f6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

🎭 Playwright: ✅ 1922 passed, 0 failed

📊 Browser Reports
  • chromium: View Report (✅ 1901 / ❌ 0 / ⚠️ 0 / ⏭️ 13)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/15/2026, 03:53:02 PM UTC

Links

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.8 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 65.5 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.9 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.3 MB heap
large-graph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.5 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.3 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 72.7 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 80.6 MB heap
minimap-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.8 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.2 MB heap
subgraph-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.7 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 75.0 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 135ms TBT · 82.9 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.1 MB heap
vue-large-graph-idle: · 57.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 167.4 MB heap
vue-large-graph-pan: · 58.1 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 25ms TBT · 163.7 MB heap
vue-node-resize-workload: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 206ms TBT · 165.4 MB heap
vue-zoom-out-idle: · 57.1 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 169.4 MB heap
workflow-execution: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 69.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 7ms
canvas-idle: layout count 0
canvas-idle: style recalc count 9
canvas-idle: task duration 501ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 65.8 MB
canvas-idle: DOM nodes -280
canvas-idle: event listeners -175
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 41ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 79
canvas-mouse-sweep: task duration 927ms
canvas-mouse-sweep: script duration 152ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 65.5 MB
canvas-mouse-sweep: DOM nodes -275
canvas-mouse-sweep: event listeners -159
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 16ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 364ms
canvas-zoom-sweep: script duration 13ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.9 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 19
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 7ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 11
dom-widget-clipping: task duration 419ms
dom-widget-clipping: script duration 146ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 72.3 MB
dom-widget-clipping: DOM nodes 18
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 586ms
large-graph-idle: script duration 35ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 83.5 MB
large-graph-idle: DOM nodes -267
large-graph-idle: event listeners -173
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 63
large-graph-pan: task duration 1571ms
large-graph-pan: script duration 765ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 85.3 MB
large-graph-pan: DOM nodes -137
large-graph-pan: event listeners 5
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 14ms
large-graph-zoom: style recalc duration 14ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 62
large-graph-zoom: task duration 1668ms
large-graph-zoom: script duration 709ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 72.7 MB
large-graph-zoom: DOM nodes -138
large-graph-zoom: event listeners -65
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 7ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 42
legacy-node-drag: task duration 1831ms
legacy-node-drag: script duration 878ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 80.6 MB
legacy-node-drag: DOM nodes 3
legacy-node-drag: event listeners 187
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 3ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 571ms
minimap-idle: script duration 34ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.8 MB
minimap-idle: DOM nodes -273
minimap-idle: event listeners -171
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 10ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 399ms
subgraph-dom-widget-clipping: script duration 134ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 83.2 MB
subgraph-dom-widget-clipping: DOM nodes 18
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 10
subgraph-idle: task duration 497ms
subgraph-idle: script duration 10ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 64.7 MB
subgraph-idle: DOM nodes -293
subgraph-idle: event listeners -204
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 35ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 77
subgraph-mouse-sweep: task duration 777ms
subgraph-mouse-sweep: script duration 102ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 75.0 MB
subgraph-mouse-sweep: DOM nodes -116
subgraph-mouse-sweep: event listeners -109
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 28ms
subgraph-transition-enter: layout count 15
subgraph-transition-enter: style recalc count 19
subgraph-transition-enter: task duration 870ms
subgraph-transition-enter: script duration 31ms
subgraph-transition-enter: TBT 135ms
subgraph-transition-enter: heap used 82.9 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2387
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 43ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 5476ms
viewport-pan-sweep: script duration 2437ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 85.1 MB
viewport-pan-sweep: DOM nodes -265
viewport-pan-sweep: event listeners -128
vue-large-graph-idle: avg frame time 17ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 14263ms
vue-large-graph-idle: script duration 238ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 167.4 MB
vue-large-graph-idle: DOM nodes -6548
vue-large-graph-idle: event listeners -7474
vue-large-graph-pan: avg frame time 17ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 20ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 140
vue-large-graph-pan: task duration 17424ms
vue-large-graph-pan: script duration 873ms
vue-large-graph-pan: TBT 25ms
vue-large-graph-pan: heap used 163.7 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7469
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 25ms
vue-node-resize-workload: style recalc duration 72ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5228ms
vue-node-resize-workload: script duration 117ms
vue-node-resize-workload: TBT 206ms
vue-node-resize-workload: heap used 165.4 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7473
vue-zoom-out-idle: avg frame time 18ms
vue-zoom-out-idle: p95 frame time 17ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 7198ms
vue-zoom-out-idle: script duration 135ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 169.4 MB
vue-zoom-out-idle: DOM nodes 0
vue-zoom-out-idle: event listeners -10
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 19ms
workflow-execution: layout count 3
workflow-execution: style recalc count 14
workflow-execution: task duration 98ms
workflow-execution: script duration 9ms
workflow-execution: TBT 0ms
workflow-execution: heap used 69.4 MB
workflow-execution: DOM nodes 139
workflow-execution: event listeners 42
Raw data
{
  "timestamp": "2026-09-15T16:01:56.293Z",
  "gitSha": "2713afc5f3e4a18f78312720f2c5f29bc565663f",
  "branch": "backport-17348-to-cloud-1.54",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2030.918999999983,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.240999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 516.5160000000001,
      "heapDeltaBytes": 3066104,
      "heapUsedBytes": 72833920,
      "domNodes": -280,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 11.026000000000002,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-idle",
      "durationMs": 2040.4910000000314,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.168000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 485.661,
      "heapDeltaBytes": -3980908,
      "heapUsedBytes": 65170764,
      "domNodes": -279,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 9.866999999999997,
      "eventListeners": -176,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2043.4889999999655,
      "styleRecalcs": 84,
      "styleRecalcDurationMs": 49.417,
      "layouts": 14,
      "layoutDurationMs": 5.372999999999999,
      "taskDurationMs": 1013.8860000000001,
      "heapDeltaBytes": -9812980,
      "heapUsedBytes": 60825180,
      "domNodes": -275,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 162.049,
      "eventListeners": -144,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1818.5270000000173,
      "styleRecalcs": 74,
      "styleRecalcDurationMs": 31.668000000000003,
      "layouts": 14,
      "layoutDurationMs": 4.413,
      "taskDurationMs": 840.773,
      "heapDeltaBytes": 6778620,
      "heapUsedBytes": 76540148,
      "domNodes": -275,
      "jsHeapTotalBytes": 6283264,
      "scriptDurationMs": 141.734,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1667.4429999999916,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 15.271999999999998,
      "layouts": 6,
      "layoutDurationMs": 1.126,
      "taskDurationMs": 352.445,
      "heapDeltaBytes": 4757724,
      "heapUsedBytes": 74835932,
      "domNodes": 77,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 12.229000000000001,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1725.1739999999245,
      "styleRecalcs": 31,
      "styleRecalcDurationMs": 16.555,
      "layouts": 6,
      "layoutDurationMs": 1.2329999999999999,
      "taskDurationMs": 376.07399999999996,
      "heapDeltaBytes": 5028504,
      "heapUsedBytes": 75850268,
      "domNodes": 75,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 13.426999999999998,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 626.3180000000261,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 6.050999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 422.482,
      "heapDeltaBytes": -7535768,
      "heapUsedBytes": 63127880,
      "domNodes": 16,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 148.405,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 609.9370000000022,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 7.66,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 414.69999999999993,
      "heapDeltaBytes": 18445084,
      "heapUsedBytes": 88594376,
      "domNodes": 20,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 143.21699999999998,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2038.925000000006,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 6.031999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 585.2149999999999,
      "heapDeltaBytes": 11546288,
      "heapUsedBytes": 87703072,
      "domNodes": -270,
      "jsHeapTotalBytes": -1675264,
      "scriptDurationMs": 32.849999999999994,
      "eventListeners": -172,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.660000000000007,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2048.6360000000445,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 5.3260000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 587.7770000000002,
      "heapDeltaBytes": 11312524,
      "heapUsedBytes": 87361300,
      "domNodes": -264,
      "jsHeapTotalBytes": -1675264,
      "scriptDurationMs": 36.507000000000005,
      "eventListeners": -174,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2421.1329999999975,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 9.984999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1612.8269999999998,
      "heapDeltaBytes": 22735856,
      "heapUsedBytes": 89190336,
      "domNodes": 0,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 785.68,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2175.094999999999,
      "styleRecalcs": 64,
      "styleRecalcDurationMs": 11.095999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1528.391,
      "heapDeltaBytes": 23228920,
      "heapUsedBytes": 89778356,
      "domNodes": -273,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 744.2149999999999,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3633.4150000000136,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 14.291000000000002,
      "layouts": 60,
      "layoutDurationMs": 14.500000000000002,
      "taskDurationMs": 1696.8429999999998,
      "heapDeltaBytes": 10383108,
      "heapUsedBytes": 76333180,
      "domNodes": -277,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 714.868,
      "eventListeners": -138,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3579.0130000000318,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 13.068,
      "layouts": 60,
      "layoutDurationMs": 14.474999999999998,
      "taskDurationMs": 1638.2990000000002,
      "heapDeltaBytes": 8501872,
      "heapUsedBytes": 76229472,
      "domNodes": 2,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 703.002,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3081.298000000004,
      "styleRecalcs": 43,
      "styleRecalcDurationMs": 8.220000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1882.164,
      "heapDeltaBytes": 94524,
      "heapUsedBytes": 83717324,
      "domNodes": 6,
      "jsHeapTotalBytes": 6221824,
      "scriptDurationMs": 894.8210000000001,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 2996.668999999997,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 5.999999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1779.557,
      "heapDeltaBytes": 17195688,
      "heapUsedBytes": 85401812,
      "domNodes": 0,
      "jsHeapTotalBytes": 417792,
      "scriptDurationMs": 861.32,
      "eventListeners": 186,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "minimap-idle",
      "durationMs": 2045.6810000000019,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.4769999999999976,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 571.5340000000001,
      "heapDeltaBytes": 10615544,
      "heapUsedBytes": 87792344,
      "domNodes": -274,
      "jsHeapTotalBytes": -2199552,
      "scriptDurationMs": 34.618,
      "eventListeners": -170,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2034.6979999999348,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 3.484000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 570.8500000000001,
      "heapDeltaBytes": 11058488,
      "heapUsedBytes": 87869616,
      "domNodes": -271,
      "jsHeapTotalBytes": -2199552,
      "scriptDurationMs": 32.596000000000004,
      "eventListeners": -172,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 579.6829999999886,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 9.405000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 388.411,
      "heapDeltaBytes": 14373760,
      "heapUsedBytes": 86606804,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 128.996,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 611.3000000000284,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 10.453999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 410.187,
      "heapDeltaBytes": 14824512,
      "heapUsedBytes": 87902880,
      "domNodes": 18,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 138.849,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2005.8779999999956,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 8.652999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 494.87,
      "heapDeltaBytes": -10022912,
      "heapUsedBytes": 62934328,
      "domNodes": -292,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 9.860000000000001,
      "eventListeners": -188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2034.4089999999824,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 7.699000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 499.768,
      "heapDeltaBytes": -278856,
      "heapUsedBytes": 72801900,
      "domNodes": -294,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 10.491,
      "eventListeners": -220,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1692.941000000019,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 34.092999999999996,
      "layouts": 18,
      "layoutDurationMs": 5.751,
      "taskDurationMs": 749.128,
      "heapDeltaBytes": 20202928,
      "heapUsedBytes": 85263384,
      "domNodes": 63,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 101.755,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1743.0410000000052,
      "styleRecalcs": 77,
      "styleRecalcDurationMs": 34.993,
      "layouts": 18,
      "layoutDurationMs": 5.846,
      "taskDurationMs": 805.686,
      "heapDeltaBytes": -180660,
      "heapUsedBytes": 72070936,
      "domNodes": -295,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 101.478,
      "eventListeners": -222,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1366.435000000024,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 28.039999999999996,
      "layouts": 15,
      "layoutDurationMs": 13.023999999999997,
      "taskDurationMs": 869.9929999999998,
      "heapDeltaBytes": -5510960,
      "heapUsedBytes": 86919836,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10747904,
      "scriptDurationMs": 30.78,
      "eventListeners": 2387,
      "totalBlockingTimeMs": 135,
      "frameDurationMs": 16.666666666666636,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8335.512999999992,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 42.17,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5482.619,
      "heapDeltaBytes": -13142288,
      "heapUsedBytes": 89348124,
      "domNodes": -264,
      "jsHeapTotalBytes": -1413120,
      "scriptDurationMs": 2452.006,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333338,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8304.124000000002,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 43.086,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5469.015,
      "heapDeltaBytes": -12884980,
      "heapUsedBytes": 89049936,
      "domNodes": -265,
      "jsHeapTotalBytes": -364544,
      "scriptDurationMs": 2422.61,
      "eventListeners": -128,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14654.56800000004,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14061.229000000001,
      "heapDeltaBytes": -33826580,
      "heapUsedBytes": 175556584,
      "domNodes": -6548,
      "jsHeapTotalBytes": -331776,
      "scriptDurationMs": 237.85300000000004,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333237,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 14947.663000000033,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 14463.855000000001,
      "heapDeltaBytes": -35382752,
      "heapUsedBytes": 175419760,
      "domNodes": -6548,
      "jsHeapTotalBytes": 2609152,
      "scriptDurationMs": 238.227,
      "eventListeners": -7473,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.77333333333336,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 17446.057999999994,
      "styleRecalcs": 138,
      "styleRecalcDurationMs": 19.569000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17090.377,
      "heapDeltaBytes": -27399748,
      "heapUsedBytes": 176712020,
      "domNodes": -6548,
      "jsHeapTotalBytes": 454656,
      "scriptDurationMs": 844.191,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 27,
      "frameDurationMs": 17.223333333333237,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 18102.875999999924,
      "styleRecalcs": 141,
      "styleRecalcDurationMs": 20.47199999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17758.189000000002,
      "heapDeltaBytes": -50587352,
      "heapUsedBytes": 166647592,
      "domNodes": -6548,
      "jsHeapTotalBytes": 344064,
      "scriptDurationMs": 901.9659999999999,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 23,
      "frameDurationMs": 17.219999999999953,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5294.555000000002,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 76.45500000000006,
      "layouts": 20,
      "layoutDurationMs": 25.866,
      "taskDurationMs": 5173.559,
      "heapDeltaBytes": -53075432,
      "heapUsedBytes": 159063176,
      "domNodes": -6548,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 126.67600000000002,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 206,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 5380.785999999944,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 67.33499999999998,
      "layouts": 20,
      "layoutDurationMs": 24.128999999999998,
      "taskDurationMs": 5283.3550000000005,
      "heapDeltaBytes": -22951660,
      "heapUsedBytes": 187744736,
      "domNodes": -6548,
      "jsHeapTotalBytes": 10858496,
      "scriptDurationMs": 106.97399999999999,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 206,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7378.265999999996,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7155.1720000000005,
      "heapDeltaBytes": 13193016,
      "heapUsedBytes": 177690808,
      "domNodes": 0,
      "jsHeapTotalBytes": -6815744,
      "scriptDurationMs": 145.859,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.223333333333358,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 7441.332999999986,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7241.774000000001,
      "heapDeltaBytes": 20771932,
      "heapUsedBytes": 177478264,
      "domNodes": 0,
      "jsHeapTotalBytes": 1572864,
      "scriptDurationMs": 124.139,
      "eventListeners": -10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 472.56800000002386,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 19.609,
      "layouts": 4,
      "layoutDurationMs": 1.907,
      "taskDurationMs": 115.973,
      "heapDeltaBytes": 5131736,
      "heapUsedBytes": 74275172,
      "domNodes": 149,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 12.546000000000001,
      "eventListeners": 67,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 144.95399999998426,
      "styleRecalcs": 9,
      "styleRecalcDurationMs": 17.792,
      "layouts": 2,
      "layoutDurationMs": 1.1119999999999999,
      "taskDurationMs": 79.77099999999999,
      "heapDeltaBytes": 3019964,
      "heapUsedBytes": 71345032,
      "domNodes": 128,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 4.929999999999999,
      "eventListeners": 17,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666682,
      "p95FrameDurationMs": 16.800000000000182
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 49921 74602 66.9% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.4% 1159
src/LGraphNode.ts 69.5% 390
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/platform/workspace/stores/billingOperationStore.ts 8.1% 305
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 78.6% 261
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.8% 251
src/scripts/pnginfo.ts 21.4% 221

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 15, 2026
@codecov

codecov Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.36782% with 37 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/platform/workspace/utils/checkoutJourney.ts 88.23% 22 Missing ⚠️
...kspace/components/UnifiedStripePaymentSelector.vue 89.83% 6 Missing ⚠️
src/platform/telemetry/types.ts 85.00% 3 Missing ⚠️
...try/providers/cloud/DatadogRumTelemetryProvider.ts 0.00% 2 Missing ⚠️
...emetry/providers/cloud/PostHogTelemetryProvider.ts 33.33% 2 Missing ⚠️
.../components/TopUpCreditsDialogContentWorkspace.vue 95.65% 1 Missing ⚠️
...m/workspace/composables/useSubscriptionCheckout.ts 97.95% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.54   #17751   +/-   ##
=============================================
  Coverage              ?   83.01%           
=============================================
  Files                 ?     2053           
  Lines                 ?   120049           
  Branches              ?    32916           
=============================================
  Hits                  ?    99653           
  Misses                ?    20216           
  Partials              ?      180           
Flag Coverage Δ
e2e 66.94% <7.69%> (?)
unit 77.60% <93.35%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/telemetry/TelemetryRegistry.ts 36.30% <100.00%> (ø)
...metry/providers/cloud/MixpanelTelemetryProvider.ts 82.05% <100.00%> (ø)
...platform/workspace/stores/billingOperationStore.ts 92.95% <100.00%> (ø)
.../components/TopUpCreditsDialogContentWorkspace.vue 86.71% <95.65%> (ø)
...m/workspace/composables/useSubscriptionCheckout.ts 92.81% <97.95%> (ø)
...try/providers/cloud/DatadogRumTelemetryProvider.ts 86.95% <0.00%> (ø)
...emetry/providers/cloud/PostHogTelemetryProvider.ts 67.32% <33.33%> (ø)
src/platform/telemetry/types.ts 92.59% <85.00%> (ø)
...kspace/components/UnifiedStripePaymentSelector.vue 90.22% <89.83%> (ø)
src/platform/workspace/utils/checkoutJourney.ts 88.23% <88.23%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CodeJuggernaut

Copy link
Copy Markdown
Contributor

Holding this backport for 1.55 from main: there is no log of testing beyond unit tests, and the release lines need that evidence.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as part of a batch pass over the eight unreviewed backports. For this family (#17750–#17753) I compared the 1.53 and 1.54 payloads against each other rather than reading each separately, because the question that matters for a backport set is whether every release line gets the same change.

They are equivalent except in one place, and it is deliberate. The size difference (+2351/−48 on 1.54 versus +2383/−81 on 1.53) resolves to four files, and three of them are noise — an ADR index that is ordered differently on the older branch, and a test file needing slightly more adaptation. The real one is this, in both MixpanelTelemetryProvider.ts and PostHogTelemetryProvider.ts:

// 1.54
const TELEMETRY_EVENT_SET = new Set<TelemetryEventName>([
  ...Object.values(TelemetryEvents),

// 1.53
const TELEMETRY_EVENT_SET = new Set<string>([
  ...(Object.values(TelemetryEvents) as TelemetryEventName[]),

Both branches add exactly 9 and 15 lines respectively, so the behaviour is the same — the set holds the same events and filters the same way at runtime. What differs is the type: 1.53 widens the set to string and casts the spread.

I assume that is forced by TelemetryEvents having a looser shape on the older branch, which makes it a reasonable adaptation rather than a defect. Two things worth noting anyway:

  • On 1.53 the set no longer constrains what can be looked up in it. Anything typed string is accepted. That is a weaker guarantee than 1.54 gets from the same PR, and the as cast is what makes the mismatch invisible rather than resolving it.
  • This is only findable by comparing the siblings. Read on its own, each PR looks like a faithful backport. Worth a line in the 1.53 bodies saying the type was widened and why, so nobody later reads the two release lines as byte-identical or copies the string version forward.

Nothing here blocks: the runtime payload matches, the file sets are identical, and CI is green and mergeable on all four.

@comfy-pr-bot
comfy-pr-bot merged commit 0b599fa into cloud/1.54 Sep 17, 2026
104 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-17348-to-cloud-1.54 branch September 17, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants