Repository navigation
[backport cloud/1.54] feat(billing): embedded checkout journey instrumentation (#17348) - #17751
Conversation
…mentation (#17348) Manual backport of 6a6a4a2 — the automated cherry-pick hit conflicts. Resolutions against this branch: - billingOperationStore: this branch has no try/cleanup restructure, so the journey clear sits before the success telemetry instead. - TopUpCreditsDialogContentWorkspace.test: this branch mocks the operation store with hoisted mocks and has no billingOperationTestUtils helper, so only the journey setup was added onto its own structure, plus a firebase/auth spy so useAuthStore() does not reach real Firebase. - ADR index and provider imports merged with this branch's entries.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 1922 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-15T16:01:56.293Z",
"gitSha": "2713afc5f3e4a18f78312720f2c5f29bc565663f",
"branch": "backport-17348-to-cloud-1.54",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2030.918999999983,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.240999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 516.5160000000001,
"heapDeltaBytes": 3066104,
"heapUsedBytes": 72833920,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 11.026000000000002,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2040.4910000000314,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.168000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 485.661,
"heapDeltaBytes": -3980908,
"heapUsedBytes": 65170764,
"domNodes": -279,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.866999999999997,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2043.4889999999655,
"styleRecalcs": 84,
"styleRecalcDurationMs": 49.417,
"layouts": 14,
"layoutDurationMs": 5.372999999999999,
"taskDurationMs": 1013.8860000000001,
"heapDeltaBytes": -9812980,
"heapUsedBytes": 60825180,
"domNodes": -275,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 162.049,
"eventListeners": -144,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1818.5270000000173,
"styleRecalcs": 74,
"styleRecalcDurationMs": 31.668000000000003,
"layouts": 14,
"layoutDurationMs": 4.413,
"taskDurationMs": 840.773,
"heapDeltaBytes": 6778620,
"heapUsedBytes": 76540148,
"domNodes": -275,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 141.734,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1667.4429999999916,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.271999999999998,
"layouts": 6,
"layoutDurationMs": 1.126,
"taskDurationMs": 352.445,
"heapDeltaBytes": 4757724,
"heapUsedBytes": 74835932,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 12.229000000000001,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.1739999999245,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.555,
"layouts": 6,
"layoutDurationMs": 1.2329999999999999,
"taskDurationMs": 376.07399999999996,
"heapDeltaBytes": 5028504,
"heapUsedBytes": 75850268,
"domNodes": 75,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 13.426999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 626.3180000000261,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.050999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.482,
"heapDeltaBytes": -7535768,
"heapUsedBytes": 63127880,
"domNodes": 16,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 148.405,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 609.9370000000022,
"styleRecalcs": 12,
"styleRecalcDurationMs": 7.66,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.69999999999993,
"heapDeltaBytes": 18445084,
"heapUsedBytes": 88594376,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 143.21699999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2038.925000000006,
"styleRecalcs": 4,
"styleRecalcDurationMs": 6.031999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 585.2149999999999,
"heapDeltaBytes": 11546288,
"heapUsedBytes": 87703072,
"domNodes": -270,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 32.849999999999994,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000007,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2048.6360000000445,
"styleRecalcs": 7,
"styleRecalcDurationMs": 5.3260000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 587.7770000000002,
"heapDeltaBytes": 11312524,
"heapUsedBytes": 87361300,
"domNodes": -264,
"jsHeapTotalBytes": -1675264,
"scriptDurationMs": 36.507000000000005,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2421.1329999999975,
"styleRecalcs": 62,
"styleRecalcDurationMs": 9.984999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1612.8269999999998,
"heapDeltaBytes": 22735856,
"heapUsedBytes": 89190336,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 785.68,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2175.094999999999,
"styleRecalcs": 64,
"styleRecalcDurationMs": 11.095999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1528.391,
"heapDeltaBytes": 23228920,
"heapUsedBytes": 89778356,
"domNodes": -273,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 744.2149999999999,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3633.4150000000136,
"styleRecalcs": 62,
"styleRecalcDurationMs": 14.291000000000002,
"layouts": 60,
"layoutDurationMs": 14.500000000000002,
"taskDurationMs": 1696.8429999999998,
"heapDeltaBytes": 10383108,
"heapUsedBytes": 76333180,
"domNodes": -277,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 714.868,
"eventListeners": -138,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3579.0130000000318,
"styleRecalcs": 61,
"styleRecalcDurationMs": 13.068,
"layouts": 60,
"layoutDurationMs": 14.474999999999998,
"taskDurationMs": 1638.2990000000002,
"heapDeltaBytes": 8501872,
"heapUsedBytes": 76229472,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 703.002,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3081.298000000004,
"styleRecalcs": 43,
"styleRecalcDurationMs": 8.220000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1882.164,
"heapDeltaBytes": 94524,
"heapUsedBytes": 83717324,
"domNodes": 6,
"jsHeapTotalBytes": 6221824,
"scriptDurationMs": 894.8210000000001,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "legacy-node-drag",
"durationMs": 2996.668999999997,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.999999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1779.557,
"heapDeltaBytes": 17195688,
"heapUsedBytes": 85401812,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 861.32,
"eventListeners": 186,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2045.6810000000019,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.4769999999999976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 571.5340000000001,
"heapDeltaBytes": 10615544,
"heapUsedBytes": 87792344,
"domNodes": -274,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 34.618,
"eventListeners": -170,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2034.6979999999348,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.484000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 570.8500000000001,
"heapDeltaBytes": 11058488,
"heapUsedBytes": 87869616,
"domNodes": -271,
"jsHeapTotalBytes": -2199552,
"scriptDurationMs": 32.596000000000004,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 579.6829999999886,
"styleRecalcs": 46,
"styleRecalcDurationMs": 9.405000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.411,
"heapDeltaBytes": 14373760,
"heapUsedBytes": 86606804,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 128.996,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 611.3000000000284,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.453999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 410.187,
"heapDeltaBytes": 14824512,
"heapUsedBytes": 87902880,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 138.849,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2005.8779999999956,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.652999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.87,
"heapDeltaBytes": -10022912,
"heapUsedBytes": 62934328,
"domNodes": -292,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 9.860000000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2034.4089999999824,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.699000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.768,
"heapDeltaBytes": -278856,
"heapUsedBytes": 72801900,
"domNodes": -294,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.491,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.941000000019,
"styleRecalcs": 76,
"styleRecalcDurationMs": 34.092999999999996,
"layouts": 18,
"layoutDurationMs": 5.751,
"taskDurationMs": 749.128,
"heapDeltaBytes": 20202928,
"heapUsedBytes": 85263384,
"domNodes": 63,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 101.755,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1743.0410000000052,
"styleRecalcs": 77,
"styleRecalcDurationMs": 34.993,
"layouts": 18,
"layoutDurationMs": 5.846,
"taskDurationMs": 805.686,
"heapDeltaBytes": -180660,
"heapUsedBytes": 72070936,
"domNodes": -295,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 101.478,
"eventListeners": -222,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1366.435000000024,
"styleRecalcs": 19,
"styleRecalcDurationMs": 28.039999999999996,
"layouts": 15,
"layoutDurationMs": 13.023999999999997,
"taskDurationMs": 869.9929999999998,
"heapDeltaBytes": -5510960,
"heapUsedBytes": 86919836,
"domNodes": 13751,
"jsHeapTotalBytes": 10747904,
"scriptDurationMs": 30.78,
"eventListeners": 2387,
"totalBlockingTimeMs": 135,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8335.512999999992,
"styleRecalcs": 248,
"styleRecalcDurationMs": 42.17,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5482.619,
"heapDeltaBytes": -13142288,
"heapUsedBytes": 89348124,
"domNodes": -264,
"jsHeapTotalBytes": -1413120,
"scriptDurationMs": 2452.006,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8304.124000000002,
"styleRecalcs": 248,
"styleRecalcDurationMs": 43.086,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5469.015,
"heapDeltaBytes": -12884980,
"heapUsedBytes": 89049936,
"domNodes": -265,
"jsHeapTotalBytes": -364544,
"scriptDurationMs": 2422.61,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14654.56800000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14061.229000000001,
"heapDeltaBytes": -33826580,
"heapUsedBytes": 175556584,
"domNodes": -6548,
"jsHeapTotalBytes": -331776,
"scriptDurationMs": 237.85300000000004,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 14947.663000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14463.855000000001,
"heapDeltaBytes": -35382752,
"heapUsedBytes": 175419760,
"domNodes": -6548,
"jsHeapTotalBytes": 2609152,
"scriptDurationMs": 238.227,
"eventListeners": -7473,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 17446.057999999994,
"styleRecalcs": 138,
"styleRecalcDurationMs": 19.569000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17090.377,
"heapDeltaBytes": -27399748,
"heapUsedBytes": 176712020,
"domNodes": -6548,
"jsHeapTotalBytes": 454656,
"scriptDurationMs": 844.191,
"eventListeners": -7469,
"totalBlockingTimeMs": 27,
"frameDurationMs": 17.223333333333237,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 18102.875999999924,
"styleRecalcs": 141,
"styleRecalcDurationMs": 20.47199999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17758.189000000002,
"heapDeltaBytes": -50587352,
"heapUsedBytes": 166647592,
"domNodes": -6548,
"jsHeapTotalBytes": 344064,
"scriptDurationMs": 901.9659999999999,
"eventListeners": -7469,
"totalBlockingTimeMs": 23,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 5294.555000000002,
"styleRecalcs": 20,
"styleRecalcDurationMs": 76.45500000000006,
"layouts": 20,
"layoutDurationMs": 25.866,
"taskDurationMs": 5173.559,
"heapDeltaBytes": -53075432,
"heapUsedBytes": 159063176,
"domNodes": -6548,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 126.67600000000002,
"eventListeners": -7475,
"totalBlockingTimeMs": 206,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-node-resize-workload",
"durationMs": 5380.785999999944,
"styleRecalcs": 20,
"styleRecalcDurationMs": 67.33499999999998,
"layouts": 20,
"layoutDurationMs": 24.128999999999998,
"taskDurationMs": 5283.3550000000005,
"heapDeltaBytes": -22951660,
"heapUsedBytes": 187744736,
"domNodes": -6548,
"jsHeapTotalBytes": 10858496,
"scriptDurationMs": 106.97399999999999,
"eventListeners": -7471,
"totalBlockingTimeMs": 206,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7378.265999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7155.1720000000005,
"heapDeltaBytes": 13193016,
"heapUsedBytes": 177690808,
"domNodes": 0,
"jsHeapTotalBytes": -6815744,
"scriptDurationMs": 145.859,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333358,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7441.332999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7241.774000000001,
"heapDeltaBytes": 20771932,
"heapUsedBytes": 177478264,
"domNodes": 0,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 124.139,
"eventListeners": -10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 472.56800000002386,
"styleRecalcs": 19,
"styleRecalcDurationMs": 19.609,
"layouts": 4,
"layoutDurationMs": 1.907,
"taskDurationMs": 115.973,
"heapDeltaBytes": 5131736,
"heapUsedBytes": 74275172,
"domNodes": 149,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.546000000000001,
"eventListeners": 67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 144.95399999998426,
"styleRecalcs": 9,
"styleRecalcDurationMs": 17.792,
"layouts": 2,
"layoutDurationMs": 1.1119999999999999,
"taskDurationMs": 79.77099999999999,
"heapDeltaBytes": 3019964,
"heapUsedBytes": 71345032,
"domNodes": 128,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 4.929999999999999,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
Holding this backport for 1.55 from main: there is no log of testing beyond unit tests, and the release lines need that evidence. |
christian-byrne
left a comment
There was a problem hiding this comment.
Approving as part of a batch pass over the eight unreviewed backports. For this family (#17750–#17753) I compared the 1.53 and 1.54 payloads against each other rather than reading each separately, because the question that matters for a backport set is whether every release line gets the same change.
They are equivalent except in one place, and it is deliberate. The size difference (+2351/−48 on 1.54 versus +2383/−81 on 1.53) resolves to four files, and three of them are noise — an ADR index that is ordered differently on the older branch, and a test file needing slightly more adaptation. The real one is this, in both MixpanelTelemetryProvider.ts and PostHogTelemetryProvider.ts:
// 1.54
const TELEMETRY_EVENT_SET = new Set<TelemetryEventName>([
...Object.values(TelemetryEvents),
// 1.53
const TELEMETRY_EVENT_SET = new Set<string>([
...(Object.values(TelemetryEvents) as TelemetryEventName[]),Both branches add exactly 9 and 15 lines respectively, so the behaviour is the same — the set holds the same events and filters the same way at runtime. What differs is the type: 1.53 widens the set to string and casts the spread.
I assume that is forced by TelemetryEvents having a looser shape on the older branch, which makes it a reasonable adaptation rather than a defect. Two things worth noting anyway:
- On 1.53 the set no longer constrains what can be looked up in it. Anything typed
stringis accepted. That is a weaker guarantee than 1.54 gets from the same PR, and theascast is what makes the mismatch invisible rather than resolving it. - This is only findable by comparing the siblings. Read on its own, each PR looks like a faithful backport. Worth a line in the 1.53 bodies saying the type was widened and why, so nobody later reads the two release lines as byte-identical or copies the
stringversion forward.
Nothing here blocks: the runtime payload matches, the file sets are identical, and CI is green and mergeable on all four.
Manual backport of #17348 (
6a6a4a2). The automated cherry-pick failed with conflicts, so this was resolved by hand per the bot's instructions.Why
#17348 is labelled for this release. The auto-backport workflow could not apply it because this branch predates several
mainrefactors the commit sits on top of.Root cause of the conflict
Not a stacking conflict — the open backports the bot pointed at (#17720 / #17721 / #17600) are workflow and ECS test-coverage changes that touch none of the conflicting files. The conflicts are genuine divergence between
mainand this branch.How — conflicts and how each was resolved
billingOperationStore.ts—mainwrapshandleSuccess's body intry { cleanup(opId) … }; this branch does not. The checkout-journey clear is placed before the success telemetry here, keeping the same guarantee (it runs before any cleanup path can throw) against this branch's structure.TopUpCreditsDialogContentWorkspace.test.ts— this branch mocks the operation store with hoistedmockStartOperationand has nobillingOperationTestUtilshelper, whichmain's version of this file depends on. Takingmain's blocks wholesale compiled but broke all 31 tests, so only feat(billing): embedded checkout journey instrumentation #17348's journey additions were applied onto this branch's own structure, plus afirebase/authspy mock souseAuthStore()does not reach real Firebase.types.ts— the conflict region carriedFetchTimeoutMetadata, which belongs to amain-only feature and has no consumer here. Dropped;knipconfirms nothing else was over-pulled.The diff against this branch now adds exactly the symbols #17348 added, and nothing else.
AS IS / TO BE
Not applicable — this is a telemetry-only backport with no user-visible surface. #17348 changes no checkout UX or payment behavior; it adds
billing.checkout.*events alongside the existing terminalbilling.*taxonomy.Verification
pnpm typecheck,pnpm knip,pnpm lint(0 errors) clean