Repository navigation
[backport cloud/1.53] test: add ECS feature sanity coverage - #18972
comfy-pr-bot wants to merge 1 commit into
Conversation
Adds e2e coverage for four ECS migration behaviours, in both the Vue and legacy renderers: - **Node source badge Settings transitions** (`nodeSourceBadgeMode.spec.ts`). Drives the real Settings control through Show all, Hide built-in, None, Show all again, with no reload. Core `PreviewImage` and custom `DevToolsErrorRaiseNode` are expected to differ under Hide built-in. Vue asserts on visible badges; legacy observes actual `drawBadges`/`fillText` calls and waits for a completed frame. - **API pricing badge toggle** (`apiPricingBadge.spec.ts`). - **Link disconnect/reconnect at emulated DPR 1.5** (`links/deviceScaleFactor.spec.ts`). Exact endpoints and output-link count. - **Marquee selection at emulated DPR 1.5** (`selection/deviceScaleFactor.spec.ts`). Exact two-node selection. Both scaling tests use Playwright's emulated `deviceScaleFactor`, not physical display scaling or browser zoom. Physical display validation stays manual. Supporting fixtures: `LegacyNodeBadgeHelper` (legacy badge probe), `SettingDialog.selectSetting`. [QA plan](https://app.notion.com/p/comfy-org/3c56d73d365081629481ea0f1d09fc65) · [Migration](#14246) <details><summary>Rebase note, 2026-09-25</summary> The branch had drifted 634 commits behind `main` and was red on `typecheck-aux`, `repo-checks`, `fallow` and `lint`. Rebased clean (no conflicts, diff unchanged at 551 lines across 7 files) and fixed the fallout in `e8ae9041a0`: - `Settings` moved out of `@/schemas/apiSchema`. The unresolved import was the single cause of the typecheck, knip and fallow failures. - `SettingDialog` already imports `comfyExpect as expect`; the added `@playwright/test` `expect` was a duplicate identifier. - `vueNodes.waitForNodes()` no longer takes a count. - `comfy(prefer-initial-settings)` landed after this branch was cut. Startup settings moved to `test.use({ initialSettings })`, and the settings-only `afterEach` teardown was removed: `comfyPageFixture` reseeds settings before each test, so the restores were dead code. That supersedes three earlier commits on this branch that added those restores in response to review. Dropping them also removes describe-scope mutable state shared across the renderer loop. Earlier body text referenced pre-rebase commit SHAs and out-of-scope claims (body zoom, API serialization, locale layout, download/re-import, Browse Templates undo, missing-model dialogs). None of that is in this PR; removed so it does not read as a spec. </details> --------- Co-authored-by: Amp <amp@ampcode.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
🎭 Playwright: 🕵🏻 0 passed, 0 failed📊 Browser Reports
📦 Bundle Size
🔬 E2E Coverage
|
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 24 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 912768c | Docs | View more details | Give us feedback! |
|
Closing: this cannot pass on Zero
The rule for this shape is to backport the missing module rather than rewrite the import. I checked, and here that is disproportionate: the fixture arrives in 1.53 is still taking backports, but the recent ones carry Same disposition as #17600 for the same reason. The coverage is already on |
Pull request was closed
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.53 #18972 +/- ##
=============================================
Coverage ? 76.82%
=============================================
Files ? 1933
Lines ? 104806
Branches ? 29473
=============================================
Hits ? 80519
Misses ? 24112
Partials ? 175
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Backport of #17459 to
cloud/1.53Automatically created by backport workflow.