Skip to content

[backport cloud/1.53] feat(billing): embedded checkout journey instrumentation (#17348) - #17753

Merged
comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-17348-to-cloud-1.53
Sep 17, 2026
Merged

comfy-pr-bot merged 1 commit into
cloud/1.53from
backport-17348-to-cloud-1.53

Conversation

@dante01yoon

Copy link
Copy Markdown
Collaborator

Manual backport of #17348 (6a6a4a2). The automated cherry-pick failed with conflicts, so this was resolved by hand per the bot's instructions.

Why

#17348 is labelled for this release. The auto-backport workflow could not apply it because this branch predates several main refactors the commit sits on top of.

Root cause of the conflict

Not a stacking conflict — the open backports the bot pointed at (#17720 / #17721 / #17600) are workflow and ECS test-coverage changes that touch none of the conflicting files. The conflicts are genuine divergence between main and this branch.

How — conflicts and how each was resolved

  • billingOperationStore.ts — main wraps handleSuccess's body in try { cleanup(opId) … }; this branch does not. The checkout-journey clear is placed before the success telemetry here, keeping the same guarantee (it runs before any cleanup path can throw) against this branch's structure.
  • TopUpCreditsDialogContentWorkspace.vue — this branch keeps isAddingCredits, unlike core/1.53 which uses isPolling.
  • Provider event sets — this branch types TELEMETRY_EVENT_SET as Set<TelemetryEventName> rather than Set<string>, so the checkout-journey names are spread into that typed set.
  • TopUpCreditsDialogContentWorkspace.test.ts / TelemetryRegistry.test.ts — this branch mocks the operation store with hoisted mocks and has no billingOperationTestUtils helper, which main's version depends on. Taking main's blocks wholesale compiled but broke every test, so only feat(billing): embedded checkout journey instrumentation #17348's journey additions were applied onto this branch's own structure, plus a firebase/auth spy so useAuthStore() does not reach real Firebase.
  • types.ts / TelemetryRegistry.ts — the conflict regions carried FetchTimeoutMetadata and BootstrapCompleteMetadata, both from main-only features with no consumer here. Dropped; knip confirms nothing else was over-pulled.
  • ADR index — this branch still uses the numeric ADR naming scheme, so the row was appended rather than slotted into a domain-led ordering.

The diff against this branch now adds exactly the symbols #17348 added, and nothing else.

AS IS / TO BE

Not applicable — this is a telemetry-only backport with no user-visible surface. #17348 changes no checkout UX or payment behavior; it adds billing.checkout.* events alongside the existing terminal billing.* taxonomy.

Verification

  • 7 affected suites, 352 tests passing
  • pnpm typecheck, pnpm knip, pnpm lint (0 errors) clean

…mentation (#17348)

Manual backport of 6a6a4a2 — the automated cherry-pick hit conflicts.

Resolutions against this branch:
- billingOperationStore: no try/cleanup restructure here, so the journey
  clear sits before the success telemetry instead.
- TopUpCreditsDialogContentWorkspace.vue: this branch keeps the isAddingCredits
  name, unlike core/1.53 which uses isPolling.
- Provider event sets: this branch types the Set as TelemetryEventName, so the
  checkout names are spread into that typed set rather than a Set<string>.
- TopUpCreditsDialogContentWorkspace.test / TelemetryRegistry.test: only the
  journey additions were applied onto this branch's own mocks, plus a
  firebase/auth spy so useAuthStore() does not reach real Firebase.
- Dropped FetchTimeoutMetadata and BootstrapCompleteMetadata, which the
  conflict regions carried in from main-only features.
@dante01yoon dante01yoon added the backport Backporting a PR onto a release candidate label Sep 15, 2026
@coderabbitai

coderabbitai Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (2)
  • [release]
  • [backport

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: de311867-b59f-4d44-93e7-9bfaf234cf66

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/15/2026, 04:00:26 PM UTC

Links

🎭 Playwright: ✅ 1888 passed, 0 failed · 3 flaky

📊 Browser Reports
  • chromium: View Report (✅ 1867 / ❌ 0 / ⚠️ 3 / ⏭️ 4)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.1 MB heap
canvas-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 58.3 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.4 MB heap
dom-widget-clipping: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.9 MB heap
large-graph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.5 MB heap
large-graph-pan: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 88.5 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 71.8 MB heap
legacy-node-drag: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 64.8 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 83.4 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 82.7 MB heap
subgraph-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 63.3 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.6 MB heap
subgraph-transition-enter: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 143ms TBT · 103.9 MB heap
viewport-pan-sweep: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 76.5 MB heap
vue-large-graph-idle: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 164.5 MB heap
vue-large-graph-pan: · 56.3 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 111ms TBT · 166.1 MB heap
vue-node-resize-workload: · 55.4 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 479ms TBT · 181.4 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 70.4 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 10ms
canvas-idle: layout count 0
canvas-idle: style recalc count 8
canvas-idle: task duration 581ms
canvas-idle: script duration 12ms
canvas-idle: TBT 0ms
canvas-idle: heap used 63.1 MB
canvas-idle: DOM nodes -283
canvas-idle: event listeners -170
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 7ms
canvas-mouse-sweep: style recalc duration 61ms
canvas-mouse-sweep: layout count 14
canvas-mouse-sweep: style recalc count 83
canvas-mouse-sweep: task duration 1188ms
canvas-mouse-sweep: script duration 189ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 58.3 MB
canvas-mouse-sweep: DOM nodes -281
canvas-mouse-sweep: event listeners -156
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 2ms
canvas-zoom-sweep: style recalc duration 22ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 31
canvas-zoom-sweep: task duration 461ms
canvas-zoom-sweep: script duration 17ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 71.4 MB
canvas-zoom-sweep: DOM nodes 76
canvas-zoom-sweep: event listeners 20
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 9ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 10
dom-widget-clipping: task duration 536ms
dom-widget-clipping: script duration 176ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 71.9 MB
dom-widget-clipping: DOM nodes 16
dom-widget-clipping: event listeners 2
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 6ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 5
large-graph-idle: task duration 741ms
large-graph-idle: script duration 44ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 82.5 MB
large-graph-idle: DOM nodes -272
large-graph-idle: event listeners -168
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 11ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 62
large-graph-pan: task duration 1939ms
large-graph-pan: script duration 924ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 88.5 MB
large-graph-pan: DOM nodes -279
large-graph-pan: event listeners 8
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 16ms
large-graph-zoom: style recalc duration 14ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 60
large-graph-zoom: task duration 2000ms
large-graph-zoom: script duration 856ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 71.8 MB
large-graph-zoom: DOM nodes -141
large-graph-zoom: event listeners 10
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 7ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 40
legacy-node-drag: task duration 2291ms
legacy-node-drag: script duration 1097ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 64.8 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 189
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 0ms
minimap-idle: layout count 0
minimap-idle: style recalc count 0
minimap-idle: task duration 643ms
minimap-idle: script duration 41ms
minimap-idle: TBT 0ms
minimap-idle: heap used 83.4 MB
minimap-idle: DOM nodes -280
minimap-idle: event listeners 4
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 12ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 45
subgraph-dom-widget-clipping: task duration 498ms
subgraph-dom-widget-clipping: script duration 162ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 82.7 MB
subgraph-dom-widget-clipping: DOM nodes 16
subgraph-dom-widget-clipping: event listeners 8
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 8ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 8
subgraph-idle: task duration 599ms
subgraph-idle: script duration 12ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 63.3 MB
subgraph-idle: DOM nodes -300
subgraph-idle: event listeners -216
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 7ms
subgraph-mouse-sweep: style recalc duration 50ms
subgraph-mouse-sweep: layout count 18
subgraph-mouse-sweep: style recalc count 79
subgraph-mouse-sweep: task duration 1070ms
subgraph-mouse-sweep: script duration 131ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 62.6 MB
subgraph-mouse-sweep: DOM nodes -296
subgraph-mouse-sweep: event listeners -216
subgraph-transition-enter: avg frame time 17ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 18ms
subgraph-transition-enter: style recalc duration 33ms
subgraph-transition-enter: layout count 12
subgraph-transition-enter: style recalc count 16
subgraph-transition-enter: task duration 1026ms
subgraph-transition-enter: script duration 38ms
subgraph-transition-enter: TBT 143ms
subgraph-transition-enter: heap used 103.9 MB
subgraph-transition-enter: DOM nodes 13751
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 50ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 245
viewport-pan-sweep: task duration 7232ms
viewport-pan-sweep: script duration 3116ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 76.5 MB
viewport-pan-sweep: DOM nodes -275
viewport-pan-sweep: event listeners -159
vue-large-graph-idle: avg frame time 18ms
vue-large-graph-idle: p95 frame time 17ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16915ms
vue-large-graph-idle: script duration 357ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 164.5 MB
vue-large-graph-idle: DOM nodes -6550
vue-large-graph-idle: event listeners -7475
vue-large-graph-pan: avg frame time 18ms
vue-large-graph-pan: p95 frame time 17ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 29ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 156
vue-large-graph-pan: task duration 21642ms
vue-large-graph-pan: script duration 1081ms
vue-large-graph-pan: TBT 111ms
vue-large-graph-pan: heap used 166.1 MB
vue-large-graph-pan: DOM nodes -6548
vue-large-graph-pan: event listeners -7469
vue-node-resize-workload: avg frame time 18ms
vue-node-resize-workload: p95 frame time 17ms
vue-node-resize-workload: layout duration 33ms
vue-node-resize-workload: style recalc duration 85ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 6466ms
vue-node-resize-workload: script duration 137ms
vue-node-resize-workload: TBT 479ms
vue-node-resize-workload: heap used 181.4 MB
vue-node-resize-workload: DOM nodes -6548
vue-node-resize-workload: event listeners -7471
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 25ms
workflow-execution: layout count 4
workflow-execution: style recalc count 13
workflow-execution: task duration 142ms
workflow-execution: script duration 12ms
workflow-execution: TBT 0ms
workflow-execution: heap used 70.4 MB
workflow-execution: DOM nodes 133
workflow-execution: event listeners 99
Raw data
{
  "timestamp": "2026-09-15T16:12:00.676Z",
  "gitSha": "8f0735aa83336d59d0968e153491442a71634a34",
  "branch": "backport-17348-to-cloud-1.53",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2051.4709999999923,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 9.922,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 592.9250000000001,
      "heapDeltaBytes": 5645632,
      "heapUsedBytes": 75216024,
      "domNodes": -283,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 13.078,
      "eventListeners": -185,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2050.316000000066,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 9.981,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 569.589,
      "heapDeltaBytes": -13305128,
      "heapUsedBytes": 57131516,
      "domNodes": -282,
      "jsHeapTotalBytes": 4972544,
      "scriptDurationMs": 10.929999999999998,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2362.684999999999,
      "styleRecalcs": 84,
      "styleRecalcDurationMs": 68.024,
      "layouts": 14,
      "layoutDurationMs": 7.606000000000001,
      "taskDurationMs": 1317.97,
      "heapDeltaBytes": -8470508,
      "heapUsedBytes": 61151568,
      "domNodes": -280,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 209.033,
      "eventListeners": -157,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66999999999998,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 2036.7659999999432,
      "styleRecalcs": 81,
      "styleRecalcDurationMs": 53.172000000000004,
      "layouts": 14,
      "layoutDurationMs": 5.586,
      "taskDurationMs": 1057.966,
      "heapDeltaBytes": -9132892,
      "heapUsedBytes": 61167944,
      "domNodes": -282,
      "jsHeapTotalBytes": 5234688,
      "scriptDurationMs": 168.29,
      "eventListeners": -155,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1773.6449999999877,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 22.334999999999997,
      "layouts": 6,
      "layoutDurationMs": 1.575,
      "taskDurationMs": 468.483,
      "heapDeltaBytes": 4675464,
      "heapUsedBytes": 75189188,
      "domNodes": 77,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 17.085,
      "eventListeners": 21,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1729.7340000000077,
      "styleRecalcs": 30,
      "styleRecalcDurationMs": 21.775000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.4960000000000002,
      "taskDurationMs": 453.99,
      "heapDeltaBytes": 4649556,
      "heapUsedBytes": 74506712,
      "domNodes": 75,
      "jsHeapTotalBytes": 5505024,
      "scriptDurationMs": 16.567,
      "eventListeners": 19,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 755.5120000000102,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 9.884999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 540.5070000000001,
      "heapDeltaBytes": 17505572,
      "heapUsedBytes": 87887292,
      "domNodes": 16,
      "jsHeapTotalBytes": 6029312,
      "scriptDurationMs": 176.36800000000002,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 774.6989999999414,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 8.564000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 530.5009999999999,
      "heapDeltaBytes": -7752000,
      "heapUsedBytes": 62893132,
      "domNodes": 16,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 176.06199999999998,
      "eventListeners": 2,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2072.8630000000976,
      "styleRecalcs": 5,
      "styleRecalcDurationMs": 6.876999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 740.108,
      "heapDeltaBytes": -14155792,
      "heapUsedBytes": 86447996,
      "domNodes": -272,
      "jsHeapTotalBytes": -1355776,
      "scriptDurationMs": 43.260000000000005,
      "eventListeners": -153,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2045.2000000000226,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 5.236000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 740.9480000000001,
      "heapDeltaBytes": 11084204,
      "heapUsedBytes": 86485888,
      "domNodes": -271,
      "jsHeapTotalBytes": -868352,
      "scriptDurationMs": 43.81,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.670000000000012,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3094.8889999999665,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 11.553,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1967.978,
      "heapDeltaBytes": 27295816,
      "heapUsedBytes": 93261788,
      "domNodes": -277,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 938.673,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 3102.820000000065,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 11.131000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1910.6319999999998,
      "heapDeltaBytes": 26720004,
      "heapUsedBytes": 92331612,
      "domNodes": -281,
      "jsHeapTotalBytes": 225280,
      "scriptDurationMs": 910.038,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4067.6789999999983,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 13.942000000000004,
      "layouts": 60,
      "layoutDurationMs": 16.291,
      "taskDurationMs": 1994.0769999999998,
      "heapDeltaBytes": 8478620,
      "heapUsedBytes": 75155256,
      "domNodes": -282,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 853.828,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 4009.582999999907,
      "styleRecalcs": 60,
      "styleRecalcDurationMs": 13.718000000000002,
      "layouts": 60,
      "layoutDurationMs": 16.168000000000003,
      "taskDurationMs": 2005.1930000000002,
      "heapDeltaBytes": 7729348,
      "heapUsedBytes": 75478552,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 858.077,
      "eventListeners": 10,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3397.685000000024,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 7.099000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2227.188,
      "heapDeltaBytes": 324900,
      "heapUsedBytes": 68164772,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 1078.256,
      "eventListeners": 188,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3594.468000000006,
      "styleRecalcs": 40,
      "styleRecalcDurationMs": 7.088000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 2355.6620000000003,
      "heapDeltaBytes": 688992,
      "heapUsedBytes": 67769564,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 1116.6909999999998,
      "eventListeners": 190,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2000.8940000000166,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 642.5439999999999,
      "heapDeltaBytes": 21804284,
      "heapUsedBytes": 87239900,
      "domNodes": -280,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 39.441,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2005.316999999991,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 643.0010000000001,
      "heapDeltaBytes": 21797252,
      "heapUsedBytes": 87661232,
      "domNodes": -280,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 41.878000000000014,
      "eventListeners": 4,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 705.857999999921,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 11.827999999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 480.286,
      "heapDeltaBytes": 14034076,
      "heapUsedBytes": 85880532,
      "domNodes": 16,
      "jsHeapTotalBytes": 5242880,
      "scriptDurationMs": 156.637,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 754.7029999999495,
      "styleRecalcs": 45,
      "styleRecalcDurationMs": 13.057000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 515.1539999999999,
      "heapDeltaBytes": 14785648,
      "heapUsedBytes": 87496004,
      "domNodes": 16,
      "jsHeapTotalBytes": 5767168,
      "scriptDurationMs": 166.864,
      "eventListeners": 8,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.699999999999818
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2017.6819999999793,
      "styleRecalcs": 8,
      "styleRecalcDurationMs": 8.342000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 623.3720000000001,
      "heapDeltaBytes": -2171176,
      "heapUsedBytes": 69787216,
      "domNodes": -300,
      "jsHeapTotalBytes": 5758976,
      "scriptDurationMs": 12.681000000000001,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2034.6519999999373,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 7.773000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 575.2049999999999,
      "heapDeltaBytes": -9678656,
      "heapUsedBytes": 63013488,
      "domNodes": -299,
      "jsHeapTotalBytes": 5496832,
      "scriptDurationMs": 12.065,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1870.70099999994,
      "styleRecalcs": 79,
      "styleRecalcDurationMs": 53.647000000000006,
      "layouts": 18,
      "layoutDurationMs": 7.176,
      "taskDurationMs": 1100.085,
      "heapDeltaBytes": -12411520,
      "heapUsedBytes": 60410392,
      "domNodes": -298,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 138.706,
      "eventListeners": -201,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333332,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1808.1949999999551,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 47.349,
      "layouts": 18,
      "layoutDurationMs": 6.585,
      "taskDurationMs": 1039.933,
      "heapDeltaBytes": -932512,
      "heapUsedBytes": 70913948,
      "domNodes": -294,
      "jsHeapTotalBytes": 6545408,
      "scriptDurationMs": 123.07399999999998,
      "eventListeners": -231,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1468.1499999999232,
      "styleRecalcs": 16,
      "styleRecalcDurationMs": 32.690999999999995,
      "layouts": 12,
      "layoutDurationMs": 17.706,
      "taskDurationMs": 1025.925,
      "heapDeltaBytes": 21027484,
      "heapUsedBytes": 108989016,
      "domNodes": 13751,
      "jsHeapTotalBytes": 10485760,
      "scriptDurationMs": 38.437,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 143,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 11865.88800000004,
      "styleRecalcs": 246,
      "styleRecalcDurationMs": 52.44800000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7109.871999999999,
      "heapDeltaBytes": -8524600,
      "heapUsedBytes": 66959640,
      "domNodes": -271,
      "jsHeapTotalBytes": -868352,
      "scriptDurationMs": 3093.242,
      "eventListeners": -159,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 11929.554000000053,
      "styleRecalcs": 244,
      "styleRecalcDurationMs": 48.294999999999995,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 7353.722000000001,
      "heapDeltaBytes": 18249304,
      "heapUsedBytes": 93396940,
      "domNodes": -278,
      "jsHeapTotalBytes": 634880,
      "scriptDurationMs": 3138.675,
      "eventListeners": -159,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17085.724000000027,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16778.255999999998,
      "heapDeltaBytes": -35572668,
      "heapUsedBytes": 174008436,
      "domNodes": -6552,
      "jsHeapTotalBytes": 3395584,
      "scriptDurationMs": 356.15999999999997,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 18.329999999999927,
      "p95FrameDurationMs": 16.80000000000291
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17271.634999999947,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 17051.547,
      "heapDeltaBytes": -40252648,
      "heapUsedBytes": 171001324,
      "domNodes": -6548,
      "jsHeapTotalBytes": 1830912,
      "scriptDurationMs": 357.956,
      "eventListeners": -7475,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.776666666666763,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 21429.215999999997,
      "styleRecalcs": 152,
      "styleRecalcDurationMs": 27.25899999999998,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 21266.820000000003,
      "heapDeltaBytes": -23586816,
      "heapUsedBytes": 179883228,
      "domNodes": -6548,
      "jsHeapTotalBytes": -2297856,
      "scriptDurationMs": 1067.9699999999998,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 101,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 22117.038999999975,
      "styleRecalcs": 159,
      "styleRecalcDurationMs": 30.45600000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 22016.292,
      "heapDeltaBytes": -34194716,
      "heapUsedBytes": 168536136,
      "domNodes": -6548,
      "jsHeapTotalBytes": 4661248,
      "scriptDurationMs": 1094.09,
      "eventListeners": -7469,
      "totalBlockingTimeMs": 121,
      "frameDurationMs": 17.776666666666642,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6562.925000000064,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 83.35900000000002,
      "layouts": 20,
      "layoutDurationMs": 32.18599999999999,
      "taskDurationMs": 6510.991000000001,
      "heapDeltaBytes": -26549468,
      "heapUsedBytes": 185494648,
      "domNodes": -6548,
      "jsHeapTotalBytes": 15720448,
      "scriptDurationMs": 131.852,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 364,
      "frameDurationMs": 18.333333333333393,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6454.221000000075,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 87.00999999999998,
      "layouts": 20,
      "layoutDurationMs": 32.92,
      "taskDurationMs": 6420.739,
      "heapDeltaBytes": -9188976,
      "heapUsedBytes": 195009032,
      "domNodes": -6548,
      "jsHeapTotalBytes": 9048064,
      "scriptDurationMs": 141.55900000000003,
      "eventListeners": -7471,
      "totalBlockingTimeMs": 593,
      "frameDurationMs": 17.780000000000047,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "workflow-execution",
      "durationMs": 517.6369999999224,
      "styleRecalcs": 15,
      "styleRecalcDurationMs": 25.732000000000006,
      "layouts": 4,
      "layoutDurationMs": 2.5390000000000006,
      "taskDurationMs": 158.65099999999998,
      "heapDeltaBytes": 5316248,
      "heapUsedBytes": 74044728,
      "domNodes": 147,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 14.990000000000004,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66333333333335,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "workflow-execution",
      "durationMs": 469.36600000003637,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 23.652,
      "layouts": 3,
      "layoutDurationMs": 1.0690000000000002,
      "taskDurationMs": 125.04499999999999,
      "heapDeltaBytes": 5052108,
      "heapUsedBytes": 73532148,
      "domNodes": 119,
      "jsHeapTotalBytes": 524288,
      "scriptDurationMs": 9.607999999999999,
      "eventListeners": 99,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 48194 70902 68.0% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.1% 1188
src/LGraphNode.ts 69.5% 396
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.0% 343
src/platform/workspace/stores/billingOperationStore.ts 8.1% 305
src/platform/workspace/stores/workspaceAuthStore.ts 36.0% 288
src/LGraph.ts 78.4% 261
src/platform/workspace/stores/teamWorkspaceStore.ts 37.7% 261
src/scripts/app.ts 71.7% 247
src/scripts/pnginfo.ts 21.4% 221
src/stores/assetsStore.ts 44.7% 204

@github-actions github-actions Bot added the risk:R3 PR risk grade (advisory shadow check; grader-owned) label Sep 15, 2026
@codecov

codecov Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 89.85507% with 35 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/platform/workspace/utils/checkoutJourney.ts 88.23% 22 Missing ⚠️
...kspace/components/UnifiedStripePaymentSelector.vue 89.83% 6 Missing ⚠️
...try/providers/cloud/DatadogRumTelemetryProvider.ts 0.00% 2 Missing ⚠️
...emetry/providers/cloud/PostHogTelemetryProvider.ts 33.33% 2 Missing ⚠️
src/platform/telemetry/types.ts 94.11% 1 Missing ⚠️
.../components/TopUpCreditsDialogContentWorkspace.vue 95.65% 1 Missing ⚠️
...m/workspace/composables/useSubscriptionCheckout.ts 97.95% 1 Missing ⚠️
@@              Coverage Diff              @@
##             cloud/1.53   #17753   +/-   ##
=============================================
  Coverage              ?   83.39%           
=============================================
  Files                 ?     2027           
  Lines                 ?   117735           
  Branches              ?    33304           
=============================================
  Hits                  ?    98188           
  Misses                ?    19189           
  Partials              ?      358           
Flag Coverage Δ
e2e 66.47% <6.58%> (?)
unit 76.81% <93.35%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/telemetry/TelemetryRegistry.ts 23.02% <100.00%> (ø)
...metry/providers/cloud/MixpanelTelemetryProvider.ts 82.27% <100.00%> (ø)
...platform/workspace/stores/billingOperationStore.ts 93.15% <100.00%> (ø)
src/platform/telemetry/types.ts 96.07% <94.11%> (ø)
.../components/TopUpCreditsDialogContentWorkspace.vue 88.19% <95.65%> (ø)
...m/workspace/composables/useSubscriptionCheckout.ts 92.81% <97.95%> (ø)
...try/providers/cloud/DatadogRumTelemetryProvider.ts 85.00% <0.00%> (ø)
...emetry/providers/cloud/PostHogTelemetryProvider.ts 67.43% <33.33%> (ø)
...kspace/components/UnifiedStripePaymentSelector.vue 90.22% <89.83%> (ø)
src/platform/workspace/utils/checkoutJourney.ts 88.23% <88.23%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CodeJuggernaut

Copy link
Copy Markdown
Contributor

Holding this backport for 1.55 from main: there is no log of testing beyond unit tests, and the release lines need that evidence.

@christian-byrne christian-byrne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as part of a batch pass over the eight unreviewed backports. For this family (#17750–#17753) I compared the 1.53 and 1.54 payloads against each other rather than reading each separately, because the question that matters for a backport set is whether every release line gets the same change.

They are equivalent except in one place, and it is deliberate. The size difference (+2351/−48 on 1.54 versus +2383/−81 on 1.53) resolves to four files, and three of them are noise — an ADR index that is ordered differently on the older branch, and a test file needing slightly more adaptation. The real one is this, in both MixpanelTelemetryProvider.ts and PostHogTelemetryProvider.ts:

// 1.54
const TELEMETRY_EVENT_SET = new Set<TelemetryEventName>([
  ...Object.values(TelemetryEvents),

// 1.53
const TELEMETRY_EVENT_SET = new Set<string>([
  ...(Object.values(TelemetryEvents) as TelemetryEventName[]),

Both branches add exactly 9 and 15 lines respectively, so the behaviour is the same — the set holds the same events and filters the same way at runtime. What differs is the type: 1.53 widens the set to string and casts the spread.

I assume that is forced by TelemetryEvents having a looser shape on the older branch, which makes it a reasonable adaptation rather than a defect. Two things worth noting anyway:

  • On 1.53 the set no longer constrains what can be looked up in it. Anything typed string is accepted. That is a weaker guarantee than 1.54 gets from the same PR, and the as cast is what makes the mismatch invisible rather than resolving it.
  • This is only findable by comparing the siblings. Read on its own, each PR looks like a faithful backport. Worth a line in the 1.53 bodies saying the type was widened and why, so nobody later reads the two release lines as byte-identical or copies the string version forward.

Nothing here blocks: the runtime payload matches, the file sets are identical, and CI is green and mergeable on all four.

@comfy-pr-bot
comfy-pr-bot merged commit c215ce8 into cloud/1.53 Sep 17, 2026
109 checks passed
@comfy-pr-bot
comfy-pr-bot deleted the backport-17348-to-cloud-1.53 branch September 17, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Backporting a PR onto a release candidate risk:R3 PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants