Repository navigation
[backport cloud/1.53] feat(billing): embedded checkout journey instrumentation (#17348) - #17753
Conversation
…mentation (#17348) Manual backport of 6a6a4a2 — the automated cherry-pick hit conflicts. Resolutions against this branch: - billingOperationStore: no try/cleanup restructure here, so the journey clear sits before the success telemetry instead. - TopUpCreditsDialogContentWorkspace.vue: this branch keeps the isAddingCredits name, unlike core/1.53 which uses isPolling. - Provider event sets: this branch types the Set as TelemetryEventName, so the checkout names are spread into that typed set rather than a Set<string>. - TopUpCreditsDialogContentWorkspace.test / TelemetryRegistry.test: only the journey additions were applied onto this branch's own mocks, plus a firebase/auth spy so useAuthStore() does not reach real Firebase. - Dropped FetchTimeoutMetadata and BootstrapCompleteMetadata, which the conflict regions carried in from main-only features.
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 1888 passed, 0 failed · 3 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-15T16:12:00.676Z",
"gitSha": "8f0735aa83336d59d0968e153491442a71634a34",
"branch": "backport-17348-to-cloud-1.53",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2051.4709999999923,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.922,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 592.9250000000001,
"heapDeltaBytes": 5645632,
"heapUsedBytes": 75216024,
"domNodes": -283,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 13.078,
"eventListeners": -185,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2050.316000000066,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.981,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 569.589,
"heapDeltaBytes": -13305128,
"heapUsedBytes": 57131516,
"domNodes": -282,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 10.929999999999998,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2362.684999999999,
"styleRecalcs": 84,
"styleRecalcDurationMs": 68.024,
"layouts": 14,
"layoutDurationMs": 7.606000000000001,
"taskDurationMs": 1317.97,
"heapDeltaBytes": -8470508,
"heapUsedBytes": 61151568,
"domNodes": -280,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 209.033,
"eventListeners": -157,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 2036.7659999999432,
"styleRecalcs": 81,
"styleRecalcDurationMs": 53.172000000000004,
"layouts": 14,
"layoutDurationMs": 5.586,
"taskDurationMs": 1057.966,
"heapDeltaBytes": -9132892,
"heapUsedBytes": 61167944,
"domNodes": -282,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 168.29,
"eventListeners": -155,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1773.6449999999877,
"styleRecalcs": 32,
"styleRecalcDurationMs": 22.334999999999997,
"layouts": 6,
"layoutDurationMs": 1.575,
"taskDurationMs": 468.483,
"heapDeltaBytes": 4675464,
"heapUsedBytes": 75189188,
"domNodes": 77,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 17.085,
"eventListeners": 21,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1729.7340000000077,
"styleRecalcs": 30,
"styleRecalcDurationMs": 21.775000000000002,
"layouts": 6,
"layoutDurationMs": 1.4960000000000002,
"taskDurationMs": 453.99,
"heapDeltaBytes": 4649556,
"heapUsedBytes": 74506712,
"domNodes": 75,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 16.567,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 755.5120000000102,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.884999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 540.5070000000001,
"heapDeltaBytes": 17505572,
"heapUsedBytes": 87887292,
"domNodes": 16,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 176.36800000000002,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 774.6989999999414,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.564000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 530.5009999999999,
"heapDeltaBytes": -7752000,
"heapUsedBytes": 62893132,
"domNodes": 16,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 176.06199999999998,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2072.8630000000976,
"styleRecalcs": 5,
"styleRecalcDurationMs": 6.876999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 740.108,
"heapDeltaBytes": -14155792,
"heapUsedBytes": 86447996,
"domNodes": -272,
"jsHeapTotalBytes": -1355776,
"scriptDurationMs": 43.260000000000005,
"eventListeners": -153,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2045.2000000000226,
"styleRecalcs": 4,
"styleRecalcDurationMs": 5.236000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 740.9480000000001,
"heapDeltaBytes": 11084204,
"heapUsedBytes": 86485888,
"domNodes": -271,
"jsHeapTotalBytes": -868352,
"scriptDurationMs": 43.81,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 3094.8889999999665,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.553,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1967.978,
"heapDeltaBytes": 27295816,
"heapUsedBytes": 93261788,
"domNodes": -277,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 938.673,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 3102.820000000065,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.131000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1910.6319999999998,
"heapDeltaBytes": 26720004,
"heapUsedBytes": 92331612,
"domNodes": -281,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 910.038,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 4067.6789999999983,
"styleRecalcs": 60,
"styleRecalcDurationMs": 13.942000000000004,
"layouts": 60,
"layoutDurationMs": 16.291,
"taskDurationMs": 1994.0769999999998,
"heapDeltaBytes": 8478620,
"heapUsedBytes": 75155256,
"domNodes": -282,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 853.828,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 4009.582999999907,
"styleRecalcs": 60,
"styleRecalcDurationMs": 13.718000000000002,
"layouts": 60,
"layoutDurationMs": 16.168000000000003,
"taskDurationMs": 2005.1930000000002,
"heapDeltaBytes": 7729348,
"heapUsedBytes": 75478552,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 858.077,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3397.685000000024,
"styleRecalcs": 40,
"styleRecalcDurationMs": 7.099000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2227.188,
"heapDeltaBytes": 324900,
"heapUsedBytes": 68164772,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 1078.256,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3594.468000000006,
"styleRecalcs": 40,
"styleRecalcDurationMs": 7.088000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2355.6620000000003,
"heapDeltaBytes": 688992,
"heapUsedBytes": 67769564,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 1116.6909999999998,
"eventListeners": 190,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2000.8940000000166,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 642.5439999999999,
"heapDeltaBytes": 21804284,
"heapUsedBytes": 87239900,
"domNodes": -280,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 39.441,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2005.316999999991,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 643.0010000000001,
"heapDeltaBytes": 21797252,
"heapUsedBytes": 87661232,
"domNodes": -280,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 41.878000000000014,
"eventListeners": 4,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 705.857999999921,
"styleRecalcs": 45,
"styleRecalcDurationMs": 11.827999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 480.286,
"heapDeltaBytes": 14034076,
"heapUsedBytes": 85880532,
"domNodes": 16,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 156.637,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 754.7029999999495,
"styleRecalcs": 45,
"styleRecalcDurationMs": 13.057000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 515.1539999999999,
"heapDeltaBytes": 14785648,
"heapUsedBytes": 87496004,
"domNodes": 16,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 166.864,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-idle",
"durationMs": 2017.6819999999793,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.342000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 623.3720000000001,
"heapDeltaBytes": -2171176,
"heapUsedBytes": 69787216,
"domNodes": -300,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 12.681000000000001,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2034.6519999999373,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.773000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.2049999999999,
"heapDeltaBytes": -9678656,
"heapUsedBytes": 63013488,
"domNodes": -299,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 12.065,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1870.70099999994,
"styleRecalcs": 79,
"styleRecalcDurationMs": 53.647000000000006,
"layouts": 18,
"layoutDurationMs": 7.176,
"taskDurationMs": 1100.085,
"heapDeltaBytes": -12411520,
"heapUsedBytes": 60410392,
"domNodes": -298,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 138.706,
"eventListeners": -201,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1808.1949999999551,
"styleRecalcs": 78,
"styleRecalcDurationMs": 47.349,
"layouts": 18,
"layoutDurationMs": 6.585,
"taskDurationMs": 1039.933,
"heapDeltaBytes": -932512,
"heapUsedBytes": 70913948,
"domNodes": -294,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 123.07399999999998,
"eventListeners": -231,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1468.1499999999232,
"styleRecalcs": 16,
"styleRecalcDurationMs": 32.690999999999995,
"layouts": 12,
"layoutDurationMs": 17.706,
"taskDurationMs": 1025.925,
"heapDeltaBytes": 21027484,
"heapUsedBytes": 108989016,
"domNodes": 13751,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 38.437,
"eventListeners": 2383,
"totalBlockingTimeMs": 143,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 11865.88800000004,
"styleRecalcs": 246,
"styleRecalcDurationMs": 52.44800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7109.871999999999,
"heapDeltaBytes": -8524600,
"heapUsedBytes": 66959640,
"domNodes": -271,
"jsHeapTotalBytes": -868352,
"scriptDurationMs": 3093.242,
"eventListeners": -159,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 11929.554000000053,
"styleRecalcs": 244,
"styleRecalcDurationMs": 48.294999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7353.722000000001,
"heapDeltaBytes": 18249304,
"heapUsedBytes": 93396940,
"domNodes": -278,
"jsHeapTotalBytes": 634880,
"scriptDurationMs": 3138.675,
"eventListeners": -159,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17085.724000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16778.255999999998,
"heapDeltaBytes": -35572668,
"heapUsedBytes": 174008436,
"domNodes": -6552,
"jsHeapTotalBytes": 3395584,
"scriptDurationMs": 356.15999999999997,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 17271.634999999947,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17051.547,
"heapDeltaBytes": -40252648,
"heapUsedBytes": 171001324,
"domNodes": -6548,
"jsHeapTotalBytes": 1830912,
"scriptDurationMs": 357.956,
"eventListeners": -7475,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21429.215999999997,
"styleRecalcs": 152,
"styleRecalcDurationMs": 27.25899999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21266.820000000003,
"heapDeltaBytes": -23586816,
"heapUsedBytes": 179883228,
"domNodes": -6548,
"jsHeapTotalBytes": -2297856,
"scriptDurationMs": 1067.9699999999998,
"eventListeners": -7469,
"totalBlockingTimeMs": 101,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 22117.038999999975,
"styleRecalcs": 159,
"styleRecalcDurationMs": 30.45600000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22016.292,
"heapDeltaBytes": -34194716,
"heapUsedBytes": 168536136,
"domNodes": -6548,
"jsHeapTotalBytes": 4661248,
"scriptDurationMs": 1094.09,
"eventListeners": -7469,
"totalBlockingTimeMs": 121,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6562.925000000064,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.35900000000002,
"layouts": 20,
"layoutDurationMs": 32.18599999999999,
"taskDurationMs": 6510.991000000001,
"heapDeltaBytes": -26549468,
"heapUsedBytes": 185494648,
"domNodes": -6548,
"jsHeapTotalBytes": 15720448,
"scriptDurationMs": 131.852,
"eventListeners": -7471,
"totalBlockingTimeMs": 364,
"frameDurationMs": 18.333333333333393,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6454.221000000075,
"styleRecalcs": 20,
"styleRecalcDurationMs": 87.00999999999998,
"layouts": 20,
"layoutDurationMs": 32.92,
"taskDurationMs": 6420.739,
"heapDeltaBytes": -9188976,
"heapUsedBytes": 195009032,
"domNodes": -6548,
"jsHeapTotalBytes": 9048064,
"scriptDurationMs": 141.55900000000003,
"eventListeners": -7471,
"totalBlockingTimeMs": 593,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "workflow-execution",
"durationMs": 517.6369999999224,
"styleRecalcs": 15,
"styleRecalcDurationMs": 25.732000000000006,
"layouts": 4,
"layoutDurationMs": 2.5390000000000006,
"taskDurationMs": 158.65099999999998,
"heapDeltaBytes": 5316248,
"heapUsedBytes": 74044728,
"domNodes": 147,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.990000000000004,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 469.36600000003637,
"styleRecalcs": 11,
"styleRecalcDurationMs": 23.652,
"layouts": 3,
"layoutDurationMs": 1.0690000000000002,
"taskDurationMs": 125.04499999999999,
"heapDeltaBytes": 5052108,
"heapUsedBytes": 73532148,
"domNodes": 119,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 9.607999999999999,
"eventListeners": 99,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
Holding this backport for 1.55 from main: there is no log of testing beyond unit tests, and the release lines need that evidence. |
christian-byrne
left a comment
There was a problem hiding this comment.
Approving as part of a batch pass over the eight unreviewed backports. For this family (#17750–#17753) I compared the 1.53 and 1.54 payloads against each other rather than reading each separately, because the question that matters for a backport set is whether every release line gets the same change.
They are equivalent except in one place, and it is deliberate. The size difference (+2351/−48 on 1.54 versus +2383/−81 on 1.53) resolves to four files, and three of them are noise — an ADR index that is ordered differently on the older branch, and a test file needing slightly more adaptation. The real one is this, in both MixpanelTelemetryProvider.ts and PostHogTelemetryProvider.ts:
// 1.54
const TELEMETRY_EVENT_SET = new Set<TelemetryEventName>([
...Object.values(TelemetryEvents),
// 1.53
const TELEMETRY_EVENT_SET = new Set<string>([
...(Object.values(TelemetryEvents) as TelemetryEventName[]),Both branches add exactly 9 and 15 lines respectively, so the behaviour is the same — the set holds the same events and filters the same way at runtime. What differs is the type: 1.53 widens the set to string and casts the spread.
I assume that is forced by TelemetryEvents having a looser shape on the older branch, which makes it a reasonable adaptation rather than a defect. Two things worth noting anyway:
- On 1.53 the set no longer constrains what can be looked up in it. Anything typed
stringis accepted. That is a weaker guarantee than 1.54 gets from the same PR, and theascast is what makes the mismatch invisible rather than resolving it. - This is only findable by comparing the siblings. Read on its own, each PR looks like a faithful backport. Worth a line in the 1.53 bodies saying the type was widened and why, so nobody later reads the two release lines as byte-identical or copies the
stringversion forward.
Nothing here blocks: the runtime payload matches, the file sets are identical, and CI is green and mergeable on all four.
Manual backport of #17348 (
6a6a4a2). The automated cherry-pick failed with conflicts, so this was resolved by hand per the bot's instructions.Why
#17348 is labelled for this release. The auto-backport workflow could not apply it because this branch predates several
mainrefactors the commit sits on top of.Root cause of the conflict
Not a stacking conflict — the open backports the bot pointed at (#17720 / #17721 / #17600) are workflow and ECS test-coverage changes that touch none of the conflicting files. The conflicts are genuine divergence between
mainand this branch.How — conflicts and how each was resolved
billingOperationStore.ts—mainwrapshandleSuccess's body intry { cleanup(opId) … }; this branch does not. The checkout-journey clear is placed before the success telemetry here, keeping the same guarantee (it runs before any cleanup path can throw) against this branch's structure.TopUpCreditsDialogContentWorkspace.vue— this branch keepsisAddingCredits, unlike core/1.53 which usesisPolling.TELEMETRY_EVENT_SETasSet<TelemetryEventName>rather thanSet<string>, so the checkout-journey names are spread into that typed set.TopUpCreditsDialogContentWorkspace.test.ts/TelemetryRegistry.test.ts— this branch mocks the operation store with hoisted mocks and has nobillingOperationTestUtilshelper, whichmain's version depends on. Takingmain's blocks wholesale compiled but broke every test, so only feat(billing): embedded checkout journey instrumentation #17348's journey additions were applied onto this branch's own structure, plus afirebase/authspy souseAuthStore()does not reach real Firebase.types.ts/TelemetryRegistry.ts— the conflict regions carriedFetchTimeoutMetadataandBootstrapCompleteMetadata, both frommain-only features with no consumer here. Dropped;knipconfirms nothing else was over-pulled.The diff against this branch now adds exactly the symbols #17348 added, and nothing else.
AS IS / TO BE
Not applicable — this is a telemetry-only backport with no user-visible surface. #17348 changes no checkout UX or payment behavior; it adds
billing.checkout.*events alongside the existing terminalbilling.*taxonomy.Verification
pnpm typecheck,pnpm knip,pnpm lint(0 errors) clean