Repository navigation
test: add ECS widget QA coverage - #17460
Conversation
🎭 Playwright: ✅ 1968 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle: 9.94 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.73 kB (baseline 3.73 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.43 MB (baseline 1.43 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 622 kB (baseline 622 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 27 unchanged User & Accounts — 26.2 kB (baseline 26.2 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 118 kB (baseline 118 kB) • ⚪ 0 BReusable component library chunks Status: 15 unchanged Data & Services — 3.71 MB (baseline 3.71 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 16 unchanged Utilities & Hooks — 560 kB (baseline 560 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 37 unchanged Vendor & Third-Party — 18.2 MB (baseline 18.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.2 MB (baseline 17.2 MB) • ⚪ 0 BBundles that do not match a named category Status: 296 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-12T01:15:10.475Z",
"gitSha": "65cae3aa01b0ee0bfac94418a56ce2afc642872b",
"branch": "test/ecs-qa-widgets",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1999.4179999999915,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.962,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 534.316,
"heapDeltaBytes": 6910012,
"heapUsedBytes": 68592404,
"domNodes": -262,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 11.433000000000002,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2013.180000000034,
"styleRecalcs": 8,
"styleRecalcDurationMs": 11.542999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 563.422,
"heapDeltaBytes": -5104292,
"heapUsedBytes": 55413616,
"domNodes": -263,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 13.614999999999998,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1961.0890000000154,
"styleRecalcs": 73,
"styleRecalcDurationMs": 30.088000000000005,
"layouts": 14,
"layoutDurationMs": 4.728,
"taskDurationMs": 939.1919999999999,
"heapDeltaBytes": -257380,
"heapUsedBytes": 61241192,
"domNodes": -268,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 181.10099999999997,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1925.0160000000278,
"styleRecalcs": 79,
"styleRecalcDurationMs": 33.098,
"layouts": 14,
"layoutDurationMs": 4.957000000000001,
"taskDurationMs": 923.128,
"heapDeltaBytes": -554672,
"heapUsedBytes": 61184012,
"domNodes": -260,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 175.597,
"eventListeners": -184,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.0560000000091,
"styleRecalcs": 32,
"styleRecalcDurationMs": 14.576,
"layouts": 6,
"layoutDurationMs": 1.0859999999999996,
"taskDurationMs": 328.07399999999996,
"heapDeltaBytes": 2214444,
"heapUsedBytes": 64271504,
"domNodes": 75,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 10.102,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1688.9899999999898,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.713,
"layouts": 6,
"layoutDurationMs": 1.1879999999999997,
"taskDurationMs": 378.71599999999995,
"heapDeltaBytes": 2167304,
"heapUsedBytes": 64227208,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 14.372999999999998,
"eventListeners": 19,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 611.0920000000419,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.545,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 431.425,
"heapDeltaBytes": 17855900,
"heapUsedBytes": 79968400,
"domNodes": 18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 164.526,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 707.5209999999288,
"styleRecalcs": 10,
"styleRecalcDurationMs": 7.933999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.264,
"heapDeltaBytes": 18007748,
"heapUsedBytes": 79741772,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 164.887,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2039.9889999999914,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.9609999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 713.3539999999999,
"heapDeltaBytes": 4267312,
"heapUsedBytes": 83527300,
"domNodes": -249,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 37.826,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2012.9289999999855,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.7829999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 548.5840000000001,
"heapDeltaBytes": 20149764,
"heapUsedBytes": 83505104,
"domNodes": -248,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.622,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2257.8169999999886,
"styleRecalcs": 66,
"styleRecalcDurationMs": 10.516000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1622.9900000000002,
"heapDeltaBytes": 11109556,
"heapUsedBytes": 75515712,
"domNodes": -251,
"jsHeapTotalBytes": 2060288,
"scriptDurationMs": 857.384,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2267.626000000064,
"styleRecalcs": 64,
"styleRecalcDurationMs": 9.673999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1682.0539999999999,
"heapDeltaBytes": 18095736,
"heapUsedBytes": 82683596,
"domNodes": 4,
"jsHeapTotalBytes": 749568,
"scriptDurationMs": 852.6560000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3501.3040000000046,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.679,
"layouts": 60,
"layoutDurationMs": 12.416,
"taskDurationMs": 1648.7469999999998,
"heapDeltaBytes": 9379996,
"heapUsedBytes": 74507496,
"domNodes": -253,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 773.8389999999999,
"eventListeners": 10,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3703.2930000000306,
"styleRecalcs": 62,
"styleRecalcDurationMs": 13.118999999999998,
"layouts": 60,
"layoutDurationMs": 13.730999999999998,
"taskDurationMs": 1847.819,
"heapDeltaBytes": -8883600,
"heapUsedBytes": 73336192,
"domNodes": -268,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 830.536,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2871.7380000000503,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.315000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1700.529,
"heapDeltaBytes": 18379728,
"heapUsedBytes": 84178268,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 964.3609999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3138.4879999999384,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.724,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1938.269,
"heapDeltaBytes": 15077972,
"heapUsedBytes": 80558528,
"domNodes": -9,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 984.0389999999999,
"eventListeners": 188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.9450000000165,
"styleRecalcs": 5,
"styleRecalcDurationMs": 4.028999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 538.6289999999999,
"heapDeltaBytes": -3088968,
"heapUsedBytes": 83177948,
"domNodes": -252,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 32.427,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2019.2409999999654,
"styleRecalcs": 4,
"styleRecalcDurationMs": 4.196999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 674.8510000000001,
"heapDeltaBytes": -3438724,
"heapUsedBytes": 83976580,
"domNodes": -252,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 39.13700000000001,
"eventListeners": -154,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 579.5160000000124,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.196999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 396.8229999999999,
"heapDeltaBytes": 13536764,
"heapUsedBytes": 76664824,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 147.417,
"eventListeners": 8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 575.2650000000585,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.335999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 383.18600000000004,
"heapDeltaBytes": 13850048,
"heapUsedBytes": 76993392,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 148.23,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2003.9729999999736,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.466,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.23600000000005,
"heapDeltaBytes": 17450232,
"heapUsedBytes": 80650620,
"domNodes": -274,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.230999999999998,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.8869999999451,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.975999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 542.819,
"heapDeltaBytes": 10293532,
"heapUsedBytes": 73662248,
"domNodes": -276,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 11.200000000000001,
"eventListeners": -200,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1730.181000000016,
"styleRecalcs": 79,
"styleRecalcDurationMs": 25.764000000000003,
"layouts": 18,
"layoutDurationMs": 5.446999999999999,
"taskDurationMs": 678.982,
"heapDeltaBytes": 4939336,
"heapUsedBytes": 67153384,
"domNodes": -277,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 107.08099999999999,
"eventListeners": -232,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.6389999999483,
"styleRecalcs": 76,
"styleRecalcDurationMs": 28.169,
"layouts": 18,
"layoutDurationMs": 5.430000000000001,
"taskDurationMs": 824.184,
"heapDeltaBytes": 7701428,
"heapUsedBytes": 70994636,
"domNodes": -278,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 115.16600000000001,
"eventListeners": -202,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1351.3580000000047,
"styleRecalcs": 16,
"styleRecalcDurationMs": 29.517999999999997,
"layouts": 5,
"layoutDurationMs": 12.917000000000002,
"taskDurationMs": 851.2639999999998,
"heapDeltaBytes": 19695312,
"heapUsedBytes": 101213764,
"domNodes": 13587,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 29.309999999999995,
"eventListeners": 2387,
"totalBlockingTimeMs": 139,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8638.575000000003,
"styleRecalcs": 248,
"styleRecalcDurationMs": 34.568000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6050.388,
"heapDeltaBytes": 23220964,
"heapUsedBytes": 102468396,
"domNodes": -245,
"jsHeapTotalBytes": 1789952,
"scriptDurationMs": 3027.355,
"eventListeners": -136,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9344.019000000004,
"styleRecalcs": 248,
"styleRecalcDurationMs": 38.335,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6473.353,
"heapDeltaBytes": -4173448,
"heapUsedBytes": 75507364,
"domNodes": -246,
"jsHeapTotalBytes": 446464,
"scriptDurationMs": 2981.2400000000002,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 17139.177000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16672.445,
"heapDeltaBytes": -50787596,
"heapUsedBytes": 161877272,
"domNodes": -6542,
"jsHeapTotalBytes": 3891200,
"scriptDurationMs": 273.26500000000004,
"eventListeners": -7480,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.889999999999905,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 16986.35999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16702.821999999996,
"heapDeltaBytes": -39636144,
"heapUsedBytes": 168256376,
"domNodes": -6542,
"jsHeapTotalBytes": 2899968,
"scriptDurationMs": 278.366,
"eventListeners": -7480,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20568.461000000014,
"styleRecalcs": 159,
"styleRecalcDurationMs": 16.82399999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20284.365,
"heapDeltaBytes": -20603176,
"heapUsedBytes": 174551468,
"domNodes": -6542,
"jsHeapTotalBytes": 372736,
"scriptDurationMs": 898.183,
"eventListeners": -7476,
"totalBlockingTimeMs": 39,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20836.453000000005,
"styleRecalcs": 153,
"styleRecalcDurationMs": 19.00200000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20604.333,
"heapDeltaBytes": -24434764,
"heapUsedBytes": 176567676,
"domNodes": -6542,
"jsHeapTotalBytes": 2113536,
"scriptDurationMs": 896.6410000000001,
"eventListeners": -7474,
"totalBlockingTimeMs": 33,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6121.449999999982,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.515,
"layouts": 20,
"layoutDurationMs": 22.43200000000001,
"taskDurationMs": 5975.87,
"heapDeltaBytes": -21888388,
"heapUsedBytes": 180385412,
"domNodes": -6542,
"jsHeapTotalBytes": 16486400,
"scriptDurationMs": 110.50699999999999,
"eventListeners": -7478,
"totalBlockingTimeMs": 399,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6246.980000000008,
"styleRecalcs": 20,
"styleRecalcDurationMs": 82.29699999999995,
"layouts": 20,
"layoutDurationMs": 23.707000000000004,
"taskDurationMs": 6176.486000000001,
"heapDeltaBytes": -3589640,
"heapUsedBytes": 194187916,
"domNodes": -6542,
"jsHeapTotalBytes": 18890752,
"scriptDurationMs": 120.82600000000001,
"eventListeners": -7476,
"totalBlockingTimeMs": 428,
"frameDurationMs": 17.776666666666703,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8693.94699999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8528.475999999999,
"heapDeltaBytes": 13275848,
"heapUsedBytes": 184139468,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 135.42700000000008,
"eventListeners": -12,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8490.094999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8315.423,
"heapDeltaBytes": -5859512,
"heapUsedBytes": 168213760,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 141.31899999999996,
"eventListeners": -8,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 121.87600000004295,
"styleRecalcs": 8,
"styleRecalcDurationMs": 18.715000000000003,
"layouts": 5,
"layoutDurationMs": 2.7619999999999996,
"taskDurationMs": 107.46700000000001,
"heapDeltaBytes": 3363032,
"heapUsedBytes": 65141568,
"domNodes": 133,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.623,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 105.15800000007403,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.810999999999998,
"layouts": 3,
"layoutDurationMs": 1.4909999999999999,
"taskDurationMs": 77.33000000000001,
"heapDeltaBytes": 3072364,
"heapUsedBytes": 64883116,
"domNodes": 131,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 5.942000000000001,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughAdded ECS migration browser tests for widget connection restoration and multiline text persistence. The tests cover setup, input metadata, widget state, values, and special characters across save and reload. ChangesECS widget tests
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~15 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The added browser coverage exercises the intended restoration and persisted multiline-text behavior without an identified merge-blocking risk. Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The available metadata shows a change under ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #17460 +/- ##
==========================================
+ Coverage 82.48% 83.55% +1.06%
==========================================
Files 2685 2107 -578
Lines 135414 122712 -12702
Branches 35504 33827 -1677
==========================================
- Hits 111700 102532 -9168
+ Misses 22795 19999 -2796
+ Partials 919 181 -738
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: changes requested
Pre-merge blocker:
- P1: The PR says "No rows were skipped," but three mapped release-plan rows are only partially covered. The widget-input test never converts the input back to a widget, the cleared-text test does not use a promoted widget, and the pin test never saves or reloads either state. Please either complete those scenarios or narrow the PR's stated QA-plan coverage so these steps remain in the manual queue.
Findings without an anchorable line
- P1, PR description /
browser_tests/tests/ecsWidgets.spec.ts:38-161: The linked QA plan, last edited before this PR, requires a final convert-back step, a promoted text widget, and save/reload checks while pinned and after unpinning. Those actions are absent. This is blocking because the plan says automated rows leave the manual QA queue.
Unverified candidate
- P3, PR description verification section: The detailed historical local Chromium outcomes are not backed by attached logs, so I could not audit the stated per-run results or the shared-backend attribution. Attaching those logs or trimming the historical detail would settle this. Separately, exact-head CI's
playwright-video-new-testsjob ran all five tests and passed in 54.5 seconds.
Checked and cleared
- CodeRabbit's regression-coverage check said the PR title and commit subjects were unavailable. REST returns both, so that metadata limitation does not hold. CodeRabbit posted no actionable inline findings.
- The apparent overlap with PRs 17455, 17456, 17457, 17459, and 17462 is series-level only. Each PR adds a separate spec for a different ECS QA area; this review covers only PR 17460.
Coverage
- Depth: standard. Lanes run: correctness, maintainability, idiomaticity, tests, and documentation. No applicable lane was skipped.
- Correctness lenses: blast radius, regression risk/blame, idempotence, shared-state separation, boundary discipline, and root-cause analysis. The file is new, so there were no changed pre-image lines to blame.
- Maintainability lenses: deletion-first/YAGNI, comment quality, reader load, subtract-before-add, laziness, and legacy-API migration. Coverage included ownership of save interactions, persisted-state lifetime, duplicate scenario searches, repository prohibitions, and diff-scoped Fallow. Fallow found no issue in the changed file.
- Test lenses: Playwright conventions, unit-test quality, mock-boundary analysis, flake hardening, setup consolidation, and proof. All five tests were traced to their fixtures and falsifiers. No mocks are involved.
- Checks at
5423c73675dfcfc08c0a225528a552cde8a630ce: browser typecheck, targeted ESLint, Oxlint, formatting,git diff --check, Playwright discovery, and Fallow passed. Exact-head CI ran all five new tests successfully. My first local run reached no test body because the orb's backend image was still building; all five setup attempts failed with connection refused, so that run is infrastructure-only evidence. - Lane reconciliation merged four duplicate candidates: placement was independently found by maintainability, idiomaticity, and tests; save-helper duplication by maintainability and idiomaticity; cleanup lifetime by maintainability and tests.
- Candidate reconciliation: 13 received = 6 inline + 1 body blocker + 1 unverified body item + 4 merged duplicates + 1 rejected automated claim.
Addresses review feedback: #17460 (comment)
Addresses review feedback: #17460 (comment) #17460 (comment) #17460 (comment) #17460 (comment) #17460 (comment)
|
Coverage claims narrowed at Full context for agent readersThe PR body now keeps convert-back, promoted-text empty persistence, and pinned/unpinned save-reload steps manual. It no longer claims those three complete QA rows are retired. |
|
Persistence setup fixed. Five tests pass locally. Re-review needed. Full context for agent readersCorrection to the earlier static-only verification: CI found save-menu timeouts. The persistence setup fix enables the top menu for save/reload and uses a real multiline widget fixture. The disconnect assertion accepts a removed input as disconnected; the preserved widget value is still checked. All five browser tests passed locally. Root/browser typechecks, formatting, linters, and Knip passed. Remote CI and human re-review remain required. The full promoted-input and pin/save/reload QA scenarios remain manual; this narrower suite does not retire them. |
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: changes requested.
The author fixed the six original inline findings and narrowed the QA-plan claims correctly. One blocker remains in the replacement restoration oracle: the test can pass while the widget stays connection-suppressed after its source is deleted. That makes the advertised restoration coverage insensitive to a user-visible ECS regression.
Pre-merge blocker:
- P1
browser_tests/tests/widgets/ecsWidgets.spec.ts:69-82: verify that the current seed widget is usable/visible again after source deletion, not only that its link disappeared and its value remains stored.
Other findings
- P2 The suite changes
Comfy.VueNodes.Enabledin two cases but does not establish or restore a renderer policy for every test. The combo and pin cases therefore depend on which earlier tests ran. - P2 Three cases overlap established feature-owner specs without a distinct ECS configuration or assertion. Cleared text overlaps
vueNodes/widgets/widgetValuePersistence.spec.ts; pin drag overlaps the Vue pin and legacy right-click specs; combo serialization overlapsvueNodes/widgets/combo/comboWidget.spec.ts. Keeping the unique assertions beside those owners would avoid a temporary migration bucket becoming a second owner. - P3, unverified and non-blocking The body and author update report historical/local commands whose raw logs are unavailable here. Current exact-head CI and the exact-head checks listed below supersede that evidence for this review.
Prior findings reevaluated
- Fixed: feature-folder placement.
- Fixed: failure-safe workflow cleanup.
- Fixed: diagnostic precondition message.
- Fixed: connected-link boolean oracle.
- Fixed: explicit text fixtures and node-scoped locators.
- Fixed: shared
Topbar.saveWorkflowusage. - Fixed: the body now leaves convert-back, promoted-text empty persistence, and pin save/reload in manual QA.
I did not resolve the existing threads.
Checked and cleared
- A successful
ComfyWorkflow.saveAs()removes the matching local draft, so the following page reload cannot mask a failed server serialization with that draft. - The connected-state predicate now returns false if the node/input is absent.
- Explicit workflow assets remove the old startup/default-graph dependency.
- Fallow found no issue in the changed file. Its baseline-path warnings are repository/environment noise, not introduced by this PR.
Coverage and checks
Standard-depth follow-up at fdb87a718593c894305f3676f47e8eb9c32265c4. Lanes run: correctness, maintainability, idiomaticity, Playwright tests, and documentation. Maintainability traced ownership and overlap across the current feature specs. Playwright specialists covered falsifiers, mock boundaries, flake risks, setup/teardown ownership, and executed-proof claims. Correctness traced connection suppression, save/reload, pin drag, and test isolation. All changed lines and the called fixture/storage boundaries were inspected. No lane was skipped.
Checks at this head:
pnpm typecheck:browser: pass.- Targeted ESLint: pass.
- Targeted Oxfmt: pass.
- Oxlint: pass, with unrelated baseline warnings.
pnpm fallow audit --base origin/main: pass, no issues in the changed file.- REST check rollup: 30 completed, 29 success, one neutral advisory, none pending or failing. All Chromium shards, mobile jobs, cloud Playwright, E2E rollup, and report merge are green.
The direct REST job-log archive was empty, so I could not audit per-test Playwright output. The exact-head job/check conclusions are green.
Addresses review feedback: #17460 (comment)
Addresses review feedback: #17460 (comment)
Addresses review feedback: #17460 (comment)
|
@christian-byrne Backport branch created but PR creation failed for |
|
@christian-byrne Successfully backported to #17600 |
239398abea.Full context for agent readers
The restoration case explicitly uses the legacy renderer and proves the retained seed value plus a visible, enabled, connection-unsuppressed widget row after direct source-node removal. The multiline case explicitly uses Vue Nodes and preserves newlines, Unicode, HTML-like text, ampersands, hashes, and percentages across save/reload. Existing owners remain
vueNodes/widgets/widgetValuePersistence.spec.ts,vueNodes/widgets/combo/comboWidget.spec.ts, andvueNodes/nodeStates/pin.spec.ts.Verification: Oxfmt, Oxlint, ESLint, browser typecheck, and Knip passed. Focused Chromium: 2/2. Mutating the expected restored visibility to false failed the restoration oracle. Logs:
/tmp/ecs-wake1/logs/pr-17460-static.log,pr-17460-targeted.log, andpr-17460-mutation.log.