Repository navigation
[backport core/1.57] FE-3381 fix(auth): report a revoked session as a warning and retry it once - #21324
Conversation
… once (#20967) ## Summary A revoked web session is an expected signed-out state. It no longer raises an error-level report, and workspace init gives up after one retry instead of three. Follow-up to #20834 after a Sentry alert on this state. **Why**: a user whose sign-in predates a sign-out gets `401 SESSION_REVOKED` ("This session was signed out; sign in again") and has to sign in again. That is normal, but it fired a new high-priority Sentry issue (`CLOUD-FRONTEND-PROD-2GP`: 3 events in the first hour, one browser, release 1.56.3, `error_type: workspace_auth_gate_initialization_failure`, level error), and the user waits through retries before seeing the sign-in screen. **Root cause**: #20834 made the gate stop offering Try again for a revoked session but left two things as they were: - `WorkspaceAuthGate` reports every init failure at the default `error` level, including `SessionRevokedError`. - `teamWorkspaceStore.initialize` retries any non-permanent failure with backoff (1s, 2s, 4s). The Sentry breadcrumbs show "Init failed (attempt 3/4)" for this refusal, so the panel appears about 7s late. A refusal that persists cannot succeed on a longer ladder. **How**: - The gate reports `SessionRevokedError` at `warning` level and everything else at `error`. - The report carries `failure_code` (`SESSION_REVOKED` or `TOKEN_REVOKED`) and `outcome: gave_up` tags, so the revoked cohort can be filtered without relying on the message text. - `teamWorkspaceStore` retries `SESSION_REVOKED` once (1s) and gives up on `TOKEN_REVOKED` immediately. A rotated cookie is revoked too, so a second tab holding it can be refused and recover on the next attempt (ingest `lockReplaceable` refuses on `RevokedAt` regardless of the reason). `TOKEN_REVOKED` is Firebase's own revocation list and cannot recover. - `readSessionError` maps `401 TOKEN_REVOKED` to the same typed error, so it takes the same non-retryable gate path. - `createSession()` no longer reports a revoked session, so the gate is the only reporter for it. - `SessionRevokedError` moves to `sessionRevokedError.ts` so the store can name it without importing the session cookie composable. Not changed: the server still requires a fresh sign-in, and the user lands on the existing "Sign out and log in again" panel. On the unified rail a revoked session already signs the user out and routes to sign-in; doing the same in the legacy gate is a separate change. Whether ingest should refuse a rotated cookie at all is a backend question. AS IS / TO BE - AS IS (`main` 3557c08): 4 session requests, 3 init retries, panel 7.10s after the first refusal, reported through `console.error` (level `error`). <img width="720" alt="AS IS recording: main, panel shown 7.10s after the first SESSION_REVOKED refusal, reportError at level error" src="https://github.com/user-attachments/assets/23f8e9ea-75fd-4ab1-aef2-fc9fd74636ba" /> <img width="720" alt="AS IS final frame: Couldn't load your workspace, Sign out and log in again to continue, reportError via console.error" src="https://github.com/user-attachments/assets/ab603190-2b94-4bfe-b671-ae4af41f0979" /> Real cloud app (local dev server on `local.comfy.org`, signed-in session against cloud.comfy.org). Only `POST /api/auth/session` was stubbed with an in-page `fetch` override returning `401 {"code":"SESSION_REVOKED","message":"This session was signed out; sign in again"}`; every other request was real. The overlay is injected by the same page script: it counts the stubbed requests and the store's "Init failed" warnings, timestamps the panel with a MutationObserver, and reads the `[Reported error]: workspace_auth_gate_initialization_failure` console line. - TO BE (earlier revision of this PR, b857d72, which failed on the first refusal and had no retry): 1 session request, no retries, panel in the same tick as the first refusal, reported through `console.warn` (level `warning`). The current revision retries `SESSION_REVOKED` once, so the panel appears about 1s after the first refusal; the recording has not been redone for that. <img width="720" alt="TO BE recording: PR 20967, panel shown with no retries right after the first SESSION_REVOKED refusal, reportError at level warning" src="https://github.com/user-attachments/assets/53bc792b-8ef8-4ba1-9c9d-2fb2d22fda50" /> <img width="720" alt="TO BE final frame: Couldn't load your workspace, Sign out and log in again to continue, reportError via console.warn" src="https://github.com/user-attachments/assets/d6df3c9d-7748-43d8-a157-9651111ffc82" /> Same browser, session, dev server and stub; only the worktree was switched from `main` to this branch between runs. Sentry and Datadog RUM are not live on a dev server, so the level comes from `reportError`'s console line, which picks `console.warn` or `console.error` from the same `level` option it passes to both sinks. The GIF frames are about 1s apart; the counter in the overlay gives the real timing. ## Verification - Tests: `pnpm test:unit src/platform/auth/session src/platform/workspace/auth src/platform/workspace/stores` (9 files, 555 tests). New: a table on the store (`SESSION_REVOKED` is tried twice, `TOKEN_REVOKED` once), the gate's report options per case (including the tags), `TOKEN_REVOKED` in the typed-error table, and `createSession` leaving a revoked session unreported. The five new cases fail against the previous revision of this PR. - Human QA: run in the real cloud app with the stubbed refusal above, on the earlier revision (see AS IS / TO BE): time to panel after the first refusal was 7.10s on `main` and 0.00s there; report level `error` on `main`, `warning` there. Not yet re-run on the current revision, which adds one 1s retry for `SESSION_REVOKED`. ## Plan position | Item | Ticket | PR | Status | | --- | --- | --- | --- | | Typed revoked error, no Try again | FE-3381 | 20834 | merged | | Warning-level report, one retry for a revoked session | FE-3381 | **this PR** | open | | Straight to sign-in instead of the panel | FE-3381 | not started | separate change | ```mermaid graph LR A["FE-3381: typed revoked error (PR 20834)"] --> B["FE-3381: warning level and one retry (this PR)"]:::current B --> C["Straight to sign-in (separate change)"] classDef current fill:#f9d71c,stroke:#333,stroke-width:2px ```
📦 Bundle Size
⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-18T23:57:29.124Z",
"gitSha": "aaaf13a326de559471067cefa2ca6891c2491c7a",
"branch": "backport-20967-to-core-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2015.5219999999758,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.3880000000000003,
"layouts": 9,
"layoutDurationMs": 2.496,
"taskDurationMs": 511.136,
"heapDeltaBytes": 22113040,
"heapUsedBytes": 87540824,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 8.254000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2022.6049999999987,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.7239999999999998,
"layouts": 10,
"layoutDurationMs": 2.846,
"taskDurationMs": 492.38,
"heapDeltaBytes": -876992,
"heapUsedBytes": 74518272,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 8.235,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1729.379999999992,
"styleRecalcs": 74,
"styleRecalcDurationMs": 13.863,
"layouts": 9,
"layoutDurationMs": 2.1870000000000003,
"taskDurationMs": 851.516,
"heapDeltaBytes": -3344372,
"heapUsedBytes": 72017504,
"domNodes": 0,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 160.01299999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846153,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1942.1740000000227,
"styleRecalcs": 82,
"styleRecalcDurationMs": 15.730999999999998,
"layouts": 9,
"layoutDurationMs": 2.414,
"taskDurationMs": 882.2019999999999,
"heapDeltaBytes": 15656964,
"heapUsedBytes": 81549240,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 159.935,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66581196581196,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1725.2110000000016,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.168000000000001,
"layouts": 12,
"layoutDurationMs": 3.2900000000000005,
"taskDurationMs": 380.79799999999994,
"heapDeltaBytes": -4509468,
"heapUsedBytes": 70134620,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 9.935000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1758.320000000026,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.313,
"layouts": 12,
"layoutDurationMs": 3.1420000000000003,
"taskDurationMs": 392.46500000000003,
"heapDeltaBytes": -4548788,
"heapUsedBytes": 70563428,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 9.663000000000002,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 631.2080000000151,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.7069999999999994,
"layouts": 9,
"layoutDurationMs": 2.4720000000000004,
"taskDurationMs": 466.67500000000007,
"heapDeltaBytes": 24765924,
"heapUsedBytes": 90909720,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 163.191,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684203,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 663.9209999999593,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.888,
"layouts": 9,
"layoutDurationMs": 2.4859999999999998,
"taskDurationMs": 487.904,
"heapDeltaBytes": 3538248,
"heapUsedBytes": 79093792,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 165.635,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.105263157894736,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1202.9379999999605,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 854.927,
"heapDeltaBytes": -11493336,
"heapUsedBytes": 81040828,
"domNodes": -192,
"jsHeapTotalBytes": 20455424,
"scriptDurationMs": 64.451,
"eventListeners": -106,
"totalBlockingTimeMs": 537,
"frameDurationMs": 33.333333333333336,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1201.1609999999564,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 838.7509999999999,
"heapDeltaBytes": -11287328,
"heapUsedBytes": 81615720,
"domNodes": -192,
"jsHeapTotalBytes": 21504000,
"scriptDurationMs": 71.42199999999998,
"eventListeners": -106,
"totalBlockingTimeMs": 524,
"frameDurationMs": 33.333333333333336,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 831.8610000000035,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 436.7569999999996,
"heapDeltaBytes": -4756800,
"heapUsedBytes": 76703496,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 155.30300000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 211,
"frameDurationMs": 24.5058823529412,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 849.807999999939,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.0379999999997,
"heapDeltaBytes": -5523292,
"heapUsedBytes": 75122804,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 158.61600000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 221,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10790.77700000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9890.172000000002,
"heapDeltaBytes": -15666112,
"heapUsedBytes": 71840340,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 8109.237999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 1155,
"frameDurationMs": 32.188059701492534,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 8464.890999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7685.531000000001,
"heapDeltaBytes": 504064,
"heapUsedBytes": 99555896,
"domNodes": -258,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 6447.964000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 439,
"frameDurationMs": 32.68803088803089,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10529.656999999987,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9747.552,
"heapDeltaBytes": -1063272,
"heapUsedBytes": 98411868,
"domNodes": -258,
"jsHeapTotalBytes": 13758464,
"scriptDurationMs": 8022.1489999999985,
"eventListeners": -68,
"totalBlockingTimeMs": 1023,
"frameDurationMs": 32.15993883792049,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8502.516999999898,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.33799999999999975,
"layouts": 1,
"layoutDurationMs": 0.3510000000000002,
"taskDurationMs": 7757.739,
"heapDeltaBytes": -7217168,
"heapUsedBytes": 91782932,
"domNodes": -258,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 6493.953,
"eventListeners": -64,
"totalBlockingTimeMs": 405,
"frameDurationMs": 33.332156862745094,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 216.12799999996923,
"styleRecalcs": 24,
"styleRecalcDurationMs": 14.597999999999999,
"layouts": 11,
"layoutDurationMs": 3.0629999999999997,
"taskDurationMs": 156.68300000000002,
"heapDeltaBytes": -8252524,
"heapUsedBytes": 79048008,
"domNodes": 917,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 8.045000000000002,
"eventListeners": 195,
"totalBlockingTimeMs": 1,
"frameDurationMs": 21.670000000000027,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 212.61200000003555,
"styleRecalcs": 24,
"styleRecalcDurationMs": 14.228000000000002,
"layouts": 11,
"layoutDurationMs": 2.9979999999999993,
"taskDurationMs": 160.03700000000003,
"heapDeltaBytes": -8139520,
"heapUsedBytes": 79304644,
"domNodes": 917,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 8.439000000000002,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.670000000000027,
"p95FrameDurationMs": 66.59999999999945
},
{
"name": "large-graph-idle",
"durationMs": 2055.796999999984,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.0159999999999996,
"layouts": 8,
"layoutDurationMs": 1.951,
"taskDurationMs": 613.7499999999999,
"heapDeltaBytes": -2069352,
"heapUsedBytes": 76455532,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 30.104999999999993,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665040650406507,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2023.984999999925,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.1329999999999996,
"layouts": 8,
"layoutDurationMs": 2.207,
"taskDurationMs": 604.5050000000001,
"heapDeltaBytes": -2216912,
"heapUsedBytes": 76421256,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 28.534000000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2360.459999999989,
"styleRecalcs": 68,
"styleRecalcDurationMs": 5.671,
"layouts": 7,
"layoutDurationMs": 1.6199999999999999,
"taskDurationMs": 1615.1169999999997,
"heapDeltaBytes": -11161748,
"heapUsedBytes": 68310096,
"domNodes": -258,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 772.7040000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66549295774648,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2225.9520000000066,
"styleRecalcs": 67,
"styleRecalcDurationMs": 5.853000000000001,
"layouts": 6,
"layoutDurationMs": 1.546,
"taskDurationMs": 1492.1309999999999,
"heapDeltaBytes": -11149856,
"heapUsedBytes": 68582852,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 800.0799999999999,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.791666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3474.9700000000416,
"styleRecalcs": 71,
"styleRecalcDurationMs": 7.187,
"layouts": 65,
"layoutDurationMs": 10.378,
"taskDurationMs": 1539.419,
"heapDeltaBytes": 7402328,
"heapUsedBytes": 88598380,
"domNodes": -234,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 754.494,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.746376811594203,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3589.3949999999677,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.1419999999999995,
"layouts": 63,
"layoutDurationMs": 10.207,
"taskDurationMs": 1747.1940000000002,
"heapDeltaBytes": -7238212,
"heapUsedBytes": 71874580,
"domNodes": -234,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 798.3249999999999,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666046511627908,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2896.3899999999967,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.501,
"layouts": 5,
"layoutDurationMs": 1.229,
"taskDurationMs": 1879.8819999999998,
"heapDeltaBytes": 12884716,
"heapUsedBytes": 95782948,
"domNodes": 0,
"jsHeapTotalBytes": 4874240,
"scriptDurationMs": 933.847,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76300578034682,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2623.9909999999327,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.6080000000000005,
"layouts": 5,
"layoutDurationMs": 1.2930000000000004,
"taskDurationMs": 1685.5319999999997,
"heapDeltaBytes": 3784072,
"heapUsedBytes": 86436852,
"domNodes": 0,
"jsHeapTotalBytes": 5730304,
"scriptDurationMs": 936.2349999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.881290322580647,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2026.721000000009,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.7230000000000005,
"layouts": 7,
"layoutDurationMs": 1.8149999999999997,
"taskDurationMs": 618.165,
"heapDeltaBytes": -3271488,
"heapUsedBytes": 77939696,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 30.694000000000006,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2019.9249999999438,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.2380000000000004,
"layouts": 8,
"layoutDurationMs": 1.981,
"taskDurationMs": 450.76899999999995,
"heapDeltaBytes": -2808884,
"heapUsedBytes": 78030196,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 28.240000000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 642.3770000000104,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.617000000000001,
"layouts": 9,
"layoutDurationMs": 2.41,
"taskDurationMs": 453.5319999999999,
"heapDeltaBytes": -1101344,
"heapUsedBytes": 75807032,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 143.414,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 589.0960000000405,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.875000000000001,
"layouts": 9,
"layoutDurationMs": 2.6490000000000005,
"taskDurationMs": 425.179,
"heapDeltaBytes": -1885928,
"heapUsedBytes": 74691908,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 141.28099999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66285714285715,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2020.8690000000047,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.423999999999999,
"layouts": 9,
"layoutDurationMs": 2.2249999999999996,
"taskDurationMs": 488.25600000000003,
"heapDeltaBytes": 21592784,
"heapUsedBytes": 88528224,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 7.353999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2009.84399999993,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.306999999999999,
"layouts": 8,
"layoutDurationMs": 2.6080000000000005,
"taskDurationMs": 347.556,
"heapDeltaBytes": 21640124,
"heapUsedBytes": 88547556,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 7.5329999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1692.265999999961,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.697999999999999,
"layouts": 9,
"layoutDurationMs": 2.6899999999999995,
"taskDurationMs": 778.575,
"heapDeltaBytes": 11293004,
"heapUsedBytes": 78149708,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 105.372,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1709.3790000000126,
"styleRecalcs": 78,
"styleRecalcDurationMs": 14.75,
"layouts": 9,
"layoutDurationMs": 2.5619999999999994,
"taskDurationMs": 776.3359999999999,
"heapDeltaBytes": -11377536,
"heapUsedBytes": 65938220,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 104.702,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1435.3189999999927,
"styleRecalcs": 19,
"styleRecalcDurationMs": 26.138999999999996,
"layouts": 5,
"layoutDurationMs": 16.27,
"taskDurationMs": 996.165,
"heapDeltaBytes": 9744884,
"heapUsedBytes": 104332564,
"domNodes": 15953,
"jsHeapTotalBytes": 16916480,
"scriptDurationMs": 26.838000000000008,
"eventListeners": 3244,
"totalBlockingTimeMs": 154,
"frameDurationMs": 19.594594594594593,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8253.993000000037,
"styleRecalcs": 249,
"styleRecalcDurationMs": 17.607999999999997,
"layouts": 6,
"layoutDurationMs": 1.3200000000000003,
"taskDurationMs": 4939.366,
"heapDeltaBytes": 8882048,
"heapUsedBytes": 87978848,
"domNodes": -258,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 2635.551,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.767479674796746,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9201.31600000002,
"styleRecalcs": 250,
"styleRecalcDurationMs": 17.784000000000002,
"layouts": 8,
"layoutDurationMs": 2.2079999999999997,
"taskDurationMs": 5845.276,
"heapDeltaBytes": -8325976,
"heapUsedBytes": 90134056,
"domNodes": -258,
"jsHeapTotalBytes": 5599232,
"scriptDurationMs": 2757.679,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666003616636527,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 22966.332000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22034.601000000002,
"heapDeltaBytes": -20184012,
"heapUsedBytes": 261274988,
"domNodes": -3330,
"jsHeapTotalBytes": 15192064,
"scriptDurationMs": 328.553,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.59637931034483,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-idle",
"durationMs": 15382.302999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14767.921000000002,
"heapDeltaBytes": -19003832,
"heapUsedBytes": 271073480,
"domNodes": -3330,
"jsHeapTotalBytes": 28565504,
"scriptDurationMs": 225.39499999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.116638370118846,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 27571.934999999998,
"styleRecalcs": 181,
"styleRecalcDurationMs": 14.796999999999978,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27165.838,
"heapDeltaBytes": -3772248,
"heapUsedBytes": 287169460,
"domNodes": -3330,
"jsHeapTotalBytes": 9355264,
"scriptDurationMs": 876.001,
"eventListeners": -651,
"totalBlockingTimeMs": 22,
"frameDurationMs": 50.42449725776965,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 18748.417999999903,
"styleRecalcs": 168,
"styleRecalcDurationMs": 12.513999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18292.138000000003,
"heapDeltaBytes": -9663556,
"heapUsedBytes": 294798012,
"domNodes": -3330,
"jsHeapTotalBytes": 18006016,
"scriptDurationMs": 861.7429999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 31,
"frameDurationMs": 32.97992957746479,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 8163.624999999967,
"styleRecalcs": 20,
"styleRecalcDurationMs": 70.21499999999997,
"layouts": 20,
"layoutDurationMs": 22.271999999999988,
"taskDurationMs": 7988.651,
"heapDeltaBytes": -9717460,
"heapUsedBytes": 281182540,
"domNodes": -3330,
"jsHeapTotalBytes": 19910656,
"scriptDurationMs": 118.24,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.66457142857143,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8114.957000000004,
"styleRecalcs": 20,
"styleRecalcDurationMs": 70.74899999999998,
"layouts": 20,
"layoutDurationMs": 22.056000000000004,
"taskDurationMs": 7974.893000000001,
"heapDeltaBytes": -6663436,
"heapUsedBytes": 274558196,
"domNodes": -3330,
"jsHeapTotalBytes": 18599936,
"scriptDurationMs": 123.58200000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 48.02544378698226,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11349.657999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10893.349,
"heapDeltaBytes": 27586460,
"heapUsedBytes": 282883396,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 145.02299999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.74195804195804,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11389.904999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10917.11,
"heapDeltaBytes": -9037584,
"heapUsedBytes": 269226016,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 148.011,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.717346938775506,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 463.10499999998456,
"styleRecalcs": 14,
"styleRecalcDurationMs": 13.117999999999999,
"layouts": 14,
"layoutDurationMs": 4.946000000000001,
"taskDurationMs": 127.691,
"heapDeltaBytes": -13190620,
"heapUsedBytes": 70484700,
"domNodes": 98,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 12.557,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66785714285715,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 477.0939999999655,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.999999999999998,
"layouts": 10,
"layoutDurationMs": 3.1069999999999993,
"taskDurationMs": 121.119,
"heapDeltaBytes": -13209364,
"heapUsedBytes": 70151012,
"domNodes": 95,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 10.331000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.257142857142867,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 449.971000000005,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.948,
"layouts": 76,
"layoutDurationMs": 14.033,
"taskDurationMs": 404.31600000000003,
"heapDeltaBytes": 11474208,
"heapUsedBytes": 82366816,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 198.524,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 391.83300000001964,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.9169999999999999,
"layouts": 76,
"layoutDurationMs": 13.756,
"taskDurationMs": 336.87899999999996,
"heapDeltaBytes": -15125292,
"heapUsedBytes": 80328568,
"domNodes": 4,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 160.237,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304356,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 475.6840000000011,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.796,
"layouts": 76,
"layoutDurationMs": 13.76,
"taskDurationMs": 443.81399999999996,
"heapDeltaBytes": -231256,
"heapUsedBytes": 118478592,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 176.981,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.24137931034483,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 533.8339999999562,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.9300000000000002,
"layouts": 76,
"layoutDurationMs": 13.811,
"taskDurationMs": 497.024,
"heapDeltaBytes": 17605128,
"heapUsedBytes": 188475580,
"domNodes": 4,
"jsHeapTotalBytes": 14942208,
"scriptDurationMs": 200.12099999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.18437499999999,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 64.8% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2276 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (11 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e9b9b5c4913a5542f69e7519df880ac9e69831c9
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.57 #21324 +/- ##
=============================================
- Coverage 87.20% 87.19% -0.01%
=============================================
Files 2624 2625 +1
Lines 147451 147473 +22
Branches 40498 38417 -2081
=============================================
+ Hits 128578 128594 +16
- Misses 18485 18491 +6
Partials 388 388
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 7 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #20967 to
core/1.57Automatically created by backport workflow.