Repository navigation
DESK2-183 fix(auth): tell Desktop users to finish sign-in in the browser, not that it was blocked - #21715
Conversation
…hat it was blocked Comfy Desktop intercepts the Firebase sign-in popup and finishes sign-in in the system browser, so Firebase raises auth/popup-blocked on every Desktop sign-in. Desktop hid the resulting toast by matching its old copy, which #14944 reworded, so users saw 'Your browser blocked the sign-in window' while sign-in succeeded. Inside Desktop, show the existing 'Finish signing in in your browser' info toast for that code instead.
|
Warning Review limit reached
This review includes 2 billable files and costs up to $0.50. Or wait 26 minutes for your next included review. View limit details
Comment |
📦 Bundle: 11.7 MB gzip 🔴 +123 BDetailsSummary
Category Glance App Entry Points — 6.8 kB (baseline 6.8 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 3.46 MB (baseline 3.46 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 2 unchanged Views & Navigation — 148 kB (baseline 148 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 6 added / 6 removed / 12 unchanged Panels & Settings — 835 kB (baseline 835 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 6 added / 6 removed / 29 unchanged User & Accounts — 149 kB (baseline 148 kB) • 🔴 +312 BAuthentication, profile, and account management bundles
Status: 4 added / 4 removed / 13 unchanged Editors & Dialogs — 248 kB (baseline 248 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 9 added / 9 removed / 6 unchanged UI Components — 230 kB (baseline 230 kB) • ⚪ 0 BReusable component library chunks
Status: 4 added / 4 removed / 26 unchanged Data & Services — 1.23 MB (baseline 1.23 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 4 added / 4 removed / 39 unchanged Utilities & Hooks — 996 kB (baseline 996 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 13 added / 13 removed / 61 unchanged Vendor & Third-Party — 24.7 MB (baseline 24.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 17 unchanged Other — 20.8 MB (baseline 20.8 MB) • ⚪ 0 BBundles that do not match a named category
Status: 62 added / 62 removed / 626 unchanged ⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-22T19:23:04.760Z",
"gitSha": "352b59b23d4b3736679bffb199ad2526b448be8f",
"branch": "dante/desktop-popup-blocked-toast",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.8440000000437,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.465,
"layouts": 10,
"layoutDurationMs": 2.205,
"taskDurationMs": 359.92999999999995,
"heapDeltaBytes": -12343744,
"heapUsedBytes": 93393804,
"domNodes": -200,
"jsHeapTotalBytes": 2232320,
"scriptDurationMs": 6.858999999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2008.4139999999024,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.2680000000000002,
"layouts": 10,
"layoutDurationMs": 2.7750000000000004,
"taskDurationMs": 282.31700000000006,
"heapDeltaBytes": -18081248,
"heapUsedBytes": 87943204,
"domNodes": -180,
"jsHeapTotalBytes": 2715648,
"scriptDurationMs": 7.0340000000000025,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1677.8150000000096,
"styleRecalcs": 71,
"styleRecalcDurationMs": 13.424000000000001,
"layouts": 10,
"layoutDurationMs": 2.555,
"taskDurationMs": 636.042,
"heapDeltaBytes": -4528692,
"heapUsedBytes": 101439036,
"domNodes": -180,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 110.23200000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66534653465347,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1693.0569999999534,
"styleRecalcs": 73,
"styleRecalcDurationMs": 12.473,
"layouts": 10,
"layoutDurationMs": 2.551,
"taskDurationMs": 574.879,
"heapDeltaBytes": -4287384,
"heapUsedBytes": 102240344,
"domNodes": -200,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 97.102,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.430999999995,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.565,
"layouts": 13,
"layoutDurationMs": 3.598,
"taskDurationMs": 251.50499999999997,
"heapDeltaBytes": -568904,
"heapUsedBytes": 105529312,
"domNodes": 56,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 9.777,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1710.0470000000314,
"styleRecalcs": 18,
"styleRecalcDurationMs": 3.54,
"layouts": 11,
"layoutDurationMs": 2.145,
"taskDurationMs": 222.83400000000003,
"heapDeltaBytes": -1890940,
"heapUsedBytes": 104673920,
"domNodes": 56,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 6.5219999999999985,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 516.5439999999535,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.762,
"layouts": 9,
"layoutDurationMs": 2.255,
"taskDurationMs": 316.517,
"heapDeltaBytes": 4096988,
"heapUsedBytes": 111336212,
"domNodes": 0,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 106.11,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664516129032254,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 428.14800000007835,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.6329999999999996,
"layouts": 9,
"layoutDurationMs": 2.2449999999999997,
"taskDurationMs": 308.032,
"heapDeltaBytes": 4921492,
"heapUsedBytes": 111241584,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 105.95900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669230769230754,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 891.0490000000664,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 513.1640000000001,
"heapDeltaBytes": 21727976,
"heapUsedBytes": 123361464,
"domNodes": 0,
"jsHeapTotalBytes": 16416768,
"scriptDurationMs": 37.47500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 287,
"frameDurationMs": 26.46764705882353,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 877.0009999999502,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 474.736,
"heapDeltaBytes": 21957652,
"heapUsedBytes": 119684036,
"domNodes": 0,
"jsHeapTotalBytes": 10125312,
"scriptDurationMs": 39.109,
"eventListeners": 0,
"totalBlockingTimeMs": 265,
"frameDurationMs": 25.979411764705887,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 701.8599999998969,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 292.51000000000005,
"heapDeltaBytes": -3248104,
"heapUsedBytes": 103194040,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 94.06,
"eventListeners": 0,
"totalBlockingTimeMs": 89,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 671.0779999999659,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 258.0359999999997,
"heapDeltaBytes": -3243884,
"heapUsedBytes": 103041720,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 84.121,
"eventListeners": 0,
"totalBlockingTimeMs": 81,
"frameDurationMs": 20.097058823529416,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6555.301999999983,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.04700000000000017,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5382.471,
"heapDeltaBytes": -10246276,
"heapUsedBytes": 101847784,
"domNodes": 0,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 4155.394,
"eventListeners": 0,
"totalBlockingTimeMs": 2,
"frameDurationMs": 20.204307692307687,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6619.880999999964,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.07599999999999968,
"layouts": 1,
"layoutDurationMs": 0.25300000000000017,
"taskDurationMs": 5453.273,
"heapDeltaBytes": -1932044,
"heapUsedBytes": 109752748,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 4175.7970000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.575443786982248,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6702.52499999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5517.858,
"heapDeltaBytes": -3470912,
"heapUsedBytes": 108652744,
"domNodes": 0,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 4341.5419999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 16,
"frameDurationMs": 20.80652173913044,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6384.476000000063,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5200.606,
"heapDeltaBytes": 83896,
"heapUsedBytes": 111887780,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 4050.9539999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.020125786163522,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-combo-open",
"durationMs": 134.8389999999995,
"styleRecalcs": 21,
"styleRecalcDurationMs": 10.732000000000001,
"layouts": 12,
"layoutDurationMs": 2.739,
"taskDurationMs": 95.388,
"heapDeltaBytes": 14506020,
"heapUsedBytes": 121018432,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.397000000000001,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.05714285714287,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "large-combo-open",
"durationMs": 134.6089999999549,
"styleRecalcs": 20,
"styleRecalcDurationMs": 10.374,
"layouts": 11,
"layoutDurationMs": 2.586,
"taskDurationMs": 100.72599999999998,
"heapDeltaBytes": 14513864,
"heapUsedBytes": 119046000,
"domNodes": 936,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.24,
"eventListeners": 205,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.41428571428573,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2030.0210000000334,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.8329999999999995,
"layouts": 7,
"layoutDurationMs": 1.474,
"taskDurationMs": 308.0539999999999,
"heapDeltaBytes": 11613656,
"heapUsedBytes": 104246888,
"domNodes": -276,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 29.686000000000003,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2027.3759999998902,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.3630000000000004,
"layouts": 9,
"layoutDurationMs": 2.085,
"taskDurationMs": 379.65400000000005,
"heapDeltaBytes": -33157916,
"heapUsedBytes": 97323092,
"domNodes": -296,
"jsHeapTotalBytes": -2519040,
"scriptDurationMs": 20.604,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2156.955999999923,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.421000000000001,
"layouts": 5,
"layoutDurationMs": 1.0220000000000002,
"taskDurationMs": 1034.18,
"heapDeltaBytes": 14951208,
"heapUsedBytes": 109409176,
"domNodes": 0,
"jsHeapTotalBytes": 1273856,
"scriptDurationMs": 520.654,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66589147286822,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "large-graph-pan",
"durationMs": 2068.704000000025,
"styleRecalcs": 67,
"styleRecalcDurationMs": 8.991000000000001,
"layouts": 5,
"layoutDurationMs": 1.0669999999999997,
"taskDurationMs": 989.711,
"heapDeltaBytes": 14964716,
"heapUsedBytes": 109393892,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 514.4409999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666400000000003,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3152.5870000000396,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.475999999999999,
"layouts": 64,
"layoutDurationMs": 10.687999999999999,
"taskDurationMs": 1119.99,
"heapDeltaBytes": 4383852,
"heapUsedBytes": 100389684,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 495.29100000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666137566137568,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3212.904999999978,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.298000000000002,
"layouts": 65,
"layoutDurationMs": 10.716,
"taskDurationMs": 1118.6059999999998,
"heapDeltaBytes": 1162920,
"heapUsedBytes": 95788244,
"domNodes": 24,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 501.692,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666321243523317,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2442.068000000063,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.330999999999999,
"layouts": 5,
"layoutDurationMs": 1.4389999999999998,
"taskDurationMs": 1369.5970000000002,
"heapDeltaBytes": -10868216,
"heapUsedBytes": 99864280,
"domNodes": -296,
"jsHeapTotalBytes": -4444160,
"scriptDurationMs": 656.2529999999999,
"eventListeners": 52,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.781379310344825,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2303.446000000008,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.005999999999999,
"layouts": 6,
"layoutDurationMs": 1.5119999999999998,
"taskDurationMs": 1252.565,
"heapDeltaBytes": -31425340,
"heapUsedBytes": 101222096,
"domNodes": -296,
"jsHeapTotalBytes": -1273856,
"scriptDurationMs": 616.3570000000001,
"eventListeners": 52,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665942028985505,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2032.2869999999966,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.5920000000000005,
"layouts": 7,
"layoutDurationMs": 1.398,
"taskDurationMs": 365.76500000000004,
"heapDeltaBytes": -24234292,
"heapUsedBytes": 105297288,
"domNodes": -276,
"jsHeapTotalBytes": -6127616,
"scriptDurationMs": 25.188000000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "minimap-idle",
"durationMs": 2028.838999999948,
"styleRecalcs": 8,
"styleRecalcDurationMs": 1.784,
"layouts": 8,
"layoutDurationMs": 1.5729999999999997,
"taskDurationMs": 326.30300000000005,
"heapDeltaBytes": 11613332,
"heapUsedBytes": 105337716,
"domNodes": -296,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 18.641,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 399.47800000004463,
"styleRecalcs": 49,
"styleRecalcDurationMs": 5.049999999999999,
"layouts": 10,
"layoutDurationMs": 2.309,
"taskDurationMs": 252.83,
"heapDeltaBytes": 388104,
"heapUsedBytes": 108297684,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 95.041,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 413.7680000000046,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.194000000000001,
"layouts": 10,
"layoutDurationMs": 2.534,
"taskDurationMs": 280.215,
"heapDeltaBytes": -119108,
"heapUsedBytes": 107953048,
"domNodes": 0,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 92.008,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667999999999992,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2009.1750000000275,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.091,
"layouts": 11,
"layoutDurationMs": 2.848,
"taskDurationMs": 292.53799999999995,
"heapDeltaBytes": -21633548,
"heapUsedBytes": 85308704,
"domNodes": -222,
"jsHeapTotalBytes": 3502080,
"scriptDurationMs": 8.105,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2009.5800000000281,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.4479999999999995,
"layouts": 10,
"layoutDurationMs": 2.0879999999999996,
"taskDurationMs": 274.619,
"heapDeltaBytes": 227296,
"heapUsedBytes": 108809348,
"domNodes": -222,
"jsHeapTotalBytes": 2453504,
"scriptDurationMs": 6.787,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.833000000017,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.145,
"layouts": 10,
"layoutDurationMs": 2.5039999999999996,
"taskDurationMs": 519.602,
"heapDeltaBytes": -1359884,
"heapUsedBytes": 105140620,
"domNodes": -222,
"jsHeapTotalBytes": 4550656,
"scriptDurationMs": 80.728,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1693.9889999999878,
"styleRecalcs": 75,
"styleRecalcDurationMs": 11.431000000000001,
"layouts": 11,
"layoutDurationMs": 2.1710000000000003,
"taskDurationMs": 527.602,
"heapDeltaBytes": -5865984,
"heapUsedBytes": 100446652,
"domNodes": -202,
"jsHeapTotalBytes": 4067328,
"scriptDurationMs": 71.63399999999999,
"eventListeners": -177,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 819.342000000006,
"styleRecalcs": 19,
"styleRecalcDurationMs": 15.880999999999998,
"layouts": 5,
"layoutDurationMs": 9.503999999999998,
"taskDurationMs": 638.3689999999999,
"heapDeltaBytes": 13802876,
"heapUsedBytes": 144003984,
"domNodes": 16030,
"jsHeapTotalBytes": 16392192,
"scriptDurationMs": 17.322000000000003,
"eventListeners": 3246,
"totalBlockingTimeMs": 68,
"frameDurationMs": 19.44285714285715,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8128.301999999962,
"styleRecalcs": 250,
"styleRecalcDurationMs": 33.653,
"layouts": 8,
"layoutDurationMs": 1.818,
"taskDurationMs": 3645.006,
"heapDeltaBytes": -18053568,
"heapUsedBytes": 109644376,
"domNodes": -296,
"jsHeapTotalBytes": -4067328,
"scriptDurationMs": 1788.448,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665913757700206,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8217.789999999923,
"styleRecalcs": 252,
"styleRecalcDurationMs": 34.677,
"layouts": 9,
"layoutDurationMs": 2.1609999999999996,
"taskDurationMs": 3764.2920000000004,
"heapDeltaBytes": -19485852,
"heapUsedBytes": 108959840,
"domNodes": -296,
"jsHeapTotalBytes": -4591616,
"scriptDurationMs": 1819.7430000000002,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665720081135902,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16289.04,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15351.494999999999,
"heapDeltaBytes": -25339680,
"heapUsedBytes": 291307000,
"domNodes": -3347,
"jsHeapTotalBytes": 25153536,
"scriptDurationMs": 206.424,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.767120954003406,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-idle",
"durationMs": 14983.144000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14159.107999999998,
"heapDeltaBytes": -14712184,
"heapUsedBytes": 296313168,
"domNodes": -3343,
"jsHeapTotalBytes": 27250688,
"scriptDurationMs": 182.893,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.714948453608248,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 17977.999999999953,
"styleRecalcs": 137,
"styleRecalcDurationMs": 17.237000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17656.691000000003,
"heapDeltaBytes": -12737400,
"heapUsedBytes": 298826676,
"domNodes": -3343,
"jsHeapTotalBytes": 24891392,
"scriptDurationMs": 635.1129999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 2,
"frameDurationMs": 33.42509293680298,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 17760.868999999955,
"styleRecalcs": 155,
"styleRecalcDurationMs": 16.230999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17411.2,
"heapDeltaBytes": -1593696,
"heapUsedBytes": 314203028,
"domNodes": -3343,
"jsHeapTotalBytes": 20172800,
"scriptDurationMs": 622.802,
"eventListeners": -651,
"totalBlockingTimeMs": 1,
"frameDurationMs": 33.30075046904315,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5947.914999999966,
"styleRecalcs": 20,
"styleRecalcDurationMs": 46.00599999999999,
"layouts": 20,
"layoutDurationMs": 23.63599999999999,
"taskDurationMs": 5826.938999999999,
"heapDeltaBytes": -11456324,
"heapUsedBytes": 304716884,
"domNodes": -3343,
"jsHeapTotalBytes": 23842816,
"scriptDurationMs": 82.66999999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.627544910179644,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5742.211999999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 41.95199999999999,
"layouts": 20,
"layoutDurationMs": 21.15700000000001,
"taskDurationMs": 5630.46,
"heapDeltaBytes": -28543172,
"heapUsedBytes": 297117972,
"domNodes": -3343,
"jsHeapTotalBytes": 25677824,
"scriptDurationMs": 85.585,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.52748538011696,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8241.614000000027,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7889.222000000002,
"heapDeltaBytes": -18814568,
"heapUsedBytes": 284273268,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 108.72199999999992,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.389655172413793,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7305.090000000064,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7029.135000000002,
"heapDeltaBytes": -4170660,
"heapUsedBytes": 310475228,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 83.89200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.38766666666667,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "workflow-execution",
"durationMs": 82.12400000002162,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.312999999999999,
"layouts": 5,
"layoutDurationMs": 2.496,
"taskDurationMs": 59.07,
"heapDeltaBytes": 4827956,
"heapUsedBytes": 107629428,
"domNodes": 105,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.110000000000001,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.659999999999947,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 75.06100000000515,
"styleRecalcs": 5,
"styleRecalcDurationMs": 6.596000000000001,
"layouts": 4,
"layoutDurationMs": 1.21,
"taskDurationMs": 54.794999999999995,
"heapDeltaBytes": 4636596,
"heapUsedBytes": 108876468,
"domNodes": 98,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 4.324,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.660000000000036,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 198.61700000001292,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.584,
"layouts": 76,
"layoutDurationMs": 9.799000000000001,
"taskDurationMs": 155.924,
"heapDeltaBytes": 9214228,
"heapUsedBytes": 97406092,
"domNodes": 4,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 65.27199999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 193.2409999999436,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.683,
"layouts": 76,
"layoutDurationMs": 10.048,
"taskDurationMs": 159.164,
"heapDeltaBytes": 9378304,
"heapUsedBytes": 97059728,
"domNodes": 4,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 66.944,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 233.81800000004205,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.193,
"layouts": 76,
"layoutDurationMs": 9.189,
"taskDurationMs": 191.33800000000002,
"heapDeltaBytes": -2241464,
"heapUsedBytes": 116073824,
"domNodes": 4,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 61.259,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66428571428573,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 212.48700000001008,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.231,
"layouts": 76,
"layoutDurationMs": 8.98,
"taskDurationMs": 181.649,
"heapDeltaBytes": -2499412,
"heapUsedBytes": 119584596,
"domNodes": 4,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 57.065999999999995,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669230769230754,
"p95FrameDurationMs": 16.700000000000273
}
]
}🔬 E2E CoverageLine coverage: 64.2% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3054 passed, 0 failed · 3 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since dcf5a69655bb927db72ab5b292948d8f3e3a89b9
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (150)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #21715 +/- ##
==========================================
+ Coverage 86.67% 87.62% +0.95%
==========================================
Files 3894 2735 -1159
Lines 181820 151418 -30402
Branches 49851 41217 -8634
==========================================
- Hits 157584 132685 -24899
+ Misses 21820 18097 -3723
+ Partials 2416 636 -1780
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1166 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Approved at full head 791b09e27c6b08c265130969f4f690a7cf267c94.
Full context for agent readers
The Desktop-only branch matches the host contract: only auth/popup-blocked becomes the existing browser-continuation info toast. Other popup dismissals and non-Desktop behavior remain unchanged. The focused regression coverage proves both sides, all review threads are clear, and CI is settled green.
|
@dante01yoon Successfully backported to #21762 |
|
@dante01yoon Successfully backported to #21763 |
|
|
…h sign-in in the browser, not that it was blocked (#21715) (#21794) Backport of #21715 to core/1.57. ## Why Same fix as #21715, needed on this release branch. ## Root cause / How See #21715. Cherry-picked from its merge commit. ## AS IS / TO BE See #21715. ## Conflicts - src/composables/auth/useAuthActions.test.ts: import conflict only. Kept both the target `computed` import and the added `afterEach` import.
…sh sign-in in the browser, not that it was blocked (#21715) (#21795) Backport of #21715 to cloud/1.57. ## Why Same fix as #21715, needed on this release branch. ## Root cause / How See #21715. Cherry-picked from its merge commit. ## AS IS / TO BE See #21715. ## Conflicts - src/composables/auth/useAuthActions.test.ts: import conflict only. Kept both the target `computed` import and the added `afterEach` import.
|
|
|
|
Summary
Inside Comfy Desktop, every Firebase sign-in showed "Your browser blocked the sign-in window. Please allow pop-ups for this site and try again." even though sign-in finished fine. Inside Desktop that code now shows the existing "Finish signing in in your browser" info toast.
Why
The warning is wrong in Desktop. The browser didn't block anything: Desktop opened the system browser on purpose. Users go looking for a pop-up setting that isn't the problem.
Root cause
setWindowOpenHandlerintercepts the Firebase__/auth/handlerpopup in every comfy view (local and Cloud) and finishes sign-in in the system browser.window.openreturns null, so Firebase rejects withauth/popup-blockedon every Desktop sign-in.COMFY_CLOUD_PATCHES_JSin Comfy-Desktopsrc/main/host/attach.ts, Comfy-Desktop#853):auth/popup-blockedor "signing you in".auth/popup-blockedits own copy ("Your browser blocked the sign-in window…"). That no longer matches, so the toast shows. The matcher only runs on Cloud views and only matches English text. In local views and other locales it never hid anything.How
useAuthActions.reportError, whenwindow.__comfyDesktop2is present and the code isauth/popup-blocked, showauth.desktopHost.continueInBrowseras an info toast. That is the same toast and copy the Desktop-hosted SSO sign-in already uses.auth/popup-closed-by-userandauth/cancelled-popup-requeststill warn. Those come from the user, not from Desktop.Verification
pnpm test:unit src/composables/auth/useAuthActions.test.ts: 59 passed.mainand passes with the fix. Checked by running it against the unfixed file.main.json, which this PR doesn't touch. The Desktop SSO PRs (FE-3267 feat(auth): sign the Desktop-hosted local view in with Desktop's account session #20383, FE-3297 feat(auth): switch workspaces in the Desktop-hosted view #20484) are merged and use separate code (desktopHost/*,SignInContent).AS IS / TO BE
AS IS (main,
window.__comfyDesktop2set, real Chromium popup block):TO BE (this branch, same setup):