Repository navigation
fix: create restored above-max DynamicGroups on followers - #21280
Conversation
📦 Bundle: 11.6 MB gzip 🔴 +245 BDetailsSummary
Category Glance App Entry Points — 6.92 kB (baseline 6.92 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 3.4 MB (baseline 3.4 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 3 added / 3 removed / 1 unchanged Views & Navigation — 147 kB (baseline 147 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 12 added / 12 removed / 6 unchanged Panels & Settings — 783 kB (baseline 783 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 14 added / 14 removed / 20 unchanged User & Accounts — 155 kB (baseline 155 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 9 added / 9 removed / 8 unchanged Editors & Dialogs — 366 kB (baseline 366 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 9 added / 9 removed / 4 unchanged UI Components — 225 kB (baseline 225 kB) • ⚪ 0 BReusable component library chunks
Status: 8 added / 8 removed / 22 unchanged Data & Services — 1.21 MB (baseline 1.21 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 36 added / 36 removed / 7 unchanged Utilities & Hooks — 1.02 MB (baseline 1.02 MB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 40 added / 40 removed / 37 unchanged Vendor & Third-Party — 24.7 MB (baseline 24.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 17 unchanged Other — 20.6 MB (baseline 20.6 MB) • 🔴 +328 BBundles that do not match a named category
Status: 107 added / 107 removed / 580 unchanged ⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-20T03:23:05.269Z",
"gitSha": "24cb6dfb560330ffdeb2cddc04bfb7e8cc0a31cf",
"branch": "jaeone94/dynamic-group-remote-create-max",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2046.5940000000273,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.4739999999999998,
"layouts": 8,
"layoutDurationMs": 2.352,
"taskDurationMs": 562.1320000000001,
"heapDeltaBytes": -6183188,
"heapUsedBytes": 91041432,
"domNodes": -200,
"jsHeapTotalBytes": -1847296,
"scriptDurationMs": 8.675000000000002,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2024.7249999999894,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.182,
"layouts": 9,
"layoutDurationMs": 2.882,
"taskDurationMs": 442.96399999999994,
"heapDeltaBytes": -21481104,
"heapUsedBytes": 86573800,
"domNodes": -200,
"jsHeapTotalBytes": 2441216,
"scriptDurationMs": 10.069999999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1809.0349999999944,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.118,
"layouts": 10,
"layoutDurationMs": 2.9890000000000003,
"taskDurationMs": 925.519,
"heapDeltaBytes": -13749080,
"heapUsedBytes": 98883040,
"domNodes": -209,
"jsHeapTotalBytes": 3022848,
"scriptDurationMs": 161.289,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665740740740738,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1992.902000000072,
"styleRecalcs": 83,
"styleRecalcDurationMs": 13.406999999999998,
"layouts": 9,
"layoutDurationMs": 2.28,
"taskDurationMs": 1094.003,
"heapDeltaBytes": -3797008,
"heapUsedBytes": 100420652,
"domNodes": -180,
"jsHeapTotalBytes": 1974272,
"scriptDurationMs": 156.102,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66583333333333,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.087000000025,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.329,
"layouts": 11,
"layoutDurationMs": 3.9899999999999998,
"taskDurationMs": 461.02400000000006,
"heapDeltaBytes": 130016,
"heapUsedBytes": 97575904,
"domNodes": 49,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 14.288999999999996,
"eventListeners": 42,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1780.9140000000525,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.2860000000000005,
"layouts": 10,
"layoutDurationMs": 2.8559999999999994,
"taskDurationMs": 456.784,
"heapDeltaBytes": 235228,
"heapUsedBytes": 106489324,
"domNodes": 49,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 12.218,
"eventListeners": 42,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 634.3360000000189,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.698000000000001,
"layouts": 9,
"layoutDurationMs": 2.4099999999999997,
"taskDurationMs": 486,
"heapDeltaBytes": 1283296,
"heapUsedBytes": 98459232,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 170.108,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736838,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 652.2889999999961,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.093,
"layouts": 10,
"layoutDurationMs": 2.8420000000000005,
"taskDurationMs": 490.3070000000001,
"heapDeltaBytes": 4724540,
"heapUsedBytes": 111013928,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 166.161,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1152.5669999999764,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 781.31,
"heapDeltaBytes": 22299708,
"heapUsedBytes": 124755476,
"domNodes": 0,
"jsHeapTotalBytes": 14843904,
"scriptDurationMs": 69.869,
"eventListeners": 0,
"totalBlockingTimeMs": 532,
"frameDurationMs": 34.84848484848485,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1146.3959999999815,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 782.8900000000001,
"heapDeltaBytes": 21940628,
"heapUsedBytes": 122378340,
"domNodes": 0,
"jsHeapTotalBytes": 14581760,
"scriptDurationMs": 63.527000000000015,
"eventListeners": 0,
"totalBlockingTimeMs": 522,
"frameDurationMs": 33.82058823529411,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 844.0719999999828,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.9460000000004,
"heapDeltaBytes": -3564096,
"heapUsedBytes": 103676780,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 159.993,
"eventListeners": 0,
"totalBlockingTimeMs": 221,
"frameDurationMs": 24.997058823529454,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.8679999999486,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.3409999999998,
"heapDeltaBytes": -3331532,
"heapUsedBytes": 102807244,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 158.468,
"eventListeners": 0,
"totalBlockingTimeMs": 215,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10140.976000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9270.319000000001,
"heapDeltaBytes": 2499592,
"heapUsedBytes": 114032408,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 7786.094,
"eventListeners": 0,
"totalBlockingTimeMs": 1236,
"frameDurationMs": 32.06613924050633,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10662.55000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9732.110999999999,
"heapDeltaBytes": 11691024,
"heapUsedBytes": 123794656,
"domNodes": 0,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 8292.332999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1342,
"frameDurationMs": 31.601186943620178,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10573.71599999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9877.178,
"heapDeltaBytes": 18655952,
"heapUsedBytes": 129301504,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 8010.349,
"eventListeners": 0,
"totalBlockingTimeMs": 1178,
"frameDurationMs": 30.944152046783625,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9581.611000000066,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8777.313000000002,
"heapDeltaBytes": 10037632,
"heapUsedBytes": 121576100,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 7356.513000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 800,
"frameDurationMs": 31.943000000000005,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 224.7600000000034,
"styleRecalcs": 21,
"styleRecalcDurationMs": 14.523000000000001,
"layouts": 11,
"layoutDurationMs": 2.8569999999999998,
"taskDurationMs": 169.573,
"heapDeltaBytes": -8058972,
"heapUsedBytes": 96399044,
"domNodes": 927,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.668,
"eventListeners": 205,
"totalBlockingTimeMs": 10,
"frameDurationMs": 29.162500000000023,
"p95FrameDurationMs": 116.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 227.70100000002458,
"styleRecalcs": 21,
"styleRecalcDurationMs": 14.802000000000001,
"layouts": 11,
"layoutDurationMs": 3.656,
"taskDurationMs": 166.39200000000002,
"heapDeltaBytes": 15004296,
"heapUsedBytes": 120353860,
"domNodes": 927,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 9.685,
"eventListeners": 205,
"totalBlockingTimeMs": 7,
"frameDurationMs": 29.149999999999977,
"p95FrameDurationMs": 116.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2090.3659999999036,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.8199999999999994,
"layouts": 8,
"layoutDurationMs": 3.005,
"taskDurationMs": 696.5469999999999,
"heapDeltaBytes": -29767192,
"heapUsedBytes": 99744952,
"domNodes": -277,
"jsHeapTotalBytes": -1593344,
"scriptDurationMs": 34.364,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665599999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2014.2959999999448,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.739000000000001,
"layouts": 3,
"layoutDurationMs": 0.8770000000000002,
"taskDurationMs": 426.86099999999993,
"heapDeltaBytes": 13027588,
"heapUsedBytes": 105730280,
"domNodes": -296,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 35.30899999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2706.456000000003,
"styleRecalcs": 63,
"styleRecalcDurationMs": 7.399000000000001,
"layouts": 2,
"layoutDurationMs": 0.5449999999999995,
"taskDurationMs": 1715.1609999999996,
"heapDeltaBytes": 16185700,
"heapUsedBytes": 109776524,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 832.196,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.769565217391303,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2438.068000000044,
"styleRecalcs": 63,
"styleRecalcDurationMs": 6.96,
"layouts": 2,
"layoutDurationMs": 0.5599999999999997,
"taskDurationMs": 1617.137,
"heapDeltaBytes": 15586780,
"heapUsedBytes": 108990284,
"domNodes": 0,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 775.487,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665753424657538,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3925.664000000097,
"styleRecalcs": 66,
"styleRecalcDurationMs": 8.497000000000002,
"layouts": 60,
"layoutDurationMs": 9.263999999999998,
"taskDurationMs": 1848.524,
"heapDeltaBytes": 3810672,
"heapUsedBytes": 99004304,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 819.689,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66553191489362,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3703.0560000000605,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.419,
"layouts": 64,
"layoutDurationMs": 9.727,
"taskDurationMs": 1757.387,
"heapDeltaBytes": 1561568,
"heapUsedBytes": 115726340,
"domNodes": -278,
"jsHeapTotalBytes": -4603904,
"scriptDurationMs": 756.654,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.817727272727275,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3089.4140000000334,
"styleRecalcs": 41,
"styleRecalcDurationMs": 4.0280000000000005,
"layouts": 1,
"layoutDurationMs": 0.392,
"taskDurationMs": 1981.2569999999998,
"heapDeltaBytes": 19177612,
"heapUsedBytes": 116173908,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 964.452,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.94065934065934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2950.741999999991,
"styleRecalcs": 39,
"styleRecalcDurationMs": 3.501000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1878.8489999999997,
"heapDeltaBytes": 19928768,
"heapUsedBytes": 115469568,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 913.37,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.760795454545452,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2074.840999999992,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.393000000000001,
"layouts": 7,
"layoutDurationMs": 2.3489999999999998,
"taskDurationMs": 755.611,
"heapDeltaBytes": -29783060,
"heapUsedBytes": 100149648,
"domNodes": -276,
"jsHeapTotalBytes": -2207744,
"scriptDurationMs": 37.959,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665599999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2011.3890000000083,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.6050000000000005,
"layouts": 2,
"layoutDurationMs": 0.5419999999999995,
"taskDurationMs": 414.34400000000005,
"heapDeltaBytes": 12575532,
"heapUsedBytes": 105735752,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 31.669000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 625.065999999947,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.564999999999999,
"layouts": 10,
"layoutDurationMs": 2.824,
"taskDurationMs": 464.74999999999994,
"heapDeltaBytes": -123084,
"heapUsedBytes": 109814356,
"domNodes": 0,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 148.488,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 614.2360000000053,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.3420000000000005,
"layouts": 10,
"layoutDurationMs": 3.0939999999999994,
"taskDurationMs": 456.34000000000003,
"heapDeltaBytes": -523296,
"heapUsedBytes": 105738860,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 148.582,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2058.3709999999655,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.083999999999999,
"layouts": 10,
"layoutDurationMs": 3.0810000000000004,
"taskDurationMs": 611.115,
"heapDeltaBytes": -16131328,
"heapUsedBytes": 98240292,
"domNodes": -218,
"jsHeapTotalBytes": 2916352,
"scriptDurationMs": 10.126000000000001,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66532258064516,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2054.4900000001007,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.471,
"layouts": 9,
"layoutDurationMs": 2.488,
"taskDurationMs": 558.6529999999999,
"heapDeltaBytes": 7747088,
"heapUsedBytes": 105989148,
"domNodes": -218,
"jsHeapTotalBytes": -2482176,
"scriptDurationMs": 7.671000000000001,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 2008.3829999999807,
"styleRecalcs": 87,
"styleRecalcDurationMs": 15.238000000000001,
"layouts": 9,
"layoutDurationMs": 2.429,
"taskDurationMs": 1139.458,
"heapDeltaBytes": -6010480,
"heapUsedBytes": 92605236,
"domNodes": -199,
"jsHeapTotalBytes": -1323008,
"scriptDurationMs": 120.541,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1993.6529999999948,
"styleRecalcs": 86,
"styleRecalcDurationMs": 15.166,
"layouts": 9,
"layoutDurationMs": 2.587,
"taskDurationMs": 957.557,
"heapDeltaBytes": 1928664,
"heapUsedBytes": 107691548,
"domNodes": -198,
"jsHeapTotalBytes": 3379200,
"scriptDurationMs": 109.568,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1469.116999999983,
"styleRecalcs": 18,
"styleRecalcDurationMs": 27.060999999999996,
"layouts": 5,
"layoutDurationMs": 17.363,
"taskDurationMs": 1160.934,
"heapDeltaBytes": 19101880,
"heapUsedBytes": 180449336,
"domNodes": 16030,
"jsHeapTotalBytes": 41295872,
"scriptDurationMs": 30.692999999999998,
"eventListeners": 3244,
"totalBlockingTimeMs": 165,
"frameDurationMs": 20.31780821917807,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8318.123000000014,
"styleRecalcs": 249,
"styleRecalcDurationMs": 30.485000000000003,
"layouts": 6,
"layoutDurationMs": 2.1710000000000003,
"taskDurationMs": 5426.483,
"heapDeltaBytes": -2813968,
"heapUsedBytes": 109353080,
"domNodes": -297,
"jsHeapTotalBytes": -3641344,
"scriptDurationMs": 2736.914,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73326612903226,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8219.907000000036,
"styleRecalcs": 248,
"styleRecalcDurationMs": 27.898,
"layouts": 5,
"layoutDurationMs": 1.3039999999999996,
"taskDurationMs": 5152.976,
"heapDeltaBytes": -2905860,
"heapUsedBytes": 109179044,
"domNodes": -296,
"jsHeapTotalBytes": -4952064,
"scriptDurationMs": 2634.6269999999995,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666056910569107,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 23096.947,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22597.941,
"heapDeltaBytes": -33679548,
"heapUsedBytes": 296338576,
"domNodes": -3343,
"jsHeapTotalBytes": 14405632,
"scriptDurationMs": 314.32,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.28342059336824,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-large-graph-idle",
"durationMs": 16364.634000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15429.303000000002,
"heapDeltaBytes": -23267196,
"heapUsedBytes": 290938304,
"domNodes": -3343,
"jsHeapTotalBytes": 6541312,
"scriptDurationMs": 240.13199999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.072041166380785,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-large-graph-pan",
"durationMs": 28243.055000000026,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.268000000000008,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27852.415999999997,
"heapDeltaBytes": -1280476,
"heapUsedBytes": 308435748,
"domNodes": -3343,
"jsHeapTotalBytes": 16502784,
"scriptDurationMs": 879.593,
"eventListeners": -651,
"totalBlockingTimeMs": 19,
"frameDurationMs": 52.801495327102806,
"p95FrameDurationMs": 116.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 27886.991999999962,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.272000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27558.167,
"heapDeltaBytes": 4074316,
"heapUsedBytes": 314983180,
"domNodes": -3347,
"jsHeapTotalBytes": 10928128,
"scriptDurationMs": 878.297,
"eventListeners": -651,
"totalBlockingTimeMs": 37,
"frameDurationMs": 52.41015037593985,
"p95FrameDurationMs": 116.60000000000036
},
{
"name": "vue-node-resize-workload",
"durationMs": 8265.173000000004,
"styleRecalcs": 20,
"styleRecalcDurationMs": 73.522,
"layouts": 20,
"layoutDurationMs": 22.599000000000007,
"taskDurationMs": 8168.422,
"heapDeltaBytes": -17928216,
"heapUsedBytes": 307186908,
"domNodes": -3343,
"jsHeapTotalBytes": 20959232,
"scriptDurationMs": 121.52300000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.50747126436782,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8110.904000000005,
"styleRecalcs": 20,
"styleRecalcDurationMs": 88.74100000000001,
"layouts": 20,
"layoutDurationMs": 22.032999999999998,
"taskDurationMs": 7978.254000000001,
"heapDeltaBytes": -20402380,
"heapUsedBytes": 289597088,
"domNodes": -3343,
"jsHeapTotalBytes": 16764928,
"scriptDurationMs": 118.00899999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 10,
"frameDurationMs": 47.187790697674416,
"p95FrameDurationMs": 99.89999999999782
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8249.525000000063,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7678.588999999999,
"heapDeltaBytes": 10627556,
"heapUsedBytes": 305182940,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 120.865,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.252054794520557,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11292.911000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10759.431999999999,
"heapDeltaBytes": 14803128,
"heapUsedBytes": 304602936,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 144.81499999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.906551724137934,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 479.21400000007,
"styleRecalcs": 18,
"styleRecalcDurationMs": 10.654,
"layouts": 12,
"layoutDurationMs": 4.798,
"taskDurationMs": 124.235,
"heapDeltaBytes": 7391260,
"heapUsedBytes": 109120836,
"domNodes": 136,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 15.369999999999997,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 120.45799999998508,
"styleRecalcs": 8,
"styleRecalcDurationMs": 9.604000000000001,
"layouts": 8,
"layoutDurationMs": 4.0089999999999995,
"taskDurationMs": 95.79799999999999,
"heapDeltaBytes": -14569416,
"heapUsedBytes": 100034808,
"domNodes": 132,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 6.947999999999998,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428546,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 433.74999999991815,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6,
"layouts": 76,
"layoutDurationMs": 14.445,
"taskDurationMs": 394.309,
"heapDeltaBytes": -14942100,
"heapUsedBytes": 78343784,
"domNodes": 4,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 189.468,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66296296296295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 417.04299999992145,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.713,
"layouts": 76,
"layoutDurationMs": 14.112,
"taskDurationMs": 375.219,
"heapDeltaBytes": -15253408,
"heapUsedBytes": 79731348,
"domNodes": 4,
"jsHeapTotalBytes": 1835008,
"scriptDurationMs": 176.413,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663999999999977,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 495.4219999999623,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.63,
"layouts": 76,
"layoutDurationMs": 14.712,
"taskDurationMs": 467.461,
"heapDeltaBytes": 324748,
"heapUsedBytes": 118665488,
"domNodes": 4,
"jsHeapTotalBytes": 958464,
"scriptDurationMs": 189.221,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.216666666666665,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 540.7369999998082,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.621,
"layouts": 76,
"layoutDurationMs": 14.6,
"taskDurationMs": 512.4100000000001,
"heapDeltaBytes": -3809460,
"heapUsedBytes": 104692652,
"domNodes": 4,
"jsHeapTotalBytes": 958464,
"scriptDurationMs": 203.40900000000002,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.1875,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E CoverageLine coverage: 64.0% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2942 passed, 0 failed · 9 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since c0a123ec3b0af4990c818863f862bf8ffd975f41
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (112)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #21280 +/- ##
==========================================
+ Coverage 86.50% 87.45% +0.95%
==========================================
Files 3875 2712 -1163
Lines 180307 150187 -30120
Branches 49816 41740 -8076
==========================================
- Hits 155968 131352 -24616
+ Misses 22073 18312 -3761
+ Partials 2266 523 -1743
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1175 files with indirect coverage changes 🚀 New features to boost your workflow:
|
…m/Comfy-Org/ComfyUI_frontend into jaeone94/dynamic-group-remote-create-max # Conflicts: # src/workbench/extensions/agent/crdt/liveGraphApplier.ts
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @jaeone94.
Found 6 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 2 |
| 🟢 Low | 4 |
Panel: 6/6 reviewers contributed findings.
| const index = overflowWidgetIndex(name) | ||
| return index === null | ||
| ? !constructedNames.has(name) | ||
| ? !constructedNames.has(name) || dynamicGroupController(node, name) |
There was a problem hiding this comment.
🟡 Medium — Before this change, configure's validateSavedRowCount capped the create path at the length of the projected positional array. Now the controller goes to applyDynamicGroupRowCount, whose over-max ceiling is documentedRowCount, and that counts any distinct segment under rows., including junk keys like rows.x or rows.$add that back no real row field. A crafted add_node with N filler keys and rows: N can force N addRow calls, each rescanning widgets and inputs (O(N²)), and freeze every follower tab. Count only numeric row indices (/^\d+$/) that carry at least one template field, and add a hard cap. Raised by 3 of 6 reviewers (claude-opus-5-5-xhigh adversarial, gpt-5.6-sol-xhigh adversarial, kimi-k3-high adversarial).
There was a problem hiding this comment.
This is the same bound question that came up on #21264. documentedRowCount is shared with that PR, and which layer owns the row-count cap (including whether the frontend should apply the comfy-multi-player allocation bound as a hard cap) is tracked in #21288.
On this create path specifically, a crafted doc still has to carry one key per row, so the work grows with the size of the doc. The opaque-array path already allowed [N, ...N values] before this PR. Leaving this open for a human reviewer.
| @@ -533,6 +541,8 @@ function positionalWidgetValues( | |||
| ) | |||
There was a problem hiding this comment.
🟢 Low — The new controller deferral covers only the named-map branch. Opaque array widgets still pass the raw controller value into node.configure, so a crafted count such as 1e9 hits validateSavedRowCount as a RangeError mid-configure. That aborts the node's configuration instead of refusing just the count, the way the named-map path now does. Apply the same deferral or clamp to the Array.isArray branch so both document shapes behave the same. Raised by 1 of 6 reviewers (kimi-k3-high adversarial).
There was a problem hiding this comment.
Out of scope here. The opaque-array branch is unchanged by this PR: it passed the raw count into configure before, and a bare 1e9 already threw there. Making both document shapes behave the same is part of the bound decision in #21288.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @jaeone94.
Round 2 — ledger: 6 prior finding(s) across 1 round(s) (0 never answered).
Found 3 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 3 |
Panel: 6/6 reviewers contributed findings.
| return ( | ||
| widget === undefined || | ||
| index >= constructed.length || | ||
| isDynamicGroupController(widget) |
There was a problem hiding this comment.
🟡 Medium — Alias-addressed controllers now go through applyDynamicGroupRowCount, but its over-max ceiling documentedRowCount counts only rows.-prefixed keys, so it returns 0 when the row values are stored as _extra_N aliases. A valid restored group above max on an overflow node (e.g. ['head', 4, 0.1, 0.2, 0.3, 0.4] with max: 3 and widget_order: ['before']) is refused, failureCount increments, and its row values are dropped. The same group restores fine when stored under named keys. This is the opposite of the junk-key over-counting tracked in #21288: here valid documents are under-counted. Count the positional entries behind the controller's index as documented rows, and add an alias over-max case next to the named over-max test. Raised by 5 of 6 reviewers (claude-opus-5-5-xhigh adversarial, gpt-5.6-sol-xhigh adversarial, claude-opus-5-5-xhigh edge-case, gpt-5.6-sol-xhigh edge-case, kimi-k3-high edge-case).
There was a problem hiding this comment.
With 7a7f72d, an alias-stored count takes the pre-PR configure path again rather than applyDynamicGroupRowCount, so documentedRowCount isn't consulted for it. A restored above-max group stored under aliases behaves exactly as it did before this PR. This PR fixes the named-storage case from #21279. Doc nodes stored positionally (no catalog names for the rows) are the unsupported reader/catalog combination in comfy-multi-player #276's adoption table, and the bound question for them is part of #21288.
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @jaeone94.
Round 3 — ledger: 9 prior finding(s) across 2 round(s) (0 never answered).
Found 1 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 1 |
Panel: 6/6 reviewers contributed findings.
|
|
|
|
|
|
Summary
A DynamicGroup restored from a saved workflow can hold more rows than its
max. When that node reaches another tab through the shared doc, the follower's create path configures it with only the widgets a fresh node has. The row values are dropped,validateSavedRowCountthrows, and the follower records an apply failure and ends up with 0 rows.On create,
createNodenow holds a DynamicGroup row count at its constructed value duringconfigure, then applies it with the row values through the existing widget rounds. There the remote row-count guard from #21264 lets a real restored group through, because its limit counts the rows the document carries values for:max(max, current rows, documented rows). A crafted doc with a huge count and no row values is still refused before any row is allocated.Scope: the count is only deferred when the document stores it by name on a node without a DynamicCombo input. On a DynamicCombo node, positional
_extra_Naliases can address slots that the rows would shift, so those nodes keep the existingconfigurepath exactly as before. That keeps this PR free of the alias edge cases Cursor kept finding. The DynamicCombo-node case is tracked in #21297, and a test asserts today's behavior there (0 rows, one failure).Red-Green Verification
test: cover creating a restored above-max DynamicGroup on a follower(612c215)fix: create restored above-max DynamicGroups on followers(4733ced)test: create a DynamicGroup whose row count is stored under an overflow alias(c12b1cd)test: keep aliased DynamicGroup row values off a trailing widget on create(04427b5)test: cover a named DynamicGroup row count followed by aliased values on create(4d85d35)test: create a restored above-max DynamicGroup next to a stray overflow key(c5c277b)_extra_9brought back #21279test: cover a fully named catalog order on an overflow DynamicGroup node(c48b631)fix: defer DynamicGroup row counts only on nodes without overflow aliases(6e9f43c)Each of the Cursor reds above also had its own fix commit in between (94daae4, 7a7f72d, 49aacc3, 9f67924), each with a green run. Those tried to handle aliases on DynamicCombo nodes, and 6e9f43c replaces all of them by keeping those nodes on the
configurepath. The test-only commits 6f438e8 and 7c3007f label the cases and pin today's #21297 behavior.The documented-rows part of the limit later moved into #21264 (bc77798) to fix a rollback regression there, and this branch picked it up through a merge. This PR's own diff is now just the create path.
Test Plan
max: 3) is created on a fresh follower with all 4 rows and no failure, also when a stray_extra_9sits in the doc. The stray key is still reported as a missing widget, which is existing behavior.rows = 1e9and no row values is still refused on create (0 rows, one failure).