Repository navigation
fix(agent): hold the out-of-credits card until the thread is activated - #21241
Conversation
📦 Bundle: 11.6 MB gzip 🔴 +16 BDetailsSummary
Category Glance App Entry Points — 6.86 kB (baseline 6.86 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 3.4 MB (baseline 3.4 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 1 added / 1 removed / 3 unchanged Views & Navigation — 147 kB (baseline 147 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 787 kB (baseline 787 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 2 added / 2 removed / 32 unchanged User & Accounts — 151 kB (baseline 151 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 17 unchanged Editors & Dialogs — 359 kB (baseline 359 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 12 unchanged UI Components — 217 kB (baseline 217 kB) • ⚪ 0 BReusable component library chunks Status: 29 unchanged Data & Services — 1.21 MB (baseline 1.21 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 43 unchanged Utilities & Hooks — 1.01 MB (baseline 1.01 MB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 77 unchanged Vendor & Third-Party — 24.7 MB (baseline 24.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 17 unchanged Other — 20.5 MB (baseline 20.5 MB) • 🔴 +144 BBundles that do not match a named category
Status: 2 added / 2 removed / 683 unchanged ⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-18T07:42:45.973Z",
"gitSha": "effbf57eb728a78896d2c93cad22fbc69264ab43",
"branch": "glary/agent-credits-banner-after-first-message",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2024.9560000000315,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.5170000000000012,
"layouts": 10,
"layoutDurationMs": 3.038,
"taskDurationMs": 487.32099999999997,
"heapDeltaBytes": -14711452,
"heapUsedBytes": 88971588,
"domNodes": -176,
"jsHeapTotalBytes": 1216512,
"scriptDurationMs": 12.345,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2009.5119999999724,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.5609999999999995,
"layouts": 10,
"layoutDurationMs": 2.4210000000000003,
"taskDurationMs": 351.646,
"heapDeltaBytes": -11294640,
"heapUsedBytes": 92238604,
"domNodes": -176,
"jsHeapTotalBytes": 954368,
"scriptDurationMs": 6.929000000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1711.0549999999876,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.952,
"layouts": 10,
"layoutDurationMs": 2.628,
"taskDurationMs": 755.962,
"heapDeltaBytes": -16528228,
"heapUsedBytes": 86892496,
"domNodes": -200,
"jsHeapTotalBytes": 7245824,
"scriptDurationMs": 132.57399999999998,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665048543689316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1962.9569999999603,
"styleRecalcs": 81,
"styleRecalcDurationMs": 13.415999999999999,
"layouts": 10,
"layoutDurationMs": 2.291,
"taskDurationMs": 822.394,
"heapDeltaBytes": -19172704,
"heapUsedBytes": 84351580,
"domNodes": -176,
"jsHeapTotalBytes": 2539520,
"scriptDurationMs": 111.028,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.901000000002,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.6850000000000005,
"layouts": 12,
"layoutDurationMs": 3.3419999999999996,
"taskDurationMs": 291.63500000000005,
"heapDeltaBytes": 1804588,
"heapUsedBytes": 105757996,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 15.391,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665048543689316,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.4290000000237,
"styleRecalcs": 18,
"styleRecalcDurationMs": 5.342,
"layouts": 13,
"layoutDurationMs": 3.3099999999999996,
"taskDurationMs": 268.16,
"heapDeltaBytes": 1797312,
"heapUsedBytes": 105802328,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 10.62,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 550.4030000000171,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.289,
"layouts": 10,
"layoutDurationMs": 2.8629999999999995,
"taskDurationMs": 365.267,
"heapDeltaBytes": 692032,
"heapUsedBytes": 87933888,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 117.06300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636368,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 499.37199999999393,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.02,
"layouts": 10,
"layoutDurationMs": 2.4720000000000004,
"taskDurationMs": 320.02,
"heapDeltaBytes": 6860964,
"heapUsedBytes": 110410684,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 107.364,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 966.3320000000226,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 651.1799999999998,
"heapDeltaBytes": -16356992,
"heapUsedBytes": 101989040,
"domNodes": -206,
"jsHeapTotalBytes": 15446016,
"scriptDurationMs": 42.961,
"eventListeners": -168,
"totalBlockingTimeMs": 309,
"frameDurationMs": 26.849999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 937.5090000000341,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 578.33,
"heapDeltaBytes": -9664016,
"heapUsedBytes": 102121656,
"domNodes": -226,
"jsHeapTotalBytes": 11972608,
"scriptDurationMs": 36.95,
"eventListeners": -168,
"totalBlockingTimeMs": 277,
"frameDurationMs": 25.925000000000004,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 696.5869999999654,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 299.998,
"heapDeltaBytes": -4170440,
"heapUsedBytes": 96784480,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 98.29900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 95,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 702.6180000000295,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 276.9190000000004,
"heapDeltaBytes": -5099592,
"heapUsedBytes": 96143352,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 90.48200000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 90,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7020.092000000005,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.2109999999999994,
"layouts": 4,
"layoutDurationMs": 1.091,
"taskDurationMs": 6170.719,
"heapDeltaBytes": 7739504,
"heapUsedBytes": 121021104,
"domNodes": -292,
"jsHeapTotalBytes": 22515712,
"scriptDurationMs": 4595.671,
"eventListeners": -130,
"totalBlockingTimeMs": 111,
"frameDurationMs": 22.90912052117264,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5915.412000000004,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.9620000000000002,
"layouts": 4,
"layoutDurationMs": 0.8319999999999999,
"taskDurationMs": 4960.268999999999,
"heapDeltaBytes": 13240484,
"heapUsedBytes": 134694032,
"domNodes": -272,
"jsHeapTotalBytes": 25071616,
"scriptDurationMs": 3964.128,
"eventListeners": -130,
"totalBlockingTimeMs": 92,
"frameDurationMs": 19.535761589403975,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6546.069999999986,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.856,
"layouts": 3,
"layoutDurationMs": 0.761,
"taskDurationMs": 5648.682,
"heapDeltaBytes": 9978976,
"heapUsedBytes": 114802144,
"domNodes": -292,
"jsHeapTotalBytes": 15175680,
"scriptDurationMs": 4089.291,
"eventListeners": -130,
"totalBlockingTimeMs": 11,
"frameDurationMs": 19.610179640718563,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6457.677999999987,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.6979999999999998,
"layouts": 3,
"layoutDurationMs": 0.6360000000000002,
"taskDurationMs": 5294.121999999999,
"heapDeltaBytes": 21127800,
"heapUsedBytes": 142341584,
"domNodes": -272,
"jsHeapTotalBytes": 33722368,
"scriptDurationMs": 4237,
"eventListeners": -130,
"totalBlockingTimeMs": 62,
"frameDurationMs": 20.940584415584414,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-combo-open",
"durationMs": 173.58999999999014,
"styleRecalcs": 23,
"styleRecalcDurationMs": 14.514,
"layouts": 12,
"layoutDurationMs": 3.3679999999999994,
"taskDurationMs": 125.48400000000001,
"heapDeltaBytes": 13304408,
"heapUsedBytes": 117543568,
"domNodes": 917,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 7.194999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.82499999999999,
"p95FrameDurationMs": 49.90000000000009
},
{
"name": "large-combo-open",
"durationMs": 145.4219999999964,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.413,
"layouts": 13,
"layoutDurationMs": 3.108,
"taskDurationMs": 102.21499999999999,
"heapDeltaBytes": 13324404,
"heapUsedBytes": 120170976,
"domNodes": 917,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 5.921,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.05714285714287,
"p95FrameDurationMs": 33.29999999999973
},
{
"name": "large-graph-idle",
"durationMs": 2026.94699999995,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.94,
"layouts": 9,
"layoutDurationMs": 2.6699999999999995,
"taskDurationMs": 553.873,
"heapDeltaBytes": -17114928,
"heapUsedBytes": 93261468,
"domNodes": -272,
"jsHeapTotalBytes": -2125824,
"scriptDurationMs": 31.796000000000006,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2005.4980000000455,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.4419999999999997,
"layouts": 9,
"layoutDurationMs": 2.0959999999999996,
"taskDurationMs": 394.15600000000006,
"heapDeltaBytes": -286920,
"heapUsedBytes": 100263292,
"domNodes": -272,
"jsHeapTotalBytes": -2179072,
"scriptDurationMs": 25.452,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 3061.3950000000045,
"styleRecalcs": 69,
"styleRecalcDurationMs": 8.934000000000001,
"layouts": 8,
"layoutDurationMs": 2.6859999999999995,
"taskDurationMs": 1344.7160000000001,
"heapDeltaBytes": 1101376,
"heapUsedBytes": 103935408,
"domNodes": -292,
"jsHeapTotalBytes": -393216,
"scriptDurationMs": 613.592,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666304347826088,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2215.2850000000512,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.3469999999999995,
"layouts": 9,
"layoutDurationMs": 2.015,
"taskDurationMs": 1123.4740000000002,
"heapDeltaBytes": 509076,
"heapUsedBytes": 103531420,
"domNodes": -272,
"jsHeapTotalBytes": -905216,
"scriptDurationMs": 539.372,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3887.4329999999873,
"styleRecalcs": 72,
"styleRecalcDurationMs": 9.42,
"layouts": 65,
"layoutDurationMs": 12.363,
"taskDurationMs": 1446.41,
"heapDeltaBytes": 6494168,
"heapUsedBytes": 110802660,
"domNodes": -248,
"jsHeapTotalBytes": -1536000,
"scriptDurationMs": 607.1719999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665665236051503,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3304.17900000009,
"styleRecalcs": 74,
"styleRecalcDurationMs": 9.033,
"layouts": 68,
"layoutDurationMs": 12.391,
"taskDurationMs": 1270.941,
"heapDeltaBytes": -4621096,
"heapUsedBytes": 102082120,
"domNodes": -248,
"jsHeapTotalBytes": 17403904,
"scriptDurationMs": 571.517,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665656565656565,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2643.9400000000433,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.829,
"layouts": 7,
"layoutDurationMs": 1.938,
"taskDurationMs": 1485.948,
"heapDeltaBytes": 17770116,
"heapUsedBytes": 123897112,
"domNodes": 0,
"jsHeapTotalBytes": 5926912,
"scriptDurationMs": 754.807,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.771518987341775,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2535.094000000072,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.51,
"layouts": 6,
"layoutDurationMs": 1.4520000000000002,
"taskDurationMs": 1313.9879999999998,
"heapDeltaBytes": 17835552,
"heapUsedBytes": 124328124,
"domNodes": 0,
"jsHeapTotalBytes": 6713344,
"scriptDurationMs": 637.652,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66578947368421,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2034.388999999976,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6570000000000005,
"layouts": 8,
"layoutDurationMs": 2.4440000000000004,
"taskDurationMs": 540.1590000000001,
"heapDeltaBytes": -830164,
"heapUsedBytes": 102007768,
"domNodes": -292,
"jsHeapTotalBytes": -2453504,
"scriptDurationMs": 34.27400000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2004.6479999999747,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4870000000000005,
"layouts": 9,
"layoutDurationMs": 2.19,
"taskDurationMs": 422.246,
"heapDeltaBytes": -218228,
"heapUsedBytes": 102292548,
"domNodes": -272,
"jsHeapTotalBytes": -2441216,
"scriptDurationMs": 27.648,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 559.8149999999578,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.1049999999999995,
"layouts": 10,
"layoutDurationMs": 2.7979999999999996,
"taskDurationMs": 363.348,
"heapDeltaBytes": 2695688,
"heapUsedBytes": 108549380,
"domNodes": 0,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 110.99099999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 447.5670000000491,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.281999999999999,
"layouts": 10,
"layoutDurationMs": 2.344,
"taskDurationMs": 304.547,
"heapDeltaBytes": 2743692,
"heapUsedBytes": 108681728,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 99.882,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2026.3390000000072,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.144000000000001,
"layouts": 10,
"layoutDurationMs": 2.8089999999999997,
"taskDurationMs": 406.937,
"heapDeltaBytes": -12717268,
"heapUsedBytes": 93220108,
"domNodes": -214,
"jsHeapTotalBytes": 2002944,
"scriptDurationMs": 12.038,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2009.206000000006,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.4599999999999995,
"layouts": 9,
"layoutDurationMs": 2.039,
"taskDurationMs": 297.247,
"heapDeltaBytes": 3462504,
"heapUsedBytes": 95247908,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 6.422000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.863000000002,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.986,
"layouts": 10,
"layoutDurationMs": 2.7039999999999997,
"taskDurationMs": 673.143,
"heapDeltaBytes": -6934752,
"heapUsedBytes": 92936708,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 99.36200000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665346534653462,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1677.8299999999717,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.373,
"layouts": 10,
"layoutDurationMs": 2.33,
"taskDurationMs": 576.724,
"heapDeltaBytes": -17467412,
"heapUsedBytes": 88107008,
"domNodes": -186,
"jsHeapTotalBytes": 2002944,
"scriptDurationMs": 80.478,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 783.5150000000226,
"styleRecalcs": 19,
"styleRecalcDurationMs": 16.002,
"layouts": 5,
"layoutDurationMs": 9.259000000000002,
"taskDurationMs": 481.31400000000014,
"heapDeltaBytes": 33473916,
"heapUsedBytes": 131801196,
"domNodes": 15950,
"jsHeapTotalBytes": 16392192,
"scriptDurationMs": 17.216,
"eventListeners": 3244,
"totalBlockingTimeMs": 63,
"frameDurationMs": 19.107317073170723,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10870.015999999963,
"styleRecalcs": 252,
"styleRecalcDurationMs": 26.032,
"layouts": 9,
"layoutDurationMs": 2.5109999999999992,
"taskDurationMs": 4792.999,
"heapDeltaBytes": 2053988,
"heapUsedBytes": 103903172,
"domNodes": -292,
"jsHeapTotalBytes": -1986560,
"scriptDurationMs": 2120.454,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610429447853,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8869.18400000002,
"styleRecalcs": 251,
"styleRecalcDurationMs": 23.711,
"layouts": 10,
"layoutDurationMs": 2.298,
"taskDurationMs": 4263.92,
"heapDeltaBytes": 5280040,
"heapUsedBytes": 106001000,
"domNodes": -272,
"jsHeapTotalBytes": 917504,
"scriptDurationMs": 2019.3509999999999,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853658,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 12571.247000000028,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11743.998,
"heapDeltaBytes": -7543152,
"heapUsedBytes": 303548984,
"domNodes": -3330,
"jsHeapTotalBytes": 30396416,
"scriptDurationMs": 181.898,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.33480475382003,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-idle",
"durationMs": 15487.410999999953,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14713.001,
"heapDeltaBytes": -51290360,
"heapUsedBytes": 274960308,
"domNodes": -3330,
"jsHeapTotalBytes": 24629248,
"scriptDurationMs": 222.15699999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 26.37597955706985,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 18249.978,
"styleRecalcs": 161,
"styleRecalcDurationMs": 13.945000000000013,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17849.819,
"heapDeltaBytes": -43584536,
"heapUsedBytes": 281001116,
"domNodes": -3330,
"jsHeapTotalBytes": 8114176,
"scriptDurationMs": 626.166,
"eventListeners": -651,
"totalBlockingTimeMs": 2,
"frameDurationMs": 33.48495412844037,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 14725.622000000043,
"styleRecalcs": 70,
"styleRecalcDurationMs": 8.461999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14038.249,
"heapDeltaBytes": -17926288,
"heapUsedBytes": 288413684,
"domNodes": -3334,
"jsHeapTotalBytes": 13619200,
"scriptDurationMs": 583.561,
"eventListeners": -651,
"totalBlockingTimeMs": 24,
"frameDurationMs": 25.75646853146853,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 5495.479999999987,
"styleRecalcs": 20,
"styleRecalcDurationMs": 51.11099999999999,
"layouts": 20,
"layoutDurationMs": 20.76,
"taskDurationMs": 5326.922,
"heapDeltaBytes": -11656972,
"heapUsedBytes": 294146860,
"domNodes": -3330,
"jsHeapTotalBytes": 35901440,
"scriptDurationMs": 75.192,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.60747126436782,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5790.711999999985,
"styleRecalcs": 20,
"styleRecalcDurationMs": 46.97899999999999,
"layouts": 20,
"layoutDurationMs": 20.962999999999994,
"taskDurationMs": 5684.679999999999,
"heapDeltaBytes": -32612888,
"heapUsedBytes": 296754480,
"domNodes": -3330,
"jsHeapTotalBytes": 22007808,
"scriptDurationMs": 85.21300000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.423809523809524,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7403.971999999953,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7066.442,
"heapDeltaBytes": -3583272,
"heapUsedBytes": 277168016,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 87.034,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.083728813559325,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8226.064999999948,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7624.735,
"heapDeltaBytes": 4621040,
"heapUsedBytes": 281530296,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 107.18999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 27.908474576271182,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 89.6979999999985,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.683999999999999,
"layouts": 6,
"layoutDurationMs": 2.0280000000000005,
"taskDurationMs": 62.312,
"heapDeltaBytes": 4894904,
"heapUsedBytes": 106428184,
"domNodes": 99,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.940999999999999,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 88.55700000003708,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.997,
"layouts": 5,
"layoutDurationMs": 2.144,
"taskDurationMs": 59.78699999999999,
"heapDeltaBytes": 4662744,
"heapUsedBytes": 106300724,
"domNodes": 117,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 4.085,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20,
"p95FrameDurationMs": 33.29999999999973
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 206.37500000009368,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.7200000000000001,
"layouts": 76,
"layoutDurationMs": 11.051,
"taskDurationMs": 169.547,
"heapDeltaBytes": 8876788,
"heapUsedBytes": 90985956,
"domNodes": 4,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 71.36000000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.676923076923057,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 233.8399999999865,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.718,
"layouts": 76,
"layoutDurationMs": 12.45,
"taskDurationMs": 187.307,
"heapDeltaBytes": 9118580,
"heapUsedBytes": 96233076,
"domNodes": 4,
"jsHeapTotalBytes": 8912896,
"scriptDurationMs": 79.27199999999999,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428578,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 288.82899999996425,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.9940000000000002,
"layouts": 76,
"layoutDurationMs": 12.133,
"taskDurationMs": 255.066,
"heapDeltaBytes": -1930228,
"heapUsedBytes": 114650964,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 86.45700000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66111111111109,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 292.60199999998804,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.509,
"layouts": 76,
"layoutDurationMs": 11.763,
"taskDurationMs": 244.63700000000003,
"heapDeltaBytes": -6857384,
"heapUsedBytes": 105177664,
"domNodes": 4,
"jsHeapTotalBytes": 2621440,
"scriptDurationMs": 82.014,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 64.1% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2284 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e7fc8af32cb77c88ae5a88ffe782c2b91287093e
Full docs: ADR-DEVEX-LINT-0015 |
|
CodeRabbit's comment is only its automatic "review in progress" status note and doesn't contain any findings yet, so I haven't changed anything. I'll address its review comments once they're posted. |
|
Thanks @coderabbitai. The approval came with no review text and no inline comments, so I haven't changed anything. |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #21241 +/- ##
==========================================
+ Coverage 86.59% 87.40% +0.81%
==========================================
Files 3765 2688 -1077
Lines 177954 149297 -28657
Branches 49114 40928 -8186
==========================================
- Hits 154096 130500 -23596
+ Misses 21791 18407 -3384
+ Partials 2067 390 -1677
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1086 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
…anner-after-first-message
There was a problem hiding this comment.
🔍 Cursor Review — Consolidated panel
Triggered by @christian-byrne.
Found 2 finding(s).
| Severity | Count |
|---|---|
| 🟡 Medium | 1 |
| 🟢 Low | 1 |
Panel: 6/6 reviewers contributed findings.
…d id A first send that fails before the server acknowledges it (network, 5xx, or a 402 whose inline card is later resolved) leaves a user message in the transcript with no thread id, which hid the standing card on a non-empty conversation. Restoring a thread set the id before its history loaded, which showed the card over an empty transcript. Addresses #21241 (comment) and #21241 (comment)
…ifecycle e2e The lifecycle fixture answered every thread history read with an empty list, so reopening the panel restored the thread with no messages. A real thread keeps its turns, and the standing out-of-credits card now waits for a user message in the transcript.
Swarmhost agentic reviewThe detailed evaluation is available to employees in the internal Slack review thread. Evaluation budget remaining for this pull request: 98 automatic and 99 manual. Updated by Swarmhost's agentic review process. |
|
@coderabbitai's latest approval came with no review text and no inline comments, so there was nothing to address from it. The two commits I just pushed (6538fa7, db1394e) update e2e tests to go with the user-message gating in 4fe474b. |
|
|
|
|
…the thread is activated (#21241) (#21353) Backport of #21241 to `cloud/1.57`. The out-of-credits card in the agent panel now waits for the first user message, so an empty or still-loading thread no longer shows it. Conflict resolved by hand in the lifecycle e2e fixture only: this branch still passes a single socket, so the new thread-history route was added around that. Checked locally on this branch: `AgentPanelRoot.test.ts` passes, app and browser typecheck pass. The two new empty-thread unit tests fail without the change.
…he thread is activated (#21241) (#21354) Backport of #21241 to `core/1.56`. The out-of-credits card in the agent panel now waits for the first user message, so an empty or still-loading thread no longer shows it. Conflict resolved by hand: 1.56 still has the older `showStandingPaywall` body, so the user-message check was added to that body instead of taking main's version. The lifecycle e2e fixture keeps this branch's single-socket shape. Checked locally on this branch: `AgentPanelRoot.test.ts` passes, app and browser typecheck pass. The two new empty-thread unit tests fail without the change.
…he thread is activated (#21241) (#21352) Backport of #21241 to `core/1.57`. The out-of-credits card in the agent panel now waits for the first user message, so an empty or still-loading thread no longer shows it. Conflict resolved by hand in the lifecycle e2e fixture only: this branch still passes a single socket, so the new thread-history route was added around that. Checked locally on this branch: `AgentPanelRoot.test.ts` passes, app and browser typecheck pass. The two new empty-thread unit tests fail without the change.
…the thread is activated (#21241) (#21355) Backport of #21241 to `cloud/1.56`. The out-of-credits card in the agent panel now waits for the first user message, so an empty or still-loading thread no longer shows it. Conflict resolved by hand: 1.56 still has the older `showStandingPaywall` body, so the user-message check was added to that body instead of taking main's version. The lifecycle e2e fixture keeps this branch's single-socket shape. Checked locally on this branch: `AgentPanelRoot.test.ts` passes, app and browser typecheck pass. The two new empty-thread unit tests fail without the change.
…anscript is back (Comfy-Org#21356) Test-only follow-up to Comfy-Org#21241. Since Comfy-Org#21241 the out-of-credits card only shows once the thread has a user message. The shared agent mock answers thread-history reads with `[]`, so after the panel reopens in `keeps the standing paywall in sync across turn completion and panel close`, the transcript is empty and the card is hidden whatever the funding state. The `reopen without the stale paywall` step then passes without testing the stale-paywall behaviour it was written for. Change: serve the first turn as thread history for that test, and wait for its user bubble before asserting the card is gone. This is the change from Glary-Bot's commit db1394e. It was pushed to the PR branch after Comfy-Org#21241 had already merged, so it never reached `main`. The other commit on that branch (6538fa7) duplicates the lifecycle-fixture fix that did merge in Comfy-Org#21241, so it is not carried here. Checked locally: oxfmt, oxlint and browser typecheck pass. The e2e run is CI's `cloud` shards.
…ut-of-credits card (Comfy-Org#21538) ## Summary A new account's first prompt showed the standing "Out of credits" card for the whole turn, although the turn ran normally. The panel had read billing before the send, and pre-turn admission granted the free Agent credits inside that send, so the stale no-funds read stayed on screen until the turn finished. Stopping or finishing the turn cleared it. Now, when the last read says no funds, the panel holds the standing card from the send until a billing read taken after admission settles. A send that is refused keeps its inline card, and funded users make no extra request. Reported by Windows Local Agent QA in `#comfy-agent-user-feedback` on 2026-10-21. The card is shared frontend code, so Cloud has the same race whenever a grant is minted at admission. This finishes the work of [PM-2066](https://linear.app/comfyorg/issue/PM-2066), whose Comfy-Org#21241 kept the card hidden only until the first message. <details><summary>Full context for agent readers</summary> - The standing card reads `subscription.agentHasFunds`, which is `scoped_effective_has_funds.agent` from `GET /api/billing/status`. Before this change, billing was refreshed only when a turn finished (`AgentPanelRoot.vue`, the idle branch of the `[status, conversationTurnId]` watch). - Cloud ingest mints the monthly or Local Agent gratis grant in `agentGratisEnsureBeforeAdmission` before `/v1/decide`, and it writes the funds snapshot synchronously. So a 2xx on the turn POST means a status read made after admission shows the grant. - Ingest's `billing_status` websocket push is not consumed by the frontend, and its payload has no Agent funds field, so it cannot correct this read. - The existing empty-thread spec still passes: when a post-admission read still says exhausted, the card shows. </details> ## Verification - New black-box case in `browser_tests/tests/agent/agentCreditsExhaustionEmptyThread.spec.ts`: billing is exhausted at load, and the turn POST flips the fixture to funded. On the parent commit it fails with `Expected: 0, Received: 1` (the card is visible during the admitted turn). With this change it passes, after waiting for the billing read that follows admission. - `playwright test` over `agentCreditsExhaustionEmptyThread`, `agentCreditsExhaustionLifecycle`, `agentPanel` and `agentFreeUsePlacement` (`--project=cloud`): 19 passed. - `vitest run src/workbench/extensions/agent/AgentPanelRoot.test.ts`: 465 passed. - Commit hooks passed: oxfmt, stylelint, oxlint, eslint, server-facts, `typecheck:app`, `typecheck:browser`. - Not run: a packaged Desktop build with a brand-new account. ## Linear Fixes [PM-2239](https://linear.app/comfyorg/issue/PM-2239/out-of-credits-banner-shows-on-a-new-account-even-though-free-credits).
…d before showing the out-of-credits card (#21538) (#21590) Backport of #21538 to `cloud/1.57`. A new account's first prompt no longer shows the "Out of credits" card while the turn runs on the free credits granted at admission. Cloud production serves `ba2c2c2269`, which is on this branch, so Cloud gets the fix from the next `cloud/1.57` patch promotion. The product code is the clean cherry-pick. Only the three new `AgentPanelRoot` unit cases were adapted to this branch: they match the thread list the way the rest of this file does and import the promise form of `setImmediate`. <details><summary>Full context for agent readers</summary> - Source: #21538, merged as 340d406. Its prerequisite #21241 is already on this branch (#21353)). `git patch-id --stable` of the unadapted cherry-pick equals the source. - Author and author date preserved; `-x` provenance line kept. No AI co-author trailer. - Black-box proof, `browser_tests/tests/agent/agentCreditsExhaustionEmptyThread.spec.ts` › "keeps the card hidden when the first send is admitted on credits granted at admission", `--project=cloud`, local ComfyUI CI container 0.0.27 plus a `DISTRIBUTION=cloud` dev server: - parent (`cloud/1.57` product files, new spec kept): fails; the page snapshot shows "Out of credits" and "Add credits" under the admitted user message. - this head: passes, along with the rest of `agentCreditsExhaustionEmptyThread`, `agentCreditsExhaustionLifecycle` and `agentFreeUsePlacement`. - `agentPanel.spec.ts`: 18 of 19 pass. "flag off › does not expose the Agent button" fails the same way with and without this change on the local dev server, so it is a local-environment result, not a regression; CI decides. - Vitest `AgentPanelRoot.test.ts`, `useAgentSession.test.ts`, `agentPanelStore.test.ts`: 713 passed. `typecheck` and `typecheck:browser` clean. - Not run: a packaged Desktop build or a hosted Agent turn. - Release-train scope: 1.56 trains are not carried (no consumer; product code diverged). `cloud/1.58` and `core/1.58` are not in the program's release authority yet and also lack #21538. </details>
… before showing the out-of-credits card (#21538) (#21589) Backport of #21538 to `core/1.57`. A new account's first prompt no longer shows the "Out of credits" card while the turn runs on the free credits granted at admission. ComfyUI core pins `comfyui-frontend-package==1.57.1`, which is this branch, so Desktop and Local Agent get the fix from the next 1.57 package. The product code is the clean cherry-pick. Only the three new `AgentPanelRoot` unit cases were adapted to this branch: they match the thread list the way the rest of this file does and import the promise form of `setImmediate`. <details><summary>Full context for agent readers</summary> - Source: #21538, merged as 340d406. Its prerequisite #21241 is already on this branch (#21352)). `git patch-id --stable` of the unadapted cherry-pick equals the source. - Author and author date preserved; `-x` provenance line kept. No AI co-author trailer. - Black-box proof, `browser_tests/tests/agent/agentCreditsExhaustionEmptyThread.spec.ts` › "keeps the card hidden when the first send is admitted on credits granted at admission", `--project=cloud`, local ComfyUI CI container 0.0.27 plus a `DISTRIBUTION=cloud` dev server: - parent (`core/1.57` product files, new spec kept): fails; the page snapshot shows "Out of credits" and "Add credits" under the admitted user message. - this head: passes, along with the rest of `agentCreditsExhaustionEmptyThread`, `agentCreditsExhaustionLifecycle` and `agentFreeUsePlacement`. - `agentPanel.spec.ts`: 18 of 19 pass. "flag off › does not expose the Agent button" fails the same way with and without this change on the local dev server, so it is a local-environment result, not a regression; CI decides. - Vitest `AgentPanelRoot.test.ts`, `useAgentSession.test.ts`, `agentPanelStore.test.ts`: 713 passed. `typecheck` and `typecheck:browser` clean. - Not run: a packaged Desktop build or a hosted Agent turn. - Release-train scope: 1.56 trains are not carried (no consumer; product code diverged). `cloud/1.58` and `core/1.58` are not in the program's release authority yet and also lack #21538. </details>
Comfy-Org#22242) ## Summary [FRONT-3670](https://linear.app/comfyorg/issue/FRONT-3670). Comfy-Org#21241 holds the standing "Out of credits" card until the thread has a user message, and its own description flagged the gate as needing a decision once the agent can open a chat itself ([FRONT-3251](https://linear.app/comfyorg/issue/FRONT-3251)). That makes a new state reachable — a thread with an assistant turn and no user turn — and nothing says what the card should do in it. FRONT-3670 offers two choices. **This takes the second: keep the card hidden until the user engages, and let the first refusal explain credits.** No behaviour changes; the PR pins the behaviour the panel already has, which was untested and would otherwise shift silently when the proactive message lands. The reason to prefer it is the thing Comfy-Org#21241 was fixing. A new workspace's monthly Agent gratis grant is minted lazily — `agentGratisEnsureBeforeAdmissionOnSurface` runs inside pre-turn admission, so the user's own first send can be what mints it. Before that send, `agent_has_funds: false` is not yet evidence the user is out of credits. Counting the agent's own turn as activation would therefore put "Out of credits" beside the agent's opening line for a user who is about to be granted free credits — the false card Comfy-Org#21241 removed, now at the most prominent moment of onboarding. The panel already has the matching evidence in `agentCreditsExhaustionEmptyThread.spec.ts`: "keeps the card hidden when the first send is admitted on credits granted at admission". So the user's cost under this choice is one reply that gets refused, and the refusal is not a dead end: it renders the inline credits card with the server's message and an **Add credits** button. The new spec asserts that, so "the first refusal explains credits clearly" is a tested claim rather than an assumption. The other shape FRONT-3251 might take — a greeting rendered in the empty state with no transcript row at all, as prototyped in Comfy-Org#20610 — produces no conversation entry, so it is already covered by the existing empty-thread spec. Both plausible shapes now have coverage. ## Verification New black-box Playwright case, `browser_tests/tests/agent/agentCreditsExhaustionAgentStartedThread.spec.ts`, next to the empty-thread spec as the ticket asks. It boots with billing exhausted and a restored thread whose only row is an assistant turn, then asserts visible and accessible state only: 1. the agent's opening line is on screen, no user bubble, the composer is usable, and **zero** `role="alert"` nodes — nothing claims the user is out of credits; 2. after the first reply is refused `402 no_funds`: the credits card is visible, echoes the server's message, offers **Add credits**, and there is **exactly one** `role="alert"` — the inline refusal card is not joined by the standing card. Both the spec and the new `AgentPanelRoot.test.ts` case were proven non-vacuous by mutation: with the gate changed to count any entry (the other FRONT-3670 option), step 1 fails with the "Out of credits" alert rendered beside the agent's opening line, and the unit case fails too. Reverted before committing. Also run on a real `DISTRIBUTION=cloud` harness: this spec plus `agentCreditsExhaustionEmptyThread`, `agentCreditsExhaustionLifecycle` and `agentPaywallSubscribe` — 6 passed. `AgentPanelRoot.test.ts` 562 passed. `typecheck:app`, `typecheck:browser`, `oxlint` and `oxfmt --check` clean. Not covered: the real proactive message, which does not exist yet. The spec reaches the state through restored thread history, which is the same seam a server-authored opening turn would arrive on.
|
Correction to the comment above: the two commits it mentions (6538fa7, db1394e) never reached this PR or
Full context for agent readersThis PR had already merged and its head branch was deleted when Glary-Bot pushed. The push re-created the branch with no PR attached, so the comment's claim was wrong. Glary-Bot now refuses to push to the branch of a merged or closed PR (https://linear.app/comfyorg/issue/BOT-219). Remaining gaps are tracked in https://linear.app/comfyorg/issue/BOT-228. |
|
Thanks for the correction. My earlier comment was wrong: 6538fa7 and db1394e never reached this PR or |
PR Created by the Glary-Bot Agent
Summary
The standing "Out of credits" card in the agent side panel now appears only after the thread is activated. It no longer shows on a fresh empty thread.
Why: newly granted gratis credits take about 30s to show up in billing. Until then the workspace reads as exhausted, so the card was appearing on brand-new empty chats. The backend latency fix shipped separately. This is the frontend mitigation agreed in #pillar5-agent.
Change
AgentPanelRoot.vue:showStandingPaywallalso requires the transcript to hold at least one user message. Brand-new and New Chat threads stay clean; the card appears as soon as the user has sent something.creditsExhaustedgating itself (billing, consent, capability, presentation) is unchanged.credits_exhausted) is only reported once the card actually shows.Test-driven
New e2e test first:
browser_tests/tests/agent/agentCreditsExhaustionEmptyThread.spec.ts, tagged@cloud. It boots with billing exhausted, then checks three things:On
mainit failed at the empty-thread step:expected 0, received 1.Then the fix. The new spec passes, and so do these neighbouring specs:
agentCreditsExhaustionLifecycle.spec.tsagentPaywallSubscribe.spec.tsagentPanel.spec.tscase "keeps the standing paywall in sync…"Unit tests:
AgentPanelRoot.test.ts, 458/458 passing.This uses "the thread is activated by the user" as a stand-in for "the user is engaged". If we ever add proactive first turns, where the agent sends the first message, this gating has to be revisited. An "empty thread / no accepted user turn" check would then suppress the card when it should show (or the wrong event would activate it), and the gratis-latency issue it covers would come back.
A failed first send (503, network error, refused 402) still counts as the user's first message, so the standing card shows after it when the workspace is exhausted.
Screenshots
Empty thread with billing exhausted (no card), and the same session after the first message (card shown).
Backports
The automated backport failed (see comments below), so these were done by hand and are merged: