Repository navigation
fix: guard touch handlers against a missing canvas and report why - #21321
Conversation
The processMouseDown wrapper read app.canvas, which stays undefined when ComfyApp.setup() aborts inside the LGraphCanvas constructor, so every click threw. Read the canvas from the receiver instead, bail out of the touch handlers when no canvas exists, and report the first occurrence per entry point with diagnostic context. Also stop a throwing first frame from aborting LGraphCanvas construction: the failure is reported and the instance finishes constructing.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle: 11.8 MB gzip 🔴 +709 BDetailsSummary
Category Glance App Entry Points — 7.04 kB (baseline 7.04 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 3.59 MB (baseline 3.59 MB) • 🔴 +201 BGraph editor runtime, canvas, workflow orchestration
Status: 3 added / 3 removed / 1 unchanged Views & Navigation — 148 kB (baseline 148 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 9 added / 9 removed / 9 unchanged Panels & Settings — 871 kB (baseline 870 kB) • 🔴 +220 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 25 unchanged User & Accounts — 149 kB (baseline 149 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 5 added / 5 removed / 12 unchanged Editors & Dialogs — 271 kB (baseline 271 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 9 added / 9 removed / 6 unchanged UI Components — 333 kB (baseline 333 kB) • ⚪ 0 BReusable component library chunks
Status: 6 added / 6 removed / 24 unchanged Data & Services — 1.88 MB (baseline 1.88 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 19 added / 19 removed / 22 unchanged Utilities & Hooks — 1.23 MB (baseline 1.23 MB) • 🔴 +1 BHelpers, composables, and utility bundles
Status: 24 added / 24 removed / 50 unchanged Vendor & Third-Party — 10.2 MB (baseline 10.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 16 unchanged Other — 34.1 MB (baseline 34.1 MB) • 🔴 +1.81 kBBundles that do not match a named category
Status: 82 added / 82 removed / 668 unchanged ⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-23T00:00:20.607Z",
"gitSha": "d04fd218a1d7921d44a1be3096037a1e0ff6ed3c",
"branch": "fix/touch-support-missing-canvas",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2023.1739999999263,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.0910000000000006,
"layouts": 10,
"layoutDurationMs": 2.823,
"taskDurationMs": 562.9409999999999,
"heapDeltaBytes": 3496360,
"heapUsedBytes": 80655492,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.598000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2023.3659999998963,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.2969999999999997,
"layouts": 9,
"layoutDurationMs": 2.1879999999999997,
"taskDurationMs": 532.543,
"heapDeltaBytes": 3452148,
"heapUsedBytes": 80693872,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.198,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1809.573999999884,
"styleRecalcs": 76,
"styleRecalcDurationMs": 13.434000000000001,
"layouts": 9,
"layoutDurationMs": 2.689,
"taskDurationMs": 922.1270000000001,
"heapDeltaBytes": -4056652,
"heapUsedBytes": 72639264,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 160.37199999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1972.4730000002637,
"styleRecalcs": 84,
"styleRecalcDurationMs": 13.626,
"layouts": 10,
"layoutDurationMs": 2.5320000000000005,
"taskDurationMs": 1064.98,
"heapDeltaBytes": -4188796,
"heapUsedBytes": 73045132,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 159.878,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1791.1119999998846,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.411,
"layouts": 10,
"layoutDurationMs": 2.9590000000000005,
"taskDurationMs": 486.31100000000004,
"heapDeltaBytes": -1980096,
"heapUsedBytes": 75227156,
"domNodes": 56,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 13.985000000000001,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1807.5559999997495,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.3870000000000005,
"layouts": 10,
"layoutDurationMs": 2.578,
"taskDurationMs": 459.471,
"heapDeltaBytes": -2469212,
"heapUsedBytes": 74545672,
"domNodes": 56,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 9.949999999999998,
"eventListeners": 43,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871556,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 725.0560000002224,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.9310000000000005,
"layouts": 9,
"layoutDurationMs": 2.5260000000000002,
"taskDurationMs": 508.795,
"heapDeltaBytes": 2674276,
"heapUsedBytes": 79755392,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 168.16,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66744186046511,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 662.3749999998836,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.6789999999999994,
"layouts": 10,
"layoutDurationMs": 2.536,
"taskDurationMs": 498.29999999999995,
"heapDeltaBytes": 2620872,
"heapUsedBytes": 79756696,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 169.02100000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664999999999985,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1145.5520000004071,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 856.822,
"heapDeltaBytes": 23026324,
"heapUsedBytes": 104720512,
"domNodes": 0,
"jsHeapTotalBytes": 17465344,
"scriptDurationMs": 65.85,
"eventListeners": 0,
"totalBlockingTimeMs": 523,
"frameDurationMs": 33.82058823529411,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1130.6259999996655,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 816.408,
"heapDeltaBytes": 23840272,
"heapUsedBytes": 105501428,
"domNodes": 0,
"jsHeapTotalBytes": 19038208,
"scriptDurationMs": 65.398,
"eventListeners": 0,
"totalBlockingTimeMs": 506,
"frameDurationMs": 33.335294117647074,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 858.9449999999488,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.8969999999999,
"heapDeltaBytes": -3666868,
"heapUsedBytes": 89359832,
"domNodes": 0,
"jsHeapTotalBytes": 4722688,
"scriptDurationMs": 171.10399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 234,
"frameDurationMs": 25.485294117647086,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 856.9359999996777,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 489.78699999999975,
"heapDeltaBytes": -3205364,
"heapUsedBytes": 89713884,
"domNodes": 0,
"jsHeapTotalBytes": 4460544,
"scriptDurationMs": 154.45700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 221,
"frameDurationMs": 24.99999999999997,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11120.37700000019,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10213.988000000001,
"heapDeltaBytes": -17044244,
"heapUsedBytes": 75325136,
"domNodes": -141,
"jsHeapTotalBytes": 6680576,
"scriptDurationMs": 8202.884999999998,
"eventListeners": -53,
"totalBlockingTimeMs": 1163,
"frameDurationMs": 31.051117318435757,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11746.997000000192,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10890.972,
"heapDeltaBytes": -8449392,
"heapUsedBytes": 84825132,
"domNodes": -141,
"jsHeapTotalBytes": 15855616,
"scriptDurationMs": 8975.078,
"eventListeners": -53,
"totalBlockingTimeMs": 1634,
"frameDurationMs": 32.144657534246576,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11355.417999999645,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10439.304,
"heapDeltaBytes": -13587620,
"heapUsedBytes": 78375420,
"domNodes": -141,
"jsHeapTotalBytes": 8777728,
"scriptDurationMs": 8444.958999999999,
"eventListeners": -49,
"totalBlockingTimeMs": 1308,
"frameDurationMs": 31.84245810055866,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10770.246000000043,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9966.068,
"heapDeltaBytes": 2495804,
"heapUsedBytes": 95698024,
"domNodes": -141,
"jsHeapTotalBytes": 7991296,
"scriptDurationMs": 8110.9310000000005,
"eventListeners": -53,
"totalBlockingTimeMs": 1042,
"frameDurationMs": 31.48040935672515,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 228.38999999976295,
"styleRecalcs": 23,
"styleRecalcDurationMs": 16.02,
"layouts": 11,
"layoutDurationMs": 3.9570000000000003,
"taskDurationMs": 180.24300000000002,
"heapDeltaBytes": 14618776,
"heapUsedBytes": 91390000,
"domNodes": 936,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 9.226999999999999,
"eventListeners": 205,
"totalBlockingTimeMs": 11,
"frameDurationMs": 25.933333333333394,
"p95FrameDurationMs": 100
},
{
"name": "large-combo-open",
"durationMs": 215.39500000017142,
"styleRecalcs": 22,
"styleRecalcDurationMs": 14.174,
"layouts": 10,
"layoutDurationMs": 2.5809999999999995,
"taskDurationMs": 170.84499999999997,
"heapDeltaBytes": 14639232,
"heapUsedBytes": 91502056,
"domNodes": 936,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.917000000000001,
"eventListeners": 205,
"totalBlockingTimeMs": 3,
"frameDurationMs": 27.075000000000045,
"p95FrameDurationMs": 100
},
{
"name": "large-graph-idle",
"durationMs": 2007.6550000003408,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.668,
"layouts": 8,
"layoutDurationMs": 2.628,
"taskDurationMs": 657.8709999999999,
"heapDeltaBytes": -7856708,
"heapUsedBytes": 86366372,
"domNodes": 0,
"jsHeapTotalBytes": 5017600,
"scriptDurationMs": 38.38099999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2023.9659999997457,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.197,
"layouts": 8,
"layoutDurationMs": 2.243,
"taskDurationMs": 605.3179999999999,
"heapDeltaBytes": -6902512,
"heapUsedBytes": 88171068,
"domNodes": 0,
"jsHeapTotalBytes": 5279744,
"scriptDurationMs": 29.98100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2867.0569999999316,
"styleRecalcs": 67,
"styleRecalcDurationMs": 9.306999999999999,
"layouts": 6,
"layoutDurationMs": 1.6489999999999998,
"taskDurationMs": 1779.5449999999998,
"heapDeltaBytes": -4763512,
"heapUsedBytes": 90691584,
"domNodes": 0,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 847.774,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.763742690058482,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2768.094000000019,
"styleRecalcs": 68,
"styleRecalcDurationMs": 8.593,
"layouts": 7,
"layoutDurationMs": 1.8419999999999999,
"taskDurationMs": 1723.839,
"heapDeltaBytes": -4927204,
"heapUsedBytes": 91060672,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 837.5989999999999,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76727272727273,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3987.0860000000903,
"styleRecalcs": 72,
"styleRecalcDurationMs": 10.118,
"layouts": 65,
"layoutDurationMs": 11.018,
"taskDurationMs": 1797.0100000000002,
"heapDeltaBytes": 6290756,
"heapUsedBytes": 81071920,
"domNodes": 24,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 794.213,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.736134453781514,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3751.6239999999925,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.357,
"layouts": 64,
"layoutDurationMs": 10.41,
"taskDurationMs": 1741.6569999999997,
"heapDeltaBytes": 5785724,
"heapUsedBytes": 80667884,
"domNodes": 24,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 777.437,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.740624999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3166.7090000000826,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.0120000000000005,
"layouts": 4,
"layoutDurationMs": 1.041,
"taskDurationMs": 2034.4510000000002,
"heapDeltaBytes": 22902744,
"heapUsedBytes": 98577052,
"domNodes": 0,
"jsHeapTotalBytes": 4612096,
"scriptDurationMs": 995.6940000000001,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84385026737968,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3083.47700000013,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.577,
"layouts": 5,
"layoutDurationMs": 1.2519999999999996,
"taskDurationMs": 1967.353,
"heapDeltaBytes": 21876364,
"heapUsedBytes": 97914352,
"domNodes": 0,
"jsHeapTotalBytes": 5136384,
"scriptDurationMs": 958.7359999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.84945054945055,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2021.998000000167,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.968,
"layouts": 8,
"layoutDurationMs": 2.94,
"taskDurationMs": 656.4340000000001,
"heapDeltaBytes": 16164452,
"heapUsedBytes": 90287324,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 40.632999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2018.895999999586,
"styleRecalcs": 6,
"styleRecalcDurationMs": 1.2500000000000002,
"layouts": 5,
"layoutDurationMs": 1.2469999999999999,
"taskDurationMs": 594.979,
"heapDeltaBytes": 15887740,
"heapUsedBytes": 90391888,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 29.997999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 696.4109999998982,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.314,
"layouts": 9,
"layoutDurationMs": 2.6209999999999996,
"taskDurationMs": 487.28700000000003,
"heapDeltaBytes": -922120,
"heapUsedBytes": 78264460,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 149.969,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668292682926822,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 638.9199999998709,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.647000000000001,
"layouts": 10,
"layoutDurationMs": 2.197,
"taskDurationMs": 477.44900000000007,
"heapDeltaBytes": -2324992,
"heapUsedBytes": 76654512,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 141.51899999999998,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2023.7230000002455,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.031999999999999,
"layouts": 10,
"layoutDurationMs": 2.8089999999999997,
"taskDurationMs": 653.288,
"heapDeltaBytes": 3890092,
"heapUsedBytes": 82922188,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 11.450999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2007.9719999998815,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.241999999999999,
"layouts": 9,
"layoutDurationMs": 2.486,
"taskDurationMs": 521.111,
"heapDeltaBytes": 3825864,
"heapUsedBytes": 82911040,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.394000000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1973.0560000002697,
"styleRecalcs": 87,
"styleRecalcDurationMs": 15.254999999999997,
"layouts": 9,
"layoutDurationMs": 2.513,
"taskDurationMs": 1089.567,
"heapDeltaBytes": -7811252,
"heapUsedBytes": 71352112,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 113.08400000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66610169491526,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1973.8459999998668,
"styleRecalcs": 87,
"styleRecalcDurationMs": 13.105,
"layouts": 11,
"layoutDurationMs": 2.3939999999999997,
"taskDurationMs": 1032.9899999999998,
"heapDeltaBytes": -7828760,
"heapUsedBytes": 71367444,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 107.57799999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666949152542372,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-transition-enter",
"durationMs": 1469.9860000000626,
"styleRecalcs": 18,
"styleRecalcDurationMs": 30.29500000000001,
"layouts": 5,
"layoutDurationMs": 16.968,
"taskDurationMs": 1132.628,
"heapDeltaBytes": 8739140,
"heapUsedBytes": 112280644,
"domNodes": 16030,
"jsHeapTotalBytes": 17436672,
"scriptDurationMs": 31.679,
"eventListeners": 3246,
"totalBlockingTimeMs": 178,
"frameDurationMs": 20.04594594594594,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 10923.441999999795,
"styleRecalcs": 249,
"styleRecalcDurationMs": 30.313000000000002,
"layouts": 7,
"layoutDurationMs": 1.96,
"taskDurationMs": 6230.087,
"heapDeltaBytes": 6006056,
"heapUsedBytes": 100557312,
"domNodes": 0,
"jsHeapTotalBytes": 6782976,
"scriptDurationMs": 2809.2169999999996,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.691450381679388,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9219.261000000188,
"styleRecalcs": 250,
"styleRecalcDurationMs": 28.456000000000003,
"layouts": 8,
"layoutDurationMs": 2.0050000000000003,
"taskDurationMs": 5953.306,
"heapDeltaBytes": -19006728,
"heapUsedBytes": 75713636,
"domNodes": 0,
"jsHeapTotalBytes": 6852608,
"scriptDurationMs": 2744.0009999999997,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69620253164557,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23589.872000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22940.781000000003,
"heapDeltaBytes": 9046068,
"heapUsedBytes": 290770012,
"domNodes": -3245,
"jsHeapTotalBytes": 25165824,
"scriptDurationMs": 351.45000000000005,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.37263157894738,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-idle",
"durationMs": 22955.24099999966,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22252.658,
"heapDeltaBytes": -32999888,
"heapUsedBytes": 278246200,
"domNodes": -3245,
"jsHeapTotalBytes": 20447232,
"scriptDurationMs": 327.364,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.36380789022298,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 28488.510000000133,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.816,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 28151.976000000006,
"heapDeltaBytes": 5168224,
"heapUsedBytes": 292562252,
"domNodes": -3245,
"jsHeapTotalBytes": 21688320,
"scriptDurationMs": 899.4159999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 41,
"frameDurationMs": 52.58081180811808,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 27811.850999999933,
"styleRecalcs": 181,
"styleRecalcDurationMs": 17.722000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27371.573000000004,
"heapDeltaBytes": 1566664,
"heapUsedBytes": 294621600,
"domNodes": -3245,
"jsHeapTotalBytes": 24571904,
"scriptDurationMs": 876.319,
"eventListeners": -651,
"totalBlockingTimeMs": 38,
"frameDurationMs": 51.41534195933457,
"p95FrameDurationMs": 116.60000000000036
},
{
"name": "vue-node-resize-workload",
"durationMs": 8269.162999999935,
"styleRecalcs": 20,
"styleRecalcDurationMs": 68.61999999999999,
"layouts": 20,
"layoutDurationMs": 23.04700000000001,
"taskDurationMs": 8134.758,
"heapDeltaBytes": 9206756,
"heapUsedBytes": 302274752,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 128.39299999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 44.6827027027027,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 7954.112999999779,
"styleRecalcs": 20,
"styleRecalcDurationMs": 68.47800000000001,
"layouts": 20,
"layoutDurationMs": 22.410000000000014,
"taskDurationMs": 7801.384,
"heapDeltaBytes": 10387520,
"heapUsedBytes": 306424672,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 116.993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.039053254437874,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11802.977000000283,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11532.142999999998,
"heapDeltaBytes": -28058356,
"heapUsedBytes": 280960168,
"domNodes": -3245,
"jsHeapTotalBytes": 17825792,
"scriptDurationMs": 193.80000000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.27133105802048,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11496.744999999919,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11012.359,
"heapDeltaBytes": -26412536,
"heapUsedBytes": 286247448,
"domNodes": -3245,
"jsHeapTotalBytes": 23330816,
"scriptDurationMs": 147.06900000000002,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.24744027303754,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "workflow-execution",
"durationMs": 532.2799999999006,
"styleRecalcs": 24,
"styleRecalcDurationMs": 13.433,
"layouts": 10,
"layoutDurationMs": 3.823,
"taskDurationMs": 167.775,
"heapDeltaBytes": 7500040,
"heapUsedBytes": 82352920,
"domNodes": 138,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 18.788,
"eventListeners": 7,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.223333333333326,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 118.02199999965524,
"styleRecalcs": 7,
"styleRecalcDurationMs": 7.5840000000000005,
"layouts": 7,
"layoutDurationMs": 2.574,
"taskDurationMs": 87.342,
"heapDeltaBytes": 4701288,
"heapUsedBytes": 79674700,
"domNodes": 98,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.532,
"eventListeners": 3,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.671428571428674,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 472.56800000013754,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.64,
"layouts": 76,
"layoutDurationMs": 14.840000000000002,
"taskDurationMs": 419.833,
"heapDeltaBytes": -4575124,
"heapUsedBytes": 38945464,
"domNodes": 4,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 201.769,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 510.9099999999671,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.66,
"layouts": 76,
"layoutDurationMs": 15.482,
"taskDurationMs": 458.947,
"heapDeltaBytes": -3976424,
"heapUsedBytes": 37600648,
"domNodes": 4,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 232.22899999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903227,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 434.1739999999845,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.502,
"layouts": 76,
"layoutDurationMs": 13.124,
"taskDurationMs": 393.91700000000003,
"heapDeltaBytes": -807452,
"heapUsedBytes": 102768776,
"domNodes": 4,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 150.715,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.307692307692307,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 484.9730000000818,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.538,
"layouts": 76,
"layoutDurationMs": 14.057,
"taskDurationMs": 442.31800000000004,
"heapDeltaBytes": -254944,
"heapUsedBytes": 106277676,
"domNodes": 4,
"jsHeapTotalBytes": 1052672,
"scriptDurationMs": 169.997,
"eventListeners": 300,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 64.2% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 3070 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 644b7dac03f86fdfe074f30ae92ef2ab1f7ebb1f
Full docs: ADR-DEVEX-LINT-0015 🏛️ Architecture: ✅ PassedFindings and check detailsWarnings (158)
Reproduce locallypnpm architecture:checkFull docs: Frontend domain catalog |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #21321 +/- ##
==========================================
+ Coverage 86.69% 87.59% +0.90%
==========================================
Files 3903 2749 -1154
Lines 182125 151763 -30362
Branches 49633 42335 -7298
==========================================
- Hits 157887 132935 -24952
+ Misses 21822 18192 -3630
+ Partials 2416 636 -1780
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1189 files with indirect coverage changes 🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
The crash is the constructor aborting inside the first frame, so app.canvas is never assigned and the touch wrapper then reads app.canvas.pointer. startRendering now reports that first-frame throw and leaves is_rendering false, so construction finishes and the assignment happens. The pinch paths skip the gesture when the canvas is still missing and report each entry point once. The mouse-down wrapper clears this.pointer instead of the global, which is the canvas the listener is actually on.
|
|
|
|
|
|
|
|
|
|
|
|
…as and report why (#22278) Backport of #21321 to `core/1.58`. The auto-backport hit cherry-pick conflicts. - Touch handlers no longer crash when `app.canvas` is missing, and they report why. - A throwing first frame no longer aborts `LGraphCanvas` construction. - The diff is the same as the reviewed 1.57 carriers (#21850 and #21851), since `simpleTouchSupport.ts` matches between 1.57 and 1.58. <details><summary>Full context for agent readers</summary> Built by cherry-picking the core/1.57 carrier's resolution onto `core/1.58`. The only conflict was `bootstrapTracer.ts`, where both `_timeoutReported` (already on 1.58) and the new `_outcome` field are kept. Local checks: the touch, startRendering and bootstrapTracer suites pass (30 tests), and `pnpm typecheck` is clean. The AI co-author trailer from the source squash is dropped from this commit. Follow-up #22273 (render loop recovery, pinch scale guard, timed_out outcome) will be backported here after it merges. </details> Part of https://linear.app/comfyorg/issue/FRONT-3716 Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
…vas and report why (#22279) Backport of #21321 to `cloud/1.58`. The auto-backport hit cherry-pick conflicts. - Touch handlers no longer crash when `app.canvas` is missing, and they report why. - A throwing first frame no longer aborts `LGraphCanvas` construction. - The diff is the same as the reviewed 1.57 carriers (#21850 and #21851), since `simpleTouchSupport.ts` matches between 1.57 and 1.58. <details><summary>Full context for agent readers</summary> Built by cherry-picking the core/1.57 carrier's resolution onto `cloud/1.58`. The only conflict was `bootstrapTracer.ts`, where both `_timeoutReported` (already on 1.58) and the new `_outcome` field are kept. Local checks: the touch, startRendering and bootstrapTracer suites pass (30 tests), and `pnpm typecheck` is clean. The AI co-author trailer from the source squash is dropped from this commit. Follow-up #22273 (render loop recovery, pinch scale guard, timed_out outcome) will be backported here after it merges. </details> Part of https://linear.app/comfyorg/issue/FRONT-3716 Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
…as and report why (#21850) Backport of #21321 to `core/1.57` after the automatic carrier conflicted. The target predates the extraction of `touchPointerGuards.ts`, so the resolution keeps the target’s inline pointer guards while applying the source behavior: pinch handlers fail closed through `canvasOrReport`, `processMouseDown` uses its receiver’s pointer, initial render failures are reported without aborting construction, and bootstrap outcome is exposed for diagnostics. No deleted helper was resurrected. Verification: the four focused Vitest files pass (25 tests); targeted ESLint has no errors; targeted formatting passes. Source commit: `42f00b3f1b33d42b8da10b3fbdcd47a97fcbc8a8`. Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: Terry Jia <terryjia88@gmail.com>
…22273) Follow-up to Comfy-Org#21321, from review findings on its backports Comfy-Org#21850 and Comfy-Org#21851. - **The canvas keeps rendering after a frame throws.** Comfy-Org#21321 caught a throwing first frame so the `LGraphCanvas` constructor could finish, but it also stopped the render loop, so the canvas stayed frozen for the rest of the session. Now any frame that throws is reported (each distinct error once). The 2D context is reset to its DPR base transform, both canvases are redrawn, and the loop continues. After 60 failed drawing frames with no successful draw in between, the loop stops, reports `error_rendering_canvas_stopped` and can be restarted. - **Pinch zoom no longer writes NaN, 0 or Infinity into the viewport.** This happened when two fingers touched the same point. A pinch that starts that way now measures from the first move where the fingers are at least 8px apart. - **`bootstrapTracer.outcome` reads `timed_out` after the watchdog fires,** not `pending`, so the missing-canvas report can tell a hung startup from one that is still loading. <details><summary>Full context for agent readers</summary> **Tests, red first.** On `main` these failed: - `is_rendering` was false after a throwing first frame, and no frame was scheduled. - A persistently throwing draw escaped on frame 2 and left `is_rendering` stuck at true. - A same-point pinch changed the viewport. - `outcome` stayed `pending` after the watchdog fired. They pass with this PR. Local results: - `vitest run src/extensions/core src/lib/litegraph/src/LGraphCanvas* src/platform/telemetry/perf`: 1793 passed. - `pnpm typecheck`, oxlint and eslint are clean. - The pre-push hooks pass: depcruise, knip and the fallow audit. **Review rounds.** CodeRabbit and Cursor review findings on the first heads are addressed in 8014af1: context reset, dirty marking, failure counting that ignores idle frames, an outer guard on the first frame, the 8px pinch threshold, no inline comments, and a later-frame failure test. **Adversarial review.** A fresh Claude reviewer ran on the first push (Codex is unavailable on this host). Its HIGH finding: a persistent failure still killed the loop on frame 2, and `is_rendering` stayed stuck. This push addresses that with the bounded retry, frame-level tests and stronger pinch assertions. **Also changed:** - The touchmove pinch branch moved into `handlePinchMove`, to stay under the complexity gate. - The test no longer imports `@/scripts/app`, which was a boundary-rule violation. **Not changed.** The `canvasOrReport('processMouseDown')` false-positive finding on the backports does not apply to `main`, which has no processMouseDown wrapper in `simpleTouchSupport.ts`. **Backports.** Labels are set for 1.57, 1.58 and 1.59. The 1.57 and 1.58 lines need the Comfy-Org#21321 carriers first; 1.59 already has Comfy-Org#21321. </details> Part of https://linear.app/comfyorg/issue/FRONT-3716
Requested via Slack thread
Summary
Before: If
app.canvaswas never assigned, every click on the canvas threwTypeError: Cannot read properties of undefined (reading 'pointer')from the touch-supportprocessMouseDownwrapper, and the two-finger touch handlers threw the same way. One production RUM session shows how that state arises: a browser userscript patchesCanvasRenderingContext2D.drawImageand throws. The throw happens in the first synchronous frame insidenew LGraphCanvas(...)(startRendering->renderFrame->draw->drawFrontCanvas), soComfyApp.setup()aborts beforeapp.canvasis assigned. Event listeners were already bound by then, so each click hit the wrapper with no canvas. The app stayed unusable for the whole session.After: The wrapper uses the canvas it is called on (
this.pointer) instead of the global, and the touch handlers readapp.canvasOrUndefinedonce and skip the gesture when it is missing. A throwing first frame no longer abortsLGraphCanvasconstruction: it is reported and the instance finishes constructing, soapp.canvasgets assigned. Per-frame behaviour is unchanged.How
simpleTouchSupport.ts:this.pointer.isDown = falsein theprocessMouseDownwrapper;canvasOrReportguards in thetouchstartandtouchmovepinch paths; pinch math moved intozoomCanvasAroundPinchunchanged.touchCanvasAccess.ts: when a touch or pointer entry point finds no canvas, report once per entry point per page load (errorType: error_handling_touch_input_missing_canvas, level warning) with context: entry point, event type, pointer type, isPrimary,document.readyState, startup outcome (pending/completed/failed), whetherwindow.appis defined, whether the canvas element exists and is connected, and whether the event target is the canvas element. No URLs, user data or ids.bootstrapTracer.ts: read-onlyoutcomegetter so the report can say whether startup failed.LGraphCanvas.startRendering: the initialrenderFramecall is wrapped; on failure it resetsis_rendering, reportserror_rendering_canvas_initial_frameand returns instead of throwing out of the constructor.Verification
drawImageabove), not proven for every occurrence. The new telemetry is meant to show whether other sessions share it or have a different cause.pnpm test:unitonsimpleTouchSupport.test.ts,touchCanvasAccess.test.ts,LGraphCanvas.startRendering.test.ts,bootstrapTracer.test.ts(30 passing). The new wrapper and construction tests fail against the previous code.drawImage.@error.type:error_handling_touch_input_missing_canvasand@error.type:error_rendering_canvas_initial_framein Datadog and group bybootstrapOutcomeandentryPoint.Generated by Claude Code