Repository navigation
refactor(billing): remove the core app's embedded checkout UI - #21170
Conversation
Checkout UI now lives in billing-web. The core app drops its reads of the embedded_checked_enabled server flag and always takes the former flag-off path: hosted checkout (Stripe or billing-web per hosted_billing_destination). Removes the embedded-only payment element wiring, saved payment methods, promotion-code quotes and stale-quote recovery, the Stripe return-URL loader, the in-page 3DS challenge handling on both billing rails, and the embedded checkout E2E spec. The checkout journey still records the server assignment arm from the raw feature payload, with ui_mode always hosted.
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-17T00:07:08.618Z",
"gitSha": "5b476b837eccca2f049f151349660653a8c1c871",
"branch": "claude/remove-core-embedded-checkout",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.0260000000058,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.6479999999999997,
"layouts": 10,
"layoutDurationMs": 2.813,
"taskDurationMs": 392.983,
"heapDeltaBytes": -19538772,
"heapUsedBytes": 59075792,
"domNodes": -162,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 7.934,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-idle",
"durationMs": 2006.185999999957,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.2429999999999994,
"layouts": 11,
"layoutDurationMs": 3.531,
"taskDurationMs": 387.415,
"heapDeltaBytes": -5204108,
"heapUsedBytes": 59127904,
"domNodes": -162,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 9.024000000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1727.0399999999881,
"styleRecalcs": 75,
"styleRecalcDurationMs": 13.458000000000002,
"layouts": 10,
"layoutDurationMs": 2.7819999999999996,
"taskDurationMs": 766.038,
"heapDeltaBytes": 3325156,
"heapUsedBytes": 81977976,
"domNodes": -162,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 159.67000000000002,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666346153846156,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1716.2080000000515,
"styleRecalcs": 73,
"styleRecalcDurationMs": 13.221999999999998,
"layouts": 9,
"layoutDurationMs": 2.692,
"taskDurationMs": 725.0920000000001,
"heapDeltaBytes": -7231360,
"heapUsedBytes": 56313344,
"domNodes": -162,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 150.023,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.8300000000445,
"styleRecalcs": 20,
"styleRecalcDurationMs": 5.419,
"layouts": 11,
"layoutDurationMs": 2.941,
"taskDurationMs": 394.32500000000005,
"heapDeltaBytes": 24416752,
"heapUsedBytes": 88940868,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 11.450999999999999,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1707.0240000000467,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.431,
"layouts": 11,
"layoutDurationMs": 3.837,
"taskDurationMs": 419.36699999999996,
"heapDeltaBytes": -163356,
"heapUsedBytes": 78603516,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 12.472000000000001,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 658.141999999998,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.4149999999999996,
"layouts": 8,
"layoutDurationMs": 2.388,
"taskDurationMs": 485.589,
"heapDeltaBytes": 1991612,
"heapUsedBytes": 72806348,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 164.325,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66923076923077,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 667.1649999999545,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.629,
"layouts": 9,
"layoutDurationMs": 2.5280000000000005,
"taskDurationMs": 484.54,
"heapDeltaBytes": 25750204,
"heapUsedBytes": 89887756,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 165.91699999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667500000000008,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1103.962000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 725.9590000000001,
"heapDeltaBytes": 17882980,
"heapUsedBytes": 97572544,
"domNodes": 0,
"jsHeapTotalBytes": 20086784,
"scriptDurationMs": 62.872,
"eventListeners": 0,
"totalBlockingTimeMs": 481,
"frameDurationMs": 33.333333333333336,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1122.9919999999538,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 801.226,
"heapDeltaBytes": 18060628,
"heapUsedBytes": 98621988,
"domNodes": 0,
"jsHeapTotalBytes": 18776064,
"scriptDurationMs": 63.613000000000014,
"eventListeners": 0,
"totalBlockingTimeMs": 491,
"frameDurationMs": 33.83636363636365,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 825.7259999999746,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.14199999999994,
"heapDeltaBytes": -4818632,
"heapUsedBytes": 74508260,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 152.25499999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 207,
"frameDurationMs": 24.50882352941177,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 832.6200000000199,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.36899999999997,
"heapDeltaBytes": -4735936,
"heapUsedBytes": 73641752,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 146.968,
"eventListeners": 0,
"totalBlockingTimeMs": 201,
"frameDurationMs": 24.50882352941177,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9824.815999999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9038.001000000002,
"heapDeltaBytes": -10873652,
"heapUsedBytes": 72818748,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 7193.482999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 659,
"frameDurationMs": 31.215873015873015,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9255.655000000046,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8433.161,
"heapDeltaBytes": -13584228,
"heapUsedBytes": 69774896,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 6739.396,
"eventListeners": 0,
"totalBlockingTimeMs": 392,
"frameDurationMs": 31.24864864864865,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9253.254999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8506.912,
"heapDeltaBytes": -92212,
"heapUsedBytes": 83417592,
"domNodes": 0,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 6802.765,
"eventListeners": 0,
"totalBlockingTimeMs": 503,
"frameDurationMs": 31.461224489795914,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10234.35100000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9428.338,
"heapDeltaBytes": 6373512,
"heapUsedBytes": 89720440,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 7681.094,
"eventListeners": 0,
"totalBlockingTimeMs": 1025,
"frameDurationMs": 30.637425149700597,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 202.541999999994,
"styleRecalcs": 22,
"styleRecalcDurationMs": 11.233,
"layouts": 8,
"layoutDurationMs": 2.1540000000000004,
"taskDurationMs": 142.75000000000003,
"heapDeltaBytes": 13273580,
"heapUsedBytes": 77188164,
"domNodes": 917,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.004000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.22222222222217,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 186.6820000000189,
"styleRecalcs": 23,
"styleRecalcDurationMs": 12.944,
"layouts": 11,
"layoutDurationMs": 2.8989999999999996,
"taskDurationMs": 140.435,
"heapDeltaBytes": 13227784,
"heapUsedBytes": 76721676,
"domNodes": 917,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 8.216999999999999,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.912500000000023,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "large-graph-idle",
"durationMs": 2043.565000000001,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.6249999999999998,
"layouts": 6,
"layoutDurationMs": 1.5150000000000003,
"taskDurationMs": 582.649,
"heapDeltaBytes": -10796544,
"heapUsedBytes": 74212464,
"domNodes": -258,
"jsHeapTotalBytes": -262144,
"scriptDurationMs": 31.663999999999998,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2052.1439999999984,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.2579999999999996,
"layouts": 9,
"layoutDurationMs": 2.569,
"taskDurationMs": 602.1229999999999,
"heapDeltaBytes": -11272456,
"heapUsedBytes": 74628936,
"domNodes": -258,
"jsHeapTotalBytes": -1310720,
"scriptDurationMs": 34.389,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2145.2639999999974,
"styleRecalcs": 66,
"styleRecalcDurationMs": 5,
"layouts": 4,
"layoutDurationMs": 0.8649999999999999,
"taskDurationMs": 1406.8449999999998,
"heapDeltaBytes": 16606024,
"heapUsedBytes": 81367712,
"domNodes": -258,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 796.132,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2527.904999999919,
"styleRecalcs": 64,
"styleRecalcDurationMs": 4.374,
"layouts": 2,
"layoutDurationMs": 0.5070000000000001,
"taskDurationMs": 1602.1000000000001,
"heapDeltaBytes": 15260852,
"heapUsedBytes": 81077544,
"domNodes": 0,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 784.338,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.777333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3390.3760000000034,
"styleRecalcs": 69,
"styleRecalcDurationMs": 5.842000000000001,
"layouts": 63,
"layoutDurationMs": 9.449000000000002,
"taskDurationMs": 1451.4170000000001,
"heapDeltaBytes": 3840820,
"heapUsedBytes": 71084156,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 738.116,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66600985221675,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3448.988999999983,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.126000000000001,
"layouts": 62,
"layoutDurationMs": 9.373,
"taskDurationMs": 1516.937,
"heapDeltaBytes": -106936,
"heapUsedBytes": 67214832,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 758.396,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666183574879224,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2831.2609999999836,
"styleRecalcs": 41,
"styleRecalcDurationMs": 3.5579999999999994,
"layouts": 2,
"layoutDurationMs": 0.4469999999999999,
"taskDurationMs": 1867.509,
"heapDeltaBytes": 8794796,
"heapUsedBytes": 76078604,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 925.123,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.965868263473055,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3067.0290000000477,
"styleRecalcs": 41,
"styleRecalcDurationMs": 4.351999999999999,
"layouts": 2,
"layoutDurationMs": 0.464,
"taskDurationMs": 1936.586,
"heapDeltaBytes": 18046868,
"heapUsedBytes": 87195892,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 939.473,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.943333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2022.154999999998,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.3559999999999997,
"layouts": 5,
"layoutDurationMs": 1.3699999999999997,
"taskDurationMs": 582.535,
"heapDeltaBytes": 10028220,
"heapUsedBytes": 76122020,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 33.517,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2010.5250000000296,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.085,
"layouts": 4,
"layoutDurationMs": 1.1909999999999998,
"taskDurationMs": 554.7090000000002,
"heapDeltaBytes": 10030920,
"heapUsedBytes": 75864268,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 30.622999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 560.6659999999692,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.665000000000001,
"layouts": 10,
"layoutDurationMs": 2.8389999999999995,
"taskDurationMs": 385.00500000000005,
"heapDeltaBytes": 2133192,
"heapUsedBytes": 82797296,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 141.63600000000002,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823537,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 575.4429999999502,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.239,
"layouts": 8,
"layoutDurationMs": 2.057,
"taskDurationMs": 422.20599999999996,
"heapDeltaBytes": -931172,
"heapUsedBytes": 64492976,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 142.595,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714277,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2008.322000000021,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.3819999999999997,
"layouts": 10,
"layoutDurationMs": 2.8970000000000002,
"taskDurationMs": 534.531,
"heapDeltaBytes": -2940276,
"heapUsedBytes": 62262560,
"domNodes": -180,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 7.662000000000001,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.149999999987,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.7840000000000007,
"layouts": 9,
"layoutDurationMs": 2.9949999999999997,
"taskDurationMs": 545.995,
"heapDeltaBytes": -6543720,
"heapUsedBytes": 59031484,
"domNodes": -180,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 8.015,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.2630000000113,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.288999999999998,
"layouts": 9,
"layoutDurationMs": 2.0500000000000003,
"taskDurationMs": 651.141,
"heapDeltaBytes": -796908,
"heapUsedBytes": 79961628,
"domNodes": -180,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 100.078,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1977.3959999999988,
"styleRecalcs": 86,
"styleRecalcDurationMs": 14.579000000000002,
"layouts": 10,
"layoutDurationMs": 3.4360000000000004,
"taskDurationMs": 922.212,
"heapDeltaBytes": 15294852,
"heapUsedBytes": 80484192,
"domNodes": -180,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 108.452,
"eventListeners": -114,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665546218487393,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1436.4719999999807,
"styleRecalcs": 19,
"styleRecalcDurationMs": 25.645999999999994,
"layouts": 5,
"layoutDurationMs": 16.194999999999997,
"taskDurationMs": 1063.68,
"heapDeltaBytes": 7324548,
"heapUsedBytes": 103930460,
"domNodes": 15950,
"jsHeapTotalBytes": 16916480,
"scriptDurationMs": 29.737999999999992,
"eventListeners": 3244,
"totalBlockingTimeMs": 159,
"frameDurationMs": 19.594594594594593,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8247.320000000002,
"styleRecalcs": 248,
"styleRecalcDurationMs": 16.447,
"layouts": 5,
"layoutDurationMs": 1.3970000000000002,
"taskDurationMs": 4964.254,
"heapDeltaBytes": -23198680,
"heapUsedBytes": 76400412,
"domNodes": -278,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 2612.712,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69979674796748,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8199.738000000025,
"styleRecalcs": 248,
"styleRecalcDurationMs": 16.845,
"layouts": 6,
"layoutDurationMs": 1.572,
"taskDurationMs": 4970.313,
"heapDeltaBytes": -7676316,
"heapUsedBytes": 77611676,
"domNodes": -258,
"jsHeapTotalBytes": 1798144,
"scriptDurationMs": 2618.5519999999997,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 22982.032000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22149.234,
"heapDeltaBytes": 3575908,
"heapUsedBytes": 287790096,
"domNodes": -3330,
"jsHeapTotalBytes": 12308480,
"scriptDurationMs": 344.503,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.6248275862069,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 22544.481000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21668.398,
"heapDeltaBytes": 28445932,
"heapUsedBytes": 280045264,
"domNodes": -3330,
"jsHeapTotalBytes": 16777216,
"scriptDurationMs": 322.71799999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.715463917525774,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 19163.546999999995,
"styleRecalcs": 164,
"styleRecalcDurationMs": 13.156,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 18645.15,
"heapDeltaBytes": -38318636,
"heapUsedBytes": 263801960,
"domNodes": -3330,
"jsHeapTotalBytes": 11784192,
"scriptDurationMs": 790.3679999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 13,
"frameDurationMs": 35.16678899082569,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-pan",
"durationMs": 27257.44599999996,
"styleRecalcs": 181,
"styleRecalcDurationMs": 15.322000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 26808.319999999996,
"heapDeltaBytes": -1752844,
"heapUsedBytes": 256325492,
"domNodes": 0,
"jsHeapTotalBytes": -5242880,
"scriptDurationMs": 865.875,
"eventListeners": 2,
"totalBlockingTimeMs": 27,
"frameDurationMs": 50.182320441988956,
"p95FrameDurationMs": 100.10000000000036
},
{
"name": "vue-node-resize-workload",
"durationMs": 7894.627999999898,
"styleRecalcs": 20,
"styleRecalcDurationMs": 87.50700000000003,
"layouts": 20,
"layoutDurationMs": 27.40300000000001,
"taskDurationMs": 7746.445999999999,
"heapDeltaBytes": -2994040,
"heapUsedBytes": 276874240,
"domNodes": -3330,
"jsHeapTotalBytes": 17813504,
"scriptDurationMs": 139.549,
"eventListeners": -653,
"totalBlockingTimeMs": 30,
"frameDurationMs": 45.66242774566474,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-node-resize-workload",
"durationMs": 5880.053999999973,
"styleRecalcs": 20,
"styleRecalcDurationMs": 69.356,
"layouts": 20,
"layoutDurationMs": 22.155999999999995,
"taskDurationMs": 5741.296000000001,
"heapDeltaBytes": -19961936,
"heapUsedBytes": 269102760,
"domNodes": -3330,
"jsHeapTotalBytes": 20172800,
"scriptDurationMs": 94.62199999999999,
"eventListeners": -653,
"totalBlockingTimeMs": 15,
"frameDurationMs": 33.617714285714285,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11538.215000000037,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11035.430999999999,
"heapDeltaBytes": -3665000,
"heapUsedBytes": 255570664,
"domNodes": 0,
"jsHeapTotalBytes": -3145728,
"scriptDurationMs": 158.79099999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.4958904109589,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11586.320999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11147.436000000002,
"heapDeltaBytes": -21301532,
"heapUsedBytes": 259562828,
"domNodes": 0,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 182.77700000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.13141891891891,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 494.28100000000086,
"styleRecalcs": 19,
"styleRecalcDurationMs": 11.938999999999998,
"layouts": 10,
"layoutDurationMs": 4.439,
"taskDurationMs": 150.052,
"heapDeltaBytes": -12386576,
"heapUsedBytes": 64038664,
"domNodes": 126,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 16.199,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379302,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 489.94599999991806,
"styleRecalcs": 21,
"styleRecalcDurationMs": 11.564000000000002,
"layouts": 11,
"layoutDurationMs": 4.403,
"taskDurationMs": 134.525,
"heapDeltaBytes": 6910280,
"heapUsedBytes": 71588204,
"domNodes": 121,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.839,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.237931034482763,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 450.3429999999753,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.691,
"layouts": 76,
"layoutDurationMs": 14.295,
"taskDurationMs": 402.648,
"heapDeltaBytes": 11423384,
"heapUsedBytes": 88708828,
"domNodes": 4,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 196.858,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662962962962983,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 425.4720000000134,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.7739999999999999,
"layouts": 76,
"layoutDurationMs": 13.75,
"taskDurationMs": 386.575,
"heapDeltaBytes": -19463608,
"heapUsedBytes": 67340600,
"domNodes": 4,
"jsHeapTotalBytes": 12058624,
"scriptDurationMs": 186.6,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 443.2679999999891,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.528,
"layouts": 76,
"layoutDurationMs": 12.876999999999999,
"taskDurationMs": 409.72600000000006,
"heapDeltaBytes": -756068,
"heapUsedBytes": 115727364,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 162.95399999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664285714285693,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 411.86199999992823,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.616,
"layouts": 76,
"layoutDurationMs": 11.719999999999999,
"taskDurationMs": 373.061,
"heapDeltaBytes": -1335320,
"heapUsedBytes": 115513976,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 144.028,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.332000000000008,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
🎭 Playwright: ✅ 2282 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (57 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 3a708645fb31a71b741d86f8ab6c37bd3e3253e9
Full docs: ADR-DEVEX-LINT-0015 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #21170 +/- ##
==========================================
+ Coverage 86.56% 87.40% +0.83%
==========================================
Files 3748 2671 -1077
Lines 177214 148154 -29060
Branches 48987 38509 -10478
==========================================
- Hits 153411 129491 -23920
+ Misses 21740 18273 -3467
+ Partials 2063 390 -1673
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1084 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Read the removal in useSubscriptionCheckout.ts, billingOperationStore.ts, createBillingSdk.ts, and checkoutJourney.ts, plus the flag drop in useFeatureFlags/serverFeatureFlag.ts. The dead-branch removal is mechanical and consistent — every embeddedCheckoutEnabled conditional collapses to its flag-off branch, matching the "behaviour delta: none expected" claim. "Kept on purpose" items checked against the diff: resolveCheckoutAssignment's telemetry read, the operation types' shared authentication fields, and billing-web/packages/account-ui/packages/account-core/ingest are all untouched as stated.
One non-blocking note: checkoutJourney.ts's EMBEDDED_CHECKOUT_FLAG_KEY loses its type anchor —
-const EMBEDDED_CHECKOUT_FLAG_KEY: `${ServerFeatureFlag.EMBEDDED_CHECKOUT_ENABLED}` =
- 'embedded_checked_enabled'
+const EMBEDDED_CHECKOUT_FLAG_KEY = 'embedded_checked_enabled'The deleted comment explained exactly why this mattered: it's typed to the enum member so a future correction of the server's flag key (or its checked/checkout typo) fails to compile instead of silently reading a stale key. This PR removes ServerFeatureFlag.EMBEDDED_CHECKOUT_ENABLED itself (since the flag is otherwise fully retired), so there's no longer anything else in the codebase that would break if this string drifted from the server's actual name — the exact failure mode the guard existed to catch, now unguarded on the one place that still reads it live for telemetry. Worth a trivial follow-up (e.g. a local literal type pinned to the string itself, or keeping the enum member solely as a type anchor with a comment saying why) rather than a bare untyped string, but it isn't a behavior change today and doesn't need to block this.
No open threads. CI settled (110 pass / 38 skip, no failures). Approving.
…bedded-checkout # Conflicts: # src/platform/workspace/components/TopUpCreditsDialogContentWorkspace.vue
6bd0897
…bedded-checkout # Conflicts: # docs/architecture/domains/boundaries.json # docs/architecture/domains/records/billing.domain.json
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 7 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 3d9101c | Docs | View more details | Give us feedback! |
christian-byrne
left a comment
There was a problem hiding this comment.
Re-reviewing after the approval dismissal: the two commits since my prior approval
(6bd0897e59b0, 3d9101cdc2dc) are both plain Merge remote-tracking branch 'origin/main'
commits with no conflict-resolution edits — the PR's own diff against base is byte-identical to
the original commit 7612a348a1bf (53 files, +180/-4515). Confirmed via git diff 7612a348a1bf 3d9101cdc2dc -- <PR's changed files> and by comparing gh pr diff's patch output to
that single commit. So this is the same change I already reviewed, rebased onto a newer main,
not new content.
CI is fully green at this head: the four FAILURE entries GitHub shows in the rollup
(billing-web-e2e-gate, billing-web-unit-gate, website-unit-gate, website-e2e,
lint-and-format, test, e2e-status) were all from a run that started and failed within the
same ~10-second window, then superseded by a second run on the same head that passed each of
those checks (confirmed per-check via the check-runs API, not just the rollup). The remaining
CANCELLED entries (merge-reports, playwright-tests*, sharded) never got a second run, but
this PR doesn't touch anything those gate on. No open review threads; CodeRabbit's current state
is APPROVED.
Approving again on the current head.
|
|
|
|
…eckout when top-up has no default payment method (#21180) (#21218) Manual backport of #21180 (FE-1908 / DES-1033). The bot's cherry-pick hit conflicts. ## Why On the consolidated billing rail, top-up dead-ends with `NO_PAYMENT_METHOD` when the workspace has no Stripe invoice default. This backport brings the hosted-checkout recovery, the billing-web `return_url` for non-cloud-web origins, and the Desktop billing-tab handoff (#21198, folded into #21180) to this release line. ## Root cause Off-session top-up charges only the Stripe customer's invoice default, and the dialog had no recovery when that was missing. Details and fix design are in #21180. ## How Cherry-pick of the #21180 squash commit, with the conflicts resolved as below. ## Conflict resolution `main` has #21170 (removes `retryPaymentAuthentication` / the embedded checkout UI) and #21159 (the `no-redundant-component-classes` lint rule). This branch has neither, so: - `useTopupOperation.ts` and `TopUpCreditsDialogContentWorkspace.vue` keep this branch's `retryPaymentAuthentication` / `resumeTopupAuthentication` and add `createHostedCheckout` and `showAmountStep` next to them. - `openHostedBillingTab.ts` adds only the `reserveBillingTab` import. This branch reads `readCheckoutOperation` from `useBillingContext`; there is no `billingRefresh` module here. - The dialog uses this branch's `<h2>` titles instead of `DialogTitle`. The new buttons follow this branch's `h-10 justify-center` classes. The `BILLING_ACTION_NAME` attribute, which doesn't exist on this branch, is not added. ## Verification `vitest` on the top-up dialog, `platform/workspace/billing`, `useTopupOperation`, `useWorkspaceBilling` and `composables/billing`: all pass. The pre-commit hook ran lint and typecheck. ## AS IS / TO BE | AS IS | TO BE | | --- | --- | | Same as #21180 (Desktop video there) | Same as #21180 (Desktop video there) | See #21180 for the AS IS / TO BE recordings; this backport has no behavior of its own.
…heckout when top-up has no default payment method (#21180) (#21219) Manual backport of #21180 (FE-1908 / DES-1033). The bot's cherry-pick hit conflicts. ## Why On the consolidated billing rail, top-up dead-ends with `NO_PAYMENT_METHOD` when the workspace has no Stripe invoice default. This backport brings the hosted-checkout recovery, the billing-web `return_url` for non-cloud-web origins, and the Desktop billing-tab handoff (#21198, folded into #21180) to this release line. ## Root cause Off-session top-up charges only the Stripe customer's invoice default, and the dialog had no recovery when that was missing. Details and fix design are in #21180. ## How Cherry-pick of the #21180 squash commit, with the conflicts resolved as below. ## Conflict resolution `main` has #21170 (removes `retryPaymentAuthentication` / the embedded checkout UI) and #21159 (the `no-redundant-component-classes` lint rule). This branch has neither, so: - `useTopupOperation.ts` and `TopUpCreditsDialogContentWorkspace.vue` keep this branch's `retryPaymentAuthentication` / `resumeTopupAuthentication` and add `createHostedCheckout` and `showAmountStep` next to them. - `openHostedBillingTab.ts` adds only the `reserveBillingTab` import. This branch reads `readCheckoutOperation` from `useBillingContext`; there is no `billingRefresh` module here. - The dialog uses this branch's `<h2>` titles instead of `DialogTitle`. The new buttons follow this branch's `h-10 justify-center` classes. The `BILLING_ACTION_NAME` attribute, which doesn't exist on this branch, is not added. ## Verification `vitest` on the top-up dialog, `platform/workspace/billing`, `useTopupOperation`, `useWorkspaceBilling` and `composables/billing`: all pass. The pre-commit hook ran lint and typecheck. ## AS IS / TO BE | AS IS | TO BE | | --- | --- | | Same as #21180 (Desktop video there) | Same as #21180 (Desktop video there) | See #21180 for the AS IS / TO BE recordings; this backport has no behavior of its own.
|
|
|
|
Summary
Removes the core app's in-app embedded checkout (the Stripe Payment Element rendered inside the cloud pricing dialog) and the core frontend's reads of
embedded_checked_enabled. Checkout UI now lives on billing-web; the core app always takes today's flag-off path: the Stripe hosted page or billing-web, chosen byhosted_billing_destination.Why
billing.checkout.enteredwithui_mode=embedded, last 14 days: 599 entries on billing.comfy.org, and 2 entries from 1 person on cloud.comfy.org. In prod the flag targets a single test account.hosted_billing_destination, so an account routed to billing-web never reaches it. This is the screen QA saw on testcloud with onlyembedded_checked_enabledon.Discussed in #proj-billing (thread on
embedded_checked_enabled). The ingest change that makes billing-web independent of the flag is separate (cloud, Wei).How
useFeatureFlags/ServerFeatureFlag/ remote-config types: dropembeddedCheckoutEnabledandembedded_checked_enabled.useSubscriptionCheckout: remove every embedded branch: saved payment methods, promo previews, quote identity and stale-quote recovery, confirmation tokens, the embedded reactivation decision,paymentReturnUrl(). Return URL is always/payment/success; journeyuiModeis alwayshosted.billingSdkStore/createBillingSdk/billingOperationStore/useTopupOperation: remove Stripe loading, in-page 3DS challenge driving and retry, and the challenge-paused polling. Flag-off polling order is unchanged.usePaymentReturnUrlLoader,stripePublishableKey.ts, the Payment Element test, and theembeddedCheckoutSdkRaile2e spec.stripPaymentReturnParamsstays.VITE_STRIPE_PUBLISHABLE_KEY(billing-web keeps its own), four embedded-only i18n keys, and stale oxlint suppression counts.Kept on purpose:
resolveCheckoutAssignmentstill records the server-assignedembedded_checked_enabledarm in checkout telemetry (ADR BILLING-CHECKOUT-0031). It's passed through, not used for a decision.packages/account-ui,packages/account-coreand ingest types are untouched.Behaviour delta for flag-off users: none expected. The only visible removal is the top-up "resume challenge" button, which needed an in-page challenge and so could not appear with the flag off.
Non-test diff: +47 / −1095 (53 files incl. tests, +180 / −4515).
Verification
pnpm exec vitest run src/platform/workspace src/platform/cloud/subscription src/composables src/components/dialog/GlobalDialog.test.ts: 287 files, 5693 passed.pnpm typecheck, oxlint (type-aware), eslint, oxfmt, knip: clean (git hooks also ran).authentication_state === 'reconciliation_needed'alone no longer reconciles.embedded_checked_enabledoverridden on should now land on billing-web (or the Stripe page) from the core app, never the in-app card form.embedded_checked_enabledon)Plan position (IR-146 follow-ups)
embedded_checked_enabledhosted_billing_destination