Repository navigation
[backport core/1.57] FE-3099 feat(auth): keep local SSO tokens in localStorage, refreshing under a cross-tab lock - #21196
Conversation
… under a cross-tab lock (#21168) ## Summary Resolves D3 (where Local SSO keeps the refresh token) the same way Firebase sign-in already works on a local ComfyUI page: the OAuth tokens persist in `localStorage`. A reload or a new tab now stays signed in instead of going back through the authorize redirect. - Linear: FE-3099 - Decision thread: #proj-sso, D3 (options A sessionStorage / B localStorage / C core httpOnly cookie). This PR implements **B**, matching today's non-SSO Local behavior. ## Why F4 (#20722) kept the tokens in memory until D3 was decided, so every reload or new tab on `127.0.0.1:8188` meant signing in again. Cloud survives a reload through its httpOnly session cookie, and Desktop survives through its main process. A loopback page has neither. Firebase sign-in on Local already keeps its refresh token in browser storage, so Local SSO now matches it. ## How - **`createStorageTokenStore`** - Persists the tokens under `Comfy.LocalWebSignIn.Tokens`. - Validates the stored value with zod; anything malformed reads as signed out. - Returns the same object until the stored string changes. - Reports `storage` events for its key (or a full clear) from other tabs. - **Cross-tab refresh lock.** Ingest rotates refresh tokens and treats reuse as theft, so two tabs refreshing with the same token would revoke the session. - Refresh runs under a Web Lock (`navigator.locks`, always available on loopback because it's a secure context). - Once it holds the lock, it re-reads storage. A tab that waited adopts the rotation another tab already made instead of spending the rotated-away token. - The "did someone sign out mid-refresh" check now compares refresh tokens instead of object identity, which no longer holds across tabs. - **Tab sync.** The bridge subscribes to the store, so signing in or out in one tab re-emits the auth state in the others. - `createMemoryTokenStore` stays as the test double. Risk trade-off, as discussed in the D3 thread: a custom-node frontend extension on the same origin can read `localStorage`. The same is already true for the Firebase refresh token on Local today. Rotation plus reuse detection limit a stolen token. OAuth refresh tokens have no revoke endpoint yet. ### Compared with Firebase sign-in on Local | | Firebase (Local today) | Local SSO OAuth (this PR) | |---|---|---| | Storage | `localStorage` (`browserLocalPersistence` first in `src/platform/auth/firebaseIdentity.ts`) | `localStorage` | | Access token | ID token, 1 h | OAuth access token, refreshed within 60 s of expiry | | Idle expiry of the refresh token | None | 30 days (`OAUTH_REFRESH_TOKEN_TTL`, renewed on each rotation) | | Absolute lifetime | None | None | | Re-checked on refresh | Account state only (deleted, disabled, password or email changed, admin revoke) | User, workspace membership, SSO policy and client (`revalidateOAuthMintState` in ingest) | | Rotation and reuse detection | No | Yes, with a 60 s grace (`OAUTH_REFRESH_REUSE_GRACE`) | Local SSO is as strict as Firebase or stricter on every row. A removed member, an SSO policy change, or a disabled `comfy-local-web` client is cut off at the next refresh, however long the token has been stored. The refresh TTL is a single ingest setting for every OAuth client, so Desktop (`comfy-desktop`) already ships with the same lifetime. Neither has the 7-day absolute cap of the Cloud web session. Adding one would be an ingest policy change, not something the frontend should enforce. ## Verification - `pnpm exec vitest run src/platform/auth`: 521 passed. New tests: - store: round trip across store instances; malformed values read as signed out; clear; storage events only for its key. - bridge: a reload stays signed in without hitting the token endpoint; with two tabs sharing storage and a lock, both expiring tabs end up on the rotated token with a single refresh request (the second tab never spends `refresh-1`); another tab's sign-out reaches this tab's listeners. - Typecheck, oxlint, eslint and knip pass (git hooks). AS IS / TO BE (local ComfyUI on 127.0.0.1 with `local_web_sso` on, signed in through Cloud, then reload / open a second tab): | AS IS | TO BE | |---|---| | _pending_ | _pending_ | ## Plan position (Local SSO, FE-3099 / FE-2170) | Item | PR | State | |---|---|---| | B1–B5, K1 (cloud) | cloud#12827, #12884, #12885, #12886, #12887, #12828, #13131 | merged | | F1–F5 | #20720, #20721, #20722, #20725, #20791 | merged | | **D3: persist tokens (this PR)** | this PR | **in review** | | Decision record (D1, D3 outcome) | #20953 | open | | C1 core renew | Comfy-Org/ComfyUI#16943 | review required | | F6 QA, then K1 off | — | after C1 | ```mermaid graph LR F4["F4: browser auth bridge (PR 20722)"] --> D3["D3: localStorage tokens (this PR)"] D3 --> F6["F6: QA"] C1["C1: core renew (ComfyUI 16943)"] --> F6 F6 --> K1["K1 off: enable mint in prod"] style D3 fill:#f9d71c,stroke:#333,stroke-width:2px ```
📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-16T23:13:18.301Z",
"gitSha": "3e4956eba62867560bc59b6cb100357f510f4652",
"branch": "backport-21168-to-core-1.57",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2023.800000000051,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.0879999999999996,
"layouts": 9,
"layoutDurationMs": 3.1809999999999996,
"taskDurationMs": 525.34,
"heapDeltaBytes": 22136344,
"heapUsedBytes": 87908072,
"domNodes": 0,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 10.894999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2020.9649999999328,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.975,
"layouts": 9,
"layoutDurationMs": 2.997,
"taskDurationMs": 551.0429999999999,
"heapDeltaBytes": 21335928,
"heapUsedBytes": 87165960,
"domNodes": 0,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 12.322,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1719.5449999999823,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.47,
"layouts": 9,
"layoutDurationMs": 2.6339999999999995,
"taskDurationMs": 755.528,
"heapDeltaBytes": 15639568,
"heapUsedBytes": 81096240,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 168.10899999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1776.0050000000547,
"styleRecalcs": 76,
"styleRecalcDurationMs": 16.012999999999998,
"layouts": 9,
"layoutDurationMs": 2.7140000000000004,
"taskDurationMs": 894.365,
"heapDeltaBytes": -7265948,
"heapUsedBytes": 68360160,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 163.55199999999996,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666355140186912,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1705.8289999999943,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.441,
"layouts": 11,
"layoutDurationMs": 3.184,
"taskDurationMs": 304.902,
"heapDeltaBytes": 18731044,
"heapUsedBytes": 84447696,
"domNodes": 47,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 12.933999999999997,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1800.683000000049,
"styleRecalcs": 19,
"styleRecalcDurationMs": 5.263999999999999,
"layouts": 12,
"layoutDurationMs": 2.902,
"taskDurationMs": 426.091,
"heapDeltaBytes": -4528136,
"heapUsedBytes": 70487104,
"domNodes": 47,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 11.087,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66481481481481,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 757.8720000000203,
"styleRecalcs": 15,
"styleRecalcDurationMs": 3.360000000000001,
"layouts": 10,
"layoutDurationMs": 3.0540000000000003,
"taskDurationMs": 521.5120000000001,
"heapDeltaBytes": 25691288,
"heapUsedBytes": 91480240,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 170.896,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666657,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 674.9260000000277,
"styleRecalcs": 13,
"styleRecalcDurationMs": 2.673000000000001,
"layouts": 9,
"layoutDurationMs": 2.3100000000000005,
"taskDurationMs": 481.65599999999995,
"heapDeltaBytes": 25597764,
"heapUsedBytes": 91451976,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 167.50900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1196.7420000000288,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 864.2520000000002,
"heapDeltaBytes": -11633308,
"heapUsedBytes": 81290724,
"domNodes": -192,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 69.16099999999999,
"eventListeners": -105,
"totalBlockingTimeMs": 531,
"frameDurationMs": 33.33055555555557,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1192.4589999999853,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 868.431,
"heapDeltaBytes": -12706848,
"heapUsedBytes": 80085140,
"domNodes": -192,
"jsHeapTotalBytes": 21241856,
"scriptDurationMs": 70.68800000000002,
"eventListeners": -106,
"totalBlockingTimeMs": 531,
"frameDurationMs": 33.33055555555555,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.7659999999787,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 442.4130000000002,
"heapDeltaBytes": -4356444,
"heapUsedBytes": 77026500,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 159.798,
"eventListeners": 0,
"totalBlockingTimeMs": 216,
"frameDurationMs": 25.00000000000003,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 861.7570000000114,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 513.2289999999995,
"heapDeltaBytes": -4285336,
"heapUsedBytes": 76471564,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 174.875,
"eventListeners": 0,
"totalBlockingTimeMs": 224,
"frameDurationMs": 25.49117647058823,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11340.900000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10365.355999999998,
"heapDeltaBytes": -19994348,
"heapUsedBytes": 67494264,
"domNodes": -258,
"jsHeapTotalBytes": 3272704,
"scriptDurationMs": 8323.044,
"eventListeners": -68,
"totalBlockingTimeMs": 1230,
"frameDurationMs": 31.480277777777783,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9649.156999999945,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8819.373,
"heapDeltaBytes": -16063044,
"heapUsedBytes": 82860168,
"domNodes": -258,
"jsHeapTotalBytes": 4845568,
"scriptDurationMs": 7048.115,
"eventListeners": -68,
"totalBlockingTimeMs": 621,
"frameDurationMs": 31.431921824104236,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10700.666000000012,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9885.386999999999,
"heapDeltaBytes": -3088736,
"heapUsedBytes": 96064784,
"domNodes": -258,
"jsHeapTotalBytes": 6680576,
"scriptDurationMs": 7994.293,
"eventListeners": -68,
"totalBlockingTimeMs": 1131,
"frameDurationMs": 31.285380116959065,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9839.656999999988,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.056000000000000494,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8996.226,
"heapDeltaBytes": -14437604,
"heapUsedBytes": 84185700,
"domNodes": -258,
"jsHeapTotalBytes": 6156288,
"scriptDurationMs": 7227.117,
"eventListeners": -68,
"totalBlockingTimeMs": 714,
"frameDurationMs": 31.018611987381707,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 233.32199999998693,
"styleRecalcs": 24,
"styleRecalcDurationMs": 16.272000000000002,
"layouts": 11,
"layoutDurationMs": 3.3010000000000006,
"taskDurationMs": 178.63400000000001,
"heapDeltaBytes": -8339212,
"heapUsedBytes": 79235456,
"domNodes": 917,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 9.117999999999999,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.339999999999964,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-combo-open",
"durationMs": 226.16400000003978,
"styleRecalcs": 24,
"styleRecalcDurationMs": 14.654,
"layouts": 11,
"layoutDurationMs": 3.205,
"taskDurationMs": 164.561,
"heapDeltaBytes": -8036452,
"heapUsedBytes": 79764928,
"domNodes": 917,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 8.445,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.218181818181787,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "large-graph-idle",
"durationMs": 2041.1430000000337,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6869999999999994,
"layouts": 9,
"layoutDurationMs": 2.841,
"taskDurationMs": 654.588,
"heapDeltaBytes": -19446732,
"heapUsedBytes": 77492096,
"domNodes": -258,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 35.202999999999996,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622944,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2056.291999999985,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.4219999999999997,
"layouts": 8,
"layoutDurationMs": 2.433,
"taskDurationMs": 683.6790000000002,
"heapDeltaBytes": -1896184,
"heapUsedBytes": 76638788,
"domNodes": -258,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 37.047,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2551.441000000011,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.030999999999999,
"layouts": 7,
"layoutDurationMs": 1.7959999999999998,
"taskDurationMs": 1691.319,
"heapDeltaBytes": -29303676,
"heapUsedBytes": 68568800,
"domNodes": -258,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 819.133,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665584415584416,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2524.057999999968,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.285,
"layouts": 6,
"layoutDurationMs": 1.7379999999999995,
"taskDurationMs": 1728.878,
"heapDeltaBytes": 10952116,
"heapUsedBytes": 91124056,
"domNodes": -278,
"jsHeapTotalBytes": 4546560,
"scriptDurationMs": 837.6850000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66578947368421,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3857.4240000000373,
"styleRecalcs": 72,
"styleRecalcDurationMs": 7.915,
"layouts": 65,
"layoutDurationMs": 10.869,
"taskDurationMs": 1797.5189999999998,
"heapDeltaBytes": -14686660,
"heapUsedBytes": 84273504,
"domNodes": -234,
"jsHeapTotalBytes": 6193152,
"scriptDurationMs": 776.37,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.738695652173913,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3565.517,
"styleRecalcs": 70,
"styleRecalcDurationMs": 7.7540000000000004,
"layouts": 64,
"layoutDurationMs": 10.94,
"taskDurationMs": 1643.7489999999998,
"heapDeltaBytes": -11400384,
"heapUsedBytes": 70565148,
"domNodes": -234,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 796.224,
"eventListeners": -67,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66588785046729,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3162.9629999999906,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.106,
"layouts": 5,
"layoutDurationMs": 1.6219999999999997,
"taskDurationMs": 2054.381,
"heapDeltaBytes": -11519088,
"heapUsedBytes": 71445208,
"domNodes": 0,
"jsHeapTotalBytes": 7467008,
"scriptDurationMs": 1035.0059999999999,
"eventListeners": 182,
"totalBlockingTimeMs": 20,
"frameDurationMs": 17.113978494623655,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2901.544000000058,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.426,
"layouts": 6,
"layoutDurationMs": 1.8130000000000004,
"taskDurationMs": 1801.136,
"heapDeltaBytes": 5565032,
"heapUsedBytes": 89157780,
"domNodes": 0,
"jsHeapTotalBytes": 8089600,
"scriptDurationMs": 979.119,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.95847953216374,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2008.6430000000064,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.302,
"layouts": 7,
"layoutDurationMs": 2.2279999999999993,
"taskDurationMs": 497.06800000000004,
"heapDeltaBytes": -3044084,
"heapUsedBytes": 77976776,
"domNodes": -258,
"jsHeapTotalBytes": 3010560,
"scriptDurationMs": 36.123999999999995,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2047.6560000000745,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9689999999999994,
"layouts": 7,
"layoutDurationMs": 2.346,
"taskDurationMs": 631.7230000000001,
"heapDeltaBytes": -3142160,
"heapUsedBytes": 78835348,
"domNodes": -278,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 33.893,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 590.4359999999542,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.195,
"layouts": 9,
"layoutDurationMs": 2.7499999999999996,
"taskDurationMs": 395.91200000000003,
"heapDeltaBytes": 21547188,
"heapUsedBytes": 88498012,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 152.134,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66857142857142,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 646.3569999999663,
"styleRecalcs": 48,
"styleRecalcDurationMs": 5.397999999999999,
"layouts": 11,
"layoutDurationMs": 3.369,
"taskDurationMs": 449.636,
"heapDeltaBytes": -2315768,
"heapUsedBytes": 74303532,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 143.963,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 2039.9949999999762,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.5129999999999986,
"layouts": 10,
"layoutDurationMs": 3.498,
"taskDurationMs": 549.5870000000001,
"heapDeltaBytes": -206724,
"heapUsedBytes": 76250480,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 11.322,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.340999999973,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.2900000000000005,
"layouts": 10,
"layoutDurationMs": 2.9520000000000004,
"taskDurationMs": 562.5459999999999,
"heapDeltaBytes": -668592,
"heapUsedBytes": 76776540,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 11.261,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1974.4790000000307,
"styleRecalcs": 87,
"styleRecalcDurationMs": 18.018,
"layouts": 10,
"layoutDurationMs": 2.696,
"taskDurationMs": 1062.381,
"heapDeltaBytes": 11676236,
"heapUsedBytes": 78568272,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 119.50399999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666101694915252,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1694.1279999999779,
"styleRecalcs": 76,
"styleRecalcDurationMs": 16.546,
"layouts": 9,
"layoutDurationMs": 2.5820000000000003,
"taskDurationMs": 699.2799999999999,
"heapDeltaBytes": 10878284,
"heapUsedBytes": 78233496,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 114.45799999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 983.6530000000039,
"styleRecalcs": 19,
"styleRecalcDurationMs": 26.754,
"layouts": 5,
"layoutDurationMs": 16.065,
"taskDurationMs": 790.2620000000003,
"heapDeltaBytes": 5029828,
"heapUsedBytes": 103653536,
"domNodes": 15953,
"jsHeapTotalBytes": 17698816,
"scriptDurationMs": 25.463,
"eventListeners": 3244,
"totalBlockingTimeMs": 161,
"frameDurationMs": 21.853333333333346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10650.34400000002,
"styleRecalcs": 250,
"styleRecalcDurationMs": 19.427,
"layouts": 8,
"layoutDurationMs": 2.143,
"taskDurationMs": 6227.348999999999,
"heapDeltaBytes": -7538092,
"heapUsedBytes": 88986256,
"domNodes": -258,
"jsHeapTotalBytes": 5861376,
"scriptDurationMs": 2839.6090000000004,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.692006269592476,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 10000.373999999965,
"styleRecalcs": 251,
"styleRecalcDurationMs": 19.887,
"layouts": 9,
"layoutDurationMs": 2.4229999999999996,
"taskDurationMs": 6086.4890000000005,
"heapDeltaBytes": -13023416,
"heapUsedBytes": 83479816,
"domNodes": -258,
"jsHeapTotalBytes": 7172096,
"scriptDurationMs": 2755.0629999999996,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.721739130434784,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 23208.82499999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22655.87,
"heapDeltaBytes": -10752840,
"heapUsedBytes": 280242448,
"domNodes": -3330,
"jsHeapTotalBytes": 9424896,
"scriptDurationMs": 374.15200000000004,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 40.06753022452504,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 23074.866000000042,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 22215.017000000003,
"heapDeltaBytes": -14335560,
"heapUsedBytes": 281132576,
"domNodes": -3330,
"jsHeapTotalBytes": 14929920,
"scriptDurationMs": 334.104,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.72874354561102,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 27547.436999999947,
"styleRecalcs": 181,
"styleRecalcDurationMs": 16.991000000000007,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27147.851999999995,
"heapDeltaBytes": -5630820,
"heapUsedBytes": 275888948,
"domNodes": -3330,
"jsHeapTotalBytes": 9687040,
"scriptDurationMs": 880.6610000000001,
"eventListeners": -651,
"totalBlockingTimeMs": 24,
"frameDurationMs": 50.734806629834246,
"p95FrameDurationMs": 100.10000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 27525.693000000047,
"styleRecalcs": 181,
"styleRecalcDurationMs": 15.266000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 27094.675000000003,
"heapDeltaBytes": 3194424,
"heapUsedBytes": 284619248,
"domNodes": -3330,
"jsHeapTotalBytes": 6209536,
"scriptDurationMs": 873.154,
"eventListeners": -651,
"totalBlockingTimeMs": 27,
"frameDurationMs": 50.61066176470589,
"p95FrameDurationMs": 100.09999999999854
},
{
"name": "vue-node-resize-workload",
"durationMs": 8398.514999999974,
"styleRecalcs": 20,
"styleRecalcDurationMs": 70.37799999999997,
"layouts": 20,
"layoutDurationMs": 21.779000000000007,
"taskDurationMs": 8266.067,
"heapDeltaBytes": -38160736,
"heapUsedBytes": 257937496,
"domNodes": -3330,
"jsHeapTotalBytes": 20697088,
"scriptDurationMs": 129.349,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 47.45536723163841,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 8232.074000000011,
"styleRecalcs": 20,
"styleRecalcDurationMs": 69.86300000000001,
"layouts": 20,
"layoutDurationMs": 21.453,
"taskDurationMs": 8127.323,
"heapDeltaBytes": -17055840,
"heapUsedBytes": 273615560,
"domNodes": -3330,
"jsHeapTotalBytes": 23056384,
"scriptDurationMs": 129.47199999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 46.25224719101122,
"p95FrameDurationMs": 100
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11439.533999999981,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11052.926000000001,
"heapDeltaBytes": 530368,
"heapUsedBytes": 278296356,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 163.16400000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 39.56055363321799,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 11361.891000000014,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11032.662,
"heapDeltaBytes": 28316504,
"heapUsedBytes": 278542340,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 156.6949999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 38.92568493150686,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 523.7720000000081,
"styleRecalcs": 26,
"styleRecalcDurationMs": 18.383,
"layouts": 12,
"layoutDurationMs": 11.571000000000002,
"taskDurationMs": 174.62299999999996,
"heapDeltaBytes": 7145496,
"heapUsedBytes": 79731128,
"domNodes": 128,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 17.79,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903224,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 127.76199999996152,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.448,
"layouts": 8,
"layoutDurationMs": 2.8529999999999998,
"taskDurationMs": 90.12799999999999,
"heapDeltaBytes": 4452884,
"heapUsedBytes": 77509456,
"domNodes": 94,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 6.521000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.450000000000045,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 515.6630000000177,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.312,
"layouts": 76,
"layoutDurationMs": 17.255,
"taskDurationMs": 470.34999999999997,
"heapDeltaBytes": 11821288,
"heapUsedBytes": 88158264,
"domNodes": 4,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 225.469,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66874999999999,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 518.4740000000829,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.9940000000000001,
"layouts": 76,
"layoutDurationMs": 16.266,
"taskDurationMs": 462.586,
"heapDeltaBytes": -13919356,
"heapUsedBytes": 81174256,
"domNodes": 4,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 222.335,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999994,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 618.7430000001086,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.42,
"layouts": 76,
"layoutDurationMs": 15.872,
"taskDurationMs": 582.6220000000001,
"heapDeltaBytes": 20409528,
"heapUsedBytes": 192098092,
"domNodes": 4,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 238.16899999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.11621621621622,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 645.73699999994,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.8389999999999995,
"layouts": 76,
"layoutDurationMs": 15.001000000000001,
"taskDurationMs": 584.256,
"heapDeltaBytes": 415396,
"heapUsedBytes": 122248828,
"domNodes": 4,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 245.949,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.54473684210526,
"p95FrameDurationMs": 33.19999999999982
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2276 passed, 0 failed · 2 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 5572a657668ed6ea1a2c8aabe6f6448642f82347
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.57 #21196 +/- ##
=============================================
+ Coverage 87.16% 87.17% +0.01%
=============================================
Files 2614 2614
Lines 147008 147050 +42
Branches 38231 40320 +2089
=============================================
+ Hits 128141 128193 +52
+ Misses 18479 18469 -10
Partials 388 388
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 15 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Backport of #21168 to
core/1.57Automatically created by backport workflow.