Repository navigation
[backport core/1.57] FE-2170 docs(auth): record the D1 decision and the current local SSO graph - #21192
Merged
Conversation
…graph (#20953) ## Summary Records the decisions made on 10-13 for local ComfyUI SSO and the partner-node execution token, so the repo docs show what was decided, by whom, and what is still open. - Linear: FE-2170, FE-3099 ## Why ADR-AUTH-LOCAL-0043 still said "Proposed" and the TDD's decision table had no outcomes, so anyone pointed at these docs could not tell D1 had been approved or that core #16242 was closed. The dependency graph also no longer matched the PRs: B3 was split in two and a prod kill switch was added. ## How - **ADR-AUTH-LOCAL-0043**: Status → Accepted (2026-10-13), with where D1 was approved and a pointer to the TDD's decision table. - **TDD decisions table**: new Outcome column. - D1 approved (Christian, #proj-sso 10-13); core #16242 closed as superseded by C1 (Comfy-Org/ComfyUI#16943); cloud GPU job token expiry and the single-use token idea moved to FE-3424. - D2, D3 still open. - New K1: ship B3a with `PartnerNodeTokenMintDisabled: true` in prod (Comfy-Org/cloud#13131), merged after the release carrying B3a is on prod. - **Action items**: B3 split into B3a (mint, cloud#12885, merged) and B3b (renew/revoke, cloud#12886); B4 now depends on B3b and mints the partner-node token only; C1 also depends on B3b and registers the two flags. - **Dependency graph**: every node names its PR; merged/decided nodes are green, open ones amber; K1 added. ## AS IS / TO BE Docs only; no UI. | | ADR status | D1 in TDD | Graph | |---|---|---|---| | AS IS | Proposed | "Approve…" with no outcome | B3 as one node, no PR numbers, no kill switch | | TO BE | Accepted (2026-10-13) | Approved, with source and follow-ups | B3a/B3b, K1, PR per node, done/open colours | ## Plan position | Item | PR | State | |---|---|---| | B1 / B2 / B3a / B5 | cloud#12827 / #12884 / #12885 / #12828 | merged | | K1 prod mint off | cloud#13131 | approved, merge after prod release | | B3b / B4 | cloud#12886 / #12887 | open | | C1 | Comfy-Org/ComfyUI#16943 | open, review required | | F1–F5 | #20720, #20721, #20722, #20725, #20791 | merged | | **Decision record (this PR)** | | open | | F6 QA | — | after C1 |
Contributor
📦 Bundle Size
🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight This candidate changes nothing the matrix measures, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 5572a657668ed6ea1a2c8aabe6f6448642f82347
Full docs: ADR-DEVEX-LINT-0015 |
This was referenced Oct 17, 2026
This was referenced Oct 24, 2026
dante01yoon
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #20953 to
core/1.57Automatically created by backport workflow.