Repository navigation
[backport cloud/1.56] FE-3263 fix(telemetry): group SDK-rail billing reads by the legacy operation they replace - #20746
Conversation
…eration they replace (#20714) ## Why #20344 added `operation`-based fingerprints for `WorkspaceApiError`, but in production (1.56.3, last 7d) **all 666** tagged events have an empty `workspace_api_operation`, so none of them got the new grouping. Every one of them is a billing read on the SDK rail, not a legacy HTTP call: | code | status | events | |---|---|---| | REQUEST_FAILED | none | 536 | | REQUEST_FAILED | 400 | 111 | | NOT_AUTHENTICATED | none | 13 | | MALFORMED_RESPONSE | 200 | 4 | | REQUEST_FAILED | 200 | 2 | ## Root cause `readOnRail` turns a failed SDK read into `WorkspaceApiError(code, httpStatus, code)` with no `operation`. `sentryBeforeSend` only fingerprints errors that carry one, so these fall back to message grouping, and the message is just the code (`REQUEST_FAILED`). Reads of status, balance, capabilities, plans, payment methods and events all land in the same issue. ## How - `readOnRail(read, operation)` now requires the `workspaceApi` method the read replaces (`WorkspaceApiOperation`, exported). A read on either rail lands in the same Sentry group, e.g. `[WorkspaceApiError, getBillingStatus, 400, REQUEST_FAILED]`. - All 8 call sites pass their legacy counterpart: `getBillingStatus`, `getBillingBalance`, `getBillingCapabilities`, `getBillingPlans`, `listSavedPaymentMethods`, `getBillingEvents`. - SDK operation refusals (`subscriptionOperationView`, `topupOperationView`) still have no `operation` and keep default grouping; unchanged. - `readOnRail.test.ts` checks a failed read through `sentryBeforeSend` gets the operation fingerprint and tag. ## AS IS / TO BE No UI change. Sentry event for an SDK-rail status read that fails with a 400: AS IS ```json { "tags": { "workspace_api_status": "400", "workspace_api_code": "REQUEST_FAILED" } } ``` TO BE ```json { "tags": { "workspace_api_operation": "getBillingStatus", "workspace_api_status": "400", "workspace_api_code": "REQUEST_FAILED" }, "fingerprint": ["WorkspaceApiError", "getBillingStatus", "400", "REQUEST_FAILED"] } ``` ## Plan position | # | Item | Ticket | PR | Status | |---|------|--------|----|--------| | 1 | Group WorkspaceApiError by operation/status/code | FE-3263 | #20344 | merged | | 1b | **Same grouping for SDK-rail reads** | FE-3263 | **this PR** | **open** | | 2 | One-off triage pass over the regrouped issues | — | — | next, after 1b ships | | 3 | Code-side expected-failure allowlist + report-after-final-retry | — | — | planned | | 4 | Codify the triage as a skill, then schedule it (read-only Sentry, PRs only) | — | — | planned | ```mermaid graph LR A["Group WorkspaceApiError (#20344)"] --> A2["SDK-rail reads (this PR)"] A2 --> B["One-off triage pass"] B --> C["Expected-failure allowlist"] B --> D["Triage skill + schedule"] C --> D style A2 fill:#f9d71c,stroke:#333,stroke-width:2px ``` - Related FE-3263
📦 Bundle Size
⚡ Performance Report
Scenario timings
Absolute values
Raw data{
"timestamp": "2026-10-26T23:58:20.837Z",
"gitSha": "72c99646a2243d19de4706dfdc15910a51c53ab2",
"branch": "backport-20714-to-cloud-1.56",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.7349999999778,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.908,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 443.558,
"heapDeltaBytes": -3167092,
"heapUsedBytes": 58767204,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.957,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2010.0800000000163,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.8539999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 326.19199999999995,
"heapDeltaBytes": 1317204,
"heapUsedBytes": 69087896,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.300000000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1694.5659999999805,
"styleRecalcs": 72,
"styleRecalcDurationMs": 18.762,
"layouts": 12,
"layoutDurationMs": 4.67,
"taskDurationMs": 674.231,
"heapDeltaBytes": -2024176,
"heapUsedBytes": 65480076,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 131.94,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1680.070999999998,
"styleRecalcs": 71,
"styleRecalcDurationMs": 18.322,
"layouts": 12,
"layoutDurationMs": 4.98,
"taskDurationMs": 595.749,
"heapDeltaBytes": -1991124,
"heapUsedBytes": 65777404,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 119.009,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1721.176000000014,
"styleRecalcs": 30,
"styleRecalcDurationMs": 11.143,
"layouts": 6,
"layoutDurationMs": 1.409,
"taskDurationMs": 331.563,
"heapDeltaBytes": 4182912,
"heapUsedBytes": 70776472,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 16.395,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666990291262135,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.5250000000087,
"styleRecalcs": 29,
"styleRecalcDurationMs": 10.046999999999999,
"layouts": 6,
"layoutDurationMs": 1.31,
"taskDurationMs": 279.11600000000004,
"heapDeltaBytes": 4204180,
"heapUsedBytes": 71726164,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.627,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 543.3130000000119,
"styleRecalcs": 15,
"styleRecalcDurationMs": 4.5120000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 370.54900000000004,
"heapDeltaBytes": -7397920,
"heapUsedBytes": 59165064,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 127.01300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663636363636368,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 533.4470000000238,
"styleRecalcs": 15,
"styleRecalcDurationMs": 4.27,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 345.996,
"heapDeltaBytes": -6400852,
"heapUsedBytes": 61112740,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 118.56800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999994,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 955.6510000000173,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 586.973,
"heapDeltaBytes": 16434868,
"heapUsedBytes": 85339348,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 40.258,
"eventListeners": 0,
"totalBlockingTimeMs": 327,
"frameDurationMs": 27.938235294117664,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 911.0230000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 540.5340000000001,
"heapDeltaBytes": 16300808,
"heapUsedBytes": 85274380,
"domNodes": 0,
"jsHeapTotalBytes": 2260992,
"scriptDurationMs": 42.47699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 280,
"frameDurationMs": 27.272727272727288,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 745.4659999999933,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 356.8910000000001,
"heapDeltaBytes": 17722324,
"heapUsedBytes": 100192436,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 118.80699999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 117,
"frameDurationMs": 22.055882352941165,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 721.1540000000127,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 297.61400000000026,
"heapDeltaBytes": -14558212,
"heapUsedBytes": 81502748,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 104.93799999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 100,
"frameDurationMs": 21.079411764705878,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7017.704000000009,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.2630000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6013.515,
"heapDeltaBytes": 18116656,
"heapUsedBytes": 95146476,
"domNodes": -142,
"jsHeapTotalBytes": -7475200,
"scriptDurationMs": 4631.732999999999,
"eventListeners": -74,
"totalBlockingTimeMs": 48,
"frameDurationMs": 24.532867132867132,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6500.61199999999,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.143,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5569.709000000001,
"heapDeltaBytes": 17008208,
"heapUsedBytes": 85573380,
"domNodes": -142,
"jsHeapTotalBytes": -10620928,
"scriptDurationMs": 4257.511,
"eventListeners": -74,
"totalBlockingTimeMs": 30,
"frameDurationMs": 23.66058394160584,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6424.225000000007,
"styleRecalcs": 3,
"styleRecalcDurationMs": 1.2180000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5580.4580000000005,
"heapDeltaBytes": 16396000,
"heapUsedBytes": 93719064,
"domNodes": -142,
"jsHeapTotalBytes": -10620928,
"scriptDurationMs": 4300.059,
"eventListeners": -74,
"totalBlockingTimeMs": 32,
"frameDurationMs": 24.03183520599251,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6020.443,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.223,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5135.276,
"heapDeltaBytes": -3922548,
"heapUsedBytes": 72966952,
"domNodes": -142,
"jsHeapTotalBytes": -10620928,
"scriptDurationMs": 3987.445,
"eventListeners": -78,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.642086330935253,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2011.2379999999916,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.279,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.54699999999997,
"heapDeltaBytes": -10546492,
"heapUsedBytes": 77353496,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 33.69699999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2010.3940000000193,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.8589999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 421.306,
"heapDeltaBytes": -10153068,
"heapUsedBytes": 77455428,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 33.452,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2124.592000000007,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.341999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1253.457,
"heapDeltaBytes": 11123080,
"heapUsedBytes": 99896300,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 656.9430000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665354330708663,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2131.35699999998,
"styleRecalcs": 70,
"styleRecalcDurationMs": 14.380999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1262.759,
"heapDeltaBytes": -20401560,
"heapUsedBytes": 68650176,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 649.86,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66640625,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3186.487999999997,
"styleRecalcs": 74,
"styleRecalcDurationMs": 17.252,
"layouts": 60,
"layoutDurationMs": 17.177999999999997,
"taskDurationMs": 1361.9170000000001,
"heapDeltaBytes": 1870344,
"heapUsedBytes": 69428232,
"domNodes": 24,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 627.193,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665968586387432,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3274.79900000003,
"styleRecalcs": 74,
"styleRecalcDurationMs": 17.159,
"layouts": 60,
"layoutDurationMs": 17.107,
"taskDurationMs": 1427.97,
"heapDeltaBytes": -19547688,
"heapUsedBytes": 69718344,
"domNodes": 24,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 657.6189999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666326530612242,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2549.7419999999806,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.527000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1554.948,
"heapDeltaBytes": 3042488,
"heapUsedBytes": 71088560,
"domNodes": 0,
"jsHeapTotalBytes": 1572864,
"scriptDurationMs": 811.659,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.775657894736845,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 2223.0900000000133,
"styleRecalcs": 47,
"styleRecalcDurationMs": 8.193999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1450.346,
"heapDeltaBytes": 4308136,
"heapUsedBytes": 72370164,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 755.004,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.792424242424246,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2018.7080000000037,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.7760000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 515.073,
"heapDeltaBytes": -9544368,
"heapUsedBytes": 79474228,
"domNodes": 0,
"jsHeapTotalBytes": 36864,
"scriptDurationMs": 38.779999999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2018.1479999999965,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.418000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 395.278,
"heapDeltaBytes": -9406796,
"heapUsedBytes": 79973524,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 34.667,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 528.4340000000043,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.175000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 340.782,
"heapDeltaBytes": -11546404,
"heapUsedBytes": 57925152,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 110.83299999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66562499999999,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 510.7189999999946,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.724000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 306.673,
"heapDeltaBytes": 10532896,
"heapUsedBytes": 74724532,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 103.405,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2021.6070000000173,
"styleRecalcs": 11,
"styleRecalcDurationMs": 4.073,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 387.54299999999995,
"heapDeltaBytes": 1284824,
"heapUsedBytes": 70692676,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 12.635,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.139999999969,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.601000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 360.049,
"heapDeltaBytes": 1158860,
"heapUsedBytes": 70702856,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.722000000000003,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1706.9809999999848,
"styleRecalcs": 76,
"styleRecalcDurationMs": 17.864,
"layouts": 16,
"layoutDurationMs": 5.431,
"taskDurationMs": 595.5140000000001,
"heapDeltaBytes": -5855464,
"heapUsedBytes": 63846012,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 97.273,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.2640000000129,
"styleRecalcs": 76,
"styleRecalcDurationMs": 19.970000000000002,
"layouts": 16,
"layoutDurationMs": 6.079999999999999,
"taskDurationMs": 619.1759999999999,
"heapDeltaBytes": 16746544,
"heapUsedBytes": 78832344,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 96.826,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 885.7160000000022,
"styleRecalcs": 18,
"styleRecalcDurationMs": 22.335999999999995,
"layouts": 5,
"layoutDurationMs": 10.169999999999998,
"taskDurationMs": 680.4650000000001,
"heapDeltaBytes": -592888,
"heapUsedBytes": 89747264,
"domNodes": 14227,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 23.689999999999994,
"eventListeners": 2463,
"totalBlockingTimeMs": 74,
"frameDurationMs": 19.56304347826088,
"p95FrameDurationMs": 33.30000000000018
},
{
"name": "viewport-pan-sweep",
"durationMs": 8227.207999999962,
"styleRecalcs": 250,
"styleRecalcDurationMs": 46.335,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4658.4310000000005,
"heapDeltaBytes": -17277484,
"heapUsedBytes": 70691360,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 2237.089,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66599190283401,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8246.62699999999,
"styleRecalcs": 250,
"styleRecalcDurationMs": 45.85699999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4402.8369999999995,
"heapDeltaBytes": -18518168,
"heapUsedBytes": 69138560,
"domNodes": 0,
"jsHeapTotalBytes": 561152,
"scriptDurationMs": 2169.424,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665858585858587,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 13927.624999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13237.517,
"heapDeltaBytes": -43782636,
"heapUsedBytes": 169593628,
"domNodes": -3045,
"jsHeapTotalBytes": 8409088,
"scriptDurationMs": 223.69899999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 24.02206896551724,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-idle",
"durationMs": 13572.04200000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12964.991000000002,
"heapDeltaBytes": -41422280,
"heapUsedBytes": 179225964,
"domNodes": -3045,
"jsHeapTotalBytes": 5410816,
"scriptDurationMs": 206.67999999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.7584938704028,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "vue-large-graph-pan",
"durationMs": 14997.86499999999,
"styleRecalcs": 72,
"styleRecalcDurationMs": 14.720000000000011,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14629.845,
"heapDeltaBytes": -27701156,
"heapUsedBytes": 186175108,
"domNodes": -3045,
"jsHeapTotalBytes": 5197824,
"scriptDurationMs": 643.391,
"eventListeners": -14915,
"totalBlockingTimeMs": 5,
"frameDurationMs": 27.153887884267636,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 16076.808999999912,
"styleRecalcs": 99,
"styleRecalcDurationMs": 19.15800000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15665.639,
"heapDeltaBytes": -36223568,
"heapUsedBytes": 183897184,
"domNodes": -3045,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 694.342,
"eventListeners": -14915,
"totalBlockingTimeMs": 7,
"frameDurationMs": 29.16576086956522,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-node-resize-workload",
"durationMs": 4629.612000000008,
"styleRecalcs": 20,
"styleRecalcDurationMs": 54.367,
"layouts": 20,
"layoutDurationMs": 22.941000000000003,
"taskDurationMs": 4500.890000000001,
"heapDeltaBytes": -8031736,
"heapUsedBytes": 214244192,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 77.872,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.935393258426966,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-node-resize-workload",
"durationMs": 4946.971000000076,
"styleRecalcs": 20,
"styleRecalcDurationMs": 57.81,
"layouts": 20,
"layoutDurationMs": 25.636000000000006,
"taskDurationMs": 4896.110000000001,
"heapDeltaBytes": 1162752,
"heapUsedBytes": 214295940,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 82.911,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.283536585365855,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6612.467000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6415.281000000002,
"heapDeltaBytes": -31335772,
"heapUsedBytes": 180309636,
"domNodes": -3045,
"jsHeapTotalBytes": 3252224,
"scriptDurationMs": 105.54000000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.835986159169543,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 7082.99199999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6773.035000000002,
"heapDeltaBytes": -36572676,
"heapUsedBytes": 169512832,
"domNodes": -3045,
"jsHeapTotalBytes": 7032832,
"scriptDurationMs": 125.34599999999996,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.2067615658363,
"p95FrameDurationMs": 50
},
{
"name": "workflow-execution",
"durationMs": 458.50599999999986,
"styleRecalcs": 16,
"styleRecalcDurationMs": 17.55,
"layouts": 4,
"layoutDurationMs": 1.9160000000000001,
"taskDurationMs": 112.64999999999998,
"heapDeltaBytes": 5829260,
"heapUsedBytes": 65480584,
"domNodes": 129,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.956,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66785714285715,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 88.8999999999669,
"styleRecalcs": 7,
"styleRecalcDurationMs": 11.376,
"layouts": 2,
"layoutDurationMs": 1.243,
"taskDurationMs": 60.463000000000015,
"heapDeltaBytes": 3723784,
"heapUsedBytes": 63764908,
"domNodes": 114,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 5.232,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 580.8020000000624,
"styleRecalcs": 78,
"styleRecalcDurationMs": 99.775,
"layouts": 76,
"layoutDurationMs": 27.741,
"taskDurationMs": 539.8729999999999,
"heapDeltaBytes": -17099856,
"heapUsedBytes": 67288984,
"domNodes": 76,
"jsHeapTotalBytes": 11796480,
"scriptDurationMs": 182.70299999999997,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714266,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 624.9169999999822,
"styleRecalcs": 78,
"styleRecalcDurationMs": 106.58800000000001,
"layouts": 76,
"layoutDurationMs": 30.439,
"taskDurationMs": 585.533,
"heapDeltaBytes": -16869060,
"heapUsedBytes": 67458580,
"domNodes": 76,
"jsHeapTotalBytes": 12582912,
"scriptDurationMs": 195.08,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1099.4819999999663,
"styleRecalcs": 78,
"styleRecalcDurationMs": 271.161,
"layouts": 76,
"layoutDurationMs": 31.572000000000003,
"taskDurationMs": 1083.8070000000002,
"heapDeltaBytes": 6819836,
"heapUsedBytes": 114824704,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 291.58,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66716417910449,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1171.510000000012,
"styleRecalcs": 78,
"styleRecalcDurationMs": 303.55,
"layouts": 76,
"layoutDurationMs": 32.096,
"taskDurationMs": 1148.202,
"heapDeltaBytes": -20607004,
"heapUsedBytes": 107174196,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 303.623,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.413432835820892,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
🎭 Playwright: ✅ 2205 passed, 0 failed📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 21944c18680b3bb222d4f16f874be468ffc78692
Full docs: ADR-DEVEX-LINT-0015 |
This comment has been minimized.
This comment has been minimized.
…read The backport has failed typecheck since it opened: readOnRail now requires an operation, and useHasSavedPaymentMethod still called it with one argument. The file exists only on cloud/1.56, so #20714 never saw this call site and the generated backport could not carry a change for it. It takes the same operation as the identical read in useSubscriptionCheckout.ts:431, which is also the legacy workspaceApi method this function falls back to when there is no rail.
|
This has been failing typecheck since it opened on Oct 10, on one error: #20714 made Fixed in The other nine failing checks were all gates downstream of I could not validate fully in my sandbox: it only has Context for whoever reviews: this backport is the last step before the Sentry |
|
Second blocker found and cleared: the branch was 61 commits behind
Merged So the two reasons this sat for 16 days were both mechanical: a call site that exists only on 1.56 so the generated backport couldn't carry it, and a base that moved under the branch the same evening. Neither needed a decision — they needed someone to look. Still |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## cloud/1.56 #20746 +/- ##
=============================================
Coverage ? 83.16%
=============================================
Files ? 2398
Lines ? 128077
Branches ? 39161
=============================================
Hits ? 106518
Misses ? 21148
Partials ? 411
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
dante01yoon
left a comment
There was a problem hiding this comment.
LGTM — approving backport.
Backport of #20714 to
cloud/1.56Automatically created by backport workflow.