Repository navigation
fix: only create async work for extensions that define the hook - #20522
Conversation
invokeExtensionsAsync created an async wrapper and promise for every enabled extension on every call, even for extensions without the hook. It runs once per node def, so large installs created millions of promises at startup. Now only extensions that define the hook start async work. Result array length and indices are unchanged, and the `in` check is now inside a per-extension guard so a throwing Proxy `has` trap is logged instead of rejecting the whole call.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 9b91a0c8331da05cf9d92f408688d1e6b3d16561
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 9.36 MB gzip 🔴 +106 BDetailsSummary
Category Glance App Entry Points — 4.44 kB (baseline 4.44 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.16 MB (baseline 2.16 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 154 kB (baseline 154 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 5 unchanged Panels & Settings — 671 kB (baseline 671 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 11 added / 11 removed / 19 unchanged User & Accounts — 54.5 kB (baseline 54.5 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 8 unchanged Editors & Dialogs — 340 kB (baseline 340 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 10 added / 10 removed / 3 unchanged UI Components — 201 kB (baseline 201 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 17 unchanged Data & Services — 3.07 MB (baseline 3.07 MB) • 🔴 +724 BStores, services, APIs, and repositories
Status: 18 added / 18 removed / 4 unchanged Utilities & Hooks — 814 kB (baseline 814 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 21 added / 21 removed / 30 unchanged Vendor & Third-Party — 14.2 MB (baseline 14.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 18.7 MB (baseline 18.7 MB) • ⚪ 0 BBundles that do not match a named category
Status: 86 added / 86 removed / 261 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-09T00:22:24.738Z",
"gitSha": "6fef4a7bc05ab3f6bdbf20431fcc57f015308480",
"branch": "fix/extension-hook-fanout",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2017.4480000000017,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.4849999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 296.448,
"heapDeltaBytes": -26959704,
"heapUsedBytes": 64260572,
"domNodes": -217,
"jsHeapTotalBytes": -4718592,
"scriptDurationMs": 9.781999999999998,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2041.4590000000317,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.614,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.04799999999994,
"heapDeltaBytes": -42336056,
"heapUsedBytes": 60228964,
"domNodes": -217,
"jsHeapTotalBytes": 6029312,
"scriptDurationMs": 11.527000000000003,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1735.4910000000245,
"styleRecalcs": 74,
"styleRecalcDurationMs": 15.424,
"layouts": 12,
"layoutDurationMs": 4.318,
"taskDurationMs": 728.905,
"heapDeltaBytes": -46386764,
"heapUsedBytes": 57913368,
"domNodes": -217,
"jsHeapTotalBytes": -2359296,
"scriptDurationMs": 114.96300000000001,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1712.095999999974,
"styleRecalcs": 54,
"styleRecalcDurationMs": 16.029,
"layouts": 12,
"layoutDurationMs": 5.189,
"taskDurationMs": 702.5780000000001,
"heapDeltaBytes": 3377552,
"heapUsedBytes": 59479736,
"domNodes": -237,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 123.47200000000001,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665686274509806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1694.718000000023,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.929999999999999,
"layouts": 3,
"layoutDurationMs": 1.12,
"taskDurationMs": 303.19199999999995,
"heapDeltaBytes": 8030872,
"heapUsedBytes": 64887028,
"domNodes": 45,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.503,
"eventListeners": 39,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1750.5210000000488,
"styleRecalcs": 21,
"styleRecalcDurationMs": 6.075,
"layouts": 3,
"layoutDurationMs": 1.1430000000000002,
"taskDurationMs": 354.0760000000001,
"heapDeltaBytes": -25700244,
"heapUsedBytes": 62501096,
"domNodes": -172,
"jsHeapTotalBytes": -4194304,
"scriptDurationMs": 13.123000000000001,
"eventListeners": -87,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 562.3190000000022,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.4950000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 381.717,
"heapDeltaBytes": 17727260,
"heapUsedBytes": 73856032,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 133.89200000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666682,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 601.560999999947,
"styleRecalcs": 15,
"styleRecalcDurationMs": 4.305,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.59700000000004,
"heapDeltaBytes": -31083532,
"heapUsedBytes": 72413804,
"domNodes": -217,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 134.299,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1003.518999999983,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 626.051,
"heapDeltaBytes": 13285656,
"heapUsedBytes": 94376732,
"domNodes": 0,
"jsHeapTotalBytes": 5668864,
"scriptDurationMs": 44.485,
"eventListeners": 0,
"totalBlockingTimeMs": 370,
"frameDurationMs": 29.41176470588235,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1036.4769999999908,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 663.916,
"heapDeltaBytes": 18714452,
"heapUsedBytes": 99762476,
"domNodes": 0,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 43.021,
"eventListeners": 0,
"totalBlockingTimeMs": 400,
"frameDurationMs": 30.391176470588242,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 744.103999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 343.1350000000002,
"heapDeltaBytes": -8345656,
"heapUsedBytes": 79041024,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 108.099,
"eventListeners": 0,
"totalBlockingTimeMs": 119,
"frameDurationMs": 22.058823529411764,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 731.9069999999783,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 331.91099999999983,
"heapDeltaBytes": -12625256,
"heapUsedBytes": 79020652,
"domNodes": 0,
"jsHeapTotalBytes": 1052672,
"scriptDurationMs": 104.18299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 117,
"frameDurationMs": 21.567647058823535,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7034.893000000011,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6068.874999999999,
"heapDeltaBytes": 10893068,
"heapUsedBytes": 94743160,
"domNodes": 0,
"jsHeapTotalBytes": -16777216,
"scriptDurationMs": 4775.5650000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 35,
"frameDurationMs": 24.851590106007066,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7384.178999999904,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6443.194,
"heapDeltaBytes": -8814428,
"heapUsedBytes": 75060672,
"domNodes": 0,
"jsHeapTotalBytes": -6029312,
"scriptDurationMs": 5128.48,
"eventListeners": 0,
"totalBlockingTimeMs": 39,
"frameDurationMs": 24.528239202657808,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7254.208000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6396.353999999999,
"heapDeltaBytes": 12690672,
"heapUsedBytes": 96540952,
"domNodes": 0,
"jsHeapTotalBytes": -14417920,
"scriptDurationMs": 4888.478,
"eventListeners": 0,
"totalBlockingTimeMs": 93,
"frameDurationMs": 24.575254237288135,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 7416.386999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6544.13,
"heapDeltaBytes": 605124,
"heapUsedBytes": 83672184,
"domNodes": 0,
"jsHeapTotalBytes": -8650752,
"scriptDurationMs": 5047.39,
"eventListeners": 0,
"totalBlockingTimeMs": 37,
"frameDurationMs": 24.236601307189545,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "large-combo-open",
"durationMs": 167.15300000004163,
"styleRecalcs": 22,
"styleRecalcDurationMs": 15.428,
"layouts": 5,
"layoutDurationMs": 1.9529999999999998,
"taskDurationMs": 122.617,
"heapDeltaBytes": 12160224,
"heapUsedBytes": 78421636,
"domNodes": 918,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.728000000000002,
"eventListeners": 202,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.80000000000005,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 181.92999999996573,
"styleRecalcs": 24,
"styleRecalcDurationMs": 15.729,
"layouts": 5,
"layoutDurationMs": 1.8619999999999997,
"taskDurationMs": 129.082,
"heapDeltaBytes": 12243400,
"heapUsedBytes": 77390956,
"domNodes": 918,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 7.802999999999999,
"eventListeners": 202,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.825000000000045,
"p95FrameDurationMs": 49.900000000000546
},
{
"name": "large-graph-idle",
"durationMs": 2050.042000000019,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.1649999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.1810000000001,
"heapDeltaBytes": -40178732,
"heapUsedBytes": 88303896,
"domNodes": -313,
"jsHeapTotalBytes": -3506176,
"scriptDurationMs": 31.83200000000001,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2033.0549999999903,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.0820000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.468,
"heapDeltaBytes": -18224384,
"heapUsedBytes": 87610108,
"domNodes": -313,
"jsHeapTotalBytes": -3543040,
"scriptDurationMs": 30.663999999999998,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2112.6279999999724,
"styleRecalcs": 67,
"styleRecalcDurationMs": 7.573999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1302.6020000000003,
"heapDeltaBytes": 22630476,
"heapUsedBytes": 88458924,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 638.5450000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665079365079368,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2109.698999999978,
"styleRecalcs": 68,
"styleRecalcDurationMs": 7.755999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1309.352,
"heapDeltaBytes": 23048256,
"heapUsedBytes": 88919244,
"domNodes": -313,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 655.4910000000001,
"eventListeners": 2,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665873015873014,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3362.9850000000374,
"styleRecalcs": 69,
"styleRecalcDurationMs": 9.193000000000001,
"layouts": 60,
"layoutDurationMs": 19.39,
"taskDurationMs": 1477.495,
"heapDeltaBytes": 12457584,
"heapUsedBytes": 79745164,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 642.7740000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663363,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3325.2260000000433,
"styleRecalcs": 70,
"styleRecalcDurationMs": 9.385,
"layouts": 60,
"layoutDurationMs": 19.249,
"taskDurationMs": 1345.743,
"heapDeltaBytes": 12442252,
"heapUsedBytes": 79706144,
"domNodes": 24,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 632.778,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665829145728644,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2455.067999999983,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.110000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1609.2009999999998,
"heapDeltaBytes": 20027260,
"heapUsedBytes": 86810304,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 790.613,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.89586206896552,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2219.5480000000316,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.792999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1517.462,
"heapDeltaBytes": 16638696,
"heapUsedBytes": 84094340,
"domNodes": 0,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 735.707,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.792424242424246,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2041.2000000000035,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.5719999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 445.63999999999993,
"heapDeltaBytes": -41568192,
"heapUsedBytes": 88682052,
"domNodes": -314,
"jsHeapTotalBytes": -4816896,
"scriptDurationMs": 32.452,
"eventListeners": -131,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2043.52700000004,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.4470000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.854,
"heapDeltaBytes": -18076240,
"heapUsedBytes": 89255748,
"domNodes": -313,
"jsHeapTotalBytes": -4067328,
"scriptDurationMs": 27.059000000000008,
"eventListeners": -125,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 562.3899999999935,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.612999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 383.31,
"heapDeltaBytes": -21143068,
"heapUsedBytes": 68200236,
"domNodes": -235,
"jsHeapTotalBytes": -3145728,
"scriptDurationMs": 119.423,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.669696969696968,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 599.9570000000176,
"styleRecalcs": 49,
"styleRecalcDurationMs": 7.885999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.69199999999995,
"heapDeltaBytes": -21006660,
"heapUsedBytes": 68163612,
"domNodes": -235,
"jsHeapTotalBytes": -3407872,
"scriptDurationMs": 119.32000000000001,
"eventListeners": -126,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66285714285714,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2040.6589999999483,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.181,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 425.706,
"heapDeltaBytes": -27244888,
"heapUsedBytes": 62892540,
"domNodes": -255,
"jsHeapTotalBytes": -4980736,
"scriptDurationMs": 10.581999999999999,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2030.6550000000243,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.0620000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.756,
"heapDeltaBytes": -27556644,
"heapUsedBytes": 64051132,
"domNodes": -235,
"jsHeapTotalBytes": -3407872,
"scriptDurationMs": 10.384999999999998,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1733.6420000000317,
"styleRecalcs": 78,
"styleRecalcDurationMs": 16.183000000000003,
"layouts": 16,
"layoutDurationMs": 5.607000000000001,
"taskDurationMs": 681.4149999999998,
"heapDeltaBytes": -8610816,
"heapUsedBytes": 81114596,
"domNodes": -235,
"jsHeapTotalBytes": -5242880,
"scriptDurationMs": 87.94,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667307692307695,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.1789999999728,
"styleRecalcs": 78,
"styleRecalcDurationMs": 16.453,
"layouts": 16,
"layoutDurationMs": 6.132000000000001,
"taskDurationMs": 617.812,
"heapDeltaBytes": -9184096,
"heapUsedBytes": 81540084,
"domNodes": -235,
"jsHeapTotalBytes": -3670016,
"scriptDurationMs": 92.457,
"eventListeners": -172,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666667,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 882.5239999999894,
"styleRecalcs": 20,
"styleRecalcDurationMs": 22.636000000000003,
"layouts": 6,
"layoutDurationMs": 10.026,
"taskDurationMs": 705.2460000000001,
"heapDeltaBytes": 5522944,
"heapUsedBytes": 88344376,
"domNodes": 14650,
"jsHeapTotalBytes": 6553600,
"scriptDurationMs": 24.247000000000003,
"eventListeners": 2456,
"totalBlockingTimeMs": 114,
"frameDurationMs": 20.54418604651164,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8157.901000000038,
"styleRecalcs": 250,
"styleRecalcDurationMs": 25.669000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4816.483000000001,
"heapDeltaBytes": -14746716,
"heapUsedBytes": 90463232,
"domNodes": -313,
"jsHeapTotalBytes": -696320,
"scriptDurationMs": 2195.948,
"eventListeners": -124,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66605316973415,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8181.749999999965,
"styleRecalcs": 251,
"styleRecalcDurationMs": 25.820000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4746.3240000000005,
"heapDeltaBytes": -12299936,
"heapUsedBytes": 94145184,
"domNodes": -333,
"jsHeapTotalBytes": -2793472,
"scriptDurationMs": 2186.45,
"eventListeners": -124,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.700204081632656,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 13600.567999999952,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12868.648000000001,
"heapDeltaBytes": -34684320,
"heapUsedBytes": 183489328,
"domNodes": -3046,
"jsHeapTotalBytes": 4886528,
"scriptDurationMs": 222.411,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.12840136054422,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-idle",
"durationMs": 13397.36199999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12517.58,
"heapDeltaBytes": -46620684,
"heapUsedBytes": 184661176,
"domNodes": -3046,
"jsHeapTotalBytes": 6574080,
"scriptDurationMs": 267.47900000000004,
"eventListeners": -14915,
"totalBlockingTimeMs": 2,
"frameDurationMs": 22.994329896907217,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-pan",
"durationMs": 16326.832999999966,
"styleRecalcs": 103,
"styleRecalcDurationMs": 12.933,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15922.559,
"heapDeltaBytes": -29008868,
"heapUsedBytes": 190594604,
"domNodes": -3046,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 777.151,
"eventListeners": -14913,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.428288288288286,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 15954.671999999959,
"styleRecalcs": 95,
"styleRecalcDurationMs": 12.49599999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15518.034,
"heapDeltaBytes": -32575560,
"heapUsedBytes": 187111536,
"domNodes": -3046,
"jsHeapTotalBytes": 3006464,
"scriptDurationMs": 798.8329999999999,
"eventListeners": -14913,
"totalBlockingTimeMs": 46,
"frameDurationMs": 28.158906525573194,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "vue-node-resize-workload",
"durationMs": 5199.502999999936,
"styleRecalcs": 20,
"styleRecalcDurationMs": 56.02799999999999,
"layouts": 20,
"layoutDurationMs": 27.468000000000007,
"taskDurationMs": 5036.516,
"heapDeltaBytes": 1240296,
"heapUsedBytes": 229547020,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 93.02900000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.728176795580108,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-node-resize-workload",
"durationMs": 4956.205999999952,
"styleRecalcs": 20,
"styleRecalcDurationMs": 53.72500000000002,
"layouts": 20,
"layoutDurationMs": 27.324,
"taskDurationMs": 4889.291,
"heapDeltaBytes": 1133012,
"heapUsedBytes": 220130300,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 91.517,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.5625,
"p95FrameDurationMs": 50
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6813.7210000001005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6609.273000000002,
"heapDeltaBytes": -21147496,
"heapUsedBytes": 184969648,
"domNodes": -3046,
"jsHeapTotalBytes": 12828672,
"scriptDurationMs": 136.12300000000005,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.894612794612797,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5362.059000000045,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4849.152999999999,
"heapDeltaBytes": -22729480,
"heapUsedBytes": 191272312,
"domNodes": -3046,
"jsHeapTotalBytes": 15224832,
"scriptDurationMs": 94.084,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.253061224489787,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 186.31700000003093,
"styleRecalcs": 10,
"styleRecalcDurationMs": 17.584000000000003,
"layouts": 5,
"layoutDurationMs": 3.234,
"taskDurationMs": 175.97000000000003,
"heapDeltaBytes": -30627888,
"heapUsedBytes": 58235196,
"domNodes": -60,
"jsHeapTotalBytes": -2359296,
"scriptDurationMs": 11.459999999999999,
"eventListeners": -92,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.912499999999966,
"p95FrameDurationMs": 33.40000000000009
},
{
"name": "workflow-execution",
"durationMs": 530.6799999999612,
"styleRecalcs": 16,
"styleRecalcDurationMs": 14.742999999999999,
"layouts": 3,
"layoutDurationMs": 1.2640000000000002,
"taskDurationMs": 174.624,
"heapDeltaBytes": -46720540,
"heapUsedBytes": 59564528,
"domNodes": -84,
"jsHeapTotalBytes": 2097152,
"scriptDurationMs": 11.001000000000001,
"eventListeners": -36,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903227,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 494.89600000003975,
"styleRecalcs": 77,
"styleRecalcDurationMs": 64.638,
"layouts": 76,
"layoutDurationMs": 18.759999999999998,
"taskDurationMs": 460.519,
"heapDeltaBytes": 14350240,
"heapUsedBytes": 84434032,
"domNodes": 77,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 161.78699999999998,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 508.14200000002074,
"styleRecalcs": 77,
"styleRecalcDurationMs": 67.725,
"layouts": 76,
"layoutDurationMs": 17.77,
"taskDurationMs": 478.896,
"heapDeltaBytes": 14566276,
"heapUsedBytes": 83339720,
"domNodes": 77,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 168.68,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903227,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 839.4369999999753,
"styleRecalcs": 77,
"styleRecalcDurationMs": 189.287,
"layouts": 76,
"layoutDurationMs": 21.166999999999998,
"taskDurationMs": 802.4879999999999,
"heapDeltaBytes": 6514744,
"heapUsedBytes": 119451388,
"domNodes": 77,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 222.392,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.006122448979596,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1037.5919999999041,
"styleRecalcs": 77,
"styleRecalcDurationMs": 214.71699999999998,
"layouts": 76,
"layoutDurationMs": 23.609,
"taskDurationMs": 1019.3160000000001,
"heapDeltaBytes": 13551784,
"heapUsedBytes": 213816088,
"domNodes": 77,
"jsHeapTotalBytes": 21233664,
"scriptDurationMs": 289.581,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66507936507936,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2247 passed, 0 failed · 1 flaky📊 Browser Reports
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
registerNodesFromDefs started registration for every node def at once, which put thousands of defs (and their extension hooks) in flight together. Process them in chunks of 256 instead. Defs within a chunk still overlap, order is preserved, and a failed def still lets the rest register before the first error is rethrown.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20522 +/- ##
==========================================
+ Coverage 85.85% 86.69% +0.84%
==========================================
Files 3594 2539 -1055
Lines 172349 144095 -28254
Branches 47295 37490 -9805
==========================================
- Hits 147966 124928 -23038
+ Misses 22365 18780 -3585
+ Partials 2018 387 -1631
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1065 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This reverts commit 7246a01.
Replace the per-extension async wrapper in invokeExtensionsAsync with a synchronous loop. Hooks that return synchronously are never awaited and only returned promises are collected, so extensions without a hook, and hooks that do not return a promise, allocate no promises. The property read is guarded per extension so a throwing getter or Proxy trap is logged without aborting the call.
| const result: unknown = fn.call(ext, ...args, app) | ||
| if (isPromiseLike(result)) { | ||
| pending.push( | ||
| Promise.resolve(result).catch((error) => logError(ext, error)) | ||
| ) | ||
| } |
There was a problem hiding this comment.
result is discarded if it's not promiseLike. That'll break calls like getCustomWidgets for which the return is both important and unlikely to be a promise.
There was a problem hiding this comment.
Fixed in ba333b7. You were right: sync return values were being dropped. invokeExtensionsAsync now keeps the previous result shape, one entry per enabled extension in order, holding the hook's return value whether it is sync or async (falsy values included), or undefined for extensions without the hook or whose hook threw or rejected. Only promise-like results are awaited, and extensions without the hook still allocate no promise. In this repo getCustomWidgets is read directly in registerExtension rather than through this function, and no call site uses the return value, but I kept the shape for any third-party callers. Tests cover sync objects, falsy values, async values, ordering and error isolation.
Generated by Claude Code
There was a problem hiding this comment.
Updated in 4263e8a to your suggested shape: the result of every applicable hook is kept (sync values as-is, promises awaited with errors logged), extensions without the hook contribute nothing, and there is no index alignment. This supersedes my previous reply about the result shape.
Generated by Claude Code
invokeExtensionsAsync dropped the return value of hooks that returned synchronously. Restore the previous result shape: one entry per enabled extension in order, holding the awaited hook result, or undefined for extensions without the hook or whose hook threw or rejected. Only promise-like results are awaited, and extensions without the hook still allocate no promise.
This reverts commit ba333b7.
Collect the return value of hooks that return synchronously alongside the promises from async hooks, so invokeExtensionsAsync still resolves with every hook result. Extensions without the hook contribute nothing, and the result array is not index-aligned with the extensions.
|
… define the hook (#20522) (#20787) ## Summary Manual backport of #20522 to `cloud/1.56` for BE-5708. The automated backport detected release-line conflicts in `src/services/extensionService.ts` and its tests; this PR preserves the release branch's existing bootstrap tracing and carries the hook fan-out optimization. ## Validation - `pnpm exec vitest run src/services/extensionService.test.ts --pool=forks --maxWorkers=2` — 17 passed - `pnpm exec oxfmt --check src/services/extensionService.ts src/services/extensionService.test.ts` — passed - `git diff --check` — passed Original: #20522 Issue: BE-5708 --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
|

Requested via Slack thread
Summary
Refs #17124
Before:
invokeExtensionsAsyncmapped every enabled extension through anasyncfunction, so each call allocated a wrapper promise per extension even when the extension had no such hook, or the hook returned synchronously. It runs once per node def (beforeRegisterNodeDef), so nodes x extensions promises (about 6M on a 6k-node, 1k-extension install) piled onto the microtask queue at startup.After: a plain synchronous loop. Extensions without the hook do no work, hooks that return synchronously are never wrapped or awaited, and only promises that hooks actually return are awaited. Based on the shape suggested by Austin Mroz.
How: per extension, read
ext[method]and skip it if it is not a function, call it, and collect the result. If the result is a promise or thenable it gets a.catchthat logs the error (same message as before). The call resolves withPromise.allover the collected results.setupkeeps itslegacyMenuCompatset/clear via a small async wrapper (set before the call, cleared infinally, so also on throw or rejection). The property read and call are inside a per-extension try/catch, so a throwing getter or Proxy trap is logged for that extension only, where previously a throwingincheck rejected the whole call.Preserved: same snapshot of
enabledExtensionsper call, in-order concurrent invocation, inherited prototype hooks, hooks added by an earlier hook mid-call, and the same error log message and context. Hook return values (sync or async, falsy values included) are still returned.Behavior differences:
undefinedslot). Nothing in this repo uses the return value; all call sites discard it.in, so a Proxy that only defines ahastrap is no longer consulted. Non-function values are still skipped silently, as before.Limitation: this only partially fixes the Firefox slowness (reporter measured about 110s to 61s on a real install); the remainder looks like a separate Firefox/SpiderMonkey issue. The unbounded
Promise.allover node defs inregisterNodesFromDefs(app.ts) is intentionally left as-is: chunking it was tried and dropped pending a Firefox and Chromium startup benchmark.Verification
invokeExtensionsAsyncsuite insrc/services/extensionService.test.ts(35 tests pass), plussrc/services,app.test.tsandSelectionToolbox.test.ts.pnpm typecheck, oxlint, eslint and oxfmt are clean.