Repository navigation
FE-3362 refactor(workspace): drop off-Cloud branches from the members panel - #20917
Conversation
The members panel is only registered on Cloud (useSettingUI), so every `isCloud ? fact : role/seat rule` branch in useMembersPanel and MembersPanelContent was unreachable. Render can_invite_members and can_manage_members as received: the invite button shows exactly when the server allows inviting, so the separate disabled state, limit tooltip and desktop invite flow go away. The view tabs narrow can_manage_members by whether there is anything to switch between, through narrowServerFact. Tests that only drove the off-Cloud path are removed; isInviteDisabled assertions now read showInviteButton.
📦 Bundle: 9.4 MB gzip 🟢 -297 BDetailsSummary
Category Glance App Entry Points — 5.55 kB (baseline 5.55 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 2.16 MB (baseline 2.16 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 147 kB (baseline 147 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 6 added / 6 removed / 12 unchanged Panels & Settings — 669 kB (baseline 669 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 3 added / 3 removed / 26 unchanged User & Accounts — 275 kB (baseline 275 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 3 added / 3 removed / 14 unchanged Editors & Dialogs — 340 kB (baseline 340 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 5 added / 5 removed / 7 unchanged UI Components — 211 kB (baseline 211 kB) • ⚪ 0 BReusable component library chunks
Status: 3 added / 3 removed / 21 unchanged Data & Services — 2.17 MB (baseline 2.17 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 2 added / 2 removed / 22 unchanged Utilities & Hooks — 1.29 MB (baseline 1.29 MB) • 🔴 +178 BHelpers, composables, and utility bundles
Status: 13 added / 13 removed / 50 unchanged Vendor & Third-Party — 14.2 MB (baseline 14.2 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 19 MB (baseline 19 MB) • 🟢 -1.29 kBBundles that do not match a named category
Status: 49 added / 49 removed / 302 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-13T15:07:37.375Z",
"gitSha": "21f43a301c2c24601eaf57fd6a6e38c1506668e0",
"branch": "jaewon/fe-3362-members-panel-cloud-only",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2031.3770000000204,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.1189999999999993,
"layouts": 10,
"layoutDurationMs": 3.667,
"taskDurationMs": 431.891,
"heapDeltaBytes": 22140968,
"heapUsedBytes": 87968396,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 13.669999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2019.4529999999986,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.705,
"layouts": 8,
"layoutDurationMs": 3.178,
"taskDurationMs": 576.975,
"heapDeltaBytes": -899828,
"heapUsedBytes": 74025272,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 13.379000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1809.4209999999862,
"styleRecalcs": 76,
"styleRecalcDurationMs": 14.963000000000001,
"layouts": 9,
"layoutDurationMs": 2.3550000000000004,
"taskDurationMs": 784.3530000000001,
"heapDeltaBytes": 15175960,
"heapUsedBytes": 81382420,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 158.936,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66574074074074,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1824.226000000067,
"styleRecalcs": 79,
"styleRecalcDurationMs": 16.648,
"layouts": 10,
"layoutDurationMs": 3.1719999999999993,
"taskDurationMs": 948.6660000000002,
"heapDeltaBytes": -7247244,
"heapUsedBytes": 68079752,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 157.88600000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666972477064224,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1706.5620000000195,
"styleRecalcs": 19,
"styleRecalcDurationMs": 6.445,
"layouts": 11,
"layoutDurationMs": 3.2709999999999995,
"taskDurationMs": 444.428,
"heapDeltaBytes": 18799380,
"heapUsedBytes": 84592340,
"domNodes": 47,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 14.559000000000003,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823523,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1692.4099999999953,
"styleRecalcs": 18,
"styleRecalcDurationMs": 6.4190000000000005,
"layouts": 10,
"layoutDurationMs": 3.15,
"taskDurationMs": 350.735,
"heapDeltaBytes": 18363352,
"heapUsedBytes": 84672252,
"domNodes": 47,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 14.832999999999995,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 764.4429999999716,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.302,
"layouts": 10,
"layoutDurationMs": 5.497,
"taskDurationMs": 532.604,
"heapDeltaBytes": 26001080,
"heapUsedBytes": 91880760,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 174.352,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 760.0949999999784,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.1410000000000005,
"layouts": 9,
"layoutDurationMs": 2.7790000000000004,
"taskDurationMs": 522.8589999999999,
"heapDeltaBytes": 24822500,
"heapUsedBytes": 91519768,
"domNodes": 0,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 170.78199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664444444444445,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1223.3039999999846,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 945.812,
"heapDeltaBytes": -11934328,
"heapUsedBytes": 81090564,
"domNodes": -212,
"jsHeapTotalBytes": 20717568,
"scriptDurationMs": 66.50800000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 531,
"frameDurationMs": 32.88108108108109,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1215.693999999985,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 906.1460000000001,
"heapDeltaBytes": -13660864,
"heapUsedBytes": 80939556,
"domNodes": -192,
"jsHeapTotalBytes": 21766144,
"scriptDurationMs": 69.35000000000001,
"eventListeners": -106,
"totalBlockingTimeMs": 545,
"frameDurationMs": 33.791666666666664,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 825.129000000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.5949999999997,
"heapDeltaBytes": -4475692,
"heapUsedBytes": 76352288,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 135.185,
"eventListeners": 0,
"totalBlockingTimeMs": 187,
"frameDurationMs": 23.808571428571433,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 829.7789999999168,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.94000000000057,
"heapDeltaBytes": -4552644,
"heapUsedBytes": 74953644,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 153.947,
"eventListeners": 0,
"totalBlockingTimeMs": 204,
"frameDurationMs": 24.508823529411742,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10787.431999999968,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9870.643000000002,
"heapDeltaBytes": -1790216,
"heapUsedBytes": 97348932,
"domNodes": -258,
"jsHeapTotalBytes": 8515584,
"scriptDurationMs": 7794.327,
"eventListeners": -68,
"totalBlockingTimeMs": 766,
"frameDurationMs": 31.852662721893488,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9404.398000000016,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.33199999999999896,
"layouts": 1,
"layoutDurationMs": 0.30200000000000016,
"taskDurationMs": 8441.018,
"heapDeltaBytes": -24084936,
"heapUsedBytes": 75419708,
"domNodes": -258,
"jsHeapTotalBytes": 7729152,
"scriptDurationMs": 6878.536,
"eventListeners": -68,
"totalBlockingTimeMs": 414,
"frameDurationMs": 30.865131578947373,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9618.741,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8763.521,
"heapDeltaBytes": -28195048,
"heapUsedBytes": 71574672,
"domNodes": -258,
"jsHeapTotalBytes": 11661312,
"scriptDurationMs": 7209.398,
"eventListeners": -68,
"totalBlockingTimeMs": 826,
"frameDurationMs": 32.487162162162164,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9576.647999999977,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.06600000000000009,
"layouts": 1,
"layoutDurationMs": 0.3370000000000001,
"taskDurationMs": 8654.257,
"heapDeltaBytes": -8677536,
"heapUsedBytes": 86713456,
"domNodes": -258,
"jsHeapTotalBytes": 4321280,
"scriptDurationMs": 6727.747,
"eventListeners": -68,
"totalBlockingTimeMs": 364,
"frameDurationMs": 29.70900621118012,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-combo-open",
"durationMs": 221.8220000000315,
"styleRecalcs": 25,
"styleRecalcDurationMs": 15.622,
"layouts": 12,
"layoutDurationMs": 4.0889999999999995,
"taskDurationMs": 168.38500000000002,
"heapDeltaBytes": -8164684,
"heapUsedBytes": 79049260,
"domNodes": 917,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 8.839999999999998,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.670000000000027,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-combo-open",
"durationMs": 229.46000000001732,
"styleRecalcs": 25,
"styleRecalcDurationMs": 16.011999999999997,
"layouts": 12,
"layoutDurationMs": 3.7010000000000005,
"taskDurationMs": 164.48700000000002,
"heapDeltaBytes": -8172588,
"heapUsedBytes": 79191384,
"domNodes": 917,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 9.726,
"eventListeners": 195,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.209090909090886,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2048.480999999981,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.302000000000001,
"layouts": 7,
"layoutDurationMs": 2.289,
"taskDurationMs": 741.441,
"heapDeltaBytes": -18562300,
"heapUsedBytes": 78171880,
"domNodes": -258,
"jsHeapTotalBytes": 3309568,
"scriptDurationMs": 35.127,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2059.724000000074,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.076999999999999,
"layouts": 7,
"layoutDurationMs": 1.6530000000000002,
"taskDurationMs": 562.66,
"heapDeltaBytes": -2453408,
"heapUsedBytes": 76883184,
"domNodes": -258,
"jsHeapTotalBytes": 3534848,
"scriptDurationMs": 35.76500000000001,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66612903225806,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2755.717000000004,
"styleRecalcs": 69,
"styleRecalcDurationMs": 6.8340000000000005,
"layouts": 8,
"layoutDurationMs": 2.131,
"taskDurationMs": 1845.5780000000002,
"heapDeltaBytes": -1913056,
"heapUsedBytes": 77996996,
"domNodes": -258,
"jsHeapTotalBytes": 4022272,
"scriptDurationMs": 861.3570000000001,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.76768292682927,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2374.8270000000957,
"styleRecalcs": 68,
"styleRecalcDurationMs": 6.351,
"layouts": 6,
"layoutDurationMs": 1.9030000000000002,
"taskDurationMs": 1633.6910000000003,
"heapDeltaBytes": -1424872,
"heapUsedBytes": 78504036,
"domNodes": -258,
"jsHeapTotalBytes": 4284416,
"scriptDurationMs": 823.255,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.90575539568345,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3944.345999999996,
"styleRecalcs": 71,
"styleRecalcDurationMs": 9.141,
"layouts": 64,
"layoutDurationMs": 11.748999999999999,
"taskDurationMs": 1906.128,
"heapDeltaBytes": -2148312,
"heapUsedBytes": 97157452,
"domNodes": 24,
"jsHeapTotalBytes": 5279744,
"scriptDurationMs": 849.0790000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.73686440677966,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3851.0259999999334,
"styleRecalcs": 71,
"styleRecalcDurationMs": 8.542000000000002,
"layouts": 65,
"layoutDurationMs": 12.526,
"taskDurationMs": 1946.837,
"heapDeltaBytes": 6393096,
"heapUsedBytes": 84357872,
"domNodes": -234,
"jsHeapTotalBytes": 4059136,
"scriptDurationMs": 837.688,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66580086580087,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3203.2120000000077,
"styleRecalcs": 44,
"styleRecalcDurationMs": 5.458,
"layouts": 5,
"layoutDurationMs": 1.94,
"taskDurationMs": 1923.805,
"heapDeltaBytes": -4928792,
"heapUsedBytes": 78567764,
"domNodes": 0,
"jsHeapTotalBytes": 7692288,
"scriptDurationMs": 1000.0019999999998,
"eventListeners": 182,
"totalBlockingTimeMs": 24,
"frameDurationMs": 17.10904255319149,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3389.982000000032,
"styleRecalcs": 45,
"styleRecalcDurationMs": 5.973,
"layouts": 5,
"layoutDurationMs": 1.6899999999999997,
"taskDurationMs": 2240.633,
"heapDeltaBytes": 14274232,
"heapUsedBytes": 93085524,
"domNodes": -258,
"jsHeapTotalBytes": 5525504,
"scriptDurationMs": 1062.212,
"eventListeners": -59,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.8318407960199,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2062.5970000000393,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.3529999999999993,
"layouts": 7,
"layoutDurationMs": 2.477,
"taskDurationMs": 537.4250000000001,
"heapDeltaBytes": -2080252,
"heapUsedBytes": 79444688,
"domNodes": -258,
"jsHeapTotalBytes": 3796992,
"scriptDurationMs": 37.267,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666129032258066,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2045.086000000083,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.229,
"layouts": 7,
"layoutDurationMs": 2.3859999999999997,
"taskDurationMs": 700.4549999999999,
"heapDeltaBytes": -19070320,
"heapUsedBytes": 79426488,
"domNodes": -258,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 36.878,
"eventListeners": -68,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536587,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 731.4179999999624,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.829999999999999,
"layouts": 8,
"layoutDurationMs": 2.095,
"taskDurationMs": 502.606,
"heapDeltaBytes": 21631556,
"heapUsedBytes": 88498964,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 148.768,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66818181818181,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 691.379999999981,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.388000000000001,
"layouts": 9,
"layoutDurationMs": 2.8649999999999998,
"taskDurationMs": 486.18899999999996,
"heapDeltaBytes": -1110808,
"heapUsedBytes": 75896024,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 159.974,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2007.09599999999,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.805000000000001,
"layouts": 9,
"layoutDurationMs": 2.759,
"taskDurationMs": 429.25,
"heapDeltaBytes": 22367624,
"heapUsedBytes": 89338816,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 12.899,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.8569999999308,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.614,
"layouts": 8,
"layoutDurationMs": 2.9000000000000004,
"taskDurationMs": 419.67499999999995,
"heapDeltaBytes": 22431396,
"heapUsedBytes": 89884592,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 12.678999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1758.3850000000325,
"styleRecalcs": 80,
"styleRecalcDurationMs": 18.160999999999998,
"layouts": 9,
"layoutDurationMs": 2.7609999999999997,
"taskDurationMs": 960.723,
"heapDeltaBytes": -11407464,
"heapUsedBytes": 65944436,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 118.69,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66666666666666,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1993.6550000001034,
"styleRecalcs": 87,
"styleRecalcDurationMs": 19.477,
"layouts": 10,
"layoutDurationMs": 4.245,
"taskDurationMs": 1140.784,
"heapDeltaBytes": -11352372,
"heapUsedBytes": 65573724,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 117.529,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66583333333334,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1232.3279999999386,
"styleRecalcs": 17,
"styleRecalcDurationMs": 25.822000000000006,
"layouts": 5,
"layoutDurationMs": 14.242999999999999,
"taskDurationMs": 865.1990000000001,
"heapDeltaBytes": 7306864,
"heapUsedBytes": 103041400,
"domNodes": 15953,
"jsHeapTotalBytes": 19800064,
"scriptDurationMs": 30.255999999999997,
"eventListeners": 3244,
"totalBlockingTimeMs": 170,
"frameDurationMs": 20.833333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 9509.593999999994,
"styleRecalcs": 249,
"styleRecalcDurationMs": 19.461,
"layouts": 7,
"layoutDurationMs": 1.8429999999999997,
"taskDurationMs": 6592.825000000001,
"heapDeltaBytes": -7946520,
"heapUsedBytes": 88843168,
"domNodes": -258,
"jsHeapTotalBytes": 4812800,
"scriptDurationMs": 2935.673,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.72464788732394,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9595.444000000043,
"styleRecalcs": 251,
"styleRecalcDurationMs": 20.908,
"layouts": 8,
"layoutDurationMs": 2.38,
"taskDurationMs": 6563.622,
"heapDeltaBytes": -12696876,
"heapUsedBytes": 84085268,
"domNodes": -258,
"jsHeapTotalBytes": 5074944,
"scriptDurationMs": 2891.805,
"eventListeners": -66,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.695121951219516,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 21210.63600000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20826.838000000003,
"heapDeltaBytes": -16259880,
"heapUsedBytes": 266814828,
"domNodes": -3330,
"jsHeapTotalBytes": 10215424,
"scriptDurationMs": 287.437,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.92325581395349,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-idle",
"durationMs": 20682.242999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20177.855,
"heapDeltaBytes": -25959456,
"heapUsedBytes": 269274932,
"domNodes": -3330,
"jsHeapTotalBytes": 13885440,
"scriptDurationMs": 292.41299999999995,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.40054249547921,
"p95FrameDurationMs": 66.80000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 25343.892999999982,
"styleRecalcs": 180,
"styleRecalcDurationMs": 18.79899999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 25010.77,
"heapDeltaBytes": -8981656,
"heapUsedBytes": 273229800,
"domNodes": -3330,
"jsHeapTotalBytes": 5754880,
"scriptDurationMs": 878.807,
"eventListeners": -651,
"totalBlockingTimeMs": 12,
"frameDurationMs": 48.56130268199234,
"p95FrameDurationMs": 99.90000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 25631.987000000096,
"styleRecalcs": 181,
"styleRecalcDurationMs": 19.15,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 25297.533000000003,
"heapDeltaBytes": -37795268,
"heapUsedBytes": 262943044,
"domNodes": -3330,
"jsHeapTotalBytes": 9162752,
"scriptDurationMs": 924.6049999999999,
"eventListeners": -651,
"totalBlockingTimeMs": 35,
"frameDurationMs": 48.090619136960605,
"p95FrameDurationMs": 100
},
{
"name": "vue-node-resize-workload",
"durationMs": 7721.609999999999,
"styleRecalcs": 20,
"styleRecalcDurationMs": 64.05199999999999,
"layouts": 20,
"layoutDurationMs": 24.180999999999994,
"taskDurationMs": 7595.062000000001,
"heapDeltaBytes": -23264360,
"heapUsedBytes": 258076080,
"domNodes": -3330,
"jsHeapTotalBytes": 15458304,
"scriptDurationMs": 116.374,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.48846153846153,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-node-resize-workload",
"durationMs": 7609.838999999965,
"styleRecalcs": 20,
"styleRecalcDurationMs": 63.485000000000014,
"layouts": 20,
"layoutDurationMs": 23.76199999999999,
"taskDurationMs": 7512.024,
"heapDeltaBytes": -15827756,
"heapUsedBytes": 265557496,
"domNodes": -3330,
"jsHeapTotalBytes": 12574720,
"scriptDurationMs": 133.122,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 41.39293478260869,
"p95FrameDurationMs": 83.39999999999964
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10435.764000000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10132.694,
"heapDeltaBytes": -16078940,
"heapUsedBytes": 252459848,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 141.36099999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.35156794425087,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 10233.532999999967,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10009.200000000003,
"heapDeltaBytes": 24251928,
"heapUsedBytes": 282710808,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 144.34700000000007,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.80899280575539,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "workflow-execution",
"durationMs": 538.3369999999559,
"styleRecalcs": 22,
"styleRecalcDurationMs": 16.408,
"layouts": 10,
"layoutDurationMs": 4.276000000000001,
"taskDurationMs": 187.67999999999995,
"heapDeltaBytes": 7243772,
"heapUsedBytes": 80255612,
"domNodes": 130,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 18.409000000000002,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666674,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 499.18700000000626,
"styleRecalcs": 20,
"styleRecalcDurationMs": 12.598,
"layouts": 10,
"layoutDurationMs": 3.794,
"taskDurationMs": 139.83199999999997,
"heapDeltaBytes": -13598888,
"heapUsedBytes": 69749568,
"domNodes": 121,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 15.667,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 661.0019999999395,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.945,
"layouts": 76,
"layoutDurationMs": 19.754,
"taskDurationMs": 611.925,
"heapDeltaBytes": 13314616,
"heapUsedBytes": 83495764,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 291.862,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667500000000018,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 525.1459999999497,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.324,
"layouts": 76,
"layoutDurationMs": 18.057,
"taskDurationMs": 463.346,
"heapDeltaBytes": 11348644,
"heapUsedBytes": 83608512,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 209.452,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66451612903227,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 611.6520000000492,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.385,
"layouts": 76,
"layoutDurationMs": 17.427999999999997,
"taskDurationMs": 565.619,
"heapDeltaBytes": 372876,
"heapUsedBytes": 119070952,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 222.09699999999998,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664864864864875,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 623.7780000000157,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.219,
"layouts": 76,
"layoutDurationMs": 18.483,
"taskDurationMs": 576.296,
"heapDeltaBytes": 524448,
"heapUsedBytes": 131724340,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 225.161,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.11351351351351,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2278 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 0e1a2fbbe4d5ed1eeefb70a3fd6f0d805331d3e8
Full docs: ADR-DEVEX-LINT-0015 |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #20917 +/- ##
==========================================
+ Coverage 86.32% 87.15% +0.82%
==========================================
Files 3665 2612 -1053
Lines 175150 146879 -28271
Branches 48346 40270 -8076
==========================================
- Hits 151201 128006 -23195
+ Misses 21936 18485 -3451
+ Partials 2013 388 -1625
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1067 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
Reviewed at pinned head d6712bc.
No actionable findings. The Cloud-only settings registration makes the removed desktop branches unreachable; the remaining Cloud behavior preserves server-fact gating, and narrowServerFact only withholds the pending tab when there is no local tab content. Targeted verification passed: 2 files, 223 tests.
|
|
…ers (Comfy-Org#20918) ## Why FE-3361 (L1, server-fact guardrails), step 7 of the design note. `receiveServerFact` holds the one cast that turns any boolean into a `ServerFact<Field>`. It was importable anywhere, so a gate could launder a derivation through it (`receiveServerFact('can_invite_members', canInvite || isPlanEnded)`) and the type from Comfy-Org#20818 would accept the result. Comfy-Org#20818 listed this as a known risk. ## How - New rule `comfy/no-stray-server-fact-constructor` in `tools/oxlint-plugins/serverFacts.ts`: reports `receiveServerFact` outside fact providers: a named import (aliased or not), or a member access such as `facts.receiveServerFact` after `import * as facts`. - Allowed: `serverFact.ts` itself, `useBillingCapabilities.ts` (the capability read that decodes the API response), test/spec/stories files, `__mocks__/`, `src/storybook/`. A new provider is added to `FACT_PROVIDERS`, so minting facts in a new module is a reviewed change. - Registered in `serverFacts.oxlintrc.json`, so it runs in the changed-line `lint:server-facts` gate inside the required `lint-and-format` check. - ADR-API-SERVER-FACTS-0042 enforcement list names the rule, and counts an off-Cloud local provider (rule 2) as a fact provider alongside the API decoder. Reporting the import and the member access, rather than resolving calls, covers aliases and namespaces without scope tracking. Every current import is in an allowed file, so the rule has no existing findings. ## AS IS / TO BE Tooling only, no UI change. | A gate file adds `import { receiveServerFact } from '@/platform/serverFacts/serverFact'` | AS IS | TO BE | |---|---|---| | `lint:server-facts` | passes | fails at the import | ## Verification - `vitest run tools/oxlint-plugins/serverFacts.test.ts`: 68 passed (allowed: 4 providers and a reading gate; reported: a minting gate, a namespace member in dotted and bracketed form, an aliased import). - Mutation: inverting the name check fails 3 rows; removing the member-access visitor fails the namespace row. - `scripts/server-fact-gate.test.ts`: a `lintSnapshot` case runs the gate config on a real `<script setup lang="ts">` SFC and expects the finding on line 3. - End to end through `lintSnapshot` with the gate config: the import is reported in `src/platform/workspace/composables/useX.ts` and not in `useBillingCapabilities.ts`. ## Plan position TDD: [Server-fact guardrails](https://app.notion.com/p/3f46d73d36508162ae1be360e6403b5b). Parent: FE-3360. | Item | Ticket | PR | Status | |---|---|---|---| | L1 `ServerFact` type (members panel) | FE-3361 | Comfy-Org#20818 | Merged | | L2 members panel: drop off-Cloud branches | FE-3362 | Comfy-Org#20917 | In review | | **L1 restrict `receiveServerFact`** | **FE-3361** | **this PR** | **In review** | | L1 lifecycle, seats, top-up, subscribe | FE-3361 | — | Waiting on backend facts (FE-3366 C list) | ```mermaid graph LR L1["L1 ServerFact type (PR 20818, merged)"] --> R["L1 restrict constructor (this PR)"]:::current L1 --> L2["L2 members panel (PR 20917)"] BE["Backend facts (C list)"] -. blocks .-> M["L1 remaining surfaces"] R --> M classDef current fill:#f9d71c,stroke:Comfy-Org#333,stroke-width:2px ```
Why
FE-3362 (L2, server-fact guardrails). ADR-API-SERVER-FACTS-0042 rule 2:
isClouddecides which build ships, not what a user may do. The members panel still answered invite and management off Cloud from role and seats (workspaceRole === 'owner',hasMemberSeats,isMemberLimitReached), which the lint gate reports.Root cause
The members panel is only registered on Cloud (
useSettingUI:isCloud ? [planCreditsPanel, membersPanel] : [planCreditsPanel]), anduseMembersPanel/MembersPanelContenthave no other callers. Every off-Cloud branch was unreachable, so the role-and-seat rules were dead copies of backend policy. #20818 removed the first of them (useMemberFacts).How
isCloud ? fact : rulebranch inuseMembersPanelto the fact:canViewOtherMembers, the minimal layout, the manager layout, the pending tab, the view tabs, the invite button andhandleInviteMember.can_invite_membersis true, soisInviteDisabled(always false while visible on Cloud), the seat-limit tooltip and the desktop invite flow are deleted.can_manage_membersby whether there is anything to switch between, throughnarrowServerFact(local state may withhold, never grant).isInviteDisabledassertions now readshowInviteButton, which is the same value on Cloud. ThedescribeServerFactGatetables for invite and management still pass.AS IS / TO BE
No UI or behaviour change on Cloud; off Cloud the panel never renders. Every changed branch evaluates to the same value on Cloud as before (verified by the unchanged Cloud test cases).
Verification
vitest run src/platform/workspace: 2725 passed.pnpm lint:server-facts --staged: no findings on changed lines (the view-tabs&&was reported until moved tonarrowServerFact).Plan position
TDD: Server-fact guardrails. Parent: FE-3360.
ServerFacttype (members panel)