Repository navigation
fix: show agent usage charge in credits in the activity tooltip - #21251
Conversation
The Activity tab tooltip listed charge_micro_usd as a raw micro USD count. Convert it to credits at the shared CREDITS_PER_USD rate and show it as Charge with at most two decimals, 0 credits for zero and <0.01 credits for tiny non-zero charges. Non-numeric values keep the original label and value.
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
📦 Bundle: 11.6 MB gzip 🔴 +242 BDetailsSummary
Category Glance App Entry Points — 6.86 kB (baseline 6.86 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 3.4 MB (baseline 3.4 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 3 added / 3 removed / 1 unchanged Views & Navigation — 147 kB (baseline 147 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 12 added / 12 removed / 6 unchanged Panels & Settings — 787 kB (baseline 786 kB) • 🔴 +592 BConfiguration panels, inspectors, and settings screens
Status: 14 added / 14 removed / 20 unchanged User & Accounts — 151 kB (baseline 151 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 9 added / 9 removed / 8 unchanged Editors & Dialogs — 359 kB (baseline 359 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 8 added / 8 removed / 4 unchanged UI Components — 217 kB (baseline 217 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 22 unchanged Data & Services — 1.21 MB (baseline 1.21 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 36 added / 36 removed / 7 unchanged Utilities & Hooks — 1.01 MB (baseline 1.01 MB) • 🔴 +161 BHelpers, composables, and utility bundles
Status: 41 added / 41 removed / 36 unchanged Vendor & Third-Party — 24.7 MB (baseline 24.7 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 17 unchanged Other — 20.5 MB (baseline 20.5 MB) • 🔴 +21 BBundles that do not match a named category
Status: 107 added / 107 removed / 578 unchanged ⚡ Performance Report
Scenario timings
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-18T04:54:12.412Z",
"gitSha": "ec7dd00a430bdd8f39578266b1f9e0aad5c73eae",
"branch": "fix/activity-charge-in-credits",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.2950000000656,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.113,
"layouts": 9,
"layoutDurationMs": 2.1060000000000003,
"taskDurationMs": 409.166,
"heapDeltaBytes": 3498196,
"heapUsedBytes": 94601672,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 8.128,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2008.2170000000588,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.1539999999999995,
"layouts": 9,
"layoutDurationMs": 2.078,
"taskDurationMs": 410.73500000000007,
"heapDeltaBytes": 1835328,
"heapUsedBytes": 93603608,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 7.791999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1676.3389999999845,
"styleRecalcs": 71,
"styleRecalcDurationMs": 10.808,
"layouts": 10,
"layoutDurationMs": 2.176,
"taskDurationMs": 553.212,
"heapDeltaBytes": 22519508,
"heapUsedBytes": 113733784,
"domNodes": 0,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 108.809,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1945.508000000018,
"styleRecalcs": 81,
"styleRecalcDurationMs": 11.959999999999999,
"layouts": 9,
"layoutDurationMs": 1.9929999999999999,
"taskDurationMs": 777.142,
"heapDeltaBytes": 23256384,
"heapUsedBytes": 114858092,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 115.616,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66581196581196,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1708.1159999999045,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.206,
"layouts": 12,
"layoutDurationMs": 2.3440000000000003,
"taskDurationMs": 319.79799999999994,
"heapDeltaBytes": 1814616,
"heapUsedBytes": 105372752,
"domNodes": 47,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 10.120999999999999,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.1739999999618,
"styleRecalcs": 18,
"styleRecalcDurationMs": 4.149,
"layouts": 11,
"layoutDurationMs": 2.289,
"taskDurationMs": 314.444,
"heapDeltaBytes": -932100,
"heapUsedBytes": 97703868,
"domNodes": 47,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 9.925,
"eventListeners": 37,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 576.2750000000096,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.6629999999999994,
"layouts": 10,
"layoutDurationMs": 2.3569999999999998,
"taskDurationMs": 430.23699999999997,
"heapDeltaBytes": 6458480,
"heapUsedBytes": 110022672,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 130.06199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 582.9439999999977,
"styleRecalcs": 14,
"styleRecalcDurationMs": 2.583,
"layouts": 10,
"layoutDurationMs": 2.4749999999999996,
"taskDurationMs": 433.9560000000001,
"heapDeltaBytes": 8084928,
"heapUsedBytes": 114199644,
"domNodes": 0,
"jsHeapTotalBytes": 14155776,
"scriptDurationMs": 130.81699999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66285714285715,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1009.3779999999697,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 662.6720000000001,
"heapDeltaBytes": -17644268,
"heapUsedBytes": 101477800,
"domNodes": -226,
"jsHeapTotalBytes": 14659584,
"scriptDurationMs": 48.382999999999996,
"eventListeners": -168,
"totalBlockingTimeMs": 372,
"frameDurationMs": 29.045714285714297,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1009.9050000000034,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 655.0800000000002,
"heapDeltaBytes": -9678348,
"heapUsedBytes": 101428208,
"domNodes": -226,
"jsHeapTotalBytes": 10137600,
"scriptDurationMs": 46.221,
"eventListeners": -168,
"totalBlockingTimeMs": 369,
"frameDurationMs": 29.045714285714297,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 782.8440000000683,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.07800000000015,
"heapDeltaBytes": -3081764,
"heapUsedBytes": 96849080,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 116.21000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 156,
"frameDurationMs": 23.03823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 769.5009999999911,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 349.5929999999996,
"heapDeltaBytes": -3310356,
"heapUsedBytes": 96711368,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 105.805,
"eventListeners": 0,
"totalBlockingTimeMs": 153,
"frameDurationMs": 23.230303030303013,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 7071.460999999999,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.28500000000000053,
"layouts": 1,
"layoutDurationMs": 0.18000000000000005,
"taskDurationMs": 6341.057,
"heapDeltaBytes": 7771716,
"heapUsedBytes": 129652496,
"domNodes": -302,
"jsHeapTotalBytes": 20090880,
"scriptDurationMs": 4805.948999999999,
"eventListeners": -130,
"totalBlockingTimeMs": 87,
"frameDurationMs": 24.451211072664357,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6923.96599999995,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.4160000000000006,
"layouts": 2,
"layoutDurationMs": 0.41399999999999987,
"taskDurationMs": 6222.365,
"heapDeltaBytes": -9678640,
"heapUsedBytes": 109305116,
"domNodes": -272,
"jsHeapTotalBytes": -1863680,
"scriptDurationMs": 4858.298,
"eventListeners": -130,
"totalBlockingTimeMs": 27,
"frameDurationMs": 24.26807017543859,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6771.862999999939,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.51,
"layouts": 2,
"layoutDurationMs": 0.4459999999999998,
"taskDurationMs": 6145.322,
"heapDeltaBytes": -3423888,
"heapUsedBytes": 118261484,
"domNodes": -292,
"jsHeapTotalBytes": 21663744,
"scriptDurationMs": 4670.89,
"eventListeners": -130,
"totalBlockingTimeMs": 87,
"frameDurationMs": 25.060740740740744,
"p95FrameDurationMs": 33.400000000000546
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6302.910999999995,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.699,
"layouts": 3,
"layoutDurationMs": 0.6459999999999999,
"taskDurationMs": 5633.077,
"heapDeltaBytes": -4856100,
"heapUsedBytes": 116405020,
"domNodes": -272,
"jsHeapTotalBytes": 19828736,
"scriptDurationMs": 4496.551,
"eventListeners": -130,
"totalBlockingTimeMs": 70,
"frameDurationMs": 25.098804780876492,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-combo-open",
"durationMs": 155.26500000009946,
"styleRecalcs": 21,
"styleRecalcDurationMs": 11.3,
"layouts": 10,
"layoutDurationMs": 2.3529999999999998,
"taskDurationMs": 116.63099999999999,
"heapDeltaBytes": 13253744,
"heapUsedBytes": 117990952,
"domNodes": 917,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 6.457000000000001,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.82499999999999,
"p95FrameDurationMs": 50
},
{
"name": "large-combo-open",
"durationMs": 157.98900000004323,
"styleRecalcs": 21,
"styleRecalcDurationMs": 11.084999999999999,
"layouts": 11,
"layoutDurationMs": 2.5589999999999997,
"taskDurationMs": 117.56300000000003,
"heapDeltaBytes": 13313416,
"heapUsedBytes": 118276620,
"domNodes": 917,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 6.704,
"eventListeners": 196,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.82499999999999,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2010.5459999999766,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.117,
"layouts": 9,
"layoutDurationMs": 1.895,
"taskDurationMs": 393.2579999999999,
"heapDeltaBytes": -15534756,
"heapUsedBytes": 95558000,
"domNodes": -292,
"jsHeapTotalBytes": -1863680,
"scriptDurationMs": 28.65600000000001,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "large-graph-idle",
"durationMs": 2010.772999999972,
"styleRecalcs": 9,
"styleRecalcDurationMs": 1.9839999999999995,
"layouts": 9,
"layoutDurationMs": 1.8869999999999998,
"taskDurationMs": 387.4839999999999,
"heapDeltaBytes": -18246256,
"heapUsedBytes": 93732240,
"domNodes": -292,
"jsHeapTotalBytes": -2387968,
"scriptDurationMs": 27.907,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2316.079000000059,
"styleRecalcs": 69,
"styleRecalcDurationMs": 5.8790000000000004,
"layouts": 8,
"layoutDurationMs": 1.8059999999999998,
"taskDurationMs": 1304.369,
"heapDeltaBytes": 979644,
"heapUsedBytes": 104198968,
"domNodes": -292,
"jsHeapTotalBytes": -655360,
"scriptDurationMs": 608.0889999999999,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666187050359714,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2296.032000000082,
"styleRecalcs": 70,
"styleRecalcDurationMs": 5.985,
"layouts": 8,
"layoutDurationMs": 1.8040000000000003,
"taskDurationMs": 1334.979,
"heapDeltaBytes": -15707372,
"heapUsedBytes": 88129808,
"domNodes": -292,
"jsHeapTotalBytes": -1654784,
"scriptDurationMs": 613.949,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666664,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3256.752000000006,
"styleRecalcs": 73,
"styleRecalcDurationMs": 7.241,
"layouts": 67,
"layoutDurationMs": 10.191,
"taskDurationMs": 1359.4880000000003,
"heapDeltaBytes": 7633908,
"heapUsedBytes": 121312596,
"domNodes": 24,
"jsHeapTotalBytes": 5246976,
"scriptDurationMs": 606.911,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665641025641023,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3194.291999999905,
"styleRecalcs": 73,
"styleRecalcDurationMs": 7.396000000000001,
"layouts": 67,
"layoutDurationMs": 10.626,
"taskDurationMs": 1286.711,
"heapDeltaBytes": -13304512,
"heapUsedBytes": 91569112,
"domNodes": -268,
"jsHeapTotalBytes": -749568,
"scriptDurationMs": 612.697,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.753403141361254,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2491.115000000036,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.02,
"layouts": 7,
"layoutDurationMs": 1.7170000000000003,
"taskDurationMs": 1359.757,
"heapDeltaBytes": 11353656,
"heapUsedBytes": 117345512,
"domNodes": 0,
"jsHeapTotalBytes": 6189056,
"scriptDurationMs": 744.024,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66577181208054,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 2322.907999999984,
"styleRecalcs": 43,
"styleRecalcDurationMs": 4.226999999999999,
"layouts": 4,
"layoutDurationMs": 0.9630000000000003,
"taskDurationMs": 1508.0659999999998,
"heapDeltaBytes": 7659580,
"heapUsedBytes": 110372160,
"domNodes": 0,
"jsHeapTotalBytes": 3674112,
"scriptDurationMs": 739.597,
"eventListeners": 182,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.909489051094894,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2038.4229999999661,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.0989999999999993,
"layouts": 10,
"layoutDurationMs": 2.137,
"taskDurationMs": 383.405,
"heapDeltaBytes": 3721620,
"heapUsedBytes": 106855536,
"domNodes": -292,
"jsHeapTotalBytes": -5599232,
"scriptDurationMs": 27.889000000000003,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2037.2330000000147,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.1460000000000004,
"layouts": 9,
"layoutDurationMs": 1.926,
"taskDurationMs": 386.895,
"heapDeltaBytes": -344308,
"heapUsedBytes": 102493588,
"domNodes": -292,
"jsHeapTotalBytes": -1404928,
"scriptDurationMs": 30.654999999999994,
"eventListeners": -130,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 631.0159999999314,
"styleRecalcs": 47,
"styleRecalcDurationMs": 4.064,
"layouts": 9,
"layoutDurationMs": 1.8699999999999999,
"taskDurationMs": 423.80299999999994,
"heapDeltaBytes": 2721208,
"heapUsedBytes": 108255228,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 119.815,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.11621621621622,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 466.1079999999629,
"styleRecalcs": 46,
"styleRecalcDurationMs": 4.114999999999998,
"layouts": 9,
"layoutDurationMs": 2.11,
"taskDurationMs": 306.253,
"heapDeltaBytes": -1580748,
"heapUsedBytes": 91174864,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 118.04899999999999,
"eventListeners": 46,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66785714285715,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2010.911999999962,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.2430000000000003,
"layouts": 10,
"layoutDurationMs": 2.0949999999999998,
"taskDurationMs": 409.607,
"heapDeltaBytes": 3510140,
"heapUsedBytes": 96050424,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 7.040999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.9920000000584,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.4930000000000003,
"layouts": 10,
"layoutDurationMs": 2.3019999999999996,
"taskDurationMs": 337.463,
"heapDeltaBytes": -13778744,
"heapUsedBytes": 92311020,
"domNodes": -214,
"jsHeapTotalBytes": 2265088,
"scriptDurationMs": 7.562999999999999,
"eventListeners": -176,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1727.3549999999886,
"styleRecalcs": 76,
"styleRecalcDurationMs": 11.762,
"layouts": 11,
"layoutDurationMs": 2.477,
"taskDurationMs": 688.35,
"heapDeltaBytes": -20394520,
"heapUsedBytes": 85570948,
"domNodes": -206,
"jsHeapTotalBytes": 3051520,
"scriptDurationMs": 81.45700000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.9459999999353,
"styleRecalcs": 75,
"styleRecalcDurationMs": 12.014,
"layouts": 10,
"layoutDurationMs": 2.121,
"taskDurationMs": 572.366,
"heapDeltaBytes": -11417852,
"heapUsedBytes": 94147644,
"domNodes": -186,
"jsHeapTotalBytes": 2789376,
"scriptDurationMs": 84.099,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-transition-enter",
"durationMs": 1318.5610000000452,
"styleRecalcs": 20,
"styleRecalcDurationMs": 19.482000000000003,
"layouts": 5,
"layoutDurationMs": 11.483,
"taskDurationMs": 814.44,
"heapDeltaBytes": 16410460,
"heapUsedBytes": 137524028,
"domNodes": 15950,
"jsHeapTotalBytes": 16392192,
"scriptDurationMs": 21.926000000000002,
"eventListeners": 3244,
"totalBlockingTimeMs": 97,
"frameDurationMs": 18.777464788732406,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8241.834000000039,
"styleRecalcs": 251,
"styleRecalcDurationMs": 17.838,
"layouts": 9,
"layoutDurationMs": 1.8920000000000001,
"taskDurationMs": 3953.044,
"heapDeltaBytes": -21543416,
"heapUsedBytes": 89145652,
"domNodes": -272,
"jsHeapTotalBytes": -28672,
"scriptDurationMs": 2057.3779999999997,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665991902834005,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8409.081000000015,
"styleRecalcs": 251,
"styleRecalcDurationMs": 17.910000000000004,
"layouts": 9,
"layoutDurationMs": 2.078,
"taskDurationMs": 4572.33,
"heapDeltaBytes": 1760504,
"heapUsedBytes": 112861988,
"domNodes": -272,
"jsHeapTotalBytes": -65536,
"scriptDurationMs": 2074.42,
"eventListeners": -128,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666138613861385,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 13661.399999999958,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12795.799,
"heapDeltaBytes": -2402164,
"heapUsedBytes": 303419580,
"domNodes": -3330,
"jsHeapTotalBytes": 25153536,
"scriptDurationMs": 189.96099999999998,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.929865771812086,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-idle",
"durationMs": 13671.313000000055,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12687.281,
"heapDeltaBytes": -24053408,
"heapUsedBytes": 287325540,
"domNodes": -3330,
"jsHeapTotalBytes": 28299264,
"scriptDurationMs": 187.938,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.6636815920398,
"p95FrameDurationMs": 33.5
},
{
"name": "vue-large-graph-pan",
"durationMs": 22330.647999999997,
"styleRecalcs": 176,
"styleRecalcDurationMs": 12.870999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21961.178,
"heapDeltaBytes": -29274388,
"heapUsedBytes": 281308728,
"domNodes": -3330,
"jsHeapTotalBytes": -5775360,
"scriptDurationMs": 708.245,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 42.02598870056497,
"p95FrameDurationMs": 83.40000000000146
},
{
"name": "vue-large-graph-pan",
"durationMs": 16521.33500000002,
"styleRecalcs": 99,
"styleRecalcDurationMs": 7.981999999999989,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15844.309,
"heapDeltaBytes": -8096120,
"heapUsedBytes": 302958540,
"domNodes": -3330,
"jsHeapTotalBytes": 22794240,
"scriptDurationMs": 650.923,
"eventListeners": -651,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.598745519713265,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6846.5419999999995,
"styleRecalcs": 20,
"styleRecalcDurationMs": 62.04100000000001,
"layouts": 20,
"layoutDurationMs": 20.317,
"taskDurationMs": 6684.574,
"heapDeltaBytes": -36230008,
"heapUsedBytes": 274459492,
"domNodes": -3330,
"jsHeapTotalBytes": 18337792,
"scriptDurationMs": 117.913,
"eventListeners": -653,
"totalBlockingTimeMs": 10,
"frameDurationMs": 37.430601092896175,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 4990.50299999999,
"styleRecalcs": 20,
"styleRecalcDurationMs": 60.35299999999999,
"layouts": 20,
"layoutDurationMs": 20.254999999999995,
"taskDurationMs": 4875.418000000001,
"heapDeltaBytes": -13165032,
"heapUsedBytes": 307646000,
"domNodes": -3330,
"jsHeapTotalBytes": 22794240,
"scriptDurationMs": 97.31500000000001,
"eventListeners": -653,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.24745762711864,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9360.339999999951,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9064.424,
"heapDeltaBytes": -4399808,
"heapUsedBytes": 289272976,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 118.37900000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.239999999999995,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9465.21400000006,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9087.715000000002,
"heapDeltaBytes": 10267992,
"heapUsedBytes": 297658812,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 121.22800000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.69792387543253,
"p95FrameDurationMs": 66.69999999999709
},
{
"name": "workflow-execution",
"durationMs": 88.99499999995442,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.005000000000001,
"layouts": 7,
"layoutDurationMs": 1.61,
"taskDurationMs": 64.81600000000002,
"heapDeltaBytes": 4794128,
"heapUsedBytes": 106356052,
"domNodes": 97,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 7.803000000000001,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 450.7619999999406,
"styleRecalcs": 21,
"styleRecalcDurationMs": 10.792,
"layouts": 12,
"layoutDurationMs": 3.9170000000000003,
"taskDurationMs": 99.92899999999999,
"heapDeltaBytes": 7039532,
"heapUsedBytes": 103333240,
"domNodes": 121,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 8.805999999999997,
"eventListeners": 1,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 265.69599999993443,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.6809999999999999,
"layouts": 76,
"layoutDurationMs": 11.485000000000001,
"taskDurationMs": 230.844,
"heapDeltaBytes": -14573136,
"heapUsedBytes": 77030076,
"domNodes": 4,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 106.938,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66874999999999,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 272.9620000000068,
"styleRecalcs": 5,
"styleRecalcDurationMs": 0.679,
"layouts": 76,
"layoutDurationMs": 11.014,
"taskDurationMs": 224.09400000000002,
"heapDeltaBytes": 9535184,
"heapUsedBytes": 94324480,
"domNodes": 4,
"jsHeapTotalBytes": 9437184,
"scriptDurationMs": 106.069,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.662499999999994,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 310.4889999999614,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.471,
"layouts": 76,
"layoutDurationMs": 10.655,
"taskDurationMs": 267.942,
"heapDeltaBytes": -1830140,
"heapUsedBytes": 114534196,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 98.95700000000001,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736862,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 305.34099999999853,
"styleRecalcs": 5,
"styleRecalcDurationMs": 1.482,
"layouts": 76,
"layoutDurationMs": 10.826,
"taskDurationMs": 268.148,
"heapDeltaBytes": -6765640,
"heapUsedBytes": 102988560,
"domNodes": 4,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 97.735,
"eventListeners": 292,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.663157894736813,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E CoverageLine coverage: 64.1% Coverage totals
Top 10 files by uncovered lines
🎭 Playwright: ✅ 2284 passed, 0 failed · 2 flaky📊 Browser Reports
🎭 Playwright Expectations UpdateTip Updated 2 screenshots taken from the E2E run without rerunning Playwright and pushed to the branch. 🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: 🟡 Withheld — could not measureExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
Findings and check detailsThe matrix runs on same-repository version-bump PRs with relevant changes, main-branch pushes, and manual dispatches. This candidate does not qualify, so every expensive stage was skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Findings and check detailsNo new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e5a8fe732edb5ba56f24212716cf61a4b73d52bc
Full docs: ADR-DEVEX-LINT-0015 🌐 Website E2ETip All tests passed. Test results
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #21251 +/- ##
==========================================
+ Coverage 86.58% 87.40% +0.82%
==========================================
Files 3755 2688 -1067
Lines 177554 149294 -28260
Branches 48947 40968 -7979
==========================================
- Hits 153728 130496 -23232
+ Misses 21759 18408 -3351
+ Partials 2067 390 -1677
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1111 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Render charge_micro_usd through formatCreditsFromUsd with the whole-credit rounding used for credit amounts elsewhere in the app, labelled with the existing Credits string. Drops the dedicated micro USD converter and the extra i18n keys.
Hovers the Additional Info icon on Settings > Plan & Credits > Activity against a mocked /customers/events page and asserts the tooltip reads "Charge: 7 Credits" for charge_micro_usd 33044, with a screenshot of each tooltip. A second row covers a non-numeric charge passing through unchanged.
This comment has been minimized.
This comment has been minimized.
Taken from the failed screenshot assertions of https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/39095924417 without rerunning Playwright. | snapshot | status | changed pixels | | --- | --- | --- | | `browser_tests/tests/dialogs/usageLogsChargeTooltip.spec.ts-snapshots/activity-charge-tooltip-credits-chromium-linux.png` | new | n/a | | `browser_tests/tests/dialogs/usageLogsChargeTooltip.spec.ts-snapshots/activity-charge-tooltip-passthrough-chromium-linux.png` | new | n/a | Screenshot capture is not bit-deterministic; small pixel deltas are usually text rasterization noise. Confirm each update corresponds to a test expected to change.
The events route is registered after boot because the usage log only reads /customers/events once the Activity tab mounts it. The Activity tab locator is exact so it does not also match the panel's "Full usage activity" button. 33,044 micro-USD is 6.97 credits at 211 credits per dollar, hence "Charge: 7 Credits".
|
|
|
|
The Event badge on Settings > Plan & Credits > Activity showed the raw type agent_usage. Give it a label and the warning severity the other usage events use. Follow-up to #21251.
…activity tooltip Manual backport of #21251. On 1.56 the tooltip is built in customerEventsService.getTooltipContent, so the charge_micro_usd special case lives there, using the same formatCreditsFromUsd whole-credit rounding.
…ctivity tooltip Manual backport of #21251. On 1.56 the tooltip is built in customerEventsService.getTooltipContent, so the charge_micro_usd special case lives there, using the same formatCreditsFromUsd whole-credit rounding.
<!-- claude-slack-attribution --> _Requested by **Denys Puziak, Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1792054147598189?thread_ts=1792054147.598189&cid=C0BGH348Z0C)_ ## Summary **Before:** In Settings > Plan & credits > Activity, the info tooltip on agent usage events showed the raw param, for example `Charge Micro Usd: 36,209`, which means nothing to users. **After:** The same line reads `Charge: 8 Credits`. The amount uses the same whole-credit rounding and `Credits` label as credit amounts elsewhere in the app, in the active locale (zero shows `0 Credits`). Non-numeric values keep the old label and value. How: `UsageLogsTable.vue` special-cases the `charge_micro_usd` param when it parses as a finite number and formats it with the existing `formatCreditsFromUsd` (micro USD / 1,000,000, no fraction digits, as `UserCredit.vue` and `useSubscriptionCredits` do), followed by the existing `credits.credits` string. No new conversion helper; one new string, `credits.charge`, in `src/locales/en/main.json`. The workspace Activity view (`WorkspaceActivityContent.vue`) does not render event params, so it needs no change. ## Verification - `pnpm exec vitest run src/components/dialog/content/setting/UsageLogsTable.test.ts`: 41 passed, including table-driven tooltip cases for conversion (33,044 micro USD to 7 Credits), numeric strings, thousands grouping, zero and non-numeric passthrough. - `pnpm typecheck`, oxfmt, oxlint, eslint, stylelint, server-facts gate and typecheck (pre-commit hook) all pass. - Browser test `browser_tests/tests/dialogs/usageLogsChargeTooltip.spec.ts` (`@screenshot`): hovers the Activity tab's info icon against a mocked `/customers/events` page and asserts `Charge: 7 Credits` for `charge_micro_usd: 33044` (no `Charge Micro Usd`), plus `Charge Micro Usd: pending` passthrough for a non-numeric value, with a screenshot of each tooltip. Linux baselines come from the `New Browser Test Expectations` CI workflow. --- _Generated by [Claude Code](https://claude.ai/code/session_013QvgAYioaYR18CeyWyUMBz)_ --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: github-actions <github-actions@github.com>
<!-- claude-slack-attribution --> _Requested by **Denys Puziak, Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1792054147598189?thread_ts=1792054147.598189&cid=C0BGH348Z0C)_ ## Summary **Before:** In Settings > Plan & credits > Activity, the info tooltip on agent usage events showed the raw param, for example `Charge Micro Usd: 36,209`, which means nothing to users. **After:** The same line reads `Charge: 8 Credits`. The amount uses the same whole-credit rounding and `Credits` label as credit amounts elsewhere in the app, in the active locale (zero shows `0 Credits`). Non-numeric values keep the old label and value. How: `UsageLogsTable.vue` special-cases the `charge_micro_usd` param when it parses as a finite number and formats it with the existing `formatCreditsFromUsd` (micro USD / 1,000,000, no fraction digits, as `UserCredit.vue` and `useSubscriptionCredits` do), followed by the existing `credits.credits` string. No new conversion helper; one new string, `credits.charge`, in `src/locales/en/main.json`. The workspace Activity view (`WorkspaceActivityContent.vue`) does not render event params, so it needs no change. ## Verification - `pnpm exec vitest run src/components/dialog/content/setting/UsageLogsTable.test.ts`: 41 passed, including table-driven tooltip cases for conversion (33,044 micro USD to 7 Credits), numeric strings, thousands grouping, zero and non-numeric passthrough. - `pnpm typecheck`, oxfmt, oxlint, eslint, stylelint, server-facts gate and typecheck (pre-commit hook) all pass. - Browser test `browser_tests/tests/dialogs/usageLogsChargeTooltip.spec.ts` (`@screenshot`): hovers the Activity tab's info icon against a mocked `/customers/events` page and asserts `Charge: 7 Credits` for `charge_micro_usd: 33044` (no `Charge Micro Usd`), plus `Charge Micro Usd: pending` passthrough for a non-numeric value, with a screenshot of each tooltip. Linux baselines come from the `New Browser Test Expectations` CI workflow. --- _Generated by [Claude Code](https://claude.ai/code/session_013QvgAYioaYR18CeyWyUMBz)_ --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: github-actions <github-actions@github.com>
…activity tooltip (#21277) Manual backport of #21251 to `cloud/1.56` (auto-backport hit conflicts), plus the label from #21276. **Before:** Activity tooltip showed `Charge Micro Usd: 33,044`; the event badge showed raw `agent_usage`. **After:** `Charge: 7 Credits` (whole credits, app language) and an "Agent Usage" badge. Other tooltip params are now escaped (1.56 renders this tooltip as HTML). <details><summary>Full context</summary> - On 1.56 the tooltip HTML is built in `customerEventsService.getTooltipContent` (main builds it in `UsageLogsTable.vue`), so the `charge_micro_usd` case lives there. Same rule as main: finite numeric (or numeric string) values convert with `formatCreditsFromUsd` (micro USD / 1,000,000, 0 fraction digits, `i18n.global.locale`) plus `credits.credits`; non-numeric values keep the raw key/value. - Commits: (1) credits tooltip, (2) `agent_usage` -> `credits.eventTypes.agentUsage` + warning severity (label half of #21276; its browser fixture does not exist on 1.56), (3) pass the app locale, matching main's `locale: locale.value`, (4) escape param keys/values with `escapeHtml`: the tooltip uses `escape: false` on 1.56 and params can carry user text such as prompts (see https://linear.app/comfyorg/issue/FE-2429). main and 1.57 no longer render this tooltip as HTML. - Adds en strings `credits.charge` and `credits.eventTypes.agentUsage` (same keys as main). - Unit: table-driven `getTooltipContent` cases (33,044 -> 7, '36209' -> 8, 0 -> 0, 'n/a' passthrough), a German-locale case (2.110.000) a charge next to other params, and markup in a param key/value rendered as text. The credits, label, locale and markup cases were each red before their fix. - No browser test: main's `usageLogsChargeTooltip.spec.ts` relies on fixtures not on 1.56. </details>
…ctivity tooltip (#21278) Manual backport of #21251 to `core/1.56` (auto-backport hit conflicts), plus the label from #21276. **Before:** Activity tooltip showed `Charge Micro Usd: 33,044`; the event badge showed raw `agent_usage`. **After:** `Charge: 7 Credits` (whole credits, app language) and an "Agent Usage" badge. Other tooltip params are now escaped (1.56 renders this tooltip as HTML). <details><summary>Full context</summary> - On 1.56 the tooltip HTML is built in `customerEventsService.getTooltipContent` (main builds it in `UsageLogsTable.vue`), so the `charge_micro_usd` case lives there. Same rule as main: finite numeric (or numeric string) values convert with `formatCreditsFromUsd` (micro USD / 1,000,000, 0 fraction digits, `i18n.global.locale`) plus `credits.credits`; non-numeric values keep the raw key/value. - Commits: (1) credits tooltip, (2) `agent_usage` -> `credits.eventTypes.agentUsage` + warning severity (label half of #21276; its browser fixture does not exist on 1.56), (3) pass the app locale, matching main's `locale: locale.value`, (4) escape param keys/values with `escapeHtml`: the tooltip uses `escape: false` on 1.56 and params can carry user text such as prompts (see https://linear.app/comfyorg/issue/FE-2429). main and 1.57 no longer render this tooltip as HTML. - Adds en strings `credits.charge` and `credits.eventTypes.agentUsage` (same keys as main). - Unit: table-driven `getTooltipContent` cases (33,044 -> 7, '36209' -> 8, 0 -> 0, 'n/a' passthrough), a German-locale case (2.110.000) a charge next to other params, and markup in a param key/value rendered as text. The credits, label, locale and markup cases were each red before their fix. - No browser test: main's `usageLogsChargeTooltip.spec.ts` relies on fixtures not on 1.56. </details>
…mfy-Org#21276) ## Summary **Before:** agent usage rows on Settings > Plan & Credits > Activity showed the raw type `agent_usage` in the Event column. **After:** they read `Agent Usage`, with the same warning badge as other usage events. <details><summary>Full context for agent readers</summary> - `customerEventsService.formatEventType` maps `agent_usage` to the new `credits.eventTypes.agentUsage` string; `getEventSeverity` returns `warning` for it, like `api_node_usage` and `gpu_usage`. - Unit: `customerEventsService.test.ts` covers the label key and severity (red before the change). - The browser test from Comfy-Org#21251 (`usageLogsChargeTooltip.spec.ts`) finds the agent row by its badge text, so its fixture constant moves from `agent_usage` to `Agent Usage`. The tooltip screenshots are unchanged. - Follow-up to Comfy-Org#21251 (PM-2137). Platform counterpart for the same raw label: Comfy-Org/platform#1422. - Linear: https://linear.app/comfyorg/issue/PM-2137 </details>
…ist (Comfy-Org#17858) ## ELI5 The usage log has a little (i) icon whose tooltip printed *every* field the billing feed happened to attach to an event. That feed's field list is open-ended, so anything the backend starts storing shows up in a customer's tooltip for free — today that includes our internal provider-cost numbers and, on the workspace-scoped feed, other members' prompts. This PR replaces "print everything" with "print these twelve fields", so the tooltip can only ever show what we chose to show. The agent usage charge is still shown, as credits. ## Summary `getTooltipContent` now renders a fixed allowlist of `params` keys instead of iterating the object, as plain-text `Key: value` lines that `UsageLogsTable.vue` passes to the design-system tooltip. `hasAdditionalInfo` is derived from that same list, so the icon is only shown when the tooltip has something to say. ## Changes - **What**: a new pure module `src/services/customerEventParams.ts` holds `TOOLTIP_PARAM_ALLOWLIST` (`credits_used`, `amount`, `model`, `api_name`, `endpoint`, `subscription_id`, `gpu_seconds`, `duration`, plus the agent usage keys `charge_micro_usd`, `input_tokens`, `output_tokens`, `cached_input_tokens` that main's Comfy-Org#21251 renders and its browser test asserts). `getTooltipContent` renders only allowlisted keys with a non-null, non-empty value, one `Key: value` line each. A numeric `charge_micro_usd` renders as `Charge: N Credits`, or `Charge: <1 Credits` for a non-zero charge under one credit (Comfy-Org#21251's formatting and Comfy-Org#22470's sub-credit rule from the component, now done inside `getTooltipContent`). Main's tooltip migration (Comfy-Org#16325) made the tooltip plain text, so values are no longer HTML and need no escaping; the table now calls `getTooltipContent` instead of its own unfiltered `additionalInfoTooltip`. `hasAdditionalInfo` uses the same present-key filter, minus the keys the Details column already shows for that event type (`credit_added` → `amount`, `api_usage_completed` → `api_name`/`model`, matching `UsageLogsTable.vue`), so a shown icon always has a non-empty tooltip. The service and its manual mock (`src/services/__mocks__/customerEventsService.ts`) both use this module, so component tests see production filtering. - **Breaking**: user-visible narrowing. A params key outside the allowlist is no longer rendered, and a row whose only extra params are outside it no longer shows an info icon. That is the intended effect, not a regression. - Tests: `customerEventsService.test.ts` now asserts the allowlist directly, including a case built from a params object carrying `prompt`, `credits` and `final_unit_deduction` alongside a legitimate key — the output is exactly the legitimate key. The old tests asserted the leaky behaviour (they used `extra_param`, `transaction_id` and `status` as examples of things that *should* render), so they were rewritten rather than extended. ## Review Focus **Why a frontend allowlist and not just a backend strip.** The generated ingest schema in this repo types the field as an open map — `packages/ingest-types/src/zod.gen.ts:3655` has `params: z.record(z.string(), z.unknown()).optional()`, with no named keys at all. There is no contract here saying which keys arrive, which is precisely why a denylist or a backend-only fix can be silently re-opened by the next thing the backend decides to store. An allowlist at the render site cannot be. **Both rails are covered.** `UsageLogsTable.vue` feeds rows from either `customerEventService.getMyEvents()` (legacy) or the workspace read (`billingApi.getBillingEvents()` or the billing rail's `readEvents`) into the same `hasAdditionalInfo` / `getTooltipContent` pair, so the workspace-scope prompt exposure is closed by the same change. I grepped for other consumers: `usePendingTopup` reads `event_type` / `createdAt` only and never touches `params`, and `UsageLogsTable.vue` is the only renderer. No other call site. **Red-then-green was checked, not assumed.** I ran the new service tests against the unmodified implementation: 4 failed, and the failure output printed the leak verbatim (`<strong>Prompt:</strong> a private prompt…<br><strong>Credits:</strong> 500,000,000<br><strong>Final Unit Deduction:</strong> 12,345`). With the fix applied, 45 pass. **Judgment call worth a look.** `hasAdditionalInfo` leaves out the keys the Details column already prints for that event type, so the icon doesn't light up on rows with nothing new to say. The guarantee runs one way: if the icon is shown, the tooltip is non-empty. The reverse doesn't hold: an `api_usage_completed` row with only `model` has tooltip content but no icon. Event types whose Details column shows none of these keys (`api_node_usage`, `gpu_usage`, `topup_completed`) show the icon for any allowlisted key. Rendering order is now the allowlist's order rather than the backend's object-key order. Deterministic either way; flagging it because it is a visible diff in the tooltip for multi-key rows. ## Residual **The backend still stores and returns these fields.** This PR is the defence-in-depth half only. The upstream feed continues to persist the raw properties map and return it whole, so any *other* consumer of that endpoint — now or later — still receives the provider-cost keys and the prompt. The server-side strip is tracked separately and deliberately not blocked on this change. **Benign fields were narrowed away too.** Keys such as `transaction_id` and `status` appeared in this repo's own prior tests as things the tooltip rendered. They are not on the allowlist and so are now dropped. If any of them is load-bearing for support workflows, the allowlist is the one place to add it back — but it should be added deliberately, and the additions should stay in sync with the sibling surface below. **Unexercised artifacts.** (1) The sibling module that this allowlist is meant to match is not in this repository — grep finds no `auditLogDisplay` anywhere in this checkout. The original eight keys were transcribed from the specification of this change, not read from that module's source, so a reviewer with access to it should confirm the list is still identical. (2) I made no live or staging call to the billing events endpoint from this environment, so *which* keys real events actually carry is unverified from here; the only in-repo evidence is the open-map schema cited above (which names no keys) and the single E2E mock in `browser_tests/fixtures/apiKeyAuthFixture.ts:153`, which sends `params: { amount }` only. That mock's row shows no info icon before or after this change, so E2E behaviour is unchanged — but it also means nothing in this repo can demonstrate a populated tooltip end to end. Concretely: if the live feed turns out to use different names for these concepts, this change would render an empty tooltip rather than a wrong one, and the icon would correctly not appear — a fail-closed outcome, but one that would go unnoticed until someone looks at a real usage log. **Out of scope by design.** Whether a workspace owner should be able to read other members' prompts *at all* is a product and privacy-posture question about the feed's workspace scope, not a rendering decision. This PR only stops this surface from displaying them. ## Provenance - **Authored by:** agent-work loop - **Verified:** - Merged `main` at `63b649ef70` (the 10 later `main` commits touch none of these files and merge cleanly): the table now uses main's telemetry and icon changes, and Comfy-Org#22470's `<1` charge rule moved into `getTooltipContent`. Its charge cases moved from `UsageLogsTable.test.ts` to `customerEventsService.test.ts`, because the component test mocks the service. - `vitest run` on `customerEventsService.test.ts` and `UsageLogsTable.test.ts` at the current head: 99 passed, including the sub-credit charge cases and the component case that keeps a `prompt` param out of the tooltip. - `pnpm typecheck`, `pnpm knip`, eslint and oxfmt on the touched files: clean. `pnpm architecture:check`: passes, with a non-blocking warning that `customerEventParams.ts` is unclaimed by a domain, one of 324 such warnings. - The browser test `usageLogsChargeTooltip.spec.ts`, including its sub-credit screenshot, was not run locally; CI's required `e2e-status` check passes on the current head. - **Deviations:** - The allowlist tests live mainly in `customerEventsService.test.ts` because `UsageLogsTable.test.ts` mocks the whole service module; the mock shares the filter module, so the component case above exercises the real filtering. - Main's new `no-circular` rule flagged a type-only import from `customerEventParams.ts` back to the service. That import and its `satisfies` key check were removed; the `hasAdditionalInfo` tests still pin the event-type keys. - The agent usage token counts were allowlisted to keep Comfy-Org#21251's tooltip contents. - Review findings asking to restore `transaction_id`/`status`/`payment_method` were deferred as a product decision. --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Requested by Denys Puziak, Christian Byrne · Slack thread
Summary
Before: Settings > Plan & credits > Activity showed agent usage as
agent_usagewith a tooltip line likeCharge Micro Usd: 33,044.After: the row reads
Agent Usageand the tooltip readsCharge: 7 Credits, using the same whole-credit rounding as the rest of the app.Full context for agent readers
How:
UsageLogsTable.vuespecial-casescharge_micro_usdwhen it parses as a finite number and formats it with the existingformatCreditsFromUsd(micro USD / 1,000,000, no fraction digits, asUserCredit.vueanduseSubscriptionCreditsdo), followed by the existingcredits.creditsstring. Non-numeric values keep the old label and value. No new conversion helper.customerEventsService.formatEventTypemapsagent_usagetocredits.eventTypes.agentUsage("Agent Usage") with thewarningseverity the other usage events use. New en strings:credits.charge,credits.eventTypes.agentUsage.WorkspaceActivityContent.vue) does not render event params, so it needs no change.Verification:
UsageLogsTable.test.ts: table-driven tooltip cases (33,044 micro USD to 7 Credits, numeric strings, grouping, zero, non-numeric passthrough).customerEventsService.test.ts:agent_usagelabel key and severity (red before the fix).browser_tests/tests/dialogs/usageLogsChargeTooltip.spec.ts(@screenshot): mocked/customers/events, hovers the info icon on theAgent Usagerow, assertsCharge: 7 Creditsand noCharge Micro Usd, plus non-numeric passthrough; screenshot of each tooltip (Linux baselines from the expectations workflow; the tooltips themselves did not change in the label commit).main(overlap insrc/locales/en/main.json).Backports:
core/1.57,cloud/1.57(same tooltip code). Not 1.56: its tooltip is built in a different place (getTooltipContent), so this diff does not apply.Platform counterpart: Comfy-Org/platform#1421.