Repository navigation
FE-3135 fix(billing): show Subscription paused copy for payment_failed renewals - #19677
Conversation
Runs are already blocked on payment_failed, so "update payment to avoid a pause" describes a warning stage that does not exist. Until BE-6970 records failed renewals as paused, the payment_failed banner reuses the paused copy and keeps its Pay invoice / Update payment actions. The member paused banner uses the informational (grey) icon.
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2161 passed, 0 failed📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (7 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 7ca90bfa3f397e329edd2467cec940b6977fa523
Full docs: ADR-DEVEX-LINT-0015 📦 Bundle: 10.1 MB gzip 🟢 -449 BDetailsSummary
Category Glance App Entry Points — 3.8 kB (baseline 3.8 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.46 MB (baseline 1.46 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 133 kB (baseline 133 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 643 kB (baseline 643 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 49.9 kB (baseline 49.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 8 added / 8 removed / 6 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 150 kB (baseline 150 kB) • ⚪ 0 BReusable component library chunks
Status: 8 added / 8 removed / 9 unchanged Data & Services — 4.1 MB (baseline 4.1 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 12 added / 12 removed / 3 unchanged Utilities & Hooks — 584 kB (baseline 584 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 21 added / 21 removed / 16 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 18.2 MB (baseline 18.2 MB) • 🟢 -1.43 kBBundles that do not match a named category
Status: 84 added / 84 removed / 221 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-30T23:34:39.006Z",
"gitSha": "8a3ff83d059d7b1afc052a3e1a665d224150749d",
"branch": "jaewon/fe-3135-payment-failed-paused-copy",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2021.7350000000351,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.219,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 516.965,
"heapDeltaBytes": -6258564,
"heapUsedBytes": 74923676,
"domNodes": -232,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 13.315000000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2038.4730000000673,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.9439999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 440.565,
"heapDeltaBytes": -7285200,
"heapUsedBytes": 74139272,
"domNodes": -232,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 8.184999999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1793.0680000000052,
"styleRecalcs": 54,
"styleRecalcDurationMs": 16.366000000000003,
"layouts": 12,
"layoutDurationMs": 4.1899999999999995,
"taskDurationMs": 837.8219999999999,
"heapDeltaBytes": 19038896,
"heapUsedBytes": 72453364,
"domNodes": -231,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 170.613,
"eventListeners": -138,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665420560747663,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1774.6099999999387,
"styleRecalcs": 54,
"styleRecalcDurationMs": 15.223999999999998,
"layouts": 12,
"layoutDurationMs": 3.9690000000000003,
"taskDurationMs": 770.9970000000001,
"heapDeltaBytes": -29087164,
"heapUsedBytes": 72570216,
"domNodes": -236,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 153.644,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66635514018692,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1682.9470000000128,
"styleRecalcs": 29,
"styleRecalcDurationMs": 9.1,
"layouts": 6,
"layoutDurationMs": 1.1569999999999998,
"taskDurationMs": 314.251,
"heapDeltaBytes": -1301868,
"heapUsedBytes": 57689676,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.966,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.3060000000032,
"styleRecalcs": 32,
"styleRecalcDurationMs": 8.519999999999998,
"layouts": 6,
"layoutDurationMs": 1.1019999999999999,
"taskDurationMs": 332.451,
"heapDeltaBytes": 25341524,
"heapUsedBytes": 78573356,
"domNodes": -179,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.947999999999999,
"eventListeners": -149,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 743.1490000000167,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.6170000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 502.355,
"heapDeltaBytes": -13050832,
"heapUsedBytes": 67794644,
"domNodes": -232,
"jsHeapTotalBytes": -1310720,
"scriptDurationMs": 167.40099999999998,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665909090909096,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 656.4569999999321,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.905,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 433.25800000000004,
"heapDeltaBytes": 14538128,
"heapUsedBytes": 68139164,
"domNodes": -231,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 166.26399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666654,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1188.2469999999898,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 860.227,
"heapDeltaBytes": 13999020,
"heapUsedBytes": 92734292,
"domNodes": 0,
"jsHeapTotalBytes": 8290304,
"scriptDurationMs": 72.35799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 542,
"frameDurationMs": 34.8029411764706,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1113.830999999891,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 788.0200000000001,
"heapDeltaBytes": 15584684,
"heapUsedBytes": 92544824,
"domNodes": 0,
"jsHeapTotalBytes": 3047424,
"scriptDurationMs": 64.741,
"eventListeners": 0,
"totalBlockingTimeMs": 507,
"frameDurationMs": 33.83636363636362,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 862.6209999999901,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 496.67400000000004,
"heapDeltaBytes": -7856000,
"heapUsedBytes": 89809020,
"domNodes": 0,
"jsHeapTotalBytes": 3149824,
"scriptDurationMs": 172.80900000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 223,
"frameDurationMs": 24.76000000000001,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 860.0780000000441,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.57899999999984,
"heapDeltaBytes": 16792492,
"heapUsedBytes": 118682056,
"domNodes": 0,
"jsHeapTotalBytes": 4198400,
"scriptDurationMs": 166.43399999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 232,
"frameDurationMs": 25.49117647058823,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9247.503999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8487.272,
"heapDeltaBytes": 12027936,
"heapUsedBytes": 80244996,
"domNodes": -142,
"jsHeapTotalBytes": -4067328,
"scriptDurationMs": 7151.887000000001,
"eventListeners": -70,
"totalBlockingTimeMs": 894,
"frameDurationMs": 34.841509433962266,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9676.125000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8792.182,
"heapDeltaBytes": -13858584,
"heapUsedBytes": 66815812,
"domNodes": 0,
"jsHeapTotalBytes": -17301504,
"scriptDurationMs": 7130.528,
"eventListeners": 0,
"totalBlockingTimeMs": 626,
"frameDurationMs": 31.9023102310231,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10663.281999999981,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9676.309,
"heapDeltaBytes": -6847596,
"heapUsedBytes": 74460892,
"domNodes": 0,
"jsHeapTotalBytes": -3145728,
"scriptDurationMs": 7976.746999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 1210,
"frameDurationMs": 32.27151515151515,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9596.795000000042,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8784.536000000002,
"heapDeltaBytes": -871836,
"heapUsedBytes": 79742460,
"domNodes": 0,
"jsHeapTotalBytes": -15466496,
"scriptDurationMs": 7212.535,
"eventListeners": 0,
"totalBlockingTimeMs": 705,
"frameDurationMs": 31.7317880794702,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2042.7650000000313,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.543,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 655.468,
"heapDeltaBytes": -13081452,
"heapUsedBytes": 82664736,
"domNodes": -328,
"jsHeapTotalBytes": -1445888,
"scriptDurationMs": 33.952999999999996,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666942148760327,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2047.16499999995,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.0830000000000024,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 557.9129999999999,
"heapDeltaBytes": -12944376,
"heapUsedBytes": 82472536,
"domNodes": -328,
"jsHeapTotalBytes": -397312,
"scriptDurationMs": 28.46499999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2490.2359999999817,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.31,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1627.2720000000002,
"heapDeltaBytes": -5591512,
"heapUsedBytes": 68306436,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 828.1229999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666216216216213,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2209.5659999999953,
"styleRecalcs": 65,
"styleRecalcDurationMs": 8.528999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1566.7690000000002,
"heapDeltaBytes": 19644872,
"heapUsedBytes": 82877588,
"domNodes": -328,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 784.731,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665151515151518,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3588.632999999959,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.177000000000001,
"layouts": 60,
"layoutDurationMs": 13.103,
"taskDurationMs": 1667.2640000000004,
"heapDeltaBytes": 8172128,
"heapUsedBytes": 72552884,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 765.822,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666046511627908,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3560.628999999949,
"styleRecalcs": 63,
"styleRecalcDurationMs": 10.122,
"layouts": 60,
"layoutDurationMs": 13.125,
"taskDurationMs": 1681.971,
"heapDeltaBytes": 9783088,
"heapUsedBytes": 74076428,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 805.7700000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666197183098593,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3094.9850000000083,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.334999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1883.957,
"heapDeltaBytes": 26368028,
"heapUsedBytes": 90316944,
"domNodes": 0,
"jsHeapTotalBytes": 942080,
"scriptDurationMs": 948.8069999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.756521739130434,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3081.0160000000906,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.818000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1926.46,
"heapDeltaBytes": -6325972,
"heapUsedBytes": 70171504,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 985.5050000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.756830601092897,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2051.856999999984,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.9490000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.7079999999999,
"heapDeltaBytes": -13332692,
"heapUsedBytes": 83663880,
"domNodes": -328,
"jsHeapTotalBytes": -397312,
"scriptDurationMs": 29.743999999999993,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536584,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2037.149999999997,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.7319999999999984,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 544.093,
"heapDeltaBytes": -25603108,
"heapUsedBytes": 83157804,
"domNodes": -328,
"jsHeapTotalBytes": -622592,
"scriptDurationMs": 34.02300000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 589.9889999999459,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.4060000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 398.53900000000004,
"heapDeltaBytes": -19907676,
"heapUsedBytes": 62526092,
"domNodes": -250,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 140.19299999999998,
"eventListeners": -204,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667647058823537,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 573.1490000000576,
"styleRecalcs": 45,
"styleRecalcDurationMs": 4.827000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 380.07,
"heapDeltaBytes": 8620444,
"heapUsedBytes": 62107836,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 141.632,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714266,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2057.615999999996,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.076,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 533.984,
"heapDeltaBytes": -9235400,
"heapUsedBytes": 73373900,
"domNodes": -250,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 12.444999999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.801639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2008.0709999999726,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.6869999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 390.83600000000007,
"heapDeltaBytes": 22288116,
"heapUsedBytes": 75838300,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 6.880000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66611570247934,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1732.5220000000172,
"styleRecalcs": 80,
"styleRecalcDurationMs": 18.692,
"layouts": 16,
"layoutDurationMs": 5.337,
"taskDurationMs": 807.909,
"heapDeltaBytes": 14948144,
"heapUsedBytes": 67851180,
"domNodes": -250,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 115.69099999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1721.8129999999974,
"styleRecalcs": 78,
"styleRecalcDurationMs": 17.328,
"layouts": 16,
"layoutDurationMs": 5.236,
"taskDurationMs": 760.668,
"heapDeltaBytes": -35448808,
"heapUsedBytes": 68308540,
"domNodes": -250,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 105.46799999999999,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667307692307688,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1368.0309999999736,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.366000000000003,
"layouts": 5,
"layoutDurationMs": 12.871,
"taskDurationMs": 854.2750000000001,
"heapDeltaBytes": 23926292,
"heapUsedBytes": 108532164,
"domNodes": 13747,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 27.212000000000007,
"eventListeners": 2383,
"totalBlockingTimeMs": 129,
"frameDurationMs": 19.21249999999999,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8455.692999999996,
"styleRecalcs": 251,
"styleRecalcDurationMs": 32.99,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5683.576999999999,
"heapDeltaBytes": -22935276,
"heapUsedBytes": 78777108,
"domNodes": -328,
"jsHeapTotalBytes": 880640,
"scriptDurationMs": 2668.962,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.698814229249013,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8530.697000000033,
"styleRecalcs": 250,
"styleRecalcDurationMs": 32.821999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5737.664000000001,
"heapDeltaBytes": -15974816,
"heapUsedBytes": 78798132,
"domNodes": -328,
"jsHeapTotalBytes": 581632,
"scriptDurationMs": 2682.0440000000003,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.698431372549017,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 16596.61299999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15607.655,
"heapDeltaBytes": -36548400,
"heapUsedBytes": 188377796,
"domNodes": -3045,
"jsHeapTotalBytes": 4333568,
"scriptDurationMs": 237.59,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.375042735042737,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "vue-large-graph-idle",
"durationMs": 12493.266000000061,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11555.489,
"heapDeltaBytes": -17720016,
"heapUsedBytes": 191583676,
"domNodes": -3046,
"jsHeapTotalBytes": 10768384,
"scriptDurationMs": 197.14499999999998,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.221731748726658,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-pan",
"durationMs": 20103.058999999972,
"styleRecalcs": 170,
"styleRecalcDurationMs": 17.222000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19671.675,
"heapDeltaBytes": -30014492,
"heapUsedBytes": 180210908,
"domNodes": -3045,
"jsHeapTotalBytes": 5591040,
"scriptDurationMs": 846.2350000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 36.574363636363636,
"p95FrameDurationMs": 83.30000000000109
},
{
"name": "vue-large-graph-pan",
"durationMs": 20470.96399999998,
"styleRecalcs": 165,
"styleRecalcDurationMs": 16.68,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20061.630999999998,
"heapDeltaBytes": -39981128,
"heapUsedBytes": 168463356,
"domNodes": -3045,
"jsHeapTotalBytes": 5787648,
"scriptDurationMs": 830.602,
"eventListeners": -14915,
"totalBlockingTimeMs": 18,
"frameDurationMs": 37.241090909090914,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6004.868999999985,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.66799999999999,
"layouts": 20,
"layoutDurationMs": 22.696999999999996,
"taskDurationMs": 5868.637000000001,
"heapDeltaBytes": 8046996,
"heapUsedBytes": 209331728,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 103.603,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.96593406593407,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 5955.356000000052,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.72700000000002,
"layouts": 20,
"layoutDurationMs": 22.96100000000001,
"taskDurationMs": 5854.177000000001,
"heapDeltaBytes": 949644,
"heapUsedBytes": 225749424,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 100.422,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 33.14666666666666,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8383.014000000003,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7903.967,
"heapDeltaBytes": -14826708,
"heapUsedBytes": 182106432,
"domNodes": -3045,
"jsHeapTotalBytes": 4804608,
"scriptDurationMs": 142.91000000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.13120805369128,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8473.899000000074,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7996.405000000001,
"heapDeltaBytes": -46647308,
"heapUsedBytes": 182307668,
"domNodes": -3045,
"jsHeapTotalBytes": 6836224,
"scriptDurationMs": 120.78200000000005,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 28.796938775510203,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "workflow-execution",
"durationMs": 477.3190000000227,
"styleRecalcs": 13,
"styleRecalcDurationMs": 15.767000000000003,
"layouts": 3,
"layoutDurationMs": 0.964,
"taskDurationMs": 126.70899999999996,
"heapDeltaBytes": 5780780,
"heapUsedBytes": 59538844,
"domNodes": 104,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 11.354,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241368,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "workflow-execution",
"durationMs": 187.66099999993457,
"styleRecalcs": 9,
"styleRecalcDurationMs": 13.824,
"layouts": 3,
"layoutDurationMs": 1.8479999999999999,
"taskDurationMs": 176.872,
"heapDeltaBytes": -28162516,
"heapUsedBytes": 53775380,
"domNodes": -100,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 7.823000000000002,
"eventListeners": -146,
"totalBlockingTimeMs": 0,
"frameDurationMs": 22.233333333333274,
"p95FrameDurationMs": 50
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 772.2380000000157,
"styleRecalcs": 78,
"styleRecalcDurationMs": 96.509,
"layouts": 76,
"layoutDurationMs": 23.642,
"taskDurationMs": 734.9910000000001,
"heapDeltaBytes": 16354940,
"heapUsedBytes": 86828736,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 289.33500000000004,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665217391304356,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 876.9629999999324,
"styleRecalcs": 78,
"styleRecalcDurationMs": 103.13600000000001,
"layouts": 76,
"layoutDurationMs": 25.243000000000002,
"taskDurationMs": 844.053,
"heapDeltaBytes": 17555628,
"heapUsedBytes": 84910644,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 361.442,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1329.1900000000396,
"styleRecalcs": 78,
"styleRecalcDurationMs": 244.102,
"layouts": 76,
"layoutDurationMs": 27.934,
"taskDurationMs": 1304.21,
"heapDeltaBytes": -19405568,
"heapUsedBytes": 108678392,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 440.077,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.093589743589757,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1340.8289999999852,
"styleRecalcs": 78,
"styleRecalcDurationMs": 248.944,
"layouts": 76,
"layoutDurationMs": 27.144000000000002,
"taskDurationMs": 1314.529,
"heapDeltaBytes": -19101884,
"heapUsedBytes": 108587352,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 443.487,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.092307692307678,
"p95FrameDurationMs": 16.799999999999272
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughPayment-failure banners now use the paused-subscription title, body, and action. Their muting follows subscription-management permission. The component no longer formats invoice amounts or uses payment-warning translations. ChangesBilling status banners
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The banner changes align payment-failure messaging with paused subscriptions while retaining payment recovery actions and existing visibility. No concrete merge-blocking issue is identified; merge after normal checks. 🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (6 passed)
Full details: End-To-End Regression Coverage For FixesExplanation The title and commit subject use the bug-fix signal “fix”. The PR changes frontend files under
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19677 +/- ##
==========================================
+ Coverage 84.54% 85.27% +0.72%
==========================================
Files 3363 2364 -999
Lines 161887 135630 -26257
Branches 42143 36546 -5597
==========================================
- Hits 136863 115653 -21210
+ Misses 23106 19615 -3491
+ Partials 1918 362 -1556
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1006 files with indirect coverage changes 🚀 New features to boost your workflow:
|
christian-byrne
left a comment
There was a problem hiding this comment.
- Reviewed the exact current head; the payment-failed renewal state now renders the paused-subscription copy without changing workspace selection.
- CI is settled green and there are no unresolved review threads.
Full context for agent readers
The change is narrowly scoped to the billing state presentation and its coverage. Tab-local workspace scope remains intact: separate tabs may intentionally use different workspaces.
|
|
…copy for payment_failed renewals (#19677) (#19748) *PR Created by the Glary-Bot Agent* --- Manual backport of #19677 to `cloud/1.55`, from the v1.56.2 backport-status report. Companion to #19746 (`core/1.55`). Cherry-picked from upstream merge commit `13a9333e54`. Requested in [#frontend-releases](https://comfy-organization.slack.com/archives/C09K9TPU2G7/p1790847308032919) as a cherry-pick "carrier" backport, one per target branch. #19677 is the only PR the report flags for `cloud/1.55` that is actually backportable, so this carrier carries one commit — see "Why this carrier holds one commit" below. ## Why For a `payment_failed` renewal the run button is already locked, but the settings banner said "Update payment to avoid a pause" — copy describing a warning stage that does not exist, because the backend never sets `paused` on renewal failure (BE-6970). `payment_failed` now reads as paused, and the member paused banner gets the informational grey icon. ## Conflict resolution Identical to #19746: `BillingStatusBanner.vue` and `BillingStatusBanner.test.ts` are **byte-identical** between `core/1.55` and `cloud/1.55` at their bases (verified by blob hash), so this is the same resolution. `cloud/1.55` predates main's refactor of this banner into per-kind view factories, and has no renewal-invoice support: `BannerView` has no `payInvoiceUrl`, the template has no Pay invoice button, there is no `payInvoice` string, and `useBillingContext` does not expose `renewalInvoice`. The upstream diff was applied as behaviour, not as text. - **`BillingStatusBanner.vue`** — kept this branch's single `switch`-based `banner` computed rather than main's `pausedView()`/`paymentFailedView()` factories. Accept-theirs would have produced a broken hybrid and dragged in an unrelated `isEnterprisePlan` ending-copy change not on this branch. `paymentFailed` now shares the `paused` case, and `paused` is muted for members. The Pay invoice branch is omitted — that feature does not exist here. - **`BillingStatusBanner.test.ts`** — dropped upstream's edits to the `renewal invoice` describe block; that block does not exist on this branch. Kept the renamed payment_failed test and its updated paused-copy assertions. - **`src/locales/en/main.json`** — removed the now-unused `billingStatus.warning` strings. This file is *not* identical between the 1.55 branches, so the conflict was resolved in place rather than by reusing the `core/1.55` blob; the `billingStatus` sub-tree is identical (verified by hash) and the banner was the strings' only consumer. Semantics preserved exactly: upstream's `pausedView()` is `{ muted: !canManage, title: paused.title, body: canManage ? paused.body : paused.memberBody, action: canManage ? 'updatePayment' : null, dismissible: false }`, and the merged `case 'paused'/'paymentFailed'` arm reproduces that. `useBillingBanner` gates `paymentFailed` on `canManage`, so the newly-gated `action` and `muted` resolve to the same values upstream produces. No backport-only compatibility shim was needed; no public API shape or callback signature changed. The resulting net diff is identical to #19746 (3 files, +7/−24). ## Validation - `pnpm test:unit BillingStatusBanner.test.ts` — 20/20 passing - `pnpm typecheck` — exit 0 - `pnpm exec oxfmt --check` on changed files — clean - Rendered verification was done on the identical `core/1.55` component tree (see #19746 for screenshots and the live-DOM icon-class/colour table): `payment_failed` owner flips from "Payment failed / …avoid a pause" to "Subscription paused / …Update payment to resume", and the paused **member** icon flips from amber `icon-[lucide--triangle-alert]` `rgb(252,191,100)` to grey `icon-[lucide--circle-alert]` `rgb(73,74,80)`, with the paused owner unchanged. No E2E added — matching upstream, which notes Playwright cannot put a real workspace into these billing states. ## Why this carrier holds one commit The report flagged four PRs as "❗ Need backport". Two cannot be carried: - **#19053** ("restore live turn after panel remount", PM-1776) — **not merged.** Only `refs/pull/19053/head` exists; it is 69 commits ahead of `main` with no squash commit, which is why the report listed it without a `(#NNNNN)` suffix. There is nothing to cherry-pick. - **#19240** ("say when the open workflow is deleted") — flagged for `cloud/1.55`, but its **prerequisite is missing on every target branch.** Its mechanism marks the target unavailable so the in-chat notice from #18866 renders. Neither `markWorkflowTargetUnavailable`/`targetUnavailable` nor the `targetWorkflowUnavailable` string exists on `core/1.54`, `cloud/1.54`, `core/1.55` or `cloud/1.55`, and the 1.55 branches still use the older `WorkflowTargetSelection` model instead of `TargetTracking` — so the cherry-pick does not even apply here. Carrying it would set a state nothing renders, a silent no-op defeating the fix. It needs #18866 backported first. #18074 is labelled `core/1.54` + `cloud/1.54` only, so it is not in this branch's scope. Original PR: #19677 / Original commit: `13a9333e5426d6e2e2f5f61d3da72a8184176a75` Justification: Standing Agent release-backport grant; independent exact-head audit found faithful cloud/1.55 adaptation, all hosted checks are terminal green at aed7958, and the live target advanced by three commits with zero changed-file overlap. REVIEW_REQUIRED alone is not an added approval requirement for this grant. Co-authored-by: Dante <bunggl@naver.com>
Comfy-Org#19680) ## Summary Bring the `billing_control_enabled` banners in line with the design review before the flag ramps: copy, roles, actions, and dates now match the [Billing banners reference](https://www.figma.com/design/CkFTD4c20PyRGpNVAJgpfV/Workspaces--BIlling--Team-Plans?node-id=7186-30627). Rebased on main after Comfy-Org#19677 merged. ## Why `billing_control_enabled` is still 0% in prod. Design reviewed the built banners (Slack rollout thread) and asked for these changes before it ramps. The amber/grey split was confirmed as is. ## Changes - **What**: - **Out of credits**: shorter copy ("Add more credits or wait until credits refill on {date}"). Members get "Ask your workspace owner…" instead of "admins". An owner who can't buy credits gets no banner; that only happens once the plan has ended, and the upcoming Plan ended banner covers it. - **Plan ending**: the button is now "Resume plan", and the body says "…keep your team's shared credits" with no mention of seats. Members now see the banner too, reading "You can run workflows until then." with no action. - **Scheduled plan change**: owner-only, as in the reference. It gains Dismiss, which lasts the session (shared state, like the out-of-credits dismissal). The title ends with a period, per the reference. - **Enterprise plan ending**: owners get **Contact sales**, which opens `ENTERPRISE_URL`. Members now see the banner too, reading "You can run workflows until then." - **Payment failed, members**: members now get the paused member banner ("Ask your workspace owner to restore the workspace's subscription.", grey icon, no actions), since their runs are blocked too. Requested by design after Comfy-Org#19677. - **Dates**: full month and year everywhere ("October 1, 2026"). The out-of-credits refill date and the scheduled change date used short forms. - Storybook: drops `OutOfCreditsSelfServe` and adds `EndingMember` and `EndingEnterpriseMember`. ## Review Focus - Role changes live in `deriveBillingBanner`. Ending (team and Enterprise) no longer requires `canManage`, and plan change now requires it. The view picks owner or member copy. - Not done, on purpose: - The reference's plan change body ("We'll automatically charge $X to your card on file") needs the upcoming charge amount. The client has only the target plan slug, and deriving a price from the catalog would miss proration and tax. That needs the backend to return the amount on the scheduled change, so the current body stays. - **Stay on {plan}** waits on BE-10873. - `UnifiedPricingTable.test.ts > prompts free-tier users to subscribe` fails locally on clean `main` too ("INTERNAL ASSERTION FAILED: Expected a class definition"), so it's unrelated to this PR. - No E2E added. These are banner copy and role rules driven by billing states Playwright can't put a real workspace into. `deriveBillingBanner.test.ts` and `BillingStatusBanner.test.ts` cover each case. ## Plan position | # | Step | Status | |---|------|--------| | 1 | Ramp `v1_payment_recovery` to 100% | done | | 2 | Split Members credit limits off `billing_control_enabled` (Comfy-Org#19641) | merged | | 3 | Payment failed reads as paused (Comfy-Org#19677) | merged | | **4** | **Banner copy/roles per design review (this PR)** | **this PR** | | 5 | New "Plan ended" banner + Members footer | next | | 6 | Ramp `billing_control_enabled`, then remove both gates | after 4-5 | ```mermaid flowchart LR B[2 split flags Comfy-Org#19641] --> D[4 design review - this PR]:::me C[3 payment_failed copy Comfy-Org#19677] --> D D --> E[5 Plan ended banner] E --> F[6 ramp + remove gates] classDef me fill:#3b5bdb,color:#fff ``` ## Screenshots **AS IS** See table below (left column). **TO BE** Captured from Storybook (`Platform/Workspace/BillingStatusBanner`) with demo billing data. | State | AS IS | TO BE | |---|---|---| | Out of credits (owner) | <img width="480" alt="asis-out-of-credits-owner" src="https://github.com/user-attachments/assets/4fbdd77c-57c4-4e3f-944d-a9aa2fccc82d" /> | <img width="480" alt="tobe-out-of-credits-owner" src="https://github.com/user-attachments/assets/eb4397b6-fd6e-4802-b1e8-06f1f1ca04b9" /> | | Out of credits (member) | <img width="480" alt="asis-out-of-credits-member" src="https://github.com/user-attachments/assets/46fea3ac-5527-4fd9-9062-e28dbfe57f0e" /> | <img width="480" alt="tobe-out-of-credits-member" src="https://github.com/user-attachments/assets/24e86885-cd41-49a4-af55-ea56ed6c6023" /> | | Out of credits (self-serve) | <img width="480" alt="asis-out-of-credits-self-serve" src="https://github.com/user-attachments/assets/275fd8db-dec1-4830-867d-848ad8013a28" /> | Variant removed (no banner) | | Plan ending (owner) | <img width="480" alt="asis-ending-owner" src="https://github.com/user-attachments/assets/b0ad8743-d7b4-4cd1-b0a1-80cb278396de" /> | <img width="480" alt="tobe-ending-owner" src="https://github.com/user-attachments/assets/84ecbf66-2cf2-46f1-9283-20704351dc3e" /> | | Plan ending (member) | No banner (members were not shown one; no story in base) | <img width="480" alt="tobe-ending-member" src="https://github.com/user-attachments/assets/be0d6730-5ca8-4ac7-9383-2dca653553af" /> | | Scheduled plan change (owner) | <img width="480" alt="asis-plan-change-owner" src="https://github.com/user-attachments/assets/035f0192-d0e9-44ad-8f61-c850d656ca03" /> | <img width="480" alt="tobe-plan-change-owner" src="https://github.com/user-attachments/assets/a2a208db-4e98-457a-9d79-90363cb84b64" /> | | Enterprise ending (owner) | <img width="480" alt="asis-ending-enterprise-owner" src="https://github.com/user-attachments/assets/ac90ddaf-c473-402f-ad4b-c26d595ecda7" /> | <img width="480" alt="tobe-ending-enterprise-owner" src="https://github.com/user-attachments/assets/0a665c5d-c514-4ca5-983e-0c7e64d26e57" /> | | Enterprise ending (member) | No banner (members were not shown one; no story in base) | <img width="480" alt="tobe-ending-enterprise-member" src="https://github.com/user-attachments/assets/01eae6fe-d2b1-413e-ae8c-691c9db7b1a2" /> | - Fixes FE-3138
…y-Org#19682) ## Summary Add a **Plan ended** state to the workspace billing banner. It shows on every workspace tab, for team and Enterprise plans, to owners and members, and it ships without the billing control flag. The Members footer now explains why invites are closed, and it can't be dismissed. The Members-only ended banner (Comfy-Org#19455) stays for now and is retired in a follow-up once this is live, per the FE-3136 rollout. Stacked on Comfy-Org#19680. Review only the top commit until it merges. ## Why When a plan ends today, only the Members page says so (Comfy-Org#19455), and only to owners. Every other tab looks normal, so members hit a locked run button with no explanation. Design review asked for one ended banner in the shared banner slot, with a route back from any tab. ## Changes - **What**: - `usePlanEnded` holds the existing plan-ended rules, moved out of `useMembersPanel` unchanged (`subscription_status` `ended`, or cancelled with access closed, on a team or sales-managed tier). The banner and the Members page now read the same rules. - `deriveBillingBanner` gains `planEnded`. It ranks paused > paymentFailed > **planEnded** > outOfCredits > ending > planChange, and is not gated on `billing_control_enabled`. - Banner copy and actions per the reference, all with the grey icon and Dismiss (lasts the session): | Plan | Owner | Member | |---|---|---| | Team | "Your team plan ended on {date}" + Resubscribe (opens the pricing table) | "Ask your workspace owner to resubscribe." | | Enterprise | "Your Enterprise plan ended on {date}" + Contact sales (`ENTERPRISE_URL`) | "Ask your workspace owner to contact sales." | | Unrecognized sales-managed tier | Plan-neutral copy ("Your plan ended…", "start a new plan"), same sales route | "Ask your workspace owner to contact sales." | - Members page: - The ended variants of `MemberUpsellBanner` stay until this is live; a follow-up retires them. - The footer reads "Your plan has ended, so you can't add new members." with Resubscribe or Contact sales for managers. - The ended footer replaces the "N of M total members" line, since `max_seats` collapses to 1 once the plan ends. ## Review Focus - The Members tab shows both ended banners until the follow-up lands. That's intentional (FE-3136 rollout): if this reaches a release branch later than Comfy-Org#19455, the Members page still explains the ended state. - Answers the DES-1223 open question: the ended rules live in a shared helper (`usePlanEnded`) that the banner and the footer both consume. If the backend later returns an explicit denial reason (FE-2030 direction), only `usePlanEnded` changes. - Ended plans have a real tier on the subscription (team plans carry e.g. `PRO`). A missing tier still fails closed to the sales route, matching the Members-page behaviour this replaces. - `UnifiedPricingTable.test.ts > prompts free-tier users to subscribe` also fails on clean `main` locally, so it's unrelated to this PR. - No E2E added. The ended state needs a real workspace whose plan has ended. `deriveBillingBanner.test.ts`, `BillingStatusBanner.test.ts` and `MembersPanelContent.test.ts` cover priority, flag independence, roles, actions and dismissal. ## Plan position | # | Step | Status | |---|------|--------| | 1 | Ramp `v1_payment_recovery` to 100% | done | | 2 | Split Members credit limits off `billing_control_enabled` (Comfy-Org#19641) | merged | | 3 | Payment failed reads as paused (Comfy-Org#19677) | merged | | 4 | Banner copy/roles per design review (Comfy-Org#19680) | in review | | **5** | **Plan ended banner + Members footer (this PR)** | **this PR** | | 6 | Ramp `billing_control_enabled`, then remove both gates | after 3-5 | ```mermaid flowchart LR C[3 payment_failed copy Comfy-Org#19677] --> D[4 design review Comfy-Org#19680] D --> E[5 Plan ended - this PR]:::me E --> F[6 ramp + remove gates] classDef me fill:#3b5bdb,color:#fff ``` ## Screenshots Storybook captures with demo billing data (`DISTRIBUTION=cloud`). | State | AS IS | TO BE | |---|---|---| | Team plan ended, owner | No workspace billing banner for an ended plan; only the Members page banner below | <img width="480" alt="plan-ended-owner" src="https://github.com/user-attachments/assets/b94187be-15d5-4e49-bc04-f26357c67a72" /> | | Team plan ended, member | No workspace billing banner for an ended plan; only the Members page banner below | <img width="480" alt="plan-ended-member" src="https://github.com/user-attachments/assets/0cfc7d59-652d-4b72-9585-e266c333fabe" /> | | Enterprise plan ended, owner | No workspace billing banner for an ended plan; only the Members page banner below | <img width="480" alt="plan-ended-enterprise-owner" src="https://github.com/user-attachments/assets/f1da50cf-38f3-4f78-bbc0-93ca52320156" /> | | Enterprise plan ended, member | No workspace billing banner for an ended plan; only the Members page banner below | <img width="480" alt="plan-ended-enterprise-member" src="https://github.com/user-attachments/assets/829ca4db-a06e-40f2-87f9-a59f89c19955" /> | | Members page, team plan ended | <img width="480" alt="members-reactivate" src="https://github.com/user-attachments/assets/36445f76-579b-40f6-b16e-ddf2a9bb75ac" /> | Banner unchanged (retired in a follow-up); new footer reads "Your plan has ended, so you can't add new members." + Resubscribe (covered by `MembersPanelContent.test.ts`, no story) | | Members page, Enterprise plan ended | <img width="480" alt="members-contact-sales" src="https://github.com/user-attachments/assets/e527735d-d961-4b8b-aa2c-b9ca7e934cb9" /> | Banner unchanged (retired in a follow-up); new footer with Contact sales (covered by `MembersPanelContent.test.ts`, no story) | - Fixes FE-3136
…opy for payment_failed renewals (#19677) (#19746) Manual backport of #19677 to `core/1.55`. Companion to #19748 (`cloud/1.55`). Cherry-picked from upstream merge commit `13a9333e5426d6e2e2f5f61d3da72a8184176a75` (squashed onto main as `aed795880dc552b53d8fd55bd7c1adc099d07c1c`). ## Why For a `payment_failed` renewal the run button is already locked, but the settings banner said "Update payment to avoid a pause" - copy describing a warning stage that does not exist, because the backend never sets `paused` on renewal failure (BE-6970). `payment_failed` now reads as paused, and the member paused banner gets the informational grey icon. ## Target refresh The carrier was 2 commits behind `core/1.55` and the target-aware guard refused on target-tip staleness alone. The target branch was merged in - no rebase, no force-push, no conflicts. - previous head `6fc92b38b2c726d8df6ea807673d39d0bfe938f3` - merged-in `core/1.55` tip `cc2945c0325048da3fa43d9d6b11959dc6205539` - reviewed head `b5f4303dd827196e45bd18bc17cab5c652733028` `git diff --stat origin/core/1.55 b5f4303` is unchanged from the pre-merge delta (3 files, +7/-24), so the target merge contributed no payload. That delta is byte-identical to the upstream source commit `aed795880d` on main and to the already-merged `cloud/1.55` twin `26c10985c6`. ## Validation at the reviewed head - `vitest run BillingStatusBanner.test.ts` - 20/20 passing. It asserts rendered DOM via `screen.getByRole('status')`, so it pins the user-visible copy rather than an internal call. - `vue-tsc --noEmit` - exit 0. - No black-box coverage exists for these banner states on any branch; upstream added none, noting Playwright cannot drive a real workspace into these billing states. Nothing was skipped or weakened. - All hosted checks terminal at the reviewed head: 90 pass, 15 skipped, 0 failures. No `Vercel - billing-web-test` status is present on this carrier, so the `core/1.54`/`cloud/1.54` waiver was neither relied on nor extended to the 1.55 line. Original PR: #19677 / Original commit: `13a9333e5426d6e2e2f5f61d3da72a8184176a75` Justification: Standing Agent release-backport grant for the 1.54 and 1.55 trains (program/active-authority.md, effective 2026-09-27 for 1.55). Independent exact-head audit found the backport byte-identical to the upstream source and to the already- merged cloud/1.55 twin; all hosted checks are terminal green at b5f4303 with zero failures; the target-aware guard reports MERGE READY with no unresolved threads and no reviewer objections. Reviewed by COMMENT rather than approval because the merging identity is the PR author and the grant forbids manufacturing an approval record. REVIEW_REQUIRED alone is not an added approval requirement under this grant.
…oss a rewire (#18074) (#19750) *PR Created by the Glary-Bot Agent* --- Manual backport of #18074 to `cloud/1.54`, from the v1.56.2 backport-status report. Companion to #19749 (`core/1.54`). Cherry-picked from upstream merge commit `9ee67cb17b`. Requested in [#frontend-releases](https://comfy-organization.slack.com/archives/C09K9TPU2G7/p1790847308032919) as a cherry-pick "carrier" backport, one per target branch. #18074 is the only PR the report flags for `cloud/1.54` that is actually backportable, so this carrier carries one commit — see "Why this carrier holds one commit" below. ## Why Rewiring the interior link behind one promoted subgraph widget (e.g. dragging a new node onto an already-promoted widget's socket) could drop or visually duplicate the host node's *other* promoted widgets, and make the rewired widget itself disappear. `SubgraphInputNode`'s `'input-disconnected'` handler demoted the widget **synchronously** while deferring the matching `widgetValueStore` cleanup to a `queueMicrotask`. For one tick `hostNode.widgets.length` and the store's tracked id count disagreed — and the Vue widget grid reads its render *order* from the store and its liveness *filter* from `hostNode.widgets`, i.e. from both sides of that disagreement. The fix defers the demotion itself by a microtask with a per-input cancellation token, which `'input-connected'` clears on a same-tick reconnect, so a rewire never drops the widget at all. - Fixes #14495 ## Conflict resolution **The fix itself (`SubgraphNode.ts`, `interfaces.ts`) cherry-picked clean.** `SubgraphNode.ts` differs slightly between `core/1.54` and `cloud/1.54`, but the fix applied cleanly to both and the resulting hunks are identical. Only two test files conflicted — the same two as on #19749, and those two files are **byte-identical between `core/1.54` and `cloud/1.54` at their merge base** (verified by blob hash), so this is the same resolution, reusing the exact same resolved blobs: - **`useErrorClearingHooks.test.ts`** — the conflict hunk also carried an unrelated test, "retires an absorbed promoted media error when its host is deleted", which `main` gained from a different, unbackported PR. Dropped that test and applied only this PR's change to the test that does exist here: make "keeps promoted missing media until the last fanout consumer is deleted" `async` and `await` the now-deferred demotion. - **`SubgraphWidgetPromotion.test.ts`** — import-only conflict. Accepted the three new imports (`WidgetValue`, `createPromotedMultilineWidget`, `useDomWidgetStore`) required by the new PM-1328 describe block, after verifying all three modules and symbols exist on this branch. The new block also uses `LegacyWidget`, which `main` imports from the litegraph barrel in a *neighbouring non-conflicting* import hunk — so this branch's version won and left it out, failing with `ReferenceError: LegacyWidget is not defined` until it was added to the barrel import. `LegacyWidget` already exists and is exported from the barrel here, so this is an import fix, not new code. No backport-only compatibility shim was needed, and no public API shape or callback signature changed. The deliberate timing change this PR documents — a genuine disconnect becomes observable on `hostNode.widgets` one microtask later — is carried as-is rather than shimmed: the surrounding machinery (`SubgraphInputNode.ts`, `SubgraphInputEventMap.ts`) is byte-identical between this branch and `main`, so a literal cherry-pick cannot recreate the original bug for an old-contract consumer, and deviating would leave this branch running demotion logic `main`'s CI has never exercised. Changed-file set is **exactly** the same 7 files as upstream `9ee67cb17b` — no unrelated drift smuggled in. ## Validation - `pnpm test:unit` on the suites upstream used to validate the fix — **527/527 passing across 24 files** (`src/lib/litegraph/src/subgraph/`, `useErrorClearingHooks.test.ts`, `promotionUtils.test.ts`, `multilineTextarea.promoted.test.ts`, `widgetValueStore.test.ts`, `domWidgetStore.test.ts`). This includes the PR's own regression case, "keeps every promoted widget present while rewiring the interior link behind one of them", which asserts `hostNode.widgets.length` stays at 4 throughout a rewire — i.e. the exact mechanism, proven fixed on this branch. - `pnpm typecheck` — exit 0 - `pnpm exec eslint` on changed files — **0 errors**, 6 warnings, all pre-existing `import-x/no-restricted-paths` on `src/lib/` (upstream carries the same; `pnpm lint` sets no `--max-warnings`) - `pnpm exec oxfmt --check` on changed files — clean ###⚠️ Please let CI run the E2E before merging This PR lands `subgraphPromotedWidgetRewireDuplication.spec.ts` and flips `test.fail()` → `test()` in `subgraphPromotion.spec.ts`. Upstream justified those flips with CI evidence gathered on `main` ([run 35419314544](https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/35419314544)); **there is no equivalent evidence for `cloud/1.54` yet**, and the Playwright suite needs a live ComfyUI backend plus a built frontend, which I could not stand up in the sandbox. The unit-level regression above proves the mechanism on this branch, but per `SKILL.md` ("NEVER merge a backport PR without all CI checks passing") the flipped e2e should be confirmed green here before merge. Kept as a draft for that reason. ## Why this carrier holds one commit The report flagged four PRs as "❗ Need backport". Two cannot be carried: - **#19053** ("restore live turn after panel remount", PM-1776) — **not merged.** Only `refs/pull/19053/head` exists; it is 69 commits ahead of `main` with no squash commit, which is why the report listed it without a `(#NNNNN)` suffix. There is nothing to cherry-pick. - **#19240** ("say when the open workflow is deleted") — flagged for `cloud/1.54`, but its **prerequisite is missing.** Its mechanism marks the target unavailable so the in-chat notice from #18866 renders. This branch has the `TargetTracking` model but **no** `markWorkflowTargetUnavailable`/`targetUnavailable` and no `targetWorkflowUnavailable` string — the only "unavailable" path here is an unrelated *toast* fired on navigation failure (`agent.targetNavigationUnavailable`), a different mechanism for a different trigger. Carrying #19240 alone would set a state nothing renders — a silent no-op defeating the fix. It needs #18866 backported first. (Same gap on all four target branches.) #19677 is labelled `core/1.55` + `cloud/1.55` only, so it is not in this branch's scope. Original PR: #18074 / Original commit: `9ee67cb17b` --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
Summary
Show the Subscription paused copy for
payment_failedrenewals instead of "update payment to avoid a pause", and give the member Subscription paused banner the informational (grey) icon.Why
v1_payment_recoverywent to 100% in prod today, so this banner is live. For apayment_failedrenewal the run button is already locked (CloudRunButtonWrapperlocks onpayment_failedregardless of the flag), yet the settings banner says "Update payment to avoid a pause", which describes a warning stage that does not exist. Per design review (Alex), until BE-6970 records failed renewals aspaused,payment_failedshould read as paused. About 850 workspaces are inpayment_failedtoday.Root cause
The banner copy for
payment_failedwas written for a dunning model where a failed payment is a warning before a pause. The backend never setpausedon renewal failure (BE-6970), sopayment_failedis the blocked state in practice, and the copy disagrees with the run lock.Changes
paymentFailedViewreusespausedView(title, body, Update payment) and keeps Pay invoice when a hosted https invoice URL exists.billingStatus.warningstrings and the invoice amount formatting (Stripe decimal tables) that only fed that copy.payment_failedis still owner-only.Review Focus
paused,payment_failedstops being the blocked state and this can be revisited.BillingStatusBanner.test.tscovers the payment_failed copy and actions.Plan position
v1_payment_recoveryto 100%billing_control_enabled(#19641)billing_control_enabledbanner copy/roles per design reviewbilling_control_enabled, then remove both gatesScreenshots
AS IS —
payment_failed, owner: "Payment failed … update payment to avoid a pause". Paused member: amber icon.Captured from Storybook (
DISTRIBUTION=cloud): real banner logic, demo billing data.payment_failed, owner (old):Paused, member (old):

TO BE —
payment_failed, owner: "Subscription paused … Update payment to resume". Paused member: grey icon.payment_failed, owner (new):Paused, member (new):
