Repository navigation
FE-3136 feat(billing): plan ended banner on every workspace tab - #19682
Conversation
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2185 passed, 0 failed · 1 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (14 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 6ad3f724882f4a4789e737e40f36337e5e3085b6
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle: 10.1 MB gzipDetailsSummary
Category Glance App Entry Points — 3.89 kBMain entry bundles and manifests
Status: 1 added Graph Workspace — 1.47 MBGraph editor runtime, canvas, workflow orchestration
Status: 3 added Views & Navigation — 135 kBTop-level views, pages, and routed surfaces
Status: 18 added Panels & Settings — 646 kBConfiguration panels, inspectors, and settings screens
Status: 28 added User & Accounts — 53.6 kBAuthentication, profile, and account management bundles
Status: 15 added Editors & Dialogs — 126 kBModals, dialogs, drawers, and in-app editors
Status: 8 added UI Components — 184 kBReusable component library chunks
Status: 18 added Data & Services — 4.12 MBStores, services, APIs, and repositories
Status: 14 added Utilities & Hooks — 586 kBHelpers, composables, and utility bundles
Status: 38 added Vendor & Third-Party — 17.2 MBExternal libraries and shared vendor chunks
Status: 18 added Other — 18.3 MBBundles that do not match a named category
Status: 305 added ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-01T18:24:09.678Z",
"gitSha": "d480c6e566d4d3115d6e327898de674b71414f0a",
"branch": "jaewon/fe-3139-plan-ended-banner",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2013.0550000000085,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.2230000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 401.68000000000006,
"heapDeltaBytes": 22319216,
"heapUsedBytes": 75956292,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.331999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2014.8080000000164,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.1899999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.94399999999996,
"heapDeltaBytes": 370752,
"heapUsedBytes": 66825776,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 10.275999999999993,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1812.1399999999994,
"styleRecalcs": 76,
"styleRecalcDurationMs": 18.372,
"layouts": 12,
"layoutDurationMs": 4.627,
"taskDurationMs": 813.656,
"heapDeltaBytes": -2525980,
"heapUsedBytes": 64473524,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 170.54399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666055045871563,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1788.1280000000288,
"styleRecalcs": 75,
"styleRecalcDurationMs": 16.925999999999995,
"layouts": 12,
"layoutDurationMs": 3.9109999999999996,
"taskDurationMs": 812.7400000000001,
"heapDeltaBytes": -29384208,
"heapUsedBytes": 73078424,
"domNodes": -251,
"jsHeapTotalBytes": -2883584,
"scriptDurationMs": 159.575,
"eventListeners": -160,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.822429906542055,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1709.6439999999689,
"styleRecalcs": 31,
"styleRecalcDurationMs": 9.46,
"layouts": 6,
"layoutDurationMs": 1.165,
"taskDurationMs": 333.54200000000003,
"heapDeltaBytes": 3428828,
"heapUsedBytes": 70184064,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.997000000000007,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1726.458999999977,
"styleRecalcs": 32,
"styleRecalcDurationMs": 9.982000000000001,
"layouts": 6,
"layoutDurationMs": 1.1300000000000003,
"taskDurationMs": 334.04100000000005,
"heapDeltaBytes": 3391024,
"heapUsedBytes": 70186224,
"domNodes": 53,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 12.251999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 691.2820000000011,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.052000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 449.94599999999997,
"heapDeltaBytes": 15263008,
"heapUsedBytes": 69306616,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 167.498,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 691.1400000000185,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.790999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 437.45799999999997,
"heapDeltaBytes": 15393844,
"heapUsedBytes": 76298216,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 164.81199999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66341463414634,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1150.8719999999926,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 822.312,
"heapDeltaBytes": 15508908,
"heapUsedBytes": 83354776,
"domNodes": 0,
"jsHeapTotalBytes": 7241728,
"scriptDurationMs": 71.26299999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 513,
"frameDurationMs": 33.8235294117647,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1158.4389999999303,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 806.3189999999998,
"heapDeltaBytes": 14881176,
"heapUsedBytes": 83409808,
"domNodes": 0,
"jsHeapTotalBytes": 4358144,
"scriptDurationMs": 68.51499999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 526,
"frameDurationMs": 33.82058823529411,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.8190000000154,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.49700000000007,
"heapDeltaBytes": 17783900,
"heapUsedBytes": 118515120,
"domNodes": 0,
"jsHeapTotalBytes": 3149824,
"scriptDurationMs": 170.56,
"eventListeners": 0,
"totalBlockingTimeMs": 222,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.0829999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.35599999999977,
"heapDeltaBytes": 18074688,
"heapUsedBytes": 120212356,
"domNodes": 0,
"jsHeapTotalBytes": 2363392,
"scriptDurationMs": 169.692,
"eventListeners": 0,
"totalBlockingTimeMs": 223,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10810.33100000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9793.660000000002,
"heapDeltaBytes": 7678844,
"heapUsedBytes": 83320544,
"domNodes": -142,
"jsHeapTotalBytes": -8261632,
"scriptDurationMs": 8070.71,
"eventListeners": -74,
"totalBlockingTimeMs": 1120,
"frameDurationMs": 32.82522796352583,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10136.794000000009,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9195.271999999999,
"heapDeltaBytes": 5500832,
"heapUsedBytes": 81754152,
"domNodes": -142,
"jsHeapTotalBytes": -7213056,
"scriptDurationMs": 7452.638999999999,
"eventListeners": -78,
"totalBlockingTimeMs": 780,
"frameDurationMs": 31.764576802507843,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10805.902000000004,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.052999999999997494,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9883.704000000002,
"heapDeltaBytes": 17974212,
"heapUsedBytes": 86767544,
"domNodes": -142,
"jsHeapTotalBytes": -1970176,
"scriptDurationMs": 8154.789000000001,
"eventListeners": -74,
"totalBlockingTimeMs": 1299,
"frameDurationMs": 32.72575757575758,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10887.26500000007,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9923.1,
"heapDeltaBytes": 7091004,
"heapUsedBytes": 83963652,
"domNodes": -142,
"jsHeapTotalBytes": -1970176,
"scriptDurationMs": 8194.712000000001,
"eventListeners": -78,
"totalBlockingTimeMs": 1392,
"frameDurationMs": 32.978484848484854,
"p95FrameDurationMs": 66.69999999999982
},
{
"name": "large-graph-idle",
"durationMs": 2036.0569999999711,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.4659999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 568.7860000000002,
"heapDeltaBytes": -40444808,
"heapUsedBytes": 82322776,
"domNodes": -328,
"jsHeapTotalBytes": -3506176,
"scriptDurationMs": 34.90099999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.80327868852459,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2008.2329999999047,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.8060000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 560.178,
"heapDeltaBytes": -758136,
"heapUsedBytes": 84826448,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 38.28799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2489.986999999985,
"styleRecalcs": 70,
"styleRecalcDurationMs": 11.030999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1652.511,
"heapDeltaBytes": -4222984,
"heapUsedBytes": 82515520,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 847.681,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666891891891897,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2576.2000000000853,
"styleRecalcs": 69,
"styleRecalcDurationMs": 11.172999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1657.5479999999998,
"heapDeltaBytes": -185384,
"heapUsedBytes": 86939744,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 850.082,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666233766233763,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3702.99,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.054,
"layouts": 60,
"layoutDurationMs": 14.741999999999999,
"taskDurationMs": 1753.183,
"heapDeltaBytes": -11824332,
"heapUsedBytes": 76670700,
"domNodes": 0,
"jsHeapTotalBytes": 823296,
"scriptDurationMs": 797.941,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666216216216213,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3570.0259999999844,
"styleRecalcs": 63,
"styleRecalcDurationMs": 10.832999999999998,
"layouts": 60,
"layoutDurationMs": 13.831999999999999,
"taskDurationMs": 1663.8669999999997,
"heapDeltaBytes": 7745312,
"heapUsedBytes": 72442600,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 767.066,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665887850467293,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3108.0279999999902,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.469000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1933.275,
"heapDeltaBytes": 25535564,
"heapUsedBytes": 90441636,
"domNodes": 0,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 976.7800000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.756216216216213,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3153.3170000000155,
"styleRecalcs": 47,
"styleRecalcDurationMs": 7.762999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 2019.594,
"heapDeltaBytes": 25762200,
"heapUsedBytes": 93144140,
"domNodes": 0,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 1024.925,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755080213903742,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2029.9890000000005,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.6669999999999983,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 536.2979999999999,
"heapDeltaBytes": 20978104,
"heapUsedBytes": 83702696,
"domNodes": -328,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 32.50800000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2021.5460000000576,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.9509999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 541.3839999999999,
"heapDeltaBytes": -673448,
"heapUsedBytes": 87072868,
"domNodes": 0,
"jsHeapTotalBytes": -225280,
"scriptDurationMs": 33.11500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 624.7960000000035,
"styleRecalcs": 46,
"styleRecalcDurationMs": 6.653,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 422.877,
"heapDeltaBytes": -39921448,
"heapUsedBytes": 63493184,
"domNodes": -250,
"jsHeapTotalBytes": -1310720,
"scriptDurationMs": 142.482,
"eventListeners": -204,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 662.4299999999721,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.998999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 451.244,
"heapDeltaBytes": -41644992,
"heapUsedBytes": 62844392,
"domNodes": -250,
"jsHeapTotalBytes": -2621440,
"scriptDurationMs": 147.97199999999998,
"eventListeners": -204,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2023.9409999999793,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.172000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.012,
"heapDeltaBytes": -3490256,
"heapUsedBytes": 59845008,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 9.018999999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2022.7119999999559,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.6279999999999992,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 402.648,
"heapDeltaBytes": 552988,
"heapUsedBytes": 69904652,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.807000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1695.017000000007,
"styleRecalcs": 61,
"styleRecalcDurationMs": 19.164,
"layouts": 16,
"layoutDurationMs": 5.6499999999999995,
"taskDurationMs": 743.9989999999999,
"heapDeltaBytes": -6396972,
"heapUsedBytes": 62560600,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 114.446,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66568627450981,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1720.5590000000939,
"styleRecalcs": 77,
"styleRecalcDurationMs": 18.339000000000002,
"layouts": 16,
"layoutDurationMs": 5.889,
"taskDurationMs": 750.316,
"heapDeltaBytes": -6467180,
"heapUsedBytes": 62857660,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 116.69800000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66504854368932,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1402.6440000000093,
"styleRecalcs": 17,
"styleRecalcDurationMs": 29.67899999999999,
"layouts": 5,
"layoutDurationMs": 12.740000000000002,
"taskDurationMs": 909.6390000000001,
"heapDeltaBytes": 23888528,
"heapUsedBytes": 109941996,
"domNodes": 13747,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 30.761999999999997,
"eventListeners": 2383,
"totalBlockingTimeMs": 135,
"frameDurationMs": 19.4054794520548,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "viewport-pan-sweep",
"durationMs": 8726.032000000032,
"styleRecalcs": 251,
"styleRecalcDurationMs": 35.462999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6009.8060000000005,
"heapDeltaBytes": -21659036,
"heapUsedBytes": 63721388,
"domNodes": -142,
"jsHeapTotalBytes": -9273344,
"scriptDurationMs": 2871.283,
"eventListeners": -74,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.730134357005756,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 9531.840999999986,
"styleRecalcs": 249,
"styleRecalcDurationMs": 35.152,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6176.63,
"heapDeltaBytes": -33513696,
"heapUsedBytes": 89318892,
"domNodes": -328,
"jsHeapTotalBytes": -3837952,
"scriptDurationMs": 2938.616,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6661996497373,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17270.487,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16616.896,
"heapDeltaBytes": -20581532,
"heapUsedBytes": 187660340,
"domNodes": -3045,
"jsHeapTotalBytes": 5525504,
"scriptDurationMs": 310.942,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.21489001692048,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-idle",
"durationMs": 17202.52400000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16589.300000000003,
"heapDeltaBytes": -20251920,
"heapUsedBytes": 185905872,
"domNodes": -3045,
"jsHeapTotalBytes": 14495744,
"scriptDurationMs": 263.984,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.151355932203394,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-large-graph-pan",
"durationMs": 21568.290000000048,
"styleRecalcs": 176,
"styleRecalcDurationMs": 20.33500000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21056.874,
"heapDeltaBytes": -32291036,
"heapUsedBytes": 169208260,
"domNodes": -3045,
"jsHeapTotalBytes": 6311936,
"scriptDurationMs": 897.4190000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 15,
"frameDurationMs": 38.74775583482944,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-large-graph-pan",
"durationMs": 21427.584000000024,
"styleRecalcs": 175,
"styleRecalcDurationMs": 20.214000000000038,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21048.445,
"heapDeltaBytes": -30777316,
"heapUsedBytes": 168768752,
"domNodes": -3045,
"jsHeapTotalBytes": 8122368,
"scriptDurationMs": 913.6670000000001,
"eventListeners": -14915,
"totalBlockingTimeMs": 10,
"frameDurationMs": 39.50128913443831,
"p95FrameDurationMs": 83.39999999999782
},
{
"name": "vue-node-resize-workload",
"durationMs": 6343.399999999974,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.97799999999997,
"layouts": 20,
"layoutDurationMs": 25.351,
"taskDurationMs": 6235.724999999999,
"heapDeltaBytes": 7228572,
"heapUsedBytes": 199217068,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 110.39999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 37.133333333333326,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6253.6139999999705,
"styleRecalcs": 20,
"styleRecalcDurationMs": 83.22299999999998,
"layouts": 20,
"layoutDurationMs": 24.83400000000001,
"taskDurationMs": 6112.142,
"heapDeltaBytes": -19223132,
"heapUsedBytes": 205773408,
"domNodes": 0,
"jsHeapTotalBytes": 1310720,
"scriptDurationMs": 109.002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 35.309604519774005,
"p95FrameDurationMs": 66.79999999999927
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8969.475999999986,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8601.251999999999,
"heapDeltaBytes": -70650904,
"heapUsedBytes": 161362996,
"domNodes": -3045,
"jsHeapTotalBytes": 2760704,
"scriptDurationMs": 137.65500000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.592079207920786,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6543.966000000069,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6188.143999999999,
"heapDeltaBytes": -10167016,
"heapUsedBytes": 192537000,
"domNodes": -3045,
"jsHeapTotalBytes": 11030528,
"scriptDurationMs": 110.14299999999993,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.923154362416103,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "workflow-execution",
"durationMs": 490.893999999912,
"styleRecalcs": 22,
"styleRecalcDurationMs": 19.239,
"layouts": 5,
"layoutDurationMs": 2.527,
"taskDurationMs": 150.319,
"heapDeltaBytes": 6115816,
"heapUsedBytes": 59608800,
"domNodes": 131,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 17.027,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 465.4960000000301,
"styleRecalcs": 14,
"styleRecalcDurationMs": 13.661,
"layouts": 3,
"layoutDurationMs": 0.9399999999999998,
"taskDurationMs": 105.054,
"heapDeltaBytes": 5501188,
"heapUsedBytes": 63376216,
"domNodes": 99,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.4,
"eventListeners": 65,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667857142857137,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 922.6320000000214,
"styleRecalcs": 78,
"styleRecalcDurationMs": 107.387,
"layouts": 76,
"layoutDurationMs": 26.451999999999998,
"taskDurationMs": 894.1739999999999,
"heapDeltaBytes": 17964740,
"heapUsedBytes": 88338568,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 372.303,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66607142857143,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 921.3019999999688,
"styleRecalcs": 78,
"styleRecalcDurationMs": 106.923,
"layouts": 76,
"layoutDurationMs": 27.23,
"taskDurationMs": 894.7700000000001,
"heapDeltaBytes": 17892836,
"heapUsedBytes": 88393676,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 363.15799999999996,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666071428571417,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1373.6300000000483,
"styleRecalcs": 78,
"styleRecalcDurationMs": 252,
"layouts": 76,
"layoutDurationMs": 28.092,
"taskDurationMs": 1350.8629999999998,
"heapDeltaBytes": 8187580,
"heapUsedBytes": 113804772,
"domNodes": 76,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 448.228,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.510126582278495,
"p95FrameDurationMs": 33.20000000000073
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1417.4540000000206,
"styleRecalcs": 78,
"styleRecalcDurationMs": 258.629,
"layouts": 76,
"layoutDurationMs": 28.944000000000003,
"taskDurationMs": 1392.811,
"heapDeltaBytes": -19073592,
"heapUsedBytes": 109145568,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 462.382,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.488888888888894,
"p95FrameDurationMs": 16.80000000000109
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (10)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughThe workspace billing flow now identifies ended plans, displays role- and plan-specific billing notices, and provides resubscription or sales-contact actions. The members panel also displays ended-plan guidance and an action for users who can manage subscriptions. ChangesWorkspace billing status
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant User
participant usePlanEnded
participant deriveBillingBanner
participant BillingStatusBanner
participant useSubscriptionDialog
User->>usePlanEnded: Provide workspace plan state
usePlanEnded->>deriveBillingBanner: Supply ended-plan flags
deriveBillingBanner->>BillingStatusBanner: Select planEnded banner
BillingStatusBanner->>User: Show ended-plan copy and available action
User->>BillingStatusBanner: Select resubscribe
BillingStatusBanner->>useSubscriptionDialog: Open team pricing dialog
Possibly related PRs
Suggested reviewers: Merge Risk: ⚪ Minimal · up to No concrete merge-blocking issue is established for the ended-plan notices or members guidance. The change is mergeable subject to normal checks. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The change broadens billing guidance rather than billing permissions. Recovery actions remain limited to subscription managers, and no introduced security weakness was identified. Dismissal behavior across workspace changes and dialog closure remains incompletely established. Retained concerns Security review detailsSecurity Blast Radius
Security Findings and Attack Paths
Trust Boundaries and Controls
Resilience and Maintainability Implications
🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #19682 +/- ##
==========================================
+ Coverage 84.72% 85.48% +0.75%
==========================================
Files 3402 2390 -1012
Lines 163352 136837 -26515
Branches 42609 36943 -5666
==========================================
- Hits 138407 116975 -21432
+ Misses 23004 19494 -3510
+ Partials 1941 368 -1573
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1021 files with indirect coverage changes 🚀 New features to boost your workflow:
|
a76b3b7 to
8e084aa
Compare
48eee93 to
ce81304
Compare
b446523 to
f053630
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
- Ended-plan detection remains distinct from scheduled cancellation and payment recovery.
- Banner and member-panel actions respect owner, member, Team, and sales-managed roles.
- The stack is exactly based on its current parent and preserves workspace-scoped behavior.
Full context for agent readers
Reviewed the complete child diff at frontend PR 19682. It is exactly based on the current head of frontend PR 19680; all checks are settled green and no unresolved review thread remains.
The base branch was changed.
The workspace billing banner gains a Plan ended state for team and Enterprise, owners and members, ranked right after payment recovery and shipped without the billing control flag. Team owners resubscribe through the pricing table, Enterprise owners contact sales, and dismissal lasts the session. On the Members page the ended footer replaces the member count line and offers the same route back; it cannot be dismissed. The Members-only ended banner stays until this is live (FE-3136 rollout). The plan-ended rules move to usePlanEnded so both surfaces agree.
f053630 to
fb343d6
Compare
|
|
@christian-byrne #19680 merged, so this is now rebased onto main and retargeted. The diff is the same single commit you approved, minus #19680's commits. The rebase dismissed your approval, so it needs a re-approve once CI is green. |
christian-byrne
left a comment
There was a problem hiding this comment.
The ended-plan banner is driven by the shared account state and updates every open workspace tab without collapsing their selected workspace scopes.
Replacement CI is settled and all review threads are resolved. Approved.
Full context for agent readers
Reviewed exact head fb343d61a95c1f9e071b4babcf898c7e3ddbad0b. The implementation broadcasts only the plan-ended signal; each tab keeps its own workspace selection and recomputes from its tab-local context, so two tabs may intentionally use different workspaces.
The remaining red entries are superseded-run cancellation debris: their dependencies were cancelled and the aggregate gates exited in 2–13 seconds. The replacement run completed successfully.
|
|
…20254) ## Why Design added a Personal column to the [billing banner reference](https://www.figma.com/design/CkFTD4c20PyRGpNVAJgpfV/Workspaces--BIlling--Team-Plans?node-id=7186-30628) for Standard, Creator and Pro plans, and updated the [Members tab matrix](https://www.figma.com/design/CkFTD4c20PyRGpNVAJgpfV/Workspaces--BIlling--Team-Plans?node-id=7244-30885). Today only Subscription paused reaches personal workspaces. Out of credits, Plan ending and Plan ended are team-only, so a personal plan that runs out, is cancelled or ends shows no banner. The decisions come from the [design thread](https://comfy-organization.slack.com/archives/C0BNGQG2LCW/p1791229801307819). ## How - **Audience.** `deriveBillingBanner` stays the single pure derivation. Next to the kind it now derives an audience, `team | personal | null`. A plan is personal when it is not team, not Enterprise, and on a known personal tier. Enterprise and unrecognized tiers get `null` and still fail closed. `BillingStatusBanner` reads its copy from a small table keyed by that audience, instead of checking the workspace type in each view. - **Paused.** The owner copy is the same for team and personal. The personal-only bodies are deleted. - **Out of credits, Plan ending (personal).** Same gates as team: `billing_control_enabled` and subscription access. The copy is first person and uses the tier name ("Your Pro plan ends on {date}"). - **Plan ending owner bodies (team and personal).** Both now start with "You won't be charged again." This line used to live only on the canceled card. - **Plan ended (personal).** Uses the same terminal test as `usePlanEnded`, in the same priority slot right after Paused, with a session-long dismiss. Resubscribe opens the pricing table on Personal plans. `usePlanEnded().isPlanEnded` itself is unchanged, because the Members panel reads it. - **Members tab, personal workspace.** The banner hides Plan ended, Plan ending and Scheduled change, so `MemberUpsellBanner` ("To add teammates, upgrade your plan") carries that tab. That upsell no longer switches to the team-worded ended or contact-sales variants in a personal workspace. Paused and Out of credits still show. - **Amber "Your subscription has been canceled" card.** Hidden while the Plan ending banner shows. The banner is still behind `billing_control_enabled`, so the card remains wherever the banner is not shown. - **Scheduled plan change.** Stays team-only, since there is no personal design for it. A terminal personal subscription that comes back with no tier, or an unknown tier, gets no Plan ended banner. That follows the existing fail-closed rule for unrecognized tiers. ## AS IS / TO BE Surface: the real cloud app (`DISTRIBUTION=cloud` dev build, Settings dialog, personal workspace) on origin/main (AS IS) and this branch (TO BE), against a local ComfyUI backend. Firebase auth and the personal-workspace billing endpoints (`/api/billing/*`, `/customers/balance`, workspace and members) are stubbed per state with Playwright routes; `billing_control_enabled` and `v1_payment_recovery` are turned on through the dev `ff:` overrides. Pro tier, monthly. The Ended state has no plan catalog in the stub, so the plan card falls back to Free. **Cancelled Pro plan** (`subscription_status: canceled`, `cancel_at` set). The amber canceled card is replaced by the "Your Pro plan ends on ..." banner. | AS IS | TO BE | | --- | --- | | <img src="https://github.com/user-attachments/assets/b0c8d40f-4e23-4ff1-a45c-46cc6c293fb2" width="480"> | <img src="https://github.com/user-attachments/assets/7c87a0a9-bf41-49e9-84c3-f96edfe283dc" width="480"> | **Out of credits** (`has_funds: false`). | AS IS | TO BE | | --- | --- | | <img src="https://github.com/user-attachments/assets/9e2e2594-42d6-4702-a489-5d78fa9bd4c7" width="480"> | <img src="https://github.com/user-attachments/assets/1b79610e-4b5d-4d92-aa13-d826f3dcd1f6" width="480"> | **Ended** (`subscription_status: ended`, `billing_status: inactive`). | AS IS | TO BE | | --- | --- | | <img src="https://github.com/user-attachments/assets/5ea54910-ef5e-40ac-b3dc-7fe619c7ef4c" width="480"> | <img src="https://github.com/user-attachments/assets/ddfda87e-e8a2-4fee-b836-74bc2fc5b149" width="480"> | **Members tab, ended plan.** Both sides show the upgrade-to-Team upsell and no plan-ended banner; the personal workspace keeps the upsell and does not pick up the new banner. | AS IS | TO BE | | --- | --- | | <img src="https://github.com/user-attachments/assets/43e45cbb-4125-486a-a46c-47f2aadd7f34" width="480"> | <img src="https://github.com/user-attachments/assets/d86a5d7e-76c5-4f2f-ac74-2c632866c2d5" width="480"> | **Paused** (`billing_status: paused`). Same copy as team: "This workspace's subscription is paused. Update payment to resume." | AS IS | TO BE | | --- | --- | | <img src="https://github.com/user-attachments/assets/756be259-7bd8-441c-94d8-c1eee5b883ba" width="480"> | <img src="https://github.com/user-attachments/assets/4e83ff50-ac50-463d-9160-70dc7b11ac7f" width="480"> | ## Plan position | Item | Ticket | PR | Status | | --- | --- | --- | --- | | Align billing banners with the design reference | FE-3138 | Comfy-Org#19680 | Merged | | Plan ended banner on every workspace tab | FE-3136 | Comfy-Org#19682 | Merged | | **Personal-plan banners + canceled card handoff** | **FE-3241** | **this PR** | **Open** | | Retire the Members-only ended banner | FE-3159 | | Backlog | ```mermaid graph LR A["FE-3138 PR 19680 banner copy"] --> C["FE-3241 personal banners"] B["FE-3136 PR 19682 plan ended banner"] --> C B --> D["FE-3159 retire Members-only ended banner"] style C fill:#f9d71c,stroke:Comfy-Org#333,stroke-width:2px ``` Fixes FE-3241
Summary
Add a Plan ended state to the workspace billing banner. It shows on every workspace tab, for team and Enterprise plans, to owners and members, and it ships without the billing control flag. The Members footer now explains why invites are closed, and it can't be dismissed. The Members-only ended banner (#19455) stays for now and is retired in a follow-up once this is live, per the FE-3136 rollout.
Stacked on #19680. Review only the top commit until it merges.
Why
When a plan ends today, only the Members page says so (#19455), and only to owners. Every other tab looks normal, so members hit a locked run button with no explanation. Design review asked for one ended banner in the shared banner slot, with a route back from any tab.
Changes
usePlanEndedholds the existing plan-ended rules, moved out ofuseMembersPanelunchanged (subscription_statusended, or cancelled with access closed, on a team or sales-managed tier). The banner and the Members page now read the same rules.deriveBillingBannergainsplanEnded. It ranks paused > paymentFailed > planEnded > outOfCredits > ending > planChange, and is not gated onbilling_control_enabled.Banner copy and actions per the reference, all with the grey icon and Dismiss (lasts the session):
ENTERPRISE_URL)Members page:
MemberUpsellBannerstay until this is live; a follow-up retires them.max_seatscollapses to 1 once the plan ends.Review Focus
usePlanEnded) that the banner and the footer both consume. If the backend later returns an explicit denial reason (FE-2030 direction), onlyusePlanEndedchanges.PRO). A missing tier still fails closed to the sales route, matching the Members-page behaviour this replaces.UnifiedPricingTable.test.ts > prompts free-tier users to subscribealso fails on cleanmainlocally, so it's unrelated to this PR.deriveBillingBanner.test.ts,BillingStatusBanner.test.tsandMembersPanelContent.test.tscover priority, flag independence, roles, actions and dismissal.Plan position
v1_payment_recoveryto 100%billing_control_enabled(#19641)billing_control_enabled, then remove both gatesScreenshots
Storybook captures with demo billing data (
DISTRIBUTION=cloud).MembersPanelContent.test.ts, no story)MembersPanelContent.test.ts, no story)