Repository navigation
[backport core/1.55] FE-3013 feat(pricing): read the plan's raw credit grant from the catalog - #19658
Conversation
🎭 Playwright: ✅ 2142 passed, 0 failed · 2 flaky📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since f871ec91cf8c47edf0ebf7d74fe68e2ac38aa898
Full docs: ADR-DEVEX-LINT-0015 🎨 Storybook: ✅ Built — View Storybook📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-03T02:59:18.564Z",
"gitSha": "1a0939f2dea550e0775f54fbea4839606cf68bb5",
"branch": "backport-18873-to-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 1990.4539999999997,
"styleRecalcs": 12,
"styleRecalcDurationMs": 10.761,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.159,
"heapDeltaBytes": -1638388,
"heapUsedBytes": 66123936,
"domNodes": -258,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.306999999999999,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 1993.2440000000042,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.747,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 345.24000000000007,
"heapDeltaBytes": -7305488,
"heapUsedBytes": 60317676,
"domNodes": -260,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 8.665000000000003,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1750.7689999999911,
"styleRecalcs": 44,
"styleRecalcDurationMs": 13.936,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 812.31,
"heapDeltaBytes": 8944976,
"heapUsedBytes": 76815808,
"domNodes": -262,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 168.686,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1757.1720000000823,
"styleRecalcs": 45,
"styleRecalcDurationMs": 14.815999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 803.698,
"heapDeltaBytes": -4240076,
"heapUsedBytes": 63555884,
"domNodes": -260,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 165.399,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1722.1499999999992,
"styleRecalcs": 32,
"styleRecalcDurationMs": 15.143,
"layouts": 6,
"layoutDurationMs": 1.0279999999999998,
"taskDurationMs": 339.379,
"heapDeltaBytes": 2844124,
"heapUsedBytes": 70562556,
"domNodes": 77,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 11.295,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.2549999999947,
"styleRecalcs": 31,
"styleRecalcDurationMs": 15.622,
"layouts": 6,
"layoutDurationMs": 1.096,
"taskDurationMs": 338.724,
"heapDeltaBytes": 3137156,
"heapUsedBytes": 70772820,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.577999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 690.6479999999533,
"styleRecalcs": 12,
"styleRecalcDurationMs": 9.21,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.91099999999994,
"heapDeltaBytes": 18949520,
"heapUsedBytes": 86687388,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 173.766,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 623.7530000000788,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.672999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 450.34499999999997,
"heapDeltaBytes": 18651560,
"heapUsedBytes": 86293092,
"domNodes": 18,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 166.679,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1179.9899999999752,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 834.4319999999999,
"heapDeltaBytes": 38269580,
"heapUsedBytes": 105197984,
"domNodes": 0,
"jsHeapTotalBytes": 19296256,
"scriptDurationMs": 71.40400000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 561,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1182.1780000000217,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 844.204,
"heapDeltaBytes": 38302280,
"heapUsedBytes": 105242756,
"domNodes": 0,
"jsHeapTotalBytes": 19558400,
"scriptDurationMs": 68.452,
"eventListeners": 0,
"totalBlockingTimeMs": 565,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 873.9160000000084,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 487.8479999999996,
"heapDeltaBytes": 14700312,
"heapUsedBytes": 91097876,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 174.018,
"eventListeners": 0,
"totalBlockingTimeMs": 226,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 841.5169999999534,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.97400000000056,
"heapDeltaBytes": 14592272,
"heapUsedBytes": 91823576,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 166.16299999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 226,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10927.499999999953,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9954.781,
"heapDeltaBytes": -11416988,
"heapUsedBytes": 71120784,
"domNodes": -18,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 8214.701,
"eventListeners": 0,
"totalBlockingTimeMs": 1355,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11133.533000000058,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10270.015,
"heapDeltaBytes": 14125164,
"heapUsedBytes": 95872272,
"domNodes": -12,
"jsHeapTotalBytes": 10485760,
"scriptDurationMs": 8616.049,
"eventListeners": 0,
"totalBlockingTimeMs": 1486,
"frameDurationMs": 18.889999999999965,
"p95FrameDurationMs": 49.89999999999782
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10481.773000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9649.923999999999,
"heapDeltaBytes": -8806964,
"heapUsedBytes": 73661512,
"domNodes": -18,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 8010.894,
"eventListeners": 0,
"totalBlockingTimeMs": 1140,
"frameDurationMs": 20,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10150.457999999959,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9290.649,
"heapDeltaBytes": -446272,
"heapUsedBytes": 81829076,
"domNodes": -14,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 7672.281,
"eventListeners": 0,
"totalBlockingTimeMs": 907,
"frameDurationMs": 18.886666666666677,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2057.422000000031,
"styleRecalcs": 10,
"styleRecalcDurationMs": 11.806999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 616.553,
"heapDeltaBytes": -292748,
"heapUsedBytes": 79693300,
"domNodes": -247,
"jsHeapTotalBytes": -532480,
"scriptDurationMs": 34.49100000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2072.420999999963,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.573999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 597.1209999999999,
"heapDeltaBytes": -6514764,
"heapUsedBytes": 80944484,
"domNodes": -248,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 34.895999999999994,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-pan",
"durationMs": 2412.3030000000085,
"styleRecalcs": 69,
"styleRecalcDurationMs": 13.964,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1785.374,
"heapDeltaBytes": -5792724,
"heapUsedBytes": 82450804,
"domNodes": -220,
"jsHeapTotalBytes": 2613248,
"scriptDurationMs": 925.5090000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2366.895999999997,
"styleRecalcs": 68,
"styleRecalcDurationMs": 12.804999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1707.646,
"heapDeltaBytes": -3004228,
"heapUsedBytes": 84805432,
"domNodes": -246,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 890.516,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3618.9959999999814,
"styleRecalcs": 64,
"styleRecalcDurationMs": 14.714999999999996,
"layouts": 60,
"layoutDurationMs": 12.957999999999998,
"taskDurationMs": 1781.5320000000002,
"heapDeltaBytes": -12453700,
"heapUsedBytes": 70291336,
"domNodes": -227,
"jsHeapTotalBytes": 516096,
"scriptDurationMs": 819.2700000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3500.658000000044,
"styleRecalcs": 64,
"styleRecalcDurationMs": 12.739,
"layouts": 60,
"layoutDurationMs": 13.145,
"taskDurationMs": 1516.7169999999999,
"heapDeltaBytes": 9778756,
"heapUsedBytes": 74957840,
"domNodes": -246,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 774.475,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3026.7920000000004,
"styleRecalcs": 42,
"styleRecalcDurationMs": 6.124999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1912.1710000000003,
"heapDeltaBytes": 23196408,
"heapUsedBytes": 89356400,
"domNodes": 4,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 981.5579999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3113.122999999973,
"styleRecalcs": 43,
"styleRecalcDurationMs": 7.105,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1912.315,
"heapDeltaBytes": 22810596,
"heapUsedBytes": 90795624,
"domNodes": 6,
"jsHeapTotalBytes": 1466368,
"scriptDurationMs": 1000.106,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "minimap-idle",
"durationMs": 2019.5929999999862,
"styleRecalcs": 8,
"styleRecalcDurationMs": 6.468999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 566.5380000000001,
"heapDeltaBytes": -4356588,
"heapUsedBytes": 84526868,
"domNodes": -245,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 37.147,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2059.804999999983,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.853,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 597.1469999999999,
"heapDeltaBytes": -9866776,
"heapUsedBytes": 78898832,
"domNodes": -254,
"jsHeapTotalBytes": -757760,
"scriptDurationMs": 34.331,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 569.7400000000243,
"styleRecalcs": 46,
"styleRecalcDurationMs": 10.033,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 391.85800000000006,
"heapDeltaBytes": 13656528,
"heapUsedBytes": 83715816,
"domNodes": 18,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 142.347,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 543.81699999999,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.044000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 355.473,
"heapDeltaBytes": 14048132,
"heapUsedBytes": 84045036,
"domNodes": 20,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 140.653,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2006.249999999966,
"styleRecalcs": 10,
"styleRecalcDurationMs": 9.478,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 466.848,
"heapDeltaBytes": -5254816,
"heapUsedBytes": 64762716,
"domNodes": -275,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 8.24,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 1991.2950000000365,
"styleRecalcs": 12,
"styleRecalcDurationMs": 10.233999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 455.1839999999999,
"heapDeltaBytes": 9943876,
"heapUsedBytes": 78847320,
"domNodes": -274,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.193000000000001,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1690.2469999999994,
"styleRecalcs": 46,
"styleRecalcDurationMs": 13.925999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 741.263,
"heapDeltaBytes": -4666324,
"heapUsedBytes": 65373340,
"domNodes": -274,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 105.008,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1708.6329999999634,
"styleRecalcs": 46,
"styleRecalcDurationMs": 15.788,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 735.8130000000001,
"heapDeltaBytes": 8024092,
"heapUsedBytes": 77725880,
"domNodes": -276,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 106.771,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1384.2170000000351,
"styleRecalcs": 17,
"styleRecalcDurationMs": 28.924000000000007,
"layouts": 5,
"layoutDurationMs": 12.946,
"taskDurationMs": 891.1210000000001,
"heapDeltaBytes": -6223632,
"heapUsedBytes": 81615916,
"domNodes": 13667,
"jsHeapTotalBytes": 11534336,
"scriptDurationMs": 31.84700000000001,
"eventListeners": 2383,
"totalBlockingTimeMs": 139,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8458.999000000005,
"styleRecalcs": 250,
"styleRecalcDurationMs": 34.836999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5875.044,
"heapDeltaBytes": -10341612,
"heapUsedBytes": 76851548,
"domNodes": -241,
"jsHeapTotalBytes": 778240,
"scriptDurationMs": 2800.394,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8340.096000000016,
"styleRecalcs": 250,
"styleRecalcDurationMs": 36.659,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5775.62,
"heapDeltaBytes": -18435240,
"heapUsedBytes": 68766732,
"domNodes": -219,
"jsHeapTotalBytes": 5009408,
"scriptDurationMs": 2836.3160000000003,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17196.82899999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16654.560000000005,
"heapDeltaBytes": -54773864,
"heapUsedBytes": 185550920,
"domNodes": -8061,
"jsHeapTotalBytes": -13000704,
"scriptDurationMs": 261.431,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 16939.59099999995,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16472.268,
"heapDeltaBytes": -42847476,
"heapUsedBytes": 184289700,
"domNodes": -8091,
"jsHeapTotalBytes": -14745600,
"scriptDurationMs": 263.716,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20895.831999999984,
"styleRecalcs": 161,
"styleRecalcDurationMs": 17.659999999999982,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20587.822,
"heapDeltaBytes": -70874892,
"heapUsedBytes": 170819156,
"domNodes": -8061,
"jsHeapTotalBytes": -16650240,
"scriptDurationMs": 881.5440000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 85,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-pan",
"durationMs": 20247.367000000053,
"styleRecalcs": 157,
"styleRecalcDurationMs": 16.346,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 19997.954999999998,
"heapDeltaBytes": -33078364,
"heapUsedBytes": 192471312,
"domNodes": -8061,
"jsHeapTotalBytes": -18690048,
"scriptDurationMs": 881.366,
"eventListeners": -14928,
"totalBlockingTimeMs": 30,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6213.275999999951,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.209,
"layouts": 20,
"layoutDurationMs": 23.316000000000003,
"taskDurationMs": 6075.216,
"heapDeltaBytes": -63423708,
"heapUsedBytes": 176928644,
"domNodes": -8061,
"jsHeapTotalBytes": 3776512,
"scriptDurationMs": 147.503,
"eventListeners": -14928,
"totalBlockingTimeMs": 423,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6086.857000000009,
"styleRecalcs": 20,
"styleRecalcDurationMs": 84.79999999999998,
"layouts": 20,
"layoutDurationMs": 23.098999999999993,
"taskDurationMs": 6001.8009999999995,
"heapDeltaBytes": -70084376,
"heapUsedBytes": 169880304,
"domNodes": -8061,
"jsHeapTotalBytes": 3551232,
"scriptDurationMs": 115.09599999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 415,
"frameDurationMs": 17.77333333333336,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8779.862999999978,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8489.391,
"heapDeltaBytes": -18556128,
"heapUsedBytes": 169970512,
"domNodes": 0,
"jsHeapTotalBytes": -29360128,
"scriptDurationMs": 145.27999999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8427.841000000059,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8252.927999999998,
"heapDeltaBytes": 8132076,
"heapUsedBytes": 177645820,
"domNodes": 0,
"jsHeapTotalBytes": -29622272,
"scriptDurationMs": 127.10899999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 450.9529999999131,
"styleRecalcs": 14,
"styleRecalcDurationMs": 17.251,
"layouts": 2,
"layoutDurationMs": 0.48699999999999993,
"taskDurationMs": 105.1,
"heapDeltaBytes": 4990124,
"heapUsedBytes": 70945068,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.343,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 128.90199999992547,
"styleRecalcs": 9,
"styleRecalcDurationMs": 18.307999999999996,
"layouts": 4,
"layoutDurationMs": 1.8860000000000001,
"taskDurationMs": 94.06899999999999,
"heapDeltaBytes": 3023436,
"heapUsedBytes": 68964840,
"domNodes": 130,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 9.168,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌐 Website E2ETip All tests passed.
|
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## core/1.55 #19658 +/- ##
=============================================
- Coverage 84.71% 83.85% -0.86%
=============================================
Files 2318 3076 +758
Lines 132286 151144 +18858
Branches 35337 38840 +3503
=============================================
+ Hits 112062 126744 +14682
- Misses 19864 22993 +3129
- Partials 360 1407 +1047
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 762 files with indirect coverage changes 🚀 New features to boost your workflow:
|
0fb6c89 to
0091d6d
Compare
Addresses review feedback: #19658 (review)
|
Addressed the requested Plan.credits prerequisite in 0091d6d, 363a28c, and bcd829e: the generated field is present, projected through the safe-int64 boundary, and raw bigint values are omitted from the public Plan shape. The focused billingPlansView suite passes (3/3), and the CI-reported type error is fixed. |
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: Request changes. #18873 is carried byte-for-byte and now compiles, but the Plan.credits prerequisite is carried without the tests that ship with it.
I compared this branch, against its merge base f305b09 (the current core/1.55 tip), with #18873's merged diff (efcd653). The two pricing components and their tests carry exactly the source's added and removed lines.
The remaining three files carry the part of #19212 (8d81825, "Update Ingest API types from cloud@6d1e6b7") that #18873 depends on and core/1.55 lacks:
credits?: numberon the generatedPlantype- the matching
zPlan.creditsint64 schema - the
billingPlansView.tsprojection that reads the decodedbigintgrant back as a number and refuses a catalog whose grant a number cannot hold
Carrying that subset is the right fix for the TS2339 failure I flagged earlier. The zod hunk matches #19212, and the projection is equivalent to #19212's projectCredits. What is missing is noted inline.
Checks at e1bd260:
- Locally,
vitest runoversrc/platform/workspace/billing/sdk/,PricingTableWorkspace.test.ts, andUnifiedPricingTable.test.tspassed.vue-tsc --noEmitpassed. - Hosted: the required
lint-and-format,test, ande2e-statuschecks passed.website-unitandwebsite-unit-gatefail onrouter-providers.test.ts"counts the models the docs catalog lists" (expected 214 to be 213). That test is outside this diff and not required.
| type DecodedStop = DecodedStops['stops'][number] | ||
| type StopPrice = TeamCreditStops['stops'][number]['monthly'] | ||
|
|
||
| function projectOptionalCredits( |
There was a problem hiding this comment.
#19212 adds this projection, as projectCredits, together with two cases in billingPlansView.test.ts:
- "reads the raw credit grant back as a number when the server sends one"
- "refuses a catalog with a credit grant a number cannot hold exactly"
This branch carries the projection but neither test, so the bigint-to-number path and its overflow refusal are untested here. I applied #19212's billingPlansView.test.ts hunk to this head and it applies cleanly; the billing SDK and pricing suites pass with it. Please carry those two cases.
While carrying them, I would also take #19212's generated Plan.credits doc comment in types.gen.ts verbatim, in place of the hand-written "Per-member raw credit grant, when present in the catalog." at line 1702. That keeps the generated file identical to what regeneration produces.
There was a problem hiding this comment.
Carried both upstream projection cases and the generated Plan.credits documentation in e9e5aad. The focused suite passes 5/5.
Addresses review feedback: #19658 (comment)
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: Request changes. The #18873 carry and its #19212 prerequisite are now complete, but 27025d7 adds an unrelated cherry-pick of #19635 that also fails the AI co-author trailer check.
I compared this branch, against its merge base f305b09, with #18873's merged diff (efcd653).
What matches:
- The two pricing components and their tests carry exactly the source's added and removed lines.
- The prerequisite from #19212 (8d81825), which
core/1.55lacks, is now carried in full: - Locally at 27025d7,
vitest runoversrc/platform/workspace/billing/sdk/,PricingTableWorkspace.test.ts, andUnifiedPricingTable.test.tspassed 195/195.
What diverges is inline. 27025d7 is a byte-identical cherry-pick of #19635 (934af07), which is not part of #18873 or its prerequisite. It deletes the website's live docs-catalog count test. That test was failing the non-required website-unit check on the previous head for reasons unrelated to this diff. The commit also carries Co-authored-by: Cursor Agent <cursoragent@cursor.com> from #19635's squash message, so Check for AI agent co-author trailers now fails at this head, naming 27025d7. Most other hosted checks were still running when I posted.
| ) | ||
| }) | ||
|
|
||
| it('counts the models the docs catalog lists', async (ctx) => { |
There was a problem hiding this comment.
This deletion is #19635 (934af07), carried verbatim. It is unrelated to #18873, so I think it belongs in its own core/1.55 backport of #19635, not in this PR. Its squash message also brings a Co-authored-by: Cursor Agent trailer, which is why Check for AI agent co-author trailers fails here. Please drop 27025d7 from this branch. The website-unit failure it was addressing is not a required check for core/1.55.
27025d7 to
e9e5aad
Compare
… that never held (#19874) (#19900) Test-only port of #19874 to `core/1.55`. **Unblocks the whole `core/1.55` line** — including the release bump — which is currently red on the required `test` context. ## Why `core/1.55` is red #19860 ("preserve seal ordering under reentry") changed `opSender.ts`. Review on `main` then corrected two stale assertions in #19874 (test-only, merged 2026-10-02T06:05:26Z). The `core/1.55` carrier of the **production** half, #19861 → `62f0cc1d9e`, merged at 2026-10-02T03:21:21Z — about 2h45m *before* the companion test correction existed — and it merged with `test=cancelled` / `e2e-status=failure`. So the line took the implementation without its test fix and has been red since: ``` FAIL src/workbench/extensions/agent/crdt/opSender.test.ts > createOpSender > does not rechunk a prefix after serialization aborts and throws FAIL src/workbench/extensions/agent/crdt/opSender.test.ts > createOpSender > resumes a pump requested during workflow-change sealing ``` Ruleset **"Core release branches"** (id 7297873) makes `test` required on every `core/**` ref, so **every** PR targeting `core/1.55` is blocked until this lands — #19858 and #19658 included. `cloud/1.55` has the same breakage from its own carrier #19862; its repair is #19890. **This is the missing `core/1.55` half of that pair.** >⚠️ Related trap, not fixed here: `strict_required_status_checks_policy` is `false` on that ruleset, and #19658 carries a **stale green** `test` computed at `e9e5aadd0b`, which predates `62f0cc1d9e` (`compare/62f0cc1d...e9e5aad` → `diverged`). Do not read that green as branch health. ## What this changes **One file, test-only. Zero production change.** `opSender.ts` is byte-identical to `core/1.55` at `b2743f2f0ae4895f50f8e9becf378507b9720ea0`: ``` $ git diff origin/core/1.55 --name-only src/workbench/extensions/agent/crdt/opSender.test.ts ``` And after this commit `opSender.test.ts` is **byte-identical to `main`** — this is a faithful port, not a variant: ``` $ git diff origin/main --stat -- src/workbench/extensions/agent/crdt/opSender.test.ts (empty) ``` The only production delta between `core/1.55` and `main` in `opSender.ts` is two added `surface: 'agent'` telemetry fields, which do not touch the seal/reentry behaviour these tests exercise — so #19874's corrections apply here unchanged. The cherry-pick applied cleanly with no conflicts. ## These are not loosened-to-green assertions Verified independently **on this branch**, not taken on trust from #19874. Each mutation of `core/1.55`'s own `opSender.ts` kills exactly the test that guards it: | mutation of `opSender.ts` | result | |---|---| | neutralize the `interruptedBeforeProbe` abort short-circuit (`opSender.ts:531`) | `does not rechunk…` **fails** (1 failed \| 86 passed) | | neutralize the `sealing === 0 && pumpRequested` deferral resume (`opSender.ts:614`) | `resumes a pump…` **fails** (1 failed \| 86 passed) | `expect(firstSerializations).toBe(1)` is the only guard on the abort short-circuit branch, so simply deleting the test — the lazy route to green — would have left that branch uncovered. The ported assertions are also *stronger* than the ones they replace: test 1 moves from shape-only checks to an exact settlement list, and test 2 replaces an `onBatchSettled: vi.fn()` that was never asserted on with a real settlement sink plus a wire-addressing assertion (`workflowId === 'wf-new'`). ## Verification on this branch Node 26 (the repo's required version), `NODE_OPTIONS=--no-experimental-webstorage`: | check | before (at `b2743f2f0a`) | after | |---|---|---| | `vitest run opSender.test.ts` | **2 failed** \| 85 passed — `expected 1 to be 2`, `expected 3 to be 1`, identical to CI | **87 passed (87)** | | `vitest run src/workbench/extensions/agent/crdt/` | — | **56 files passed, 776 passed + 2 expected-fail (778)** | | `vitest run --shard="5/8"` | — | **210 files passed, 3025 passed (3025)**, exit 0 | | `typecheck:app` (`vue-tsc --noEmit`) | — | exit 0 | | oxfmt, oxlint `--type-aware`, oxlint audit config, eslint | — | clean (also via pre-commit hooks) | | `.github/scripts/check-ai-co-authors.sh origin/core/1.55 HEAD` | — | `No AI agent Co-authored-by trailers found.` | The two expected-fails in the `crdt/` run are pre-existing `it.fails` cases on this branch, untouched here. ## Provenance Cherry-picked from `b365e2a8478c5d9cc790d620d88a50a2277ae456` (#19874, authored by @huang47 via the Glary-Bot Agent); the `(cherry picked from commit …)` line is preserved in the commit message. The source commit's `Co-authored-by: Glary-Bot` trailer was removed per this repository's AI co-author policy (`.github/scripts/check-ai-co-authors.sh`) — the carrier commit is authored under the same convention as every other `core/1.55` carrier on this line. Landing under Christian's 1.55 release-backport authority. No production behaviour is widened, no test is weakened, and no check was bypassed.
…log (#18873) ## Summary The pricing cards read the plan's raw credit grant from the backend (`Plan.credits`, added in Comfy-Org/cloud#10703) instead of the hardcoded `TIER_PRICING` figure. They fall back to the static grant only when the field is absent. - Follows #18867 (the FE-3013 hotfix). Part of FE-3013. - Comfy-Org/cloud#10703 is merged and live on test-v2. The generated `Plan.credits` type and its SDK projection landed on `main` through #19212, so this PR is now only the pricing surfaces reading it. Until prod serves the field, both tables fall back to the static grant. ## Why The hotfix #18867 stops misreading `credits_cents` by going back to a static grant. A static grant cannot follow a catalog change. Converting `credits_cents` cannot produce the real grant either, because the backend rounds it to whole cents: 23,887¢ → 50,402, while the catalog grants 50,400. The backend now sends the grant itself. ## Root cause `Plan` exposed the grant only as `credits_cents`. The raw count the subscription actually receives, the catalog's `credit_grant`, never reached the client. ## How - `Plan.credits` (generated types) and its safe-number projection in `billingPlansView.ts` are on `main` via #19212. - `UnifiedPricingTable.vue` / `PricingTableWorkspace.vue`: `plan.credits ?? amountForBillingCycle(static)`. The value is read straight off the server; nothing is derived. - Tests: the catalog grant wins over the static figure on the matching cycle only. The #18867 tests still pin the fallback (field absent) to the static grant. ## Screenshots Both builds run locally against the Comfy-Org/cloud#10703 preview backend (`pr-10703.testenvs.comfy.org`). The page's own `GET /api/billing/plans` response already carries `credits`: | slug | `credits_cents` | `credits` | | --- | --- | --- | | standard-monthly | 1,991 | 4,200 | | standard-annual | 23,887 | 50,400 | | creator-monthly | 3,508 | 7,400 | | creator-annual | 42,086 | 88,800 | | pro-monthly | 10,000 | 21,100 | | pro-annual | 120,000 | 253,200 | AS IS (#18867, `86fba0349b`, static grant): Yearly 50,400 / 88,800 / 253,200; Monthly 4,200 / 7,400 / 21,100. | Yearly | Monthly | | --- | --- | | <img width="480" alt="asis-yearly" src="https://github.com/user-attachments/assets/a790c178-0acd-4a1f-9f38-b1925ddbddc2" /> | <img width="480" alt="asis-monthly" src="https://github.com/user-attachments/assets/3dfb46e7-f7cc-486b-98af-8f49a15265ef" /> | TO BE (`a7270257f7`, reads `plan.credits`): same figures, Yearly 50,400 / 88,800 / 253,200; Monthly 4,200 / 7,400 / 21,100. The numbers now come from the API instead of the static table. | Yearly | Monthly | | --- | --- | | <img width="480" alt="tobe-yearly" src="https://github.com/user-attachments/assets/94eafd26-f717-4d31-a6c6-8d2e861617fe" /> | <img width="480" alt="tobe-monthly" src="https://github.com/user-attachments/assets/6e7733e0-71d1-44ee-9b43-b5f318dbcbe7" /> |
Addresses review feedback: #19658 (review)
Addresses review feedback: #19658 (review)
Fixes the typecheck failure reported by CI: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36945811819/job/110647562667
Fixes the Fallow finding reported by CI: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36946049339/job/110648314717
Addresses review feedback: #19658 (comment)
e9e5aad to
7df80f0
Compare
christian-byrne
left a comment
There was a problem hiding this comment.
Exact-head review at 7df80f0d35c6a00ddde7c3b4390c00c4f1c952f1:
- The four pricing files have the same stable patch ID (
e9aa4b62944f6ed0b38bc41a349fb2f35d8ede73) as merged source #18873 (efcd653ca6be69c386003091fe00530b780dd322). The existing fallback assertions remain present; the raw catalog grant wins only when supplied. - The release-only delta is the narrow #19212 prerequisite: generated
Plan.credits, matching zod int64 decoding, safe bigint-to-number projection, and both upstream projection tests (present grant and unsafe overflow refusal). - The unrelated #19635 docs-test deletion is absent,
git diff --checkis clean, and no AI co-author trailer remains. - Exact-head hosted checks are fully terminal green (112/112 non-adverse); required
lint-and-format,test, ande2e-statusall pass. The head is mergeable against livecore/1.55atf871ec91cf8c47edf0ebf7d74fe68e2ac38aa898.
No new code finding from this review. I am not merging: DrJKL’s earlier CHANGES_REQUESTED verdict remains active and three current human threads remain unresolved, so the target-aware program gate correctly refuses. The re-review request already exists in Slack; this review does not repeat it.
There was a problem hiding this comment.
Verdict: Approve. This is a faithful backport of #18873, plus the Plan.credits subset of #19212 that it needs on core/1.55.
I compared it with #18873's merge commit efcd653ca6be69c386003091fe00530b780dd322. All four source files carry identical hunks: PricingTableWorkspace.vue, UnifiedPricingTable.vue and both of their test files. No source hunk or test is dropped.
Adaptations, each accounted for by #19212 (8d81825635462e8e464b1bed57cc83cb07ca0ae9) not being on core/1.55:
packages/ingest-types/src/types.gen.tsandzod.gen.tsadd only the generatedPlan.creditsfield and itszPlanint64 schema. The text matches #19212 exactly. #19212's other generated additions (scoped_has_funds,scoped_effective_has_funds,web_session_probe) are not needed here and are left out.billingPlansView.tsbrings in #19212's projection of the raw grant throughasSafeNumber. The two shape differences are the helper name (projectOptionalCreditsinstead ofprojectCredits) and wherecreditsis destructured (in the body instead of the parameter). The projected plan is the same: an absent grant stays absent, and a grant aboveNumber.MAX_SAFE_INTEGERrejects the catalog. Commit 8990d05 says the reshaping keeps the function under the Fallow complexity gate.billingPlansView.test.tscarries #19212's two projection cases verbatim.
Checks: the three touched suites pass locally at this head (55 tests). On hosted CI at 7df80f0, lint-and-format, test, e2e-status and typecheck all passed, with no failing runs.
Backport of #18873 to
core/1.55Automatically created by backport workflow.