Repository navigation
[backport core/1.55] test(agent): correct op sender seal expectations that never held (#19874) - #19900
Conversation
… that never held (#19874) Test-only port of #19874 to `core/1.55`. `core/1.55` took the production half of #19860 via its carrier #19861 but not the companion test correction, which only existed on `main` ~2h45m later as #19874. The line has been red on the required `test` context ever since, on exactly two cases in `opSender.test.ts`: does not rechunk a prefix after serialization aborts and throws resumes a pump requested during workflow-change sealing Neither assertion ever passed against the implementation #19861 carried, so there is no regression here to preserve — only the stale expectations to correct, with the same corrections `main` already took. No production change: `opSender.ts` is byte-identical to `core/1.55` at b2743f2. After this commit `opSender.test.ts` is byte-identical to `main`. The Glary-Bot co-author trailer carried by the source commit is removed per the repository's AI co-author policy (.github/scripts/check-ai-co-authors.sh); the source author and the cherry-pick provenance line below are preserved. (cherry picked from commit b365e2a)
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2146 passed, 0 failed📊 Browser Reports
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since b2743f2f0ae4895f50f8e9becf378507b9720ea0
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 📦 Bundle Size
⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-10-02T12:52:47.659Z",
"gitSha": "3cd52aebc561ef938e1142c45e67ef34ea5fbabc",
"branch": "op298/fe19874-core-1.55",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2021.23899999998,
"styleRecalcs": 9,
"styleRecalcDurationMs": 9.599,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 510.25600000000003,
"heapDeltaBytes": 8347832,
"heapUsedBytes": 76271724,
"domNodes": -262,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 10.818000000000001,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2007.6919999999063,
"styleRecalcs": 11,
"styleRecalcDurationMs": 10.548,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 423.49899999999997,
"heapDeltaBytes": 9883844,
"heapUsedBytes": 77420240,
"domNodes": -261,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 11.901999999999996,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1774.15400000001,
"styleRecalcs": 46,
"styleRecalcDurationMs": 17.136,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 841.628,
"heapDeltaBytes": 5524560,
"heapUsedBytes": 73146816,
"domNodes": -260,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 162.798,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1758.958000000007,
"styleRecalcs": 44,
"styleRecalcDurationMs": 17.161,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 863.177,
"heapDeltaBytes": 1024344,
"heapUsedBytes": 68987512,
"domNodes": -263,
"jsHeapTotalBytes": 6545408,
"scriptDurationMs": 171.214,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1739.2040000000293,
"styleRecalcs": 32,
"styleRecalcDurationMs": 17.659,
"layouts": 6,
"layoutDurationMs": 1.2409999999999999,
"taskDurationMs": 386.858,
"heapDeltaBytes": 3030812,
"heapUsedBytes": 70770824,
"domNodes": 77,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 14.034999999999998,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1682.8629999999976,
"styleRecalcs": 32,
"styleRecalcDurationMs": 16.344,
"layouts": 6,
"layoutDurationMs": 1.1879999999999997,
"taskDurationMs": 266.349,
"heapDeltaBytes": 2696392,
"heapUsedBytes": 70516196,
"domNodes": 80,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 10.657,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 660.6510000000299,
"styleRecalcs": 12,
"styleRecalcDurationMs": 8.211,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.998,
"heapDeltaBytes": 18528228,
"heapUsedBytes": 86586164,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 171.604,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "dom-widget-clipping",
"durationMs": 697.1369999999979,
"styleRecalcs": 13,
"styleRecalcDurationMs": 9.809,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 465.13699999999994,
"heapDeltaBytes": 18867460,
"heapUsedBytes": 85687760,
"domNodes": 22,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 170.90800000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1220.993999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 916.248,
"heapDeltaBytes": 13706940,
"heapUsedBytes": 103562240,
"domNodes": -292,
"jsHeapTotalBytes": 19025920,
"scriptDurationMs": 70.601,
"eventListeners": -195,
"totalBlockingTimeMs": 586,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1257.865000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 963.399,
"heapDeltaBytes": -17127128,
"heapUsedBytes": 73039068,
"domNodes": -297,
"jsHeapTotalBytes": 20578304,
"scriptDurationMs": 79.03,
"eventListeners": -217,
"totalBlockingTimeMs": 582,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 874.2460000000278,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 516.3229999999999,
"heapDeltaBytes": 14494896,
"heapUsedBytes": 89943068,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 179.88599999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 247,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 858.6450000000241,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 488.69199999999944,
"heapDeltaBytes": 14873500,
"heapUsedBytes": 90137132,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 169.13999999999996,
"eventListeners": 0,
"totalBlockingTimeMs": 231,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10512.045,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9509.649,
"heapDeltaBytes": -10049848,
"heapUsedBytes": 71930412,
"domNodes": -14,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 8133.735,
"eventListeners": 0,
"totalBlockingTimeMs": 1345,
"frameDurationMs": 20,
"p95FrameDurationMs": 50
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11214.527999999973,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10350.403,
"heapDeltaBytes": -7934260,
"heapUsedBytes": 74554588,
"domNodes": -16,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 8577.113,
"eventListeners": 0,
"totalBlockingTimeMs": 1470,
"frameDurationMs": 19.996666666666716,
"p95FrameDurationMs": 50
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11600.399000000038,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10628.785,
"heapDeltaBytes": 15483308,
"heapUsedBytes": 97956192,
"domNodes": -12,
"jsHeapTotalBytes": 9961472,
"scriptDurationMs": 8871.665,
"eventListeners": 0,
"totalBlockingTimeMs": 1783,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11070.112999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10209.964000000002,
"heapDeltaBytes": 11589712,
"heapUsedBytes": 93505260,
"domNodes": -10,
"jsHeapTotalBytes": 8650752,
"scriptDurationMs": 8420.599,
"eventListeners": 0,
"totalBlockingTimeMs": 1428,
"frameDurationMs": 18.886666666666738,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2012.597000000028,
"styleRecalcs": 7,
"styleRecalcDurationMs": 6.110000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 634.5280000000001,
"heapDeltaBytes": 20198068,
"heapUsedBytes": 84135968,
"domNodes": -243,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 36.703,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "large-graph-idle",
"durationMs": 2037.5000000000227,
"styleRecalcs": 8,
"styleRecalcDurationMs": 7.275,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 567.4840000000002,
"heapDeltaBytes": -3663404,
"heapUsedBytes": 83660684,
"domNodes": -244,
"jsHeapTotalBytes": -1544192,
"scriptDurationMs": 30.414000000000012,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2491.2599999999543,
"styleRecalcs": 69,
"styleRecalcDurationMs": 14.715000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1789.074,
"heapDeltaBytes": -21603416,
"heapUsedBytes": 66710524,
"domNodes": -259,
"jsHeapTotalBytes": 2387968,
"scriptDurationMs": 931.145,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2239.445000000046,
"styleRecalcs": 68,
"styleRecalcDurationMs": 11.585999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1643.627,
"heapDeltaBytes": 15718320,
"heapUsedBytes": 80016736,
"domNodes": -246,
"jsHeapTotalBytes": 1536000,
"scriptDurationMs": 852.6610000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3508.369000000016,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.844000000000005,
"layouts": 60,
"layoutDurationMs": 13.691000000000003,
"taskDurationMs": 1697.502,
"heapDeltaBytes": 9386920,
"heapUsedBytes": 75365960,
"domNodes": 6,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 800.049,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3576.0210000000825,
"styleRecalcs": 62,
"styleRecalcDurationMs": 11.618,
"layouts": 60,
"layoutDurationMs": 13.418,
"taskDurationMs": 1717.2389999999998,
"heapDeltaBytes": 8200436,
"heapUsedBytes": 74288504,
"domNodes": 6,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 810.4050000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3100.2129999999966,
"styleRecalcs": 43,
"styleRecalcDurationMs": 6.4540000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1972.8309999999997,
"heapDeltaBytes": 25883440,
"heapUsedBytes": 92316968,
"domNodes": 6,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1011.706,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3156.8500000000768,
"styleRecalcs": 44,
"styleRecalcDurationMs": 7.911000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1988.655,
"heapDeltaBytes": 28524240,
"heapUsedBytes": 94358512,
"domNodes": 8,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1031.085,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666636,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2044.212000000016,
"styleRecalcs": 5,
"styleRecalcDurationMs": 5.465000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 641.4009999999998,
"heapDeltaBytes": -4452288,
"heapUsedBytes": 84622488,
"domNodes": -250,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 39.980000000000004,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2053.309000000013,
"styleRecalcs": 9,
"styleRecalcDurationMs": 10.185999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 640.9169999999999,
"heapDeltaBytes": -7437380,
"heapUsedBytes": 81623760,
"domNodes": -246,
"jsHeapTotalBytes": 290816,
"scriptDurationMs": 35.06200000000001,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 614.1719999999964,
"styleRecalcs": 48,
"styleRecalcDurationMs": 12.098,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 411.813,
"heapDeltaBytes": 14049856,
"heapUsedBytes": 83833212,
"domNodes": 22,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 147.493,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 606.9660000000567,
"styleRecalcs": 48,
"styleRecalcDurationMs": 11.599,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 409.52299999999997,
"heapDeltaBytes": 14009456,
"heapUsedBytes": 83658024,
"domNodes": 21,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 147.851,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-idle",
"durationMs": 1997.616999999991,
"styleRecalcs": 10,
"styleRecalcDurationMs": 8.606000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 446.222,
"heapDeltaBytes": -12061960,
"heapUsedBytes": 57816028,
"domNodes": -277,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 7.136,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2002.426000000014,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.902000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 348.425,
"heapDeltaBytes": -3891424,
"heapUsedBytes": 66096820,
"domNodes": -276,
"jsHeapTotalBytes": 5234688,
"scriptDurationMs": 7.047999999999998,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1722.4150000000122,
"styleRecalcs": 46,
"styleRecalcDurationMs": 15.22,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 766.241,
"heapDeltaBytes": 6693664,
"heapUsedBytes": 76619872,
"domNodes": -275,
"jsHeapTotalBytes": 6283264,
"scriptDurationMs": 110.69699999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1718.1640000000016,
"styleRecalcs": 44,
"styleRecalcDurationMs": 13.037,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 731.7370000000001,
"heapDeltaBytes": -6959736,
"heapUsedBytes": 63074060,
"domNodes": -277,
"jsHeapTotalBytes": 6021120,
"scriptDurationMs": 103.965,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1401.0060000000522,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.298000000000005,
"layouts": 5,
"layoutDurationMs": 12.971,
"taskDurationMs": 895.165,
"heapDeltaBytes": -6232548,
"heapUsedBytes": 81309560,
"domNodes": 13667,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 29.612000000000005,
"eventListeners": 2383,
"totalBlockingTimeMs": 137,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8897.85500000005,
"styleRecalcs": 249,
"styleRecalcDurationMs": 39.314,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6225.392999999999,
"heapDeltaBytes": -5666248,
"heapUsedBytes": 80991596,
"domNodes": -245,
"jsHeapTotalBytes": -827392,
"scriptDurationMs": 2956.658,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8556.330000000002,
"styleRecalcs": 249,
"styleRecalcDurationMs": 43.665,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6012.214,
"heapDeltaBytes": -2886452,
"heapUsedBytes": 84347372,
"domNodes": -249,
"jsHeapTotalBytes": 1269760,
"scriptDurationMs": 2903.255,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17557.687999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17248.22,
"heapDeltaBytes": -44018864,
"heapUsedBytes": 182029452,
"domNodes": -8061,
"jsHeapTotalBytes": -17833984,
"scriptDurationMs": 273.284,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 13121.919999999933,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 12522.934,
"heapDeltaBytes": -65318296,
"heapUsedBytes": 175057920,
"domNodes": -8062,
"jsHeapTotalBytes": -11653120,
"scriptDurationMs": 216.866,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.219999999999953,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 20942.78200000002,
"styleRecalcs": 160,
"styleRecalcDurationMs": 17.95399999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20665.288,
"heapDeltaBytes": -26075000,
"heapUsedBytes": 192372312,
"domNodes": -8061,
"jsHeapTotalBytes": -17641472,
"scriptDurationMs": 948.505,
"eventListeners": -14928,
"totalBlockingTimeMs": 84,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21176.964,
"styleRecalcs": 151,
"styleRecalcDurationMs": 18.544000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20966.36,
"heapDeltaBytes": -42944328,
"heapUsedBytes": 182496696,
"domNodes": -8061,
"jsHeapTotalBytes": -13639680,
"scriptDurationMs": 886.09,
"eventListeners": -14928,
"totalBlockingTimeMs": 78,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6274.005999999986,
"styleRecalcs": 20,
"styleRecalcDurationMs": 80.369,
"layouts": 20,
"layoutDurationMs": 24.385000000000005,
"taskDurationMs": 6183.077,
"heapDeltaBytes": -65146152,
"heapUsedBytes": 170705124,
"domNodes": -8061,
"jsHeapTotalBytes": 15343616,
"scriptDurationMs": 112.21,
"eventListeners": -14928,
"totalBlockingTimeMs": 380,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6331.663000000049,
"styleRecalcs": 20,
"styleRecalcDurationMs": 77.53800000000003,
"layouts": 20,
"layoutDurationMs": 24.94300000000001,
"taskDurationMs": 6289.835000000001,
"heapDeltaBytes": -33855872,
"heapUsedBytes": 181151012,
"domNodes": -8061,
"jsHeapTotalBytes": 15396864,
"scriptDurationMs": 116.86800000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 426,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8778.394999999931,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8471.884000000002,
"heapDeltaBytes": -8900400,
"heapUsedBytes": 174492916,
"domNodes": 0,
"jsHeapTotalBytes": -6815744,
"scriptDurationMs": 138.706,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.333333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6775.758999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6538.224000000001,
"heapDeltaBytes": 25811296,
"heapUsedBytes": 188367248,
"domNodes": 0,
"jsHeapTotalBytes": -2359296,
"scriptDurationMs": 115.94300000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.220000000000073,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 130.44200000001638,
"styleRecalcs": 11,
"styleRecalcDurationMs": 22.59,
"layouts": 5,
"layoutDurationMs": 2.4789999999999996,
"taskDurationMs": 107.039,
"heapDeltaBytes": 3329068,
"heapUsedBytes": 69275008,
"domNodes": 135,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 13.924000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 116.3210000000845,
"styleRecalcs": 7,
"styleRecalcDurationMs": 15.267000000000001,
"layouts": 4,
"layoutDurationMs": 1.859,
"taskDurationMs": 83.43199999999997,
"heapDeltaBytes": 3004788,
"heapUsedBytes": 68656860,
"domNodes": 124,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 7.623000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## core/1.55 #19900 +/- ##
============================================
Coverage 84.71% 84.71%
============================================
Files 2315 2318 +3
Lines 132152 132285 +133
Branches 35293 33444 -1849
============================================
+ Hits 111950 112063 +113
- Misses 19843 19862 +19
- Partials 359 360 +1
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: Approve. This is a faithful backport of #19874 to core/1.55, a clean cherry-pick with no adaptations, and all checks are green.
I compared this branch, at 2960a24 against its merge base b2743f2 (the current core/1.55 tip), with #19874's merged diff (b365e2a). The only file, src/workbench/extensions/agent/crdt/opSender.test.ts, carries exactly the source's added and removed lines. After the change it is byte-identical to main's copy. No production file changes, and the branch merges cleanly into core/1.55.
The commit message keeps the (cherry picked from commit b365e2a8) line and leaves out the source's AI co-author trailer, as the repository's trailer policy requires. That does not change any code.
Checks: at 2960a24, vitest run src/workbench/extensions/agent/crdt/ passed 776 tests across 56 files, plus 2 expected failures that already exist on this branch. All hosted checks at this head passed, including the required test.
Test-only port of #19874 to
core/1.55. Unblocks the wholecore/1.55line — including the release bump — which is currently red on the requiredtestcontext.Why
core/1.55is red#19860 ("preserve seal ordering under reentry") changed
opSender.ts. Review onmainthen corrected two stale assertions in #19874 (test-only, merged 2026-10-02T06:05:26Z). Thecore/1.55carrier of the production half, #19861 →62f0cc1d9e, merged at 2026-10-02T03:21:21Z — about 2h45m before the companion test correction existed — and it merged withtest=cancelled/e2e-status=failure. So the line took the implementation without its test fix and has been red since:Ruleset "Core release branches" (id 7297873) makes
testrequired on everycore/**ref, so every PR targetingcore/1.55is blocked until this lands — #19858 and #19658 included.cloud/1.55has the same breakage from its own carrier #19862; its repair is #19890. This is the missingcore/1.55half of that pair.What this changes
One file, test-only. Zero production change.
opSender.tsis byte-identical tocore/1.55atb2743f2f0ae4895f50f8e9becf378507b9720ea0:And after this commit
opSender.test.tsis byte-identical tomain— this is a faithful port, not a variant:The only production delta between
core/1.55andmaininopSender.tsis two addedsurface: 'agent'telemetry fields, which do not touch the seal/reentry behaviour these tests exercise — so #19874's corrections apply here unchanged. The cherry-pick applied cleanly with no conflicts.These are not loosened-to-green assertions
Verified independently on this branch, not taken on trust from #19874. Each mutation of
core/1.55's ownopSender.tskills exactly the test that guards it:opSender.tsinterruptedBeforeProbeabort short-circuit (opSender.ts:531)does not rechunk…fails (1 failed | 86 passed)sealing === 0 && pumpRequesteddeferral resume (opSender.ts:614)resumes a pump…fails (1 failed | 86 passed)expect(firstSerializations).toBe(1)is the only guard on the abort short-circuit branch, so simply deleting the test — the lazy route to green — would have left that branch uncovered. The ported assertions are also stronger than the ones they replace: test 1 moves from shape-only checks to an exact settlement list, and test 2 replaces anonBatchSettled: vi.fn()that was never asserted on with a real settlement sink plus a wire-addressing assertion (workflowId === 'wf-new').Verification on this branch
Node 26 (the repo's required version),
NODE_OPTIONS=--no-experimental-webstorage:b2743f2f0a)vitest run opSender.test.tsexpected 1 to be 2,expected 3 to be 1, identical to CIvitest run src/workbench/extensions/agent/crdt/vitest run --shard="5/8"typecheck:app(vue-tsc --noEmit)--type-aware, oxlint audit config, eslint.github/scripts/check-ai-co-authors.sh origin/core/1.55 HEADNo AI agent Co-authored-by trailers found.The two expected-fails in the
crdt/run are pre-existingit.failscases on this branch, untouched here.Provenance
Cherry-picked from
b365e2a8478c5d9cc790d620d88a50a2277ae456(#19874, authored by @huang47 via the Glary-Bot Agent); the(cherry picked from commit …)line is preserved in the commit message. The source commit'sCo-authored-by: Glary-Bottrailer was removed per this repository's AI co-author policy (.github/scripts/check-ai-co-authors.sh) — the carrier commit is authored under the same convention as every othercore/1.55carrier on this line.Landing under Christian's 1.55 release-backport authority. No production behaviour is widened, no test is weakened, and no check was bypassed.