Repository navigation
fix: start typing from anywhere in the agent composer prompt area - #19517
Conversation
The prompt editor was a single 28px line inside a taller prompt area, so clicks below the first line landed on padding and focused nothing. The editor now fills the prompt area and owns its padding, and the empty-state hint is stacked in the same grid cell instead of pulled up with a negative margin.
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe inline agent composer now uses a grid and flex layout. Unit and browser tests cover clicking the empty-composer hint and clicking below the first prompt line. ChangesAgent composer
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The composer expands its typing hit area while retaining coverage for hint selection and clipboard behavior. No concrete merge-blocking issue remains; merge after normal checks pass. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 2 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (11 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since ed558d08fa73e9a14b8c343785b2b9b04c4b8808
Full docs: ADR-DEVEX-LINT-0015 🎭 Playwright: ✅ 2158 passed, 0 failed · 1 flaky📊 Browser Reports
🎨 Storybook: ✅ Built — View Storybook📦 Bundle: 10 MB gzip 🔴 +1 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.46 MB (baseline 1.46 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 133 kB (baseline 133 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 643 kB (baseline 643 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 28 unchanged User & Accounts — 39.4 kB (baseline 39.4 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 125 kB (baseline 125 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 4.07 MB (baseline 4.07 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 15 unchanged Utilities & Hooks — 582 kB (baseline 582 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 37 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.9 MB (baseline 17.9 MB) • ⚪ 0 BBundles that do not match a named category
Status: 1 added / 1 removed / 299 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-30T03:24:39.594Z",
"gitSha": "b2de16abdd22ba74c430f6c4d010cd31953613d9",
"branch": "ryan-di/agent-composer-click-focus",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2009.258999999986,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.8119999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 268.96999999999997,
"heapDeltaBytes": -2343944,
"heapUsedBytes": 77703008,
"domNodes": -228,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 6.658,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66528925619835,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-idle",
"durationMs": 2036.4470000000097,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.740000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 309.71,
"heapDeltaBytes": -1551208,
"heapUsedBytes": 78018612,
"domNodes": -228,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 10.122,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622947,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1700.3730000000132,
"styleRecalcs": 71,
"styleRecalcDurationMs": 14.312999999999999,
"layouts": 12,
"layoutDurationMs": 3.7940000000000005,
"taskDurationMs": 504.44599999999997,
"heapDeltaBytes": -4114312,
"heapUsedBytes": 75995208,
"domNodes": -228,
"jsHeapTotalBytes": -262144,
"scriptDurationMs": 100.901,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6656862745098,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1713.9349999999922,
"styleRecalcs": 71,
"styleRecalcDurationMs": 16.198,
"layouts": 12,
"layoutDurationMs": 4.297000000000001,
"taskDurationMs": 565.719,
"heapDeltaBytes": -22199984,
"heapUsedBytes": 57363480,
"domNodes": -228,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 113.917,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665048543689316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1713.8669999999934,
"styleRecalcs": 32,
"styleRecalcDurationMs": 8.924000000000001,
"layouts": 6,
"layoutDurationMs": 1.192,
"taskDurationMs": 204.82300000000004,
"heapDeltaBytes": 1886080,
"heapUsedBytes": 81103544,
"domNodes": 53,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 9.425,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1719.818000000032,
"styleRecalcs": 30,
"styleRecalcDurationMs": 9.618,
"layouts": 6,
"layoutDurationMs": 1.2509999999999997,
"taskDurationMs": 249.72399999999996,
"heapDeltaBytes": 1813780,
"heapUsedBytes": 81179104,
"domNodes": 53,
"jsHeapTotalBytes": 3407872,
"scriptDurationMs": 13.681000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "dom-widget-clipping",
"durationMs": 491.3980000000038,
"styleRecalcs": 14,
"styleRecalcDurationMs": 3.947999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 302.497,
"heapDeltaBytes": 17951200,
"heapUsedBytes": 97391112,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 109.072,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241382,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "dom-widget-clipping",
"durationMs": 544.6169999999597,
"styleRecalcs": 13,
"styleRecalcDurationMs": 4.047999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 322.907,
"heapDeltaBytes": 18639064,
"heapUsedBytes": 97657032,
"domNodes": 0,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 113.565,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 843.9039999999522,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.46999999999997,
"heapDeltaBytes": 9931248,
"heapUsedBytes": 85529768,
"domNodes": 0,
"jsHeapTotalBytes": 2785280,
"scriptDurationMs": 35.626,
"eventListeners": 0,
"totalBlockingTimeMs": 253,
"frameDurationMs": 25.754545454545443,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 904.090999999994,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 499.035,
"heapDeltaBytes": 9365104,
"heapUsedBytes": 85070432,
"domNodes": 0,
"jsHeapTotalBytes": 4620288,
"scriptDurationMs": 40.790000000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 287,
"frameDurationMs": 27.272727272727273,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 688.3119999999963,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 247.02199999999985,
"heapDeltaBytes": 12980372,
"heapUsedBytes": 92355700,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 84.57799999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 84,
"frameDurationMs": 20.591176470588245,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 689.2169999999851,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 265.3179999999997,
"heapDeltaBytes": 13331652,
"heapUsedBytes": 93784316,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 89.219,
"eventListeners": 0,
"totalBlockingTimeMs": 86,
"frameDurationMs": 20.58823529411765,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "extension-clean-combined-draw",
"durationMs": 6083.988000000034,
"styleRecalcs": 1,
"styleRecalcDurationMs": 0.056000000000000494,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4933.878,
"heapDeltaBytes": 3131184,
"heapUsedBytes": 83639992,
"domNodes": 0,
"jsHeapTotalBytes": -17563648,
"scriptDurationMs": 3824.5519999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 9,
"frameDurationMs": 20.28896321070234,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-clean-combined-draw",
"durationMs": 5786.61500000004,
"styleRecalcs": 2,
"styleRecalcDurationMs": 0.34,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4771.299,
"heapDeltaBytes": -2831324,
"heapUsedBytes": 78576124,
"domNodes": 0,
"jsHeapTotalBytes": -15990784,
"scriptDurationMs": 3739.9179999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 32,
"frameDurationMs": 19.5375,
"p95FrameDurationMs": 33.30000000000109
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 5724.247999999989,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.8799999999999988,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4754.691,
"heapDeltaBytes": 11712768,
"heapUsedBytes": 92659740,
"domNodes": 0,
"jsHeapTotalBytes": -11534336,
"scriptDurationMs": 3707.77,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.046153846153846,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 6328.599999999995,
"styleRecalcs": 3,
"styleRecalcDurationMs": 0.7400000000000011,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5135.2390000000005,
"heapDeltaBytes": -5517908,
"heapUsedBytes": 75097688,
"domNodes": 0,
"jsHeapTotalBytes": -17039360,
"scriptDurationMs": 3915.1390000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 22,
"frameDurationMs": 20.180511182108628,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "large-graph-idle",
"durationMs": 2030.046000000027,
"styleRecalcs": 9,
"styleRecalcDurationMs": 2.6870000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 315.49199999999996,
"heapDeltaBytes": -36195724,
"heapUsedBytes": 82916876,
"domNodes": -228,
"jsHeapTotalBytes": -622592,
"scriptDurationMs": 21.467,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665573770491804,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2030.953000000011,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.5099999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 435.927,
"heapDeltaBytes": -37420536,
"heapUsedBytes": 82086508,
"domNodes": -228,
"jsHeapTotalBytes": 1998848,
"scriptDurationMs": 33.138000000000005,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2094.918000000007,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.911999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1016.953,
"heapDeltaBytes": 19437240,
"heapUsedBytes": 82188784,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 520.793,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6664,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2087.806999999998,
"styleRecalcs": 67,
"styleRecalcDurationMs": 11.532,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1143.9940000000001,
"heapDeltaBytes": 18680620,
"heapUsedBytes": 81882168,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 553.492,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665599999999998,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3070.485000000019,
"styleRecalcs": 65,
"styleRecalcDurationMs": 11.755,
"layouts": 60,
"layoutDurationMs": 13.992,
"taskDurationMs": 1047.979,
"heapDeltaBytes": 8526588,
"heapUsedBytes": 72368012,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 476.231,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666304347826088,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3075.2109999999675,
"styleRecalcs": 65,
"styleRecalcDurationMs": 13.124,
"layouts": 60,
"layoutDurationMs": 15.264000000000001,
"taskDurationMs": 1216.8709999999999,
"heapDeltaBytes": 12154188,
"heapUsedBytes": 76713784,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 535.363,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665945945945946,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 2191.127999999992,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.304999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1225.536,
"heapDeltaBytes": 8733120,
"heapUsedBytes": 73033748,
"domNodes": 0,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 627.1719999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665648854961834,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "legacy-node-drag",
"durationMs": 2363.4930000000054,
"styleRecalcs": 45,
"styleRecalcDurationMs": 7.532000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1416.91,
"heapDeltaBytes": 17865632,
"heapUsedBytes": 82370572,
"domNodes": -228,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 697.485,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66595744680851,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "minimap-idle",
"durationMs": 2010.5660000000398,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.047,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 294.971,
"heapDeltaBytes": 21431580,
"heapUsedBytes": 84167200,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 19.322,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2036.8409999999812,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.6100000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 388.5729999999999,
"heapDeltaBytes": -37959784,
"heapUsedBytes": 83585196,
"domNodes": -228,
"jsHeapTotalBytes": 163840,
"scriptDurationMs": 28.328000000000007,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 426.8910000000119,
"styleRecalcs": 49,
"styleRecalcDurationMs": 6.7170000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 268.256,
"heapDeltaBytes": 12791060,
"heapUsedBytes": 93601932,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 96.327,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66538461538462,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 481.2299999999823,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.9239999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 296.32099999999997,
"heapDeltaBytes": 12348836,
"heapUsedBytes": 93755376,
"domNodes": 0,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 102.45800000000001,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241368,
"p95FrameDurationMs": 16.700000000000273
},
{
"name": "subgraph-idle",
"durationMs": 2027.7849999999944,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.8519999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 262.08699999999993,
"heapDeltaBytes": -13985116,
"heapUsedBytes": 67400920,
"domNodes": -244,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 5.345999999999998,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2043.6839999999847,
"styleRecalcs": 12,
"styleRecalcDurationMs": 4.5649999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 329.20899999999995,
"heapDeltaBytes": -13675240,
"heapUsedBytes": 67886132,
"domNodes": -244,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 10.365999999999998,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1678.3629999999903,
"styleRecalcs": 75,
"styleRecalcDurationMs": 15.65,
"layouts": 16,
"layoutDurationMs": 5.391,
"taskDurationMs": 485.37,
"heapDeltaBytes": -5877832,
"heapUsedBytes": 75723756,
"domNodes": -244,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 75.70599999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666336633663366,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1712.4689999999987,
"styleRecalcs": 77,
"styleRecalcDurationMs": 21.035999999999998,
"layouts": 16,
"layoutDurationMs": 5.672,
"taskDurationMs": 594.1179999999999,
"heapDeltaBytes": -17828664,
"heapUsedBytes": 63630336,
"domNodes": -215,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 91.51400000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666019417475727,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "subgraph-transition-enter",
"durationMs": 800.7890000000089,
"styleRecalcs": 18,
"styleRecalcDurationMs": 17.836,
"layouts": 5,
"layoutDurationMs": 7.543999999999999,
"taskDurationMs": 514.6500000000001,
"heapDeltaBytes": 21429116,
"heapUsedBytes": 96540368,
"domNodes": 13667,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 25.097,
"eventListeners": 2383,
"totalBlockingTimeMs": 49,
"frameDurationMs": 19.047619047619047,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8165.255999999999,
"styleRecalcs": 251,
"styleRecalcDurationMs": 38.19,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 3585.2929999999997,
"heapDeltaBytes": -36390176,
"heapUsedBytes": 83004412,
"domNodes": -228,
"jsHeapTotalBytes": -397312,
"scriptDurationMs": 1771.895,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66625766871166,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8225.356000000033,
"styleRecalcs": 250,
"styleRecalcDurationMs": 41.080999999999996,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 4390.907999999999,
"heapDeltaBytes": -33670404,
"heapUsedBytes": 85875124,
"domNodes": -228,
"jsHeapTotalBytes": -135168,
"scriptDurationMs": 2076.6240000000003,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.69979674796748,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 11173.941000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10430.156,
"heapDeltaBytes": -69730244,
"heapUsedBytes": 186311220,
"domNodes": -8049,
"jsHeapTotalBytes": -24125440,
"scriptDurationMs": 149.065,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 19.615575221238938,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "vue-large-graph-idle",
"durationMs": 11874.676000000021,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 11689.868,
"heapDeltaBytes": -33635832,
"heapUsedBytes": 188905352,
"domNodes": -3045,
"jsHeapTotalBytes": 18567168,
"scriptDurationMs": 173.20699999999997,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 23.450988142292488,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-large-graph-pan",
"durationMs": 13949.436000000049,
"styleRecalcs": 67,
"styleRecalcDurationMs": 13.231000000000021,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 13481.392,
"heapDeltaBytes": -40203744,
"heapUsedBytes": 184633840,
"domNodes": -3048,
"jsHeapTotalBytes": 7712768,
"scriptDurationMs": 599.617,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.928438661710032,
"p95FrameDurationMs": 50
},
{
"name": "vue-large-graph-pan",
"durationMs": 14535.95299999995,
"styleRecalcs": 69,
"styleRecalcDurationMs": 15.758000000000022,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 14472.172999999999,
"heapDeltaBytes": -37911576,
"heapUsedBytes": 175675388,
"domNodes": -8049,
"jsHeapTotalBytes": -17620992,
"scriptDurationMs": 651.2209999999999,
"eventListeners": -14923,
"totalBlockingTimeMs": 4,
"frameDurationMs": 28.8258449304175,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "vue-node-resize-workload",
"durationMs": 4237.367000000006,
"styleRecalcs": 20,
"styleRecalcDurationMs": 50.97599999999999,
"layouts": 20,
"layoutDurationMs": 20.003,
"taskDurationMs": 4198.304,
"heapDeltaBytes": -17031084,
"heapUsedBytes": 197464400,
"domNodes": -8049,
"jsHeapTotalBytes": 20652032,
"scriptDurationMs": 69.94300000000001,
"eventListeners": -14923,
"totalBlockingTimeMs": 2,
"frameDurationMs": 25.710365853658537,
"p95FrameDurationMs": 50
},
{
"name": "vue-node-resize-workload",
"durationMs": 4440.7770000000255,
"styleRecalcs": 20,
"styleRecalcDurationMs": 55.581999999999994,
"layouts": 20,
"layoutDurationMs": 22.32,
"taskDurationMs": 4397.377,
"heapDeltaBytes": 7442880,
"heapUsedBytes": 203637932,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 75.46,
"eventListeners": 0,
"totalBlockingTimeMs": 42,
"frameDurationMs": 28.057594936708856,
"p95FrameDurationMs": 50.099999999999454
},
{
"name": "vue-zoom-out-idle",
"durationMs": 5851.359000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5415.7919999999995,
"heapDeltaBytes": 21901664,
"heapUsedBytes": 197188232,
"domNodes": 0,
"jsHeapTotalBytes": -24903680,
"scriptDurationMs": 73.37899999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 20.525614035087717,
"p95FrameDurationMs": 33.399999999999636
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6287.374,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6198.838000000001,
"heapDeltaBytes": -16576552,
"heapUsedBytes": 188681604,
"domNodes": -3046,
"jsHeapTotalBytes": 10092544,
"scriptDurationMs": 96.44400000000003,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 25.132,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "workflow-execution",
"durationMs": 455.37400000000616,
"styleRecalcs": 20,
"styleRecalcDurationMs": 16.041,
"layouts": 4,
"layoutDurationMs": 1.6910000000000003,
"taskDurationMs": 111.76399999999998,
"heapDeltaBytes": -14343368,
"heapUsedBytes": 82317912,
"domNodes": 131,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 12.443999999999999,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66785714285715,
"p95FrameDurationMs": 16.799999999999727
},
{
"name": "workflow-execution",
"durationMs": 95.35800000003292,
"styleRecalcs": 9,
"styleRecalcDurationMs": 11.324000000000002,
"layouts": 3,
"layoutDurationMs": 1.449,
"taskDurationMs": 71.67099999999998,
"heapDeltaBytes": -16672156,
"heapUsedBytes": 80744232,
"domNodes": 114,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 5.397000000000001,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.650000000000016,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 439.2520000000104,
"styleRecalcs": 78,
"styleRecalcDurationMs": 81.065,
"layouts": 76,
"layoutDurationMs": 20.867,
"taskDurationMs": 401.896,
"heapDeltaBytes": -10385844,
"heapUsedBytes": 77780816,
"domNodes": 76,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 127.25900000000001,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 472.0039999999699,
"styleRecalcs": 78,
"styleRecalcDurationMs": 88.087,
"layouts": 76,
"layoutDurationMs": 24.366,
"taskDurationMs": 443.09900000000005,
"heapDeltaBytes": -9987544,
"heapUsedBytes": 78951248,
"domNodes": 76,
"jsHeapTotalBytes": 2883584,
"scriptDurationMs": 138.984,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 892.8570000000491,
"styleRecalcs": 78,
"styleRecalcDurationMs": 232.172,
"layouts": 76,
"layoutDurationMs": 26.851,
"taskDurationMs": 862.8439999999999,
"heapDeltaBytes": 10667856,
"heapUsedBytes": 131157008,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 223.028,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.664814814814807,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 956.7799999999806,
"styleRecalcs": 78,
"styleRecalcDurationMs": 250.73899999999998,
"layouts": 76,
"layoutDurationMs": 28.396,
"taskDurationMs": 931.7139999999999,
"heapDeltaBytes": 11404120,
"heapUsedBytes": 136433056,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 245.923,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379302,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19517 +/- ##
==========================================
+ Coverage 84.31% 85.05% +0.73%
==========================================
Files 3294 2341 -953
Lines 158986 133903 -25083
Branches 43239 34224 -9015
==========================================
- Hits 134051 113888 -20163
+ Misses 23060 19651 -3409
+ Partials 1875 364 -1511
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 975 files with indirect coverage changes 🚀 New features to boost your workflow:
|
| await agentPanel.open() | ||
|
|
||
| const panel = agentPanel.root | ||
| const composer = panel.getByRole('textbox', { name: /^Describe ideas/ }) |
There was a problem hiding this comment.
Instead of pulling out the root, this is where you would add a locator to the Page Object and expose more user-style semantic methods.
There was a problem hiding this comment.
This comment has been minimized.
This comment has been minimized.
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
christian-byrne
left a comment
There was a problem hiding this comment.
The implementation is clean on 4a45f3a. The inline editor now fills the prompt area, the placeholder’s node-selection action remains clickable, and the browser regression covers clicks below the first line. I found no code-level blockers.
Verification: targeted ESLint and formatting checks pass, and the repository typecheck check passes. I am leaving this unapproved because the required lint-and-format check failed when CI invoked the missing lint:fix:ci script, and the required test check is still pending. Please rerun or repair the required checks so this exact-head review can be completed.
The prompt editor now fills the prompt area, so its center sits under the empty-state hint's "mention nodes" button and a plain composer.click() lands on the button. Click the empty prompt area instead, as a user would.
|
|
|
|
|
|
|
|
|
|
|
|
…mposer prompt area (#19517) (#19577) ## Summary Backports merged #19517 (`79c6bef950`) to `cloud/1.54`. ## Conflict resolution - Preserved the complete composer hitbox layout from #19517. - Preserved `cloud/1.54` prompt semantics, including its existing editor event surface. - Adapted `agentComposerPaste.spec.ts` to the Agent page object and below-first-line click. - Kept `agentCopyPaste.spec.ts` deleted because `cloud/1.54` does not contain its newer `AgentCopyPasteDriver` harness. ## Verification - `pnpm exec oxfmt --check <six changed files>` - `pnpm exec eslint <six changed files>` (0 errors; one pre-existing import warning) - `NODE_OPTIONS=--max-old-space-size=8192 pnpm typecheck:browser` - `pnpm test:unit src/workbench/extensions/agent/components/agent/Composer.test.ts --testTimeout=30000` — 93/93 passed - `DISTRIBUTION=cloud NODE_OPTIONS=--max-old-space-size=8192 pnpm build` - isolated Cloud browser proof, repeat-each=5 — 10/10 passed across the hitbox and paste scenarios Original PR: #19517 Failed automation: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/36673105273 Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com>
Backports #19517 to `cloud/1.55`. Resolves the two release-branch conflicts while preserving `cloud/1.55` panel-opening, prompt, and copy/paste behavior. The full composer prompt area remains clickable; no copy, send behavior, starter prompt, auto-prompt, flag, billing, or gratis behavior changes. Verification: - `pnpm exec vitest run src/workbench/extensions/agent/components/agent/Composer.test.ts --testTimeout=30000` (96 passed) - `NODE_OPTIONS=--max-old-space-size=8192 pnpm typecheck:app` - `NODE_OPTIONS=--max-old-space-size=8192 pnpm typecheck:browser` - targeted Stylelint, Oxlint, and ESLint on all seven changed files - `NODE_OPTIONS=--max-old-space-size=8192 pnpm build:cloud` - offline cloud Playwright: focused hitbox + composer paste (2 passed) - offline cloud Playwright: `agentCopyPaste.spec.ts` (4 passed) --------- Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com>
…poser prompt area (#19576) ## Summary Backports #19517 to `core/1.55` so the full Agent composer prompt area accepts clicks for typing. ## Changes - **What**: Recovers merged commit `79c6bef950` while preserving the target branch’s existing entry-button flow and prompt attachment semantics. ## Review Focus Please verify the conflict resolution in `Composer.vue` and `agentComposerPaste.spec.ts` preserves `core/1.55` behavior while retaining the full hitbox and copy/paste regressions. Backport of #19517. --------- Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com>
…mfy-Org#19517) Clicking anywhere in the agent composer's prompt area now starts typing. Before, only the first 28px line was clickable, and clicks below it landed on padding. - **What**: The prompt editor now fills the prompt area and owns its padding, so a click anywhere lands in the editor and the caret goes where you click. The empty-state hint sits in the same grid cell as the editor instead of being pulled up with `-mt-7`, so it can't overflow when it wraps. This is CSS only, with no new event handlers. - The placeholder should line up with the first typed line, and the gap under "Saving workflow…" should stay at 4px (`-mb-2`). - New e2e test in `agentPanel.spec.ts`: starts typing from a click below the first prompt line.
…poser prompt area (#19578) ## Summary Backports #19517 to `core/1.54` so the full Agent composer prompt area accepts focus while retaining this release branch's panel-opening and prompt behavior. ## Changes - **What**: Recovers merge commit `79c6bef950` and resolves the release-specific `Composer.vue` and paste-test conflicts. - **Dependencies**: None. ## Review Focus Please verify that the editor owns the full prompt-area hitbox and that the existing empty-state mention action and copy/paste behavior remain intact. Verification: - Focused cloud browser cases: 10/10 passed (2 cases × 5 repetitions) - `Composer.test.ts`: 93/93 passed with a 30-second timeout - Browser typecheck passed - Targeted ESLint, Oxlint, and formatting checks passed Backport of #19517. Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com>
|
|
|
|
Summary
Clicking anywhere in the agent composer's prompt area now starts typing. Before, only the first 28px line was clickable, and clicks below it landed on padding.
Changes
-mt-7, so it can't overflow when it wraps. This is CSS only, with no new event handlers.Review Focus
-mb-2).agentPanel.spec.ts: starts typing from a click below the first prompt line.