Repository navigation
feat(agent): tailor starter prompts to cloud and local - #19283
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Warning Review paused — included plan limit reachedKeep your review moving with free on-demand reviews.
On-demand reviews are free for the next 10 days.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Promotion and pricing detailsOn-demand reviews are free for the next 10 days. After that, they cost $0.25 per reviewed file. Review limit detailsOr wait 14 minutes for your next included review. Limit details: You’ve used all 8 included reviews currently available. Review configuration: ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughThe agent empty state now displays separate suggested prompts for cloud and local environments. Starter-prompt attribution uses positional slot IDs, and tests use the corresponding localized lists and IDs. ChangesDistribution-specific starter prompts
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Change: Feature Suggested reviewers: Merge Risk: 🔵 Low · up to Starter prompt clicks in non-English locales may be recorded with the wrong source locale in analytics. User-facing behavior is unaffected, so this is a bounded follow-up. 🚥 Pre-merge checks | ✅ 7✅ Passed checks (7 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since e9b2a2d484f1eb10fdec756524200275ae17af5f
Full docs: ADR-DEVEX-LINT-0015 🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2156 passed, 0 failed · 2 flaky📊 Browser Reports
📦 Bundle: 10 MB gzip 🟢 -17 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.46 MB (baseline 1.46 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 133 kB (baseline 133 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 643 kB (baseline 643 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 39.4 kB (baseline 39.4 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 4 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 125 kB (baseline 125 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 4.07 MB (baseline 4.07 MB) • ⚪ 0 BStores, services, APIs, and repositories
Status: 12 added / 12 removed / 3 unchanged Utilities & Hooks — 582 kB (baseline 582 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 21 added / 21 removed / 16 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.9 MB (baseline 17.9 MB) • 🔴 +262 BBundles that do not match a named category
Status: 82 added / 82 removed / 218 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-29T23:29:48.717Z",
"gitSha": "643788e9ed85ac31336636e71a18a2951110a2bc",
"branch": "feat/agent-distribution-starter-prompts",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2030.7050000000118,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.967999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.32099999999997,
"heapDeltaBytes": -16372552,
"heapUsedBytes": 62752192,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.092999999999998,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666393442622944,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2043.2220000000143,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.7809999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 355.209,
"heapDeltaBytes": -36356836,
"heapUsedBytes": 62105716,
"domNodes": -228,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 9.473000000000003,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1805.7720000000472,
"styleRecalcs": 77,
"styleRecalcDurationMs": 22.073999999999998,
"layouts": 12,
"layoutDurationMs": 4.601,
"taskDurationMs": 758.1129999999999,
"heapDeltaBytes": -33701580,
"heapUsedBytes": 65055132,
"domNodes": -228,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 154.421,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.82149532710281,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1860.920999999962,
"styleRecalcs": 77,
"styleRecalcDurationMs": 17.571,
"layouts": 12,
"layoutDurationMs": 4.666,
"taskDurationMs": 832.755,
"heapDeltaBytes": -36687652,
"heapUsedBytes": 61719204,
"domNodes": -228,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 153.846,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.818181818181817,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1731.0970000000339,
"styleRecalcs": 31,
"styleRecalcDurationMs": 10.834,
"layouts": 6,
"layoutDurationMs": 1.5299999999999998,
"taskDurationMs": 336.04900000000004,
"heapDeltaBytes": 1754844,
"heapUsedBytes": 80922012,
"domNodes": 53,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 12.433000000000003,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665384615384614,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1717.1160000000327,
"styleRecalcs": 32,
"styleRecalcDurationMs": 9.66,
"layouts": 6,
"layoutDurationMs": 1.23,
"taskDurationMs": 326.781,
"heapDeltaBytes": 1487016,
"heapUsedBytes": 80472748,
"domNodes": 53,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 11.933,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66601941747573,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 713.7720000000058,
"styleRecalcs": 13,
"styleRecalcDurationMs": 4.181000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 462.70300000000003,
"heapDeltaBytes": -1618628,
"heapUsedBytes": 97107128,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 162.402,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66744186046511,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 680.3969999999708,
"styleRecalcs": 13,
"styleRecalcDurationMs": 3.817000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.08400000000006,
"heapDeltaBytes": -2909344,
"heapUsedBytes": 95325172,
"domNodes": 0,
"jsHeapTotalBytes": 7864320,
"scriptDurationMs": 161.28400000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665853658536566,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1171.6880000000174,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 835.263,
"heapDeltaBytes": 10253972,
"heapUsedBytes": 86258532,
"domNodes": 0,
"jsHeapTotalBytes": 3833856,
"scriptDurationMs": 63.56500000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 537,
"frameDurationMs": 34.31470588235294,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1128.5110000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 794.9,
"heapDeltaBytes": 6468428,
"heapUsedBytes": 82738548,
"domNodes": 0,
"jsHeapTotalBytes": 3571712,
"scriptDurationMs": 62.913,
"eventListeners": 0,
"totalBlockingTimeMs": 512,
"frameDurationMs": 34.34242424242422,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 862.3269999999934,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 476.4089999999999,
"heapDeltaBytes": 14379452,
"heapUsedBytes": 93079596,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 146.951,
"eventListeners": 0,
"totalBlockingTimeMs": 224,
"frameDurationMs": 24.76000000000001,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 847.3989999999958,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 469.31100000000026,
"heapDeltaBytes": 13787624,
"heapUsedBytes": 93058640,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 144.58700000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 221,
"frameDurationMs": 25,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9522.674999999992,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8512.339,
"heapDeltaBytes": -13527104,
"heapUsedBytes": 67586608,
"domNodes": 0,
"jsHeapTotalBytes": -14680064,
"scriptDurationMs": 6821.204,
"eventListeners": 0,
"totalBlockingTimeMs": 384,
"frameDurationMs": 30.697741935483876,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9175.658999999996,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8334.045,
"heapDeltaBytes": -8301996,
"heapUsedBytes": 72319740,
"domNodes": 0,
"jsHeapTotalBytes": -3932160,
"scriptDurationMs": 6684.814,
"eventListeners": 0,
"totalBlockingTimeMs": 444,
"frameDurationMs": 31.499312714776636,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 9219.70399999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8323.746,
"heapDeltaBytes": 11212696,
"heapUsedBytes": 92859312,
"domNodes": 0,
"jsHeapTotalBytes": -13107200,
"scriptDurationMs": 6688.82,
"eventListeners": 0,
"totalBlockingTimeMs": 160,
"frameDurationMs": 29.218354430379748,
"p95FrameDurationMs": 50.099999999998545
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 8307.633999999893,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 7615.606999999999,
"heapDeltaBytes": -11507796,
"heapUsedBytes": 69113884,
"domNodes": 0,
"jsHeapTotalBytes": -16252928,
"scriptDurationMs": 6303.611,
"eventListeners": 0,
"totalBlockingTimeMs": 195,
"frameDurationMs": 31.201879699248117,
"p95FrameDurationMs": 50.100000000000364
},
{
"name": "large-graph-idle",
"durationMs": 2048.3560000000125,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.422999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 580.4770000000001,
"heapDeltaBytes": -36662380,
"heapUsedBytes": 83376736,
"domNodes": -228,
"jsHeapTotalBytes": 163840,
"scriptDurationMs": 35.89200000000001,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66585365853659,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2054.202000000032,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.7170000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 575.955,
"heapDeltaBytes": -37053512,
"heapUsedBytes": 82610552,
"domNodes": -228,
"jsHeapTotalBytes": 1736704,
"scriptDurationMs": 34.997,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.801626016260165,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-pan",
"durationMs": 2370.933999999977,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.767000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1638.112,
"heapDeltaBytes": -32058068,
"heapUsedBytes": 87616612,
"domNodes": -228,
"jsHeapTotalBytes": 651264,
"scriptDurationMs": 809.17,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66595744680851,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2230.748999999946,
"styleRecalcs": 69,
"styleRecalcDurationMs": 10.558000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1516.194,
"heapDeltaBytes": 20253096,
"heapUsedBytes": 83500500,
"domNodes": -228,
"jsHeapTotalBytes": 225280,
"scriptDurationMs": 785.387,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666165413533836,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3752.262999999971,
"styleRecalcs": 63,
"styleRecalcDurationMs": 12.17,
"layouts": 60,
"layoutDurationMs": 15.176,
"taskDurationMs": 1723.605,
"heapDeltaBytes": 12740676,
"heapUsedBytes": 78055412,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 801.3000000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66622222222222,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3615.8159999999953,
"styleRecalcs": 64,
"styleRecalcDurationMs": 11.447000000000003,
"layouts": 60,
"layoutDurationMs": 14.728,
"taskDurationMs": 1653.134,
"heapDeltaBytes": 9615256,
"heapUsedBytes": 73200612,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 770.7499999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66589861751152,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3083.8449999999966,
"styleRecalcs": 44,
"styleRecalcDurationMs": 6.3,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1771.7139999999997,
"heapDeltaBytes": -234400,
"heapUsedBytes": 66973544,
"domNodes": 0,
"jsHeapTotalBytes": 524288,
"scriptDurationMs": 986.523,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75737704918033,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "legacy-node-drag",
"durationMs": 3091.6129999999384,
"styleRecalcs": 42,
"styleRecalcDurationMs": 5.733000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1862.9529999999997,
"heapDeltaBytes": 23233780,
"heapUsedBytes": 88830428,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 950.3999999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.7570652173913,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2025.1430000000141,
"styleRecalcs": 6,
"styleRecalcDurationMs": 2.322000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 577.6719999999998,
"heapDeltaBytes": -38110488,
"heapUsedBytes": 83284816,
"domNodes": -228,
"jsHeapTotalBytes": -360448,
"scriptDurationMs": 35.177,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2028.5259999999425,
"styleRecalcs": 5,
"styleRecalcDurationMs": 2.5299999999999976,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 526.4689999999999,
"heapDeltaBytes": 21675848,
"heapUsedBytes": 84265024,
"domNodes": -228,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 34.361999999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66557377049181,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 639.8499999999672,
"styleRecalcs": 48,
"styleRecalcDurationMs": 6.418999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 416.164,
"heapDeltaBytes": 12302464,
"heapUsedBytes": 93736076,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 151.919,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665789473684214,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 612.5090000000455,
"styleRecalcs": 47,
"styleRecalcDurationMs": 6.359999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 397.38199999999995,
"heapDeltaBytes": 12665148,
"heapUsedBytes": 94041024,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 147.538,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66486486486485,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2039.4170000000145,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.4649999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 472.22600000000006,
"heapDeltaBytes": -16680724,
"heapUsedBytes": 64650556,
"domNodes": -244,
"jsHeapTotalBytes": -786432,
"scriptDurationMs": 9.162,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2038.458999999989,
"styleRecalcs": 10,
"styleRecalcDurationMs": 3.287,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 438.09800000000007,
"heapDeltaBytes": -1438272,
"heapUsedBytes": 80005684,
"domNodes": -244,
"jsHeapTotalBytes": -262144,
"scriptDurationMs": 7.922999999999999,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66475409836066,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1759.570999999994,
"styleRecalcs": 74,
"styleRecalcDurationMs": 19.296,
"layouts": 16,
"layoutDurationMs": 6.375000000000001,
"taskDurationMs": 786.7420000000001,
"heapDeltaBytes": -5930352,
"heapUsedBytes": 75723780,
"domNodes": -244,
"jsHeapTotalBytes": -262144,
"scriptDurationMs": 109.73200000000001,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66603773584906,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1742.242000000033,
"styleRecalcs": 72,
"styleRecalcDurationMs": 18.789,
"layouts": 16,
"layoutDurationMs": 12.992,
"taskDurationMs": 769.278,
"heapDeltaBytes": -1415152,
"heapUsedBytes": 80020616,
"domNodes": -244,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 108.36500000000002,
"eventListeners": -210,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.825961538461534,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1351.9059999999854,
"styleRecalcs": 18,
"styleRecalcDurationMs": 28.181000000000004,
"layouts": 5,
"layoutDurationMs": 11.889000000000001,
"taskDurationMs": 890.4329999999998,
"heapDeltaBytes": -2685068,
"heapUsedBytes": 96317984,
"domNodes": 13667,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 29.377,
"eventListeners": 2383,
"totalBlockingTimeMs": 116,
"frameDurationMs": 18.979166666666654,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8406.737000000021,
"styleRecalcs": 249,
"styleRecalcDurationMs": 36.5,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5724.478999999999,
"heapDeltaBytes": -35913600,
"heapUsedBytes": 83258176,
"domNodes": -228,
"jsHeapTotalBytes": 1142784,
"scriptDurationMs": 2665.1980000000003,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66600397614314,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8348.463000000038,
"styleRecalcs": 252,
"styleRecalcDurationMs": 38.311,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5462.479,
"heapDeltaBytes": -35774932,
"heapUsedBytes": 83880756,
"domNodes": -228,
"jsHeapTotalBytes": 1437696,
"scriptDurationMs": 2596.5950000000003,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699201596806386,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17266.642000000047,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 17119.042999999998,
"heapDeltaBytes": -49197116,
"heapUsedBytes": 173803392,
"domNodes": -3046,
"jsHeapTotalBytes": 7921664,
"scriptDurationMs": 300.157,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 34.39442231075697,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-large-graph-idle",
"durationMs": 17375.393000000033,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16969.037,
"heapDeltaBytes": -56569704,
"heapUsedBytes": 169559312,
"domNodes": -3045,
"jsHeapTotalBytes": 6209536,
"scriptDurationMs": 288.714,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 31.92261029411765,
"p95FrameDurationMs": 66.60000000000036
},
{
"name": "vue-large-graph-pan",
"durationMs": 21434.35900000003,
"styleRecalcs": 154,
"styleRecalcDurationMs": 18.92900000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 21261.66,
"heapDeltaBytes": -37639100,
"heapUsedBytes": 167745076,
"domNodes": -3045,
"jsHeapTotalBytes": 5996544,
"scriptDurationMs": 922.169,
"eventListeners": -14915,
"totalBlockingTimeMs": 46,
"frameDurationMs": 40.637191650853886,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21166.757999999958,
"styleRecalcs": 155,
"styleRecalcDurationMs": 18.485000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20910.226000000002,
"heapDeltaBytes": -26983040,
"heapUsedBytes": 177697808,
"domNodes": -3045,
"jsHeapTotalBytes": 5423104,
"scriptDurationMs": 899.411,
"eventListeners": -14915,
"totalBlockingTimeMs": 55,
"frameDurationMs": 39.562242990654205,
"p95FrameDurationMs": 83.30000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6322.549999999978,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.40999999999998,
"layouts": 20,
"layoutDurationMs": 24.743000000000002,
"taskDurationMs": 6247.7519999999995,
"heapDeltaBytes": -19526540,
"heapUsedBytes": 205522348,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 118.90100000000001,
"eventListeners": 0,
"totalBlockingTimeMs": 429,
"frameDurationMs": 37.597619047619055,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6277.67700000004,
"styleRecalcs": 20,
"styleRecalcDurationMs": 75.91399999999999,
"layouts": 20,
"layoutDurationMs": 25.356000000000005,
"taskDurationMs": 6236.947,
"heapDeltaBytes": 329512,
"heapUsedBytes": 199363508,
"domNodes": 0,
"jsHeapTotalBytes": 1048576,
"scriptDurationMs": 114.64899999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 456,
"frameDurationMs": 39.26937499999999,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8701.266000000032,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8562.536,
"heapDeltaBytes": -23492292,
"heapUsedBytes": 188699788,
"domNodes": -3045,
"jsHeapTotalBytes": 6565888,
"scriptDurationMs": 146.95600000000002,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.58277153558052,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8702.881000000049,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8520.039,
"heapDeltaBytes": -17547544,
"heapUsedBytes": 188267772,
"domNodes": -3045,
"jsHeapTotalBytes": 6041600,
"scriptDurationMs": 178.10299999999995,
"eventListeners": -14915,
"totalBlockingTimeMs": 0,
"frameDurationMs": 32.95303030303031,
"p95FrameDurationMs": 66.59999999999854
},
{
"name": "workflow-execution",
"durationMs": 537.4300000000289,
"styleRecalcs": 19,
"styleRecalcDurationMs": 21.089000000000002,
"layouts": 5,
"layoutDurationMs": 2.366,
"taskDurationMs": 183.31199999999998,
"heapDeltaBytes": -14357904,
"heapUsedBytes": 82402512,
"domNodes": 133,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 19.187,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665625000000006,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "workflow-execution",
"durationMs": 120.4210000000785,
"styleRecalcs": 8,
"styleRecalcDurationMs": 10.536,
"layouts": 3,
"layoutDurationMs": 1.038,
"taskDurationMs": 86.13,
"heapDeltaBytes": -16160408,
"heapUsedBytes": 80565196,
"domNodes": 94,
"jsHeapTotalBytes": 3932160,
"scriptDurationMs": 6.922,
"eventListeners": 33,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.65714285714278,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 974.2760000000317,
"styleRecalcs": 78,
"styleRecalcDurationMs": 110.381,
"layouts": 76,
"layoutDurationMs": 24.5,
"taskDurationMs": 929.039,
"heapDeltaBytes": 18694232,
"heapUsedBytes": 88691804,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 381.416,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667241379310326,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 871.0039999999708,
"styleRecalcs": 78,
"styleRecalcDurationMs": 109.96000000000001,
"layouts": 76,
"layoutDurationMs": 22.934,
"taskDurationMs": 827.579,
"heapDeltaBytes": 17552060,
"heapUsedBytes": 87282628,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 329.34400000000005,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.667307692307688,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1474.9980000000278,
"styleRecalcs": 78,
"styleRecalcDurationMs": 268.54,
"layouts": 76,
"layoutDurationMs": 26.811,
"taskDurationMs": 1456.9019999999998,
"heapDeltaBytes": -1760132,
"heapUsedBytes": 130770024,
"domNodes": -7943,
"jsHeapTotalBytes": -3448832,
"scriptDurationMs": 449.461,
"eventListeners": -1226,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.658333333333324,
"p95FrameDurationMs": 33.29999999999927
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1453.033000000005,
"styleRecalcs": 78,
"styleRecalcDurationMs": 274.58,
"layouts": 76,
"layoutDurationMs": 26.031,
"taskDurationMs": 1433.609,
"heapDeltaBytes": 626788,
"heapUsedBytes": 138649104,
"domNodes": -7974,
"jsHeapTotalBytes": 4153344,
"scriptDurationMs": 432.719,
"eventListeners": -1402,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.14430379746837,
"p95FrameDurationMs": 33.399999999999636
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #19283 +/- ##
==========================================
- Coverage 85.11% 85.03% -0.09%
==========================================
Files 2406 2340 -66
Lines 135505 133805 -1700
Branches 34711 36129 +1418
==========================================
- Hits 115337 113780 -1557
+ Misses 19700 19661 -39
+ Partials 468 364 -104
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 111 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Delivery-readiness read at exact head
Copy/ownership state also changed while this matrix ran: Jo supplied explicit five-item Cloud and local prompt sets in the linked Slack thread and delegated their code update. Those approved strings are not yet present at this head, so this PR should remain draft and this head should not be represented as copy-final. The update belongs on this distribution-split PR (#19283), while parent #18991’s five stable telemetry slot IDs/identity must remain unchanged. Remaining gates: land the delegated approved-copy update on #19283 and run its fresh checks; obtain human review; land parent #18991 first (currently green at |
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
|
Approved-copy readiness is complete at
Marking this stacked PR ready for human review. Parent #18991 remains the explicit merge-first gate and still needs human approval. |
…19310) ## Summary Shortens the second local/Desktop starter prompt so its full capability hint fits at the panel's default width: ```diff - Find an image-to-video workflow that works on my GPU + An image-to-video workflow that fits my GPU ``` This is a stacked, copy-only follow-up: #19310 → #19283 → #18991. Merge the parent instrumentation PR #18991 first, then the Cloud/local copy PR #19283, then this PR. ## Scope - Changes `src/locales/en/main.json` and the matching `EmptyState.test.ts` fixture only (2 insertions, 2 deletions). - Preserves the five stable positional `AgentStarterPromptId` values from #18991 byte-for-byte: `generate_image`, `list_workflows`, `find_workflow`, `explain_selected_node`, and `build_video_workflow`. - Does not add contextual prompt selection, distribution-scoped IDs, flags, allocation, or telemetry-contract changes. Jo approved the shortened line in the example-prompts Slack thread after the original local copy ellipsized at the default panel width. The rendered measurement reported on this PR is 304 px for the approved line versus 375 px for the prior line in a 344 px label box. ## Verification At exact head `1dcd9740db5c19eeb14643f3ef753fbdfea48102`, the complete GitHub matrix is terminal green: **95 successful checks, 15 intentional skips, and 0 failed, cancelled, queued, or running checks**. The focused local verification published with the change is 326 passing tests across the four affected Agent files, plus clean `typecheck`, `typecheck:browser`, and format checks. The full matrix independently covers unit, browser, ecosystem, lint/typecheck, security, performance, Storybook, and affected web suites. ## Review and merge gate `dante01yoon` is the named human reviewer across this stack. This PR is ready for review, but remains parent-first: #18991 and #19283 must be approved and land before #19310 can merge. Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
ryan-di
left a comment
There was a problem hiding this comment.
Looks good once #18991 lands. It will need the same rebase on main as #18991. CI on this head is green.
Small things:
- The chip icons are picked by position (
promptIconsinEmptyState.vue) and weren't updated, so some no longer match the new text. On Cloud, "Turn the product image into a short ad" gets the list icon and "Explain the selected nodes" gets the search icon. - 4 of the 5 slot ids are now named after the old prompts. For example,
find_workflowis now "Explain the selected nodes" andbuild_video_workflowis "Fix the errors in this workflow". Fine if they're meant as slot ids, but dashboards will read oddly, so a note where the ids are defined would help. suggestedPromptschanged from a list to{ cloud, local }only inen. Other locales still have the old list, so non-English users fall back to English until translations are updated, and the event'slocalewon't match the text shown.- The description quotes checks from
acf46b77f9(the head is now0494355ea3) and says #18991 is assigned to @dante01yoon (it's assigned to @benjcooley).
0ff6beb to
c2d8555
Compare
|
Tested on top of #18991 with current main merged in. The ten strings match Jo's final copy in the Slack thread and each distribution renders its own five in English. Two things to look at before this lands. The
|
e2ac7ad to
ffd7ee4
Compare
Resolve array-valued locale keys through their first translated leaf, pin both distribution lists to stable slots, and simplify the shared icon mapping.\n\nReview: https://github.com/Comfy-Org/ComfyUI_frontend/pull/19283#discussion_r4139103287\nReview: https://github.com/Comfy-Org/ComfyUI_frontend/pull/19283#discussion_r4139103308\nReview: #19283 (comment)
DrJKL
left a comment
There was a problem hiding this comment.
Verdict: ready to approve
d9ad57a fixes everything from my last review. The locale check now tests the first entry of the list, so translated prompts report their own locale. A new test covers that path and goes red when I restore the old array-key check. The slot table covers all ten cloud and local chips, and the icon list, test id, comments, and casts are cleaned up. What's left doesn't block merging:
- P3 PR description: it still says "The stable IDs remain
generate_image,list_workflows, …" (head emitsslot_1toslot_5) and "Exact head:acf46b77…". It also still describes the PR as stacked on #18991 with a delivery gate, but #18991 merged asd7d6752and the base ismain. Someone reading the dashboards later will rely on this text, so it's worth fixing before merge. This covers @ryan-di's point about the stale description too. - Nit, inline: the table titles mix a 0-based
$indexwith 1-based slot ids. - Unverified: #18991 has been on
mainsince 2026-09-29, so a staging or nightly Cloud build may have sent the oldprompt_idvalues. A PostHog query for those five values onapp:agent_starter_prompt_clickedsettles whether a saved insight needs updating.
Review record
Round 1: blind approve at 0494355, no findings, later dismissed by the rebase.
Round 2 (round 2, at 5139455):
- P1
EmptyState.vuete()on the array key always false, solocalewas alwaysen: addressed ind9ad57a, reply. The translated-zhtest fails with the old check (1 failed / 15 passed). - P2
EmptyState.test.tscloud slots and copy not pinned: addressed ind9ad57a, reply. Swapping cloud prompts 3 and 4 inen/main.jsonnow fails 2 rows. - P3
EmptyState.vueduplicated icon lists: addressed ind9ad57a, reply. - P3
EmptyState.test.tstest-onlydata-testidfor class assertions: addressed ind9ad57a(both removed), reply. - P3
starterPrompts.test.tscomment claimed position enforcement: addressed ind9ad57a(deleted), reply. - P3
starterPrompts.tsandtypes.tsdocblocks described one locale array: addressed ind9ad57a, reply. - P3
AgentPanelRoot.test.tstm()[1] as string: addressed ind9ad57a, reply. - P3
AgentPanel.test.tstm()[0] as string: addressed ind9ad57a, reply. - P3 PR description says the old ids remain: still open, see above.
- Unverified: old
prompt_idvalues in staging or nightly PostHog. Still unverified, see above.
Other reviewers' findings, as of this head:
- @ryan-di, icons and slot names no longer match the copy: addressed in
e39fc92(per-distribution icons,slot_nids), and the icon list was simplified ind9ad57a. - @ryan-di, non-English locales fall back and
localedoesn't match the text: addressed ind9ad57a. Fallback reportsenand translated copy reports its own locale, and both paths have tests. - @ryan-di, stale description: still open, see above.
- @MaanilVerma,
slot_nids (r4131768023) and icons per distribution (r4131768378): addressed ine39fc92. - CodeRabbit, translate every locale in this PR (r4138995221): contested, because the version-bump i18n run regenerates locales and rebuilds the
{ cloud, local }shape. The bot withdrew the request. - CodeRabbit,
te()on the array key (r4139074643): confirmed in round 2 and addressed ind9ad57a.
Checks at d9ad57a: pnpm install --frozen-lockfile. Focused Vitest over the 11 changed test files passed 680/680. ESLint and oxfmt are clean on the changed files, and pnpm typecheck and pnpm knip are clean (the new FALLBACK_LOCALE export has one consumer). Mutations: reverting the leaf te() check fails 1 test, and swapping cloud prompts 3 and 4 fails 2.
|
Final review sweep: substantive findings are addressed at d9ad57a with required CI green. Remaining open threads were reviewer acknowledgements, notes-to-self, or explicitly non-blocking naming nits; resolved for release. Proceeding with the time-bounded release path. |
|
|
|
|
…d local (#19283) (#19566) Backport of #19283 to `cloud/1.55`. This ships separate Cloud and local starter-prompt sets while preserving stable positional telemetry IDs, so the prompt-distribution experiment reaches testcloud alongside the current Agent release train. Conflict resolution preserved the release line’s existing test surface and applied the source prompt/telemetry changes without importing unrelated main-only tests. Validation: `git diff --check origin/cloud/1.55..HEAD`.
… (#19567) Backports #19283 to `core/1.54`. This gives cloud and local distributions distinct starter-prompt sets, replaces semantic prompt telemetry IDs with stable slot IDs, and keeps the experiment instrumentation aligned across the composer and empty state. Conflict resolution preserved the release branch’s older test structure and applied the source PR’s localized prompt and slot-ID assertions without importing unrelated newer test scaffolding. Source commit for review: d60b4bb Validation: - 74 focused unit tests passed across starter prompts, empty state, draft submission, composer, and composer store - focused AgentPanel localized-prompt test passed - formatting check passed for all 14 changed source/data files - locale structure check passed (new English strings correctly reported pending translation in non-English locales) - focused AgentPanelRoot telemetry assertion is currently blocked by an inherited `core/1.54` test-fixture failure: the branch’s billing mock does not provide `billingType` required by the already-landed exhaustion logic
…d local (#19283) (#19568) ## Summary Backports [#19283](#19283) (tailors the five starter prompts for Cloud versus local/Desktop while retaining stable telemetry slots) to `cloud/1.54`. Source merge: [`d60b4bbf9d`](d60b4bb) Backport commit: [`6fff5464ee`](christian-byrne@6fff5464ee) ## Conflict resolution Three conflicts were confined to tests whose harnesses have advanced on `main`. The backport preserves the `cloud/1.54` test structure and applies the source PR’s localized prompt lookup and stable `slot_2` telemetry expectations. Production feature files applied cleanly. ## Verification - 6 focused test files: 472 passed - `oxfmt --check` on all changed supported files: passed - `git diff --check`: passed - pre-push Knip check: passed ## Review [Review the complete backport diff](cloud/1.54...christian-byrne:ComfyUI_frontend:backport-19283-to-cloud-1.54) Co-authored-by: jojodecayz <121620462+jojodecayz@users.noreply.github.com> Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
… local (#19283) (#19569) ## Summary Backports #19283 to `core/1.55`. - ships the approved five-prompt distributions for Cloud and local/Desktop - preserves the stable telemetry slot IDs introduced by #18991 - retains core/1.55-specific test structure while carrying the source feature and focused coverage ## Conflict resolution The release branch already contains the manually backported #18991 implementation, but its test scaffolding differs from `main`. Conflicted test-only hunks were resolved against the release line, then the slot-ID assertions needed by this feature were applied directly. Production prompt selection, copy, localization, and telemetry types are preserved from the source PR. ## Verification - `pnpm typecheck:app` - focused Vitest: 7 files, 270 tests passed - pre-push `knip --cache` - `git diff --check` ## Source - Source PR: #19283 - Dependency/backport context: #19489 Co-authored-by: jojodecayz <121620462+jojodecayz@users.noreply.github.com> Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com>
|
|
|
|
## Summary - show the first three cold-start prompt suggestions below the existing 460px panel breakpoint - retain all five suggestions in the DOM and show them at wider panel sizes - cover the rendered behavior on both sides of the breakpoint in the Agent browser harness The other compact-empty-state acceptance item, removing the Comfy logo, is covered by [frontend PR 18052](Comfy-Org#18052), merged 2026-09-25. This PR intentionally avoids duplicating that change. ## Rebased onto current `main` (second time) `5e260d95` was `CONFLICTING`/`DIRTY` again. Rebased onto `d965cd4dbd65b24546c518a0319f0f1edb3d4ada`; new head `35f9d672532a93d678d25424cb1b0d4ab0aaec36`. The branch's earlier `main` merge commit is gone — the four commits are linear on top of `main` now. **One conflict, in `browser_tests/fixtures/components/AgentPanel.ts`.** `main` added a private `toasts: ToastHelper` to the property list where this branch added `public readonly suggestedPrompts`. Both belong, so both are kept, in the list's alphabetical order. Nothing was preferred mechanically and nothing upstream was reverted: `main`'s attachment drop/hand-over helpers, the credit-transition notice locator, the tooltip settle in `selectWorkflow`, `rejectEveryTurn`, and the canvas settle in node-selection mode are all intact. `EmptyState.vue` auto-merged against an upstream class removal on a line this branch does not touch. The net change against `main` is the same four files, +123/−14 before the review fixes below. **No approval was spent.** This PR has never had one — latest non-dismissed review per reviewer is `dante01yoon` CHANGES_REQUESTED, `DrJKL` COMMENTED, `christian-byrne` COMMENTED. `dante01yoon` has no earlier changes-requested to resurrect, so the push could not re-expose a retired verdict. ## Review follow-up at `35f9d672532a93d678d25424cb1b0d4ab0aaec36` The blocking finding was real and is fixed by taking the reviewer's first option. `prompt_count` meant "size of the rendered set" and the starter-prompt set experiment reads it that way; reporting the compact panel's visible count through that same field would have made a narrow panel indistinguishable from a shrunken set in every arm. - `prompt_count` is `prompts.value.length` again, so its existing docblock is accurate. - The width-dependent count moved to a **new** `visible_prompt_count` on `app:agent_starter_prompt_clicked`: 3 in a compact panel, the set size elsewhere. It carries its own docblock stating why the two are separate. - The field is **required**, not optional, so no future emitter can drop it silently. That is what the six fixture updates are. - Two non-blocking test notes also addressed: the compact visibility array is derived from `compactCount` instead of repeating three literals, and both breakpoint phases use `expect.poll` so they keep a web-first retry. The `EmptyState.test.ts` comment names happy-dom, which is the environment `vite.config.mts:843` actually configures. ## Testing At head `35f9d672532a93d678d25424cb1b0d4ab0aaec36`, locally: - `pnpm vitest run src/platform/telemetry src/workbench/extensions/agent` — **209 files, 4444 passed**, 1 expected fail. - `pnpm typecheck` and `pnpm typecheck:browser` — both clean. `oxfmt --check` and type-aware `oxlint` clean on the changed files; full pre-commit hooks ran on both commits, and the pre-push `fallow audit` reports no issues in the 15 changed files. - The whole `@cloud` spec file through the browser harness — **6 passed (16.6s)**, against a local ComfyUI e2e backend with `DISTRIBUTION=cloud` on the dev server. **Regression proofs, all three red without the change:** - Browser: reverting only `EmptyState.vue` to `main` fails the PM-1373 case at the 459px phase — suggestions 4 and 5 resolve visible where the assertion wants them hidden. Restoring it turns the file green. - Unit: restoring the blocked telemetry behaviour (`prompt_count` carrying the visible count) fails the new `EmptyState` case on `promptCount: 5`. - Unit: unwiring `visiblePromptCount()` fails the same case on `visiblePromptCount: 3`. No existing assertion was weakened to go green. Remote checks at this head are running; results are not claimed here until they land. --- <details> <summary>Earlier rebase and review history (head <code>f63a35cc</code> / <code>235cde9c</code>)</summary> ## Rebased onto current `main` This branch was `CONFLICTING` against `main` for nineteen days and has been rebased onto `1697904c9dccce16f50a55d2dfd828bd3aa4e506`. New head: `f63a35ccbf2f03c8f00665b7290fe4f955c46ed0`. The ten review-iteration commits are collapsed into two; the net change is the same three files. Three things moved under the branch and the resolution adapts to them rather than reverting them: - `EmptyState.vue` gained the starter-prompt set experiment ([Comfy-Org#20272](Comfy-Org#20272)) and distribution-specific prompt sets ([Comfy-Org#19283](Comfy-Org#19283)). The click handler is now `onPromptClick(prompt, index)`, so the class edit is reapplied around it. The hidden-overflow rule is index-based, so it holds for the control set, the local set, and the treatment set alike. - `agent.suggestedPrompts` in the locale files is no longer a flat array — it is `{ cloud, local, treatment.cloud }`. The page object therefore resolves suggestion buttons **by position** inside `[data-testid="suggested-prompts"]`, not by prompt text, which would otherwise have broken on whichever set rendered. `includeHidden: true` is load-bearing: the compact state keeps every suggestion in the DOM, so a visible-only locator cannot tell "hidden" from "never rendered". - `main`'s `X-01 / PM-672` already took the `agentPanel.open()` change but kept the inline resize-handle drag. That duplication is removed here as originally reviewed. ## Testing At head `f63a35ccbf2f03c8f00665b7290fe4f955c46ed0`, locally: - `pnpm vitest run src/workbench/extensions/agent/components/agent/EmptyState.test.ts` — 24 passed - `pnpm typecheck` and `pnpm typecheck:browser` — both clean - `oxfmt --check`, `stylelint`, and type-aware `oxlint` on the three changed files — clean. ESLint reports the two `browser_tests/` files as outside its config, which is the repo's configuration, not a change here. Full pre-commit hooks (oxfmt, stylelint, type-aware oxlint, ESLint, `typecheck:app`) ran on both commits; the transcripts are the recorded `lint-staged` output. - The whole `@cloud` spec file through the browser harness — **6 passed (21.6s)**, against a local ComfyUI e2e backend with `DISTRIBUTION=cloud` on the dev server. That is the file's six cases, i.e. the new breakpoint case plus the two X-01 widths and the three neighbor-layout cases that exercise the refactored `resizeTo`. - **Regression proof:** reverting only `EmptyState.vue` and rerunning the new case fails at `suggestions.nth(4)` → `toBeHidden`, resolved to a visible `<button>` at 459px. Restoring the fix turns it green. The pin fails on the parent and passes on the fix. Remote checks at this head are running; results are not claimed here until they land. ## Review follow-up at `235cde9c7ffc790c99ceaeefd30209bd12b13d5a` - Click attribution now reports the number of suggestions visible when clicked (3 in a compact panel), not the full set size. Unit case added; it fails without the change. - The X-01 cases measure the outer dock again, as originally written. `resizeTo` takes the element to size; the PM-1373 case still measures the panel root. - The PM-1373 case no longer pins the set at five suggestions. Locally at this head: `EmptyState.test.ts` 25 passed; `pnpm typecheck` and `typecheck:browser` clean; the whole `@cloud` spec file 6 passed. Reverting only `EmptyState.vue` still fails the new case at `nth(3)` and `nth(4)` → `toBeHidden`. </details> ## Note for the reviewer: backport labels were retargeted This PR carried `needs-backport` + `cloud/1.54`. The 1.54 trains are retired, and `pr-backport.yaml` creates a carrier per train label on merge — so merging as labelled would have opened a `cloud/1.54` carrier. `cloud/1.54` was removed and replaced with `cloud/1.55` + `cloud/1.56`. Correction, since this paragraph had gone stale: `cloud/1.55` was then removed again on 2026-10-11 by the repository owner, so the PR currently carries `needs-backport` + **`cloud/1.56` only**. That removal is left alone deliberately — it reads as a release-line decision, not a mechanical slip. If 1.55 should also receive this change, re-add the label before merging. If no release line should, drop `needs-backport`. Linear: [PM-1370 — compact Agent empty state](https://linear.app/comfyorg/issue/PM-1370), [PM-1373 — reduce narrow-panel suggestions](https://linear.app/comfyorg/issue/PM-1373) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Summary
This is stacked on #18991 (starter-prompt click and send attribution); merge that PR first.
Verification
Exact head:
acf46b77f9e7f6242dd5d2bb25eaeac66dca1bf6agentRateLimitDuplicateSubmit.spec.ts— jobgit diff --checkall passedThe ten prompt strings match Jo's approved Slack copy byte-for-byte. The stable IDs remain
generate_image,list_workflows,find_workflow,explain_selected_node, andbuild_video_workflow.Delivery gate
#18991 is terminal green and assigned to @dante01yoon, but still needs human approval and must land before this stacked PR can merge.