Skip to content

Validate #10841 reconciliation with current HDR and model drop behavior - #39

Open
xmarre wants to merge 3 commits into
mirror/pr-10841-base-20261014from
mirror/pr-10841-reconcile-20261014
Open

xmarre wants to merge 3 commits into
mirror/pr-10841-base-20261014from
mirror/pr-10841-reconcile-20261014

Conversation

@xmarre

@xmarre xmarre commented Oct 14, 2026 •

Copy link
Copy Markdown
Owner

Reconciles Comfy-Org#10841 against upstream 791f2f7. Single-commit candidate: 27c72f7 on mirror/pr-10841-final-20261014.

Preserves Comfy-Org#20839 EXR/HDR normalization, Comfy-Org#20540 consumed model-drop ownership, Comfy-Org#19143/Comfy-Org#19153 app registry and leaf interfaces, Comfy-Org#18389 Agent video validation, and Comfy-Org#16407 semantic Vue-node colors. Restores the missing shared event utility exports.

Evidence: 777 tests passed / 1 skipped across 11 focused suites on mirror 24eda66; a subsequent fetch-mock correction passed the 26-test node routing suite. Format, Stylelint, type-aware Oxlint, ESLint and the changed-line server-fact check completed on the earlier base. Typecheck found one missing constructor argument in the added test; the candidate fixes it. CodeRabbit reviewed that earlier mirror with no actionable findings.

Final-base validation remains incomplete: upstream subsequently removed PrimeVue, and the execution environment disconnected before revalidation. The candidate differs from the tested mirror in three files only: two upstream semantic color replacements, the required test constructor argument, and the shared fetch mock. Native OS-to-browser drag behavior and a fresh final-base build are unverified. Fork validation and push branches have not received workflow runs.

Reconcile the graph/document and Vue drag/drop handoff with current upstream.
Preserve video rejection and warning ownership, Agent attachment semantics,
current Vue pointer gestures, typed widgets, toasts, and asset metadata.

Include focused regression coverage for URI, BMP placeholder, media MIME,
rejected file ownership, clipboard paste, and canvas fallback paths.
@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: xmarre/ComfyUI_frontend/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: aab4e9f4-3d62-4f47-af1e-96bac5fd1b72
📥 Commits

Reviewing files that changed from the base of the PR and between 3eb32ee and 24eda66.

📒 Files selected for processing: 19
  • src/composables/node/useNodeDragAndDrop.test.ts
  • src/composables/node/useNodeDragAndDrop.ts
  • src/composables/node/useNodeImageUpload.ts
  • src/composables/usePaste.test.ts
  • src/composables/usePaste.ts
  • src/renderer/extensions/vueNodes/components/LGraphNode.test.ts
  • src/renderer/extensions/vueNodes/components/LGraphNode.vue
  • src/renderer/extensions/vueNodes/composables/useVueNodeDragAndDrop.test.ts
  • src/renderer/extensions/vueNodes/composables/useVueNodeDragAndDrop.ts
  • src/renderer/extensions/vueNodes/widgets/composables/useImageUploadWidget.test.ts
  • src/renderer/extensions/vueNodes/widgets/composables/useImageUploadWidget.ts
  • src/scripts/app.test.ts
  • src/scripts/app.ts
  • src/types/comfy.ts
  • src/utils/__tests__/eventUtils.test.ts
  • src/utils/eventUtils.ts
  • src/utils/mediaUploadUtil.ts
  • src/workbench/extensions/agent/AgentPanelRoot.test.ts
  • src/workbench/extensions/agent/AgentPanelRoot.vue

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

File extraction and media classification now support transfer items, filename extensions, and synthetic BMP placeholders. Paste, node, canvas, and agent-panel handlers use updated routing and drop-event handling.

Changes: Media transfer handling

Layer / File(s) Summary
File extraction and media classification
src/utils/eventUtils.ts, src/utils/__tests__/eventUtils.test.ts, src/utils/mediaUploadUtil.ts
Transfer utilities extract files from items or file lists, discard zero-byte BMP placeholders, and classify media by MIME type or recognized filename extension. File-picker filters include more image and video formats.
Clipboard media paste
src/composables/usePaste.ts, src/composables/usePaste.test.ts
Paste handling captures files before cloning clipboard data, removes synthetic BMP placeholders, and routes matching files to a selected media node or to a node for the first media type found in clipboard order.
Node file-drop filtering
src/composables/node/useNodeDragAndDrop.ts, src/composables/node/useNodeDragAndDrop.test.ts, src/composables/node/useNodeImageUpload.ts, src/renderer/extensions/vueNodes/widgets/composables/useImageUploadWidget.ts, src/renderer/extensions/vueNodes/widgets/composables/useImageUploadWidget.test.ts
Node drag-and-drop handling extracts files from transfer items or file lists, recognizes URI formats, and separates accepted from rejected files. Image-upload options can identify rejected files that a handler may claim.
Vue node drop routing
src/renderer/extensions/vueNodes/composables/useVueNodeDragAndDrop.ts, src/renderer/extensions/vueNodes/composables/useVueNodeDragAndDrop.test.ts, src/renderer/extensions/vueNodes/components/LGraphNode.vue, src/renderer/extensions/vueNodes/components/LGraphNode.test.ts
A composable tracks drag-over ownership and acceptance, handles accepted drops, and falls back to application file handling when a node declines a drop. LGraphNode delegates its handlers to the composable.
Canvas and agent-panel drop routing
src/scripts/app.ts, src/scripts/app.test.ts, src/types/comfy.ts, src/workbench/extensions/agent/AgentPanelRoot.vue, src/workbench/extensions/agent/AgentPanelRoot.test.ts
ComfyApp.handleFileDrop routes eligible drops to a node before processing files. Agent-panel handlers prevent default behavior, stop propagation, and mark claimed events as handled.

Priority: ➖ Normal

Estimated code review effort: 4 (Complex) | ~50 minutes

Change: Bug fix

Sequence Diagram(s)

sequenceDiagram
  participant Browser
  participant useVueNodeDragAndDrop
  participant LGraphNode
  participant ComfyApp
  participant eventUtils
  Browser->>useVueNodeDragAndDrop: Dispatch drop event
  useVueNodeDragAndDrop->>LGraphNode: Call onDragDrop
  LGraphNode-->>useVueNodeDragAndDrop: Return false
  useVueNodeDragAndDrop->>ComfyApp: handleFileDrop with skipNodeRouting
  ComfyApp->>eventUtils: extractFilesFromDragEvent
Loading

Suggested reviewers: christian-byrne

Merge Risk: ⚪ Minimal · up to 24eda

The reviewed media paste and drop-routing paths have no identified issue requiring a fix before merge.

Pre-merge checks: Passed 6 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
End-To-End Test Suggestion For User-Facing Changes Warning The PR changes user-facing drag-and-drop, media upload, clipboard paste, and node-routing behavior under src/. A user can trigger these changes by dragging a media file or asset onto the canvas, or … Add an end-to-end Playwright test to an existing relevant spec under browser_tests/. Suggested scenario: drag a supported media file or asset onto the canvas and verify that the intended node receives the drop. - Open the canvas. - Drag a…
Passed Passed checks: 6 passed
Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Website End-To-End Regression Coverage Passed No changed file is under apps/website/src/ or apps/website/public/. The PR changes frontend src/ files and tests only, so this website-specific check does not apply.
Adr Compliance For Entity/Litegraph Changes Passed PASS. The PR changes graph-related node and widget files, so the check applies. The provided diff summary shows drag-and-drop routing, media classification, and Vue delegation changes. It does not sho…
Title check Passed The title clearly identifies the reconciliation work and its focus on current HDR and model drop behavior.
Description check Passed The description is detailed and relevant. It explains the reconciliation scope, preserved behavior, restored utilities, validation evidence, and remaining validation limits. It does not use the templa…
Full details: End-To-End Test Suggestion For User-Facing Changes

Explanation

The PR changes user-facing drag-and-drop, media upload, clipboard paste, and node-routing behavior under src/. A user can trigger these changes by dragging a media file or asset onto the canvas, or by pasting media into a selected node. The changed-file list contains no added or updated spec under browser_tests/. This is a test suggestion, not a merge requirement.

Resolution

Add an end-to-end Playwright test to an existing relevant spec under browser_tests/. Suggested scenario: drag a supported media file or asset onto the canvas and verify that the intended node receives the drop. - Open the canvas. - Drag a supported media file onto the canvas. - Verify that the intended node receives the file. - Verify that the drop event is handled.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

xmarre commented Oct 14, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant