Repository navigation
Conversation
interfaces.ts now imports only branded IDs and enums, so Rectangle, measure, ConstrainedSize, LGraphBadge, LGraphButton, SlotBase and 15 app modules (linkStore, rerouteStore, ...) leave the import-cycle SCC (923 -> 905). Graph-bound contracts move to types/slots.ts, types/linkNetwork.ts, types/contextMenu.ts, types/panel.ts; CreateNodeOptions to LiteGraphGlobal, NewNodePosition/IBoundaryNodes to utils/arrange, Hoverable to types/events. The litegraph barrel exports are unchanged. Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
remoteConfig imported the enum type from useFeatureFlags, which imports the API client, which imports the workflow schema, which imports LGraph. That one edge bound reportError, telemetry, and every module they touch into the same import cycle as litegraph. The enum now lives in src/platform/remoteConfig/serverFeatureFlag.ts with no imports. The Storybook mock's duplicated copy of the enum is deleted. Cyclic modules 949 -> 816, largest cycle 905 -> 618. litegraph and its entity stores now form their own 149-module cycle, separate from the app. Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
sidebarTabStore imported the six core tab composables so it could register them, pulling the node library, model library, queue, assets and workflow UI trees into the same import cycle as the store that every one of them reads. registerCoreSidebarTabs() now lives in src/composables/sidebarTabs/registerCoreSidebarTabs.ts and calls the store; the store keeps register/unregister/toggle. GraphView.vue is the only caller. Store tests that only exercised registration move with it. Cyclic modules 816 -> 669, largest cycle 618 -> 465. Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
extensionService imported extensions/core/index so loadExtensions could pull the core extensions in. Every core extension imports app, which imports extensionService, so the whole extensions/core tree and its UI sat in the same import cycle as the app object. loadExtensions and shouldLoadExtension move to src/services/extensionLoader.ts. GraphCanvas.vue, which already owns the bootstrap sequence and is outside the cycle, runs the extensions-load phase right before app.setup(). app.setup() no longer loads extensions. Ordering change: extensions now import before syncWorkflows() and fetchSubgraphs() instead of after. Extension hooks (init, setup, registerCustomNodes) still run inside app.setup() as before. Cyclic modules 669 -> 580, largest cycle 465 -> 371. Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
… of scripts/widgets scripts/widgets.ts held three things: the ComfyWidgets registry, the widget constructor types, and the control_after_generate helpers. Every widget composable imported the V2 constructor type from it, which put all 22 of them in the app import cycle through the registry's imports. ComfyWidgetConstructorV2 moves to src/types/widgetConstructor.ts (depends only on litegraph and schema types). addValueControlWidget(s), updateControlWidgetLabel and their helpers move to src/scripts/valueControlWidgets.ts. widgets.ts keeps the registry and the V1 types that reference ComfyApp. IS_CONTROL_WIDGET is imported from controlWidgetMarker directly instead of re-exported. useIntWidget/useFloatWidget tests now use the scripts/app manual mock; the previous mock of scripts/widgets had also been hiding the registry from them. Cyclic modules 580 -> 566, largest cycle 371 -> 357. Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
…lder appModeStore imported useEmptyWorkflowDialog so enterBuilder() could show a dialog when the graph had no nodes. That pulled the dialog service, the template selector dialog and their content components into the store's import cycle. The store now enters the builder unconditionally; the UI-facing check and dialog live in src/components/builder/useEnterBuilder.ts, which the three entry points (workflow actions menu, app-mode toolbar, LinearWelcome) call. The dialog tests move from appModeStore.test.ts to useEnterBuilder.test.ts. useWorkflowActionsMenu.test.ts asserts against the composable instead of the store action, since the real store reports no nodes under the test app mock. Cyclic modules 566 -> 558, largest cycle 357 -> 349. Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
useSettingsDialog imported SettingDialog.vue so it could open it, while the settings subtree (billing stores, top-up dialogs, confirmation content) imports useSettingsDialog to jump to a panel. That single edge kept 52 modules of settings UI inside the main import cycle. The composable now opens whichever component GraphView registers through registerSettingDialogComponent(). SettingDialog.vue declares its props with SettingDialogProps from platform/settings/types so the registration stays typed without importing the component. Cyclic modules 558 -> 509, largest cycle 349 -> 297. Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
useAssetBrowserDialog imported AssetBrowserModal.vue, which pulls the asset grid, model info panel, upload flow, and their stores into the main import cycle. The composable now opens whatever component the app shell registers through registerAssetBrowserModalComponent, and the modal's props interface lives in a leaf type module both sides import. Import cycles: 509 -> 496 cyclic modules, largest SCC 297 -> 284. Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
…sion litegraphService imported useMaskEditor only to push the "Open in MaskEditor | Image Canvas" context menu item, pulling the whole mask editor UI into the services cycle. The Comfy.MaskEditor extension already owns useMaskEditor, so it now contributes the item through getNodeMenuItems with the same clipspace and image-node guards and the same 'preview' media-action marking. Import cycles: 496 -> 484 cyclic modules, largest SCC 284 -> 272. Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
bottomPanelStore imported the shortcuts and terminal tab composables only to register the core tabs, which pulled the bottom panel tab components into the stores import cycle. The registration now lives in composables/bottomPanelTabs/registerCoreBottomPanelTabs, mirroring registerCoreSidebarTabs, and GraphView calls it at startup. Import cycles: 484 -> 476 cyclic modules, largest SCC 272 -> 264. Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
…f modules domWidgetStore imported useAbsolutePosition only for the PositionConfig type, and changeTracker imported layerEditorDialog only for its dialog key. Both imports dragged UI composables into the stores and scripts import cycle. PositionConfig now lives in types/positionConfig and LAYER_EDITOR_DIALOG_KEY in renderer/extensions/layerEditor/layerEditorDialogKey. Import cycles: 476 -> 471 cyclic modules, largest SCC 264 -> 257. Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
sidebarTabStore special-cased the model-library tab id to open the asset browser instead of the sidebar, importing openModelLibraryBrowser and the feature flag and setting stores for one tab. SidebarTabExtension gains an optional onToggle hook; the toggle command defers to it and the model library tab owns the asset browser routing. Import cycles: 471 -> 467 cyclic modules, largest SCC 257 -> 253. Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
executionStore drove the node text preview widget directly: it handled the progress_text socket event and removed leftover widgets when a job reset, importing useNodeProgressText and canvasStore for it. The store now only emits onJobReset with the finished job. useProgressTextPreviews, mounted from GraphView, listens to progress_text and onJobReset and owns the widget calls. Import cycles: 467 -> 464 cyclic modules, largest SCC 253 -> 250. Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
ComfyApi lazily imported authStore for the Firebase header and WebSocket token and imported remintRetry for the 401 re-mint fetch, pulling the cloud auth graph back into the most imported module in src. The client now takes an ApiAuthProvider (leaf interface plus an anonymous default); the cloud provider carries the moved logic and main.ts installs it before any request. Import cycles: 464 -> 447 cyclic modules, largest SCC 250 -> 233. Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
workspaceApi imported authStore for its request headers and remintRetry to attach the 401 re-mint interceptor at module load, tying the workspace billing and capability modules into the auth cycle. The client now exposes setWorkspaceApiAuth; installWorkspaceApiAuth wires the auth store and the interceptor and main.ts calls it before any request. Import cycles: 447 -> 428 cyclic modules, largest SCC 233 -> 214. Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
…pi provider" This reverts commit f9c6913.
`settingStore` reached back into `scripts/app` to replay every change on the legacy `ComfySettingsDialog` event target, and owned `SettingTreeNode`, a settings-dialog UI type that pulled `treeExplorerTypes` into the store. The store now exposes `onSettingChanged` (vueuse event hook, same shape as `executionStore.onJobReset`) and GraphCanvas bridges it to `app.ui.settings.dispatchChange` before core settings register, so extensions still observe `<id>.change` at the same point. `SettingTreeNode` moves next to the composables that build and search the settings tree. `$el` moves from `scripts/ui.ts` to the `scripts/ui/utils.ts` leaf; `ui.ts` keeps exporting it for the `scripts/ui.js` shim. Without the settingStore shortcut into `app`, a test that reached `scripts/utils -> ui` before `app` evaluated `new ComfyApp()` while `ComfyUI` was still uninitialised. Import cycles: 428 -> 417 cyclic modules, largest SCC 214 -> 203. Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
`src/types/comfy.ts` sits in the app cycle through the litegraph barrel and `ComfyExtension`, so every importer of `MissingNodeType` (missing-node scan, error catalog, right-side-panel error groups, telemetry grouping) joined the cycle for one type alias. The alias already referenced `NodeReplacement` from the nodeReplacement leaf; it now lives next to it and importers read it from there. `comfy.ts` keeps using it for the `ComfyExtension` hooks. Import cycles: 417 -> 411 cyclic modules, largest SCC 203 -> 197. Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
`nodeDefStore.nodeDefs` prepended `subgraphStore.subgraphBlueprints`, so the node-def registry depended on the subgraph store, which in turn depends on the workflow store, dialog service, canvas store and the rest of the app cycle. The blueprint node defs are node defs; `nodeDefStore` now owns the `blueprintNodeDefsByName` map and `subgraphStore` registers and removes entries in it. `subgraphStore.subgraphBlueprints` is derived from that map, so its callers are unchanged. Import cycles: 411 -> 403 cyclic modules, largest SCC 197 -> 184.
`createGraphThumbnail` and `useWorkflowThumbnail.storeThumbnail` take the graph to render instead of reading it from workflowStore/canvasStore; workflowService passes the active subgraph or root graph at the call site. `MinimapDataSource` receives node progress states through `MinimapRenderContext` instead of reading executionStore, so the live minimap keeps its execution colors and the thumbnail renderer has no store imports. Import cycles: 403 -> 400 cyclic modules, largest SCC 184 -> 181.
`dialogService` bundled the core prompt/confirm/error dialogs with every auth, billing, workspace, cloud-notification and ComfyHub dialog, so the core service pulled the whole platform layer into the app SCC and every consumer of `confirm()` transitively imported billing. The core service keeps `showExecutionErrorDialog`, `showErrorDialog`, `prompt`, `confirm`, `showExtensionDialog`, `showLayoutDialog` and `showSmallLayoutDialog`. Feature dialogs move verbatim into `useAuthDialogs`, `useBillingDialogs`, `useWorkspaceDialogs`, `useCloudNotificationDialog` and `useComfyHubPublishDialog.showPublishDialog`; callers import the composable they need. Extensions still reach every dialog through `app.extensionManager.dialog`. `ExtensionDialogService` declares that surface with leaf types only; `createExtensionDialogService()` assembles it and `App.vue` registers it before the workspace store is created, so `workspaceStore` no longer imports the feature composables directly (that variant kept the SCC at 185). `ConfirmationDialogType` moves to a leaf module and `useSettingsDialog` calls `dialogStore.showDialog` directly instead of `showLayoutDialog`. Billing dialog tests move next to `useBillingDialogs`; a new `__mocks__` per feature composable replaces the monolithic dialogService mock in the affected tests. Import cycles: 400 -> 391 cyclic modules, largest SCC 181 -> 172. Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
Modules that sit underneath `scripts/app.ts` in the import graph no longer import the `app` value from it. They call `useApp()` from `scripts/appInstance`, which reads a registry that `app.ts` fills once the `ComfyApp` instance exists. Type-only consumers import the new `ComfyApp` interface from `types/comfy`, and clipspace state moves to `scripts/clipspace` with the `ComfyApp` statics kept as accessors. Import cycles: 391 -> 352 cyclic modules, largest SCC 172 -> 149. Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
… context The SDK store, operation store, and hosted-tab opener settled a billing mutation by calling `useBillingContext()` and `useBillingCapabilities()` to refetch, which put the readers of billing state underneath the rails that feed them. They now call `refreshBilling(scope)` from the new leaf `platform/workspace/billing/billingRefresh`, and the context and capabilities composables register as listeners for their own scope. `showSubscriptionDialog` and `requireActiveSubscription` leave the `BillingActions` facade; callers open the paywall through `useBillingDialogs().showSubscriptionRequiredDialog`. The subscription guard on `purchaseCreditsDirect` moves from `useAuthActions` to its two callers so auth actions no longer read the billing context. Import cycles: 352 -> 324 cyclic modules, largest SCC 149 -> 149. Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
The public extension contract in types/comfy.ts no longer reaches scripts/appInstance. Widget constructor types move into types/comfy, MissingModelPipelineResult into platform/missingModel/types, and the legacy menu (scripts/ui.ts) takes its app and host collaborators as constructor arguments. comfyWorkflow.ts becomes a leaf: the change tracker, draft persistence, and settings are registered by the workflow store through a WorkflowRuntime, and the save-as name prompt moves to workflowService with the copy supplied as i18n keys. WorkflowStore and the dialog service contracts are declared in new leaf modules so extensionTypes.ts stops importing the stores. Import cycles: 324 -> 293 cyclic modules, largest SCC 149 -> 149. Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
Manager: `useManagerState` keeps only the UI-state derivations and the once-per-session upgrade toast; `openManager` moves to `useManagerDialog`, which already owns showing the dialog. Callers open the manager through `useManagerDialog().openManager`. This removes the useManagerState -> useManagerDialog -> ManagerDialog.vue back-edge that made the 28 manager modules one cycle. Agent: `ComposerAttachment` lives in `types/composerPrompt.ts` instead of `useComposer.ts`, and the CRDT follower's `AgentCrdtStatus` and outcome counters live in a new `crdt/agentCrdtStatus.ts` leaf so `crdtSnapshot` does not depend on the composable. Import cycles: 293 -> 259 cyclic modules, 21 -> 18 cycles, largest SCC 149 -> 149. Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
Import cycles: 259 -> 211 cyclic modules, 18 -> 5 cycles, largest SCC 149 -> 149. Breaks 13 small strongly connected components outside litegraph and the 42-module app core by extracting leaf modules and inverting dependencies: - scripts/ui: `LegacyUIApp` interface typed on ComfyUI/ComfyList; the unused `app` field/ctor param dropped from ComfySettingsDialog and ComfyAppMenu; button.ts and applyTextReplacements take narrow shapes. - telemetry: `TierKey`/`BillingCycle` moved to a leaf `platform/cloud/subscription/constants/tierKey.ts`. - nodeDef: `ComfyNodeDefImpl` moved to `core/graph/nodeDef/ComfyNodeDefImpl.ts`; `NodeLibrarySection` moved to nodeOrganizationTypes; `useNodeFrequencyStore` split into its own leaf store and `topNodeDefs` moved onto useNodeDefStore. - QuadTree: `Bounds` moved to `types/spatialIndex.ts`. - settings: `ServerConfigValue` moved to `platform/settings/types.ts`. - domWidget: widget interfaces moved to `types/domWidget.ts`. - maskEditor: `useCanvasHistory` takes its layers as an argument. - widgetInputs: `nodeTypeGuards.ts` removed; `isPrimitiveNode` made private. - searchbox: `FilterChip` moved to `components/searchbox/v2/filterChip.ts`; searchBoxStore declares a local `SearchBoxPopover` interface. - keybinding: dialog state moved to `editKeybindingDialogState.ts`. - auth dialogs: `updatePassword` moved to `useUpdatePassword(requestSignIn)`; UpdatePasswordContent takes a `requestSignIn` prop. - menu: `MenuOption`/`SubMenuOption`/`BadgeVariant` moved to `composables/graph/menuOption.ts`. - billingOperationStore: `pollPendingOperations` no longer exposed. Deferred: Subscription (9), Auth (8), load3d (3), app (42), litegraph (149). Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (575 changed files).
Pre-existing findings are baselined in Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 7bd1e8b0c046f589b0a14627399326669c8d6d08
Full docs: ADR-DEVEX-LINT-0015 🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2158 passed, 0 failed · 1 flaky📊 Browser Reports
📦 Bundle Size
⚡ Performance Report
Absolute values
Raw data{
"timestamp": "2026-09-29T21:26:20.382Z",
"gitSha": "8d2ad4703628a0029b294ddc0a9aef6be1884cc6",
"branch": "drjkl/import-cycles-stack",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.3869999999706,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.501,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 386.581,
"heapDeltaBytes": -29260632,
"heapUsedBytes": 63536552,
"domNodes": -232,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 10.450000000000001,
"eventListeners": -137,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2023.5460000000103,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.1860000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 372.79699999999997,
"heapDeltaBytes": -30776932,
"heapUsedBytes": 62202796,
"domNodes": -232,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 9.309000000000001,
"eventListeners": -137,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1989.3660000000182,
"styleRecalcs": 85,
"styleRecalcDurationMs": 19.185000000000002,
"layouts": 12,
"layoutDurationMs": 5.082000000000001,
"taskDurationMs": 973.7099999999999,
"heapDeltaBytes": -31675880,
"heapUsedBytes": 61205088,
"domNodes": -232,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 179.424,
"eventListeners": -137,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.80762711864407,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1850.4950000000235,
"styleRecalcs": 76,
"styleRecalcDurationMs": 17.840999999999998,
"layouts": 12,
"layoutDurationMs": 4.251,
"taskDurationMs": 876.6229999999999,
"heapDeltaBytes": -23089048,
"heapUsedBytes": 69642720,
"domNodes": -203,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 171.529,
"eventListeners": -137,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.818181818181817,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1742.1370000000138,
"styleRecalcs": 32,
"styleRecalcDurationMs": 9.198000000000002,
"layouts": 6,
"layoutDurationMs": 1.115,
"taskDurationMs": 282.785,
"heapDeltaBytes": 11369580,
"heapUsedBytes": 104292184,
"domNodes": 53,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 12.103,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66571428571429,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1742.30799999998,
"styleRecalcs": 32,
"styleRecalcDurationMs": 9.177000000000001,
"layouts": 6,
"layoutDurationMs": 1.1260000000000001,
"taskDurationMs": 362.79100000000005,
"heapDeltaBytes": 11391228,
"heapUsedBytes": 104251988,
"domNodes": 53,
"jsHeapTotalBytes": 6291456,
"scriptDurationMs": 12.341999999999999,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665714285714284,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 747.3029999999881,
"styleRecalcs": 12,
"styleRecalcDurationMs": 3.142999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.827,
"heapDeltaBytes": -674976,
"heapUsedBytes": 92185244,
"domNodes": 0,
"jsHeapTotalBytes": 7077888,
"scriptDurationMs": 174.69799999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 747.8820000000042,
"styleRecalcs": 11,
"styleRecalcDurationMs": 2.985999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 491.82499999999993,
"heapDeltaBytes": -1116656,
"heapUsedBytes": 91707460,
"domNodes": 0,
"jsHeapTotalBytes": 6815744,
"scriptDurationMs": 176.99599999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.053488372093028,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1195.100000000025,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 827.8560000000001,
"heapDeltaBytes": 15624848,
"heapUsedBytes": 92162832,
"domNodes": 0,
"jsHeapTotalBytes": 9076736,
"scriptDurationMs": 68.03999999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 578,
"frameDurationMs": 36.36363636363637,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1163.383999999951,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 821.327,
"heapDeltaBytes": 13859988,
"heapUsedBytes": 91582732,
"domNodes": 0,
"jsHeapTotalBytes": 7766016,
"scriptDurationMs": 64.73399999999998,
"eventListeners": 0,
"totalBlockingTimeMs": 534,
"frameDurationMs": 34.31176470588234,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 864.2340000000104,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 460.6959999999996,
"heapDeltaBytes": -12328000,
"heapUsedBytes": 67116592,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 170.56499999999997,
"eventListeners": 0,
"totalBlockingTimeMs": 231,
"frameDurationMs": 25.491176470588204,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 862.2060000000147,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 495.75999999999976,
"heapDeltaBytes": -7153400,
"heapUsedBytes": 67162008,
"domNodes": 0,
"jsHeapTotalBytes": 266240,
"scriptDurationMs": 174.17399999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 238,
"frameDurationMs": 25.491176470588204,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10070.458000000002,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9171.206000000002,
"heapDeltaBytes": -1116220,
"heapUsedBytes": 79835812,
"domNodes": 0,
"jsHeapTotalBytes": -11796480,
"scriptDurationMs": 7724.3189999999995,
"eventListeners": 0,
"totalBlockingTimeMs": 1404,
"frameDurationMs": 35.196503496503496,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "extension-clean-combined-draw",
"durationMs": 9856.356000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9022.629,
"heapDeltaBytes": 9503868,
"heapUsedBytes": 90649560,
"domNodes": 0,
"jsHeapTotalBytes": -12320768,
"scriptDurationMs": 7613.182,
"eventListeners": 0,
"totalBlockingTimeMs": 1153,
"frameDurationMs": 33.67431506849315,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11196.316000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10157.577,
"heapDeltaBytes": -2462100,
"heapUsedBytes": 79540140,
"domNodes": 0,
"jsHeapTotalBytes": -14680064,
"scriptDurationMs": 8363.546,
"eventListeners": 0,
"totalBlockingTimeMs": 1342,
"frameDurationMs": 32.32023121387284,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11247.30999999997,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10204.382000000001,
"heapDeltaBytes": 10900724,
"heapUsedBytes": 92475496,
"domNodes": 0,
"jsHeapTotalBytes": -12582912,
"scriptDurationMs": 8425.44,
"eventListeners": 0,
"totalBlockingTimeMs": 1575,
"frameDurationMs": 32.65377906976744,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "large-graph-idle",
"durationMs": 2053.18699999998,
"styleRecalcs": 7,
"styleRecalcDurationMs": 2.021000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 482.3229999999999,
"heapDeltaBytes": -25854364,
"heapUsedBytes": 88723568,
"domNodes": -232,
"jsHeapTotalBytes": 425984,
"scriptDurationMs": 38.839,
"eventListeners": -137,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-idle",
"durationMs": 2052.6740000000245,
"styleRecalcs": 4,
"styleRecalcDurationMs": 1.1839999999999993,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.31600000000003,
"heapDeltaBytes": -23213304,
"heapUsedBytes": 89238720,
"domNodes": -232,
"jsHeapTotalBytes": -884736,
"scriptDurationMs": 34.952,
"eventListeners": -137,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2986.6029999999455,
"styleRecalcs": 65,
"styleRecalcDurationMs": 8.992999999999997,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1798.467,
"heapDeltaBytes": 3080980,
"heapUsedBytes": 66092472,
"domNodes": 0,
"jsHeapTotalBytes": 3670016,
"scriptDurationMs": 919.48,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6659217877095,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2508.114999999975,
"styleRecalcs": 65,
"styleRecalcDurationMs": 8.620000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1555.9479999999999,
"heapDeltaBytes": -438132,
"heapUsedBytes": 62852264,
"domNodes": 0,
"jsHeapTotalBytes": 2359296,
"scriptDurationMs": 865.87,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.777852348993285,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-zoom",
"durationMs": 3669.9820000000045,
"styleRecalcs": 61,
"styleRecalcDurationMs": 9.819999999999999,
"layouts": 60,
"layoutDurationMs": 14.089,
"taskDurationMs": 1764.855,
"heapDeltaBytes": 17772448,
"heapUsedBytes": 82053276,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 803.328,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66590909090909,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3707.3709999999664,
"styleRecalcs": 62,
"styleRecalcDurationMs": 10.540000000000001,
"layouts": 60,
"layoutDurationMs": 14.046000000000003,
"taskDurationMs": 1666.8979999999997,
"heapDeltaBytes": 18374220,
"heapUsedBytes": 83071840,
"domNodes": 0,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 834.1909999999999,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66576576576577,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "legacy-node-drag",
"durationMs": 3136.922000000027,
"styleRecalcs": 42,
"styleRecalcDurationMs": 5.589,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1835.9959999999999,
"heapDeltaBytes": 2720924,
"heapUsedBytes": 67113988,
"domNodes": 0,
"jsHeapTotalBytes": 4456448,
"scriptDurationMs": 1004.5580000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.755080213903742,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3080.714999999941,
"styleRecalcs": 41,
"styleRecalcDurationMs": 5.608000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1879.671,
"heapDeltaBytes": 35802120,
"heapUsedBytes": 100090332,
"domNodes": 0,
"jsHeapTotalBytes": 5136384,
"scriptDurationMs": 1041.481,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.75683060109289,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2022.9790000000207,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.9960000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 558.0280000000001,
"heapDeltaBytes": 115744,
"heapUsedBytes": 63218488,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 35.496,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665289256198346,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2018.0239999999685,
"styleRecalcs": 4,
"styleRecalcDurationMs": 0.9650000000000005,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 555.736,
"heapDeltaBytes": 212960,
"heapUsedBytes": 63075592,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 38.813,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666115702479342,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 648.7450000000194,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.077999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 420.53,
"heapDeltaBytes": -6112080,
"heapUsedBytes": 88982172,
"domNodes": 0,
"jsHeapTotalBytes": 8126464,
"scriptDurationMs": 144.99699999999999,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 597.2870000000512,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.119999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 382.181,
"heapDeltaBytes": -6192660,
"heapUsedBytes": 89129540,
"domNodes": 0,
"jsHeapTotalBytes": 7602176,
"scriptDurationMs": 149.314,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2025.3450000000157,
"styleRecalcs": 10,
"styleRecalcDurationMs": 2.9460000000000006,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 372.35699999999997,
"heapDeltaBytes": -29319356,
"heapUsedBytes": 65964592,
"domNodes": -248,
"jsHeapTotalBytes": 3145728,
"scriptDurationMs": 8.367000000000003,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.6655737704918,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2029.7100000000228,
"styleRecalcs": 7,
"styleRecalcDurationMs": 1.9309999999999987,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 471.67,
"heapDeltaBytes": -14279292,
"heapUsedBytes": 65275876,
"domNodes": -248,
"jsHeapTotalBytes": -524288,
"scriptDurationMs": 8.483,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66639344262295,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1762.6500000000078,
"styleRecalcs": 78,
"styleRecalcDurationMs": 17.934,
"layouts": 16,
"layoutDurationMs": 6.173,
"taskDurationMs": 856.143,
"heapDeltaBytes": -33655080,
"heapUsedBytes": 61580136,
"domNodes": -248,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 117.60900000000001,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666981132075477,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1773.2900000000882,
"styleRecalcs": 80,
"styleRecalcDurationMs": 19.442,
"layouts": 16,
"layoutDurationMs": 6.108,
"taskDurationMs": 898.631,
"heapDeltaBytes": -27719812,
"heapUsedBytes": 67420816,
"domNodes": -248,
"jsHeapTotalBytes": 4194304,
"scriptDurationMs": 120.374,
"eventListeners": -183,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666037735849052,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1416.9770000000312,
"styleRecalcs": 18,
"styleRecalcDurationMs": 29.649,
"layouts": 5,
"layoutDurationMs": 12.923,
"taskDurationMs": 923.125,
"heapDeltaBytes": 22554780,
"heapUsedBytes": 104222724,
"domNodes": 13667,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 30.471999999999998,
"eventListeners": 2383,
"totalBlockingTimeMs": 149,
"frameDurationMs": 19.36621621621622,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "viewport-pan-sweep",
"durationMs": 8541.792999999983,
"styleRecalcs": 248,
"styleRecalcDurationMs": 32.445,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5481.338,
"heapDeltaBytes": 25587548,
"heapUsedBytes": 87468480,
"domNodes": -232,
"jsHeapTotalBytes": 192512,
"scriptDurationMs": 2880.5420000000004,
"eventListeners": -137,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.698630136986306,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8451.543000000016,
"styleRecalcs": 248,
"styleRecalcDurationMs": 31.955,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5416.7609999999995,
"heapDeltaBytes": -23399284,
"heapUsedBytes": 91205684,
"domNodes": -232,
"jsHeapTotalBytes": 1667072,
"scriptDurationMs": 2809.469,
"eventListeners": -137,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.699011857707507,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17415.832999999962,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16835.090999999997,
"heapDeltaBytes": -16492260,
"heapUsedBytes": 165517636,
"domNodes": -1520,
"jsHeapTotalBytes": 17825792,
"scriptDurationMs": 284.729,
"eventListeners": -7452,
"totalBlockingTimeMs": 0,
"frameDurationMs": 30.66214788732394,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-idle",
"durationMs": 17156.74200000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16583.645999999997,
"heapDeltaBytes": -11305008,
"heapUsedBytes": 169830352,
"domNodes": -1520,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 278.366,
"eventListeners": -7452,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.721490467937606,
"p95FrameDurationMs": 66.60000000000218
},
{
"name": "vue-large-graph-pan",
"durationMs": 16001.96500000004,
"styleRecalcs": 94,
"styleRecalcDurationMs": 13.084999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 15415.858,
"heapDeltaBytes": -10820004,
"heapUsedBytes": 170295076,
"domNodes": -1520,
"jsHeapTotalBytes": 14155776,
"scriptDurationMs": 838.73,
"eventListeners": -7452,
"totalBlockingTimeMs": 128,
"frameDurationMs": 28,
"p95FrameDurationMs": 66.69999999999891
},
{
"name": "vue-large-graph-pan",
"durationMs": 20628.462000000014,
"styleRecalcs": 159,
"styleRecalcDurationMs": 17.417000000000016,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20400.855,
"heapDeltaBytes": -7636376,
"heapUsedBytes": 166601744,
"domNodes": -1520,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 922.6460000000001,
"eventListeners": -7452,
"totalBlockingTimeMs": 47,
"frameDurationMs": 38.6376404494382,
"p95FrameDurationMs": 83.29999999999927
},
{
"name": "vue-node-resize-workload",
"durationMs": 6019.398999999965,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.30300000000001,
"layouts": 20,
"layoutDurationMs": 23.043999999999993,
"taskDurationMs": 5958.810999999999,
"heapDeltaBytes": 7846276,
"heapUsedBytes": 186970948,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 108.931,
"eventListeners": 0,
"totalBlockingTimeMs": 437,
"frameDurationMs": 36.02694610778443,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-node-resize-workload",
"durationMs": 6134.389000000056,
"styleRecalcs": 20,
"styleRecalcDurationMs": 78.96600000000001,
"layouts": 20,
"layoutDurationMs": 22.731,
"taskDurationMs": 6032.909999999999,
"heapDeltaBytes": 8037264,
"heapUsedBytes": 182334548,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 109.332,
"eventListeners": 0,
"totalBlockingTimeMs": 431,
"frameDurationMs": 35.97882352941176,
"p95FrameDurationMs": 66.70000000000073
},
{
"name": "vue-zoom-out-idle",
"durationMs": 6452.339999999993,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6171.345000000002,
"heapDeltaBytes": 3470020,
"heapUsedBytes": 172281736,
"domNodes": -1520,
"jsHeapTotalBytes": 15728640,
"scriptDurationMs": 108.57399999999996,
"eventListeners": -7452,
"totalBlockingTimeMs": 0,
"frameDurationMs": 21.716161616161617,
"p95FrameDurationMs": 33.400000000001455
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8477.778000000057,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8228.454,
"heapDeltaBytes": -3104828,
"heapUsedBytes": 194391052,
"domNodes": -1520,
"jsHeapTotalBytes": 12845056,
"scriptDurationMs": 162.968,
"eventListeners": -7452,
"totalBlockingTimeMs": 0,
"frameDurationMs": 29.70666666666666,
"p95FrameDurationMs": 50.10000000000218
},
{
"name": "workflow-execution",
"durationMs": 500.7990000000291,
"styleRecalcs": 21,
"styleRecalcDurationMs": 18.533,
"layouts": 4,
"layoutDurationMs": 1.9390000000000003,
"taskDurationMs": 132.952,
"heapDeltaBytes": 6326168,
"heapUsedBytes": 97281460,
"domNodes": 129,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 14.472000000000001,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.665517241379316,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 472.70400000002155,
"styleRecalcs": 19,
"styleRecalcDurationMs": 15.394000000000002,
"layouts": 3,
"layoutDurationMs": 1.652,
"taskDurationMs": 125.68099999999998,
"heapDeltaBytes": 6177188,
"heapUsedBytes": 97083336,
"domNodes": 126,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 10.277,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.668965517241396,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 1033.7450000000672,
"styleRecalcs": 78,
"styleRecalcDurationMs": 116.27600000000001,
"layouts": 76,
"layoutDurationMs": 25.732000000000003,
"taskDurationMs": 1006.721,
"heapDeltaBytes": 19525392,
"heapUsedBytes": 90330956,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 418.956,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66612903225808,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-empty-conversation-typing",
"durationMs": 863.2369999999128,
"styleRecalcs": 78,
"styleRecalcDurationMs": 108.515,
"layouts": 76,
"layoutDurationMs": 21.678,
"taskDurationMs": 838.3009999999999,
"heapDeltaBytes": 17772884,
"heapUsedBytes": 87941564,
"domNodes": 76,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 338.69899999999996,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66792452830188,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1362.844999999993,
"styleRecalcs": 78,
"styleRecalcDurationMs": 238.12,
"layouts": 76,
"layoutDurationMs": 23.781,
"taskDurationMs": 1347.197,
"heapDeltaBytes": 8725464,
"heapUsedBytes": 152679364,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 463.374,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.298734177215195,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "agent-composer-long-conversation-typing",
"durationMs": 1389.3809999999576,
"styleRecalcs": 78,
"styleRecalcDurationMs": 243.09900000000002,
"layouts": 76,
"layoutDurationMs": 25.184,
"taskDurationMs": 1364.862,
"heapDeltaBytes": 8757560,
"heapUsedBytes": 152716028,
"domNodes": 76,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 460.146,
"eventListeners": 876,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.5,
"p95FrameDurationMs": 16.80000000000109
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## drjkl/depcruise-no-circular #19467 +/- ##
===============================================================
+ Coverage 84.93% 85.01% +0.07%
===============================================================
Files 2407 2372 -35
Lines 136081 133541 -2540
Branches 35252 34736 -516
===============================================================
- Hits 115587 113531 -2056
+ Misses 20026 19647 -379
+ Partials 468 363 -105
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 254 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Summary
Combines the 25 import-cycle PRs (#19088 through #19189) into one branch so the whole change can be reviewed and merged as a unit. Targets #19085 (the baseline check) so the diff is only the untangling. The small PRs stay open for per-cut review; this PR is the one to merge.
Eight of those PRs are now outside the stack: #19089, #19094, #19109, #19112, #19122, #19124, #19125 and #19127 were each rebuilt as one commit on current
mainand targetmainon their own. This branch still contains their original commits.Import cycles in
src/, measured withpnpm lint:cycles: 967 -> 211 cyclic modules, largest component 923 -> 149. Five components remain: litegraph (149), app (42), Subscription (9), Auth (8), load3d (3).Tracks FE-2769 / FE-3037. Narrative with the reasoning behind each cut: Linear doc "Import cycle untangling: the stack narrative" on FE-3037.
The seven patterns
Every cut was one of these, and each has one shape of fix.
ServerFeatureFlag,PositionConfig,MissingNodeType,TierKey,Bounds,MenuOption, the litegraphinterfaces.tssplit).register, and the composition root (main.ts,GraphView, the app shell) does the registering (sidebar tabs, bottom panel tabs, settings dialog, asset browser, extensions).appModeStoreempty-workflow dialog, mask editor menu item,dialogServicefeature dialogs).api.tstakes anApiAuthProviderinstalled frommain.ts; workspace credentials install the same way.useApp()inscripts/appInstance.tsis the seam belowscripts/app;settingStoreand$elbecome leaves.types/comfyand the workflow contracts become leaves of the runtime.scripts/widgets.ts,nodeDefStore,useAuthActions,executionStoreeach split along the responsibility line.Merge with #19085
#19085 merged 106 commits of
mainafter the stack forked. This branch merges that back in. Conflict resolutions worth a look:scripts/api.ts: keeps main's web-session branching (sessionMediaUrl,webSessionFetch) and routes the non-session branch through the stack'sauthProvider. Socket auth readsauthProvider.getAuthToken().serverFeatureFlag.ts: addsAGENT_IN_APP_EXPERIENCE, which main added to the pre-split enum.ComfyNodeDefImpl.ts: carries main'soutputTypesand searchable input/output type changes into the extracted class.planDuration.ts,teamSubscriptionCheckoutUtil.ts,agent/crdt/graphMutations.ts.TierKey,INodeInputSlot,ComposerAttachment, bareappinexecutionErrorStore); repointed.api.tsreadsuseAuthStoreitself, or that the socket opens synchronously off-cloud, now install the provider withinstallCloudApiAuth()and await the socket like the stack's other api tests.SubscribeButton.test.tsmocksuseBillingDialogs, which the button now calls..import-cycles-baseline.jsonregenerated;.fallow-baselines/dead-code.jsongains four pre-existing cycles fallow re-attributes to touched files. The 10 new edges all come from modules main added (graphIntents<->LGraph/LGraphNode/LLink,cloudWebSessionStore<->useSessionCookie<-> workspace stores).A second merge picked up #19085's next 22
maincommits (billing-web checkout, web-session comfy-api, agent consent):openHostedBillingTab.ts: main importsuseBillingContextanduseBillingCapabilitiesdirectly to pollreadCheckoutOperation()after a hosted checkout tab opens, which recreates the context -> workspace billing -> openHostedBillingTab cycle refactor: let billing rails announce refreshes instead of reading the context #19148 broke (main even documents the TDZ it causes). This branch keeps the inversion:billingRefresh.tsgainsonCheckoutOperationRead(reader)/readCheckoutOperation()next toonBillingRefresh/refreshBilling;useBillingContextregisters its reader andopenHostedBillingTabcalls the bus. Main's three-fetch return refresh staysrefreshBilling('account'), which the context anduseBillingCapabilitiesalready listen to. Main's operation-watch tests pass unchanged; the test registers its mock reader on the bus instead of mocking two modules.__mocks__/useBillingContext.ts: main addedrequireActiveSubscriptionandshowSubscriptionDialog, neither onBillingContexthere (dialogs moved touseBillingDialogs); onlyreadCheckoutOperationkept.useAgentConsent.test.tsauto-merged but two new tests still calleduseDialogService().showSignInDialog, which the stack split intouseAuthDialogs; renamed.Checks run on the merged tree:
pnpm typecheck,pnpm lint:cycles, oxlint and eslint on touched files (0 errors),pnpm test:unit.Stack
Import-cycle progress for FE-3037, measured with
pnpm lint:cycles(dependency-cruiser onsrc).Standalone PRs targeting
mainEach is one commit on current
mainand can merge on its own. Numbers are that PR alone againstorigin/main(1027 cyclic modules, largest cycle 983, 4562 cyclic edges).mainServerFeatureFlagenum to a leaf modulemainappModeStoremainComfy.MaskEditorextensionmainPositionConfigand layer editor dialog key to leaf modulesmainsettingStoreoffscripts/app;$elto a leafmainMissingNodeTypeto the nodeReplacement leafmainnodeDefStoremainAll eight together on
main, plus #19091, #19107, #19108, #19111, #19116 and #19113 (checked locally; those six are not retargeted yet): 630 cyclic modules, largest cycle 412, 2476 cyclic edges.Remaining stack
Bottom to top, with current bases. Numbers are from the original 26-PR stack, each PR against its parent at the time, on the older
mainthe stack forked from (967 cyclic modules then). They have not been remeasured since the eight PRs above left the stack. Where the base changed, the parent the numbers were measured on is in parentheses.#19091, #19107, #19111, #19113 and #19131 still carry the old commits of the PRs they were moved off (#19131 carries #19122, #19124, #19125 and #19127), so their GitHub diffs are wider than one PR until the stack is rebased.
mainpnpm lint:cycles)interfaces.tsinto leaf typessidebarTabStoreextensionServicescripts/widgets.tsregistry, types, helpersexecutionStoremain.tsmain.tsdialogServicescripts/appbehinduseApp()types/comfy,comfyWorkflow, dialog/workflow contracts as leavesopenManagerontouseManagerDialog, agent leaves