Skip to content

refactor: break the app import cycles (stack #19088 to #19189 combined) - #19467

Closed
DrJKL wants to merge 31 commits into
drjkl/depcruise-no-circularfrom
drjkl/import-cycles-stack
Closed

DrJKL wants to merge 31 commits into
drjkl/depcruise-no-circularfrom
drjkl/import-cycles-stack

Conversation

@DrJKL

@DrJKL DrJKL commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Combines the 25 import-cycle PRs (#19088 through #19189) into one branch so the whole change can be reviewed and merged as a unit. Targets #19085 (the baseline check) so the diff is only the untangling. The small PRs stay open for per-cut review; this PR is the one to merge.

Eight of those PRs are now outside the stack: #19089, #19094, #19109, #19112, #19122, #19124, #19125 and #19127 were each rebuilt as one commit on current main and target main on their own. This branch still contains their original commits.

Import cycles in src/, measured with pnpm lint:cycles: 967 -> 211 cyclic modules, largest component 923 -> 149. Five components remain: litegraph (149), app (42), Subscription (9), Auth (8), load3d (3).

Tracks FE-2769 / FE-3037. Narrative with the reasoning behind each cut: Linear doc "Import cycle untangling: the stack narrative" on FE-3037.

The seven patterns

Every cut was one of these, and each has one shape of fix.

  1. A shared type lives in a module that also imports the world. Move the declaration to a file with no imports and repoint importers (ServerFeatureFlag, PositionConfig, MissingNodeType, TierKey, Bounds, MenuOption, the litegraph interfaces.ts split).
  2. A registry imports its own registrants. The registry exposes register, and the composition root (main.ts, GraphView, the app shell) does the registering (sidebar tabs, bottom panel tabs, settings dialog, asset browser, extensions).
  3. A store does UI work. The dialog or menu item moves to the extension or component that owns it (appModeStore empty-workflow dialog, mask editor menu item, dialogService feature dialogs).
  4. Infrastructure reaches up into auth. api.ts takes an ApiAuthProvider installed from main.ts; workspace credentials install the same way.
  5. Everyone imports the app object. useApp() in scripts/appInstance.ts is the seam below scripts/app; settingStore and $el become leaves.
  6. Two layers reach into each other. Billing rails announce refreshes instead of reading the dialog context; types/comfy and the workflow contracts become leaves of the runtime.
  7. One module, two jobs. scripts/widgets.ts, nodeDefStore, useAuthActions, executionStore each split along the responsibility line.

Merge with #19085

#19085 merged 106 commits of main after the stack forked. This branch merges that back in. Conflict resolutions worth a look:

  • scripts/api.ts: keeps main's web-session branching (sessionMediaUrl, webSessionFetch) and routes the non-session branch through the stack's authProvider. Socket auth reads authProvider.getAuthToken().
  • serverFeatureFlag.ts: adds AGENT_IN_APP_EXPERIENCE, which main added to the pre-split enum.
  • ComfyNodeDefImpl.ts: carries main's outputTypes and searchable input/output type changes into the extracted class.
  • Deleted on main, only import paths changed here, deletion kept: planDuration.ts, teamSubscriptionCheckoutUtil.ts, agent/crdt/graphMutations.ts.
  • Five files main added still used pre-stack paths (TierKey, INodeInputSlot, ComposerAttachment, bare app in executionErrorStore); repointed.
  • Tests main added that assumed api.ts reads useAuthStore itself, or that the socket opens synchronously off-cloud, now install the provider with installCloudApiAuth() and await the socket like the stack's other api tests. SubscribeButton.test.ts mocks useBillingDialogs, which the button now calls.
  • .import-cycles-baseline.json regenerated; .fallow-baselines/dead-code.json gains four pre-existing cycles fallow re-attributes to touched files. The 10 new edges all come from modules main added (graphIntents <-> LGraph/LGraphNode/LLink, cloudWebSessionStore <-> useSessionCookie <-> workspace stores).

A second merge picked up #19085's next 22 main commits (billing-web checkout, web-session comfy-api, agent consent):

  • openHostedBillingTab.ts: main imports useBillingContext and useBillingCapabilities directly to poll readCheckoutOperation() after a hosted checkout tab opens, which recreates the context -> workspace billing -> openHostedBillingTab cycle refactor: let billing rails announce refreshes instead of reading the context #19148 broke (main even documents the TDZ it causes). This branch keeps the inversion: billingRefresh.ts gains onCheckoutOperationRead(reader) / readCheckoutOperation() next to onBillingRefresh / refreshBilling; useBillingContext registers its reader and openHostedBillingTab calls the bus. Main's three-fetch return refresh stays refreshBilling('account'), which the context and useBillingCapabilities already listen to. Main's operation-watch tests pass unchanged; the test registers its mock reader on the bus instead of mocking two modules.
  • __mocks__/useBillingContext.ts: main added requireActiveSubscription and showSubscriptionDialog, neither on BillingContext here (dialogs moved to useBillingDialogs); only readCheckoutOperation kept.
  • useAgentConsent.test.ts auto-merged but two new tests still called useDialogService().showSignInDialog, which the stack split into useAuthDialogs; renamed.

Checks run on the merged tree: pnpm typecheck, pnpm lint:cycles, oxlint and eslint on touched files (0 errors), pnpm test:unit.

Stack

Import-cycle progress for FE-3037, measured with pnpm lint:cycles (dependency-cruiser on src).

Standalone PRs targeting main

Each is one commit on current main and can merge on its own. Numbers are that PR alone against origin/main (1027 cyclic modules, largest cycle 983, 4562 cyclic edges).

PR Base Change Cyclic modules Largest cycle Cyclic edges
#19089 main ServerFeatureFlag enum to a leaf module 1027 -> 884 983 -> 677 4562 -> 3382
#19094 main Empty-workflow dialog out of appModeStore 1027 -> 1026 983 -> 982 4562 -> 4558
#19109 main Mask editor menu item into Comfy.MaskEditor extension 1027 -> 1027 983 -> 983 4562 -> 4562
#19112 main PositionConfig and layer editor dialog key to leaf modules 1027 -> 1027 983 -> 983 4562 -> 4558
#19122 main settingStore off scripts/app; $el to a leaf 1027 -> 1025 983 -> 981 4562 -> 4552
#19124 main MissingNodeType to the nodeReplacement leaf 1027 -> 1027 983 -> 983 4562 -> 4555
#19125 main Blueprint node defs owned by nodeDefStore 1027 -> 1027 983 -> 983 4562 -> 4561
#19127 main Thumbnail and minimap data from explicit inputs 1027 -> 1027 983 -> 983 4562 -> 4561

All eight together on main, plus #19091, #19107, #19108, #19111, #19116 and #19113 (checked locally; those six are not retargeted yet): 630 cyclic modules, largest cycle 412, 2476 cyclic edges.

Remaining stack

Bottom to top, with current bases. Numbers are from the original 26-PR stack, each PR against its parent at the time, on the older main the stack forked from (967 cyclic modules then). They have not been remeasured since the eight PRs above left the stack. Where the base changed, the parent the numbers were measured on is in parentheses.

#19091, #19107, #19111, #19113 and #19131 still carry the old commits of the PRs they were moved off (#19131 carries #19122, #19124, #19125 and #19127), so their GitHub diffs are wider than one PR until the stack is rebased.

PR Base Change Cyclic modules Largest cycle
#19085 main Import-cycle baseline check (pnpm lint:cycles) 967 (baseline) 923 (baseline)
#19088 #19085 Split litegraph interfaces.ts into leaf types 967 -> 949 923 -> 905
#19091 #19088 (measured on #19089) Register core sidebar tabs outside sidebarTabStore 816 -> 669 618 -> 465
#19092 #19091 Load extensions from bootstrap, not extensionService 669 -> 580 465 -> 371
#19093 #19092 Split scripts/widgets.ts registry, types, helpers 580 -> 566 371 -> 357
#19107 #19093 (measured on #19094) Register settings dialog from the app shell 558 -> 509 349 -> 297
#19108 #19107 Register asset browser modal from the app shell 509 -> 496 297 -> 284
#19111 #19108 (measured on #19109) Register core bottom panel tabs from GraphView 484 -> 476 272 -> 264
#19113 #19111 (measured on #19112) Model library asset-browser routing onto the sidebar tab 471 -> 467 257 -> 253
#19116 #19113 Progress text previews out of executionStore 467 -> 464 253 -> 250
#19118 #19116 Inject the api auth provider from main.ts 464 -> 447 250 -> 233
#19121 #19118 Install workspace api credentials from main.ts 447 -> 428 233 -> 214
#19131 #19121 (measured on #19127) Feature dialogs out of dialogService 400 -> 391 181 -> 172
#19143 #19131 Invert scripts/app behind useApp() 391 -> 352 172 -> 149
#19148 #19143 Billing rails announce refreshes; dialogs above the facade 352 -> 324 149 (baseline)
#19153 #19148 types/comfy, comfyWorkflow, dialog/workflow contracts as leaves 324 -> 293 149 (baseline)
#19186 #19153 Workbench cycles: openManager onto useManagerDialog, agent leaves 293 -> 259 149 (baseline)
#19189 #19186 Thirteen small app cycles: ui, nodeDef, auth dialogs, menu, and more 259 -> 211 149 (baseline)
this PR #19085 All 25 PRs in both tables, merged with #19085 967 -> 211 923 -> 149

ampagent and others added 29 commits September 27, 2026 08:36
interfaces.ts now imports only branded IDs and enums, so Rectangle, measure,
ConstrainedSize, LGraphBadge, LGraphButton, SlotBase and 15 app modules
(linkStore, rerouteStore, ...) leave the import-cycle SCC (923 -> 905).

Graph-bound contracts move to types/slots.ts, types/linkNetwork.ts,
types/contextMenu.ts, types/panel.ts; CreateNodeOptions to LiteGraphGlobal,
NewNodePosition/IBoundaryNodes to utils/arrange, Hoverable to types/events.
The litegraph barrel exports are unchanged.

Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
remoteConfig imported the enum type from useFeatureFlags, which imports
the API client, which imports the workflow schema, which imports LGraph.
That one edge bound reportError, telemetry, and every module they touch
into the same import cycle as litegraph.

The enum now lives in src/platform/remoteConfig/serverFeatureFlag.ts with
no imports. The Storybook mock's duplicated copy of the enum is deleted.

Cyclic modules 949 -> 816, largest cycle 905 -> 618. litegraph and its
entity stores now form their own 149-module cycle, separate from the app.

Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
sidebarTabStore imported the six core tab composables so it could
register them, pulling the node library, model library, queue, assets and
workflow UI trees into the same import cycle as the store that every one
of them reads.

registerCoreSidebarTabs() now lives in
src/composables/sidebarTabs/registerCoreSidebarTabs.ts and calls the
store; the store keeps register/unregister/toggle. GraphView.vue is the
only caller. Store tests that only exercised registration move with it.

Cyclic modules 816 -> 669, largest cycle 618 -> 465.

Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
extensionService imported extensions/core/index so loadExtensions could
pull the core extensions in. Every core extension imports app, which
imports extensionService, so the whole extensions/core tree and its UI
sat in the same import cycle as the app object.

loadExtensions and shouldLoadExtension move to
src/services/extensionLoader.ts. GraphCanvas.vue, which already owns the
bootstrap sequence and is outside the cycle, runs the extensions-load
phase right before app.setup(). app.setup() no longer loads extensions.

Ordering change: extensions now import before syncWorkflows() and
fetchSubgraphs() instead of after. Extension hooks (init, setup,
registerCustomNodes) still run inside app.setup() as before.

Cyclic modules 669 -> 580, largest cycle 465 -> 371.

Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
… of scripts/widgets

scripts/widgets.ts held three things: the ComfyWidgets registry, the widget
constructor types, and the control_after_generate helpers. Every widget
composable imported the V2 constructor type from it, which put all 22 of them
in the app import cycle through the registry's imports.

ComfyWidgetConstructorV2 moves to src/types/widgetConstructor.ts (depends only
on litegraph and schema types). addValueControlWidget(s),
updateControlWidgetLabel and their helpers move to
src/scripts/valueControlWidgets.ts. widgets.ts keeps the registry and the V1
types that reference ComfyApp. IS_CONTROL_WIDGET is imported from
controlWidgetMarker directly instead of re-exported.

useIntWidget/useFloatWidget tests now use the scripts/app manual mock; the
previous mock of scripts/widgets had also been hiding the registry from them.

Cyclic modules 580 -> 566, largest cycle 371 -> 357.

Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
…lder

appModeStore imported useEmptyWorkflowDialog so enterBuilder() could show a
dialog when the graph had no nodes. That pulled the dialog service, the
template selector dialog and their content components into the store's import
cycle. The store now enters the builder unconditionally; the UI-facing check
and dialog live in src/components/builder/useEnterBuilder.ts, which the three
entry points (workflow actions menu, app-mode toolbar, LinearWelcome) call.

The dialog tests move from appModeStore.test.ts to useEnterBuilder.test.ts.
useWorkflowActionsMenu.test.ts asserts against the composable instead of the
store action, since the real store reports no nodes under the test app mock.

Cyclic modules 566 -> 558, largest cycle 357 -> 349.

Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
useSettingsDialog imported SettingDialog.vue so it could open it, while
the settings subtree (billing stores, top-up dialogs, confirmation
content) imports useSettingsDialog to jump to a panel. That single edge
kept 52 modules of settings UI inside the main import cycle.

The composable now opens whichever component GraphView registers through
registerSettingDialogComponent(). SettingDialog.vue declares its props
with SettingDialogProps from platform/settings/types so the registration
stays typed without importing the component.

Cyclic modules 558 -> 509, largest cycle 349 -> 297.

Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
useAssetBrowserDialog imported AssetBrowserModal.vue, which pulls the asset
grid, model info panel, upload flow, and their stores into the main import
cycle. The composable now opens whatever component the app shell registers
through registerAssetBrowserModalComponent, and the modal's props interface
lives in a leaf type module both sides import.

Import cycles: 509 -> 496 cyclic modules, largest SCC 297 -> 284.

Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
…sion

litegraphService imported useMaskEditor only to push the
"Open in MaskEditor | Image Canvas" context menu item, pulling the
whole mask editor UI into the services cycle. The Comfy.MaskEditor
extension already owns useMaskEditor, so it now contributes the item
through getNodeMenuItems with the same clipspace and image-node guards
and the same 'preview' media-action marking.

Import cycles: 496 -> 484 cyclic modules, largest SCC 284 -> 272.

Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
bottomPanelStore imported the shortcuts and terminal tab composables
only to register the core tabs, which pulled the bottom panel tab
components into the stores import cycle. The registration now lives
in composables/bottomPanelTabs/registerCoreBottomPanelTabs, mirroring
registerCoreSidebarTabs, and GraphView calls it at startup.

Import cycles: 484 -> 476 cyclic modules, largest SCC 272 -> 264.

Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
…f modules

domWidgetStore imported useAbsolutePosition only for the PositionConfig
type, and changeTracker imported layerEditorDialog only for its dialog
key. Both imports dragged UI composables into the stores and scripts
import cycle. PositionConfig now lives in types/positionConfig and
LAYER_EDITOR_DIALOG_KEY in renderer/extensions/layerEditor/layerEditorDialogKey.

Import cycles: 476 -> 471 cyclic modules, largest SCC 264 -> 257.

Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
sidebarTabStore special-cased the model-library tab id to open the asset
browser instead of the sidebar, importing openModelLibraryBrowser and the
feature flag and setting stores for one tab. SidebarTabExtension gains an
optional onToggle hook; the toggle command defers to it and the model
library tab owns the asset browser routing.

Import cycles: 471 -> 467 cyclic modules, largest SCC 257 -> 253.

Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
executionStore drove the node text preview widget directly: it handled the
progress_text socket event and removed leftover widgets when a job reset,
importing useNodeProgressText and canvasStore for it. The store now only
emits onJobReset with the finished job. useProgressTextPreviews, mounted
from GraphView, listens to progress_text and onJobReset and owns the widget
calls.

Import cycles: 467 -> 464 cyclic modules, largest SCC 253 -> 250.

Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
ComfyApi lazily imported authStore for the Firebase header and WebSocket
token and imported remintRetry for the 401 re-mint fetch, pulling the cloud
auth graph back into the most imported module in src. The client now takes
an ApiAuthProvider (leaf interface plus an anonymous default); the cloud
provider carries the moved logic and main.ts installs it before any request.

Import cycles: 464 -> 447 cyclic modules, largest SCC 250 -> 233.

Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
workspaceApi imported authStore for its request headers and remintRetry to
attach the 401 re-mint interceptor at module load, tying the workspace
billing and capability modules into the auth cycle. The client now exposes
setWorkspaceApiAuth; installWorkspaceApiAuth wires the auth store and the
interceptor and main.ts calls it before any request.

Import cycles: 447 -> 428 cyclic modules, largest SCC 233 -> 214.

Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
`settingStore` reached back into `scripts/app` to replay every change on the
legacy `ComfySettingsDialog` event target, and owned `SettingTreeNode`, a
settings-dialog UI type that pulled `treeExplorerTypes` into the store.

The store now exposes `onSettingChanged` (vueuse event hook, same shape as
`executionStore.onJobReset`) and GraphCanvas bridges it to
`app.ui.settings.dispatchChange` before core settings register, so extensions
still observe `<id>.change` at the same point. `SettingTreeNode` moves next to
the composables that build and search the settings tree.

`$el` moves from `scripts/ui.ts` to the `scripts/ui/utils.ts` leaf; `ui.ts`
keeps exporting it for the `scripts/ui.js` shim. Without the settingStore
shortcut into `app`, a test that reached `scripts/utils -> ui` before `app`
evaluated `new ComfyApp()` while `ComfyUI` was still uninitialised.

Import cycles: 428 -> 417 cyclic modules, largest SCC 214 -> 203.

Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
`src/types/comfy.ts` sits in the app cycle through the litegraph barrel and
`ComfyExtension`, so every importer of `MissingNodeType` (missing-node scan,
error catalog, right-side-panel error groups, telemetry grouping) joined the
cycle for one type alias. The alias already referenced `NodeReplacement`
from the nodeReplacement leaf; it now lives next to it and importers read it
from there. `comfy.ts` keeps using it for the `ComfyExtension` hooks.

Import cycles: 417 -> 411 cyclic modules, largest SCC 203 -> 197.

Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
`nodeDefStore.nodeDefs` prepended `subgraphStore.subgraphBlueprints`, so the
node-def registry depended on the subgraph store, which in turn depends on
the workflow store, dialog service, canvas store and the rest of the app
cycle. The blueprint node defs are node defs; `nodeDefStore` now owns the
`blueprintNodeDefsByName` map and `subgraphStore` registers and removes
entries in it. `subgraphStore.subgraphBlueprints` is derived from that map,
so its callers are unchanged.

Import cycles: 411 -> 403 cyclic modules, largest SCC 197 -> 184.
`createGraphThumbnail` and `useWorkflowThumbnail.storeThumbnail` take the
graph to render instead of reading it from workflowStore/canvasStore;
workflowService passes the active subgraph or root graph at the call site.
`MinimapDataSource` receives node progress states through
`MinimapRenderContext` instead of reading executionStore, so the live minimap
keeps its execution colors and the thumbnail renderer has no store imports.

Import cycles: 403 -> 400 cyclic modules, largest SCC 184 -> 181.
`dialogService` bundled the core prompt/confirm/error dialogs with every
auth, billing, workspace, cloud-notification and ComfyHub dialog, so the
core service pulled the whole platform layer into the app SCC and every
consumer of `confirm()` transitively imported billing.

The core service keeps `showExecutionErrorDialog`, `showErrorDialog`,
`prompt`, `confirm`, `showExtensionDialog`, `showLayoutDialog` and
`showSmallLayoutDialog`. Feature dialogs move verbatim into
`useAuthDialogs`, `useBillingDialogs`, `useWorkspaceDialogs`,
`useCloudNotificationDialog` and `useComfyHubPublishDialog.showPublishDialog`;
callers import the composable they need.

Extensions still reach every dialog through `app.extensionManager.dialog`.
`ExtensionDialogService` declares that surface with leaf types only;
`createExtensionDialogService()` assembles it and `App.vue` registers it
before the workspace store is created, so `workspaceStore` no longer imports
the feature composables directly (that variant kept the SCC at 185).

`ConfirmationDialogType` moves to a leaf module and `useSettingsDialog`
calls `dialogStore.showDialog` directly instead of `showLayoutDialog`.
Billing dialog tests move next to `useBillingDialogs`; a new
`__mocks__` per feature composable replaces the monolithic dialogService
mock in the affected tests.

Import cycles: 400 -> 391 cyclic modules, largest SCC 181 -> 172.

Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
Modules that sit underneath `scripts/app.ts` in the import graph no longer
import the `app` value from it. They call `useApp()` from
`scripts/appInstance`, which reads a registry that `app.ts` fills once the
`ComfyApp` instance exists. Type-only consumers import the new `ComfyApp`
interface from `types/comfy`, and clipspace state moves to
`scripts/clipspace` with the `ComfyApp` statics kept as accessors.

Import cycles: 391 -> 352 cyclic modules, largest SCC 172 -> 149.

Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
… context

The SDK store, operation store, and hosted-tab opener settled a billing
mutation by calling `useBillingContext()` and `useBillingCapabilities()`
to refetch, which put the readers of billing state underneath the rails
that feed them. They now call `refreshBilling(scope)` from the new leaf
`platform/workspace/billing/billingRefresh`, and the context and
capabilities composables register as listeners for their own scope.

`showSubscriptionDialog` and `requireActiveSubscription` leave the
`BillingActions` facade; callers open the paywall through
`useBillingDialogs().showSubscriptionRequiredDialog`. The subscription
guard on `purchaseCreditsDirect` moves from `useAuthActions` to its two
callers so auth actions no longer read the billing context.

Import cycles: 352 -> 324 cyclic modules, largest SCC 149 -> 149.

Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
The public extension contract in types/comfy.ts no longer reaches
scripts/appInstance. Widget constructor types move into types/comfy,
MissingModelPipelineResult into platform/missingModel/types, and the
legacy menu (scripts/ui.ts) takes its app and host collaborators as
constructor arguments. comfyWorkflow.ts becomes a leaf: the change
tracker, draft persistence, and settings are registered by the workflow
store through a WorkflowRuntime, and the save-as name prompt moves to
workflowService with the copy supplied as i18n keys. WorkflowStore and
the dialog service contracts are declared in new leaf modules so
extensionTypes.ts stops importing the stores.

Import cycles: 324 -> 293 cyclic modules, largest SCC 149 -> 149.

Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
Manager: `useManagerState` keeps only the UI-state derivations and the
once-per-session upgrade toast; `openManager` moves to `useManagerDialog`,
which already owns showing the dialog. Callers open the manager through
`useManagerDialog().openManager`. This removes the
useManagerState -> useManagerDialog -> ManagerDialog.vue back-edge that made
the 28 manager modules one cycle.

Agent: `ComposerAttachment` lives in `types/composerPrompt.ts` instead of
`useComposer.ts`, and the CRDT follower's `AgentCrdtStatus` and outcome
counters live in a new `crdt/agentCrdtStatus.ts` leaf so `crdtSnapshot` does
not depend on the composable.

Import cycles: 293 -> 259 cyclic modules, 21 -> 18 cycles, largest SCC 149 -> 149.

Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
Import cycles: 259 -> 211 cyclic modules, 18 -> 5 cycles, largest SCC 149 -> 149.

Breaks 13 small strongly connected components outside litegraph and the
42-module app core by extracting leaf modules and inverting dependencies:

- scripts/ui: `LegacyUIApp` interface typed on ComfyUI/ComfyList; the
  unused `app` field/ctor param dropped from ComfySettingsDialog and
  ComfyAppMenu; button.ts and applyTextReplacements take narrow shapes.
- telemetry: `TierKey`/`BillingCycle` moved to a leaf
  `platform/cloud/subscription/constants/tierKey.ts`.
- nodeDef: `ComfyNodeDefImpl` moved to `core/graph/nodeDef/ComfyNodeDefImpl.ts`;
  `NodeLibrarySection` moved to nodeOrganizationTypes; `useNodeFrequencyStore`
  split into its own leaf store and `topNodeDefs` moved onto useNodeDefStore.
- QuadTree: `Bounds` moved to `types/spatialIndex.ts`.
- settings: `ServerConfigValue` moved to `platform/settings/types.ts`.
- domWidget: widget interfaces moved to `types/domWidget.ts`.
- maskEditor: `useCanvasHistory` takes its layers as an argument.
- widgetInputs: `nodeTypeGuards.ts` removed; `isPrimitiveNode` made private.
- searchbox: `FilterChip` moved to `components/searchbox/v2/filterChip.ts`;
  searchBoxStore declares a local `SearchBoxPopover` interface.
- keybinding: dialog state moved to `editKeybindingDialogState.ts`.
- auth dialogs: `updatePassword` moved to `useUpdatePassword(requestSignIn)`;
  UpdatePasswordContent takes a `requestSignIn` prop.
- menu: `MenuOption`/`SubMenuOption`/`BadgeVariant` moved to
  `composables/graph/menuOption.ts`.
- billingOperationStore: `pollPendingOperations` no longer exposed.

Deferred: Subscription (9), Auth (8), load3d (3), app (42), litegraph (149).
Amp-Thread-ID: https://ampcode.com/threads/T-01a0dcdd-4461-71d3-be73-0705e36d5297
@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Team

Run ID: 2799258b-73ec-4d0c-a78f-2a64a93864d4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

🌾 Fallow: ✅ Passed

Fallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened.

Fallow gates on new findings in changed files only, so everything below was introduced or moved by this PR (575 changed files).

Kind Finding Where Usual remedy
Complexity <arrow>() — cyclomatic 29, CRAP 210.7 src/composables/usePaste.ts:202 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.
Complexity addInputWidget() — cyclomatic 23, CRAP 137.3 src/services/litegraphService.ts:286 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.
Complexity navigateToHash() — cyclomatic 20, CRAP 106.4 src/stores/subgraphNavigationStore.ts:292 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.
Complexity <template>() — cyclomatic 16, CRAP undefined src/components/cameraInfo/CameraInfo.vue:12 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.
Complexity <template>() — cyclomatic 12, CRAP undefined src/components/actionbar/PartnerNodesEducationCard.vue:12 Extract a branch, or raise branch coverage — CRAP is CC² × (1−cov)³ + CC, so either moves it.

Pre-existing findings are baselined in .fallow-baselines/ and are not your
responsibility — see ADR-DEVEX-LINT-0015.

Reproduce locally
# the base the gate compared against
npx fallow audit --root . --quiet --format json \
  --changed-since 7bd1e8b0c046f589b0a14627399326669c8d6d08

Full docs: ADR-DEVEX-LINT-0015

🎨 Storybook: ✅ Built — View Storybook

Details

⏰ Completed at: 09/29/2026, 09:20:55 PM UTC

Links

🎭 Playwright: ✅ 2158 passed, 0 failed · 1 flaky

📊 Browser Reports
  • chromium: View Report (✅ 2137 / ❌ 0 / ⚠️ 1 / ⏭️ 9)
  • chromium-2x: View Report (✅ 2 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • chromium-0.5x: View Report (✅ 1 / ❌ 0 / ⚠️ 0 / ⏭️ 0)
  • mobile-chrome: View Report (✅ 18 / ❌ 0 / ⚠️ 0 / ⏭️ 0)

📦 Bundle Size

⏳ Size data collection in progress…

⚡ Performance Report

canvas-idle: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.0 MB heap
canvas-mouse-sweep: · 59.5 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.4 MB heap
canvas-zoom-sweep: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 99.4 MB heap
dom-widget-clipping: · 59.3 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 87.7 MB heap
dom-widget-order-dense-n200-w200-i120: · 28.3 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 556ms TBT · 87.6 MB heap
dom-widget-order-sparse-n1000-w20-i120: · 39.2 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 235ms TBT · 64.0 MB heap
extension-clean-combined-draw: · 29.0 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 1279ms TBT · 81.3 MB heap
extension-rgthree-prototype-draw: · 30.8 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 1459ms TBT · 82.0 MB heap
large-graph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.9 MB heap
large-graph-pan: · 59.8 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.5 MB heap
large-graph-zoom: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 78.7 MB heap
legacy-node-drag: · 59.7 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 79.7 MB heap
minimap-idle: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 60.2 MB heap
subgraph-dom-widget-clipping: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 84.9 MB heap
subgraph-idle: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 62.6 MB heap
subgraph-mouse-sweep: · 60.0 avg FPS · 59.9 P5 FPS ✅ (target: ≥52) · 0ms TBT · 61.5 MB heap
subgraph-transition-enter: · 51.6 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 149ms TBT · 99.4 MB heap
viewport-pan-sweep: · 59.9 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.2 MB heap
vue-large-graph-idle: · 33.1 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 159.9 MB heap
vue-large-graph-pan: · 30.0 avg FPS · 13.3 P5 FPS ❌ (target: ≥52) · 88ms TBT · 160.6 MB heap
vue-node-resize-workload: · 27.8 avg FPS · 15.0 P5 FPS ❌ (target: ≥52) · 434ms TBT · 176.1 MB heap
vue-zoom-out-idle: · 38.9 avg FPS · 24.0 P5 FPS ❌ (target: ≥52) · 0ms TBT · 174.8 MB heap
workflow-execution: · 60.0 avg FPS · 59.7 P5 FPS ✅ (target: ≥52) · 0ms TBT · 92.7 MB heap
agent-composer-empty-conversation-typing: · 60.0 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 85.0 MB heap
agent-composer-long-conversation-typing: · 57.5 avg FPS · 59.5 P5 FPS ✅ (target: ≥52) · 0ms TBT · 145.6 MB heap

ℹ️ No baseline found — significance unavailable.

Absolute values
Metric Value
canvas-idle: avg frame time 17ms
canvas-idle: p95 frame time 17ms
canvas-idle: layout duration 0ms
canvas-idle: style recalc duration 3ms
canvas-idle: layout count 0
canvas-idle: style recalc count 11
canvas-idle: task duration 380ms
canvas-idle: script duration 10ms
canvas-idle: TBT 0ms
canvas-idle: heap used 60.0 MB
canvas-idle: DOM nodes -232
canvas-idle: event listeners -137
canvas-mouse-sweep: avg frame time 17ms
canvas-mouse-sweep: p95 frame time 17ms
canvas-mouse-sweep: layout duration 5ms
canvas-mouse-sweep: style recalc duration 19ms
canvas-mouse-sweep: layout count 12
canvas-mouse-sweep: style recalc count 81
canvas-mouse-sweep: task duration 925ms
canvas-mouse-sweep: script duration 175ms
canvas-mouse-sweep: TBT 0ms
canvas-mouse-sweep: heap used 62.4 MB
canvas-mouse-sweep: DOM nodes -218
canvas-mouse-sweep: event listeners -137
canvas-zoom-sweep: avg frame time 17ms
canvas-zoom-sweep: p95 frame time 17ms
canvas-zoom-sweep: layout duration 1ms
canvas-zoom-sweep: style recalc duration 9ms
canvas-zoom-sweep: layout count 6
canvas-zoom-sweep: style recalc count 32
canvas-zoom-sweep: task duration 323ms
canvas-zoom-sweep: script duration 12ms
canvas-zoom-sweep: TBT 0ms
canvas-zoom-sweep: heap used 99.4 MB
canvas-zoom-sweep: DOM nodes 53
canvas-zoom-sweep: event listeners 15
dom-widget-clipping: avg frame time 17ms
dom-widget-clipping: p95 frame time 17ms
dom-widget-clipping: layout duration 0ms
dom-widget-clipping: style recalc duration 3ms
dom-widget-clipping: layout count 0
dom-widget-clipping: style recalc count 12
dom-widget-clipping: task duration 494ms
dom-widget-clipping: script duration 176ms
dom-widget-clipping: TBT 0ms
dom-widget-clipping: heap used 87.7 MB
dom-widget-clipping: DOM nodes 0
dom-widget-clipping: event listeners 0
dom-widget-order-dense-n200-w200-i120: avg frame time 35ms
dom-widget-order-dense-n200-w200-i120: p95 frame time 17ms
dom-widget-order-dense-n200-w200-i120: layout duration 0ms
dom-widget-order-dense-n200-w200-i120: style recalc duration 0ms
dom-widget-order-dense-n200-w200-i120: layout count 0
dom-widget-order-dense-n200-w200-i120: style recalc count 0
dom-widget-order-dense-n200-w200-i120: task duration 825ms
dom-widget-order-dense-n200-w200-i120: script duration 66ms
dom-widget-order-dense-n200-w200-i120: TBT 556ms
dom-widget-order-dense-n200-w200-i120: heap used 87.6 MB
dom-widget-order-dense-n200-w200-i120: DOM nodes 0
dom-widget-order-dense-n200-w200-i120: event listeners 0
dom-widget-order-sparse-n1000-w20-i120: avg frame time 25ms
dom-widget-order-sparse-n1000-w20-i120: p95 frame time 17ms
dom-widget-order-sparse-n1000-w20-i120: layout duration 0ms
dom-widget-order-sparse-n1000-w20-i120: style recalc duration 0ms
dom-widget-order-sparse-n1000-w20-i120: layout count 0
dom-widget-order-sparse-n1000-w20-i120: style recalc count 0
dom-widget-order-sparse-n1000-w20-i120: task duration 478ms
dom-widget-order-sparse-n1000-w20-i120: script duration 172ms
dom-widget-order-sparse-n1000-w20-i120: TBT 235ms
dom-widget-order-sparse-n1000-w20-i120: heap used 64.0 MB
dom-widget-order-sparse-n1000-w20-i120: DOM nodes 0
dom-widget-order-sparse-n1000-w20-i120: event listeners 0
extension-clean-combined-draw: avg frame time 34ms
extension-clean-combined-draw: p95 frame time 67ms
extension-clean-combined-draw: layout duration 0ms
extension-clean-combined-draw: style recalc duration 0ms
extension-clean-combined-draw: layout count 0
extension-clean-combined-draw: style recalc count 0
extension-clean-combined-draw: task duration 9097ms
extension-clean-combined-draw: script duration 7669ms
extension-clean-combined-draw: TBT 1279ms
extension-clean-combined-draw: heap used 81.3 MB
extension-clean-combined-draw: DOM nodes 0
extension-clean-combined-draw: event listeners 0
extension-rgthree-prototype-draw: avg frame time 32ms
extension-rgthree-prototype-draw: p95 frame time 67ms
extension-rgthree-prototype-draw: layout duration 0ms
extension-rgthree-prototype-draw: style recalc duration 0ms
extension-rgthree-prototype-draw: layout count 0
extension-rgthree-prototype-draw: style recalc count 0
extension-rgthree-prototype-draw: task duration 10181ms
extension-rgthree-prototype-draw: script duration 8394ms
extension-rgthree-prototype-draw: TBT 1459ms
extension-rgthree-prototype-draw: heap used 82.0 MB
extension-rgthree-prototype-draw: DOM nodes 0
extension-rgthree-prototype-draw: event listeners 0
large-graph-idle: avg frame time 17ms
large-graph-idle: p95 frame time 17ms
large-graph-idle: layout duration 0ms
large-graph-idle: style recalc duration 2ms
large-graph-idle: layout count 0
large-graph-idle: style recalc count 6
large-graph-idle: task duration 471ms
large-graph-idle: script duration 37ms
large-graph-idle: TBT 0ms
large-graph-idle: heap used 84.9 MB
large-graph-idle: DOM nodes -232
large-graph-idle: event listeners -137
large-graph-pan: avg frame time 17ms
large-graph-pan: p95 frame time 17ms
large-graph-pan: layout duration 0ms
large-graph-pan: style recalc duration 9ms
large-graph-pan: layout count 0
large-graph-pan: style recalc count 65
large-graph-pan: task duration 1677ms
large-graph-pan: script duration 893ms
large-graph-pan: TBT 0ms
large-graph-pan: heap used 61.5 MB
large-graph-pan: DOM nodes 0
large-graph-pan: event listeners 0
large-graph-zoom: avg frame time 17ms
large-graph-zoom: p95 frame time 17ms
large-graph-zoom: layout duration 14ms
large-graph-zoom: style recalc duration 10ms
large-graph-zoom: layout count 60
large-graph-zoom: style recalc count 62
large-graph-zoom: task duration 1716ms
large-graph-zoom: script duration 819ms
large-graph-zoom: TBT 0ms
large-graph-zoom: heap used 78.7 MB
large-graph-zoom: DOM nodes 0
large-graph-zoom: event listeners 0
legacy-node-drag: avg frame time 17ms
legacy-node-drag: p95 frame time 17ms
legacy-node-drag: layout duration 0ms
legacy-node-drag: style recalc duration 6ms
legacy-node-drag: layout count 0
legacy-node-drag: style recalc count 42
legacy-node-drag: task duration 1858ms
legacy-node-drag: script duration 1023ms
legacy-node-drag: TBT 0ms
legacy-node-drag: heap used 79.7 MB
legacy-node-drag: DOM nodes 0
legacy-node-drag: event listeners 180
minimap-idle: avg frame time 17ms
minimap-idle: p95 frame time 17ms
minimap-idle: layout duration 0ms
minimap-idle: style recalc duration 1ms
minimap-idle: layout count 0
minimap-idle: style recalc count 4
minimap-idle: task duration 557ms
minimap-idle: script duration 37ms
minimap-idle: TBT 0ms
minimap-idle: heap used 60.2 MB
minimap-idle: DOM nodes 0
minimap-idle: event listeners 0
subgraph-dom-widget-clipping: avg frame time 17ms
subgraph-dom-widget-clipping: p95 frame time 17ms
subgraph-dom-widget-clipping: layout duration 0ms
subgraph-dom-widget-clipping: style recalc duration 5ms
subgraph-dom-widget-clipping: layout count 0
subgraph-dom-widget-clipping: style recalc count 46
subgraph-dom-widget-clipping: task duration 401ms
subgraph-dom-widget-clipping: script duration 147ms
subgraph-dom-widget-clipping: TBT 0ms
subgraph-dom-widget-clipping: heap used 84.9 MB
subgraph-dom-widget-clipping: DOM nodes 0
subgraph-dom-widget-clipping: event listeners 6
subgraph-idle: avg frame time 17ms
subgraph-idle: p95 frame time 17ms
subgraph-idle: layout duration 0ms
subgraph-idle: style recalc duration 2ms
subgraph-idle: layout count 0
subgraph-idle: style recalc count 9
subgraph-idle: task duration 422ms
subgraph-idle: script duration 8ms
subgraph-idle: TBT 0ms
subgraph-idle: heap used 62.6 MB
subgraph-idle: DOM nodes -248
subgraph-idle: event listeners -183
subgraph-mouse-sweep: avg frame time 17ms
subgraph-mouse-sweep: p95 frame time 17ms
subgraph-mouse-sweep: layout duration 6ms
subgraph-mouse-sweep: style recalc duration 19ms
subgraph-mouse-sweep: layout count 16
subgraph-mouse-sweep: style recalc count 79
subgraph-mouse-sweep: task duration 877ms
subgraph-mouse-sweep: script duration 119ms
subgraph-mouse-sweep: TBT 0ms
subgraph-mouse-sweep: heap used 61.5 MB
subgraph-mouse-sweep: DOM nodes -248
subgraph-mouse-sweep: event listeners -183
subgraph-transition-enter: avg frame time 19ms
subgraph-transition-enter: p95 frame time 17ms
subgraph-transition-enter: layout duration 13ms
subgraph-transition-enter: style recalc duration 30ms
subgraph-transition-enter: layout count 5
subgraph-transition-enter: style recalc count 18
subgraph-transition-enter: task duration 923ms
subgraph-transition-enter: script duration 30ms
subgraph-transition-enter: TBT 149ms
subgraph-transition-enter: heap used 99.4 MB
subgraph-transition-enter: DOM nodes 13667
subgraph-transition-enter: event listeners 2383
viewport-pan-sweep: avg frame time 17ms
viewport-pan-sweep: p95 frame time 17ms
viewport-pan-sweep: layout duration 0ms
viewport-pan-sweep: style recalc duration 32ms
viewport-pan-sweep: layout count 0
viewport-pan-sweep: style recalc count 248
viewport-pan-sweep: task duration 5449ms
viewport-pan-sweep: script duration 2845ms
viewport-pan-sweep: TBT 0ms
viewport-pan-sweep: heap used 85.2 MB
viewport-pan-sweep: DOM nodes -232
viewport-pan-sweep: event listeners -137
vue-large-graph-idle: avg frame time 30ms
vue-large-graph-idle: p95 frame time 67ms
vue-large-graph-idle: layout duration 0ms
vue-large-graph-idle: style recalc duration 0ms
vue-large-graph-idle: layout count 0
vue-large-graph-idle: style recalc count 0
vue-large-graph-idle: task duration 16709ms
vue-large-graph-idle: script duration 282ms
vue-large-graph-idle: TBT 0ms
vue-large-graph-idle: heap used 159.9 MB
vue-large-graph-idle: DOM nodes -1520
vue-large-graph-idle: event listeners -7452
vue-large-graph-pan: avg frame time 33ms
vue-large-graph-pan: p95 frame time 75ms
vue-large-graph-pan: layout duration 0ms
vue-large-graph-pan: style recalc duration 15ms
vue-large-graph-pan: layout count 0
vue-large-graph-pan: style recalc count 127
vue-large-graph-pan: task duration 17908ms
vue-large-graph-pan: script duration 881ms
vue-large-graph-pan: TBT 88ms
vue-large-graph-pan: heap used 160.6 MB
vue-large-graph-pan: DOM nodes -1520
vue-large-graph-pan: event listeners -7452
vue-node-resize-workload: avg frame time 36ms
vue-node-resize-workload: p95 frame time 67ms
vue-node-resize-workload: layout duration 23ms
vue-node-resize-workload: style recalc duration 80ms
vue-node-resize-workload: layout count 20
vue-node-resize-workload: style recalc count 20
vue-node-resize-workload: task duration 5996ms
vue-node-resize-workload: script duration 109ms
vue-node-resize-workload: TBT 434ms
vue-node-resize-workload: heap used 176.1 MB
vue-node-resize-workload: DOM nodes 0
vue-node-resize-workload: event listeners 0
vue-zoom-out-idle: avg frame time 26ms
vue-zoom-out-idle: p95 frame time 42ms
vue-zoom-out-idle: layout duration 0ms
vue-zoom-out-idle: style recalc duration 0ms
vue-zoom-out-idle: layout count 0
vue-zoom-out-idle: style recalc count 0
vue-zoom-out-idle: task duration 7200ms
vue-zoom-out-idle: script duration 136ms
vue-zoom-out-idle: TBT 0ms
vue-zoom-out-idle: heap used 174.8 MB
vue-zoom-out-idle: DOM nodes -1520
vue-zoom-out-idle: event listeners -7452
workflow-execution: avg frame time 17ms
workflow-execution: p95 frame time 17ms
workflow-execution: layout duration 2ms
workflow-execution: style recalc duration 17ms
workflow-execution: layout count 4
workflow-execution: style recalc count 20
workflow-execution: task duration 129ms
workflow-execution: script duration 12ms
workflow-execution: TBT 0ms
workflow-execution: heap used 92.7 MB
workflow-execution: DOM nodes 128
workflow-execution: event listeners 81
agent-composer-empty-conversation-typing: avg frame time 17ms
agent-composer-empty-conversation-typing: p95 frame time 17ms
agent-composer-empty-conversation-typing: layout duration 24ms
agent-composer-empty-conversation-typing: style recalc duration 112ms
agent-composer-empty-conversation-typing: layout count 76
agent-composer-empty-conversation-typing: style recalc count 78
agent-composer-empty-conversation-typing: task duration 923ms
agent-composer-empty-conversation-typing: script duration 379ms
agent-composer-empty-conversation-typing: TBT 0ms
agent-composer-empty-conversation-typing: heap used 85.0 MB
agent-composer-empty-conversation-typing: DOM nodes 76
agent-composer-empty-conversation-typing: event listeners 876
agent-composer-long-conversation-typing: avg frame time 17ms
agent-composer-long-conversation-typing: p95 frame time 17ms
agent-composer-long-conversation-typing: layout duration 24ms
agent-composer-long-conversation-typing: style recalc duration 241ms
agent-composer-long-conversation-typing: layout count 76
agent-composer-long-conversation-typing: style recalc count 78
agent-composer-long-conversation-typing: task duration 1356ms
agent-composer-long-conversation-typing: script duration 462ms
agent-composer-long-conversation-typing: TBT 0ms
agent-composer-long-conversation-typing: heap used 145.6 MB
agent-composer-long-conversation-typing: DOM nodes 76
agent-composer-long-conversation-typing: event listeners 876
Raw data
{
  "timestamp": "2026-09-29T21:26:20.382Z",
  "gitSha": "8d2ad4703628a0029b294ddc0a9aef6be1884cc6",
  "branch": "drjkl/import-cycles-stack",
  "measurements": [
    {
      "name": "canvas-idle",
      "durationMs": 2008.3869999999706,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 3.501,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 386.581,
      "heapDeltaBytes": -29260632,
      "heapUsedBytes": 63536552,
      "domNodes": -232,
      "jsHeapTotalBytes": 3145728,
      "scriptDurationMs": 10.450000000000001,
      "eventListeners": -137,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479335,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-idle",
      "durationMs": 2023.5460000000103,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 3.1860000000000004,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 372.79699999999997,
      "heapDeltaBytes": -30776932,
      "heapUsedBytes": 62202796,
      "domNodes": -232,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 9.309000000000001,
      "eventListeners": -137,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198346,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1989.3660000000182,
      "styleRecalcs": 85,
      "styleRecalcDurationMs": 19.185000000000002,
      "layouts": 12,
      "layoutDurationMs": 5.082000000000001,
      "taskDurationMs": 973.7099999999999,
      "heapDeltaBytes": -31675880,
      "heapUsedBytes": 61205088,
      "domNodes": -232,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 179.424,
      "eventListeners": -137,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.80762711864407,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-mouse-sweep",
      "durationMs": 1850.4950000000235,
      "styleRecalcs": 76,
      "styleRecalcDurationMs": 17.840999999999998,
      "layouts": 12,
      "layoutDurationMs": 4.251,
      "taskDurationMs": 876.6229999999999,
      "heapDeltaBytes": -23089048,
      "heapUsedBytes": 69642720,
      "domNodes": -203,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 171.529,
      "eventListeners": -137,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.818181818181817,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1742.1370000000138,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 9.198000000000002,
      "layouts": 6,
      "layoutDurationMs": 1.115,
      "taskDurationMs": 282.785,
      "heapDeltaBytes": 11369580,
      "heapUsedBytes": 104292184,
      "domNodes": 53,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 12.103,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66571428571429,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "canvas-zoom-sweep",
      "durationMs": 1742.30799999998,
      "styleRecalcs": 32,
      "styleRecalcDurationMs": 9.177000000000001,
      "layouts": 6,
      "layoutDurationMs": 1.1260000000000001,
      "taskDurationMs": 362.79100000000005,
      "heapDeltaBytes": 11391228,
      "heapUsedBytes": 104251988,
      "domNodes": 53,
      "jsHeapTotalBytes": 6291456,
      "scriptDurationMs": 12.341999999999999,
      "eventListeners": 15,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665714285714284,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 747.3029999999881,
      "styleRecalcs": 12,
      "styleRecalcDurationMs": 3.142999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 495.827,
      "heapDeltaBytes": -674976,
      "heapUsedBytes": 92185244,
      "domNodes": 0,
      "jsHeapTotalBytes": 7077888,
      "scriptDurationMs": 174.69799999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-clipping",
      "durationMs": 747.8820000000042,
      "styleRecalcs": 11,
      "styleRecalcDurationMs": 2.985999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 491.82499999999993,
      "heapDeltaBytes": -1116656,
      "heapUsedBytes": 91707460,
      "domNodes": 0,
      "jsHeapTotalBytes": 6815744,
      "scriptDurationMs": 176.99599999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.053488372093028,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1195.100000000025,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 827.8560000000001,
      "heapDeltaBytes": 15624848,
      "heapUsedBytes": 92162832,
      "domNodes": 0,
      "jsHeapTotalBytes": 9076736,
      "scriptDurationMs": 68.03999999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 578,
      "frameDurationMs": 36.36363636363637,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "dom-widget-order-dense-n200-w200-i120",
      "durationMs": 1163.383999999951,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 821.327,
      "heapDeltaBytes": 13859988,
      "heapUsedBytes": 91582732,
      "domNodes": 0,
      "jsHeapTotalBytes": 7766016,
      "scriptDurationMs": 64.73399999999998,
      "eventListeners": 0,
      "totalBlockingTimeMs": 534,
      "frameDurationMs": 34.31176470588234,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 864.2340000000104,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 460.6959999999996,
      "heapDeltaBytes": -12328000,
      "heapUsedBytes": 67116592,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 170.56499999999997,
      "eventListeners": 0,
      "totalBlockingTimeMs": 231,
      "frameDurationMs": 25.491176470588204,
      "p95FrameDurationMs": 16.80000000000109
    },
    {
      "name": "dom-widget-order-sparse-n1000-w20-i120",
      "durationMs": 862.2060000000147,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 495.75999999999976,
      "heapDeltaBytes": -7153400,
      "heapUsedBytes": 67162008,
      "domNodes": 0,
      "jsHeapTotalBytes": 266240,
      "scriptDurationMs": 174.17399999999995,
      "eventListeners": 0,
      "totalBlockingTimeMs": 238,
      "frameDurationMs": 25.491176470588204,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 10070.458000000002,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9171.206000000002,
      "heapDeltaBytes": -1116220,
      "heapUsedBytes": 79835812,
      "domNodes": 0,
      "jsHeapTotalBytes": -11796480,
      "scriptDurationMs": 7724.3189999999995,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1404,
      "frameDurationMs": 35.196503496503496,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "extension-clean-combined-draw",
      "durationMs": 9856.356000000005,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 9022.629,
      "heapDeltaBytes": 9503868,
      "heapUsedBytes": 90649560,
      "domNodes": 0,
      "jsHeapTotalBytes": -12320768,
      "scriptDurationMs": 7613.182,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1153,
      "frameDurationMs": 33.67431506849315,
      "p95FrameDurationMs": 66.69999999999891
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 11196.316000000024,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10157.577,
      "heapDeltaBytes": -2462100,
      "heapUsedBytes": 79540140,
      "domNodes": 0,
      "jsHeapTotalBytes": -14680064,
      "scriptDurationMs": 8363.546,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1342,
      "frameDurationMs": 32.32023121387284,
      "p95FrameDurationMs": 66.69999999999891
    },
    {
      "name": "extension-rgthree-prototype-draw",
      "durationMs": 11247.30999999997,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 10204.382000000001,
      "heapDeltaBytes": 10900724,
      "heapUsedBytes": 92475496,
      "domNodes": 0,
      "jsHeapTotalBytes": -12582912,
      "scriptDurationMs": 8425.44,
      "eventListeners": 0,
      "totalBlockingTimeMs": 1575,
      "frameDurationMs": 32.65377906976744,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2053.18699999998,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 2.021000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 482.3229999999999,
      "heapDeltaBytes": -25854364,
      "heapUsedBytes": 88723568,
      "domNodes": -232,
      "jsHeapTotalBytes": 425984,
      "scriptDurationMs": 38.839,
      "eventListeners": -137,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-idle",
      "durationMs": 2052.6740000000245,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 1.1839999999999993,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 459.31600000000003,
      "heapDeltaBytes": -23213304,
      "heapUsedBytes": 89238720,
      "domNodes": -232,
      "jsHeapTotalBytes": -884736,
      "scriptDurationMs": 34.952,
      "eventListeners": -137,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2986.6029999999455,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 8.992999999999997,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1798.467,
      "heapDeltaBytes": 3080980,
      "heapUsedBytes": 66092472,
      "domNodes": 0,
      "jsHeapTotalBytes": 3670016,
      "scriptDurationMs": 919.48,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6659217877095,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-pan",
      "durationMs": 2508.114999999975,
      "styleRecalcs": 65,
      "styleRecalcDurationMs": 8.620000000000001,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1555.9479999999999,
      "heapDeltaBytes": -438132,
      "heapUsedBytes": 62852264,
      "domNodes": 0,
      "jsHeapTotalBytes": 2359296,
      "scriptDurationMs": 865.87,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.777852348993285,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3669.9820000000045,
      "styleRecalcs": 61,
      "styleRecalcDurationMs": 9.819999999999999,
      "layouts": 60,
      "layoutDurationMs": 14.089,
      "taskDurationMs": 1764.855,
      "heapDeltaBytes": 17772448,
      "heapUsedBytes": 82053276,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 803.328,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66590909090909,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "large-graph-zoom",
      "durationMs": 3707.3709999999664,
      "styleRecalcs": 62,
      "styleRecalcDurationMs": 10.540000000000001,
      "layouts": 60,
      "layoutDurationMs": 14.046000000000003,
      "taskDurationMs": 1666.8979999999997,
      "heapDeltaBytes": 18374220,
      "heapUsedBytes": 83071840,
      "domNodes": 0,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 834.1909999999999,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66576576576577,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3136.922000000027,
      "styleRecalcs": 42,
      "styleRecalcDurationMs": 5.589,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1835.9959999999999,
      "heapDeltaBytes": 2720924,
      "heapUsedBytes": 67113988,
      "domNodes": 0,
      "jsHeapTotalBytes": 4456448,
      "scriptDurationMs": 1004.5580000000001,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.755080213903742,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "legacy-node-drag",
      "durationMs": 3080.714999999941,
      "styleRecalcs": 41,
      "styleRecalcDurationMs": 5.608000000000002,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 1879.671,
      "heapDeltaBytes": 35802120,
      "heapUsedBytes": 100090332,
      "domNodes": 0,
      "jsHeapTotalBytes": 5136384,
      "scriptDurationMs": 1041.481,
      "eventListeners": 180,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.75683060109289,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2022.9790000000207,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 0.9960000000000003,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 558.0280000000001,
      "heapDeltaBytes": 115744,
      "heapUsedBytes": 63218488,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 35.496,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665289256198346,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "minimap-idle",
      "durationMs": 2018.0239999999685,
      "styleRecalcs": 4,
      "styleRecalcDurationMs": 0.9650000000000005,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 555.736,
      "heapDeltaBytes": 212960,
      "heapUsedBytes": 63075592,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 38.813,
      "eventListeners": 0,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666115702479342,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 648.7450000000194,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 5.077999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 420.53,
      "heapDeltaBytes": -6112080,
      "heapUsedBytes": 88982172,
      "domNodes": 0,
      "jsHeapTotalBytes": 8126464,
      "scriptDurationMs": 144.99699999999999,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-dom-widget-clipping",
      "durationMs": 597.2870000000512,
      "styleRecalcs": 46,
      "styleRecalcDurationMs": 5.119999999999999,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 382.181,
      "heapDeltaBytes": -6192660,
      "heapUsedBytes": 89129540,
      "domNodes": 0,
      "jsHeapTotalBytes": 7602176,
      "scriptDurationMs": 149.314,
      "eventListeners": 6,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666666666666668,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2025.3450000000157,
      "styleRecalcs": 10,
      "styleRecalcDurationMs": 2.9460000000000006,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 372.35699999999997,
      "heapDeltaBytes": -29319356,
      "heapUsedBytes": 65964592,
      "domNodes": -248,
      "jsHeapTotalBytes": 3145728,
      "scriptDurationMs": 8.367000000000003,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.6655737704918,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-idle",
      "durationMs": 2029.7100000000228,
      "styleRecalcs": 7,
      "styleRecalcDurationMs": 1.9309999999999987,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 471.67,
      "heapDeltaBytes": -14279292,
      "heapUsedBytes": 65275876,
      "domNodes": -248,
      "jsHeapTotalBytes": -524288,
      "scriptDurationMs": 8.483,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66639344262295,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1762.6500000000078,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 17.934,
      "layouts": 16,
      "layoutDurationMs": 6.173,
      "taskDurationMs": 856.143,
      "heapDeltaBytes": -33655080,
      "heapUsedBytes": 61580136,
      "domNodes": -248,
      "jsHeapTotalBytes": 4718592,
      "scriptDurationMs": 117.60900000000001,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666981132075477,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-mouse-sweep",
      "durationMs": 1773.2900000000882,
      "styleRecalcs": 80,
      "styleRecalcDurationMs": 19.442,
      "layouts": 16,
      "layoutDurationMs": 6.108,
      "taskDurationMs": 898.631,
      "heapDeltaBytes": -27719812,
      "heapUsedBytes": 67420816,
      "domNodes": -248,
      "jsHeapTotalBytes": 4194304,
      "scriptDurationMs": 120.374,
      "eventListeners": -183,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.666037735849052,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "subgraph-transition-enter",
      "durationMs": 1416.9770000000312,
      "styleRecalcs": 18,
      "styleRecalcDurationMs": 29.649,
      "layouts": 5,
      "layoutDurationMs": 12.923,
      "taskDurationMs": 923.125,
      "heapDeltaBytes": 22554780,
      "heapUsedBytes": 104222724,
      "domNodes": 13667,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 30.471999999999998,
      "eventListeners": 2383,
      "totalBlockingTimeMs": 149,
      "frameDurationMs": 19.36621621621622,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8541.792999999983,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 32.445,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5481.338,
      "heapDeltaBytes": 25587548,
      "heapUsedBytes": 87468480,
      "domNodes": -232,
      "jsHeapTotalBytes": 192512,
      "scriptDurationMs": 2880.5420000000004,
      "eventListeners": -137,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.698630136986306,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "viewport-pan-sweep",
      "durationMs": 8451.543000000016,
      "styleRecalcs": 248,
      "styleRecalcDurationMs": 31.955,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 5416.7609999999995,
      "heapDeltaBytes": -23399284,
      "heapUsedBytes": 91205684,
      "domNodes": -232,
      "jsHeapTotalBytes": 1667072,
      "scriptDurationMs": 2809.469,
      "eventListeners": -137,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.699011857707507,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17415.832999999962,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16835.090999999997,
      "heapDeltaBytes": -16492260,
      "heapUsedBytes": 165517636,
      "domNodes": -1520,
      "jsHeapTotalBytes": 17825792,
      "scriptDurationMs": 284.729,
      "eventListeners": -7452,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 30.66214788732394,
      "p95FrameDurationMs": 66.60000000000218
    },
    {
      "name": "vue-large-graph-idle",
      "durationMs": 17156.74200000001,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 16583.645999999997,
      "heapDeltaBytes": -11305008,
      "heapUsedBytes": 169830352,
      "domNodes": -1520,
      "jsHeapTotalBytes": 11010048,
      "scriptDurationMs": 278.366,
      "eventListeners": -7452,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 29.721490467937606,
      "p95FrameDurationMs": 66.60000000000218
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 16001.96500000004,
      "styleRecalcs": 94,
      "styleRecalcDurationMs": 13.084999999999985,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 15415.858,
      "heapDeltaBytes": -10820004,
      "heapUsedBytes": 170295076,
      "domNodes": -1520,
      "jsHeapTotalBytes": 14155776,
      "scriptDurationMs": 838.73,
      "eventListeners": -7452,
      "totalBlockingTimeMs": 128,
      "frameDurationMs": 28,
      "p95FrameDurationMs": 66.69999999999891
    },
    {
      "name": "vue-large-graph-pan",
      "durationMs": 20628.462000000014,
      "styleRecalcs": 159,
      "styleRecalcDurationMs": 17.417000000000016,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 20400.855,
      "heapDeltaBytes": -7636376,
      "heapUsedBytes": 166601744,
      "domNodes": -1520,
      "jsHeapTotalBytes": 8388608,
      "scriptDurationMs": 922.6460000000001,
      "eventListeners": -7452,
      "totalBlockingTimeMs": 47,
      "frameDurationMs": 38.6376404494382,
      "p95FrameDurationMs": 83.29999999999927
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6019.398999999965,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 81.30300000000001,
      "layouts": 20,
      "layoutDurationMs": 23.043999999999993,
      "taskDurationMs": 5958.810999999999,
      "heapDeltaBytes": 7846276,
      "heapUsedBytes": 186970948,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 108.931,
      "eventListeners": 0,
      "totalBlockingTimeMs": 437,
      "frameDurationMs": 36.02694610778443,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-node-resize-workload",
      "durationMs": 6134.389000000056,
      "styleRecalcs": 20,
      "styleRecalcDurationMs": 78.96600000000001,
      "layouts": 20,
      "layoutDurationMs": 22.731,
      "taskDurationMs": 6032.909999999999,
      "heapDeltaBytes": 8037264,
      "heapUsedBytes": 182334548,
      "domNodes": 0,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 109.332,
      "eventListeners": 0,
      "totalBlockingTimeMs": 431,
      "frameDurationMs": 35.97882352941176,
      "p95FrameDurationMs": 66.70000000000073
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 6452.339999999993,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 6171.345000000002,
      "heapDeltaBytes": 3470020,
      "heapUsedBytes": 172281736,
      "domNodes": -1520,
      "jsHeapTotalBytes": 15728640,
      "scriptDurationMs": 108.57399999999996,
      "eventListeners": -7452,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 21.716161616161617,
      "p95FrameDurationMs": 33.400000000001455
    },
    {
      "name": "vue-zoom-out-idle",
      "durationMs": 8477.778000000057,
      "styleRecalcs": 0,
      "styleRecalcDurationMs": 0,
      "layouts": 0,
      "layoutDurationMs": 0,
      "taskDurationMs": 8228.454,
      "heapDeltaBytes": -3104828,
      "heapUsedBytes": 194391052,
      "domNodes": -1520,
      "jsHeapTotalBytes": 12845056,
      "scriptDurationMs": 162.968,
      "eventListeners": -7452,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 29.70666666666666,
      "p95FrameDurationMs": 50.10000000000218
    },
    {
      "name": "workflow-execution",
      "durationMs": 500.7990000000291,
      "styleRecalcs": 21,
      "styleRecalcDurationMs": 18.533,
      "layouts": 4,
      "layoutDurationMs": 1.9390000000000003,
      "taskDurationMs": 132.952,
      "heapDeltaBytes": 6326168,
      "heapUsedBytes": 97281460,
      "domNodes": 129,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 14.472000000000001,
      "eventListeners": 81,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.665517241379316,
      "p95FrameDurationMs": 16.700000000000728
    },
    {
      "name": "workflow-execution",
      "durationMs": 472.70400000002155,
      "styleRecalcs": 19,
      "styleRecalcDurationMs": 15.394000000000002,
      "layouts": 3,
      "layoutDurationMs": 1.652,
      "taskDurationMs": 125.68099999999998,
      "heapDeltaBytes": 6177188,
      "heapUsedBytes": 97083336,
      "domNodes": 126,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 10.277,
      "eventListeners": 81,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.668965517241396,
      "p95FrameDurationMs": 16.800000000000182
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 1033.7450000000672,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 116.27600000000001,
      "layouts": 76,
      "layoutDurationMs": 25.732000000000003,
      "taskDurationMs": 1006.721,
      "heapDeltaBytes": 19525392,
      "heapUsedBytes": 90330956,
      "domNodes": 76,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 418.956,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66612903225808,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "agent-composer-empty-conversation-typing",
      "durationMs": 863.2369999999128,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 108.515,
      "layouts": 76,
      "layoutDurationMs": 21.678,
      "taskDurationMs": 838.3009999999999,
      "heapDeltaBytes": 17772884,
      "heapUsedBytes": 87941564,
      "domNodes": 76,
      "jsHeapTotalBytes": 262144,
      "scriptDurationMs": 338.69899999999996,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 16.66792452830188,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1362.844999999993,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 238.12,
      "layouts": 76,
      "layoutDurationMs": 23.781,
      "taskDurationMs": 1347.197,
      "heapDeltaBytes": 8725464,
      "heapUsedBytes": 152679364,
      "domNodes": 76,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 463.374,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.298734177215195,
      "p95FrameDurationMs": 16.799999999999272
    },
    {
      "name": "agent-composer-long-conversation-typing",
      "durationMs": 1389.3809999999576,
      "styleRecalcs": 78,
      "styleRecalcDurationMs": 243.09900000000002,
      "layouts": 76,
      "layoutDurationMs": 25.184,
      "taskDurationMs": 1364.862,
      "heapDeltaBytes": 8757560,
      "heapUsedBytes": 152716028,
      "domNodes": 76,
      "jsHeapTotalBytes": 0,
      "scriptDurationMs": 460.146,
      "eventListeners": 876,
      "totalBlockingTimeMs": 0,
      "frameDurationMs": 17.5,
      "p95FrameDurationMs": 16.80000000000109
    }
  ]
}

🔬 E2E Coverage

Metric Covered Total Pct
Lines 53190 80895 65.8% 🟡
Functions 0 0 — —
Branches 0 0 — —
Top 10 files by uncovered lines
File Coverage Missed
src/LGraphCanvas.ts 67.4% 1151
src/LGraphNode.ts 70.3% 388
src/extensions/core/cameraInfo/CameraInfoViewport.ts 2.5% 344
src/platform/workspace/stores/billingOperationStore.ts 8.1% 341
src/renderer/extensions/layerEditor/composables/useLayerEditorSession.ts 40.1% 332
src/LGraph.ts 79.2% 267
src/platform/workspace/stores/teamWorkspaceStore.ts 38.9% 256
src/core/billing/operationLifecycle.ts 1.2% 252
src/core/webSessionIdentity.ts 3.4% 224
src/scripts/pnginfo.ts 20.7% 222

🧩 Custom Nodes Ecosystem Matrix: ✅ Passed

Executes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight ecosystem-matrix shard checks are a harness self-test; the pack verdict is matrix-verdict.

Stage Result What a failure here means
pin-status success Informational. It never fails the build; it warns when the corpus snapshot is over 30 days old.
corpus success Infrastructure: the pack mirror could not be fetched, validated or cached. Not your diff.
shards success Harness integrity, not pack breakage. A shard only checks that every built spec wrote its row; vitest's own exit code is deliberately ignored because pack code leaks unhandled rejections.
verdicts success The population verdict per renderer. This is the stage that judges packs. Exit 1 is FAIL; exit 2 is withheld — rows were missing, so nothing was measured, which is not the same as your change breaking packs.
detection-proofs success The instrument self-test: the matrix must FAIL on a deliberately poisoned corpus. A failure here means the gate cannot be trusted this run, in either direction.

On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff.

Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped.

Reproduce locally
# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
  npx vitest run --config vitest.matrix.config.mts

Full docs: scripts/registry-census/README.md

@github-actions github-actions Bot added the risk:xhigh PR risk grade (advisory shadow check; grader-owned) label Sep 29, 2026
@codecov

codecov Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.01613% with 114 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/composables/auth/useAuthDialogs.ts 20.00% 28 Missing ⚠️
src/composables/auth/useUpdatePassword.ts 0.00% 20 Missing ⚠️
src/platform/auth/cloudApiAuthProvider.ts 48.14% 14 Missing ⚠️
src/composables/billing/useBillingDialogs.ts 89.01% 10 Missing ⚠️
src/core/graph/nodeDef/ComfyNodeDefImpl.ts 89.23% 7 Missing ⚠️
src/composables/useCoreCommands.ts 50.00% 6 Missing ⚠️
...fication/composables/useCloudNotificationDialog.ts 33.33% 6 Missing ⚠️
...composables/billing/__mocks__/useBillingDialogs.ts 66.66% 3 Missing ⚠️
src/main.ts 25.00% 3 Missing ⚠️
src/composables/auth/__mocks__/useAuthDialogs.ts 66.66% 2 Missing ⚠️
... and 13 more
@@                       Coverage Diff                       @@
##           drjkl/depcruise-no-circular   #19467      +/-   ##
===============================================================
+ Coverage                        84.93%   85.01%   +0.07%     
===============================================================
  Files                             2407     2372      -35     
  Lines                           136081   133541    -2540     
  Branches                         35252    34736     -516     
===============================================================
- Hits                            115587   113531    -2056     
+ Misses                           20026    19647     -379     
+ Partials                           468      363     -105     
Flag Coverage Δ
billing-web-unit ?
e2e 65.75% <68.14%> (+<0.01%) ⬆️
unit 81.43% <75.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/App.vue 55.00% <100.00%> (+1.15%) ⬆️
...actionbar/ComfyRunButton/LocalRunButtonWrapper.vue 100.00% <100.00%> (ø)
...components/actionbar/PartnerNodesEducationCard.vue 100.00% <100.00%> (ø)
src/components/appMode/AppModeToolbar.vue 100.00% <100.00%> (ø)
src/components/builder/useEnterBuilder.ts 100.00% <100.00%> (ø)
src/components/cameraInfo/CameraInfo.vue 90.66% <ø> (ø)
src/components/common/TreeExplorerV2.vue 29.26% <ø> (ø)
src/components/common/TreeExplorerV2Node.vue 93.24% <ø> (ø)
...nents/dialog/content/ConfirmationDialogContent.vue 73.21% <ø> (+0.48%) ⬆️
...c/components/dialog/content/ErrorDialogContent.vue 92.30% <ø> (+0.12%) ⬆️
... and 183 more

... and 254 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DrJKL DrJKL added the refactor-gordian-knot Import-cycle untangling stack (FE-3037) label Oct 6, 2026
@DrJKL DrJKL closed this Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor-gordian-knot Import-cycle untangling stack (FE-3037) risk:xhigh PR risk grade (advisory shadow check; grader-owned)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants