Repository navigation
fix: run the live widget's effects for agent widget writes - #18070
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎨 Storybook: ✅ Built — View Storybook🎭 Playwright: ✅ 2056 passed, 0 failed📊 Browser Reports
📦 Bundle: 9.93 MB gzip 🟢 -1.09 kBDetailsSummary
Category Glance App Entry Points — 3.81 kB (baseline 3.81 kB) • ⚪ 0 BMain entry bundles and manifests
Status: 1 added / 1 removed Graph Workspace — 1.45 MB (baseline 1.46 MB) • 🟢 -4.02 kBGraph editor runtime, canvas, workflow orchestration
Status: 2 added / 2 removed / 1 unchanged Views & Navigation — 132 kB (baseline 132 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces
Status: 14 added / 14 removed / 4 unchanged Panels & Settings — 638 kB (baseline 638 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens
Status: 10 added / 10 removed / 18 unchanged User & Accounts — 37.9 kB (baseline 37.9 kB) • ⚪ 0 BAuthentication, profile, and account management bundles
Status: 7 added / 7 removed / 4 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors
Status: 7 added / 7 removed / 1 unchanged UI Components — 124 kB (baseline 124 kB) • ⚪ 0 BReusable component library chunks
Status: 7 added / 7 removed / 9 unchanged Data & Services — 3.87 MB (baseline 3.87 MB) • 🔴 +170 BStores, services, APIs, and repositories
Status: 13 added / 13 removed / 3 unchanged Utilities & Hooks — 566 kB (baseline 566 kB) • ⚪ 0 BHelpers, composables, and utility bundles
Status: 21 added / 21 removed / 17 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.7 MB (baseline 17.7 MB) • 🟢 -281 BBundles that do not match a named category
Status: 80 added / 81 removed / 220 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-20T09:27:47.141Z",
"gitSha": "80a94dc3ef88d1bfbb2176503b94c35a07e99a25",
"branch": "claude/pm-1273-combo-widget-red-outline-repro",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2008.0859999999916,
"styleRecalcs": 8,
"styleRecalcDurationMs": 8.072999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 508.39,
"heapDeltaBytes": 15167416,
"heapUsedBytes": 76316108,
"domNodes": -264,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 9.591,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-idle",
"durationMs": 2015.369000000078,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.368,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 492.32699999999994,
"heapDeltaBytes": 11643296,
"heapUsedBytes": 73356608,
"domNodes": -263,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 10.526,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1954.8320000000103,
"styleRecalcs": 78,
"styleRecalcDurationMs": 39.167,
"layouts": 14,
"layoutDurationMs": 4.962,
"taskDurationMs": 905.7650000000001,
"heapDeltaBytes": -8558440,
"heapUsedBytes": 58597300,
"domNodes": -259,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 193.949,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1858.788000000004,
"styleRecalcs": 75,
"styleRecalcDurationMs": 32.131,
"layouts": 14,
"layoutDurationMs": 4.069000000000001,
"taskDurationMs": 765.061,
"heapDeltaBytes": 14377576,
"heapUsedBytes": 76518340,
"domNodes": -264,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 169.309,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1741.8729999999982,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.161,
"layouts": 6,
"layoutDurationMs": 1.273,
"taskDurationMs": 362.53099999999995,
"heapDeltaBytes": 2153424,
"heapUsedBytes": 64274688,
"domNodes": 74,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 11.82,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1687.0519999999942,
"styleRecalcs": 31,
"styleRecalcDurationMs": 16.076,
"layouts": 6,
"layoutDurationMs": 1.0579999999999998,
"taskDurationMs": 353.627,
"heapDeltaBytes": 1844544,
"heapUsedBytes": 64183576,
"domNodes": 77,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.116000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-clipping",
"durationMs": 669.0770000000157,
"styleRecalcs": 10,
"styleRecalcDurationMs": 6.580999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 459.152,
"heapDeltaBytes": 18119004,
"heapUsedBytes": 80209268,
"domNodes": 16,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 171.22500000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 666.6690000000699,
"styleRecalcs": 11,
"styleRecalcDurationMs": 8.454,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 463.37799999999993,
"heapDeltaBytes": 18181636,
"heapUsedBytes": 80952196,
"domNodes": 18,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 177.05,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2073.1420000000185,
"styleRecalcs": 6,
"styleRecalcDurationMs": 6.644000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 720.633,
"heapDeltaBytes": 2021804,
"heapUsedBytes": 81113604,
"domNodes": -255,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 46.26,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-idle",
"durationMs": 2027.5940000000219,
"styleRecalcs": 3,
"styleRecalcDurationMs": 5.8759999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 597.593,
"heapDeltaBytes": 3201220,
"heapUsedBytes": 82311936,
"domNodes": -252,
"jsHeapTotalBytes": -794624,
"scriptDurationMs": 35.014,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-pan",
"durationMs": 2432.1520000000305,
"styleRecalcs": 63,
"styleRecalcDurationMs": 8.988000000000003,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1704.485,
"heapDeltaBytes": 19839656,
"heapUsedBytes": 83953056,
"domNodes": -259,
"jsHeapTotalBytes": 487424,
"scriptDurationMs": 897.702,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2336.073000000056,
"styleRecalcs": 68,
"styleRecalcDurationMs": 13.628000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1707.226,
"heapDeltaBytes": -4950260,
"heapUsedBytes": 77002000,
"domNodes": -250,
"jsHeapTotalBytes": 2613248,
"scriptDurationMs": 894.795,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3706.481999999994,
"styleRecalcs": 60,
"styleRecalcDurationMs": 10.339999999999998,
"layouts": 60,
"layoutDurationMs": 13.583000000000002,
"taskDurationMs": 1806.8399999999997,
"heapDeltaBytes": 9061460,
"heapUsedBytes": 74955748,
"domNodes": -261,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 864.058,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3620.2789999999823,
"styleRecalcs": 61,
"styleRecalcDurationMs": 10.698000000000002,
"layouts": 60,
"layoutDurationMs": 13.062000000000001,
"taskDurationMs": 1716.3659999999998,
"heapDeltaBytes": 8723096,
"heapUsedBytes": 74297380,
"domNodes": 2,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 823.762,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3129.82999999997,
"styleRecalcs": 41,
"styleRecalcDurationMs": 6.415999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1967.1100000000001,
"heapDeltaBytes": 23196016,
"heapUsedBytes": 89096144,
"domNodes": 2,
"jsHeapTotalBytes": 417792,
"scriptDurationMs": 1014.1139999999999,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3138.3049999999457,
"styleRecalcs": 40,
"styleRecalcDurationMs": 5.0390000000000015,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1930.2359999999999,
"heapDeltaBytes": -1807864,
"heapUsedBytes": 66197108,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 1006.1179999999998,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "minimap-idle",
"durationMs": 2031.3540000000216,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.705,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 563.618,
"heapDeltaBytes": -4732200,
"heapUsedBytes": 83575316,
"domNodes": -254,
"jsHeapTotalBytes": -495616,
"scriptDurationMs": 32.668,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "minimap-idle",
"durationMs": 2021.2629999999763,
"styleRecalcs": 4,
"styleRecalcDurationMs": 3.304000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 576.7909999999999,
"heapDeltaBytes": -4465992,
"heapUsedBytes": 83704424,
"domNodes": -254,
"jsHeapTotalBytes": -1544192,
"scriptDurationMs": 34.537,
"eventListeners": -152,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 618.204999999989,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.547,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 425.13700000000006,
"heapDeltaBytes": 14165360,
"heapUsedBytes": 76977784,
"domNodes": 20,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 148.265,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66999999999998,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 578.1569999999192,
"styleRecalcs": 47,
"styleRecalcDurationMs": 11.569999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 414.31699999999995,
"heapDeltaBytes": 13160944,
"heapUsedBytes": 76658000,
"domNodes": 20,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 145.974,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2017.8050000000098,
"styleRecalcs": 9,
"styleRecalcDurationMs": 7.032000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 494.236,
"heapDeltaBytes": -1477268,
"heapUsedBytes": 62117092,
"domNodes": -279,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 8.132999999999997,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2007.4779999999919,
"styleRecalcs": 9,
"styleRecalcDurationMs": 8.222000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 477.47499999999997,
"heapDeltaBytes": -7004280,
"heapUsedBytes": 56182728,
"domNodes": -277,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 7.269999999999999,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1717.002999999977,
"styleRecalcs": 77,
"styleRecalcDurationMs": 30.044,
"layouts": 18,
"layoutDurationMs": 5.443,
"taskDurationMs": 821.644,
"heapDeltaBytes": -7174892,
"heapUsedBytes": 56158296,
"domNodes": -278,
"jsHeapTotalBytes": 4186112,
"scriptDurationMs": 112.562,
"eventListeners": -198,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1707.8859999999167,
"styleRecalcs": 79,
"styleRecalcDurationMs": 26.879,
"layouts": 18,
"layoutDurationMs": 5.326,
"taskDurationMs": 790.803,
"heapDeltaBytes": 4750928,
"heapUsedBytes": 67404652,
"domNodes": -276,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 112.13,
"eventListeners": -220,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.0679999999484,
"styleRecalcs": 17,
"styleRecalcDurationMs": 28.496000000000006,
"layouts": 5,
"layoutDurationMs": 13.006,
"taskDurationMs": 915.1699999999998,
"heapDeltaBytes": -6438228,
"heapUsedBytes": 80222780,
"domNodes": 13587,
"jsHeapTotalBytes": 11010048,
"scriptDurationMs": 31.144999999999992,
"eventListeners": 2383,
"totalBlockingTimeMs": 139,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8680.834000000004,
"styleRecalcs": 245,
"styleRecalcDurationMs": 36.14000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6035.969,
"heapDeltaBytes": 3046348,
"heapUsedBytes": 84160280,
"domNodes": -254,
"jsHeapTotalBytes": -303104,
"scriptDurationMs": 2923.5299999999997,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "viewport-pan-sweep",
"durationMs": 8310.318999999936,
"styleRecalcs": 248,
"styleRecalcDurationMs": 37.594,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 5411.5869999999995,
"heapDeltaBytes": -4602344,
"heapUsedBytes": 76552956,
"domNodes": -247,
"jsHeapTotalBytes": 221184,
"scriptDurationMs": 2941.448,
"eventListeners": -174,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-large-graph-idle",
"durationMs": 17436.244999999984,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16952.106,
"heapDeltaBytes": -25687812,
"heapUsedBytes": 192179288,
"domNodes": -8061,
"jsHeapTotalBytes": -3158016,
"scriptDurationMs": 285.192,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17277.261000000068,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16745.357000000004,
"heapDeltaBytes": -60704380,
"heapUsedBytes": 171018312,
"domNodes": -8061,
"jsHeapTotalBytes": -10072064,
"scriptDurationMs": 283.957,
"eventListeners": -14928,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 21235.736999999972,
"styleRecalcs": 165,
"styleRecalcDurationMs": 18.81100000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20991.424,
"heapDeltaBytes": -62498624,
"heapUsedBytes": 168738388,
"domNodes": -8065,
"jsHeapTotalBytes": -12955648,
"scriptDurationMs": 917.4010000000001,
"eventListeners": -14928,
"totalBlockingTimeMs": 33,
"frameDurationMs": 17.773333333333238,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-pan",
"durationMs": 21181.561999999984,
"styleRecalcs": 170,
"styleRecalcDurationMs": 18.02899999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20921.030000000002,
"heapDeltaBytes": -38883784,
"heapUsedBytes": 191392300,
"domNodes": -8061,
"jsHeapTotalBytes": -6684672,
"scriptDurationMs": 914.3679999999999,
"eventListeners": -14928,
"totalBlockingTimeMs": 34,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6351.704999999982,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.84700000000001,
"layouts": 20,
"layoutDurationMs": 24.55700000000001,
"taskDurationMs": 6264.673999999999,
"heapDeltaBytes": -45077112,
"heapUsedBytes": 175701684,
"domNodes": -8061,
"jsHeapTotalBytes": 7331840,
"scriptDurationMs": 118.158,
"eventListeners": -14928,
"totalBlockingTimeMs": 441,
"frameDurationMs": 17.779999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-node-resize-workload",
"durationMs": 6414.243000000056,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.99299999999998,
"layouts": 20,
"layoutDurationMs": 24.566999999999993,
"taskDurationMs": 6342.765000000001,
"heapDeltaBytes": -39436184,
"heapUsedBytes": 171315848,
"domNodes": -8065,
"jsHeapTotalBytes": 13574144,
"scriptDurationMs": 125.42,
"eventListeners": -14928,
"totalBlockingTimeMs": 453,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8774.509000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8519.339,
"heapDeltaBytes": 19799804,
"heapUsedBytes": 183083048,
"domNodes": 0,
"jsHeapTotalBytes": -9961472,
"scriptDurationMs": 139.42200000000005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 9112.64600000004,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8824.704999999998,
"heapDeltaBytes": 1503192,
"heapUsedBytes": 183418840,
"domNodes": 0,
"jsHeapTotalBytes": -9437184,
"scriptDurationMs": 152.02300000000002,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 18.329999999999927,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "workflow-execution",
"durationMs": 474.3220000000292,
"styleRecalcs": 22,
"styleRecalcDurationMs": 32.277,
"layouts": 5,
"layoutDurationMs": 2.5100000000000002,
"taskDurationMs": 155.93500000000003,
"heapDeltaBytes": 5349728,
"heapUsedBytes": 66908260,
"domNodes": 153,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 19.588,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "workflow-execution",
"durationMs": 125.99199999999655,
"styleRecalcs": 9,
"styleRecalcDurationMs": 18.247,
"layouts": 3,
"layoutDurationMs": 1.7730000000000004,
"taskDurationMs": 93.16499999999996,
"heapDeltaBytes": 3022660,
"heapUsedBytes": 64725368,
"domNodes": 130,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 6.901999999999998,
"eventListeners": 17,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since 065c91127b6aff12cf73593ef48ecb87e0b2b219
Full docs: ADR-DEVEX-LINT-0015 🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md |
4e0f3cc to
c016766
Compare
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #18070 +/- ##
==========================================
+ Coverage 82.90% 83.87% +0.97%
==========================================
Files 2951 2255 -696
Lines 145493 128472 -17021
Branches 39349 34604 -4745
==========================================
- Hits 120621 107758 -12863
+ Misses 23603 20425 -3178
+ Partials 1269 289 -980
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 707 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Superseded: mechanism B is now implemented in this PR (see the ADR Mechanism B: agent widget writes bypass the live widget callbackThe placeholder-options repro ( Problem
Why it isn't a small fix
Options to design further
Open design questions
Given the extension-ecosystem blast radius, this needs a short design pass (RFC/TDD) before implementation rather than a quick patch here. Generated by Claude Code |
4c7dad1 to
2aa4904
Compare
|
Updating Playwright Expectations |
2aa4904 to
8cadc5e
Compare
Adds two failing (test.fails) repro tests for the red-outline bug on
combo widgets touched by the agent CRDT path:
- WidgetSelectDefault.test.ts: a placeholder combo widget (options: {},
as registerPlaceholder() in graphMutations.ts builds it before a node
materializes) renders its false-invalid ring for a value that will be
legitimate once the real options load.
- graphMutations.test.ts: an agent-set value never fires the live
widget's own callback the way the human-edit path in
processedWidgetRenderModel.ts does, so a combo's options never get the
chance to refresh in sync with the new value.
WidgetSelectDefault's isInvalid check couldn't tell "options not loaded yet" (options.values is undefined, e.g. an agent-created node's placeholder widget) from a genuinely stale value not present in a populated options list. Gate the check on values being defined so a placeholder widget's legitimate value no longer renders a red ring. Flips the WidgetSelectDefault repro test from failing to passing. The companion graphMutations repro (agent writes bypassing the live widget's callback) is a separate, deeper issue and remains open; see PR comment for the fix plan.
Records the design for mechanism B of the false-invalid combo ring: agent CRDT widget writes never reach the live widget's callback or onWidgetChanged. Adds a renderer-owned SemanticWidgetEffectPort on GraphMutationsDeps, change-gated and drained after the batch commits, with the alternatives considered, the extension-facing contract, and the test plan. Node-field reconcile is scoped out explicitly.
Restate the context as a contract gap (agent writes bypass the live widget's value accessor, callback, and onWidgetChanged) with Custom Combo and PrimitiveNode as concrete beneficiaries; the ring on core static combos is mechanism A plus stale defs, not this ADR. Gate effects on the applied store value with structural equality for objects (identity is defeated by the follower's clone and loops through a normalizing callback's mint echo); shape the shared write helper so the PR 18089 recency guard reports applied: false; require store ownership of the resolved live node so a replaced or deleted node's orphan never receives its successor's value; define placeholder semantics by live-node presence; state what onWidgetChanged triggers; pin reentrancy and drain order; correct file attributions and the layering rationale; note the reactive-options dependency for ring clearance and the subgraph surface.
Red half of ADR-CRDT-WIDGETS-0036. Adds the required widgets port to GraphMutationsDeps with an inert createLiveWidgetEffectPort seam so the suites compile, and pins the behaviour the green half must supply: - the false-invalid combo repro, adapted to a live LGraph so resolution can find the node, now a plain it and asserting callback plus live value - port contract: change-gated effects (structural for objects, one per widget per batch, previous re-read per write), payload order after commit, throwing-port isolation via reportError, nothing on rejection - live port: callback and onWidgetChanged arguments, no-ops for store-only nodes, missing widgets, a foreign root graph, and the orphan left by an in-batch replaceNode; drain-time resolution; required_input_missing cleared through onWidgetChanged - mint echo: a callback that rewrites its own object value mints one human set_widget and the echo frame mints nothing
Green half of ADR-CRDT-WIDGETS-0036. Both follower write paths (named set_widget and positional reconcile) go through one helper that reads the previous store value, writes with the remote context, and reports whether the write applied. A batch records an effect only when the write applied and the store's post-write value differs from the previous one, by Object.is for primitives and structurally for objects, so the clone every doc value takes on the way in cannot count as a change and a callback that normalizes its own value into a new object cannot loop through its mint echo. Effects are drained after commit in payload order, each call isolated behind reportError. createLiveWidgetEffectPort resolves the live node the way the Vue render model does, requires the store to still own that node so an orphan left by an in-batch replace or delete never receives its successor's value, then assigns widget.value, runs callback(value, canvas, node) and node.onWidgetChanged, and redraws. AgentPanelRoot wires it with the displayed root graph and canvas.
…ffects valueApplied held every guard inline: root graph present and matching the scope, locator resolution, store ownership, and widget lookup. Move them into resolveLiveWidget so the port reads as resolve, early return, then the effects a human edit runs. Behaviour is unchanged; the complexity audit no longer flags the function.
The repository is public; the tracker identifiers carried no information a reader of these files can act on.
02b0ec0 to
cdeb174
Compare
| snapshot | status | changed pixels | | --- | --- | --- | | `tests/agent/agentConversationReplay.spec.ts-snapshots/two-turn-dependent-edit-wired-cloud-linux.png` | modified | 149031B -> 148076B | Screenshot capture is not bit-deterministic; small pixel deltas are usually text rasterization noise. Confirm each rewrite corresponds to a test expected to change.
## Summary Seventeen non-billing Agent sources are carried for `core/1.54`. Exact-head hosted checks and target-native replay acceptance pass; review remains. <details><summary>Full context for agent readers</summary> ## Changes - **Sources**: [18113](#18113), [18096](#18096), [18122](#18122), [18164](#18164), [18121](#18121), [18148](#18148), [18111](#18111), [18174](#18174), [17912](#17912), [18081](#18081), [16936](#16936), [18183](#18183), [18197](#18197), [18070](#18070), [18084](#18084), [18071](#18071), and [18107](#18107). - **New in this head**: PR 18107 rejects incompatible Agent-created links, retires incompatible retained links from the local projection, and keeps one bad link from blocking unrelated later edits. Main-only Load3D coverage is adapted onto the release-local unit, `HostDoc`, and tab-return harnesses. - **Dependencies**: no new package dependency; release lockfile pins are preserved. - **Exclusions**: billing/account work, protected source [17730](#17730), target-specific screenshot source [18168](#18168), separately owned focused carriers, and [18123](#18123), whose generic Vue-node test depends on [17576](#17576), absent from this release line. ## Review focus - PR 16936 adapts widget-state rebinding to the 1.54 store API without importing `main`'s newer visibility architecture. - PR 18070 runs target-local live widget projection callbacks with the canvas and owner node while retaining the release projection boundary. - PR 18084 adds placement as a renderer-owned port; resync materializations retain document coordinates, while new offscreen batches move together beside existing content. - The release browser harness seeds the same client-only API-node colors that normal node registration owns before testing whether a later CRDT reconcile preserves them. - This is not behavioral acceptance, deployment authorization, or a merge-check waiver. ## Exact-head verification Current head: `2bd4dace2e6207fede11d2ac219d691a811769dc`, verified under Node 25.9.0 and pnpm 11.13.1. - main typecheck passed with an 8 GiB heap at the production-identical parent; this head changes only the browser harness lifecycle; - the prior 146-test selection passed with 1 expected failure; - after repairing idempotent replay, 119 focused tests passed with 1 expected failure; - the exact head passes browser typecheck and adds a target-native check that the missing checkpoint value and `aria-invalid=true` survive tab return; - ancestor head `bd7da3cffd6dc349e1c48c5a277bc112cabd0e41` passed one zero-retry target-native warning-retention case with an inspected final frame; its [durable QA receipt](https://github.com/christian-byrne/in-app-agent-program/blob/7fa0ba4d731f00684388a45f1aeb1d24dc6f2280/reports/pr-ownership/2026-09-20-missing-model-tab-warning.md#1145-utc-exact-core-native-case-passes-final-warning-frame-inspected) is ancestry evidence, not acceptance of this newer head; - frozen installation and main typecheck pass at the production-identical parent; browser typecheck, target-native browser collection, formatting, ESLint, fixture mint/projection, and diff checks pass at this exact head; - the extended browser case commits pasted-node operations through the real `HostDoc` and asserts the pasted position survives another tab retarget; - parent head `389a3718bd2f637f704bde349068cbfd87cd9542` passed warning, node-presentation, and viewport assertions but stopped before paste because the zoom popup backdrop intercepted node selection; this head closes the popup through its real toggle and asserts it hidden before selection; - the first PR 18107 browser head stopped before app boot because the force-input string sink serialized one widget value while declaring no widgets; this head removes that non-widget value, and the exact fixture contract now mints and projects successfully; - parent head `366e0287095876351377f873688fece88eb90397` reached local paste but had already closed the Agent panel, which unmounted `AgentPanelRoot`, detached mint-port wiring, and disposed the CRDT follower; this head preserves the closed-panel screenshot, then reopens the panel and requires a fresh workflow subscription before mutation while retaining the unchanged `HostDoc` assertion; - one zero-retry target-native invocation passed the complete case at 13:44:02 UTC: warning retention, node presentation, popup closure, fresh subscription, local and host paste position after a second retarget, incompatible-link retirement, and the subsequent Agent edit; the [durable QA receipt](https://github.com/christian-byrne/in-app-agent-program/blob/28f5a4bb05318cc4e1a95d819951f7924bf9d2c2/reports/pr-ownership/2026-09-20-missing-model-tab-warning.md#1345-utc-both-lifecycle-corrected-candidates-pass-the-complete-native-case) includes inspected frames and cleanup; - PR 18107's exact-head focused coverage passes 63 tests with 1 expected failure; main and browser typechecks, targeted formatting and ESLint, and three affected Cloud-project browser cases also collect successfully; - targeted format and ESLint passed; - three affected Cloud-project browser cases collected successfully. Exact-head hosted checks and target-native replay acceptance pass. Review and the release-target merge-readiness gate remain required before merge. No deployment or check waiver is authorized. </details> Justification: Authorized Agent 1.54 release backport aggregate merged without standing human approval under the published release-backport authority; exact-head hosted checks, target-native replay acceptance, target-aware merge guard, adaptation review, and absence of unresolved human objections limit risk. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com>
## Summary Seventeen non-billing Agent sources are carried for `cloud/1.54`. The candidate now contains release `1.54.12`; fresh hosted checks and target-native replay acceptance passed. <details><summary>Full context for agent readers</summary> ## Changes - **Sources**: [18113](#18113), [18096](#18096), [18122](#18122), [18164](#18164), [18121](#18121), [18148](#18148), [18111](#18111), [18174](#18174), [17912](#17912), [18081](#18081), [16936](#16936), [18183](#18183), [18197](#18197), [18070](#18070), [18084](#18084), [18071](#18071), and [18107](#18107). - **New in this head**: PR 18107 rejects incompatible Agent-created links, retires incompatible retained links from the local projection, and keeps one bad link from blocking unrelated later edits. Main-only Load3D coverage is adapted onto the release-local unit, `HostDoc`, and tab-return harnesses. - **Dependencies**: no new package dependency; release lockfile pins are preserved. - **Exclusions**: billing/account work, protected source [17730](#17730), target-specific screenshot source [18168](#18168), separately owned focused carriers, and [18123](#18123), whose generic Vue-node test depends on [17576](#17576), absent from this release line. ## Review focus - PR 16936 adapts widget-state rebinding to the 1.54 store API without importing `main`'s newer visibility architecture. - PR 18070 runs target-local live widget projection callbacks with the canvas and owner node while retaining the release projection boundary. - PR 18084 adds placement as a renderer-owned port; resync materializations retain document coordinates, while new offscreen batches move together beside existing content. - The release browser harness seeds the same client-only API-node colors that normal node registration owns before testing whether a later CRDT reconcile preserves them. - This is not behavioral acceptance, deployment authorization, or a merge-check waiver. ## Exact-head verification Current head: `aabd82168d2d7b2f1b9f685a5477dcdc491d3b02`, verified locally under Node 25.9.0 and pnpm 11.13.1. - merged current `cloud/1.54` tip `d2667baf6bdb8664821b4bed7a7f5a1df65f9f49` cleanly; the imported release delta is limited to the package version and locale data; - frozen installation, 174 focused Agent/missing-model tests with 1 expected failure, main and browser typechecks, formatting, full ESLint with zero errors, the Cloud production build, target ancestry, and diff checks pass locally; - fresh exact-head hosted checks and one zero-retry target-native replay passed after the release target changed; - main typecheck passed with an 8 GiB heap at the production-identical parent; this head changes only the browser harness lifecycle; - the prior 146-test selection passed with 1 expected failure; - after repairing idempotent replay, 119 focused tests passed with 1 expected failure; - the exact head passes browser typecheck and adds a target-native check that the missing checkpoint value and `aria-invalid=true` survive tab return; - frozen installation and main typecheck pass at the production-identical parent; browser typecheck, target-native browser collection, formatting, ESLint, fixture mint/projection, and diff checks pass at this exact head; - the extended browser case commits pasted-node operations through the real `HostDoc` and asserts the pasted position survives another tab retarget; - parent head `dfe99947cffb5f31c5f4750113eb9770720e5eac` passed warning, node-presentation, and viewport assertions but stopped before paste because the zoom popup backdrop intercepted node selection; this head closes the popup through its real toggle and asserts it hidden before selection; - the first PR 18107 browser head stopped before app boot because the force-input string sink serialized one widget value while declaring no widgets; this head removes that non-widget value, and the exact fixture contract now mints and projects successfully; - parent head `5ec6c64e9b78b56b12350ae732dc1e1ea20052e0` reached local paste but had already closed the Agent panel, which unmounted `AgentPanelRoot`, detached mint-port wiring, and disposed the CRDT follower; this head preserves the closed-panel screenshot, then reopens the panel and requires a fresh workflow subscription before mutation while retaining the unchanged `HostDoc` assertion; - one zero-retry target-native invocation passed the complete case at 13:45:15 UTC: warning retention, node presentation, popup closure, fresh subscription, local and host paste position after a second retarget, incompatible-link retirement, and the subsequent Agent edit; the [durable QA receipt](https://github.com/christian-byrne/in-app-agent-program/blob/28f5a4bb05318cc4e1a95d819951f7924bf9d2c2/reports/pr-ownership/2026-09-20-missing-model-tab-warning.md#1345-utc-both-lifecycle-corrected-candidates-pass-the-complete-native-case) includes inspected frames and cleanup; - PR 18107's exact-head focused coverage passes 63 tests with 1 expected failure; main and browser typechecks, targeted formatting and ESLint, and three affected Cloud-project browser cases also collect successfully; - targeted format and ESLint passed; - three affected Cloud-project browser cases collected successfully. The prior replay receipt remains historical evidence for parent head `516f6b5f71e251b25985fb61715432f05249c4bd`. Fresh hosted checks and the fresh target-native replay passed at current head `aabd82168d2d7b2f1b9f685a5477dcdc491d3b02`; adaptation review and the release-target merge-readiness gate also passed. </details> Justification: Author-owned release aggregate merged under the published Agent 1.54 backport grant after exact-head hosted checks, target-native replay, adaptation review, target ancestry, and the target-aware merge guard passed; no independent approval was available. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: jaeone94 <89377375+jaeone94@users.noreply.github.com>
|
|
|
|
|
Release follow-up: the automated core/cloud 1.54 jobs conflicted because their agent browser fixtures were intentionally removed. I compared the release implementations directly: both 1.54 branches already call the live widget callback and |
…get writes (#18070) (#19171) Manual backport of #18070. Production conflicts were resolved to the source fix; test files whose supporting fixtures do not exist on this release line were omitted. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com>
…dget writes (#18070) (#19172) Manual backport of #18070. Production conflicts were resolved to the source fix; test files whose supporting fixtures do not exist on this release line were omitted. --------- Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com>
Requested by Christian Byrne · Slack thread
Summary
Fixes the false "invalid" red ring on combo widgets in agent workflow tabs by closing both mechanisms behind it.
Before: repro-only. Two
it.failspins:WidgetSelectDefaultmarking an agent-created node's placeholder widget (options: {}) invalid, andgraphMutations.setWidgetwriting the widget store without ever reaching the live widget'scallback.After:
WidgetSelectDefault.isInvalidno longer flags a value whileoptions.valuesis still undefined, so a placeholder widget's legitimate value renders clean until the node materializes.GraphMutationsDepsgains a required renderer-ownedwidgets: SemanticWidgetEffectPort; both follower write paths (namedset_widget, positional reconcile) go through oneapplyWidgetWritehelper; a batch records an effect only when the write applied and the store's post-write value differs from the previous one (Object.isfor primitives, structural equality for objects, so the clone every doc value takes cannot count as a change and a normalizing callback cannot loop through its mint echo); effects drain aftercommitin payload order, each call isolated behindreportError('error_applying_agent_widget_effects'). The newcreateLiveWidgetEffectPortresolves the live node the way the Vue render model does (resolveLiveWidget), requires the store to still own it (so an orphan left by an in-batch replace or delete never receives its successor's value), then assignswidget.value, runscallback(value, canvas, node)andnode.onWidgetChanged, and redraws. Wired inAgentPanelRoot.vue.Concrete beneficiaries beyond the ring: Custom Combo's
option*value setters (agent edits now rebuild its option list) andPrimitiveNode'scallback → applyToGraph(agent edits to a primitive now propagate to linked targets). An agent write also clearsrequired_input_missingfor that widget through the existingonWidgetChangedhook.Changes
docs/adr/CRDT-WIDGETS-0036-agent-widget-writes-run-live-widget-effects.md(+ README index row): the design, amended after adversarial review (structural change gate, ownership gating, placeholder semantics by live-node presence,onWidgetChangedcontract, reentrancy and drain order, subgraph note).src/workbench/extensions/agent/crdt/graphMutations.ts:SemanticWidgetEffectPort,applyWidgetWrite, post-commit drain.src/workbench/extensions/agent/crdt/liveWidgetEffects.ts(new):createLiveWidgetEffectPort({ getGraph, getCanvas }), with the guards in aresolveLiveWidgethelper.src/workbench/extensions/agent/crdt/__fixtures__/widgetEffectPorts.ts(new): inert and recording ports for the other construction sites.src/workbench/extensions/agent/AgentPanelRoot.vue: wiring.src/renderer/extensions/vueNodes/widgets/components/WidgetSelectDefault.vue: mechanism A.it(fixture adapted to a liveLGraph; assertion unchanged); port-contract table ingraphMutations.test.ts;liveWidgetEffects.test.ts(callback andonWidgetChangedarguments, no-ops for store-only nodes, missing widgets, a foreign root graph, the orphan after an in-batchreplaceNode, drain-time resolution,required_input_missingclearing); mint-echo test inagentCrdtProjection.integration.test.ts(a callback that rewrites its own object value mints one humanset_widget; the echo frame mints nothing).Red-Green Verification
test(agent): pin live widget effects for agent writesfix(agent): run the live widget's effects for agent widget writesScope notes
prepareNodereplacing live node fields wholesale) and are owned by fix(agent): preserve node color and autogrow input labels across CRDT tab-switch reconcile #18081.applyWidgetWritehelper introduced here and should reportapplied: false, which by construction records no effect. Expect a small merge on that helper and on theGraphMutationsDepstype (fix(agent): land agent-inserted template nodes near existing canvas content #18084 addsplacement).callbackand its node'sonWidgetChangednow also fire when the in-app agent changes the value, with(value, canvas, node)and no pointer arguments. Treat it as programmatic, like a remote option refresh.options.valuesadditionally depends on that mutation being reactive (Custom Combo'sshallowReactivesplice is; a rawwidget.options.values = …write is not). Documented in the ADR; a renderer concern outside this PR.aria-invalidabsence after an agent set plus tab switch next toagentTabSwitchCatchUp.spec.ts.Review Focus
graphMutations.tswriteWidget/applyWidgetWriteand the drain inbatch.liveWidgetEffects.tsownership check (useNodeDataStore().ownsNode) and root-graph guard.pnpm exec vitest run src/workbench/extensions/agent/ src/renderer/extensions/vueNodes/widgets/ src/stores/: all pass, 1 expected fail (pre-existing serialize pin).pnpm typecheck,pnpm lint,pnpm format:check,pnpm knip: clean.🤖 Generated with Claude Code
https://claude.ai/code/session_01Nxv4TewGb9qXkwjUMofZ8D
Generated by Claude Code