Repository navigation
fix(agent): deselect node when its composer reference chip is removed (PM-1227) - #18061
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository: Comfy-Org/ComfyUI_frontend/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🎭 Playwright: ✅ 2132 passed, 0 failed📊 Browser Reports
📦 Bundle: 10 MB gzip ⚪ 0 BDetailsSummary
Category Glance App Entry Points — 3.77 kB (baseline 3.77 kB) • ⚪ 0 BMain entry bundles and manifests Status: 1 unchanged Graph Workspace — 1.45 MB (baseline 1.45 MB) • ⚪ 0 BGraph editor runtime, canvas, workflow orchestration Status: 3 unchanged Views & Navigation — 134 kB (baseline 134 kB) • ⚪ 0 BTop-level views, pages, and routed surfaces Status: 18 unchanged Panels & Settings — 639 kB (baseline 639 kB) • ⚪ 0 BConfiguration panels, inspectors, and settings screens Status: 28 unchanged User & Accounts — 39.4 kB (baseline 39.4 kB) • ⚪ 0 BAuthentication, profile, and account management bundles Status: 11 unchanged Editors & Dialogs — 126 kB (baseline 126 kB) • ⚪ 0 BModals, dialogs, drawers, and in-app editors Status: 8 unchanged UI Components — 125 kB (baseline 125 kB) • ⚪ 0 BReusable component library chunks Status: 16 unchanged Data & Services — 3.98 MB (baseline 3.98 MB) • ⚪ 0 BStores, services, APIs, and repositories Status: 15 unchanged Utilities & Hooks — 576 kB (baseline 576 kB) • ⚪ 0 BHelpers, composables, and utility bundles Status: 36 unchanged Vendor & Third-Party — 17.4 MB (baseline 17.4 MB) • ⚪ 0 BExternal libraries and shared vendor chunks Status: 18 unchanged Other — 17.9 MB (baseline 17.9 MB) • ⚪ 0 BBundles that do not match a named category Status: 301 unchanged ⚡ Performance Report
Show regressions
All metrics
Historical variance (last 15 runs)
Trend (last 15 commits on main)
Raw data{
"timestamp": "2026-09-26T00:29:30.407Z",
"gitSha": "278a4515bd0198fe648ff38b170d7b4e3288ba2b",
"branch": "test/pm-1227-node-chip-removal-canvas-highlight",
"measurements": [
{
"name": "canvas-idle",
"durationMs": 2004.8830000000635,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.3389999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 461.8310000000001,
"heapDeltaBytes": 1473024,
"heapUsedBytes": 63875256,
"domNodes": -228,
"jsHeapTotalBytes": 4710400,
"scriptDurationMs": 9.376,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-idle",
"durationMs": 2022.0620000000054,
"styleRecalcs": 9,
"styleRecalcDurationMs": 3.7799999999999985,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 448.793,
"heapDeltaBytes": 3404648,
"heapUsedBytes": 65862980,
"domNodes": -228,
"jsHeapTotalBytes": 4448256,
"scriptDurationMs": 7.984999999999999,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1868.5100000000148,
"styleRecalcs": 70,
"styleRecalcDurationMs": 16.942,
"layouts": 12,
"layoutDurationMs": 4.3759999999999994,
"taskDurationMs": 855.2389999999999,
"heapDeltaBytes": 15550532,
"heapUsedBytes": 77773184,
"domNodes": -228,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 174.151,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "canvas-mouse-sweep",
"durationMs": 1807.3729999999841,
"styleRecalcs": 71,
"styleRecalcDurationMs": 17.211000000000002,
"layouts": 12,
"layoutDurationMs": 4.392,
"taskDurationMs": 825.8050000000002,
"heapDeltaBytes": 15522920,
"heapUsedBytes": 77801652,
"domNodes": -228,
"jsHeapTotalBytes": 5496832,
"scriptDurationMs": 168.934,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1723.6500000000206,
"styleRecalcs": 32,
"styleRecalcDurationMs": 10.578,
"layouts": 6,
"layoutDurationMs": 1.2699999999999998,
"taskDurationMs": 354.582,
"heapDeltaBytes": 2151588,
"heapUsedBytes": 64371488,
"domNodes": 53,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 13.514000000000001,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "canvas-zoom-sweep",
"durationMs": 1740.3229999999894,
"styleRecalcs": 32,
"styleRecalcDurationMs": 10.950000000000001,
"layouts": 6,
"layoutDurationMs": 1.528,
"taskDurationMs": 329.18499999999995,
"heapDeltaBytes": 2168780,
"heapUsedBytes": 64570340,
"domNodes": 53,
"jsHeapTotalBytes": 5242880,
"scriptDurationMs": 11.146999999999997,
"eventListeners": 15,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "dom-widget-clipping",
"durationMs": 697.2059999999374,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.672999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 458.011,
"heapDeltaBytes": 18511264,
"heapUsedBytes": 80791648,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 168.005,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-clipping",
"durationMs": 668.3959999999161,
"styleRecalcs": 11,
"styleRecalcDurationMs": 3.5370000000000004,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 447.257,
"heapDeltaBytes": 18447500,
"heapUsedBytes": 80935400,
"domNodes": 0,
"jsHeapTotalBytes": 4980736,
"scriptDurationMs": 170.115,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1258.0330000000117,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 951.5010000000002,
"heapDeltaBytes": -16814348,
"heapUsedBytes": 73628848,
"domNodes": -259,
"jsHeapTotalBytes": 19529728,
"scriptDurationMs": 77.372,
"eventListeners": -207,
"totalBlockingTimeMs": 599,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-dense-n200-w200-i120",
"durationMs": 1208.189999999945,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 928.5490000000001,
"heapDeltaBytes": -13928100,
"heapUsedBytes": 72245264,
"domNodes": -259,
"jsHeapTotalBytes": 19267584,
"scriptDurationMs": 68.60000000000001,
"eventListeners": -185,
"totalBlockingTimeMs": 558,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 845.3230000000076,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 473.87599999999975,
"heapDeltaBytes": 14862004,
"heapUsedBytes": 91690964,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 171.12700000000004,
"eventListeners": 0,
"totalBlockingTimeMs": 226,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "dom-widget-order-sparse-n1000-w20-i120",
"durationMs": 846.6290000000072,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 492.6360000000001,
"heapDeltaBytes": 14433112,
"heapUsedBytes": 91112560,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 171.647,
"eventListeners": 0,
"totalBlockingTimeMs": 234,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.80000000000109
},
{
"name": "extension-clean-combined-draw",
"durationMs": 11381.844999999998,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10427.983999999999,
"heapDeltaBytes": 12002396,
"heapUsedBytes": 94567864,
"domNodes": 0,
"jsHeapTotalBytes": 9175040,
"scriptDurationMs": 8743.435,
"eventListeners": 0,
"totalBlockingTimeMs": 1977,
"frameDurationMs": 18.890000000000025,
"p95FrameDurationMs": 49.89999999999782
},
{
"name": "extension-clean-combined-draw",
"durationMs": 10242.255000000001,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9418.215,
"heapDeltaBytes": -10016036,
"heapUsedBytes": 72312068,
"domNodes": 0,
"jsHeapTotalBytes": 4718592,
"scriptDurationMs": 7987.396,
"eventListeners": 0,
"totalBlockingTimeMs": 1369,
"frameDurationMs": 19.996666666666655,
"p95FrameDurationMs": 49.899999999999636
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 11397.822000000018,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 10411.227,
"heapDeltaBytes": 323504,
"heapUsedBytes": 83111848,
"domNodes": 0,
"jsHeapTotalBytes": 7340032,
"scriptDurationMs": 8663.679,
"eventListeners": 0,
"totalBlockingTimeMs": 1636,
"frameDurationMs": 18.886666666666617,
"p95FrameDurationMs": 49.900000000001455
},
{
"name": "extension-rgthree-prototype-draw",
"durationMs": 10272.370000000024,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 9518.311000000002,
"heapDeltaBytes": -8492220,
"heapUsedBytes": 68766412,
"domNodes": 0,
"jsHeapTotalBytes": 8388608,
"scriptDurationMs": 8143.084,
"eventListeners": 0,
"totalBlockingTimeMs": 1716,
"frameDurationMs": 19.996666666666716,
"p95FrameDurationMs": 50
},
{
"name": "large-graph-idle",
"durationMs": 2044.7719999999663,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.3399999999999994,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 608.752,
"heapDeltaBytes": 1602112,
"heapUsedBytes": 82856640,
"domNodes": -228,
"jsHeapTotalBytes": -1282048,
"scriptDurationMs": 37.00299999999999,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "large-graph-idle",
"durationMs": 2019.4450000000188,
"styleRecalcs": 9,
"styleRecalcDurationMs": 4.299999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 470.18499999999995,
"heapDeltaBytes": -13491696,
"heapUsedBytes": 73420236,
"domNodes": -228,
"jsHeapTotalBytes": 5271552,
"scriptDurationMs": 34.885,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2593.3690000000524,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.892999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1751.028,
"heapDeltaBytes": 2949960,
"heapUsedBytes": 85071804,
"domNodes": -228,
"jsHeapTotalBytes": 1302528,
"scriptDurationMs": 897.6149999999999,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-pan",
"durationMs": 2451.487000000043,
"styleRecalcs": 68,
"styleRecalcDurationMs": 9.384,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1632.416,
"heapDeltaBytes": 2393912,
"heapUsedBytes": 84519924,
"domNodes": -228,
"jsHeapTotalBytes": -270336,
"scriptDurationMs": 868.388,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "large-graph-zoom",
"durationMs": 3693.5210000000325,
"styleRecalcs": 63,
"styleRecalcDurationMs": 13.406999999999998,
"layouts": 60,
"layoutDurationMs": 13.565,
"taskDurationMs": 1722.996,
"heapDeltaBytes": 8457928,
"heapUsedBytes": 74477800,
"domNodes": 0,
"jsHeapTotalBytes": 0,
"scriptDurationMs": 804.255,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "large-graph-zoom",
"durationMs": 3667.777000000001,
"styleRecalcs": 64,
"styleRecalcDurationMs": 11.582000000000003,
"layouts": 60,
"layoutDurationMs": 13.524999999999999,
"taskDurationMs": 1721.772,
"heapDeltaBytes": -8713556,
"heapUsedBytes": 75113844,
"domNodes": -228,
"jsHeapTotalBytes": -1019904,
"scriptDurationMs": 804.5340000000001,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333338,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3146.6239999999743,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.908,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1946.928,
"heapDeltaBytes": 564340,
"heapUsedBytes": 67077340,
"domNodes": 0,
"jsHeapTotalBytes": 786432,
"scriptDurationMs": 1029.7029999999997,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "legacy-node-drag",
"durationMs": 3083.509999999933,
"styleRecalcs": 43,
"styleRecalcDurationMs": 5.806000000000002,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 1824.2720000000002,
"heapDeltaBytes": 23644832,
"heapUsedBytes": 89793608,
"domNodes": 0,
"jsHeapTotalBytes": 679936,
"scriptDurationMs": 1022.2150000000001,
"eventListeners": 180,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666696,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2045.788000000016,
"styleRecalcs": 8,
"styleRecalcDurationMs": 3.959999999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 639.144,
"heapDeltaBytes": -13161236,
"heapUsedBytes": 75211992,
"domNodes": -228,
"jsHeapTotalBytes": 4485120,
"scriptDurationMs": 36.96099999999999,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "minimap-idle",
"durationMs": 2037.2810000000072,
"styleRecalcs": 8,
"styleRecalcDurationMs": 2.6690000000000014,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 559.1139999999999,
"heapDeltaBytes": -4256236,
"heapUsedBytes": 83994224,
"domNodes": -228,
"jsHeapTotalBytes": -1544192,
"scriptDurationMs": 34.31099999999999,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.699999999999818
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 620.6730000000107,
"styleRecalcs": 46,
"styleRecalcDurationMs": 5.791999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 405.029,
"heapDeltaBytes": 13475140,
"heapUsedBytes": 77055060,
"domNodes": 0,
"jsHeapTotalBytes": 5505024,
"scriptDurationMs": 149.91899999999998,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-dom-widget-clipping",
"durationMs": 606.4969999999903,
"styleRecalcs": 47,
"styleRecalcDurationMs": 5.662000000000001,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 392.65399999999994,
"heapDeltaBytes": 13894816,
"heapUsedBytes": 83559816,
"domNodes": 0,
"jsHeapTotalBytes": 5767168,
"scriptDurationMs": 142.64100000000002,
"eventListeners": 6,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "subgraph-idle",
"durationMs": 2024.1000000000895,
"styleRecalcs": 10,
"styleRecalcDurationMs": 4.728,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 464.59599999999995,
"heapDeltaBytes": 7418568,
"heapUsedBytes": 71074476,
"domNodes": -244,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 8.434000000000001,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.670000000000012,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-idle",
"durationMs": 2021.6740000000755,
"styleRecalcs": 11,
"styleRecalcDurationMs": 7.243999999999999,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 457.2540000000001,
"heapDeltaBytes": 15791248,
"heapUsedBytes": 79078328,
"domNodes": -244,
"jsHeapTotalBytes": 4972544,
"scriptDurationMs": 7.838999999999999,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1727.1389999999656,
"styleRecalcs": 74,
"styleRecalcDurationMs": 19.563,
"layouts": 16,
"layoutDurationMs": 6.358,
"taskDurationMs": 828.87,
"heapDeltaBytes": 13443776,
"heapUsedBytes": 76945956,
"domNodes": -244,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 120.25099999999999,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333335,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-mouse-sweep",
"durationMs": 1716.4149999999836,
"styleRecalcs": 72,
"styleRecalcDurationMs": 18.378999999999998,
"layouts": 16,
"layoutDurationMs": 5.970000000000001,
"taskDurationMs": 792.199,
"heapDeltaBytes": 6402128,
"heapUsedBytes": 69750992,
"domNodes": -244,
"jsHeapTotalBytes": 5758976,
"scriptDurationMs": 117.74500000000002,
"eventListeners": -188,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "subgraph-transition-enter",
"durationMs": 1418.5019999999895,
"styleRecalcs": 16,
"styleRecalcDurationMs": 30.227000000000004,
"layouts": 5,
"layoutDurationMs": 13.738999999999997,
"taskDurationMs": 1009.368,
"heapDeltaBytes": -6207792,
"heapUsedBytes": 81888508,
"domNodes": 13667,
"jsHeapTotalBytes": 11272192,
"scriptDurationMs": 34.59400000000001,
"eventListeners": 2383,
"totalBlockingTimeMs": 151,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 8726.924000000054,
"styleRecalcs": 250,
"styleRecalcDurationMs": 32.966,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6001.125,
"heapDeltaBytes": 3692356,
"heapUsedBytes": 84949052,
"domNodes": -228,
"jsHeapTotalBytes": 1007616,
"scriptDurationMs": 2854.6,
"eventListeners": -142,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "viewport-pan-sweep",
"durationMs": 9697.300999999925,
"styleRecalcs": 250,
"styleRecalcDurationMs": 32.687999999999995,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 6294.881,
"heapDeltaBytes": 8261284,
"heapUsedBytes": 89989908,
"domNodes": -228,
"jsHeapTotalBytes": 4153344,
"scriptDurationMs": 3223.877,
"eventListeners": -164,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-idle",
"durationMs": 17095.0499999999,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16794.176,
"heapDeltaBytes": -33290708,
"heapUsedBytes": 184268696,
"domNodes": -8049,
"jsHeapTotalBytes": -14159872,
"scriptDurationMs": 270.17600000000004,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.780000000000047,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-large-graph-idle",
"durationMs": 16824.916999999914,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 16350.233,
"heapDeltaBytes": -42319868,
"heapUsedBytes": 182593392,
"domNodes": -8049,
"jsHeapTotalBytes": -16261120,
"scriptDurationMs": 265.472,
"eventListeners": -14923,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666763,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20807.374999999978,
"styleRecalcs": 154,
"styleRecalcDurationMs": 20.93499999999998,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20532.346999999998,
"heapDeltaBytes": -28840540,
"heapUsedBytes": 192302528,
"domNodes": -8049,
"jsHeapTotalBytes": -18518016,
"scriptDurationMs": 912.521,
"eventListeners": -14923,
"totalBlockingTimeMs": 91,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-large-graph-pan",
"durationMs": 20777.35800000005,
"styleRecalcs": 161,
"styleRecalcDurationMs": 17.861999999999963,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 20483.836999999996,
"heapDeltaBytes": -47148352,
"heapUsedBytes": 192087664,
"domNodes": -8049,
"jsHeapTotalBytes": -19709952,
"scriptDurationMs": 904.3270000000001,
"eventListeners": -14923,
"totalBlockingTimeMs": 36,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.700000000000728
},
{
"name": "vue-node-resize-workload",
"durationMs": 6315.5360000000655,
"styleRecalcs": 20,
"styleRecalcDurationMs": 79.13599999999998,
"layouts": 20,
"layoutDurationMs": 24.916999999999994,
"taskDurationMs": 6248.384,
"heapDeltaBytes": -66691892,
"heapUsedBytes": 172904676,
"domNodes": -8049,
"jsHeapTotalBytes": -1167360,
"scriptDurationMs": 109.64,
"eventListeners": -14923,
"totalBlockingTimeMs": 454,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-node-resize-workload",
"durationMs": 6241.40900000009,
"styleRecalcs": 20,
"styleRecalcDurationMs": 81.48200000000003,
"layouts": 20,
"layoutDurationMs": 24.41,
"taskDurationMs": 6139.095,
"heapDeltaBytes": -36188516,
"heapUsedBytes": 182357576,
"domNodes": -8049,
"jsHeapTotalBytes": 13361152,
"scriptDurationMs": 114.387,
"eventListeners": -14923,
"totalBlockingTimeMs": 414,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.799999999999272
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8579.384000000005,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8347.232999999998,
"heapDeltaBytes": -402768,
"heapUsedBytes": 195905888,
"domNodes": 0,
"jsHeapTotalBytes": -23330816,
"scriptDurationMs": 131.25700000000006,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "vue-zoom-out-idle",
"durationMs": 8506.974000000013,
"styleRecalcs": 0,
"styleRecalcDurationMs": 0,
"layouts": 0,
"layoutDurationMs": 0,
"taskDurationMs": 8346.219000000001,
"heapDeltaBytes": -16446632,
"heapUsedBytes": 164870044,
"domNodes": 0,
"jsHeapTotalBytes": -29622272,
"scriptDurationMs": 134.93399999999994,
"eventListeners": 0,
"totalBlockingTimeMs": 0,
"frameDurationMs": 17.776666666666642,
"p95FrameDurationMs": 16.80000000000291
},
{
"name": "workflow-execution",
"durationMs": 489.17999999991935,
"styleRecalcs": 21,
"styleRecalcDurationMs": 20.997999999999998,
"layouts": 4,
"layoutDurationMs": 2.105,
"taskDurationMs": 146.931,
"heapDeltaBytes": 5301748,
"heapUsedBytes": 67425188,
"domNodes": 131,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 19.786,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.666666666666668,
"p95FrameDurationMs": 16.800000000000182
},
{
"name": "workflow-execution",
"durationMs": 473.11600000000453,
"styleRecalcs": 19,
"styleRecalcDurationMs": 16.424999999999997,
"layouts": 3,
"layoutDurationMs": 1.624,
"taskDurationMs": 132.01800000000003,
"heapDeltaBytes": 5073368,
"heapUsedBytes": 67000136,
"domNodes": 126,
"jsHeapTotalBytes": 262144,
"scriptDurationMs": 15.280999999999999,
"eventListeners": 81,
"totalBlockingTimeMs": 0,
"frameDurationMs": 16.66333333333332,
"p95FrameDurationMs": 16.700000000000728
}
]
}🔬 E2E Coverage
Top 10 files by uncovered lines
🎨 Storybook: ✅ Built — View Storybook🧩 Custom Nodes Ecosystem Matrix: ✅ PassedExecutes the frontend JS of every registry pack that ships any, against this change, in both renderers. The eight
On a pin-bump PR, a red gate means the ecosystem moved — not that your diff broke something. That is what the bump PR is for. Outside a pin bump or a cold rebuild of the unpinned tail, a red means the diff. Note the corpus size and the executed count are different numbers, and the verdict is against the executed count: roughly 3,100 of ~5,100 packs ship no extension-shaped JS and are skipped. Reproduce locally# build one shard's fixture, then run it
python3 scripts/registry-census/build_matrix.py --shard 1/4
MATRIX_RENDERER=vue MATRIX_VUE=1 \
npx vitest run --config vitest.matrix.config.mts
Full docs: scripts/registry-census/README.md 🌾 Fallow: ✅ PassedFallow audits the diff for duplication, complexity and dead code. It gates on new findings only, so when the audit completes, a red is something this PR introduced or moved — never inherited backlog. A red can also mean the audit itself did not finish; the details below say which happened. No new findings in the changed files. Reproduce locally# the base the gate compared against
npx fallow audit --root . --quiet --format json \
--changed-since c5bd73bad8171a29d406dde7c44d82156e898851
Full docs: ADR-DEVEX-LINT-0015 |
278d111 to
775efa7
Compare
Playwright videos for new testsDownload the recorded videos and HTML report Recorded projects: cloud Recorded test titles:
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #18061 +/- ##
==========================================
+ Coverage 83.91% 84.89% +0.98%
==========================================
Files 3053 2307 -746
Lines 151099 132701 -18398
Branches 39117 35957 -3160
==========================================
- Hits 126788 112659 -14129
+ Misses 22899 19730 -3169
+ Partials 1412 312 -1100
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 807 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
CI status on the current head (
The actual fix ( Generated by Claude Code |
Removing a node's reference chip from the agent composer only filters useCanvasSelection's staged list; it never calls canvas.deselectAll()/ canvasStore.updateSelectedItems(), so the node stays highlighted on canvas after its chip disappears. Pinned with test.fail() until PM-1226 lands.
Removing a node reference from the composer now clears the matching canvas selection while preserving other selected nodes.
|
Taking this over from the paused Claude feedback sweep. Rebased onto current |
b1c01ab to
fab0b2c
Compare
|
Title and body corrected — no code change. Head is still This PR was opened as a So the title is now Still needs exactly one approval from |
christian-byrne
left a comment
There was a problem hiding this comment.
the exact-head diff routes chip removal through canvas.deselect(node) at the existing selection-tag boundary, and agentNodeSelectionChipRemoval.spec.ts verifies the user-visible chip and canvas-highlight state together. The shared settle helper strengthens the pre-existing screenshot case without coupling the test to selection internals. All 107 checks are terminal with no adverse result. Local replay was attempted but correctly refused because the already-running backend lacks the required ComfyUI_devtools endpoint; the exact-head cloud Playwright job is green.
… (PM-1227) (#18061) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789585023130639?thread_ts=1789585023.130639&cid=C0BGH348Z0C)_ ## Summary Removing a node's reference chip from the agent composer left the node highlighted on canvas. This fixes that, and adds the e2e regression test that covers it. **This PR carries the fix, not just a repro.** It started as a `test.fail()`-pinned repro; commits `3564898d6`, `fab0b2c13` and `d0af7f19f9` added the fix, removed the pin, and moved the spec to asserting the corrected behaviour. The title and this body have been corrected to match — earlier revisions described it as test-only. ## Changes - **What**: - `src/workbench/extensions/agent/AgentPanelRoot.vue` (+6) — `onRemoveSelectionTag` now resolves the node the chip refers to out of the current canvas selection and deselects it after removing the chip. - `browser_tests/tests/agent/agentNodeSelectionChipRemoval.spec.ts` (+65) — black-box regression spec. Enters agent node-selection mode, captures the unselected canvas, stages a node as a composer chip, removes the chip, and waits for the rendered canvas to return to its unselected pixels. - `browser_tests/fixtures/helpers/CanvasHelper.ts` (+25) — owns the shared canvas-view readiness check used by this spec and the composer placeholder regression spec. - **Breaking**: none - **Dependencies**: none ## Root cause `onRemoveSelectionTag` in `AgentPanelRoot.vue` called `removeSelectionTag(id)` and nothing else. That `remove()` (from `useCanvasSelection`) only filters the composer's local `staged` list; it has no canvas dependency, so the node's LiteGraph selection survived. The only other deselect on that surface is in `exitNodeSelectionMode()`, which runs when leaving node-selection mode entirely — never on a single chip removal. **Before**: selecting a node on canvas while in agent node-selection mode adds a reference chip and highlights the node. Removing that chip clears the chip but leaves the node highlighted. **After**: removing the chip also deselects the node, and the highlight clears. The fix is at the panel rather than inside `remove()` deliberately: `useCanvasSelection.ts` imports only `vue` and a type, and the composable is generic over staged selections. Pushing `canvas.deselect` into it would give it a canvas dependency it does not currently have. ## Review Focus - **The deselect goes through the canonical API**, not a direct store mutation: `canvas.deselect(node)` → `setCanvasItemSelected(..., false)` → the selection store that `canvasStore.selectedItems` is computed from. Commit `d0af7f19f9` is what moved it onto that API; an earlier revision used `canvas.deselectAll()` / `canvasStore.updateSelectedItems()` and those are gone. - **This is the only call site.** `removeSelectionTag` is referenced exactly three times in `src/`, all in `AgentPanelRoot.vue` — the destructure, this function, and the `@remove-tag` binding. There is no second path that can leave a node lit. - **Ordering** (`removeSelectionTag` before `deselect`) through `useCanvasSelection`'s `flush: 'sync'` watcher: single-chip — `remove()` empties `staged` and latches `dismissedSig`, then the deselect fires the watcher with an empty selection, clearing `dismissedSig` again. Multi-chip — the watcher re-stages the remaining nodes from the new selection. Consistent in both. - The spec reuses existing agent e2e infra (`agentTest`/`agentPanel` from `browser_tests/tests/agent/agentPanelMocks.ts`, plus `comfyPage.nodeOps`/`NodeReference`) and the shared `CanvasHelper` readiness check rather than adding spec-local fixtures or polling. **Verification note.** CI ran the original state-based spec green in `playwright-tests (cloud, frontend-dist-cloud)`; 91/91 checks were green at `d0af7f19f9`. The revised rendered-canvas assertion was verified red by temporarily removing `canvas.deselect(node)`, then green after restoring it. The focused cloud run and the neighboring composer placeholder spec both pass locally at `24025ec535`. ## Screenshots (if applicable) N/A (no visual change beyond the highlight clearing) 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_014TL6Z2fYevRQcChLMRy6Pk --- _Generated by [Claude Code](https://claude.ai/code/session_014TL6Z2fYevRQcChLMRy6Pk)_ --------- Co-authored-by: bymyself <cbyrne@comfy.org> (cherry picked from commit e968f00) (cherry picked from commit c32dd29)
## Summary Consolidates the verified fixes that landed on `cloud/1.54` but were absent from `cloud/1.55`: - #17486 keeps promoted dynamic-combo child links when loading workflows. - #18599 gives unified-remint retries a fresh timeout window. - #18093 allows nodes to shrink after content growth and tab switches. - #18155 resolves stale Agent bindings when workflows share a name. - #18693 keeps the Agent target aligned with the visible workflow until send or node reference. - #18619 waits for open dialogs before showing Agent consent. - #18061 deselects a node when its composer reference is removed. - #18392 marks video reply assets correctly. - #18664 records Agent panel visibility and page-hide teardown correctly. - #18911 restores Agent onboarding focus, navigation, and replay behavior. - #18911 remains deliberately excluded: its activation-telemetry substrate is cloud/1.54-only, and the original backport records that scope. This is the consolidated `cloud/1.55` carrier from the 1.54→1.55 release audit. The already-open saved-workflow backport remains in #19732 and is intentionally not duplicated here. ## Validation - Release-branch conflicts were resolved against the current cloud/1.55 Agent targeting, consent, and onboarding implementations. - CI is the authoritative full suite. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com> Co-authored-by: Maanil Verma <vermaMaanil97@gmail.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: dante01yoon <bunggl@naver.com> Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com> Co-authored-by: Hunter <huntcsg@users.noreply.github.com> Co-authored-by: uytieu <uytieu@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com>
… (PM-1227) (#18061) <!-- ccr-slack-attribution --> _Requested by **Christian Byrne** · [Slack thread](https://comfy-organization.slack.com/archives/C0BGH348Z0C/p1789585023130639?thread_ts=1789585023.130639&cid=C0BGH348Z0C)_ ## Summary Removing a node's reference chip from the agent composer left the node highlighted on canvas. This fixes that, and adds the e2e regression test that covers it. **This PR carries the fix, not just a repro.** It started as a `test.fail()`-pinned repro; commits `3564898d6`, `fab0b2c13` and `d0af7f19f9` added the fix, removed the pin, and moved the spec to asserting the corrected behaviour. The title and this body have been corrected to match — earlier revisions described it as test-only. ## Changes - **What**: - `src/workbench/extensions/agent/AgentPanelRoot.vue` (+6) — `onRemoveSelectionTag` now resolves the node the chip refers to out of the current canvas selection and deselects it after removing the chip. - `browser_tests/tests/agent/agentNodeSelectionChipRemoval.spec.ts` (+65) — black-box regression spec. Enters agent node-selection mode, captures the unselected canvas, stages a node as a composer chip, removes the chip, and waits for the rendered canvas to return to its unselected pixels. - `browser_tests/fixtures/helpers/CanvasHelper.ts` (+25) — owns the shared canvas-view readiness check used by this spec and the composer placeholder regression spec. - **Breaking**: none - **Dependencies**: none ## Root cause `onRemoveSelectionTag` in `AgentPanelRoot.vue` called `removeSelectionTag(id)` and nothing else. That `remove()` (from `useCanvasSelection`) only filters the composer's local `staged` list; it has no canvas dependency, so the node's LiteGraph selection survived. The only other deselect on that surface is in `exitNodeSelectionMode()`, which runs when leaving node-selection mode entirely — never on a single chip removal. **Before**: selecting a node on canvas while in agent node-selection mode adds a reference chip and highlights the node. Removing that chip clears the chip but leaves the node highlighted. **After**: removing the chip also deselects the node, and the highlight clears. The fix is at the panel rather than inside `remove()` deliberately: `useCanvasSelection.ts` imports only `vue` and a type, and the composable is generic over staged selections. Pushing `canvas.deselect` into it would give it a canvas dependency it does not currently have. ## Review Focus - **The deselect goes through the canonical API**, not a direct store mutation: `canvas.deselect(node)` → `setCanvasItemSelected(..., false)` → the selection store that `canvasStore.selectedItems` is computed from. Commit `d0af7f19f9` is what moved it onto that API; an earlier revision used `canvas.deselectAll()` / `canvasStore.updateSelectedItems()` and those are gone. - **This is the only call site.** `removeSelectionTag` is referenced exactly three times in `src/`, all in `AgentPanelRoot.vue` — the destructure, this function, and the `@remove-tag` binding. There is no second path that can leave a node lit. - **Ordering** (`removeSelectionTag` before `deselect`) through `useCanvasSelection`'s `flush: 'sync'` watcher: single-chip — `remove()` empties `staged` and latches `dismissedSig`, then the deselect fires the watcher with an empty selection, clearing `dismissedSig` again. Multi-chip — the watcher re-stages the remaining nodes from the new selection. Consistent in both. - The spec reuses existing agent e2e infra (`agentTest`/`agentPanel` from `browser_tests/tests/agent/agentPanelMocks.ts`, plus `comfyPage.nodeOps`/`NodeReference`) and the shared `CanvasHelper` readiness check rather than adding spec-local fixtures or polling. **Verification note.** CI ran the original state-based spec green in `playwright-tests (cloud, frontend-dist-cloud)`; 91/91 checks were green at `d0af7f19f9`. The revised rendered-canvas assertion was verified red by temporarily removing `canvas.deselect(node)`, then green after restoring it. The focused cloud run and the neighboring composer placeholder spec both pass locally at `24025ec535`. ## Screenshots (if applicable) N/A (no visual change beyond the highlight clearing) 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_014TL6Z2fYevRQcChLMRy6Pk --- _Generated by [Claude Code](https://claude.ai/code/session_014TL6Z2fYevRQcChLMRy6Pk)_ --------- Co-authored-by: bymyself <cbyrne@comfy.org> Co-authored-by: Amp <amp@ampcode.com> (cherry picked from commit e968f00)
## Summary Carries the fixes that landed on `core/1.54` but were absent from `core/1.55`: - #17486 keeps promoted dynamic-combo child links when loading workflows. - #18599 gives unified-remint retries a fresh timeout window. - #18093 allows nodes to shrink after content growth and tab switches. - #18155 resolves stale Agent bindings when workflows share a name. - #18693 keeps the Agent target aligned with the visible workflow until send or node reference. - #18619 waits for open dialogs before showing Agent consent. - #18061 deselects a node when its composer reference is removed. - #18392 marks video reply assets correctly. This is the consolidated `core/1.55` carrier from the 1.54→1.55 release audit. ## Validation - Cherry-picks applied cleanly except for release-branch adaptations in Agent consent and workflow targeting. - Local typecheck is running; CI is the authoritative full suite. --------- Co-authored-by: Alexander Brown <drjkl@comfy.org> Co-authored-by: Glary-Bot <glary-bot@users.noreply.github.com> Co-authored-by: Amp <amp@ampcode.com> Co-authored-by: Maanil Verma <vermaMaanil97@gmail.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: dante01yoon <bunggl@naver.com> Co-authored-by: Ryan Di <ryan.weihao.di@gmail.com> Co-authored-by: GitHub Action <action@github.com>
Requested by Christian Byrne · Slack thread
Summary
Removing a node's reference chip from the agent composer left the node highlighted on canvas. This fixes that, and adds the e2e regression test that covers it.
This PR carries the fix, not just a repro. It started as a
test.fail()-pinned repro; commits3564898d6,fab0b2c13andd0af7f19f9added the fix, removed the pin, and moved the spec to asserting the corrected behaviour. The title and this body have been corrected to match — earlier revisions described it as test-only.Changes
src/workbench/extensions/agent/AgentPanelRoot.vue(+6) —onRemoveSelectionTagnow resolves the node the chip refers to out of the current canvas selection and deselects it after removing the chip.browser_tests/tests/agent/agentNodeSelectionChipRemoval.spec.ts(+65) — black-box regression spec. Enters agent node-selection mode, captures the unselected canvas, stages a node as a composer chip, removes the chip, and waits for the rendered canvas to return to its unselected pixels.browser_tests/fixtures/helpers/CanvasHelper.ts(+25) — owns the shared canvas-view readiness check used by this spec and the composer placeholder regression spec.Root cause
onRemoveSelectionTaginAgentPanelRoot.vuecalledremoveSelectionTag(id)and nothing else. Thatremove()(fromuseCanvasSelection) only filters the composer's localstagedlist; it has no canvas dependency, so the node's LiteGraph selection survived. The only other deselect on that surface is inexitNodeSelectionMode(), which runs when leaving node-selection mode entirely — never on a single chip removal.Before: selecting a node on canvas while in agent node-selection mode adds a reference chip and highlights the node. Removing that chip clears the chip but leaves the node highlighted.
After: removing the chip also deselects the node, and the highlight clears.
The fix is at the panel rather than inside
remove()deliberately:useCanvasSelection.tsimports onlyvueand a type, and the composable is generic over staged selections. Pushingcanvas.deselectinto it would give it a canvas dependency it does not currently have.Review Focus
canvas.deselect(node)→setCanvasItemSelected(..., false)→ the selection store thatcanvasStore.selectedItemsis computed from. Commitd0af7f19f9is what moved it onto that API; an earlier revision usedcanvas.deselectAll()/canvasStore.updateSelectedItems()and those are gone.removeSelectionTagis referenced exactly three times insrc/, all inAgentPanelRoot.vue— the destructure, this function, and the@remove-tagbinding. There is no second path that can leave a node lit.removeSelectionTagbeforedeselect) throughuseCanvasSelection'sflush: 'sync'watcher: single-chip —remove()emptiesstagedand latchesdismissedSig, then the deselect fires the watcher with an empty selection, clearingdismissedSigagain. Multi-chip — the watcher re-stages the remaining nodes from the new selection. Consistent in both.agentTest/agentPanelfrombrowser_tests/tests/agent/agentPanelMocks.ts, pluscomfyPage.nodeOps/NodeReference) and the sharedCanvasHelperreadiness check rather than adding spec-local fixtures or polling.Verification note. CI ran the original state-based spec green in
playwright-tests (cloud, frontend-dist-cloud); 91/91 checks were green atd0af7f19f9. The revised rendered-canvas assertion was verified red by temporarily removingcanvas.deselect(node), then green after restoring it. The focused cloud run and the neighboring composer placeholder spec both pass locally at24025ec535.Screenshots (if applicable)
N/A (no visual change beyond the highlight clearing)
🤖 Generated with Claude Code
https://claude.ai/code/session_014TL6Z2fYevRQcChLMRy6Pk
Generated by Claude Code